Re: passing function pointers through platform devices?

2007-03-08 Thread Haavard Skinnemoen
On 3/7/07, NZG [EMAIL PROTECTED] wrote: Once the generic GPIO framework migrates upstream from -mm It already has: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=4c20386c8d0719b42503efe65abe47ad3fb3d711 I googled extensively and requested information on any

Re: [PATCH] Fix avr32 TIF atomicity in do_debug_priv

2007-03-08 Thread Haavard Skinnemoen
On Thu, 8 Mar 2007 22:21:37 -0500 Mathieu Desnoyers [EMAIL PROTECTED] wrote: Fix avr32 TIF atomicity in do_debug_priv avr32 updates the thread flags 1 - non atomically and 2 - with the wrong value (for TIF_SINGLE_STEP) in this function. It applies to 2.6.20. Thanks, but this has already

[PATCH] Bitbanging i2c bus driver using the GPIO API

2007-03-09 Thread Haavard Skinnemoen
= { .platform_data = i2c_gpio_data, }, }; Register this platform_device, set up the i2c pins as GPIO if required and you're ready to go. Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- I wrote this driver for testing purposes a couple of weeks ago. Figured I might

[PATCH v2] Bitbanging i2c bus driver using the GPIO API

2007-03-10 Thread Haavard Skinnemoen
= { .platform_data = i2c_gpio_data, }, }; Register this platform_device, set up the i2c pins as GPIO if required and you're ready to go. Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- This patch is different from the first patch in the following ways: * Handles pins

Re: [PATCH v2] Bitbanging i2c bus driver using the GPIO API

2007-03-12 Thread Haavard Skinnemoen
On Sat, 10 Mar 2007 21:15:50 +0100 Jean Delvare [EMAIL PROTECTED] wrote: I like the idea very much. Would this let us get rid of i2c-ixp2000? i2c-ixp4xx? scx200_i2c? Other drivers? Any platform that implements the generic gpio api should be able to use this driver. So yes, I hope we might be

Re: [PATCH v2] Bitbanging i2c bus driver using the GPIO API

2007-03-12 Thread Haavard Skinnemoen
On Mon, 12 Mar 2007 18:07:59 +0800 Wu, Bryan [EMAIL PROTECTED] wrote: static struct i2c_gpio_platform_data i2c_gpio_data = { .sda_pin= GPIO_PIN_FOO, .scl_pin= GPIO_PIN_BAR, }; Is this usage right, because 3 flags are added to this structure as below:

Re: [PATCH v2] Bitbanging i2c bus driver using the GPIO API

2007-03-12 Thread Haavard Skinnemoen
On Mon, 12 Mar 2007 15:34:57 +0100 Haavard Skinnemoen [EMAIL PROTECTED] wrote: + bit_data-udelay= 5,/* 100 kHz */ + bit_data-timeout = HZ / 10, /* 100 ms */ Can we add these udelay/timeout to struct i2c_gpio_platform_data? And let

Re: [PATCH v2] Bitbanging i2c bus driver using the GPIO API

2007-03-12 Thread Haavard Skinnemoen
On Mon, 12 Mar 2007 16:11:09 +0100 Jean Delvare [EMAIL PROTECTED] wrote: By the way, timeout seems to be hardcoded to 100 jiffies in the i2c-algo-bit driver, so there's probably not much point passing it from the board code when it's going to be overridden anyway. I'll add just a udelay

[PATCH -mm] AVR32: Implement utrace support

2007-03-12 Thread Haavard Skinnemoen
From: Haavard Skinnemoen [EMAIL PROTECTED] Rip out most of the ptrace code for AVR32 and replace it with the much nicer utrace stuff. It builds in all possible combinations of CONFIG_UTRACE and CONFIG_PTRACE, and it seems to work as far as I've tested it with strace and some simple debugging

Re: [BUG] PATA_PCMCIA does not work

2007-02-11 Thread Haavard Skinnemoen
On 2/11/07, Alan [EMAIL PROTECTED] wrote: [pata_pcmcia dmesg] ata1.00: CFA, max PIO0, 20480 sectors: LBA ata1.00: ata1: dev 0 multi count 0 ata1.01: CFA, max PIO0, 20480 sectors: LBA ata1.01: ata1: dev 1 multi count 0 Do you have two cards here ? I've seen this as well, on an ancient 4MB

[GIT PULL] AVR32 update

2007-02-16 Thread Haavard Skinnemoen
deletions(-) Haavard Skinnemoen (7): [AVR32] Fix prototypes for __raw_writesb and friends [AVR32] Define ioremap_nocache, ioport_map and ioport_unmap [AVR32] Wire up the SysV IPC calls properly [AVR32] Remove unnecessary sys_nfsservctl conditional [AVR32] Make sure

[PATCH] AVR32 utrace: Add missing includes

2007-04-14 Thread Haavard Skinnemoen
From: Haavard Skinnemoen [EMAIL PROTECTED] Include linux/tracehook.h and linux/utrace.h Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- Don't know why I missed these initially, but this should fix utrace on avr32. Andrew, I've rebased my avr32-arch branch so it should no longer conflict

[PATCH v3] Bitbanging i2c bus driver using the GPIO API

2007-04-14 Thread Haavard Skinnemoen
changing the direction of the SDA and SCL lines on the fly. Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- Sorry for the long delay. I didn't want to send out a patch just before taking off for two weeks. This patch contains the following changes compared to v2: o Make udelay and timeout

Re: [PATCH v3] Bitbanging i2c bus driver using the GPIO API

2007-04-14 Thread Haavard Skinnemoen
On Sat, 14 Apr 2007 14:56:47 +0200 Haavard Skinnemoen [EMAIL PROTECTED] wrote: o Default to a very low SCL frequency (6.6 kHz) if clock stretching isn't supported This would have been true if I had remembered to save before generating the patch... Updated patch below. Sorry about

Re: ioread32 endianess.

2007-02-27 Thread Haavard Skinnemoen
On 2/27/07, Kyle McMartin [EMAIL PROTECTED] wrote: __raw_(read|write){b,w,l} are also old style accessors. They always operate in host endianness. Are there any new style accessors operating in host endianness? Haavard - To unsubscribe from this list: send the line unsubscribe linux-kernel in

Re: Thread flags modified without set_thread_flag() (non atomically)

2007-03-01 Thread Haavard Skinnemoen
[trimming cc list since I'm only replying to the avr32 part] On Wed, 28 Feb 2007 22:03:49 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Mon, 26 Feb 2007 12:10:37 -0800 Mathieu Desnoyers [EMAIL PROTECTED] wrote: avr32/kernel/ptrace.c: ti-flags |= _TIF_BREAKPOINT; No, I don't

Re: Thread flags modified without set_thread_flag() (non atomically)

2007-03-01 Thread Haavard Skinnemoen
On Thu, 1 Mar 2007 01:45:23 -0800 Andrew Morton [EMAIL PROTECTED] wrote: If there's a lesson here, it is don't provide #defines in the header for both versions. Yes, that's true. It looks like all the other arches do the same thing with the _TIF flags, however, so just ripping it out probably

Re: Thread flags modified without set_thread_flag() (non atomically)

2007-03-01 Thread Haavard Skinnemoen
On Thu, 1 Mar 2007 11:14:47 +0100 Haavard Skinnemoen [EMAIL PROTECTED] wrote: On Thu, 1 Mar 2007 01:45:23 -0800 Andrew Morton [EMAIL PROTECTED] wrote: If there's a lesson here, it is don't provide #defines in the header for both versions. Yes, that's true. It looks like all the other

Re: [patch 2.6.20-rc2] gpio_direction_output() needs an initial value

2007-03-02 Thread Haavard Skinnemoen
those chips might not avoid the glitches. Signed-off-by: David Brownell [EMAIL PROTECTED] Acked-by: Haavard Skinnemoen [EMAIL PROTECTED] Thanks, Dave. Haavard - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

[GIT PULL] AVR32 fixes

2007-03-07 Thread Haavard Skinnemoen
Hi Linus, Please pull the 'for-linus' branch of git://www.atmel.no/~hskinnemoen/linux/kernel/avr32.git for-linus to receive the following updates. Gary Zambrano (1): avr32: dma-mapping.h Haavard Skinnemoen (5): [AVR32] at32_spi_setup_slaves should be __init [AVR32

Re: [RFC, PATCH] watchdog on gpio

2008-01-14 Thread Haavard Skinnemoen
On Mon, 14 Jan 2008 04:45:25 -0500 Mike Frysinger [EMAIL PROTECTED] wrote: there is no hard requirement anywhere that says platform resources must be in the board resources file. marking the functions as __init instead of __devinit will basically cause a kernel crash if someone tries to use

Re: [RFC, PATCH] watchdog on gpio

2008-01-14 Thread Haavard Skinnemoen
On Mon, 14 Jan 2008 07:22:39 -0500 Mike Frysinger [EMAIL PROTECTED] wrote: There is: platform_driver_probe(). It takes the probe function as a parameter so that it can be left out of the platform_driver struct. After it returns, there are no references to the probe function left around,

Re: [RFC, PATCH, take 2] watchdog on generic gpio

2008-01-14 Thread Haavard Skinnemoen
On Mon, 14 Jan 2008 15:03:14 +0100 Florian Fainelli [EMAIL PROTECTED] wrote: Le lundi 14 janvier 2008, Marc Pignat a écrit : Hi Florian! I understand your wish, but... You told me that your plaform doesn't implement the generic gpio interface (yet?), so this driver can't work for you.

Re: [PATCH] AVR32: Drop support for redundant keepinitrd boot-time parm.

2007-09-20 Thread Haavard Skinnemoen
On Wed, 19 Sep 2007 08:43:42 -0400 (EDT) Robert P. J. Day [EMAIL PROTECTED] wrote: Given the existing retain_initrd boot-time parameter defined in init/initramfs.c, there appears to be no need for the equivalent keepinitrd parameter. Signed-off-by: Robert P. J. Day [EMAIL PROTECTED]

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-14 Thread Haavard Skinnemoen
On Wed, 14 Nov 2007 00:37:57 -0800 David Brownell [EMAIL PROTECTED] wrote: Although another point is related to trivial: the data is being protected through an operation too trivial to be worth paying for any of that priority logic. But isn't there any way we can remove the lock from the

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-15 Thread Haavard Skinnemoen
On Wed, 14 Nov 2007 22:50:17 -0800 David Brownell [EMAIL PROTECTED] wrote: Since this is the code that runs under the lock No, there's more than that. This is what runs under it in the hot paths, yes, but the gpio request/free paths do more work than this. (That includes direction

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-15 Thread Haavard Skinnemoen
On Thu, 15 Nov 2007 00:20:33 -0800 David Brownell [EMAIL PROTECTED] wrote: - gpio_direction_input()/gpio_direction_output() implicitly request the pins, if they weren't already requested. Eek, that's completely wrong. Allowing to access a resource _before_ it is assigned and

Re: [PATCH] More CFI fixups for Atmel chips

2007-11-15 Thread Haavard Skinnemoen
On Tue, 30 Oct 2007 16:33:07 +0100 Haavard Skinnemoen [EMAIL PROTECTED] wrote: This patch (or some variation of it) has been posted a couple of times before to the MTD list, and I find myself applying it over and over again when testing stuff against the latest mainline tree. I'd appreciate

[GIT PULL] avr32 fixes for 2.6.24-rc3

2007-11-15 Thread Haavard Skinnemoen
Linus, Please pull from ssh://master.kernel.org/pub/scm/linux/kernel/git/hskinnemoen/avr32-2.6.git for-linus to receive the following updates. Adrian Bunk (1): [AVR32] remove UID16 option Haavard Skinnemoen (4): [AVR32] pcmcia ioaddr_t should be 32 bits on AVR32 [AVR32

Re: [PATCH]: Atmel Serial Console interrupt handler splitup

2007-12-17 Thread Haavard Skinnemoen
On Fri, 14 Dec 2007 12:46:09 +0100 Remy Bohmer [EMAIL PROTECTED] wrote: Hello Andrew, So, to come to a conclusion about this complex patch series, I attached all the latest versions to this mail. The latest patches from yesterday including inline are also included to make the set complete.

Re: [PATCH]: Atmel Serial Console interrupt handler splitup

2007-12-17 Thread Haavard Skinnemoen
On Mon, 17 Dec 2007 13:17:01 +0100 Haavard Skinnemoen [EMAIL PROTECTED] wrote: 3) NEW: optional: add-atmel-serial-dma.patch, this merged the DMA code (from Chip Coldwell) in your 2.6.23 patch back on top of this series. Because the AT32 bug is not been fixed for a very long time, I do

Re: [PATCH]: Atmel Serial Console interrupt handler splitup

2007-12-17 Thread Haavard Skinnemoen
On Mon, 17 Dec 2007 21:56:30 +0100 Remy Bohmer [EMAIL PROTECTED] wrote: Btw, it would be nice if patches that affect more or less architecture-independent drivers were posted to linux-kernel (added to Cc.) Not really architecture independant, I believe, because thos are drivers for

Re: [PATCH]: Atmel Serial Console interrupt handler splitup

2007-12-18 Thread Haavard Skinnemoen
On Mon, 17 Dec 2007 23:49:32 + Russell King - ARM Linux [EMAIL PROTECTED] wrote: On Mon, Dec 17, 2007 at 09:56:30PM +0100, Remy Bohmer wrote: +#define lread(port) __raw_readl(port) +#define lwrite(v, port) __raw_writel(v, port) Why is this necessary, and

[PATCH v2] atmel_serial: Clean up the code

2007-12-18 Thread Haavard Skinnemoen
From: Remy Bohmer [EMAIL PROTECTED] This patch cleans up the atmel_serial driver to conform the coding rules. It contains no functional change. [EMAIL PROTECTED]: additional cleanups] Signed-off-by: Remy Bohmer [EMAIL PROTECTED] Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- Changes

Re: [PATCH]: Atmel Serial Console interrupt handler splitup

2007-12-18 Thread Haavard Skinnemoen
On Tue, 18 Dec 2007 12:08:05 +0200 Andrew Victor [EMAIL PROTECTED] wrote: #define at_readl(port, off) __raw_readl((port)-membase + (off)) #define at_writel(v, port, off) __raw_writel(v, (port)-membase + (off)) #define UART_PUT_CR(port, v)at_writel(v, port, ATMEL_US_CR) #define

Re: [PATCH v2] atmel_serial: Clean up the code

2007-12-18 Thread Haavard Skinnemoen
On Tue, 18 Dec 2007 11:14:42 +0100 Remy Bohmer [EMAIL PROTECTED] wrote: Hello Haavard, Please note that I'm not trying to steal the show here -- I just want That did not even come to my mind at all... I am happy with everything that helps making this driver better. Good :) What shall

Re: [PATCH v2] atmel_serial: Clean up the code

2007-12-18 Thread Haavard Skinnemoen
On Tue, 18 Dec 2007 21:22:01 +0800 steve birtles [EMAIL PROTECTED] wrote: Is there any change can we clean this up? /* * We wrap our port structure around the generic uart_port. @@ -142,8 +146,8 @@ static void atmel_set_mctrl(struct uart_port *port, u_int mctrl) #ifdef

[PATCH] atmel_serial: Split the interrupt handler

2007-12-18 Thread Haavard Skinnemoen
]: misc cleanups and simplifications] Signed-off-by: Remy Bohmer [EMAIL PROTECTED] Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- Changes since v1: Whitespace cleanups Allocate rx ring data separately Move more of the rx processing into tasklet Consolidate rx

[PATCH 4/5] atmel_serial: Split the interrupt handler

2007-12-18 Thread Haavard Skinnemoen
-by: Haavard Skinnemoen [EMAIL PROTECTED] --- drivers/serial/atmel_serial.c | 215 - 1 files changed, 169 insertions(+), 46 deletions(-) diff --git a/drivers/serial/atmel_serial.c b/drivers/serial/atmel_serial.c index a6b3828..990d3ab 100644 --- a/drivers/serial

[PATCH 3/5] atmel_serial: Use existing console options only if BRG is running

2007-12-18 Thread Haavard Skinnemoen
If BRGR is zero, the baud rate generator isn't running, so the boot loader can't have initialized the port. Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- drivers/serial/atmel_serial.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/serial

[PATCH 1/5] atmel_serial: Clean up the code

2007-12-18 Thread Haavard Skinnemoen
From: Remy Bohmer [EMAIL PROTECTED] This patch cleans up the atmel_serial driver to conform the coding rules. It contains no functional change. [EMAIL PROTECTED]: additional cleanups] Signed-off-by: Remy Bohmer [EMAIL PROTECTED] Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- drivers

[PATCH 0/5] atmel_serial: Cleanups, irq handler splitup DMA

2007-12-18 Thread Haavard Skinnemoen
if this isn't how you want it. Chip Coldwell (1): atmel_serial: Add DMA support Haavard Skinnemoen (2): atmel_serial: Use cpu_relax() when busy-waiting atmel_serial: Use existing console options only if BRG is running Remy Bohmer (2): atmel_serial: Clean up the code

[PATCH 2/5] atmel_serial: Use cpu_relax() when busy-waiting

2007-12-18 Thread Haavard Skinnemoen
Replace two instances of barrier() with cpu_relax() since that's the right thing to do when busy-waiting. This does not actually change anything since cpu_relax() is defined as barrier() on both ARM and AVR32. Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- drivers/serial/atmel_serial.c

[PATCH 5/5] atmel_serial: Add DMA support

2007-12-18 Thread Haavard Skinnemoen
]: rebased onto irq-splitup patch] [EMAIL PROTECTED]: moved to tasklet, fixed dma bug, misc cleanups] Signed-off-by: Remy Bohmer [EMAIL PROTECTED] Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- drivers/serial/atmel_serial.c | 386 ++-- 1 files changed, 366

Re: [PATCH 4/5] atmel_serial: Split the interrupt handler

2007-12-18 Thread Haavard Skinnemoen
On Tue, 18 Dec 2007 18:06:14 +0100 Haavard Skinnemoen [EMAIL PROTECTED] wrote: From: Remy Bohmer [EMAIL PROTECTED] Heh. That's obviously wrong. Wonder what happened there? Looks like Chip's address got mangled too. Haavard -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH] atmel_serial: Split the interrupt handler

2007-12-18 Thread Haavard Skinnemoen
Crud...my mailer helpfully filtered this into the huge linux-kernel bin instead of leaving it in my inbox... On Tue, 18 Dec 2007 16:23:11 +0100 Remy Bohmer [EMAIL PROTECTED] wrote: Hello Haavard, A few remarks: From: Remy Bohmer [EMAIL PROTECTED] My name, at your address ;-))) Right.

Re: [PATCH 4/5] atmel_serial: Split the interrupt handler

2007-12-19 Thread Haavard Skinnemoen
On Wed, 19 Dec 2007 00:15:24 +0100 Jiri Slaby [EMAIL PROTECTED] wrote: On 12/18/2007 06:06 PM, Haavard Skinnemoen wrote: port = atmel_ports[pdev-id]; atmel_init_port(port, pdev); + data = kmalloc(ATMEL_SERIAL_RINGSIZE, GFP_KERNEL); + if (!data) { clk_disable

Re: [PATCH 0/5] atmel_serial: Cleanups, irq handler splitup DMA

2007-12-19 Thread Haavard Skinnemoen
On Wed, 19 Dec 2007 09:29:52 +0200 Vadim Yatsenko [EMAIL PROTECTED] wrote: What prepatches one need to aply to what kernel version (vanila, git, ...) before these? They should apply to a fresh checkout of Linus' git tree. If you want to use 2.6.23, you need to apply this patch first:

Re: [PATCH 4/5] atmel_serial: Split the interrupt handler

2007-12-19 Thread Haavard Skinnemoen
On Tue, 18 Dec 2007 13:19:39 -0500 (EST) Chip Coldwell [EMAIL PROTECTED] wrote: On Tue, 18 Dec 2007 18:06:14 +0100 Haavard Skinnemoen [EMAIL PROTECTED] wrote: From: Remy Bohmer [EMAIL PROTECTED] Heh. That's obviously wrong. Wonder what happened there? Looks like Chip's

Re: [PATCH] atmel_serial: Split the interrupt handler

2007-12-19 Thread Haavard Skinnemoen
On Tue, 18 Dec 2007 16:23:11 +0100 Remy Bohmer [EMAIL PROTECTED] wrote: Preempt-RT now absolutely requires my (4th) IRQ_NODELAY patch, because the spinlock now is always inside the code, and not only in theexception path, and thus without my NO_DELAY patch we have a panic during boot.

Re: [PATCH] atmel_serial: Split the interrupt handler

2007-12-19 Thread Haavard Skinnemoen
On Wed, 19 Dec 2007 13:50:16 +0100 Remy Bohmer [EMAIL PROTECTED] wrote: Hello Haavard, Hmm...perhaps we can eliminate the locking in the status handler too...? Does anyone see a problem with this patch? I have not seen any problem so far, besides, I am very happy with a lockless

Re: [PATCH] atmel_serial: Split the interrupt handler

2007-12-19 Thread Haavard Skinnemoen
On Wed, 19 Dec 2007 14:18:18 +0100 Remy Bohmer [EMAIL PROTECTED] wrote: Hello Haavard, Hrm. We probably need to lock while updating icount. That's a problem since we do that from the tx interrupt handler...and I don't suppose we want to move most of the atmel_tx_chars() code into the

Re: [PATCH 4/5] atmel_serial: Split the interrupt handler

2007-12-19 Thread Haavard Skinnemoen
On Wed, 19 Dec 2007 12:40:08 +0100 Haavard Skinnemoen [EMAIL PROTECTED] wrote: Btw, the funny thing is that, looking at my shell history, I think I actually did the right thing when committing your patches: git commit -s --author 'Remy Bohmer [EMAIL PROTECTED]' git commit -s --author 'Chip

[PATCH v2 4/6] atmel_serial: Fix bugs in probe() error path and remove()

2007-12-19 Thread Haavard Skinnemoen
When an error happens in probe(), the clocks should be disabled, but only if the port isn't already used as a console. In remove(), the port struct shouldn't be freed because it's defined statically. Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- drivers/serial/atmel_serial.c | 39

[PATCH v2 2/6] atmel_serial: Use cpu_relax() when busy-waiting

2007-12-19 Thread Haavard Skinnemoen
Replace two instances of barrier() with cpu_relax() since that's the right thing to do when busy-waiting. This does not actually change anything since cpu_relax() is defined as barrier() on both ARM and AVR32. Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- drivers/serial/atmel_serial.c

[PATCH v2 3/6] atmel_serial: Use existing console options only if BRG is running

2007-12-19 Thread Haavard Skinnemoen
If BRGR is zero, the baud rate generator isn't running, so the boot loader can't have initialized the port. Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- drivers/serial/atmel_serial.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/serial

[PATCH v2 6/6] atmel_serial: Add DMA support

2007-12-19 Thread Haavard Skinnemoen
] Signed-off-by: Remy Bohmer [EMAIL PROTECTED] Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- drivers/serial/atmel_serial.c | 390 ++--- 1 files changed, 365 insertions(+), 25 deletions(-) diff --git a/drivers/serial/atmel_serial.c b/drivers/serial

[PATCH v2 0/6] atmel_serial: Cleanups, irq handler splitup DMA

2007-12-19 Thread Haavard Skinnemoen
(including my own). The PDC error handling also accesses icount without locking. I'm tempted to just ignore the problem for now and hopefully come up with a solution later. Everyone, please give it a try and/or review the code. Chip Coldwell (1): atmel_serial: Add DMA support Haavard Skinnemoen (3

[PATCH v2 1/6] atmel_serial: Clean up the code

2007-12-19 Thread Haavard Skinnemoen
From: Remy Bohmer [EMAIL PROTECTED] This patch cleans up the atmel_serial driver to conform the coding rules. It contains no functional change. Signed-off-by: Remy Bohmer [EMAIL PROTECTED] Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- drivers/serial/atmel_serial.c | 327

[PATCH v2 5/6] atmel_serial: Split the interrupt handler

2007-12-19 Thread Haavard Skinnemoen
] Signed-off-by: Remy Bohmer [EMAIL PROTECTED] Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- drivers/serial/atmel_serial.c | 239 +++-- 1 files changed, 184 insertions(+), 55 deletions(-) diff --git a/drivers/serial/atmel_serial.c b/drivers/serial

Re: [PATCH v2 0/6] atmel_serial: Cleanups, irq handler splitup DMA

2007-12-19 Thread Haavard Skinnemoen
On Wed, 19 Dec 2007 16:57:04 +0100 Remy Bohmer [EMAIL PROTECTED] wrote: Hello Haavard, Sorry.. But I get an Oops on Preempt-RT with the latest set of patches. I did not see it earlier today with the other set of patches. Hmm...from the backtrace, it looks like lock recursion -- port-lock is

Re: [PATCH v2 0/6] atmel_serial: Cleanups, irq handler splitup DMA

2007-12-19 Thread Haavard Skinnemoen
On Wed, 19 Dec 2007 17:40:44 +0100 Remy Bohmer [EMAIL PROTECTED] wrote: But... I tried that patch, and it works a lot better, no oopses anymore, Good :) but I noticed that I sometimes get an input overrun (ttyS0: 1 input overrun(s) ) during stress conditions. This is something I did not

Re: [PATCH v2 0/6] atmel_serial: Cleanups, irq handler splitup DMA

2007-12-19 Thread Haavard Skinnemoen
On Wed, 19 Dec 2007 17:59:09 +0100 Remy Bohmer [EMAIL PROTECTED] wrote: but I noticed that I sometimes get an input overrun (ttyS0: 1 input overrun(s) ) during stress conditions. This is something I did not notice before, maybe it was already there, or has something changed in this

Re: [PATCH v2 0/6] atmel_serial: Cleanups, irq handler splitup DMA

2007-12-22 Thread Haavard Skinnemoen
On Wed, 19 Dec 2007 21:32:44 +0100 Remy Bohmer [EMAIL PROTECTED] wrote: We need to fix the break- and error handling though. But my vacation starts tomorrow, so I probably won't be able to fix it until next year. In that case, I wish you very good holiday, and a happy new-year. It was

Re: git guidance

2007-11-29 Thread Haavard Skinnemoen
On Thu, 29 Nov 2007 13:45:44 +0100 Tilman Schmidt [EMAIL PROTECTED] wrote: Haavard Skinnemoen schrieb: No, use git rebase --interactive ;-) What's that? I can't find it in man git-rebase. I think it was added very recently; most distributions probably don't have a recent enough

[PATCH] atmel_lcdfb: Validate display timings

2007-11-29 Thread Haavard Skinnemoen
Setting a display timing parameter too high or too low may cause it to wrap around and thus become completely wrong. Validate the timings in atmel_lcdfb_check_var() and saturate to the highest or lowest possible value if necessary. Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- drivers

[PATCH 1/2] [AVR32] Include instrumentation menu

2007-12-03 Thread Haavard Skinnemoen
Remove KPROBES option from Kconfig.debug and include kernel/Kconfig.instrumentation. Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- arch/avr32/Kconfig |2 ++ arch/avr32/Kconfig.debug | 10 -- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/arch/avr32

[PATCH 2/2] [AVR32] Oprofile support

2007-12-03 Thread Haavard Skinnemoen
This adds the necessary architecture code to run oprofile on AVR32 using the performance counters documented by the AVR32 Architecture Manual. Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] Acked-by: Philippe Elie [EMAIL PROTECTED] --- Mathieu, I want to get oprofile support queued up

Re: [patch 0/4] Instrumentation menu removal

2007-12-04 Thread Haavard Skinnemoen
On Tue, 04 Dec 2007 12:43:58 -0500 Mathieu Desnoyers [EMAIL PROTECTED] wrote: [PATCH 1/2] [AVR32] Include instrumentation menu [PATCH 2/2] [AVR32] Oprofile support (which have been merged in the avr32 tree by Haavard) I forgot to actually apply the patches though. I've pushed them out now.

Re: [RFC 1/4] dmaengine: Add slave DMA interface

2007-12-05 Thread Haavard Skinnemoen
On Mon, 3 Dec 2007 12:20:15 -0700 Dan Williams [EMAIL PROTECTED] wrote: Hi Haavard, Some (delayed) comments. Thanks for the feedback. A few questions: The one change that seems to be missing, at least in my mind, is extending struct dma_client to include details about the slave device.

[GIT PULL] avr32 fixes for 2.6.24

2007-12-07 Thread Haavard Skinnemoen
. I wouldn't have pushed it if I didn't think the bug it fixes is very serious, and I've spent quite a few days testing that nothing broke. A customer has verified the fix too, and the LTP test cases that fail after this patch, failed before too. Haavard Skinnemoen (9): [AVR32] Add

[PATCH] dmaengine: Simple DMA memcpy test client

2007-11-20 Thread Haavard Skinnemoen
This client tests DMA memcpy using various lengths and various offsets into the source and destination buffers. It will initialize both buffers with a know pattern and verify that the DMA engine copies the requested region and nothing more. Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED

[PATCH] dmaengine: Driver for the AVR32 DMACA controller

2007-11-20 Thread Haavard Skinnemoen
This patch makes the DMA Engine menu visible on AVR32 and adds a driver for the DMACA (aka DW DMAC) controller. This DMA controller can be found on the AT32AP7000 chip and it primarily meant for peripheral DMA transfer, but can also be used for memory-to-memory transfers. The dmatest client shows

Re: [PATCH] dmaengine: Simple DMA memcpy test client

2007-11-21 Thread Haavard Skinnemoen
On Tue, 20 Nov 2007 09:34:38 -0800 Nelson, Shannon [EMAIL PROTECTED] wrote: -Original Message- From: Haavard Skinnemoen [mailto:[EMAIL PROTECTED] +#define TEST_BUF_SIZE (16384) You might make this a module parameter so we can test with various sizes. Good idea

[PATCH] mmc: Add missing sg_init_table() call

2007-11-22 Thread Haavard Skinnemoen
mmc_init_queue only initializes the scatterlists with sg_init_table() when using a bounce buffer. This leads to a BUG() when CONFIG_DEBUG_SG is set. Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- drivers/mmc/card/queue.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff

[RFC 2/4] dmaengine: Make DMA Engine menu visible for AVR32 users

2007-11-23 Thread Haavard Skinnemoen
Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- drivers/dma/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index 1db5499..9bcc392 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig @@ -4,7 +4,7

[RFC 3/4] dmaengine: Driver for the Synopsys DesignWare DMA controller

2007-11-23 Thread Haavard Skinnemoen
-by: Haavard Skinnemoen [EMAIL PROTECTED] Changes since v1: * Implement DMA slave operations * Set DWC_MAX_LEN to a more sane number * Get rid of the dummy descriptors * Fix DWC_CTLL_SRC_WIDTH() definition (wrong start bit) --- arch/avr32/mach-at32ap/at32ap7000.c| 29 +- drivers/dma

[PATCH v2] dmaengine: Simple DMA memcpy test client

2007-11-23 Thread Haavard Skinnemoen
This client tests DMA memcpy using various lengths and various offsets into the source and destination buffers. It will initialize both buffers with a know pattern and verify that the DMA engine copies the requested region and nothing more. Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED

[RFC 0/4] dmaengine: Slave DMA interface and example users

2007-11-23 Thread Haavard Skinnemoen
time to time, so there are still some issues to be worked out. Haavard Haavard Skinnemoen (4): dmaengine: Add slave DMA interface dmaengine: Make DMA Engine menu visible for AVR32 users dmaengine: Driver for the Synopsys DesignWare DMA controller Atmel MCI: Driver for Atmel

[RFC 4/4] Atmel MCI: Driver for Atmel on-chip MMC controllers

2007-11-23 Thread Haavard Skinnemoen
provided by Atmel, but this particular version uses the generic DMA Engine framework (with the slave extensions) instead of an avr32-only DMA controller framework. Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- arch/avr32/boards/atngw100/setup.c |6 + arch/avr32/boards/atstk1000

[RFC 1/4] dmaengine: Add slave DMA interface

2007-11-23 Thread Haavard Skinnemoen
the controller to do slave DMA for a given device, and for terminating all pending transfers. The latter is needed because there may be errors outside the scope of the DMA Engine framework that requires DMA operations to be terminated prematurely. Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED

Re: [RFC] Documentation about unaligned memory access

2007-11-24 Thread Haavard Skinnemoen
On Sat, 24 Nov 2007 17:22:36 + Luciano Rocha [EMAIL PROTECTED] wrote: Nothing does, even memcpy doesn't check alignment of the source, or alignment at all in some assembly implementations (only word-copy, without checking if at word-boundary). An out-of-line implementation can only do

Re: [RFC 4/4] Atmel MCI: Driver for Atmel on-chip MMC controllers

2007-11-24 Thread Haavard Skinnemoen
On Sat, 24 Nov 2007 18:00:23 +0100 Pierre Ossman [EMAIL PROTECTED] wrote: On Fri, 23 Nov 2007 13:20:13 +0100 Haavard Skinnemoen [EMAIL PROTECTED] wrote: This is a driver for the MMC controller on the AP7000 chips from Atmel. It should in theory work on AT91 systems too with some

Re: [RFC 4/4] Atmel MCI: Driver for Atmel on-chip MMC controllers

2007-11-24 Thread Haavard Skinnemoen
On Sat, 24 Nov 2007 10:48:39 -0800 David Brownell [EMAIL PROTECTED] wrote: On Saturday 24 November 2007, Haavard Skinnemoen wrote: Why is this needed and is it perhaps something that can be moved to the MMC core? We used to have lots of problems with overruns and underruns

Re: [PATCH] mmc: Add missing sg_init_table() call

2007-11-27 Thread Haavard Skinnemoen
On Mon, 26 Nov 2007 21:29:55 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Thu, 22 Nov 2007 20:32:51 +0100 Haavard Skinnemoen [EMAIL PROTECTED] wrote: mmc_init_queue only initializes the scatterlists with sg_init_table() when using a bounce buffer. This leads to a BUG() when

[PATCH] ptrace: Call arch_ptrace_attach() when request=PTRACE_TRACEME

2007-11-27 Thread Haavard Skinnemoen
debugged and keep it off otherwise. To be able to do this, I need to intercept PTRACE_TRACEME and PTRACE_ATTACH, as well as PTRACE_DETACH and thread exit. The latter two can be handled by existing hooks. Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- kernel/ptrace.c |2 ++ 1 files

Re: git guidance

2007-11-28 Thread Haavard Skinnemoen
On Wed, 28 Nov 2007 00:20:46 +0100 (CET) Jan Engelhardt [EMAIL PROTECTED] wrote: On Nov 27 2007 23:33, Tilman Schmidt wrote: It didn't work too well. The first result was one of maximal embarrassment: I produced a patch that didn't even compile when applied to the official tree. This

Re: Working upstream toolchain for avr32?

2007-12-14 Thread Haavard Skinnemoen
On Thu, 13 Dec 2007 20:56:17 +0100 Adrian Bunk [EMAIL PROTECTED] wrote: AFAIK the latest available AVR32 toolchains are some patched gcc 4.0 and some patched binutils 2.17, and avr32 is currently the only architecture in the kernel where upstream of both of them is not capable of building

Re: [PATCH] w1-gpio: Add GPIO w1 bus master driver

2007-12-26 Thread Haavard Skinnemoen
On Fri, 21 Dec 2007 09:34:01 +0200 Ville Syrjala [EMAIL PROTECTED] wrote: +static struct platform_device foo_w1_device = { + .name = w1-gpio, + .id = -1, Assigning -1 to a u32 member isn't a very nice example. What does it mean anyway? +static

Re: Correct use of __init and __devinit

2007-12-26 Thread Haavard Skinnemoen
On Mon, 24 Dec 2007 14:01:43 +0100 Sam Ravnborg [EMAIL PROTECTED] wrote: So of the principle of least suprise it is best to use __devinit for the probe function as most other drivers do. And if the driver model happens to call your probe function after init time then we will not oops. If

Re: [PATCH] w1-gpio: Add GPIO w1 bus master driver

2008-01-03 Thread Haavard Skinnemoen
On Thu, 3 Jan 2008 15:48:35 +0200 Ville Syrjälä [EMAIL PROTECTED] wrote: On Wed, Dec 26, 2007 at 11:24:54PM +0100, Haavard Skinnemoen wrote: On Fri, 21 Dec 2007 09:34:01 +0200 Ville Syrjala [EMAIL PROTECTED] wrote: +static struct platform_device foo_w1_device = { + .name

Re: [PATCH 2/3] Rework arch specific Makefiles to use mkubootimg

2008-01-04 Thread Haavard Skinnemoen
-by: Haavard Skinnemoen [EMAIL PROTECTED] -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [patch 2.6.24-rc6-mm 4/9] gpiolib: avr32 at32ap platform support

2008-01-05 Thread Haavard Skinnemoen
] Cc: Haavard Skinnemoen [EMAIL PROTECTED] Acked-by: Haavard Skinnemoen [EMAIL PROTECTED] I'm not going to merge it since the rest of gpiolib isn't in mainline yet. Haavard -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH] DMA: Correct invalid assumptions in the Kconfig text

2007-10-25 Thread Haavard Skinnemoen
On Wed, 24 Oct 2007 20:16:16 +0200 Haavard Skinnemoen [EMAIL PROTECTED] wrote: [handwaving about API extensions] Oh, and we definitely need a way to report errors. Looks like the existing drivers want this as well -- I couldn't help but notice this in the iop-adma driver: static irqreturn_t

[PATCH] DMA: Fix broken device refcounting

2007-10-26 Thread Haavard Skinnemoen
-free fun. Fix it by incrementing the device's reference count twice for each channel during registration. Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- I'm not sure if this is the correct way to solve it, but it seems to work. The remove() function does not hang, which indicates

Re: [PATCH] DMAENGINE: too many kref_put calls

2007-10-27 Thread Haavard Skinnemoen
On Fri, 26 Oct 2007 16:56:48 -0700 Shannon Nelson [EMAIL PROTECTED] wrote: @@ -134,8 +134,7 @@ static void dma_async_device_cleanup(struct kref *kref); static void dma_dev_release(struct device *dev) { - struct dma_chan *chan = to_dma_chan(dev); - kref_put(chan-device-refcount,

Re: [PATCH] DMA: Fix broken device refcounting

2007-10-27 Thread Haavard Skinnemoen
On Fri, 26 Oct 2007 09:36:17 -0700 Dan Williams [EMAIL PROTECTED] wrote: @@ -221,7 +220,6 @@ void dma_chan_cleanup(struct kref *kref) { struct dma_chan *chan = container_of(kref, struct dma_chan, refcount); chan-device-device_free_chan_resources(chan); -

Re: [PATCH] DMA: Correct invalid assumptions in the Kconfig text

2007-10-27 Thread Haavard Skinnemoen
On Fri, 26 Oct 2007 10:02:24 -0700 Dan Williams [EMAIL PROTECTED] wrote: On 10/25/07, Haavard Skinnemoen [EMAIL PROTECTED] wrote: static irqreturn_t iop_adma_err_handler(int irq, void *data) { (...) BUG(); } That's a panic waiting to happen, isn't it? Yes

Re: [PATCH] DMA: Correct invalid assumptions in the Kconfig text

2007-10-27 Thread Haavard Skinnemoen
On Fri, 26 Oct 2007 09:44:44 -0700 Dan Williams [EMAIL PROTECTED] wrote: On 10/24/07, Haavard Skinnemoen [EMAIL PROTECTED] wrote: Otherwise, Acked-by: Dan Williams [EMAIL PROTECTED] Thanks. Are one of you going to pick it up as well? Yeah, I'll pick it up. I'll leave off the AVR

Re: sg_next() for struct scatterlist is confusing

2007-10-27 Thread Haavard Skinnemoen
On Sat, 27 Oct 2007 07:39:40 -0400 (EDT) Robert P. J. Day [EMAIL PROTECTED] wrote: note how the comment says that the next entry will usually be sg+1, but not if it's actually a pointer. however, as i read the code above, sg is *always* incremented before that testing. is that correct?

  1   2   3   4   5   6   7   >