Re: [tip:perf/core] perf tools: Remove the node from rblist in strlist__remove

2012-11-03 Thread Hannes Frederic Sowa
On Fri, Sep 7, 2012 at 8:04 AM, tip-bot for Suzuki K. Poulose suz...@in.ibm.com wrote: Reported-by: Ananth N. Mavinakayanahalli ana...@in.ibm.com Signed-off-by: Suzuki K. Poulose suz...@in.ibm.com Acked-by: David Ahern dsah...@gmail.com Cc: Ananth N Mavinakayanahalli ana...@in.ibm.com Cc:

[PATCH] Call perf_event_comm under task_lock

2012-11-03 Thread Hannes Frederic Sowa
] sys_execve+0x47/0x70 [ 735.601016] [816b49ac] stub_execve+0x6c/0xc0 I think this dereference qualifies for the task_lock exception, thus this patch ensures calling perf_event_comm before giving up the task_lock. Patch based on linux-stable v3.6.5. Signed-off-by: Hannes Frederic Sowa

[PATCH] [perf] convert_variable_type does not correctly check type of arrays

2012-11-05 Thread Hannes Frederic Sowa
a...@ghostprotocols.net Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- tools/perf/util/probe-finder.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c index 1daf5c1..2a61ea5 100644

[PATCH 4/4] brd: add miscdevice to control creation and deletion of ram disks

2012-10-20 Thread Hannes Frederic Sowa
Piggin npig...@kernel.dk Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- Documentation/ioctl/ioctl-number.txt | 1 + drivers/block/brd.c | 170 --- include/linux/Kbuild | 1 + include/linux/brd.h

[PATCH 0/4] brd: sanity checks and dynamic ram disk creation/destroying

2012-10-20 Thread Hannes Frederic Sowa
Hi! While toying around with a library which needs small block devices for quorum management, I came up with these patches to dynamically create and destroy ram disks (I wanted to have non-swappable backed devices). Feedback is appreciated! Change log (since RFC patch

[PATCH 3/4] brd: replace list with brd_devices by an idr indexed by minor ids

2012-10-20 Thread Hannes Frederic Sowa
This patch replaces the list of brd_devices with an idr, thus enabling easier block ram disk creation and deletion. Cc: Nick Piggin npig...@kernel.dk Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- drivers/block/brd.c | 136

[PATCH 2/4] brd: check for open partitions when BLKFLSBUFing a ram disk

2012-10-20 Thread Hannes Frederic Sowa
kind of use-after-free could happen. After this change BLKFLSBUFing on partitions of a ram disk is never possible. Cc: Nick Piggin npig...@kernel.dk Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- block/partition-generic.c | 1 + drivers/block/brd.c | 20

[PATCH 1/4] brd: change module parameters rd_size, rd_nr, max_part to unsigned

2012-10-20 Thread Hannes Frederic Sowa
) placed brd_mutex out of the silly constellation between function prelude comment and function. Cc: Nick Piggin npig...@kernel.dk Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- drivers/block/brd.c | 44 +--- 1 file changed, 21 insertions

[PATCH RFC] brd: Add miscdevice to control creation and deletion of ramdisks

2012-10-13 Thread Hannes Frederic Sowa
: Deletes a ram disk. Takes the minor id as parameter. Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- Documentation/ioctl/ioctl-number.txt | 1 + drivers/block/brd.c | 115 --- include/linux/Kbuild | 1

Re: [PATCH RFC] brd: Add miscdevice to control creation and deletion of ramdisks

2012-10-13 Thread Hannes Frederic Sowa
On Sun, Oct 14, 2012 at 04:48:36AM +0200, Hannes Frederic Sowa wrote: + case BRD_CTL_DEL: + error = get_user(val, (int __user *)param); + if (error 0) + break; + if ((val max_part) != 0) { + error = -EINVAL

[PATCH] hidraw: add a .gitignore entry for samples/hidraw/hid-example

2012-10-28 Thread Hannes Frederic Sowa
Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- samples/hidraw/.gitignore | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 samples/hidraw/.gitignore diff --git a/samples/hidraw/.gitignore b/samples/hidraw/.gitignore new file mode 100644 index 000..b1bdafd

[PATCH] perf: call perf_event_comm under task_lock to fix suspicious rcu usage

2012-11-09 Thread Hannes Frederic Sowa
to 3.7-rc4 2) slightly improved/updated commit msg and added more people to Cc Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Paul Mackerras pau...@samba.org Cc: Ingo Molnar mi...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Signed-off-by: Hannes Frederic Sowa han

Re: [PATCH 2/3] input: stmpe-ts: Use devm_*() routines

2012-11-10 Thread Hannes Frederic Sowa
On Sat, Nov 10, 2012 at 01:34:33PM +0530, Viresh Kumar wrote: wrapped again.. Don't know how to disable it. :( To quote Documentation/email-clients.txt: ~ Gmail (Web GUI) Does not work for sending patches. Gmail web client converts tabs to spaces

Re: [RFC] revoke(2) and generic handling of things like remove_proc_entry()

2013-04-05 Thread Hannes Frederic Sowa
On Fri, Apr 05, 2013 at 05:29:32AM +0100, Al Viro wrote: 4) nasty semantics issue - mmap() vs. revoke (of any sort, including remove_proc_entry(), etc.). Suppose a revokable file had been mmapped; now it's going away. What should we do to its VMAs? Right now sysfs and procfs get away with

Re: BUG: IPv4: Attempt to release TCP socket in state 1

2013-03-17 Thread Hannes Frederic Sowa
On Sat, Mar 16, 2013 at 10:36:06AM -0700, Eric Dumazet wrote: On Fri, 2013-03-15 at 00:19 +0100, Eric Dumazet wrote: Thanks thats really useful, we might miss to increment socket refcount in a timer setup. Hmm, please add following debugging patch as well diff --git

Re: BUG: IPv4: Attempt to release TCP socket in state 1

2013-03-17 Thread Hannes Frederic Sowa
On Sun, Mar 17, 2013 at 07:39:48AM +0100, Hannes Frederic Sowa wrote: On Sat, Mar 16, 2013 at 10:36:06AM -0700, Eric Dumazet wrote: On Fri, 2013-03-15 at 00:19 +0100, Eric Dumazet wrote: Thanks thats really useful, we might miss to increment socket refcount in a timer setup

Re: [PATCH] perf: call perf_event_comm under task_lock to fix suspicious rcu usage

2012-11-21 Thread Hannes Frederic Sowa
Ping, this problem still persists in v3.7-rc6. Could someone have a look? On Sat, Nov 10, 2012 at 06:32:28AM +0100, Hannes Frederic Sowa wrote: Following RCU warning showed up while executing a shebang-script under perf-record (could even be an empty script) on a 3.7-rc4 stable kernel

[PATCH v2 0/4] brd: sanity checks and dynamic ram disk creation/destroying

2012-12-17 Thread Hannes Frederic Sowa
While toying around with a library which needs small block devices for quorum management, I came up with these patches to dynamically create and destroy ram disks (I wanted to have non-swappable backed devices). Change log (since RFC patch 20121014024836.gb27...@order.stressinduktion.org): 1)

[PATCH v2 1/4] brd: change module parameters rd_size, rd_nr, max_part to unsigned

2012-12-17 Thread Hannes Frederic Sowa
constellation between function prelude comment and function and convert simple Cc: Nick Piggin npig...@kernel.dk Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- drivers/block/brd.c | 45 ++--- 1 file changed, 22 insertions(+), 23 deletions

[PATCH v2 2/4] brd: check for open partitions when BLKFLSBUFing a ram disk

2012-12-17 Thread Hannes Frederic Sowa
kind of use-after-free could happen. After this change BLKFLSBUFing on partitions of a ram disk is never possible. Cc: Nick Piggin npig...@kernel.dk Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- block/partition-generic.c | 1 + drivers/block/brd.c | 20

[PATCH v2 3/4] brd: replace list with brd_devices by an idr indexed by minor ids

2012-12-17 Thread Hannes Frederic Sowa
This patch replaces the list of brd_devices with an idr, thus enabling easier block ram disk creation and deletion. Cc: Nick Piggin npig...@kernel.dk Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- drivers/block/brd.c | 136

[PATCH v2 4/4] brd: add miscdevice to control creation and deletion of ram disks

2012-12-17 Thread Hannes Frederic Sowa
Piggin npig...@kernel.dk Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- Documentation/ioctl/ioctl-number.txt | 1 + drivers/block/brd.c | 170 --- include/linux/miscdevice.h | 1 + include/uapi/linux/Kbuild

Re: [RFC PATCH - diffstat only] include/net: Remove extern from function prototypes

2013-07-24 Thread Hannes Frederic Sowa
On Wed, Jul 24, 2013 at 06:41:20PM -0700, Joe Perches wrote: On Thu, 2013-07-25 at 01:27 +, Cong Wang wrote: On Tue, 23 Jul 2013 at 17:58 GMT, Joe Perches j...@perches.com wrote: You dropped the author from the cc list. Always reply to the author. Function prototypes don't need to

Re: ipv4: crash at leaf_walk_rcu

2013-07-31 Thread Hannes Frederic Sowa
On Wed, Jul 31, 2013 at 05:55:13AM -0700, Paul E. McKenney wrote: On Wed, Jul 31, 2013 at 04:40:47PM +0530, vinayak menon wrote: Hi, A crash was seen on 3.4.5 kernel during some random wlan operations. CPU: Single core ARM Cortex A9. fib_route_seq_next was called with second

Re: PROBLEM: 3.11.0-rc2+ lost of connectivity

2013-08-01 Thread Hannes Frederic Sowa
On Thu, Aug 01, 2013 at 04:34:00PM +0200, Sebastiano Spicuglia wrote: [Kernel version from /proc/version ] Linux version 3.11.0-rc2+ (r...@cache.pdbg) (gcc version 4.7.2 (Debian 4.7.2-5) ) #5 SMP Thu Aug 1 14:20:35 CEST 2013 Which commit exactly? Thanks, Hannes -- To unsubscribe from

Re: [PATCH net-next v4 3/9] static_key: WARN on usage before jump_label_init was called

2013-11-06 Thread Hannes Frederic Sowa
On Wed, Nov 06, 2013 at 04:16:49PM -0500, Steven Rostedt wrote: Sorry for the late reply, but this was sent while I was getting ready for my two week conference trip. Note, this should not go through the net tree, but instead should go through tip, as it deals with jump labels and not

Re: [PATCH RFC] random: introduce get_random_bytes_busy_wait_initialized

2013-10-02 Thread Hannes Frederic Sowa
Hi! Thanks for looking into this! On Wed, Oct 02, 2013 at 11:10:18AM -0400, Theodore Ts'o wrote: On Wed, Sep 25, 2013 at 11:00:34AM +0200, Hannes Frederic Sowa wrote: [PATCH RFC] random: introduce get_random_bytes_busy_wait_initialized We want to use good entropy for initializing

Re: [PATCHv2] IPv6: Allow the MTU of ipip6 tunnel to be set below 1280

2013-10-04 Thread Hannes Frederic Sowa
; dev-mtu = new_mtu; return 0; } Acked-by: Hannes Frederic Sowa han...@stressinduktion.org Anytime soon we should replace all the FFF8 with a symbolic constant. Thanks, Hannes -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH] Fix the upper MTU limit in ipv6 GRE tunnel

2013-10-05 Thread Hannes Frederic Sowa
On Fri, Oct 04, 2013 at 10:52:13AM +0100, Oussama Ghorbel wrote: Unlike ipv4, the struct member hlen holds the length of the GRE and ipv6 headers. This length is also counted in dev-hard_header_len. Perhaps, it's more clean to modify the hlen to count only the GRE header without ipv6 header as

Introduce support to lazy initialize mostly static keys v2

2013-10-05 Thread Hannes Frederic Sowa
Hi! This series implements support for delaying the initialization of secret keys, e.g. used for hashing, for as long as possible. This functionality is implemented by a new macro, net_get_random_bytes. I already used it to protect the socket hashes, the syncookie secret (most important) and the

[PATCH net-next v2 8/8] net: switch net_secret key generation to net_get_random_once

2013-10-05 Thread Hannes Frederic Sowa
Cc: Eric Dumazet eduma...@google.com Cc: David S. Miller da...@davemloft.net Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- net/core/secure_seq.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/net/core/secure_seq.c b/net/core/secure_seq.c

[PATCH net-next v2 2/8] ipv6: split inet6_ehashfn to hash functions per compilation unit

2013-10-05 Thread Hannes Frederic Sowa
This patch splits the inet6_ehashfn into separate ones in ipv6/inet6_hashtables.o and ipv6/udp.o to ease the introduction of seperate secrets keys later. Cc: Eric Dumazet eduma...@google.com Cc: David S. Miller da...@davemloft.net Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org

[PATCH net-next v2 7/8] tcp: switch tcp_fastopen key generation to net_get_random_once

2013-10-05 Thread Hannes Frederic Sowa
Dumazet eduma...@google.com Cc: David S. Miller da...@davemloft.net Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- include/net/tcp.h | 2 +- net/ipv4/sysctl_net_ipv4.c | 5 + net/ipv4/tcp_fastopen.c| 27 --- 3 files changed, 22

[PATCH net-next v2 6/8] inet: convert inet_ehash_secret and ipv6_hash_secret to net_get_random_once

2013-10-05 Thread Hannes Frederic Sowa
at most two (needed in ipv6) if (unlikely(...)). Cc: Eric Dumazet eduma...@google.com Cc: David S. Miller da...@davemloft.net Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- include/net/inet_sock.h | 4 net/ipv4/af_inet.c | 27 --- net

[PATCH net-next v2 4/8] net: introduce new macro net_get_random_once

2013-10-05 Thread Hannes Frederic Sowa
...@davemloft.net Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- I tested this patchset with !CC_HAVE_ASM_GOTO and with CC_HAVE_ASM_GOTO on x86_64. I quickly reviewed that all architectures which implement HAVE_JUMP_LABEL also patch all branch sites on boot-up. But this needs further review

[PATCH net-next v2 5/8] inet: split syncookie keys for ipv4 and ipv6 and initialize with net_get_random_once

2013-10-05 Thread Hannes Frederic Sowa
...@google.com Cc: David S. Miller da...@davemloft.net Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- include/net/tcp.h | 1 - net/ipv4/syncookies.c | 15 +-- net/ipv6/syncookies.c | 12 +--- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/include

[PATCH net-next v2 3/8] x86/jump_label: expect default_nop if static_key gets enabled on boot-up

2013-10-05 Thread Hannes Frederic Sowa
...@redhat.com Cc: H. Peter Anvin h...@zytor.com Cc: Steven Rostedt rost...@goodmis.org Cc: Jason Baron jba...@redhat.com Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Eric Dumazet eduma...@google.com Cc: David S. Miller da...@davemloft.net Cc: x...@kernel.org Signed-off-by: Hannes Frederic Sowa han

[PATCH net-next v2 1/8] ipv4: split inet_ehashfn to hash functions per compilation unit

2013-10-05 Thread Hannes Frederic Sowa
This duplicates a bit of code but let's us easily introduce separate secret keys later. The separate compilation units are ipv4/inet_hashtabbles.o, ipv4/udp.o and rds/connection.o. Cc: Eric Dumazet eduma...@google.com Cc: David S. Miller da...@davemloft.net Signed-off-by: Hannes Frederic Sowa han

Re: [PATCH net-next v2 3/8] x86/jump_label: expect default_nop if static_key gets enabled on boot-up

2013-10-05 Thread Hannes Frederic Sowa
On Sat, Oct 05, 2013 at 08:05:58PM -0400, Steven Rostedt wrote: if (type == JUMP_LABEL_ENABLE) { - /* -* We are enabling this jump label. If it is not a nop -* then something must have gone wrong. -*/ - if

Re: [PATCH] Fix the upper MTU limit in ipv6 GRE tunnel

2013-10-06 Thread Hannes Frederic Sowa
On Sun, Oct 06, 2013 at 03:42:15PM +0100, Oussama Ghorbel wrote: The initialization in ip6gre_tnl_link_config is done as the following: static void ip6gre_tnl_link_config(struct ip6_tnl *t, int set_mtu) { ... int addend = sizeof(struct ipv6hdr) + 4; ... /* Precalculate GRE options length

Re: [PATCH] Fix the upper MTU limit in ipv6 GRE tunnel

2013-10-06 Thread Hannes Frederic Sowa
On Sun, Oct 06, 2013 at 04:36:56PM +0100, Oussama Ghorbel wrote: On Sun, Oct 6, 2013 at 4:13 PM, Hannes Frederic Sowa han...@stressinduktion.org wrote: On Sun, Oct 06, 2013 at 03:42:15PM +0100, Oussama Ghorbel wrote: The initialization in ip6gre_tnl_link_config is done as the following

[PATCH] static_key: WARN on usage before jump_label_init was called

2013-10-06 Thread Hannes Frederic Sowa
On Sun, Oct 06, 2013 at 02:12:47AM +0200, Hannes Frederic Sowa wrote: On Sat, Oct 05, 2013 at 08:05:58PM -0400, Steven Rostedt wrote: if (type == JUMP_LABEL_ENABLE) { - /* - * We are enabling this jump label. If it is not a nop - * then something must have

Re: [PATCH] Fix the upper MTU limit in ipv6 GRE tunnel

2013-10-06 Thread Hannes Frederic Sowa
the solution provided in the patch seems to be regression risk-less. I agree, it actually does not worsen the situation: Acked-by: Hannes Frederic Sowa han...@stressinduktion.org Although the value hold by hlen is not coherent with the variable name nor with ipv4, I think there is an advantage

[PATCH net-next v3 5/9] net: introduce new macro net_get_random_once

2013-10-16 Thread Hannes Frederic Sowa
...@davemloft.net Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- I tested this patchset with !CC_HAVE_ASM_GOTO and with CC_HAVE_ASM_GOTO on x86_64. I quickly reviewed that all architectures which implement HAVE_JUMP_LABEL also patch all branch sites on boot-up. But this needs further review

[PATCH net-next v3 8/9] tcp: switch tcp_fastopen key generation to net_get_random_once

2013-10-16 Thread Hannes Frederic Sowa
Dumazet eduma...@google.com Cc: David S. Miller da...@davemloft.net Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- include/net/tcp.h | 2 +- net/ipv4/sysctl_net_ipv4.c | 5 + net/ipv4/tcp_fastopen.c| 27 --- 3 files changed, 22

[PATCH net-next v3 1/9] ipv4: split inet_ehashfn to hash functions per compilation unit

2013-10-16 Thread Hannes Frederic Sowa
This duplicates a bit of code but let's us easily introduce separate secret keys later. The separate compilation units are ipv4/inet_hashtabbles.o, ipv4/udp.o and rds/connection.o. Cc: Eric Dumazet eduma...@google.com Cc: David S. Miller da...@davemloft.net Signed-off-by: Hannes Frederic Sowa han

[PATCH net-next v3 7/9] inet: convert inet_ehash_secret and ipv6_hash_secret to net_get_random_once

2013-10-16 Thread Hannes Frederic Sowa
at most two (needed in ipv6) if (unlikely(...)). Cc: Eric Dumazet eduma...@google.com Cc: David S. Miller da...@davemloft.net Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- include/net/inet_sock.h | 4 net/ipv4/af_inet.c | 27 --- net

[PATCH net-next v3 4/9] x86/jump_label: expect default_nop if static_key gets enabled on boot-up

2013-10-16 Thread Hannes Frederic Sowa
...@redhat.com Cc: H. Peter Anvin h...@zytor.com Cc: Steven Rostedt rost...@goodmis.org Cc: Jason Baron jba...@redhat.com Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Eric Dumazet eduma...@google.com Cc: David S. Miller da...@davemloft.net Cc: x...@kernel.org Signed-off-by: Hannes Frederic Sowa han

[PATCH net-next v3 9/9] net: switch net_secret key generation to net_get_random_once

2013-10-16 Thread Hannes Frederic Sowa
Cc: Eric Dumazet eduma...@google.com Cc: David S. Miller da...@davemloft.net Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- net/core/secure_seq.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/net/core/secure_seq.c b/net/core/secure_seq.c

[PATCH net-next v3 6/9] inet: split syncookie keys for ipv4 and ipv6 and initialize with net_get_random_once

2013-10-16 Thread Hannes Frederic Sowa
...@google.com Cc: David S. Miller da...@davemloft.net Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- include/net/tcp.h | 1 - net/ipv4/syncookies.c | 15 +-- net/ipv6/syncookies.c | 12 +--- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/include

[PATCH net-next v3 0/9] Introduce support to lazy initialize mostly static keys

2013-10-16 Thread Hannes Frederic Sowa
Hi! This series implements support for delaying the initialization of secret keys, e.g. used for hashing, for as long as possible. This functionality is implemented by a new macro, net_get_random_bytes. I already used it to protect the socket hashes, the syncookie secret (most important) and the

[PATCH net-next v3 2/9] ipv6: split inet6_ehashfn to hash functions per compilation unit

2013-10-16 Thread Hannes Frederic Sowa
This patch splits the inet6_ehashfn into separate ones in ipv6/inet6_hashtables.o and ipv6/udp.o to ease the introduction of seperate secrets keys later. Cc: Eric Dumazet eduma...@google.com Cc: David S. Miller da...@davemloft.net Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org

[PATCH net-next v3 3/9] static_key: WARN on usage before jump_label_init was called

2013-10-16 Thread Hannes Frederic Sowa
Based on a patch from Andi Kleen. Cc: Steven Rostedt rost...@goodmis.org Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Andi Kleen a...@firstfloor.org Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- include/linux/jump_label.h | 10 ++ include/linux

Re: [PATCH net-next v3 3/9] static_key: WARN on usage before jump_label_init was called

2013-10-17 Thread Hannes Frederic Sowa
On Thu, Oct 17, 2013 at 05:19:40PM -0400, Steven Rostedt wrote: On Thu, 17 Oct 2013 07:31:57 +0200 Hannes Frederic Sowa han...@stressinduktion.org wrote: Based on a patch from Andi Kleen. I'm fine with the patch, but the change log needs a lot more work. Like, why is this needed? I know

Re: [PATCH net-next v3 3/9] static_key: WARN on usage before jump_label_init was called

2013-10-17 Thread Hannes Frederic Sowa
On Fri, Oct 18, 2013 at 02:50:57AM +0200, Andi Kleen wrote: On Thu, Oct 17, 2013 at 05:19:40PM -0400, Steven Rostedt wrote: On Thu, 17 Oct 2013 07:31:57 +0200 Hannes Frederic Sowa han...@stressinduktion.org wrote: Based on a patch from Andi Kleen. I'm fine with the patch

[PATCH net-next v4 9/9] net: switch net_secret key generation to net_get_random_once

2013-10-19 Thread Hannes Frederic Sowa
Cc: Eric Dumazet eduma...@google.com Cc: David S. Miller da...@davemloft.net Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- net/core/secure_seq.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/net/core/secure_seq.c b/net/core/secure_seq.c

[PATCH net-next v4 1/9] ipv4: split inet_ehashfn to hash functions per compilation unit

2013-10-19 Thread Hannes Frederic Sowa
This duplicates a bit of code but let's us easily introduce separate secret keys later. The separate compilation units are ipv4/inet_hashtabbles.o, ipv4/udp.o and rds/connection.o. Cc: Eric Dumazet eduma...@google.com Cc: David S. Miller da...@davemloft.net Signed-off-by: Hannes Frederic Sowa han

[PATCH net-next v4 2/9] ipv6: split inet6_ehashfn to hash functions per compilation unit

2013-10-19 Thread Hannes Frederic Sowa
This patch splits the inet6_ehashfn into separate ones in ipv6/inet6_hashtables.o and ipv6/udp.o to ease the introduction of seperate secrets keys later. Cc: Eric Dumazet eduma...@google.com Cc: David S. Miller da...@davemloft.net Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org

[PATCH net-next v4 0/9] Introduce support to lazy initialize mostly static keys

2013-10-19 Thread Hannes Frederic Sowa
Hi! This series implements support for delaying the initialization of secret keys, e.g. used for hashing, for as long as possible. This functionality is implemented by a new macro, net_get_random_bytes. I already used it to protect the socket hashes, the syncookie secret (most important) and the

[PATCH net-next v4 8/9] tcp: switch tcp_fastopen key generation to net_get_random_once

2013-10-19 Thread Hannes Frederic Sowa
Dumazet eduma...@google.com Cc: David S. Miller da...@davemloft.net Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- include/net/tcp.h | 2 +- net/ipv4/sysctl_net_ipv4.c | 5 + net/ipv4/tcp_fastopen.c| 27 --- 3 files changed, 22

[PATCH net-next v4 7/9] inet: convert inet_ehash_secret and ipv6_hash_secret to net_get_random_once

2013-10-19 Thread Hannes Frederic Sowa
at most two (needed in ipv6) if (unlikely(...)). Cc: Eric Dumazet eduma...@google.com Cc: David S. Miller da...@davemloft.net Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- include/net/inet_sock.h | 4 net/ipv4/af_inet.c | 27 --- net

[PATCH net-next v4 5/9] net: introduce new macro net_get_random_once

2013-10-19 Thread Hannes Frederic Sowa
...@davemloft.net Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- I tested this patchset with !CC_HAVE_ASM_GOTO and with CC_HAVE_ASM_GOTO on x86_64. I quickly reviewed that all architectures which implement HAVE_JUMP_LABEL also patch all branch sites on boot-up. But this needs further review

[PATCH net-next v4 3/9] static_key: WARN on usage before jump_label_init was called

2013-10-19 Thread Hannes Frederic Sowa
are considered slow-path so the additional check does no harm to performance. The warnings are best observed with earlyprintk. Based on a patch from Andi Kleen. Cc: Steven Rostedt rost...@goodmis.org Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Andi Kleen a...@firstfloor.org Signed-off-by: Hannes Frederic

[PATCH net-next v4 6/9] inet: split syncookie keys for ipv4 and ipv6 and initialize with net_get_random_once

2013-10-19 Thread Hannes Frederic Sowa
...@google.com Cc: David S. Miller da...@davemloft.net Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- include/net/tcp.h | 1 - net/ipv4/syncookies.c | 15 +-- net/ipv6/syncookies.c | 12 +--- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/include

[PATCH net-next v4 4/9] x86/jump_label: expect default_nop if static_key gets enabled on boot-up

2013-10-19 Thread Hannes Frederic Sowa
...@redhat.com Cc: H. Peter Anvin h...@zytor.com Cc: Steven Rostedt rost...@goodmis.org Cc: Jason Baron jba...@redhat.com Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Eric Dumazet eduma...@google.com Cc: David S. Miller da...@davemloft.net Cc: x...@kernel.org Signed-off-by: Hannes Frederic Sowa han

Re: [PATCH net-next v4 0/9] Introduce support to lazy initialize mostly static keys

2013-10-19 Thread Hannes Frederic Sowa
On Sat, Oct 19, 2013 at 07:46:35PM -0400, David Miller wrote: From: Hannes Frederic Sowa han...@stressinduktion.org Date: Sat, 19 Oct 2013 21:48:50 +0200 This series implements support for delaying the initialization of secret keys, e.g. used for hashing, for as long as possible

[PATCH net-next] net: fix build warnings because of net_get_random_once merge

2013-10-19 Thread Hannes Frederic Sowa
. Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- include/linux/net.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/net.h b/include/linux/net.h index a489705..aca446b 100644 --- a/include/linux/net.h +++ b/include/linux/net.h @@ -24,6 +24,7 @@ #include linux

Re: [Patch v2] IPv6: Fixed support for blackhole and prohibit routes

2013-11-23 Thread Hannes Frederic Sowa
On Fri, Nov 22, 2013 at 01:51:28PM +0530, Kamala R wrote: diff --git a/net/ipv6/route.c b/net/ipv6/route.c index f54e3a1..d90b9ab 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -1564,21 +1564,24 @@ int ip6_route_add(struct fib6_config *cfg) goto out;

Re: [PATCH] update consumers of MSG_MORE to recognize MSG_SENDPAGE_NOTLAST

2013-11-24 Thread Hannes Frederic Sowa
On Sun, Nov 24, 2013 at 06:08:59PM -0800, Shawn Landden wrote: Commit 35f9c09fe (tcp: tcp_sendpages() should call tcp_push() once) added an internal flag MSG_SENDPAGE_NOTLAST, similar to MSG_MORE. algif_hash and algif_skcipher used MSG_MORE from tcp_sendpages() and need to see the new flag

Re: [PATCH] fix printk output

2013-11-27 Thread Hannes Frederic Sowa
On Thu, Nov 28, 2013 at 02:03:59AM +0400, Sergei Ianovich wrote: Signed-off-by: Sergei Ianovich ynv...@gmail.com --- kernel/module.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/module.c b/kernel/module.c index f5a3b1e..6f87299 100644 --- a/kernel/module.c

Re: 3.13.0-rc1+ INFO: inconsistent lock state

2013-11-27 Thread Hannes Frederic Sowa
On Thu, Nov 28, 2013 at 04:17:56AM +, 허종만 wrote: With current linus git (HEAD 8ae516aa), I got following kernel message. This is slightly different from what I had reported recently (14th Nov). I guess the prolem is that the STATS _BH functions are to be used if they are executed in bottom

Re: [PATCH v2] inet: fix possible seqlock deadlocks

2013-11-28 Thread Hannes Frederic Sowa
) Signed-off-by: Eric Dumazet eduma...@google.com Cc: Hannes Frederic Sowa han...@stressinduktion.org Just got home after getting distracted with other things today and the work is already done. Thanks, Eric! ;) Exactly the spots I noticed this morning, so Acked-by: Hannes Frederic Sowa han

Re: [Patch v3] IPv6: Fixed support for blackhole and prohibit routes

2013-11-28 Thread Hannes Frederic Sowa
and to ip6_pkt_discard and ip6_pkt_discard_out respectively for prohibit routes. Signed-off-by: Kamala R kam...@aristanetworks.com Thanks for changing this once again! Acked-by: Hannes Frederic Sowa han...@stressinduktion.org -- To unsubscribe from this list: send the line unsubscribe linux

Re: [Patch v2] IPv6: Fixed support for blackhole and prohibit routes

2013-11-28 Thread Hannes Frederic Sowa
On Fri, Nov 22, 2013 at 01:51:28PM +0530, Kamala R wrote: From: Kamala R kam...@aristanetworks.com The behaviour of blackhole and prohibit routes has been corrected by setting the input and output function pointers of the dst variable appropriately. For blackhole routes, they are set to

[PATCH] ipv6: ip6_pkt_prohibit(_out) should not depend on CONFIG_IPV6_MULTIPLE_TABLES

2013-11-28 Thread Hannes Frederic Sowa
Since patch IPv6: Fixed support for blackhole and prohibit routes we need ip6_pkt_prohibit(_out) available without CONFIG_IPV6_MULTIPLE_TABLES defined. Cc: Kamala R kam...@aristanetworks.com Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- net/ipv6/route.c | 9 ++--- 1 file

[PATCH] inet: further fixes of possible seqlock deadlocks

2013-11-28 Thread Hannes Frederic Sowa
This fixes more incorrect uses of *_STATS_BH in process context. Cc: Eric Dumazet eduma...@google.com Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- net/ipv4/udp.c| 8 net/ipv6/ip6_output.c | 8 net/ipv6/ping.c | 4 ++-- 3 files changed, 10

Re: [PATCH] inet: further fixes of possible seqlock deadlocks

2013-11-28 Thread Hannes Frederic Sowa
On Thu, Nov 28, 2013 at 01:01:42PM -0800, Eric Dumazet wrote: On Thu, 2013-11-28 at 20:22 +0100, Hannes Frederic Sowa wrote: This fixes more incorrect uses of *_STATS_BH in process context. Cc: Eric Dumazet eduma...@google.com Signed-off-by: Hannes Frederic Sowa han

Re: [PATCH] inet: further fixes of possible seqlock deadlocks

2013-11-28 Thread Hannes Frederic Sowa
On Thu, Nov 28, 2013 at 10:27:00PM +0100, Hannes Frederic Sowa wrote: @@ -1524,8 +1524,8 @@ int ip6_push_pending_frames(struct sock *sk) if (proto == IPPROTO_ICMPV6) { struct inet6_dev *idev = ip6_dst_idev(skb_dst(skb)); - ICMP6MSGOUT_INC_STATS_BH(net, idev

[PATCH] ipv6: fix possible seqlock deadlock in ip6_finish_output2

2013-11-28 Thread Hannes Frederic Sowa
IPv6 stats are 64 bits and thus are protected with a seqlock. By not disabling bottom-half we could deadlock here if we don't disable bh and a softirq reentrantly updates the same mib. Cc: Eric Dumazet eric.duma...@gmail.com Signed-off-by: Hannes Frederic Sowa han...@stressinduktion.org --- net

Re: [PATCH] update consumers of MSG_MORE to recognize MSG_SENDPAGE_NOTLAST

2013-11-28 Thread Hannes Frederic Sowa
On Sun, Nov 24, 2013 at 10:36:28PM -0800, Shawn Landden wrote: Commit 35f9c09fe (tcp: tcp_sendpages() should call tcp_push() once) added an internal flag MSG_SENDPAGE_NOTLAST, similar to MSG_MORE. algif_hash, algif_skcipher, and udp used MSG_MORE from tcp_sendpages() and need to see the new

Re: [PATCH] ipv6: ip6_pkt_prohibit(_out) should not depend on CONFIG_IPV6_MULTIPLE_TABLES

2013-11-30 Thread Hannes Frederic Sowa
On Fri, Nov 29, 2013 at 04:39:30PM -0500, David Miller wrote: From: Hannes Frederic Sowa han...@stressinduktion.org Date: Thu, 28 Nov 2013 20:04:11 +0100 Since patch IPv6: Fixed support for blackhole and prohibit routes we need ip6_pkt_prohibit(_out) available without

Re: [PATCH] ipv6: ip6_pkt_prohibit(_out) should not depend on CONFIG_IPV6_MULTIPLE_TABLES

2013-11-30 Thread Hannes Frederic Sowa
On Sat, Nov 30, 2013 at 12:51:10PM -0500, David Miller wrote: From: Hannes Frederic Sowa han...@stressinduktion.org Date: Sat, 30 Nov 2013 18:46:35 +0100 On Fri, Nov 29, 2013 at 04:39:30PM -0500, David Miller wrote: From: Hannes Frederic Sowa han...@stressinduktion.org Date: Thu, 28 Nov

Re: [Patch v4] IPv6: Fixed support for blackhole and prohibit routes

2013-12-02 Thread Hannes Frederic Sowa
and ip6_pkt_discard_out respectively for prohibit routes. ipv6: ip6_pkt_prohibit(_out) should not depend on CONFIG_IPV6_MULTIPLE_TABLES We need ip6_pkt_prohibit(_out) available without CONFIG_IPV6_MULTIPLE_TABLES Signed-off-by: Kamala R kam...@aristanetworks.com Looks good, thanks! Acked-by: Hannes Frederic

Re: [PATCH] ipv6: Initialize ip6_tnl.hlen in gre tunnel even if no route is found

2013-10-11 Thread Hannes Frederic Sowa
happen in real life, but doing that will avoid to call the skb_push function with a zero in ip6gre_header function. Suggested-by: Hannes Frederic Sowa han...@stressinduktion.org Signed-off-by: Oussama Ghorbel ou.ghor...@gmail.com Acked-by: Hannes Frederic Sowa han...@stressinduktion.org Thanks

Re: [PATCH v2 tip/core/rcu 07/13] ipv6/ip6_tunnel: Apply rcu_access_pointer() to avoid sparse false positive

2013-10-11 Thread Hannes Frederic Sowa
On Thu, Oct 10, 2013 at 12:05:32PM -0700, Paul E. McKenney wrote: On Thu, Oct 10, 2013 at 04:04:22AM +0200, Hannes Frederic Sowa wrote: On Wed, Oct 09, 2013 at 05:28:33PM -0700, Paul E. McKenney wrote: On Wed, Oct 09, 2013 at 05:12:40PM -0700, Eric Dumazet wrote: On Wed, 2013-10-09 at 16

Re: [PATCH v2 tip/core/rcu 07/13] ipv6/ip6_tunnel: Apply rcu_access_pointer() to avoid sparse false positive

2013-10-12 Thread Hannes Frederic Sowa
On Sat, Oct 12, 2013 at 12:53:36AM -0700, Paul E. McKenney wrote: On Sat, Oct 12, 2013 at 04:25:08AM +0200, Hannes Frederic Sowa wrote: I saw your patch regarding making rcu_assign_pointer volatile and wonder if we can still make it a bit more safe to use if we force the evaluation

Re: [PATCH v2 tip/core/rcu 07/13] ipv6/ip6_tunnel: Apply rcu_access_pointer() to avoid sparse false positive

2013-10-12 Thread Hannes Frederic Sowa
On Sat, Oct 12, 2013 at 06:43:45PM +0200, Hannes Frederic Sowa wrote: Regarding the volatile access, I hope that the C11 memory model and enhancements to the compiler will some day provide a better way to express the semantics of what is tried to express here (__atomic_store_n/__atomic_load_n

Re: [Bridge] [PATCH v3 tip/core/rcu 0/14] Sparse-related updates for 3.13

2013-10-12 Thread Hannes Frederic Sowa
On Sat, Oct 12, 2013 at 10:13:45AM -0700, Paul E. McKenney wrote: On Fri, Oct 11, 2013 at 11:53:27PM -0700, Josh Triplett wrote: On Fri, Oct 11, 2013 at 04:16:59PM -0700, Paul E. McKenney wrote: Changes from v2: o Switch from rcu_assign_pointer() to ACCESS_ONCE() given that the

Re: [Bridge] [PATCH v3 tip/core/rcu 0/14] Sparse-related updates for 3.13

2013-10-12 Thread Hannes Frederic Sowa
On Sat, Oct 12, 2013 at 07:39:30PM +0200, Hannes Frederic Sowa wrote: On Sat, Oct 12, 2013 at 10:13:45AM -0700, Paul E. McKenney wrote: On Fri, Oct 11, 2013 at 11:53:27PM -0700, Josh Triplett wrote: On Fri, Oct 11, 2013 at 04:16:59PM -0700, Paul E. McKenney wrote: Changes from v2

Re: [PATCH v2 tip/core/rcu 07/13] ipv6/ip6_tunnel: Apply rcu_access_pointer() to avoid sparse false positive

2013-10-13 Thread Hannes Frederic Sowa
On Sun, Oct 13, 2013 at 04:14:39AM -0700, Paul E. McKenney wrote: On Sat, Oct 12, 2013 at 07:42:18PM +, Mathieu Desnoyers wrote: - Original Message - On Sat, Oct 12, 2013 at 06:43:45PM +0200, Hannes Frederic Sowa wrote: Regarding the volatile access, I hope that the C11

Re: IPv6: Blackhole route support partial ?

2013-11-11 Thread Hannes Frederic Sowa
Hello! On Mon, Nov 11, 2013 at 07:25:14PM +0530, Kamala R wrote: On adding IPv6 blackhole routes, ICMP unreachable messages are being sent back to source. According to the definition, packets destined to a blackhole address must be dropped silently. Yes, this is a bug. I applied the patch

Re: IPv6: Blackhole route support partial ?

2013-11-12 Thread Hannes Frederic Sowa
On Tue, Nov 12, 2013 at 04:39:10PM +0530, Kamala R wrote: Hi, Sure, here it is. --- linux-3.12/net/ipv6/route.c.orig2013-11-12 16:23:46.0 +0530 +++ linux-3.12/net/ipv6/route.c 2013-11-12 16:30:51.0 +0530 @@ -1570,9 +1570,13 @@ int ip6_route_add(struct fib6_config *cf

Re: linux-next: manual merge of the random tree with the net-next tree

2013-11-12 Thread Hannes Frederic Sowa
On Tue, Nov 12, 2013 at 06:02:42PM -0500, Theodore Ts'o wrote: On Tue, Nov 12, 2013 at 09:55:29AM +0100, Daniel Borkmann wrote: As per Hannes' suggestion, the result should look like (see cover letter in [1]): if (r-entropy_total 128) { r-initialized = 1; r-entropy_total

Re: IPv6: Blackhole route support partial ?

2013-11-14 Thread Hannes Frederic Sowa
Hi! On Thu, Nov 14, 2013 at 01:50:20PM +0530, Kamala R wrote: I have one quick question before I send the patch across. I noticed that ip -6 route show shows an error -22 in the output which signifies -EINVAL associated with blackhole routes. This behaviour is not consistent with that of ip

Re: IPv6: Blackhole route support partial ?

2013-11-15 Thread Hannes Frederic Sowa
Hi! On Fri, Nov 15, 2013 at 03:06:28PM +0530, Kamala R wrote: That's right. We don't show the error for IPv4 routes as it follows a different path in kernel while dumping the information as compared with IPv6. Therefore, ip route show does not show an error while ip -6 route show does. So it

Re: [RFC v2 2/4] net: enables interface option to skip IP

2014-02-24 Thread Hannes Frederic Sowa
On Tue, Feb 25, 2014 at 02:01:59AM +, Ben Hutchings wrote: On Mon, 2014-02-24 at 19:12 -0500, David Miller wrote: From: Ben Hutchings b...@decadent.org.uk Date: Tue, 25 Feb 2014 00:02:00 + You can run an internal network, or access network, as v6-only with NAT64 and DNS64 at

Re: [RFC v2 2/4] net: enables interface option to skip IP

2014-02-25 Thread Hannes Frederic Sowa
On Tue, Feb 25, 2014 at 04:18:17PM -0500, David Miller wrote: From: Dan Williams d...@redhat.com Date: Tue, 25 Feb 2014 15:07:00 -0600 Also, disable_ipv4 signals *intent*, which is distinct from current state. Does an interface without an IPv4 address mean that the user wished it

Re: [PATCH] bridge: multicast: add sanity check for query source addresses

2014-03-04 Thread Hannes Frederic Sowa
On Tue, Mar 04, 2014 at 03:57:35AM +0100, Linus Lüssing wrote: MLD queries are supposed to have an IPv6 link-local source address according to RFC2710, section 4 and RFC3810, section 5.1.14. This patch adds a sanity check to ignore such broken MLD queries. Without this check, such malformed

Re: [PATCH] bridge: multicast: add sanity check for query source addresses

2014-03-04 Thread Hannes Frederic Sowa
On Tue, Mar 04, 2014 at 11:43:55AM +0100, Linus Lüssing wrote: On Tue, Mar 04, 2014 at 10:06:14AM +0100, Hannes Frederic Sowa wrote: diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c index ef66365..fb0e36f 100644 --- a/net/bridge/br_multicast.c +++ b/net/bridge

Re: [PATCHv2 2/2] bridge: multicast: enable snooping on general queries only

2014-03-10 Thread Hannes Frederic Sowa
On Mon, Mar 10, 2014 at 10:25:25PM +0100, Linus Lüssing wrote: br_multicast_query_received(br, port, br-ip6_querier, - !ipv6_addr_any(ip6h-saddr), max_delay); + !ipv6_addr_any(ip6h-saddr), +

  1   2   3   4   5   6   7   8   9   10   >