Either way, the code looks functional to me.
So is that reviewed-by?
I was thinking about this hunk:
@@ -1972,7 +2084,20 @@ int input_register_device(struct input_dev *dev)
mutex_unlock(input_mutex);
+ if (dev-devres_managed) {
+ dev_info(dev-dev.parent,
Hi Benjamin,
Win8 certification introduced the ability to transmit two X and two Y per
touch. The specification precises that it must be in an array, with a
report count == 2.
The number two never really enters the patch, so maybe it should be
dropped to avoid confusion. It probably makes
)
+ td-maxcontacts = field-logical_maximum;
if (td-mtclass.maxcontacts)
/* check if the maxcontacts is given by the class */
td-maxcontacts = td-mtclass.maxcontacts;
--
1.7.11.7
Acked-by: Henrik Rydberg rydb...@euromail.se
Hi Benjamin,
Win8 input specification clarifies the X and Y sent by devices.
It distincts the position where the user wants to Touch (T) from
the center of the ellipsoide (C). This patch enable supports for this
distinction in hid-multitouch.
We recognize Win8 certified devices from their
Hi Benjamin,
Win 8 device specification changed the requirements for the hid usages
of the multitouch devices. Now InRange is optional and must be only
used when the device supports hovering.
This ensures that the quirk ALWAYS_VALID is taken into account and
also ensures its precedence
On Fri, Oct 26, 2012 at 10:44:24AM +0200, Benjamin Tissoires wrote:
Win 8 specification is much more precise than the Win 7 one.
Moreover devices that need to take certification must be submitted
to Microsoft.
The result is a better protocol support and we can rely on that to
skip all the
Hi Benjamin,
Win8 devices supporting hovering must provides InRange HID field.
The information that the finger is here but is not touching the surface
is sent to the user space through ABS_MT_DISTANCE as required by the
multitouch protocol.
Signed-off-by: Benjamin Tissoires
Hi Benjamin,
Win 8 digitizer devices provides the actual scan time computed by the
hardware itself. The value is global to the frame and is not specific
to the multitouch protocol (though only touch, not pen, should use it
according to the specification).
Signed-off-by: Benjamin Tissoires
---
From 5d9a791e0a9e41bcea0fcb286e2849b403675f37 Mon Sep 17 00:00:00 2001
From: Henrik Rydberg rydb...@euromail.se
Date: Mon, 2 Jul 2012 20:38:21 +0200
Subject: [PATCH 3/7] hid: extend interface with report requests
---
drivers/hid/usbhid/hid-core.c | 14 ++
include/linux/hid.h
Hi Alexandra,
From: Alexandra Chin alexandra.c...@tw.synaptics.com
Date: Wed, 31 Oct 2012 16:21:12 +0800
Subject: [PATCH] staging: ste_rmi4: Convert to Type-B support
This patch:
- Convert to MT-B because Synaptics touch devices are capable of
tracking identifiable fingers
- Modify
+ usage_index) {
+ hid_map_usage(hi, usage, bit, max,
+ EV_ABS, ABS_MT_TOOL_X);
+ set_abs(hi-input, ABS_MT_TOOL_X, field,
+
Hi Benjamin,
On Mon, Oct 29, 2012 at 11:19 PM, Henrik Rydberg rydb...@euromail.se wrote:
On Fri, Oct 26, 2012 at 10:44:24AM +0200, Benjamin Tissoires wrote:
Win 8 specification is much more precise than the Win 7 one.
Moreover devices that need to take certification must be submitted
Hi Benjamin,
This is a nice feature, useful in many other contexts. As such, I
think it should be defined in the context of the input subsystem, with
a more specific definition added to the documentation. For instance,
is 100us suitable? When should it start at zero, at BTN_TOUCH? Or
17 00:00:00 2001
From: Henrik Rydberg rydb...@euromail.se
Date: Mon, 2 Jul 2012 20:38:21 +0200
Subject: [PATCH 3/7] hid: extend interface with report requests
---
drivers/hid/usbhid/hid-core.c | 14 ++
include/linux/hid.h | 33
Hi Alexandra,
From 783c14e5978600cc78e11ea078cc413d77a9debd Mon Sep 17 00:00:00 2001
From: Alexandra Chin alexandra.c...@tw.synaptics.com
Date: Thu, 1 Nov 2012 17:02:14 +0800
Subject: [PATCH v2] staging: ste_rmi4: Convert to Type-B support
This patch:
- convert to MT-B because Synaptics
Hi Yufeng,
We are already releasing all pressed keys on device reset and
disconnect. This patch adds the finger release for multi-touch
device.
Different than the key release logic that only the pressed keys
are released, here all the possible fingers are released even
it is not recorded
Hi Alexandra,
Hi Henrik/Dmitry,
We are working on a product specific driver for Synaptics DS4 I2C touchscreen
devices. It was submitted on Sept. 16, 2012, but has not been reviewed.
(http://lkml.org/lkml/2012/9/16/24).
We found several warnings after running script/checkpatch.pl,
Hi Benjamin,
The goal of this patch is to implement in a reliable way Win 8
multitouch protocol (to avoid quirking many devices). Thanks to the
precision they made in the specification, I think it is feasible:
they add the dynamic part that were missing in Win 7 spec:
When sending data in
Hi Alexandra,
Thanks for making changes.
This patch converts to MT-B because Synaptics touch devices are
capable of tracking identifiable fingers
This patch was tested on pandaboard, except input_mt_sync_frame(),
which is a quite new function.
I am not sure how to interpret this. Is the
Hi Benjamin,
This patch factorizes the hid set_feature command by using
hid_device-hid_output_raw_report instead of direclty relying on
usbhid. This makes the driver usb independant.
However I still can't remove the 2 usb related headers because the
function mt_resume has a specific
are alright with the patch
below, Dmitry, care to pick this up for 3.7? Otherwise I can carry it
for 3.8.
Thanks,
Henrik
---
From a96b3a67eefba05d7e6de3afa1b51d17728d45d3 Mon Sep 17 00:00:00 2001
From: Henrik Rydberg rydb...@euromail.se
Date: Wed, 7 Nov 2012 20:40:24 +0100
Subject: [PATCH] Input: MT
Hi Alexandra,
Convert to MT-B because Synaptics touch devices are capable of tracking
identifiable fingers.
Signed-off-by: Alexandra Chin alexandra.c...@tw.synaptics.com
---
Changes from v4:
- Incorporated Henrik's review comments
*split function
the
former patch into this one.
Thanks,
Henrik
From 1ba1d5e18057260a3203625eaee22cc94393fda3 Mon Sep 17 00:00:00 2001
From: Henrik Rydberg rydb...@euromail.se
Date: Thu, 8 Nov 2012 18:48:22 +0100
Subject: [PATCH] Input: Document new struct members
Fixes kernel-doc warnings for the members added
On Thu, Oct 18, 2012 at 11:58:09AM +0200, Henrik Rydberg wrote:
Hi Ben,
3.7-rc1 messed up the screen on my MacBookAir3,1 (nv50, 0xaf) pretty
badly. Not surprisingly,
commit 3863c9bc887e9638a9d905d55f6038641ece78d6
Author: Ben Skeggs bske...@redhat.com
Date: Sat Jul 14 19:09:17 2012
Hi Christopher,
rmi_f11.c is a driver for 2D touch sensors. It has been updated to support
the MT-B specification, partition control attributes between debugfs and
sysfs,
and to use the standard bus model for loading/unloading.
Please find comments inline.
Generally, if you want this
Hi Hans, Alan, Greg,
commit 3d97ff63f8997761f12c8fbe8082996c6eeaba1a
Author: Hans de Goede hdego...@redhat.com
Date: Wed Jul 4 09:18:03 2012 +0200
usbdevfs: Use scatter-gather lists for large bulk transfers
breaks an usb programming cable over here. The problem is reported as
bulk
On Wed, Oct 10, 2012 at 10:34:59PM +0200, Peter Stuge wrote:
Hej Henrik,
Henrik Rydberg wrote:
commit 3d97ff63f8997761f12c8fbe8082996c6eeaba1a
Author: Hans de Goede hdego...@redhat.com
Date: Wed Jul 4 09:18:03 2012 +0200
usbdevfs: Use scatter-gather lists for large bulk
?
Thanks,
Henrik
From 40b70394747eea51fdd07cc8213dd6afd24b1b30 Mon Sep 17 00:00:00 2001
From: Henrik Rydberg rydb...@euromail.se
Date: Thu, 11 Oct 2012 23:27:04 +0200
Subject: [PATCH] usbdevfs: Fix broken scatter-gather transfer
The recently introduced handling of large bulk transfers
On Thu, Oct 11, 2012 at 08:50:33AM +0200, Peter Stuge wrote:
Henrik Rydberg wrote:
What is the programming cable and software that uses it?
The programmer is impact, using libusbx-1.0.14-1.
Do you know for a fact that your version calls libusb-1.0? Did you
establish this with e.g
: Henrik Rydberg rydb...@euromail.se
Date: Thu, 11 Oct 2012 23:27:04 +0200
Subject: [PATCH v2] usbdevfs: Fix broken scatter-gather transfer
The handling of large output bulk transfers is broken; the same user
page is read over and over again. Fixed with this patch.
Signed-off-by: Henrik Rydberg
Or, the large bulk transfer actually never worked in the first place.
Large input transfers certainly do, as they were part of my tests, but
I must admit my test cases seem to not include large output transfers
(my bad).
Oh right, I should change the wording to reflect that this is for
The handling of large output bulk transfers is broken; the same user
page is read over and over again. Fixed with this patch.
Cc: sta...@kernel.org
Acked-by: Peter Stuge pe...@stuge.se
Acked-by: Hans de Goede hdego...@redhat.com
Acked-by: Alan Stern st...@rowland.harvard.edu
Signed-off-by: Henrik
Hi Dmitry Torokhov wrote:
There is a demand from driver's writers to use managed devices framework
for their drivers. Unfortunately up to this moment input devices did not
provide support for managed devices and that lead to mixing two styles
of resource management which usually introduced
Hi Benjamin,
Exporting this function allows us to calculate the resolution in third
party drivers like hid-multitouch.
This patch also complete the function with additional valid axes.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
---
Nice, but please see comment below.
Hi Benjamin,
HID spec details special values for the HID field unit exponent.
Basically, the range [0x8..0xf] correspond to [-8..-1].
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
---
Standard two's complement, in other words?
drivers/hid/hid-core.c | 10 +-
Hi Benjamin,
Currently, there is no way to know the index of the current field
in the .input_mapping and .event callbacks when this field is inside
an array of HID fields.
This patch forwards this index to the input_mapping and event
callbacks.
I agree with the idea, but the function
@@ -1766,8 +1830,14 @@ EXPORT_SYMBOL(input_allocate_device);
*/
void input_free_device(struct input_dev *dev)
{
- if (dev)
+ if (dev) {
+ if (dev-devres_managed)
+ WARN_ON(devres_destroy(dev-dev.parent,
+
On Thu, Nov 08, 2012 at 03:05:29PM +0800, Alexandra Chin wrote:
Convert to MT-B because Synaptics touch devices are capable
of tracking identifiable fingers.
Signed-off-by: Alexandra Chin alexandra.c...@tw.synaptics.com
---
Changes from v5:
- Incorporated Henrik's review comments
On Mon, Nov 12, 2012 at 04:40:34PM +, Alexandra Chin wrote:
Hi Henrik,
Convert to MT-B because Synaptics touch devices are capable
of tracking identifiable fingers.
Signed-off-by: Alexandra Chin alexandra.c...@tw.synaptics.com
---
Changes from v5:
- Incorporated
Hi Benjamin,
Currently, there is no way to know the index of the current field
in the .input_mapping and .event callbacks when this field is inside
an array of HID fields.
This patch adds this index to the struct hid_usage so that this
information is available to input_mapping and event
-num_expected)
+ mt_sync_frame(td, field-hidinput-input);
+ }
}
--
1.7.11.7
Reviewed-by: Henrik Rydberg rydb...@euromail.se
Thanks,
Henrik
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
-curdata.y = value;
break;
case HID_DG_WIDTH:
td-curdata.w = value;
--
1.7.11.7
Reviewed-by: Henrik Rydberg rydb...@euromail.se
Thanks,
Henrik
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
)
+ if (quirks MT_QUIRK_VALID_IS_INRANGE)
td-curvalid = value;
break;
case HID_DG_TIPSWITCH:
--
1.7.11.7
Reviewed-by: Henrik Rydberg rydb...@euromail.se
Thanks,
Henrik
--
To unsubscribe from this list
Hi Benjamin,
this prevents a device to reuse contact id 0 several time when
sending garbage values to complete the report.
This quirk allows a device to reuse a contact id when sending garbage
inactive contacts at the end of a report.
Signed-off-by: Benjamin Tissoires
Hi Benjamin,
Win 8 specification is much more precise than the Win 7 one.
Moreover devices that need to take certification must be submitted
to Microsoft.
The result is a better protocol support and we can rely on that to
skip all the messy tests we used to do.
You could possibly start
On Wed, Nov 07, 2012 at 05:37:34PM +0100, Benjamin Tissoires wrote:
Win8 devices supporting hovering must provides InRange HID field.
provide the
The information that the finger is here but is not touching the surface
is sent to the user space through ABS_MT_DISTANCE as required by the
,
Benjamin
Reviewed-by: Henrik Rydberg rydb...@euromail.se
Thanks,
Henrik
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
Hi Benjamin,
From: Benjamin Tissoires benjamin.tissoi...@gmail.com
Date: Tue, 13 Nov 2012 15:12:17 +0100
Subject: [PATCH v4] HID: hid-multitouch: forwards MSC_TIMESTAMP
Computes the device timestamp according to the specification.
It also ensures that if the time between two events is
Hi Benjamin,
here is the third version of this patchset.
I think I included most of Henrik's comments.
Happy reviewing :)
thanks for the changes :-)
Jiri,
I am fine with the HID-specific changes (and I have sent out my Acks to
the invidivual patches).
Looks reasonable to me too
with the patch as is. Looks like we have finally arrived. :-)
Reviewed-by: Henrik Rydberg rydb...@euromail.se
Thanks,
Henrik
---
drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c | 76
+++--
1 files changed, 33 insertions(+), 43 deletions(-)
diff --git a/drivers/staging
Hi Benjamin,
Why [-1,1] here?
At first, I only used [0,1]. However, it's still the same problem with
the information being kept between the touches:
if you start an application after having touched your device, you
normally have to ask for the different per-touche states to get x, y,
@@ -98,6 +99,9 @@ struct mt_device {
bool serial_maybe; /* need to check for serial protocol */
bool curvalid; /* is the current contact valid? */
unsigned mt_flags; /* flags to pass to input-mt */
+ __s32 dev_time; /* the scan time
To conclude, we obviously have devices with a rather short wrap-around
time. However, since the normal inter-frame time is in the millisecond
range, it should not be overly restrictive to change the definition of
the minimum wraparound time from hours to seconds.
Sorry, Benjamin, you are
I just intend to force the update of the distance value at the
beginning of the touch.
This is just to send a coherent state when the finger goes in range,
and to make sure that user-space application do not rely on the
undefined value (0) whereas the kernel thought it was set to 1.
Right,
Hi Ben,
3.7-rc1 messed up the screen on my MacBookAir3,1 (nv50, 0xaf) pretty
badly. Not surprisingly,
commit 3863c9bc887e9638a9d905d55f6038641ece78d6
Author: Ben Skeggs bske...@redhat.com
Date: Sat Jul 14 19:09:17 2012 +1000
drm/nouveau/instmem: completely new implementation, as a subdev
)
I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
Patch originally written and tested by clipcarl (forums.opensuse.org).
Thanks to Ryan Bourgeois bluedrag...@gmail.com for providing the usb
device data.
Signed-off-by: Henrik Rydberg rydb...@euromail.se
---
Hi Gustavo,
I
and of varying sign.
This patch interprets the sp78 type as signed short, but keeps the
original scaling. For other types, -EINVAL is returned, since the
nature of those sensors is unknown.
Signed-off-by: Henrik Rydberg rydb...@euromail.se
---
drivers/hwmon/applesmc.c | 19 ---
1 file changed
Not all sensors in the T range are useful temperatures. This patch
creates a subset of sensors to be exported to userland, excluding the
unknown types.
Signed-off-by: Henrik Rydberg rydb...@euromail.se
---
drivers/hwmon/applesmc.c | 75 ++--
1 file
Hi Benson,
This patch introduces a driver for Cypress All Points Addressable
I2C Trackpad, including the one in the Samsung Series 5 550 Chromebook.
This device is compatible with MT protocol type B, providing identifiable
contacts.
This driver also implements firmware updating
Thanks for your great comments. You are right, it is impossible to get
correct finger tracking if both fingers are moving. However, we think it
still worth to have the firmware tracking of the fingers as they could
perform well for most one-stationary-one-moving cases. This will be good
I understand the usefulness of this functionality, but I also worry
about proliferating the number of properties for devices (there are
only 32 bits we can use, IIRC). I see four options off the top of my
head:
* Don't do anything, leave it as SEMI_MT. Obviously this would suck,
but it is
On Fri, Jul 20, 2012 at 11:14:25AM +0800, Chung-Yih Wang (王崇懿) wrote:
From our experiments, the assumption of the slowest corner is the
stationary finger is not always true. That is the major reason we want to
report the firmware data instead of semi-mt.
Oh, but that was precisely the point;
Most semi-mt drivers use the slots in a manual way, but really only
need to treat the finger count manually. With this patch, a semi-mt
driver may use the input-mt core for everything else.
Signed-off-by: Henrik Rydberg rydb...@euromail.se
---
Hi Dmitry,
an earlier version of this patch came
Hi Ivan,
Tested on Dell 7720. Works fine.
Signed-off-by: Valyushkov Ivan ktopi...@gmail.com
---
drivers/input/mouse/alps.c | 464
+---
drivers/input/mouse/alps.h |2 +
2 files changed, 443 insertions(+), 23 deletions(-)
This patch does not
Hi Nick,
The following patches are a large series of updates in functionality to the
atmel_mxt_ts touch driver. They apply cleanly to input/next.
I guess this is no longer true.
These changes address some of the same issues that appear in the patchsets
submitted by Daniel Kurtz and Peter
Hi Benson,
cyapa_check_is_operational and cyapa_create_input_dev are common to
the probe and firmware update paths. Pull those out into
cyapa_detect.
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/input/mouse/cyapa.c | 57
+++--
1
Hi Benson,
From: Daniel Kurtz djku...@chromium.org
Use the kernel request_firmware API to allow a hotplug script to load new
firmware into CYAPA device. When request_firmware is called by a driver,
the kernel creates 'loading' and 'data' sysfs entries, and generates a
firmware udev event
Hi Benjamin,
There is no need to register an input device containing no events.
This allows drivers using the quirk MULTI_INPUT to register one input
per report effectively used.
For backward compatibility, we need to add a quirk to request
this behavior.
Signed-off-by: Benjamin
Hi Benjamin,
Dual sensors devices reports pen and touch on two different reports.
Using the quirk HID_QUIRK_MULTI_INPUT allows us to create a new input
device to forward pen events.
The quirk HID_QUIRK_NO_EMPTY_INPUT avoids the creation of input devices
for the not used mouse emulation
Hi Benjamin,
This is not just cosmetics, it can help to write udev and X.org
rules.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/hid/hid-multitouch.c | 24 +++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git
Hi Jiri, Benjamin,
So the solution consists in relying inconditionaly to the quirk MULTI_INPUT
for
hid-multitouch. Before registering the input device in hid-input, we can
test if
it has been populated, and if not, then we simply don't register it. In
order to
prevent a
Hi Benson,
On Sat, Mar 16, 2013 at 1:00 PM, Henrik Rydberg rydb...@euromail.se wrote:
Userspace can initiate the firmware update procedure by copying cyapa.bin
to /lib/firmware, and then writing anything to the device sysfs attribute:
/sys/bus/i2c/devices/7-0067/update_fw
Why do you
Hi Benson,
From: Daniel Kurtz djku...@chromium.org
This same driver can be used by atmel based touchscreens and touchpads
(buttonpads). Platform data may specify a device is a touchpad
using the is_tp flag.
This will cause the driver to perform some touchpad specific
initializations,
Hi Linus, Peter,
I don't know if it's just me, but this merge window had more Uhhuh
moments than I'm used to. I stopped merging a couple of times, because
we had bugs that looked really scary, but thankfully each time people
were on them like paparazzi on Justin Bieber. Special thanks to
Hi Yinghai,
Can you get a boot log with debug memblock=debug from the last
successful commit point? Are you booting EFI or BootCamp?
Attached the dmesg log, booting from f763ad1 which is on top of
3.7-rc6. I am booting with EFI_STUB, straight into the kernel.
The command line and
Can you check bootloader like grub.efi ?
I checked, same story. I tried without EFI_STUB, no joy. I ran with
and without nouveau, just in case. Without the patch, everything
works. With the patch, nothing works, and no output at all.
With a bit of luck, I could maybe get the first
) for first step.
Please try attached patch.
Bingo. Excellent, thank you Yinghai. I verified that it also boots on
top of Linus' tree, so you may add
Tested-by: Henrik Rydberg rydb...@euromail.se
to the final result.
Cheers,
Henrik
--
To unsubscribe from this list: send the line unsubscribe
On Wed, Mar 06, 2013 at 08:08:34AM -0800, Linus Torvalds wrote:
On Wed, Mar 6, 2013 at 12:06 AM, Henrik Rydberg rydb...@euromail.se wrote:
Or not. ;-) This commit breaks boot on my MacBookAir3,1:
commit 8d57470d8f859635deffe3919d7d4867b488b85a
Author: Yinghai Lu ying...@kernel.org
On Wed, Mar 06, 2013 at 01:49:15PM -0800, H. Peter Anvin wrote:
On 03/06/2013 01:33 PM, Yinghai Lu wrote:
On Wed, Mar 6, 2013 at 12:58 PM, H. Peter Anvin h...@linux.intel.com
wrote:
Excellent. Yinghai, can you write up the patch with a proper
description and I'll put it into
Hi Benjamin,
I can think of two mechanisms that might be useful in finding a
way to achieve this cleanly: a) Let a driver return a value telling
whether to change input device, and b) Let a second driver have a go
at the same device report. Some return value or state could determine
Hi Dudley,
Another question is that new interface input_mt_assign_slots() is introduced
since 3.7-rc7 or later,
So we could not support the kernel releases that earlier than 3.7-rc7 with
this driver.
The patch is a submission to mainline, so of course it should be in sync with
mainline.
Hi Kamal,
From: Cypress Semiconductor Corporation customerc...@cypress.com
Input/mouse driver for Cypress PS/2 Trackpad.
Original code contributed by Cypress Semiconductor Corporation,
modified by Kamal Mostafa and Kyle Fazzari.
BugLink: http://launchpad.net/bugs/978807
Hi Kamal,
Patch #2 (main driver), as recommended by Henrik Rydberg[2]:
- use input_mt_assign_slots; drop cypress_cal_finger_id.
- enable 2-finger-only SEMI_MT; drop cypress_simulate_fingers.
- various code clean-ups.
Henrik, does patch #2 appear to properly use assign_slots
Hi Benson,
This patch adds support for the Cypress APA Smbus Trackpad type,
which uses a modified register map that fits within the
limitations of the smbus protocol.
Devices that use this protocol include:
CYTRA-116001-00 - Samsung Series 5 550 Chromebook trackpad
CYTRA-103002-00 - Acer
Hi Daniel,
A recent patch refactored i2c error handling in the register read/write
path. This adds similar handling to the other i2c paths used in fw_update
and bootloader state detection.
The generic i2c layer can return values indicating a partial transaction.
From the atmel_mxt
Hi Benjamin,
I think this is more useful if called before the individual fields. In
fact, it seems raw_event() is already doing exactly that. No need for
a new callback, in other words.
I'm afraid this does not work:
- calling it before the individual fields is not possible unless more
Hi Benjamin,
Why not an index here?
Just because an index is not sufficient. You need two things: an index
within the field, and the actual field (a pointer to a struct
hid_field). Each .value is local to a field, and even if in most of
the case, the contact count is alone in its field,
Hi Benjamin,
Thanks for the review. However, before sending a new patch series, I'd
like to have your answers to my comments as I mostly disagree on
everything :)
With good reason, apparently. :-) I see no major problem with your
patches, although the discussed details show that there is room
Hi Benjamin,
This callback is called when the parsing of the report has been done
by hid-core (so after the calls to .event). The hid drivers can now
have access to the whole report by relying on the values stored in
the different fields.
Signed-off-by: Benjamin Tissoires
Hi Benjamin,
This device is the worst device I saw. It keeps TipSwitch and InRange
at 1 for fingers that are not touching the panel.
The solution is to rely on the field ContactCount, which is accurate
as the correct information are packed at the begining of the frame.
Unfortunately,
Hi Benjamin,
so, this is the v2 of the support of win7/8 devices.
Looks like it is getting there, thanks.
changes since v1:
- removed the optimization patches, as the benefit was minimum
- introduce a new callback report in hid-core that drivers can use to treat
the
report by having it
Hi Benjamin,
This device is the worst device I saw. It keeps TipSwitch and InRange
at 1 for fingers that are not touching the panel.
The solution is to rely on the field ContactCount, which is accurate
as the correct information are packed at the begining of the frame.
Unfortunately,
Hi Benjamin,
Breaking out this function allows third parties hid drivers to retrieve
the data fields of a hid report in the raw_event callback.
No functional changes, only exports the function.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
---
drivers/hid/hid-core.c |
Hi Benjamin,
Relying on ALWAYS_VALID enhance a little the processing time of
the events.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
---
drivers/hid/hid-multitouch.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Is there a measurement backing up this
Hi Benjamin,
By running a test on all the traces of the devices I have,
I noticed that the class MT_CLS_ALWAYS_TRUE could handle all
the devices I've seen so far without any other quirks.
I guess this is the behavior Win 7 requires in its driver.
We can change the default class then and
Hi Benjamin,
finally, I managed to send a new bunch of patches. Sorry for the delay from
the
previous version, but meanwhile, I implemented an automatic regressions tests
for hid device [1].
So this series seems pretty big, but it does not break any known devices (I
ran
40 successful
On Wed, Feb 13, 2013 at 08:26:35PM -0800, Dmitry Torokhov wrote:
On Sun, Feb 10, 2013 at 12:15:40PM -0800, Benson Leung wrote:
This patch adds support for the Cypress APA Smbus Trackpad type,
which uses a modified register map that fits within the
limitations of the smbus protocol.
Hmm, instead of disabling fuzz completely maybe we should disable it
only on the derived axes (ABS_X/ABS_Y) for multitouch devices?
Yes, that should work... both would end up fuzzed to the same value,
for a not-so-obvious reason, IMHO :).
It's a bit tricky, and I like it, but is that
The pointer emulation events are derived from contact values that
have already been filtered, so send the emulated events as is.
Reported-by: Daniel Kurtz djku...@chromium.org
Signed-off-by: Henrik Rydberg rydb...@euromail.se
---
drivers/input/input-mt.c | 1 +
1 file changed, 1 insertion
...@chromium.org
Signed-off-by: Henrik Rydberg rydb...@euromail.se
---
Hi Daniel,
This patch has only been compile tested, but chances are that it will
work for you, together with the previous patch.
Cheers,
Henrik
drivers/input/mouse/synaptics.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
1 - 100 of 712 matches
Mail list logo
