On Tue, 10 Nov 2020 09:57:46 -0800 Randy Dunlap wrote:
> Fix kconfig warning when CONFIG_NET is not set/enabled:
>
> WARNING: unmet direct dependencies detected for SKB_EXTENSIONS
> Depends on [n]: NET [=n]
> Selected by [y]:
> - KCOV [=y] && ARCH_HAS_KCOV [=y] && (CC_HAS_SANCOV_TRACE_PC
On Thu, 12 Nov 2020 13:09:53 +0200 Lev Stipakov wrote:
> Commit d3fd65484c781 ("net: core: add dev_sw_netstats_tx_add")
> has added function "dev_sw_netstats_tx_add()" to update
> net device per-cpu TX stats.
>
> Use this function instead of ieee80211_tx_stats().
>
> Signed-off-by: Lev Stipakov
On Thu, 12 Nov 2020 16:44:54 +0100 Dmytro Shytyi wrote:
> Reported-by: kernel test robot
You don't have to add the reported by tag just because the bot pointed
out issues in the previous version.
On Wed, 11 Nov 2020 09:34:24 +0800 kernel test robot wrote:
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot
Good people of kernel test robot, could you please rephrase this to say
that the tag is only appropriate if someone is sending a fix
On Tue, 17 Nov 2020 21:06:47 +0100 Simon Horman wrote:
> On Tue, Nov 17, 2020 at 11:13:47AM -0600, Gustavo A. R. Silva wrote:
> > Fix the following unreachable code issue:
> >
> >drivers/net/ethernet/netronome/nfp/crypto/tls.c: In function
> > 'nfp_net_tls_add':
> >
On Tue, 17 Nov 2020 20:22:03 +0100 Bjørn Mork wrote:
> Filip Moc writes:
>
> > LTE module MR400 embedded in TL-MR6400 v4 requires DTR to be set.
> >
> > Signed-off-by: Filip Moc
> > ---
> > drivers/net/usb/qmi_wwan.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
On Wed, 18 Nov 2020 05:05:41 -0800 Richard Cochran wrote:
> On Tue, Nov 17, 2020 at 10:38:26PM +0100, Ahmad Fatoum wrote:
> > It's arguable most people interested in configuring a PPS signal
> > want it as external output, not as kernel input. PTP_CLK_REQ_PPS
> > is for input though. Add
On Sun, 15 Nov 2020 12:10:29 -0800 Dongli Zhang wrote:
> The ethernet driver may allocate skb (and skb->data) via napi_alloc_skb().
> This ends up to page_frag_alloc() to allocate skb->data from
> page_frag_cache->va.
>
> During the memory pressure, page_frag_cache->va may be allocated as
>
On Wed, 18 Nov 2020 16:44:11 +0530 siddhant gupta wrote:
> On Wed, 18 Nov 2020 at 15:53, Tom Parkin wrote:
> >
> > On Tue, Nov 17, 2020 at 15:22:07 +0530, Siddhant Gupta wrote:
> > > Fix Column span alignment problem warnings in the file
> > >
> >
> > Thanks for the patch, Siddhant.
> >
> >
On Wed, 18 Nov 2020 13:13:35 -0800 Andrew Morton wrote:
> On Wed, 18 Nov 2020 11:46:54 -0800 Jakub Kicinski wrote:
>
> > > 1. The kernel is under memory pressure and allocation of
> > > PAGE_FRAG_CACHE_MAX_ORDER in __page_frag_cache_refill() will fail.
> > > I
Saruhan Karademir
> Signed-off-by: Andrea Parri (Microsoft)
> Cc: "David S. Miller"
> Cc: Jakub Kicinski
> Cc: net...@vger.kernel.org
Acked-by: Jakub Kicinski
On Tue, 17 Nov 2020 17:08:24 +0900 Bongsu Jeon wrote:
> max_payload is unused.
>
> Reviewed-by: Krzysztof Kozlowski
> Signed-off-by: Bongsu Jeon
Applied all 3 to net-next, thanks!
On Wed, 18 Nov 2020 17:26:53 -0800 Guenter Roeck wrote:
> On Wed, Nov 18, 2020 at 05:01:19PM -0800, Guenter Roeck wrote:
> > On Wed, Nov 18, 2020 at 03:42:53PM -0800, Tao Ren wrote:
> > > On Thu, Nov 19, 2020 at 12:27:19AM +0100, Andrew Lunn wrote:
> > > > On Wed, Nov 18, 2020 at 03:09:27PM
On Thu, 19 Nov 2020 09:09:53 -0800 Joe Perches wrote:
> On Thu, 2020-11-19 at 17:35 +0100, Jesper Dangaard Brouer wrote:
> > On Thu, 19 Nov 2020 07:46:34 -0800 Jakub Kicinski wrote:
>
> > I think it is a good idea to change the keyword (K:), but I'm not sure
> > this c
On Thu, 19 Nov 2020 14:37:35 +0100 Dmytro Shytyi wrote:
> +struct inet6_ifaddr *ipv6_cmp_rcvd_prsnt_prfxs(struct inet6_ifaddr *ifp,
> +struct inet6_dev *in6_dev,
> +struct net *net,
> +
Fix socket refcount leak on kTLS RX resync
- net: dsa: mv88e6xxx: Avoid VLAN database corruption on 6097
- fix 21 unset return codes and other mistakes on error paths,
mostly detected by the Hulk Robot
Signed-off-by: Jakub Kicin
~
> > net/ipv6/addrconf.c:2579:21: warning: symbol 'ipv6_cmp_rcvd_prsnt_prfxs'
> was not declared. Should it be static?
> >
>
> Hideaki Yoshifuji helped to improve this patch with suggestions. @Hideaki,
> should I add "Reported-by" tag in this case?
> Jak
On Wed, 18 Nov 2020 10:20:25 -0800 Bhaumik Bhatt wrote:
> Reset MHI device channels when driver remove is called due to
> module unload or any crash scenario. This will make sure that
> MHI channels no longer remain enabled for transfers since the
> MHI stack does not take care of this anymore
On Thu, 19 Nov 2020 23:09:52 +0100 Heiner Kallweit wrote:
> Am 19.11.2020 um 22:41 schrieb Andrew Lunn:
> Doesn't checkpatch complain about line length > 80 here?
> >>>
> >>> :)
> >>>
> >>> commit bdc48fa11e46f867ea4d75fa59ee87a7f48be144
> >>> Author: Joe Perches
> >>> Date: Fri May 29
On Thu, 19 Nov 2020 10:53:47 -0800 Edwin Peer wrote:
> > Fix to return a negative error code from the error handling
> > case instead of 0, as done elsewhere in this function.
> >
> > Fixes: c213eae8d3cd ("bnxt_en: Improve VF/PF link change logic.")
> > Reported-by: Hulk Robot
> > Signed-off-by:
On Thu, 19 Nov 2020 10:53:23 -0800 Edwin Peer wrote:
> > Fix to return a negative error code from the error handling
> > case instead of 0, as done elsewhere in this function.
> >
> > Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.")
> > Reported-by: Hulk Robot
> > Signed-off-by:
On Fri, 20 Nov 2020 11:45:12 +0530 Manivannan Sadhasivam wrote:
> Jakub, can you please provide your ack so that I can take it?
Sure:
Acked-by: Jakub Kicinski
On Fri, 13 Nov 2020 00:32:55 + Li, Philip wrote:
> > Subject: [kbuild-all] Re: [PATCH net-next] net: Variable SLAAC: SLAAC with
> > prefixes of arbitrary length in PIO
> >
> > On Wed, 11 Nov 2020 09:34:24 +0800 kernel test robot wrote:
> > > If you fix the issue, kindly add following tag as
On Thu, 12 Nov 2020 17:43:56 -0800 Dave Hansen wrote:
> On 11/12/20 4:24 PM, Jakub Kicinski wrote:
> > On Wed, 11 Nov 2020 09:34:24 +0800 kernel test robot wrote:
> >> If you fix the issue, kindly add following tag as appropriate
> >> Reported-by: kernel test robot
On Thu, 12 Nov 2020 12:41:26 +0100 Bartosz Golaszewski wrote:
> On Thu, Nov 12, 2020 at 12:33 PM Zhang Changzhong
> wrote:
> >
> > Fix to return a negative error code from the error handling
> > case instead of 0, as done elsewhere in this function.
> >
> > Fixes: 8c7bd5a454ff ("net: ethernet:
On Thu, 12 Nov 2020 02:35:06 -0800 Xie He wrote:
> The x25_disconnect function in x25_subr.c would decrease the refcount of
> "x25->neighbour" (struct x25_neigh) and reset this pointer to NULL.
>
> However, the x25_rx_call_request function in af_x25.c, which is called
> when we receive a
On Thu, 12 Nov 2020 17:54:55 +0200 Ioana Ciornei wrote:
> From: Ioana Ciornei
>
> This patch set aims to actually add support for shared interrupts in
> phylib and not only for multi-PHY devices. While we are at it,
> streamline the interrupt handling in phylib.
Ioana, would you mind resending?
On Thu, 12 Nov 2020 18:49:17 -0700 David Ahern wrote:
> On 11/12/20 6:28 PM, Andrea Mayer wrote:
> > The implementation of SRv6 End.DT4 differs from the the implementation of
> > SRv6
> > End.DT6 due to the different *route input* lookup functions. For IPv6 is it
> > possible to force the routing
On Fri, 13 Nov 2020 10:04:44 -0700 David Ahern wrote:
> On 11/13/20 10:02 AM, Stefano Salsano wrote:
> > Il 2020-11-13 17:55, Jakub Kicinski ha scritto:
> >> On Thu, 12 Nov 2020 18:49:17 -0700 David Ahern wrote:
> >>> On 11/12/20 6:28 PM, Andrea Mayer wrote:
>
On Fri, 13 Nov 2020 14:25:25 +0200 Lev Stipakov wrote:
> > Seems I should take this through my tree, any objections?
Go for it, you may need to pull net-next first but that should happen
soonish anyway, when I get to your pr.
> The rest are similar changes for openvswitch and xfrm subsystems, so
On Fri, 13 Nov 2020 08:17:00 + Ioana Ciornei wrote:
> On Thu, Nov 12, 2020 at 06:19:10PM -0800, Jakub Kicinski wrote:
> > On Thu, 12 Nov 2020 17:54:55 +0200 Ioana Ciornei wrote:
> > > From: Ioana Ciornei
> > >
> > > This patch set aims to actual
On Thu, 12 Nov 2020 12:51:04 +0100 Łukasz Stelmach wrote:
> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be
> connected to a CPU with a 8/16-bit bus or with an SPI. This driver
> supports SPI connection.
>
> The driver has been ported from the vendor kernel for ARTIK5[2]
>
On Fri, 13 Nov 2020 23:25:31 +0200 Lev Stipakov wrote:
> > Since there are no dependencies between the patches here you could have
> > gone for separate patches here.
>
> Shall I re-send those 3 patches separately or can we proceed with those
> in the (sub-optimal) form they've been already
On Fri, 13 Nov 2020 11:40:36 -0800 Jakub Kicinski wrote:
> > agreed. The v6 variant has existed for a while. The v4 version is
> > independent.
>
> Okay, I'm not sure what's the right call so I asked DaveM.
DaveM raised a concern that unless we implement v6 now we can't be
On Thu, 12 Nov 2020 18:45:41 +0200 Grygorii Strashko wrote:
> From: Wang Qing
>
> We always have to update the value of ret, otherwise the
> error value may be the previous one.
>
> Fixes: f6bd59526ca5 ("net: ethernet: ti: introduce am654 common platform time
> sync driver")
> Signed-off-by:
On Sat, 14 Nov 2020 00:00:24 +0100 Andrea Mayer wrote:
> On Fri, 13 Nov 2020 13:40:10 -0800
> Jakub Kicinski wrote:
>
> > On Fri, 13 Nov 2020 11:40:36 -0800 Jakub Kicinski wrote:
> > > > agreed. The v6 variant has existed for a while. The v4 ver
On Fri, 13 Nov 2020 09:27:30 + Antoine Tenart wrote:
> Quoting Steen Hegelund (2020-11-13 10:11:16)
> > Selecting VSC8575 as a MACSec PHY was not correct
> >
> > The relevant datasheet can be found here:
> > - VSC8575: https://www.microchip.com/wwwproducts/en/VSC8575
> >
> > History:
> > v1
On Sat, 14 Nov 2020 02:50:58 +0100 Andrea Mayer wrote:
> Hi Jakub,
> Please see my responses inline:
>
> On Fri, 13 Nov 2020 15:54:37 -0800
> Jakub Kicinski wrote:
>
> > On Sat, 14 Nov 2020 00:00:24 +0100 Andrea Mayer wrote:
> > > On Fri, 13 Nov 2020 13:40:10
On Sat, 14 Nov 2020 17:38:26 +0800 Zou Wei wrote:
> This patch fixes below warning reported by coccicheck:
>
> ./drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:3284:5-8: Unneeded variable:
> "ret". Return "0" on line 3301
>
> Signed-off-by: Zou Wei
Some macro uses it implicitly, this breaks the
On Thu, 12 Nov 2020 11:33:14 +0800 Huazhong Tan wrote:
> Add a control private flag in ethtool for enable/disable
> DIM feature.
>
> Signed-off-by: Huazhong Tan
Please work on a common ethtool API for the configuration instead of
using private flags.
Private flags were overused because the old
On Wed, 11 Nov 2020 22:29:54 +0530 Anmol Karn wrote:
> rose_send_frame() dereferences `neigh->dev` when called from
> rose_transmit_clear_request(), and the first occurrence of the
> `neigh` is in rose_loopback_timer() as `rose_loopback_neigh`,
> and it is initialized in rose_add_loopback_neigh()
On Thu, 12 Nov 2020 19:23:59 +0800 Zhang Changzhong wrote:
> Add the missing clk_disable_unprepare() before return from
> smsc_phy_probe() in the error handling case.
>
> Fixes: bedd8d78aba3 ("net: phy: smsc: LAN8710/20: add phy refclk in support")
> Reported-by: Hulk Robot
> Signed-off-by:
st robot
> Cc: Aleksandr Nogikh
> Cc: Willem de Bruijn
> Cc: Jakub Kicinski
> Cc: linux-n...@vger.kernel.org
> Cc: net...@vger.kernel.org
> ---
> v2: (as suggested by Matthieu Baerts )
> drop an extraneous space in a comment;
> use CONFIG_SKB_EXTENSIONS instead of C
On Fri, 13 Nov 2020 11:36:49 -0700 Nathan Chancellor wrote:
> On Fri, Nov 13, 2020 at 02:50:12PM +0100, Lukas Bulwahn wrote:
> > Commit bdb7cc643fc9 ("ipv6: Count interface receive statistics on the
> > ingress netdev") removed all callees for ipv6_skb_idev(). Hence, since
> > then,
On Thu, 12 Nov 2020 22:49:36 +0800 YueHaibing wrote:
> Check PTR_ERR with IS_ERR to fix this.
>
> Fixes: cd5afa91f078 ("net: macb: Add null check for PCLK and HCLK")
> Signed-off-by: YueHaibing
Looks like a cleanup PTR_ERR() should return 0 for NULL AFAICS.
Applied to net-next, thanks!
On Thu, 12 Nov 2020 22:49:48 +0800 Wong Vee Khee wrote:
> Fix an issue where dump stack is printed on suspend resume flow due to
> netif_set_real_num_rx_queues() is not called with rtnl_lock held().
>
> Fixes: 686cff3d7022 ("net: stmmac: Fix incorrect location to set
> real_num_rx|tx_queues")
>
On Thu, 12 Nov 2020 13:59:49 -0500 Sven Van Asbroeck wrote:
> From: Sven Van Asbroeck
>
> When running this chip on arm imx6, we intermittently observe
> the following kernel warning in the log, especially when the
> system is under high load:
> The driver is calling dev_kfree_skb() from code
On Thu, 12 Nov 2020 15:47:41 -0500 Sven Van Asbroeck wrote:
> From: Sven Van Asbroeck
>
> On arm imx6, when opening the chip's netdev, the whole Linux
> kernel intermittently hangs/freezes.
>
> This is caused by a bug in the driver code which tests if pcie
> interrupts are working correctly,
On Fri, 13 Nov 2020 19:16:22 +0800 Wang Hai wrote:
> If sb_occ_port_pool_get() failed in devlink_nl_sb_port_pool_fill(),
> msg should be canceled by genlmsg_cancel().
>
> Fixes: df38dafd2559 ("devlink: implement shared buffer occupancy monitoring
> interface")
> Reported-by: Hulk Robot
>
On Fri, 13 Nov 2020 23:59:40 +0200 Lev Stipakov wrote:
> Commit d3fd65484c781 ("net: core: add dev_sw_netstats_tx_add") has added
> function "dev_sw_netstats_tx_add()" to update net device per-cpu TX
> stats.
>
> Use this function instead of own code.
>
> While on it, remove xfrmi_get_stats64()
On Tue, 20 Oct 2020 17:15:42 +1100 Benjamin Herrenschmidt wrote:
> On Mon, 2020-10-19 at 19:57 -0700, Jakub Kicinski wrote:
> > > I suspect the problem is that the HW (and yes this would be a HW bug)
> > > doesn't order the CPU -> memory and the CPU -> MMIO path.
> &
On Mon, 19 Oct 2020 10:26:07 -0700 t...@redhat.com wrote:
> From: Tom Rix
>
> A break is not needed if it is preceded by a return or goto
>
> Signed-off-by: Tom Rix
Applied, thanks!
On Mon, 19 Oct 2020 12:15:00 -0700 t...@redhat.com wrote:
> From: Tom Rix
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix
Applied to net, thanks!
On Tue, 20 Oct 2020 15:23:16 +0800 Xiaoliang Yang wrote:
> This patch series add gate and police action for tc flower offload to
> support Per-Stream Filtering and Policing(PSFP), which is defined in
> IEEE802.1Qci.
>
> There is also a TC flower offload to set up VCAPs on ocelot driver.
> Because
On Tue, 20 Oct 2020 07:45:09 -0400 Michael S. Tsirkin wrote:
> On Mon, Oct 19, 2020 at 12:15:00PM -0700, Jakub Kicinski wrote:
> > On Mon, 19 Oct 2020 13:32:12 -0400 Michael S. Tsirkin wrote:
> > > This reverts commit 3618ad2a7c0e78e4258386394d5d5f92a3dbccf8.
> > >
On Mon, 19 Oct 2020 18:23:14 +0800 Geliang Tang wrote:
> This patchset deals with initializations of mptcp_options_received's two
> fields, ahmac and port.
Applied, but two extra comments:
- please make sure the commit messages are in imperative form
e.g. "Initialize x..." rather than "This
On Mon, 19 Oct 2020 17:47:20 +0200 Matthieu Baerts wrote:
> On 19/10/2020 13:32, Geert Uytterhoeven wrote:
> > MPTCP_KUNIT_TESTS selects MPTCP, thus enabling an optional feature the
> > user may not want to enable. Fix this by making the test depend on
> > MPTCP instead.
>
> Reviewed-by:
On Mon, 19 Oct 2020 19:38:58 +0800 Defang Bo wrote:
> check that the NFC_ATTR_FIRMWARE_NAME attributes are provided by the netlink
> client prior to accessing them.This prevents potential unhandled NULL pointer
> dereference exceptions which can be triggered by malicious user-mode
> programs, if
On Tue, 20 Oct 2020 00:19:16 +0300 Vladimir Oltean wrote:
> On Mon, Oct 19, 2020 at 02:03:40PM -0700, Florian Fainelli wrote:
> > > Completely crazy and outlandish idea, I know, but what's wrong with
> > > doing this in DSA?
> >
> > I really do not have a problem with that approach however
On Mon, 19 Oct 2020 11:10:59 -0700 Randy Dunlap wrote:
> Fix build errors when TLS=m, TLS_TOE=y, and CRYPTO_DEV_CHELSIO_TLS=y.
>
> Having (tristate) CRYPTO_DEV_CHELSIO_TLS depend on (bool) TLS_TOE
> is not strong enough to prevent the bad combination of TLS=m and
> CRYPTO_DEV_CHELSIO_TLS=y, so
On Tue, 20 Oct 2020 11:26:34 +0200 Matthieu Baerts wrote:
> On 20/10/2020 09:38, Geert Uytterhoeven wrote:
> > MPTCP_IPV6 selects IPV6, thus enabling an optional feature the user may
> > not want to enable. Fix this by making MPTCP_IPV6 depend on IPV6, like
> > is done for all other IPv6
On Tue, 20 Oct 2020 09:51:39 -0700 Florian Fainelli wrote:
> On 10/20/20 9:50 AM, Colin King wrote:
> > From: Colin Ian King
> >
> > Don't populate the const array rate_table on the stack but instead it
> > static. Makes the object code smaller by 46 bytes.
> >
> > Before:
> >text
On Wed, 21 Oct 2020 12:51:53 +0200 Matthieu Baerts wrote:
> Like TCP, MPTCP cannot be compiled as a module. Obviously, MPTCP IPv6'
> support also depends on CONFIG_IPV6. But not all functions from IPv6
> code are exported.
>
> To simplify the code and reduce modifications outside MPTCP, it was
>
On Wed, 21 Oct 2020 15:38:09 +0800 Defang Bo wrote:
> Similar to commit<1b0ff89852d7>("tg3: Avoid NULL pointer dereference in
> tg3_io_error_detected()")
> This patch avoids NULL pointer dereference add a check for netdev being NULL
> on tg3_resume().
>
> Signed-off-by: Defang Bo
Are you
On Wed, 21 Oct 2020 22:25:48 +0200 Thomas Gleixner wrote:
> On Tue, Oct 20 2020 at 20:07, Thomas Gleixner wrote:
> > On Tue, Oct 20 2020 at 12:18, Nitesh Narayan Lal wrote:
> >> However, IMHO we would still need a logic to prevent the devices from
> >> creating excess vectors.
> >
> > Managed
On Mon, 19 Oct 2020 18:31:52 -0700 Xie He wrote:
> The hdlc_rcv function is used as hdlc_packet_type.func to process any
> skb received in the kernel with skb->protocol == htons(ETH_P_HDLC).
> The purpose of this function is to provide second-stage processing for
> skbs not assigned a "real" L3
On Mon, 19 Oct 2020 23:34:20 -0700 Xie He wrote:
> This driver calls ether_setup to set up the network device.
> The ether_setup function would add the IFF_TX_SKB_SHARING flag to the
> device. This flag indicates that it is safe to transmit shared skbs to
> the device.
>
> However, this is not
On Tue, 20 Oct 2020 09:35:15 +0200 Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski
>
> The driver depends on mmio regmap API but doesn't select the appropriate
> Kconfig option. This fixes it.
>
> Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
> Cc:
No need, we queue
On Wed, 21 Oct 2020 10:30:43 -0400 Michael S. Tsirkin wrote:
> This reverts commit 3618ad2a7c0e78e4258386394d5d5f92a3dbccf8.
>
> When control vq is not negotiated, that commit causes a crash:
>
> [ 72.229171] kernel BUG at drivers/net/virtio_net.c:1667!
Applied, thank you!
On Wed, 21 Oct 2020 17:35:32 -0700 (PDT) Mat Martineau wrote:
> > Recently, CONFIG_MPTCP_IPV6 no longer selects CONFIG_IPV6. As a
> > consequence, if CONFIG_MPTCP_IPV6=y is added to the kconfig, it will no
> > longer ensure CONFIG_IPV6=y. If it is not enabled, CONFIG_MPTCP_IPV6
> > will stay
On Thu, 22 Oct 2020 00:46:38 -0700 Xie He wrote:
> It was very hard for me to attempt fixing. There are too many drivers
> that need to be fixed. Fixing them is very time-consuming and may also
> be error-prone. So I think it may be better to just remove
> IFF_TX_SKB_SHARING from ether_setup.
On Thu, 22 Oct 2020 13:42:33 +0800 Dinghao Liu wrote:
> When rtnl_configure_link() fails, peer needs to be
> freed just like when register_netdevice() fails.
>
> Signed-off-by: Dinghao Liu
Can you see this leak or are you just sending this based on your
reading of the code?
netdev should be
On Wed, 21 Oct 2020 13:20:16 +0200 Oliver Hartkopp wrote:
> On 21.10.20 07:21, Dinghao Liu wrote:
> > When rtnl_configure_link() fails, peer needs to be
> > freed just like when register_netdevice() fails.
> >
> > Signed-off-by: Dinghao Liu
>
> Acked-by: Oliver Hartkopp
>
> Btw. as the
On Mon, 26 Oct 2020 09:34:35 +0800 Yi Li wrote:
> Trivial fix to use func skb_is_gso in place of
> test for skb_shinfo(skb)->gso_size.
>
> Signed-off-by: Yi Li
So you gave up on all the drivers now?
Please replace the word "fix" in the commit message with "refactoring",
the resulting code is
On Mon, 26 Oct 2020 11:01:12 +0100 Stefano Garzarella wrote:
> On Mon, Oct 26, 2020 at 09:46:17AM +, David Laight wrote:
> >From: Stefano Garzarella
> >> Sent: 26 October 2020 09:39
> >>
> >> On Mon, Oct 26, 2020 at 09:13:23AM +, David Laight wrote:
> >> >From: Stefano Garzarella
>
On Tue, 27 Oct 2020 01:38:04 +0800 Xu Yilun wrote:
> > > The line/host side Ether Group is not the terminal of the network data
> > > stream.
> > > Eth1 will not paticipate in the network data exchange to host.
> > >
> > > The main purposes for eth1 are:
> > > 1. For users to monitor the network
On Mon, 26 Oct 2020 19:24:57 +0100 Stefano Garzarella wrote:
> @Colin, can you send a v2 removing the error message and updating the
> return value?
Not as a single patch, please, these are two different changes.
On Mon, 26 Oct 2020 16:22:27 +0900 Masahiro Fujiwara wrote:
> v2:
> - leave out_hashtable: label for clarity (Jakub).
> - fix code and comment styles.
Thanks!
> diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c
> index 8e47d0112e5d..07cb6d9495e8 100644
> --- a/drivers/net/gtp.c
> +++
On Mon, 26 Oct 2020 11:42:21 +0100 Michal Suchanek wrote:
> From: Thomas Bogendoerfer
>
> The check for src mac address in ibmveth_is_packet_unsupported is wrong.
> Commit 6f2275433a2f wanted to shut down messages for loopback packets,
> but now suppresses bridged frames, which are accepted by
On Mon, 26 Oct 2020 22:50:45 +0100 Thomas Gleixner wrote:
> On Mon, Oct 26 2020 at 14:11, Jacob Keller wrote:
> > On 10/26/2020 1:11 PM, Thomas Gleixner wrote:
> >> On Mon, Oct 26 2020 at 12:21, Jacob Keller wrote:
> >>> Are there drivers which use more than one interrupt per queue? I know
>
On Mon, 26 Oct 2020 07:38:46 -0600 Jeffrey Hugo wrote:
> On 10/25/2020 3:46 PM, Jakub Kicinski wrote:
> > On Fri, 23 Oct 2020 16:17:54 -0700 Hemant Kumar wrote:
> >> +UCI driver enables userspace clients to communicate to external MHI
> >> devices
> >> +l
On Fri, 23 Oct 2020 15:01:14 +0800 Zenghui Yu wrote:
> On 2020/10/23 14:22, Yunsheng Lin wrote:
> > On 2020/10/23 13:15, Zenghui Yu wrote:
> >> When unbinding the hns3 driver with the HNS3 VF, I got the following
> >> kernel panic:
> >>
> >> [ 265.709989] Unable to handle kernel paging request
On Fri, 23 Oct 2020 14:22:12 +0300 Dan Carpenter wrote:
> Smatch complains that "ret" might be uninitialized if we don't enter
> the loop. We do always enter the loop so it's a false positive, but
> it's cleaner to just return a literal zero and that silences the
> warning as well.
>
>
On Tue, 27 Oct 2020 07:37:37 +1100 (AEDT) James Morris wrote:
> On Fri, 23 Oct 2020, Jeff Vander Stoep wrote:
>
> > During __vsock_create() CAP_NET_ADMIN is used to determine if the
> > vsock_sock->trusted should be set to true. This value is used later
> > for determing if a remote connection
On Tue, 27 Oct 2020 09:24:10 +0800 Yunsheng Lin wrote:
> > Fixes: 862d969a3a4d ("net: hns3: do VF's pci re-initialization while PF
> > doing FLR")
>
> The correct Fixes tag should be:
>
> Fixes: e3338205f0c7 ("net: hns3: uninitialize pci in the hclgevf_uninit")
Why is that?
Isn't the issue
On Mon, 26 Oct 2020 10:47:38 +0100 Mauro Carvalho Chehab wrote:
> Some identifiers have different names between their prototypes
> and the kernel-doc markup.
>
> In the specific case of netif_subqueue_stopped(), keep the
> current markup for __netif_subqueue_stopped(), adding a
> new one for
On Tue, 27 Oct 2020 09:42:01 +0800 Yunsheng Lin wrote:
> On 2020/10/27 9:25, Jakub Kicinski wrote:
> > On Tue, 27 Oct 2020 09:24:10 +0800 Yunsheng Lin wrote:
> >>> Fixes: 862d969a3a4d ("net: hns3: do VF's pci re-initialization while PF
> >>> doing FLR
On Thu, 29 Oct 2020 20:07:57 +0800 Willy Liu wrote:
> Realtek single-port 2.5Gbps Ethernet PHY ids as below:
> RTL8226-CG: 0x001cc800(ES)/0x001cc838(MP)
> RTL8226B-CG/RTL8221B-CG: 0x001cc840(ES)/0x001cc848(MP)
> ES: engineer sample
> MP: mass production
>
> Since above PHYs are already in mass
On Thu, 29 Oct 2020 13:34:45 +0100 Andrew Lunn wrote:
> On Thu, Oct 29, 2020 at 10:33:52AM +0800, Zou Wei wrote:
> > Fix the following coccinelle report:
> >
> > ./drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:233:6-8:
> > WARNING: possible condition with no effect (if == else)
> >
> >
On Tue, 27 Oct 2020 09:09:40 + Colin King wrote:
> From: Colin Ian King
>
> Two minor changes to the ioctl error handling.
Applied, thanks!
On Tue, 27 Oct 2020 12:43:17 +0100 Łukasz Stelmach wrote:
> Unify the set of information returned by mii_ethtool_get_link_ksettings(),
> mii_ethtool_gset() and phy_ethtool_ksettings_get(). Make the mii_*()
> functions report advertised settings when autonegotiation if disabled.
>
> Suggested-by:
On Tue, 27 Oct 2020 10:02:41 + Henrik Bjoernlund wrote:
> Connectivity Fault Management (CFM) is defined in 802.1Q
> section 12.14.
>
> Connectivity Fault Management (CFM) comprises capabilities for
> detecting, verifying, and isolating connectivity failures in Virtual
> Bridged Networks.
On Fri, 30 Oct 2020 13:56:20 +0800 Willy Liu wrote:
> diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
> old mode 100644
> new mode 100755
> index fb1db71..2ba0d73
checkpatch says:
ERROR: do not set execute permissions for source files
#23: FILE: drivers/net/phy/realtek.c
On Fri, 30 Oct 2020 13:22:31 +0100 gregkh wrote:
> On Thu, Oct 29, 2020 at 10:06:14PM +0100, Arnd Bergmann wrote:
> > The following changes since commit 3650b228f83adda7e5ee532e2b90429c03f7b9ec:
> >
> > Linux 5.10-rc1 (2020-10-25 15:14:11 -0700)
> >
> > are available in the Git repository at:
On Thu, 29 Oct 2020 17:32:28 +0800 Wong Vee Khee wrote:
> The commit "stmmac: intel: Adding ref clock 1us tic for LPI cntr"
> introduced a regression which leads to the kernel panic duing loading
> of the dwmac_intel module.
>
> Move the code block after pci resources is obtained.
>
> Fixes:
On Wed, 28 Oct 2020 00:00:51 +0800 Voon Weifeng wrote:
> From: "Vineetha G. Jaya Kumaran"
>
> This patch enables the HW LPI Timer which controls the automatic entry
> and exit of the LPI state.
> The EEE LPI timer value is configured through ethtool. The driver will
> auto select the LPI HW
On Wed, 28 Oct 2020 12:53:49 +0100 Lukas Bulwahn wrote:
> Commit 931ca7ab7fe8 ("ip*_mc_gsfget(): lift copyout of struct group_filter
> into callers") adjusted the type annotations for ip6_mc_msfget() at its
> declaration, but missed the type annotations at its definition.
>
> Hence, sparse
On Wed, 28 Oct 2020 12:35:33 +0100 Lukas Bulwahn wrote:
> make clang-analyzer on x86_64 defconfig caught my attention with:
>
> net/sched/cls_api.c:2964:3: warning: Value stored to 'parent' is never read
> [clang-analyzer-deadcode.DeadStores]
> parent = 0;
> ^
>
On Thu, 29 Oct 2020 14:09:23 +0100 Andrew Lunn wrote:
> On Thu, Oct 29, 2020 at 03:25:25PM +0530, Bhaskar Chowdhury wrote:
> > Fixed spelling in comment like below:
> >
> > s/defalut/default/p
> >
> > This is in linux-next.
> >
> > Signed-off-by: Bhaskar Chowdhury
>
> Reviewed-by: Andrew
On Fri, 30 Oct 2020 13:55:32 -0400 min.li...@renesas.com wrote:
> From: Min Li
>
> Add idt82p33_adjwritephase() to support PHC write phase mode.
>
> Signed-off-by: Min Li
Doesn't build on 32bit.
make[2]: *** Deleting file 'Module.symvers'
ERROR: modpost: "__divdi3"
701 - 800 of 2080 matches
Mail list logo
