[PATCH v2] staging: lustre: obdclass: change object lookup to no wait mode

049 Reviewed-on: https://review.whamcloud.com/26965 Reviewed-by: Alex Zhuravlev <alexey.zhurav...@intel.com> Tested-by: Cliff White <cliff.wh...@intel.com> Reviewed-by: Fan Yong <fan.y...@intel.com> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> Signed-off-by: James Simmons &l

[PATCH v2] staging: lustre: obdclass: change object lookup to no wait mode

-by: Alex Zhuravlev Tested-by: Cliff White Reviewed-by: Fan Yong Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- Changelog: v1) Initial patch that didn't apply to staging-testing branch v2) Rebased after Neil's patches landed. Remove unlikely() test as requested by Dan Carpenter

Re: [PATCH 4/4] staging: lustre: obdclass: change object lookup to no wait mode

> >> On Wed, May 02 2018, James Simmons wrote: > >> > >> > From: Lai Siyao <lai.si...@intel.com> > >> > > >> > Currently we set LU_OBJECT_HEARD_BANSHEE on object when we want > >> > to remove object from cache, but this ma

Re: [PATCH 4/4] staging: lustre: obdclass: change object lookup to no wait mode

> >> On Wed, May 02 2018, James Simmons wrote: > >> > >> > From: Lai Siyao > >> > > >> > Currently we set LU_OBJECT_HEARD_BANSHEE on object when we want > >> > to remove object from cache, but this may lead to deadlock, beca

Re: [PATCH 4/4] staging: lustre: obdclass: change object lookup to no wait mode

> On Wed, May 02 2018, James Simmons wrote: > > > From: Lai Siyao <lai.si...@intel.com> > > > > Currently we set LU_OBJECT_HEARD_BANSHEE on object when we want > > to remove object from cache, but this may lead to deadlock, because > > when other pr

Re: [PATCH 4/4] staging: lustre: obdclass: change object lookup to no wait mode

> On Wed, May 02 2018, James Simmons wrote: > > > From: Lai Siyao > > > > Currently we set LU_OBJECT_HEARD_BANSHEE on object when we want > > to remove object from cache, but this may lead to deadlock, because > > when other process lookup such object, it nee

[PATCH 3/4] staging: lustre: obdclass: guarantee all keys filled

n <oleg.dro...@intel.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lustre/obdclass/lu_object.c | 29 +++--- 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/lu_object.c b/dr

[PATCH 3/4] staging: lustre: obdclass: guarantee all keys filled

Reviewed-by: Patrick Farrell Reviewed-by: Jinshan Xiong Reviewed-by: Mike Pershin Reviewed-by: Fan Yong Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/obdclass/lu_object.c | 29 +++--- 1 file changed, 25 insertions(+), 4 deletions(-) diff

[PATCH 2/4] staging: lustre: obdclass: hoist locking in lu_context_exit()

oud.com/24217 Reviewed-by: Dmitry Eremin <dmitry.ere...@intel.com> Reviewed-by: Jinshan Xiong <jinshan.xi...@gmail.com> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lustre/obdclass/lu_object.c |

[PATCH 1/4] staging: lustre: obdclass: change spinlock of key to rwlock

Reviewed-on: http://review.whamcloud.com/15558 Reviewed-by: Faccini Bruno <bruno.facc...@intel.com> Reviewed-by: James Simmons <uja.o...@yahoo.com> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/stagi

[PATCH 1/4] staging: lustre: obdclass: change spinlock of key to rwlock

Reviewed-by: James Simmons Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/obdclass/lu_object.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/lu_object.c b/drivers/staging

[PATCH 2/4] staging: lustre: obdclass: hoist locking in lu_context_exit()

Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/obdclass/lu_object.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/lu_object.c b/drivers/staging/lustre/lustre/obdclass/lu_obje

[PATCH 4/4] staging: lustre: obdclass: change object lookup to no wait mode

049 Reviewed-on: https://review.whamcloud.com/26965 Reviewed-by: Alex Zhuravlev <alexey.zhurav...@intel.com> Tested-by: Cliff White <cliff.wh...@intel.com> Reviewed-by: Fan Yong <fan.y...@intel.com> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> Signed-off-by: James Simmons &

[PATCH 4/4] staging: lustre: obdclass: change object lookup to no wait mode

-by: Alex Zhuravlev Tested-by: Cliff White Reviewed-by: Fan Yong Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/include/lu_object.h | 2 +- drivers/staging/lustre/lustre/obdclass/lu_object.c | 82 +- 2 files changed, 36 insertions

[PATCH 0/4] staging: lustre: obdclass: missing lu_object fixes

With the work going for lu_object by Neil I noticed him solving the same problem as the Intel developers in a very similar approach. Also with the changes we don't want to lose these important changes. This is more mean for a basic review since in the end Neil and this work will be combined in

[PATCH 0/4] staging: lustre: obdclass: missing lu_object fixes

With the work going for lu_object by Neil I noticed him solving the same problem as the Intel developers in a very similar approach. Also with the changes we don't want to lose these important changes. This is more mean for a basic review since in the end Neil and this work will be combined in

Re: [lustre-devel] [PATCH 04/10] staging: lustre: lu_object: move retry logic inside htable_lookup

> On Apr 30, 2018, at 21:52, NeilBrown wrote: > > > > The current retry logic, to wait when a 'dying' object is found, > > spans multiple functions. The process is attached to a waitqueue > > and set TASK_UNINTERRUPTIBLE in htable_lookup, and this status > > is passed back

Re: [lustre-devel] [PATCH 04/10] staging: lustre: lu_object: move retry logic inside htable_lookup

> On Apr 30, 2018, at 21:52, NeilBrown wrote: > > > > The current retry logic, to wait when a 'dying' object is found, > > spans multiple functions. The process is attached to a waitqueue > > and set TASK_UNINTERRUPTIBLE in htable_lookup, and this status > > is passed back through

Re: [PATCH 09/10] staging: lustre: move remaining code from linux-module.c to module.c

> There is no longer any need to keep this code separate, > and now we can remove linux-module.c > > Signed-off-by: NeilBrown <ne...@suse.com> Reviewed-by: James Simmons <jsimm...@infradead.org> > --- > .../staging/lustre/include/linux/libcfs/libcfs.h |4

Re: [PATCH 09/10] staging: lustre: move remaining code from linux-module.c to module.c

> There is no longer any need to keep this code separate, > and now we can remove linux-module.c > > Signed-off-by: NeilBrown Reviewed-by: James Simmons > --- > .../staging/lustre/include/linux/libcfs/libcfs.h |4 > drivers/staging/lustre/lnet/libcfs/M

Re: [PATCH 08/10] staging: lustre: move misc-device registration closer to related code.

> The ioctl handler for the misc device is in lnet/libcfs/module.c > but is it registered in lnet/libcfs/linux/linux-module.c. > > Keeping related code together make maintenance easier, so move the > code. > > Signed-off-by: NeilBrown <ne...@suse.com> Review

Re: [PATCH 08/10] staging: lustre: move misc-device registration closer to related code.

> The ioctl handler for the misc device is in lnet/libcfs/module.c > but is it registered in lnet/libcfs/linux/linux-module.c. > > Keeping related code together make maintenance easier, so move the > code. > > Signed-off-by: NeilBrown Reviewed-by: James Simmons > -

Re: [PATCH 01/10] staging: lustre: ldlm: store name directly in namespace.

> Rather than storing the name of a namespace in the > hash table, store it directly in the namespace. > This will allow the hashtable to be changed to use > rhashtable. > > Signed-off-by: NeilBrown <ne...@suse.com> Reviewed-by: James Simmons <jsimm...@infradead.org

Re: [PATCH 01/10] staging: lustre: ldlm: store name directly in namespace.

> Rather than storing the name of a namespace in the > hash table, store it directly in the namespace. > This will allow the hashtable to be changed to use > rhashtable. > > Signed-off-by: NeilBrown Reviewed-by: James Simmons > --- > drivers/staging/lustre/lustre/inc

Re: [lustre_init] BUG: unable to handle kernel NULL pointer dereference at 0000000000000004

> Hello, > > FYI this happens in mainline kernel 4.17.0-rc3. > It looks like a new regression since v4.17-rc1. > > It occurs in 2 out of 2 boots. > > [ 54.222599] Magic number: 14:276:994 > [ 54.223261] tty ttyd7: hash matches > [ 54.223841] tty ttyaa: hash matches > [ 54.227288]

Re: [lustre_init] BUG: unable to handle kernel NULL pointer dereference at 0000000000000004

> Hello, > > FYI this happens in mainline kernel 4.17.0-rc3. > It looks like a new regression since v4.17-rc1. > > It occurs in 2 out of 2 boots. > > [ 54.222599] Magic number: 14:276:994 > [ 54.223261] tty ttyd7: hash matches > [ 54.223841] tty ttyaa: hash matches > [ 54.227288]

Re: [PATCH 10/10] staging: lustre: fix error deref in ll_splice_alias().

ank you. Reviewed-by: James Simmons <jsimm...@infradead.org> > Reported-by: James Simmons <jsimm...@infradead.org> > Fixes: e9d4f0b9f559 ("staging: lustre: llite: use d_splice_alias for > directories.") > Signed-off-by: NeilBrown <ne...@suse.com> &

Re: [PATCH 10/10] staging: lustre: fix error deref in ll_splice_alias().

ank you. Reviewed-by: James Simmons > Reported-by: James Simmons > Fixes: e9d4f0b9f559 ("staging: lustre: llite: use d_splice_alias for > directories.") > Signed-off-by: NeilBrown > --- > drivers/staging/lustre/lustre/llite/namei.c |8 ++-- > 1 file changed

Re: [PATCH 02/10] staging: lustre: make struct lu_site_bkt_data private

> This data structure only needs to be public so that > various modules can access a wait queue to wait for object > destruction. > If we provide a function to get the wait queue, rather than the > whole bucket, the structure can be made private. > > Signed-off-by: NeilBrown >

Re: [PATCH 02/10] staging: lustre: make struct lu_site_bkt_data private

> This data structure only needs to be public so that > various modules can access a wait queue to wait for object > destruction. > If we provide a function to get the wait queue, rather than the > whole bucket, the structure can be made private. > > Signed-off-by: NeilBrown > --- >

Re: [cfs_trace_lock_tcd] BUG: unable to handle kernel NULL pointer dereference at 00000050

> Hello, > > FYI this happens in mainline kernel 4.17.0-rc1. > It looks like a new regression. > > [7.587002] lnet_selftest_init+0x2c4/0x5d9: > lnet_selftest_init at > drivers/staging/lustre/lnet/selftest/module.c:134 > [7.587002] ?

Re: [cfs_trace_lock_tcd] BUG: unable to handle kernel NULL pointer dereference at 00000050

> Hello, > > FYI this happens in mainline kernel 4.17.0-rc1. > It looks like a new regression. > > [7.587002] lnet_selftest_init+0x2c4/0x5d9: > lnet_selftest_init at > drivers/staging/lustre/lnet/selftest/module.c:134 > [7.587002] ?

Re: [PATCH 00/20] staging: lustre: convert to rhashtable

> libcfs in lustre has a resizeable hashtable. > Linux already has a resizeable hashtable, rhashtable, which is better > is most metrics. See https://lwn.net/Articles/751374/ in a few days > for an introduction to rhashtable. Thansk for starting this work. I was think about cleaning the libcfs

Re: [PATCH 00/20] staging: lustre: convert to rhashtable

> libcfs in lustre has a resizeable hashtable. > Linux already has a resizeable hashtable, rhashtable, which is better > is most metrics. See https://lwn.net/Articles/751374/ in a few days > for an introduction to rhashtable. Thansk for starting this work. I was think about cleaning the libcfs

Re: [lustre-devel] [PATCH 1/6] staging: lustre: move stack-check macros to libcfs_debug.h

a period where both debugging infrastructurs will exist and some deployers of lustre will want to turn off the old debugging infrastructure and just use the new. That is what I have in mind. A switch to flip between options. > - Patrick > > On 4/15/18, 10:49 PM, "lustre-devel on behalf

Re: [lustre-devel] [PATCH 1/6] staging: lustre: move stack-check macros to libcfs_debug.h

a period where both debugging infrastructurs will exist and some deployers of lustre will want to turn off the old debugging infrastructure and just use the new. That is what I have in mind. A switch to flip between options. > - Patrick > > On 4/15/18, 10:49 PM, "lustre-devel on

[PATCH 05/25] staging: lustre: libcfs: remove excess space

hamcloud.com/18916 Reviewed-by: Olaf Weber <o...@sgi.com> Reviewed-by: Doug Oucharek <dou...@me.com> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c | 2 +- 1 file

[PATCH 02/22] staging: lustre: obd: create it_has_reply_body()

Gryaznova <elena.gryazn...@seagate.com> Reviewed-by: John L. Hammond <john.hamm...@intel.com> Reviewed-by: Lai Siyao <lai.si...@intel.com> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/l

[PATCH 05/25] staging: lustre: libcfs: remove excess space

Oucharek Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c b/drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c

[PATCH 02/22] staging: lustre: obd: create it_has_reply_body()

Seagate-bug-id: MRP-3072 MRP-3137 Reviewed-on: http://review.whamcloud.com/17220 Reviewed-by: Andrew Perepechko Reviewed-by: Andriy Skulysh Tested-by: Elena V. Gryaznova Reviewed-by: John L. Hammond Reviewed-by: Lai Siyao Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging

[PATCH 04/22] staging: lustre: ldlm: xattr locks are lost on mdt

m> Tested-by: Elena V. Gryaznova <elena.gryazn...@seagate.com> Reviewed-by: John L. Hammond <john.hamm...@intel.com> Reviewed-by: Lai Siyao <lai.si...@intel.com> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> Signed-off-by: James Simmons <jsimm...@infradead.org> ---

[PATCH 01/22] staging: lustre: llite: initialize xattr->xe_namelen

ng statement to really report the xattr name instead of its length which wasn't event being set. Fixes: b3dd8957c23a ("staging: lustre: lustre: llite: Use kstrdup" Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lustre/llite/xattr_cache.c | 6 --

[PATCH 00/22] staging: lustre: llite: fix xattr handling

From: James Simmons <uja.o...@yahoo.com> Lustre utilities and user land APIs heavly depend on special xattr handling. Sadly much of the xattr handling for lustre client has been broken for awhile. This is all the fixes needed to make xattr handling work properly with the latest kernels. Bo

[PATCH 04/22] staging: lustre: ldlm: xattr locks are lost on mdt

://jira.hpdd.intel.com/browse/LU-7433 Seagate-bug-id: MRP-3072 MRP-3137 Reviewed-on: http://review.whamcloud.com/17220 Reviewed-by: Andrew Perepechko Reviewed-by: Andriy Skulysh Tested-by: Elena V. Gryaznova Reviewed-by: John L. Hammond Reviewed-by: Lai Siyao Reviewed-by: Oleg Drokin Signed-off-by: James Simmons

[PATCH 01/22] staging: lustre: llite: initialize xattr->xe_namelen

ng statement to really report the xattr name instead of its length which wasn't event being set. Fixes: b3dd8957c23a ("staging: lustre: lustre: llite: Use kstrdup" Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/llite/xattr_cache.c | 6 -- 1 file changed, 4 insertions(+)

[PATCH 00/22] staging: lustre: llite: fix xattr handling

From: James Simmons Lustre utilities and user land APIs heavly depend on special xattr handling. Sadly much of the xattr handling for lustre client has been broken for awhile. This is all the fixes needed to make xattr handling work properly with the latest kernels. Bobi Jam (3): staging

[PATCH 07/22] staging: lustre: llite: refactor lustre.lov xattr handling

.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8998 Reviewed-on: https://review.whamcloud.com/24851 Reviewed-by: Andreas Dilger <andreas.dil...@intel.com> Reviewed-by: Lai Siyao <lai.si...@intel.com> Reviewed-by: Jinshan Xiong <jinshan.xi...@gmail.com> Signed-off-by: J

[PATCH 05/22] staging: lustre: llite: handle xattr cache refill race

l.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-10132 Reviewed-on: https://review.whamcloud.com/29654 Reviewed-by: Andreas Dilger <andreas.dil...@intel.com> Reviewed-by: Lai Siyao <lai.si...@intel.com> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> Signed-off-b

[PATCH 07/22] staging: lustre: llite: refactor lustre.lov xattr handling

-on: https://review.whamcloud.com/24851 Reviewed-by: Andreas Dilger Reviewed-by: Lai Siyao Reviewed-by: Jinshan Xiong Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/llite/xattr.c | 131 +++- 1 file changed, 69 insertions(+), 62 deletions(-) diff --git a/drivers

[PATCH 05/22] staging: lustre: llite: handle xattr cache refill race

e/LU-10132 Reviewed-on: https://review.whamcloud.com/29654 Reviewed-by: Andreas Dilger Reviewed-by: Lai Siyao Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/llite/xattr_cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/stag

[PATCH 10/22] staging: lustre: llite: return from ll_adjust_lum() if lump is NULL

d-by: Dmitry Eremin <dmitry.ere...@intel.com> Reviewed-by: Niu Yawei <yawei@intel.com> Reviewed-by: James Simmons <uja.o...@yahoo.com> Reviewed-by: Andreas Dilger <andreas.dil...@intel.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/

[PATCH 03/22] staging: lustre: obd: change debug reporting in lmv_enqueue()

by: John L. Hammond <john.hamm...@intel.com> Reviewed-by: Lai Siyao <lai.si...@intel.com> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lustre/lmv/lmv_obd.c | 7 +++ 1 file changed, 3 inser

[PATCH 10/22] staging: lustre: llite: return from ll_adjust_lum() if lump is NULL

-by: James Simmons Reviewed-by: Andreas Dilger Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/llite/xattr.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/xattr.c b/drivers/staging/lustre/lustre/llite/xattr.c index

[PATCH 03/22] staging: lustre: obd: change debug reporting in lmv_enqueue()

://review.whamcloud.com/17220 Reviewed-by: Andrew Perepechko Reviewed-by: Andriy Skulysh Tested-by: Elena V. Gryaznova Reviewed-by: John L. Hammond Reviewed-by: Lai Siyao Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/lmv/lmv_obd.c | 7 +++ 1 file changed

[PATCH 06/22] staging: lustre: llite: Remove filtering of seclabel xattr

hamcloud.com/27292 Reviewed-by: John L. Hammond <john.hamm...@intel.com> Reviewed-by: Sebastien Buisson <sbuis...@ddn.com> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lustre/llite/xatt

[PATCH 09/22] staging: lustre: llite: break up ll_setstripe_ea function

ug-id: https://jira.hpdd.intel.com/browse/LU-9484 Reviewed-on: https://review.whamcloud.com/27126 Reviewed-by: Dmitry Eremin <dmitry.ere...@intel.com> Reviewed-by: Niu Yawei <yawei@intel.com> Reviewed-by: James Simmons <uja.o...@yahoo.com> Reviewed-by: Andreas Dilger <andreas.dil...@intel.

[PATCH 06/22] staging: lustre: llite: Remove filtering of seclabel xattr

Buisson Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/llite/xattr.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/xattr.c b/drivers/staging/lustre/lustre/llite/xattr.c index 2d78432..55a19a5 100644

[PATCH 09/22] staging: lustre: llite: break up ll_setstripe_ea function

://review.whamcloud.com/27126 Reviewed-by: Dmitry Eremin Reviewed-by: Niu Yawei Reviewed-by: James Simmons Reviewed-by: Andreas Dilger Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/llite/xattr.c | 37 +++-- 1 file changed, 24 insertions(+), 13 deletions

[PATCH 14/22] staging: lustre: llite: record in stats attempted removal of lma/link xattr

Keep track of attempted deletions as well as changing of the lma/link xattrs. Signed-off-by: James Simmons <uja.o...@yahoo.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27240 Reviewed-by: Dmitry Eremin <dmitry.ere...@intel.com&

[PATCH 14/22] staging: lustre: llite: record in stats attempted removal of lma/link xattr

Keep track of attempted deletions as well as changing of the lma/link xattrs. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27240 Reviewed-by: Dmitry Eremin Reviewed-by: Bob Glossman Reviewed-by: Sebastien

[PATCH 12/22] staging: lustre: llite: fix invalid size test in ll_setstripe_ea()

The size check at the start of ll_setstripe_ea() is only valid for a directory. Move that check to the section of code handling the S_ISDIR case. Signed-off-by: James Simmons <uja.o...@yahoo.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamclo

[PATCH 08/22] staging: lustre: llite: add simple comment about lustre.lov xattrs

viewed-by: Andreas Dilger <andreas.dil...@intel.com> Reviewed-by: Lai Siyao <lai.si...@intel.com> Reviewed-by: Jinshan Xiong <jinshan.xi...@gmail.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lustre/llite/xattr.c | 1 + 1 file cha

[PATCH 11/22] staging: lustre: llite: eat -EEXIST on setting trusted.lov

ewed-by: Niu Yawei <yawei@intel.com> Reviewed-by: James Simmons <uja.o...@yahoo.com> Reviewed-by: Andreas Dilger <andreas.dil...@intel.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lustre/llite/xattr.c | 14 +++--- 1 f

[PATCH 12/22] staging: lustre: llite: fix invalid size test in ll_setstripe_ea()

The size check at the start of ll_setstripe_ea() is only valid for a directory. Move that check to the section of code handling the S_ISDIR case. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27240 Reviewed

[PATCH 08/22] staging: lustre: llite: add simple comment about lustre.lov xattrs

Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/llite/xattr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/lustre/lustre/llite/xattr.c b/drivers/staging/lustre/lustre/llite/xattr.c index 1b462e4..c1600b9 100644 --- a/drivers/staging/lustre/lustre/llite/xattr.c

[PATCH 11/22] staging: lustre: llite: eat -EEXIST on setting trusted.lov

-EEXIST on setting these attributes to avoid problems. Signed-off-by: Bobi Jam Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9484 Reviewed-on: https://review.whamcloud.com/27126 Reviewed-by: Dmitry Eremin Reviewed-by: Niu Yawei Reviewed-by: James Simmons Reviewed-by: Andreas Dilger Signed-off

[PATCH 13/22] staging: lustre: llite: remove newline in fullname strings

In creating the full name of a xattr a new line was added that was seen by the remote MDS server which confused it. Remove the newline. Signed-off-by: James Simmons <uja.o...@yahoo.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com

[PATCH 13/22] staging: lustre: llite: remove newline in fullname strings

In creating the full name of a xattr a new line was added that was seen by the remote MDS server which confused it. Remove the newline. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27240 Reviewed-by: Dmitry Eremin

[PATCH 19/22] staging: lustre: llite: add support set_acl method in inode operations

m> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/25965 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-10541 Reviewed-on: https://review.whamcloud.com/ Reviewed-by: Bob Glossman <bob.gloss...@intel.com> Reviewed-by: James Simmons <u

[PATCH 19/22] staging: lustre: llite: add support set_acl method in inode operations

://review.whamcloud.com/25965 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-10541 Reviewed-on: https://review.whamcloud.com/ Reviewed-by: Bob Glossman Reviewed-by: James Simmons Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/llite/file.c | 67

[PATCH 20/22] staging: lustre: llite: use xattr_handler name for ACLs

t; Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-10785 Reviewed-on: https://review.whamcloud.com/ Reviewed-by: Dmitry Eremin <dmitry.ere...@intel.com> Reviewed-by: James Simmons <uja.o...@yahoo.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lust

[PATCH 20/22] staging: lustre: llite: use xattr_handler name for ACLs

-on: https://review.whamcloud.com/ Reviewed-by: Dmitry Eremin Reviewed-by: James Simmons Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/llite/xattr.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/xattr.c

[PATCH 18/22] staging: lustre: llite: style changes in xattr.c

Small style changes to match more the kernel code standard and it make it more readable. Signed-off-by: James Simmons <uja.o...@yahoo.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27240 Reviewed-by: Dmitry Eremin <dmitry.ere...@

[PATCH 16/22] staging: lustre: llite: use proper types in the xattr code

Convert __uXX types to uXX types since this is kernel code. The function ll_lov_user_md_size() returns ssize_t so change lum_size from int to ssize_t. Signed-off-by: James Simmons <uja.o...@yahoo.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on:

[PATCH 18/22] staging: lustre: llite: style changes in xattr.c

Small style changes to match more the kernel code standard and it make it more readable. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27240 Reviewed-by: Dmitry Eremin Reviewed-by: Bob Glossman Reviewed

[PATCH 16/22] staging: lustre: llite: use proper types in the xattr code

Convert __uXX types to uXX types since this is kernel code. The function ll_lov_user_md_size() returns ssize_t so change lum_size from int to ssize_t. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27240 Reviewed

[PATCH 17/22] staging: lustre: llite: cleanup xattr code comments

Add proper punctuation to the comments. Change buf_size to size for comment in ll_listxattr() since buf_size doesn't exit which will confuse someone reading the code. Signed-off-by: James Simmons <uja.o...@yahoo.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on:

[PATCH 17/22] staging: lustre: llite: cleanup xattr code comments

Add proper punctuation to the comments. Change buf_size to size for comment in ll_listxattr() since buf_size doesn't exit which will confuse someone reading the code. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com

[PATCH 21/22] staging: lustre: llite: correct removexattr detection

Dmitry Eremin <dmitry.ere...@intel.com> Reviewed-by: James Simmons <uja.o...@yahoo.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lustre/llite/xattr.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lus

[PATCH 21/22] staging: lustre: llite: correct removexattr detection

-by: James Simmons Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/llite/xattr.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/xattr.c b/drivers/staging/lustre/lustre/llite/xattr.c index e835c8e..1a597a6 100644 --- a/drivers

[PATCH 22/22] staging: lustre: llite: remove unused parameters from md_{get,set}xattr()

el.com/browse/LU-10792 Reviewed-on: https://review.whamcloud.com/ Reviewed-by: Dmitry Eremin <dmitry.ere...@intel.com> Reviewed-by: James Simmons <uja.o...@yahoo.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lustre/include/obd.h | 7 ++--

[PATCH 22/22] staging: lustre: llite: remove unused parameters from md_{get,set}xattr()

/ Reviewed-by: Dmitry Eremin Reviewed-by: James Simmons Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/include/obd.h | 7 ++--- drivers/staging/lustre/lustre/include/obd_class.h | 21 ++ drivers/staging/lustre/lustre/llite/file.c| 5 ++-- drivers/stag

[PATCH 15/22] staging: lustre: llite: cleanup posix acl xattr code

cleaner. Signed-off-by: James Simmons <uja.o...@yahoo.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27240 Reviewed-by: Dmitry Eremin <dmitry.ere...@intel.com> Reviewed-by: Bob Glossman <bob.gloss...@intel.com> Reviewed-by:

[PATCH 15/22] staging: lustre: llite: cleanup posix acl xattr code

cleaner. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27240 Reviewed-by: Dmitry Eremin Reviewed-by: Bob Glossman Reviewed-by: Sebastien Buisson Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- drivers

[PATCH 01/25] staging: lustre: libcfs: remove useless CPU partition code

global struct cfs_cpt_data cpt_data. * remove few unused APIs. Signed-off-by: Dmitry Eremin <dmitry.ere...@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23303 Reviewed-on: https://review.whamcloud.com/25048 Reviewed-by: James Si

[PATCH 01/25] staging: lustre: libcfs: remove useless CPU partition code

. * remove few unused APIs. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23303 Reviewed-on: https://review.whamcloud.com/25048 Reviewed-by: James Simmons Reviewed-by: Doug Oucharek Reviewed-by: Andreas Dilger

[PATCH 03/25] staging: lustre: libcfs: implement cfs_cpt_cpumask for UMP case

t; Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7734 Reviewed-on: http://review.whamcloud.com/18916 Reviewed-by: Olaf Weber <o...@sgi.com> Reviewed-by: Doug Oucharek <dou...@me.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/include/

[PATCH 06/25] staging: lustre: libcfs: replace num_possible_cpus() with nr_cpu_ids

i.com> Reviewed-by: Doug Oucharek <dou...@me.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c

[PATCH 08/25] staging: lustre: libcfs: add cpu distance handling

ug-id: https://jira.hpdd.intel.com/browse/LU-7734 Reviewed-on: http://review.whamcloud.com/18916 Reviewed-by: Olaf Weber <o...@sgi.com> Reviewed-by: Doug Oucharek <dou...@me.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- .../lustre/include/linux/libcfs/libcfs_cpu.h | 8

[PATCH 03/25] staging: lustre: libcfs: implement cfs_cpt_cpumask for UMP case

Reviewed-on: http://review.whamcloud.com/18916 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Signed-off-by: James Simmons --- drivers/staging/lustre/include/linux/libcfs/libcfs_cpu.h | 16 +--- drivers/staging/lustre/lnet/libcfs/libcfs_cpu.c | 9 + 2 files

[PATCH 06/25] staging: lustre: libcfs: replace num_possible_cpus() with nr_cpu_ids

From: Amir Shehata Move from num_possible_cpus() to nr_cpu_ids. Signed-off-by: Amir Shehata Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7734 Reviewed-on: http://review.whamcloud.com/18916 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Signed-off-by: James Simmons --- drivers

[PATCH 08/25] staging: lustre: libcfs: add cpu distance handling

://review.whamcloud.com/18916 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Signed-off-by: James Simmons --- .../lustre/include/linux/libcfs/libcfs_cpu.h | 8 +++ .../lustre/include/linux/libcfs/linux/linux-cpu.h | 4 ++ drivers/staging/lustre/lnet/libcfs/libcfs_cpu.c| 21

[PATCH 09/25] staging: lustre: libcfs: use distance in cpu and node handling

intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7734 Reviewed-on: http://review.whamcloud.com/18916 Reviewed-by: Olaf Weber <o...@sgi.com> Reviewed-by: Doug Oucharek <dou...@me.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- .../staging/lustre/lnet/li

[PATCH 09/25] staging: lustre: libcfs: use distance in cpu and node handling

-7734 Reviewed-on: http://review.whamcloud.com/18916 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Signed-off-by: James Simmons --- .../staging/lustre/lnet/libcfs/linux/linux-cpu.c | 192 +++-- 1 file changed, 143 insertions(+), 49 deletions(-) diff --git a/drivers

[PATCH 11/25] staging: lustre: libcfs: invert error handling for cfs_cpt_table_print

intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7734 Reviewed-on: http://review.whamcloud.com/18916 Reviewed-by: Olaf Weber <o...@sgi.com> Reviewed-by: Doug Oucharek <dou...@me.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- .../staging/lustre

[PATCH 11/25] staging: lustre: libcfs: invert error handling for cfs_cpt_table_print

/browse/LU-7734 Reviewed-on: http://review.whamcloud.com/18916 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Signed-off-by: James Simmons --- .../staging/lustre/lnet/libcfs/linux/linux-cpu.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers

[PATCH 02/25] staging: lustre: libcfs: rename variable i to cpu

ud.com/23303 Reviewed-by: James Simmons <uja.o...@yahoo.com> Reviewed-by: Doug Oucharek <dou...@me.com> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c | 12 ++

[PATCH 04/25] staging: lustre: libcfs: replace MAX_NUMNODES with nr_node_ids

lt;o...@sgi.com> Reviewed-by: Doug Oucharek <dou...@me.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lnet/libcfs/linux/

[PATCH 14/25] staging: lustre: libcfs: rename i to node for cfs_cpt_set_nodemask

Amir Shehata <amir.sheh...@intel.com> Reviewed-by: James Simmons <uja.o...@yahoo.com> Reviewed-by: Oleg Drokin <oleg.dro...@intel.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c | 12 ++-- 1 file c

[PATCH 10/25] staging: lustre: libcfs: provide debugfs files for distance handling

ug-id: https://jira.hpdd.intel.com/browse/LU-7734 Reviewed-on: http://review.whamcloud.com/18916 Reviewed-by: Olaf Weber <o...@sgi.com> Reviewed-by: Doug Oucharek <dou...@me.com> Signed-off-by: James Simmons <jsimm...@infradead.org> --- drivers/staging/lustre/lnet/libcfs/module.c | 53 ++

<    1   2   3   4   5   6   7   8   9   10   >