Re: Microphone gain on N900

On 03/02/17 16:28, Pavel Machek wrote: > Hi! > v4.10 works quite nicely on N900, but I still have problems with audio. Even GSM calls would be usable, if I had reasonable volume on microphone and speaker... but I don't. Both speaker and microphone are too quiet. I can get

Re: Microphone gain on N900

On 03/02/17 16:28, Pavel Machek wrote: > Hi! > v4.10 works quite nicely on N900, but I still have problems with audio. Even GSM calls would be usable, if I had reasonable volume on microphone and speaker... but I don't. Both speaker and microphone are too quiet. I can get

Re: [RESEND PATCH v6 5/6] i2c: designware: add SLAVE mode functions

On 03/01/17 17:59, Luis Oliveira wrote: - Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support - Slave functions added to core library file - Slave abort sources added to common source file - New driver: i2c-designware-slave added - Changes in the Makefile to compile the

Re: [RESEND PATCH v6 5/6] i2c: designware: add SLAVE mode functions

On 03/01/17 17:59, Luis Oliveira wrote: - Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support - Slave functions added to core library file - Slave abort sources added to common source file - New driver: i2c-designware-slave added - Changes in the Makefile to compile the

Re: [RESEND PATCH v6 3/6] i2c: designware: MASTER mode as separated driver

On 03/01/17 17:59, Luis Oliveira wrote: - The functions related to I2C master mode of operation were transformed in a single driver. - Common definitions were moved to i2c-designware-core.h - The i2c-designware-core is now only a library file, the functions associated are in a source file

Re: [RESEND PATCH v6 3/6] i2c: designware: MASTER mode as separated driver

On 03/01/17 17:59, Luis Oliveira wrote: - The functions related to I2C master mode of operation were transformed in a single driver. - Common definitions were moved to i2c-designware-core.h - The i2c-designware-core is now only a library file, the functions associated are in a source file

Re: [RESEND PATCH v6 2/6] i2c: designware: refactoring of the i2c-designware

les changed, 52 insertions(+), 35 deletions(-) Acked-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: [RESEND PATCH v6 2/6] i2c: designware: refactoring of the i2c-designware

c__ of dev_dbg prints - Fix i2c_dw_configure_master() to accept dw_i2c_dev * drivers/i2c/busses/i2c-designware-core.c| 56 + drivers/i2c/busses/i2c-designware-platdrv.c | 31 +--- 2 files changed, 52 insertions(+), 35 deletions(-) Acked-by: Jarkko Nikula

Re: [RESEND PATCH v6 4/6] i2c: designware: introducing I2C_SLAVE definitions

On 03/01/17 17:59, Luis Oliveira wrote: - Definitions were added to core library - A example was added to designware-core.txt Documentation that shows how the slave can be setup using DTS SLAVE related definitions were added to the core of the controller. Signed-off-by: Luis Oliveira

Re: [RESEND PATCH v6 4/6] i2c: designware: introducing I2C_SLAVE definitions

On 03/01/17 17:59, Luis Oliveira wrote: - Definitions were added to core library - A example was added to designware-core.txt Documentation that shows how the slave can be setup using DTS SLAVE related definitions were added to the core of the controller. Signed-off-by: Luis Oliveira

Re: Microphone gain on N900

On 02/27/17 21:53, Pali Rohár wrote: > On Sunday 26 February 2017 21:28:32 Pavel Machek wrote: >> Hi! >> >> v4.10 works quite nicely on N900, but I still have problems with >> audio. Even GSM calls would be usable, if I had reasonable volume on >> microphone and speaker... but I don't. >> >> Both

Re: Microphone gain on N900

On 02/27/17 21:53, Pali Rohár wrote: > On Sunday 26 February 2017 21:28:32 Pavel Machek wrote: >> Hi! >> >> v4.10 works quite nicely on N900, but I still have problems with >> audio. Even GSM calls would be usable, if I had reasonable volume on >> microphone and speaker... but I don't. >> >> Both

Re: [PATCH v6 1/6] i2c: designware: Cleaning and comment style fixes.

ewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> Signed-off-by: Luis Oliveira <loli...@synopsys.com> Acked-by: Jarkko Nikula <jarkko.nik...@linux.intel.com> Unfortunately this doesn't apply anymore due we had to revert commit 63d0f0a6952a ("i2c: designware: detect whe

Re: [PATCH v6 1/6] i2c: designware: Cleaning and comment style fixes.

: Andy Shevchenko Signed-off-by: Luis Oliveira Acked-by: Jarkko Nikula Unfortunately this doesn't apply anymore due we had to revert commit 63d0f0a6952a ("i2c: designware: detect when dynamic tar update is possible") for v4.10. Could you rebase and resend. -- Jarkko

Re: [PATCH v2] i2c: designwear: Fix clk warning on suspend/resume

pm_runtime_force_suspend and pm_runtime_force_resume. Cc: Jarkko Nikula <jarkko.nik...@linux.intel.com> Cc: Andy Shevchenko <andriy.shevche...@linux.intel.com> Cc: Mika Westerberg <mika.westerb...@linux.intel.com> Cc: Wolfram Sang <w...@the-dreams.de> Cc: linux-...@v

Re: [PATCH v2] i2c: designwear: Fix clk warning on suspend/resume

pm_runtime_force_suspend and pm_runtime_force_resume. Cc: Jarkko Nikula Cc: Andy Shevchenko Cc: Mika Westerberg Cc: Wolfram Sang Cc: linux-...@vger.kernel.org Suggested-by: Jarkko Nikula Signed-off-by: John Stultz --- v2: Switch to suggested fix by Jarkko. drivers/i2c/busses/i2c-designware

Re: [PATCH] i2c: designware: Fix regression when dynamic TAR update is disabled

On 10.02.2017 08:38, Suravee Suthikulpanit wrote: At this points, my understanding is there are probably two options here: 1) Keep the commit 63d0f0a6952a (i2c: designware: detect when dynamic tar update is possible) and apply V2 of this patch in 4.10. We might need to back-port the change

Re: [PATCH] i2c: designware: Fix regression when dynamic TAR update is disabled

On 10.02.2017 08:38, Suravee Suthikulpanit wrote: At this points, my understanding is there are probably two options here: 1) Keep the commit 63d0f0a6952a (i2c: designware: detect when dynamic tar update is possible) and apply V2 of this patch in 4.10. We might need to back-port the change

Re: [PATCH] i2c: designwear: Fix clk warning on suspend/resume

and suspend causing double suspend calls on i2c-designware-platdrv. Feedback would be greatly appreciated! Cc: Jarkko Nikula <jarkko.nik...@linux.intel.com> Cc: Andy Shevchenko <andriy.shevche...@linux.intel.com> Cc: Mika Westerberg <mika.westerb...@linux.intel.com> C

Re: [PATCH] i2c: designwear: Fix clk warning on suspend/resume

and suspend causing double suspend calls on i2c-designware-platdrv. Feedback would be greatly appreciated! Cc: Jarkko Nikula Cc: Andy Shevchenko Cc: Mika Westerberg Cc: Wolfram Sang Cc: linux-...@vger.kernel.org Signed-off-by: John Stultz --- drivers/i2c/busses/i2c-designware-core.h| 1

Re: Issue with i2c-designware-platdrv's suspend/runtime-suspend handling

On 01/31/2017 12:05 AM, John Stultz wrote: On Tue, Jan 24, 2017 at 2:03 PM, John Stultz wrote: Doing some further debugging, it seems the problem is that the device is being runtime suspended, and then at suspend time, we're calling the same logic, calling

Re: Issue with i2c-designware-platdrv's suspend/runtime-suspend handling

On 01/31/2017 12:05 AM, John Stultz wrote: On Tue, Jan 24, 2017 at 2:03 PM, John Stultz wrote: Doing some further debugging, it seems the problem is that the device is being runtime suspended, and then at suspend time, we're calling the same logic, calling i2c_dw_plat_prepare_clk, which causes

Re: [PATCH] i2c: busses: constify i2c_algorithm structures

dev->functionality; } -static struct i2c_algorithm i2c_dw_algo = { +static const struct i2c_algorithm i2c_dw_algo = { .master_xfer= i2c_dw_xfer, .functionality = i2c_dw_func, }; Acked-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: [PATCH] i2c: busses: constify i2c_algorithm structures

dev->functionality; } -static struct i2c_algorithm i2c_dw_algo = { +static const struct i2c_algorithm i2c_dw_algo = { .master_xfer= i2c_dw_xfer, .functionality = i2c_dw_func, }; Acked-by: Jarkko Nikula

Re: [PATCH v3 0/3] Init device ids from ACPI of_compatible

++ drivers/i2c/i2c-core.c | 8 +++- drivers/spi/spi.c | 10 +- include/acpi/acpi_bus.h | 1 + 4 files changed, 52 insertions(+), 2 deletions(-) After addressing comments from Andy Reviewed-by: Jarkko Nikula <jarkko.nik...@linux.int

Re: [PATCH v3 0/3] Init device ids from ACPI of_compatible

++ drivers/i2c/i2c-core.c | 8 +++- drivers/spi/spi.c | 10 +- include/acpi/acpi_bus.h | 1 + 4 files changed, 52 insertions(+), 2 deletions(-) After addressing comments from Andy Reviewed-by: Jarkko Nikula Tested-by: Jarkko Nikula --

Re: Nokia N900: mixers changed between 4.9 and 4.10-rc3, no longer can use in-call speaker

On 01/17/2017 03:47 PM, Peter Ujfalusi wrote: > On 01/15/2017 09:08 PM, Jarkko Nikula wrote: >> However v4.9.4 works and with it I can see there is an issue with these >> aic3x controls: >> >> amixer: Unable to find simple control 'Left DAC_L1 Mixer Line',0 >>

Re: Nokia N900: mixers changed between 4.9 and 4.10-rc3, no longer can use in-call speaker

On 01/17/2017 03:47 PM, Peter Ujfalusi wrote: > On 01/15/2017 09:08 PM, Jarkko Nikula wrote: >> However v4.9.4 works and with it I can see there is an issue with these >> aic3x controls: >> >> amixer: Unable to find simple control 'Left DAC_L1 Mixer Line',0 >>

Re: [PATCH v2 2/3] spi: pxa2xx: Prepare for edge-triggered interrupts

On 01/17/2017 10:10 AM, Jan Kiszka wrote: On 2017-01-17 08:58, Robert Jarzmik wrote: Jan Kiszka writes: When using the a device with edge-triggered interrupts, such as MSIs, the interrupt handler has to ensure that there is a point in time during its execution where

Re: [PATCH v2 2/3] spi: pxa2xx: Prepare for edge-triggered interrupts

On 01/17/2017 10:10 AM, Jan Kiszka wrote: On 2017-01-17 08:58, Robert Jarzmik wrote: Jan Kiszka writes: When using the a device with edge-triggered interrupts, such as MSIs, the interrupt handler has to ensure that there is a point in time during its execution where all interrupts sources

Re: [PATCH v2 1/3] spi: pxa2xx: Factor out handle_bad_msg

rtions(+), 14 deletions(-) Reviewed-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: [PATCH v2 3/3] spi: pca2xx-pci: Allow MSI

Shevchenko <andriy.shevche...@linux.intel.com> I was looking at is there need to call pci_free_irq_vectors() but pcim_release() takes care of that since this driver uses pcim_enable_device(). Reviewed-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: [PATCH v2 3/3] spi: pca2xx-pci: Allow MSI

Shevchenko I was looking at is there need to call pci_free_irq_vectors() but pcim_release() takes care of that since this driver uses pcim_enable_device(). Reviewed-by: Jarkko Nikula

Re: [PATCH v2 1/3] spi: pxa2xx: Factor out handle_bad_msg

(-) Reviewed-by: Jarkko Nikula

Re: Nokia N900: mixers changed between 4.9 and 4.10-rc3, no longer can use in-call speaker

On 01/15/2017 12:05 PM, Pavel Machek wrote: >>> So regression seems to be between v4.9 and v4.10. Any ideas? >> >> Interesting... seems there are no sound relevant changes after v4.9. >> >> Looks like there are only three commits after v4.9 for sound/soc which >> are built for Nokia N900: >> >>

Re: Nokia N900: mixers changed between 4.9 and 4.10-rc3, no longer can use in-call speaker

On 01/15/2017 12:05 PM, Pavel Machek wrote: >>> So regression seems to be between v4.9 and v4.10. Any ideas? >> >> Interesting... seems there are no sound relevant changes after v4.9. >> >> Looks like there are only three commits after v4.9 for sound/soc which >> are built for Nokia N900: >> >>

Re: Nokia N900 sound driver and ECI GPIOs

Hi On 01/02/2017 12:36 AM, Pavel Machek wrote: >> Jarkko, you are listed as original author of that driver. Do you (or >> anybody else) remember what that rx51_set_eci_switches() function is >> doing? And what gpio 178 controls? I was even not able to find gpio 178 >> in RX-51 Schematics [6]. >>

Re: Nokia N900 sound driver and ECI GPIOs

Hi On 01/02/2017 12:36 AM, Pavel Machek wrote: >> Jarkko, you are listed as original author of that driver. Do you (or >> anybody else) remember what that rx51_set_eci_switches() function is >> doing? And what gpio 178 controls? I was even not able to find gpio 178 >> in RX-51 Schematics [6]. >>

Re: [v1] i2c: busses: i2c-designware-pcidrv:- Unmap region obtained by pcim_iomap_regions

On 12/23/2016 12:44 PM, Mika Westerberg wrote: On Fri, Dec 23, 2016 at 03:41:33PM +0530, Arvind Yadav wrote: Release IO memory mapping, if i2c_dw_pci_probe is not successful. Point of pcim_iomap_regions() is that the regions are released automatically. So there is no need for explicit

Re: [v1] i2c: busses: i2c-designware-pcidrv:- Unmap region obtained by pcim_iomap_regions

On 12/23/2016 12:44 PM, Mika Westerberg wrote: On Fri, Dec 23, 2016 at 03:41:33PM +0530, Arvind Yadav wrote: Release IO memory mapping, if i2c_dw_pci_probe is not successful. Point of pcim_iomap_regions() is that the regions are released automatically. So there is no need for explicit

Re: [PATCH v4] i2c: designware: Cleaning and comment style fixes.

editor for git commit: autocmd Filetype gitcommit set textwidth=72 Although not that big issue. Acked-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: [PATCH v4] i2c: designware: Cleaning and comment style fixes.

editor for git commit: autocmd Filetype gitcommit set textwidth=72 Although not that big issue. Acked-by: Jarkko Nikula

Re: [PATCH V5] i2c: designware: fix wrong Tx/Rx FIFO for ACPI

nhu...@apm.com> --- drivers/i2c/busses/i2c-designware-platdrv.c | 31 -- 1 files changed, 24 insertions(+), 7 deletions(-) Acked-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: [PATCH V5] i2c: designware: fix wrong Tx/Rx FIFO for ACPI

/i2c/busses/i2c-designware-platdrv.c | 31 -- 1 files changed, 24 insertions(+), 7 deletions(-) Acked-by: Jarkko Nikula

Re: [PATCH V4] i2c: designware: fix wrong Tx/Rx FIFO for ACPI

On 12/14/2016 05:20 AM, Tin Huynh wrote: On Tue, Dec 13, 2016 at 6:25 PM, Andy Shevchenko + param = i2c_dw_read_comp_param(dev); + tx_fifo_depth = ((param >> 16) & 0xff) + 1; + rx_fifo_depth = ((param >> 8) & 0xff) + 1; + if (!dev->tx_fifo_depth) { +

Re: [PATCH V4] i2c: designware: fix wrong Tx/Rx FIFO for ACPI

On 12/14/2016 05:20 AM, Tin Huynh wrote: On Tue, Dec 13, 2016 at 6:25 PM, Andy Shevchenko + param = i2c_dw_read_comp_param(dev); + tx_fifo_depth = ((param >> 16) & 0xff) + 1; + rx_fifo_depth = ((param >> 8) & 0xff) + 1; + if (!dev->tx_fifo_depth) { +

Re: [PATCH v4 5/5] i2c: designware: Cleaning comments and formatation

On 12/07/2016 07:55 PM, Luis Oliveira wrote: - Missspelling, comment formatation and fix a string of the existing code Signed-off-by: Luis Oliveira --- Changes V3->V4: (Andy Shevchenko) - created a commit message drivers/i2c/busses/i2c-designware-common.c | 2 +-

Re: [PATCH v4 5/5] i2c: designware: Cleaning comments and formatation

On 12/07/2016 07:55 PM, Luis Oliveira wrote: - Missspelling, comment formatation and fix a string of the existing code Signed-off-by: Luis Oliveira --- Changes V3->V4: (Andy Shevchenko) - created a commit message drivers/i2c/busses/i2c-designware-common.c | 2 +-

Re: [PATCH V4] i2c: designware: fix wrong Tx/Rx FIFO for ACPI

the smaller one of the two. Signed-off-by: Tin Huynh <tnhu...@apm.com> One comment below, after addressing it Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> Feel free to add my Acked-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: [PATCH V4] i2c: designware: fix wrong Tx/Rx FIFO for ACPI

the smaller one of the two. Signed-off-by: Tin Huynh One comment below, after addressing it Reviewed-by: Andy Shevchenko Feel free to add my Acked-by: Jarkko Nikula

Re: [PATCH v4] i2c: designware: Implement support for SMBus block read and write

ITY in i2c-designware-pcidrv.c --- drivers/i2c/busses/i2c-designware-core.c| 46 +-- drivers/i2c/busses/i2c-designware-pcidrv.c |1 + drivers/i2c/busses/i2c-designware-platdrv.c |1 + 3 files changed, 45 insertions(+), 3 deletions(-) Acked-by: Jarkko Nikula

Re: [PATCH v4] i2c: designware: Implement support for SMBus block read and write

/busses/i2c-designware-core.c| 46 +-- drivers/i2c/busses/i2c-designware-pcidrv.c |1 + drivers/i2c/busses/i2c-designware-platdrv.c |1 + 3 files changed, 45 insertions(+), 3 deletions(-) Acked-by: Jarkko Nikula

Re: [PATCH v3] i2c: designware: Implement support for SMBus block read and write

moment. The below patch supports this feature. Signed-off-by: Tin Huynh <tnhu...@apm.com> Looks good to me, Reviewed-by: Mika Westerberg <mika.westerb...@linux.intel.com> Acked-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: [PATCH v3] i2c: designware: Implement support for SMBus block read and write

supports this feature. Signed-off-by: Tin Huynh Looks good to me, Reviewed-by: Mika Westerberg Acked-by: Jarkko Nikula

Re: [PATCH 10/15] ASoC: omap-mcbsp: use permission-specific DEVICE_ATTR variants

Hi On Sat, 29 Oct 2016 21:37:04 +0200 Julia Lawall wrote: > Use DEVICE_ATTR_RW for read-write attributes. This simplifies the > source code, improves readbility, and reduces the chance of > inconsistencies. > ... > > - DEVICE_ATTR(x, \(0644\|S_IRUGO|S_IWUSR\), x_show,

Re: [PATCH 10/15] ASoC: omap-mcbsp: use permission-specific DEVICE_ATTR variants

Hi On Sat, 29 Oct 2016 21:37:04 +0200 Julia Lawall wrote: > Use DEVICE_ATTR_RW for read-write attributes. This simplifies the > source code, improves readbility, and reduces the chance of > inconsistencies. > ... > > - DEVICE_ATTR(x, \(0644\|S_IRUGO|S_IWUSR\), x_show, x_store); > +

Re: [PATCH v1] I2C Designware Core Supports SMBUS BLOCK

Hi On 10/25/2016 07:35 AM, tnhu...@apm.com wrote: --- a/drivers/i2c/busses/i2c-designware-platdrv.c +++ b/drivers/i2c/busses/i2c-designware-platdrv.c @@ -220,6 +220,7 @@ static int dw_i2c_plat_probe(struct platform_device *pdev) I2C_FUNC_SMBUS_BYTE |

Re: [PATCH v1] I2C Designware Core Supports SMBUS BLOCK

Hi On 10/25/2016 07:35 AM, tnhu...@apm.com wrote: --- a/drivers/i2c/busses/i2c-designware-platdrv.c +++ b/drivers/i2c/busses/i2c-designware-platdrv.c @@ -220,6 +220,7 @@ static int dw_i2c_plat_probe(struct platform_device *pdev) I2C_FUNC_SMBUS_BYTE |

Re: Regression with 0b9e2988ab22 ("ahci: use pci_alloc_irq_vectors")

On 10/21/2016 04:27 PM, Christoph Hellwig wrote: Hi Jarkko, please try the two fixes queue up in the libata tree for this: https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/log/?h=for-4.9-fixes Great! Commit 17a51f12cfbd ("ahci: only try to use multi-MSI mode if there is more than 1

Re: Regression with 0b9e2988ab22 ("ahci: use pci_alloc_irq_vectors")

On 10/21/2016 04:27 PM, Christoph Hellwig wrote: Hi Jarkko, please try the two fixes queue up in the libata tree for this: https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/log/?h=for-4.9-fixes Great! Commit 17a51f12cfbd ("ahci: only try to use multi-MSI mode if there is more than 1

Regression with 0b9e2988ab22 ("ahci: use pci_alloc_irq_vectors")

Hi SATA stopped working on Intel SoCs that have single SATA port after v4.9-rc1: [8.705008] ata1.00: qc timeout (cmd 0x27) [8.709164] ata1.00: failed to read native max address (err_mask=0x4) [8.715557] ata1.00: HPA support seems broken, skipping HPA handling [9.029754] ata1:

Regression with 0b9e2988ab22 ("ahci: use pci_alloc_irq_vectors")

Hi SATA stopped working on Intel SoCs that have single SATA port after v4.9-rc1: [8.705008] ata1.00: qc timeout (cmd 0x27) [8.709164] ata1.00: failed to read native max address (err_mask=0x4) [8.715557] ata1.00: HPA support seems broken, skipping HPA handling [9.029754] ata1:

[PATCH] mfd: lpss: Fix Intel Kaby Lake PCH-H properties

nrisepoint properties on Kaby Lake PCH-H. Fixes: a6a576b78e09 ("mfd: lpss: Add Intel Kaby Lake PCH-H PCI IDs") Reported-by: Xiang A Wang <xiang.a.w...@intel.com> Signed-off-by: Jarkko Nikula <jarkko.nik...@linux.intel.com> --- drivers/mfd/intel-lpss-pci.c | 31 +--

[PATCH] mfd: lpss: Fix Intel Kaby Lake PCH-H properties

nrisepoint properties on Kaby Lake PCH-H. Fixes: a6a576b78e09 ("mfd: lpss: Add Intel Kaby Lake PCH-H PCI IDs") Reported-by: Xiang A Wang Signed-off-by: Jarkko Nikula --- drivers/mfd/intel-lpss-pci.c | 31 +-- 1 file changed, 9 insertions(+), 22 dele

[PATCH] mfd: intel-lpss: Add default I2C device properties for Apollo Lake

: i2c_designware i2c_designware.1: i2c_dw_handle_tx_abort: lost arbitration Fix this by using different default device properties on Apollo Lake than Broxton. Reported-by: Paul Liu <paul@canonical.com> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=156181 Signed-off-by: Jarkko Nikula <j

[PATCH] mfd: intel-lpss: Add default I2C device properties for Apollo Lake

: i2c_designware i2c_designware.1: i2c_dw_handle_tx_abort: lost arbitration Fix this by using different default device properties on Apollo Lake than Broxton. Reported-by: Paul Liu Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=156181 Signed-off-by: Jarkko Nikula --- Hi Paul. This is the same patch I

Re: [PATCH v1] i2c: designware: save the preset value of DW_IC_SDA_HOLD

com> Acked-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: [PATCH v1] i2c: designware: save the preset value of DW_IC_SDA_HOLD

controller. If sda_hold_time is zero, the chipset default hold time will be used, that will be too short for some platforms. Therefore, to have a better tolerance, the DW_IC_SDA_HOLD value should be kept by sda_hold_time. Looks good to me. Reviewed-by: Andy Shevchenko Acked-by: Jarkko Nikula

Re: [PATCH v4 0/4] i2c: designware: improve performance for transfers

-by: Christian Ruppert <christian.rupp...@alitech.com> on TB101 with Linux-4.7 And Jarkko added his Acked-by: Jarkko Nikula <jarkko.nik...@linux.intel.com> on patches 1 and 3 (now 4). Acked-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: [PATCH v4 0/4] i2c: designware: improve performance for transfers

-by: Christian Ruppert on TB101 with Linux-4.7 And Jarkko added his Acked-by: Jarkko Nikula on patches 1 and 3 (now 4). Acked-by: Jarkko Nikula

Re: [PATCH v3 2/3] i2c: designware: detect when dynamic tar update is possible

On 08/16/2016 05:07 PM, De Marchi, Lucas wrote: On Tue, 2016-08-16 at 17:00 +0300, Jarkko Nikula wrote: +*/ + reg = dw_readl(dev, DW_IC_CON); + dw_writel(dev, reg ^ DW_IC_CON_10BITADDR_MASTER, DW_IC_CON); + + if ((dw_readl(dev, DW_IC_CON) & DW_IC_CON_10BITADDR_MA

Re: [PATCH v3 2/3] i2c: designware: detect when dynamic tar update is possible

On 08/16/2016 05:07 PM, De Marchi, Lucas wrote: On Tue, 2016-08-16 at 17:00 +0300, Jarkko Nikula wrote: +*/ + reg = dw_readl(dev, DW_IC_CON); + dw_writel(dev, reg ^ DW_IC_CON_10BITADDR_MASTER, DW_IC_CON); + + if ((dw_readl(dev, DW_IC_CON) & DW_IC_CON_10BITADDR_MA

Re: [PATCH v3 1/3] i2c: designware: wait for disable/enable only if necessary

gnware-core.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) Acked-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: [PATCH v3 2/3] i2c: designware: detect when dynamic tar update is possible

Hi, + Wolfram On 07/29/2016 01:03 AM, Lucas De Marchi wrote: This adapter can be synthesized with dynamic tar update enabled or disabled. When enabled it is not necessary to disable the adapter to change the slave address in some situations, which saves some time per transaction. There is no

Re: [PATCH v3 1/3] i2c: designware: wait for disable/enable only if necessary

( +- 14.83% ) After: 8.638705161 seconds time elapsed ( +- 5.90% ) Signed-off-by: José Roberto de Souza Signed-off-by: Lucas De Marchi --- drivers/i2c/busses/i2c-designware-core.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) Acked-by: Jarkko

Re: [PATCH v3 2/3] i2c: designware: detect when dynamic tar update is possible

Hi, + Wolfram On 07/29/2016 01:03 AM, Lucas De Marchi wrote: This adapter can be synthesized with dynamic tar update enabled or disabled. When enabled it is not necessary to disable the adapter to change the slave address in some situations, which saves some time per transaction. There is no

Re: [PATCH v3 3/3] i2c: designware: do not disable adapter after transfer

( +- 0.11% ) Signed-off-by: Lucas De Marchi <lucas.demar...@intel.com> Signed-off-by: José Roberto de Souza <jose.so...@intel.com> --- drivers/i2c/busses/i2c-designware-core.c | 55 +--- 1 file changed, 37 insertions(+), 18 deletions(-) Acke

Re: [PATCH v3 3/3] i2c: designware: do not disable adapter after transfer

( +- 0.11% ) Signed-off-by: Lucas De Marchi Signed-off-by: José Roberto de Souza --- drivers/i2c/busses/i2c-designware-core.c | 55 +--- 1 file changed, 37 insertions(+), 18 deletions(-) Acked-by: Jarkko Nikula

Re: [PATCH] x86/hpet: fix typo from rtc cleanup

1 deletion(-) I started seeing system reboots and lockups during kernel boot on a prototype HW this week using v4.8-rc1 and bisected to this same commit. This patch fixes the issue. Tested-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: [PATCH] x86/hpet: fix typo from rtc cleanup

HW this week using v4.8-rc1 and bisected to this same commit. This patch fixes the issue. Tested-by: Jarkko Nikula

Re: [PATCH v3] i2c: designware: Use transfer timeout from ioctl I2C_TIMEOUT

plete, HZ)) { + if (!wait_for_completion_timeout(>cmd_complete, adap->timeout)) { dev_err(dev->dev, "controller timed out\n"); /* i2c_dw_init implicitly disables the adapter */ i2c_dw_init(dev); Acked-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: [PATCH v3] i2c: designware: Use transfer timeout from ioctl I2C_TIMEOUT

mplete, adap->timeout)) { dev_err(dev->dev, "controller timed out\n"); /* i2c_dw_init implicitly disables the adapter */ i2c_dw_init(dev); Acked-by: Jarkko Nikula

Re: [PATCH v2] i2c: designware: Use transfer timeout from ioctl I2C_TIMEOUT

es/i2c-designware-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Actually changelog doesn't belong to commit log. Otherwise Acked-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: [PATCH v2] i2c: designware: Use transfer timeout from ioctl I2C_TIMEOUT

file changed, 1 insertion(+), 1 deletion(-) Actually changelog doesn't belong to commit log. Otherwise Acked-by: Jarkko Nikula

Re: [PATCH 0/5] i2c: designware: Enable fast mode plus and high speed

+++-- 3 files changed, 68 insertions(+), 16 deletions(-) Acked-by: Jarkko Nikula <jarkko.nik...@linux.intel.com>

Re: [PATCH 0/5] i2c: designware: Enable fast mode plus and high speed

+++-- 3 files changed, 68 insertions(+), 16 deletions(-) Acked-by: Jarkko Nikula

Re: [PATCH] i2c: designware: do not disable adapter after transfer

On 04/25/2016 06:04 PM, Lucas De Marchi wrote: On 04/25/2016 08:51 AM, Jarkko Nikula wrote: [ ... ] @@ -413,8 +416,16 @@ static void i2c_dw_xfer_init(struct dw_i2c_dev *dev) struct i2c_msg *msgs = dev->msgs; u32 ic_con, ic_tar = 0; -/* Disable the adap

Re: [PATCH] i2c: designware: do not disable adapter after transfer

On 04/25/2016 06:04 PM, Lucas De Marchi wrote: On 04/25/2016 08:51 AM, Jarkko Nikula wrote: [ ... ] @@ -413,8 +416,16 @@ static void i2c_dw_xfer_init(struct dw_i2c_dev *dev) struct i2c_msg *msgs = dev->msgs; u32 ic_con, ic_tar = 0; -/* Disable the adap

Re: [PATCH] ASoC: omap-pcm: Initialize DMA configuration

rr = 0; > > + memset(, 0x00, sizeof(config)); Based on a894bd7fb539 ("ASoC: generic-dmaengine-pcm: Clear slave_config memory") Acked-by: Jarkko Nikula <jarkko.nik...@bitmer.com> Reviewed-by: Jarkko Nikula <jarkko.nik...@bitmer.com>

Re: [PATCH] ASoC: omap-pcm: Initialize DMA configuration

ASoC: generic-dmaengine-pcm: Clear slave_config memory") Acked-by: Jarkko Nikula Reviewed-by: Jarkko Nikula

Re: [PATCH] i2c: designware: do not disable adapter after transfer

On 04/22/2016 06:08 PM, Lucas De Marchi wrote: Disabling the adapter after each transfer is pretty bad for sensors and other devices doing small transfers at a high rate. It slows down the transfer rate a lot since each of them have to wait the adapter to be enabled again. During the transfer

Re: [PATCH] i2c: designware: do not disable adapter after transfer

On 04/22/2016 06:08 PM, Lucas De Marchi wrote: Disabling the adapter after each transfer is pretty bad for sensors and other devices doing small transfers at a high rate. It slows down the transfer rate a lot since each of them have to wait the adapter to be enabled again. During the transfer

Re: [PATCH v4] i2c: designware-platdrv: fix unbalanced clk enable and prepare

Hi On 04/22/2016 11:49 AM, Jisheng Zhang wrote: If i2c_dw_probe() fails, we should disable and unprepare the clock, otherwise the clock enable and prepare is left unbalanced. In dw_i2c_plat_remove(), we'd better to not rely on runtime PM to disable and unprepare the clock since CONFIG_PM may

Re: [PATCH v4] i2c: designware-platdrv: fix unbalanced clk enable and prepare

Hi On 04/22/2016 11:49 AM, Jisheng Zhang wrote: If i2c_dw_probe() fails, we should disable and unprepare the clock, otherwise the clock enable and prepare is left unbalanced. In dw_i2c_plat_remove(), we'd better to not rely on runtime PM to disable and unprepare the clock since CONFIG_PM may

Re: [PATCH 1/4] i2c: designware-platdrv: Fix runtime PM initialization

Hi On 04/21/2016 06:08 AM, Jisheng Zhang wrote: Dear Jarkko, On Wed, 20 Apr 2016 16:53:08 +0300 Jarkko Nikula wrote: On 04/14/2016 03:53 PM, Jisheng Zhang wrote: When pm_runtime_enable() was being called, the device's usage counter was 0, causing the PM layer to runtime-suspend the device

Re: [PATCH 1/4] i2c: designware-platdrv: Fix runtime PM initialization

Hi On 04/21/2016 06:08 AM, Jisheng Zhang wrote: Dear Jarkko, On Wed, 20 Apr 2016 16:53:08 +0300 Jarkko Nikula wrote: On 04/14/2016 03:53 PM, Jisheng Zhang wrote: When pm_runtime_enable() was being called, the device's usage counter was 0, causing the PM layer to runtime-suspend the device

Re: [PATCH 2/4] i2c: designware-platdrv: fix unbalanced clk enable and prepare

On 04/21/2016 05:40 AM, Jisheng Zhang wrote: Dear Jarkko, Andy, On Wed, 20 Apr 2016 17:16:00 +0300 Andy Shevchenko wrote: On Wed, 2016-04-20 at 15:55 +0300, Jarkko Nikula wrote: I see Andy's 1cb715ca4694 ("i2c-designware: move to managed functions (devm_*)") removed it but at

Re: [PATCH 2/4] i2c: designware-platdrv: fix unbalanced clk enable and prepare

On 04/21/2016 05:40 AM, Jisheng Zhang wrote: Dear Jarkko, Andy, On Wed, 20 Apr 2016 17:16:00 +0300 Andy Shevchenko wrote: On Wed, 2016-04-20 at 15:55 +0300, Jarkko Nikula wrote: I see Andy's 1cb715ca4694 ("i2c-designware: move to managed functions (devm_*)") removed it but at

Re: [PATCH 1/4] i2c: designware-platdrv: Fix runtime PM initialization

On 04/14/2016 03:53 PM, Jisheng Zhang wrote: When pm_runtime_enable() was being called, the device's usage counter was 0, causing the PM layer to runtime-suspend the device. We then went on to call i2c_dw_probe() on a suspended device, which could hung. Fix this by incrementing the usage

Re: [PATCH 1/4] i2c: designware-platdrv: Fix runtime PM initialization

On 04/14/2016 03:53 PM, Jisheng Zhang wrote: When pm_runtime_enable() was being called, the device's usage counter was 0, causing the PM layer to runtime-suspend the device. We then went on to call i2c_dw_probe() on a suspended device, which could hung. Fix this by incrementing the usage

<    1   2   3   4   5   >