Re: [PATCH] ARM: dove: Fix typo COMMON_CLK_DOVE

2013-03-05 Thread Jean-Francois Moine
On Tue, 5 Mar 2013 09:00:25 -0500 Jason Cooper ja...@lakedaemon.net wrote: On Tue, Mar 05, 2013 at 10:34:58AM +0100, Paul Bolle wrote: Commit 5b03df9ace680d7cdd34a69dfd85ca5f74159d18 (ARM: dove: switch to DT clock providers) added select COMMON_CLK_DOVE to Marvell Dove's Kconfig entry. But

Re: [PATCH] tty vt: fix character insertion overflow

2013-02-25 Thread Jean-Francois Moine
On Sun, 24 Feb 2013 20:06:09 -0500 (EST) Nicolas Pitre nicolas.pi...@linaro.org wrote: Commit 81732c3b2f (tty vt: Fix line garbage in virtual console on command line edition) broke insert_char() in multiple ways. Then commit b1a925f44a (tty vt: Fix a regression in command line edition)

[PATCH] tty vt: Fix line garbage in virtual console on command line edition

2012-09-06 Thread Jean-Francois Moine
From: Jean-François Moine moin...@free.fr On some machines using a specific hardware for console screen output, the update of the pixel frame buffer does not work correctly when using command line edition. This may be due to a memory cache bug in the machine on which the problem has been found,

Re: vt: regression caused by Fix line garbage in virtual..

2012-11-20 Thread Jean-Francois Moine
On Mon, 19 Nov 2012 22:15:53 +0100 Krzysztof Mazur krzys...@podlesie.net wrote: That patch fixed the original issue, but I noticed another artifact (I tested only v3.7-rc6 after your fix, I didn't check if the same problems exists in v3.7). After: for ((i = 0; i 40; i++)); do

[PATCH] tty vt: Fix a regression in command line edition

2012-11-20 Thread Jean-Francois Moine
From: Jean-François Moine moin...@free.fr The commit 81732c3b2fede049a692e58a7ceabb6d18ffb18c (Fix line garbage in virtual console on command line edition) made a regression with some machines: some characters were not erased after line edition. This patch adjusts the number of moved characters

Re: vt: regression caused by Fix line garbage in virtual..

2012-11-19 Thread Jean-Francois Moine
On Mon, 19 Nov 2012 11:38:28 + Alan Cox a...@linux.intel.com wrote: There are some garbage after mousedev.c not present on older kernels. Reverting commit 81732c in v3.7-rc6 fixes the issue. Then we should drop this for 3.7 until a fixed one is provided IMHO. Its not relevant to

Re: [PATCH v3 1/4] ASoc: kirkwood: simplify probe error

2013-08-03 Thread Jean-Francois Moine
On Sat, 3 Aug 2013 13:39:54 +0100 Russell King - ARM Linux li...@arm.linux.org.uk wrote: This doesn't apply to mainline as there's a clk_put() there. Right, it applies to linux-next: On Fri, 26 Jul 2013 11:32:50 +0100, Mark Brown broo...@kernel.org wrote: Always submit against where the code

Re: [PATCH v3 4/4] ASoC: kirkwood: change kirkwood-i2s to mvebu-pcm-audio and DT doc

2013-08-03 Thread Jean-Francois Moine
On Sat, 3 Aug 2013 14:48:55 +0100 Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Jul 31, 2013 at 08:18:58AM +0200, Jean-Francois Moine wrote: diff --git a/sound/soc/kirkwood/kirkwood-i2s.c b/sound/soc/kirkwood/kirkwood-i2s.c index 9844010..4f817a2 100644 --- a/sound/soc

Re: [PATCH v3 1/4] ASoc: kirkwood: simplify probe error

2013-08-03 Thread Jean-Francois Moine
On Sat, 3 Aug 2013 13:46:52 +0100 Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Jul 31, 2013 at 08:17:39AM +0200, Jean-Francois Moine wrote: The function kirkwood_i2s_dev_remove() may be used when probe fails. Looking at this deeper, I'm not happy with this. [snip

[PATCH 1/4] ASoc: kirkwood: change the pcm/dma stream data pointer

2013-07-25 Thread Jean-Francois Moine
In the kirkwood pcm/dma driver, the private stream related data pointer was hold in the platform drvdata. As this pointer may be used by other parts of the audio subsystem, this patch uses the substream runtime private data pointer instead. Signed-off-by: Jean-Francois Moine moin...@free.fr

[PATCH 0/4] ASoc: kirkwood: extend the kirkwood audio subsystem for DT usage

2013-07-25 Thread Jean-Francois Moine
This patch series adds DT support to the kirkwood audio subsystem. It cancels the previous patch requests: - ARM: kirkwood: enable S/PDIF - ARM: kirkwood: extend the kirkwood i2s driver for DT usage - ARM: kirkwood: extend the kirkwood pcm/dma driver for DT usage It also contains the merge of

[PATCH 2/4] ASoc: kirkwood: simplify probe error

2013-07-25 Thread Jean-Francois Moine
The function kirkwood_i2s_dev_remove() may be used when probe fails. Signed-off-by: Jean-Francois Moine moin...@free.fr --- sound/soc/kirkwood/kirkwood-i2s.c | 44 +++ 1 file changed, 21 insertions(+), 23 deletions(-) diff --git a/sound/soc/kirkwood/kirkwood

[PATCH 4/4] ASoc: kirkwood: add DT support

2013-07-25 Thread Jean-Francois Moine
The kirkwood audio driver is used without DT in the Kirkwood machine. This patch adds a DT compatible definition for use in other Marvell machines as the Armada 88AP510 (Dove). Signed-off-by: Jean-Francois Moine moin...@free.fr --- .../devicetree/bindings/sound/kirkwood-i2s.txt | 29

[PATCH 3/4] ASoc: kirkwood: merge kirkwood-i2c and kirkwood-dma

2013-07-25 Thread Jean-Francois Moine
To avoid the declaration of a 'kirkwood-pcm-audio' device in the DT, this patch merges the kirkwood-i2c and kirkwood-dma drivers into one module. Signed-off-by: Jean-Francois Moine moin...@free.fr --- arch/arm/mach-kirkwood/common.c | 6 -- sound/soc/kirkwood/Kconfig | 5

[PATCH 3/4 v2] ASoc: kirkwood: merge kirkwood-i2c and kirkwood-dma

2013-07-25 Thread Jean-Francois Moine
To avoid the declaration of a 'kirkwood-pcm-audio' device in the DT, this patch merges the kirkwood-i2c and kirkwood-dma drivers into one module. Signed-off-by: Jean-Francois Moine moin...@free.fr --- v2 - fix compilation error --- arch/arm/mach-kirkwood/common.c | 6 -- sound

[PATCH 4/4 v2] ASoc: kirkwood: add DT support

2013-07-25 Thread Jean-Francois Moine
The kirkwood audio driver is used without DT in the Kirkwood machine. This patch adds a DT compatible definition for use in other Marvell machines as the Armada 88AP510 (Dove). Signed-off-by: Jean-Francois Moine moin...@free.fr --- v2 fix compilation error --- Documentation/devicetree

Re: [PATCH 1/4] ASoc: kirkwood: change the pcm/dma stream data pointer

2013-07-26 Thread Jean-Francois Moine
On Thu, 25 Jul 2013 19:23:56 +0100 Mark Brown broo...@kernel.org wrote: On Thu, Jul 25, 2013 at 10:38:55AM +0100, Russell King - ARM Linux wrote: There's a much better solution to this, which is to get rid of kirkwood_dma_priv entirely: This does seem a lot nicer, can we either grab the

Re: [PATCH 2/4] ASoc: kirkwood: simplify probe error

2013-07-26 Thread Jean-Francois Moine
On Thu, 25 Jul 2013 20:10:59 +0100 Mark Brown broo...@kernel.org wrote: On Thu, Jul 25, 2013 at 11:13:57AM +0200, Jean-Francois Moine wrote: The function kirkwood_i2s_dev_remove() may be used when probe fails. This seems fine but doesn't apply against current code but otherwise seems fine

Re: [PATCH 3/4] ASoc: kirkwood: merge kirkwood-i2c and kirkwood-dma

2013-07-26 Thread Jean-Francois Moine
On Thu, 25 Jul 2013 23:58:16 +0100 Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Jul 25, 2013 at 08:16:04PM +0100, Mark Brown wrote: On Thu, Jul 25, 2013 at 11:14:28AM +0200, Jean-Francois Moine wrote: To avoid the declaration of a 'kirkwood-pcm-audio' device in the DT

Re: [PATCH 4/4] ASoc: kirkwood: add DT support

2013-07-26 Thread Jean-Francois Moine
On Fri, 26 Jul 2013 00:05:33 +0100 Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Jul 25, 2013 at 08:19:05PM +0100, Mark Brown wrote: On Thu, Jul 25, 2013 at 11:14:59AM +0200, Jean-Francois Moine wrote: [snip] - priv-clk = devm_clk_get(pdev-dev, NULL); + priv-clk

Re: [PATCH 4/4] ASoc: kirkwood: add DT support

2013-07-26 Thread Jean-Francois Moine
On Fri, 26 Jul 2013 10:21:56 +0100 Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Jul 26, 2013 at 11:09:13AM +0200, Jean-Francois Moine wrote: The A510 documentation uses the names DCO PLL for the internal clock and AU_EXTCLK for the external clock. So, what about dcopll

[PATCH] ASoc: kirkwood: Use the Kirkwood audio driver in Dove boards

2013-08-27 Thread Jean-Francois Moine
This patch permits the generation of the Kirkwood audio driver which may be used in the Dove boards. Signed-off-by: Jean-Francois Moine moin...@free.fr --- sound/soc/kirkwood/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/kirkwood

[PATCH 0/2] ARM: Dove: Add audio to the DT

2013-08-28 Thread Jean-Francois Moine
This patch series adds audio DT to the Dove boards and activates the Cubox audio device. Full audio in the Cubox will work when the DT extension of the generic simple audio card will be complete. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef |

[PATCH 1/2] ARM: Dove: Add the audio devices in DT

2013-08-28 Thread Jean-Francois Moine
This patch adds the nodes to instantiate the audio devices of the Dove boards. Signed-off-by: Jean-Francois Moine moin...@free.fr --- arch/arm/boot/dts/dove.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot

[PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-08-28 Thread Jean-Francois Moine
This patch activates the audio device of the Cubox and sets the i2s and S/PDIF pins. Signed-off-by: Jean-Francois Moine moin...@free.fr --- arch/arm/boot/dts/dove-cubox.dts | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/dove-cubox.dts b/arch

[PATCH] of: reduce the number of PROBE_DEFERs

2013-08-20 Thread Jean-Francois Moine
This patch populates the platform from the device tree into two steps: the first step creates the nodes that are referenced by a phandle, the second step creates the other nodes. This permits to reduce the number of PROBE_DEFERs. Signed-off-by: Jean-Francois Moine moin...@free.fr --- A better

Re: [PATCH v2 4/8] drm/i2c: tda998x: prepare for video input configuration

2013-08-21 Thread Jean-Francois Moine
On Wed Aug 14 12:43:29 PDT 2013, Sebastian Hesselbarth wrote: From: Russell King rmk+kernel at arm.linux.org.uk The video-input-port (VIP) is highly configurable. This prepares current driver to allow to configure VIP configuration, as some boards connect lcd controller and TDA998x

Re: [PATCH v2 5/8] drm/i2c: tda998x: add video and audio input configuration

2013-08-21 Thread Jean-Francois Moine
On Wed Aug 14 12:43:30 PDT 2013, Sebastian Hesselbarth wrote: From: Russell King rmk+kernel at arm.linux.org.uk This patch adds tda998x specific parameters to allow it to be configured for different boards using it. Also, this implements rudimentary audio support for S/PDIF attached

Re: [PATCH v2 4/8] drm/i2c: tda998x: prepare for video input configuration

2013-08-22 Thread Jean-Francois Moine
On Wed, 21 Aug 2013 23:36:05 +0100 Russell King - ARM Linux li...@arm.linux.org.uk wrote: AFAIK, the TI boards have no pin-swapped, nor has the Cubox (there is no need to set the bit CFG_GRA_SWAPRB of the register LCD_SPU_DMA_CTRL0 of the Dove lcd for RGB or YUV formats). Which board

Re: [PATCH] of: reduce the number of PROBE_DEFERs

2013-08-22 Thread Jean-Francois Moine
On Tue, 20 Aug 2013 11:13:24 +0100 Grant Likely grant.lik...@linaro.org wrote: On Tue, Aug 20, 2013 at 11:01 AM, Jean-Francois Moine moin...@free.fr wrote: This patch populates the platform from the device tree into two steps: the first step creates the nodes that are referenced by a phandle

[PATCH v5 1/1] ASoc: kirkwood: add DT support to the mvebu audio subsystem

2013-08-14 Thread Jean-Francois Moine
This patch adds DT support to the audio subsystem of the mvebu family (Kirkwood, Dove, Armada 370). Signed-off-by: Jean-Francois Moine moin...@free.fr --- This patch does not add any new function as S/PDIF or DPCM support. --- .../devicetree/bindings/sound/mvebu-audio.txt | 29

[PATCH v5 0/1] ASoc: kirkwood: extend the kirkwood audio subsystem for DT usage

2013-08-14 Thread Jean-Francois Moine
This patch series adds DT support to the kirkwood/mvebu audio subsystem. History v5 - change the DT name to marvell,mvebu-audio v4 - change the DT name to mrvl,mvebu-audio - remove previous patches 1..3 which have been applied by Russell King v3 - change the DT

[PATCH] pinctrl: pinctrl-single: fix compile warning when no CONFIG_PM

2013-07-15 Thread Jean-Francois Moine
This warning has been introduced by the commit 0f9bc4bcdf4f pinctrl: single: adopt pinctrl sleep mode management Signed-off-by: Jean-Francois Moine moin...@free.fr --- drivers/pinctrl/pinctrl-single.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pinctrl/pinctrl-single.c b

[PATCH] ASoC: kirkwood-i2s: fix a compilation warning

2013-07-15 Thread Jean-Francois Moine
of the external clock pointer. Signed-off-by: Jean-Francois Moine moin...@free.fr --- sound/soc/kirkwood/kirkwood-i2s.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/kirkwood/kirkwood-i2s.c b/sound/soc/kirkwood/kirkwood-i2s.c index 4c9dad3..8da5cdb 100644 --- a/sound/soc

Re: [PATCH] ASoC: kirkwood-i2s: fix a compilation warning

2013-07-15 Thread Jean-Francois Moine
On Mon, 15 Jul 2013 16:31:01 +0100 Mark Brown broo...@kernel.org wrote: On Mon, Jul 15, 2013 at 10:36:44AM +0200, Jean-Francois Moine wrote: In the function kirkwood_set_rate, when the rate cannot be satisfied by the internal nor by an external clock, the clock source in undefined

[PATCH v2] ASoC: kirkwood-i2s: fix a compilation warning

2013-07-16 Thread Jean-Francois Moine
), the function will simply cause a backtrace. Signed-off-by: Jean-Francois Moine moin...@free.fr --- v2 - add more explanations --- sound/soc/kirkwood/kirkwood-i2s.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sound/soc/kirkwood/kirkwood-i2s.c b/sound/soc/kirkwood

Re: [PATCH] ARM: Fix r7/r11 confusion when CONFIG_THUMB2_KERNEL=y [OT]

2013-07-30 Thread Jean-Francois Moine
On Tue, 30 Jul 2013 10:25:18 +0100 Dave Martin dave.mar...@arm.com wrote: The pragmatic route is less contraversial and lower overhead: even though it's not correct as per the ABI, GCC is the only supported compiler for building the kernel anyway. BTW, kernels compiled with gcc-4.8 don't

Re: [PATCH] ARM: Fix r7/r11 confusion when CONFIG_THUMB2_KERNEL=y [OT]

2013-07-30 Thread Jean-Francois Moine
On Tue, 30 Jul 2013 10:44:57 +0100 Dave Martin dave.mar...@arm.com wrote: On Tue, Jul 30, 2013 at 11:38:53AM +0200, Jean-Francois Moine wrote: On Tue, 30 Jul 2013 10:25:18 +0100 Dave Martin dave.mar...@arm.com wrote: The pragmatic route is less contraversial and lower overhead: even

[PATCH v3 0/4] ASoc: kirkwood: extend the kirkwood audio subsystem for DT usage

2013-07-31 Thread Jean-Francois Moine
This patch series adds DT support to the kirkwood audio subsystem. It cancels the previous patch requests: - ARM: kirkwood: enable S/PDIF - ARM: kirkwood: extend the kirkwood i2s driver for DT usage - ARM: kirkwood: extend the kirkwood pcm/dma driver for DT usage It also contains the merge of

[PATCH v3 3/4] ASoc: kirkwood: add DT support

2013-07-31 Thread Jean-Francois Moine
The kirkwood audio driver is used without DT in the Kirkwood machine. This patch adds a DT compatible definition for use in other Marvell machines such as the Armada 88AP510 (Dove). Signed-off-by: Jean-Francois Moine moin...@free.fr --- sound/soc/kirkwood/kirkwood-i2s.c| 27

[PATCH v3 1/4] ASoc: kirkwood: simplify probe error

2013-07-31 Thread Jean-Francois Moine
The function kirkwood_i2s_dev_remove() may be used when probe fails. Signed-off-by: Jean-Francois Moine moin...@free.fr --- sound/soc/kirkwood/kirkwood-i2s.c | 40 +++--- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/sound/soc/kirkwood/kirkwood-i2s.c

[PATCH v3 2/4] ASoc: kirkwood: merge kirkwood-i2c and kirkwood-dma

2013-07-31 Thread Jean-Francois Moine
To avoid the declaration of a 'kirkwood-pcm-audio' device in the DT, this patch merges the kirkwood-i2c and kirkwood-dma drivers into one module associated with 'kirkwood-i2s'. Signed-off-by: Jean-Francois Moine moin...@free.fr --- arch/arm/mach-kirkwood/common.c | 6 -- sound/soc

[PATCH v3 4/4] ASoC: kirkwood: change kirkwood-i2s to mvebu-pcm-audio and DT doc

2013-07-31 Thread Jean-Francois Moine
As the kirkwood audio system may be used in other Marvell machines (mvebu), this patch changes the name of the audio driver to 'mvebu-pcm-audio' and also contains the associated DT documentation. Signed-off-by: Jean-Francois Moine moin...@free.fr --- .../devicetree/bindings/sound/mvebu-pcm

Re: [PATCH] ARM: Fix r7/r11 confusion when CONFIG_THUMB2_KERNEL=y [OT]

2013-07-31 Thread Jean-Francois Moine
On Tue, 30 Jul 2013 10:49:04 +0100 Will Deacon will.dea...@arm.com wrote: On Tue, Jul 30, 2013 at 10:38:53AM +0100, Jean-Francois Moine wrote: BTW, kernels compiled with gcc-4.8 don't work. Erm. Can you elaborate please? There was an issue where SLUB would get miscompiled with 4.8 due

Re: [PATCH 2/2] ARM: Dove: Add the audio device to the Cubox DT

2013-10-03 Thread Jean-Francois Moine
On Sat, 28 Sep 2013 16:27:19 +0200 Sebastian Hesselbarth sebastian.hesselba...@gmail.com wrote: Jean-Francois, I can confirm the following for CuBox: AU1_EXTCLK is connected to si5351 clkout 2. For the _current_ (v3.12-rc1) dove-cubox.dts that means that you'll have to exchange the

[PATCH] ARM: Dove: fix bad properties of the si5351 clkout2 used by Cubox audio

2013-10-04 Thread Jean-Francois Moine
As defined in the DT, clkout2 is not allowed to change the pll inside si5351. This patch inverts the properties of the clkout{1,2} so that clkout2 may be defined as the external clock of the audio device in the Cubox. Signed-off-by: Jean-Francois Moine moin...@free.fr --- arch/arm/boot/dts/dove

[PATCH RESEND v2] clk: probe defer when clock not yet ready

2013-11-25 Thread Jean-Francois Moine
. Signed-off-by: Jean-Francois Moine moin...@free.fr --- resend v2: remove ASoc from subject (thank you, Mark) resend: - patch subject change from [PATCH v3 1/2] ASoC: kirkwood: clk: probe defer when clock not yet ready - base kernel 3.13.0-rc1 v2: fix __clk_get() failure (from Russell King

Re: [alsa-devel] [PATCH v2 3/4] ASoC: simple-card: accept many DAI links

2014-03-14 Thread Jean-Francois Moine
On Fri, 14 Mar 2014 13:16:12 +0200 Jyri Sarha jsa...@ti.com wrote: On 03/11/2014 11:36 AM, Jean-Francois Moine wrote: Some simple audio cards may have many DAI links. This patch extends the simple-card driver for handling such cards. Signed-off-by: Jean-Francois Moine moin...@free.fr

Re: [alsa-devel] [PATCH v2 3/4] ASoC: simple-card: accept many DAI links

2014-03-14 Thread Jean-Francois Moine
On Wed, 12 Mar 2014 05:20:17 + li.xi...@freescale.com li.xi...@freescale.com wrote: I'm not sure why only the first link needs parsing the DAIFMT ? In my machine, there is only one audio device and the CODECs don't need any format, sysclk or TDM slot. But, as Jyri asked it too, I will add

[PATCH v3 0/4] ASoC: simple-card: multi DAI links extension

2014-03-15 Thread Jean-Francois Moine
the reference count of the device node at end of probe Jean-Francois Moine (4): ASoC: simple-card: Simplify code ASoC: simple-card: dynamically allocate the DAI link and properties ASoC: simple-card: Handle many DAI links ASoC: simple-card: Add DT documentation for multi-DAI links

[PATCH v3 2/4] ASoC: simple-card: dynamically allocate the DAI link and properties

2014-03-15 Thread Jean-Francois Moine
The DAI link array and the properties (fmt, sysclk slots) are hard-coded for a single CPU / CODEC link. This patch dynamically allocates the DAI link array and the properties with the aim of supporting many DAI links. Signed-off-by: Jean-Francois Moine moin...@free.fr --- sound/soc/generic

[PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links

2014-03-15 Thread Jean-Francois Moine
There may be many couples of CPU/CODEC DAI links. The example 2 is extracted from the Cubox DT. Signed-off-by: Jean-Francois Moine moin...@free.fr --- .../devicetree/bindings/sound/simple-card.txt | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git

[PATCH v3 3/4] ASoC: simple-card: Handle many DAI links

2014-03-15 Thread Jean-Francois Moine
Some simple audio cards may have many DAI links. This patch extends the simple-card driver for handling such cards. Signed-off-by: Jean-Francois Moine moin...@free.fr --- sound/soc/generic/simple-card.c | 134 +--- 1 file changed, 83 insertions(+), 51

[PATCH v3 1/4] ASoC: simple-card: Simplify code

2014-03-15 Thread Jean-Francois Moine
The global DAI format is used only in the function asoc_simple_card_parse_of(). So, move it from the private data to the stack. Signed-off-by: Jean-Francois Moine moin...@free.fr --- sound/soc/generic/simple-card.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH RFC 0/5] Move tda998x to a couple encoder/connector

2014-03-17 Thread Jean-Francois Moine
subsystems. The proposed patch set does not include changes to the Armada DRM driver which has no DT support yet and which will not work anymore if this patch set is applied. Jean-Francois Moine (5): drm/i2c: tda998x: Move tda998x to a couple encoder/connector drm/tilcdc: Change the interface

[PATCH RFC 3/5] drm/i2c: tda998x: Add required properties

2014-03-17 Thread Jean-Francois Moine
The I2C address of the HDMI subdevice is needed for the driver to be loaded and initialized at system startup time. The origin of the video must be indicated by a reverse phandle according to the media video interface. Signed-off-by: Jean-Francois Moine moin...@free.fr --- Documentation

[PATCH RFC 4/5] drm/tilcd: dts: Add the video sink

2014-03-17 Thread Jean-Francois Moine
The connection between the video source and sink must follow the media video interface. Signed-off-by: Jean-Francois Moine moin...@free.fr --- Documentation/devicetree/bindings/drm/tilcdc/slave.txt | 18 -- .../devicetree/bindings/drm/tilcdc/tilcdc.txt | 6 ++ 2

[PATCH RFC 2/5] drm/tilcdc: Change the interface with the tda998x driver

2014-03-17 Thread Jean-Francois Moine
-Francois Moine moin...@free.fr --- drivers/gpu/drm/tilcdc/Makefile | 1 - drivers/gpu/drm/tilcdc/tilcdc_drv.c | 81 +-- drivers/gpu/drm/tilcdc/tilcdc_slave.c | 406 -- drivers/gpu/drm/tilcdc/tilcdc_slave.h | 26 --- 4 files changed, 64 insertions

[PATCH RFC 1/5] drm/i2c: tda998x: Move tda998x to a couple encoder/connector

2014-03-17 Thread Jean-Francois Moine
The 'slave encoder' structure of the tda998x driver asks for glue between the DRM driver and the encoder/connector structures. This patch changes the driver to a normal DRM encoder/connector thanks to the infrastructure for componentised subsystems. Signed-off-by: Jean-Francois Moine moin

[PATCH RFC 5/5] ARM: AM33XX: dts: Change the tda998x description

2014-03-17 Thread Jean-Francois Moine
The tda998x being moved from a 'slave encoder' to a normal DRM encoder/connector and the tilcdc_slave glue being removed, the declaration of the HDMI transmitter description must be changed in the associated DTs. Signed-off-by: Jean-Francois Moine moin...@free.fr --- arch/arm/boot/dts/am335x

Re: [alsa-devel] [PATCH v3 2/4] ASoC: simple-card: dynamically allocate the DAI link and properties

2014-03-17 Thread Jean-Francois Moine
On Mon, 17 Mar 2014 11:29:42 +0200 Jyri Sarha jsa...@ti.com wrote: On 03/15/2014 01:09 PM, Jean-Francois Moine wrote: The DAI link array and the properties (fmt, sysclk slots) are hard-coded for a single CPU / CODEC link. This patch dynamically allocates the DAI link array

Re: [PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links

2014-03-18 Thread Jean-Francois Moine
On Mon, 17 Mar 2014 16:43:39 + Mark Brown broo...@kernel.org wrote: On Sat, Mar 15, 2014 at 12:30:05PM +0100, Jean-Francois Moine wrote: [snip] +sound { + compatible = simple-audio-card; + simple-audio-card,name = Cubox Audio; + + simple-audio-card,cpu@0

Re: [PATCH 1/4] ASoC: simple-card: Fix device node locks

2014-02-24 Thread Jean-Francois Moine
On Mon, 24 Feb 2014 02:17:00 + li.xi...@freescale.com li.xi...@freescale.com wrote: @@ -169,22 +164,26 @@ static int asoc_simple_card_parse_of(struct device_node *node, /* CPU sub-node */ ret = -EINVAL; np = of_get_child_by_name(node, simple-audio-card,cpu); - if

Re: [alsa-devel] [PATCH 2/4] ASoC: simple-card: dynamically allocate the DAI link array

2014-02-25 Thread Jean-Francois Moine
On Mon, 24 Feb 2014 03:32:02 + li.xi...@freescale.com li.xi...@freescale.com wrote: @@ -20,7 +20,6 @@ struct simple_card_data { unsigned int daifmt; struct asoc_simple_dai cpu_dai; struct asoc_simple_dai codec_dai; - struct snd_soc_dai_link snd_link; };

[PATCH v2 3/4] ASoC: simple-card: accept many DAI links

2014-03-11 Thread Jean-Francois Moine
Some simple audio cards may have many DAI links. This patch extends the simple-card driver for handling such cards. Signed-off-by: Jean-Francois Moine moin...@free.fr --- sound/soc/generic/simple-card.c | 132 ++-- 1 file changed, 85 insertions(+), 47

[PATCH v2 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links

2014-03-11 Thread Jean-Francois Moine
There may be many couples of CPU/CODEC DAI links. The example 2 is extracted from the Cubox DT. Signed-off-by: Jean-Francois Moine moin...@free.fr --- .../devicetree/bindings/sound/simple-card.txt | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git

[PATCH v2 1/4] ASoC: simple-card: Fix the reference count of device nodes

2014-03-11 Thread Jean-Francois Moine
The reference count of some device nodes is not correctly reset at end of card probe. Signed-off-by: Jean-Francois Moine moin...@free.fr --- sound/soc/generic/simple-card.c | 50 ++--- 1 file changed, 37 insertions(+), 13 deletions(-) diff --git a/sound/soc

[PATCH v2 2/4] ASoC: simple-card: dynamically allocate the DAI link array

2014-03-11 Thread Jean-Francois Moine
The DAI link array is hard-coded as a single CPU / CODEC link. This patch allocates this array with the card definition and facilitates handling more DAI links. Signed-off-by: Jean-Francois Moine moin...@free.fr --- sound/soc/generic/simple-card.c | 8 +--- 1 file changed, 5 insertions

[PATCH v2 0/4] ASoC: simple-card: DT fix and multi DAI links extension

2014-03-11 Thread Jean-Francois Moine
size array instead of an implicit area for the DAI links (Li Xiubo) - update the reference count of the device node at end of probe Jean-Francois Moine (4): ASoC: simple-card: Fix the reference count of device nodes ASoC: simple-card: dynamically allocate the DAI link

Re: [alsa-devel] [PATCH] ASoC: simple-card: fix one bug to writing to the platform data

2014-01-09 Thread Jean-Francois Moine
Xiubo Li wrote: It's a bug that writing to the platform data directly, for it should be constant. So just copy it before writing. Signed-off-by: Xiubo Li Li.Xiubo at freescale.com --- sound/soc/generic/simple-card.c | 40 +--- 1 file changed, 21

Re: [PATCH v2 26/28] drm/i2c: tda998x: code optimization

2014-01-12 Thread Jean-Francois Moine
On Sat, 11 Jan 2014 18:55:09 + Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Jan 09, 2014 at 12:07:25PM +0100, Jean-Francois Moine wrote: This patch reduces the number of I2C exchanges by setting many bits in one write and removing a useless write. Signed-off

Re: [PATCH v2 26/28] drm/i2c: tda998x: code optimization

2014-01-12 Thread Jean-Francois Moine
On Sun, 12 Jan 2014 09:45:33 + Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Sun, Jan 12, 2014 at 09:22:01AM +0100, Jean-Francois Moine wrote: On Sat, 11 Jan 2014 18:55:09 + Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Jan 09, 2014 at 12:07:25PM

Re: [PATCH v2 20/28] drm/i2c: tda998x: move the TBG_CNTRL_0 register setting

2014-01-12 Thread Jean-Francois Moine
On Sat, 11 Jan 2014 18:36:48 + Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Jan 09, 2014 at 12:06:07PM +0100, Jean-Francois Moine wrote: According to the comment, the TBG_CNTRL_0 register must be set at the end of the mode change sequence. So you believe comments

Re: [PATCH v2 20/28] drm/i2c: tda998x: move the TBG_CNTRL_0 register setting

2014-01-12 Thread Jean-Francois Moine
On Sun, 12 Jan 2014 12:31:59 + Russell King - ARM Linux li...@arm.linux.org.uk wrote: So, in my patch 9, I was writing the REG_TBG_CNTRL_1 after writing REG_TBG_CNTRL_0, and you refused it. Here, I write REG_TBG_CNTRL_0 after the write of REG_TBG_CNTRL_1 in the HDMI sequence, and you

Re: [PATCH v2 13/28] drm/i2c: tda998x: use irq for connection status and EDID read

2014-01-12 Thread Jean-Francois Moine
On Sat, 11 Jan 2014 19:35:21 +0100 Sebastian Hesselbarth sebastian.hesselba...@gmail.com wrote: At least for the DT part, I'd suggest to not ask for interrupt directly but use a proper gpios property. The can of course be converted to priv-int_irq in some tda998x_dt_probe. May you give me

Re: [PATCH v2 23/28] drm/i2c: tda998x: add the active aspect in HDMI AVI frame

2014-01-13 Thread Jean-Francois Moine
On Sat, 11 Jan 2014 18:51:14 + Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Jan 09, 2014 at 12:06:39PM +0100, Jean-Francois Moine wrote: This patch adds the active aspect as 'picture' in the HDMI AVI frame and also some comments about this frame. Yes, this should've

Re: [PATCH v2 17/28] drm/i2c: tda998x: set the repeat PLL value in range 0..3

2014-01-13 Thread Jean-Francois Moine
On Sat, 11 Jan 2014 18:26:02 + Russell King - ARM Linux li...@arm.linux.org.uk wrote: div = 148500 / mode-clock; + if (div != 0) { + div--; + if (div 3) + div = 3; + } As the driver currently stands, we know that the clock

Re: [PATCH v2 15/28] drm/i2c: tda998x: use the tda998x video format when cea mode

2014-01-13 Thread Jean-Francois Moine
On Sat, 11 Jan 2014 18:18:32 + Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Jan 09, 2014 at 12:04:48PM +0100, Jean-Francois Moine wrote: This patch uses the tda998x video format tied to the CEA mode. This reduces the number of i2c exchanges. It is my understanding

Re: [PATCH v2 15/28] drm/i2c: tda998x: use the tda998x video format when cea mode

2014-01-13 Thread Jean-Francois Moine
On Mon, 13 Jan 2014 16:13:34 + Russell King - ARM Linux li...@arm.linux.org.uk wrote: Sorry, I don't see what bearing your response to my reply has. Simply that NXP people better like to use the cea mode. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef |

Re: [PATCH v2 15/28] drm/i2c: tda998x: use the tda998x video format when cea mode

2014-01-13 Thread Jean-Francois Moine
On Mon, 13 Jan 2014 16:35:01 + Russell King - ARM Linux li...@arm.linux.org.uk wrote: Ah, I see. It's a thread about your DRM driver, and about the lack of audio on 1080 resolutions. Taking it in context, the reported issue appears to be lack of video when 1080p is selected, but the

Re: [alsa-devel] [RFC][PATCH] ASoC: simple-card: Add asoc_simple_card_data for the simple card driver data

2014-01-14 Thread Jean-Francois Moine
and snd_card are of no use, so move them from struct asoc_simple_card_info to struct asoc_simple_card_data. And now only one DAI link is supported for simple card. Suggested-by: Jean-Francois Moine moin...@free.fr Signed-off-by: Xiubo Li li.xi...@freescale.com --- This patch

[PATCH] ASoC: simple-card: simplify code

2014-01-14 Thread Jean-Francois Moine
This patch - removes the fields of the platform data which are of no use to the non-DT platform callers, - uses a new private structure to handle all the sound card information, - simplifies the code and make easier a possible multi-DAI links extension. Signed-off-by: Jean-Francois Moine moin

Re: [PATCH] ASoC: simple-card: simplify code

2014-01-14 Thread Jean-Francois Moine
On Tue, 14 Jan 2014 14:20:14 + Mark Brown broo...@kernel.org wrote: On Tue, Jan 14, 2014 at 12:36:06PM +0100, Jean-Francois Moine wrote: This patch - removes the fields of the platform data which are of no use to the non-DT platform callers, - uses a new private structure to handle

Re: [PATCH RESEND v3] clk: return probe defer when DT clock not yet ready

2014-02-19 Thread Jean-Francois Moine
On Mon, 25 Nov 2013 19:47:04 +0100 Jean-Francois Moine moin...@free.fr wrote: At probe time, a clock device may not be ready when some other device wants to use it. This patch lets the functions clk_get/devm_clk_get return a probe defer when the clock is defined in the DT but not yet

[PATCH 2/4] ASoC: simple-card: dynamically allocate the DAI link array

2014-02-21 Thread Jean-Francois Moine
The DAI link array is hard-coded as a single CPU / CODEC DAIs link. This patch allocates this array with the card definition and facilitates handling more links. Signed-off-by: Jean-Francois Moine moin...@free.fr --- sound/soc/generic/simple-card.c | 7 --- 1 file changed, 4 insertions

[PATCH 3/4] ASoC: simple-card: accept many DAI links

2014-02-21 Thread Jean-Francois Moine
Some simple audio cards may have many DAI links. This patch makes them handled by the simple-card driver. Signed-off-by: Jean-Francois Moine moin...@free.fr --- sound/soc/generic/simple-card.c | 100 ++-- 1 file changed, 66 insertions(+), 34 deletions(-) diff

[PATCH 4/4] ASoC: simple-card: add DT documentation for multi-DAI links

2014-02-21 Thread Jean-Francois Moine
There may be many couples of CPU/CODEC DAI links. The example 2 is extracted from the Cubox DT. Signed-off-by: Jean-Francois Moine moin...@free.fr --- .../devicetree/bindings/sound/simple-card.txt | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git

[PATCH 1/4] ASoC: simple-card: Fix device node locks

2014-02-21 Thread Jean-Francois Moine
Some device nodes stay locked and some other ones are not locked while being used during the card lifetime. Signed-off-by: Jean-Francois Moine moin...@free.fr --- sound/soc/generic/simple-card.c | 51 +++-- 1 file changed, 39 insertions(+), 12 deletions

[PATCH 0/4] ASoC: simple-card: DT fix and multi DAI links extension

2014-02-21 Thread Jean-Francois Moine
This patch series fixes a small problem about node device locks and also extends the simple card driver to handle many DAI links as this exists in the Cubox audio subsystem. Jean-Francois Moine (4): ASoC: simple-card: Fix device node locks ASoC: simple-card: dynamically allocate the DAI link

[PATCH] drm/i2c: tda998x: fix memory leak in case of i2c error

2014-02-13 Thread Jean-Francois Moine
When the creation of the second i2c client was failing, the private buffer was not freed. This bug was introduced by the commit 6ae668cc19e8 'drm/i2c: tda998x: check the CEC device creation' Signed-off-by: Jean-Francois Moine moin...@free.fr --- drivers/gpu/drm/i2c/tda998x_drv.c | 4 +++- 1

Re: [PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links

2014-03-19 Thread Jean-Francois Moine
On Wed, 19 Mar 2014 12:08:55 +0200 Jyri Sarha jsa...@ti.com wrote: sound { compatible = simple-audio-card; simple-audio-card,name = Simple Audio; simple-audio-card,widgets = ... simple-audio-card,routing = ... simple-audio-card,dai-link@0 { /* I2S -

[PATCH] ASoC: tda998x: Fix lack of required reg in DT documentation

2014-03-20 Thread Jean-Francois Moine
The I2C address (reg) is required for the TDA998x driver to be loaded and initialized. Signed-off-by: Jean-Francois Moine moin...@free.fr --- This patch applies to linux-next. --- Documentation/devicetree/bindings/drm/i2c/tda998x.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH] ASoC: tda998x: Fix lack of required reg in DT documentation

2014-03-20 Thread Jean-Francois Moine
On Thu, 20 Mar 2014 13:32:24 +0100 Sebastian Hesselbarth sebastian.hesselba...@gmail.com wrote: + - reg: I2C address - must be 0x70 TDA9983b datasheet says: Bits A0 and A1 of the I2C-bus device address are externally selected by pins A0 and A1. Therefore, 0x70, 0x71, 0x72, and 0x73

Re: [PATCH] ASoC: tda998x: Fix lack of required reg in DT documentation

2014-03-20 Thread Jean-Francois Moine
On Thu, 20 Mar 2014 14:01:56 +0100 Jean-Francois Moine moin...@free.fr wrote: For other boards using the TDA998x family, if the I2C address is different from 0x70, have you an idea about what can be the CEC I2C address? (this value is actually hard-coded in the TDA998x driver) I had a look

Re: [PATCH] ASoC: tda998x: Fix lack of required reg in DT documentation

2014-03-20 Thread Jean-Francois Moine
On Thu, 20 Mar 2014 14:32:18 +0100 Sebastian Hesselbarth sebastian.hesselba...@gmail.com wrote: Ok, I had another round of google'ing and found this: http://hipstercircuits.com/wp-content/uploads/2013/05/TDA19988.pdf There, the datasheet specifically for TDA19988 only states 0x70 and 0x34

Re: [PATCH] ASoC: tda998x: Fix lack of required reg in DT documentation

2014-03-20 Thread Jean-Francois Moine
On Thu, 20 Mar 2014 14:31:10 + Russell King - ARM Linux li...@arm.linux.org.uk wrote: 1. change the DT compatible strings the driver has to accept both nxp,tda19988 and nxp,tda19989, and set the appropriate device in the DT file (tda19988). I'm a bit nervous about using

Re: [PATCH] ASoC: tda998x: Fix lack of required reg in DT documentation

2014-03-20 Thread Jean-Francois Moine
On Thu, 20 Mar 2014 15:19:34 + Russell King - ARM Linux li...@arm.linux.org.uk wrote: I'm not saying that it has to match the physical device fitted - I'm merely suggesting not using nxp,tda1998x which could (and as Sebastian has found, does) conflict with other devices with different

[PATCH v2] ASoC: tda998x: Fix lack of required reg in DT documentation

2014-03-20 Thread Jean-Francois Moine
The I2C address (reg) is required for the TDA998x driver to be loaded and initialized. Signed-off-by: Jean-Francois Moine moin...@free.fr --- - v2 - don't force the I2C address to be 0x70 This patch applies to linux-next. --- Documentation/devicetree/bindings/drm/i2c/tda998x.txt | 2

[PATCH] ASoC: tda998x: Change the compatible strings

2014-03-20 Thread Jean-Francois Moine
The tda998x driver accepts 3 chips only from the TDA998x family. This patch changes the driver to accept only these chips. Signed-off-by: Jean-Francois Moine moin...@free.fr --- Documentation/devicetree/bindings/drm/i2c/tda998x.txt | 4 ++-- drivers/gpu/drm/i2c/tda998x_drv.c

[PATCH v3] drm/i2c: tda998x: Fix lack of required reg in DT documentation

2014-03-21 Thread Jean-Francois Moine
The I2C address (reg) is required for the TDA998x driver to be loaded and initialized. Signed-off-by: Jean-Francois Moine moin...@free.fr --- - v3 - change subject to drm/i2c - v2 - don't force the I2C address to be 0x70 This patch applies to linux-next. --- Documentation

  1   2   3   4   5   6   7   8   9   10   >