Hi Masahiro,
On 24-06-14 14:53, Masahiro Yamada wrote:
On Thu, 12 Jun 2014 23:40:54 +0200
Jeroen Hofstee jer...@myspectrum.nl wrote:
KBuild (ab)uses the asm statement to write to a file and
llvm integrated as chokes about these invalid asm statements.
Workaround it by making it look like
Hello Masahiro,
On 27-06-14 08:38, Masahiro Yamada wrote:
KBuild (ab)uses the asm statement to write to a file and
llvm integrated as chokes about these invalid asm statements.
Workaround it by making it look like valid asm code.
Signed-off-by: Jeroen Hofstee jer...@myspectrum.nl
I think
Hello Hans,
On 31-07-14 16:21, Hans de Goede wrote:
This fixes the following compiler warning:
In file included from scripts/kconfig/zconf.tab.c:2537:0:
scripts/kconfig/menu.c: In function ‘get_symbol_str’:
scripts/kconfig/menu.c:590:18: warning: ‘jump’ may be used uninitialized in
this
Hello Hans,
On 31-07-14 16:21, Hans de Goede wrote:
This fixes the following compiler warning:
In file included from scripts/kconfig/zconf.tab.c:2537:0:
scripts/kconfig/menu.c: In function ‘get_symbol_str’:
scripts/kconfig/menu.c:590:18: warning: ‘jump’ may be used uninitialized in
this
Hello Hans,
On 12-10-14 12:25, Hans de Goede wrote:
Hi,
This one seems to have fallen through the cracks.
Regards,
Hans
(for U-boot)
nope, you replace an innocent warning (_might_ be) with
bad code, without any comment it is just because gcc failed
to recognize it is fine. Nor did you
Hello Simon,
On 13-10-14 07:14, Simon Glass wrote:
Hi Jeroen,
On 12 October 2014 10:13, Jeroen Hofstee jer...@myspectrum.nl wrote:
Hello Hans,
On 12-10-14 12:25, Hans de Goede wrote:
Hi,
This one seems to have fallen through the cracks.
Regards,
Hans
(for U-boot)
nope, you replace
Hi,
On 22-05-15 12:05, Yann Droneaud wrote:
Le mardi 05 mai 2015 à 11:41 -0500, Rob Herring a écrit :
On Tue, May 5, 2015 at 5:05 AM, Yann Droneaud ydrone...@opteya.com
wrote:
I believe Device Tree Blob (.dtb file) built from kernel's Device
Tree
Sources (.dts, which #include .dtsi, which
Hello Tony,
On 28-10-16 17:52, Tony Lindgren wrote:
* Jeroen Hofstee <jhofs...@victronenergy.com> [161028 08:33]:
Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac
id to common file") did not only move the code for an am3517, it also
added the slave para
Hello Tony,
On 21-10-16 09:53, Tony Lindgren wrote:
* Jeroen Hofstee <jhofs...@victronenergy.com> [161021 00:37]:
Hello Tony,
On 21-10-16 08:38, Tony Lindgren wrote:
* Jeroen Hofstee <jhofs...@victronenergy.com> [161020 12:57]:
Commit b6745f6e4e63 ("drivers: net: cpsw: d
Hello Tony,
On 21-10-16 08:38, Tony Lindgren wrote:
* Jeroen Hofstee <jhofs...@victronenergy.com> [161020 12:57]:
Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac
id to common file") did not only move the code for an am3517, it also
added the slave para
has a
check for netif_running it returns 0 and doesn't call napi_complete and hence
violates the napi its expectation.
So remove this check, so either napi_complete is called or quota is returned.
Signed-off-by: Jeroen Hofstee <jhofs...@victronenergy.com>
---
drivers/net/can/ti_hecc.c | 3
Hi Masahiro,
On 24-06-14 14:53, Masahiro Yamada wrote:
On Thu, 12 Jun 2014 23:40:54 +0200
Jeroen Hofstee wrote:
KBuild (ab)uses the asm statement to write to a file and
llvm integrated as chokes about these invalid asm statements.
Workaround it by making it look like valid asm code.
Signed
Hello Masahiro,
On 27-06-14 08:38, Masahiro Yamada wrote:
KBuild (ab)uses the asm statement to write to a file and
llvm integrated as chokes about these invalid asm statements.
Workaround it by making it look like valid asm code.
Signed-off-by: Jeroen Hofstee
I think Linux has the same
Hello Hans,
On 31-07-14 16:21, Hans de Goede wrote:
This fixes the following compiler warning:
In file included from scripts/kconfig/zconf.tab.c:2537:0:
scripts/kconfig/menu.c: In function ‘get_symbol_str’:
scripts/kconfig/menu.c:590:18: warning: ‘jump’ may be used uninitialized in
this
Hello Hans,
On 31-07-14 16:21, Hans de Goede wrote:
This fixes the following compiler warning:
In file included from scripts/kconfig/zconf.tab.c:2537:0:
scripts/kconfig/menu.c: In function ‘get_symbol_str’:
scripts/kconfig/menu.c:590:18: warning: ‘jump’ may be used uninitialized in
this
has a
check for netif_running it returns 0 and doesn't call napi_complete and hence
violates the napi its expectation.
So remove this check, so either napi_complete is called or quota is returned.
Signed-off-by: Jeroen Hofstee
---
drivers/net/can/ti_hecc.c | 3 ---
1 file changed, 3 deletions
on a normal functioning CAN-bus. So stop counting them
as errors.
For completeness, the Kvaser USB hybra also increments the tx_error
on arbitration lose, but it does so in single shot. Since in that
case the message is not retried, that behaviour is kept.
Signed-off-by: Jeroen Hofstee
---
drivers/net
Hello Marc,
On 7/24/19 10:26 AM, Marc Kleine-Budde wrote:
> On 4/29/19 2:03 PM, Jeroen Hofstee wrote:
>> As already mentioned in [1] and included in [2], there is an off by one
>> issue since the high bank is already enabled when the _next_ mailbox to
>> be read has index 12,
-semiconductors.com/media/ip_modules/pdf_2/c_can_fd8/users_manual_c_can_fd8_r210_1.pdf
Signed-off-by: Jeroen Hofstee
---
drivers/net/can/c_can/c_can.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_can.c
index 606b7d8ffe13
rectly to ERROR_ACTIVE again.
Signed-off-by: Jeroen Hofstee
---
drivers/net/can/c_can/c_can.c | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_can.c
index 502a181d02e7..5cfaab18e10b 100644
--- a/drivers/net/can
-semiconductors.com/media/ip_modules/pdf_2/c_can_fd8/users_manual_c_can_fd8_r210_1.pdf
Signed-off-by: Jeroen Hofstee
---
drivers/net/can/c_can/c_can.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_can.c
index 606b7d8ffe13
rectly to ERROR_ACTIVE again.
Signed-off-by: Jeroen Hofstee
Acked-by: Kurt Van Dijck
Tested-by: Kurt Van Dijck
---
drivers/net/can/c_can/c_can.c | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_can.c
Hello Marc,
On 10/1/19 4:32 PM, Marc Kleine-Budde wrote:
> On 9/26/19 10:50 AM, Jeroen Hofstee wrote:
>> When the C_CAN interface is closed it is put in power down mode, but
>> does not reset the error counters / state. So reset the D_CAN on open,
>> so the reported state
cd28d1d6e52e: ("net: phy: at803x: Disable phy delay for RGMII mode") broke
the ethernet networking on the beaglebone enhanced.
The board relied on the bug in the at803x driver to always enable the rx
delay. So change the phy-mode to rgmii-id so it is enabled again.
Signed-off-by: Jero
Hello Grygorri,
On 10/2/19 4:48 PM, Grygorii Strashko wrote:
>
>
> On 02/10/2019 12:54, Jeroen Hofstee wrote:
>> cd28d1d6e52e: ("net: phy: at803x: Disable phy delay for RGMII mode")
>> broke
>> the ethernet networking on the beaglebone enhanced.
>
Hello Tony,
On 10/8/19 4:23 PM, Tony Lindgren wrote:
> * Grygorii Strashko [191003 02:32]:
>> On 03/10/2019 11:16, Jeroen Hofstee wrote:
>>> Furthermore 4.19 is fine, so there is no need to include it in stable
>>> and have a note to make sure also other patches are
Hello Tony,
On 10/8/19 4:23 PM, Tony Lindgren wrote:
> * Grygorii Strashko [191003 02:32]:
>> On 03/10/2019 11:16, Jeroen Hofstee wrote:
>>> Furthermore 4.19 is fine, so there is no need to include it in stable
>>> and have a note to make sure also other patches are
Hello Tony,
On 10/8/19 6:14 PM, Tony Lindgren wrote:
> * Jeroen Hofstee [191008 16:03]:
>> Hello Tony,
>>
>> On 10/8/19 4:23 PM, Tony Lindgren wrote:
>>> * Grygorii Strashko [191003 02:32]:
>>>> On 03/10/2019 11:16, Jeroen Hofstee wrote:
>>&
Hi,
On 10/8/19 6:51 PM, Tony Lindgren wrote:
> * Jeroen Hofstee [191008 16:43]:
>> Hello Tony,
>>
>> On 10/8/19 6:14 PM, Tony Lindgren wrote:
>>> * Jeroen Hofstee [191008 16:03]:
>>>> Hello Tony,
>>>>
>>>> On 10/8/19 4:23
Hello Grygorri,
On 10/9/19 11:43 AM, Grygorii Strashko wrote:
>
>
>>> Grygorii doesn't suggest to add a fixes tag, just to change the
>>> referenced
>>> commit to another. Obviously I would like to understand why another
>>> commit
>>> should be referenced. And then I should read and parse the
Hello Marc,
On 10/9/19 3:18 PM, Marc Kleine-Budde wrote:
> Hello Jeroen,
>
> I'm currently looking at the rx-offload error handling in detail.
>
> TLDR: I've added the patch to linux-can.
>
> Thanks,
> Marc
>
> For the record, the details:
>
> On 9/24/19 8:4
Hi,
On 10/15/19 7:57 AM, Simon Horman wrote:
> On Mon, Oct 14, 2019 at 11:04:28PM +0800, kbuild test robot wrote:
>> From: kbuild test robot
>>
>> drivers/net/can/m_can/m_can.c:783:9-10: WARNING: return of 0/1 in function
>> 'is_protocol_err' with return type bool
>>
>> Return statements in
Hello Simon,
On 10/15/19 9:13 AM, Simon Horman wrote:
> On Tue, Oct 15, 2019 at 06:37:54AM +0000, Jeroen Hofstee wrote:
>> Hi,
>>
>> On 10/15/19 7:57 AM, Simon Horman wrote:
>>> On Mon, Oct 14, 2019 at 11:04:28PM +0800, kbuild test robot wrote:
>>>> From
to discard them directly.
Signed-off-by: Jeroen Hofstee
---
drivers/net/can/rx-offload.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/rx-offload.c b/drivers/net/can/rx-offload.c
index e6a668ee7730..39df41280e2d 100644
--- a/drivers/net/can/rx-offload.c
+++ b/drivers
Release the mailbox after reading it, so it can be reused a bit earlier.
Since "can: rx-offload: continue on error" all pending message bits are
cleared directly, so remove clearing them in ti_hecc.
Suggested-by: Marc Kleine-Budde
Signed-off-by: Jeroen Hofstee
---
drivers/net/can/ti_
in the middle of a message, by disabling
the tranceiver while the CPK is sending.
Since the CPK is disabled after normal power on, it is typically only
seen when the interface is restarted.
Signed-off-by: Jeroen Hofstee
---
drivers/net/can/ti_hecc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
be partially updated.
Signed-off-by: Jeroen Hofstee
---
drivers/net/can/ti_hecc.c | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/drivers/net/can/ti_hecc.c b/drivers/net/can/ti_hecc.c
index 35c82289f2a3..4206ad5cb666 100644
--- a/drivers/net/can/ti_hecc.c
+++ b
, it is completely unrelated.
And use net_ratelimit to make checkpatch happy.
Signed-off-by: Jeroen Hofstee
---
drivers/net/can/ti_hecc.c | 156 --
1 file changed, 82 insertions(+), 74 deletions(-)
diff --git a/drivers/net/can/ti_hecc.c b/drivers/net/can/ti_hecc.c
on the
error counters, when the state is not error active and goes down again.
Signed-off-by: Jeroen Hofstee
---
drivers/net/can/ti_hecc.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/net/can/ti_hecc.c b/drivers/net/can/ti_hecc.c
index 6098725bfdea..c7c866da9c6a 100644
with HECC_CANME (while holding a spinlock). So lets just
always keep MIM set.
While at it, since the mailbox direction never changes, don't set it
every time a message is send, ti_hecc_reset already sets them to tx.
Signed-off-by: Jeroen Hofstee
---
drivers/net/can/ti_hecc.c | 6 +++---
1 file changed
rectly to ERROR_ACTIVE again.
Signed-off-by: Jeroen Hofstee
Cc: Stephane Grosjean
---
drivers/net/can/usb/peak_usb/pcan_usb.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/net/can/usb/peak_usb/pcan_usb.c
b/drivers/net/can/usb/peak_usb/pcan_usb.c
Hello Marc,
On 7/26/19 1:48 PM, Marc Kleine-Budde wrote:
> On 4/29/19 2:03 PM, Jeroen Hofstee wrote:
>
>> @@ -744,8 +652,8 @@ static irqreturn_t ti_hecc_interrupt(int irq, void
>> *dev_id)
>> struct net_device *ndev = (struct net_device *)dev_id;
>>
Hello Hans,
On 12-10-14 12:25, Hans de Goede wrote:
Hi,
This one seems to have fallen through the cracks.
Regards,
Hans
(for U-boot)
nope, you replace an innocent warning (_might_ be) with
bad code, without any comment it is just because gcc failed
to recognize it is fine. Nor did you
Hello Simon,
On 13-10-14 07:14, Simon Glass wrote:
Hi Jeroen,
On 12 October 2014 10:13, Jeroen Hofstee wrote:
Hello Hans,
On 12-10-14 12:25, Hans de Goede wrote:
Hi,
This one seems to have fallen through the cracks.
Regards,
Hans
(for U-boot)
nope, you replace an innocent warning
Hi,
On 22-05-15 12:05, Yann Droneaud wrote:
Le mardi 05 mai 2015 à 11:41 -0500, Rob Herring a écrit :
On Tue, May 5, 2015 at 5:05 AM, Yann Droneaud
wrote:
I believe Device Tree Blob (.dtb file) built from kernel's Device
Tree
Sources (.dts, which #include .dtsi, which #include .h) using
Hello Tony,
On 28-10-16 17:52, Tony Lindgren wrote:
* Jeroen Hofstee [161028 08:33]:
Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac
id to common file") did not only move the code for an am3517, it also
added the slave parameter, resulting in an invalid (all
Hello Tony,
On 21-10-16 08:38, Tony Lindgren wrote:
* Jeroen Hofstee [161020 12:57]:
Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac
id to common file") did not only move the code for an am3517, it also
added the slave parameter, resulting in a invalid (all
Hello Tony,
On 21-10-16 09:53, Tony Lindgren wrote:
* Jeroen Hofstee [161021 00:37]:
Hello Tony,
On 21-10-16 08:38, Tony Lindgren wrote:
* Jeroen Hofstee [161020 12:57]:
Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac
id to common file") did not
Hello Vincent,
On 1/10/21 11:35 AM, Vincent Mailhol wrote:
Call skb_tx_timestamp() within can_put_echo_skb() so that a software
tx timestamp gets attached on the skb.
[..]
diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c
index 3486704c8a95..3904e0874543 100644
---
49 matches
Mail list logo
