Re: [PATCH v4 0/3] x86, apic, kexec: Add disable_cpu_apic kernel parameter

2013-11-06 Thread jerry . hoemann
I am still pursuing the issue of the 2.6.32 kernel on our proto, I believe this patch is good and should be accepted. thanks Jerry -- Jerry HoemannSoftware Engineer Hewlett-Packard/MODL

Re: [edk2] Corrupted EFI region

2013-09-13 Thread jerry . hoemann
haven't been focused there. So we are definitely interested in finding a mechanism to not do this reservation on platforms that don't have the issues described earlier in this thread. thanks, Jerry -- Jerry Hoemann

Re: [edk2] Corrupted EFI region

2013-09-18 Thread jerry . hoemann
-- Jerry HoemannSoftware Engineer Hewlett-Packard/MODL 3404 E Harmony Rd. MS 57phone: (970) 898-1022 Ft. Collins, CO 80528 FAX:(970) 898- email: jerry.hoem...@hp.com

[PATCH 0/3] Early use of boot service memory

2013-11-11 Thread Jerry Hoemann
. With this information, setup_arch avoids calling efi_reserve_boot_services and fragmenting memory. Jerry Hoemann (3): efi: Early use of boot service memory x86: avoid efi_reserve_boot_services x86, efi: Early use of boot service memory Documentation/kernel-parameters.txt | 8 arch/x86

[PATCH 3/3] x86, efi: Early use of boot service memory

2013-11-11 Thread Jerry Hoemann
Extend the kernel parameter add_efi_memmap to have additional optional arguement correct. EFI memmaps that are correct aren't accessed by platform firmware after a call to Exit Boot Services. Signed-off-by: Jerry Hoemann jerry.hoem...@hp.com --- Documentation/kernel-parameters.txt | 8

[PATCH 1/3] efi: Early use of boot service memory

2013-11-11 Thread Jerry Hoemann
Add #define to allow for specifying that firmware doesn't reuse boot service code or data after Exit Boot Service. Signed-off-by: Jerry Hoemann jerry.hoem...@hp.com --- include/linux/efi.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/efi.h b/include/linux/efi.h index 5f8f176

[PATCH 2/3] x86: avoid efi_reserve_boot_services

2013-11-11 Thread Jerry Hoemann
, this reservation fragments memory which can cause large allocations early in boot (e.g. crash kernel) to fail. Avoid calling efi_reserve_boot_services if the memmap is correct. Signed-off-by: Jerry Hoemann jerry.hoem...@hp.com --- arch/x86/kernel/setup.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH 0/3] Early use of boot service memory

2013-11-12 Thread jerry . hoemann
On Tue, Nov 12, 2013 at 12:37:29PM +0200, Pekka Enberg wrote: On Tue, Nov 12, 2013 at 4:15 AM, Jerry Hoemann jerry.hoem...@hp.com wrote: Some platform have firmware that violates UEFI spec and access boot service code or data segments after the system has called Exit Boot Services. The call

Re: [PATCH 0/3] Early use of boot service memory

2013-11-12 Thread jerry . hoemann
has been discussed, but I don't recall seeing a resolution. If I missed this, point me in right direction. :) thanks Jerry -- Jerry HoemannSoftware Engineer Hewlett-Packard/MODL 3404 E

Re: [PATCH v4 0/3] x86, apic, kexec: Add disable_cpu_apic kernel parameter

2013-11-13 Thread jerry . hoemann
different distros. These are not the same as long term kernels on kernel.org. I see you've posted an updated version of the patch. i've picked it up and will test. -- Jerry HoemannSoftware Engineer

Re: [PATCH 0/3] Early use of boot service memory

2013-11-13 Thread jerry . hoemann
. Or, we change the call to efi_reserve_boot_services not apply to all platforms. The problems for pre 3.9 based distros is worse as they don't have ability to allocate crash kernel high. Jerry Jerry Hoemann jerry.hoem...@hp.com wrote: Some platform have firmware that violates UEFI spec

Re: [PATCH 0/3] Early use of boot service memory

2013-11-13 Thread jerry . hoemann
platforms that don't have that bug. Its just much less likely to cause problems with higher crash kernel allocation. -- Jerry HoemannSoftware Engineer Hewlett-Packard/MODL 3404 E Harmony Rd

Re: [PATCH 0/3] Early use of boot service memory

2013-11-13 Thread jerry . hoemann
-- Jerry HoemannSoftware Engineer Hewlett-Packard/MODL 3404 E Harmony Rd. MS 57phone: (970) 898-1022 Ft. Collins, CO 80528 FAX:(970) 898- email: jerry.hoem

Re: [PATCH 0/3] Early use of boot service memory

2013-11-14 Thread jerry . hoemann
for it instead of special-casing for 'proper firmware' because it makes testing the kernel more difficult. Pekka -- Jerry HoemannSoftware Engineer Hewlett-Packard 3404 E

Re: [PATCH 0/3] Early use of boot service memory

2013-11-14 Thread jerry . hoemann
that life is optional, how can one argue any piece of software be an absolute must? :) :) Jerry Pekka -- Jerry HoemannSoftware Engineer Hewlett-Packard/MODL

Re: [PATCH 0/3] Early use of boot service memory

2013-11-15 Thread jerry . hoemann
-- Jerry HoemannSoftware Engineer Hewlett-Packard 3404 E Harmony Rd. MS 57phone: (970) 898-1022 Ft. Collins, CO 80528 FAX:(970) 898-

Re: [PATCH 0/3] Early use of boot service memory

2013-11-15 Thread jerry . hoemann
a different view. Jerry Thanks, Ingo -- Jerry HoemannSoftware Engineer Hewlett-Packard 3404 E Harmony Rd. MS 57phone: (970) 898-1022 Ft. Collins, CO 80528

Re: [PATCH 0/3] Early use of boot service memory

2013-11-15 Thread jerry . hoemann
-- Jerry HoemannSoftware Engineer Hewlett-Packard 3404 E Harmony Rd. MS 57phone: (970) 898-1022 Ft. Collins, CO 80528 FAX:(970) 898- email: jerry.hoem...@hp.com

Re: [PATCH v9] x86, apic, kexec, Documentation: Add disable_cpu_apic kernel parameter

2013-12-04 Thread Jerry . Hoemann
with this patch being accepted upstream and working the intermittent 2.6.32 failures separately. Jerry -- Jerry HoemannSoftware Engineer Hewlett-Packard 3404 E Harmony Rd. MS 57

[PATCH] x86/mm: account for PGDIR_SIZE alignment

2013-04-29 Thread Jerry Hoemann
for by find_early_table_space and causes a kernel panic. Change is to take into account PGDIR_SIZE alignment in find_early_table_space. Signed-off-by: Jerry Hoemann jerry.hoem...@hp.com --- arch/x86/mm/init.c | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c index c22c423

Re: [PATCH v4 0/3] x86, apic, kexec: Add disable_cpu_apic kernel parameter

2013-10-30 Thread jerry . hoemann
-- Jerry HoemannSoftware Engineer Hewlett-Packard/MODL 3404 E Harmony Rd. MS 57phone: (970) 898-1022 Ft. Collins, CO 80528 FAX:(970) 898

Re: [PATCH v4 0/3] x86, apic, kexec: Add disable_cpu_apic kernel parameter

2013-11-01 Thread jerry . hoemann
-- Jerry HoemannSoftware Engineer Hewlett-Packard/MODL 3404 E Harmony Rd. MS 57phone: (970) 898-1022 Ft. Collins, CO 80528 FAX:(970) 898- email

Re: [PATCH v3 0/2] x86, apic, kdump: Disable BSP if boot cpu is AP

2013-10-21 Thread jerry . hoemann
boot the capture kernel when nr_cpus 1. thanks Jerry Hoemann v1 = v2) - Rebased on top of v3.12-rc5. - Fix linking time error of boot_cpu_is_bsp_init() in case of CONFIG_LOCAL_APIC disabled by adding empty static inline function instead. - Fix missing feature check by means

Re: [PATCH v4 0/3] x86, apic, kexec: Add disable_cpu_apic kernel parameter

2013-10-22 Thread jerry . hoemann
. HATAYAMA, Daisuke ___ kexec mailing list ke...@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec -- Jerry HoemannSoftware Engineer

Re: [PATCH V3 08/11] kexec: Disable at runtime if the kernel enforces module loading restrictions

2013-09-04 Thread jerry . hoemann
-info.html -- Jerry HoemannSoftware Engineer Hewlett-Packard/MODL 3404 E Harmony Rd. MS 57phone: (970) 898-1022 Ft. Collins, CO 80528 FAX:(970

Re: [PATCH 0/8] iommu/vt-d: Fix crash dump failure caused by legacy DMA/IO

2014-05-07 Thread Jerry Hoemann
considered and discounted for some reason? It seems like it would make sense. -- Bill Sumner Forwarded by Jerry Hoemann -- Jerry HoemannSoftware Engineer Hewlett-Packard 3404 E Harmony Rd. MS 57

Re: [RFC v2 0/2] Early use of boot service memory

2013-12-16 Thread jerry . hoemann
-- Jerry HoemannSoftware Engineer Hewlett-Packard 3404 E Harmony Rd. MS 57phone: (970) 898-1022 Ft. Collins, CO 80528 FAX:(970) 898-

Re: [PATCH v10] x86, apic, kexec, Documentation: Add disable_cpu_apic kernel parameter

2013-12-13 Thread jerry . hoemann
-- Jerry HoemannSoftware Engineer Hewlett-Packard 3404 E Harmony Rd. MS 57phone: (970) 898-1022 Ft. Collins, CO 80528 FAX:(970) 898-

Re: [PATCH 0/8] iommu/vt-d: Fix crash dump failure caused by legacy DMA/IO

2014-05-02 Thread Jerry Hoemann
-- Jerry HoemannSoftware Engineer Hewlett-Packard 3404 E Harmony Rd. MS 57phone: (970) 898-1022 Ft. Collins, CO 80528 FAX:(970) 898-

Re: [PATCH 0/8] iommu/vt-d: Fix crash dump failure caused by legacy DMA/IO

2014-07-11 Thread Jerry Hoemann
the patch set for 3.17? Jerry -- Jerry HoemannSoftware Engineer Hewlett-Packard 3404 E Harmony Rd. MS 57phone: (970) 898-1022 Ft. Collins, CO 80528

[RFC 1/1] fsnotify: next_i is freed during fsnotify_unmount_inodes.

2014-10-08 Thread Jerry Hoemann
During list_for_each_entry_safe, next_i is becoming free causing the loop to never terminate. Advance next_i in those cases where __iget is not done. Signed-off-by: Jerry Hoemann jerry.hoem...@hp.com --- fs/notify/inode_mark.c | 17 +++-- 1 file changed, 11 insertions(+), 6

[RFC 0/1] fsnotify: next_i is freed during fsnotify_unmount_inodes.

2014-10-08 Thread Jerry Hoemann
variable (from hours to days.) We ran the stress test on a 3.10 kernel with the proposed patch for a week without failure. Jerry Hoemann (1): fsnotify: next_i is freed during fsnotify_unmount_inodes. fs/notify/inode_mark.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions

Re: [PATCH 0/2] iommu/vt-d: Keep RMRR mappings around on driver unbind

2014-10-01 Thread Jerry Hoemann
-by: Jerry Hoemann jerry.hoem...@hp.com -- Jerry HoemannSoftware Engineer Hewlett-Packard 3404 E Harmony Rd. MS 36phone: (970) 898-1022 Ft. Collins, CO 80528

Re: [PATCH 2/2] iommu/vt-d: Only remove domain when device is removed

2014-12-11 Thread Jerry Hoemann
___ iommu mailing list io...@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu -- Jerry HoemannSoftware Engineer Hewlett-Packard 3404 E Harmony Rd. MS 36

Re: [PATCH 1/2] iommu/vt-d: Fix dmar_domain leak in iommu_attach_device

2014-12-17 Thread Jerry Hoemann
on of the VM. Looks good. Thanks! Tested-by: Jerry Hoemann jerry.hoem...@hp.com -- Jerry HoemannSoftware Engineer Hewlett-Packard 3404 E Harmony Rd. MS 36phone: (970) 898-1022

Re: [PATCH 2/2] iommu/vt-d: Remove dead code in device_notifier

2014-12-17 Thread Jerry Hoemann
executed during VM power on/power off. Thanks! Tested-by: Jerry Hoemann jerry.hoem...@hp.com -- Jerry HoemannSoftware Engineer Hewlett-Packard 3404 E Harmony Rd. MS 36phone

[PATCH 0/1] fsnotify: next_i is freed during

2014-10-10 Thread Jerry Hoemann
of the variable inode. The time to reproduce the hang is highly variable (from hours to days.) We ran the stress test on a 3.10 kernel with the proposed patch for a week without failure. Jerry Hoemann (1): fsnotify: next_i is freed during fsnotify_unmount_inodes. fs/notify/inode_mark.c | 17

[PATCH 1/1] fsnotify: next_i is freed during fsnotify_unmount_inodes.

2014-10-10 Thread Jerry Hoemann
During list_for_each_entry_safe, next_i is becoming free causing the loop to never terminate. Advance next_i in those cases where __iget is not done. Signed-off-by: Jerry Hoemann jerry.hoem...@hp.com --- fs/notify/inode_mark.c | 17 +++-- 1 file changed, 11 insertions(+), 6

Re: [PATCH 3/4] nvdimm: Add IOCTL pass thru

2015-11-10 Thread Jerry Hoemann
On Tue, Nov 10, 2015 at 11:24:47AM -0500, Jeff Moyer wrote: > Jerry Hoemann <jerry.hoem...@hpe.com> writes: > > > @@ -633,10 +718,11 @@ static int match_dimm(struct device *dev, void *data) > > > > static long nvdimm_ioctl(struct file *file, unsigned i

Re: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru.

2015-11-10 Thread Jerry Hoemann
On Tue, Nov 10, 2015 at 12:51:59PM -0500, Jeff Moyer wrote: > Jerry Hoemann <jerry.hoem...@hpe.com> writes: > > > Add IOCTL type 'P' to denote NVDIMM_TYPE_PASSTHRU. > > Can't you just make passthrough a separate command? If you actually add There are multiple conflic

Re: [PATCH 0/4] nvdimm: Add an IOCTL pass thru for DSM calls

2015-11-10 Thread Jerry Hoemann
On Tue, Nov 10, 2015 at 10:33:29AM -0500, Jeff Moyer wrote: > Jerry Hoemann <jerry.hoem...@hpe.com> writes: > > > The NVDIMM code in the kernel supports an IOCTL interface to user > > space based upon the Intel Example DSM: > > > > http://pmem.io/docume

Re: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru.

2015-11-10 Thread Jerry Hoemann
o > express all possible Function Indexes. > > 3. The Revision ID and Function Index values passed to > the _DSM are defined as little-endian. Are they > intended to use native endianness or be little-endian > in this structure? > Thanks, Robert. I will look at these for version 2.

Re: [PATCH 2/4] nvdimm: Add IOCTL pass thru

2015-11-10 Thread Jerry Hoemann
On Tue, Nov 10, 2015 at 01:05:20PM -0500, Jeff Moyer wrote: > Jerry Hoemann <jerry.hoem...@hpe.com> writes: > > > Add internal data structure for ndctl_passthru call. > > > > Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> > > --- > > includ

Re: [PATCH 3/4] nvdimm: Add IOCTL pass thru

2015-11-09 Thread Jerry Hoemann
: > > + rc = -ENOTTY; > > + } > > The same comment. Identical code in nd_ioctl and nvdimm_ioctl. > Perhaps move to a helper function? If we had a longer list, I would definitely say yes. Not so sure with just two types. I'll

[PATCH v2 3/3] nvdimm: Add IOCTL pass thru functions

2015-11-16 Thread Jerry Hoemann
Add functions acpi_nfit_ctl_passthru and __nd_ioctl_passthru which allow kernel to call a nvdimm's _DSM as a passthru without the marshaling code of the nd_cmd_desc. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> --- drivers/acpi/nfit.c

[PATCH v2 1/3] nvdimm: Clean-up access mode check.

2015-11-16 Thread Jerry Hoemann
Change nd_ioctl and nvdimm_ioctl access mode check to use O_RDONLY. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> --- drivers/nvdimm/bus.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c index 7e2c43f..1

[PATCH v2 0/3] nvdimm: Add an IOCTL pass thru for DSM calls

2015-11-16 Thread Jerry Hoemann
_pkg 3. Adjust sizes in nd_passthru_pkg. DSM intergers are 64 bit. 4. No new ioctl type, instead tunnel into the existing number space. 5. Push down one function level where determine ioctl cmd type. 6. re-work diagnostic print/dump message in pass-thru functions. Jerry Hoemann (3): nvdimm: Clean-

[PATCH v2 2/3] nvdimm: Add wrapper for IOCTL pass thru

2015-11-16 Thread Jerry Hoemann
Add struct nd_passthru_pkg which serves as a warapper for the data being passed via a pass thru to a NVDIMM DSM. This wrapper specifies the extra information in a uniform manner allowing the kenrel to call a DSM without knowing specifics of the DSM. Signed-off-by: Jerry Hoemann <jerry.h

Re: [PATCH v2 0/3] nvdimm: Add an IOCTL pass thru for DSM calls

2015-11-16 Thread Jerry Hoemann
On Mon, Nov 16, 2015 at 11:00:20AM -0800, Dan Williams wrote: > On Mon, Nov 16, 2015 at 10:38 AM, Jerry Hoemann <jerry.hoem...@hpe.com> wrote: > > > > The NVDIMM code in the kernel supports an IOCTL interface to user > > space based upon the Intel Example DSM: >

Re: [PATCH 3/4] nvdimm: Add IOCTL pass thru

2015-11-12 Thread Jerry Hoemann
ng > after the bus was found (even though you don't do anything and just > compare IDs and "continue"). okay, i understand now what you're saying. i'll address in version 2. -- ----- Jerry HoemannSoft

Re: [PATCH 3/4] nvdimm: Add IOCTL pass thru

2015-11-11 Thread Jerry Hoemann
; to "!=" > here, but you didn't add "break" after ioctl is handled for the found > bus. > I added the continue. the code is going through a list and wants to only do action when it matches on id. but, we still want to go through entire list. -- -------

Re: [PATCH v2 0/3] nvdimm: Add an IOCTL pass thru for DSM calls

2015-11-17 Thread Jerry Hoemann
On Mon, Nov 16, 2015 at 05:29:41PM -0800, Dan Williams wrote: > On Mon, Nov 16, 2015 at 1:10 PM, Jerry Hoemann <jerry.hoem...@hpe.com> wrote: > > On Mon, Nov 16, 2015 at 11:00:20AM -0800, Dan Williams wrote: > >> On Mon, Nov 16, 2015 at 10:38 AM, Jerry Hoemann <jerry.h

Re: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru.

2015-11-10 Thread Jerry Hoemann
ero > length array (see the structure definition quoted above). I guess you > meant to write this: > > unsigned char buf[0]; > The ndn_pkg.buf struct uses a flexible array definition. This

Re: [PATCH 3/4] nvdimm: Add IOCTL pass thru

2015-11-10 Thread Jerry Hoemann
On Tue, Nov 10, 2015 at 04:54:28PM -0500, Jeff Moyer wrote: > Jerry Hoemann <jerry.hoem...@hpe.com> writes: > > > + uuid = pkg->h.dsm_uuid; > > + rev = pkg->h.dsm_rev ? pkg->h.dsm_rev : 1; > > Shouldn't revision id be required? > Yes it

Re: [PATCH 3/4] nvdimm: Add IOCTL pass thru

2015-11-10 Thread Jerry Hoemann
On Tue, Nov 10, 2015 at 04:45:16PM -0500, Jeff Moyer wrote: > Jerry Hoemann <jerry.hoem...@hpe.com> writes: > > > On Tue, Nov 10, 2015 at 11:24:47AM -0500, Jeff Moyer wrote: > >> Jerry Hoemann <jerry.hoem...@hpe.com> writes: > >> > >> > @@

[PATCH 3/4] nvdimm: Add IOCTL pass thru

2015-11-06 Thread Jerry Hoemann
Add functions acpi_nfit_ctl_passthru and __nd_ioctl_passthru which allow kernel to call a nvdimm's _DSM as a passthru without the marshaling code of the nd_cmd_desc. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> --- drivers/acpi/nfit.c

[PATCH 0/4] nvdimm: Add an IOCTL pass thru for DSM calls

2015-11-06 Thread Jerry Hoemann
__nd_ioctl_passthru were created to supply the pass thru interface. These changes are based upon the 4.3 kernel. Jerry Hoemann (4): nvdimm: Add wrapper for IOCTL pass thru. nvdimm: Add IOCTL pass thru nvdimm: Add IOCTL pass thru nvdimm: rename functions that aren't IOCTL passthru

[PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru.

2015-11-06 Thread Jerry Hoemann
of the DSM. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> --- include/uapi/linux/ndctl.h | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/ndctl.h b/include/uapi/linux/ndctl.h index 5b4a4be..1c81a99 100644 --- a/include/uapi

[PATCH 2/4] nvdimm: Add IOCTL pass thru

2015-11-06 Thread Jerry Hoemann
Add internal data structure for ndctl_passthru call. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> --- include/linux/libnvdimm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/libnvdimm.h b/include/linux/libnvdimm.h index 3f021dc..01117e1 100644 --- a/include

[PATCH 4/4] nvdimm: rename functions that aren't IOCTL passthru

2015-11-06 Thread Jerry Hoemann
rename functions acpi_nfit_ctl, __nd_ioctl, ndctl, to *_intel to denote that the functions implement the Intel example _DSM. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> --- drivers/acpi/nfit.c| 6 +++--- drivers/nvdimm/bus.c | 15 --- drivers/

[PATCH v3 3/3] nvdimm: Add IOCTL pass thru functions

2015-12-02 Thread Jerry Hoemann
Add ioctl command ND_CMD_CALL_DSM to acpi_nfit_ctl and __nd_ioctl which allow kernel to call a nvdimm's _DSM as a passthru without using the marshaling code of the nd_cmd_desc. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> --- drivers/acpi/nfit.c

[PATCH v3 0/3] nvdimm: Add an IOCTL pass thru for DSM calls

2015-12-02 Thread Jerry Hoemann
pass-thru functions. Jerry Hoemann (3): nvdimm: Clean-up access mode check. nvdimm: Add wrapper for IOCTL pass thru nvdimm: Add IOCTL pass thru functions drivers/acpi/nfit.c| 109 - drivers/nvdimm/bus.c | 73 +---

[PATCH v3 1/3] nvdimm: Clean-up access mode check.

2015-12-02 Thread Jerry Hoemann
Change nd_ioctl and nvdimm_ioctl access mode check to use O_RDONLY. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> --- drivers/nvdimm/bus.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c index 7e2c43f..1

[PATCH v3 2/3] nvdimm: Add wrapper for IOCTL pass thru

2015-12-02 Thread Jerry Hoemann
and nvdimm_cmd_name. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> --- include/uapi/linux/ndctl.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/include/uapi/linux/ndctl.h b/include/uapi/linux/ndctl.h index 5b4a4be..fdb30d2 100644 --- a/include/uapi/linux/ndctl.h

Re: [PATCH v3 3/3] nvdimm: Add IOCTL pass thru functions

2015-12-09 Thread Jerry Hoemann
On Tue, Dec 08, 2015 at 06:10:20PM -0800, Dan Williams wrote: > On Wed, Dec 2, 2015 at 1:05 PM, Jerry Hoemann <jerry.hoem...@hpe.com> wrote: > > Add ioctl command ND_CMD_CALL_DSM to acpi_nfit_ctl and __nd_ioctl which > > allow kernel to call a nvdimm's _DSM as a p

Re: [PATCH v4 0/6] nvdimm: Add an IOCTL pass thru for DSM calls

2015-12-14 Thread Jerry Hoemann
On Sun, Dec 13, 2015 at 06:54:21PM -0700, Jerry Hoemann wrote: > > The NVDIMM code in the kernel supports an IOCTL interface to user > space based upon the Intel Example DSM: > > http://pmem.io/documents/NVDIMM_DSM_Interface_Example.pdf > > This interface cannot be

[PATCH v3 0/6] nvdimm: Add an IOCTL pass thru for DSM calls

2015-12-13 Thread Jerry Hoemann
are 64 bit. 4. No new ioctl type, instead tunnel into the existing number space. 5. Push down one function level where determine ioctl cmd type. 6. re-work diagnostic print/dump message in pass-thru functions. Jerry Hoemann (6): acpica: Correct parameter type to acpi_evaluate_dsm nvdimm: Clean-up access

[PATCH v3 5/6] nvdimm: Increase max envelope size for IOCTL

2015-12-13 Thread Jerry Hoemann
In __nd_ioctl must first read in the fixed sized portion of an ioctl so that it can then determine the size of the variable part. Prepare for ND_CMD_CALL_DSM calls which have larger fixed portion wrapper. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> --- include/linux/libnvdimm

[PATCH v3 1/6] acpica: Correct parameter type to acpi_evaluate_dsm

2015-12-13 Thread Jerry Hoemann
evaluate_dsm and its callers and derived callers to pass correct type. acpi_check_dsm and acpi_evaluate_dsm_typed had similar issue and were corrected as well. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> --- drivers/acpi/utils.c| 4 ++-- include/acpi/acpi_bus.h | 6 +++---

[PATCH v3 2/6] nvdimm: Clean-up access mode check.

2015-12-13 Thread Jerry Hoemann
Change nd_ioctl and nvdimm_ioctl access mode check to use O_RDONLY. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> --- drivers/nvdimm/bus.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c index 7e2c43f..1

Re: [PATCH v3 1/6] acpica: Correct parameter type to acpi_evaluate_dsm

2015-12-13 Thread Jerry Hoemann
On Mon, Dec 14, 2015 at 03:07:22AM +0100, Rafael J. Wysocki wrote: > On Mon, Dec 14, 2015 at 2:54 AM, Jerry Hoemann <jerry.hoem...@hpe.com> wrote: > > The ACPI spec speicifies that arguments "Revision ID" and > > "Function Index" to a _DSM are type

Re: [PATCH v3 3/3] nvdimm: Add IOCTL pass thru functions

2015-12-11 Thread Jerry Hoemann
rs/lists not previously reviewing this series. Do you want me to send this patch as one of this series (w/ the extra reviewers?) Or as separate stand alone to just those reviewers (and yourself.) (and if this option, before or after t

[PATCH v3 4/6] nvdimm: Fix security issue with DSM IOCTL.

2015-12-13 Thread Jerry Hoemann
Code attempts to prevent certain IOCTL DSM from being called when device is opened read only. This security feature can be trivially overcome by changing the size portion of the ioctl_command which isn't used. Check only the _IOC_NR (i.e. the command). Signed-off-by: Jerry Hoemann <jerry.h

[PATCH v3 6/6] nvdimm: Add IOCTL pass thru functions

2015-12-13 Thread Jerry Hoemann
Add ioctl command ND_CMD_CALL_DSM to acpi_nfit_ctl and __nd_ioctl which allow kernel to call a nvdimm's _DSM as a passthru without using the marshaling code of the nd_cmd_desc. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> --- drivers/acpi/nfit.c

[PATCH v3 3/6] nvdimm: Add wrapper for IOCTL pass thru

2015-12-13 Thread Jerry Hoemann
and nvdimm_cmd_name. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> --- include/uapi/linux/ndctl.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/uapi/linux/ndctl.h b/include/uapi/linux/ndctl.h index 5b4a4be..6823af3 100644 --- a/include/uapi/linux/n

Re: [PATCH v3 3/3] nvdimm: Add IOCTL pass thru functions

2015-12-11 Thread Jerry Hoemann
On Fri, Dec 11, 2015 at 10:18:59AM -0800, Dan Williams wrote: > On Fri, Dec 11, 2015 at 10:09 AM, Jerry Hoemann <jerry.hoem...@hpe.com> wrote: > > On Wed, Dec 09, 2015 at 04:48:55PM -0800, Dan Williams wrote: > >> Yes, updating the acpi_evaluate_dsm() definiti

[PATCH v5 6/6] nvdimm: Add IOCTL pass thru functions

2016-01-06 Thread Jerry Hoemann
Add ioctl command ND_CMD_CALL_DSM to acpi_nfit_ctl and __nd_ioctl which allow kernel to call a nvdimm's _DSM as a passthru without using the marshaling code of the nd_cmd_desc. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> --- drivers/acpi/nfit.c

[PATCH v5 1/6] ACPI / util: Fix acpi_evaluate_dsm() argument type

2016-01-06 Thread Jerry Hoemann
evaluate_dsm and its callers and derived callers to pass correct type. acpi_check_dsm and acpi_evaluate_dsm_typed had similar issue and were corrected as well. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> --- drivers/acpi/utils.c| 4 ++-- include/acpi/acpi_bus.h | 6 +++---

[PATCH v5 0/6] nvdimm: Add an IOCTL pass thru for DSM calls

2016-01-06 Thread Jerry Hoemann
zes in nd_passthru_pkg. DSM intergers are 64 bit. 4. No new ioctl type, instead tunnel into the existing number space. 5. Push down one function level where determine ioctl cmd type. 6. re-work diagnostic print/dump message in pass-thru functions. Jerry Hoemann (6): ACPI / util: Fix acpi_evalua

[PATCH v5 4/6] nvdimm: Fix security issue with DSM IOCTL.

2016-01-06 Thread Jerry Hoemann
Code attempts to prevent certain IOCTL DSM from being called when device is opened read only. This security feature can be trivially overcome by changing the size portion of the ioctl_command which isn't used. Check only the _IOC_NR (i.e. the command). Signed-off-by: Jerry Hoemann <jerry.h

[PATCH v5 3/6] nvdimm: Add wrapper for IOCTL pass thru

2016-01-06 Thread Jerry Hoemann
and nvdimm_cmd_name. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> --- include/uapi/linux/ndctl.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/uapi/linux/ndctl.h b/include/uapi/linux/ndctl.h index 5b4a4be..6823af3 100644 --- a/include/uapi/linux/n

[PATCH v5 5/6] nvdimm: Increase max envelope size for IOCTL

2016-01-06 Thread Jerry Hoemann
In __nd_ioctl must first read in the fixed sized portion of an ioctl so that it can then determine the size of the variable part. Prepare for ND_CMD_CALL_DSM calls which have larger fixed portion wrapper. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> --- include/linux/libnvdimm

[PATCH v5 2/6] nvdimm: Clean-up access mode check.

2016-01-06 Thread Jerry Hoemann
Change nd_ioctl and nvdimm_ioctl access mode check to use O_RDONLY. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> --- drivers/nvdimm/bus.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c index 7e2c43f..1

Re: [PATCH v2 0/3] nvdimm: Add an IOCTL pass thru for DSM calls

2015-11-17 Thread Jerry Hoemann
On Tue, Nov 17, 2015 at 09:05:28AM -0800, Dan Williams wrote: > On Tue, Nov 17, 2015 at 8:56 AM, Jerry Hoemann <jerry.hoem...@hpe.com> wrote: > > On Mon, Nov 16, 2015 at 05:29:41PM -0800, Dan Williams wrote: > >> On Mon, Nov 16, 2015 at 1:10 PM, Jerry Hoemann <jerry.h

Re: [PATCH v3 4/7] acpi, nfit: Use bus_dsm_mask for passthru

2017-06-29 Thread Jerry Hoemann
On Thu, Jun 29, 2017 at 02:35:14PM -0700, Dan Williams wrote: > On Thu, Jun 29, 2017 at 9:56 AM, Jerry Hoemann <jerry.hoem...@hpe.com> wrote: > > Populate bus_dsm_mask and use it to filter dsm calls that user can > > make through the pass thru interface. > > >

Re: [PATCH v3 7/7] acpi, nfit: override mask

2017-06-29 Thread Jerry Hoemann
On Thu, Jun 29, 2017 at 02:16:17PM -0700, Dan Williams wrote: > On Thu, Jun 29, 2017 at 9:56 AM, Jerry Hoemann <jerry.hoem...@hpe.com> wrote: > > Have module parameter override_dsm_mask override the dsm_mask for > > root calls like it does for non-root dsm calls. > &g

Re: [PATCH v3 4/7] acpi, nfit: Use bus_dsm_mask for passthru

2017-06-29 Thread Jerry Hoemann
On Thu, Jun 29, 2017 at 02:55:55PM -0700, Dan Williams wrote: > On Thu, Jun 29, 2017 at 2:47 PM, Jerry Hoemann <jerry.hoem...@hpe.com> wrote: > > On Thu, Jun 29, 2017 at 02:35:14PM -0700, Dan Williams wrote: > >> On Thu, Jun 29, 2017 at 9:56 AM, Jerry Hoemann <jerry.h

Re: [PATCH v2 5/7] acpi, nfit: Show bus_dsm_mask

2017-06-28 Thread Jerry Hoemann
On Wed, Jun 28, 2017 at 02:07:20PM -0700, Dan Williams wrote: > On Tue, Jun 20, 2017 at 9:51 AM, Jerry Hoemann <jerry.hoem...@hpe.com> wrote: > > Add bus_dsm_mask to sysfs display under /sys/bus/nd/devices/ndbusX/nfit. > > > > Signed-off-by: Jerry Hoe

[PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru.

2017-06-30 Thread Jerry Hoemann
Add a bus level dsm_mask to nvdimm_bus_descriptor to allow the passthru calling mechanism to specify a different mask from the cmd_mask. Populate bus_dsm_mask and use it to filter dsm calls that user can make through the pass thru interface. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.

[PATCH v3 0/7] Enable DSM pass thru for root functions

2017-06-30 Thread Jerry Hoemann
_mask also. Details v1 -- __nd_ioctl: Check pass thru functions against nd_cmd_clear_to_send. acpi_nfit_init_dsms: Set additional bits in cmd_mask for new functions. ndctl.h: Define data structure for the new 6.2 functions. Jerry Hoemann (6): libnvdimm: passthru functions clear to s

[PATCH v4 1/6] libnvdimm: passthru functions clear to send

2017-06-30 Thread Jerry Hoemann
Have dsm functions called via the pass thru mechanism also be checked against clear to send. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> --- drivers/nvdimm/bus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c

[PATCH v4 5/6] libnvdimm: New ACPI 6.2 DSM functions

2017-06-30 Thread Jerry Hoemann
ACPI 6.2 added new NVDIMM root DSM functions. Define their data structures. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> --- include/uapi/linux/ndctl.h | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/n

[PATCH v4 4/6] acpi, nfit: Show bus_dsm_mask in sysfs

2017-06-30 Thread Jerry Hoemann
Display bus_dsm_mask in sysfs as /sys/bus/nd/devices/ndbusX/nfit/dsm_mask. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> --- drivers/acpi/nfit/core.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c index 5

[PATCH v4 6/6] nfit allow override of root dsm mask

2017-06-30 Thread Jerry Hoemann
Have module parameter override_dsm_mask override the dsm_mask for root calls like it does for non-root dsm calls. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> --- drivers/acpi/nfit/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/acpi/nfit/core.c b/drivers/acp

[PATCH v4 2/6] acpi, nfit: Enable DSM pass thru for root functions.

2017-06-30 Thread Jerry Hoemann
Set ND_CMD_CALL in the cmd_mask to enable calling root functions via the pass thru mechanism. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> --- drivers/acpi/nfit/core.c | 1 + include/uapi/linux/ndctl.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/acpi/nfit/co

[PATCH v3 0/7] Enable DSM pass thru for root functions

2017-06-29 Thread Jerry Hoemann
functions against nd_cmd_clear_to_send. acpi_nfit_init_dsms: Set additional bits in cmd_mask for new functions. ndctl.h: Define data structure for the new 6.2 functions. Jerry Hoemann (7): libnvdimm: passthru functions clear to send acpi, nfit: Enable DSM pass thru for root functions.

[PATCH v3 5/7] acpi, nfit: Show bus_dsm_mask in sysfs

2017-06-29 Thread Jerry Hoemann
Display bus_dsm_mask in sysfs as /sys/bus/nd/devices/ndbusX/nfit/dsm_mask. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> --- drivers/acpi/nfit/core.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c index 9

[PATCH v3 6/7] libnvdimm: New ACPI 6.2 DSM functions

2017-06-29 Thread Jerry Hoemann
ACPI 6.2 added new NVDIMM root DSM functions. Define their data structures. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> --- include/uapi/linux/ndctl.h | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/n

[PATCH v3 3/7] libnvdimm: Add bus level dsm mask.

2017-06-29 Thread Jerry Hoemann
Add a bus level dsm_mask to nvdimm_bus_descriptor to allow the passthru calling mechanism to specify a different mask from the cmd_mask. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> --- include/linux/libnvdimm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include

[PATCH v3 4/7] acpi, nfit: Use bus_dsm_mask for passthru

2017-06-29 Thread Jerry Hoemann
Populate bus_dsm_mask and use it to filter dsm calls that user can make through the pass thru interface. Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> --- drivers/acpi/nfit/core.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/

  1   2   3   4   5   6   >