Re: [PATCH] HID: uhid: use strlcpy() instead of strncpy()

2018-02-16 Thread Jiri Kosina
from a string of length 127 > [-Wstringop-truncation] > > The compiler require that the input param 'len' of strncpy() should be > greater than the length of the src string, so that '\0' is copied as > well. We can just use strlcpy() to avoid this warning. Applied to for-4.17/upstream. -- Jiri Kosina SUSE Labs

Re: [PATCH][next] HID: asus: make array 'buf' static const, shrinks object size

2018-02-16 Thread Jiri Kosina
t; Signed-off-by: Colin Ian King Applied to for-4.17/upstream. -- Jiri Kosina SUSE Labs

Re: [PATCH v2 2/2] HID: core: Fix size as type u32

2018-02-16 Thread Jiri Kosina
On Sat, 3 Feb 2018, Aaron Ma wrote: > Could anyone review and apply these 2 patch? I have applied all 3 patches to for-4.16/upstream-fixes. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: corsair: Add support for the GLAIVE RGB gaming mouse

2018-02-16 Thread Jiri Kosina
On Sat, 10 Feb 2018, Guus Sliepen wrote: > This mouse sold by Corsair as the GLAIVE RGB gaming mouse has the same > problem with its HID reports as the Scimitar PRO RGB, so reuse the > same fix for the GLAIVE RGB. Applied to for-4.16/upstream-fixes. -- Jiri Kosina SUSE Labs

Re: [PATCH] input: Add driver for USB ELAN Touchpad

2018-02-16 Thread Jiri Kosina
id-quirks.c | 3 + > 5 files changed, 434 insertions(+) > create mode 100644 drivers/hid/hid-elan.c Applied to for-4.17/hid-elan. Thanks, -- Jiri Kosina SUSE Labs

[GIT PULL] HID

2018-01-31 Thread Jiri Kosina
HID: wacom: Fix reporting of touch toggle (WACOM_HID_WD_MUTE_DEVICE) events HID: wacom: Add support for One by Wacom (CTL-472 / CTL-672) Jiri Kosina (1): HID: elo: clear BTN_LEFT mapping Niels Skou Olsen (2): HID: Ignore Jabra HID interface based on firmware version HID: Add

[GIT PULL] livepatching for 4.16

2018-01-31 Thread Jiri Kosina
hadow-fix2.c| 15 --- 13 files changed, 227 insertions(+), 187 deletions(-) -- Jiri Kosina SUSE Labs

Re: [PATCH] fork: Allow stack to be wiped on fork

2018-01-26 Thread Jiri Kosina
On Fri, 26 Jan 2018, Jiri Kosina wrote: > > diff --git a/include/linux/thread_info.h b/include/linux/thread_info.h > > index 34f053a150a9..091f53fe31cc 100644 > > --- a/include/linux/thread_info.h > > +++ b/include/linux/thread_info.h > > @@ -43,7 +43,9 @@ en

Re: [PATCH] fork: Allow stack to be wiped on fork

2018-01-26 Thread Jiri Kosina
from reused stack. */ > memset(s->addr, 0, THREAD_SIZE); > #endif Is there any good reason not to do it symmetricaly also for non-vmapped stacks? (by passing __GFP_ZERO to alloc_pages_node())? Thanks, -- Jiri Kosina SUSE Labs

Re: [tip:x86/pti] x86/retpoline: Fill return stack buffer on vmexit

2018-01-25 Thread Jiri Kosina
ow is this relevant to ABI? Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v8 04/12] x86/spectre: Add boot time option to select Spectre v2 mitigation

2018-01-24 Thread Jiri Kosina
reak loading of externally-built modules just because they might contain indirect calls. Warning in such situations / tainting the kernel / reporting "might be vulnerable" in sysfs should be the proper way to go. retpolines are not kernel ABI (towards modules) breaker, so let's not pretend it is. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v8 04/12] x86/spectre: Add boot time option to select Spectre v2 mitigation

2018-01-24 Thread Jiri Kosina
ng each and every one fail to load. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v8 04/12] x86/spectre: Add boot time option to select Spectre v2 mitigation

2018-01-23 Thread Jiri Kosina
us' tree > > instead of that? > > Greg prefered using modversions Ah. OK, Greg: I'll eat my hat (I've heard that's very popular these times) if there is a major enterprise distro that doesn't revert this patch immediately. -- Jiri Kosina SUSE Labs

Re: [PATCH v8 04/12] x86/spectre: Add boot time option to select Spectre v2 mitigation

2018-01-23 Thread Jiri Kosina
nting this out, Andi. I've been just now writing more or less the same thing; ditching that and will reuse your patch instead. Why was the more aggresive version (6cfb521ac0d5b) merged into Linus' tree instead of that? Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v8 04/12] x86/spectre: Add boot time option to select Spectre v2 mitigation

2018-01-23 Thread Jiri Kosina
On Tue, 23 Jan 2018, Jiri Kosina wrote: > So that vermagic patch doesn't really help anything in real world (FWIW > I've just dropped it from SLE kernel). "Potentially insecure" doesn't mean > it shouldn't be loaded if the user wishes so. Only "fun

Re: [PATCH v8 04/12] x86/spectre: Add boot time option to select Spectre v2 mitigation

2018-01-23 Thread Jiri Kosina
"Potentially insecure" doesn't mean it shouldn't be loaded if the user wishes so. Only "functionally incorrect" (which is the kernel ABI compatibility check) should be the show stopper. -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: intel-ish-hid: Enable Cannon Lake and Coffee Lake laptop/desktop

2018-01-23 Thread Jiri Kosina
On Wed, 20 Dec 2017, Srinivas Pandruvada wrote: > Added PCI ID for Cannon Lake and Coffee Lake laptop/desktop skews. > > Signed-off-by: Srinivas Pandruvada Applied to for-4.16/hid-quirks-cleanup/ish. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v2] HID: elecom: rewrite report fixup for EX-G and future mice

2018-01-23 Thread Jiri Kosina
quot; comment for > a more abridged yet hopefully just as informative generic version. > > Signed-off-by: Tomasz Kramkowski > --- > v2 changes: > * pass rsize directly to mouse_button_fixup > * add support for wireless EX-G variant > v1: https://marc.info/?i=20171204205550.2621-1...@the-tk.com Applied, thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: rmi: Support the Fujitsu R726 Pad dock using hid-rmi

2018-01-23 Thread Jiri Kosina
On Fri, 17 Nov 2017, Andrew Duggan wrote: > The Fujitsu R726 Pad has an optional USB keyboard dock which contains > a Synaptics touchpad. The dock identifies itself as a > Primax Rezel Tablet Keyboard. > > Signed-off-by: Andrew Duggan Applied, thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH 4.9 85/96] x86/retpoline: Add initial retpoline support

2018-01-20 Thread Jiri Kosina
file that provides C prototypes for exported asm functions, which enables proper CRC versions to be generated for them. Signed-off-by: Nicholas Piggin Signed-off-by: Michal Marek Signed-off-by: Jiri Kosina --- scripts/Makefile.build | 87 +

Re: [PATCH 2/6] s390: implement nospec_[load|ptr]

2018-01-17 Thread Jiri Kosina
from Dan Williams [1] uses ifence_...(). [1] lkml.kernel.org/r/151586744180.5820.13215059696964205856.st...@dwillia2-desk3.amr.corp.intel.com -- Jiri Kosina SUSE Labs

Re: [PATCH] x86/pti: Fix !PCID and sanitize defines

2018-01-16 Thread Jiri Kosina
.9-stable already do the right thing (always or-ing 0 into CR3 on non-PCID systems) due to the way how x86_cr3_pcid_user handling is done. -- Jiri Kosina SUSE Labs

Re: [PATCH 4.9] x86/pti/efi: broken conversion from efi to kernel page table

2018-01-12 Thread Jiri Kosina
thread: > http://lkml.iu.edu/hypermail/linux/kernel/1801.1/00951.html > > Signed-off-by: Pavel Tatashin > Reviewed-by: Steven Sistare Acked-by: Jiri Kosina We are carrying similar patch in our 4.4 codestream as well. Please note that this is needed only for those trees that have 67a9108ed4

Re: [4.4] broken conversion from efi to kernel page table

2018-01-12 Thread Jiri Kosina
her of this fixes your problem? Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH 2/3] objtool: Ignore retpoline alternatives

2018-01-11 Thread Jiri Kosina
; } # gcc --version gcc (SUSE Linux) 4.3.4 [gcc-4_3-branch revision 152973] # ./test 8 So this part is OK. The asm-goto hard dependency would be worse with that compiler though. -- Jiri Kosina SUSE Labs

Re: [PATCH 2/3] objtool: Ignore retpoline alternatives

2018-01-11 Thread Jiri Kosina
backport retpolines in some form to 4.3.x at least. I'd be surprised if we'd be the only ones on this planet :) -- Jiri Kosina SUSE Labs

Re: [PATCH v2] livepatch: add locking to force and signal functions

2018-01-11 Thread Jiri Kosina
applied to for-4.16/signal-sysfs-force-v2. Thanks, -- Jiri Kosina SUSE Labs

Re: Linux 4.15-rc7

2018-01-11 Thread Jiri Kosina
find the x86-32 support there, it's yours (hint: you won't). Otherwise, you'd either have to wait until we (or someone else) implements it (it's on our list), or implement it yourself. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v2] livepatch: Remove immediate feature

2018-01-11 Thread Jiri Kosina
E_RELIABLE_STACKTRACE to > fully support livepatch. > > Signed-off-by: Miroslav Benes > --- > v2 changes: > - 2/2 from v1 dropped > - documentation It's very refreshing to have to handle something non-toxic (no PTI, no retpolines) finally :) Applied to for-4.16/remove-immediate, thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

2018-01-11 Thread Jiri Kosina
On Tue, 9 Jan 2018, Josh Poimboeuf wrote: > On Tue, Jan 09, 2018 at 11:44:05AM -0800, Dan Williams wrote: > > On Tue, Jan 9, 2018 at 11:34 AM, Jiri Kosina wrote: > > > On Fri, 5 Jan 2018, Dan Williams wrote: > > > > > > [ ... snip ... ] > > >>

Re: [patch RFC 5/5] x86/speculation: Add basic speculation control code

2018-01-10 Thread Jiri Kosina
entation I've seen. Thanks, -- Jiri Kosina SUSE Labs

Re: [patch RFC 5/5] x86/speculation: Add basic speculation control code

2018-01-10 Thread Jiri Kosina
L3 vs CPL0-2" and "VMX root vs VMX non-root", with obvious ordering of privileges. So if IBRS is set, branch predictor will not allow the predicted target to be influenced by code that executed in less privileged prediction mode before value of '1' IBRS mode was last written to, and that's pretty much it. -- Jiri Kosina SUSE Labs

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

2018-01-09 Thread Jiri Kosina
OP, and something comparable for eBPF JIT? Is this going to be handled in eBPF in some other way? Without that in place, and considering Jann Horn's paper, it would seem like PTI doesn't really lock it down fully, right? [1] https://bugs.chromium.org/p/project-zero/issues/attachmentText?aid=287305 -- Jiri Kosina SUSE Labs

Re: [PATCH v6 00/10] Retpoline: Avoid speculative indirect calls in kernel

2018-01-08 Thread Jiri Kosina
or thread. I am still unclear whether this closes it completely, as when HT is on, the RSB is shared between the threads, right? Therefore one thread can poision it for the other without even context switch happening. -- Jiri Kosina SUSE Labs

[tip:x86/pti] x86/pti: Unbreak EFI old_memmap

2018-01-06 Thread tip-bot for Jiri Kosina
Commit-ID: de53c3786a3ce162a1c815d0c04c766c23ec9c0a Gitweb: https://git.kernel.org/tip/de53c3786a3ce162a1c815d0c04c766c23ec9c0a Author: Jiri Kosina AuthorDate: Fri, 5 Jan 2018 22:35:41 +0100 Committer: Thomas Gleixner CommitDate: Sat, 6 Jan 2018 21:38:16 +0100 x86/pti: Unbreak EFI

[tip:x86/pti] x86/pti: Unbreak EFI old_memmap

2018-01-06 Thread tip-bot for Jiri Kosina
Commit-ID: 5ad9a697fa957e61d50ef969179c18348968cd9f Gitweb: https://git.kernel.org/tip/5ad9a697fa957e61d50ef969179c18348968cd9f Author: Jiri Kosina AuthorDate: Fri, 5 Jan 2018 22:35:41 +0100 Committer: Ingo Molnar CommitDate: Sat, 6 Jan 2018 11:43:44 +0100 x86/pti: Unbreak EFI

[PATCH] PTI: unbreak EFI old_memmap

2018-01-05 Thread Jiri Kosina
From: Jiri Kosina old_memmap's efi_call_phys_prolog() calls set_pgd() with swapper PGD that has PAGE_USER set, which makes PTI set NX on it, and therefore EFI can't execute it's code. Fix that by forcefully clearing _PAGE_NX from the PGD (this can't be done by the pgprot

Re: [PATCH 05/23] x86, kaiser: unmap kernel from userspace page tables (core patch)

2018-01-05 Thread Jiri Kosina
;ll extract the patch out of this thread and submit it separately, so that it doesn't get lost buried here. > I'd personally much rather muck with random relatively unused bits of > the efi code than touch the core PGD code. Exactly. Especially at this point. > We need to go look at it again in the 4.16 timeframe, probably. Agreed. On my TODO list already. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH 05/23] x86, kaiser: unmap kernel from userspace page tables (core patch)

2018-01-05 Thread Jiri Kosina
On Fri, 5 Jan 2018, Jiri Kosina wrote: > That's because pgd_populate() uses _PAGE_TABLE and not _KERNPG_TABLE for > reasons that are behind me. [ oh and BTW I find the fact that we have populate_pgd() and pgd_populate(), which do something *completely* different quite entertaining

Re: [PATCH 05/23] x86, kaiser: unmap kernel from userspace page tables (core patch)

2018-01-05 Thread Jiri Kosina
mm in there and *not* set _PAGE_USER? That's because pgd_populate() uses _PAGE_TABLE and not _KERNPG_TABLE for reasons that are behind me. I did put this on my TODO list, but for later. (and yes, I tried clearing _PAGE_USER from init_mm's PGD, and no obvious breakages appeared, but I wanted to give it more thought later). -- Jiri Kosina SUSE Labs

Re: [PATCH 05/23] x86, kaiser: unmap kernel from userspace page tables (core patch)

2018-01-05 Thread Jiri Kosina
The previous patch was for slightly older kernel, and the logic in _prologue() is a bit different in 4.15, but the (cofirmed) fix for mainline is basically the same: From: Jiri Kosina Subject: [PATCH] PTI: unbreak EFI old_memmap old_memmap's efi_call_phys_prolog() calls set_pgd()

Re: [RFC] boot failed when enable KAISER/KPTI

2018-01-05 Thread Jiri Kosina
9124] CR2: 5b835f90 CR3: 01966000 CR4: > 000606b0 > [0.156234] DR0: DR1: DR2: > > [0.163344] DR3: DR6: fffe0ff0 DR7: > 00000400 > [0.170454] Call Trace: > [0.172899] [] ? efi_call4+0x6c/0xf0 EFI old memmap have NX bit set. Immediate workaround is remove that cmdline parameter. I have also submitted proposed fix here: http://lkml.kernel.org/r/alpine.lrh.2.00.1801051909160.27...@gjva.wvxbf.pm -- Jiri Kosina SUSE Labs

Re: [PATCH 05/23] x86, kaiser: unmap kernel from userspace page tables (core patch)

2018-01-05 Thread Jiri Kosina
apping or not, as that would be way too much overhead just for this one-off call during boot. From: Jiri Kosina Subject: [PATCH] PTI: unbreak EFI old_memmap old_memmap's efi_call_phys_prolog() calls set_pgd() with swapper PGD that has PAGE_USER set, which makes PTI set NX on it, and

Re: [RFC PATCH] asm/generic: introduce if_nospec and nospec_barrier

2018-01-04 Thread Jiri Kosina
ow does this work on HT with the shared BTB? There is no context switch (and hence no IBPB) happening between the threads sharing it. -- Jiri Kosina SUSE Labs

Re: [RFC PATCH] asm/generic: introduce if_nospec and nospec_barrier

2018-01-03 Thread Jiri Kosina
s reports to a dozen > or so locations that need some 'nospec' handling. How exactly is that related (especially in longer-term support terms) to BPF anyway? Thanks, -- Jiri Kosina SUSE Labs

Re: [RFC PATCH] asm/generic: introduce if_nospec and nospec_barrier

2018-01-03 Thread Jiri Kosina
nstruct to a real processor one. Again, what is the problem with "yeah, it turned out to speed things up in the past, but hey, it has security issues, so we stopped doing it" aproach? Thanks, -- Jiri Kosina SUSE Labs

Re: [RFC PATCH] asm/generic: introduce if_nospec and nospec_barrier

2018-01-03 Thread Jiri Kosina
cause these kinds of side-effects, it just must not happen, full stop. OS trying to work it around is just a whack-a-mole (which we can apply for old silicon, sure ... but not something that becomes a new standard) that's never going to lead to any ultimate solution. -- Jiri Kosina SUSE Labs

Re: Avoid speculative indirect calls in kernel

2018-01-03 Thread Jiri Kosina
patch them using alternatives in runtime, that'd be enough. -- Jiri Kosina SUSE Labs

Re: 4.14.9 doesn't boot (regression)

2017-12-30 Thread Jiri Kosina
probably the "hardened" flavor of your distro trying to push '-fstack-check' to everything it compiles; so I actually think the Makefile patch, sanitizing CFLAGS by force-disabling -fstack-check is exactly what we should be doing. Thanks, -- Jiri Kosina SUSE Labs

Re: Graphics on thinkpad x270 after dock/undock works only for the first time (CPU pipe B FIFO underrun)

2017-12-30 Thread Jiri Kosina
On Sat, 30 Dec 2017, Jiri Kosina wrote: > Seems like disabling RC6 on the kernel command line works this around, and > I can dock / undock several times in a row with the image always coming > up properly on the external display. > > On the first undock, the WARN_ONCE() below

[GIT PULL] HID

2017-12-30 Thread Jiri Kosina
| 2 +- drivers/hid/hid-cp2112.c | 15 +-- drivers/hid/hid-holtekff.c | 8 3 files changed, 18 insertions(+), 7 deletions(-) -- Jiri Kosina SUSE Labs

Re: 4.14.9 doesn't boot (regression)

2017-12-30 Thread Jiri Kosina
interrupt stack and triple-faults. -- Jiri Kosina SUSE Labs

Re: Graphics on thinkpad x270 after dock/undock works only for the first time (CPU pipe B FIFO underrun)

2017-12-30 Thread Jiri Kosina
On Fri, 29 Dec 2017, Jiri Kosina wrote: > When I dock my thinkpad x270 [1] and run xrandr --auto, image correctly > appears on external display. > > After undocking and docking again, the image on external display doesn't > appear any more, and t

Re: Graphics on thinkpad x270 after dock/undock works only for the first time (CPU pipe B FIFO underrun)

2017-12-29 Thread Jiri Kosina
On Fri, 29 Dec 2017, Jiri Kosina wrote: > When I dock my thinkpad x270 [1] and run xrandr --auto, image correctly > appears on external display. > [1] 00:02.0 VGA compatible controller: Intel Corporation Skylake GT2 [HD Graphics 520] (rev 07) > After undocking and docking again,

Graphics on thinkpad x270 after dock/undock works only for the first time (CPU pipe B FIFO underrun)

2017-12-29 Thread Jiri Kosina
ase let me know, I'll happily provide it. Thanks, -- Jiri Kosina SUSE Labs

Re: [patch V181 49/54] x86/dumpstack: Indicate in Oops whether pti is configured and enabled

2017-12-20 Thread Jiri Kosina
; We can decide to remove this after the feature has been tested in the field > long enough. > > [ tglx: Made it use boot_cpu_has() as requested by Borislav ] > > Signed-off-by: Vlastimil Babka > Signed-off-by: Thomas Gleixner > Reviewed-by: Eduardo Valentin > Acked-by:

Re: [PATCH] HID: elecom: rewrite report fixup for EX-G and future mice

2017-12-11 Thread Jiri Kosina
llowup here. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v4 0/2] livepatch: Introduce signal and force sysfs attributes

2017-12-07 Thread Jiri Kosina
[ CC list trimmed ] On Mon, 4 Dec 2017, Jiri Kosina wrote: > This is now queued in livepatching.git#for-4.16/signal-sysfs-force. The branch above has been obsoleted by for-4.16/signal-sysfs-force-v2, which contains the proper (v4.1) version of the patch 2/2. -- Jiri Kosina SUSE Labs

Re: [PATCH v2] HID: add quirk for another PIXART OEM mouse used by HP

2017-12-07 Thread Jiri Kosina
input: USB HID v1.11 Mouse > [PixArt HP USB Optical Mouse] on usb-:00:14.0-2/input0 Applied, thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: elecom: rewrite report fixup for EX-G and future mice

2017-12-07 Thread Jiri Kosina
to me that it > makes most sense to allow for the possibility (although slim) of this > function eventually being expanded to actually replace the report > descriptor Sure, but you can extend the API of mouse_button_fixup() once such need arises; no need to pass data pointers around wit

Re: [PATCH][next] HID: quirks: make array hid_quirks static

2017-12-07 Thread Jiri Kosina
as not > declared. Should it be static? > > Signed-off-by: Colin Ian King Applied to for-4.16/hid-quirks-cleanup/_base. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v4 0/2] livepatch: Introduce signal and force sysfs attributes

2017-12-04 Thread Jiri Kosina
> arch/x86/entry/common.c | 6 +-- > kernel/livepatch/core.c | 60 + > kernel/livepatch/transition.c| 66 > > kernel/livepatch/transition.h| 2 + > kernel/signal.c | 4 +- This is now queued in livepatching.git#for-4.16/signal-sysfs-force. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v5] HID: hid-multitouch: support fine-grain orientation reporting

2017-12-01 Thread Jiri Kosina
7;t set ABS_MT_ORIENTATION in ABS_DG_HEIGHT when it is already > set by ABS_DG_AZIMUTH. > v4 -> v5: >- Improve multi-touch-protocol.rst documentation. > > Signed-off-by: Wei-Ning Huang > Signed-off-by: Wei-Ning Huang > Reviewed-by: Dmitry Torokhov This is now queued in for-4.16/hid-quirks-cleanup/multitouch. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v4 1/2] livepatch: send a fake signal to all blocking tasks

2017-11-30 Thread Jiri Kosina
> kernel/livepatch/transition.h| 1 + > kernel/signal.c | 4 ++- I'd like to be queuing this patchset for the next merge window, so if there are any objections for the out-of-kernel/livepatch/* changes, please speak up now. Thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH 00/11] fs: use freeze_fs on suspend/hibernate

2017-11-30 Thread Jiri Kosina
figure out the viability of the whole aproach in practice. -- Jiri Kosina SUSE Labs

[PATCH] HID: elo: clear BTN_LEFT mapping

2017-11-24 Thread Jiri Kosina
From: Jiri Kosina ELO devices have one Button usage in GenDesk field, which makes hid-input map it to BTN_LEFT; that confuses userspace, which then considers the device to be a mouse/touchpad instead of touchscreen. Fix that by unmapping BTN_LEFT and keeping only BTN_TOUCH in place. Signed

Re: [PATCH v2] HID: cp2112: Fix I2C_BLOCK_DATA transactions

2017-11-21 Thread Jiri Kosina
A write change > is pretty simple to verify by inspection. > > Signed-off-by: Eudean Sun > --- > Changes in v2: > - Explain the fix and testing in more detail in the commit message. Applied to for-4.15/upstream-fixes, thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: cp2112: Fix I2C_BLOCK_DATA transactions

2017-11-21 Thread Jiri Kosina
On Tue, 21 Nov 2017, Jiri Kosina wrote: > > The existing driver erroneously treats I2C_BLOCK_DATA and BLOCK_DATA > > commands the same. Fix the logic for I2C_BLOCK_DATA reads and writes. > > Addin David, the original author of the driver (and the code in question > as

Re: [PATCH] HID: cp2112: Fix I2C_BLOCK_DATA transactions

2017-11-21 Thread Jiri Kosina
; data->word = le16_to_cpup((__le16 *)buf); > break; > + case I2C_SMBUS_I2C_BLOCK_DATA: > + memcpy(data->block + 1, buf, read_length); > + break; > case I2C_SMBUS_BLOCK_DATA: > if (read_length > I2C_SMBUS_BLOCK_MAX) { > ret = -EPROTO; > -- > 2.7.4 > -- Jiri Kosina SUSE Labs

Re: [PATCH v3] HID: i2c-hid: Allow ACPI systems to specify "post-power-on-delay-ms"

2017-11-21 Thread Jiri Kosina
call i2c_hid_acpi_pdata() if can't get > HID register address using device_property. Queued now for 4.16 merge window. -- Jiri Kosina SUSE Labs

[PATCH v2] sched/deadline: Use unsigned type for the state flags

2017-11-21 Thread Jiri Kosina
teven Rostedt Cc: Thomas Gleixner Signed-off-by: Jiri Kosina --- v2: switch over to unsisgned int from bool, as asked for by Thomas. Feel free to pick either of the versions include/linux/sched.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/sched.

Re: [PATCH] sched/deadline: Use bools for the state flags

2017-11-21 Thread Jiri Kosina
se bool as that's in line with the actual semantics, but I can of course resend with unsigned type if that's preferred for one reason or another. Thanks, -- Jiri Kosina SUSE Labs

[PATCH] sched/deadline: Use bools for the state flags

2017-11-21 Thread Jiri Kosina
From: Jiri Kosina Commit 799ba82de01e ("sched/deadline: Use C bitfields for the state flags") converted state flags into one-bit signed int. Signed one-bit type can be either 0 or -1, which is going to cause a problem once 1 is assigned to it and then the value later tested

Re: [PATCH v3 0/4] Quirks cleanup and hid-generic niceness

2017-11-21 Thread Jiri Kosina
up-base (not pushed into for-next yet though, as 4.15 merge window is still open). Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v4 2/2] livepatch: force transition to finish

2017-11-20 Thread Jiri Kosina
On Tue, 21 Nov 2017, Pavel Machek wrote: > Just disable rmmod in case of forced removal. Yeah, well, that's basically what the patch does :) Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v4 2/2] livepatch: force transition to finish

2017-11-20 Thread Jiri Kosina
On Tue, 21 Nov 2017, Jiri Kosina wrote: > I agree; the only thing I think really has to be done is putting a comment > there, explaining why forcing implies infinite module reference (and also > perhaps making it therefore even more obvious from documentation, that > this real

Re: [PATCH v4 2/2] livepatch: force transition to finish

2017-11-20 Thread Jiri Kosina
event, not worth the > trouble to try to keep track of that IMO. Well, that was my rather random idea when we were discussing this over lunch today. But I agree, it definitely is a total overkill, and I don't want it to be atributed to me any more :p Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v2 0/4] Quirks cleanup and hid-generic niceness

2017-11-20 Thread Jiri Kosina
Would be perfect; the sooner it gets into my tree the better, so that we could start basing other topic branches on it. That'd avoid a lot of merge conflicts later. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH] tracing/probe: fix typo in pr_fmt in trace_uprobe.c

2017-11-16 Thread Jiri Kosina
gt; > > "trace_kprobe". > > > > Oh, good catch! > > > > Acked-by: Masami Hiramatsu > > > > Thanks. > > Acked-by: Steven Rostedt (VMware) > > Jiri, can you take this in your tree? Yup, no problem; will add it to queue once merge window is over. -- Jiri Kosina SUSE Labs

Re: [PATCH v2 0/4] Quirks cleanup and hid-generic niceness

2017-11-16 Thread Jiri Kosina
.c is basically moved to > hid-quirks.c. I am planning to queue this for 4.16; do you happen to have any followups since you posted v2 in october? Thanks, -- Jiri Kosina SUSE Labs

[GIT PULL] trivial for 4.15

2017-11-15 Thread Jiri Kosina
- kernel/trace/Kconfig | 4 ++-- lib/xz/xz_dec_stream.c | 16 mm/huge_memory.c | 8 samples/trace_events/trace-events-sample.h | 10 +- 26 files changed, 62 insertions(+), 46 deletions(-) -- Jiri Kosina SUSE Labs

[GIT PULL] HID for 4.15

2017-11-15 Thread Jiri Kosina
+ include/uapi/linux/input-event-codes.h | 1 + 22 files changed, 608 insertions(+), 149 deletions(-) -- Jiri Kosina SUSE Labs

[GIT PULL] livepatching for 4.15

2017-11-15 Thread Jiri Kosina
sting data structures, from Joe Lawrence - pre/post patch callbacks API, allowing livepatch writers to register callbacks to be called before and after patch application, from Joe Lawrence = Thanks. ---- Jiri Kosina (1):

Re: [PATCH v2 3/3] HID: cp2112: fix broken gpio_direction_input callback

2017-11-10 Thread Jiri Kosina
> Changes in v2: > - rework error handling to have only one exit path as suggested by >Benjamin Tissoires Applied to for-4.15/upstream. -- Jiri Kosina SUSE Labs

Re: [PATCH 26/30] Lock down ftrace

2017-11-10 Thread Jiri Kosina
... and even if that happens, locking down only that particular feature of ftrace would be needed. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH 26/30] Lock down ftrace

2017-11-10 Thread Jiri Kosina
27;t seem to fit at all. > > I'll defer this question to Alexei since he suggested I needed to deal > with this too. Thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH 26/30] Lock down ftrace

2017-11-10 Thread Jiri Kosina
verification that the code you're running in ring0 can be trusted (IOW is the one that has been signed and verified by the whole boot chain). Checking execution patterns doesn't seem to fit at all. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH 1/3] HID: cp2112: fix interface specification URL

2017-11-10 Thread Jiri Kosina
t; > > > I've applied patches 1 and 2 (with stable anotation) for now. Thanks, > > > > Thanks, I've send a v2 of patch 3. > > Regards, > > P.S: I don't see patch 1 on your cgit, is it normal? It's been applied only locally, today I've actually pushed it out. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: Wacom: switch Dell canvas into highres mode

2017-11-10 Thread Jiri Kosina
appy with the one-off approach, but I'll but > my stamp of approval on it. We can work out a more generic way to > detect and configure these dual-resolution devices going forward :) > > Reviewed-by: Jason Gerecke Applied to for-4.15/wacom, thanks for checking. -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: sony: Fix SHANWAN pad rumbling on USB

2017-11-09 Thread Jiri Kosina
sending data, disable that call for > the SHANWAN so the rumble motors aren't started on plug. > > Signed-off-by: Bastien Nocera Applied to for-4.15/sony. -- Jiri Kosina SUSE Labs

Re: [PATCH] add backlight level quirk for Asus ROG laptops

2017-11-09 Thread Jiri Kosina
#x27;ve reformatted the changelog/shortlog a little bit and applied to for-4.15/asus. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH 1/3] HID: cp2112: fix interface specification URL

2017-11-09 Thread Jiri Kosina
s/TechnicalDocs/AN495.pdf > + * > https://www.silabs.com/documents/public/application-notes/an495-cp2112-interface-specification.pdf > */ I've applied patches 1 and 2 (with stable anotation) for now. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: Wacom: switch Dell canvas into highres mode

2017-11-09 Thread Jiri Kosina
, here it comes in the hid-replay format (and with a recording > of a single dot from the pen): Jason, any word on the descriptor please, did you have time to analyze it? Merge window for 4.15 is almost there, so in case you don't want to miss it, I'd need your Ack/Nack/Postopne rather quickly. Thanks, -- Jiri Kosina SUSE Labs

[PATCH] x86/mm: Unbreak modules that rely on external PAGE_KERNEL availability

2017-11-08 Thread Jiri Kosina
From: Jiri Kosina Commit 7744ccdbc16f0 ("x86/mm: Add Secure Memory Encryption (SME) support") as a side-effect made PAGE_KERNEL all of a sudden unavailable to modules which can't make use of EXPORT_SYMBOL_GPL() symbols. This is because once SME is enabled, sme_me_mask (whic

Re: [PATCH v3 2/2] livepatch: force transition process to finish

2017-11-06 Thread Jiri Kosina
nks, -- Jiri Kosina SUSE Labs

Re: [PATCH] livepatch: fix merge bug in klp_cleanup_module_patches_limited()

2017-11-01 Thread Jiri Kosina
for upstream)? > > Sure, no problem. Thanks a lot again; I've just pushed out a fixed merge. -- Jiri Kosina SUSE Labs

Re: [PATCH] livepatch: fix merge bug in klp_cleanup_module_patches_limited()

2017-10-31 Thread Jiri Kosina
apply this patch to would be for-next, but that'd be useless, as that is only an integration/testing branch, that doesn't get merged anywhere else than linux-next. Would you be okay with me just redoing the merge into for-next with this fixup attributed to you in the merge message (and my git-rerere picking it up for upstream)? Thanks Josh, -- Jiri Kosina SUSE Labs

Re: [PATCH 0/2] livepatch: Additional fixes for callbacks feature

2017-10-26 Thread Jiri Kosina
; 2 files changed, 10 insertions(+), 7 deletions(-) Applied to for-4.15/callbacks (with Joe's changelog comments incorporated). Thanks, -- Jiri Kosina SUSE Labs

RE: [PATCH v2 0/4] Quirks cleanup and hid-generic niceness

2017-10-25 Thread Jiri Kosina
ID, so the > reviewer candidates are probably few. > > Has anyone had time to look at this? It's one the first things I'd like to process once kernel summit is over. Thanks for patience, -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: hid-logitech: remove redundant assignment to pointer value

2017-10-19 Thread Jiri Kosina
es > report and report_list. Cleans up the clang warning: Value stored to > 'value' during its initialization is never read > > Signed-off-by: Colin Ian King Applied to for-4.15/logitech. Thanks, -- Jiri Kosina SUSE Labs

<    3   4   5   6   7   8   9   10   11   12   >