On Tue, Aug 21, 2012 at 07:12:10PM +0200, Peter Zijlstra wrote:
On Tue, 2012-08-21 at 08:51 -0700, tip-bot for Jiri Olsa wrote:
@@ -1829,6 +1829,7 @@ out_free:
static const int attr_file_abi_sizes[] = {
[0] = PERF_ATTR_SIZE_VER0,
[1] = PERF_ATTR_SIZE_VER1,
+ [2
On Tue, Aug 21, 2012 at 07:11:56PM +0200, Peter Zijlstra wrote:
On Tue, 2012-08-21 at 08:49 -0700, tip-bot for Jiri Olsa wrote:
#define PERF_ATTR_SIZE_VER388 /* add: sample_regs_user */
+#define PERF_ATTR_SIZE_VER496 /* add: sample_stack_user */
Both are introduced
On Tue, Aug 21, 2012 at 11:36:28AM +0200, Jiri Olsa wrote:
On Tue, Aug 21, 2012 at 11:32:31AM +0200, Ingo Molnar wrote:
* Arnaldo Carvalho de Melo a...@infradead.org wrote:
SNIP
One minor observation, the Makefile tells us:
Makefile:496: No libunwind found. Please install
...@linux.vnet.ibm.com
Cc: Frederic Weisbecker fweis...@gmail.com
Signed-off-by: Jiri Olsa jo...@redhat.com
graph
---
tools/perf/util/test-attr/test-record-graph-default | 6 ++
tools/perf/util/test-attr/test-record-graph-dwarf | 6 ++
tools/perf/util/test-attr/test-record-graph-fp
...@linux.vnet.ibm.com
Cc: Frederic Weisbecker fweis...@gmail.com
Signed-off-by: Jiri Olsa jo...@redhat.com
---
tools/perf/util/test-attr/test-stat-group | 15 +++
1 file changed, 15 insertions(+)
create mode 100644 tools/perf/util/test-attr/test-stat-group
diff --git a/tools/perf/util/test-attr
...@chello.nl
Cc: Ingo Molnar mi...@elte.hu
Cc: Paul Mackerras pau...@samba.org
Cc: Corey Ashford cjash...@linux.vnet.ibm.com
Cc: Frederic Weisbecker fweis...@gmail.com
Signed-off-by: Jiri Olsa jo...@redhat.com
---
tools/perf/builtin-test.c | 4
tools/perf/perf.h | 1 +
tools/perf/util
Weisbecker fweis...@gmail.com
Signed-off-by: Jiri Olsa jo...@redhat.com
---
tools/perf/util/test-attr/test-record-no-inherit | 7 +++
1 file changed, 7 insertions(+)
create mode 100644 tools/perf/util/test-attr/test-record-no-inherit
diff --git a/tools/perf/util/test-attr/test-record-no-inherit
b
Weisbecker fweis...@gmail.com
Signed-off-by: Jiri Olsa jo...@redhat.com
---
tools/perf/util/test-attr/test-record-freq | 6 ++
1 file changed, 6 insertions(+)
create mode 100644 tools/perf/util/test-attr/test-record-freq
diff --git a/tools/perf/util/test-attr/test-record-freq
b/tools/perf
Weisbecker fweis...@gmail.com
Signed-off-by: Jiri Olsa jo...@redhat.com
---
tools/perf/util/test-attr/test-stat-no-inherit | 7 +++
1 file changed, 7 insertions(+)
create mode 100644 tools/perf/util/test-attr/test-stat-no-inherit
diff --git a/tools/perf/util/test-attr/test-stat-no-inherit
b/tools
Weisbecker fweis...@gmail.com
Signed-off-by: Jiri Olsa jo...@redhat.com
---
tools/perf/util/test-attr/test-record-no-samples | 6 ++
1 file changed, 6 insertions(+)
create mode 100644 tools/perf/util/test-attr/test-record-no-samples
diff --git a/tools/perf/util/test-attr/test-record-no-samples
b
fweis...@gmail.com
Signed-off-by: Jiri Olsa jo...@redhat.com
---
tools/perf/util/test-attr/base-stat | 39 +++
tools/perf/util/test-attr/test-stat-basic | 6 +
2 files changed, 45 insertions(+)
create mode 100644 tools/perf/util/test-attr/base-stat
create
: Frederic Weisbecker fweis...@gmail.com
Signed-off-by: Jiri Olsa jo...@redhat.com
---
tools/perf/util/test-attr/test-record-period | 7 +++
1 file changed, 7 insertions(+)
create mode 100644 tools/perf/util/test-attr/test-record-period
diff --git a/tools/perf/util/test-attr/test-record-period
b
Weisbecker fweis...@gmail.com
Signed-off-by: Jiri Olsa jo...@redhat.com
---
tools/perf/util/test-attr/test-record-count | 8
1 file changed, 8 insertions(+)
create mode 100644 tools/perf/util/test-attr/test-record-count
diff --git a/tools/perf/util/test-attr/test-record-count
b/tools
...@linux.vnet.ibm.com
Cc: Frederic Weisbecker fweis...@gmail.com
Signed-off-by: Jiri Olsa jo...@redhat.com
---
tools/perf/util/test-attr/test-record-group | 17 +
1 file changed, 17 insertions(+)
create mode 100644 tools/perf/util/test-attr/test-record-group
diff --git a/tools/perf/util/test
Ashford cjash...@linux.vnet.ibm.com
Cc: Frederic Weisbecker fweis...@gmail.com
Signed-off-by: Jiri Olsa jo...@redhat.com
---
tools/perf/Makefile | 1 +
tools/perf/builtin-test.c | 4 +
tools/perf/perf.c
Weisbecker fweis...@gmail.com
Signed-off-by: Jiri Olsa jo...@redhat.com
---
tools/perf/util/test-attr/base-record | 39 +
tools/perf/util/test-attr/test-record-basic | 5
2 files changed, 44 insertions(+)
create mode 100644 tools/perf/util/test-attr/base-record
...@gmail.com
Signed-off-by: Jiri Olsa jo...@redhat.com
---
tools/perf/Makefile | 1 +
tools/perf/perf.c| 2 +
tools/perf/perf.h| 10 ++
tools/perf/util/test-attr.c | 128
tools/perf/util/test-attr.py | 272
On Wed, Aug 01, 2012 at 06:04:31AM +0200, Stephane Eranian wrote:
On Fri, Jul 27, 2012 at 2:23 PM, Jiri Olsa jo...@redhat.com wrote:
hi,
patches available also as tarball in here:
http://people.redhat.com/~jolsa/perf_post_unwind_v8.tar.bz2
v8 changes:
- patch 2 - added dump
hi,
patches available also as tarball in here:
http://people.redhat.com/~jolsa/perf_post_unwind_v9.tar.bz2
v9 changes:
- rebased to current tip tree
v8 changes:
- patch 2 - added dump registers ABI specification as suggested
by Stephane
- v7 patches 9,10,16,17 already in
to the architecture to map the registers into the mask bits.
For the x86 arch implementation, both 32 and 64 bit registers
bits are defined within single enum to ensure 64 bit system can
provide register dump for compat task if needed in the future.
Signed-off-by: Jiri Olsa jo...@redhat.com
Original
function is used and __copy_from_user_inatomic for the rest
of the architectures.
This new function will be used in user stack dump on sample,
coming in next patches.
Signed-off-by: Frederic Weisbecker fweis...@gmail.com
Signed-off-by: Jiri Olsa jo...@redhat.com
---
arch/x86/include/asm/perf_event.h
of
the requested dump size, regardless this size is crossing
the task boundary.
Signed-off-by: Jiri Olsa jo...@redhat.com
---
arch/x86/include/asm/uaccess.h |2 ++
arch/x86/lib/usercopy.c| 15 +++
2 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/arch/x86
callchains filtering ]
Signed-off-by: Jiri Olsa jo...@redhat.com
CC: Andrew Vagin ava...@openvz.org
---
include/linux/perf_event.h |5 -
kernel/events/callchain.c | 36 +---
kernel/events/core.c |6 +-
kernel/events/internal.h |3 ++-
4
need a way to skip the remaining bytes.
This is going to be useful when storing the user stack dump,
where we might end up with less data than we originally requested.
Signed-off-by: Jiri Olsa jo...@redhat.com
Acked-by: Frederic Weisbecker fweis...@gmail.com
---
include/linux/perf_event.h |2
the directory with libunwind to be linked. This is used for
debug purposes.
Signed-off-by: Jiri Olsa jo...@redhat.com
Original-patch-by: Frederic Weisbecker fweis...@gmail.com
---
tools/perf/Makefile | 30 +-
tools/perf/config/feature-tests.mak | 25
dumps.
Signed-off-by: Jiri Olsa jo...@redhat.com
Original-patch-by: Frederic Weisbecker fweis...@gmail.com
---
tools/perf/builtin-test.c |4 ++--
tools/perf/util/event.h | 16 +++-
tools/perf/util/evlist.c |8
tools/perf/util/evlist.h |1 +
tools/perf/util
:
typedef int (*unwind_entry_cb_t)(struct unwind_entry *entry,
void *arg);
Signed-off-by: Jiri Olsa jo...@redhat.com
Original-patch-by: Frederic Weisbecker fweis...@gmail.com
---
tools/perf/Makefile|2 +
tools/perf
with libunwind)
perf record -g dwarf ls
- provides dwarf unwind with 8192 as stack dump size
perf record -g dwarf,4096 ls
- provides dwarf unwind with 4096 as stack dump size
perf record -g -- ls
perf record -g fp ls
- provides frame pointer unwind
Signed-off-by: Jiri Olsa jo
current arch registers (will be used in
unwind patches).
Signed-off-by: Jiri Olsa jo...@redhat.com
---
tools/perf/Makefile | 13 +-
tools/perf/arch/x86/include/perf_regs.h | 80 +++
tools/perf/util/perf_regs.h | 14 +
3
Updating attr_file_abi_sizes array with PERF_ATTR_SIZE_VER2 version,
so we have the swap check complete.
Signed-off-by: Jiri Olsa jo...@redhat.com
---
tools/perf/util/header.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/tools/perf/util/header.c b/tools/perf/util
of samples.
Signed-off-by: Jiri Olsa jo...@redhat.com
Original-patch-by: Frederic Weisbecker fweis...@gmail.com
[ Dump registers ABI specification. ]
Suggested-by: Stephane Eranian eran...@google.com
---
arch/x86/kernel/perf_regs.c | 15 ++
include/linux/perf_event.h | 35
On Wed, Aug 01, 2012 at 01:57:40PM +0200, Markus Trippelsdorf wrote:
On 2012.07.31 at 16:14 +0200, Ingo Molnar wrote:
Jiri Olsa (4):
perf symbols: Factor DSO symtab types to generic binary types
The commit above causes perf segfaults on my machine (running glibc trunk):
(gdb) run
On Wed, Aug 01, 2012 at 02:25:22PM +0200, Markus Trippelsdorf wrote:
On 2012.08.01 at 14:21 +0200, Jiri Olsa wrote:
On Wed, Aug 01, 2012 at 01:57:40PM +0200, Markus Trippelsdorf wrote:
On 2012.07.31 at 16:14 +0200, Ingo Molnar wrote:
Jiri Olsa (4):
perf symbols: Factor DSO
Following commit introduced wrong array boundaries, that could
lead to SIGSEGV.
perf symbols: Factor DSO symtab types to generic binary types
commit 44f24cb3156a1e7d2b6bb501b7f6153aed08994c
Author: Jiri Olsa jo...@redhat.com
Fixing to use proper array size.
Reported-by: Markus
.
Signed-off-by: Jiri Olsa jo...@redhat.com
Cc: Frederic Weisbecker fweis...@gmail.com
---
tools/perf/util/parse-events-test.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/tools/perf/util/parse-events-test.c
b/tools/perf/util/parse-events-test.c
index 1b997d2
On Wed, Aug 01, 2012 at 08:26:11AM -0600, David Ahern wrote:
On 8/1/12 4:11 AM, Jiri Olsa wrote:
+static int
+parse_callchain_opt(const struct option *opt __used, const char *arg,
+int unset)
+{
+struct perf_record *rec = (struct perf_record *)opt-value;
+char *tok
On Thu, Aug 02, 2012 at 11:38:26AM +0400, Andrew Vagin wrote:
On Wed, Aug 01, 2012 at 02:10:59PM +0400, Jiri Olsa wrote:
From: Frederic Weisbecker fweis...@gmail.com
Introducing following bits to the the perf_event_attr struct:
- exclude_callchain_kernel to filter out kernel callchain
On Thu, Aug 02, 2012 at 11:47:30AM -0700, Andy Lutomirski wrote:
On 07/22/2012 05:14 AM, Jiri Olsa wrote:
Adding copy_from_user_nmi_nochk that provides the best effort
copy regardless the requesting size crossing the task boundary.
This is going to be useful for stack dump we need
On Mon, Aug 20, 2012 at 10:25:42AM +0200, Stephane Eranian wrote:
On Mon, Jul 9, 2012 at 10:37 PM, Jiri Olsa jo...@redhat.com wrote:
SNIP
+static ssize_t event_sysfs_data(char *page, u64 config)
+{
+ u64 event = (config ARCH_PERFMON_EVENTSEL_EVENT) |
+(config
On Thu, Aug 16, 2012 at 09:10:21PM +0200, Robert Richter wrote:
Use command line string provided by the -e option to name events. This
way we get unique events names that also support pmu event syntax
(pmu_name/config/modifier). No need to reconstruct the name
anymore from its attributes. We
On Tue, Aug 21, 2012 at 11:32:31AM +0200, Ingo Molnar wrote:
* Arnaldo Carvalho de Melo a...@infradead.org wrote:
SNIP
One minor observation, the Makefile tells us:
Makefile:496: No libunwind found. Please install libunwind = 0.99
I guess that should be libunwind-dev[el], right?
found some code in misc.c that could be ifdef'ed for KMOD
Signed-off-by: Jiri Olsa [EMAIL PROTECTED]
---
drivers/char/misc.c |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/drivers/char/misc.c b/drivers/char/misc.c
index a39101f..3455b09 100644
--- a/drivers/char
Hi,
seems struct char_device_struct::fops is no longer used, removing it.
I checked with make allyesconfig and got proper compile.
Signed-off-by: Jiri Olsa [EMAIL PROTECTED]
---
fs/char_dev.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/fs/char_dev.c b/fs/char_dev.c
oops, sorry... for some reason I though you were the guy :)
I'll resend
jirka
Greg KH wrote:
On Wed, Feb 20, 2008 at 09:57:23PM +0100, Jiri Olsa wrote:
Hi,
seems struct char_device_struct::fops is no longer used, removing it.
I checked with make allyesconfig and got proper compile
Removing duplicit #includes for kernel/
Signed-off-by: Jiri Olsa [EMAIL PROTECTED]
---
kernel/printk.c |1 -
kernel/profile.c |2 --
kernel/sysctl.c |1 -
3 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/kernel/printk.c b/kernel/printk.c
index a30fe33..3f06748 100644
Removing duplicit #includes for kernel/
Signed-off-by: Jiri Olsa [EMAIL PROTECTED]
---
kernel/printk.c |1 -
kernel/profile.c |2 --
kernel/sysctl.c |1 -
3 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/kernel/printk.c b/kernel/printk.c
index a30fe33..3f06748 100644
sorry, the patch is mangled, I will resend another
Jiri Olsa wrote:
Removing duplicit #includes for kernel/
Signed-off-by: Jiri Olsa [EMAIL PROTECTED]
---
kernel/printk.c |1 -
kernel/profile.c |2 --
kernel/sysctl.c |1 -
3 files changed, 0 insertions(+), 4 deletions
On Fri, Jul 06, 2012 at 03:42:54AM +0200, Stephane Eranian wrote:
On Fri, Jul 6, 2012 at 3:32 AM, Ulrich Drepper drep...@gmail.com wrote:
On Thu, Jul 5, 2012 at 12:15 PM, Stephane Eranian eran...@google.com
wrote:
I don't understand why you actually need the :2 suffix. There can
only be
hi,
here's the change to make following syntax available:
perf stat -e cpu/event=instructions/u ls
this is identical to:
perf stat -e instructions:u ls
v3 changes:
- patches v2 1,5,6,9 are already in
- patch 1 - sysfs 'events' attribute file names with dashes '-'
- using
for the currently running cpu model.
# cat /sys/devices/cpu/events/stalled-cycles-backend
event=0xb1,umask=0x01,inv,cmask=0x01
Suggested-by: Peter Zijlstra a.p.zijls...@chello.nl
Signed-off-by: Jiri Olsa jo...@redhat.com
---
arch/x86/kernel/cpu/perf_event.c | 74
The pmu_lookup should return pmus that do not expose the 'events'
group attribute in sysfs. Also it should fail when any other error
during 'events' lookup is hit (pmu_aliases fails).
Signed-off-by: Jiri Olsa jo...@redhat.com
---
tools/perf/util/pmu.c |7 ---
1 file changed, 4 insertions
) and that modifier is properly set.
Signed-off-by: Jiri Olsa jo...@redhat.com
---
tools/perf/util/parse-events-test.c | 75 ++-
1 file changed, 73 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/parse-events-test.c
b/tools/perf/util/parse-events
handled by the pmu alias code.
Signed-off-by: Jiri Olsa jo...@redhat.com
---
tools/perf/util/parse-events.c | 13 +
tools/perf/util/parse-events.h |2 ++
tools/perf/util/parse-events.y |9 +
3 files changed, 24 insertions(+)
diff --git a/tools/perf/util/parse-events.c b
The sysfs events group attribute currently shows all hw events,
including also undefined ones.
This patch filters out all undefined events out of the sysfs events
group attribute, so they don't even show up.
Suggested-by: Peter Zijlstra a.p.zijls...@chello.nl
Signed-off-by: Jiri Olsa jo
Format data are allocated during PMU lookup. If the lookup
fails in next steps, we don't release the format data.
This patch ensures that format data get released in case
there's failure during PMU load.
Signed-off-by: Jiri Olsa jo...@redhat.com
---
tools/perf/util/pmu.c | 58
of samples.
Signed-off-by: Jiri Olsa jo...@redhat.com
Original-patch-by: Frederic Weisbecker fweis...@gmail.com
---
include/linux/perf_event.h | 20 --
kernel/events/core.c | 61
2 files changed, 78 insertions(+), 3 deletions(-)
diff
Updating attr_file_abi_sizes array with PERF_ATTR_SIZE_VER2 version,
so we have the swap check complete.
Signed-off-by: Jiri Olsa jo...@redhat.com
---
tools/perf/util/header.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/tools/perf/util/header.c b/tools/perf/util
the directory with libunwind to be linked. This is used for
debug purposes.
Signed-off-by: Jiri Olsa jo...@redhat.com
Signed-off-by: Frederic Weisbecker fweis...@gmail.com
---
tools/perf/Makefile | 30 +-
tools/perf/config/feature-tests.mak | 25
to the architecture to map the registers into the mask bits.
For the x86 arch implementation, both 32 and 64 bit registers
bits are defined within single enum to ensure 64 bit system can
provide register dump for compat task if needed in the future.
Signed-off-by: Jiri Olsa jo...@redhat.com
Original
stack unwinding.
Signed-off-by: Jiri Olsa jo...@redhat.com
Signed-off-by: Frederic Weisbecker fweis...@gmail.com
---
include/linux/perf_event.h | 18 ++-
kernel/events/core.c | 121 +++-
2 files changed, 137 insertions(+), 2 deletions(-)
diff
callchains filtering ]
Signed-off-by: Jiri Olsa jo...@redhat.com
---
include/linux/perf_event.h |5 -
kernel/events/callchain.c | 25 +++--
kernel/events/core.c |5 -
kernel/events/internal.h |3 ++-
4 files changed, 25 insertions(+), 13 deletions
current arch registers (will be used in
unwind patches).
Signed-off-by: Jiri Olsa jo...@redhat.com
---
tools/perf/Makefile | 13 +-
tools/perf/arch/x86/include/perf_regs.h | 80 +++
tools/perf/util/perf_regs.h | 14 +
3
In other word we first try to open DSO build-id path,
and if that fails we try to open DSO system path.
dso__data_read_offset
- reads DSO data from specified offset
dso__data_read_addr
- reads DSO data from specified address/map.
Signed-off-by: Jiri Olsa jo...@redhat.com
---
tools
:
typedef int (*unwind_entry_cb_t)(struct unwind_entry *entry,
void *arg);
Signed-off-by: Jiri Olsa jo...@redhat.com
Signed-off-by: Frederic Weisbecker fweis...@gmail.com
---
tools/perf/Makefile|2 +
tools/perf
with libunwind)
perf record -g dwarf ls
- provides dwarf unwind with 8192 as stack dump size
perf record -g dwarf,4096 ls
- provides dwarf unwind with 4096 as stack dump size
perf record -g -- ls
perf record -g fp ls
- provides frame pointer unwind
Signed-off-by: Jiri Olsa jo
Adding automated test for DSO data reading. Testing raw/cached
reads from different file/cache locations.
Signed-off-by: Jiri Olsa jo...@redhat.com
---
tools/perf/Makefile |1 +
tools/perf/builtin-test.c |4 +
tools/perf/util/dso-test-data.c | 154
from file,
and returns the data. If it is present, data are returned
with no file read.
Each data read is cached by reading cache page sized/aligned
amount of DSO data. The cache page size is hardcoded to 4096.
The cache is using RB tree with file offset as a sort key.
Signed-off-by: Jiri Olsa jo
dumps.
Signed-off-by: Jiri Olsa jo...@redhat.com
Signed-off-by: Frederic Weisbecker fweis...@gmail.com
---
tools/perf/builtin-test.c |4 ++--
tools/perf/util/event.h | 16 +++-
tools/perf/util/evlist.c |8
tools/perf/util/evlist.h |1 +
tools/perf/util
-off-by: Jiri Olsa jo...@redhat.com
---
tools/perf/builtin-top.c |2 +-
tools/perf/util/annotate.c |2 +-
tools/perf/util/symbol.c | 209 ++--
tools/perf/util/symbol.h | 34
4 files changed, 145 insertions(+), 102 deletions(-)
diff
need a way to skip the remaining bytes.
This is going to be useful when storing the user stack dump,
where we might end up with less data than we originally requested.
Signed-off-by: Jiri Olsa jo...@redhat.com
Acked-by: Frederic Weisbecker fweis...@gmail.com
---
include/linux/perf_event.h |2
hi,
patches available also as tarball in here:
http://people.redhat.com/~jolsa/perf_post_unwind_v7.tar.bz2
v7 changes:
- omitted v6 patches 9 and 15
They need more work and will be sent separately. I dont want to hold off
whole
patchset because of them. We could miss some related
function is used and __copy_from_user_inatomic for the rest
of the architectures.
This new function will be used in user stack dump on sample,
coming in next patches.
Signed-off-by: Frederic Weisbecker fweis...@gmail.com
Signed-off-by: Jiri Olsa jo...@redhat.com
---
arch/x86/include/asm/perf_event.h
of
the requested dump size, regardless this size is crossing
the task boundary.
Signed-off-by: Jiri Olsa jo...@redhat.com
---
arch/x86/include/asm/uaccess.h |2 ++
arch/x86/lib/usercopy.c| 15 +++
2 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/arch/x86
-by: David Ahern dsah...@gmail.com
Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net
Cc: Ingo Molnar mi...@kernel.org
Cc: Jiri Olsa jo...@redhat.com
Tested-by: Jiri Olsa jo...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
Olsa jo...@redhat.com
Signed-off-by: David Ahern dsah...@gmail.com
Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net
Cc: Ingo Molnar mi...@kernel.org
Cc: Jiri Olsa jo...@redhat.com
Cc: Namhyung Kim namhy...@kernel.org
Cc: Frederic Weisbecker fweis...@gmail.com
Cc: Peter Zijlstra pet
which is wrong. With this patch you get:
31.50% 39258 [guest/18772] [unknown] [u] 0x7fd7dcaea8e5
31.50% 39236 [guest/11230] [unknown] [u] 0x00a57340
30.84% 39232 [guest/18395] [unknown] [u] 0x7f66f641e107
Tested-by: Jiri Olsa jo...@redhat.com
On Tue, Jul 24, 2012 at 06:01:27PM +0900, Namhyung Kim wrote:
In order to support the event group viewer, their group relationship
is needed. Since it's not recorded explicitly anywhere in the perf.data
we should parse saved cmdline and apply the result to the evlist. It is
assumed that parsed
On Wed, Dec 05, 2012 at 03:56:42PM +0900, Namhyung Kim wrote:
From: Namhyung Kim namhyung@lge.com
SNIP
- struct rb_node *next = rb_first(hists-entries);
+ struct rb_root *root;
+ struct rb_node *next;
+
+ if (sort__need_collapse)
+ root =
On Wed, Dec 05, 2012 at 08:06:46PM +0100, Jiri Olsa wrote:
On Wed, Dec 05, 2012 at 03:56:42PM +0900, Namhyung Kim wrote:
From: Namhyung Kim namhyung@lge.com
SNIP
- struct rb_node *next = rb_first(hists-entries);
+ struct rb_root *root;
+ struct rb_node *next
On Wed, Dec 05, 2012 at 04:12:09PM -0300, Arnaldo Carvalho de Melo wrote:
Em Wed, Dec 05, 2012 at 08:06:46PM +0100, Jiri Olsa escreveu:
On Wed, Dec 05, 2012 at 03:56:42PM +0900, Namhyung Kim wrote:
From: Namhyung Kim namhyung@lge.com
@@ -481,6 +459,11 @@ static void hists__process
0.84% -0.83% dbus-daemon
0.02% -0.01% perf
0.40% -0.40% wpa_supplicant
0.05% -0.05% gpm
0.04% -0.04%crond
small nitpick below, otherwise
Acked-by: Jiri Olsa jo...@redhat.com
Its only user - at the time of this writing
respin, or I can
send it later.
other than that:
Acked-by: Jiri Olsa jo...@redhat.com
thanks,
jirka
---
diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
index f66968e..6f56f78 100644
--- a/tools/perf/builtin-diff.c
+++ b/tools/perf/builtin-diff.c
@@ -425,12 +425,15 @@ static void
collapsing. So change
the order for the sake of consistency. It will be required for
matching and/or linking multiple hist entries.
As discussed with Arnadlo, this change seems like changing the
sort order... could you ellaborate how it is usefull in future?
thanks,
jirka
Cc: Jiri Olsa jo
On Fri, Dec 07, 2012 at 05:38:22PM +0900, Namhyung Kim wrote:
Hi Arnaldo,
SNIP
@@ -739,6 +739,10 @@ static struct hist_entry *hists__add_dummy_entry(struct
hists *hists,
cmp = hist_entry__collapse(he, pair);
+ if (sort__need_collapse)
+
collapsing. So change
the order for the sake of consistency. It will be required for
matching and/or linking multiple hist entries.
Cc: Jiri Olsa jo...@redhat.com
Cc: Stephane Eranian eran...@google.com
Signed-off-by: Namhyung Kim namhy...@kernel.org
Acked-by: Jiri Olsa jo...@redhat.com
for multiple files.
Signed-off-by: Jiri Olsa jo...@redhat.com
Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net
Cc: Peter Zijlstra a.p.zijls...@chello.nl
Cc: Ingo Molnar mi...@elte.hu
Cc: Paul Mackerras pau...@samba.org
Cc: Corey Ashford cjash...@linux.vnet.ibm.com
Cc: Frederic Weisbecker fweis
Removing displacement from struct hist_entry_diff, because
it's not used. Displacement is not used for sorting, so
there's no reason to pre-calculate it.
Signed-off-by: Jiri Olsa jo...@redhat.com
Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net
Cc: Peter Zijlstra a.p.zijls...@chello.nl
Cc
Adding 'struct perf_hpp_fmt' into hpp callbacks, so commands
can access their private data.
It'll be handy for diff command in future to be able to access
file related data for each column.
Signed-off-by: Jiri Olsa jo...@redhat.com
Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net
Cc: Peter
Updating perf diff documentation to include multiple perf data
files comparison.
Signed-off-by: Jiri Olsa jo...@redhat.com
Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net
Cc: Peter Zijlstra a.p.zijls...@chello.nl
Cc: Ingo Molnar mi...@elte.hu
Cc: Paul Mackerras pau...@samba.org
Cc: Corey
All compute functions are now local to the diff command,
making them static.
Signed-off-by: Jiri Olsa jo...@redhat.com
Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net
Cc: Peter Zijlstra a.p.zijls...@chello.nl
Cc: Ingo Molnar mi...@elte.hu
Cc: Paul Mackerras pau...@samba.org
Cc: Corey Ashford
Data files are referenced through the index of the file
on the command line. Adding list of data files for each
index to ease up navigation.
Signed-off-by: Jiri Olsa jo...@redhat.com
Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net
Cc: Peter Zijlstra a.p.zijls...@chello.nl
Cc: Ingo Molnar mi
Adding option 'o' to allow sorting based on the
input file number.
Signed-off-by: Jiri Olsa jo...@redhat.com
Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net
Cc: Peter Zijlstra a.p.zijls...@chello.nl
Cc: Ingo Molnar mi...@elte.hu
Cc: Paul Mackerras pau...@samba.org
Cc: Corey Ashford cjash
B and C data (symbol samples)
only if they found in A (baseline)
All other standard diff command computation features
(delta,ratio,wdiff) stays.
Signed-off-by: Jiri Olsa jo...@redhat.com
Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net
Cc: Peter Zijlstra a.p.zijls...@chello.nl
Cc: Ingo Molnar
Forcing zero calculation outputs to appear in final output,
so we can differ between zero output calculation result and
empty space for missing pair of baseline hist_entry.
Also skipping the compute and period output for dummy entries.
Signed-off-by: Jiri Olsa jo...@redhat.com
Cc: Arnaldo
Currently we don't properly display hist data with
symbol_conf.field_sep separator. We need to display
either space or separator.
Signed-off-by: Jiri Olsa jo...@redhat.com
Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net
Cc: Peter Zijlstra a.p.zijls...@chello.nl
Cc: Ingo Molnar mi...@elte.hu
Changing compute methods to operate over hist entry and its
pair directly. This makes the code more obvious and readable,
instead of all time checking for pair being != NULL.
Signed-off-by: Jiri Olsa jo...@redhat.com
Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net
Cc: Peter Zijlstra
Now when diff command is separated from other standard outputs,
we can use perf_hpp__init to initialize all standard columns.
Moving PERF_HPP__OVERHEAD column init back to perf_hpp__init,
and removing extra enable calls.
Signed-off-by: Jiri Olsa jo...@redhat.com
Cc: Arnaldo Carvalho de Melo
Changing formula methods to operate over hist entry and its
pair directly. This makes the code more obvious and readable,
instead of all time checking for pair being != NULL.
Signed-off-by: Jiri Olsa jo...@redhat.com
Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net
Cc: Peter Zijlstra
It's possible different users of hists__match/hists__link will need
specific processing of matching hists_entry data.
Adding callback to hists__match/hists__link functions to allow that.
Signed-off-by: Jiri Olsa jo...@redhat.com
Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net
Cc: Peter
hi,
adding support to display diff for more than 2 perf.data files.
Sending as RFC, since the change touches lot of hists code,
so I might be breaking something I missed.. still testing.
Also it could colide with Namhyung changes for group report
wrt patches 7 and 8, where I changed the linking
401 - 500 of 20027 matches
Mail list logo
