[RFC 0/6] perf tools: Add perf_evlist errno

2013-11-29 Thread Jiri Olsa
not sure about this approach. Maybe it'd be better be more global..? So before throwing this out, sending it as RFC ;-) thanks for ideas, jirka Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi

[PATCH 1/6] perf tools: Add perf_evlist error string interface

2013-11-29 Thread Jiri Olsa
it's not needed. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Namhyung Kim namhy...@kernel.org Cc: Paul Mackerras pau...@samba.org Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc

[PATCH 2/6] perf tools: Add PERF_EVLIST__ERRNO_MMAP internal error

2013-11-29 Thread Jiri Olsa
Adding internal error (PERF_EVLIST__ERRNO_MMAP) for case when 'mmap' syscall fails. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Namhyung Kim namhy...@kernel.org Cc: Paul

[PATCH 4/6] perf tools: Add PERF_EVLIST__ERRNO_IOCTL_ID_GROUP internal error

2013-11-29 Thread Jiri Olsa
Adding internal error (PERF_EVLIST__ERRNO_IOCTL_ID_GROUP) for cases when ioctl syscall fails during perf_evlist__mmap call. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Namhyung

[PATCH 6/6] perf tools: Use perf_evlist__strerror in kvm/record/top/trace commands

2013-11-29 Thread Jiri Olsa
: Failed to mmap events with error 12 (Cannot allocate memory) Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Namhyung Kim namhy...@kernel.org Cc: Paul Mackerras pau...@samba.org Cc

[PATCH 5/6] perf tools: Add PERF_EVLIST__ERRNO_NEWTP internal error

2013-11-29 Thread Jiri Olsa
Adding internal error (PERF_EVLIST__ERRNO_NEWTP) for case when perf_evlist__add_newtp call fails. Moving perf_evlist__strerror_tp function to the error string handling framework. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis

[PATCH 3/6] perf tools: Add PERF_EVLIST__ERRNO_OPEN internal error

2013-11-29 Thread Jiri Olsa
Adding internal error (PERF_EVLIST__ERRNO_OPEN) for cases when perf_evlist__open fails. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Namhyung Kim namhy...@kernel.org Cc: Paul

[PATCHv3 20/29] tools lib traceevent: Remove malloc_or_die from plugin_function.c

2013-11-29 Thread Jiri Olsa
--- Removing malloc_or_die calls from plugin_function.c, replacing them and factoring the code with standard realloc and error path. Suggested-by: Namhyung Kim namhy...@kernel.org Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis

Re: [BUG] perf stat: explicit grouping yields unexpected results

2013-11-29 Thread Jiri Olsa
On Sat, Nov 16, 2013 at 07:41:34PM -0800, Andi Kleen wrote: I'd say that the default behavior should be what Jiri implemented: get the most out of the situation and inform. But you are right in that 'forcing' all elements of a group to be valid should be possible as well - if a special

Re: [PATCH v3 1/4] perf diff: color the Delta column

2013-11-29 Thread Jiri Olsa
On Thu, Nov 28, 2013 at 10:54:25PM +0530, Ramkumar Ramachandra wrote: Jiri Olsa wrote: these colors are not consistent with colors in baseline, moreover all negative values are shown as red - please check get_percent_color function (used for baseline), it checks the percentage against

Re: [BUG] perf stat: explicit grouping yields unexpected results

2013-11-29 Thread Jiri Olsa
On Fri, Nov 29, 2013 at 02:43:35PM +0100, Stephane Eranian wrote: On Fri, Nov 29, 2013 at 2:33 PM, Jiri Olsa jo...@redhat.com wrote: On Sat, Nov 16, 2013 at 07:41:34PM -0800, Andi Kleen wrote: I'd say that the default behavior should be what Jiri implemented: get the most out

Re: [PATCH 34/34] perf tools unwinding: Use the per-feature check flags

2013-11-29 Thread Jiri Olsa
On Thu, Nov 28, 2013 at 09:02:23PM +0100, Jean Pihet wrote: On 28 November 2013 14:46, Arnaldo Carvalho de Melo a...@infradead.org wrote: Em Thu, Nov 28, 2013 at 09:56:19AM -0300, Arnaldo Carvalho de Melo escreveu: Em Thu, Nov 28, 2013 at 10:58:01AM +0100, Jiri Olsa escreveu: On Wed, Nov

Re: [PATCH 06/29] tools lib traceevent: Add jbd2 plugin

2013-11-30 Thread Jiri Olsa
On Fri, Nov 29, 2013 at 03:42:35PM -0300, Arnaldo Carvalho de Melo wrote: Em Thu, Nov 28, 2013 at 12:33:05PM +0100, Jiri Olsa escreveu: Backporting jbd2 plugin. Backported from Steven Rostedt's trace-cmd repo (HEAD 0f2c2fb): git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace

[PATCHv3 01/29] perf tools: Remove stackprotector feature check

2013-11-30 Thread Jiri Olsa
On Fri, Nov 29, 2013 at 03:34:39PM -0300, Arnaldo Carvalho de Melo wrote: Em Thu, Nov 28, 2013 at 12:33:00PM +0100, Jiri Olsa escreveu: We use -fstack-protector-all option to enable stack protecting for all available functions. There's no reason for enabling -Wstack-protector to get warning

Re: [PATCH 06/29] tools lib traceevent: Add jbd2 plugin

2013-11-30 Thread Jiri Olsa
On Fri, Nov 29, 2013 at 04:31:13PM -0300, Arnaldo Carvalho de Melo wrote: Em Fri, Nov 29, 2013 at 03:42:35PM -0300, Arnaldo Carvalho de Melo escreveu: Em Thu, Nov 28, 2013 at 12:33:05PM +0100, Jiri Olsa escreveu: This plugin adds field resolving functions for following tracepoint events

Re: [PATCH v4 1/3] perf diff: color the Delta column

2013-12-01 Thread Jiri Olsa
On Fri, Nov 29, 2013 at 07:06:30PM +0530, Ramkumar Ramachandra wrote: Color the numbers in the Delta column using percent_color_snprintf(). Generalize the function so that we can accommodate all three comparison methods in the future: delta, ratio, and wdiff. Cc: Jiri Olsa jo...@redhat.com

Re: [PATCH v4 2/3] perf diff: color the Ratio column

2013-12-01 Thread Jiri Olsa
On Fri, Nov 29, 2013 at 07:06:31PM +0530, Ramkumar Ramachandra wrote: In $ perf diff -c ratio color the Ratio column using percent_color_snprintf(). Cc: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@redhat.com Signed-off-by: Ramkumar Ramachandra artag...@gmail.com

Re: [PATCH 06/29] tools lib traceevent: Add jbd2 plugin

2013-12-02 Thread Jiri Olsa
On Mon, Dec 02, 2013 at 04:26:51PM -0300, Arnaldo Carvalho de Melo wrote: Em Sat, Nov 30, 2013 at 05:49:21PM +0100, Jiri Olsa escreveu: On Fri, Nov 29, 2013 at 04:31:13PM -0300, Arnaldo Carvalho de Melo wrote: Em Fri, Nov 29, 2013 at 03:42:35PM -0300, Arnaldo Carvalho de Melo escreveu

Re: [PATCHSET 0/8] perf tools: Fix scalability problem on callchain merging (v5)

2013-10-13 Thread Jiri Olsa
On Fri, Oct 11, 2013 at 04:04:43PM -0600, David Ahern wrote: On 10/11/13 3:51 PM, Andi Kleen wrote: David Ahern dsah...@gmail.com writes: On 10/11/13 9:11 AM, David Ahern wrote: It would be nice to fix the callchain arg handler to not attempt to process the next argument if it is not fp or

Re: [PATCHSET 0/8] perf tools: Fix scalability problem on callchain merging (v5)

2013-10-13 Thread Jiri Olsa
On Fri, Oct 11, 2013 at 02:15:35PM +0900, Namhyung Kim wrote: Hello, This is a new version of callchain improvement patchset. Basically it's almost same as v4 but rebased on current acme/perf/core and some functions are renamed as Frederic requested. Now I'm hunting down a bug in 'perf

[RFC] perf record,top: Add callchain option into .perfconfig

2013-10-13 Thread Jiri Olsa
On Sun, Oct 13, 2013 at 12:25:21PM +0200, Jiri Olsa wrote: SNIP I'll try to come up with something later today jirka hi, here it is.. not fully tested, no doc updates, dont want to go too far before we agreed on this ;-) thanks for comments, jirka -- The callchain option is now used

[PATCH] perf make: Move DEBUG initialization into Makefile.perf

2013-10-13 Thread Jiri Olsa
Adding new top level Makefile invalidated the DEBUG variable check for command line origin. Moving this check into Makefile.perf. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: David Ahern dsah...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Namhyung

Re: [PATCHSET 0/8] perf tools: Fix scalability problem on callchain merging (v5)

2013-10-14 Thread Jiri Olsa
On Mon, Oct 14, 2013 at 01:50:09PM +0900, Namhyung Kim wrote: On Sun, 13 Oct 2013 14:34:44 +0200, Jiri Olsa wrote: I put perf archive and data output in here if you're interested: http://people.redhat.com/jolsa/cc/ I can't download the data output (but the archive is fine). $ curl

Re: [PATCH] perf make: Move DEBUG initialization into Makefile.perf

2013-10-14 Thread Jiri Olsa
On Mon, Oct 14, 2013 at 09:16:11AM +0200, Ingo Molnar wrote: * Jiri Olsa jo...@redhat.com wrote: Adding new top level Makefile invalidated the DEBUG variable check for command line origin. Moving this check into Makefile.perf. This ought to be fixed in my latest tip:tmp.perf

Re: [PATCH] perf record: mmap output file - v2

2013-10-15 Thread Jiri Olsa
On Tue, Oct 15, 2013 at 09:25:40AM +0200, Ingo Molnar wrote: * Namhyung Kim namhy...@kernel.org wrote: 3) The rec-bytes_at_mmap_start field feels a bit weird. If I read the code correctly, in every 'perf record' invocation, rec-bytes_written starts at 0 - i.e. we don't

[PATCH 1/3] perf tools: Add data object to handle perf data file

2013-10-15 Thread Jiri Olsa
perf_session are changed now. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Namhyung Kim namhy...@kernel.org Cc: Paul Mackerras pau...@samba.org Cc: Peter Zijlstra a.p.zijls...@chello.nl

[PATCH 2/3] perf tools: Add perf_data_file__open interface to data object

2013-10-15 Thread Jiri Olsa
Adding perf_data_file__open interface to data object to open the perf.data file for both read and write. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Namhyung Kim namhy

[PATCH 3/3] perf tools: Separating data file properties from session

2013-10-15 Thread Jiri Olsa
Removing 'fd, fd_pipe, filename, size' from struct perf_session and replacing them with struct perf_data_file object. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Namhyung Kim

Re: [PATCH] tools lib traceevent: Add direct access to dynamic arrays

2013-11-12 Thread Jiri Olsa
On Mon, Nov 11, 2013 at 04:08:10PM -0500, Steven Rostedt wrote: Jiri Olsa was writing a plugin for the cfg80211_tx_mlme_mgmt trace event, and was not able to get the implemented function working. The event's print fmt looks like: netdev:%s(%d), ftype:0x%.2x, REC-name, REC-ifindex

Re: [PATCH] perf top: Make -g refer to callchains

2013-11-18 Thread Jiri Olsa
On Mon, Nov 18, 2013 at 09:59:45AM -0300, Arnaldo Carvalho de Melo wrote: Em Fri, Nov 15, 2013 at 06:46:09AM +0100, Ingo Molnar escreveu: btw., here's some 'perf top' call graph performance and profiling quality feedback, with the latest perf code: 'perf top --call-graph fp' now works

Re: [PATCH] perf top: Make -g refer to callchains

2013-11-18 Thread Jiri Olsa
On Mon, Nov 18, 2013 at 03:26:53PM +0100, Ingo Molnar wrote: * Jiri Olsa jo...@redhat.com wrote: On Mon, Nov 18, 2013 at 09:59:45AM -0300, Arnaldo Carvalho de Melo wrote: Em Fri, Nov 15, 2013 at 06:46:09AM +0100, Ingo Molnar escreveu: btw., here's some 'perf top' call graph

[PATCH 08/28] perf tools: Add filename__read_str util function

2013-12-03 Thread Jiri Olsa
to store data size v2 change: - better error handling suggested by Namhyung Kim. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Namhyung Kim namhy...@kernel.org Cc: Paul Mackerras

[PATCH 04/28] tools lib traceevent: Add traceevent_host_bigendian function

2013-12-03 Thread Jiri Olsa
Adding traceevent_host_bigendian function to get host endianity. It's used in following patches. Signed-off-by: Steven Rostedt rost...@goodmis.org Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi

[PATCH 10/28] perf tools: Add trace-event global object for tracepoint interface

2013-12-03 Thread Jiri Olsa
properly initialized global trace-event object, ensuring proper plugins processing. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Namhyung Kim namhy...@kernel.org Cc: Paul Mackerras

[PATCH 03/28] tools lib traceevent: Add plugin build support

2013-12-03 Thread Jiri Olsa
This path is propagated to the plugin object as a plugins search path. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Namhyung Kim namhy...@kernel.org Cc: Paul Mackerras pau...@samba.org Cc

[PATCHv3 00/28] perf tools: Add traceevent plugins support

2013-12-03 Thread Jiri Olsa
2576 [001] 781.731668: kvmmmu:kvm_mmu_unsync_page: 3/0 q0 --- !pge !nxe root 10 unsync Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Namhyung Kim namhy...@kernel.org Cc: Paul

[PATCH 24/28] tools lib traceevent: Use pevent_print_func_field in hrtimer_start handler

2013-12-03 Thread Jiri Olsa
-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Namhyung Kim namhy...@kernel.org Cc: Paul Mackerras pau...@samba.org Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Arnaldo Carvalho de Melo

[PATCH 27/28] tools lib traceevent: Update kvm plugin with is_writable_pte helper

2013-12-03 Thread Jiri Olsa
0x88019f1e3670 old 0x140cec75 new 140cec77 spurious 0 fixed 1 Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Namhyung Kim namhy...@kernel.org Cc: Paul Mackerras pau...@samba.org Cc

[PATCH 26/28] tools lib traceevent: Remove malloc_or_die from plugin_function.c

2013-12-03 Thread Jiri Olsa
Removing malloc_or_die calls from plugin_function.c, replacing them and factoring the code with standard realloc and error path. Suggested-by: Namhyung Kim namhy...@kernel.org Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis

[PATCH 20/28] tools lib traceevent: Add scsi plugin

2013-12-03 Thread Jiri Olsa
similar to the rest, so I believe it's ok. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Namhyung Kim namhy...@kernel.org Cc: Paul Mackerras pau...@samba.org Cc: Peter Zijlstra

[PATCH 28/28] perf tools: Add udis86 disassembler feature check

2013-12-03 Thread Jiri Olsa
15519 [003] 5332.470049: kvm:kvm_emulate_insn: 0:8103c596:89 b7 00 80 5f ff (prot64) + qemu-system-x86 15519 [003] 5332.470049: kvm:kvm_emulate_insn: 0:8103c596: mov %esi, -0xa08000(%rdi) Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc

[PATCH 23/28] tools lib traceevent: Use static functions in jbd2 plugin

2013-12-03 Thread Jiri Olsa
There's no need for following functions to be global: process_jbd2_dev_to_name process_jiffies_to_msecs Making them static. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc

[PATCH 25/28] tools lib traceevent: Several cleanups for function plugin

2013-12-03 Thread Jiri Olsa
Several cleanups suggested by Namhyung: * removing index field from struct func_stack as it's not needed * renaming get_index into add_and_get_index * using '%*X' format string capability instead of the loop Suggested-by: Namhyung Kim namhy...@kernel.org Signed-off-by: Jiri Olsa jo

[PATCH 22/28] tools lib traceevent: Remove malloc_or_die from event-plugin.c

2013-12-03 Thread Jiri Olsa
Removing malloc_or_die calls from event-plugin.c, replacing them with standard malloc and error path. Suggested-by: Namhyung Kim namhy...@kernel.org Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar

[PATCH 18/28] tools lib traceevent: Add function plugin

2013-12-03 Thread Jiri Olsa
indents Enabling both of them by default. Signed-off-by: Steven Rostedt rost...@goodmis.org Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Namhyung Kim namhy...@kernel.org Cc: Paul

[PATCH 21/28] tools lib traceevent: Add cfg80211 plugin

2013-12-03 Thread Jiri Olsa
, 0b, a9, c6, f4, 74, d8, 24, bd, a1, 26, 31, d8, 24, bd, a1, 26, 31, 10, b7, 00, 00, 02, 00, 00, 00] + kworker/u16:0 1697 [002] 664.808210: cfg80211:cfg80211_rx_mlme_mgmt: netdev:wlan0(3), ftype:0xb0 Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc

[PATCH 11/28] perf tools: Overload pr_stat traceevent print function

2013-12-03 Thread Jiri Olsa
The traceevent lib uses pr_stat to display all standard info. It's defined as __weak. Overloading it with perf version plugged into perf output system logic. Displaying the pr_stat stuff under '-v' option. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc

[PATCH 15/28] tools lib traceevent: Add kvm plugin

2013-12-03 Thread Jiri Olsa
broken because of missing is_writable_pte function and is fixed in another patch - ommited following tracepoints from backport because the output was buggy kvm:kvm_nested_vmexit kvm:kvm_nested_vmexit_inject Signed-off-by: Steven Rostedt rost...@goodmis.org Signed-off-by: Jiri Olsa

[PATCH 14/28] tools lib traceevent: Add kmem plugin

2013-12-03 Thread Jiri Olsa
] 29643.445546: kmem:kmalloc_node: (__alloc_skb+0x7e) call_site=8153c67e ptr=0x880103828e00 bytes_req=384 bytes_alloc=512 gfp_flags=GFP_KERNEL|GFP_NOWARN|GFP_REPEAT|GFP_NOMEMALLOC node=-1 Signed-off-by: Steven Rostedt rost...@goodmis.org Signed-off-by: Jiri Olsa jo...@redhat.com Cc

[PATCH 13/28] tools lib traceevent: Add hrtimer plugin

2013-12-03 Thread Jiri Olsa
into the function name. Signed-off-by: Steven Rostedt rost...@goodmis.org Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Namhyung Kim namhy...@kernel.org Cc: Paul Mackerras pau...@samba.org

[PATCH 19/28] tools lib traceevent: Add xen plugin

2013-12-03 Thread Jiri Olsa
xen:xen_mmu_ptep_modify_prot_start xen:xen_mmu_ptep_modify_prot_commit Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Namhyung Kim namhy...@kernel.org Cc: Paul Mackerras pau...@samba.org Cc

[PATCH 16/28] tools lib traceevent: Add mac80211 plugin

2013-12-03 Thread Jiri Olsa
enable_beacon:0 + ht_operation_mode:0 Omitting the mac80211:drv_config tracepoint handling because the kernel tracepoint changed its prototype and the plugin handler is no longer working. Signed-off-by: Jiri Olsa jo...@redhat.com Cc

[PATCH 12/28] tools lib traceevent: Add jbd2 plugin

2013-12-03 Thread Jiri Olsa
logging 104 handle_count 2995 blocks 17 blocks_logged 18 This plugin also adds jbd2_dev_to_name function, which was removed from jdb2 tracepoints recently. Keeping it in for backward compatibility reasons. Signed-off-by: Steven Rostedt rost...@goodmis.org Signed-off-by: Jiri Olsa jo...@redhat.com Cc

[PATCH 17/28] tools lib traceevent: Add sched_switch plugin

2013-12-03 Thread Jiri Olsa
=120 +perf 577 [002] 30965.311852: sched:sched_switch: perf:577 [120] S == swapper/2:0 [120] Signed-off-by: Steven Rostedt rost...@goodmis.org Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo

[PATCH 09/28] perf tools: Add trace-event object

2013-12-03 Thread Jiri Olsa
'struct pevent' and plugins Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Namhyung Kim namhy...@kernel.org Cc: Paul Mackerras pau...@samba.org Cc: Peter Zijlstra a.p.zijls...@chello.nl

[PATCH 01/28] perf tools: Remove stackprotector feature check

2013-12-03 Thread Jiri Olsa
We use -fstack-protector-all option to enable stack protecting for all available functions. There's no reason for enabling -Wstack-protector to get warning for unprotected functions. Removing stackprotector feature check which was used to enable the -Wstack-protector option. Signed-off-by: Jiri

[PATCH 05/28] tools lib traceevent: Change pevent_parse_format to include pevent handle

2013-12-03 Thread Jiri Olsa
completely. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Namhyung Kim namhy...@kernel.org Cc: Paul Mackerras pau...@samba.org Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Arnaldo

[PATCH 02/28] tools lib traceevent: Add plugin support

2013-12-03 Thread Jiri Olsa
*pevent) - loads plusing for 'struct pevent' object and returns loaded plugins list void traceevent_unload_plugins(struct plugin_list *plugin_list); - unload plugin list Signed-off-by: Steven Rostedt rost...@goodmis.org Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford

[PATCH 06/28] tools lib traceevent: Harmonize the install messages in lib-traceevent

2013-12-03 Thread Jiri Olsa
plugin_scsi.so Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Namhyung Kim namhy...@kernel.org Cc: Paul Mackerras pau...@samba.org Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Arnaldo

[PATCH 07/28] perf tools: Add build and install plugins targets

2013-12-03 Thread Jiri Olsa
/lib64/traceevent/plugins/plugin_function.so /opt/perf/lib64/traceevent/plugins/plugin_cfg80211.so /opt/perf/lib64/traceevent/plugins/plugin_xen.so Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi

Re: [PATCH 22/28] tools lib traceevent: Remove malloc_or_die from event-plugin.c

2013-12-04 Thread Jiri Olsa
On Tue, Dec 03, 2013 at 11:16:01AM -0500, Steven Rostedt wrote: On Tue, 3 Dec 2013 14:09:36 +0100 Jiri Olsa jo...@redhat.com wrote: Removing malloc_or_die calls from event-plugin.c, replacing them with standard malloc and error path. Suggested-by: Namhyung Kim namhy...@kernel.org

Re: [PATCH 28/28] perf tools: Add udis86 disassembler feature check

2013-12-04 Thread Jiri Olsa
On Wed, Dec 04, 2013 at 03:53:02PM -0300, Arnaldo Carvalho de Melo wrote: SNIP Auto-detecting system features: ... backtrace: [ on ] ... dwarf: [ on ] ...fortify-source: [ on ] ... glibc: [ on ] ...

Re: [PATCH 28/28] perf tools: Add udis86 disassembler feature check

2013-12-05 Thread Jiri Olsa
On Wed, Dec 04, 2013 at 03:50:24PM -0300, Arnaldo Carvalho de Melo wrote: Em Tue, Dec 03, 2013 at 02:09:42PM +0100, Jiri Olsa escreveu: Adding udis86 disassembler feature check which support is needed for kvm:kvm_emulate_insn tracepoint. +$(call feature_check,udis86) +ifeq ($(feature

[PATCHv4 28/28] perf tools: Add udis86 disassembler feature check

2013-12-05 Thread Jiri Olsa
On Thu, Dec 05, 2013 at 09:05:13AM +0100, Jiri Olsa wrote: On Wed, Dec 04, 2013 at 03:50:24PM -0300, Arnaldo Carvalho de Melo wrote: Em Tue, Dec 03, 2013 at 02:09:42PM +0100, Jiri Olsa escreveu: Adding udis86 disassembler feature check which support is needed for kvm:kvm_emulate_insn

Re: [RFC 0/6] perf tools: Add perf_evlist errno

2013-12-05 Thread Jiri Olsa
On Mon, Dec 02, 2013 at 05:19:18PM +0900, Namhyung Kim wrote: Hi Jiri, On Fri, 29 Nov 2013 12:45:04 +0100, Jiri Olsa wrote: hi, Andi reported wrong error message for :S modifier on kernel without event ID ioctl support. The reason was that the ioctl failed, but the error

Re: [PATCH 28/28] perf tools: Add udis86 disassembler feature check

2013-12-05 Thread Jiri Olsa
On Thu, Dec 05, 2013 at 10:25:02AM +0100, Ingo Molnar wrote: * Jiri Olsa jo...@redhat.com wrote: On Wed, Dec 04, 2013 at 03:50:24PM -0300, Arnaldo Carvalho de Melo wrote: Em Tue, Dec 03, 2013 at 02:09:42PM +0100, Jiri Olsa escreveu: Adding udis86 disassembler feature check which

Re: [GIT PULL 00/38] perf/core improvements and fixes

2013-12-05 Thread Jiri Olsa
On Thu, Dec 05, 2013 at 11:04:29AM +0100, Ingo Molnar wrote: * Arnaldo Carvalho de Melo a...@infradead.org wrote: From: Arnaldo Carvalho de Melo a...@ghostprotocols.net Hi Ingo, Please consider pulling, - Arnaldo The following changes since commit

Re: [GIT PULL 00/38] perf/core improvements and fixes

2013-12-05 Thread Jiri Olsa
On Thu, Dec 05, 2013 at 11:53:44AM +0100, Ingo Molnar wrote: SNIP I saw it again on a system by running two parallel build jobs: D=/tmp/perf-1; mkdir -p $D; while make O=$D install; do make O=$D clean; done D=/tmp/perf-2; mkdir -p $D; while make O=$D install; do make O=$D clean;

Re: [GIT PULL 00/38] perf/core improvements and fixes

2013-12-05 Thread Jiri Olsa
On Thu, Dec 05, 2013 at 11:59:14AM +0100, Ingo Molnar wrote: * Ingo Molnar mi...@kernel.org wrote: never saw that one.. starting your test on 24 CPUs server now I saw it again on a system by running two parallel build jobs: D=/tmp/perf-1; mkdir -p $D; while make O=$D install;

Re: [GIT PULL 00/38] perf/core improvements and fixes

2013-12-05 Thread Jiri Olsa
On Thu, Dec 05, 2013 at 01:27:51PM +0100, Ingo Molnar wrote: * Jiri Olsa jo...@redhat.com wrote: On Thu, Dec 05, 2013 at 11:59:14AM +0100, Ingo Molnar wrote: * Ingo Molnar mi...@kernel.org wrote: never saw that one.. starting your test on 24 CPUs server now I saw

Re: [PATCH 28/28] perf tools: Add udis86 disassembler feature check

2013-12-05 Thread Jiri Olsa
On Thu, Dec 05, 2013 at 11:45:46AM +0100, Ingo Molnar wrote: SNIP 1) So, the first problem I can see is in the output: Auto-detecting system features: ... backtrace: [ on ] ... dwarf: [ on ] ...

Re: [PATCH] perf kvm: introduce --list-cmds for use by scripts

2014-03-14 Thread Jiri Olsa
On Thu, Mar 13, 2014 at 11:52:12AM -0400, Ramkumar Ramachandra wrote: Ramkumar Ramachandra wrote: Jiri Olsa wrote: On Mon, Mar 03, 2014 at 08:26:36PM -0500, Ramkumar Ramachandra wrote: Introduce $ perf kvm --list-cmds to dump a raw list of commands for use by the completion script

Re: [PATCH] perf: Speed up thread map generation

2014-03-14 Thread Jiri Olsa
On Thu, Mar 13, 2014 at 05:16:37PM -0400, Don Zickus wrote: SNIP + event-fork.ptid = tgid; + event-fork.pid = tgid; + event-fork.tid = pid; + event-fork.header.type = PERF_RECORD_FORK; + + event-fork.header.size = (sizeof(event-fork) + machine-id_hdr_size); + +

[PATCH 4/5] perf tools: Add machine pointer into thread struct

2014-03-14 Thread Jiri Olsa
Need machine pointer in thread object, so we could lookup the process thread in following patch. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Don Zickus dzic...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: David Ahern dsah...@gmail.com Cc: Frederic Weisbecker fweis...@gmail.com

[PATCH 5/5] perf tools: Share process map groups within process threads

2014-03-14 Thread Jiri Olsa
Sharing map groups within all process threads. This way there's only one copy of mmap info and it's reachale from any thread within the process. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Don Zickus dzic...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: David Ahern dsah

[PATCH 1/5] perf tests: Add tip/pid mmap automated tests

2014-03-14 Thread Jiri Olsa
Adding automated test for memory maps lookup within multiple machines threads. The test creates 4 threads and separated memory maps. It checks that we could use thread__find_addr_map function with thread object based on TID to find memory maps. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Don

[PATCH 3/5] perf tools: Allocate thread map_groups dynamicaly

2014-03-14 Thread Jiri Olsa
Moving towards sharing map groups within a process threads. Because of this we need the map groups to be dynamically allocated. No other functional change is intended in here. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Don Zickus dzic...@redhat.com Cc: Corey Ashford cjash

[PATCH 2/5] perf tools: Factor machine__find_thread to take tid argument

2014-03-14 Thread Jiri Olsa
Forcing the code to always search thread by pid/tid pair. The PID value will be needed in future to determine the process thread leader for map groups sharing. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Don Zickus dzic...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: David

[RFC 0/5] perf tools: Share map groups within process

2014-03-14 Thread Jiri Olsa
thread: http://marc.info/?l=linux-kernelm=139403876017159w=2 This patches still has some loose ends, just wanted to hear opinions for this concept. thanks, jirka Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Don Zickus dzic...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: David Ahern

Re: [PATCH V2] perf: Speed up thread map generation

2014-03-14 Thread Jiri Olsa
-by: Don Zickus dzic...@redhat.com -- V2: based on Jiri's comments, moved malloc up a level and made sure the memory was freed Acked-by: Jiri Olsa jo...@redhat.com thanks, jirka -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH] perf sched latency: prettify printed table

2014-03-17 Thread Jiri Olsa
On Sat, Mar 15, 2014 at 12:17:38PM -0400, Ramkumar Ramachandra wrote: Cc: Frederic Weisbecker fweis...@gmail.com Cc: David Ahern dsah...@gmail.com Cc: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@redhat.com Signed-off-by: Ramkumar Ramachandra artag...@gmail.com --- tools

Re: [PATCH 1/5] perf tests: Add tip/pid mmap automated tests

2014-03-17 Thread Jiri Olsa
On Fri, Mar 14, 2014 at 05:24:21PM -0300, Arnaldo Carvalho de Melo wrote: Em Fri, Mar 14, 2014 at 03:00:02PM +0100, Jiri Olsa escreveu: Adding automated test for memory maps lookup within multiple machines threads. CC /tmp/build/perf/arch/x86/util/tsc.o tests/mmap-events.c

Re: [PATCH 1/5] perf tests: Add tip/pid mmap automated tests

2014-03-17 Thread Jiri Olsa
On Mon, Mar 17, 2014 at 01:50:12PM +0900, Namhyung Kim wrote: Hi Jiri, On Fri, 14 Mar 2014 15:00:02 +0100, Jiri Olsa wrote: +static int thread_init(struct thread_data *td) +{ + void *map; + + map = mmap(NULL, page_size, PROT_READ|PROT_WRITE, + MAP_SHARED

Re: [PATCH 5/5] perf tools: Share process map groups within process threads

2014-03-17 Thread Jiri Olsa
On Mon, Mar 17, 2014 at 04:25:15PM +0900, Namhyung Kim wrote: On Fri, 14 Mar 2014 15:00:06 +0100, Jiri Olsa wrote: + if (!mg) { + struct thread *leader = thread__get_leader(thread); + + if (!leader) + return NULL; + + if (leader-mg

Re: [PATCH 3/5] perf tools: Allocate thread map_groups dynamicaly

2014-03-17 Thread Jiri Olsa
On Mon, Mar 17, 2014 at 04:13:53PM +0900, Namhyung Kim wrote: On Fri, 14 Mar 2014 15:00:04 +0100, Jiri Olsa wrote: Moving towards sharing map groups within a process threads. Because of this we need the map groups to be dynamically allocated. No other functional change is intended in here

Re: [PATCH 4/5] perf tools: Add machine pointer into thread struct

2014-03-17 Thread Jiri Olsa
On Mon, Mar 17, 2014 at 04:17:43PM +0900, Namhyung Kim wrote: Hi Arnaldo, On Fri, 14 Mar 2014 11:16:12 -0300, Arnaldo Carvalho de Melo wrote: Em Fri, Mar 14, 2014 at 03:00:05PM +0100, Jiri Olsa escreveu: Need machine pointer in thread object, so we could lookup the process thread

Re: [PATCH 5/5] perf test: squelch warnings about undefined sizeof

2014-03-18 Thread Jiri Olsa
On Tue, Mar 18, 2014 at 05:09:33PM +0900, Namhyung Kim wrote: On Mon, 17 Mar 2014 18:26:38 -0400, Ramkumar Ramachandra wrote: perf test emits the following warnings on the parse events test: $ perf test 5: parse events tests Warning: function sizeof not defined Warning:

[PATCH 2/6] perf tools: Remove thread__find_map function

2014-03-18 Thread Jiri Olsa
Because it's not used any more. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Don Zickus dzic...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: David Ahern dsah...@gmail.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@kernel.org Cc: Namhyung Kim namhy

Re: [PATCHSET 0/8] perf tools: Update on filtered entries' percentage output (v5)

2014-02-24 Thread Jiri Olsa
was there before.. and will be fixed.. eventually ;-) Acked-by: Jiri Olsa jo...@redhat.com for the patchset thanks, jirka -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [perf tool] record failure with 3.14-rc4

2014-02-24 Thread Jiri Olsa
On Mon, Feb 24, 2014 at 05:24:41PM +, Will Deacon wrote: Hi guys, If I try to run perf record as a non-root user, I end up with the following (unhelpful) error: $ perf record -e cycles ls [...] Not enough memory for reading perf file header This is because the addresses in

[RFC] perf tools: Fix strict alias issue for find_first_bit

2014-02-26 Thread Jiri Olsa
by using __may_alias__ attribute: http://gcc.gnu.org/onlinedocs/gcc-4.4.0/gcc/Type-Attributes.html Using this workaround for the find_first_bit function. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo

[PATCH] perf tools: Do not compile with -fstrict-aliasing

2014-02-26 Thread Jiri Olsa
On Wed, Feb 26, 2014 at 06:18:05PM +0100, Peter Zijlstra wrote: On Wed, Feb 26, 2014 at 06:14:26PM +0100, Jiri Olsa wrote: hi, got issue below when compiling perf tool on i686 with gcc 4.4, but not sure the patch is correct workaround here. thanks for comments, jirka

Re: [GIT PULL 00/12] perf/core improvements and fixes

2014-02-27 Thread Jiri Olsa
. Add support for the new DWARF unwinder library in elfutils (Jiri Olsa) . Fix build race in the generation of bison files (Jiri Olsa) . Further streamline the feature detection display, trimming it a bit to show just the libraries detected, using VF=1 gets a more verbose output

Re: [GIT PULL 00/12] perf/core improvements and fixes

2014-02-27 Thread Jiri Olsa
. Add support for the new DWARF unwinder library in elfutils (Jiri Olsa) . Fix build race in the generation of bison files (Jiri Olsa) . Further streamline the feature detection display, trimming it a bit to show just the libraries detected, using VF=1 gets a more verbose output

Re: [GIT PULL 00/12] perf/core improvements and fixes

2014-02-27 Thread Jiri Olsa
On Thu, Feb 27, 2014 at 01:30:52PM +0100, Ingo Molnar wrote: * Jiri Olsa jo...@redhat.com wrote: On Thu, Feb 27, 2014 at 12:46:58PM +0100, Ingo Molnar wrote: * Arnaldo Carvalho de Melo a...@infradead.org wrote: From: Arnaldo Carvalho de Melo a...@ghostprotocols.net SNIP

[PATCH] x86 trace: Fix page fault tracing bug

2014-02-28 Thread Jiri Olsa
The trace_do_page_fault function trigger tracepoint and then handles the actual page fault. This could lead to error if the tracepoint caused page fault. The original cr2 value gets lost and the original page fault handler kills current process with SIGSEGV. This happens if you record page

Re: [PATCH] x86 trace: Fix page fault tracing bug

2014-02-28 Thread Jiri Olsa
On Fri, Feb 28, 2014 at 04:33:40PM +0100, Jiri Olsa wrote: The trace_do_page_fault function trigger tracepoint and then handles the actual page fault. This could lead to error if the tracepoint caused page fault. The original cr2 value gets lost and the original page fault handler kills

[PATCHv2] x86 trace: Fix page fault tracing bug

2014-02-28 Thread Jiri Olsa
On Fri, Feb 28, 2014 at 04:47:08PM +0100, Peter Zijlstra wrote: On Fri, Feb 28, 2014 at 04:33:40PM +0100, Jiri Olsa wrote: While I like the idea of just pushing up the CR2 read; the below does the read too late still, exception_enter() also has a tracepoint in. please check v2, thanks jirka

[PATCH] perf tools: Fix crash in elf_section_by_name

2014-03-02 Thread Jiri Olsa
Fixing crash in elf_section_by_name function caused by missing section name in elf binary. Reported-by: Albert Strasheim alb...@cloudflare.com Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: David Ahern dsah...@gmail.com Cc: Frederic Weisbecker fweis

[PATCH 1/3] perf: Disallow user space callchains for function trace event

2014-03-02 Thread Jiri Olsa
=13930143733r=1w=2 Suggested-by: Peter Zijlstra a.p.zijls...@chello.nl Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Paul Mackerras pau...@samba.org Cc: Ingo Molnar mi...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: H. Peter Anvin h

<    4   5   6   7   8   9   10   11   12   13   >