Re: [PATCH] x86/kvm: replace TASK_UNINTERRUPTIBLE with TASK_KILLABLE

p seeing something I can improve will definitely cook up a patch and send it in, thanks again! -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

[PATCH v3] scripts/tags.sh: don't parse `ls` for $ALLSOURCE_ARCHS generation

. Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com> 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/scripts/tags.sh b/scripts/tags.sh index 78e546ff689c2d5f40..e4aba2983f6272fc44 100755 --- a/scripts/tags.sh +++ b/scripts/tags.sh @@ -29,14 +29,12 @@ fi ignore="$ign

Re: [PATCH] scripts/tags.sh: don't rely on parsing `ls` for $ALLSOURCE_ARCHS generation

8k microblaze mips > nds32 nios2 openrisc parisc powerpc riscv s390 sh sparc um unicore32 x86 > xtensa However, if there really is no reason for that being there, I have no complaints against fixing it. I'll send a v3 in a bit. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH v3] scripts/tags.sh: don't parse `ls` for $ALLSOURCE_ARCHS generation

p;& find . -maxdepth 1 -type d | > paste -sd' ')" > ALLSOURCE_ARCHS="${ALLSOURCE_ARCHS//[.\/]}" > fi If something like that if acceptable, I'll use that for the v4. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH v3] scripts/tags.sh: don't parse `ls` for $ALLSOURCE_ARCHS generation

ut here in my opinion either. I'll use this in my v4 then, thanks. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH v3] scripts/tags.sh: don't parse `ls` for $ALLSOURCE_ARCHS generation

ure this didn't surprise someone in the future by squeezing the newlines into spaces. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

[PATCH v4] scripts/tags.sh: use `find` for $ALLSOURCE_ARCHS generation

Parsing `ls` is fragile at best and _will_ fail when $tree contains spaces. Replace this with a find-generated string and directly assign it to $ALLSOURCE_ARCHS; a subshell is implied by $(), so `cd` doesn't affect the current working directory. Signed-off-by: Joey Pabalinas <joeypab

Re: [PATCH v4] scripts/tags.sh: use `find` for $ALLSOURCE_ARCHS generation

mands in the script. The ' %f' was changed to '%f ' so that you don't get that weird leading space; I couldn't think of a way this could break anything but I wanted to be 100% sure instead of needing to make a v6, heh. The commit message will definitely be fixed as well. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

[PATCH v5] scripts/tags.sh: use `find` for $ALLSOURCE_ARCHS generation

the arch generation into the surrounding conditional. Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com> 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/scripts/tags.sh b/scripts/tags.sh index 78e546ff689c2d5f40..e587610d149271171d 100755 --- a/scripts/tags.sh +++ b/scripts/t

Re: [PATCH v5] scripts/tags.sh: use `find` for $ALLSOURCE_ARCHS generation

On Tue, May 22, 2018 at 09:59:02PM +0900, Masahiro Yamada wrote: > > Applied to linux-kbuild. Thanks! Cheers :) -- Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH] scripts/tags.sh: don't rely on parsing `ls` for $ALLSOURCE_ARCHS generation

On Tue, May 15, 2018 at 02:13:11PM -1000, Joey Pabalinas wrote: > and directly assign it to $ALLSOURCE_ARCHS; use a subshell > so `cd` doesn't affect the current working directory. Whoops, turns out the inner `()` isn't needed, so going to revise and send a v2. -- Cheers, Joey Pab

[PATCH v2] scripts/tags.sh: don't parse `ls` for $ALLSOURCE_ARCHS generation

Parsing `ls` is fragile at best and _will_ fail when $tree contains spaces. Replace this with a glob-generated string and directly assign it to $ALLSOURCE_ARCHS; a subshell is implied by $(), so `cd` doesn't affect the current working directory. Signed-off-by: Joey Pabalinas <joeypab

[PATCH] scripts/tags.sh: don't rely on parsing `ls` for $ALLSOURCE_ARCHS generation

Parsing `ls` is fragile at best and _will_ fail when $tree contains spaces. Replace this with a glob-generated string and directly assign it to $ALLSOURCE_ARCHS; use a subshell so `cd` doesn't affect the current working directory. Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com>

Re: [PATCH v4] scripts/tags.sh: use `find` for $ALLSOURCE_ARCHS generation

On Tue, May 22, 2018 at 03:01:07PM +0900, Masahiro Yamada wrote: > The commit log is wrong. > > > 2018-05-18 20:56 GMT+09:00 Joey Pabalinas <joeypabali...@gmail.com>: > > Parsing `ls` is fragile at best and _will_ fail when $tree > > contains spaces. > > Thi

[PATCH 2/4] HID: multitouch: don't check HID_GROUP_MULTITOUCH_WIN_8 for serial protocol

The HID_GROUP_MULTITOUCH_WIN_8 group never needs to check for the serial protocol, so avoid setting `td->serial_maybe = true;` in order to avoid an unnecessary mt_post_parse_default_settings() call Signed-off-by: Joey Pabalinas 1 file changed, 3 insertions(+), 1 deletion(-) diff --

[PATCH 4/4] HID: multitouch: remove unneeded else conditional cases

Elide lone `else` cases and replace `else if` clauses with plain `if` conditionals when they occur immediately after return statements. Signed-off-by: Joey Pabalinas 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index

[PATCH 0/4] reduce Surface Pro 3 multitouch jitter

The Surface Pro 3 firmware doesn't reliably send contact lift off reports nor handle invalid report values gracefully. To reduce touchscreen input jitter: - add MT_QUIRK_NOT_SEEN_MEANS_UP to the MT_CLS_WIN_8 - drop invalid report values Joey Pabalinas (4): HID: multitouch: add

[PATCH 3/4] HID: multitouch: drop reports containing invalid values

Avoid processing reports containing invalid values to reduce multitouch input stutter. Signed-off-by: Joey Pabalinas 1 file changed, 9 insertions(+) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index c0654db0b736543ca0..08b50e5908cecdda66 100644 --- a/drivers/hid

[PATCH 1/4] HID: multitouch: add MT_QUIRK_NOT_SEEN_MEANS_UP to MT_CLS_WIN_8 quirks

The firmware found in the touch screen of the Surface Pro 3 is slightly buggy and occasionally doesn't send lift off reports for contacts; add MT_QUIRK_NOT_SEEN_MEANS_UP to .quirks to compensate for the missed reports. Signed-off-by: Joey Pabalinas 1 file changed, 2 insertions(+), 1 deletion

Re: [PATCH v2] crypto: testmgr: change `guard` to unsigned char

On Fri, Jan 12, 2018 at 11:23:28PM +1100, Herbert Xu wrote: > > Patch applied. Thanks. No problem, cheers. -- Joey Pabalinas signature.asc Description: PGP signature

[PATCH 0/2] mm/zswap: add minor const/conditional optimizations

Make a couple minor short-circuiting order and const changes - Since the pointed-to objects are never modified through these pointers, const-qualify type and compressor variables. - Test boolean before calling `strcmp()` to take advantage of short-circuiting. Joey Pabalinas (2

[PATCH 2/2] mm/zswap: move `zswap_has_pool` to front of `if ()`

`zwap_has_pool` is a simple boolean, so it should be tested first to avoid unnecessarily calling `strcmp()`. Test `zswap_has_pool` first to take advantage of the short-circuiting behavior of && in `__zswap_param_set()`. Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com> 1 f

[PATCH 1/2] mm/zswap: make type and compressor const

The characters pointed to by `zswap_compressor`, `type`, and `compressor` aren't ever modified. Add const to the static variable and both parameters in `zswap_pool_find_get()`, `zswap_pool_create()`, and `__zswap_param_set()` Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com>

[PATCH] Documentation: gpu/i915: rename intel_guc_loader.c

Commit e8668bbcb0f91c7baa ("drm/i915/guc: Rename intel_guc_loader.c to intel_guc_fw.c") renamed drivers/gpu/drm/i915/intel_guc_loader.c but didn't update Documentation/gpu/i915.rst. Change intel_guc_loader.c to intel_guc_fw.c in Documentation/gpu/i915.rst. Signed-off-by: Joey

Re: [PATCH] Documentation: gpu/i915: rename intel_guc_loader.c

On Wed, Dec 27, 2017 at 08:19:49PM -0800, Randy Dunlap wrote: > https://marc.info/?l=dri-devel=151237442131113=2 > > Already applied to drm/ tree. Gotcha; cheers. -- Joey Pabalinas signature.asc Description: PGP signature

[PATCH] arch/x86: add __noreturn __cold to fortify_panic()

Definition of `fortify_panic()` doesn't match the declaration in include/linux/string.h. Add the missing __noreturn __cold attributes to `fortify_panic()`. Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com> --- arch/x86/boot/compressed/misc.c | 2 +- 1 file changed, 1 insertion

Re: [PATCH] arch/x86: add __noreturn __cold to fortify_panic()

On Mon, Jan 01, 2018 at 01:41:55PM -0800, Joe Perches wrote: > This should not be necessary as the prototype > has those attributes. > > Otherwise, all the __printf attributes would > also have to be added to the definitions and > not the just the declarations. Ah I see,

Re: [PATCH] crypto: testmgr: change `guard` to unsigned char

On Mon, Jan 01, 2018 at 07:03:46AM -0800, Joe Perches wrote: > > Might as well add static too > That's a good idea; I'll make a v2. -- Joey Pabalinas signature.asc Description: PGP signature

[PATCH v2] crypto: testmgr: change `guard` to unsigned char

When char is signed, storing the values 0xba (186) and 0xad (173) in the `guard` array produces signed overflow. Change the type of `guard` to static unsigned char to correct undefined behavior and reduce function stack usage. Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com> ---

[PATCH] crypto: testmgr: change `guard` to unsigned char

When char is signed, storing the values 0xba (186) and 0xad (173) in the `guard` array produces signed overflow. Change the type of `guard` to unsigned char to remove undefined behavior. Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com> --- crypto/testmgr.c | 2 +- 1 file chan

Re: [NOMERGE] [RFC PATCH 00/12] erofs: introduce erofs file system

On Thu, Jul 26, 2018 at 02:55:11PM -1000, Joey Pabalinas wrote: > I thought the exact same thing; opened the thread and was a bit confused > at first. In my opinion the name feels slightly misleading. Oooh, reading more of the thread I see there is some fun wordplay going on which I didn't

Re: [NOMERGE] [RFC PATCH 00/12] erofs: introduce erofs file system

ot;error fs". ;-) I thought the exact same thing; opened the thread and was a bit confused at first. In my opinion the name feels slightly misleading. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH 3/4] HID: multitouch: drop reports containing invalid values

a device that required this, so you are probably > the lucky one :) Ah, you are completely right. After giving that pdf a read over I will definitely be dropping this patch from the v2. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH 2/4] HID: multitouch: don't check HID_GROUP_MULTITOUCH_WIN_8 for serial protocol

devices, but I don't > think it should be done for all devices. > > All in all, it won't change much. Hm, that sounds sane. I'll do a bit more research on this and see if restricting it to just Win8 devices is simple enough to be worthwhile. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH 4/4] HID: multitouch: remove unneeded else conditional cases

hich series on top of the other, but someone between us will > have to do it :) Somehow also missed this reply... I guess I messed up my LKML filters somewhere. Noted, thanks for the review; I'll check your trees for the refactor when (if) I do my v2. -- Cheers, Joey Pabalinas signature

Re: [PATCH RESEND 1/4] HID: multitouch: add MT_QUIRK_NOT_SEEN_MEANS_UP to MT_CLS_WIN_8 quirks

On Thu, Aug 09, 2018 at 01:39:16PM -1000, Joey Pabalinas wrote: > The firmware found in the touch screen of the Surface Pro 3 is slightly > buggy and occasionally doesn't send lift off reports for contacts; add > MT_QUIRK_NOT_SEEN_MEANS_UP to .quirks to compensate for the missed

Re: [PATCH 1/4] HID: multitouch: add MT_QUIRK_NOT_SEEN_MEANS_UP to MT_CLS_WIN_8 quirks

pecial case would be a better way to handle it, so I'll do a bit more research on the quirk thing and then revise my patches (assuming they end up as something still worth sending). Appreciate the comments, thanks. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

[PATCH RESEND 1/4] HID: multitouch: add MT_QUIRK_NOT_SEEN_MEANS_UP to MT_CLS_WIN_8 quirks

The firmware found in the touch screen of the Surface Pro 3 is slightly buggy and occasionally doesn't send lift off reports for contacts; add MT_QUIRK_NOT_SEEN_MEANS_UP to .quirks to compensate for the missed reports. Signed-off-by: Joey Pabalinas 1 file changed, 2 insertions(+), 1 deletion

[PATCH RESEND 3/4] HID: multitouch: drop reports containing invalid values

Avoid processing reports containing invalid values to reduce multitouch input stutter. Signed-off-by: Joey Pabalinas 1 file changed, 9 insertions(+) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index c0654db0b736543ca0..08b50e5908cecdda66 100644 --- a/drivers/hid

[PATCH RESEND 0/4] reduce Surface Pro 3 multitouch jitter

for a couple months without any problems, as well as being run in my Arch Linux AUR kernel package [1] without a single complaint so far. [1] https://aur.archlinux.org/packages/linux-surfacepro3-git Joey Pabalinas (4): HID: multitouch: add MT_QUIRK_NOT_SEEN_MEANS_UP to MT_CLS_WIN_8 quirks HID

[PATCH RESEND 2/4] HID: multitouch: don't check HID_GROUP_MULTITOUCH_WIN_8 for serial protocol

The HID_GROUP_MULTITOUCH_WIN_8 group never needs to check for the serial protocol, so avoid setting `td->serial_maybe = true;` in order to avoid an unnecessary mt_post_parse_default_settings() call Signed-off-by: Joey Pabalinas 1 file changed, 3 insertions(+), 1 deletion(-) diff --

[PATCH RESEND 4/4] HID: multitouch: remove unneeded else conditional cases

Elide lone `else` cases and replace `else if` clauses with plain `if` conditionals when they occur immediately after return statements. Signed-off-by: Joey Pabalinas 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index

Re: [PATCH] net/tcp/illinois: replace broken algorithm reference link

On Wed, Feb 28, 2018 at 12:03:58PM -0500, David Miller wrote: > Applied, thank you. No problem, cheers. -- Joey Pabalinas signature.asc Description: PGP signature

[PATCH] x86/kvm/mmu: const-ify struct kvm_memory_slot pointers

Remove `(struct kvm_memory_slot *)` cast of the `const struct kvm_memory_slot *memslot` parameter and const-ify all references to that pointer down the function call chain. Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com> 1 file changed, 7 insertions(+), 9 deletions(-) diff --git

Re: [PATCH] sound/pci/ice1712: replace strcpy() with scnprintf()

On Thu, Mar 01, 2018 at 03:55:09PM +0200, Andy Shevchenko wrote: > So, why not just use strlcpy()? > scnprintf() here adds an overhead for no benefit. That's a good point, actually. Revising it now; patch will follow shortly. -- Joey Pabalinas signature.asc Description: PGP signature

[PATCH v2] sound/pci/ice1712: replace strcpy() with strlcpy()

Replace unsafe usages of strcpy() to copy the name argument into the sid.name buffer with strlcpy() to guard against possible buffer overflows. Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com> Suggested-by: Andy Shevchenko <andy.shevche...@gmail.com> 2 files changed, 8 inse

[PATCH] sound/pci/ice1712: replace strcpy() with scnprintf()

is exactly the same apart from the return value it would be better to account for that possibility and program defensively. Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com> 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/sound/pci/ice1712/juli.c b/sound/pci/ice1712/juli.c

Re: [PATCH v2] sound/pci/ice1712: replace strcpy() with strlcpy()

On Thu, Mar 01, 2018 at 04:13:48PM +0100, Takashi Iwai wrote: > Thanks, applied now. Cheers -- Joey Pabalinas signature.asc Description: PGP signature

[PATCH] x86/kvm: replace TASK_UNINTERRUPTIBLE with TASK_KILLABLE

process. Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com> 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index bc1a27280c4bf77899..7d4faee962e0c2e3c1 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -154,8

[PATCH v2] scripts/kconfig: cleanup symbol handling code

ali...@gmail.com> Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com> 1 file changed, 69 insertions(+), 61 deletions(-) diff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c index 2220bc4b051bd914e3..9ee32ddb44e193719c 100644 --- a/scripts/kconfig/symbol.c +++ b/scripts/kconfig/symb

[PATCH] ACPI: prefer bool over int for predicates

to hold 0 or -ENOENT as a return value or an `unsigned nmemb` meant to refer to the number of valid members in some arbitrary array. Change relevant variable / return types from int to bool and prefer a true / false value for predicate expressions versus a plain 1 / 0 value. Signed-off-by: Joey

Re: [PATCH v3] sparse: add -Wpointer-arith flag to toggle sizeof(void) warnings

pointers. > So, for the master tree, I propose to use a version with these > tests removed: > git://github.com/lucvoo/sparse-dev.git pointer-arith-v3 Not a problem; I will rebase it on the v0.5.2-rc1 tag and take out the function pointer test-case. -- Cheers, Joey Pabalinas signat

Re: [PATCH v3] sparse: add -Wpointer-arith flag to toggle sizeof(void) warnings

On Tue, Apr 10, 2018 at 12:09:44PM -1000, Joey Pabalinas wrote: > Not a problem; I will rebase it on the v0.5.2-rc1 tag and > take out the function pointer test-case. Sorry, I meant v0.5.2, heh. Sending the v4 now. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

[PATCH v4] sparse: add -Wpointer-arith flag to toggle sizeof(void) warnings

...@linux-foundation.org> CC: Martin Uecker <martin.uec...@med.uni-goettingen.de> CC: Al Viro <v...@zeniv.linux.org.uk> CC: Christopher Li <spa...@chrisli.org> CC: Joey Pabalinas <joeypabali...@gmail.com> CC: Luc Van Oostenryck <luc.vanoostenr...@gmail.com> Signed-off-by: Joey

Re: [PATCH v2] add -Wpointer-arith sparse flag to toggle sizeof(void) warnings

, I don't think this part should belong to the man page. Also have no problem eliding this section if no one else has any good arguments for keeping it. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH v2] add -Wpointer-arith sparse flag to toggle sizeof(void) warnings

On Mon, Apr 09, 2018 at 12:51:01PM -1000, Joey Pabalinas wrote: > Ah, so should I include that change in the patch itself when I make a V3? Sending a v3 now incorporating the suggestions. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

[PATCH v3] sparse: add -Wpointer-arith flag to toggle sizeof(void) warnings

esc...@chromium.org> CC: Linus Torvalds <torva...@linux-foundation.org> CC: Martin Uecker <martin.uec...@med.uni-goettingen.de> CC: Al Viro <v...@zeniv.linux.org.uk> CC: Christopher Li <spa...@chrisli.org> CC: Joey Pabalinas <joeypabali...@gmail.com> CC: Luc Van Oostenryck <

[PATCH v2] add -Wpointer-arith sparse flag to toggle sizeof(void) warnings

eniv.linux.org.uk> CC: Christopher Li <spa...@chrisli.org> CC: Joey Pabalinas <joeypabali...@gmail.com> CC: Luc Van Oostenryck <luc.vanoostenr...@gmail.com> Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com> Signed-off-by: Luc Van Oostenryck <luc.vanoostenr..

Re: New sparse warning from min_t(): expression using sizeof(void)

patch [2] and apply it directly to the v0.5.2 release to suppress the deluge of warnings (-Wpointer-arith is off by defaultl so no need to change any of you configurations). [1] https://lkml.org/lkml/2018/4/10/923 [2] https://patchwork.kernel.org/patch/10334353/raw/ -- Cheers, Joey Pab

[PATCH v3 2/2] tty/nozomi: fix inconsistent indentation

Correct misaligned indentation and remove extraneous spaces. Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com> 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c index f26bf1d1e9ee0e74eb..0fcb4db721d2a42f08 100644 --- a/drive

[PATCH v3 0/2] tty/nozomi: general module cleanup

<a...@arndb.de> CC: Jiri Slaby <jsl...@suse.cz> Joey Pabalinas (2): tty/nozomi: cleanup DUMP() macro tty/nozomi: fix inconsistent indentation drivers/tty/nozomi.c | 100 +-- 1 file changed, 50 insertions(+), 50 deletions(-) -- 2.17.0.rc1.35.g90bbd502d54fe92035.dirty

[PATCH v3 1/2] tty/nozomi: cleanup DUMP() macro

Replace snprint() with strscpy() and use min_t() instead of the conditional operator to clamp buffer length. Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com> 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c

Re: [PATCH v4 0/2] tty/nozomi: general module cleanup

ion. Sorry about all the mess; I mostly have only sent single patches before this. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH v3 1/2] tty/nozomi: cleanup DUMP() macro

On Wed, Apr 25, 2018 at 08:09:31AM +0200, Greg Kroah-Hartman wrote: > Ah, never seen that before. Just use the defaults and you should be > fine. Having the normal diffstat is good. Yes, will definitely do from now on. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

[PATCH v4 2/2] tty/nozomi: fix inconsistent indentation

Correct misaligned indentation and remove extraneous spaces. Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com> --- drivers/tty/nozomi.c | 74 ++-- 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/drivers/tty/nozomi.c b/drive

Re: [PATCH v3 1/2] tty/nozomi: cleanup DUMP() macro

about that. Going to resend. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

[PATCH v4 0/2] tty/nozomi: general module cleanup

<a...@arndb.de> CC: Jiri Slaby <jsl...@suse.cz> Joey Pabalinas (2): tty/nozomi: cleanup DUMP() macro tty/nozomi: fix inconsistent indentation drivers/tty/nozomi.c | 100 +-- 1 file changed, 50 insertions(+), 50 deletions(-) -- 2.17.0.rc1.35.g90bbd502d54fe92035.dirty

[PATCH v4 1/2] tty/nozomi: cleanup DUMP() macro

Replace snprint() with strscpy() and use min_t() instead of the conditional operator to clamp buffer length. Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com> --- drivers/tty/nozomi.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/d

Re: New sparse warning from min_t(): expression using sizeof(void)

BASE_L4 > arch/x86/include/asm/pgtable_64_types.h:108: #define __VMALLOC_BASE_L4 > 0xc900 __VMALLOC_BASE_L4 would be better written as 0xc900UL, which would indeed shut up sparse. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH v2 1/4] tty/nozomi: cleanup DUMP() macro

On Mon, Apr 23, 2018 at 10:51:31AM +0200, Greg Kroah-Hartman wrote: > Something is really odd here, look at what is in your changelog above :( > > Same for all of these patches. Can you please fix up and resend? Ah whoops, will do. -- Cheers, Joey Pabalinas signature.asc Descrip

Re: [PATCH v2] scripts/kconfig: cleanup symbol handling code

On Mon, Mar 26, 2018 at 01:52:26AM +0900, Masahiro Yamada wrote: > I want to see Kconfig improvements in a bigger picture. > > The changes below are noise. That's understandable; I do agree that nothing here is _fundamentally_ broken at all, so no worries. -- Cheers, Joey

[PATCH] tty/nozomi: refactor macros and functions

wer (but semantically equivalent) logic. In addition, simplify and coalesce a few of the return paths / loop conditionals and correct a few pointless Initializations, redundant parentheses/break statements, and inconsistently indented line. Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com>

Re: [PATCH] tty/nozomi: refactor macros and functions

On Fri, Mar 23, 2018 at 04:27:37PM +0100, Greg Kroah-Hartman wrote: > That's a lot of different things to do all in a single patch. > > Please break this up into a patch series, doing only one logical "thing" > per patch. Sorry about that, I'll spin up a patchset now. --

[PATCH 4/4] tty/nozomi: refactor conditional statements

Reduce unnecessarily deep nesting of blocks and simplify control flow (e.g. "if/else" constructs changed to "if/return" and single case "switch" statements changed to "if" conditionals where possible). Signed-off-by: Joey Pabalinas <joeypabali...@gmail.

[PATCH 1/4] tty/nozomi: cleanup DUMP() macro

Replace snprint() with strscpy() and use max_t() instead of the conditional operator. Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com> 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c index b57b35066ebea94639..f26bf1d1e9ee

[PATCH 3/4] tty/nozomi: improve code readability and style

Improve code clarity by renaming identifiers and reorganizing function control flow. Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com> 1 file changed, 92 insertions(+), 91 deletions(-) 1 file changed, 76 insertions(+), 90 deletions(-) diff --git a/drivers/tty/nozomi.c b/drive

[PATCH 0/4] tty/nozomi: general module cleanup

on.org> CC: Arnd Bergmann <a...@arndb.de> CC: Jiri Slaby <jsl...@suse.cz> CC: Tomasz Kramkowsk <t...@the-tk.com> Joey Pabalinas (4): tty/nozomi: cleanup DUMP() macro tty/nozomi: fix inconsistent indentation tty/nozomi: improve code readability and style tty/nozomi: refactor

[PATCH 2/4] tty/nozomi: fix inconsistent indentation

Correct misaligned indentation and remove extraneous spaces. Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com> 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c index f26bf1d1e9ee0e74eb..0fcb4db721d2a42f08 100644 --- a/drive

[PATCH v2 3/4] tty/nozomi: improve code readability and style

Improve code clarity by renaming identifiers and reorganizing function control flow. Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com> 1 file changed, 92 insertions(+), 91 deletions(-) 1 file changed, 76 insertions(+), 90 deletions(-) diff --git a/drivers/tty/nozomi.c b/drive

[PATCH v2 1/4] tty/nozomi: cleanup DUMP() macro

Replace snprint() with strscpy() and use max_t() instead of the conditional operator. Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com> 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c index b57b35066ebea94639..f26bf1d1e9ee

[PATCH v2 4/4] tty/nozomi: refactor conditional statements

Reduce unnecessarily deep nesting of blocks and simplify control flow (e.g. "if/else" constructs changed to "if/return" and single case "switch" statements changed to "if" conditionals where possible). Signed-off-by: Joey Pabalinas <joeypabali...@gmail.

[PATCH v2 2/4] tty/nozomi: fix inconsistent indentation

Correct misaligned indentation and remove extraneous spaces. Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com> 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c index f26bf1d1e9ee0e74eb..0fcb4db721d2a42f08 100644 --- a/drive

[PATCH v2 0/4] tty/nozomi: general module cleanup

nd extraneous whitespace. CC: Greg Kroah-Hartman <gre...@linuxfoundation.org> CC: Arnd Bergmann <a...@arndb.de> CC: Jiri Slaby <jsl...@suse.cz> CC: Tomasz Kramkowsk <t...@the-tk.com> Joey Pabalinas (4): tty/nozomi: cleanup DUMP() macro tty/nozomi: fix inconsistent i

Re: [PATCH] scripts/kconfig: replace single character strcat() appends

ake a V2 later on today. Appreciate the feedback, thanks for the comments! -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

[PATCH] mm/zsmalloc: strength reduce zspage_size calculation

Replace the repeated multiplication in the main loop body calculation of zspage_size with an equivalent (and cheaper) addition operation. Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com> 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c

[PATCH] net/tcp/illinois: replace broken algorithm reference link

that one. Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com> 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/tcp_illinois.c b/net/ipv4/tcp_illinois.c index 7c843578f2333db581..faddf4f9a707f1583f 100644 --- a/net/ipv4/tcp_illinois.c +++ b/net/ipv4/tcp_illinois.c @@ -6,

[PATCH] scripts/kconfig: replace single character strcat() appends

Convert strcat() calls which only append single characters to the end of res into simpler (and most likely cheaper) single assignment statements. Signed-off-by: Joey Pabalinas <joeypabali...@gmail.com> 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/scripts/kconfig/symb

Re: [PATCH] mm/zsmalloc: strength reduce zspage_size calculation

Cheers :) -- Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH AUTOSEL 4.14 27/30] powerpc/selftests: Wait all threads to join

ichael Ellerman > Signed-off-by: Sasha Levin Acked-by: Joey Pabalinas -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: Code of Conduct: Let's revamp it.

> escalate the rhetoric --- either in the pro- or anti- CoC direction, > and whether on mailing lists, github comment threads, Twitter, or > Reddit --- is not helpful. I completely agree with this; very eagerly seconded. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: Code of Conduct: Let's revamp it.

vate information". > How do you reconcile working on a public project while keeping email > address secret? This is a little more delicate, and I admit that I can't really think of any real solutions for this part... -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: Code of Conduct: Let's revamp it.

urce code is definitely intended for the public as well. If I post an ad targeted at dog owners in my local town hall, it doesn't mean it's not intended for the public. Even though it is only for dog owners (or those who wish to be), it is still available freely to the general public. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

A Plea to Unfuck our Codes of Conduct

you haven't always been right, but you are human too, just like the rest of us, and, in my humble opinion, don't need to feel this ashamed for trying to run this ship as best you knew how. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

A Plea to Unfuck our Codes of Conduct

you haven't always been right, but you are human too, just like the rest of us, and, in my humble opinion, don't need to feel this ashamed for trying to run this ship as best you knew how. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: [PATCH] binder: remove BINDER_DEBUG_ENTRY()

On Fri, Nov 30, 2018 at 08:26:30PM -0500, Yangtao Li wrote: > We already have the DEFINE_SHOW_ATTRIBUTE.There is no need to define > such a macro,so remove BINDER_DEBUG_ENTRY. > > Signed-off-by: Yangtao Li Good catch. Reviewed-by: Joey Pabalinas On Fri, Nov 30, 2018 at 08:2

Re: [PATCH] sched/fair: Fix assignment of boolean variables

> CC: Peter Zijlstra > CC: linux-kernel@vger.kernel.org Ack, earlier assignments in the function like: if (nr_running > 1) *overload = true; use `= true`, so this change keeps things consistent. Reviewed-by: Joey Pabalinas > --- > kernel/sched/fair.c |

Re: [PATCH] drop silly "static inline asmlinkage" from dump_stack()

On Sun, Dec 02, 2018 at 12:02:54PM +0300, Alexey Dobriyan wrote: > Empty function will be inlined so asmlinkage doesn't do anything. Yes, that is an example of a perfect explanation to have in the commit message :) Ack from me after that addition. Acked-by: Joey Pabalinas -- Cheers, J

Re: [PATCH v3 0/7] zram idle page writeback

zram idle page writeback feature. Revisions look good to me. Will also try to give it some testing this week. Reviewed-by: Joey Pabalinas > * Admin can define what is idle page "no access since X time ago" > * Admin can define when zram should writeback them > * Admin can defi

Re: [PATCH RESEND v3 1/3] ptrace: pass type of a syscall-stop in ptrace_message

t; from syscall-exit-stops using PTRACE_GETEVENTMSG request. Is there an advantage to using two constants instead of a single sys_exit bit (set/unset for syscall-exit-stop/syscall-enter-stop)? -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

Re: Re: [PATCH RESEND v3 1/3] ptrace: pass type of a syscall-stop in ptrace_message

that definitely makes sense. -- Cheers, Joey Pabalinas signature.asc Description: PGP signature

  1   2   3   >