On Tue, Sep 09, 2014 at 10:24:44PM +0300, Octavian Purdila wrote:
+MODULE_AUTHOR(Octavian Purdila octavian.purd...@intel.com);
+MODULE_DESCRIPTION(DRIVER_NAME driver);
+MODULE_LICENSE(GPL);
Just noticed both the i2c and gpio driver is lacking a MODULE_ALIAS to
enable module auto-loading.
for platform devices. Note
that the final patch is a pre-requisite for this.
Johan
[1] http://marc.info/?l=linux-kernelm=141094514827834w=2
Johan Hovold (6):
mfd: viperboard: fix platform-device id collision
mfd: rtsx_usb: fix platform device-id collision
mfd: core: add helper function
-function devices to be registered
with PLATFORM_DEVID_AUTO while still having non-zero cell ids.
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/mfd/mfd-core.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
index
Use mfd_add_hotplug_devices helper to register the subdevices.
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/mfd/rtsx_usb.c | 4 ++--
drivers/mfd/viperboard.c | 5 ++---
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/mfd/rtsx_usb.c b/drivers/mfd/rtsx_usb.c
Hot-pluggable multi-function devices should always be registered with
PLATFORM_DEVID_AUTO to avoid name collisions on the platform bus. This
helper also hides the memory map and irq parameters, which aren't used
by hot-pluggable (e.g. USB-based) devices.
Signed-off-by: Johan Hovold jo
98e8603c22d65817 ]---
viperboard 1-2.4:1.0: Failed to add mfd devices to core.
viperboard: probe of 1-2.4:1.0 failed with error -17
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/mfd/viperboard.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/viperboard.c b
Use mfd_add_hotplug_devices helper to register the subdevices.
Compile-only tested.
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/hid/hid-sensor-hub.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor
assigned the same address.
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/mfd/rtsx_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/rtsx_usb.c b/drivers/mfd/rtsx_usb.c
index 71f387ce8cbd..78073e4b87e4 100644
--- a/drivers/mfd/rtsx_usb.c
+++ b/drivers/mfd
On Fri, Nov 07, 2014 at 11:26:11PM -0600, Preston Fick wrote:
Signed-off-by: Preston Fick pff...@gmail.com
---
drivers/usb/serial/cp210x.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index cfd009d..6c4eb3c 100644
---
On Tue, Nov 11, 2014 at 02:20:56PM +0200, Octavian Purdila wrote:
If wait_for_completion_interruptible_timeout returns a positive value
it may be propagated as the return value of _dln2_transfer. This
contradicts the documentation of the function and exposes unnecessary
internals to the
On Tue, Nov 11, 2014 at 02:20:57PM +0200, Octavian Purdila wrote:
This fixes the following kbuild test robot warning:
drivers/i2c/busses/i2c-dln2.c:70:1-4: WARNING: end returns can be
simplified if negative or 0 value
Reported-by: kbuild test robot fengguang...@intel.com
Reported-by:
Remove unused function prototype that was left by commit 149c09d3a61d
(ARM: AM33xx: remove old clock data and link in new clock init code)
which removed the definition.
Signed-off-by: Johan Hovold jo...@kernel.org
---
arch/arm/mach-omap2/clock.h | 2 --
1 file changed, 2 deletions(-)
diff --git
Add micrel,rmii_ref_clk_sel_25_mhz to Micrel ethernet PHY binding
documentation.
Cc: devicet...@vger.kernel.org
Signed-off-by: Johan Hovold jo...@kernel.org
---
Documentation/devicetree/bindings/net/micrel.txt | 5 +
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree
Add helper macro for PHY drivers which do not do anything special in
module init/exit. This will allow us to eliminate a lot of boilerplate
code.
Signed-off-by: Johan Hovold jo...@kernel.org
---
include/linux/phy.h | 24
1 file changed, 24 insertions(+)
diff --git
Clean up led-mode setup by introducing proper defines for PHY Control
registers 1 and 2 and only passing the register to the setup function.
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/net/phy/micrel.c | 31 ++-
1 file changed, 22 insertions(+), 9
.
Cc: Bruno Thomsen b...@kamstrup.dk
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/net/phy/micrel.c | 18 +++---
1 file changed, 3 insertions(+), 15 deletions(-)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 3b89548e6063..bbd1c9ea0cbf 100644
Add has_broadcast_disable flag to type-data and generic config_init.
This allows us to remove the ksz8081 config_init callback.
Note that ksz8021_config_init is kept for now due to a95a18afe4c8
(phy/micrel: KSZ8031RNL RMII clock reconfiguration bug).
Signed-off-by: Johan Hovold jo...@kernel.org
Add static data field to struct phy_driver that be used to store
structured device-type information.
Signed-off-by: Johan Hovold jo...@kernel.org
---
include/linux/phy.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/phy.h b/include/linux/phy.h
index c50e1f1f46e0
to be able to configure
this.
Signed-off-by: Johan Hovold jo...@kernel.org
---
Documentation/devicetree/bindings/net/micrel.txt | 4 ++--
drivers/net/phy/micrel.c | 11 ++-
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/Documentation/devicetree
Add myself to the list of copyright holders.
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/net/phy/micrel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 743d5b52d8db..3b89548e6063 100644
--- a/drivers/net/phy/micrel.c
files which was also added by the above mentioned commit 45f56cb82e45
(net/phy: micrel: Add clock support for KSZ8021/KSZ8031).
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/net/phy/micrel.c | 94 +-
include/linux/micrel_phy.h | 1 -
2 files
Add structured device-type information and support for generic led-mode
setup to the generic config_init callback.
This is a first step in ultimately getting rid of device-type specific
callbacks.
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/net/phy/micrel.c | 82
that the KSZPHY_OMSO_RMII_OVERRIDE bit is set by default on
KSZ8021/8031.
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/net/phy/micrel.c | 24 ++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index d962a2866bba
Add generic interrupt-config callback and store interrupt-level bitmask
in type data for PHY types not using bit 9.
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/net/phy/micrel.c | 71
1 file changed, 29 insertions(+), 42 deletions
Parse the micrel,led-mode property at probe, rather than at config_init
time in the led-setup helper itself.
Note that the bogus parent-of_node bit is removed.
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/net/phy/micrel.c | 39 +--
1 file changed
Refactor led-mode error handling.
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/net/phy/micrel.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 1b3985cdc64c..ec9ce35e934b 100644
Enable led-mode configuration for KSZ8081 and KSZ8091.
Signed-off-by: Johan Hovold jo...@kernel.org
---
Documentation/devicetree/bindings/net/micrel.txt | 2 ++
drivers/net/phy/micrel.c | 1 +
2 files changed, 3 insertions(+)
diff --git a/Documentation/devicetree
, this allows for dual KSZ8081 setups.
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/net/phy/micrel.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 21abe5ade3df..16135ac18bfe 100644
--- a/drivers/net/phy
Replace module init/exit which only calls phy_drivers_register with
module_phy_driver macro.
Tested using Micrel driver, and otherwise compile-tested only.
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/net/phy/amd-xgbe-phy.c | 15 +--
drivers/net/phy/at803x.c | 14
Use BIT macro for bitmask definitions.
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/net/phy/micrel.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 62ca9613a514
Make sure never to update more than two bits when setting the led mode,
something which could for example change the reference-clock setting.
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/net/phy/micrel.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/phy
Replace module init/exit which only calls phy_driver_register with
module_phy_driver macro.
Compile tested only.
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/net/phy/amd.c | 17 +++--
drivers/net/phy/et1011c.c | 17 +++--
drivers/net/phy/national.c | 17
A recent commit extended the documentation of the ethernet-phy
compatible property, but placed the new paragraph under the max-speed
property.
Fixes: f00e756ed12d (dt: Document a compatible entry for MDIO ethernet
Phys)
Cc: devicet...@vger.kernel.org
Signed-off-by: Johan Hovold jo...@kernel.org
Make sure never to update the control register with random data (an
error code) by checking the return value after reading it.
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/net/phy/micrel.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/phy/micrel.c b/drivers
around in a different way (which I suspect).
Thanks,
Johan
Johan Hovold (22):
dt/bindings: fix documentation of ethernet-phy compatible property
net: phy: add module_phy_driver macro
net: phy: replace phy_driver_register calls
net: phy: replace phy_drivers_register calls
net: phy
On Tue, Nov 11, 2014 at 12:49:36PM -0500, David Miller wrote:
22 patches is just too much, sorry.
Please reduce this down to something closer to ~10 or so patches.
If necessary you can do two series, submit the first 10 and then
when that's reviewed and accepted submit the second set.
No
On Tue, Nov 11, 2014 at 05:57:42PM +, Mark Rutland wrote:
On Tue, Nov 11, 2014 at 05:37:37PM +, Johan Hovold wrote:
Add micrel,rmii_ref_clk_sel_25_mhz to Micrel ethernet PHY binding
documentation.
Cc: devicet...@vger.kernel.org
Signed-off-by: Johan Hovold jo...@kernel.org
Replace module init/exit which only calls phy_drivers_register with
module_phy_driver macro.
Tested using Micrel driver, and otherwise compile-tested only.
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/net/phy/amd-xgbe-phy.c | 15 +--
drivers/net/phy/at803x.c | 14
and two driver change classes) in
order to facilitate review.
Johan
Johan Hovold (3):
net: phy: add module_phy_driver macro
net: phy: replace phy_driver_register calls
net: phy: replace phy_drivers_register calls
drivers/net/phy/amd-xgbe-phy.c | 15 +--
drivers/net/phy/amd.c
Add helper macro for PHY drivers which do not do anything special in
module init/exit. This will allow us to eliminate a lot of boilerplate
code.
Signed-off-by: Johan Hovold jo...@kernel.org
---
include/linux/phy.h | 24
1 file changed, 24 insertions(+)
diff --git
Replace module init/exit which only calls phy_driver_register with
module_phy_driver macro.
Compile tested only.
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/net/phy/amd.c | 17 +++--
drivers/net/phy/et1011c.c | 17 +++--
drivers/net/phy/national.c | 17
Make sure never to update more than two bits when setting the led mode,
something which could for example change the reference-clock setting.
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/net/phy/micrel.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/phy
Make sure never to update the control register with random data (an
error code) by checking the return value after reading it.
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/net/phy/micrel.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/phy/micrel.c b/drivers
device-type abstraction which will allow for
further refactoring and shared initialisation code.
Johan
Johan Hovold (9):
dt/bindings: fix documentation of ethernet-phy compatible property
net: phy: micrel: fix config_intr error handling
net: phy: micrel: use BIT macro
net: phy: micrel
A recent commit extended the documentation of the ethernet-phy
compatible property, but placed the new paragraph under the max-speed
property.
Fixes: f00e756ed12d (dt: Document a compatible entry for MDIO ethernet
Phys)
Cc: devicet...@vger.kernel.org
Signed-off-by: Johan Hovold jo...@kernel.org
Clean up led-mode setup by introducing proper defines for PHY Control
registers 1 and 2 and only passing the register to the setup function.
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/net/phy/micrel.c | 31 ++-
1 file changed, 22 insertions(+), 9
Enable led-mode configuration for KSZ8081 and KSZ8091.
Signed-off-by: Johan Hovold jo...@kernel.org
---
Documentation/devicetree/bindings/net/micrel.txt | 2 ++
drivers/net/phy/micrel.c | 1 +
2 files changed, 3 insertions(+)
diff --git a/Documentation/devicetree
Use BIT macro for bitmask definitions.
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/net/phy/micrel.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 62ca9613a514
Refactor led-mode error handling.
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/net/phy/micrel.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 1b3985cdc64c..ec9ce35e934b 100644
, this allows for dual KSZ8081 setups.
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/net/phy/micrel.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 21abe5ade3df..16135ac18bfe 100644
--- a/drivers/net/phy
that the KSZPHY_OMSO_RMII_OVERRIDE bit is set by default on
KSZ8021/8031.
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/net/phy/micrel.c | 24 ++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index d962a2866bba
Hi Bruno,
On Thu, Oct 09, 2014 at 04:48:14PM +0200, Bruno Thomsen wrote:
Bug: Unable to send and receive Ethernet packets with Micrel PHY.
Affected devices:
KSZ8031RNL (commercial temp)
KSZ8031RNLI (industrial temp)
Description:
PHY device is correctly detected during probe.
PHY
On Wed, Nov 12, 2014 at 08:01:27AM +0100, Sascha Hauer wrote:
On Tue, Nov 11, 2014 at 07:18:25PM +0100, Johan Hovold wrote:
On Tue, Nov 11, 2014 at 05:57:42PM +, Mark Rutland wrote:
On Tue, Nov 11, 2014 at 05:37:37PM +, Johan Hovold wrote:
Add micrel,rmii_ref_clk_sel_25_mhz
On Tue, Nov 11, 2014 at 01:43:06PM -0800, Florian Fainelli wrote:
On 11/11/2014 01:41 PM, Sergei Shtylyov wrote:
Hello.
On 11/11/2014 10:00 PM, Johan Hovold wrote:
Clean up led-mode setup by introducing proper defines for PHY Control
registers 1 and 2 and only passing the register
On Tue, Nov 11, 2014 at 05:20:37PM +0100, Julia Lawall wrote:
On Tue, 11 Nov 2014, Octavian Purdila wrote:
On Tue, Nov 11, 2014 at 2:26 PM, Johan Hovold jo...@kernel.org wrote:
On Tue, Nov 11, 2014 at 02:20:57PM +0200, Octavian Purdila wrote:
This fixes the following kbuild test robot
On Thu, Nov 13, 2014 at 09:09:27AM +0100, Sascha Hauer wrote:
On Wed, Nov 12, 2014 at 10:19:20AM +0100, Johan Hovold wrote:
On Wed, Nov 12, 2014 at 08:01:27AM +0100, Sascha Hauer wrote:
On Tue, Nov 11, 2014 at 07:18:25PM +0100, Johan Hovold wrote:
On Tue, Nov 11, 2014 at 05:57:42PM +
On Tue, Sep 23, 2014 at 11:38:48AM +0200, Boris BREZILLON wrote:
@@ -328,6 +328,7 @@ static int at91_rtc_probe(struct platform_device *pdev)
struct sam9_rtc *rtc;
int ret, irq;
u32 mr;
+ unsigned intsclk_rate;
irq =
of what to do with the series:
- Johan, do you want to Ack it?
I had one comment to the slow-clock patch, but feel free to add my
Acked-by: Johan Hovold jo...@kernel.org
to the whole series.
Thanks,
Johan
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
-by: Johan Hovold jo...@kernel.org
---
drivers/rtc/rtc-at91sam9.c | 28
1 file changed, 24 insertions(+), 4 deletions(-)
diff --git a/drivers/rtc/rtc-at91sam9.c b/drivers/rtc/rtc-at91sam9.c
index be9c28b..2eca624 100644
--- a/drivers/rtc/rtc-at91sam9.c
+++ b/drivers
On Wed, Sep 10, 2014 at 03:06:27PM -0400, Peter Hurley wrote:
The tty core does not test tty-hw_stopped; remove from drivers
which don't test it themselves.
cc: Johan Hovold jo...@kernel.org
Signed-off-by: Peter Hurley pe...@hurleysoftware.com
Acked-by: Johan Hovold jo...@kernel.org
On Tue, Sep 23, 2014 at 09:44:48PM -0700, Greg Kroah-Hartman wrote:
On Mon, Sep 22, 2014 at 10:52:56AM +0200, Johan Hovold wrote:
On Mon, Sep 22, 2014 at 09:50:43AM +0200, Andreas Bomholtz wrote:
Added the Seluxit ApS USB Serial Dongle to cp210x driver.
Signed-off-by: Andreas Bomholtz
On Wed, Sep 24, 2014 at 11:12:06AM +0100, Lee Jones wrote:
On Mon, 22 Sep 2014, Octavian Purdila wrote:
Currently the I/O buffer is allocated part of the device status
structure, potentially sharing the same cache line with other members
in this structure.
Allocate the buffer
On Fri, Sep 19, 2014 at 11:22:42PM +0300, Octavian Purdila wrote:
This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO
Master Adapter DLN-2. Details about the device can be found here:
https://www.diolan.com/i2c/i2c_interface.html.
Information about the USB protocol can be
On Fri, Sep 19, 2014 at 11:22:43PM +0300, Octavian Purdila wrote:
+struct dln2_i2c {
+ struct platform_device *pdev;
+ struct i2c_adapter adapter;
+ u32 freq;
+ u32 min_freq;
+ u32 max_freq;
+ /*
+ * Buffer to hold the packet for read or write transfers. One
On Wed, Sep 24, 2014 at 10:54:51AM +0200, Linus Walleij wrote:
On Fri, Sep 19, 2014 at 10:22 PM, Octavian Purdila
octavian.purd...@intel.com wrote:
Some GPIO chips (e.g. the DLN2 USB adapter) have blocking get/set
operation but do not need a threaded irq handler.
Signed-off-by:
On Wed, Sep 24, 2014 at 01:00:02PM +0100, Lee Jones wrote:
On Wed, 24 Sep 2014, Johan Hovold wrote:
On Wed, Sep 24, 2014 at 11:12:06AM +0100, Lee Jones wrote:
On Mon, 22 Sep 2014, Octavian Purdila wrote:
Currently the I/O buffer is allocated part of the device status
structure
On Wed, Sep 24, 2014 at 03:34:08PM +0300, Octavian Purdila wrote:
I can follow-up with a v3 3 patch series: first for the fix, second
for the OOM error path cleanup, third for devm conversion.
I'd include the error-path clean up bit in the devres conversion as that
is what it's really all
On Fri, Sep 19, 2014 at 11:22:45PM +0300, Octavian Purdila wrote:
+struct dln2_gpio {
+ struct platform_device *pdev;
+ struct gpio_chip gpio;
+
+ /*
+ * Cache pin direction to save us one transfer, since the
+ * hardware has separate commands to read the in and out
On Wed, Sep 24, 2014 at 04:36:22PM +0300, Octavian Purdila wrote:
On Wed, Sep 24, 2014 at 1:48 PM, Johan Hovold jo...@kernel.org wrote:
On Fri, Sep 19, 2014 at 11:22:42PM +0300, Octavian Purdila wrote:
snip
+ * dln2_dev.mod_rx_slots and then the echo header field to index the
+ * slots
On Wed, Sep 24, 2014 at 05:54:15PM +0300, Octavian Purdila wrote:
On Wed, Sep 24, 2014 at 4:54 PM, Johan Hovold jo...@kernel.org wrote:
On Wed, Sep 24, 2014 at 04:36:22PM +0300, Octavian Purdila wrote:
On Wed, Sep 24, 2014 at 1:48 PM, Johan Hovold jo...@kernel.org wrote:
On Fri, Sep 19
On Thu, Sep 25, 2014 at 01:25:24PM +0300, Octavian Purdila wrote:
Johan, I think we don't really need the spinlock, the disconnect flag
and an atomic counter should work. Do you see any issues with that?
No, you need to test and increment atomically so the lock is needed.
Consider what could
On Thu, Sep 25, 2014 at 01:41:16PM +0300, Octavian Purdila wrote:
On Thu, Sep 25, 2014 at 1:30 PM, Johan Hovold jo...@kernel.org wrote:
On Thu, Sep 25, 2014 at 01:25:24PM +0300, Octavian Purdila wrote:
Johan, I think we don't really need the spinlock, the disconnect flag
and an atomic
On Thu, Sep 25, 2014 at 05:43:16PM +0300, Octavian Purdila wrote:
Switch to using devm_ allocation to simplify the error path. Also
remove a redundant OOM error message.
Signed-off-by: Octavian Purdila octavian.purd...@intel.com
---
drivers/mfd/viperboard.c | 18 +-
1 file
On Thu, Sep 25, 2014 at 05:43:17PM +0300, Octavian Purdila wrote:
Where's the commit message body?
Signed-off-by: Octavian Purdila octavian.purd...@intel.com
---
drivers/mfd/viperboard.c | 1 -
include/linux/mfd/viperboard.h | 1 -
2 files changed, 2 deletions(-)
diff --git
On Thu, Sep 25, 2014 at 06:29:48PM +0300, Octavian Purdila wrote:
On Thu, Sep 25, 2014 at 6:07 PM, Johan Hovold jo...@kernel.org wrote:
Still feels like the kind of clean up that should have a Tested-by.
Unfortunately I do not have access to hardware to test.
On second thought, compile
the device status structure due to cache line sharing.
Compiled tested only as I don't have access to hardware.
Signed-off-by: Octavian Purdila octavian.purd...@intel.com
Reviewed-by: Johan Hovold jo...@kernel.org
---
drivers/mfd/viperboard.c | 8
include/linux/mfd
On Thu, Sep 25, 2014 at 06:41:36PM +0300, Octavian Purdila wrote:
Switch to using devm_ allocation to simplify the error path. Also
remove a redundant OOM error message.
Signed-off-by: Octavian Purdila octavian.purd...@intel.com
Reviewed-by: Johan Hovold jo...@kernel.org
---
drivers/mfd
On Thu, Sep 25, 2014 at 06:41:37PM +0300, Octavian Purdila wrote:
Remove pdev field from struct vpbrd as it is not used in the MFD
driver or in any of the sub-drivers.
Signed-off-by: Octavian Purdila octavian.purd...@intel.com
Reviewed-by: Johan Hovold jo...@kernel.org
---
drivers/mfd
On Sun, Dec 21, 2014 at 11:33:39PM -0600, Preston Fick wrote:
Please add a proper commit message here describing why this is needed.
Are there any devices with the original PID or was that just a typo?
Signed-off-by: Preston Fick pff...@gmail.com
---
drivers/usb/serial/cp210x.c | 2 +-
1
.
Turns out that the problem seemingly worked-around by the above
mentioned commit was really due to a hardware-configuration issue, where
the PHY was in fact strapped to address 3 rather than 0.
Tested-by: Bruno Thomsen b...@kamstrup.dk
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/net
On Thu, Oct 30, 2014 at 09:54:54PM -0700, Anton Staaf wrote:
On Thu, Oct 30, 2014 at 7:33 AM, Greg Kroah-Hartman
gre...@linuxfoundation.org wrote:
On Wed, Oct 29, 2014 at 02:21:56PM -0700, Anton Staaf wrote:
Add support for Google devices that export simple serial
interfaces using the
Acked-by: Johan Hovold jo...@kernel.org
Mark, this is for the regulator tree.
Thanks,
Johan
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
On Tue, Nov 25, 2014 at 02:40:07PM +, Grant Likely wrote:
On Tue, 25 Nov 2014 12:28:25 +
, Romain Perier romain.per...@gmail.com
wrote:
It reverts commit a4b4e0461ec5 (of: Add standard property for poweroff
capability).
As discussed on the mailing list, it makes more sense to
in a
released kernel will need to support both versions.
Signed-off-by: Johan Hovold jo...@kernel.org
---
Documentation/devicetree/bindings/rtc/rtc-omap.txt | 4 ++--
arch/arm/boot/dts/am335x-boneblack.dts | 2 +-
drivers/rtc/rtc-omap.c | 2 +-
3 files changed
On Fri, Oct 24, 2014 at 09:06:32PM +0200, Johan Hovold wrote:
Remove redundant local_irq_disable() at machine halt and restart.
Since commit 44424c34049f (ARM: 7803/1: Fix deadlock scenario with
smp_send_stop()) interrupts are disabled before stopping secondary
CPUs.
Signed-off-by: Johan
On Thu, Nov 06, 2014 at 01:49:13PM +, Nix wrote:
On 5 Nov 2014, Johan Hovold told this:
On Wed, Nov 05, 2014 at 03:14:49PM +, Nix wrote:
Could you try two more things (too make sure line control is really the
culprit):
1. If you clear HUPCL in ekeyd so that the lines are never
: stable sta...@vger.kernel.org # v3.16
Signed-off-by: Johan Hovold jo...@kernel.org
---
Greg,
I believe this should into v3.18 as it fixes a reported regression with
these devices.
Johan
drivers/usb/class/cdc-acm.c | 14 --
drivers/usb/class/cdc-acm.h | 2 ++
2 files changed, 14
On Fri, Nov 07, 2014 at 10:05:12AM +0100, Oliver Neukum wrote:
On Thu, 2014-11-06 at 18:08 +0100, Johan Hovold wrote:
Add new quirk for devices that cannot handle control-line state
requests.
Note that we currently send these requests to all devices, regardless
of
whether they claim
On Wed, Nov 12, 2014 at 12:17:57PM +, Bruno Thomsen wrote:
Hi Johan,
As you may have seen by now, I've been working on refactoring the
micrel phy driver to be able to use common initialisation code.
Specifically, I've added generic support for disabling the broadcast
address,
On Mon, Nov 17, 2014 at 12:33:01PM +0200, Laurentiu Palcu wrote:
Hi Johan,
On Fri, Nov 14, 2014 at 11:56:45AM +0100, Johan Havold wrote:
On Thu, Nov 13, 2014 at 05:17:21PM +0200, Laurentiu Palcu wrote:
Hi Johan,
On Thu, Nov 13, 2014 at 01:27:28PM +0100, Johan Havold wrote:
On
On Mon, Nov 17, 2014 at 02:56:45PM +, Bruno Thomsen wrote:
Did you specify a led-mode as well, or was the Operation Mode Strap
Override (OMSO) write the first access after the soft reset?
No led-mode was specified so OMSO was the first write.
Did you try setting a led-mode before
The tty break and error flags are not bit masks so do not to use bitwise
OR when assigning them.
Note that there is no functional change due to the if-else construct and
flag having been initialised to zero (TTY_NORMAL).
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/tty/serial/serial
Fix reporting of overrun errors, which should only be reported once
using the inserted null character.
Fixes: 6b8f1ca5581b (USB: ssu100: set tty_flags in ssu100_process_packet)
Cc: stable sta...@vger.kernel.org
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/usb/serial/ssu100.c | 11
(Linux-2.6.12-rc2)
Cc: stable sta...@vger.kernel.org
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/usb/serial/keyspan.c | 76
1 file changed, 48 insertions(+), 28 deletions(-)
diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial
Fix reporting of overrun errors, which are not associated with a
character. Instead insert a null character and report only once.
Fixes: 1da177e4c3f4 (Linux-2.6.12-rc2)
Cc: stable sta...@vger.kernel.org
Signed-off-by: Johan Hovold jo...@kernel.org
---
drivers/usb/serial/keyspan.c | 21
: Johan Hovold jo...@kernel.org
Date: Mon, 22 Dec 2014 18:39:39 +0100
Subject: [PATCH] USB: keyspan: fix null-deref at probe
Fix null-pointer dereference during probe if the interface-status
completion handler is called before the individual ports have been set
up.
Reported-by: Richard richj
On Fri, Dec 12, 2014 at 09:01:03AM -0600, George McCollister wrote:
On Wed, Dec 10, 2014 at 7:04 AM, Johan Hovold jo...@kernel.org wrote:
On Mon, Dec 08, 2014 at 05:24:17PM -0600, George McCollister wrote:
+ switch (termios-c_cflag CSIZE) {
C_CSIZE(tty)
Okay
+ case CS5
On Sun, Dec 14, 2014 at 11:51:11AM -0600, George McCollister wrote:
Johan,
While working on the tx_empty changes you suggested it occurred to me
that it might not be obvious to others that the firmware doesn't send
a packet with the NT124_CTRL_TXEMPTY flag cleared when it begins
On Sat, Dec 13, 2014 at 05:17:42PM +0530, Muthu Mani wrote:
Adds support for USB-I2C/GPIO interfaces of Cypress Semiconductor
CYUSBS234 USB-Serial Bridge controller.
Details about the device can be found at:
http://www.cypress.com/?rID=84126
Separate cell drivers are available for I2C and
On Thu, Dec 11, 2014 at 03:29:52PM -0800, Jeremiah Mahler wrote:
If a USB serial device (e.g. /dev/ttyUSB0) with an active program is
unplugged, a bunch of -ENODEV and -EPROTO errors will be produced in the
logs. This patch set quiets these messages without changing the
original behavior.
501 - 600 of 4742 matches
Mail list logo
