Re: [PATCH 22/29] drivers, scsi: convert iscsi_task.refcount from atomic_t to refcount_t

> This looks OK to me. >>>> >>>> Acked-by: Chris Leech <cle...@redhat.com> >>> >>> Thank you for review! Do you have a tree that can take this change? >> >> Hi Elena, >> >> iscsi like fcoe should go via the SCSI tree. > > Tha

Re: [PATCH][V2] scsi: cxgb3i: remove redundant null check and kfree on skb

t(csk) does a kref_get(>refcnt), so this will at lease leak a kref. It will also "leak" the atids_in_use in cxgb3_alloc_atid() as there's a call to cxgb3_free_atid() missing. Looks like the complete cleanup path is worng here. But I'd prefer having Karen or someone else at

Re: [PATCH 21/29] drivers, s390: convert fc_fcp_pkt.ref_cnt from atomic_t to refcount_t

s. The subject is wrong, should be something like "scsi: libfc convert fc_fcp_pkt.ref_cnt from atomic_t to refcount_t" but not s390. Other than that Acked-by: Johannes Thumshirn <j...@kernel.org> -- Johannes Thumshirn

Re: [PATCH] zram: set physical queue limits to avoid array out of bounds accesses

>>> On 03/07/2017 06:22 AM, Minchan Kim wrote: >>>>> Hello Johannes, >>>>> >>>>> On Mon, Mar 06, 2017 at 11:23:35AM +0100, Johannes Thumshirn wrote: >>>>>> zram can handle at most SECTORS_PER_PAGE sectors in a bio's bvec. When

[PATCH] zram: set physical queue limits to avoid array out of bounds accesses

-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/block/zram/zram_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index e27d89a..dceb5ed 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram

Re: [PATCH] scsi: qedi: fix build error without DEBUG_FS

c FastLinQ offload iSCSI driver > framework.") > Signed-off-by: Arnd Bergmann <a...@arndb.de> > --- Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH] zram: set physical queue limits to avoid array out of bounds accesses

mv test.bin /dir/ sha256sum /dir/test.bin No panics and sha256sum of the 128MB test file still matches Tested-by: Johannes Thumshirn <jthumsh...@suse.de> Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> Now that you removed the one page limit in zram_bvec_rw() you can also ad

Re: [GIT PULL] SCSI fixes for 4.11-rc3

Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CA

Re: [PATCH] nvmet: convert from kmap to nvmet_copy_from_sgl

; > > I'd prefer removing the dynamic allocation and use d on the stack to > simplify the code. > Any thoughts ? Hi Max, Pasting from above: > >we can't allocate this memory on the stack as the kbuild test robot > >reports some frame size overflows on i386. -- Johannes

Re: [PATCH 00/29] constify scsi pci_device_id.

parate patch. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnber

Re: [PATCH 00/29] constify scsi pci_device_id.

h instead of replicating the same patch 29 times? Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham N

Re: [PATCH v2 01/13] mpt3sas: Update MPI Header

dd indentation. > Please reformat to have type and variable on one line. And use Linux types and no CamelCase and no typedefs (especially not for pointers), you're not on Windows here. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh..

[PATCH 2/2] nvmet: fcloop: remove ALL_OPTS define

ALL_OPTS isn't used anywhere, remove it. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/nvme/target/fcloop.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/nvme/target/fcloop.c b/drivers/nvme/target/fcloop.c index 1bb9d5b311b1..1cb9847ec261 100644 --- a/d

[PATCH 1/2] nvme: rdma: remove NVME_RDMA_MAX_SEGMENT_SIZE

NVME_RDMA_MAX_SEGMENT_SIZE is not used anywhere, zap it. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/nvme/host/rdma.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c index da04df1af231..57ac96ff9acb

[PATCH] Kbuild: enable -Wunused-macros warning for "make W=1"

We have lots of dead defines and macros in drivers, lets offer users a way to detect and eventually remove them. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- scripts/Makefile.extrawarn | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/Makefile.extrawarn b/s

Re: [PATCH] MCB: add support for SC31 to mcb-lpc

Applied, Thanks -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint

Re: [PATCH 4.12 004/106] scsi: sg: fix SG_DXFER_FROM_DEV transfers

annes >From 469957522c4b356a313cb369e3e14fdac104370f Mon Sep 17 00:00:00 2001 From: Johannes Thumshirn <jthumsh...@suse.de> Date: Thu, 27 Jul 2017 09:11:26 +0200 Subject: [PATCH] scsi: sg: only check for dxfer_len greater than 256M commit f930c7043663188429cd9b254e9d761edfc101ce upstream Don't

Re: [PATCH] sym53c8xx: Avoid undefined behaviour in drivers/scsi/sym53c8xx_2/sym_hipd.c:762

rning by switching to dev64_ul(). div64_ul() ^ Otherwise, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX Gm

Re: [PATCH 4.12 004/106] scsi: sg: fix SG_DXFER_FROM_DEV transfers

n Linus' tree (Yes I know I explicitly sent it to stable, mea culpa) Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imen

Re: [RFC PATCH 4/6] bsg: refactor ioctl to use regular BSG-command infrastructure for SG_IO

onstruct. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint

Re: [RFC PATCH 5/6] bsg: reduce unnecessary arguments for bsg_map_hdr()

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [RFC PATCH 6/6] bsg: reduce unnecessary arguments for blk_complete_sgv4_hdr_rq()

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

[PATCH v2] nvme: Fix nvme reset command timeout handling

titive returns mean the controller is still usable. bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=196325 Signed-off-by: Keith Busch <keith.bu...@intel.com> Cc: Martin Peres <martin.pe...@intel.com> [jth consolidated cleanup path ] Signed-off-by: Johannes Thumshirn <jthumsh..

Re: [PATCH v2 2/2] Introduce 8250_men_mcb

for uartclk. A reasonable default is included in > addition to the support of three boards. Additional values for other > boards will be added later. > > This v2 has some whitespace fixes, I screwed this up yesterday. Nit: this should go below the '---' marker. Apart from that, Reviewe

Re: [PATCH] nvmet: preserve controller serial number between reboots

ore as an RFD than a patch. I'm happy to withdraw if we find a better solution. [1] https://github.com/systemd/systemd/blob/master/rules/60-persistent-storage.rules [2] https://github.com/systemd/systemd/blob/master/rules/60-persistent-storage.rules#L27 Thanks, Johannes --

Re: [PATCH] nvmet: preserve controller serial number between reboots

generate a serial number per subsystem, > and on top of that the patch from Johannes seems perfectly reasonable. Well no problem, I can easily add that. -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 7405

Re: [PATCH v3 0/7] Enhance libsas hotplug feature

b is a SATA disk, the rest are SAS. This is awesome. I hope I have some time reviewing the patches themselfes soon. Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldst

[PATCH v4 0/3] Provide a stable serial number

(Chirstoph) Changes to v2: * Add attr_ prefix to version (Christoph) * Re-add random serial comment (Christoph) Changes to v1: * Move generation of random serial to nvmet_subsys_alloc() (Christoph) Johannes Thumshirn (3): nvmet: prefix version configfs file with attr nvmet: Move serial number

[PATCH v4 2/3] nvmet: Move serial number from controller to subsystem

; So move it from the controller to the subsystem, where it belongs. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Reviewed-by: Christoph Hellwig <h...@lst.de> --- drivers/nvme/target/admin-cmd.c | 2 +- drivers/nvme/target/core.c | 5 ++--- drivers/nvme/target/nvmet.h |

[PATCH v4 3/3] nvmet: preserve controller serial number between reboots

igned-off-by: Johannes Thumshirn <jthumsh...@suse.de> Reviewed-by: Christoph Hellwig <h...@lst.de> --- drivers/nvme/target/configfs.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c i

[PATCH v3 2/3] nvmet: Move serial number from controller to subsystem

; So move it from the controller to the subsystem, where it belongs. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/nvme/target/admin-cmd.c | 2 +- drivers/nvme/target/core.c | 5 ++--- drivers/nvme/target/nvmet.h | 2 +- 3 files changed, 4 insertions(+), 5 deletion

[PATCH v3 0/3] Provide a stable serial number

) * Re-add random serial comment(Christoph) Changes to v1: * Move generation of random serial to nvmet_subsys_alloc() (Christoph) Johannes Thumshirn (3): nvmet: prefix version configfs file with attr nvmet: Move serial number from controller to subsystem nvmet: preserve controller serial number

[PATCH v4 1/3] nvmet: prefix version configfs file with attr

The NVMe target's attribute files need an attr prefix in order to have nvmetcli recognize them. Add this attribute. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Reviewed-by: Christoph Hellwig <h...@lst.de> --- drivers/nvme/target/configfs.c | 8 1 file changed,

[PATCH] scsi: sg: fix static checker warning in sg_is_valid_dxfer

_dxfer(). Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Reported-by: Colin Ian King <colin.k...@canonical.com> Reported-by: Dan Carpenter <dan.carpen...@oracle.com> Cc: Douglas Gilbert <dgilb...@interlog.com> --- drivers/scsi/sg.c | 7 +-- 1 file changed

Re: [PATCH 00/13]mpt3sas driver NVMe support:

? Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerpri

[PATCH v2] scsi: sg: fix SG_DXFER_FROM_DEV transfers

Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Fixes: 28676d869bbb ("scsi: sg: check for valid direction before starting the request") Reported-by: Chris Clayton <chris2...@googlemail.com> Tested-by: Chris Clayton <chris2...@googlemail.com> Cc: Douglas Gi

[PATCH] nvme: also provide a UUID in the WWID sysfs attribute

and give it the highest priority. This eases generation of /dev/disk/by-* symlinks. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/nvme/host/core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index d70df1

[PATCH] nvmet: preserve controller serial number between reboots

igned-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/nvme/target/configfs.c | 22 ++ drivers/nvme/target/core.c | 8 ++-- drivers/nvme/target/nvmet.h| 1 + 3 files changed, 29 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/target/c

[PATCH v3 1/3] nvmet: prefix version configfs file with attr

The NVMe target's attribute files need an attr prefix in order to have nvmetcli recognize them. Add this attribute. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/nvme/target/configfs.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/driver

[PATCH v3 3/3] nvmet: preserve controller serial number between reboots

igned-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/nvme/target/configfs.c | 22 ++ drivers/nvme/target/core.c | 2 ++ 2 files changed, 24 insertions(+) diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c index ceee57bb0c24..0

[PATCH v2 0/2] Provide a stable serial number

to nvmet_subsys_alloc() (Christoph) Johannes Thumshirn (2): nvmet: Move serial number from controller to subsystem nvmet: preserve controller serial number between reboots drivers/nvme/target/admin-cmd.c | 2 +- drivers/nvme/target/configfs.c | 22 ++ drivers/nvme/target/core.c

[PATCH v2 2/2] nvmet: preserve controller serial number between reboots

igned-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/nvme/target/configfs.c | 22 ++ drivers/nvme/target/core.c | 2 ++ 2 files changed, 24 insertions(+) diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c index a358ecd93e11..9

[PATCH v2 1/2] nvmet: Move serial number from controller to subsystem

; So move it from the controller to the subsystem, where it belongs. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/nvme/target/admin-cmd.c | 2 +- drivers/nvme/target/core.c | 4 +--- drivers/nvme/target/nvmet.h | 2 +- 3 files changed, 3 insertions(+), 5 deletion

Re: [PATCH v2 2/2] nvmet: preserve controller serial number between reboots

hat should go into 3.12 (just like your serial number fix). > Is it OK if I send the patches in the same series? -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409

[PATCH 1/2] nvmet: Move serial number from controller to subsystem

; So move it from the controller to the subsystem, where it belongs. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/nvme/target/admin-cmd.c | 2 +- drivers/nvme/target/core.c | 4 ++-- drivers/nvme/target/nvmet.h | 2 +- 3 files changed, 4 insertions(+), 4 deletion

[PATCH 2/2] nvmet: preserve controller serial number between reboots

igned-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/nvme/target/configfs.c | 22 ++ drivers/nvme/target/core.c | 2 ++ 2 files changed, 24 insertions(+) diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c index a358ecd93e11..9

[PATCH 0/2] Provide a stable serial number

This pathset is a follow up to http://lists.infradead.org/pipermail/linux-nvme/2017-July/011934.html. The 1st patch moves the serial attribute from the contrller to the subsystem, while the 2nd patch makes it configurable via configfs. Johannes Thumshirn (2): nvmet: Move serial number from

Re: [PATCH] scsi: qedf: Limit number of CQs

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [REGRESSION] 28676d869bbb (scsi: sg: check for valid direction before starting the request) breaks mtx tape library control

is fixed with: commit 68c59fcea1f2c6a54c62aa896cc623c1b5bc9b47 Author: Johannes Thumshirn <jthumsh...@suse.de> Date: Fri Jul 7 10:56:38 2017 +0200 scsi: sg: fix SG_DXFER_FROM_DEV transfers SG_DXFER_FROM_DEV transfers do not necessarily have a dxferp as we set it to NULL for the old s

Re: [REGRESSION] 28676d869bbb (scsi: sg: check for valid direction before starting the request) breaks mtx tape library control

g_io_hdr_t *hp) { + + pr_info("%s: dxfer_direction: %d, dxfer_len: %d\n", + __func__, hp->dxfer_direction, hp->dxfer_len); + switch (hp->dxfer_direction) { case SG_DXFER_NONE: if (hp->dxferp || hp->dxfer_len > 0) Than

Re: [REGRESSION] 28676d869bbb (scsi: sg: check for valid direction before starting the request) breaks mtx tape library control

0, can we rely on dxferp being present? Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Gr

Re: [PATCH v2] scsi: qedf: Limit number of CQs

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

[PATCH] scsi: sg: only check for dxfer_len greater than 256M

Don't make any assumptions on the sg_io_hdr_t::dxfer_direction or the sg_io_hdr_t::dxferp in order to determine if it is a valid request. The only way we can check for bad requests is by checking if the length exceeds 256M. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>

Re: [REGRESSION] 28676d869bbb (scsi: sg: check for valid direction before starting the request) breaks mtx tape library control

care combinations was, that user-space could then easily crash the kernel. This is the reason I introduced sg_is_valid_dxfer(). It's sole purpuse was to avoid more CVEs, but unfortunately it turned into quite some regressions. Thanks, Johannes -- Johannes Thumshirn

Re: [PATCH, RESEND] scsi: lpfc: fix linking against modular NVMe support

On Wed, Jul 26, 2017 at 11:17:09AM +0200, Arnd Bergmann wrote: > Ah, it was only below the "---" line, so I'll skip the resending > unless you want me > to add a comment in the Kconfig file. Nah no need, really. Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>

Re: [PATCH, RESEND] scsi: lpfc: fix linking against modular NVMe support

m, the current symbol can only be "m" or > "n", while "X=y" means it can have any value. > > So for "depends on X || X=n", the current symbol cannot be "y" when "X=m", > but otherwise can have any of t

Re: [PATCH, RESEND] scsi: lpfc: fix linking against modular NVMe support

is black magic, but X || X=n ? I have no doubt you do the right thing, I just don't understand it. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr.

Re: [REGRESSION] 28676d869bbb (scsi: sg: check for valid direction before starting the request) breaks mtx tape library control

On Tue, Jul 25, 2017 at 01:25:07PM -0500, Jason L Tibbitts III wrote: > >>>>> "JT" == Johannes Thumshirn <jthumsh...@suse.de> writes: > ioctl(3, SG_IO, {interface_id='S', dxfer_direction=SG_DXFER_TO_DEV, > cmd_len=12, cmdp="\xa5\x00\x00\x00\x00\

Re: [REGRESSION] 28676d869bbb (scsi: sg: check for valid direction before starting the request) breaks mtx tape library control

On Fri, Jul 21, 2017 at 02:23:16PM -0500, Jason L Tibbitts III wrote: > I can also apply the debugging patch and try again if that would give > you more useful information. Yes please (on top of the snippet I've sent you last). Thanks a lot, Johannes -- Johannes Thu

Re: [REGRESSION] 28676d869bbb (scsi: sg: check for valid direction before starting the request) breaks mtx tape library control

Doug, On Wed, Jul 19, 2017 at 10:36:54AM +0200, Johannes Thumshirn wrote: > On Wed, Jul 19, 2017 at 03:13:34AM -0500, Jason L Tibbitts III wrote: > > [ 46.304530] sg_is_valid_dxfer: dxfer_direction: -2, dxfer_len: 0 > > Ahh now I see the -2 (SG_DXFER_TO_DEV) is the crucial poin

Re: [PATCH RESEND 0/7] Introduce MEDIA_VERSION to end KENREL_VERSION abuse in media

but kill all the versioning stuff out of media (and others) except for maybe the HW version. > Any upstream driver should never use KERNEL_VERSION(). Exactly my reasoning. -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911

Re: [PATCH] nvme: Makefile: remove dead build rule

oks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Grah

Re: [PATCH RESEND 0/7] Introduce MEDIA_VERSION to end KENREL_VERSION abuse in media

e in-tree users IMHO. Yes there is _one_ other user of it in-tree which is EXT4 and I already talked to Jan Kara about it and we decided to leave it in until 4.20. Byte, Johannes -- Johannes Thumshirn Storage jthumsh..

Re: [PATCH 00/13]mpt3sas driver NVMe support:

NVMe devices and > PCIe switches. Hi Suganath, Can you please also Cc linux-n...@lists.infradead.org for NVMe related topics. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689

[PATCH] scsi: sg: fix SG_DXFER_FROM_DEV transfers

SG_DXFER_FROM_DEV transfers do not have a dxferp as we set it to NULL, but must have a length bigger than 0. This fixes a regression introduced by commit 28676d869bbb ("scsi: sg: check for valid direction before starting the request") Signed-off-by: Johannes Thumshirn <jthumsh...@s

Re: [PATCH] scsi: sg: fix SG_DXFER_FROM_DEV transfers

ode more readable IMHO. But ultimately it's your driver so if you insist I'll do. -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jan

Re: [PATCH] scsi: sas: move scsi_remove_host call into sas_remove_host

On Mon, Apr 24, 2017 at 02:38:40PM +0100, John Garry wrote: > On 24/04/2017 11:09, John Garry wrote: > >On 21/04/2017 13:11, Johannes Thumshirn wrote: > >>Move scsi_remove_host call into sas_remove_host and remove it from SAS > >>HBA > >>drivers, so we don

Re: [PATCH] scsi: fcoe: make fcoe_e_d_tov and fcoe_r_a_tov static

Looks good, Acked-by: Johannes Thumshirn <j...@kernel.org> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH] IB/rxe: Don't clamp residual length to mtu

On Thu, Apr 06, 2017 at 02:49:44PM +0200, Johannes Thumshirn wrote: > When reading a RDMA WRITE FIRST packet we copy the DMA length from the RDMA > header into the qp->resp.resid variable for later use. Later in check_rkey() > we clamp it to the MTU if the packet is an RDMA WRITE pa

Re: [PATCH 00/29] constify scsi pci_device_id.

On Mon, Aug 07, 2017 at 01:28:18PM -0400, Martin K . Petersen wrote: > However, having a bazillion identical commit messages is also really > annoying. So for automated changes like this, I'd rather just have a > single patch. Thought so ;-) -- Johannes

Re: [PATCH] IB/core: fix memory leak on ah on error return path

B core code but hns code. The reference to the patch which introduced the leak is given byu the fixes line. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeld

Re: [PATCH] IB/core: fix memory leak on ah on error return path

Shouldn't the subject start with "IB/hns:" given it's touching drivers/infiniband/hw/hns/hns_roce_ah.c? Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH,

Re: [PATCH] loop: fix to a race condition due to the early registration of device

or nit. Anyways, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smit

Re: [PATCH] loop: fix to a race condition due to the early registration of device

On Mon, Aug 07, 2017 at 03:37:50PM +0300, Anton Volkov wrote: > +err_out: > return err; Any reason you can't just use return err; at the respective callsites? Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@s

[PATCH] scsi: sg: don't return bogus Sg_requests

If the list search in sg_get_rq_mark() fails to find a valid request, we return a bogus element. This then can later lead to a GPF in sg_remove_scat(). So don't return bogus Sg_requests in sg_get_rq_mark() but NULL in case the list search doesn't find a valid request. Signed-off-by: Johannes

[PATCH v2] scsi: sg: don't return bogus Sg_requests

If the list search in sg_get_rq_mark() fails to find a valid request, we return a bogus element. This then can later lead to a GPF in sg_remove_scat(). So don't return bogus Sg_requests in sg_get_rq_mark() but NULL in case the list search doesn't find a valid request. Signed-off-by: Johannes

Re: [PATCH v6 05/10] nvmet: implement namespace identify descriptor list

t; gracefully, but still.. Ahm yes. *doh* Can you fix it up when applying? -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 3/3] libnvdimm: New ACPI 6.2 DSM functions

t; }; Can you please add the new values to the enum in uapi/ndctl.h? I don't really like the magic numbers here. -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409

Re: [PATCH] Fix loop device flush before configure v3

in `ls /dev/loop[0-9]*|sort`; do \ > echo $f; dd if=$f of=/dev/null bs=512 count=1; \ > done I think Christoph already asked this, but can you send a patch for blktests [1] as well? Thanks, Johannes [1] https://github.com/osandov

Re: [PATCH v6 01/10] scatterlist: add sg_zeroout_area() helper

gt; + size_t buflen, off_t skip); > > Maybe sg_zero_buffer to fit with the other functions in the family? > > (I'd be happy to fix this up if you're ok and we don't need another > respin otherwise). Sounds good. -- Johannes Thumshirn

Re: [PATCH v6 05/10] nvmet: implement namespace identify descriptor list

On 06/08/2017 09:52 AM, Christoph Hellwig wrote: > On Thu, Jun 08, 2017 at 09:49:35AM +0200, Johannes Thumshirn wrote: >> On 06/08/2017 09:44 AM, Christoph Hellwig wrote: >>>> + if (sg_zeroout_area(req->sg, req->sg_cnt, NVME_IDENTIFY_DATA_SIZE, off) >>&

[PATCH RESEND 5/7] [media] media: s3c-camif: Use MEDIA_REVISON instead of KERNEL_VERSION

Use MEDIA_REVISON instead of KERNEL_VERSION to encode the driver version. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/media/platform/s3c-camif/camif-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/s3c-camif/camif-cor

[PATCH RESEND 7/7] staging/atomisp: use MEDIA_VERSION instead of KERNEL_VERSION

Use MEDIA_VERSION instead of KERNEL_VERSION to encode the driver version of the Atom ISP driver. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/staging/media/atomisp/include/linux/atomisp.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/d

[PATCH RESEND 2/7] video: fbdev: don't use KERNEL_VERSION macro for MEDIA_REVISION

Don't use the KERNEL_VERSION() macro for the v4l2 capabilities, use MEDIA_REVISION instead. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/video/fbdev/matrox/matroxfb_base.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbdev/

[PATCH RESEND 3/7] [media] media: document the use of MEDIA_REVISION instead of KERNEL_VERSION

Update the documentation to introduce the use of MEDIA_REVISON instead of KERNEL_VERSION for the verison triplets of a media drivers hardware revision or driver version. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- Documentation/media/uapi/cec/cec-ioc-adap-g-caps.rst

[PATCH RESEND 0/7] Introduce MEDIA_VERSION to end KENREL_VERSION abuse in media

, but clearly has media centric semantics and doesn't fool someone into thinking specific parts are defined for a specific kernel version only like in out of tree drivers. Johannes Thumshirn (7): [media] media: introduce MEDIA_REVISION macro video: fbdev: don't use KERNEL_VERSION macro for MEDIA_REVISION

[PATCH RESEND 6/7] [media] media: bcm2048: use MEDIA_REVISION isntead of KERNEL_VERSION

Use MEDIA_REVISION isntead of KERNEL_VERSION to encode the bcm2048 driver version. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/bcm2048

[PATCH RESEND 1/7] [media] media: introduce MEDIA_REVISION macro

Currently the media code abuses the KERNEL_VERSION macro to encode a version triplet. Introduce a MEDIA_REVISION macro to get rid of the confusing and creative KERNEL_VERSION usage in the media subsystem. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- include/uapi/linux/media

[PATCH RESEND 4/7] [media] cx25821: use MEDIA_REVISION instead of KERNEL_VERSION

Use MEDIA_REVISION instead of KERNEL_VERSION to encode the CX25821_VERSION_CODE. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/media/pci/cx25821/cx25821.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/cx25821/cx25821.h b/drivers

[PATCH] nvme: add hostid token to fabric options

Currently we have no way to define a stable host-id but always use the one which is randomly generated when we add the host or use the default host. Provide a "hostid=%s" for user-space to pass in a persistent host-id which overrides the randomly generated one. Signed-off-by: Johannes

Re: [PATCH 1/2] hpsa: limit transfer length to 1MB

bsc#1025461 and our internal Bugzilla IDs How about: The hpsa firmware will bypass the cache for any requests larger than 1MB, so we shoould cap the request size to avoid any performance regressions in kernels later than 4.3 The same applies for Patch 2/2 -- Johann

[PATCH] qla2xxx: Protect access to qpair members with qpair->qp_lock

In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the qpair->qp_lock but do access members of the qpair before having the lock. Re-order the locking sequence to have all read and write access to qpair members under the qpair->qp_lock. Signed-off-by: Johannes Thumshirn &l

[PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock

In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the qpair->qp_lock but do access members of the qpair before having the lock. Re-order the locking sequence to have all read and write access to qpair members under the qpair->qp_lock. Signed-off-by: Johannes Thumshirn &l

Re: [PATCH v2 1/2] hpsa: limit transfer length to 1MB

is caused from d2be537c3ba3568acd79cd178327b842e60d035e, > which changed max_sectors_kb to 1280k, but the hardware is able to > work fine with it, so the true fix should be from hpsa driver. > > Signed-off-by: Yadan Fan <yd...@suse.com> > --- Reviewed-by: Johannes Thumshirn <jth

Re: [PATCH v2 2/2] smartpqi: limit transfer length to 1MB

is caused from d2be537c3ba3568acd79cd178327b842e60d035e, > which changed max_sectors_kb to 1280k, but the hardware is able to > work fine with it, so the true fix should be from smartpqi driver. > > Signed-off-by: Yadan Fan <yd...@suse.com> > --- Reviewed-by: Johannes Thumshirn <jth

Re: [PATCH] qla2xxx: Protect access to qpair members with qpair->qp_lock

On Thu, Jun 22, 2017 at 03:19:27PM +0100, John Garry wrote: > On 22/06/2017 14:43, Johannes Thumshirn wrote: > >In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the > >qpair->qp_lock but do access members of the qpair before having the lock. > >Re-order the

Re: [PATCH] scsi: aacraid: Don't copy uninitialized stack memory to userspace

3400e64d377 ("scsi: aacraid: Include HBA direct interface") > Fixes: c799d519bf088 ("scsi: aacraid: Retrieve HBA host information ioctl") > Signed-off-by: Seth Forshee <seth.fors...@canonical.com> > --- Looks good, Reviewed-by: Johannes T

[PATCH] qla2xxx: don't disable a not previously enabled PCI device

directly return *iff* one of the pci_enable_device() calls fails. Additionally rename the 'probe_out' goto label's name to the more descriptive 'disable_device'. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Fixes: e315cd28b9ef ("[SCSI] qla2xxx: Code changes for qla dat

Re: [PATCH 21/30] men-chameleon-bus.txt: standardize document format

- Adjust identations; > - Remove title numbering; > - mark literal blocks; > - comment its TOC. > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> > --- Looks good, Acked-by: Johannes Thumshirn <jthumsh...@suse.de>

[PATCH 0/7] Implement NVMe Namespace Descriptor Identification

. Johannes Thumshirn (7): nvme: rename uuid to nguid in nvme_ns nvmet: add uuid field to nvme_ns and populate via configfs nvmet: add eui64 field to nvme_ns and populate via configfs nvme: also report include the EUI-64 in identify NS report nvmet: implement namespace identify descriptor

<    4   5   6   7   8   9   10   11   12   13   >