On Wed, 13 Sep 2017, Jérémy Lefaure wrote:
> Rule r does not depend on rule i (which is the include of
> linux/kernel.h) so the output should not depend on i in
> org and report mode.
>
> Signed-off-by: Jérémy Lefaure
Acked-by: Julia Lawall
I guess that if the incude is miss
edef
> struct
> + T2
> { ... }
> -T
> ;
>
> @r3@
> type r1.T;
> identifier c1.T2;
> @@
> -T
> +struct T2
>
> Signed-off-by: Haneen Mohammed
Acked-by: Julia Lawall
> ---
> drivers/staging/irda/include/net/irda/qos.h | 20 ++--
> 1 fi
On Wed, 13 Sep 2017, Joe Perches wrote:
> On Thu, 2017-09-14 at 00:43 +0300, Dan Carpenter wrote:
> > He was exagerating a bit to call it a "static checker" warning...
>
> Not really.
>
> False positives and false negatives exist in just about
> every static
> checker.
>
> > It's just checkpatch
On Wed, 13 Sep 2017, Himanshi Jain wrote:
> This patchset is to rewrite the IIO_DEVICE_ATTR_NAMED API to pass name
> as string.
You need to indicate what has changed in the v2, either here or in the
individual patches.
julia
>
> Himanshi Jain (2):
> include: linux: sysfs: Add __ATTR_NAMED
. };
>
> @@
> identifier r.i, r.s, rr.fld;
> position r.p;
> @@
> (
> -pr_err@p
> +netdev_err
> (
> + i->fld,
> ...)
> |
> -pr_info@p
> +netdev_info
> (
> + i->fld,
> ...)
> |
> -pr_debug@p
> +netdev_dbg
> (
> + i->f
On Tue, 12 Sep 2017, himanshi wrote:
> Thanks for the review Daniel! I will change the imperative mood for the commit
> message once the other changes are finalised too and as suggested by Julia,
> would try to make the description specific than general.
>
> I tried to think of adding subsystem
e;
> -return ret;
>
> Signed-off-by: Srishti Sharma
Acked-by: Julia Lawall
> ---
> drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm
e;
> -return ret;
>
> Signed-off-by: Srishti Sharma
Acked-by: Julia Lawall
> ---
> drivers/staging/media/atomisp/i2c/ov5693/ov5693.c | 11 ++-
> 1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/i2c/ov5693/ov5693
gt; Space required before '&', '*'
> Space is required after ',', ';'
>
> Signed-off-by: Harsha Sharma
Acked-by: Julia Lawall
> ---
> drivers/staging/rtl8723bs/os_dep/mlme_linux.c | 30
> +--
> 1 file chan
It'sa small detail, but perhaps you could fix the spelling of unnecessary
(1 c and 2 s's).
julia
On Tue, 12 Sep 2017, Harsha Sharma wrote:
> Remove space between function name and open parenthesis '('
> Remove space before ';', '++', ','
>
> Signed-off-by: Harsha Sharma
> ---
> Change in v2:
>
On Tue, 12 Sep 2017, Daniel Baluta wrote:
> Hi Himanshi,
>
> On Tue, Sep 12, 2017 at 1:43 AM, Himanshi Jain
> wrote:
> > Fixed IIO_DEVICE_ATTR_NAMED API to take name as a
> > string instead of implicit conversion to string using
> > preprocessors. Added double quotes around names in
> > existi
On Mon, 11 Sep 2017, Srishti Sharma wrote:
> On Mon, Sep 11, 2017 at 9:34 PM, Greg KH wrote:
> > On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote:
> >> The use of volatile for the variable monitor_lock is unnecessary.
> >>
> >> Signed-off-by: Srishti Sharma
> >> ---
> >> drivers
On Mon, 11 Sep 2017, Srishti Sharma wrote:
> The use of volatile for the variable monitor_lock is unnecessary.
You need to give more evidence of why this is the case. How is the
variable used? I guess this comes from checkpatch, but checkpatch has
only a local view of things, and doesn't know
On Mon, 11 Sep 2017, Srishti Sharma wrote:
> Remove extra blank line.
>
> Signed-off-by: Srishti Sharma
Acked-by: Julia Lawall
> ---
> drivers/staging/rtl8712/rtl8712_event.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/rtl8
On Sun, 10 Sep 2017, Harsha Sharma wrote:
> Space required after ','
>
> Signed-off-by: Harsha Sharma
Acked-by: Julia Lawall
> ---
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff
On Sun, 10 Sep 2017, Harsha Sharma wrote:
> Use spaces between concatenated strings
Perhaps all the entry/exit ones could be dropped, and the ohters could be
rewritten to use more standard kernel debugging functionalities.
julia
>
> Signed-off-by: Harsha Sharma
> ---
> drivers/staging/rtl87
On Sun, 10 Sep 2017, Harsha Sharma wrote:
> No spaces at the start of a line
>
> Signed-off-by: Harsha Sharma
Acked-by: Julia Lawall
> ---
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/
On Sun, 10 Sep 2017, Harsha Sharma wrote:
> Use spaces around most binary operators
>
> Signed-off-by: Harsha Sharma
Acked-by: Julia Lawall
> ---
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
&
On Sun, 10 Sep 2017, Harsha Sharma wrote:
> Use one space around (on each side of) '=' operator
>
> Signed-off-by: Harsha Sharma
Acked-by: Julia Lawall
> ---
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 20 ++--
> 1 file changed, 10
On Sun, 10 Sep 2017, Harsha Sharma wrote:
> Use one space around most binary operators
>
> Signed-off-by: Harsha Sharma
Acked-by: Julia Lawall
> ---
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
&
touching scattered places in the same file,
the patches should be in a series.
julia
>
> Regards,
> Harsha Sharma
>
>
> On Sat, Sep 9, 2017 at 11:56 PM, Julia Lawall wrote:
>
>
> On Sat, 9 Sep 2017, Harsha Sharma wrote:
>
> > Use one space arou
On Sat, 9 Sep 2017, Harsha Sharma wrote:
> Use one space around most binary operators
>
> Signed-off-by: Harsha Sharma
> ---
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 26 +-
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/staging/rtl87
; Signed-off-by: Srishti Sharma
Acked-by: Julia Lawall
> ---
> Changes in v4:
> -Edit commit message so that it respects 80 character limit
> -Remove unneeded blank lines
> -Remove declarations of variables that are not used
>
> drivers/staging/ccree/ssi_aead.c | 15 +
On Sat, 9 Sep 2017, Harsha Sharma wrote:
> This was reported by checkpatch.pl
>
> Signed-off-by: Harsha Sharma
Acked-by: Julia Lawall
> ---
> drivers/staging/sm750fb/sm750_cursor.c | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/sm7
On Sat, 9 Sep 2017, Srishti Sharma wrote:
> Merge the assignment and return statements to return the value
> directly. Done using coccinelle.
Coccinelle is not always perfect about pretty printing, so you have to
watch out for it.
>
> @@
> local idexpression ret;
> expression e;
> @@
>
> -ret
On Sat, 9 Sep 2017, Greg KH wrote:
> On Sat, Sep 09, 2017 at 12:30:42PM +0530, Harsha Sharma wrote:
> > State explicitly that individual entries in array will not change.
> >
> > Signed-off-by: Harsha Sharma
> > ---
> > drivers/staging/unisys/visorbus/visorchipset.c | 4 ++--
> > 1 file change
On Sat, 9 Sep 2017, Srishti Sharma wrote:
> On Sat, Sep 9, 2017 at 2:28 AM, Julia Lawall wrote:
> >
> >
> > On Sat, 9 Sep 2017, Srishti Sharma wrote:
> >
> >> Merge the assignment and return statements to return the value
> >> directly. D
On Sat, 9 Sep 2017, Srishti Sharma wrote:
> Merge the assignment and return statements to return the value
> directly. Done using coccinelle.
>
> @@
> local idexpression ret;
> expression e;
> @@
>
> -ret =
> +return
> e;
> -return ret;
>
> Signed-off-by: Srishti Sharma
> ---
> Changes in
On Sat, 9 Sep 2017, Srishti Sharma wrote:
> Merge the assignment and return statements to return the value
> directly. Done using coccinelle.
>
> @@
> local idexpression ret;
> expression e;
> @@
>
> -ret =
> +return
> e;
> -return ret;
>
> Signed-off-by: Srishti Sharma
> ---
> Changes in
On Sat, 9 Sep 2017, Srishti Sharma wrote:
> On Sat, Sep 9, 2017 at 1:42 AM, Julia Lawall wrote:
> >
> >
> > On Sat, 9 Sep 2017, Srishti Sharma wrote:
> >
> >> Return the return value of a function directly, instead of first saving it
> >> in a va
On Sat, 9 Sep 2017, Srishti Sharma wrote:
> Return the return value of a function directly, instead of first saving it in
> a variable and then returning it. This change was made using the following
Your commit message should respect the 80 character limit. The above is
one very long line.
>
On Fri, 8 Sep 2017, Harsha Sharma wrote:
> Make code more concise and readable
>
> Signed-off-by: Harsha Sharma
Acked-by: Julia Lawall
> ---
> Change in v3:
> -Change in subject and log message
> Change in v2:
> -Change in subject
> -Change in log message
>
Maybe "Rewrite comparison to NULL pointer" in the subject to include what
was done, not just code was touched.
On Fri, 8 Sep 2017, Harsha Sharma wrote:
> Makes code more concise and readable
Makes -> Make. Commit logs should be written in the imperative, like you
are telling someone what to do.
On Fri, 8 Sep 2017, Harsha Sharma wrote:
> Fixes coding style issue
Good job on getting the From issue sorted out.
The subject line change description is a bit verbose. One doesn't want
to see the whole code, but rather the concept of what has changed. If you
were going to tell someone about
On Fri, 8 Sep 2017, Srishti Sharma wrote:
> Use WARN_ON() instead of BUG_ON() to avoid crashing the kernel.
>
> Signed-off-by: Srishti Sharma
> ---
> drivers/staging/media/omap4iss/iss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/omap4iss/iss
On Fri, 8 Sep 2017, Lars-Peter Clausen wrote:
> On 09/08/2017 11:59 AM, Julia Lawall wrote:
> >
> >
> > On Fri, 8 Sep 2017, Lars-Peter Clausen wrote:
> >
> >> On 09/08/2017 11:32 AM, Jonathan Cameron wrote:
> >>> On Fri, 8 Sep 2017 07:29:06 +0100
On Fri, 8 Sep 2017, Lars-Peter Clausen wrote:
> On 09/08/2017 11:32 AM, Jonathan Cameron wrote:
> > On Fri, 8 Sep 2017 07:29:06 +0100
> > Jonathan Cameron wrote:
> >
> >> On 8 September 2017 05:47:52 BST, Himanshi Jain
> >> wrote:
> >>> Added space around(one on each side of) binary
> >>> ope
On Fri, 8 Sep 2017, Dan Carpenter wrote:
> On Fri, Sep 08, 2017 at 11:45:20AM +0200, Julia Lawall wrote:
> >
> >
> > On Fri, 8 Sep 2017, harsha wrote:
> >
> > > From: Harsha Sharma
> > >
> > > Fixes checkpatch warning -- "occured&
On Fri, 8 Sep 2017, harsha wrote:
> From: Harsha Sharma
>
> Fixes checkpatch warning -- "occured" and "succesfully" are misspelled
>
> Signed-off-by: Harsha Sharma
> ---
> Changes in v4:
> -Correct the format of the subject.
> -Signed-off properly.
It's not signed off properly. Like Greg j
regards,
> Harsha Sharma
>
> On Fri, Sep 8, 2017 at 2:16 PM, Julia Lawall wrote:
>
>
> On Fri, 8 Sep 2017, harsha wrote:
>
> > Fixed coding style issue
> >
> > Signed-off-by: Harsha Sharma
> > ---
> > drivers/
On Fri, 8 Sep 2017, harsha wrote:
> Fixed coding style issue
>
> Signed-off-by: Harsha Sharma
> ---
> drivers/staging/rtl8712/xmit_linux.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/xmit_linux.c
> b/drivers/staging/rtl8712/xmit_linux
The subject line above is still not what is shown with git log --oneline
for this file. Also, this patch fixes a previous submission so it should
be v2.
I suggest to read through the tutorial carefully again to get these small
details.
julia
On Fri, 8 Sep 2017, harsha wrote:
> Fixes checkpatch
On Fri, 8 Sep 2017, Himanshi Jain wrote:
> Added space around(one on each side of) binary
I think that just around would be clear enough.
In the previous patches on this file, found with git log --oneline, a
subject line of staging: iio: ad7192: seems to be more popular when the
patch affects
On Fri, 8 Sep 2017, harsha wrote:
> Fixes checkpatch warning -- "occured" and "succesfully" are misspelled
Thanks for the patch. The change looks ok, but the subject line is not.
Use git log --oneline on the affected file to see what others have done.
In general, you cannot guess what the subj
On Thu, 7 Sep 2017, Srishti Sharma wrote:
> Remove the local variable inflight_counter as it is never used.
>
> Signed-off-by: Srishti Sharma
Acked-by: Julia Lawall
> ---
> Changes in v5:
> - Correct the format of the subject.
> drivers/staging/ccree/ssi_cipher.c | 3
One last detail. The subject line above is not in the same format as that
of all of the other subject lines one commits affecting this file. You
can use git log --oneline to see what others have done. It is not really
possible to guess correctly. However, one does not generally include the
exte
On Thu, 7 Sep 2017, Srishti Sharma wrote:
> On Thu, Sep 7, 2017 at 2:47 AM, Julia Lawall wrote:
> >
> >
> > On Thu, 7 Sep 2017, Srishti Sharma wrote:
> >
> >> Remove local variable inflight_counter ,as it is never used.
> >
> > "counter
On Thu, 7 Sep 2017, Srishti Sharma wrote:
> Remove local variable inflight_counter ,as it is never used.
"counter ,as" -> "counter, as"
> Signed-off-by: Srishti Sharma
> ---
> Changes in v3:
> - There was no longer a need to make the comment more comprehensible as
>I have deleted the var
On Thu, 7 Sep 2017, Srishti Sharma wrote:
> Edited comment to make it more comprehensible.
>
> Signed-off-by: Srishti Sharma
> ---
> Changes in v2:
> - Make comment more comprehensible , instead of just correcting typos.
> drivers/staging/ccree/ssi_cipher.c | 4 +++-
> 1 file changed, 3 inser
On Wed, 6 Sep 2017, Srishti Sharma wrote:
>
>
> On Thursday, September 7, 2017 at 12:54:49 AM UTC+5:30, Srishti Sharma
> wrote:
> Correct spelling of counter in comment .
>
> Signed-off-by: Srishti Sharma
> ---
> drivers/staging/ccree/ssi_cipher.c | 2 +-
> 1 file
On Thu, 31 Aug 2017, Alexandre Belloni wrote:
> Hi,
>
> On 31/08/2017 at 21:08:10 +0200, Christophe JAILLET wrote:
> > Le 31/08/2017 à 12:38, Mark Brown a écrit :
> > > On Thu, Aug 31, 2017 at 12:31:33PM +0200, Takashi Iwai wrote:
> > >
> > > > This is again a typical problem by such a trivial f
On Thu, 31 Aug 2017, Alexandre Belloni wrote:
> On 31/08/2017 at 06:40:42 +0200, Christophe JAILLET wrote:
> > If 'clk_prepare_enable()' fails, we must release some resources before
> > returning. Add a new label in the existing error handling path and 'goto'
> > there.
> >
> > Fixes: 260ea95cc0
ic_t.
> > >
> > > Signed-off-by: Elena Reshetova
> >
> > Acked-by: Julia Lawall
>
> Thank you very much Julia! What is the correct path to merge this?
> I will resend with your acked-by, but what is the tree that should merge it?
Marek will take it. If you want to re
On Wed, 30 Aug 2017, Elena Reshetova wrote:
> atomic_as_refcounter.cocci script allows detecting
> cases when refcount_t type and API should be used
> instead of atomic_t.
>
> Signed-off-by: Elena Reshetova
Acked-by: Julia Lawall
> ---
> scripts/coccinelle/api/atomi
On Tue, 29 Aug 2017, Reshetova, Elena wrote:
> Hi, I am very sorry for the delayed reply. Finally unrigging my inbox :(
>
> > A few more small issues:
> >
> > When you deleted the disjunction, you kept the surrounding parentheses.
> > you can drop them (lines 83 and 85).
> >
> > I guess that the
On Mon, 28 Aug 2017, Joe Perches wrote:
> A simple cocci script that removes unnecessary casts of
> a void * will also remove casts with __force or __user
Unfortunately, attributes are currently not supported inside casts. This
can be done in a hackish way (possible false negatives) as follows
Allow messages about multiple timers.
Signed-off-by: Julia Lawall
---
scripts/coccinelle/api/setup_timer.cocci | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/scripts/coccinelle/api/setup_timer.cocci
b/scripts/coccinelle/api/setup_timer.cocci
index
On Tue, 22 Aug 2017, Kees Cook wrote:
> This improves the patch mode of setup_timer.cocci. Several patterns were
> missing:
> - assignments-before-init_timer() cases
> - limiting the .data case removal to the struct timer_list instance
> - handling calls by dereference (timer->field vs timer.
On Sun, 20 Aug 2017, Dmitry Torokhov wrote:
> On Sun, Aug 20, 2017 at 11:19:38AM +0200, Julia Lawall wrote:
> > No need to set .owner here. The core will do it.
> >
> > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> >
> > Fixes: 52cf590518d7
No need to set .owner here. The core will do it.
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Fixes: 52cf590518d7 ("input/keyboard: Add support for Dollar Cove TI power
button")
Signed-off-by: Julia Lawall
Signed-off-by: Fengguang Wu
---
dc_ti_pwrbtn.c |1
> +identifier fname =~ ".*free.*";
> +identifier fname2 =~ ".*destroy.*";
> +identifier fname3 =~ ".*del.*";
> +identifier fname4 =~ ".*queue_work.*";
> +identifier fname5 =~ ".*schedule_work.*";
> +identifier fname6 =~ ".*call_rcu.*";
Personally, I find the above regular expressions much easier t
It is intentional that the code on lines 122 and 124 is the same?
julia
-- Forwarded message --
Date: Thu, 17 Aug 2017 09:18:50 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [PATCH]
Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and
A few more small issues:
When you deleted the disjunction, you kept the surrounding parentheses.
you can drop them (lines 83 and 85).
I guess that the "del" regular expression is supposed to be matching
delete. But it also matches delayed, eg
net/batman-adv/bridge_loop_avoidance.c:1495:8-27:
at
These snd_soc_dai_ops structures are only stored in the ops field of
a snd_soc_dai_driver structure, which is const. Thus, the
snd_soc_dai_ops structures can be const too.
Done with the help of Coccinelle.
---
sound/soc/blackfin/bf6xx-i2s.c|2 +-
sound/soc/codecs/es8316.c |
These snd_soc_dai_ops structures are only stored in the ops field of
a snd_soc_dai_driver structure, which is const. Thus, the
snd_soc_dai_ops structures can be const too.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
sound/soc/codecs/zx_aud96p22.c |2 +-
1 file
These snd_soc_dai_ops structures are only stored in the ops field of
a snd_soc_dai_driver structure, which is const. Thus, the
snd_soc_dai_ops structures can be const too.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
sound/soc/codecs/es8316.c |2 +-
1 file changed, 1
These snd_soc_dai_ops structures are only stored in the ops field of
a snd_soc_dai_driver structure, which is const. Thus, the
snd_soc_dai_ops structures can be const too.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
sound/soc/rockchip/rockchip_pdm.c |2 +-
1 file
These snd_soc_dai_ops structures are only stored in the ops field of
a snd_soc_dai_driver structure, which is const. Thus, the
snd_soc_dai_ops structures can be const too.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
sound/soc/spear/spdif_in.c |2 +-
1 file changed
These snd_soc_dai_ops structures are only stored in the ops field of
a snd_soc_dai_driver structure, which is const. Thus, the
snd_soc_dai_ops structures can be const too.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
sound/soc/blackfin/bf6xx-i2s.c |2 +-
1 file
These snd_rawmidi_ops structures are only passed as the third
argument of snd_rawmidi_set_ops. This argument is const, so the
snd_rawmidi_ops structures can be const too.
Done with the help of Coccinelle.
---
drivers/hid/hid-prodikeys.c |2 +-
drivers/usb/gadget/function/f_midi.c
On Tue, 15 Aug 2017, Takashi Iwai wrote:
> On Tue, 15 Aug 2017 10:09:54 +0200,
> Julia Lawall wrote:
> >
> > These snd_rawmidi_ops structures are only passed as the third
> > argument of snd_rawmidi_set_ops. This argument is const, so the
> > snd_rawmidi_o
This snd_rawmidi_ops structure is only passed as the third
argument of snd_rawmidi_set_ops. This argument is const, so the
snd_rawmidi_ops structure can be const too.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/hid/hid-prodikeys.c |2 +-
1 file changed, 1
These snd_rawmidi_ops structures are only passed as the third
argument of snd_rawmidi_set_ops. This argument is const, so the
snd_rawmidi_ops structures can be const too.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/usb/gadget/function/f_midi.c |4 ++--
1
These snd_rawmidi_ops structures are only passed as the third
argument of snd_rawmidi_set_ops. This argument is const, so the
snd_rawmidi_ops structures can be const too.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
sound/firewire/motu/motu-midi.c |4 ++--
1 file
These structures are only copied into other structures, so
they can be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
v2: fix typo in the commit message
drivers/media/pci/ddbridge/ddbridge-core.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
The structure emu8000_ops is only copied into another structure, so
it can be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
sound/isa/sb/emu8000_callback.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/isa/sb/emu8000_callback.c b/sound
These structures are only copied into other stuructures, so
they can be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/media/pci/ddbridge/ddbridge-core.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/pci/ddbridge
On Mon, 14 Aug 2017, Elena Reshetova wrote:
> atomic_as_refcounter.cocci script allows detecting
> cases when refcount_t type and API should be used
> instead of atomic_t.
>
> Signed-off-by: Elena Reshetova
> ---
> scripts/coccinelle/api/atomic_as_refcounter.cocci | 148
>
This v4l2_clk_ops structure is only passed as the first argument of
v4l2_clk_register, which is const, so the v4l2_clk_ops structure can
also be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/media/platform/pxa_camera.c |2 +-
1 file changed, 1 insertion
This v4l2_audio structure is only copied into other structures,
so it can be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/media/pci/ttpci/av7110_v4l.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/ttpci
This virtio_config_ops structure is only stored in the config field
of a virtio_device structure and this field is const, so the
virtio_config_ops structure can also be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/misc/mic/vop/vop_main.c |2 +-
1 file
Hello,
At the suggestion of Christoph Hellwig, I am working on inlining the
functions stored in the err_handler field of a pci_driver structure into
the pci_driver structure itself. A number of functions in the file
arch/powerpc/kernel/eeh_driver.c have code like:
if (!driver->err_handle
On Sun, 13 Aug 2017, Joe Perches wrote:
> On Sun, 2017-08-13 at 15:24 +0200, Julia Lawall wrote:
> > Normally the values in the resource field and the argument to ARRAY_SIZE
> > in the num_resources are the same. In this case, the value in the reousrce
> > field is the s
field
with the argument to the local call to ARRAY_SIZE.
Signed-off-by: Julia Lawall
---
arch/powerpc/platforms/chrp/pegasos_eth.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/chrp/pegasos_eth.c
b/arch/powerpc/platforms/chrp/pegasos_eth.c
index
These uart_ops structures are only stored in the ops field of a
uart_port structure and this fields is const, so the uart_ops
structures can also be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/tty/serial/21285.c |2 +-
1 file changed, 1 insertion(+), 1
These uart_ops structures are only stored in the ops field of a
uart_port structure and this fields is const, so the uart_ops
structures can also be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/tty/serial/meson_uart.c |2 +-
1 file changed, 1 insertion
These uart_ops structures are only stored in the ops field of a
uart_port structure and this fields is const, so the uart_ops
structures can also be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/tty/serial/ucc_uart.c |2 +-
1 file changed, 1 insertion
These uart_ops structures are only stored in the ops field of a
uart_port structure and this fields is const, so the uart_ops
structures can also be const.
Done with the help of Coccinelle.
---
drivers/tty/serial/21285.c |2 +-
drivers/tty/serial/apbuart.c|
These uart_ops structures are only stored in the ops field of a
uart_port structure and this fields is const, so the uart_ops
structures can also be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/tty/serial/cpm_uart/cpm_uart_core.c |2 +-
1 file changed
These uart_ops structures are only stored in the ops field of a
uart_port structure and this fields is const, so the uart_ops
structures can also be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/tty/serial/m32r_sio.c |2 +-
1 file changed, 1 insertion
These uart_ops structures are only stored in the ops field of a
uart_port structure and this fields is const, so the uart_ops
structures can also be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/tty/serial/apbuart.c |2 +-
1 file changed, 1 insertion
These uart_ops structures are only stored in the ops field of a
uart_port structure and this fields is const, so the uart_ops
structures can also be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/tty/serial/mpc52xx_uart.c |2 +-
1 file changed, 1
These uart_ops structures are only stored in the ops field of a
uart_port structure and this fields is const, so the uart_ops
structures can also be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/tty/serial/sunsab.c |2 +-
1 file changed, 1 insertion
These uart_ops structures are only stored in the ops field of a
uart_port structure and this fields is const, so the uart_ops
structures can also be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/tty/serial/mux.c |2 +-
1 file changed, 1 insertion(+), 1
These uart_ops structures are only stored in the ops field of a
uart_port structure and this fields is const, so the uart_ops
structures can also be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/tty/serial/sunsu.c |2 +-
1 file changed, 1 insertion(+), 1
These uart_ops structures are only stored in the ops field of a
uart_port structure and this fields is const, so the uart_ops
structures can also be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/tty/serial/owl-uart.c |2 +-
1 file changed, 1 insertion
Another issue arises in the files drivers/infiniband/hw/hfi1/pcie.c and
drivers/infiniband/hw/qib/qib_pcie.c, where the pci_error_handlers
structure is defined in one file and used in another file. The structure
definition references various functions that are static in the same file.
Should I try
On Sat, 12 Aug 2017, Christoph Hellwig wrote:
> On Sat, Aug 12, 2017 at 09:52:28AM +0200, Julia Lawall wrote:
> > OK, sure. So to be precise, you want the fields error_detected,
> > mmio_enabled, etc to be added as new fields to the pci_driver structure?
>
> Yes.
>
>
On Sat, 12 Aug 2017, Christoph Hellwig wrote:
> On Sat, Aug 12, 2017 at 07:44:28AM +0200, Julia Lawall wrote:
> > These pci_error_handlers structures are only stored in the err_handler
> > field of a pci_driver structure, and this field is declared as const. Thus
> > t
These snd_compr_codec_caps structures are only copied into other
structures, so they can be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
sound/soc/intel/atom/sst/sst_drv_interface.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound
1101 - 1200 of 4067 matches
Mail list logo
