This patch fixes warnings/errors raised by checkpatch.pl relating to whitespace
in r8192U_dm.c.
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/rtl8192u/r8192U_dm.c | 1409 +-
1 file changed, 530 insertions(+), 879 deletions(-)
diff --git
This patch fixes errors raised by checkpatch.pl relating to use of C99 comments
in r8192U_dm.c.
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/rtl8192u/r8192U_dm.c | 841 ++-
1 file changed, 432 insertions(+), 409 deletions(-)
diff --git
This patch fixes warnings/errors raised by checkpatch.pl relating to redundant
code in r8192U_dm.c.
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/rtl8192u/r8192U_dm.c | 160 +--
1 file changed, 77 insertions(+), 83 deletions(-)
diff --git
-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/rtl8192u/r8192U_dm.c | 27 ---
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_dm.c
b/drivers/staging/rtl8192u/r8192U_dm.c
index 0839ea7..72d1f47 100644
--- a/drivers/staging
On 31 December 2014 at 19:00, Konrad Zapalowicz bergo.tor...@gmail.com wrote:
You also fix the line length here which shall be the subject of a
separate patch as this is not C99 comments related change.
Apologies - I missed this, will prepare a v2 with this separated out
into a different
On 31 December 2014 at 19:23, Jeremiah Mahler jmmah...@gmail.com wrote:
But this change is not related to C99 comments and you didn't
explain why this change was made in your log message.
It should probably be in a separate patch.
Absolutely, I am currently fixing this and checking for any
This patch fixes warnings/errors raised by checkpatch.pl relating to whitespace
in r8192U_dm.c and additionally it removes inconsistent whitespace throughout.
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/rtl8192u/r8192U_dm.c | 1606 +-
1
This patch fixes errors raised by checkpatch.pl relating to use of C99 comments
in r8192U_dm.c and cleans up existing ANSI C comments.
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/rtl8192u/r8192U_dm.c | 811 ++-
1 file changed, 420
-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/rtl8192u/r8192U_dm.c | 27 ---
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_dm.c
b/drivers/staging/rtl8192u/r8192U_dm.c
index ed566bb..bae8511 100644
--- a/drivers/staging
This patch fixes warnings/errors raised by checkpatch.pl relating to redundant
code in r8192U_dm.c.
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/rtl8192u/r8192U_dm.c | 176 +--
1 file changed, 84 insertions(+), 92 deletions(-)
diff --git
On 31 December 2014 at 21:20, Joe Perches j...@perches.com wrote:
It'd be nicer to use the same form and indentation
for both entries.
Probably be nicer to use:
static u32 edca_setting_DL[HT_IOT_PEER_MAX] = {
0x5e4322, 0x5e4322, 0x5e4322, 0x604322, 0x00a44f, 0x5ea44f
};
static
This patch fixes warnings/errors raised by checkpatch.pl relating to whitespace
in r8192U_dm.c and additionally it removes inconsistent whitespace
throughout.
Additionally some 0x00... padding has been added for alignment to the
edca_setting_* variables.
Signed-off-by: Lorenzo Stoakes lstoa
On 1 January 2015 at 06:28, Sudip Mukherjee sudipm.mukher...@gmail.com wrote:
i may be wrong, but looks like you are doing many different things in the
patch, not just whitespace errors.
marked a few, please see inline -
...
sorry for not trimming that. I noticed the big size while
On 1 January 2015 at 04:58, Sudip Mukherjee sudipm.mukher...@gmail.com wrote:
On Thu, Jan 01, 2015 at 10:19:56AM +0530, Sudip Mukherjee wrote:
but this is just removal of unnecessary braces. this is not removal of
redundant code.
Hi Sudip,
Again in the same theme as the whitespace changes I
This patch fixes warnings/errors raised by checkpatch.pl relating to whitespace
in r8192U_dm.c, removes inconsistent whitespace, and additionally fixes some
vertical alignment issues.
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/rtl8192u/r8192U_dm.c | 1697
This patch fixes errors raised by checkpatch.pl relating to use of C99 comments
in r8192U_dm.c, and cleans up existing ANSI C comments.
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/rtl8192u/r8192U_dm.c | 811 ++-
1 file changed, 420
This patch fixes warnings raised by checkpatch.pl relating to heavily indented
lines in r8192U_dm.c by refactoring code to achieve the same outcome indented by
one less tab.
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/rtl8192u/r8192U_dm.c | 27
This patch fixes warnings/errors raised by checkpatch.pl relating to redundant
code in r8192U_dm.c.
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/rtl8192u/r8192U_dm.c | 165 ---
1 file changed, 74 insertions(+), 91 deletions(-)
diff --git
the test branch instead of staging-testing as you
actually requested :) I will fix now.
--
Lorenzo Stoakes
https:/ljs.io
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
This patch fixes warnings/errors raised by checkpatch.pl relating to whitespace
in r8192U_dm.c, removes inconsistent whitespace, and additionally fixes some
vertical alignment issues.
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/rtl8192u/r8192U_dm.c | 1604
This patch fixes errors raised by checkpatch.pl relating to use of C99 comments
in r8192U_dm.c, and cleans up existing ANSI C comments.
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/rtl8192u/r8192U_dm.c | 807 ++-
1 file changed, 416
This patch fixes warnings/errors raised by checkpatch.pl relating to redundant
code in r8192U_dm.c.
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/rtl8192u/r8192U_dm.c | 153 ---
1 file changed, 68 insertions(+), 85 deletions(-)
diff --git
This patch fixes warnings raised by checkpatch.pl relating to heavily indented
lines in r8192U_dm.c by refactoring code to achieve the same outcome indented by
one less tab.
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/rtl8192u/r8192U_dm.c | 27
This patch fixes warnings/errors raised by checkpatch.pl relating to redundant
code in r8192U_dm.c.
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/rtl8192u/r8192U_dm.c | 176 +--
1 file changed, 84 insertions(+), 92 deletions(-)
diff --git
This patch fixes warnings/errors raised by checkpatch.pl relating to whitespace
in r8192U_dm.c, removes inconsistent whitespace, and additionally fixes some
vertical alignment issues.
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/rtl8192u/r8192U_dm.c | 1606
This patch fixes warnings raised by checkpatch.pl relating to heavily indented
lines in r8192U_dm.c by refactoring code to achieve the same outcome indented by
one less tab.
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/rtl8192u/r8192U_dm.c | 27
This patch fixes errors raised by checkpatch.pl relating to use of C99 comments
in r8192U_dm.c, and cleans up existing ANSI C comments.
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/rtl8192u/r8192U_dm.c | 811 ++-
1 file changed, 420
be easier for me to
resend the whole series to make it clear which is applicable right
now.
Best,
--
Lorenzo Stoakes
https:/ljs.io
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
in the kernel and see it as a means to improve my
contributions :)
Call it a v2 patch. Put a note under the --- cut off line:
v2: updated to apply to latest linux-next
http://kernelnewbies.org/PatchTipsAndTricks
Great, thanks, will do! Very useful link!
Best,
--
Lorenzo Stoakes
https
these on the lines I'm changing, will fix these!
Best,
--
Lorenzo Stoakes
https:/ljs.io
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ
This patch removes the unused hw712_fillrect function. This patch fixes
the following sparse warning:-
drivers/staging/sm750fb/sm750_accel.c:95:5: warning: symbol 'hw712_fillrect'
was not declared. Should it be static?
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging
'
was not declared. Should it be static?
drivers/staging/sm750fb/ddk750_hwi2c.c:160:14: warning: symbol 'hwI2CReadData'
was not declared. Should it be static?
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/sm750fb/ddk750_hwi2c.c | 6 +++---
drivers/staging/sm750fb/ddk750_swi2c.c
byte-sized. This
fixes the following sparse warnings:-
drivers/staging/sm750fb/sm750_cursor.c:113:19: warning: cast removes address
space of expression
drivers/staging/sm750fb/sm750_cursor.c:204:19: warning: cast removes address
space of expression
Signed-off-by: Lorenzo Stoakes lstoa
: warning: incorrect type in argument 1
(different address spaces)
drivers/staging/sm750fb/sm750.c:1154:9: warning: incorrect type in argument 1
(different address spaces)
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/sm750fb/sm750.c | 12 ++--
1 file changed, 6
This patch removes the unnecessary spinlock helper function and instead
calls spin_lock and spin_unlock directly.
This does *not* resolve sparse warnings about context imbalances but these are
spurious.
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/sm750fb/sm750.c | 53
patch which applies
the ANSI C function prototype fixes having already been applied.
Best,
--
Lorenzo Stoakes
https:/ljs.io
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
things a little more sanely in time, the hard way :)
Best,
--
Lorenzo Stoakes
https:/ljs.io
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
*to me* you wanted me to change that, given you
asked me *not* to redo it explicitly (which I assumed applied to the
message too) - apologies if I misinterpreted this!
Best,
--
Lorenzo Stoakes
https:/ljs.io
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
byte-sized. This
fixes the following sparse warnings:-
drivers/staging/sm750fb/sm750_cursor.c:113:19: warning: cast removes address
space of expression
drivers/staging/sm750fb/sm750_cursor.c:204:19: warning: cast removes address
space of expression
Signed-off-by: Lorenzo Stoakes lstoa
/staging/sm750fb/sm750.c:1154:9: warning: incorrect type in argument 1
(different address spaces)
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
v2: Whitespace fixups, updated commit message
drivers/staging/sm750fb/sm750.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff
This patch removes the unused hw712_fillrect function. This patch fixes
the following sparse warning:-
drivers/staging/sm750fb/sm750_accel.c:95:5: warning: symbol 'hw712_fillrect'
was not declared. Should it be static?
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging
/staging/sm750fb/sm750.c:1154:9: warning: incorrect type in argument 1
(different address spaces)
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/sm750fb/sm750.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b
'hwI2CWriteData'
was not declared. Should it be static?
drivers/staging/sm750fb/ddk750_hwi2c.c:160:14: warning: symbol 'hwI2CReadData'
was not declared. Should it be static?
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/sm750fb/ddk750_hwi2c.c | 6 +++---
1 files changed, 3
This patch removes the unnecessary spinlock helper function and instead
calls spin_lock and spin_unlock directly.
This does *not* resolve sparse warnings about context imbalances but these are
spurious.
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/sm750fb/sm750.c | 53
byte-sized. This
fixes the following sparse warnings:-
drivers/staging/sm750fb/sm750_cursor.c:113:19: warning: cast removes address
space of expression
drivers/staging/sm750fb/sm750_cursor.c:204:19: warning: cast removes address
space of expression
Signed-off-by: Lorenzo Stoakes lstoa
to
apply against staging-testing.
Best,
--
Lorenzo Stoakes
https:/ljs.io
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
changes.
Let me know if you'd like this done differently!
Best,
--
Lorenzo Stoakes
https:/ljs.io
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please
On 18 March 2015 at 11:25, Dan Carpenter dan.carpen...@oracle.com wrote:
Could you read your patches again and find other similar white space
issues.
Done.
Best,
--
Lorenzo Stoakes
https:/ljs.io
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
,
--
Lorenzo Stoakes
https:/ljs.io
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This patch fixes the following sparse warning:-
drivers/staging/sm750fb/ddk750_help.c: warning: incorrect type in assignment
(different address spaces)
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/sm750fb/ddk750_chip.h | 4 +++-
drivers/staging/sm750fb/ddk750_help.c
resubmits of unchanged code to be confusing. I am absolutely happy to
do whatever works for Greg of course!
Best,
--
Lorenzo Stoakes
https:/ljs.io
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
fixes the following sparse warning:-
drivers/staging/sm750fb/ddk750_help.c:12:17: warning: incorrect type in
assignment (different address spaces)
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/sm750fb/ddk750_chip.h | 4 +++-
drivers/staging/sm750fb/ddk750_help.c | 4
interacts with it, so I felt
that should perhaps be a separate patch.
I'd love to additionally provide some further patches to help out with
issues here too, incidentally! I will try to prepare some further
patches tonight in this vein.
--
Lorenzo Stoakes
https:/ljs.io
--
To unsubscribe from
of the
lynx_share-pvReg field which is passed to the ddk750_set_mmio method.
As a consequence, this patch fixes the following sparse warning:-
drivers/staging/sm750fb/ddk750_help.c:12:17: warning: incorrect type in
assignment (different address spaces)
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
? In
that case just fold it in and don't do the temporary casting.
The next patch after that could get rid of all the ramaining volatile
keywords.
It seems that we can in fact fix this problem with a single additional
change, I will submit a v2 shortly.
Best,
--
Lorenzo Stoakes
https:/ljs.io
'
was not declared. Should it be static?
drivers/staging/sm750fb/ddk750_hwi2c.c:160:14: warning: symbol 'hwI2CReadData'
was not declared. Should it be static?
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/sm750fb/ddk750_hwi2c.c | 6 +++---
drivers/staging/sm750fb/ddk750_swi2c.c
Unfortunately this change involves code (and comment) duplication.
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/sm750fb/sm750.c | 76 +++--
1 file changed, 43 insertions(+), 33 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b
: warning: incorrect type in argument 1
(different address spaces)
drivers/staging/sm750fb/sm750.c:1154:9: warning: incorrect type in argument 1
(different address spaces)
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/sm750fb/sm750.c | 12 ++--
1 file changed, 6
in the updated version of this patch.
Best,
--
Lorenzo Stoakes
https:/ljs.io
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
. Should it be static?
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/sm750fb/sm750_accel.c | 2 +-
drivers/staging/sm750fb/sm750_accel.h | 7 +++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750_accel.c
b/drivers/staging/sm750fb
'sii164GetDeviceID'
drivers/staging/sm750fb/ddk750_dvi.c:65:31: warning: non-ANSI function
declaration of function 'dviGetVendorID'
drivers/staging/sm750fb/ddk750_dvi.c:85:31: warning: non-ANSI function
declaration of function 'dviGetDeviceID'
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers
byte-sized. This
fixes the following sparse warnings:-
drivers/staging/sm750fb/sm750_cursor.c:113:19: warning: cast removes address
space of expression
drivers/staging/sm750fb/sm750_cursor.c:204:19: warning: cast removes address
space of expression
Signed-off-by: Lorenzo Stoakes lstoa
when I have
the opportunity to do so :)
--
Lorenzo Stoakes
https:/ljs.io
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
of the
lynx_share-pvReg field which is passed to the ddk750_set_mmio method.
As a consequence, this patch fixes the following sparse warning:-
drivers/staging/sm750fb/ddk750_help.c:12:17: warning: incorrect type in
assignment (different address spaces)
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
,
--
Lorenzo Stoakes
https:/ljs.io
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
'
was not declared. Should it be static?
drivers/staging/sm750fb/ddk750_hwi2c.c:160:14: warning: symbol 'hwI2CReadData'
was not declared. Should it be static?
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/sm750fb/ddk750_hwi2c.c | 6 +++---
drivers/staging/sm750fb/ddk750_swi2c.c
This patch removes the unnecessary spinlock helper function and instead
calls spin_lock and spin_unlock directly.
This does *not* resolve sparse warnings about context imbalances but these are
spurious.
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/sm750fb/sm750.c | 47
This patch removes the unused hw712_fillrect function. This patch fixes
the following sparse warning:-
drivers/staging/sm750fb/sm750_accel.c:95:5: warning: symbol 'hw712_fillrect'
was not declared. Should it be static?
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging
On 11 March 2015 at 10:57, Sudip Mukherjee sudipm.mukher...@gmail.com wrote:
but function prototype still remains in sm750_accel.h
No it doesn't, v2 of patch 3 in the series no longer puts it there :)
--
Lorenzo Stoakes
https:/ljs.io
--
To unsubscribe from this list: send the line unsubscribe
a mistake :) I'll fix it shortly.
anyways, like Dan said, delete this function, its not used anywhere.
it will not be used also, i missed removing this function from the
vendor crude drver.
Will do!
Best,
--
Lorenzo Stoakes
https:/ljs.io
--
To unsubscribe from this list: send the line
presumptuous of me to ask, perhaps you might be
able to check patches that are successfully merged into
staging-testing?
Best,
--
Lorenzo Stoakes
https:/ljs.io
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo
I expose this function in the header file. I'll update
this patch not to touch hw712_fillrect then remove it in a later patch
altogether.
Best,
--
Lorenzo Stoakes
https:/ljs.io
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
the patch as required if your
patch series is applied first, I will keep an eye out for this,
additionally if you ping me if this occurs I will fix it right away.
Best,
--
Lorenzo Stoakes
https:/ljs.io
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
in ddk750_help.h.
--
Lorenzo Stoakes
https:/ljs.io
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This patch fixes the following sparse warning:-
drivers/staging/sm750fb/ddk750_help.c: warning: incorrect type in assignment
(different address spaces)
In addition it eliminates an unnecessary volatile.
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/sm750fb
of half a thing per patch.
regards,
dan carpenter
Sure, sorry saw the patch as purely a sparse fixup, will adapt to be
an overall mmio750 cleanup and resubmit!
Best,
--
Lorenzo Stoakes
https:/ljs.io
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
a look at the --in-reply-to flag.
Will do, apologies for the mess up, it makes sense that the v2's
should be replies to their respective v1s.
Best,
--
Lorenzo Stoakes
https:/ljs.io
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
On 23 March 2015 at 13:14, Sudip Mukherjee sudipm.mukher...@gmail.com wrote:
On Mon, Mar 23, 2015 at 01:02:52PM +, Lorenzo Stoakes wrote:
On 23 March 2015 at 12:55, Sudip Mukherjee sudipm.mukher...@gmail.com
wrote:
and you need to send v3 now :(
your series is not applying. Please
On 23 March 2015 at 12:55, Sudip Mukherjee sudipm.mukher...@gmail.com wrote:
and you need to send v3 now :(
your series is not applying. Please refresh it against staging-testing
Applies to staging-testing for me. Are you sure you're applying the
correct 'RESEND 2' patches?
--
Lorenzo
On 23 March 2015 at 13:16, Lorenzo Stoakes lstoa...@gmail.com wrote:
I've tried applying resend 2 patches to both linux-next and
staging-testing in Greg's staging.git tree, they apply in both places.
Sigh. Checking the emails I actually sent, I seem to *somehow* have
sent old files
On 23 March 2015 at 13:21, Lorenzo Stoakes lstoa...@gmail.com wrote:
Sigh. Checking the emails I actually sent, I seem to *somehow* have
sent old files in this resend :S I really don't know how this
happened. My copies of the patches all apply perfectly correctly, but
these are not the ones I
Thanks for that, appreciated!
Best,
--
Lorenzo Stoakes
https:/ljs.io
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
gcov_info compatible with GCC 5.1.
Secondly, a corresponding counter function __gcov_merge_icall_topn (Top
N value tracking for indirect calls) is included in base.c with the
other gcov counters unused for kernel profiling.
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
kernel/gcov/base.c
On 3 January 2017 at 21:36, Michal Hocko <mho...@kernel.org> wrote:
> On Tue 03-01-17 21:14:20, Lorenzo Stoakes wrote:
>> Just a gentle ping on this :) I think this might be a slightly
>> abandoned corner of the kernel so not sure who else to ping to get
>> this moving
On 6 January 2017 at 07:09, Lorenzo Stoakes <lstoa...@gmail.com> wrote:
>
> Adding Andrew, as this may be another less active corner of the corner,
> thanks!
Hi all,
Thought I'd also give this one a gentle nudge now the merge window has
re-opened, Andrew - are you ok to pic
ast() in all such cases? These patches were simply a
mechanical/cautious replacement for code that is more or less exactly
equivalent but if this would make sense perhaps it'd be worth using
gup_fast() where possible?
--
Lorenzo Stoakes
https://ljs.io
Moving from get_user_pages() to get_user_pages_unlocked() simplifies the code
and takes advantage of VM_FAULT_RETRY functionality when faulting in pages.
Signed-off-by: Lorenzo Stoakes <lstoa...@gmail.com>
---
drivers/gpu/drm/via/via_dmablit.c | 10 +++---
1 file changed, 3 insertions
[adding lkml, accidentally excluded!]
On 11 September 2016 at 23:54, Lorenzo Stoakes <lstoa...@gmail.com> wrote:
> The NUMA balancing logic uses an arch-specific PROT_NONE page table flag
> defined
> by pte_protnone() or pmd_protnone() to mark PTEs or huge page PMDs
On Fri, Oct 07, 2016 at 08:34:15AM -0700, Linus Torvalds wrote:
> Would you be willing to look at doing that kind of purely syntactic,
> non-semantic cleanup first?
Sure, more than happy to do that! I'll work on a patch for this.
> I think that if we end up having the FOLL_FORCE semantics, we're
On Fri, Oct 07, 2016 at 11:16:26AM -0700, Hugh Dickins wrote:
>
> Adding Jan Kara (and Dave Hansen) to the Cc list: I think they were
> pursuing get_user_pages() cleanups last year (which would remove the
> force option from most callers anyway), and I've lost track of where
> that all got to.
On Sun, Sep 25, 2016 at 03:50:21PM -0700, Linus Torvalds wrote:
> I'd really like to re-open the "drop FOLL_FORCE entirely" discussion,
> because the thing really is disgusting.
>
> I realize that debuggers etc sometimes would want to punch through
> PROT_NONE protections, and I also realize that
This is a trivial fix to correct upper bound addresses to always be
inclusive. Previously, the majority of ranges specified were inclusive with a
small minority specifying an exclusive upper bound. This patch fixes this
inconsistency.
Signed-off-by: Lorenzo Stoakes <lstoa...@gmail.
This patch prefixes a '!' to a /* __ASSEMBLY__ */ comment following an #ifndef
__ASSEMBLY__ block.
Signed-off-by: Lorenzo Stoakes <lstoa...@gmail.com>
---
include/asm-generic/page.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/asm-generic/page.h b/inclu
Just a quick ping on this, let me know if you need anything more from me!
Thanks, Lorenzo
On Sun, Sep 11, 2016 at 11:54:25PM +0100, Lorenzo Stoakes wrote:
> The NUMA balancing logic uses an arch-specific PROT_NONE page table flag
> defined
> by pte_protnone() or pmd_protnone() to
On Wed, Oct 26, 2016 at 05:12:07PM -0700, Andrew Morton wrote:
> It's a KVM patch and should have been called "kvm: remove ...".
> Possibly the KVM maintainers will miss it for this reason.
>
Ah, indeed, however I think given my and Michal's discussion in this thread
regarding adjusting
, this flag was originally silently dropped by 1e9877902dc7e
("mm/gup: Introduce get_user_pages_remote()"), so this appears to have been
unintentional and reintroducing it is therefore not an issue.
Signed-off-by: Lorenzo Stoakes <lstoa...@gmail.com>
---
include/linux/mm.h |
parameters which were removed in c12d2da5
("mm/gup: Remove the macro overload API migration helpers from the get_user*()
APIs"), this patch fixes this also.
Signed-off-by: Lorenzo Stoakes <lstoa...@gmail.com>
---
mm/gup.c | 16 ++--
1 file changed, 6 insertions(+), 10 de
-by: Lorenzo Stoakes <lstoa...@gmail.com>
---
virt/kvm/async_pf.c | 7 ---
virt/kvm/kvm_main.c | 5 ++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/virt/kvm/async_pf.c b/virt/kvm/async_pf.c
index 8035cc1..e8c832c 100644
--- a/virt/kvm/async_pf.c
+++ b/virt/kvm/asyn
The holdout for unexporting __get_user_pages_unlocked() is its invocation in
mm/process_vm_access.c: process_vm_rw_single_vec(), as this definitely _does_
seem to invoke VM_FAULT_RETRY behaviour which get_user_pages_remote() will not
trigger if we were to replace it with the latter.
I'm not sure
- get_user_pages_unlocked() if the current
task and memory descriptor are referenced, or get_user_pages_remote() if other
task/memory descriptors are referenced (having acquiring mmap_sem.)
Lorenzo Stoakes (2):
mm: add locked parameter to get_user_pages_remote()
mm: unexport __get_user_pages_unlocked
1 - 100 of 291 matches
Mail list logo
