Re: [PATCH] ARM: convert arm/arm64 arch timer to use CLKSRC_OF init

2013-03-21 Thread Marc Zyngier
On 21/03/13 11:06, Mark Rutland wrote: > Hi Rob, > > (adding Marc to Cc as he may have comments). > > On Wed, Mar 20, 2013 at 10:34:35PM +, Rob Herring wrote: >> From: Rob Herring >> >> This converts arm and arm64 to use CLKSRC_OF DT based initialization for >> the arch timer. A new function

Re: [PATCH] ARM: arch_timer: Silence debug preempt warnings

2013-04-05 Thread Marc Zyngier
retrieve the clockevent unconditionally. We're only going to >> actually use the pointer in non-preemptible context though, >> so use __this_cpu_ptr() instead to avoid the preemptible checks >> and silence the warning. >> >> Cc: Mark Rutland >> Cc: Marc

Re: [PATCH v9 00/13] Per sub-architecture SMP operations

2012-09-13 Thread Marc Zyngier
On 12/09/12 15:58, Arnd Bergmann wrote: > As I promised at the ARM mini summit, I've updated Marc's series > for smp operations according to my complaints. Unfortunately, > I could not find version 7 of the patches when I started this, > so I based my work on version 6 and had to redo the same > ch

Re: [PATCH v4 02/24] xen/arm: hypercalls

2012-09-14 Thread Marc Zyngier
On 14/09/12 12:13, Stefano Stabellini wrote: > Use r12 to pass the hypercall number to the hypervisor. > > We need a register to pass the hypercall number because we might not > know it at compile time and HVC only takes an immediate argument. > > Among the available registers r12 seems to be the

Re: [PATCH v4 16/24] xen: clear IRQ_NOAUTOEN and IRQ_NOREQUEST

2012-09-14 Thread Marc Zyngier
On 14/09/12 12:13, Stefano Stabellini wrote: > Reset the IRQ_NOAUTOEN and IRQ_NOREQUEST flags that are enabled by > default on ARM. If IRQ_NOAUTOEN is set, __setup_irq doesn't call > irq_startup, that is responsible for calling irq_unmask at startup time. > As a result event channels remain masked.

Re: [PATCH v4 02/24] xen/arm: hypercalls

2012-09-14 Thread Marc Zyngier
On 14/09/12 15:02, Stefano Stabellini wrote: > On Fri, 14 Sep 2012, Marc Zyngier wrote: >>> +/* HVC 0xEA1 */ >>> +#ifdef CONFIG_THUMB2_KERNEL >>> +#define xen_hvc .word 0xf7e08ea1 >>> +#else >>> +#define xen_hvc .word 0xe140ea71 >>> +#e

Re: [PATCH v4 16/24] xen: clear IRQ_NOAUTOEN and IRQ_NOREQUEST

2012-09-14 Thread Marc Zyngier
On 14/09/12 15:13, Stefano Stabellini wrote: > On Fri, 14 Sep 2012, Marc Zyngier wrote: >> On 14/09/12 12:13, Stefano Stabellini wrote: >>> Reset the IRQ_NOAUTOEN and IRQ_NOREQUEST flags that are enabled by >>> default on ARM. If IRQ_NOAUTOEN is set, __setup_irq doesn&#

Re: [PATCH v4 16/24] xen: clear IRQ_NOAUTOEN and IRQ_NOREQUEST

2012-09-14 Thread Marc Zyngier
On 14/09/12 15:28, Stefano Stabellini wrote: > On Fri, 14 Sep 2012, Marc Zyngier wrote: >> On 14/09/12 15:13, Stefano Stabellini wrote: >>> On Fri, 14 Sep 2012, Marc Zyngier wrote: >>>> On 14/09/12 12:13, Stefano Stabellini wrote: >>>>> Reset the

Re: [PATCH 03/17] ARM: pxa: Wunused-result warning in viper board file

2012-10-02 Thread Marc Zyngier
t; > arch/arm/mach-pxa/viper.c: In function 'viper_tpm_setup': > arch/arm/mach-pxa/viper.c:771:10: warning: ignoring return value of > 'kstrtoul', declared with attribute warn_unused_result [-Wunused-result] > > Signed-off-by: Arnd Bergmann > Cc: Haojian Zhuang

Re: ERROR: "read_current_timer" [fs/ext4/ext4.ko] undefined

2012-10-23 Thread Marc Zyngier
On 23/10/12 15:48, Kukjin Kim wrote: > Hi all, > > Now, v3.7-rc2 happens following build error with s3c2410_defconfig... > > ERROR: "read_current_timer" [fs/ext4/ext4.ko] undefined! > make[2]: *** [__modpost] Error 1 > make[1]: *** [modules] Error 2 > make[1]: *** Waiting for unfinished jobs

Re: [PATCH 2/4] PF: Move architecture specifics to the backends

2013-07-08 Thread Marc Zyngier
On 2013-07-05 21:55, Dominik Dingel wrote: Current common codes uses PAGE_OFFSET to indicate a bad host virtual address. As this check won't work on architectures that don't map kernel and user memory into the same address space (e.g. s390), it is moved into architcture specific code. Signed-of

[PATCH] arm64: use common reboot infrastructure

2013-07-11 Thread Marc Zyngier
Moll Cc: Will Deacon Cc: Catalin Marinas Signed-off-by: Marc Zyngier --- arch/arm64/include/asm/system_misc.h | 3 ++- arch/arm64/kernel/process.c | 2 +- kernel/reboot.c | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/arm64/include/asm

Re: [PATCH 1/3] arm: kvm: clamp NR_VCPUS to MAX_VCPUS

2013-09-14 Thread Marc Zyngier
On 2013-09-14 13:14, Alexander Graf wrote: Am 14.09.2013 um 07:10 schrieb Andrew Jones : Signed-off-by: Andrew Jones --- arch/arm/kvm/arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/kvm/arm.c b/arch/arm/kvm/arm.c index 741f66a2edbd7..9ebf8ac3a12ff 100644 --- a

Re: [PATCH 2/3] arm32: kvm: rename CONFIG_KVM_ARM_MAX_VCPUS

2013-09-16 Thread Marc Zyngier
On 15/09/13 10:30, Gleb Natapov wrote: > On Sat, Sep 14, 2013 at 02:10:55PM +0200, Andrew Jones wrote: >> Drop the _ARM_ part of the name. We can then introduce a config option >> like this to aarch64 and other arches using the same name - allowing >> grep to show them all. Also update the help tex

Re: [PATCH 3/4] Add physical count arch timer support for clocksource in ARMv7.

2013-09-16 Thread Marc Zyngier
Hi Maxime, On 14/09/13 13:05, [email protected] wrote: > Hi Marc, Fan, > > On Fri, Sep 13, 2013 at 10:30:49AM +0100, Marc Zyngier wrote: >> On 13/09/13 09:49, cinifr wrote: >>> On 13 September 2013 00:39, Marc Zyngier >>> wrote: I am wonderin

Re: [PATCH 2/3] arm32: kvm: rename CONFIG_KVM_ARM_MAX_VCPUS

2013-09-16 Thread Marc Zyngier
On 16/09/13 09:32, Gleb Natapov wrote: > On Mon, Sep 16, 2013 at 09:09:27AM +0100, Marc Zyngier wrote: >> On 15/09/13 10:30, Gleb Natapov wrote: >>> On Sat, Sep 14, 2013 at 02:10:55PM +0200, Andrew Jones wrote: >>>> Drop the _ARM_ part of the name. We can then intro

Re: [PATCH 3/4] Add physical count arch timer support for clocksource in ARMv7.

2013-09-12 Thread Marc Zyngier
On 12/09/13 17:07, cinifr wrote: >> This cannot be a compile-time option as above in a multiplatform build. >> Other paltforms (e.g. KVM guests) *must* use the virtual counters to get >> any semblance of a consistent view of time. > Yes I accept compile-time option is not perfect in my pre email,

Re: [PATCH 3/4] Add physical count arch timer support for clocksource in ARMv7.

2013-09-13 Thread Marc Zyngier
On 13/09/13 09:49, cinifr wrote: > On 13 September 2013 00:39, Marc Zyngier wrote: >> On 12/09/13 17:07, cinifr wrote: >>>> This cannot be a compile-time option as above in a multiplatform build. >>>> Other paltforms (e.g. KVM guests) *must* use the virtual counte

Re: [PATCH 3/4] Add physical count arch timer support for clocksource in ARMv7.

2013-09-13 Thread Marc Zyngier
On 13/09/13 14:09, cinifr wrote: >> I urge you to read the ARM ARM, and specifically the section dedicated >> to trapping access to CP15 operations. If you do, you'll quickly notice >> that you *cannot* trap accesses to the timer subsystem. >> > I read it again. The ARMv7 manual said "Is accessible

Re: [PATCH 1/1] arm64: X-Gene AHBC platform bus driver

2013-09-27 Thread Marc Zyngier
Hi Feng, On 2013-09-27 02:19, Feng Kan wrote: This driver setup the AHBC for SPI and SD drivers to use. That's a bit thin for a description. What is AHBC? How does it relate to SPI and SD? How is it used? Signed-off-by: Feng Kan --- arch/arm64/boot/dts/apm-storm.dtsi |6 + drivers/b

Re: [RFC PATCH 1/6] DRIVERS: IRQCHIP: IRQ-GIC: Add support for routable irqs

2013-09-30 Thread Marc Zyngier
On 30/09/13 14:59, Sricharan R wrote: > In some socs the gic can be preceded by a crossbar IP which > routes the peripheral interrupts to the gic inputs. The peripheral > interrupts are associated with a fixed crossbar input line and the > crossbar routes that to one of the free gic input line. >

Re: [RFC PATCH 1/6] DRIVERS: IRQCHIP: IRQ-GIC: Add support for routable irqs

2013-09-30 Thread Marc Zyngier
On 30/09/13 15:22, Santosh Shilimkar wrote: > On Monday 30 September 2013 10:16 AM, Marc Zyngier wrote: >> On 30/09/13 14:59, Sricharan R wrote: >>> In some socs the gic can be preceded by a crossbar IP which >>> routes the peripheral interrupts to the gic inputs. The pe

Re: [PATCH 5/9] clocksource: tegra: Enable ARM arch_timer with TSC

2012-12-20 Thread Marc Zyngier
On 20/12/12 09:44, Hiroshi Doyu wrote: > Add platform enabler for ARM arch_timer(TSC). TSC is more fine grained > timer than TMR0. If it's available, it will be used for clock source > and sched_clock. Otherwise, TMR0 is used. In any case TMR0 is > necessary for clock event. > > Signed-off-by: Hir

Re: [PATCH 3/9] ARM: tegra: # of CPU cores detection w/ & w/o HAVE_ARM_SCU

2012-12-20 Thread Marc Zyngier
On 20/12/12 09:44, Hiroshi Doyu wrote: > The method to detect the number of CPU cores on Cortex-A9 MPCore and > Cortex-A15 MPCore is different. On Cortex-A9 MPCore we can get this > information from the Snoop Control Unit(SCU). On Cortex-A15 MPCore we > have to read it from the system coprocessor(C

Re: [PATCH 6/9] ARM: dt: tegra114: Add new SoC base, Tegra 114 SoC

2012-12-20 Thread Marc Zyngier
On 20/12/12 09:44, Hiroshi Doyu wrote: > Initial support for Tegra 114 SoC. This is expected to be included in > the board DTS files, Tegra 114 SoC based evaluation board family. > > Signed-off-by: Hiroshi Doyu You definitely need to add some cpu nodes here, or get someone to merge the NR_CPUS=0

Re: [PATCH 3/9] ARM: tegra: # of CPU cores detection w/ & w/o HAVE_ARM_SCU

2012-12-20 Thread Marc Zyngier
On 20/12/12 11:26, Hiroshi Doyu wrote: > Marc Zyngier wrote @ Thu, 20 Dec 2012 12:17:08 +0100: > >> On 20/12/12 09:44, Hiroshi Doyu wrote: >>> The method to detect the number of CPU cores on Cortex-A9 MPCore and >>> Cortex-A15 MPCore is different. On Co

Re: [PATCH 5/9] clocksource: tegra: Enable ARM arch_timer with TSC

2012-12-20 Thread Marc Zyngier
On 20/12/12 11:57, Hiroshi Doyu wrote: > Marc Zyngier wrote @ Thu, 20 Dec 2012 12:01:15 +0100: > >> On 20/12/12 09:44, Hiroshi Doyu wrote: >>> Add platform enabler for ARM arch_timer(TSC). TSC is more fine grained >>> timer than TMR0. If it's available, it wi

Re: [PATCH 5/9] clocksource: tegra: Enable ARM arch_timer with TSC

2012-12-20 Thread Marc Zyngier
On 20/12/12 12:22, Peter De Schrijver wrote: > + > + /* CNTFRQ */ > + asm("mcr p15, 0, %0, c14, c0, 0\n" : : "r" (freq)); > + asm("mrc p15, 0, %0, c14, c0, 0\n" : "=r" (val)); > + BUG_ON(val != freq); This is scary. CNTFRQ is only writable from secure mode, and will >>

Re: [PATCH 5/9] clocksource: tegra: Enable ARM arch_timer with TSC

2012-12-20 Thread Marc Zyngier
On 20/12/12 12:55, Peter De Schrijver wrote: > On Thu, Dec 20, 2012 at 01:33:42PM +0100, Marc Zyngier wrote: >> On 20/12/12 12:22, Peter De Schrijver wrote: >>>>>>> + >>>>>>> + /* CNTFRQ */ >>>>>>> + asm("m

Re: [PATCH 5/9] clocksource: tegra: Enable ARM arch_timer with TSC

2012-12-20 Thread Marc Zyngier
On 20/12/12 13:25, Hiroshi Doyu wrote: > Marc Zyngier wrote @ Thu, 20 Dec 2012 13:05:45 +0100: > >> On 20/12/12 11:57, Hiroshi Doyu wrote: >>> Marc Zyngier wrote @ Thu, 20 Dec 2012 12:01:15 +0100: >>> >>>> On 20/12/12 09:44, Hiroshi Doyu wrote: >>

Re: [PATCH 5/9] clocksource: tegra: Enable ARM arch_timer with TSC

2012-12-20 Thread Marc Zyngier
On 20/12/12 14:42, Hiroshi Doyu wrote: > Marc Zyngier wrote @ Thu, 20 Dec 2012 14:32:21 +0100: > >> On 20/12/12 12:55, Peter De Schrijver wrote: >>> On Thu, Dec 20, 2012 at 01:33:42PM +0100, Marc Zyngier wrote: >>>> On 20/12/1

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-18 Thread Marc Zyngier
Hi Pranavkumar, On Thu, 18 Apr 2013 11:22:24 +0530, PranavkumarSawargaonkar wrote: > From: Pranavkumar Sawargaonkar > > This patch implements early printk support for virtio-mmio console devices > without using any hypercalls. > > The current virtio early printk code in kernel expects that hyp

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-18 Thread Marc Zyngier
On Thu, 18 Apr 2013 12:47:18 +0530, Pranavkumar Sawargaonkar wrote: > Hi Marc, > > On 18 April 2013 12:19, Marc Zyngier wrote: > >> Hi Pranavkumar, >> >> On Thu, 18 Apr 2013 11:22:24 +0530, PranavkumarSawargaonkar >> wrote: >> > From: Pranavkumar

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-18 Thread Marc Zyngier
On Thu, 18 Apr 2013 09:30:52 +0100, Peter Maydell wrote: > On 18 April 2013 07:49, Marc Zyngier wrote: >> If you need an early console, why not simply wire the 8250 emulation in >> kvmtool to be useable from the MMIO bus? I reckon this would solve your >> problem

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-18 Thread Marc Zyngier
On Thu, 18 Apr 2013 11:25:56 -0400, Christopher Covington wrote: > Hi Pranavkumar, > > On 04/18/2013 01:52 AM, PranavkumarSawargaonkar wrote: >> From: Pranavkumar Sawargaonkar >> >> This patch implements early printk support for virtio-mmio console >> devices >> without using any hypercalls. >

Re: linux-next: manual merge of the arm64-hugepages tree with the arm64 tree

2013-06-17 Thread Marc Zyngier
On 17/06/13 09:42, Steve Capper wrote: > On Mon, Jun 17, 2013 at 05:45:28PM +1000, Stephen Rothwell wrote: >> Hi Steve, > > Hi Stephen, > >> >> Today's linux-next merge of the arm64-hugepages tree got conflicts in >> arch/arm64/include/asm/pgtable-hwdef.h and >> arch/arm64/include/asm/pgtable.h b

Re: [PATCH] rtc-ds1302: handle write protection

2013-05-30 Thread Marc Zyngier
On Thu, 30 May 2013 14:14:42 +0400, Sergey Yanovich wrote: > On Wed, 2013-05-29 at 15:53 -0700, Andrew Morton wrote: >> On Tue, 21 May 2013 03:21:30 +0400 Sergey Yanovich >> wrote: >> @@ -321,6 +326,7 @@ static int ds1302_rtc_remove(struct platform_device >> *pdev) >> > { >> >struct rtc_devi

Re: [PATCH] rtc-ds1302: handle write protection

2013-05-31 Thread Marc Zyngier
before the driver tries to write time > and re-disables when time data is written. > > Signed-off-by: Sergey Yanovich FWIW, Acked-by: Marc Zyngier M. -- Who you jivin' with that Cosmik Debris? -- To unsubscribe from this list: send the line "unsubscribe linux-kerne

Re: [PATCHv6 00/11] Remove ARM local timer API

2013-06-03 Thread Marc Zyngier
still missing acks from Kukjin and Barry. I don't think that should hold off the patch series. It's been tested on most other platforms over the course of several months. If the platform maintainers aren't responsive enough, fixing the issues becomes their problem. FWIW, have my Acked-by

Re: [PATCHv6 00/11] Remove ARM local timer API

2013-06-03 Thread Marc Zyngier
On Mon, 03 Jun 2013 13:00:37 -0700, Stephen Boyd wrote: > On 06/03/13 01:54, Marc Zyngier wrote: >> On 31/05/13 23:16, Stephen Boyd wrote: >>> On 05/31, John Stultz wrote: >>>> On 05/31/2013 10:45 AM, Stephen Boyd wrote: >>>>> Comments have bee

Re: [PATCH v2 0/2] ARM: Remove any correlation between IPC and BogoMips value

2013-06-21 Thread Marc Zyngier
> even being merged! For the whole series, and cheering loudly: Acked-by: Marc Zyngier M. -- Jazz is not dead. It just smells funny... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordom

Re: [PATCH v6 4/8] ARM: Add .init_platform() callback to machine descriptor

2013-06-21 Thread Marc Zyngier
On 21/06/13 01:35, Tomasz Figa wrote: Hi Tomasz, > Most ARM platforms have parts that should be initialized as early as > possible, which usually means as soon as memory management (kmalloc, > ioremap) starts to work, > > However, currently there is no appropriate callback in machine_desc > stru

Re: [PATCH] ARM: arch timer: Set the TVAL before timer is enabled

2013-06-24 Thread Marc Zyngier
eserve a comment in the code so people don't get the idea it can be reordered to save the extra write? Other than that, and FWIW: Acked-by: Marc Zyngier M. -- Jazz is not dead. It just smells funny... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&

Re: [PATCH v2] arm64: kernel: compiling issue, need delete read_current_timer().

2013-06-10 Thread Marc Zyngier
- >>> #endif >>> diff --git a/arch/arm64/kernel/time.c b/arch/arm64/kernel/time.c >>> index a551f88..03dc371 100644 >>> --- a/arch/arm64/kernel/time.c >>> +++ b/arch/arm64/kernel/time.c >>> @@ -68,12 +68,6 @@ unsigned long long notrace sched_clock(void)

Re: [PATCH 3/4] xen: move the xenvm machine to mach-virt

2013-03-22 Thread Marc Zyngier
On 21/03/13 19:16, Stefano Stabellini wrote: > xenvm is based on mach-vexpress, move it to mach-virt. > > Signed-off-by: Stefano Stabellini > CC: [email protected] > CC: [email protected] > CC: [email protected] > CC: [email protected] Awesome! Acked-by: Marc Zyngie

Re: [PATCH 05/10] ARM: sunxi: Add Allwinner A31 DTSI

2013-07-30 Thread Marc Zyngier
Hi Maxime, On 23/07/13 23:25, Maxime Ripard wrote: > Signed-off-by: Maxime Ripard > --- > arch/arm/boot/dts/Makefile | 3 +- > arch/arm/boot/dts/sun6i-a31.dtsi | 155 > +++ > 2 files changed, 157 insertions(+), 1 deletion(-) > create mode 100644 arch

Re: [PATCH v3 1/6] ARM/ARM64: arch_timer: add macros for bits in control register

2013-08-14 Thread Marc Zyngier
Hi Daniel, On 2013-08-14 09:50, Daniel Lezcano wrote: On 08/13/2013 07:29 PM, Sudeep KarkadaNagesha wrote: From: Sudeep KarkadaNagesha Add macros to describe the bitfields in the ARM architected timer control register to make code easy to understand. Cc: Catalin Marinas Reviewed-by: Lorenzo

Re: [PATCH] virtio-spec: Define virtio-mmio registers as LE

2013-03-01 Thread Marc Zyngier
On 14/02/13 10:54, Pawel Moll wrote: > To solve the never-ending confusions between hosts and guests > of different endianess, define all virtio-mmio registers as LE. > > This change should be safe at this stage, because no known > working mixed-endian system exists so there is virtually no > risk

Re: [PATCH] virtio-spec: Define virtio-mmio registers as LE

2013-03-01 Thread Marc Zyngier
On 01/03/13 10:50, Pawel Moll wrote: > On Fri, 2013-03-01 at 10:41 +0000, Marc Zyngier wrote: >> On 14/02/13 10:54, Pawel Moll wrote: >>> To solve the never-ending confusions between hosts and guests >>> of different endianess, define all virtio-mmio registers as LE. &g

Re: [PATCH] virtio-spec: Define virtio-mmio registers as LE

2013-03-01 Thread Marc Zyngier
On 01/03/13 12:37, Pawel Moll wrote: > On Fri, 2013-03-01 at 11:21 +0000, Marc Zyngier wrote: >>> Having said that, Rusty was contemplating enforcing LE config space in >>> the new PCI layout... >> >> I wouldn't complain about that, and would like to see a s

Re: [PATCHv2] ARM: arch_timer: Silence debug preempt warnings

2013-04-06 Thread Marc Zyngier
l cases. We're only going to > actually use the pointer in non-preemptible context though, so > push the this_cpu_ptr() access down into the cases to force the > checks to occur only in non-preemptible contexts. > > Cc: Mark Rutland > Cc: Marc Zyngier > Signed-off-by: Ste

Re: [Xen-devel] [PATCH 1/3] arm_arch_timer: introduce arch_timer_stolen_ticks

2013-05-03 Thread Marc Zyngier
On 03/05/13 11:43, Stefano Stabellini wrote: > On Thu, 2 May 2013, Christopher Covington wrote: >>> So the virtual timer should appear to have been running even while time >>> is being stolen and therefore stolen time needs to be accounted via some >>> other means. >> >> Something that's not curren

Re: [RFC PATCH 1/2] ARM: delay: print dummy values for bogomips

2013-05-07 Thread Marc Zyngier
On 07/05/13 00:16, Pavel Machek wrote: Hi Pawel, >> Now that we support a timer-backed delay loop, I'm quickly getting sick >> and tired of people complaining that their beloved bogomips value has >> decreased. You know who you are! > >> Unfortunately, we can't just remove the entry from /proc/c

Re: [RFC PATCH V2] ARM: EXYNOS: Fix hotplug when CPUs boot in HYP mode

2013-05-07 Thread Marc Zyngier
On 07/05/13 06:54, Giridhar Maruthy wrote: > This patch is a modification from the Christoffer Dall's u-boot > patch. This is required to put the secondary processors in hyp > mode during cpu hotplug when u-boot is no longer alive. > > Marc Zyngier suggested this logic to go

Re: [RFC PATCH V2] ARM: EXYNOS: Fix hotplug when CPUs boot in HYP mode

2013-05-08 Thread Marc Zyngier
On 08/05/13 13:23, Giridhar Maruthy wrote: > On 7 May 2013 14:25, Marc Zyngier wrote: >> On 07/05/13 06:54, Giridhar Maruthy wrote: >>> This patch is a modification from the Christoffer Dall's u-boot >>> patch. This is required to put the secondary processors in

Re: [PATCH v3 3/4] arm: introduce CONFIG_PARAVIRT, PARAVIRT_TIME_ACCOUNTING and pv_time_ops

2013-05-08 Thread Marc Zyngier
Hi Stefano, On 08/05/13 16:41, Stefano Stabellini wrote: > Introduce CONFIG_PARAVIRT and PARAVIRT_TIME_ACCOUNTING on ARM. > > The only paravirt interface supported is pv_time_ops.steal_clock, so no > runtime pvops patching needed. > > This allows us to make use of steal_account_process_tick for

Re: [PATCH v3 4/4] xen/arm: account for stolen ticks

2013-05-08 Thread Marc Zyngier
Hi Stefano, On 08/05/13 16:41, Stefano Stabellini wrote: > Register the runstate_memory_area with the hypervisor. > Use pv_time_ops.steal_clock to account for stolen ticks. > > Signed-off-by: Stefano Stabellini > > Changes in v3: > - use BUG_ON and smp_processor_id. > --- > arch/arm/xen/enligh

Re: [PATCH 0/2] Early printk support for virtio console devices.

2013-04-26 Thread Marc Zyngier
On 26/04/13 16:03, Arnd Bergmann wrote: > On Friday 26 April 2013, Anup Patel wrote: >> I am curious about how smh-based or hypercall-based early prints would >> be handled in following scenario: >> >> "A board is running KVM ARM enabled kernel and linux console on serial >> port. Now a user remote

Re: [PATCH] ARM: KVM: Add missing break;

2013-04-14 Thread Marc Zyngier
Hi Joe, On Sat, 13 Apr 2013 22:55:45 -0700, Joe Perches wrote: > commit 3401d54696f ("KVM: ARM: Introduce KVM_ARM_SET_DEVICE_ADDR ioctl") > added the case, but omitted adding break; [...] Already reported here: http://lists.infradead.org/pipermail/linux-arm-kernel/2013-April/160127.html > $ gr

Re: [PATCH] arm64: kernel: compiling issue, need 'EXPORT_SYMBOL_GPL(read_current_timer)'

2013-05-20 Thread Marc Zyngier
On Mon, 20 May 2013 14:48:05 +0800, Chen Gang wrote: > Need 'EXPORT_SYMBOL_GPL(read_current_timer)' if build with allmodconfig. > > The related error: > ERROR: "read_current_timer" [lib/rbtree_test.ko] undefined! > ERROR: "read_current_timer" [lib/interval_tree_test.ko] undefined! > ERROR:

Re: [PATCH] arm64: kernel: compiling issue, need 'EXPORT_SYMBOL_GPL(read_current_timer)'

2013-05-20 Thread Marc Zyngier
On Tue, 21 May 2013 12:06:52 +0800, Chen Gang wrote: > On 05/20/2013 05:56 PM, Will Deacon wrote: >> On Mon, May 20, 2013 at 08:15:04AM +0100, Marc Zyngier wrote: >>> On Mon, 20 May 2013 14:48:05 +0800, Chen Gang >>> wrote: >>>> Need 'EXPORT_S

Re: [PATCH] arm64: kernel: compiling issue, need 'EXPORT_SYMBOL_GPL(read_current_timer)'

2013-05-21 Thread Marc Zyngier
On 21/05/13 09:41, Chen Gang wrote: > On 05/21/2013 02:13 PM, Marc Zyngier wrote: >> On Tue, 21 May 2013 12:06:52 +0800, Chen Gang >> wrote: >>> On 05/20/2013 05:56 PM, Will Deacon wrote: >>>> On Mon, May 20, 2013 at 08:15:04AM +0100, Marc Zyngier wrote: >

Re: [PATCH v3] [RFC] arm: use PSCI if available

2013-03-27 Thread Marc Zyngier
On 27/03/13 12:50, Stefano Stabellini wrote: > Check for the presence of PSCI before setting smp_ops, use PSCI if it is > available. > > This is useful because at least when running on Xen it's possible to have a > PSCI node for example on a Versatile Express or an Exynos5 machine. In these > case

Re: [PATCH] arm: introduce a DTS for Xen unprivileged virtual machines

2012-09-20 Thread Marc Zyngier
On 20/09/12 13:15, Stefano Stabellini wrote: > On Thu, 20 Sep 2012, Pawel Moll wrote: >> On Thu, 2012-09-20 at 12:39 +0100, Stefano Stabellini wrote: >>> There are no peripherals apart from the ones that are already described >>> here (timer, gic). All the peripherals that the guest sees are virtua

Re: [PATCH] arm: introduce a DTS for Xen unprivileged virtual machines

2012-09-20 Thread Marc Zyngier
On 20/09/12 14:30, Ian Campbell wrote: > On Thu, 2012-09-20 at 13:28 +0100, Marc Zyngier wrote: >> I think the important thing here is that the memory map is RS1. As this >> is a (very limited) subset of a vexpress A15, it seems to make some sense. > > Looking at arch/arm/

Re: [PATCH 2/2] ARM: local timers: add timer support using IO mapped register

2012-08-11 Thread Marc Zyngier
Hi Rohit, On Fri, 10 Aug 2012 14:58:41 -0700, Rohit Vaswani wrote: > The current arch_timer only support accessing through CP15 interface. > Add support for ARM processors that only support IO mapped register > interface This is quite a departure from the current implementation, which raises a c

Re: [PATCH 1/2] ARM: local timers: Unmask interrupt before new TVAL is set

2012-08-11 Thread Marc Zyngier
On Fri, 10 Aug 2012 14:57:34 -0700, Rohit Vaswani wrote: > Level triggered interrupt is deasserted when a new TVAL is written > only when the interrupt is unmasked. Make sure that the interrupt > is unmasked in CTL register before TVAL is written. > If this order is not followed, there are chances

Re: [PATCH] [resend] 3c509: convert to isa_driver and pnp_driver v3

2008-02-07 Thread Marc Zyngier
> "Ondrej" == Ondrej Zary <[EMAIL PROTECTED]> writes: Ondrej> Tested using 3 ISA cards in various combinations of PnP and non-PnP modes. Ondrej> #ifdef CONFIG_EISA Ondrej> ret = eisa_driver_register(&el3_eisa_driver); Ondrej> + if (!ret) Ondrej> + eisa_registeted

Re: [Ksummit-2012-discuss] ARM mini-summit

2012-07-11 Thread Marc Zyngier
On Wed, 11 Jul 2012 12:57:55 +0100, Catalin Marinas wrote: > On Wed, Jul 11, 2012 at 12:28:29PM +0100, Arnd Bergmann wrote: >> On Wednesday 11 July 2012, James Bottomley wrote: >> > Hi All, >> > >> > We have set aside the second day of the kernel summit (Tuesday 28 >> > August) as mini-summit day

Re: [Ksummit-2012-discuss] ARM mini-summit

2012-07-11 Thread Marc Zyngier
On Wed, 11 Jul 2012 20:06:28 +, Arnd Bergmann wrote: > On Wednesday 11 July 2012, Konrad Rzeszutek Wilk wrote: >> >> > contacts, with Grant and Olof joining in as time permits. >> >> >> >> Acked-by: Grant Likely >> > >> > I would be interested in attending it as well. I believe Stefano has a

Re: [PATCH 33/36] AArch64: Generic timers support

2012-07-12 Thread Marc Zyngier
On Thu, 12 Jul 2012 02:18:42 +0200, Linus Walleij wrote: Hi Linus, > I'm reviewing the only patch I really understand... > > 2012/7/6 Catalin Marinas : > >> +/* This isn't really used any more */ >> +#define CLOCK_TICK_RATE 1000 > > Is it still necessary to even have it there? It is used as

Re: [PATCH 33/36] AArch64: Generic timers support

2012-07-12 Thread Marc Zyngier
On Thu, 12 Jul 2012 09:57:33 -0700, John Stultz wrote: > On 07/12/2012 03:56 AM, Linus Walleij wrote: >> On Thu, Jul 12, 2012 at 12:09 PM, Marc Zyngier >> wrote: >> >>> On Thu, 12 Jul 2012 02:18:42 +0200, Linus Walleij >>> wrote: >>> >>>

[RFC PATCH] virt_mmio: fix signature checking for BE guests

2013-02-13 Thread Marc Zyngier
: Pawel Moll Signed-off-by: Marc Zyngier --- So I'm not completely sure this is the right fix, and I can imagine other ways to cure the problem: - Reading the MAGIC register byte by byte. Is that allowed? The spec only says it is 32bit wide. - Using __raw_readl() instead. Is that a generic e

Re: [RFC PATCH] virt_mmio: fix signature checking for BE guests

2013-02-13 Thread Marc Zyngier
On 13/02/13 15:08, Pawel Moll wrote: > On Wed, 2013-02-13 at 14:25 +0000, Marc Zyngier wrote: >> Using readl() to read the magic value and then memcmp() to check it >> fails on BE, as bytes will be the other way around (by virtue of >> the registers to follow the endianess o

Re: [RFC PATCH] virt_mmio: fix signature checking for BE guests

2013-02-13 Thread Marc Zyngier
On 13/02/13 15:46, Pawel Moll wrote: > On Wed, 2013-02-13 at 15:28 +0000, Marc Zyngier wrote: >>>> Fix it by encoding the magic as an integer instead of a string. >>>> So I'm not completely sure this is the right fix, >>> >>> It seems right, how

Re: [RFC PATCH] virt_mmio: fix signature checking for BE guests

2013-02-13 Thread Marc Zyngier
On 13/02/13 16:53, Michael S. Tsirkin wrote: > On Wed, Feb 13, 2013 at 03:28:52PM +0000, Marc Zyngier wrote: >> On 13/02/13 15:08, Pawel Moll wrote: >>> On Wed, 2013-02-13 at 14:25 +, Marc Zyngier wrote: >>>> Using readl() to read the magic value and then memcmp(

Re: [PATCH v2 RESEND 2/2] ARM: local timers: add timer support using IO mapped register

2012-09-27 Thread Marc Zyngier
On 25/09/12 20:08, Rohit Vaswani wrote: > Any comments ? > > Marc, would it be possible for you to pull this into your timers-next tree ? Hi Rohit, Sorry for the delay. I'll give these patches a whirl first thing tomorrow. Thanks, M. -- Jazz is not dead. It just smells funny... -- T

Re: [PATCH v4 21/24] arm/v2m: initialize arch_timers even if v2m_timer is not present

2013-01-07 Thread Marc Zyngier
On 07/01/13 17:21, Stefano Stabellini wrote: > On Fri, 14 Sep 2012, Stefano Stabellini wrote: >> On Fri, 14 Sep 2012, Pawel Moll wrote: >>> On Fri, 2012-09-14 at 12:13 +0100, Stefano Stabellini wrote: >>>> Signed-off-by: Stefano Stabellini >>>> CC: Russel

[Linux-IrDA]Re: [IrDA+SMP] Lockup in handle_IRQ_event

2001-01-04 Thread Marc ZYNGIER
> "AM" == Andrew Morton <[EMAIL PROTECTED]> writes: Hi Andrew, AM> Try this: AM> --- linux-2.4.0-prerelease/net/irda/irqueue.c Tue Nov 21 20:11:22 2000 AM> +++ linux-akpm/net/irda/irqueue.c Thu Jan 4 10:14:10 2001 AM> @@ -436,7 +436,7 @@ AM> /* Release lock */ AM> if ( ha

[PATCH] [IrDA+SMP] Lockup in handle_IRQ_event

2001-01-04 Thread Marc ZYNGIER
Jun 9 13:29:31 1998 * Modified at: Sun Dec 12 13:48:22 1999 * Modified by: Dag Brattli <[EMAIL PROTECTED]> + * Modified at: Thu Jan 4 14:29:10 CET 2001 + * Modified by: Marc Zyngier <[EMAIL PROTECTED]> * * Copyright (C) 1998-1999, Aage Kvalnes <[

[IrDA+SMP] Lockup in handle_IRQ_event

2001-01-03 Thread Marc ZYNGIER
Hi all, Having just started playing with IrDA on my dual celeron (Abit "APIC error..." BP6), I managed to kill it every single time (NMI watchdog in handle_IRQ_event) while connecting to my mobile phone (in fact, when closing the connection to the phone. even 'cat /dev/ircomm0' will do...). This

Re: [patch] /proc/net/{tcp,udp,raw} cleanup

2000-09-11 Thread Marc Zyngier
> "David" == David S Miller <[EMAIL PROTECTED]> writes: David> Are sure that netstat and other tools don't "fix" this? David> I just checked, and they in fact do take care of byte swapping David> what needs to be byte-swapped. David> Thus, this patch would break more than it would fix. Oops

[patch] /proc/net/{tcp,udp,raw} cleanup

2000-09-11 Thread Marc Zyngier
Hi Dave, /proc/net/{tcp,udp,raw} show IPv4 addresses with host order, while port is shown with network order. The included patch adds the needed ntohl(). Not very usefull, but hopefully correct. Tested on 2.4.0-pre8/Alpha. M. --- linux/net/ipv4/tcp_ipv4.c.old Mon Sep 11 12:15:54

Re: SOC-specific action for irq_set_wake

2016-07-20 Thread Marc Zyngier
On 20/07/16 00:34, Sören Brinkmann wrote: > Hi Andy, > > On Tue, 2016-07-19 at 17:47:13 -0500, Andy Gross wrote: >> On Tue, Jul 19, 2016 at 11:18:04AM -0700, Sören Brinkmann wrote: >>> Hi, >>> >>> we are working on the PM solution for Zynq MPSOC and ran into some >>> problem when setting the wake

Re: [PATCH v15 04/10] arm64: Kprobes with single stepping support

2016-07-20 Thread Marc Zyngier
On 08/07/16 17:35, David Long wrote: > From: Sandeepa Prabhu > > Add support for basic kernel probes(kprobes) and jump probes > (jprobes) for ARM64. > > Kprobes utilizes software breakpoint and single step debug > exceptions supported on ARM v8. > > A software breakpoint is placed at the probe

Re: PCIe MSI address is not written at pci_enable_msi_range call

2016-07-20 Thread Marc Zyngier
+tglx On 13/07/16 09:33, Bharat Kumar Gogada wrote: >> Subject: Re: PCIe MSI address is not written at pci_enable_msi_range call >> >> On 13/07/16 07:22, Bharat Kumar Gogada wrote: Subject: Re: PCIe MSI address is not written at pci_enable_msi_range call On 11/07/16 10:33, Bhar

Re: [RFC PATCH v2] irqchip: add support for SMP irq router

2016-07-20 Thread Marc Zyngier
Thomas already commented on some aspects of the code, so I'm not going to do another review (I'll do the next round). On 20/07/16 12:06, Sebastian Frias wrote: > Hi Thomas, > > Thanks for your comments. > I appreciate the time you dedicated to the review. > I will take your comments into account,

Re: SOC-specific action for irq_set_wake

2016-07-20 Thread Marc Zyngier
Hi Sören, On 20/07/16 14:16, Sören Brinkmann wrote: > Hi Marc, > Does anybody have similar problems and probably already solved it? > Any other suggestions for approaching the problem? Any preferred > solution? I think we have the same problem. Can you provide more detail o

Re: [PATCH v15 04/10] arm64: Kprobes with single stepping support

2016-07-20 Thread Marc Zyngier
On 08/07/16 17:35, David Long wrote: > From: Sandeepa Prabhu > > Add support for basic kernel probes(kprobes) and jump probes > (jprobes) for ARM64. > > Kprobes utilizes software breakpoint and single step debug > exceptions supported on ARM v8. > > A software breakpoint is placed at the probe

Re: [PATCH v15 04/10] arm64: Kprobes with single stepping support

2016-07-20 Thread Marc Zyngier
On 20/07/16 17:28, Catalin Marinas wrote: > On Wed, Jul 20, 2016 at 05:09:28PM +0100, Marc Zyngier wrote: >> +static inline unsigned long min_stack_size(unsigned long addr) >> +{ >> +unsigned long size; >> +struct kprobe_ctlblk *ctl; >> + >> +if (

Re: [PATCH v15 04/10] arm64: Kprobes with single stepping support

2016-07-20 Thread Marc Zyngier
On 20/07/16 17:28, Catalin Marinas wrote: > On Wed, Jul 20, 2016 at 05:09:28PM +0100, Marc Zyngier wrote: >> +static inline unsigned long min_stack_size(unsigned long addr) >> +{ >> +unsigned long size; >> +struct kprobe_ctlblk *ctl; >> + >> +if (

Re: [PATCH v15 04/10] arm64: Kprobes with single stepping support

2016-07-21 Thread Marc Zyngier
On 20/07/16 20:08, David Long wrote: > On 07/20/2016 05:36 AM, Marc Zyngier wrote: >> On 08/07/16 17:35, David Long wrote: >>> From: Sandeepa Prabhu >>> >>> Add support for basic kernel probes(kprobes) and jump probes >>> (jprobes) for ARM64. >

Re: [PATCH v15 04/10] arm64: Kprobes with single stepping support

2016-07-21 Thread Marc Zyngier
On 21/07/16 17:33, David Long wrote: > On 07/20/2016 12:09 PM, Marc Zyngier wrote: >> On 08/07/16 17:35, David Long wrote: >>> From: Sandeepa Prabhu >>> >>> Add support for basic kernel probes(kprobes) and jump probes >>> (jprobes) for ARM64. >

[PATCH 0/2] jump_labels: Embedding static keys inside structures

2016-09-19 Thread Marc Zyngier
construct and could use the cleanup. Patches on top of arm64/for-next/core, which already contains some jump label changes. [1] https://git.kernel.org/cgit/linux/kernel/git/kvmarm/kvmarm.git/commit/?h=queue&id=db6ca86d92d9d8f8e0bf9c1210a90ddf70e76136 Marc Zyngier (2): jump_labels: Add API to

[PATCH 2/2] dynamic_debug: Use updated jump label API

2016-09-19 Thread Marc Zyngier
Now that we have brand new DECLARE_STATIC_KEY_TRUE/FALSE and INIT_STATIC_KEY_TRUE/FALSE as first class APIs, convert the dynamic_debug infrastructure to use it. Signed-off-by: Marc Zyngier --- include/linux/dynamic_debug.h | 22 ++ 1 file changed, 10 insertions(+), 12

[PATCH 1/2] jump_labels: Add API to deal with keys embedded in structures

2016-09-19 Thread Marc Zyngier
foo; DECLARE_STATIC_KEY_FALSE(key); } bar = { INIT_STATIC_KEY_FALSE(.key), }; Signed-off-by: Marc Zyngier --- Documentation/static-keys.txt | 19 +++ include/linux/jump_label.h| 21 ++--- 2 files changed, 37 inserti

Re: [PATCH] irqchip/gicv3: silence noisy DEBUG_PER_CPU_MAPS warning

2016-09-19 Thread Marc Zyngier
> tlist |= 1 << (mpidr & 0xf); > > - cpu = cpumask_next(cpu, mask); > - if (cpu >= nr_cpu_ids) > + next_cpu = cpumask_next(cpu, mask); > + if (next_cpu >= nr_cpu_ids) > goto out

Re: [PATCH] clocksource: arm_arch_timer: Don't assume clock runs in suspend

2016-09-20 Thread Marc Zyngier
On 20/09/16 00:14, Brian Norris wrote: > On Fri, Sep 16, 2016 at 09:06:55AM +0100, Marc Zyngier wrote: >> Hi Brian, > > Hi Marc, > > Thanks for the quick response. > >> On 16/09/16 06:49, Brian Norris wrote: >>> Since commit 4fbcdc813fb9 ("clocksou

Re: [PATCH 1/2] jump_labels: Add API to deal with keys embedded in structures

2016-09-20 Thread Marc Zyngier
On 20/09/16 10:42, Peter Zijlstra wrote: > On Mon, Sep 19, 2016 at 06:21:27PM +0100, Marc Zyngier wrote: >> It is desirable to allow static keys to be integrated in structures, >> as it can lead do slightly more readable code. But the current API >> only provides DEFINE_

Re: [PATCH] irqchip, gicv3: Fix out-of-range cpumask access reported by cpumask_check()

2016-09-20 Thread Marc Zyngier
On 20/09/16 12:39, Mark Rutland wrote: > On Tue, Sep 20, 2016 at 01:34:19PM +0200, Robert Richter wrote: >> Booting a kernel with DEBUG_PER_CPU_MAPS enabled triggers the follwing >> warning: >> >> WARNING: CPU: 1 PID: 0 at ./include/linux/cpumask.h:121 >> gic_raise_softirq+0x298/0x308 > > James

  1   2   3   4   5   6   7   8   9   10   >