Re: [PATCH v2 1/3] dt-bindings: pfuze100: add optional disable switch-regulators binding

2018-07-18 Thread Marco Felsch
Hi Rob, thanks for the review. I will integrate it in a v3. Regards, Marco On 18-07-16 11:55, Rob Herring wrote: > On Fri, Jul 13, 2018 at 02:50:01PM +0200, Marco Felsch wrote: > > This binding is used to keep the backward compatibility with the current > > dtb's [1]. The

Re: [PATCH v2 1/3] dt-bindings: pfuze100: add optional disable switch-regulators binding

2018-07-16 Thread Marco Felsch
Hi Mark, thanks for the review. On 18-07-13 16:03, Mark Brown wrote: > On Fri, Jul 13, 2018 at 02:50:01PM +0200, Marco Felsch wrote: > > > +Optional properties: > > +- fsl,pfuze-support-disable: Boolean, if present disable all unused switch > > + regulators to save powe

[PATCH v3 2/2] regulator: pfuze100: add support to en-/disable switch regulators

2018-07-23 Thread Marco Felsch
switch""). Disabling the switch regulators will only be done if the user specifies "fsl,pfuze-support-disable-sw" in its device tree to keep backward compatibility with current dtb's [1]. [1] https://patchwork.kernel.org/patch/10490381/ Signed-off-by: Marco Felsch --- Chang

[PATCH v3 1/2] dt-bindings: pfuze100: add optional disable switch-regulators binding

2018-07-23 Thread Marco Felsch
-off-by: Marco Felsch --- Changes in v3: - rename dt binding, add -sw suffix - fix description Changes in V2: - add more information about the binding - rename binding and add vendor prefix Documentation/devicetree/bindings/regulator/pfuze100.txt | 9 + 1 file changed, 9

[PATCH v3 0/2] Re-Enable support to disable switch regulators

2018-07-23 Thread Marco Felsch
: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git Branch: regulator/for-4.19 Regards, Marco [1] https://patchwork.kernel.org/patch/10490381/ [2] https://patchwork.kernel.org/patch/10500333/ Marco Felsch (2): dt-bindings: pfuze100: add optional disable switch-regulators binding

[PATCH v2 2/3] regulator: pfuze100: add support to en-/disable switch regulators

2018-07-13 Thread Marco Felsch
switch""). Disabling the switch regulators will only be done if the user specifies "fsl,pfuze-support-disable" in its device tree to keep backward compatibility with current dtb's [1]. [1] https://patchwork.kernel.org/patch/10490381/ Signed-off-by: Marco Felsch --- Changes i

[PATCH v2 1/3] dt-bindings: pfuze100: add optional disable switch-regulators binding

2018-07-13 Thread Marco Felsch
-off-by: Marco Felsch --- Changes in V2: - add more information about the binding - rename binding and add vendor prefix .../devicetree/bindings/regulator/pfuze100.txt| 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation/devicetree/bindings/regulator/pfuze100

[PATCH] regulator: core: fix _regulator_do_disable return value

2018-07-13 Thread Marco Felsch
by the driver as it is done already by _regulator_do_enable. Signed-off-by: Marco Felsch --- drivers/regulator/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index bb1324f93143..69b4e096b632 100644 --- a/drivers/regulator/core.c +++ b/drivers

[PATCH v2 0/2] Re-Enable support to disable switch regulators

2018-07-13 Thread Marco Felsch
: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git Branch: regulator/for-4.19 Regards, Marco [1] https://patchwork.kernel.org/patch/10490381/ [2] https://patchwork.kernel.org/patch/10500333/ Marco Felsch (3): dt-bindings: pfuze100: add optional disable switch-regulators

Re: [PATCH 1/2] dt-bindings: pfuze100: add optional pfuze-disable-sw binding

2018-07-13 Thread Marco Felsch
Hi Mark, On 18-07-12 16:31, Mark Brown wrote: > On Thu, Jul 12, 2018 at 01:02:39PM +0200, Marco Felsch wrote: > > > +Optional properties: > > +- pfuze-disable-sw: Disable all unused switch regulators to save power > > + consumption. Attention, some platforms are usi

Re: [PATCH 1/2] dt-bindings: pfuze100: add optional pfuze-disable-sw binding

2018-07-13 Thread Marco Felsch
Hi Fabio, On 18-07-12 12:19, Fabio Estevam wrote: > On Thu, Jul 12, 2018 at 8:02 AM, Marco Felsch wrote: > > > +Optional properties: > > +- pfuze-disable-sw: Disable all unused switch regulators to save power > > + consumption. Attention, some platforms are usi

Re: [PATCH] regulator: core: fix _regulator_do_disable return value

2018-07-13 Thread Marco Felsch
Hi Mark, tanks for the feedback. On 18-07-13 14:07, Mark Brown wrote: > On Fri, Jul 13, 2018 at 02:56:24PM +0200, Marco Felsch wrote: > > > Currently _regulator_do_disable returns 0 if either the ena_pin nor the > > ops.disbale() isn't present. This assumes that the c

[PATCH 0/2] Re-Enable support to disable switch regulators

2018-07-12 Thread Marco Felsch
patches are based on his repo too. Used Kernel: Repo: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git Branch: regulator/for-4.19 Regards, Marco [1] https://patchwork.kernel.org/patch/10490381/ [2] https://patchwork.kernel.org/patch/10500333/ Marco Felsch (2): dt-bindings

[PATCH 1/2] dt-bindings: pfuze100: add optional pfuze-disable-sw binding

2018-07-12 Thread Marco Felsch
-off-by: Marco Felsch --- Documentation/devicetree/bindings/regulator/pfuze100.txt | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/regulator/pfuze100.txt b/Documentation/devicetree/bindings/regulator/pfuze100.txt index 672c939045ff..1f17ab7c7123 100644

[PATCH 2/2] regulator: pfuze100: add support to en-/disable switch regulators

2018-07-12 Thread Marco Felsch
ore like a simulated disable. [1] https://patchwork.kernel.org/patch/10490381/ Signed-off-by: Marco Felsch --- Changes since https://patchwork.kernel.org/patch/10405723/ - Use DT property to keep backward compatibility - Use the default register val 0x8 as enable_val drivers/regulator/pfuze100-regula

Re: [PATCH] ASoC: max98988: add I2C dependency

2018-10-10 Thread Marco Felsch
/codecs/max98088.c:1780:26: error: 'max98088_i2c_driver' defined but > not used [-Werror=unused-variable] > > Fixes: 24ae67c58250 ("ASoC: max98988: make it selectable") > Signed-off-by: Arnd Bergmann Thanks for covering the issue. Reviewed-by: Marco Felsch Regrads, Marco >

Re: [PATCH v2 2/6] input/touchscreen: Add device tree support to wacom_i2c

2021-01-22 Thread Marco Felsch
On 21-01-20 22:56, Alistair Francis wrote: > Allow the wacom-i2c device to be exposed via device tree. You did a lot more than exposing. > Signed-off-by: Alistair Francis > --- > .../input/touchscreen/wacom,wacom-i2c.yaml | 4 > drivers/input/touchscreen/wacom_i2c.c| 16

Re: [PATCH v2 1/6] devicetree/bindings: Initial commit of wacom, wacom-i2c

2021-01-22 Thread Marco Felsch
Hi, thnaks for the patch. On 21-01-20 22:56, Alistair Francis wrote: > Signed-off-by: Alistair Francis > --- > .../input/touchscreen/wacom,wacom-i2c.yaml| 44 +++ > .../devicetree/bindings/vendor-prefixes.yaml | 2 + This should be splitted into two patches. Regards,

Re: [PATCH v2 3/6] touchscreen/wacom_i2c: Add support for distance and tilt x/y

2021-01-22 Thread Marco Felsch
Hi, thanks for the patch. Please align all your patch-subjects belonging to the driver to: "Input: wacom_i2c - ..." On 21-01-20 22:56, Alistair Francis wrote: > This is based on the out of tree rM2 driver. > > Signed-off-by: Alistair Francis > --- > drivers/input/touchscreen/wacom_i2c.c | 25

Re: [PATCH v2 6/6] arch/arm: reMarkable2: Enable wacom_i2c

2021-01-22 Thread Marco Felsch
Hi, thanks for the patch. On 21-01-20 22:56, Alistair Francis wrote: > Enable the wacom_i2c touchscreen for the reMarkable2. > > Signed-off-by: Alistair Francis > --- > arch/arm/boot/dts/imx7d-remarkable2.dts | 41 + > arch/arm/configs/imx_v6_v7_defconfig| 1 +

Re: [PATCH v2 0/6] Add Wacom I2C support to rM2

2021-01-22 Thread Marco Felsch
Hi Alistair, thanks for the patches. Before getting into the series please check all your commit subjects. Also please check that you do only one logical change per patch: e.g. adding DT-Support means: Add the dt-table and not more. I looking forward to your v2 :) Regards, Marco On 21-01-20

Re: PHY reset question

2020-10-07 Thread Marco Felsch
Hi Marek, On 20-10-06 14:11, Florian Fainelli wrote: > On 10/6/2020 1:24 PM, Marek Vasut wrote: ... > > If this happens on MX6 with FEC, can you please try these two patches? > > > > https://patchwork.ozlabs.org/project/netdev/patch/20201006135253.97395-1-ma...@denx.de/ > > > >

Re: PHY reset question

2020-10-07 Thread Marco Felsch
On 20-10-07 10:23, Marek Vasut wrote: > On 10/7/20 10:14 AM, Marco Felsch wrote: > > Hi Marek, > > Hi, > > [...] > > > On 20-10-06 14:11, Florian Fainelli wrote: > >> On 10/6/2020 1:24 PM, Marek Vasut wrote: > > > > ... > > > >&

Re: PHY reset question

2020-10-07 Thread Marco Felsch
On 20-10-07 11:20, Marek Vasut wrote: > On 10/7/20 11:06 AM, Marco Felsch wrote: ... > > You're right, just wanted to provide you a link :) > > Can you CC me on the next version of those patches ? I seems the LAN8710 > is causing grief to many. No need to since this serie w

Re: [PATCH] Input: ili210x: Fix potential memory leaks

2020-08-05 Thread Marco Felsch
Hi Adam, On 20-08-04 13:30, Adam Ford wrote: > This driver requests, memory twice and requests a threaded irq, but > it doesn't free any of them if something fails. Free'ing is done automatically because the driver uses devres (identified by devm_ prepfix) functions. Regards, Marco

Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles

2020-10-02 Thread Marco Felsch
Hi, sorry for jumping in. On 20-10-02 10:20, Krzysztof Kozlowski wrote: > On Fri, Oct 02, 2020 at 09:41:28AM +0200, Ahmad Fatoum wrote: > > Hello, > > > > On 10/1/20 12:37 PM, Krzysztof Kozlowski wrote: > > >> The existing binding doesn't cover these boards then and needs to be > > >> extended,

Re: [PATCH v7 2/4] SFH: PCIe driver to add support of AMD sensor fusion hub

2020-08-11 Thread Marco Felsch
Hi Sandeep, On 20-08-10 21:30, Sandeep Singh wrote: > From: Sandeep Singh > > AMD SFH uses HID over PCIe bus.SFH fw is part of MP2 processor > (MP2 which is an ARM® Cortex-M4 core based co-processor to x86) and > it runs on MP2 where in driver resides on X86. This part of module > will

Re: [PATCH v1 3/3] ARM: dts: add Van der Laan LANMCU board

2020-10-15 Thread Marco Felsch
On 20-10-15 11:02, Oleksij Rempel wrote: > Hi Marco, > > thank you for review! > > On Wed, Oct 14, 2020 at 12:05:01PM +0200, Marco Felsch wrote: > > Hi Oleksij, > > > > pls can you send a patch adding this board to: > > Documentation/devicetree

Re: [PATCH 2/2] ASoC: fsl: imx-es8328: add missing put_device() call in imx_es8328_probe()

2020-08-27 Thread Marco Felsch
On 20-08-25 20:05, Yu Kuai wrote: > if of_find_device_by_node() succeed, imx_es8328_probe() doesn't have > a corresponding put_device(). Why do we need the ssi_pdev reference here at all? Regards, Marco

Re: [PATCH v2 3/3] ARM: dts: add Plymovent M2M board

2020-09-11 Thread Marco Felsch
On 20-09-11 07:09, Oleksij Rempel wrote: > Plymovent M2M is a control interface produced for the Plymovent filter > systems. > > Signed-off-by: David Jander > Signed-off-by: Oleksij Rempel > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/imx6dl-plym2m.dts | 394

Re: [PATCH v13 00/12] add ecspi ERR009165 for i.mx6/7 soc family

2020-09-11 Thread Marco Felsch
On 20-09-01 00:03, Robin Gong wrote: > There is ecspi ERR009165 on i.mx6/7 soc family, which cause FIFO > transfer to be send twice in DMA mode. Please get more information from: > https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf. The workaround is adding > new sdma ram script which works in XCH

[PATCH 3/3] mtd: spi-nor: sst: move sst_write_second to local driver

2020-09-11 Thread Marco Felsch
Don't mess the spi-nor core with details only relating to this specific device. Handle the addr_width locally and drop the sst related stuff from the spi-nor core to clean it up. Signed-off-by: Marco Felsch --- drivers/mtd/spi-nor/core.c | 3 --- drivers/mtd/spi-nor/sst.c | 10

[PATCH 0/3] MTD: SST SPI-NOR fixes

2020-09-11 Thread Marco Felsch
even start addresses. My dut was an public available imx6q-sabrelite (rev.D). Other testers are welcome :) Regards, Marco Marco Felsch (3): mtd: spi-nor: sst: fix write support for SST_WRITE marked devices mtd: spi-nor: sst: add missing write_enable mtd: spi-nor: sst: move sst_write_second

[PATCH 1/3] mtd: spi-nor: sst: fix write support for SST_WRITE marked devices

2020-09-11 Thread Marco Felsch
rn 0 to fix both issues. Fixes: df5c21002cf4 ("mtd: spi-nor: use spi-mem dirmap API") Signed-off-by: Marco Felsch --- drivers/mtd/spi-nor/core.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c index

[PATCH 2/3] mtd: spi-nor: sst: add missing write_enable

2020-09-11 Thread Marco Felsch
SPINOR_OP_AAI_WP sequence. [1] http://ww1.microchip.com/downloads/en/DeviceDoc/20005044C.pdf; "4.3.2 WRITE ENABLE LATCH (WEL)" Signed-off-by: Marco Felsch --- drivers/mtd/spi-nor/sst.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/mtd/spi-nor/sst.c b/drivers/mtd/spi

Re: [PATCH] Input: edt-ft5x06 - consolidate handling of number of electrodes

2020-12-10 Thread Marco Felsch
eg_offset_x = EV_REGISTER_OFFSET_X; > reg_addr->reg_offset_y = EV_REGISTER_OFFSET_Y; > reg_addr->reg_num_x = NO_REGISTER; > reg_addr->reg_num_y = NO_REGISTER; > - reg_addr->reg_report_rate = NO_REGISTER; > break; Nit: Unrelated change. However the patch looks good, thanks. Acked-by: Marco Felsch Regards, Marco

Re: [PATCH net] net: phy: smsc: add missed clk_disable_unprepare in smsc_phy_probe()

2020-11-16 Thread Marco Felsch
On 20-11-14 11:45, Florian Fainelli wrote: > > > On 11/14/2020 11:26 AM, Jakub Kicinski wrote: > > On Thu, 12 Nov 2020 19:23:59 +0800 Zhang Changzhong wrote: > >> Add the missing clk_disable_unprepare() before return from > >> smsc_phy_probe() in the error handling case. > >> > >> Fixes:

Re: [PATCH v3] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q

2019-09-04 Thread Marco Felsch
Hi Robin, thanks for the patch it looks quite good, just two minor nitpicks. On 19-09-04 06:23, Robin van der Gracht wrote: > The first generation i.MX6 processors does not send an interrupt when the > power key is pressed. It sends a power down request interrupt if the key is > released before

Re: [PATCH v2 1/3] dt-bindings: ASoC: Add TDA7802 amplifier

2019-07-30 Thread Marco Felsch
Hi Charles, sorry for jumping in.. On 19-07-30 13:27, Charles Keepax wrote: > On Tue, Jul 30, 2019 at 01:09:35PM +0100, Thomas Preston wrote: > > Signed-off-by: Thomas Preston > > Cc: Patrick Glaser > > Cc: Rob Duncan > > Cc: Nate Case > > --- > > .../devicetree/bindings/sound/tda7802.txt

Re: [alsa-devel] [PATCH v2 2/3] ASoC: Add codec driver for ST TDA7802

2019-07-31 Thread Marco Felsch
Hi Thomas, again sorry for jumping in.. On 19-07-30 18:26, Thomas Preston wrote: > On 30/07/2019 15:58, Mark Brown wrote: > > On Tue, Jul 30, 2019 at 01:09:36PM +0100, Thomas Preston wrote: > > > >> index ..0f82a88bc1a4 > >> --- /dev/null > >> +++ b/sound/soc/codecs/tda7802.c > >>

Re: [PATCH v2 1/1] ARM: dts: colibri: introduce dts with UHS-I support enabled

2019-07-09 Thread Marco Felsch
Hi Marcel, On 19-07-08 17:09, Marcel Ziswiler wrote: > Hi Marco > > On Tue, 2019-07-02 at 14:51 +0200, Marco Felsch wrote: > > Hi Igor, > > > > On 19-07-02 09:42, Igor Opaniuk wrote: > > > Hi Marco, > > > > > > On Tue, Jul 2, 2019 at 10:27

Re: [PATCH v1 1/2] regulator: pca9450: add enable_val for all bucks

2020-08-31 Thread Marco Felsch
Hi Robin, On 20-09-01 00:48, Robin Gong wrote: > BuckX enable mode > 00b = OFF > 01b = ON by PMIC_ON_REQ = H > 10b = ON by PMIC_ON_REQ = H && PMIC_STBY_REQ = L > 11b = Always ON > > For such enable mode, enable_value should be clearly set in requlator desc, > 00/11 is not enough, correct it now

Re: [PATCH v1 3/3] ARM: dts: add Van der Laan LANMCU board

2020-10-14 Thread Marco Felsch
Hi Oleksij, pls can you send a patch adding this board to: Documentation/devicetree/bindings/arm/fsl.yaml infront of this patch? On 20-10-14 10:53, Oleksij Rempel wrote: > Van der Laan LANMCU is a module for the food storage rooms to control > proper gas composition. > > Co-Developed-by: Robin

Re: [PATCH v2 1/2] ARM: dts: imx7-tqma7: add SPI-NOR flash

2020-11-02 Thread Marco Felsch
Hi Matthias, On 20-10-30 11:26, Matthias Schiffer wrote: > The SPI-NOR flash on the SoM was missing from the device tree. > > Signed-off-by: Matthias Schiffer > --- > arch/arm/boot/dts/imx7-tqma7.dtsi | 30 ++ > 1 file changed, 30 insertions(+) > > v2: change node

Re: [PATCH v2 2/2] ARM: dts: imx7-mba7: add default SPI-NOR flash partition layout

2020-11-02 Thread Marco Felsch
Hi Matthias, On 20-10-30 11:26, Matthias Schiffer wrote: > Add the partition layout also used by the bootloader. > > Signed-off-by: Matthias Schiffer > --- > arch/arm/boot/dts/imx7-mba7.dtsi | 32 > 1 file changed, 32 insertions(+) > > v2: no changes > > >

Re: [PATCH v2] drm/panel: simple: add SGD GKTW70SDAD1SD

2021-02-01 Thread Marco Felsch
CAP-GLD-RGB.pdf > > Signed-off-by: Oliver Graute > Cc: Marco Felsch > Cc: Fabio Estevam > --- > > v2: > > - changed bpc to 6 > - set max value of pixelclock > - increased hfront_porch and hback_porch > - dropped connector-type > > adding of bus_f

Re: [PATCH v5 2/3] arm64: dts: imx: Add i.mx8mm nitrogen8mm basic dts support

2021-01-28 Thread Marco Felsch
Hi Adrien, thanks for the patch. I've made only a few comments inline. On 21-01-18 12:15, Adrien Grassein wrote: > Tested with a basic Build Root configuration booting from sdcard. > > Signed-off-by: Adrien Grassein > Reviewed-by: Krzysztof Kozlowski > --- >

Re: [PATCH v3] drm/panel: simple: add SGD GKTW70SDAD1SD

2021-02-02 Thread Marco Felsch
Signed-off-by: Oliver Graute > Cc: Marco Felsch > Cc: Fabio Estevam > --- > > v3: > > - added flags > - added delay Thanks, did you test the changes? I just picked it from the datasheet. Regards, Marco

[PATCH 3/5] regulator: da9062: add voltage selection gpio support

2019-09-17 Thread Marco Felsch
-based voltage switching support. Signed-off-by: Marco Felsch --- drivers/regulator/da9062-regulator.c | 149 +++ 1 file changed, 149 insertions(+) diff --git a/drivers/regulator/da9062-regulator.c b/drivers/regulator/da9062-regulator.c index 9b2ca472f70c..9d6eb7625948

[PATCH 2/5] dt-bindings: mfd: da9062: add regulator voltage selection documentation

2019-09-17 Thread Marco Felsch
Add the documentation which describe the voltage selection gpio support. This property can be applied to each subnode within the 'regulators' node so each regulator can be configured differently. Signed-off-by: Marco Felsch --- Documentation/devicetree/bindings/mfd/da9062.txt | 9 + 1

[PATCH 4/5] dt-bindings: mfd: da9062: add regulator gpio enable/disable documentation

2019-09-17 Thread Marco Felsch
At the gpio-based regulator enable/disable documentation. This property can be applied to each subnode within the 'regulators' node so each regulator can be configured differently. Signed-off-by: Marco Felsch --- Documentation/devicetree/bindings/mfd/da9062.txt | 7 +++ 1 file changed, 7

[PATCH 0/5] DA9062 PMIC fixes and features

2019-09-17 Thread Marco Felsch
Hi, the main purpose of this serie is to add the voltage selection support upon a given gpio input signal and to dis-/enable a regulator upon a gpio input signal. This series depends on [1]. [1] https://patchwork.ozlabs.org/project/linux-gpio/list/?series=131029 Regards, Marco Marco Felsch

[PATCH 5/5] regulator: da9062: add gpio based regulator dis-/enable support

2019-09-17 Thread Marco Felsch
the support to disable/enable the regulator based on a gpio input signal. Signed-off-by: Marco Felsch --- drivers/regulator/da9062-regulator.c | 84 +++- 1 file changed, 82 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/da9062-regulator.c b/drivers

[PATCH 1/5] regulator: da9062: fix suspend_enable/disable preparation

2019-09-17 Thread Marco Felsch
Signed-off-by: Marco Felsch --- drivers/regulator/da9062-regulator.c | 118 +++ 1 file changed, 47 insertions(+), 71 deletions(-) diff --git a/drivers/regulator/da9062-regulator.c b/drivers/regulator/da9062-regulator.c index 2ffc64622451..9b2ca472f70c 100644 --- a/drivers

Re: [PATCH 3/5] regulator: da9062: add voltage selection gpio support

2019-09-17 Thread Marco Felsch
> [cannot apply to v5.3 next-20190916] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Marco-Felsch/DA9062-PMIC-fixes-and-features/20190917-205911 > config: x86

[PATCH 1/3] regulator: core: fix boot-on regulators use_count usage

2019-09-17 Thread Marco Felsch
_register(). Signed-off-by: Marco Felsch --- drivers/regulator/core.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index e0c0cf462004..f9444f509440 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c

[PATCH 2/3] regulator: of: fix suspend-min/max-voltage parsing

2019-09-17 Thread Marco Felsch
. I don't know if it isn't tested but it can't work without this fix. Fixes: f7efad10b5c4 ("regulator: add PM suspend and resume hooks") Signed-off-by: Marco Felsch --- drivers/regulator/of_regulator.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH 0/3] Regulator core fixes

2019-09-17 Thread Marco Felsch
, Marco Marco Felsch (3): regulator: core: fix boot-on regulators use_count usage regulator: of: fix suspend-min/max-voltage parsing regulator: core: make regulator_register() EPROBE_DEFER aware drivers/regulator/core.c | 18 ++ drivers/regulator/of_regulator.c | 27

[PATCH 3/3] regulator: core: make regulator_register() EPROBE_DEFER aware

2019-09-17 Thread Marco Felsch
Sometimes it can happen that the regulator_of_get_init_data() can't retrieve the config due to a not probed device the regulator depends on. Fix that by checking the return value of of_parse_cb() and return EPROBE_DEFER in such cases. Signed-off-by: Marco Felsch --- drivers/regulator/core.c

Re: [PATCH 3/3] regulator: core: make regulator_register() EPROBE_DEFER aware

2019-09-18 Thread Marco Felsch
On 19-09-17 17:57, Dmitry Torokhov wrote: > On Tue, Sep 17, 2019 at 4:42 PM Marco Felsch wrote: > > > > Sometimes it can happen that the regulator_of_get_init_data() can't > > retrieve the config due to a not probed device the regulator depends on. > > Fix that b

Re: [PATCH 1/5] regulator: da9062: fix suspend_enable/disable preparation

2019-09-18 Thread Marco Felsch
Hi Adam, On 19-09-18 12:41, Adam Thomson wrote: > On 17 September 2019 13:43, Marco Felsch wrote: > > > Currently the suspend reg_field maps to the pmic voltage selection bits > > and is used during suspend_enabe/disable() and during get_mode(). This > > seems to be

Re: [PATCH 3/3] regulator: core: make regulator_register() EPROBE_DEFER aware

2019-09-18 Thread Marco Felsch
On 19-09-18 08:53, Dmitry Torokhov wrote: > On Wed, Sep 18, 2019 at 1:18 AM Marco Felsch wrote: > > > > On 19-09-17 17:57, Dmitry Torokhov wrote: > > > On Tue, Sep 17, 2019 at 4:42 PM Marco Felsch > > > wrote: > > > > > > > > Sometimes

Re: [PATCH 1/2] arm64: dts: Add a device tree for the Librem5 phone

2020-05-27 Thread Marco Felsch
Hi Martin, On 20-05-14 17:57, Martin Kepplinger wrote: > From: "Angus Ainslie (Purism)" > > Add a devicetree description for the Librem 5 phone. The early batches > that have been sold are supported as well as the mass-produced device > available later this year, see

Re: [PATCH 2/2] MAINTAINERS: Add Purism Librem 5 section to the list

2020-05-27 Thread Marco Felsch
On 20-05-14 17:57, Martin Kepplinger wrote: > Add development information for the devicetree files for hardware > by Purism SPC. > > Signed-off-by: Martin Kepplinger > --- > MAINTAINERS | 8 > 1 file changed, 8 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index

Re: [PATCH 6/6] media: i2c: Convert to new i2c device probe()

2019-07-11 Thread Marco Felsch
Hi Kieran, On 19-07-10 22:51, Kieran Bingham wrote: > The I2C core framework provides a simplified probe framework from commit > b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() call-back type"). > > These drivers do not utilise the i2c_device_id table in the probe, so we > can easily

Re: [PATCH 6/6] media: i2c: Convert to new i2c device probe()

2019-07-12 Thread Marco Felsch
Hi Kieran, On 19-07-11 09:18, Kieran Bingham wrote: > Hi Marco, > > Thank you for reviewing this topic, > > On 11/07/2019 09:05, Marco Felsch wrote: > > Hi Kieran, > > > > On 19-07-10 22:51, Kieran Bingham wrote: > >> The I2C core framework provide

Re: [PATCH] arm: dts: imx6qdl: add gpio expander pca9535

2019-07-12 Thread Marco Felsch
Hi, On 19-07-12 14:45, Gilles DOFFE wrote: > The pca9535 gpio expander is present on the Rex baseboard, but missing > from the dtsi. > > Add the new gpio controller and the associated interrupt line > MX6QDL_PAD_NANDF_CS3__GPIO6_IO16. > > Signed-off-by: Gilles DOFFE > --- >

Re: [PATCH 0/3] Add DSP node on i.MX8QXP board

2019-07-19 Thread Marco Felsch
Hi Daniel, thanks for your patches :) but it's quite common to bundle the driver related and the dt related patches. Can you add the firmware related patch to this series in your v2? Regards, Marco On 19-07-18 18:13, Daniel Baluta wrote: > i.MX8QXP boards feature an Hifi4 DSP from Tensilica.

Re: [PATCH v2] arm: dts: imx6qdl: add gpio expander pca9535

2019-07-22 Thread Marco Felsch
Hi Gilles, can you adapt the patch title, I assumed that the base dtsi is adding a gpio-expander which makes no sense. On 19-07-19 12:46, Gilles DOFFE wrote: > The pca9535 gpio expander is present on the Rex baseboard, but missing > from the dtsi. > > Add the new gpio controller and the

Re: [PATCH] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-09-26 Thread Marco Felsch
Hi Anson, On 19-09-26 08:03, Anson Huang wrote: > Hi, Marco > > > On 19-09-25 18:07, Anson Huang wrote: > > > The SCU firmware does NOT always have return value stored in message > > > header's function element even the API has response data, those > > > special APIs are defined as void function

Re: [PATCH 2/5] dt-bindings: mfd: da9062: add regulator voltage selection documentation

2019-09-26 Thread Marco Felsch
On 19-09-26 10:17, Adam Thomson wrote: > On 26 September 2019 09:10, Marco Felsch wrote: > > > On 19-09-25 16:18, Adam Thomson wrote: > > > On 25 September 2019 16:52, Marco Felsch wrote: > > > > > > > Hi Adam, > > > > > > > > On

Re: [PATCH 2/5] dt-bindings: mfd: da9062: add regulator voltage selection documentation

2019-09-26 Thread Marco Felsch
On 19-09-26 14:04, Adam Thomson wrote: > On 26 September 2019 12:44, Marco Felsch wrote: > > > On 19-09-26 10:17, Adam Thomson wrote: > > > On 26 September 2019 09:10, Marco Felsch wrote: > > > > > > > On 19-09-25 16:18, Adam Thomson wrote: > > >

Re: [PATCH 1/3] regulator: core: fix boot-on regulators use_count usage

2019-09-27 Thread Marco Felsch
Hi Doug, Mark, sorry for the delay.. On 19-09-26 12:44, Doug Anderson wrote: > Hi, > > On Tue, Sep 24, 2019 at 11:28 AM Mark Brown wrote: > > On Mon, Sep 23, 2019 at 03:40:09PM -0700, Doug Anderson wrote: > > > On Mon, Sep 23, 2019 at 11:49 AM Mark Brown wrote: > > > > On Mon, Sep 23, 2019 at

Re: [PATCH] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-09-27 Thread Marco Felsch
Hi Anson, Leonard, On 19-09-27 01:20, Anson Huang wrote: > Hi, Leonard > > > On 2019-09-26 1:06 PM, Marco Felsch wrote: > > > On 19-09-26 08:03, Anson Huang wrote: > > >>> On 19-09-25 18:07, Anson Huang wrote: > > >>>> The SCU firmware does N

Re: [PATCH 2/3] dt-bindings: arm: fsl: add compatible string for Kobo Clara HD

2019-09-27 Thread Marco Felsch
Hi Andreas, On 19-09-27 08:14, Andreas Kemnade wrote: > This adds a compatible string fro the Kobo Clara HD eBook reader. > > Signed-off-by: Andreas Kemnade > --- Just a nitpick, this should be patch number 1. Regards, Marco > Documentation/devicetree/bindings/arm/fsl.yaml | 1 + > 1 file

Re: [PATCH 1/3] ARM: dts: add Netronix E60K02 board common file

2019-09-27 Thread Marco Felsch
Hi Andreas, thanks for the patch. On 19-09-27 08:14, Andreas Kemnade wrote: > The Netronix board E60K02 can be found some several Ebook-Readers, > at least the Kobo Clara HD and the Tolino Shine 3. The board > is equipped with different SoCs. > > For now the following peripherals are included:

Re: [PATCH] iio: adc: imx25-gcq: Variable could be uninitialized if regmap_read() fails

2019-09-30 Thread Marco Felsch
Hi Yizhuo, thanks for your patch. On 19-09-27 17:28, Yizhuo wrote: > In function mx25_gcq_irq(), local variable "stats" could > be uninitialized if function regmap_read() returns -EINVAL. > However, this value is used in if statement, which is > potentially unsafe. The same case applied to the

Re: [PATCH] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-09-30 Thread Marco Felsch
Hi Anson, Leonard, On 19-09-30 07:42, Anson Huang wrote: > Hi, Leonard > > > On 2019-09-27 4:20 AM, Anson Huang wrote: > > >> On 2019-09-26 1:06 PM, Marco Felsch wrote: > > >>> On 19-09-26 08:03, Anson Huang wrote: > > >>>>> On 19-09-2

Re: [PATCH 1/3] ARM: dts: add Netronix E60K02 board common file

2019-09-30 Thread Marco Felsch
Hi Andreas, On 19-09-27 21:08, Andreas Kemnade wrote: > Hi Marco, > > On Fri, 27 Sep 2019 11:47:21 +0200 > Marco Felsch wrote: > > > Hi Andreas, > > > > thanks for the patch. > > > thanks for the quick review. Most of your comments are clear. &

Re: [PATCH] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-09-30 Thread Marco Felsch
Hi Anson, On 19-09-30 08:32, Anson Huang wrote: > Hi, Marco > > > On 19-09-30 07:42, Anson Huang wrote: > > > Hi, Leonard > > > > > > > On 2019-09-27 4:20 AM, Anson Huang wrote: > > > > >> On 2019-09-26 1:06 PM, Marco Fe

Re: [PATCH v2] arm: dts: imx6qdl: add gpio expander pca9535

2019-09-12 Thread Marco Felsch
Hi Gilles, On 19-09-12 06:01, Gilles Doffe wrote: > Hi Marco, > > Thanks for your reply and sorry about the delay. No worries ;) > - Le 22 Juil 19, à 9:53, Marco Felsch m.fel...@pengutronix.de a écrit : > > > Hi Gilles, > > > > can you adapt the patch ti

Re: [PATCH 2/5] dt-bindings: mfd: da9062: add regulator voltage selection documentation

2019-10-02 Thread Marco Felsch
On 19-09-30 09:53, Adam Thomson wrote: > On 26 September 2019 15:39, Marco Felsch wrote: > > > On 19-09-26 14:04, Adam Thomson wrote: > > > On 26 September 2019 12:44, Marco Felsch wrote: > > > > > > > On 19-09-26 10:17, Adam Thomson wrote: > > >

Re: [PATCH v2 1/2] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q

2019-08-28 Thread Marco Felsch
Hi Robin, thanks for the patch. On 19-08-27 14:32, Robin van der Gracht wrote: > The first generation i.MX6 processors does not send an interrupt when the > power key is pressed. It sends a power down request interrupt if the key is > released before a hard shutdown (5 second press). This should

Re: [PATCHv5 1/2] ARM: dts: imx6ul: Add Variscite DART-6UL SoM support

2019-08-29 Thread Marco Felsch
Hi Oliver, thanks for the patch. On 19-08-28 18:19, Oliver Graute wrote: > This patch adds support for the i.MX6UL variant of the Variscite DART-6UL > SoM Carrier-Board > > Signed-off-by: Oliver Graute > Cc: Shawn Guo > Cc: Neil Armstrong > --- >

Re: [PATCHv5 2/2] ARM: dts: Add support for i.MX6 UltraLite DART Variscite Customboard

2019-08-29 Thread Marco Felsch
Hi Oliver, On 19-08-28 18:19, Oliver Graute wrote: > This patch adds DeviceTree Source for the i.MX6 UltraLite DART NAND/WIFI > > Signed-off-by: Oliver Graute > Cc: Shawn Guo > Cc: Neil Armstrong > --- > arch/arm/boot/dts/Makefile | 1 + >

Re: [PATCH v2 1/2] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q

2019-08-29 Thread Marco Felsch
Hi Robin, On 19-08-29 09:24, robin wrote: > Hi Marco, > > On 2019-08-28 11:15, Marco Felsch wrote: > > Hi Robin, > > > > thanks for the patch. > > > > On 19-08-27 14:32, Robin van der Gracht wrote: > > > The first generation i.MX6

Re: [PATCH v2 1/2] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q

2019-08-29 Thread Marco Felsch
On 19-08-29 09:11, Robin Gong wrote: > > On 2019-08-29 16:17, Marco Felsch wrote: > > > > While reading the rm it seems that > > > > the snvs block has a dedicated version register. IMHO this could be > > > > a better way to apply the change also to

Re: [PATCH V2] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-10-07 Thread Marco Felsch
Hi Anson, On 19-10-07 09:15, Anson Huang wrote: > The SCU firmware does NOT always have return value stored in message > header's function element even the API has response data, those special > APIs are defined as void function in SCU firmware, so they should be > treated as return success

Re: [PATCH] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-10-07 Thread Marco Felsch
On 19-10-07 01:21, Anson Huang wrote: > Hi, Marco > > > On 19-09-30 08:32, Anson Huang wrote: > > > Hi, Marco > > > > > > > On 19-09-30 07:42, Anson Huang wrote: > > > > > Hi, Leonard > > > > > > > > > >

Re: [PATCH 3/5] regulator: da9062: add voltage selection gpio support

2019-10-07 Thread Marco Felsch
On 19-10-04 21:41, Linus Walleij wrote: > On Tue, Sep 17, 2019 at 2:43 PM Marco Felsch wrote: > > > + /* > > +* We only must ensure that the gpio device is probed before the > > +* regulator driver so no need to store the reference global. > >

Re: [PATCH 1/3] regulator: core: fix boot-on regulators use_count usage

2019-10-07 Thread Marco Felsch
Hi Doug, Mark, On 19-10-01 12:57, Doug Anderson wrote: > Hi, > > On Fri, Sep 27, 2019 at 1:47 AM Marco Felsch wrote: > > > > > > It should be possible to do a regulator_disable() though I'm not > > > > > > sure anyone actually uses that. The patt

Re: [PATCH 1/3] regulator: core: fix boot-on regulators use_count usage

2019-10-08 Thread Marco Felsch
On 19-10-07 19:29, Mark Brown wrote: > On Mon, Oct 07, 2019 at 11:34:29AM +0200, Marco Felsch wrote: > > > Sorry that won't fix my problem. If I drop the regulator-boot-on state > > the fixed-regulator will disable this regulator but disable/enable this > > regulator is o

Re: [PATCH 1/3] regulator: core: fix boot-on regulators use_count usage

2019-10-08 Thread Marco Felsch
On 19-10-08 13:51, Mark Brown wrote: > On Tue, Oct 08, 2019 at 08:03:11AM +0200, Marco Felsch wrote: > > On 19-10-07 19:29, Mark Brown wrote: > > > On Mon, Oct 07, 2019 at 11:34:29AM +0200, Marco Felsch wrote: > > > > > Sorry that won't fix my problem. If I

Re: [PATCH 1/3] regulator: core: fix boot-on regulators use_count usage

2019-10-08 Thread Marco Felsch
On 19-10-08 16:42, Mark Brown wrote: > On Tue, Oct 08, 2019 at 04:56:05PM +0200, Marco Felsch wrote: > > On 19-10-08 13:51, Mark Brown wrote: > > > > No, we shouldn't do anything when the regulator probes - we'll only > > > disable unused regulators when we get to

Re: [PATCH 1/3] regulator: core: fix boot-on regulators use_count usage

2019-10-08 Thread Marco Felsch
On 19-10-08 17:23, Mark Brown wrote: > On Tue, Oct 08, 2019 at 06:16:40PM +0200, Marco Felsch wrote: > > On 19-10-08 16:42, Mark Brown wrote: > > > > If this is a GPIO regulator then the Linux APIs mean you can't read the > > > status back so it's one of the regu

Re: [PATCH V2] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-10-09 Thread Marco Felsch
Hi Anson, On 19-10-08 00:48, Anson Huang wrote: > Hi, Marco > > > On 19-10-07 09:15, Anson Huang wrote: > > > The SCU firmware does NOT always have return value stored in message > > > header's function element even the API has response data, those > > > special APIs are defined as void function

Re: [PATCH V2] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-10-09 Thread Marco Felsch
On 19-10-09 08:28, Anson Huang wrote: > Hi, Marco > > > On 19-10-08 00:48, Anson Huang wrote: > > > Hi, Marco > > > > > > > On 19-10-07 09:15, Anson Huang wrote: > > > > > The SCU firmware does NOT always have return value stored in > > > > > message header's function element even the API has

Re: [PATCH V2] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-10-09 Thread Marco Felsch
Hi Anson, On 19-10-07 09:15, Anson Huang wrote: > The SCU firmware does NOT always have return value stored in message > header's function element even the API has response data, those special > APIs are defined as void function in SCU firmware, so they should be > treated as return success

Re: [PATCH V2] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-10-09 Thread Marco Felsch
ex for misc_get_control() RPC call */ > #define MISC_FUNC_SET_MAX_DMA_GROUP 4U /* Index for misc_set_max_dma_group() > RPC call */ Ahh, okay get it. Thanks for the explanation. > > > > > + saved_func = ((struct imx_sc_rpc_msg *)msg)->func; > > > > Nit

Re: [PATCH v2] media: imx7-mipi-csis: Add a check for devm_regulator_get

2019-10-17 Thread Marco Felsch
Hi Rui, On 19-10-16 14:43, Rui Miguel Silva wrote: > Hi Marco, > On Wed 16 Oct 2019 at 10:06, Marco Felsch wrote: > > Hi Chuhong, > > > > On 19-10-15 21:59, Chuhong Yuan wrote: > >> devm_regulator_get may return an error but mipi_csis_phy_init misses > &

  1   2   3   >