Re: [Announce] [patch] Modular Scheduler Core and Completely Fair Scheduler [CFS]

2007-04-16 Thread Matt Mackall
On Mon, Apr 16, 2007 at 05:03:49AM +0200, Nick Piggin wrote: I'd prefer if we kept a single CPU scheduler in mainline, because I think that simplifies analysis and focuses testing. I think you'll find something like 80-90% of the testing will be done on the default choice, even if other choices

Re: [BUG] netconsole hangs machine 2.6.20

2007-04-16 Thread Matt Mackall
[cc:ed to netdev] On Sun, Apr 15, 2007 at 10:45:37PM -0700, Mike Mattie wrote: Hello, netconsole is hanging my box during IDE init. I am running 2.6.20.7, config is attached from /proc Without using netconsole the kernel boots fine. I am writing this message from it. When I do

Re: [Announce] [patch] Modular Scheduler Core and Completely Fair Scheduler [CFS]

2007-04-17 Thread Matt Mackall
On Tue, Apr 17, 2007 at 05:31:20AM +0200, Nick Piggin wrote: On Mon, Apr 16, 2007 at 09:28:24AM -0500, Matt Mackall wrote: On Mon, Apr 16, 2007 at 05:03:49AM +0200, Nick Piggin wrote: I'd prefer if we kept a single CPU scheduler in mainline, because I think that simplifies analysis

Thinkpads not waking up on lid open with -rc6-mm1

2007-04-17 Thread Matt Mackall
Both my T30 and R51 aren't waking up when I open the lid any more. I have to hold down the power button for a moment. On my R51, I see this: $ cat /proc/acpi/wakeup Device S-state Status Sysfs node LID S3*enabled SLPB S3*enabled PCI0 S3 disabled no-bus:pci:00

Re: [PATCH 6/13] maps#2: Move the page walker code to lib/

2007-04-17 Thread Matt Mackall
On Wed, Apr 11, 2007 at 04:35:44PM +1000, Nick Piggin wrote: Matt Mackall wrote: Move the page walker code to lib/ This lets it get shared outside of proc/ and linked in only when needed. Still should go into mm/ If it had, you might have also noticed your pagetable walking code

Re: [patch 20/20] Add apply_to_page_range() which applies a function to a pte range.

2007-04-17 Thread Matt Mackall
On Wed, Apr 04, 2007 at 11:52:57PM -0700, Jeremy Fitzhardinge wrote: Matt Mackall wrote: +/* + * Scan a region of virtual memory, filling in page tables as necessary + * and calling a provided function on each leaf page table. + */ But I'm not sure what the use case

Re: [Announce] [patch] Modular Scheduler Core and Completely Fair Scheduler [CFS]

2007-04-17 Thread Matt Mackall
On Tue, Apr 17, 2007 at 09:01:55AM +0200, Nick Piggin wrote: On Mon, Apr 16, 2007 at 11:26:21PM -0700, William Lee Irwin III wrote: On Mon, Apr 16, 2007 at 11:09:55PM -0700, William Lee Irwin III wrote: All things are not equal; they all have different properties. I like On Tue, Apr 17,

Re: [Announce] [patch] Modular Scheduler Core and Completely Fair Scheduler [CFS]

2007-04-17 Thread Matt Mackall
On Tue, Apr 17, 2007 at 11:24:22AM +0200, Ingo Molnar wrote: * William Lee Irwin III [EMAIL PROTECTED] wrote: [...] Also rest assured that the tone of the critique is not hostile, and wasn't meant to sound that way. ok :) (And i guess i was too touchy - sorry about coming out

Re: [Announce] [patch] Modular Scheduler Core and Completely Fair Scheduler [CFS]

2007-04-17 Thread Matt Mackall
at 05:08:09PM -0500, Matt Mackall wrote: How's this: If you're running two identical CPU hog tasks A and B differing only by nice level (Anice, Bnice), the ratio cputime(A)/cputime(B) should be a constant f(Anice - Bnice). Other definitions make things hard to analyze and probably not well

Re: [Announce] [patch] Modular Scheduler Core and Completely Fair Scheduler [CFS]

2007-04-17 Thread Matt Mackall
others start saying they want something different and agree. On Tue, Apr 17, 2007 at 05:39:09PM -0500, Matt Mackall wrote: Good. This has a couple nice mathematical properties, including bounded unfairness which I mentioned earlier. What base are you looking at? I'm working

Re: slab allocators: Remove obsolete SLAB_MUST_HWCACHE_ALIGN

2007-04-17 Thread Matt Mackall
that changed? But if SLAB is using the other define now, I'm happy to switch. Signed-off-by: Christoph Lameter [EMAIL PROTECTED] Signed-off-by: Matt Mackall [EMAIL PROTECTED] -- Mathematics is the supreme nostalgia of our time. - To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [Announce] [patch] Modular Scheduler Core and Completely Fair Scheduler [CFS]

2007-04-17 Thread Matt Mackall
On Wed, Apr 18, 2007 at 09:23:42AM +1000, Peter Williams wrote: Matt Mackall wrote: On Tue, Apr 17, 2007 at 09:01:55AM +0200, Nick Piggin wrote: On Mon, Apr 16, 2007 at 11:26:21PM -0700, William Lee Irwin III wrote: On Mon, Apr 16, 2007 at 11:09:55PM -0700, William Lee Irwin III wrote: All

Re: [Announce] [patch] Modular Scheduler Core and Completely Fair Scheduler [CFS]

2007-04-17 Thread Matt Mackall
On Wed, Apr 18, 2007 at 05:15:11AM +0200, Nick Piggin wrote: On Tue, Apr 17, 2007 at 04:39:54PM -0500, Matt Mackall wrote: On Tue, Apr 17, 2007 at 09:01:55AM +0200, Nick Piggin wrote: On Mon, Apr 16, 2007 at 11:26:21PM -0700, William Lee Irwin III wrote: On Mon, Apr 16, 2007 at 11:09

Re: [Announce] [patch] Modular Scheduler Core and Completely Fair Scheduler [CFS]

2007-04-18 Thread Matt Mackall
On Wed, Apr 18, 2007 at 07:00:24AM +0200, Nick Piggin wrote: It's also not yet clear that a scheduler can't be taught to do the right thing with X without fiddling with nice levels. Being fair doesn't prevent that. Implicit unfairness is wrong though, because it will bite people. What's

Re: [Announce] [patch] Modular Scheduler Core and Completely Fair Scheduler [CFS]

2007-04-18 Thread Matt Mackall
On Wed, Apr 18, 2007 at 08:37:11AM +0200, Nick Piggin wrote: I don't know how that supports your argument for unfairness, I never had such an argument. I like fairness. My argument is that -you- don't have an argument for making fairness a -requirement-. processes are special only because

Re: [Announce] [patch] Modular Scheduler Core and Completely Fair Scheduler [CFS]

2007-04-18 Thread Matt Mackall
On Wed, Apr 18, 2007 at 07:48:21AM -0700, Linus Torvalds wrote: And fairness by euid is probably a hell of a lot easier to do than trying to figure out the wakeup matrix. For the record, you actually don't need to track a whole NxN matrix (or do the implied O(n**3) matrix inversion!) to get to

Re: [PATCH 12/13] maps#2: Add /proc/pid/pagemap interface

2007-04-19 Thread Matt Mackall
On Thu, Apr 19, 2007 at 12:12:29PM -0700, Dave Hansen wrote: On Fri, 2007-04-06 at 17:03 -0500, Matt Mackall wrote: +static int pagemap_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end, +void *private) +{ + struct pagemapread *pm = private

Re: [patch 20/20] Add apply_to_page_range() which applies a function to a pte range.

2007-04-19 Thread Matt Mackall
On Thu, Apr 19, 2007 at 12:44:57PM -0700, Jeremy Fitzhardinge wrote: Matt Mackall wrote: I think adding a flags field and an allocate flag to my callback struct would be sufficient here. Yes, probably. What about something that wants to shatter superpages? Haven't thought a huge

Re: [PATCH 13/13] maps#2: Add /proc/kpagemap interface

2007-04-19 Thread Matt Mackall
On Thu, Apr 19, 2007 at 12:06:38PM -0700, Dave Hansen wrote: On Fri, 2007-04-06 at 17:03 -0500, Matt Mackall wrote: +static ssize_t kpagemap_read(struct file *file, char __user *buf, +size_t count, loff_t *ppos) +{ ... + for (; i 2 * chunk

Re: [patch 20/20] Add apply_to_page_range() which applies a function to a pte range.

2007-04-19 Thread Matt Mackall
On Thu, Apr 19, 2007 at 02:37:53PM -0700, Jeremy Fitzhardinge wrote: Matt Mackall wrote: Haven't thought a huge amount about that. Perhaps it's best done with the level 3 callback? Level 2, I think, assuming you count the pte pages as level 1. I think it can be dealt with, so long

Re: [RFC][PATCH -mm take4 2/6] support multiple logging

2007-04-20 Thread Matt Mackall
On Fri, Apr 20, 2007 at 11:15:26AM -0700, Andrew Morton wrote: On Fri, 20 Apr 2007 18:51:13 +0900 Keiichi KII [EMAIL PROTECTED] wrote: I started to do some cleanups and fixups here, but abandoned it when it was all getting a bit large. Here are some fixes against this patch:

Re: Renice X for cpu schedulers

2007-04-24 Thread Matt Mackall
On Tue, Apr 24, 2007 at 08:50:20AM -0700, Ray Lee wrote: Firstly, lots of clients in your list are remote. X usually isn't. They really aren't, unless you happen to work somewhere that can afford to dedicate a box to a db, which suddenly makes the scheduler a dull topic. For example, I

Re: [RFC 4/8] Enhance fallback functions in libs to support higher order pages

2007-04-24 Thread Matt Mackall
On Fri, Apr 20, 2007 at 12:10:43PM -0700, Christoph Lameter wrote: On Fri, 20 Apr 2007, Dave Kleikamp wrote: On Fri, 2007-04-20 at 12:05 +0100, Mel Gorman wrote: comments about missing page_cache_size() covered elsewhere. However, I note that Dave Kleikamp might be interested in this

2.6.21-rc3-mm1 RSDL results

2007-03-08 Thread Matt Mackall
First off, let me say that I think your approach has great promise, but I'm afraid it doesn't work so well here yet. Box is an R51 Thinkpad, 1.7GHz Pentium M. I'm using a make -j 5 as a test load. With 2.6.21-rc2-mm2, I get slightly sluggish response for opening new terminals, scrolling in

Re: 2.6.21-rc3-mm1 RSDL results

2007-03-09 Thread Matt Mackall
On Fri, Mar 09, 2007 at 05:28:03PM +1100, Con Kolivas wrote: On Friday 09 March 2007 16:39, Matt Mackall wrote: First off, let me say that I think your approach has great promise, but I'm afraid it doesn't work so well here yet. Box is an R51 Thinkpad, 1.7GHz Pentium M. I'm using a make

Re: 2.6.21-rc3-mm1 RSDL results

2007-03-09 Thread Matt Mackall
On Fri, Mar 09, 2007 at 01:53:58AM -0600, Matt Mackall wrote: On Fri, Mar 09, 2007 at 05:28:03PM +1100, Con Kolivas wrote: On Friday 09 March 2007 16:39, Matt Mackall wrote: First off, let me say that I think your approach has great promise, but I'm afraid it doesn't work so well here yet

Re: 2.6.21-rc3-mm1 RSDL results

2007-03-09 Thread Matt Mackall
On Fri, Mar 09, 2007 at 07:39:05PM +1100, Con Kolivas wrote: On Friday 09 March 2007 19:20, Matt Mackall wrote: And I've just rebooted with NO_HZ and things are greatly improved. At idle, Beryl effects are silky smooth (possibly better than stock) and shows less load. Under 'make', Beryl

Re: 2.6.21-rc3-mm1 RSDL results

2007-03-09 Thread Matt Mackall
On Fri, Mar 09, 2007 at 07:39:05PM +1100, Con Kolivas wrote: On Friday 09 March 2007 19:20, Matt Mackall wrote: And I've just rebooted with NO_HZ and things are greatly improved. At idle, Beryl effects are silky smooth (possibly better than stock) and shows less load. Under 'make', Beryl

Re: 2.6.21-rc3-mm1 RSDL results

2007-03-09 Thread Matt Mackall
On Sat, Mar 10, 2007 at 07:26:15AM +1100, Con Kolivas wrote: How odd. I would have thought that if an interaction was to occur it would have been without the new feature. Clearly what you describe without NO_HZ is not the expected behaviour with RSDL. I wonder what went wrong. Are you on

Re: 2.6.21-rc3-mm1 RSDL results

2007-03-09 Thread Matt Mackall
On Sat, Mar 10, 2007 at 07:15:38AM +1100, Con Kolivas wrote: How odd. I would have thought that if an interaction was to occur it would have been without the new feature. Clearly what you describe without NO_HZ is not the expected behaviour with RSDL. I wonder what went wrong. Are you on

Re: 2.6.21-rc3-mm1 RSDL results

2007-03-09 Thread Matt Mackall
On Fri, Mar 09, 2007 at 02:46:24PM -0600, Matt Mackall wrote: A priori, this load should be manageable by RSDL as the interactive loads are all pretty small. So I wrote a little Python script that basically continuously memcpys some 16MB chunks of memory: #!/usr/bin/python a = a * 16 * 1024

Re: 2.6.21-rc3-mm1 RSDL results

2007-03-09 Thread Matt Mackall
On Sat, Mar 10, 2007 at 08:19:18AM +1100, Con Kolivas wrote: On Saturday 10 March 2007 08:07, Con Kolivas wrote: On Saturday 10 March 2007 07:46, Matt Mackall wrote: My suspicion is the problem lies in giving too much quanta to newly-started processes. Ah that's some nice detective

Re: 2.6.21-rc3-mm1 RSDL results

2007-03-09 Thread Matt Mackall
On Sat, Mar 10, 2007 at 09:12:07AM +1100, Con Kolivas wrote: On Saturday 10 March 2007 08:57, Willy Tarreau wrote: On Fri, Mar 09, 2007 at 03:39:59PM -0600, Matt Mackall wrote: On Sat, Mar 10, 2007 at 08:19:18AM +1100, Con Kolivas wrote: On Saturday 10 March 2007 08:07, Con Kolivas wrote

Re: 2.6.21-rc3-mm1 RSDL results

2007-03-09 Thread Matt Mackall
On Sat, Mar 10, 2007 at 09:18:05AM +1100, Con Kolivas wrote: On Saturday 10 March 2007 08:57, Con Kolivas wrote: On Saturday 10 March 2007 08:39, Matt Mackall wrote: On Sat, Mar 10, 2007 at 08:19:18AM +1100, Con Kolivas wrote: On Saturday 10 March 2007 08:07, Con Kolivas wrote

Re: 2.6.21-rc3-mm1 RSDL results

2007-03-09 Thread Matt Mackall
On Sat, Mar 10, 2007 at 10:02:37AM +1100, Con Kolivas wrote: On Saturday 10 March 2007 09:29, Matt Mackall wrote: On Sat, Mar 10, 2007 at 09:18:05AM +1100, Con Kolivas wrote: On Saturday 10 March 2007 08:57, Con Kolivas wrote: On Saturday 10 March 2007 08:39, Matt Mackall wrote: So

Re: 2.6.21-rc3-mm1 RSDL results

2007-03-09 Thread Matt Mackall
On Sat, Mar 10, 2007 at 11:34:26AM +1100, Con Kolivas wrote: On Saturday 10 March 2007 09:29, Matt Mackall wrote: On Sat, Mar 10, 2007 at 09:18:05AM +1100, Con Kolivas wrote: On Saturday 10 March 2007 08:57, Con Kolivas wrote: On Saturday 10 March 2007 08:39, Matt Mackall wrote

Re: 2.6.21-rc3-mm1 RSDL results

2007-03-09 Thread Matt Mackall
On Sat, Mar 10, 2007 at 12:02:25PM +1100, Con Kolivas wrote: On Saturday 10 March 2007 09:12, Con Kolivas wrote: On Saturday 10 March 2007 08:57, Willy Tarreau wrote: On Fri, Mar 09, 2007 at 03:39:59PM -0600, Matt Mackall wrote: On Sat, Mar 10, 2007 at 08:19:18AM +1100, Con Kolivas wrote

Re: 2.6.21-rc3-mm1 RSDL results

2007-03-09 Thread Matt Mackall
On Sat, Mar 10, 2007 at 12:28:38PM +1100, Con Kolivas wrote: On Saturday 10 March 2007 11:49, Matt Mackall wrote: On Sat, Mar 10, 2007 at 11:34:26AM +1100, Con Kolivas wrote: Ok, so some of the basics then. Can you please give me the output of 'top -b' running for a few seconds during

Re: 2.6.21-rc3-mm1 RSDL results

2007-03-09 Thread Matt Mackall
On Sat, Mar 10, 2007 at 01:20:22PM +1100, Con Kolivas wrote: Progress at last! And without any patches! Well those look very reasonable to me. Especially since -j5 is a worst case scenario. Well that's with a noyield patch and your sched_tick fix. But would you say it's still _adequate_ with

Re: netconsole system freeze when cable unplugged

2007-03-10 Thread Matt Mackall
On Fri, Mar 09, 2007 at 09:42:43PM +0100, Francois Romieu wrote: Simon Arlott [EMAIL PROTECTED] : When I unplug the cable the system just stops responding to anything, at all. No message is printed to the console when the cable is plugged back in. rtl8139_interrupt (spin_lock(tp-lock))

Re: [PATCH] proc: maps protection

2007-03-10 Thread Matt Mackall
On Sat, Mar 10, 2007 at 04:21:01PM -0800, Andrew Morton wrote: On Sat, 10 Mar 2007 10:33:41 -0800 Kees Cook [EMAIL PROTECTED] wrote: Here's another revision, with both the can ptrace and the global /proc knob; We'd be needing a changelog for that. Please update the procfs

RSDL-mm 0.28

2007-03-10 Thread Matt Mackall
I've tested -mm2 against -mm2+noyield and -mm2+rsdl+noyield. The noyield patch simply makes the sched_yield syscall return immediately. Xorg and all tests are run at nice 0. Loads: memload: constant memcpy of 16MB buffer execload: constant re-exec of a trivial shell script forkload: constant

Re: RSDL-mm 0.28

2007-03-10 Thread Matt Mackall
On Sun, Mar 11, 2007 at 01:28:22PM +1100, Con Kolivas wrote: make -j 5 ccache berylok good awful galeon goodgood bad mp3 goodgood bad terminal goodgood bad/ok mousegoodgood bad/ok

Re: RSDL-mm 0.28

2007-03-10 Thread Matt Mackall
On Sat, Mar 10, 2007 at 10:01:32PM -0600, Matt Mackall wrote: On Sun, Mar 11, 2007 at 01:28:22PM +1100, Con Kolivas wrote: Ok I don't think there's any actual accounting problem here per se (although I did just recently post a bugfix for rsdl however I think that's unrelated). What I think

Re: [PATCH][RSDL-mm 0/7] RSDL cpu scheduler for 2.6.21-rc3-mm2

2007-03-13 Thread Matt Mackall
On Tue, Mar 13, 2007 at 10:33:18AM +0100, Mike Galbraith wrote: On Tue, 2007-03-13 at 09:18 +0100, Ingo Molnar wrote: Con, we want RSDL to /improve/ interactivity. Having new scheduler interactivity logic that behaves /worse/ in the presence of CPU hogs, which CPU hogs are even reniced

Re: 2.6.21rc suspend to ram regression on Lenovo X60

2007-03-13 Thread Matt Mackall
On Tue, Mar 13, 2007 at 12:08:28AM -0400, Dave Jones wrote: I spent considerable time over the last day or so bisecting to find out why an X60 stopped resuming somewhen between 2.6.20 and current -git. (Total lockup, black screen of death). The bisect log looked like this. ... Any ideas

Re: [QUICKLIST 0/4] Arch independent quicklists V2

2007-03-13 Thread Matt Mackall
On Tue, Mar 13, 2007 at 10:30:10AM -0700, Jeremy Fitzhardinge wrote: Nick Piggin wrote: However we still have to visit those to-be-unmapped parts of the page table, to find the pages and free them. So we still at least need to bring it into cache for the read... at which point, the

Re: [QUICKLIST 0/4] Arch independent quicklists V2

2007-03-13 Thread Matt Mackall
On Tue, Mar 13, 2007 at 01:17:00PM -0700, Jeremy Fitzhardinge wrote: Matt Mackall wrote: On Tue, Mar 13, 2007 at 10:30:10AM -0700, Jeremy Fitzhardinge wrote: Nick Piggin wrote: However we still have to visit those to-be-unmapped parts of the page table, to find the pages

Re: [QUICKLIST 0/4] Arch independent quicklists V2

2007-03-13 Thread Matt Mackall
On Tue, Mar 13, 2007 at 02:07:22PM -0700, David Miller wrote: From: Matt Mackall [EMAIL PROTECTED] Date: Tue, 13 Mar 2007 15:21:25 -0500 Because the fan-out is large, the bulk of the work is bringing the last layer of the tree into cache to find all the pages in the address space

Re: [PATCH 2/9] Sched clock paravirt op fix.patch

2007-03-16 Thread Matt Mackall
On Tue, Mar 13, 2007 at 02:05:11PM -0700, Jeremy Fitzhardinge wrote: Andi Kleen wrote: It depends -- under heavy network load you can spend a long time just processing interrupts. Well, in that case you probably don't want to charge them to the process which happens to be running at the

Re: [PATCH 00/22 take 3] UBI: Unsorted Block Images

2007-03-18 Thread Matt Mackall
On Wed, Mar 14, 2007 at 05:19:34PM +0200, Artem Bityutskiy wrote: Hello, This patch-set contains UBI, which stands for Unsorted Block Images. This is closely related to the memory technology devices Linux subsystem (MTD), so this new piece of software is from drivers/mtd/ubi. In short,

Re: [PATCH 00/22 take 3] UBI: Unsorted Block Images

2007-03-18 Thread Matt Mackall
On Sun, Mar 18, 2007 at 06:49:39PM +0200, Artem Bityutskiy wrote: On Sun, 2007-03-18 at 11:27 -0500, Matt Mackall wrote: Forgive my ignorance, but why did you not implement the two features above as device mapper layers instead? A device mapper can arbitrarily transform I/O addresses

Re: [PATCH 00/22 take 3] UBI: Unsorted Block Images

2007-03-19 Thread Matt Mackall
On Sun, Mar 18, 2007 at 03:31:50PM -0500, Josh Boyer wrote: On Sun, Mar 18, 2007 at 02:18:12PM -0500, Matt Mackall wrote: I'm well aware of all that. I wrote a NAND driver just last month. Let's consider this table: HARD drives MTD device Consists of sectors

Re: [PATCH 00/22 take 3] UBI: Unsorted Block Images

2007-03-19 Thread Matt Mackall
On Mon, Mar 19, 2007 at 01:16:28PM -0500, Josh Boyer wrote: On Mon, 2007-03-19 at 12:08 -0500, Matt Mackall wrote: If the end goal is to end up with something that looks like a block device (which seems to be implied by adding transparent wear leveling Nope, not the end goal

Re: [PATCH 00/22 take 3] UBI: Unsorted Block Images

2007-03-19 Thread Matt Mackall
On Mon, Mar 19, 2007 at 08:03:30PM +0100, Thomas Gleixner wrote: Matt, On Mon, 2007-03-19 at 12:08 -0500, Matt Mackall wrote: On Sun, Mar 18, 2007 at 03:31:50PM -0500, Josh Boyer wrote: On Sun, Mar 18, 2007 at 02:18:12PM -0500, Matt Mackall wrote: I'm well aware of all that. I

Re: [PATCH] slab: deal with NULL pointers passed to kmem_cache_free

2007-03-19 Thread Matt Mackall
On Mon, Mar 19, 2007 at 10:08:03AM -0700, Christoph Lameter wrote: On Mon, 19 Mar 2007, Pekka J Enberg wrote: This changes kmem_cache_free() to deal with NULL objects passed to it. The current behavior is inconsistent with kfree() so there are callers passing NULL to kmem_cache_free().

Re: [PATCH 00/22 take 3] UBI: Unsorted Block Images

2007-03-19 Thread Matt Mackall
On Mon, Mar 19, 2007 at 11:06:33PM +0200, Artem Bityutskiy wrote: On Mon, 2007-03-19 at 14:54 -0500, Matt Mackall wrote: The issue is 14000 lines of patch to make a parallel subsystem. Parallel system exists since very long. One is flash-SW_or_HW_FTL-all_blkdev_stuff. The other is MTD-JFFS2

Re: [PATCH] slab: deal with NULL pointers passed to kmem_cache_free

2007-03-19 Thread Matt Mackall
On Mon, Mar 19, 2007 at 02:16:01PM -0700, Christoph Lameter wrote: On Mon, 19 Mar 2007, Matt Mackall wrote: I think this sort of thing should work: a = kmalloc(...) b = kmem_cache_alloc(..) c = allocate_some_id(...) if (!a || !b || !c) { free_some_id(c) kmem_cache_free(c

Re: [PATCH] slab: deal with NULL pointers passed to kmem_cache_free

2007-03-19 Thread Matt Mackall
On Mon, Mar 19, 2007 at 02:41:00PM -0700, Andrew Morton wrote: On Mon, 19 Mar 2007 23:25:36 +0200 (EET) Pekka Enberg [EMAIL PROTECTED] wrote: On 3/19/2007, Andrew Morton [EMAIL PROTECTED] wrote: Would prefer to do: static inline void kmem_cache_free_if_not_null(struct kmem_cache

Re: [PATCH 00/22 take 3] UBI: Unsorted Block Images

2007-03-19 Thread Matt Mackall
On Mon, Mar 19, 2007 at 10:05:29PM +0100, Thomas Gleixner wrote: On Mon, 2007-03-19 at 14:54 -0500, Matt Mackall wrote: (UBI also has static volumes which LVM doesn't but that is an aside.) If a static volume is simply a non-dynamic volume, then device mapper can do that too

Re: [PATCH RESEND 1/1] crypto API: RSA algorithm patch (kernel version 2.6.20.1)

2007-03-19 Thread Matt Mackall
On Mon, Mar 19, 2007 at 06:22:15PM +0200, Tasos Parisinos wrote: +static inline _i32 rsa_max(_i32 x, _i32 y) +{ +return (x y)? x: y; +} We've got a max() already. Use tabs. + +/* + * Module loading callback function + * + * Returns 0 on success or a negative value indicating error

Re: [PATCH 00/22 take 3] UBI: Unsorted Block Images

2007-03-19 Thread Matt Mackall
On Tue, Mar 20, 2007 at 01:42:46AM +0100, Thomas Gleixner wrote: On Mon, 2007-03-19 at 17:32 -0500, Matt Mackall wrote: If a static volume is simply a non-dynamic volume, then device mapper can do that too. And countless other things. Which is not an aside. UBI growing to do all

Re: [PATCH RESEND 1/1] crypto API: RSA algorithm patch (kernel version 2.6.20.1)

2007-03-20 Thread Matt Mackall
On Tue, Mar 20, 2007 at 04:44:01PM +0200, Tasos Parisinos wrote: +/* Pre-allocate some auxilliary mpis */ +rsa_echo(Preallocating %lu bytes for auxilliary operands\n, + RSA_AUX_SIZE * RSA_AUX_COUNT * sizeof(_u32)); And printk. i made such a printk wrapper not to mess with

Re: [RFC][PATCH] split file and anonymous page queues #3

2007-03-20 Thread Matt Mackall
On Tue, Mar 20, 2007 at 06:08:10PM -0400, Rik van Riel wrote: - Active: %8lu kB\n - Inactive: %8lu kB\n ... + Active(anon): %8lu kB\n + Inactive(anon): %8lu kB\n + Active(file): %8lu kB\n + Inactive(file):

Re: [RFC][PATCH -mm take3 1/6][resend] marking __init

2007-03-20 Thread Matt Mackall
init_netconsole(void) +static int __init init_netconsole(void) { int err; This is fine. Acked-by: Matt Mackall [EMAIL PROTECTED] -- Mathematics is the supreme nostalgia of our time. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED

Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap paravirt ops callsites to make them patchable

2007-03-20 Thread Matt Mackall
On Tue, Mar 20, 2007 at 09:31:58AM -0700, Jeremy Fitzhardinge wrote: Linus Torvalds wrote: On Tue, 20 Mar 2007, Eric W. Biederman wrote: If that is the case. In the normal kernel what would the the oops, we got an interrupt code do? I assume it would leave interrupts disabled when

Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap paravirt ops callsites to make them patchable

2007-03-20 Thread Matt Mackall
On Tue, Mar 20, 2007 at 03:08:19PM -0800, Zachary Amsden wrote: Matt Mackall wrote: I don't know that you need an xchg there. If you're still on the same CPU, it should all be nice and causal even across an interrupt handler. So it could be: pda.intr_mask = 0; /* intr_pending can't get

Re: 2.6.21-rc4-mm1

2007-03-21 Thread Matt Mackall
With the latest -mm, I'm now getting this: Mar 21 15:06:52 cinder kernel: ipw2200: Detected Intel PRO/Wireless 2200BG Network Connection Mar 21 15:06:52 cinder kernel: firmware_loading_store: unexpected value (0) Mar 21 15:06:52 cinder kernel: ipw2200: ipw2200-bss.fw request_firmware failed:

Re: pagetable_ops: Hugetlb character device example

2007-03-21 Thread Matt Mackall
On Wed, Mar 21, 2007 at 03:26:59PM -0700, William Lee Irwin III wrote: On Wed, 21 Mar 2007 14:43:48 CDT, Adam Litke said: The main reason I am advocating a set of pagetable_operations is to enable the development of a new hugetlb interface. On Wed, Mar 21, 2007 at 03:51:31PM -0400, [EMAIL

Re: pagetable_ops: Hugetlb character device example

2007-03-21 Thread Matt Mackall
. That would've allowed rm -rf fs/hugetlbfs/ outright. A compatibility wrapper for expand-on-mmap() around ramfs once ramfs acquires the necessary functionality is now the exit strategy. On Wed, Mar 21, 2007 at 05:53:48PM -0500, Matt Mackall wrote: Can you describe what ramfs needs here in a bit more

Re: 2.6.21-rc4-mm1

2007-03-24 Thread Matt Mackall
On Wed, Mar 21, 2007 at 11:39:17PM -0800, Andrew Morton wrote: On Wed, 21 Mar 2007 15:22:25 -0500 Matt Mackall [EMAIL PROTECTED] wrote: With the latest -mm, I'm now getting this: Mar 21 15:06:52 cinder kernel: ipw2200: Detected Intel PRO/Wireless 2200BG Network Connection Mar 21 15

Re: [patch 2/3] only allow nonlinear vmas for ram backed filesystems

2007-03-25 Thread Matt Mackall
On Sun, Mar 25, 2007 at 02:12:32PM +0200, Peter Zijlstra wrote: On Sat, 2007-03-24 at 23:09 +0100, Miklos Szeredi wrote: From: Miklos Szeredi [EMAIL PROTECTED] Dirty page accounting/limiting doesn't work for nonlinear mappings, so for non-ram backed filesystems emulate with linear

Re: [patch resend v4] update ctime and mtime for mmaped write

2007-03-26 Thread Matt Mackall
On Mon, Mar 26, 2007 at 02:00:36PM -0700, Andrew Morton wrote: On Sun, 25 Mar 2007 23:10:21 +0200 Miklos Szeredi [EMAIL PROTECTED] wrote: This patch makes writing to shared memory mappings update st_ctime and st_mtime as defined by SUSv3: Boy this is complicated. Is there a simpler

Re: [KJ][RFC]NAME_OFFSET macro

2007-04-06 Thread Matt Mackall
On Fri, Apr 06, 2007 at 02:28:13PM +0530, Milind Arun Choudhary wrote: [EMAIL PROTECTED]:~/src/linux egrep -rin #define.*NAME_?OFFSET . ./arch/alpha/kernel/osf_sys.c:95:#define NAME_OFFSEToffsetof (struct osf_dirent, d_name) ./arch/mips/kernel/sysirix.c:1738:#define NAME_OFFSET32(de)

[PATCH 0/13] maps#2: pagemap, kpagemap, and related cleanups take 2

2007-04-06 Thread Matt Mackall
This patch series introduces /proc/pid/pagemap and /proc/kpagemap, which allow detailed run-time examination of process memory usage at a page granularity. The first several patches whip the page-walking code introduced for /proc/pid/smaps and clear_refs into a more generic form, the next couple

[PATCH 1/13] maps#2: Uninline some functions in the page walker

2007-04-06 Thread Matt Mackall
Uninline some functions in the page walker Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: mm/fs/proc/task_mmu.c === --- mm.orig/fs/proc/task_mmu.c 2007-03-24 21:33:42.0 -0500 +++ mm/fs/proc/task_mmu.c 2007-03-24

[PATCH 13/13] maps#2: Add /proc/kpagemap interface

2007-04-06 Thread Matt Mackall
Add /proc/kpagemap interface This makes physical page flags and counts available to userspace. Together with /proc/pid/pagemap and /proc/pid/clear_refs, this can be used to measure memory usage on a per-page basis. Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: mm/fs/proc/proc_misc.c

[PATCH 12/13] maps#2: Add /proc/pid/pagemap interface

2007-04-06 Thread Matt Mackall
Add /proc/pid/pagemap interface This interface provides a mapping for each page in an address space to its physical page frame number, allowing precise determination of what pages are mapped and what pages are shared between processes. Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: mm/fs

[PATCH 11/13] maps#2: Make /proc/pid/clear_refs option under CONFIG_EMBEDDED

2007-04-06 Thread Matt Mackall
Make /proc/pid/clear_refs option under CONFIG_EMBEDDED This interface is primarily useful for doing memory profiling and not much use on deployed embedded boxes. Make it optional. Together with /proc/pid/smaps, this save a few K. Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: mm/fs/proc

[PATCH 8/13] maps#2: Move clear_refs code to task_mmu.c

2007-04-06 Thread Matt Mackall
Move clear_refs code to task_mmu.c This puts all the clear_refs code where it belongs and probably lets things compile on MMU-less systems as well. Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: mm/fs/proc/base.c

[PATCH 7/13] maps#2: Simplify interdependence of /proc/pid/maps and smaps

2007-04-06 Thread Matt Mackall
Simplify interdependence of /proc/pid/maps and smaps This pulls the shared map display code out of show_map and puts it in show_smap where it belongs. Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: mm/fs/proc/task_mmu.c

[PATCH 10/13] maps#2: Make /proc/pid/smaps optional under CONFIG_EMBEDDED

2007-04-06 Thread Matt Mackall
Make /proc/pid/smaps optional under CONFIG_EMBEDDED This interface is primarily useful for doing memory profiling and not much use on deployed embedded boxes. Make it optional. Together with /proc/pid/clear_refs, this save a few K. Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: mm/fs/proc

[PATCH 3/13] maps#2: Remove vma from args in the page walker

2007-04-06 Thread Matt Mackall
Remove vma from args in the page walker This makes the walker more generic. Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: mm/fs/proc/task_mmu.c === --- mm.orig/fs/proc/task_mmu.c 2007-03-24 21:33:50.0 -0500 +++ mm

[PATCH 2/13] maps#2: Eliminate the pmd_walker struct in the page walker

2007-04-06 Thread Matt Mackall
Eliminate the pmd_walker struct in the page walker This slightly simplifies things for the next few cleanups. Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: mm/fs/proc/task_mmu.c === --- mm.orig/fs/proc/task_mmu.c 2007-03-24

[PATCH 5/13] maps#2: Add callbacks for each level to page walker

2007-04-06 Thread Matt Mackall
. Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: mm/fs/proc/task_mmu.c === --- mm.orig/fs/proc/task_mmu.c 2007-03-24 21:33:58.0 -0500 +++ mm/fs/proc/task_mmu.c 2007-03-24 21:34:07.0 -0500 @@ -280,10 +280,35

[PATCH 6/13] maps#2: Move the page walker code to lib/

2007-04-06 Thread Matt Mackall
Move the page walker code to lib/ This lets it get shared outside of proc/ and linked in only when needed. Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: mm/fs/proc/task_mmu.c === --- mm.orig/fs/proc/task_mmu.c 2007-03-27 22

[PATCH 9/13] maps#2: Regroup task_mmu by interface

2007-04-06 Thread Matt Mackall
Regroup task_mmu by interface Reorder source so that all the code and data for each interface is together. Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: mm/fs/proc/task_mmu.c === --- mm.orig/fs/proc/task_mmu.c 2007-03-28 00

[PATCH 4/13] maps#2: Propagate errors from callback in page walker

2007-04-06 Thread Matt Mackall
Propagate errors from callback in page walker Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: mm/fs/proc/task_mmu.c === --- mm.orig/fs/proc/task_mmu.c 2007-03-24 21:33:52.0 -0500 +++ mm/fs/proc/task_mmu.c 2007-03

Re: [PATCH 12/13] maps#2: Add /proc/pid/pagemap interface

2007-04-07 Thread Matt Mackall
On Fri, Apr 06, 2007 at 11:55:10PM -0700, Andrew Morton wrote: On Fri, 06 Apr 2007 17:03:13 -0500 Matt Mackall [EMAIL PROTECTED] wrote: Add /proc/pid/pagemap interface This interface provides a mapping for each page in an address space to its physical page frame number, allowing

Re: [PATCH] slob: handle SLAB_PANIC flag

2007-04-09 Thread Matt Mackall
On Mon, Apr 09, 2007 at 10:08:47PM +0900, Akinobu Mita wrote: kmem_cache_create() for slob doesn't handle SLAB_PANIC. Cc: Matt Mackall [EMAIL PROTECTED] Signed-off-by: Akinobu Mita [EMAIL PROTECTED] --- mm/slob.c |3 +++ 1 file changed, 3 insertions(+) Index: 2.6-mm/mm/slob.c

Re: /proc/*/pagemap BUG: sleeping function called from invalid context

2007-04-09 Thread Matt Mackall
On Mon, Apr 09, 2007 at 12:25:54PM +0400, Alexey Dobriyan wrote: After cat /proc/self/pagemap BUG: sleeping function called from invalid context at include/asm/uaccess.h:453 in_atomic():1, irqs_disabled():0 1 lock held by cat/14183: #0: (mm-mmap_sem){}, at: [c017d17b]

Re: /proc/*/pagemap BUG: sleeping function called from invalid context

2007-04-09 Thread Matt Mackall
On Mon, Apr 09, 2007 at 12:25:54PM +0400, Alexey Dobriyan wrote: After cat /proc/self/pagemap BUG: sleeping function called from invalid context at include/asm/uaccess.h:453 in_atomic():1, irqs_disabled():0 1 lock held by cat/14183: #0: (mm-mmap_sem){}, at: [c017d17b]

Re: init's children list is long and slows reaping children.

2007-04-10 Thread Matt Mackall
On Tue, Apr 10, 2007 at 03:05:56AM -0400, Jeff Garzik wrote: Andrew Morton wrote: : root 3 0.0 0.0 0 0 ?S18:51 0:00 [watchdog/0] That's the softlockup detector. Confusingly named to look like a, err, watchdog. Could probably use keventd. I would think

Re: Add a norecovery option to ext3/4?

2007-04-10 Thread Matt Mackall
On Tue, Apr 10, 2007 at 02:08:26PM +0200, Jörn Engel wrote: On Tue, 10 April 2007 07:27:18 -0400, Theodore Tso wrote: I suppose what you could do is to read in the journal, and use it to create an remapping table so that when you want to read block #5126, and block number 5126 is in the

Re: /proc/*/pagemap BUG: sleeping function called from invalid context

2007-04-10 Thread Matt Mackall
in pagemap to avoid calling copy_to_user while preemption is disabled. Tested on x86 with HIGHPTE with DEBUG_SPINLOCK_SLEEP and PROVE_LOCKING. Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: mm/fs/proc/task_mmu.c === --- mm.orig

Re: [-mm patch] make struct proc_kpagemap static

2007-04-10 Thread Matt Mackall
the needlessly global truct proc_kpagemap static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Acked-by: Matt Mackall [EMAIL PROTECTED] -- Mathematics is the supreme nostalgia of our time. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: [PATCH 6/13] maps#2: Move the page walker code to lib/

2007-04-11 Thread Matt Mackall
On Wed, Apr 11, 2007 at 04:35:44PM +1000, Nick Piggin wrote: Matt Mackall wrote: Move the page walker code to lib/ This lets it get shared outside of proc/ and linked in only when needed. Still should go into mm/ If it had, you might have also noticed your pagetable walking code

Re: [PATCH UPDATE] deflate stack usage in lib/inflate.c

2007-04-12 Thread Matt Mackall
On Thu, Apr 12, 2007 at 01:50:54PM -0700, Jeremy Fitzhardinge wrote: -#define HEAP_SIZE 0x3000 +#define HEAP_SIZE 0x4000 There are a bunch more of these that'll need fixing. -- Mathematics is the supreme nostalgia of our time. - To unsubscribe from this list: send the

Re: [PATCH UPDATE] deflate stack usage in lib/inflate.c

2007-04-12 Thread Matt Mackall
On Thu, Apr 12, 2007 at 03:57:48PM -0700, Jeremy Fitzhardinge wrote: Matt Mackall wrote: On Thu, Apr 12, 2007 at 01:50:54PM -0700, Jeremy Fitzhardinge wrote: -#define HEAP_SIZE 0x3000 +#define HEAP_SIZE 0x4000 There are a bunch more of these that'll

Re: [PATCH 0/13] maps: pagemap, kpagemap, and related cleanups

2007-04-12 Thread Matt Mackall
On Thu, Apr 12, 2007 at 04:32:35PM -0700, Andrew Morton wrote: On Thu, 12 Apr 2007 16:10:50 -0700 William Lee Irwin III [EMAIL PROTECTED] wrote: On Tue, Apr 03, 2007 at 09:43:30PM -0500, Matt Mackall wrote: This patch series introduces /proc/pid/pagemap and /proc/kpagemap, which allow

  1   2   3   4   5   6   7   8   9   10   >