Re: [PATCH] ASoC: rockchip: i2s: Support mono capture

El Fri, Jan 05, 2018 at 02:12:42PM -0800 Matthias Kaehlcke ha dit: > The Rockchip I2S controller only allows to configure even numbers of > capture channels. It is still possible to capture monophonic audio by > using dual-channel mode and ignoring the 'data' from the second > c

[PATCH] ASoC: codecs: dmic: Fix check of return value from read of 'num-channels'

le") Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- sound/soc/codecs/dmic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/dmic.c b/sound/soc/codecs/dmic.c index c88f974ebe3e..cf83c423394d 100644 --- a/sound/soc/codecs/dmic.c +++ b/sound/soc/code

[PATCH] drm/amd/powerplay: Fix enum mismatch

,-Wenum-conversion] AMD_PG_STATE_UNGATE); Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- drivers/gpu/drm/amd/powerplay/hwmgr/cz_clockpowergating.c | 8 drivers/gpu/drm/amd/powerplay/hwmgr/smu7_clockpowergating.c | 2 +- 2 files changed, 5 insertions(+), 5 del

[PATCH] drm/amd/powerplay: Remove extra pair of parentheses

rol == SMU7_VOLTAGE_CONTROL_BY_SVID2)) { Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- drivers/gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c b/drivers/gpu/drm/amd/powerpl

[PATCH] drm/amd/display: Remove extra pairs of parentheses in dce_calcs.c

->graphics_micro_tile_mode == bw_def_rotated_micro_tiling)) { Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/calcs/dc

Re: [PATCH v2 1/2] amdgpu/dc/dml: Consolidate redundant CFLAGS

El Thu, Feb 08, 2018 at 09:33:53AM -0500 Harry Wentland ha dit: > On 2018-02-07 08:51 PM, Matthias Kaehlcke wrote: > > Use subdir-ccflags instead of specifying the same flags for every source > > file. > > > > Signed-off-by: Matthias Kaehlcke <m...@chromium.org&g

[PATCH v3 1/4] amdgpu/dc/dml: Consolidate redundant CFLAGS

Use a variable for common CFLAGS instead of specifying the same flags for every source file. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- Changes in v3: - Use variable for compiler options instead of subdir-ccflags-y drivers/gpu/drm/amd/display/dc/dml/Makefil

[PATCH v3 4/4] amdgpu/dc/calcs: Support clang option for stack alignment

and use the correct one, similar to what is done in arch/x86/Makefile. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- Changes in v3: - patch added Note to self: if this patterns proliferates further we probably want to put the evaluation of the correct compiler flag in some common

[PATCH v3 3/4] amdgpu/dc/dml: Support clang option for stack alignment

the correct one, similar to what is done in arch/x86/Makefile. Reported-by: Guenter Roeck <gro...@chromium.org> Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- Changes in v3: - adapted use of variable instead of subdir-ccflags-y drivers/gpu/drm/amd/display/dc/dml/

[PATCH v3 2/4] amdgpu/dc/calcs: Consolidate redundant CFLAGS

Use a variable for common CFLAGS instead of specifying the same flags for every source file. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- Changes in v3: - patch added drivers/gpu/drm/amd/display/dc/calcs/Makefile | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-)

Re: [PATCH v3 4/4] amdgpu/dc/calcs: Support clang option for stack alignment

El Thu, Feb 08, 2018 at 04:44:21PM -0500 Harry Wentland ha dit: > On 2018-02-08 04:03 PM, Harry Wentland wrote: > > On 2018-02-08 03:53 PM, Matthias Kaehlcke wrote: > >> calcs uses the compiler option -mpreferred-stack-boundary=4 to configure > >> a stack alignm

[PATCH 2/2] amdgpu/dc/dml: Support clang option for stack alignment

the correct one, similar to what is done in arch/x86/Makefile. Reported-by: Guenter Roeck <gro...@chromium.org> Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- drivers/gpu/drm/amd/display/dc/dml/Makefile | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --g

[PATCH 1/2] amdgpu/dc/dml: Consolidate redundant CFLAGS

Use subdir-ccflags instead of specifying the same flags for every source file. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- drivers/gpu/drm/amd/display/dc/dml/Makefile | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/display/

Re: [PATCH 2/2] amdgpu/dc/dml: Support clang option for stack alignment

El Wed, Feb 07, 2018 at 05:34:44PM -0800 Guenter Roeck ha dit: > On Wed, Feb 7, 2018 at 5:21 PM, Matthias Kaehlcke <m...@chromium.org> wrote: > > DML uses the compiler option -mpreferred-stack-boundary=4 to configure > > a stack alignment of 16 bytes. Clang uses the opt

[PATCH v2 1/2] amdgpu/dc/dml: Consolidate redundant CFLAGS

Use subdir-ccflags instead of specifying the same flags for every source file. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> Reviewed-by: Guenter Roeck <gro...@chromium.org> --- Changes in v2: - added 'Reviewed-by: Guenter Roeck <gro...@chromium.org>' tag drivers/gpu/

[PATCH v2 2/2] amdgpu/dc/dml: Support clang option for stack alignment

the correct one, similar to what is done in arch/x86/Makefile. Reported-by: Guenter Roeck <gro...@chromium.org> Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- Changes in v2: - use consistent syntax and formatting for assignment of cc_stack_align drivers/gpu/drm/amd/di

Re: [PATCH] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c

El Wed, Feb 07, 2018 at 02:35:59PM -0600 Larry Finger ha dit: > On 02/07/2018 02:26 PM, Matthias Kaehlcke wrote: > > In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal > > is assigned to itself in an if ... else statement, apparently only to > > doc

[PATCH] amdgpu/dc: Fix enum mismatch in calls to program_color_matrix()

: implicit conversion from enumeration type 'enum graphics_csc_adjust_type' to different enumeration type 'enum grph_color_adjust_option' [-Werror,-Wenum-conversion] xfm_dce, tbl_entry, GRAPHICS_CSC_ADJUST_TYPE_SW); Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- drivers/gpu/d

[PATCH] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c

the 'handling' of the branch condition. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c b/drivers/net/wi

[PATCH v2] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c

the following warning: drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c:304:13: error: explicitly assigning value of variable of type 'u32' (aka 'unsigned int') to itself [-Werror,-Wself-assign] writeVal = writeVal; Delete the branch with the self-assignment. Signed-off-by: Matthias Kaehlcke

Re: [PATCH 4.4 05/53] x86/asm: Use register variable to get stack pointer value

El Tue, Feb 06, 2018 at 02:37:06PM -0800 Greg Kroah-Hartman ha dit: > On Tue, Feb 06, 2018 at 01:59:41PM -0800, Matthias Kaehlcke wrote: > > Hi Greg, > > > > El Mon, Jan 22, 2018 at 09:39:57AM +0100 Greg Kroah-Hartman ha dit: > > > > > 4.4-stable review

Re: [PATCH 4.4 05/53] x86/asm: Use register variable to get stack pointer value

Hi Greg, El Mon, Jan 22, 2018 at 09:39:57AM +0100 Greg Kroah-Hartman ha dit: > 4.4-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Andrey Ryabinin > > commit 196bd485ee4f03ce4c690bfcf38138abfcd0a4bc upstream. >

[PATCH] amdgpu/dc: Remove unnecessary initialization in dc_link_handle_hpd_rx_irq()

enumeration type 'enum ddc_result' to different enumeration type 'enum dc_status' [-Werror,-Wenum-conversion] enum dc_status result = DDC_RESULT_UNKNOWN; Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +- 1 file chan

[PATCH v3 1/4] ASoC: dapm: fix debugfs read using path->connected

ource/sink) as declared in snd_soc_dapm_route. Signed-off-by: KaiChieh Chuang <kaichieh.chu...@mediatek.com> Signed-off-by: Mark Brown <broo...@kernel.org> Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- sound/soc/soc-dapm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] amdgpu/dc: Add missing cast in dce_clock_set_min_clocks_state()

El Fri, Feb 09, 2018 at 04:55:57PM -0500 Harry Wentland ha dit: > On 2018-02-09 04:28 PM, Matthias Kaehlcke wrote: > > dce_clock_set_min_clocks_state() assigns (intentionally) a value of type > > 'enum dm_pp_clocks_state' to a variable of type 'enum dm_pp_power_level' > > wit

[PATCH] amdgpu/dc: Add missing cast in dce_clock_set_min_clocks_state()

: implicit conversion from enumeration type 'enum dm_pp_clocks_state' to different enumeration type 'enum dm_pp_power_level' [-Werror,-Wenum-conversion] clocks_state }; Make the cast explicit. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- drivers/gpu/drm/amd/display/

Re: [PATCH v3 1/4] ASoC: dapm: fix debugfs read using path->connected

Sorry, I unintentionally 'recycled' git send-email parameters, please ignore this patch :( El Fri, Feb 09, 2018 at 01:22:13PM -0800 Matthias Kaehlcke ha dit: > From: KaiChieh Chuang <kaichieh.chu...@mediatek.com> > > This fix a bug in dapm_widget_power_read_file(), > where it

[PATCH] ASoC: dmic: Add optional wakeup delay

-by: Matthias Kaehlcke <m...@chromium.org> --- .../devicetree/bindings/sound/dmic.txt| 2 + sound/soc/codecs/dmic.c | 54 ++- 2 files changed, 42 insertions(+), 14 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/dmic.

Re: [PATCH] ASoC: dmic: Add optional wakeup delay

El Wed, Feb 14, 2018 at 04:22:54PM -0800 Brian Norris ha dit: > Hi Matthias, > > On Wed, Feb 14, 2018 at 03:51:56PM -0800, Matthias Kaehlcke wrote: > > On some systems a delay is needed after switching on the clocks, to allow > > the DMIC output to stabilize and

[PATCH v2] ASoC: dmic: Add optional wakeup delay

be applied in dmic_daiops_trigger() since the function is called in atomic context. Instead use a DAPM event handler to set the enable GPIO and apply the delay in the handler. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- Changes in v2: - use DAPM event handler instead of _prepare() a

Re: [PATCH v2] ASoC: dmic: Add optional wakeup delay

El Thu, Feb 15, 2018 at 06:47:29PM -0800 Brian Norris ha dit: > Hi, > > On Thu, Feb 15, 2018 at 06:24:16PM -0800, Matthias Kaehlcke wrote: > > On some systems a delay is needed after switching on the clocks, to allow > > the output to stabilize and avoid a popping n

Re: [PATCH v2] ASoC: dmic: Add optional wakeup delay

El Fri, Feb 16, 2018 at 11:28:01AM + Mark Brown ha dit: > On Thu, Feb 15, 2018 at 06:24:16PM -0800, Matthias Kaehlcke wrote: > > On some systems a delay is needed after switching on the clocks, to allow > > the output to stabilize and avoid a popping noise a

[PATCH v3] ASoC: dmic: Add optional wakeup delay

be applied in dmic_daiops_trigger() since the function is called in atomic context. Instead use a DAPM event handler to set the enable GPIO and apply the delay in the handler. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- Changes in v3: - rebased on latest dmic topic branch Changes

Re: [alsa-devel] [PATCH] ASoC: dmic: Add optional wakeup delay

El Thu, Feb 15, 2018 at 09:42:01AM +0200 Peter Ujfalusi ha dit: > > > On 2018-02-15 01:51, Matthias Kaehlcke wrote: > > On some systems a delay is needed after switching on the clocks, to allow > > the DMIC output to stabilize and avoid a popping noise at the beginning >

[PATCH] KVM: x86: Make enum conversion explicit in kvm_pdptr_read()

_PDPTR); Cast VCPU_EXREG_PDPTR to 'enum kvm_reg' to make the compiler happy. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- arch/x86/kvm/kvm_cache_regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/kvm_cache_regs.h b/arch/x86/kvm/kvm_cache_

Re: [PATCH v12 1/7] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn3990

On Thu, Aug 02, 2018 at 11:35:54PM +0530, Balakrishna Godavarthi wrote: > Hi Matthias, > > On 2018-08-02 23:24, Balakrishna Godavarthi wrote: > > Hi Matthias, > > > > On 2018-08-02 22:50, Matthias Kaehlcke wrote: > > > On Thu, Aug 02, 2018 at 06:55:12PM +0530

Re: [PATCH v12 7/7] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990

dev_device_get_drvdata(hu->serdev); > + if (!qcadev || !qcadev->bt_power || !qcadev->bt_power->vreg_data || > + !qcadev->bt_power->vreg_bulk) > + return -EINVAL; > + > + vregs = qcadev->bt_power->vreg_data->vregs; > + vreg_bulk = qcadev->bt_power->vreg_bulk; > + num_vregs = qcadev->bt_power->vreg_data->num_vregs; > + BT_DBG("on: %d", on); > + if (on && !qcadev->bt_power->vregs_on) { Remove extra blank after 'on' Other than that: Reviewed-by: Matthias Kaehlcke Thanks for following through!

Re: [PATCH v12 1/7] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn3990

On Thu, Aug 02, 2018 at 06:55:12PM +0530, Balakrishna Godavarthi wrote: > This patch enables regulators for the Qualcomm Bluetooth wcn3990 > controller. > > Signed-off-by: Balakrishna Godavarthi > Reviewed-by: Rob Herring > --- > .../bindings/net/qualcomm-bluetooth.txt | 26

Re: [PATCH v13 7/7] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990

On Fri, Aug 03, 2018 at 01:40:43AM +0530, Balakrishna Godavarthi wrote: > On 2018-08-03 01:27, Matthias Kaehlcke wrote: > > On Fri, Aug 03, 2018 at 12:37:32AM +0530, Balakrishna Godavarthi wrote: > > > Add support to set voltage/current of various regulators > > > to p

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

Hi Chanwoo, On Thu, Aug 02, 2018 at 10:58:59AM +0900, Chanwoo Choi wrote: > Hi Matthias, > > On 2018년 08월 02일 02:08, Matthias Kaehlcke wrote: > > Hi Chanwoo, > > > > On Wed, Aug 01, 2018 at 10:22:16AM +0900, Chanwoo Choi wrote: > >> On 2018년 08월 01일 04:39, M

Re: [PATCH v13 7/7] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990

On Fri, Aug 03, 2018 at 12:37:32AM +0530, Balakrishna Godavarthi wrote: > Add support to set voltage/current of various regulators > to power up/down Bluetooth chip wcn3990. > > Signed-off-by: Balakrishna Godavarthi > Reviewed-by: Matthias Kaehlcke > --- > Changes in v13:

Re: [PATCH v13 1/7] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn3990

t;; > + > + vddio-supply = <_s4a_1p8>; > + vddxo-supply = <_l7a_1p8>; > + vddrf-supply = <_l17a_1p3>; > + vddch0-supply = <_l25a_3p3>; > + max-speed = <320>; > + }; > +}; Reviewed-by: Matthias Kaehlcke

Re: [PATCH v5 03/12] PM / devfreq: Don't adjust to user limits in governors

On Fri, Aug 03, 2018 at 09:03:30AM +0900, Chanwoo Choi wrote: > Hi Matthias, > > On 2018년 08월 03일 08:36, Matthias Kaehlcke wrote: > > Hi Chanwoo, > > > > this patch and "PM / devfreq: Fix handling of min/max_freq == 0" > > address issues not di

Re: [PATCH v5 03/12] PM / devfreq: Don't adjust to user limits in governors

ently from the rest of the series? Thanks Matthias On Tue, Jul 03, 2018 at 04:46:56PM -0700, Matthias Kaehlcke wrote: > Several governors use the user space limits df->min/max_freq to adjust > the target frequency. This is not necessary, since update_devfreq() > already takes

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

On Thu, Aug 02, 2018 at 04:13:43PM -0700, Matthias Kaehlcke wrote: > Hi Chanwoo, > > On Thu, Aug 02, 2018 at 10:58:59AM +0900, Chanwoo Choi wrote: > > Hi Matthias, > > > > On 2018년 08월 02일 02:08, Matthias Kaehlcke wrote: > > > Hi Chanwoo, > > > &

Re: [PATCH v11 7/7] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990

On Fri, Jul 27, 2018 at 07:43:20PM +0530, Balakrishna Godavarthi wrote: > From: Balakrishna Godavarthi > > Add support to set voltage/current of various regulators > to power up/down Bluetooth chip wcn3990. > > Signed-off-by: Balakrishna Godavarthi > --- > Changes in v11: > * removed

Re: [PATCH v10 7/7] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990

On Fri, Jul 27, 2018 at 05:09:02PM +0530, Balakrishna Godavarthi wrote: > Hi Matthias, > > On 2018-07-27 01:21, Matthias Kaehlcke wrote: > > On Thu, Jul 26, 2018 at 07:51:13PM +0530, Balakrishna Godavarthi wrote: > > > Hi Matthias, > > > > > > On

Re: [PATCH v11 3/7] Bluetooth: btqca: Redefine qca_uart_setup() to generic function.

ype and soc_ver to the functions. > > These arguments will help to decide type of firmware files > to be loaded into Bluetooth chip. > soc_type holds the Bluetooth chip connected to APPS processor. > soc_ver holds the Bluetooth chip version. > > Signed-off-by: Balakrishna Godavart

Re: [PATCH v10 7/7] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990

On Thu, Jul 26, 2018 at 07:51:13PM +0530, Balakrishna Godavarthi wrote: > Hi Matthias, > > On 2018-07-26 00:01, Matthias Kaehlcke wrote: > > On Tue, Jul 24, 2018 at 09:25:16PM +0530, Balakrishna Godavarthi wrote: > > > Hi Matthias, > > > > > > On

Re: [PATCH v1 2/3] thermal: tsens: switch from of_iomap() to devm_ioremap_resource()

+ base = devm_ioremap_resource(>dev, res); > + if (IS_ERR(base)) > + return PTR_ERR(base); > + > tmdev->map = devm_regmap_init_mmio(tmdev->dev, base, _config); > - if (IS_ERR(tmdev->map)) { > - iounmap(base); > + if (IS_ERR(tmdev->map)) > return PTR_ERR(tmdev->map); > - } > > return 0; > } Reviewed-by: Matthias Kaehlcke

Re: [PATCH v1 3/3] thermal: tsens: Fix negative temperature reporting

~CODE_SIGN_BIT; > - > - /* Temperatures are in deciCelicius */ > - *temp = last_temp * 100; > + /* Convert temperatures to milliCelicius */ nits: s/temperatures/temperature/ s/milliCelicius/milliCelsius/ > + *temp = sign_extend32(last_temp, fls(LAST_TEMP_MASK) - 1) * 100; > > return 0; > } Reviewed-by: Matthias Kaehlcke

Re: [PATCH v5 1/3] thermal: qcom-spmi: Use PMIC thermal stage 2 for critical trip points

Hi Doug, On Wed, Jul 25, 2018 at 04:19:56PM -0700, Doug Anderson wrote: > On Tue, Jul 24, 2018 at 4:46 PM, Matthias Kaehlcke wrote: > > +static int qpnp_tm_update_critical_trip_temp(struct qpnp_tm_chip *chip, > > +int temp) > >

Re: [PATCH v1 1/3] thermal: tsens: Rename variable

p) > } > > /* Try a third/last time */ > - ret = regmap_read(tmdev->map, sensor_addr, ); > + ret = regmap_read(tmdev->map, status_reg, ); > if (ret) > return ret; > if (code & STATUS_VALID_BIT) { Reviewed-by: Matthias Kaehlcke

Re: [PATCH v1] arm64: dts: sdm845: enable tsens thermal zones

hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu_crit7: trip1 { > + temperature = <11>; > + hysteresis = <1000>; > + type = "critical"; > + }; > + }; Dumb DT question: the trip information is the same for all CPUs. Would it be possible to have a single node and refer to it with a phandle? I suppose the anwer is no and even if it was possible we probably wouldn't want it, since it would complicate overriding settings for a specific CPU (should that ever be needed ...) or cluster. Just wondering. > + }; > + }; > }; I don't have documentation to verify that the sensors and CPUs match, but it is in line with what I've seen in some Android tree, so it seems alright ;-) Reviewed-by: Matthias Kaehlcke Tested-by: Matthias Kaehlcke

[PATCH v6 1/5] dt-bindings: thermal: qcom-spmi-temp-alarm: Fix documentation of 'reg'

ion of the field and the example. Signed-off-by: Matthias Kaehlcke Reviewed-by: Douglas Anderson --- Changes in v6: - patch added to the series --- .../devicetree/bindings/thermal/qcom-spmi-temp-alarm.txt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/

[PATCH v6 3/5] thermal: qcom-spmi: Use PMIC thermal stage 2 for critical trip points

the OS is not notified when the critical temperature is reached) Suggested-by: Douglas Anderson Signed-off-by: Matthias Kaehlcke --- Changes in v6: - fixed condition to check if ADC is configured in qpnp_tm_update_critical_trip_temp() - changed °C in logs to C - removed needless evaluation of qpnp_tm

[PATCH v6 4/5] arm64: dts: qcom: pm8998: Add spmi-temp-alarm node

This adds the spmi-temp-alarm node to pm8998 based on the examples in the bindings. Signed-off-by: Matthias Kaehlcke Reviewed-by: Douglas Anderson --- Changes in v6: - none Changes in v5: - added tag 'Reviewed-by: Douglas Anderson ' Changes in v4: - none Changes in v3: - changed node name

Re: [PATCH v5 1/3] thermal: qcom-spmi: Use PMIC thermal stage 2 for critical trip points

On Fri, Jul 27, 2018 at 03:45:06PM -0700, Eduardo Valentin wrote: > On Fri, Jul 27, 2018 at 03:40:52PM -0700, Eduardo Valentin wrote: > > On Wed, Jul 25, 2018 at 06:12:28PM -0700, Matthias Kaehlcke wrote: > > > Hi Doug, > > > > > > On Wed, Jul 25, 2018 at 0

[PATCH v6 3/5] thermal: qcom-spmi: Use PMIC thermal stage 2 for critical trip points

the OS is not notified when the critical temperature is reached) Suggested-by: Douglas Anderson Signed-off-by: Matthias Kaehlcke --- Changes in v6: - fixed condition to check if ADC is configured in qpnp_tm_update_critical_trip_temp() - changed °C in logs to C - removed needless evaluation of qpnp_tm

[PATCH v6 2/5] dt-bindings: thermal: qcom-spmi-temp-alarm: Improve thermal zone in example

, which may prevent an orderly shutdown. The 'partial shutdown' can be disabled by software. Signed-off-by: Matthias Kaehlcke Reviewed-by: Douglas Anderson --- Changes in v6: - patch added to the series --- .../bindings/thermal/qcom-spmi-temp-alarm.txt | 11 +++ 1 file changed, 3

[PATCH v6 1/5] dt-bindings: thermal: qcom-spmi-temp-alarm: Fix documentation of 'reg'

ion of the field and the example. Signed-off-by: Matthias Kaehlcke Reviewed-by: Douglas Anderson --- Changes in v6: - patch added to the series --- .../devicetree/bindings/thermal/qcom-spmi-temp-alarm.txt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/

[PATCH v6 4/5] arm64: dts: qcom: pm8998: Add spmi-temp-alarm node

This adds the spmi-temp-alarm node to pm8998 based on the examples in the bindings. Signed-off-by: Matthias Kaehlcke Reviewed-by: Douglas Anderson --- Changes in v6: - none Changes in v5: - added tag 'Reviewed-by: Douglas Anderson ' Changes in v4: - none Changes in v3: - changed node name

[PATCH v6 5/5] arm64: dts: qcom: pm8998: Add pm8998 thermal zone

below 105°C - 107°C for temperatures >= 105°C and < 125°C - 127°C for temperatures >= 125°C (the numbers correspond to a stage 1 threshold of 105°C) Signed-off-by: Matthias Kaehlcke Reviewed-by: Douglas Anderson --- Changes in v6: - added 'Reviewed-by: Douglas Anderson ' tag Chan

[PATCH v6 2/5] dt-bindings: thermal: qcom-spmi-temp-alarm: Improve thermal zone in example

, which may prevent an orderly shutdown. The 'partial shutdown' can be disabled by software. Signed-off-by: Matthias Kaehlcke Reviewed-by: Douglas Anderson --- Changes in v6: - patch added to the series --- .../bindings/thermal/qcom-spmi-temp-alarm.txt | 11 +++ 1 file changed, 3

[PATCH v6 5/5] arm64: dts: qcom: pm8998: Add pm8998 thermal zone

below 105°C - 107°C for temperatures >= 105°C and < 125°C - 127°C for temperatures >= 125°C (the numbers correspond to a stage 1 threshold of 105°C) Signed-off-by: Matthias Kaehlcke Reviewed-by: Douglas Anderson --- Changes in v6: - added 'Reviewed-by: Douglas Anderson ' tag Chan

Re: [PATCH v5 07/12] PM / devfreq: export devfreq_class

On Mon, Jul 16, 2018 at 12:41:14PM -0700, Matthias Kaehlcke wrote: > Hi Chanwoo, > > On Thu, Jul 12, 2018 at 06:08:36PM +0900, Chanwoo Choi wrote: > > Hi Matthias, > > > > On 2018년 07월 07일 03:09, Matthias Kaehlcke wrote: > > > Hi, > > > > >

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

On Mon, Jul 16, 2018 at 10:50:50AM -0700, Matthias Kaehlcke wrote: > On Thu, Jul 12, 2018 at 05:44:33PM +0900, Chanwoo Choi wrote: > > Hi Matthias, > > > > On 2018년 07월 07일 02:53, Matthias Kaehlcke wrote: > > > Hi Chanwoo, > > > > > > On Wed, Jul

Re: [PATCH v5 1/3] thermal: qcom-spmi: Use PMIC thermal stage 2 for critical trip points

On Fri, Jul 27, 2018 at 03:40:52PM -0700, Eduardo Valentin wrote: > On Wed, Jul 25, 2018 at 06:12:28PM -0700, Matthias Kaehlcke wrote: > > Hi Doug, > > > > On Wed, Jul 25, 2018 at 04:19:56PM -0700, Doug Anderson wrote: > > > > > On Tue, Jul 24, 2018 at 4:46

Re: [PATCH v10 7/7] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990

On Tue, Jul 31, 2018 at 08:08:40PM +0530, Balakrishna Godavarthi wrote: > Hi Matthias, > > On 2018-07-31 01:37, Matthias Kaehlcke wrote: > > On Fri, Jul 27, 2018 at 05:09:02PM +0530, Balakrishna Godavarthi wrote: > > > Hi Matthias, > > > > > > On

[PATCH] arm64: dts: sdm845: Add dispcc node

This adds the display clock controller node to sdm845 based on the examples in the bindings. Signed-off-by: Matthias Kaehlcke --- The dispcc driver and DT bindings landed in the clk-qcom-dispcc-845 branch of the clk tree. arch/arm64/boot/dts/qcom/sdm845.dtsi | 9 + 1 file changed, 9

[PATCH v6 2/3] PM / devfreq: Don't adjust to user limits in governors

let update_devfreq() take care of any adjustments. Signed-off-by: Matthias Kaehlcke Reviewed-by: Brian Norris Reviewed-by: Chanwoo Choi --- Changes in v6: - added 'Reviewed-by: Chanwoo Choi ' tag Changes in v5: - none Changes in v4: - added 'Reviewed-by: Brian Norris ' tag Changes in v3: - n

[PATCH v6 3/3] PM / devfreq: Make update_devfreq() public

Currently update_devfreq() is only visible to devfreq governors outside of devfreq.c. Make it public to allow drivers that adjust devfreq policies to cause a re-evaluation of the frequency after a policy change. Signed-off-by: Matthias Kaehlcke Acked-by: MyungJoo Ham Reviewed-by: Brian Norris

[PATCH v6 0/3] PM / devfreq: misc changes (spinned out from throttler series)

://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next Matthias Kaehlcke (3): PM / devfreq: Fix handling of min/max_freq == 0 PM / devfreq: Don't adjust to user limits in governors PM / devfreq: Make update_devfreq() public drivers/devfreq/devfreq.c | 42

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

Hi Chanwoo, On Wed, Aug 01, 2018 at 10:22:16AM +0900, Chanwoo Choi wrote: > On 2018년 08월 01일 04:39, Matthias Kaehlcke wrote: > > On Mon, Jul 16, 2018 at 10:50:50AM -0700, Matthias Kaehlcke wrote: > >> On Thu, Jul 12, 2018 at 05:44:33PM +0900, Chanwoo Choi wrote:

Re: [PATCH v5 09/12] dt-bindings: misc: add bindings for throttler

Hi Chanwoo, On Wed, Aug 01, 2018 at 05:27:57PM +0900, Chanwoo Choi wrote: > Hi Matthias, > > On 2018년 07월 04일 08:47, Matthias Kaehlcke wrote: > > The Throttler is used for non-thermal throttling of system components > > like CPUs or devfreq devices. > > > >

Re: [PATCH v5 07/12] PM / devfreq: export devfreq_class

On Wed, Aug 01, 2018 at 05:18:40PM +0900, Chanwoo Choi wrote: > Hi Matthias, > > On 2018년 08월 01일 04:29, Matthias Kaehlcke wrote: > > On Mon, Jul 16, 2018 at 12:41:14PM -0700, Matthias Kaehlcke wrote: > >> Hi Chanwoo, > >> > >> On Thu, Jul 12, 20

Re: [PATCH v10 7/7] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990

On Wed, Aug 01, 2018 at 07:29:29PM +0530, Balakrishna Godavarthi wrote: > Hi Matthias, > > On 2018-07-31 21:33, Matthias Kaehlcke wrote: > > On Tue, Jul 31, 2018 at 08:08:40PM +0530, Balakrishna Godavarthi wrote: > > > Hi Matthias, > > > > > > On

[PATCH] iio: adc: qcom-spmi-adc5: Add ADC5_AMUX_THM[24]_100K_PU to rev2 channel list

Add ADC5_AMUX_THM2_100K_PU and ADC5_AMUX_THM4_100K_PU to the list of rev2 ADC channels. Signed-off-by: Matthias Kaehlcke --- drivers/iio/adc/qcom-spmi-adc5.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/iio/adc/qcom-spmi-adc5.c b/drivers/iio/adc/qcom-spmi-adc5.c index

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

Hi Chanwoo, On Tue, Aug 07, 2018 at 07:31:16AM +0900, Chanwoo Choi wrote: > Hi Matthias, > > On 2018년 08월 07일 04:21, Matthias Kaehlcke wrote: > > Hi Chanwoo, > > > > On Fri, Aug 03, 2018 at 09:14:46AM +0900, Chanwoo Choi wrote: > >> Hi Matthias, > &

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

Hi Chanwoo, On Fri, Aug 03, 2018 at 09:14:46AM +0900, Chanwoo Choi wrote: > Hi Matthias, > > On 2018년 08월 03일 08:48, Matthias Kaehlcke wrote: > > On Thu, Aug 02, 2018 at 04:13:43PM -0700, Matthias Kaehlcke wrote: > >> Hi Chanwoo, > >> > >> On Thu, Aug

[PATCH v6 1/3] PM / devfreq: Fix handling of min/max_freq == 0

lue of 0. This also prevents df->max_freq from being set below the min OPP when df->min_freq is 0, and similar for min_freq. Since it is now guaranteed that df->min/max_freq can't be 0 the checks for this case can be removed. Fixes: f1d981eaecf8 ("PM / devfreq: Use the availa

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

Hi Chanwoo, On Tue, Aug 07, 2018 at 10:35:37AM +0900, Chanwoo Choi wrote: > Hi Matthias, > > On 2018년 08월 07일 09:23, Matthias Kaehlcke wrote: > > Hi Chanwoo, > > > > On Tue, Aug 07, 2018 at 07:31:16AM +0900, Chanwoo Choi wrote: > >> Hi Matthias, > &

Re: [PATCH v2] ASoC: rt5677: Fix initialization of rt5677_of_match.data

On Tue, Aug 07, 2018 at 10:13:47PM +0300, Andy Shevchenko wrote: > On Tue, 2018-08-07 at 10:19 -0700, Matthias Kaehlcke wrote: > > The driver expects to find the device id in rt5677_of_match.data, > > however > > it is currently assigned to rt5677_of_match.type. Fix this.

[PATCH] ASoC: rt5677: Remove bogus device id from rt5677_of_match

The initializer of rt5677_of_match contains a bogus device id (enum type) for the 'type' field (char []). Remove it. Signed-off-by: Matthias Kaehlcke --- sound/soc/codecs/rt5677.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs

[PATCH v2] ASoC: rt5677: Fix initialization of rt5677_of_match.data

of type 'const void *' [-Wnon-literal-null-conversion] { .compatible = "realtek,rt5677", RT5677 }, ^~ Fixes: ddc9e69b9dc2 ("ASoC: rt5677: Hide platform data in the module sources") Signed-off-by: Matthias Kaehlcke -- Changes in

Re: [PATCH] ASoC: rt5677: Remove bogus device id from rt5677_of_match

On Tue, Aug 07, 2018 at 09:39:38AM -0700, Guenter Roeck wrote: > On Tue, Aug 7, 2018 at 9:22 AM Matthias Kaehlcke wrote: > > > > The initializer of rt5677_of_match contains a bogus device id > > (enum type) for the 'type' field (char []). Remove it. > > > >

Re: [PATCH v1 01/10] arm/arm64: dts: msm8974/msm8916: thermal: Split address space into two

DEGC_PT1 30 > @@ -107,8 +107,9 @@ int get_temp_common(struct tsens_device *tmdev, int id, > int *temp) > unsigned int status_reg; > int last_temp = 0, ret; > > - status_reg = S0_ST_ADDR + s->hw_id * SN_ADDR_OFFSET; > + status_reg = tmdev->tm_offset + STATUS_OFFSET + s->hw_id * > SN_ADDR_OFFSET; > ret = regmap_read(tmdev->map, status_reg, ); > + > if (ret) > return ret; > last_temp = code & SN_ST_TEMP_MASK; Reviewed-by: Matthias Kaehlcke

Re: [PATCH v1 04/10] thermal: tsens: Get rid of dead code

nt i; > struct thermal_zone_device *tzd; > - u32 *hw_id, n = tmdev->num_sensors; > - > - hw_id = devm_kcalloc(tmdev->dev, n, sizeof(u32), GFP_KERNEL); > - if (!hw_id) > - return -ENOMEM; > > for (i = 0; i < tmdev->num_sensors; i++) { > tmdev->sensor[i].tmdev = tmdev; Reviewed-by: Matthias Kaehlcke

Re: [PATCH v1 03/10] thermal: tsens: Add SPDX license identifiers

al Public > - * License version 2, as published by the Free Software Foundation, and > - * may be copied, distributed, and modified under those terms. > - * > - * This program is distributed in the hope that it will be useful, > - * but WITHOUT ANY WARRANTY; without even the implied warranty of > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > - * GNU General Public License for more details. > */ > + > #ifndef __QCOM_TSENS_H__ > #define __QCOM_TSENS_H__ > Reviewed-by: Matthias Kaehlcke

Re: [PATCH v1 02/10] dt-bindings: thermal: Fix a typo in documentation

are ordered and they match with sensors > by means of sensor ID. Additional coefficients are Reviewed-by: Matthias Kaehlcke

Re: [PATCH v1 05/10] thermal: tsens: Rename map field in order to add a second address map

40,7 +40,7 @@ static int get_temp_tsens_v2(struct tsens_device *tmdev, > int id, int *temp) > } > > /* Try a third/last time */ > - ret = regmap_read(tmdev->map, status_reg, ); > + ret = regmap_read(tmdev->tm_map, status_reg, ); > if (ret) > return ret; > if (code & STATUS_VALID_BIT) { > diff --git a/drivers/thermal/qcom/tsens.h b/drivers/thermal/qcom/tsens.h > index 8207610f326a..58e98c4d3a8b 100644 > --- a/drivers/thermal/qcom/tsens.h > +++ b/drivers/thermal/qcom/tsens.h > @@ -69,7 +69,7 @@ struct tsens_context { > struct tsens_device { > struct device *dev; > u32 num_sensors; > - struct regmap *map; > + struct regmap *tm_map; > u32 tm_offset; > struct tsens_contextctx; > const struct tsens_ops *ops; Reviewed-by: Matthias Kaehlcke

Re: [PATCH v1 06/10] thermal: tsens: Add the SROT address map

t; struct regmap *tm_map; > + struct regmap *srot_map; > u32 tm_offset; > struct tsens_contextctx; > const struct tsens_ops *ops; Reviewed-by: Matthias Kaehlcke

Re: [PATCH v1 07/10] thermal: tsens: Check if the IP is correctly enabled by firmware

->tm_map); > > + if (tmdev->srot_map) { > + ret = regmap_read(tmdev->srot_map, CTRL_OFFSET, ); > + if (ret) > + return ret; > + if (!(code & TSENS_EN)) { > + dev_err(tmdev->dev, "tsens device is not enabled\n"); > + return -ENODEV; > + } > + } > + > return 0; > } Reviewed-by: Matthias Kaehlcke

Re: [PATCH v1 09/10] arm64: dts: qcom: Add reg-names for all tsens nodes

@@ > compatible = "qcom,sdm845-tsens", "qcom,tsens-v2"; > reg = <0xc263000 0x1ff>, /* TM */ > <0xc222000 0x1ff>; /* SROT */ > + reg-names = "tsens0_tm", "tsens0_srot"; > #qcom,sensors = <13>; > #thermal-sensor-cells = <1>; > }; > @@ -1539,6 +1540,7 @@ > compatible = "qcom,sdm845-tsens", "qcom,tsens-v2"; > reg = <0xc265000 0x1ff>, /* TM */ > <0xc223000 0x1ff>; /* SROT */ > + reg-names = "tsens1_tm", "tsens1_srot"; > #qcom,sensors = <8>; > #thermal-sensor-cells = <1>; > }; Reviewed-by: Matthias Kaehlcke

Re: [PATCH v1 10/10] MAINTAINERS: Add entry for Qualcomm TSENS thermal drivers

> +L: linux...@vger.kernel.org > +L: linux-arm-...@vger.kernel.org > +S: Maintained > +F: drivers/thermal/qcom/ > + > QUALCOMM VENUS VIDEO ACCELERATOR DRIVER > M: Stanimir Varbanov > L: linux-me...@vger.kernel.org FWIW: Reviewed-by: Matthias Kaehlcke

Re: [PATCH v1 08/10] thermal: tsens: Get rid of 'id' field

ic status register addresses > + */ > struct tsens_sensor { > struct tsens_device *tmdev; > struct thermal_zone_device *tzd; > int offset; > - int id; > int hw_id; > int slope; > u32 status; Reviewed-by: Matthias Kaehlcke

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

Hi Chanwoo, On Fri, Aug 03, 2018 at 08:56:57AM +0900, Chanwoo Choi wrote: > Hi Matthias, > > On 2018년 08월 03일 08:13, Matthias Kaehlcke wrote: > > Hi Chanwoo, > > > > On Thu, Aug 02, 2018 at 10:58:59AM +0900, Chanwoo Choi wrote: > >> Hi Matthias, > &

[PATCH 0/3] arm64: dts: qcom: pm8998: Add ADC node and die temperature channel

on it) Matthias Kaehlcke (3): dt-bindings: iio: vadc: Fix documentation of 'reg' arm64: dts: qcom: pm8998: Add adc node arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC .../bindings/iio/adc/qcom,spmi-vadc.txt| 4 ++-- arch/arm64/boot/dts/qcom/pm8998.dtsi | 18

[PATCH 2/3] arm64: dts: qcom: pm8998: Add adc node

This adds the adc node to pm8998 based on the examples in the bindings. It also fixes the order of the included headers. Signed-off-by: Matthias Kaehlcke --- arch/arm64/boot/dts/qcom/pm8998.dtsi | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot

[PATCH 1/3] dt-bindings: iio: vadc: Fix documentation of 'reg'

ster length from the documentation of the field and the example. Signed-off-by: Matthias Kaehlcke --- Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt b/Document

<    3   4   5   6   7   8   9   10   11   12   >