Hi Yixun, thanks for the review
2018-08-03 16:14 GMT+02:00 Yixun Lan :
>> +config MESON_CANVAS
>> + bool "Amlogic Meson Canvas driver"
> shouldn't this a 'tristate'? since you'd make the driver a kernel module..
Yep it should!
I well noted your other feedback and v2 will have fixes for
>> + sysctrl_DMC: system-controller@0 {
>> + compatible = "amlogic,meson-gx-dmc-sysctrl",
>> "syscon", "simple-mfd";
>
> we'd like to drop 'meson-' prefix, so better using "amlogic,gx-dmc-sysctrl",
> please take a look at the discussion here [1]
Amlogic SoCs have a repository of 256 canvas which they use to
describe pixel buffers.
They contain metadata like width, height, block mode, endianness [..]
Many IPs within those SoCs like vdec/vpu rely on those canvas to read/write
pixels.
Signed-off-by: Maxime Jourdan
---
drivers/soc
DT bindings doc for amlogic,meson-canvas
Signed-off-by: Maxime Jourdan
---
.../soc/amlogic/amlogic,meson-canvas.txt | 36 +++
1 file changed, 36 insertions(+)
create mode 100644
Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-canvas.txt
diff --git
Wrap the canvas node in a syscon node.
Signed-off-by: Maxime Jourdan
---
arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 17 +
1 file changed, 17 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
index b8dc4dbb391b
Hi Neil,
2018-08-02 10:38 GMT+02:00 Neil Armstrong :
> Please switch to the spdx header format here and in the .h.
> In the DRM driver these are updated in IRQ context, we should make sure we
> don't sleep
> in interrupt context if IRQ occurs when the VDEC updates it's canvases.
>
> Could you
Wrap the canvas node in a syscon node.
Signed-off-by: Maxime Jourdan
---
arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 17 +
1 file changed, 17 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
index b8dc4dbb391b
DT bindings doc for amlogic,meson-canvas
Signed-off-by: Maxime Jourdan
---
.../soc/amlogic/amlogic,meson-canvas.txt | 36 +++
1 file changed, 36 insertions(+)
create mode 100644
Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-canvas.txt
diff --git
Amlogic SoCs have a repository of 256 canvas which they use to
describe pixel buffers.
They contain metadata like width, height, block mode, endianness [..]
Many IPs within those SoCs like vdec/vpu rely on those canvas to read/write
pixels.
Signed-off-by: Maxime Jourdan
Tested-by: Neil
-by: Maxime Jourdan
Tested-by: Neil Armstrong
---
.../bindings/display/amlogic,meson-vpu.txt| 9 +--
arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 7 +-
drivers/gpu/drm/meson/Kconfig | 1 +
drivers/gpu/drm/meson/Makefile| 2 +-
drivers/gpu/drm/meson
2018-08-13 21:07 GMT+02:00 Rob Herring :
> On Wed, Aug 08, 2018 at 12:00:09AM +0200, Maxime Jourdan wrote:
>> DT bindings doc for amlogic,meson-canvas
>>
>> Signed-off-by: Maxime Jourdan
>> ---
>> .../soc/amlogic/amlogic,meson-canvas.txt | 36 +
2018-08-08 17:10 GMT+02:00 Neil Armstrong :
> On 08/08/2018 09:45, Jerome Brunet wrote:
>> On Wed, 2018-08-08 at 00:00 +0200, Maxime Jourdan wrote:
>>> Amlogic SoCs have a repository of 256 canvas which they use to
>>> describe pixel buffers.
>>>
>>> Th
2018-08-09 9:53 GMT+02:00 Neil Armstrong :
> On 08/08/2018 10:41, Jerome Brunet wrote:
>> On Wed, 2018-08-08 at 00:00 +0200, Maxime Jourdan wrote:
>>> Wrap the canvas node in a syscon node.
>>>
>>> Signed-off-by: Maxime Jourdan
>>> ---
>&g
DMC is a small memory region with various registers,
including the ones needed for the canvas module.
Reviewed-by: Jerome Brunet
Signed-off-by: Maxime Jourdan
---
arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 13 +
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts
Maxime Jourdan (3):
dt-bindings: soc: amlogic: add meson-canvas documentation
soc: amlogic: add meson-canvas driver
ARM64: dts: meson-gx: add dmcbus and canvas nodes.
.../bindings/soc/amlogic/amlogic,canvas.txt | 29 +++
arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 13 ++
drivers/soc
DT bindings doc for amlogic,meson-canvas
Reviewed-by: Jerome Brunet
Signed-off-by: Maxime Jourdan
---
.../bindings/soc/amlogic/amlogic,canvas.txt | 29 +++
1 file changed, 29 insertions(+)
create mode 100644
Documentation/devicetree/bindings/soc/amlogic/amlogic,canvas.txt
Signed-off-by: Maxime Jourdan
---
drivers/soc/amlogic/Kconfig | 7 +
drivers/soc/amlogic/Makefile | 1 +
drivers/soc/amlogic/meson-canvas.c | 185 +++
include/linux/soc/amlogic/meson-canvas.h | 65
4 files changed, 258 insertions
Hi Kevin,
Please create an immutable tag for this patch, as this is a hard
dependency for the video decoder patches. This will make it easier for
Mauro.
Thanks,
Maxime
Hi Kevin,
If you don't mind, please change the title from "ARM64" to "arm64" if
this gets merged.
Thanks!
Maxime
Signed-off-by: Maxime Jourdan <maxi.jour...@wanadoo.fr>
---
include/dt-bindings/clock/gxbb-clkc.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/dt-bindings/clock/gxbb-clkc.h
b/include/dt-bindings/clock/gxbb-clkc.h
index 8ba99a5e3fd3..7a892be90549 100644
--- a/include/dt-bi
Add the SEL/DIV/GATE for VDEC_1 and VDEC_HEVC.
Signed-off-by: Maxime Jourdan <maxi.jour...@wanadoo.fr>
---
drivers/clk/meson/gxbb.c | 114 +++
drivers/clk/meson/gxbb.h | 6 ++-
2 files changed, 119 insertions(+), 1 deletion(-)
diff --git a/drivers/clk
CLK_SET_RATE_NO_REPARENT to CLK_SET_RATE_PARENT for muxes
- Add CLK_MUX_ROUND_CLOSEST for muxes
Maxime Jourdan (2):
clk: meson: gxbb: expose VDEC_1 and VDEC_HEVC clocks
clk: meson: gxbb: add the video decoder clocks
drivers/clk/meson/gxbb.c | 114 ++
drivers/clk/meson
Hi Neil,
On Mon, Nov 5, 2018 at 1:51 PM Neil Armstrong wrote:
>
> Hi Maxime,
>
> On 05/11/2018 11:45, Maxime Jourdan wrote:
> > The meson DRM driver currently uses constant, static canvas indexes.
> >
> > This is not optimal and could conflict with other d
The current condition makes it difficult to compile the amlogic/
drivers with COMPILE_TEST, or without ARCH_MESON in general.
Fixes kbuild errors with patch series that depend on drivers in that
directory, for instance the meson video decoder.
Signed-off-by: Maxime Jourdan
---
drivers/soc
Signed-off-by: Maxime Jourdan
---
include/dt-bindings/clock/gxbb-clkc.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/dt-bindings/clock/gxbb-clkc.h
b/include/dt-bindings/clock/gxbb-clkc.h
index 8ba99a5e3fd3..7a892be90549 100644
--- a/include/dt-bindings/clock/gxbb-clkc.h
+++ b
CLK_SET_RATE_NO_REPARENT to CLK_SET_RATE_PARENT for muxes
- Add CLK_MUX_ROUND_CLOSEST for muxes
Maxime Jourdan (2):
clk: meson: gxbb: expose VDEC_1 and VDEC_HEVC clocks
clk: meson: gxbb: add the video decoder clocks
drivers/clk/meson/gxbb.c | 114 ++
drivers/clk/meson
Add the SEL/DIV/GATE for VDEC_1 and VDEC_HEVC.
Signed-off-by: Maxime Jourdan
---
drivers/clk/meson/gxbb.c | 114 +++
drivers/clk/meson/gxbb.h | 6 ++-
2 files changed, 119 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk
Add an entry for the meson video decoder for amlogic SoCs.
Signed-off-by: Maxime Jourdan
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 429c6c624861..4aa50e83a494 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10215,6 +10215,14 @@ S
ux-firmware.git/commit/?id=e04cc56d0e6b6ff05924ff88fdba1a438ee7d3c8
[4] https://patchwork.kernel.org/cover/10879959/
[3] https://patchwork.kernel.org/cover/10669875/
[2] https://lore.kernel.org/patchwork/cover/993093/
[1] https://patchwork.kernel.org/cover/10595803/
[0] https://patchwork.kernel.org/cover/10583391/
start.
Add a enum_fmt format flag to tag those specific formats.
Signed-off-by: Maxime Jourdan
---
Documentation/media/uapi/v4l/vidioc-enum-fmt.rst | 6 ++
include/uapi/linux/videodev2.h | 5 +++--
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/Documentation
(S912)
There is also a hardware bitstream parser (ESPARSER) that is handled here.
Signed-off-by: Maxime Jourdan
---
drivers/staging/media/Kconfig |2 +
drivers/staging/media/Makefile|1 +
drivers/staging/media/meson/vdec/Kconfig | 11 +
drivers
Add documentation for the meson vdec dts node.
Signed-off-by: Maxime Jourdan
Reviewed-by: Rob Herring
---
.../bindings/media/amlogic,vdec.txt | 71 +++
1 file changed, 71 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/amlogic,vdec.txt
diff
Both MESON AO CEC and MESON VIDEO DECODER point to the wrong linux-media
mailing list. Update it to linux-me...@vger.kernel.org.
Signed-off-by: Maxime Jourdan
---
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index ad2bf808b02c
buf_idx)
> static int codec_mpeg12_start(struct amvdec_session *sess)
> {
> struct amvdec_core *core = sess->core;
> - struct codec_mpeg12 *mpeg12 = sess->priv;
> + struct codec_mpeg12 *mpeg12;
> int ret;
>
> mpeg12 = kzalloc(sizeof(*mpeg12), GFP_KERNEL);
> --
> 2.20.1
>
Thank you for the patch.
Acked-by: Maxime Jourdan
Hi Randy,
On Wed, Jun 12, 2019 at 11:50 PM Randy Dunlap wrote:
>
> On 6/12/19 12:00 AM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20190611:
> >
>
>
> on i386:
>
> ../drivers/staging/media/meson/vdec/vdec.c: In function ‘vdec_recycle_thread’:
>
On Tue, Jun 11, 2019 at 10:29 AM Hans Verkuil wrote:
>
> On 6/10/19 9:54 PM, Nicolas Dufresne wrote:
> > Hi Hans,
> >
> > I went through it, and I think we are close to ready. Unfortunately, I
> > believe the SOURCE_CHANGE event is still under specified. There was a
> > post recently to try and
Hey Martin, so sorry for forgetting about this.
On Thu, Apr 18, 2019 at 9:50 PM Martin Blumenstingl
wrote:
>
> Hi Maxime,
>
> On Sat, Apr 13, 2019 at 8:54 PM Maxime Jourdan
> wrote:
> >
> > Hi Martin,
> > On Sat, Apr 13, 2019 at 7:15 PM Martin Blumenstingl
On Mon, May 20, 2019 at 9:44 PM Martin Blumenstingl
wrote:
>
> Signed-off-by: Martin Blumenstingl
Reviewed-by: Maxime Jourdan
On 20/05/2019 21:43, Martin Blumenstingl wrote:
Signed-off-by: Martin Blumenstingl
Acked-by: Maxime Jourdan
cases when it comes to video
decode/encode accelerators.
Signed-off-by: Maxime Jourdan
---
Documentation/devicetree/bindings/media/amlogic,vdec.txt | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/amlogic,vdec.txt
b/Documentation
This enables the video decoder for GXBB, GXL and GXM chips
Signed-off-by: Maxime Jourdan
---
arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 11 +++
arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 11 +++
arch/arm64/boot/dts/amlogic/meson-gxm.dtsi | 4
3 files changed, 26
This series adds the dts nodes for the Amlogic video decoder for the
GXBB (S905), GXL (S905X) and GXM (S912) SoCs.
It also includes two misc. fixes for the bindings documentation:
a missing generic compatible and changing the example node's type
to something more conventional.
Maxime Jourdan (3
Add the base video decoder node compatible with the meson vdec driver,
for GX* chips.
Signed-off-by: Maxime Jourdan
---
arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 14 ++
1 file changed, 14 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
b/arch/arm64/boot/dts
nar: Captured 250 buffers
test MMAP (epoll): OK
test USERPTR (select): OK (Not Supported)
test DMABUF: Cannot test, specify --expbuf-device
Total for meson-vdec device /dev/video0: 49, Succeeded: 49, Failed: 0,
Warnings: 0
Maxime Jourdan (2):
media: meson: vdec: bring up to c
the src buffers to the dst buffers, etc.
Signed-off-by: Maxime Jourdan
---
drivers/staging/media/meson/vdec/esparser.c | 34 ++--
drivers/staging/media/meson/vdec/vdec.c | 70 ++-
drivers/staging/media/meson/vdec/vdec.h | 14 ++-
.../staging/media/meson/vdec
Add support for the H264 compressed format (V4L2_PIX_FMT_H264).
Signed-off-by: Maxime Jourdan
---
drivers/staging/media/meson/vdec/Makefile | 2 +-
drivers/staging/media/meson/vdec/codec_h264.c | 482 ++
drivers/staging/media/meson/vdec/codec_h264.h | 14 +
.../staging
On 07/10/2019 17:12, Hans Verkuil wrote:
On 10/7/19 4:59 PM, Maxime Jourdan wrote:
Hello,
This patch series aims to bring H.264 support as well as compliance update
to the amlogic stateful video decoder driver.
There is 1 issue that remains currently:
- The following codepath had
On 07/10/2019 18:39, Hans Verkuil wrote:
On 10/7/19 6:24 PM, Maxime Jourdan wrote:
On 07/10/2019 17:12, Hans Verkuil wrote:
On 10/7/19 4:59 PM, Maxime Jourdan wrote:
Hello,
This patch series aims to bring H.264 support as well as compliance update
to the amlogic stateful video decoder driver
On Tue, Oct 8, 2019 at 10:44 PM Nicolas Dufresne wrote:
>
> Le mardi 08 octobre 2019 à 16:27 -0400, Nicolas Dufresne a écrit :
> > Le lundi 07 octobre 2019 à 16:59 +0200, Maxime Jourdan a écrit :
> > > Add support for the H264 compressed format (V4L2_PIX_FMT_H264).
&
On Wed, Oct 9, 2019 at 2:01 PM Hans Verkuil wrote:
>
> On 10/8/19 3:40 PM, Maxime Jourdan wrote:
> > On 07/10/2019 18:39, Hans Verkuil wrote:
> >> On 10/7/19 6:24 PM, Maxime Jourdan wrote:
> >>> On 07/10/2019 17:12, Hans Verkuil wrote:
> >>&
On 18/10/2019 09:50, Maxime Jourdan wrote:
On Wed, Oct 9, 2019 at 2:01 PM Hans Verkuil wrote:
On 10/8/19 3:40 PM, Maxime Jourdan wrote:
On 07/10/2019 18:39, Hans Verkuil wrote:
On 10/7/19 6:24 PM, Maxime Jourdan wrote:
On 07/10/2019 17:12, Hans Verkuil wrote:
On 10/7/19 4:59 PM, Maxime
Hi Nicolas,
On 13/10/2019 03:08, Nicolas Dufresne wrote:
Le lundi 07 octobre 2019 à 16:59 +0200, Maxime Jourdan a écrit :
Hello,
This patch series aims to bring H.264 support as well as compliance update
to the amlogic stateful video decoder driver.
There is 1 issue that remains currently
a bit too soon to have this in mainline at this time.
>
> One other comment below:
>
> On 5/14/19 3:56 PM, Maxime Jourdan wrote:
> > Amlogic SoCs feature a powerful video decoder unit able to
> > decode many formats, with a performance of usually up to 4k60.
> >
> > Th
On Mon, May 27, 2019 at 4:54 PM Hans Verkuil wrote:
>
> On 5/27/19 4:44 PM, Maxime Jourdan wrote:
> > Hi Hans,
> > On Mon, May 27, 2019 at 12:04 PM Hans Verkuil wrote:
> >>
> >> Hi Maxime,
> >>
> >> First a high-level comment: I think t
The SEI510 board features a standalone MAX98357A codec.
Add a tristate prompt to allow selecting the codec.
Signed-off-by: Maxime Jourdan
---
sound/soc/codecs/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index
Hello Arnd,
On Mon, Jun 17, 2019 at 1:17 PM Arnd Bergmann wrote:
>
> Without this header, we get a compilation error in some configurations:
>
> drivers/staging/media/meson/vdec/vdec.c: In function 'vdec_recycle_thread':
> drivers/staging/media/meson/vdec/vdec.c:59:10: error: implicit declaration
Add documentation for the meson vdec dts node.
Signed-off-by: Maxime Jourdan
Reviewed-by: Rob Herring
---
.../bindings/media/amlogic,vdec.txt | 71 +++
1 file changed, 71 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/amlogic,vdec.txt
diff
ux-firmware.git/commit/?id=e04cc56d0e6b6ff05924ff88fdba1a438ee7d3c8
[4] https://patchwork.kernel.org/cover/10879959/
[3] https://patchwork.kernel.org/cover/10669875/
[2] https://lore.kernel.org/patchwork/cover/993093/
[1] https://patchwork.kernel.org/cover/10595803/
[0] https://patchwork.kernel.org/cover/10583391/
Maxime Jourdan
Add an entry for the meson video decoder for amlogic SoCs.
Signed-off-by: Maxime Jourdan
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index b8fbf41865c2..7cf3ece9f0cb 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10222,6 +10222,14 @@ S
(S912)
There is also a hardware bitstream parser (ESPARSER) that is handled here.
Signed-off-by: Maxime Jourdan
---
drivers/staging/media/Kconfig |2 +
drivers/staging/media/Makefile|1 +
drivers/staging/media/meson/vdec/Kconfig | 11 +
drivers
Hi Hans,
On Thu, Jun 6, 2019 at 2:32 PM Hans Verkuil wrote:
>
> While preparing this series for merging I came across the following checkpatch
> and sparse warnings:
>
> checkpatch:
>
> CHECK: Alignment should match open parenthesis
> #159: FILE:
Add documentation for the meson vdec dts node.
Signed-off-by: Maxime Jourdan
Reviewed-by: Rob Herring
---
.../bindings/media/amlogic,vdec.txt | 71 +++
1 file changed, 71 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/amlogic,vdec.txt
diff
(S912)
There is also a hardware bitstream parser (ESPARSER) that is handled here.
Signed-off-by: Maxime Jourdan
---
drivers/staging/media/Kconfig |2 +
drivers/staging/media/Makefile|1 +
drivers/staging/media/meson/vdec/Kconfig | 11 +
drivers
Add an entry for the meson video decoder for amlogic SoCs.
Signed-off-by: Maxime Jourdan
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index b8fbf41865c2..7cf3ece9f0cb 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10222,6 +10222,14 @@ S
s://patchwork.kernel.org/cover/10595803/
[0] https://patchwork.kernel.org/cover/10583391/
Maxime Jourdan (3):
dt-bindings: media: add Amlogic Video Decoder Bindings
media: meson: add v4l2 m2m video decoder driver
MAINTAINERS: Add meson video decoder
.../bindings/media/amlogic,vdec.txt
Add an entry for the meson video decoder for amlogic SoCs.
Signed-off-by: Maxime Jourdan
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index b8fbf41865c2..7cf3ece9f0cb 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10222,6 +10222,14 @@ S
Add documentation for the meson vdec dts node.
Signed-off-by: Maxime Jourdan
Reviewed-by: Rob Herring
---
.../bindings/media/amlogic,vdec.txt | 71 +++
1 file changed, 71 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/amlogic,vdec.txt
diff
(S912)
There is also a hardware bitstream parser (ESPARSER) that is handled here.
Signed-off-by: Maxime Jourdan
---
drivers/staging/media/Kconfig |2 +
drivers/staging/media/Makefile|1 +
drivers/staging/media/meson/vdec/Kconfig | 11 +
drivers
5/
[2] https://lore.kernel.org/patchwork/cover/993093/
[1] https://patchwork.kernel.org/cover/10595803/
[0] https://patchwork.kernel.org/cover/10583391/
Maxime Jourdan (3):
dt-bindings: media: add Amlogic Video Decoder Bindings
media: meson: add v4l2 m2m video decoder driver
MAINTAINERS: Add meso
; #include
> #include
> #include
> +#include
> #include
> #include
> #include
> --
> 2.7.4
>
>
Thanks for the patch, sorry that this one slipped through.
Acked-by: Maxime Jourdan
ine AUD_CLKID_SLV_LRCLK8 27
> -#define AUD_CLKID_SLV_LRCLK9 28
> #define AUD_CLKID_DDR_ARB 29
> #define AUD_CLKID_PDM 30
> #define AUD_CLKID_TDMIN_A 31
> --
> 2.20.1
>
Acked-by: Maxime Jourdan
Allows the vpu driver to optionally use a canvas provider node.
Signed-off-by: Maxime Jourdan
---
arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
index
On Fri, Jan 11, 2019 at 11:25 PM Rob Herring wrote:
>
> On Mon, Jan 07, 2019 at 10:53:06AM +0100, Maxime Jourdan wrote:
> > Similar to simple-framebuffer-sunxi, we support different display pipelines
> > that the firmware is free to choose from.
> >
> > This
Similar to simple-framebuffer-sunxi, we support different display pipelines
that the firmware is free to choose from.
This documents the "amlogic,simple-framebuffer" compatible and the
"amlogic,pipeline" extension.
Reviewed-by: Rob Herring
Signed-off-by: Maxime Jourdan
---
SimpleFB allows transferring a framebuffer from the firmware/bootloader
to the kernel, while making sure the related clocks and power supplies
stay enabled.
Add nodes for CVBS and HDMI Simple Framebuffers.
Signed-off-by: Maxime Jourdan
---
arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 22
si
[1] https://patchwork.kernel.org/patch/10720879/
[2] https://patchwork.kernel.org/cover/10750205/
[3] https://patchwork.ozlabs.org/project/uboot/list/?series=86214
Maxime Jourdan (2):
dt-bindings: meson: add specific simplefb bindings
arm64: dts: meson-gx: add support for simplefb
.../display/
>dev);
> + if (!canvas)
> + return ERR_PTR(-EINVAL);
> +
> + return canvas;
> }
> EXPORT_SYMBOL_GPL(meson_canvas_get);
>
> --
> 2.20.1
>
>
> ___
> linux-arm-kernel mailing list
> linux-arm-ker...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thanks for the patch, I missed the fact that a driver could have a
pdev yet with a failed probe.
Reviewed-by: Maxime Jourdan
The current condition makes it difficult to compile the amlogic/
drivers with COMPILE_TEST, or without ARCH_MESON in general.
Fixes kbuild errors with patch series that depend on drivers in that
directory, for instance the meson video decoder.
Signed-off-by: Maxime Jourdan
---
drivers/soc
Hi Neil,
On Wed, Dec 12, 2018 at 10:55 AM Neil Armstrong wrote:
>
> Hi Maxime,
>
> On 10/12/2018 10:28, Maxime Jourdan wrote:
> > In case we are using simplefb or another conflicting framebuffer, make
> > the call to drm_fb_helper_remove_conflicting_framebuffers()
>
Hi Neil,
On Wed, Dec 12, 2018 at 10:54 AM Neil Armstrong wrote:
>
> Hi Maxime,
>
> On 10/12/2018 10:06, Maxime Jourdan wrote:
> > Similar to simple-framebuffer-sunxi, we support different display pipelines
> > that the firmware is free to choose from.
> >
> >
In case we are using simplefb or another conflicting framebuffer, make
the call to drm_fb_helper_remove_conflicting_framebuffers()
Signed-off-by: Maxime Jourdan
---
drivers/gpu/drm/meson/meson_drv.c | 20
1 file changed, 20 insertions(+)
diff --git a/drivers/gpu/drm/meson
2018-08-08 17:10 GMT+02:00 Neil Armstrong :
> On 08/08/2018 09:45, Jerome Brunet wrote:
>> On Wed, 2018-08-08 at 00:00 +0200, Maxime Jourdan wrote:
>>> Amlogic SoCs have a repository of 256 canvas which they use to
>>> describe pixel buffers.
>>>
>>> Th
2018-08-09 9:53 GMT+02:00 Neil Armstrong :
> On 08/08/2018 10:41, Jerome Brunet wrote:
>> On Wed, 2018-08-08 at 00:00 +0200, Maxime Jourdan wrote:
>>> Wrap the canvas node in a syscon node.
>>>
>>> Signed-off-by: Maxime Jourdan
>>> ---
>&g
2018-08-13 21:07 GMT+02:00 Rob Herring :
> On Wed, Aug 08, 2018 at 12:00:09AM +0200, Maxime Jourdan wrote:
>> DT bindings doc for amlogic,meson-canvas
>>
>> Signed-off-by: Maxime Jourdan
>> ---
>> .../soc/amlogic/amlogic,meson-canvas.txt | 36 +
Signed-off-by: Maxime Jourdan
---
drivers/soc/amlogic/Kconfig | 7 +
drivers/soc/amlogic/Makefile | 1 +
drivers/soc/amlogic/meson-canvas.c | 185 +++
include/linux/soc/amlogic/meson-canvas.h | 65
4 files changed, 258 insertions
DMC is a small memory region with various registers,
including the ones needed for the canvas module.
Reviewed-by: Jerome Brunet
Signed-off-by: Maxime Jourdan
---
arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 13 +
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts
Maxime Jourdan (3):
dt-bindings: soc: amlogic: add meson-canvas documentation
soc: amlogic: add meson-canvas driver
ARM64: dts: meson-gx: add dmcbus and canvas nodes.
.../bindings/soc/amlogic/amlogic,canvas.txt | 29 +++
arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 13 ++
drivers/soc
DT bindings doc for amlogic,meson-canvas
Reviewed-by: Jerome Brunet
Signed-off-by: Maxime Jourdan
---
.../bindings/soc/amlogic/amlogic,canvas.txt | 29 +++
1 file changed, 29 insertions(+)
create mode 100644
Documentation/devicetree/bindings/soc/amlogic/amlogic,canvas.txt
Amlogic SoCs have a repository of 256 canvas which they use to
describe pixel buffers.
They contain metadata like width, height, block mode, endianness [..]
Many IPs within those SoCs like vdec/vpu rely on those canvas to read/write
pixels.
Signed-off-by: Maxime Jourdan
---
drivers/soc
DT bindings doc for amlogic,meson-canvas
Signed-off-by: Maxime Jourdan
---
.../soc/amlogic/amlogic,meson-canvas.txt | 36 +++
1 file changed, 36 insertions(+)
create mode 100644
Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-canvas.txt
diff --git
Wrap the canvas node in a syscon node.
Signed-off-by: Maxime Jourdan
---
arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 17 +
1 file changed, 17 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
index b8dc4dbb391b
Hi Neil,
2018-08-02 10:38 GMT+02:00 Neil Armstrong :
> Please switch to the spdx header format here and in the .h.
> In the DRM driver these are updated in IRQ context, we should make sure we
> don't sleep
> in interrupt context if IRQ occurs when the VDEC updates it's canvases.
>
> Could you
Hi Yixun, thanks for the review
2018-08-03 16:14 GMT+02:00 Yixun Lan :
>> +config MESON_CANVAS
>> + bool "Amlogic Meson Canvas driver"
> shouldn't this a 'tristate'? since you'd make the driver a kernel module..
Yep it should!
I well noted your other feedback and v2 will have fixes for
>> + sysctrl_DMC: system-controller@0 {
>> + compatible = "amlogic,meson-gx-dmc-sysctrl",
>> "syscon", "simple-mfd";
>
> we'd like to drop 'meson-' prefix, so better using "amlogic,gx-dmc-sysctrl",
> please take a look at the discussion here [1]
Amlogic SoCs have a repository of 256 canvas which they use to
describe pixel buffers.
They contain metadata like width, height, block mode, endianness [..]
Many IPs within those SoCs like vdec/vpu rely on those canvas to read/write
pixels.
Signed-off-by: Maxime Jourdan
Tested-by: Neil
-by: Maxime Jourdan
Tested-by: Neil Armstrong
---
.../bindings/display/amlogic,meson-vpu.txt| 9 +--
arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 7 +-
drivers/gpu/drm/meson/Kconfig | 1 +
drivers/gpu/drm/meson/Makefile| 2 +-
drivers/gpu/drm/meson
Wrap the canvas node in a syscon node.
Signed-off-by: Maxime Jourdan
---
arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 17 +
1 file changed, 17 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
index b8dc4dbb391b
DT bindings doc for amlogic,meson-canvas
Signed-off-by: Maxime Jourdan
---
.../soc/amlogic/amlogic,meson-canvas.txt | 36 +++
1 file changed, 36 insertions(+)
create mode 100644
Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-canvas.txt
diff --git
Add documentation for the meson vdec dts node.
Reviewed-by: Rob Herring
Signed-off-by: Maxime Jourdan
---
.../bindings/media/amlogic,vdec.txt | 71 +++
1 file changed, 71 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/amlogic,vdec.txt
diff
(S912)
There is also a hardware bitstream parser (ESPARSER) that is handled here.
Tested-by: Neil Armstrong
Signed-off-by: Maxime Jourdan
---
drivers/media/platform/Kconfig| 10 +
drivers/media/platform/meson/Makefile |1 +
drivers/media/platform/meson/vdec/Makefile
1 - 100 of 127 matches
Mail list logo
