oke too soon. Maxime hasn't pushed it out yet. Could you send
> a patch adding touchscreen-swapped-x-y for Maxime to squash in?
I did the last DT pull request for 4.4 yesterday, so I won't squash
any patches.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
signature.asc
Description: Digital signature
On Fri, Oct 23, 2015 at 09:20:13PM +0200, Jean-Francois Moine wrote:
> On Fri, 23 Oct 2015 20:14:06 +0200
> Maxime Ripard wrote:
>
> > On Wed, Oct 21, 2015 at 06:20:27PM +0200, Jens Kuske wrote:
> > > + bus_gates: clk@01c20060 {
> > > +
"PC15";
> + allwinner,function = "mmc2";
> + allwinner,drive = ;
> + allwinner,pull = ;
> + };
> +
> + uart0_pins_a: uart0@0 {
> + allwinner,pins = "PF2", "PF4";
> + allwinner,function = "uart0";
> + allwinner,drive = ;
> + allwinner,pull = ;
> + };
> +
> + uart0_pins_b: uart0@1 {
> + allwinner,pins = "PB9", "PB10";
> + allwinner,function = "uart0";
> + allwinner,drive = ;
> + allwinner,pull = ;
> + };
Are you going to use all these options?
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
signature.asc
Description: Digital signature
;
> You asked if I had tested the pm operations which I hadn't so I
> removed them after looking at your driver and searching for pm_runtime
> usage elsewhere in sound/soc. I will add them back.
What we asked you to remove were the suspend / resume hooks. What we
want you to add are runtime_pm hooks. These are not the same hooks,
and they're not called at the same moment.
The suspend / resume hooks are called before entering suspend and
after coming back from it. We don't have no way to suspend at the
moment, so there's no way you've been able to test it.
The runtime_pm hooks are called whenever your device start to be used
(for example when you start playing back an audio file on your
system).
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
signature.asc
Description: Digital signature
On Sat, Oct 24, 2015 at 10:39:49AM +0200, Hans de Goede wrote:
> Hi,
>
> On 10/23/2015 08:14 PM, Maxime Ripard wrote:
> >On Wed, Oct 21, 2015 at 06:20:27PM +0200, Jens Kuske wrote:
> >>+ bus_gates: clk@01c20060 {
> >>+
On Sat, Oct 24, 2015 at 10:47:49AM +0200, Jean-Francois Moine wrote:
> On Sat, 24 Oct 2015 09:13:28 +0200
> Maxime Ripard wrote:
>
> > Or simply
> >
> > bus_gates {
> > clocks = <&ahb1>, <&ahb2>;
> > clock-indices = <5&g
On Wed, Sep 30, 2015 at 03:38:29PM -0700, Stephen Boyd wrote:
> On 09/18, Maxime Ripard wrote:
> > The R8 is a new Allwinner SoC based on the A13. While both are very
> > similar, there's still a few differences. Introduce a new compatible to
> > deal with them.
>
its time would reset. Hence
> we want to use the external one by default.
The patch looks fine, but I'm not sure to understand the first
sentence of that paragraph :/
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
si
Hi,
On Tue, Sep 29, 2015 at 10:32:59AM -0400, Josh Boyer wrote:
> On Sun, Sep 6, 2015 at 7:20 AM, Maxime Ripard
> wrote:
> > On Fri, Sep 04, 2015 at 08:49:34AM -0400, Josh Boyer wrote:
> >> Commit 79ae3e66f8d (ARM: dts: sun4i: Add Iteaduino Plus A10) added a new
> >
. When external power is
> removed, the internal rtc would reset. Hence we want to use the
> external one by default.
>
> Add aliases for the rtc devices with the external one as rtc0.
>
> Signed-off-by: Chen-Yu Tsai
Ordered the aliases alphabetically, and applied. Thanks!
Maxime
Just like memset support, the HDMAC might be used to do a memset over a
discontiguous memory area.
In such a case, we'll just build up a chain of memset descriptors over the
contiguous chunks of memory to set, in order to allow such a support.
Signed-off-by: Maxime Ripard
---
driver
The memset and scatter gathered memset are going to use some common logic
to create their descriptors.
Move that logic into a function of its own so that we can share it with the
future memset_sg callback.
Signed-off-by: Maxime Ripard
---
drivers/dma/at_hdmac.c | 98
et me know what you think,
Maxime
Maxime Ripard (2):
dmaengine: hdmac: factorise memset descriptor allocation
dmaengine: hdmac: Add scatter-gathered memset support
drivers/dma/at_hdmac.c | 169 ++--
drivers/dma/at_hdmac_regs.h | 2 +-
2 files ch
": for the Allwinner A10 SoC
> +- "allwinner,sun7i-a20-spdif": for the Allwinner A20 SoC
> +- "allwinner,sun6i-a31-spdif": for the Allwinner A31 SoC
Are all these compatibles really work? Is there any significant
difference between the controller on all these SoCs?
; gc->reg_base = of_iomap(node, 0);
> if (!gc->reg_base) {
> - pr_err("%s: unable to map resource\n", node->name);
> + pr_err("%s: unable to map resource\n", DRV_NAME);
All the pr_err changes can even be replaced by defining pr_fmt.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
signature.asc
Description: Digital signature
On Wed, Sep 30, 2015 at 05:36:49AM -0700, Michael Turquette wrote:
> Quoting Maxime Ripard (2015-08-28 20:55:57)
> > Hi Mike,
> >
> > On Tue, Aug 25, 2015 at 02:50:51PM -0700, Michael Turquette wrote:
> > > Quoting Maxime Ripard (2015-08-20 08:15:10)
> > &g
; + dev_err(&pdev->dev,
> + "Setting SPDIF clock rate for %d Hz failed!\n", mclk);
> + return ret;
> + }
> +
> + reg_val = 0;
> + reg_val &= ~SUN4I_SPDIF_FCTL_FIFOSRC;
> + reg_val |= SUN4I_SPDIF_FCTL_TXTL_MASK;
> + reg_val |= SUN4I_SPDIF_FCTL_RXTL_MASK;
> + reg_val |= SUN4I_SPDIF_FCTL_TXIM;
> + reg_val |= SUN4I_SPDIF_FCTL_RXOM_MASK;
> + regmap_write(host->regmap, SUN4I_SPDIF_FCTL, reg_val);
You're still not using regmap_update_bits...
IF you're really going to ignore all the comments we did, please tell
us upfront. That way, we will not waste our time doing a review of
your patches.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
signature.asc
Description: Digital signature
c22c00.codec: ASoC: Failed to add route HP Right -> direct ->
Headphone Jack
Reported-by: Priit Laes
Signed-off-by: Maxime Ripard
---
.../devicetree/bindings/sound/sun4i-codec.txt | 9
sound/soc/sunxi/sun4i-codec.c | 25 +-
2 files
15 active slave devices.
>
> Signed-off-by: Chen-Yu Tsai
Acked-by: Maxime Ripard
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
signature.asc
Description: Digital signature
The fact of the matter is we won't know until these SoCs
> have been tested and with that in mind I'm happy to remove all
> capabilities for now until then.
The point was more that you document compatibles that you are not
actually supporting.
You've only tested it on one SoC (a
On Wed, Jun 20, 2018 at 11:30:55AM +0200, Emmanuel Vadot wrote:
> The card detect GPIO for Sopine and Pine64-LTS is PF6.
> Add this to the dts.
>
> Signed-off-by: Emmanuel Vadot
Applied, thanks!
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel
Hi!
On Thu, Jun 21, 2018 at 11:49:54AM +0200, Paul Kocialkowski wrote:
> Hi,
>
> On Wed, 2018-06-13 at 16:07 +0200, Maxime Ripard wrote:
> > In order to increase the number of codecs supported, we need to decouple
> > the MPEG2 only code that was there up until now and t
Hi!
On Fri, Aug 24, 2018 at 05:51:37PM +0300, Georgi Djakov wrote:
> Hi Maxime,
>
> On 08/20/2018 06:32 PM, Maxime Ripard wrote:
> > Hi Georgi,
> >
> > On Tue, Aug 07, 2018 at 05:54:38PM +0300, Georgi Djakov wrote:
> >>> There is also a patch series f
On Fri, Aug 24, 2018 at 10:35:23AM -0500, Rob Herring wrote:
> On Fri, Aug 24, 2018 at 9:51 AM Georgi Djakov
> wrote:
> >
> > Hi Maxime,
> >
> > On 08/20/2018 06:32 PM, Maxime Ripard wrote:
> > > Hi Georgi,
> > >
> > > On Tue, Aug 07, 201
y
> pool has to be located in that area. Following Allwinner's decision in
> downstream software, the last 96 MiB of the first 256 MiB of RAM are
> reserved for this purpose.
>
> Signed-off-by: Paul Kocialkowski
Acked-by: Maxime Ripard
Maxime
--
Maxime Ripard, Bootlin
Embed
On Sat, Aug 25, 2018 at 05:43:52PM +0200, Emmanuel Vadot wrote:
>
> Hi,
>
> On Fri, 24 Aug 2018 16:03:40 -0700
> Eduardo Valentin wrote:
>
> > On Fri, Aug 24, 2018 at 09:59:21PM +0200, Emmanuel Vadot wrote:
> > >
> > > Hi,
> > >
> >
On Fri, Aug 24, 2018 at 09:59:21PM +0200, Emmanuel Vadot wrote:
>
> Hi,
>
> On Fri, 24 Aug 2018 16:58:40 +0200
> Maxime Ripard wrote:
>
> > Hi,
> >
> > On Mon, Aug 20, 2018 at 04:27:15PM +0200, Emmanuel Vadot wrote:
> > > On Mon, 20 Aug 2
Hi,
On Wed, Aug 29, 2018 at 03:33:29PM +0300, Georgi Djakov wrote:
> On 08/27/2018 06:11 PM, Maxime Ripard wrote:
> > On Fri, Aug 24, 2018 at 10:35:23AM -0500, Rob Herring wrote:
> >> On Fri, Aug 24, 2018 at 9:51 AM Georgi Djakov
> >> wrote:
> >>>
> &
Hi,
On Mon, Aug 20, 2018 at 04:27:15PM +0200, Emmanuel Vadot wrote:
> On Mon, 20 Aug 2018 16:07:37 +0200
> Maxime Ripard wrote:
>
> > On Mon, Aug 20, 2018 at 07:41:22AM -0600, Rob Herring wrote:
> > > On Mon, Aug 20, 2018 at 5:17 AM Maxime Ripard
> > > wrot
1;5202;0c
On Thu, Jul 26, 2018 at 12:21:46PM +0530, Akash Gajjar wrote:
> This board has SPI flash. add spi flash support in device tree.
> Tested on pine64 LTS.
>
> Signed-off-by: Akash Gajjar
Queued for 4.20, thanks!
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Em
On Thu, Jul 26, 2018 at 09:29:24AM +0200, Maxime Ripard wrote:
> 1;5202;0c
> On Thu, Jul 26, 2018 at 12:21:46PM +0530, Akash Gajjar wrote:
> > This board has SPI flash. add spi flash support in device tree.
> > Tested on pine64 LTS.
> >
> > Signed-off-by: Akas
On Tue, Jul 24, 2018 at 04:55:01PM +0200, Emmanuel Vadot wrote:
> On Tue, 24 Jul 2018 16:42:18 +0200
> Maxime Ripard wrote:
>
> > On Tue, Jul 24, 2018 at 03:34:32PM +0200, Emmanuel Vadot wrote:
> > > On Tue, 24 Jul 2018 15:00:04 +0200
> > > Maxime Ripard wro
On Fri, Jul 27, 2018 at 01:52:02PM +0200, Emmanuel Vadot wrote:
> The A64 have a SID controller which consist of EFUSE (starting at 0x200)
> and three registers to read/write some of the protected efuses.
>
> Signed-off-by: Emmanuel Vadot
Queued all 4 for 4.20, thanks!
Maxime
--
M
;
> compatible = "allwinner,sun50i-h5-pinctrl";
> };
> +
> +&sid {
> + compatible = "allwinner,sun50i-h5-sid",
> + "allwinner,sun50i-a64-sid";
> +};
I'm not sure doing a split similar to what you're
property isn
> + spi-max-frequency = <4000>;
> +
> + uboot@0 {
> + label = "uboot";
> + reg = <0x0 0x10>;
> + };
> +
> + rootfs@0 {
> + label = "root
n
Applied (while slighly changing your commit title, the prefix should
be "ARM: dts: sun4i: ..")
Thanks!
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
signature.asc
Description: PGP signature
quot;,
> + "allwinner,sun50i-a64-sid";
> +};
This is still a bit pointless, please remove the common node.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
signature.asc
Description: PGP signature
tart with dt-bindings: ...
Thanks!
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
signature.asc
Description: PGP signature
On Tue, Jul 24, 2018 at 03:34:32PM +0200, Emmanuel Vadot wrote:
> On Tue, 24 Jul 2018 15:00:04 +0200
> Maxime Ripard wrote:
>
> > On Tue, Jul 24, 2018 at 12:15:22PM +0200, Emmanuel Vadot wrote:
> > > The SID controller on H5 look the same as the one present in the A64.
&
On Tue, Jul 24, 2018 at 10:42:32PM +0800, Icenowy Zheng wrote:
>
>
> 于 2018年7月24日 GMT+08:00 下午10:41:51, Maxime Ripard
> 写到:
> >On Tue, Jul 24, 2018 at 10:37:51AM +0800, Chen-Yu Tsai wrote:
> >> On Tue, Jul 24, 2018 at 10:28 AM, Icenowy Zheng
> >wrote:
> &g
ommit log seems to suggest that it's only relevant for the newer
SoCs (which ones?), yet you enable it for all the supported
ones. Either the code or the commit log should be adjusted to be
consistent with the other.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
Hi,
On Wed, Jan 24, 2018 at 08:37:28PM +0100, Giulio Benetti wrote:
> Hi,
>
> Il 24/01/2018 18:38, Giulio Benetti ha scritto:
> > Hi,
> >
> > Il 22/01/2018 21:27, Giulio Benetti ha scritto:
> > > Hi,
> > >
> > > Il 22/01/2018 09:51, Maxime
Hi,
On Wed, Jan 24, 2018 at 09:10:34PM +0800, Icenowy Zheng wrote:
> 在 2018年1月22日星期一 CST 下午8:14:35，Maxime Ripard 写道：
> > On Sat, Jan 20, 2018 at 07:17:26AM +0800, Icenowy Zheng wrote:
> > > This is the RFC initial patchset for the "new" Allwinner SUNIV ARM9 SoC.
headers.
>
> Signed-off-by: Icenowy Zheng
> Acked-by: Rob Herring
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
ng
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
@@ static int sun4i_gpadc_remove(struct platform_device
> *pdev)
>
> pm_runtime_put(&pdev->dev);
> pm_runtime_disable(&pdev->dev);
> +
> + if (pdev->dev.of_node)
> + thermal_zone_of_sensor_unregister(&pdev->dev, info->tzd);
> + else
> + thermal_zone_of_sensor_unregister(pdev->dev.parent, info->tzd);
> +
Can't we just store the device used to create the zone in the
structure as well, that would avoid that non-trivial logic.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
d of having 0 or 1, we're now having -1 as our id.
This is a regression, and I'm even wondering if we can't just store
the ID in the sunxi_engine structure. Is anything preventing us to do
that, instead of using a callback?
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
Acked-by: Rob Herring
Applied, thanks!
maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
;
> +
> + tcon0_in_mixer0: endpoint@0 {
> + reg = <0>;
> + remote-endpoint =
> <&mixer0_out_tcon0>;
> + };
> + };
> +
> + tcon0_out: port@1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <1>;
> + };
> + };
> + };
> +
> +
You have an extra new line here.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
n the next patch), so that we can finally gain support for the
> mixer in DE2, which has different layers.
>
> Signed-off-by: Icenowy Zheng
> Reviewed-by: Chen-Yu Tsai
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
t case properly.
Fixes: a1c55bccf600 ("drm/panel: lvds: Add support for the power-supply
property")
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/panel/panel-lvds.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-lvds.c
b/dr
would expect people
> doing SoC bringup to be able to cope with those kinds of problems.
Rght, because it worked so well in the past. We definitely didn't
overlooked some clocks used for debouncing in this particular driver,
or some to get the timekeeping right in the RTC.
The argument that "anyone who codes in the kernel should just know
better" doesn't work, on multiple levels. Because anyone that actually
knows better can make a mistake or overlook some feature (because you
didn't have your morning coffee yet, or because it was undocumented)
and because you just make someone that doesn't feel bad.
So, yes, we cannot not trust the device tree. But if we have a way to
detect simple mistakes in the binding, we should also do it.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
On Wed, Jan 10, 2018 at 08:25:08PM +0100, Jernej Skrabec wrote:
> This TCON is connected to HDMI encoder.
>
> Signed-off-by: Jernej Skrabec
Acked-by: Maxime Ripard
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
sign
abec
Acked-by: Maxime Ripard
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
lock of 83.5 MHz to display at its native resolution.
Queued all three patches as fixes, thanks!
maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
ou have a number of issues with checkpatch though still, please run
./scripts/checkpatch.pl --strict, and once all the issues have been
fixed:
Reviewed-by: Maxime Ripard
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.a
r patch 4 should come before this one.
Your commit title and log doesn't seem to match the content of the
patch either.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
gt;
> + pwm_pins: pwm-pins {
> + pins = "PB2", "PB3";
> + function = "pwm";
> + };
> +
Is it the only combination of pins that is usable?
If so, you can add the pinctrl-0 property
Hi,
On Thu, Jan 11, 2018 at 03:05:01PM +0200, Laurent Pinchart wrote:
> Hi Maxime,
>
> (CC'ing Mark Brown)
>
> Thank you for the patch.
>
> On Wednesday, 10 January 2018 17:59:41 EET Maxime Ripard wrote:
> > The devm_regulator_get_optional function, unlike
ix.org/oz6gmb-257359?raw
This is needed because while it's ok to have a NULL pointer to
v4l2_subdev_pad_config when you call the subdev set_fmt with
V4L2_SUBDEV_FORMAT_ACTIVE, it's not with V4L2_SUBDEV_FORMAT_TRY, and
sensors will assume taht it's a valid pointer.
Otherwise,
Tested-by: Max
ind of
> problems.
>
> Signed-off-by: Icenowy Zheng
One way to avoid this would have been to add the symbol to the sunxi
and multi_v7 defconfigs...
You're also adding a depends on. This should be explained or at least
mentionned in your commit log.
Thanks!
Maxime
--
Maxime Ripard, Fr
On Tue, Jan 09, 2018 at 03:28:34PM +0100, Daniel Vetter wrote:
> On Tue, Jan 09, 2018 at 02:53:22PM +0100, Maxime Ripard wrote:
> > On Tue, Jan 09, 2018 at 01:32:41PM +0100, Daniel Vetter wrote:
> > > On Tue, Jan 09, 2018 at 11:56:25AM +0100, Maxime Ripard wrote:
> > > &
On Fri, Jan 12, 2018 at 09:51:14AM +0800, Yong wrote:
> Hi Maxime,
>
> On Thu, 11 Jan 2018 14:28:44 +0100
> Maxime Ripard wrote:
>
> > Hi Yong,
> >
> > On Thu, Jan 11, 2018 at 11:06:06AM +0800, Yong Deng wrote:
> > > Allwinner V3s SoC features t
require less changes: "The best patch is no
> >patch":
>
> I can accept this. (In fact I have considered this, but
> I don't dare to directly use bus clock in a device, as it's not
> exported before.
>
> Maxime, Chen-Yu, can you agree the following code?
Yes, that works for me.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
Hi,
On Mon, Jan 29, 2018 at 03:34:02PM +0100, Arnd Bergmann wrote:
> On Mon, Jan 29, 2018 at 10:25 AM, Linus Walleij
> wrote:
> > On Mon, Jan 29, 2018 at 9:25 AM, Maxime Ripard
> > wrote:
> >> On Sat, Jan 27, 2018 at 05:14:26PM +0100, Linus Walleij wrote:
> &
1;5002;0c
On Mon, Jan 29, 2018 at 12:53:48PM +0100, Philipp Rossak wrote:
>
>
> On 29.01.2018 10:48, Maxime Ripard wrote:
> > On Mon, Jan 29, 2018 at 12:29:13AM +0100, Philipp Rossak wrote:
> > > This patch adds support for the A83T ths sensor.
> > >
> &
,
> > > if (IS_ERR(base))
> > > return PTR_ERR(base);
> > > + info->has_calibration_data[0] = false;
> > > + info->has_calibration_data[1] = false;
> > > +
> > > + if (!info->data->supports_nvmem)
> > >
is should be r_cir_pin, and
you should drop the unit-address that generates a dtc warning.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
dts/sun8i-a83t.dtsi
> @@ -605,6 +605,16 @@
> #reset-cells = <1>;
> };
>
> + cir: cir@01f02000 {
r_cir: ir@1f02000
> + compatible = "allwinner,sun5i-a13-ir";
You should have an A83t compatible there fi
r_pins>;
If this is the only muxing option (like your node name suggests), you
can put it directly in the DTSI to remove boilerplate from all the
DTS.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
Hi Thierry,
On Tue, Jan 30, 2018 at 11:01:50AM +0100, Thierry Reding wrote:
> On Tue, Jan 30, 2018 at 10:59:16AM +0100, Thierry Reding wrote:
> > On Tue, Jan 30, 2018 at 10:24:48AM +0100, Arnd Bergmann wrote:
> > > On Tue, Jan 30, 2018 at 8:54 AM, Maxime Ripard
> > >
#x27;re discussing in that other part of the thread with Thierry
and Arnd, things are slightly more complicated than that :)
In our case, the bus where the device is attached will not do the
address translations, and shouldn't.
> If you apply PHYS_OFFSET forcefully to it you might get une
driver. And the parents' parents are
irrelevant to this particular issue.
> Remove all pll parents from gpu_parents_sun7i except "pll-gpu".
However, this is not a proper fix for your issue.
What kernel version did you use?
Maxime
--
Maxime Ripard, Free Electrons
Embedded
On Mon, Jan 29, 2018 at 03:56:40PM +0200, Stefan Mavrodiev wrote:
> A20-SOM204 board has option with onboard 16GB eMMC.
> The chip is wired to MMC2 slot.
>
> Signed-off-by: Stefan Mavrodiev
Queued both in 4.17, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linu
On Wed, Jan 31, 2018 at 02:47:53PM +, Liviu Dudau wrote:
> On Wed, Jan 31, 2018 at 08:42:12AM +0100, Maxime Ripard wrote:
> > On Wed, Jan 31, 2018 at 03:08:08AM +, Liviu Dudau wrote:
> > > On Fri, Jan 26, 2018 at 11:00:41AM +0800, Yong wrote:
> > > > Hi Maxim
Sync are
> ignored.
> DE is used not only for Data Enable, but also for sync the very beginning of
> frame, the rest of syncing is done by pause between every line sent.
> This is should be why nobody noticed it before,
> I think almost every display is used in DE mode only.
> So, if
On Wed, Jan 31, 2018 at 01:05:38PM +0100, Giulio Benetti wrote:
> Hi,
>
> Il 31/01/2018 09:43, Maxime Ripard ha scritto:
> > Hi,
> >
> > On Wed, Jan 31, 2018 at 12:23:59AM +0100, Giulio Benetti wrote:
> > > When mali.ko is inserted, it set default clocks and
e header inclusion in sun7i-a20.dtsi
> using right one.
This sentence is redundant with the first one.
Dropped the first one, corrected the wrapping and applied, thanks
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature
On Wed, Jan 31, 2018 at 10:37:37AM +0100, Arnd Bergmann wrote:
> On Wed, Jan 31, 2018 at 8:29 AM, Maxime Ripard
> wrote:
> > Hi Thierry,
> >
> > On Tue, Jan 30, 2018 at 11:01:50AM +0100, Thierry Reding wrote:
> >> On Tue, Jan 30, 2018 at 10:59:16AM +0100, Thierry
On Thu, Feb 01, 2018 at 11:34:43AM +, Liviu Dudau wrote:
> On Thu, Feb 01, 2018 at 10:20:28AM +0100, Arnd Bergmann wrote:
> > On Thu, Feb 1, 2018 at 9:32 AM, Maxime Ripard
> > wrote:
> > > On Wed, Jan 31, 2018 at 02:47:53PM +, Liviu Dudau wrote:
> > >>
t to stable, so
> we can at least fix this for the A23 and A33.
>
> Also, checkpatch.pl doesn't like the stable kernel prerequisite lines.
Acked-by: Maxime Ripard
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
)
> val |= SUN4I_TCON0_IO_POL_VSYNC_POSITIVE;
>
> + if(display_info.bus_flags & DRM_BUS_FLAG_PIXDATA_POSEDGE)
> + val |= SUN4I_TCON0_IO_POL_DCLK_PHASE(1);
> +
Checkpatch here returns:
ERROR: space required before the open parenthesis '('
And, where
#x27;re not making use of any of it here?
Also, how was it tested? This seems quite weird that we haven't caught
that one sooner, and I'm a bit worried about the possible regressions
here.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
signature.asc
Description: PGP signature
to a rest.
We don't have to worry about anything else since the only time we will
trigger a new transaction is during the atomic_commit which comes much
later.
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/sun4i/sun4i_backend.c | 12
1 file c
ed-by: Chen-Yu Tsai
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/sun4i/sun4i_tcon.c | 4
drivers/gpu/drm/sun4i/sunxi_engine.h | 13 +
2 files changed, 17 insertions(+)
diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c
b/drivers/gpu/drm/sun4i/sun4i_tcon.c
index e122f5b
Fixed some compilation errors reported by the 0-day bot.
Maxime Ripard (13):
drm/sun4i: backend: Move line stride setup to buffer setup function
drm/sun4i: backend: Document the engine operations
drm/sun4i: backend: Allow a NULL plane pointer to retrieve the format
drm/sun4i: backend: Add a custom p
We have to implement some display engine specific behaviours in
atomic_begin. Let's add a function for that.
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/sun4i/sun4i_crtc.c | 6 +-
drivers/gpu/drm/sun4i/sunxi_engine.h | 13 +
2 files change
The display frontend can be used to do hardware scaling, colorspaces
conversion or to implement the buffer format output by the Cedar VPU.
Since we're starting to have some support for it in the DRM driver, let's
enable its DT node.
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Max
During a hardware commit, the commit bit in the backend will only be
cleared if the TCON is enabled. Use the runtime_pm variant of the
atomic_commit_tail hook that makes sure that the CRTC, our TCON, is enabled
when we perform an atomic_commit.
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Maxime
frontend.
Note that we're still not making any use of the frontend itself, as no one
is setting the flag yet.
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/sun4i/sun4i_backend.c | 91 -
drivers/gpu/drm/sun4i/sun4i_backend.h | 8 ++-
dr
aling features.
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/sun4i/Makefile | 3 +-
drivers/gpu/drm/sun4i/sun4i_drv.c | 27 +-
drivers/gpu/drm/sun4i/sun4i_drv.h | 1 +-
drivers/gpu/drm/sun4i/sun4i_frontend.c | 389 ++-
drivers/gpu/drm/sun4i/sun4i_front
lback to validate the
current configuration.
Reviewed-by: Chen-Yu Tsai
Reviewed-by: Neil Armstrong
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/sun4i/sun4i_crtc.c | 14 ++
drivers/gpu/drm/sun4i/sunxi_engine.h | 17 +
2 files changed, 31 insertions(+)
diff --
We will need to store some additional data in the future to the state.
Create a custom plane state that will embed those data, in order to store
the pipe or whether or not that plane should use the frontend.
Reviewed-by: Chen-Yu Tsai
Reviewed-by: Neil Armstrong
Signed-off-by: Maxime Ripard
: Chen-Yu Tsai
Reviewed-by: Neil Armstrong
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/sun4i/sun4i_backend.c | 65 -
drivers/gpu/drm/sun4i/sun4i_backend.h | 2 +-
2 files changed, 67 insertions(+)
diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c
b/drivers/gpu
Neil Armstrong
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/sun4i/sun4i_backend.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c
b/drivers/gpu/drm/sun4i/sun4i_backend.c
index 847eecbe4d14..c99d1a7e815a 100644
--- a/dr
Our operations were missing some documentation to explain what was expected
from them.
Let's make that clearer.
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/sun4i/sunxi_engine.h | 46 +-
1 file changed, 46 insertions(+)
diff --
t, we still need to setup the format to the one output
by the frontend.
Test for NULL plane pointers before referencing them, so that we can work
around it.
Reviewed-by: Neil Armstrong
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/sun4i/sun4i_backend.c | 2 +-
1 file changed, 1 insertion(
The function supposed to update a plane's coordinates is called in both
branches of our function. Let's move it out the if statement.
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/sun4i/sun4i_layer.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu
pipe.
And since we have runtime checks and pipe assignments now, we can just
remove the static declaration of the planes we used to have.
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/sun4i/sun4i_backend.c | 41 +--
drivers/gpu/drm/sun4i/sun4i_layer.c
pdate part.
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/sun4i/sun4i_backend.c | 15 +++
drivers/gpu/drm/sun4i/sun4i_backend.h | 2 ++
drivers/gpu/drm/sun4i/sun4i_framebuffer.c | 4
drivers/gpu/drm/sun4i/sun4i_layer.c | 3 +++
4 files changed, 24 inser
901 - 1000 of 7254 matches
Mail list logo
