Fixed Check:Avoid CamelCase by renaming SetFilter to set_filter
Reported by checkpatch.
Signed-off-by: Mitali Borkar
---
drivers/staging/rtl8712/xmit_osdep.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/xmit_osdep.h
b/drivers/staging/rtl8712
linux-staging@lists,linux-kernel@vger.kernel.org
Bcc:
Subject: [PATCH] staging: qlge:remove else after break
Reply-To:
Fixed Warning:- else is not needed after break
break terminates the loop if encountered. else is unnecessary and
increases indenatation
Signed-off-by: Mitali Borkar
outreachy-ker...@googlegroups.com, mitaliborkar...@gmail.com
Bcc:
Subject: [PATCH] staging: qlge:remove else after break
Reply-To:
Fixed Warning:- else is not needed after break
break terminates the loop if encountered. else is unnecessary and
increases indenatation
Signed-off-by: Mitali
Added #include and replaced bit shifts by BIT() macro.
This BIT() macro from linux/bitops.h is used to define ZR36057_VFESPFR_*
bitmasks.
Use of macro is better and neater. It maintains consistency.
Reported by checkpatch.
Signed-off-by: Mitali Borkar
---
drivers/staging/media/zoran/zr36057.h
On Thu, Apr 08, 2021 at 11:16:41PM +0200, Julia Lawall wrote:
>
>
> On Fri, 9 Apr 2021, Mitali Borkar wrote:
>
> > Added spaces around '<<' operator to improve readability and meet linux
> > kernel coding style.
> > Reported by checkpatch
Matched alignment with open parenthesis to meet linux kernel coding
style.
Reported by checkpatch
Signed-off-by: Mitali Borkar
---
drivers/staging/media/meson/vdec/codec_mpeg12.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/meson/vdec/codec_mpeg12.c
These patches make changes to clean up style issues
as identified by checkpatch
Mitali Borkar (2):
media: zoran: add spaces around '<<'
media: zoran: replace bit shifts by BIT() macro
drivers/staging/media/zoran/zr36057.h | 16 +---
1 file changed, 9 insertions(+), 7 del
Added spaces around '<<' operator to improve readability and meet linux
kernel coding style.
Reported by checkpatch
Signed-off-by: Mitali Borkar
---
drivers/staging/media/zoran/zr36057.h | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging
Reduced length of a line which exceed the 100 columns limit by splitting
the line into two statements and commenting it with '*'
Reported by checkpatch.
Signed-off-by: Mitali Borkar
---
drivers/staging/media/zoran/zr36060.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
On Fri, Apr 09, 2021 at 12:10:06AM +0200, Julia Lawall wrote:
>
>
> On Fri, 9 Apr 2021, Mitali Borkar wrote:
>
> > On Thu, Apr 08, 2021 at 11:15:07PM +0200, Julia Lawall wrote:
> > >
> > >
> > > On Fri, 9 Apr 2021, Mitali Borkar wrote:
> >
On Thu, Apr 08, 2021 at 11:15:07PM +0200, Julia Lawall wrote:
>
>
> On Fri, 9 Apr 2021, Mitali Borkar wrote:
>
> > Added #include and replaced bit shifts by BIT() macro.
> > This BIT() macro from linux/bitops.h is used to define ZR36057_VFESPFR_*
> > bitmas
Added '*' in susbsequent lines for block comments to meet linux kernel
coding style.
Signed-off-by: Mitali Borkar
---
drivers/staging/media/zoran/zr36050.c | 34 +--
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/media/zoran/zr36050.c
b
Moved the statement to next line and added '*' before it to meet
linux kernel coding style for long(multi-line) comments.
Signed-off-by: Mitali Borkar
---
Changes from v1:- made style changes according to linux kernel coding style
for long comments.
drivers/staging/media/zoran/zr36060.c | 3
Removed and moved statement in line in long(multi-line) comments and
added '*' before it to meet linux kernel coding style for long (multi-line)
comments
Signed-off-by: Mitali Borkar
---
Changes from v2:- made style changes in code according to linux kernel
coding style for long comments
Added '*' before every line inside long(multi-line) comments. Removed
'*/' from end of the comment line and added to next line as per linux
kernel coding style. Aligned '*' accordingly to make code neater.
Signed-off-by: Mitali Borkar
---
Changes from v1:- Changes made in code according
Aligned arguments with open parenthesis to meet linux kernel coding
style
Reported by checkpatch
Signed-off-by: Mitali Borkar
---
drivers/staging/rtl8712/usb_ops.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8712/usb_ops.h
b/drivers/staging
Removed an extra blank line so that only one blank line is present in
between two functions which separates them out.
Reported by checkpatch
Signed-off-by: Mitali Borkar
---
drivers/staging/rtl8712/rtl8712_wmac_regdef.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8712
Cleanup patch for CHECK: blank lines aren't necessary after an open
brace '{'
Reported by checkpatch
Signed-off-by: Mitali Borkar
---
drivers/staging/rtl8712/usb_intf.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8712/usb_intf.c
b/drivers
Clean up Check:spaces preferred around that '+' (ctx:VxV)
Reported by checkpatch
Signed-off-by: Mitali Borkar
---
drivers/staging/rtl8712/wlan_bssdef.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712
Declared 32 bit unsigned int as static constant inside a function
appropriately.
Reported-by: kernel test robot
Signed-off-by: Mitali Borkar
---
Changes from v1:- Rectified the mistake by declaring u32 as static const
properly.
drivers/staging/media/meson/vdec/codec_h264.c | 4 ++--
1 file
Changes from v1:-
Dropped patches 1/6 and 2/6 and compiled this as a patchset of 4
patches.
[PATCH 1/4]:- No changes.
[PATCH 2/4]:- No changes.
[PATCH 3/4]:- Reduced length of a line under 80 characters. This was
patch 5/6 previously.
[PATCH 4/4]:- No changes.
Mitali Borkar (4):
staging: media
Reduced length of line as it was exceeding 100 characters by removing
comments from same line and adding it to previous line. This makes code
neater, and meets linux kernel coding style.
Reported by checkpatch.
Signed-off-by: Mitali Borkar
---
Changes from v1:- No changes.
drivers/staging
Removed an unnecessary blank line to meet linux kernel coding style.
Reported by checkpatch.pl
Signed-off-by: Mitali Borkar
---
Changes from v1:- No changes.
drivers/staging/media/ipu3/include/intel-ipu3.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/ipu3/include
Removed unnecessary space before tabs to adhere to linux kernel coding
style.
Reported by checkpatch.
Signed-off-by: Mitali Borkar
---
Changes from v1:- No changes.
drivers/staging/media/ipu3/include/intel-ipu3.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
Reduced length of the line under 80 characters to meet linux-kernel
coding style.
Signed-off-by: Mitali Borkar
---
Changes from v1:- Reduced length of the line under 80 characters
drivers/staging/media/ipu3/include/intel-ipu3.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
On Mon, Apr 12, 2021 at 08:19:02AM +0200, Greg KH wrote:
> On Mon, Apr 12, 2021 at 11:40:53AM +0530, Mitali Borkar wrote:
> > Fixed the warning:-msleep < 20ms can sleep for up to 20ms by replacing
> > msleep(unsigned long msecs) by usleep_range(unsigned long min, unsi
Fixed the warning:-msleep < 20ms can sleep for up to 20ms by replacing
msleep(unsigned long msecs) by usleep_range(unsigned long min, unsigned long
max)
in usecs as msleep(1ms~20ms) can sleep for upto 20 ms.
Signed-off-by: Mitali Borkar
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
On Wed, Apr 14, 2021 at 10:16:59AM +0200, Greg KH wrote:
> On Wed, Apr 14, 2021 at 12:26:01PM +0530, Mitali Borkar wrote:
> > Added a generic function of static inline bool in
> > include/linux/etherdevice.h to replace memcmp with
> > ether_oui_equal throughout the exe
On Wed, Apr 14, 2021 at 10:55:25AM +0300, Dan Carpenter wrote:
> On Wed, Apr 14, 2021 at 12:26:01PM +0530, Mitali Borkar wrote:
> > Added a generic function of static inline bool in
> > include/linux/etherdevice.h to replace memcmp with
> > ether_oui_equal throughout the exe
On Wed, Apr 14, 2021 at 12:38:41PM +0200, z...@gentoo.org wrote:
> Am 13.04.21 um 21:50 schrieb Mitali Borkar:
> > Added #include and replaced bit shifts by BIT() macro.
> > This BIT() macro from linux/bitops.h is used to define ZR36057_VFESPFR_*
> > bitmasks.
>
Removed unnecessary parentheses around '!xyz' boolean expression as '!'
has higher precedance than '||'
Signed-off-by: Mitali Borkar
---
Changes from v3:- No changes.
Changes from v2:- Modified subject description. Changes has been made in
v3.
Changes from v1:- Removed unnecessary parentheses
Removed unncessary ftrace-like logging by simply deleting that statement
as we have other modes of logging like ftrace.
Reported by checkpatch.
Signed-off-by: Mitali Borkar
---
Changes from v3:- No changes.
Changes from v2:- No changes.
Changes from v1:- No changes.
drivers/staging/rtl8192e
Changes from v1:- Threaded mails properly and changed the subject line
to match prefix on patches.
[PATCH 1/2]:- No changes.
[PATCH 2/2]:- No changes.
Mitali Borkar (2):
staging: vc04_services: remove trailing whitespace
staging: vc04_services: rectify spelling mistake
drivers/staging
Removed unnecessary parentheses because they must be used only when it
is necessary or they improve readability.
Reported by checkpatch.
Signed-off-by: Mitali Borkar
---
Changes from v3:- No changes.
Changes from v2:- Rectified spelling mistake in subject description.
Changes has been made
Corrected the misspelled word.
Reported by checkpatch.
Signed-off-by: Mitali Borkar
---
Changes from v1:- No changes.
drivers/staging/vc04_services/interface/TODO | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/interface/TODO
b/drivers
Removed trailing whitespace to adhere to linux kernel coding style.
Reported by checkpatch.
Signed-off-by: Mitali Borkar
---
Changes from v1:- No changes.
drivers/staging/vc04_services/interface/TODO | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging
]:- Rectified spelling mistake in subject description.
Changes has been made in v3.
Changes from v1:-
[PATCH 1/3]:- Removed unnecessary parentheses around boolean expression.
Changes has been made in v2.
[PATCH 2/3]:- No changes.
[PATCH 3/3]:- No changes.
Mitali Borkar (6):
staging: rtl8192e
Fixed Check: Remove unnecessary f-trace like logging by simply deleting
that statement as we have other modes of logging like ftrace.
Reported by checkpatch.
Signed-off-by: Mitali Borkar
---
drivers/staging/rtl8192e/rtl819x_TSProc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers
On Fri, Apr 09, 2021 at 07:07:09PM -0700, Joe Perches wrote:
> On Sat, 2021-04-10 at 07:05 +0530, Mitali Borkar wrote:
> > Matched the alignment with open parenthesis to meet linux kernel coding
> > style.
> > Reported by checkpatch.
> []
> > diff --git a/drivers/sta
On Fri, Apr 09, 2021 at 10:12:12PM +0200, Julia Lawall wrote:
>
>
> On Sat, 10 Apr 2021, Mitali Borkar wrote:
>
> > Removed comments from the same line and added them to new line above the
> > blocks, aligned everything properly by using tabs to make code neater
>
On Fri, Apr 09, 2021 at 10:40:25PM +0200, Julia Lawall wrote:
>
>
> On Sat, 10 Apr 2021, Mitali Borkar wrote:
>
> > No changes required in this patch.
> > In v1:- Added spaces around '<<' operator to improve readability and meet
> > linux kernel coding
&g
Removed multiple blank lines to make code better and neater.
Reported by checkpatch.
Signed-off-by: Mitali Borkar
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c
b/drivers/staging/rtl8192e
Matched the alignment with open parenthesis to meet linux kernel coding
style.
Reported by checkpatch.
Signed-off-by: Mitali Borkar
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 20 ++--
drivers/staging/rtl8192e/rtl819x_TSProc.c | 18 +-
2 files changed, 19
Removed an exra blank line after close brace '{' as it was not
necessary.
Reported by checkpatch
Signed-off-by: Mitali Borkar
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c
b/drivers/staging/rtl8192e
Aligned the statements properly in one line to make code neater and to
improve readability.
Signed-off-by: Mitali Borkar
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c
b/drivers
These patches fix the cleanup style issues identified by checkpatch
Mitali Borkar (3):
staging: rtl8192e: replace comparison to NULL by boolean expression
staging: rtl8192e: remove unnecessary ftrace-like logging
staging: rtl8192e: remove unncessary parentheses
drivers/staging/rtl8192e
Removed unncessary ftrace-like logging by simply deleting that statement
as we have other modes of logging like ftrace.
Reported by checkpatch.
Signed-off-by: Mitali Borkar
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging
Replaced comparison to NULL by boolean expressions
(here used boolean negations). This improves readability of code.
Reported by checkpatch.
Signed-off-by: Mitali Borkar
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
Removed unnecessary parentheses because they must be used only when it
is necessary or they improve readability.
Reported by checkpatch.
Signed-off-by: Mitali Borkar
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
Fixed Comparison to NULL can be written as '!...' by replacing it with
simpler form i.e. boolean expression. This makes code more readable
alternative.
Reported by checkpatch.
Signed-off-by: Mitali Borkar
---
Changes from v1:- added pointer to the function, which was missed during
fixing v1
On Mon, Apr 12, 2021 at 11:17:22AM +0200, Hans Verkuil wrote:
> On 10/04/2021 21:59, Mitali Borkar wrote:
> > Declared 32 bit unsigned int as static constant inside a function and
> > replaced u32[] {x,y} as canvas1, canvas2 in codec_mpeg12.c
> > This indicates the va
On Sat, Apr 10, 2021 at 03:14:24PM +0200, Greg KH wrote:
> On Sat, Apr 10, 2021 at 06:30:38PM +0530, Mitali Borkar wrote:
> > Fixed Comparison to NULL can be written as '!...' by replacing it with
> > simpler form i.e. boolean expression. This makes code more readable
> > alte
Fixed Comparison to NULL can be written as '!...' by replacing it with
simpler form i.e boolean expression. This makes code more readable alternative.
Reported by checkpatch.
Signed-off-by: Mitali Borkar
---
drivers/staging/rtl8192e/rtl819x_TSProc.c | 6 +++---
1 file changed, 3 insertions
Added spaces around binary operators like '+', '*', '|', '-', '&',
to improve readability and to meet linux kernel coding style.
Signed-off-by: Mitali Borkar
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 8
drivers/staging/rtl8192e/rtl819x_TSProc.c | 8
2 files change
This patches fix the cleanup style issues.
Mitali Borkar (6):
staging: rtl8192e: add spaces around binary operators
staging: rtl8192e: remove unnecessary blank line before brace
staging: rtl8192e: remove unncessary blank line after brace
staging: rtl8192e: matched alignment with open
Removed an extra blank line before close brace as it was not necessary.
Reported by checkpatch.
Signed-off-by: Mitali Borkar
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 --
drivers/staging/rtl8192e/rtl819x_TSProc.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/drivers/staging
On Sat, Apr 10, 2021 at 02:10:38PM +0200, Greg KH wrote:
> On Sat, Apr 10, 2021 at 02:08:30PM +0200, Julia Lawall wrote:
> >
> >
> > On Sat, 10 Apr 2021, Mitali Borkar wrote:
> >
> > > Fixed Comparison to NULL can be written as '!...' by replacing it
Fixed pointer error by adding '*' to the function.
Reported by Julia.
Signed-off-by: Mitali Borkar
---
Changes from v2:- modified patch body but writing commit message
clearly.
Changes from v1:- added pointer to the function.
drivers/staging/rtl8192e/rtl819x_TSProc.c | 2 +-
1 file changed, 1
On Sat, Apr 10, 2021 at 01:56:24PM +0200, Julia Lawall wrote:
>
>
> On Sat, 10 Apr 2021, Mitali Borkar wrote:
>
> > On Fri, Apr 09, 2021 at 10:12:12PM +0200, Julia Lawall wrote:
> > >
> > >
> > > On Sat, 10 Apr 2021, Mitali Borkar wrote:
>
Declared 32 bit unsigned int as static constant inside a function and
replaced u32[] {x,y} as canvas3, canvas4 in codec_h264.c
This indicates the value of canvas indexes will remain constant throughout
execution.
Signed-off-by: Mitali Borkar
---
drivers/staging/media/meson/vdec/codec_h264.c
On Mon, Apr 12, 2021 at 12:43:15PM +0300, Sakari Ailus wrote:
> Hi Mitali,
>
> On Mon, Apr 12, 2021 at 04:38:59AM +0530, Mitali Borkar wrote:
> > This patch fixes the warning identified by checkpatch.pl by replacing
> > __attribute__aligned(size) with __aligned(siz
Fixed pointer error by adding '*' to the function.
Signed-off-by: Mitali Borkar
Reported-by: Julia Lawall
---
Changes from v3:- added reported by tag in proper manner.
Changes from v2:- changed the patch nody to describe changes.
Changes from v1:- added pointer to the function.
drivers
reg_name as it will contain data/registry bases to write static
const indexes declared above and will keep track of of contiguos
registers after each reg_base.
This makes code look better, neater. It improves readability.
Signed-off-by: Mitali Borkar
---
drivers/staging/media/meson/vdec/codec_mpeg12.c
This patch fix the alignment of code in proper manner
Changes from v2:- Aligned the code using tabs.
Changes from v1:- Aligned the code using tabs and readjusted the
comments line.
Mitali Borkar (2):
media: zoran: add spaces around '<<'
staging: media: zoran: align code appropr
Signed-off-by: Mitali Borkar
---
Changes from v2:- No changes.
Changes from v1:- NO changes.
drivers/staging/media/zoran/zr36057.h | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/media/zoran/zr36057.h
b/drivers/staging/media/zoran/zr36057.h
Aligned the code properly by using tabs to make code neater and improve
readability.
Signed-off-by: Mitali Borkar
---
drivers/staging/media/zoran/zr36057.h | 108 +-
1 file changed, 54 insertions(+), 54 deletions(-)
diff --git a/drivers/staging/media/zoran/zr36057.h
b
On Tue, Apr 13, 2021 at 01:44:32PM +0300, Sakari Ailus wrote:
> On Tue, Apr 13, 2021 at 04:13:04PM +0530, Mitali Borkar wrote:
> > On Tue, Apr 13, 2021 at 01:01:34PM +0300, Sakari Ailus wrote:
> > > Hi Mitali,
> > >
> > > Thanks for the update.
> > &
On Fri, Apr 09, 2021 at 07:31:53PM -0700, Joe Perches wrote:
> On Sat, 2021-04-10 at 07:55 +0530, Mitali Borkar wrote:
> > On Fri, Apr 09, 2021 at 07:07:09PM -0700, Joe Perches wrote:
> > > On Sat, 2021-04-10 at 07:05 +0530, Mitali Borkar wrote:
> > > > Matched the a
On Tue, Apr 13, 2021 at 09:26:01AM +0200, Hans Verkuil wrote:
> On 13/04/2021 08:27, Mitali Borkar wrote:
> > Declared 32 bit unsigned int as static constant inside a function
> > appropriately.
> >
> > Reported-by: kernel test robot
> > Signed-off-by: Mitali
Removed unnecessary space before tabs to adhere to linux kernel coding
style.
Reported by checkpatch.
Signed-off-by: Mitali Borkar
---
Changes from v2:- No changes.
Changes from v1:- No changes.
drivers/staging/media/ipu3/include/intel-ipu3.h | 2 +-
1 file changed, 1 insertion(+), 1
Fixed the issue of line should not end with '[' by moving argument
from next line to line ending with '[' and made it under 80
characters.
Reported by checkpatch.
Signed-off-by: Mitali Borkar
---
Changes from v2:- No changes
Changes from v1:- Made line length under 80 characters
drivers
. This was
patch 5/6 previously.
[PATCH 4/4]:- No changes.
Mitali Borkar (4):
staging: media: intel-ipu3: remove unnecessary blank line
staging: media: intel-ipu3: reduce length of line
staging: media: intel-ipu3: line should not end with '['
staging: media: intel-ipu3: remove space before tabs
Reduced length of line as it was exceeding 100 characters by removing
comments from same line and adding it to previous line. This makes code
neater, and meets linux kernel coding style.
Reported by checkpatch.
Signed-off-by: Mitali Borkar
---
Changes from v2:- No changes.
Changes from v1
Removed an unnecessary blank line to meet linux kernel coding style.
Reported by checkpatch.pl
Signed-off-by: Mitali Borkar
---
Changes from v2:- No changes.
Changes from v1:- NO changes.
drivers/staging/media/ipu3/include/intel-ipu3.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers
Declared 32 bit unsigned int as static constant inside a function and
replaced u32[] {x,y} as canvas3, canvas4 in codec_h264.c
This indicates the value of canvas indexes will remain constant throughout
execution.
Reported-by: kernel test robot
Signed-off-by: Mitali Borkar
---
Changes from v2
Reduced length of a line which exceed the 100 columns limit by splitting
the line into two statements and commenting it with '*' to meet linux
kernel coding style for long(multi-line) comments.
Reported by checkpatch.
Signed-off-by: Mitali Borkar
---
Changes from v2:- Rebased this patch
Declared 32 bit unsigned int as static constant inside a function and
replaced u32[] {x,y} as canvas3, canvas4 in codec_h264.c
This indicates the value of canvas indexes will remain constant
throughout execution.
Signed-off-by: Mitali Borkar
---
Changes from v3:- Made commit message under 75
Added '*' before every line inside long(multi-line) comments. Removed
'*/' from end of the comment line and added to next line as per linux
kernel coding style. Aligned '*' accordingly to make code neater.
Signed-off-by: Mitali Borkar
---
Changes from v3:- Rebased this patch and made changes
Changes from v3:- Rebased these patches and made changes against
mainline code.
Changes from v2:-
[PATCH 1/2]:- No changes.
[PATCH 2/2]:- Aligned the code using tabs.
Changes from v1:-
[PATCH 1/2]:- No changes.
[PATCH 2/2]:- Aligned the code using tabs and readjusted the
comments line.
Mitali
Added spaces around '<<' operator to improve readability and meet linux
kernel coding style.
Reported by checkpatch
Signed-off-by: Mitali Borkar
---
Changes from v3:- No changes.
Changes from v2:- No changes.
Changes from v1:- No changes.
drivers/staging/media/zoran/zr36057.
everything properly by using tabs to make code neater
and improve readability.
Reported by checkpatch.
Signed-off-by: Mitali Borkar
---
Changes from v3:- No changes.
Changes from v2:- Aligned the code using tabs.
Changes from v1:- Aligned the code using tabs and readjusted the
comments line.
drivers
On Tue, Apr 13, 2021 at 09:17:12PM +0300, Dan Carpenter wrote:
> On Tue, Apr 13, 2021 at 08:59:34PM +0530, Mitali Borkar wrote:
> > Removed unnecessary space before tabs to adhere to linux kernel coding
> > style.
> > Reported by checkpatch.
> >
>
On Tue, Apr 13, 2021 at 09:52:48AM +0200, Greg KH wrote:
> On Tue, Apr 13, 2021 at 08:55:03AM +0530, Mitali Borkar wrote:
> > Changes from v4:-
> > [PATCH v4 1/3]:- No changes.
> > [PATCH v4 2/3]:- No changes.
> > [PATCH V4 3/3]:- Removed casts and parentheses.
>
On Tue, Apr 13, 2021 at 01:01:34PM +0300, Sakari Ailus wrote:
> Hi Mitali,
>
> Thanks for the update.
>
> On Tue, Apr 13, 2021 at 10:46:06AM +0530, Mitali Borkar wrote:
> > Reduced length of the line under 80 characters to meet linux-kernel
> > coding style.
> >
Removed unnecessary parentheses because they must be used only when it
is necessary or they improve readability.
Reported by checkpatch.
Signed-off-by: Mitali Borkar
---
Changes from v3:- No changes.
Changes from v2:- Rectified spelling mistake in subject description.
Changes from v1
Removed unnecessary parentheses around '!xyz' boolean expression as '!'
has higher precedance than '||'
Signed-off-by: Mitali Borkar
---
Changes from v3:- Modified log message.
Changes from v2:- Modified subject description.
Changes from v1:- Removed unnecessary parentheses around boolean
Removed unncessary ftrace-like logging by simply deleting that statement
as we have other modes of logging like ftrace.
Reported by checkpatch.
Signed-off-by: Mitali Borkar
---
Changes from v3:- No changes.
Changes from v2:- No changes.
Changes from v1:- NO changes.
drivers/staging/rtl8192e
description.
Changes from v1:-
[PATCH 1/3]:- Removed unnecessary parentheses around boolean expression.
Changes has been made in v2.
[PATCH 2/3]:- No changes.
[PATCH 3/3]:- No changes.
Mitali Borkar (3):
staging: rtl8192e: remove parentheses around boolean expression
staging: rtl8192e: remove
On Fri, Apr 09, 2021 at 09:26:48AM +0200, Hans Verkuil wrote:
> Hi Mitali,
>
> Something to improve:
>
> On 08/04/2021 23:21, Mitali Borkar wrote:
> > Reduced length of a line which exceed the 100 columns limit by splitting
> > the line into two statements and commenti
On Fri, Apr 09, 2021 at 12:53:35PM +0200, Hans Verkuil wrote:
> On 09/04/2021 12:49, Mitali Borkar wrote:
> > Added '*' before every line inside long(multi-line) comments. Removed
> > '*/' from end of the comment line and added to next line as per linux
> > kernel
Removed unnecessary parentheses around '!xyz' as '!' has higher
precedance than '||'
Signed-off-by: Mitali Borkar
---
Changes from v1:- removed unnecessary parentheses around boolean
expression
drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
Removed unncessary ftrace-like logging by simply deleting that statement
as we have other modes of logging like ftrace.
Reported by checkpatch.
Signed-off-by: Mitali Borkar
---
Changes from v1:- No changes made.
drivers/staging/rtl8192e/rtl819x_HTProc.c | 4
1 file changed, 4 deletions
Added spaces around '+' to improve readability and adhere to linux
kernel coding style.
Reported by checkpatch
Signed-off-by: Mitali Borkar
---
Changes from v1: No changes in the code, but only to subject description
and patch body.
Changed the subject decription according to PatchPhilosophy
On Thu, Apr 08, 2021 at 10:30:09AM +0200, Julia Lawall wrote:
> The subject line should be in the imperative, so "add" instead of "added".
>
Ok Ma'am
> On Thu, 8 Apr 2021, Mitali Borkar wrote:
>
> > Clean up Check:spaces preferred around that '+' (ctx:VxV)
On Fri, Apr 09, 2021 at 09:23:22AM +0200, Hans Verkuil wrote:
> Hi Mitali,
>
> On 08/04/2021 22:38, Mitali Borkar wrote:
> > Added spaces around '<<' operator to improve readability and meet linux
> > kernel coding style.
> > Reported by checkpatch
>
On Fri, Apr 09, 2021 at 09:23:22AM +0200, Hans Verkuil wrote:
> Hi Mitali,
>
> On 08/04/2021 22:38, Mitali Borkar wrote:
> > Added spaces around '<<' operator to improve readability and meet linux
> > kernel coding style.
> > Reported by checkpatch
>
This patch fixes style issues
Changes from v1:-
[Patch 1/3]:- Removed unnecessary parentheses around boolean expressions
[Patch 2/3]:- No changes
[Patch 3/3]:- No changes
Mitali Borkar (3):
staging: rtl8192e: remove unnecessary parentheses
staging: rtl8192e: remove unnecessary ftrace-like
Removed unnecessary parentheses because they must be used only when it
is necessary or they improve readability.
Reported by checkpatch.
Signed-off-by: Mitali Borkar
---
Changes from v1:- No changes.
drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++--
1 file changed, 6 insertions
Removed unnecessary parentheses because they must be used only when it
is necessary or they improve readability.
Reported by checkpatch.
Signed-off-by: Mitali Borkar
---
Changes from v2:- Rectified spelling mistake in subject description.
Changes from v1:- No changes.
drivers/staging
been made in v2.
[PATCH 2/3]:- No changes.
[PATCH 3/3]:- No changes.
Mitali Borkar (3):
staging: rtl8192e: remove parentheses around boolean expression
staging: rtl8192e: remove unnecessary ftrace-like logging
staging: rtl8192e: remove unnecessary parentheses
drivers/staging/rtl8192e
1 - 100 of 130 matches
Mail list logo
