hange.
Signed-off-by: Nadav Amit
---
drivers/misc/vmw_balloon.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c
index 4e067d269706..626abe65eddb 100644
--- a/drivers/misc/vmw_balloon.c
+++ b/drivers/misc/vmw_ball
selectively).
Reviewed-by: Xavier Deguillard
Signed-off-by: Nadav Amit
---
drivers/misc/vmw_balloon.c | 223 +++--
1 file changed, 116 insertions(+), 107 deletions(-)
diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c
index 2543ef1ece17..0a4d5501f805
-by: Xavier Deguillard
Signed-off-by: Nadav Amit
---
drivers/misc/vmw_balloon.c | 124 -
1 file changed, 122 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c
index 4c9c171325c3..8d60c7e65242 100644
--- a/drivers
refused list.
Reviewed-by: Xavier Deguillard
Signed-off-by: Nadav Amit
---
drivers/misc/vmw_balloon.c | 52 +-
1 file changed, 29 insertions(+), 23 deletions(-)
diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c
index 96dde120bbd5
The required change in the balloon size is currently computed in
vmballoon_work(), vmballoon_inflate() and vmballoon_deflate(). Refactor
it to simplify the next patches.
Reviewed-by: Xavier Deguillard
Signed-off-by: Nadav Amit
---
drivers/misc/vmw_balloon.c | 75
consistent in the return type and avoid
potential coding errors.
Reviewed-by: Xavier Deguillard
Signed-off-by: Nadav Amit
---
drivers/misc/vmw_balloon.c | 358 +
1 file changed, 165 insertions(+), 193 deletions(-)
diff --git a/drivers/misc/vmw_balloon.c b/drivers
The lock and unlock code paths are very similar, so avoid the duplicate
code by merging them together.
Reviewed-by: Xavier Deguillard
Signed-off-by: Nadav Amit
---
drivers/misc/vmw_balloon.c | 62 +-
1 file changed, 21 insertions(+), 41 deletions(-)
diff
Now that we have a single point, unify the tracing and collecting the
statistics for commands and their failure. While it might somewhat
reduce the control over debugging, it cleans the code a lot.
Reviewed-by: Xavier Deguillard
Signed-off-by: Nadav Amit
---
drivers/misc/vmw_balloon.c | 116
The use of accessors for batch entries complicates the code and makes it
less readable. Remove it an instead use bit-fields.
Reviewed-by: Xavier Deguillard
Signed-off-by: Nadav Amit
---
drivers/misc/vmw_balloon.c | 81 ++
1 file changed, 30 insertions(+), 51
> On Nov 26, 2018, at 2:32 AM, Peter Zijlstra wrote:
>
> On Tue, Nov 20, 2018 at 12:35:35PM -0800, Nadav Amit wrote:
>
>> Nadav Amit (9):
>> Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"
>> x86/jump_label: Use text_poke_early
at 8:20 PM, Masahiro Yamada wrote:
> On Sat, Nov 17, 2018 at 6:02 AM Nadav Amit wrote:
>> From: Masahiro Yamada
>> Sent: November 16, 2018 at 7:45:45 AM GMT
>>> To: Nadav Amit
>>> Cc: Ingo Molnar , Michal Marek ,
>>> Thomas Gleixner , Borislav Pet
> On Nov 20, 2018, at 10:23 AM, H. Peter Anvin wrote:
>
> On 11/20/18 10:18 AM, Peter Zijlstra wrote:
>>> Can't we make this test in text_poke() directly, please?
>>
>> He does that in 9/10 iirc.
>
> No, in 9/10 he does that change locally for the jump_label, but there is
> absolutely no reason
> On Nov 20, 2018, at 4:42 AM, Peter Zijlstra wrote:
>
> On Tue, Nov 13, 2018 at 05:07:20AM -0800, Nadav Amit wrote:
>> v4->v5:
>> - Fix Xen breakage [Damian Tometzki]
>> - BUG_ON() when poking_mm initialization fails [PeterZ]
>> - Better comments on "
Signed-off-by: Nadav Amit
---
arch/x86/kernel/jump_label.c | 24
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/arch/x86/kernel/jump_label.c b/arch/x86/kernel/jump_label.c
index ed5fe274a7d8..994c13e2867d 100644
--- a/arch/x86/kernel/jump_label.c
+++ b/arch/x86
conservative enough when mapping pages,
as it always tries to map 2 pages, even when a single one is sufficient.
So try to be more conservative, and do not map more than needed.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Peter Zijlstra
Cc: Dave Hansen
Cc: Masami Hiramatsu
Signed-off-by: Nadav Amit
Zijlstra
Cc: Dave Hansen
Cc: Masami Hiramatsu
Suggested-by: Thomas Gleixner
Suggested-by: Andy Lutomirski
Signed-off-by: Nadav Amit
---
arch/x86/kernel/alternative.c | 28 +---
arch/x86/kernel/module.c | 2 +-
include/linux/filter.h| 6 ++
kernel
Hiramatsu
Tested-by: Masami Hiramatsu
Suggested-by: Andy Lutomirski
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/pgtable.h | 3 +++
arch/x86/include/asm/text-patching.h | 2 ++
arch/x86/kernel/alternative.c| 3 +++
arch/x86/mm/init_64.c| 35
Provide a function for copying init_mm. This function will be later used
for setting a temporary mm.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Peter Zijlstra
Cc: Dave Hansen
Reviewed-by: Masami Hiramatsu
Tested-by: Masami Hiramatsu
Signed-off-by: Nadav Amit
---
include/linux/sched/task.h | 1
that would set a temporary mm for
patching, which is initialized after some static-keys are
enabled/disabled.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Dave Hansen
Cc: Masami Hiramatsu
Co-Developed-by: Peter Zijlstra
Signed-off-by: Nadav Amit
---
arch/x86/kernel/jump_label.c | 7 ++-
1 file ch
text_poke() already ensures that the written value is the correct one
and fails if that is not the case. There is no need for an additional
comparison. Remove it.
Signed-off-by: Nadav Amit
---
arch/x86/kernel/kgdb.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff
e text_mutex in
text_poke*()")
Suggested-by: Peter Zijlstra
Acked-by: Jiri Kosina
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/text-patching.h | 1 +
arch/x86/kernel/alternative.c| 52
arch/x86/kernel/kgdb.c | 11 +++---
3 files changed,
The return value of text_poke_early() and text_poke_bp() is useless.
Remove it.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Peter Zijlstra
Cc: Dave Hansen
Cc: Masami Hiramatsu
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/text-patching.h | 4 ++--
arch/x86/kernel/alternative.c| 11
fix [peterz]
- Removed remainders of text_poke return value [masami]
- Use __weak for poking_init instead of macros [masami]
- Simplify error handling in poking_init [masami]
andy Lutomirski (1):
x86/mm: temporary mm struct
Nadav Amit (9):
Fix "x86/alternatives: Lockdep-enforce text_mu
: Peter Zijlstra
Cc: Dave Hansen
Reviewed-by: Masami Hiramatsu
Tested-by: Masami Hiramatsu
Signed-off-by: Andy Lutomirski
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/mmu_context.h | 32 ++
1 file changed, 32 insertions(+)
diff --git a/arch/x86/include/asm
> On Nov 21, 2018, at 12:56 PM, Liam R. Howlett wrote:
>
>
> My out of tree driver build is now reporting issues with the jump table:
>
> ./include/linux/jump_label.h: In function ‘jump_entry_code’:
> ./include/linux/jump_label.h:153:14: error: dereferencing pointer to
> incomplete type ‘const
> On Nov 27, 2018, at 10:48 AM, Roman Kagan wrote:
>
> On Tue, Nov 27, 2018 at 02:10:49PM +0100, Vitaly Kuznetsov wrote:
>> Roman Kagan writes:
>>> On Mon, Nov 26, 2018 at 04:47:29PM +0100, Vitaly Kuznetsov wrote:
>>> I personally tend to prefer masks over bitfields, so I'd rather do the
>>> con
> On Nov 28, 2018, at 5:07 AM, Thomas Gleixner wrote:
>
> On Wed, 28 Nov 2018, Vitaly Kuznetsov wrote:
>
>> Nadav Amit writes:
>>
>>> On a different note: how come all of the hyper-v structs are not marked
>>> with the “packed" attribute?
&
> On Nov 20, 2018, at 12:35 PM, Nadav Amit wrote:
>
> When modules and BPF filters are loaded, there is a time window in
> which some memory is both writable and executable. An attacker that has
> already found another vulnerability (e.g., a dangling pointer) might be
> ab
> On Nov 28, 2018, at 8:08 AM, Josh Poimboeuf wrote:
>
> On Wed, Oct 17, 2018 at 05:54:15PM -0700, Nadav Amit wrote:
>> This RFC introduces indirect call promotion in runtime, which for the
>> matter of simplification (and branding) will be called here "relpolines"
> On Nov 28, 2018, at 3:09 PM, Logan Gunthorpe wrote:
>
>
>
> On 2018-11-14 6:57 p.m., Nadav Amit wrote:
>> Eventually, if you get a fix into icecc, we will need to change the
>> Makefile, consider the version number and act accordingly.
>
> I got a fix pulled
> On Nov 28, 2018, at 4:49 PM, Logan Gunthorpe wrote:
>
>
>
> On 2018-11-28 5:38 p.m., Nadav Amit wrote:
>> So what’s your take? Would you think this patch is still needed? Should it
>> only be enabled automatically for distcc and not for distcc-pump?
>
>
> On Nov 28, 2018, at 5:40 PM, Andy Lutomirski wrote:
>
> On Wed, Nov 28, 2018 at 4:38 PM Josh Poimboeuf wrote:
>> On Wed, Nov 28, 2018 at 07:34:52PM +0000, Nadav Amit wrote:
>>>> On Nov 28, 2018, at 8:08 AM, Josh Poimboeuf wrote:
>>>>
>>>> O
From: Logan Gunthorpe
Sent: November 15, 2018 at 1:19:45 AM GMT
> To: Nadav Amit , Ingo Molnar
> Cc: Ingo Molnar , Masahiro Yamada
> , Michal Marek ,
> Thomas Gleixner , Borislav Petkov , H.
> Peter Anvin , X86 ML , Linux Kbuild mailing
> list , LKML
> Subject: Re: [PAT
From: Xavier Deguillard
Julien will be replacing me as the vmw_balloon maintainer.
Cc: Julien Freche
Signed-off-by: Xavier Deguillard
Signed-off-by: Nadav Amit
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index a78d45755881
file. Since this is less efficient, this
compilation mode is only used when distcc or icecc are used.
Note that the assembly stage should also be distributed, if distcc is
configured using "CFLAGS=-DENABLE_REMOTE_ASSEMBLE".
Reported-by: Logan Gunthorpe
Signed-off-by: Nadav Amit
---
Changes in macros.S should trigger the recompilation of all C files, as
the macros might need to affect their compilation.
Acked-by: Ingo Molnar
Signed-off-by: Nadav Amit
---
scripts/Makefile.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/Makefile.build b
patches through tip. Please advise
if you disagree.
v1->v2:
* Remove whitespaces [Ingo]
* Automatically enable split compilation when distcc or icecc are used
Nadav Amit (2):
Makefile: Fix distcc compilation with x86 macros
x86: set a dependency on macros.S
Makefile | 4 +++-
a
From: Masahiro Yamada
Sent: November 16, 2018 at 7:37:46 AM GMT
> To: Nadav Amit
> Cc: Ingo Molnar , Michal Marek ,
> Thomas Gleixner , Borislav Petkov , H.
> Peter Anvin , X86 ML , Linux Kbuild mailing
> list , Linux Kernel Mailing List
>
> Subject: Re: [PATCH v2 2/2]
From: Masahiro Yamada
Sent: November 16, 2018 at 7:45:45 AM GMT
> To: Nadav Amit
> Cc: Ingo Molnar , Michal Marek ,
> Thomas Gleixner , Borislav Petkov , H.
> Peter Anvin , X86 ML , Linux Kbuild mailing
> list , Linux Kernel Mailing List
>
> Subject: Re: [PATCH v2 1/2]
From: Peter Zijlstra
Sent: November 11, 2018 at 11:52:20 PM GMT
> To: Nadav Amit
> Cc: Ingo Molnar , LKML , X86
> ML , H. Peter Anvin , Thomas Gleixner
> , Borislav Petkov , Dave Hansen
> , Andy Lutomirski , Kees Cook
> , Dave Hansen , Masami
> Hiramatsu
> Subject:
Peter,
I have put you as a “Co-Developed-by”, since the patch ended up as being the
single line that you wrote in the correspondence of the previous version.
I would therefore need to ask for your signed-off-by.
Regards,
Nadav
From: Nadav Amit
Sent: November 10, 2018 at 11:17:24 PM GMT
>
There has been a complaint that the recent use of assembly macros in C
files broke distcc. The first patch fixes this issue.
The second patch adds a dependency for all C files on macros.S, to
trigger their recompilation when the relevant macros change.
Nadav Amit (2):
Makefile: Fix distcc
Changes in macros.S should trigger the recompilation of all C files, as
the macros might need to affect their compilation.
Signed-off-by: Nadav Amit
---
scripts/Makefile.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/Makefile.build b/scripts/Makefile.build
file. Since this is less efficient, this
compilation mode is only used when make is called with the "DISTCC=y"
parameter.
Note that the assembly stage should also be distributed, if distcc is
configured using "CFLAGS=-DENABLE_REMOTE_ASSEMBLE".
Reported-by: Logan Gunthorpe
From: Ingo Molnar
Sent: November 13, 2018 at 11:30:00 AM GMT
> To: Nadav Amit
> Cc: Ingo Molnar , Masahiro Yamada
> , Michal Marek ,
> Thomas Gleixner , Borislav Petkov , H.
> Peter Anvin , x...@kernel.org, linux-kbu...@vger.kernel.org,
> linux-kernel@vger.kernel.org
> Su
From: Andy Lutomirski
Sent: November 13, 2018 at 5:47:16 PM GMT
> To: Nadav Amit
> Cc: Igor Stoppa , Kees Cook ,
> Peter Zijlstra , Mimi Zohar ,
> Matthew Wilcox , Dave Chinner ,
> James Morris , Michal Hocko , Kernel
> Hardening , linux-integrity
> , LSM List
>
From: Nadav Amit
Sent: November 13, 2018 at 5:55:34 PM GMT
> To: Ingo Molnar
> Cc: Ingo Molnar , Masahiro Yamada
> , Michal Marek ,
> Thomas Gleixner , Borislav Petkov , H.
> Peter Anvin , X86 ML , Linux Kbuild mailing
> list , LKML ,
> Logan Gunthorpe
> Subject:
conservative enough when mapping pages,
as it always tries to map 2 pages, even when a single one is sufficient.
So try to be more conservative, and do not map more than needed.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Peter Zijlstra
Cc: Dave Hansen
Cc: Masami Hiramatsu
Signed-off-by: Nadav Amit
Provide a function for copying init_mm. This function will be later used
for setting a temporary mm.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Peter Zijlstra
Cc: Dave Hansen
Reviewed-by: Masami Hiramatsu
Tested-by: Masami Hiramatsu
Signed-off-by: Nadav Amit
---
include/linux/sched/task.h | 1
Signed-off-by: Nadav Amit
---
arch/x86/kernel/jump_label.c | 24
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/arch/x86/kernel/jump_label.c b/arch/x86/kernel/jump_label.c
index ed5fe274a7d8..994c13e2867d 100644
--- a/arch/x86/kernel/jump_label.c
+++ b/arch/x86
: Peter Zijlstra
Cc: Dave Hansen
Reviewed-by: Masami Hiramatsu
Tested-by: Masami Hiramatsu
Signed-off-by: Andy Lutomirski
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/mmu_context.h | 32 ++
1 file changed, 32 insertions(+)
diff --git a/arch/x86/include/asm
Zijlstra
Cc: Dave Hansen
Cc: Masami Hiramatsu
Suggested-by: Thomas Gleixner
Suggested-by: Andy Lutomirski
Signed-off-by: Nadav Amit
---
arch/x86/kernel/alternative.c | 28 +---
arch/x86/kernel/module.c | 2 +-
include/linux/filter.h| 6 ++
kernel
that would set a temporary mm for
patching, which is initialized after some static-keys are
enabled/disabled.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Dave Hansen
Cc: Masami Hiramatsu
Co-Developed-by: Peter Zijlstra
Signed-off-by: Nadav Amit
---
arch/x86/kernel/jump_label.c | 7 ++-
1 file ch
The return value of text_poke_early() and text_poke_bp() is useless.
Remove it.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Peter Zijlstra
Cc: Dave Hansen
Cc: Masami Hiramatsu
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/text-patching.h | 4 ++--
arch/x86/kernel/alternative.c| 11
text_poke() already ensures that the written value is the correct one
and fails if that is not the case. There is no need for an additional
comparison. Remove it.
Signed-off-by: Nadav Amit
---
arch/x86/kernel/kgdb.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/arch/x86/kernel
ify text_mutex use instead [masami]
- Comment fix [peterz]
- Removed remainders of text_poke return value [masami]
- Use __weak for poking_init instead of macros [masami]
- Simplify error handling in poking_init [masami]
Andy Lutomirski (1):
x86/mm: temporary mm struct
Nadav Amit (9):
Fix
Hiramatsu
Tested-by: Masami Hiramatsu
Suggested-by: Andy Lutomirski
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/pgtable.h | 3 +++
arch/x86/include/asm/text-patching.h | 2 ++
arch/x86/kernel/alternative.c| 3 +++
arch/x86/mm/init_64.c| 35
e text_mutex in
text_poke*()")
Suggested-by: Peter Zijlstra
Acked-by: Jiri Kosina
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/text-patching.h | 3 +-
arch/x86/kernel/alternative.c| 72 +---
arch/x86/kernel/kgdb.c | 15 --
3 files changed,
From: Logan Gunthorpe
Sent: November 14, 2018 at 7:29:38 AM GMT
> To: Nadav Amit , Ingo Molnar
> Cc: Ingo Molnar , Masahiro Yamada
> , Michal Marek ,
> Thomas Gleixner , Borislav Petkov , H.
> Peter Anvin , X86 ML , Linux Kbuild mailing
> list , LKML
> Subject: Re: [PAT
protection.
Cc: Kees Cook
Cc: Peter Zijlstra
Cc: Dave Hansen
Cc: Masami Hiramatsu
Suggested-by: Thomas Gleixner
Suggested-by: Andy Lutomirski
Signed-off-by: Nadav Amit
---
arch/x86/kernel/alternative.c | 28 +---
arch/x86/kernel/module.c | 2 +-
include/linux
Signed-off-by: Nadav Amit
---
arch/x86/kernel/jump_label.c | 24
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/arch/x86/kernel/jump_label.c b/arch/x86/kernel/jump_label.c
index ed5fe274a7d8..994c13e2867d 100644
--- a/arch/x86/kernel/jump_label.c
+++ b/arch/x86
The return value of text_poke_early() and text_poke_bp() is useless.
Remove it.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Peter Zijlstra
Cc: Dave Hansen
Cc: Masami Hiramatsu
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/text-patching.h | 4 ++--
arch/x86/kernel/alternative.c| 11
It seems dangerous to allow code modifications to take place
concurrently with module unloading. So take the text_mutex while the
memory of the module is freed.
Signed-off-by: Nadav Amit
---
kernel/module.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/kernel/module.c b/kernel
the PTEs can be
avoided (excluding the direct-mapping alias), which is true. However,
in x86 it requires some cleanup of the contiguous page allocator, which
is outside of the scope of this patch-set.
Cc: Rick P Edgecombe
Cc: Will Deacon
Cc: Andy Lutomirski
Signed-off-by: Nadav Amit
---
kerne
e text_mutex in
text_poke*()")
Suggested-by: Peter Zijlstra
Acked-by: Jiri Kosina
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/text-patching.h | 1 +
arch/x86/kernel/alternative.c| 52
arch/x86/kernel/kgdb.c | 11 +++---
3 files changed,
Provide a function for copying init_mm. This function will be later used
for setting a temporary mm.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Peter Zijlstra
Cc: Dave Hansen
Reviewed-by: Masami Hiramatsu
Tested-by: Masami Hiramatsu
Signed-off-by: Nadav Amit
---
include/linux/sched/task.h | 1
conservative enough when mapping pages,
as it always tries to map 2 pages, even when a single one is sufficient.
So try to be more conservative, and do not map more than needed.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Peter Zijlstra
Cc: Dave Hansen
Cc: Masami Hiramatsu
Signed-off-by: Nadav Amit
Hiramatsu
Tested-by: Masami Hiramatsu
Suggested-by: Andy Lutomirski
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/pgtable.h | 3 +++
arch/x86/include/asm/text-patching.h | 2 ++
arch/x86/kernel/alternative.c| 3 +++
arch/x86/mm/init_64.c| 35
executable
pages from modifications using nested page-tables. This would allow
us to ensure the executable has not changed between allocation and
its write-protection.
While at it, do some small cleanup of what appears to be unnecessary
masking.
Cc: Masami Hiramatsu
Signed-off-by: Nadav Amit
text_poke() already ensures that the written value is the correct one
and fails if that is not the case. There is no need for an additional
comparison. Remove it.
Signed-off-by: Nadav Amit
---
arch/x86/kernel/kgdb.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff
that would set a temporary mm for
patching, which is initialized after some static-keys are
enabled/disabled.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Dave Hansen
Cc: Masami Hiramatsu
Cc: Peter Zijlstra
Signed-off-by: Nadav Amit
---
arch/x86/kernel/jump_label.c | 7 ++-
1 file changed, 6 inser
This provides
the advantages of having slightly "safer" code patching and avoiding
races with module removal or other mechanisms that patch the kernel
code.
Cc: Steven Rostedt
Signed-off-by: Nadav Amit
---
arch/x86/kernel/ftrace.c | 74 +---
1 f
error handling in poking_init [masami]
Andy Lutomirski (1):
x86/mm: temporary mm struct
Nadav Amit (13):
Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"
x86/jump_label: Use text_poke_early() during early init
fork: provide a function for copying init_
: Peter Zijlstra
Cc: Dave Hansen
Reviewed-by: Masami Hiramatsu
Tested-by: Masami Hiramatsu
Signed-off-by: Andy Lutomirski
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/mmu_context.h | 32 ++
1 file changed, 32 insertions(+)
diff --git a/arch/x86/include/asm
> On Dec 4, 2018, at 5:34 PM, Nadav Amit wrote:
>
> A following patch is going to make module allocated memory
> non-executable. This requires to modify ftrace and make the memory
> executable again after it is configured.
>
> In addition, this patch makes ftrace use th
> On Dec 6, 2018, at 1:57 AM, Peter Zijlstra wrote:
>
> On Tue, Dec 04, 2018 at 05:34:07PM -0800, Nadav Amit wrote:
>
>> So let's remove it. Andy suggested that the changes of the PTEs can be
>> avoided (excluding the direct-mapping alias), which is true. Howeve
> On Dec 6, 2018, at 10:52 AM, Andy Lutomirski wrote:
>
> On Wed, Dec 5, 2018 at 12:52 AM Nadav Amit wrote:
>> When module memory is about to be freed, there is no apparent reason to
>> make it (and its data) executable, but that's exactly what is done
>> toda
> On Dec 6, 2018, at 12:21 PM, Edgecombe, Rick P
> wrote:
>
> On Thu, 2018-12-06 at 10:52 -0800, Andy Lutomirski wrote:
>> On Wed, Dec 5, 2018 at 12:52 AM Nadav Amit wrote:
>>> When module memory is about to be freed, there is no apparent reason to
>>> ma
[Resend, changing title & adding lkml and some others ]
On Dec 7, 2018, at 3:12 PM, Nadav Amit wrote:
[ We can start a new thread, since I have the tendency to hijack threads. ]
> On Dec 7, 2018, at 12:45 AM, Peter Zijlstra wrote:
>
> On Thu, Dec 06, 2018 at 09:26:24AM -080
> On Dec 6, 2018, at 9:43 AM, Jesper Dangaard Brouer wrote:
>
> On Thu, 6 Dec 2018 07:37:19 -0800
> Christoph Hellwig wrote:
>
>> Hi all,
>>
>> a while ago Jesper reported major performance regressions due to the
>> spectre v2 mitigations in his XDP forwarding workloads. A large part
>> of t
> On Dec 6, 2018, at 11:19 AM, Andy Lutomirski wrote:
>
> On Thu, Dec 6, 2018 at 11:01 AM Tycho Andersen wrote:
>> On Thu, Dec 06, 2018 at 10:53:50AM -0800, Andy Lutomirski wrote:
If we are going to unmap the linear alias, why not do it at vmalloc()
time rather than vfree() time?
>>>
> On Dec 6, 2018, at 12:17 PM, Andy Lutomirski wrote:
>
> On Thu, Dec 6, 2018 at 11:39 AM Nadav Amit wrote:
>>> On Dec 6, 2018, at 11:19 AM, Andy Lutomirski wrote:
>>>
>>> On Thu, Dec 6, 2018 at 11:01 AM Tycho Andersen wrote:
>>>> On Thu, D
t me know.
>
> ------
>
> From: Nadav Amit
>
> commit 9bc4f28af75a91aea0ae383f50b0a430c4509303 upstream.
>
> When page-table entries are set, the compiler might optimize their
> assignment by using multiple instructions to set the PTE. This might
> turn into a security hazard if the us
> On Dec 8, 2018, at 2:52 AM, Peter Zijlstra wrote:
>
> On Fri, Dec 07, 2018 at 04:40:52PM -0800, Nadav Amit wrote:
>
>>> I'm actually having difficulty finding the this_cpu_read() in any of the
>>> functions you mention, so I cannot make any concrete suggest
> On Dec 6, 2018, at 2:03 AM, Peter Zijlstra wrote:
>
> On Tue, Dec 04, 2018 at 05:33:54PM -0800, Nadav Amit wrote:
>> Which leads me to (b) - the patch-set is big "enough" IMHO. Indeed,
>> there are open security issues in the kernel when it comes to W^X. But
&
mization, which would break the hypervisor ABI.
>
> Mark the structures as packed to prevent this.
Seems good to me (I made sure you remembered to set __packed for the nested
structs ;-) )
If needed:
Acked-by: Nadav Amit
Having said that, something else is sort of strange in the T
> On Nov 29, 2018, at 8:43 AM, Logan Gunthorpe wrote:
>
>
>
> On 2018-11-28 6:31 p.m., Nadav Amit wrote:
>>> On Nov 28, 2018, at 4:49 PM, Logan Gunthorpe wrote:
>>>
>>>
>>>
>>> On 2018-11-28 5:38 p.m., Nadav Amit wrote:
>>
> On Nov 29, 2018, at 7:19 AM, Josh Poimboeuf wrote:
>
> On Wed, Nov 28, 2018 at 10:06:52PM -0800, Andy Lutomirski wrote:
>> On Wed, Nov 28, 2018 at 7:24 PM Andy Lutomirski wrote:
>>> On Nov 28, 2018, at 6:06 PM, Nadav Amit wrote:
>>>
>>>>> On
From: Nadav Amit
Sent: November 8, 2018 at 8:18:23 PM GMT
> To: Logan Gunthorpe , h...@zytor.com ,
> Ingo Molnar
> Cc: LKML , X86 ML , Sam
> Ravnborg , Michal Marek , Thomas
> Gleixner , Linux Kbuild mailing list
> , Stephen Bates
> Subject: Re: [PATCH v9 02/10] Makefi
Zijlstra
Cc: Dave Hansen
Cc: Masami Hiramatsu
Suggested-by: Thomas Gleixner
Suggested-by: Andy Lutomirski
Signed-off-by: Nadav Amit
---
arch/x86/kernel/alternative.c | 28 +---
arch/x86/kernel/module.c | 2 +-
include/linux/filter.h| 6 ++
kernel
conservative enough when mapping pages,
as it always tries to map 2 pages, even when a single one is sufficient.
So try to be more conservative, and do not map more than needed.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Peter Zijlstra
Cc: Dave Hansen
Cc: Masami Hiramatsu
Signed-off-by: Nadav Amit
The return value of text_poke_early() and text_poke_bp() is useless.
Remove it.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Peter Zijlstra
Cc: Dave Hansen
Cc: Masami Hiramatsu
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/text-patching.h | 4 ++--
arch/x86/kernel/alternative.c| 11
Signed-off-by: Nadav Amit
---
arch/x86/kernel/jump_label.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/arch/x86/kernel/jump_label.c b/arch/x86/kernel/jump_label.c
index ed5fe274a7d8..7947df599e58 100644
--- a/arch/x86/kernel/jump_label.c
+++ b/arch/x86/kernel
text_poke() already ensures that the written value is the correct one
and fails if that is not the case. There is no need for an additional
comparison. Remove it.
Signed-off-by: Nadav Amit
---
arch/x86/kernel/kgdb.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/arch/x86/kernel
: Peter Zijlstra
Cc: Dave Hansen
Reviewed-by: Masami Hiramatsu
Tested-by: Masami Hiramatsu
Signed-off-by: Andy Lutomirski
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/mmu_context.h | 20
1 file changed, 20 insertions(+)
diff --git a/arch/x86/include/asm
Hiramatsu
Tested-by: Masami Hiramatsu
Suggested-by: Andy Lutomirski
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/pgtable.h | 3 +++
arch/x86/include/asm/text-patching.h | 2 ++
arch/x86/kernel/alternative.c| 3 +++
arch/x86/mm/init_64.c| 39
that would set a temporary mm for
patching, which is initialized after some static-keys are
enabled/disabled.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Dave Hansen
Cc: Masami Hiramatsu
Co-Developed-by: Peter Zijlstra
Signed-off-by: Nadav Amit
---
arch/x86/kernel/jump_label.c | 7 ++-
1 file ch
Provide a function for copying init_mm. This function will be later used
for setting a temporary mm.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Peter Zijlstra
Cc: Dave Hansen
Reviewed-by: Masami Hiramatsu
Tested-by: Masami Hiramatsu
Signed-off-by: Nadav Amit
---
include/linux/sched/task.h | 1
s of text_poke return value [masami]
- Use __weak for poking_init instead of macros [masami]
- Simplify error handling in poking_init [masami]
Andy Lutomirski (1):
x86/mm: temporary mm struct
Nadav Amit (9):
Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"
x86/
Lockdep-enforce text_mutex in
text_poke*()")
Suggested-by: Peter Zijlstra
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/text-patching.h | 3 +-
arch/x86/kernel/alternative.c| 72 +---
arch/x86/kernel/kgdb.c | 15 --
3 files changed,
101 - 200 of 1398 matches
Mail list logo
