[PATCH] gpio: tps65912: fix wrong container_of arguments

2015-02-18 Thread Nicolas Saenz Julienne
The gpio_chip operations receive a pointer the gpio_chip struct which is contained in the driver's private struct, yet the container_of call in those functions point to the mfd struct defined in include/linux/mfd/tps65912.h. Signed-off-by: Nicolas Saenz Julienne nicolassae...@gmail.com

[PATCH] gpio: add tps65218 gpio driver

2015-10-23 Thread Nicolas Saenz Julienne
that evaluates the fw config flags and removed module owner Signed-off-by: Nicolas Saenz Julienne <nicolassae...@gmail.com> --- drivers/gpio/Kconfig | 7 ++ drivers/gpio/Makefile| 1 + drivers/gpio/gpio-tps65218.c | 217 +++ 3 files c

[PATCH] gpio: add tps65218 gpio driver

2015-10-11 Thread Nicolas Saenz Julienne
by default. Signed-off-by: Nicolas Saenz Julienne <nicolassae...@gmail.com> --- drivers/gpio/Kconfig | 7 ++ drivers/gpio/Makefile| 1 + drivers/gpio/gpio-tps65218.c | 165 +++ 3 files changed, 173 insertions(+) create mode 100644 d

[PATCH] tty: serial: meson: Add earlycon support

2016-02-07 Thread Nicolas Saenz Julienne
Signed-off-by: Nicolas Saenz Julienne <nicolassae...@gmail.com> --- Documentation/kernel-parameters.txt | 6 ++ drivers/tty/serial/meson_uart.c | 22 ++ 2 files changed, 28 insertions(+) diff --git a/Documentation/kernel-parameters.txt b/Documentation/

[PATCH] gpio: add tps65218 gpio

2016-01-30 Thread Nicolas Saenz Julienne
that evaluates the fw config flags and removed module owner v3: Added .direction_input() routine, and took care of all Linus Walleij suggestions (clamp to bool, use proper include) Signed-off-by: Nicolas Saenz Julienne <nicolassae...@gmail.com> --- drivers/gpio/Kconfig | 7 ++ driver

[PATCH] USB: cdc-acm: add support for Sagem Monetel ELC930

2016-03-12 Thread Nicolas Saenz Julienne
Signed-off-by: Nicolas Saenz Julienne <nicolassae...@gmail.com> --- drivers/usb/class/cdc-acm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index fa4e239..9831607 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb

[PATCH v2] USB: cdc-acm: add support for Sagem Monetel ELC930

2016-03-15 Thread Nicolas Saenz Julienne
ror during the probe function. Adding the NO_UNION_NORMAL quirk solves the issue. Signed-off-by: Nicolas Saenz Julienne <nicolassae...@gmail.com> --- v2. Added a proper description drivers/usb/class/cdc-acm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/class/cdc-acm

[PATCH] gpio: 74x164: add dt support for nxp's 74x594

2016-03-14 Thread Nicolas Saenz Julienne
The chip is also an 8 bit shift register which works out of the box as a GPO expander with this patch Signed-off-by: Nicolas Saenz Julienne <nicolassae...@gmail.com> --- Documentation/devicetree/bindings/gpio/gpio-74x164.txt | 4 +++- drivers/gpio/gpio-74x164.c

Re: [PATCH] USB: cdc-acm: add support for Sagem Monetel ELC930

2016-03-14 Thread Nicolas Saenz Julienne
On Sat, Mar 12, 2016 at 04:27:29PM -0800, Greg KH wrote: > On Sat, Mar 12, 2016 at 11:44:51PM +0000, Nicolas Saenz Julienne wrote: > > Signed-off-by: Nicolas Saenz Julienne <nicolassae...@gmail.com> > > --- > > drivers/usb/class/cdc-acm.c | 3 +++ > > 1 file chan

Re: [PATCH] gpio: 74x164: add dt support for nxp's 74x594

2016-03-22 Thread nicolas saenz julienne
Hi sorry for the late response but I was on vacation. > > Why did you choose the "lvc" variant? Well to be honest the HW people did and it's all I could test with. I don't know much about these naming schemes, apart from the intuition it has to do with frequency and line levels. > Ideally, you

Re: [PATCH] gpio: 74x164: add dt support for nxp's 74x594

2016-03-22 Thread Nicolas Saenz Julienne
Hi Geert, thanks for your reply. On Tue, Mar 22, 2016 at 11:56:51AM +0100, Geert Uytterhoeven wrote: [..] > For DT bindings, it doesn't matter who manufactured the part, or which > technology was used (TTL, HC, LVC, ...). > > Logically, the shiny new parts are compatible with the old ones, from

[PATCH v2] usb: dwc3: gadget: don't rely on jiffies while holding spinlock

2016-08-16 Thread Nicolas Saenz Julienne
From: Nicolas Saenz Julienne <nicolassae...@gmeil.com> __dwc3_gadget_wakeup() is called while holding a spinlock, then depends on jiffies in order to timeout while polling the USB core for a link state update. In the case the wakeup failed, the timeout will never happen and will also

[PATCH] usb: dwc3: gadget: don't rely on jiffies while holding spinlock

2016-08-15 Thread Nicolas Saenz Julienne
to a "decrement variable and wait" timeout scheme. Signed-off-by: Nicolas Saenz Julienne <nicolassae...@gmail.com> --- drivers/usb/dwc3/gadget.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index

[PATCH v2] usb: dwc3: gadget: don't rely on jiffies while holding spinlock

2016-08-23 Thread Nicolas Saenz Julienne
to a "decrement variable and wait" timeout scheme. Signed-off-by: Nicolas Saenz Julienne <nicolassae...@gmail.com> --- v2. removed udelay() from while loop note: resubmitting since earlier patch had errata on e-mail address drivers/usb/dwc3/gadget.c | 6 +++--- 1 file changed, 3

[PATCH 1/2] power: supply: add sbs-charger driver

2016-11-23 Thread Nicolas Saenz Julienne
This adds support for sbs-charger compilant chips as defined here: http://sbs-forum.org/specs/sbc110.pdf This was tested on a arm board connected to an LTC41000 battery charger chip. Signed-off-by: Nicolas Saenz Julienne <nicolas.sa...@prodys.net> --- v1 -> v2: - add spec link in head

[PATCH 2/2] dt-bindings: power: add bindings for sbs-charger

2016-11-23 Thread Nicolas Saenz Julienne
Adds device tree documentation for SBS charger compilant devices as defined here: http://sbs-forum.org/specs/sbc110.pdf Signed-off-by: Nicolas Saenz Julienne <nicolas.sa...@prodys.net> --- .../bindings/power/supply/sbs_sbs-charger.txt | 22 ++ 1 file chang

[PATCH 0/2] power: supply: add sbs-charger driver

2016-11-23 Thread Nicolas Saenz Julienne
the driver. Regards, Nicolas changes since v1: - added dt bindings - updated driver with Sebastian's comments - s/Nicola/Nicolas/ in commits Nicolas Saenz Julienne (2): power: supply: add sbs-charger driver dt-bindings: power: add bindings for sbs-charger .../bindings/power/supply/sbs_sbs

Re: [PATCH 1/2] power: supply: sbs-battery: use fixed device name

2016-11-22 Thread Nicolas Saenz Julienne
Hi Sebastian, sorry I wasn't aware of that feature, I'll have a look at the whole thing and rework the patch. Regards, Nicolas On 22/11/16 16:23, Sebastian Reichel wrote: > Hi, > > On Mon, Nov 21, 2016 at 07:04:50PM +0100, Nicola Saenz Julienne wrote: >> The current device name for sbs-battery

[PATCH v3 0/2] power: supply: add sbs-charger driver

2016-11-24 Thread Nicolas Saenz Julienne
the driver. Regards, Nicolas changes since v2: - updated driver and dt-binding with Sebatian's comments changes since v1: - added dt bindings - updated driver with Sebastian's comments - s/Nicola/Nicolas/ in commits Nicolas Saenz Julienne (2): power: supply: add sbs-charger driver dt-bindings

[PATCH v3 2/2] dt-bindings: power: add bindings for sbs-charger

2016-11-24 Thread Nicolas Saenz Julienne
Adds device tree documentation for SBS charger compilant devices as defined here: http://sbs-forum.org/specs/sbc110.pdf Signed-off-by: Nicolas Saenz Julienne <nicolas.sa...@prodys.net> --- v2 -> v3: - add part number as compatible .../bindings/power/supply/sbs_sbs-charger.txt

[PATCH v3 1/2] power: supply: add sbs-charger driver

2016-11-24 Thread Nicolas Saenz Julienne
This adds support for sbs-charger compilant chips as defined here: http://sbs-forum.org/specs/sbc110.pdf This was tested on a arm board connected to an LTC41000 battery charger chip. Signed-off-by: Nicolas Saenz Julienne <nicolas.sa...@prodys.net> --- v2 -> v3: - add readable_reg()

Re: [PATCH v3 0/2] power: supply: add sbs-charger driver

2016-12-13 Thread Nicolas Saenz Julienne
On 24/11/16 13:33, Nicolas Saenz Julienne wrote: > Hi, > > This series adds support for all SBS compatible battery chargers, as defined > here: http://sbs-forum.org/specs/sbc110.pdf. > > The first patch changes the sbs-battery device name in order to be able to > cre

Re: [PATCH v4 1/2] power: supply: add sbs-charger driver

2016-12-21 Thread Nicolas Saenz Julienne
Hi Manish, thanks for the interest. On 20/12/16 17:54, Manish Badarkhe wrote: > Hi Nicola > [...] > > Just some general comment, Can you add some more properties here to > know voltage and current? I assume you are mentioning reading current and voltage values. These properties are not supported

[PATCH v4 2/2] dt-bindings: power: add bindings for sbs-charger

2016-12-20 Thread Nicolas Saenz Julienne
Adds device tree documentation for SBS charger compilant devices as defined here: http://sbs-forum.org/specs/sbc110.pdf Signed-off-by: Nicolas Saenz Julienne <nicolas.sa...@prodys.net> --- v3 -> v4: - use part-number/fallback compatible string structure v2 -> v3: - add part number a

[PATCH v4 1/2] power: supply: add sbs-charger driver

2016-12-20 Thread Nicolas Saenz Julienne
This adds support for sbs-charger compilant chips as defined here: http://sbs-forum.org/specs/sbc110.pdf This was tested on a arm board connected to an LTC4100 battery charger chip. Signed-off-by: Nicolas Saenz Julienne <nicolas.sa...@prodys.net> --- v3 -> v4 - drop "lltc,ltc41

[PATCH v4 0/2] power: supply: add sbs-charger driver

2016-12-20 Thread Nicolas Saenz Julienne
changes since v1: - added dt bindings - updated driver with Sebastian's comments - s/Nicola/Nicolas/ in commits Nicolas Saenz Julienne (2): power: supply: add sbs-charger driver dt-bindings: power: add bindings for sbs-charger .../bindings/power/supply/sbs_sbs-charger.txt | 23 ++ drivers

Re: [PATCH 6/9] ASoC: dt-bindings: bcm2835-rpi: add onboard audio bindings

2018-10-16 Thread Nicolas Saenz Julienne
Hi Stefan, thanks for the review, On Tue, 2018-10-16 at 17:56 +0200, Stefan Wahren wrote: > Hi Nicolas, > > Am 16.10.2018 um 17:02 schrieb Nicolas Saenz Julienne: > > Adds a device tree binding file for Raspberry pi's Headphones and > > HDMI > > audio out

[PATCH v2 1/7] staging: bcm2835-audio: unify FOURCC command definitions

2018-10-17 Thread Nicolas Saenz Julienne
The device communicates with the audio core using FOURCC codes. The driver was generating them using different macros/expressions. We now use the same macro to create them and centralize all the definitions. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Takashi Iwai Acked-by: Stefan Wahren

[PATCH v2 0/7] staging: bcm2835-audio: Cleanups and upgrades

2018-10-17 Thread Nicolas Saenz Julienne
with sound so I only tested the mini jack output. Thanks, Nicolas v2: Removes the device tree related patches, updates TODO accordingly and adds suggestions from Takashi. Nicolas Saenz Julienne (7): staging: bcm2835-audio: unify FOURCC command definitions staging: bcm2835-audio: don't

[PATCH v2 2/7] staging: bcm2835-audio: don't initialize memory twice

2018-10-17 Thread Nicolas Saenz Julienne
The memory is being allocated with devres_alloc(), wich ultimately uses __GFP_ZERO to call kmalloc. We don't need to zero the memory area again in bcm2835-audio. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Takashi Iwai Acked-by: Stefan Wahren --- drivers/staging/vc04_services/bcm2835

[PATCH v2 7/7] staging: bcm2835-audio: update TODO

2018-10-17 Thread Nicolas Saenz Julienne
/2018/9/4/587 Also, adds a new task as per mailing list conversation. Signed-off-by: Nicolas Saenz Julienne --- .../staging/vc04_services/bcm2835-audio/TODO | 25 +++ 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-audio/TODO b

[PATCH v2 3/7] staging: bcm2835-audio: reorder variable declarations & remove trivial comments

2018-10-17 Thread Nicolas Saenz Julienne
When it comes to declaring variables it's preferred, when possible, to use an inverted tree organization scheme. Also, removes some comments that were useless. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Takashi Iwai Acked-by: Stefan Wahren --- .../vc04_services/bcm2835-audio/bcm2835

[PATCH v2 5/7] staging: bcm2835-audio: more generic probe function name

2018-10-17 Thread Nicolas Saenz Julienne
There will only be one probe function, there is no use for appendig "_dt" the end of the name. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Takashi Iwai Acked-by: Stefan Wahren --- drivers/staging/vc04_services/bcm2835-audio/bcm2835.c | 4 ++-- 1 file changed, 2 insert

[PATCH v2 6/7] staging: bcm2835-audio: rename platform_driver structure

2018-10-17 Thread Nicolas Saenz Julienne
It was called bcm2835_alsa0_driver, that "0" didn't mean much. Suggested-by: Takashi Iwai Signed-off-by: Nicolas Saenz Julienne --- drivers/staging/vc04_services/bcm2835-audio/bcm2835.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vc0

[PATCH v2 4/7] staging: bcm2835-audio: use anonymous union in struct vc_audio_msg

2018-10-17 Thread Nicolas Saenz Julienne
In this case explicitly naming the union doesn't help overall code comprehension and clutters it. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Takashi Iwai Acked-by: Stefan Wahren --- .../bcm2835-audio/bcm2835-vchiq.c | 30 +-- .../bcm2835-audio

[PATCH 9/9] staging: bcm2835-audio: check for VCHIQ during probe

2018-10-16 Thread Nicolas Saenz Julienne
The audio data is sent to rpi's VideoCore IV trough VCHIQ. We make sure it's available and that we fail gracefully in case it isn't there. Signed-off-by: Nicolas Saenz Julienne --- drivers/staging/vc04_services/bcm2835-audio/bcm2835.c | 10 ++ 1 file changed, 10 insertions(+) diff

[PATCH 3/9] staging: bcm2835-audio: reorder variable declarations & remove trivial comments

2018-10-16 Thread Nicolas Saenz Julienne
When it comes to declaring variables it's preferred, when possible, to use an inverted tree organization scheme. Also, removes some comments that were useless. Signed-off-by: Nicolas Saenz Julienne --- .../vc04_services/bcm2835-audio/bcm2835-pcm.c | 10 ++ .../vc04_services

[PATCH 5/9] staging: bcm2835-audio: more generic probe function name

2018-10-16 Thread Nicolas Saenz Julienne
There will only be one probe function, there is no use for appendig "_dt" the end of the name. Signed-off-by: Nicolas Saenz Julienne --- drivers/staging/vc04_services/bcm2835-audio/bcm2835.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vc0

[PATCH 6/9] ASoC: dt-bindings: bcm2835-rpi: add onboard audio bindings

2018-10-16 Thread Nicolas Saenz Julienne
Adds a device tree binding file for Raspberry pi's Headphones and HDMI audio output devices. Based on raspberry's downstream kernel implementation: https://github.com/raspberrypi/linux/blob/rpi-4.14.y/arch/arm/boot/dts/bcm2708-rpi.dtsi Signed-off-by: Nicolas Saenz Julienne --- .../bindings

[PATCH 4/9] staging: bcm2835-audio: use anonymous union in struct vc_audio_msg

2018-10-16 Thread Nicolas Saenz Julienne
In this case explicitly naming the union doesn't help overall code comprehension and clutters it. Signed-off-by: Nicolas Saenz Julienne --- .../bcm2835-audio/bcm2835-vchiq.c | 30 +-- .../bcm2835-audio/vc_vchi_audioserv_defs.h| 2 +- 2 files changed, 16

[PATCH 8/9] staging: vchiq_arm: add function to check if probe was successful

2018-10-16 Thread Nicolas Saenz Julienne
Devices depending on VCHIQ need to double check it's initialization process was successful. This patch adds a helper function to do so. Signed-off-by: Nicolas Saenz Julienne --- .../staging/vc04_services/interface/vchi/vchi.h | 3 +++ .../interface/vchiq_arm/vchiq_2835_arm.c | 2

[PATCH 7/9] ARM: dts: bcm2835-rpi: add onboard audio device

2018-10-16 Thread Nicolas Saenz Julienne
The audio device interfaces with VCHIQ to send audio through the rpi's Headphones & HDMI. Signed-off-by: Nicolas Saenz Julienne --- arch/arm/boot/dts/bcm2835-rpi.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm

[PATCH 0/9] staging: bcm2835-audio: Cleanups and upgrades

2018-10-16 Thread Nicolas Saenz Julienne
if VCHIQ isn't there (as per TODO). The series was developed on top of linux-next and tested on a RPi2B and RPi3B+. Sadly I don't have an HDMI monitor with sound so I only tested the mini jack output. Thanks, Nicolas === Nicolas Saenz Julienne (9): staging: bcm2835-audio: unify FOURCC command

[PATCH 2/9] staging: bcm2835-audio: don't initialize memory twice

2018-10-16 Thread Nicolas Saenz Julienne
The memory is being allocated with devres_alloc(), wich ultimately uses __GFP_ZERO to call kmalloc. We don't need to zero the memory area again in bcm2835-audio. Signed-off-by: Nicolas Saenz Julienne --- drivers/staging/vc04_services/bcm2835-audio/bcm2835.c | 2 -- 1 file changed, 2 deletions

[PATCH 1/9] staging: bcm2835-audio: unify FOURCC command definitions

2018-10-16 Thread Nicolas Saenz Julienne
The device communicates with the audio core using FOURCC codes. The driver was generating them using different macros/expressions. We now use the same macro to create them and centralize all the definitions. Signed-off-by: Nicolas Saenz Julienne --- .../vc04_services/bcm2835-audio/bcm2835

[PATCH RFC 08/18] staging: vchiq_core: remove unnecessary safety checks in vchiq_init_state

2018-10-26 Thread Nicolas Saenz Julienne
changed in between functions, making the checks useless. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_core.c | 59 --- 1 file changed, 59 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging

[PATCH RFC 02/18] staging: vchiq_arm: rework close/remove_service IOCTLS

2018-10-26 Thread Nicolas Saenz Julienne
The implementation of both IOCTLS was the same except for one function call. This joins both implementations and updates the code to avoid unneeded indentations. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_arm.c | 66 +++ 1 file changed, 24

[PATCH RFC 05/18] staging: vchiq_arm: get rid of vchi_mh.h

2018-10-26 Thread Nicolas Saenz Julienne
The concept of VCHI_MEM_HANDLE_T is introduced by this header file and was meant to be used with bulk transfers. After a quick look in vchiq_core.c it is pretty clear that it actually accomplishes nothing nor alters the bulk transfers in any way. Signed-off-by: Nicolas Saenz Julienne

[PATCH RFC 04/18] stagning: vchiq_arm: use list_for_each_entry when accessing bulk_waiter_list

2018-10-26 Thread Nicolas Saenz Julienne
The resulting code is way more readeable and intuitive compared to plain list_for_each. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_arm.c | 52 ++- 1 file changed, 16 insertions(+), 36 deletions(-) diff --git a/drivers/staging/vc04_services

[PATCH RFC 07/18] staging: vchiq-core: get rid of is_master distinction

2018-10-26 Thread Nicolas Saenz Julienne
". There seems to be an option to switch roles in vchiq. Which nobody is using nor is properly implemented. So we get rid of the "is_master == 1" option, and all the related code. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_2835_arm.c | 12 +- .../in

[PATCH RFC 01/18] staging: vchiq_core: rework vchiq_get_config

2018-10-26 Thread Nicolas Saenz Julienne
The function is overly complicated for what it's ultimately achieving. It's simply filling up a structure. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_arm.c | 12 .../interface/vchiq_arm/vchiq_core.c | 30 +-- .../interface

[PATCH RFC 00/18] staging: vchiq: remove dead code & misc fixes

2018-10-26 Thread Nicolas Saenz Julienne
-next, and was tested on a RPIv3B+ with audio, video and running vchiq_test. Regards, Nicolas === Nicolas Saenz Julienne (18): staging: vchiq_core: rework vchiq_get_config staging: vchiq_arm: rework close/remove_service IOCTLS staging: vchiq_shim: delete vchi_service_create stagning

[PATCH RFC 17/18] staging: vchiq_arm: fix open/release cdev functions

2018-10-26 Thread Nicolas Saenz Julienne
Both functions checked the minor number of the cdev prior running the code. This was useless since the number of devices is already limited by alloc_chrdev_region. This removes the check and reindents the code where relevant. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm

[PATCH RFC 15/18] stagning: vchiq_core: fix logic redundancy in parse_open

2018-10-26 Thread Nicolas Saenz Julienne
We update sync to reflect that the firmware version is compatible with that option. We don't need to check both of them again further down the code. Signed-off-by: Nicolas Saenz Julienne --- .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c| 4 +--- 1 file changed, 1 insertion

[PATCH RFC 12/18] staging: vchiq_util: use completions instead of semaphores

2018-10-26 Thread Nicolas Saenz Julienne
are semantically more explicit in this case. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_util.c | 16 .../interface/vchiq_arm/vchiq_util.h | 6 +++--- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging

[PATCH RFC 09/18] staging: vchiq_core: do not initialize semaphores twice

2018-10-26 Thread Nicolas Saenz Julienne
vchiq_init_state() initialises a series of semaphores to then call remote_event_create() on the same semaphores, which initializes them again. Signed-off-by: Nicolas Saenz Julienne --- .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 5 - 1 file changed, 5 deletions(-) diff

[PATCH RFC 14/18] staging: vchiq_util: get rid of unneeded memory barriers

2018-10-26 Thread Nicolas Saenz Julienne
All the memory operations featured in this file modify/access memory that is only accessed by the CPU. So we can assume that all the memory barrier handling done by the completion routines is good enough for us. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_util.c

[PATCH RFC 06/18] staging: vchiq_arm: rework vchiq_ioc_copy_element_data

2018-10-26 Thread Nicolas Saenz Julienne
ll the elements into memory as long as they fit". The resulting function is shorter and simpler. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_arm.c | 89 +++ 1 file changed, 31 insertions(+), 58 deletions(-) diff --git a/drivers/staging/vc0

[PATCH RFC 03/18] staging: vchiq_shim: delete vchi_service_create

2018-10-26 Thread Nicolas Saenz Julienne
No one is using the API neither in the actual staging tree nor in the downstream tree (https://github.com/raspberrypi/linux). Signed-off-by: Nicolas Saenz Julienne --- .../vc04_services/interface/vchi/vchi.h | 5 --- .../interface/vchiq_arm/vchiq_shim.c | 32

[PATCH RFC 11/18] staging: vchiq_arm: use completions instead of semaphores

2018-10-26 Thread Nicolas Saenz Julienne
are semantically more explicit in this case. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_arm.c | 58 ++- 1 file changed, 31 insertions(+), 27 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging

[PATCH RFC 10/18] staging: vchiq_core: don't add a wmb() before remote_event_signal()

2018-10-26 Thread Nicolas Saenz Julienne
It's the first thing remote_event_signal() does. Signed-off-by: Nicolas Saenz Julienne --- .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c| 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging

[PATCH RFC 16/18] staging: vchiq_arm: rework probe and init functions

2018-10-26 Thread Nicolas Saenz Julienne
Some operations performed in the probe function should have been implemented in the init function. Namely class and dev region creations. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_arm.c | 71 --- 1 file changed, 45 insertions(+), 26

[PATCH RFC 18/18] staging: vchiq: add more tasks to the TODO list

2018-10-26 Thread Nicolas Saenz Julienne
The more the better. Signed-off-by: Nicolas Saenz Julienne --- .../staging/vc04_services/interface/vchi/TODO | 46 ++- 1 file changed, 44 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchi/TODO b/drivers/staging/vc04_services/interface/vchi

[PATCH RFC 13/18] staging: vchiq_core: use completions instead of semaphores

2018-10-26 Thread Nicolas Saenz Julienne
are semantically more explicit in this case. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_arm.c | 2 +- .../interface/vchiq_arm/vchiq_core.c | 94 +-- .../interface/vchiq_arm/vchiq_core.h | 26 ++--- 3 files changed, 61 insertions(+), 61

Re: [PATCH RFC 09/18] staging: vchiq_core: do not initialize semaphores twice

2018-11-06 Thread Nicolas Saenz Julienne
On Tue, 2018-11-06 at 17:06 +0100, Stefan Wahren wrote: > Am 06.11.18 um 16:41 schrieb Nicolas Saenz Julienne: > > Hi Stefan, > > thanks for spending the time reviewing the code. I took note of the > > rest of comments. > > > > On Sun, 2018-10-28 at 21:45 +01

[PATCH 06/16] staging: vchiq_arm: rework vchiq_ioc_copy_element_data

2018-11-14 Thread Nicolas Saenz Julienne
ll the elements into memory as long as they fit". The resulting function is shorter and simpler. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_arm.c | 89 +++ 1 file changed, 31 insertions(+), 58 deletions(-) diff --git a/drivers/staging/vc0

[PATCH 04/16] staging: vchiq_arm: use list_for_each_entry when accessing bulk_waiter_list

2018-11-14 Thread Nicolas Saenz Julienne
The resulting code is way more readeable and intuitive compared to plain list_for_each. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_arm.c | 52 ++- 1 file changed, 16 insertions(+), 36 deletions(-) diff --git a/drivers/staging/vc04_services

[PATCH 14/16] staging: vchiq_arm: rework probe and init functions

2018-11-14 Thread Nicolas Saenz Julienne
Moves the allocation of a chardev region and class creation to the init function of the driver since those functions are meant to be run on a per driver basis, as opposed to the code run in the probe function which is run in a per device basis. Signed-off-by: Nicolas Saenz Julienne

[PATCH 15/16] staging: vchiq_arm: fix open/release cdev functions

2018-11-14 Thread Nicolas Saenz Julienne
Both functions checked the minor number of the cdev prior running the code. This was useless since the number of devices is already limited by alloc_chrdev_region. This removes the check and reindents the code where relevant. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm

[PATCH 16/16] staging: vchiq: add more tasks to the TODO list

2018-11-14 Thread Nicolas Saenz Julienne
The TODO list was missing some tasks needed before upstreaming the device. Signed-off-by: Nicolas Saenz Julienne --- .../staging/vc04_services/interface/vchi/TODO | 42 +++ 1 file changed, 42 insertions(+) diff --git a/drivers/staging/vc04_services/interface/vchi/TODO b

[PATCH 08/16] staging: vchiq_core: remove unnecessary safety checks in vchiq_init_state

2018-11-14 Thread Nicolas Saenz Julienne
changed in between functions, making the checks useless. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_core.c | 59 --- 1 file changed, 59 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging

[PATCH 02/16] staging: vchiq_arm: rework close/remove_service IOCTLS

2018-11-14 Thread Nicolas Saenz Julienne
The implementation of both IOCTLS was the same except for one function call. This joins both implementations and updates the code to avoid unneeded indentations. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_arm.c | 66 +++ 1 file changed, 24

[PATCH 05/16] staging: vchiq_arm: get rid of vchi_mh.h

2018-11-14 Thread Nicolas Saenz Julienne
The concept of VCHI_MEM_HANDLE_T is introduced by this header file and was meant to be used with bulk transfers. After a quick look in vchiq_core.c it is pretty clear that it actually accomplishes nothing nor alters the bulk transfers in any way. Signed-off-by: Nicolas Saenz Julienne

[PATCH 11/16] staging: vchiq: use completions instead of semaphores

2018-11-14 Thread Nicolas Saenz Julienne
are semantically more explicit in this case. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_arm.c | 60 ++- .../interface/vchiq_arm/vchiq_core.c | 100 +- .../interface/vchiq_arm/vchiq_core.h | 26 ++--- .../interface/vchiq_arm

[PATCH 07/16] staging: vchiq-core: get rid of is_master distinction

2018-11-14 Thread Nicolas Saenz Julienne
". There seems to be an option to switch roles in vchiq. Which nobody is using nor is properly implemented. So we get rid of the "is_master == 1" option, and all the related code. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_2835_arm.c | 12 +- .../in

[PATCH 01/16] staging: vchiq_core: rework vchiq_get_config

2018-11-14 Thread Nicolas Saenz Julienne
The function is overly complicated for what it's ultimately achieving. It's simply filling up a structure. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_arm.c | 12 .../interface/vchiq_arm/vchiq_core.c | 30 +-- .../interface

[PATCH 03/16] staging: vchiq_shim: delete vchi_service_create

2018-11-14 Thread Nicolas Saenz Julienne
No one is using the API neither in the actual staging tree nor in the downstream tree (https://github.com/raspberrypi/linux). Signed-off-by: Nicolas Saenz Julienne --- .../vc04_services/interface/vchi/vchi.h | 5 --- .../interface/vchiq_arm/vchiq_shim.c | 32

[PATCH 00/16] staging: vchiq: dead code removal & misc fixes

2018-11-14 Thread Nicolas Saenz Julienne
on the topic, which is nice. It was developed on top of the latest linux-next, and was tested on a RPIv3B+ with audio, video and running vchiq_test. Regards, Nicolas === Nicolas Saenz Julienne (16): staging: vchiq_core: rework vchiq_get_config staging: vchiq_arm: rework close/remove_service IOCTLS

Re: [PATCH RFC 09/18] staging: vchiq_core: do not initialize semaphores twice

2018-11-06 Thread Nicolas Saenz Julienne
Hi Stefan, thanks for spending the time reviewing the code. I took note of the rest of comments. On Sun, 2018-10-28 at 21:45 +0100, Stefan Wahren wrote: > Hi Nicolas, > > > Nicolas Saenz Julienne hat am 26. Oktober > > 2018 um 15:48 geschrieben: > > > > >

[PATCH 10/16] staging: vchiq_core: don't add a wmb() before remote_event_signal()

2018-11-14 Thread Nicolas Saenz Julienne
It's the first thing remote_event_signal() does. Signed-off-by: Nicolas Saenz Julienne --- .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c| 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging

[PATCH 09/16] staging: vchiq_core: do not initialize semaphores twice

2018-11-14 Thread Nicolas Saenz Julienne
vchiq_init_state() initialises a series of semaphores to then call remote_event_create() on the same semaphores, which initializes them again. We get rid of the second initialization. Signed-off-by: Nicolas Saenz Julienne --- .../vc04_services/interface/vchiq_arm/vchiq_core.c| 11

[PATCH 13/16] staging: vchiq_core: fix logic redundancy in parse_open

2018-11-14 Thread Nicolas Saenz Julienne
We update sync to reflect that the firmware version is compatible with that option. We don't need to check both of them again further down the code. Signed-off-by: Nicolas Saenz Julienne --- .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c| 4 +--- 1 file changed, 1 insertion

[PATCH 12/16] staging: vchiq_util: get rid of unneeded memory barriers

2018-11-14 Thread Nicolas Saenz Julienne
All the memory operations featured in this file modify/access memory that is only accessed by the CPU. So we can assume that all the memory barrier handling done by the completion routines is good enough for us. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_util.c

[PATCH RFC 1/2] input: add official Raspberry Pi's 7" touchscreen driver

2018-12-05 Thread Nicolas Saenz Julienne
Adds support to Raspberry Pi's 7" touchscreen device. Instead of using a conventional bus all information is copied into a memory mapped area by RPi's VC4 firmware. Based on the driver found in RPi's downstream kernel repository. Signed-off-by: Nicolas Saenz Julienne --- drivers/

[PATCH RFC 2/2] Input: raspberrypi-ts - add devicetree binding documentation

2018-12-05 Thread Nicolas Saenz Julienne
Adds device tree documentation for Raspberry Pi's official 7" touchscreen. The firmware mailbox interface allows the ARM core to control the device. Signed-off-by: Nicolas Saenz Julienne --- .../touchscreen/raspberrypi,firmware-ts.txt | 25 +++ 1 file changed, 25 inser

[PATCH RFC 0/2] input: driver for RPi's official 7" touchscreen

2018-12-05 Thread Nicolas Saenz Julienne
a RPi 3 B+. [1] https://lists.infradead.org/pipermail/linux-rpi-kernel/2018-December/008444.html === Nicolas Saenz Julienne (2): input: add official Raspberry Pi's 7" touchscreen driver Input: raspberrypi-ts - add devicetree binding documentation .../touchscreen/raspberrypi,fir

[PATCH] firmware: stratix10-svc: fix wrong of_node_put() in init function

2018-12-03 Thread Nicolas Saenz Julienne
e again. This patch removes the unwarranted call to of_node_put(). Fixes: 7ca5ce896524 ("firmware: add Intel Stratix10 service layer driver") Signed-off-by: Nicolas Saenz Julienne --- drivers/firmware/stratix10-svc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/firmware/stra

[PATCH] fpga: stratix10-soc: fix wrong of_node_put() in init function

2018-12-03 Thread Nicolas Saenz Julienne
e again. This patch removes the unwarranted call to of_node_put(). Fixes: e7eef1d7633a ("fpga: add intel stratix10 soc fpga manager driver") Signed-off-by: Nicolas Saenz Julienne --- drivers/fpga/stratix10-soc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/fpga/stratix10-

Re: [PATCH] firmware: arm_sdei: fix wrong of_node_put() in init function

2018-12-03 Thread Nicolas Saenz Julienne
Hi James, thanks for the review! On Fri, 2018-11-30 at 18:31 +, James Morse wrote: > Hi Nicolas, > > On 26/11/2018 12:15, Nicolas Saenz Julienne wrote: > > After finding a "firmware" dt node arm_sdei tries to match it's > > compatible string

[PATCH] w1: fix wrong dt refcount in attach slave device

2018-12-03 Thread Nicolas Saenz Julienne
y: Nicolas Saenz Julienne --- drivers/w1/w1.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index 890c038c25f8..09514fa6c6b9 100644 --- a/drivers/w1/w1.c +++ b/drivers/w1/w1.c @@ -680,15 +680,17 @@ static int w1_family_notify(unsigned l

[PATCH v2] firmware: stratix10-svc: fix wrong of_node_put() in init function

2018-12-03 Thread Nicolas Saenz Julienne
e again. This patch removes the unwarranted call to of_node_put(). Fixes: 7ca5ce896524 ("firmware: add Intel Stratix10 service layer driver") Signed-off-by: Nicolas Saenz Julienne --- v1 -> v2: add actual people to CC & remove unnecessary braces drivers/firmware/stratix10-svc.c |

Re: [PATCH 00/16] staging: vchiq: dead code removal & misc fixes

2018-11-20 Thread Nicolas Saenz Julienne
On Tue, 2018-11-20 at 10:57 +0100, Greg KH wrote: > On Sun, Nov 18, 2018 at 04:55:49PM +0100, Stefan Wahren wrote: > > Hi Nicolas, > > > > > Nicolas Saenz Julienne hat am 14. > > > November 2018 um 13:59 geschrieben: > > > > > > > > &

[PATCH 13/16] staging: vchiq_core: fix logic redundancy in parse_open

2018-11-20 Thread Nicolas Saenz Julienne
We update sync to reflect that the firmware version is compatible with that option. We don't need to check both of them again further down the code. Signed-off-by: Nicolas Saenz Julienne --- .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c| 4 +--- 1 file changed, 1 insertion

[PATCH 09/16] staging: vchiq_core: do not initialize semaphores twice

2018-11-20 Thread Nicolas Saenz Julienne
vchiq_init_state() initialises a series of semaphores to then call remote_event_create() on the same semaphores, which initializes them again. We get rid of the second initialization. Signed-off-by: Nicolas Saenz Julienne --- .../vc04_services/interface/vchiq_arm/vchiq_core.c| 11

[PATCH 05/16] staging: vchiq_arm: get rid of vchi_mh.h

2018-11-20 Thread Nicolas Saenz Julienne
The concept of VCHI_MEM_HANDLE_T is introduced by this header file and was meant to be used with bulk transfers. After a quick look in vchiq_core.c it is pretty clear that it actually accomplishes nothing nor alters the bulk transfers in any way. Signed-off-by: Nicolas Saenz Julienne

[PATCH 10/16] staging: vchiq_core: don't add a wmb() before remote_event_signal()

2018-11-20 Thread Nicolas Saenz Julienne
It's the first thing remote_event_signal() does. Signed-off-by: Nicolas Saenz Julienne --- .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c| 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging

[PATCH 07/16] staging: vchiq-core: get rid of is_master distinction

2018-11-20 Thread Nicolas Saenz Julienne
". There seems to be an option to switch roles in vchiq. Which nobody is using nor is properly implemented. So we get rid of the "is_master == 1" option, and all the related code. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_2835_arm.c | 12 +- .../in

[PATCH 12/16] staging: vchiq_util: get rid of unneeded memory barriers

2018-11-20 Thread Nicolas Saenz Julienne
All the memory operations featured in this file modify/access memory that is only accessed by the CPU. So we can assume that all the memory barrier handling done by the completion routines is good enough for us. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_util.c

[PATCH 08/16] staging: vchiq_core: remove unnecessary safety checks in vchiq_init_state

2018-11-20 Thread Nicolas Saenz Julienne
changed in between functions, making the checks useless. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_core.c | 59 --- 1 file changed, 59 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging

[PATCH 06/16] staging: vchiq_arm: rework vchiq_ioc_copy_element_data

2018-11-20 Thread Nicolas Saenz Julienne
ll the elements into memory as long as they fit". The resulting function is shorter and simpler. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_arm.c | 89 +++ 1 file changed, 31 insertions(+), 58 deletions(-) diff --git a/drivers/staging/vc0

  1   2   3   4   5   6   7   8   9   10   >