Re: [PATCH] staging: fbtft: do not allocate huge txbuf

2016-06-09 Thread Noralf Trønnes
[resending got rejected on the list for html format] Den 09.06.2016 19:18, skrev Michal Suchanek: Hello, On 9 June 2016 at 18:20, Noralf Trønnes <nor...@tronnes.org> wrote: Den 09.06.2016 17:08, skrev Michal Suchanek: txbuflen can be set to arbitrary value by user and it is al

Re: [PATCH] staging: fbtft: do not allocate huge txbuf

2016-06-09 Thread Noralf Trønnes
[resending got rejected on the list for html format] Den 09.06.2016 19:18, skrev Michal Suchanek: Hello, On 9 June 2016 at 18:20, Noralf Trønnes wrote: Den 09.06.2016 17:08, skrev Michal Suchanek: txbuflen can be set to arbitrary value by user and it is also set automagically to the maximum

Re: [PATCH] staging: fbtft: do not allocate huge txbuf

2016-06-09 Thread Noralf Trønnes
Den 09.06.2016 17:08, skrev Michal Suchanek: txbuflen can be set to arbitrary value by user and it is also set automagically to the maximum transfer size of the SPI master controller. AFAICT this is a result of your previous patch. Please make a new version of your previous patch with this

Re: [PATCH] staging: fbtft: do not allocate huge txbuf

2016-06-09 Thread Noralf Trønnes
Den 09.06.2016 17:08, skrev Michal Suchanek: txbuflen can be set to arbitrary value by user and it is also set automagically to the maximum transfer size of the SPI master controller. AFAICT this is a result of your previous patch. Please make a new version of your previous patch with this

Re: [PATCH v4 3/3] drm: Add helper for simple display pipeline

2016-06-06 Thread Noralf Trønnes
Den 12.05.2016 20:25, skrev Noralf Trønnes: Provides helper functions for drivers that have a simple display pipeline. Plane, crtc and encoder are collapsed into one entity. Cc: jsa...@ti.com Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- [...] diff --git a/drivers/g

Re: [PATCH v4 3/3] drm: Add helper for simple display pipeline

2016-06-06 Thread Noralf Trønnes
Den 12.05.2016 20:25, skrev Noralf Trønnes: Provides helper functions for drivers that have a simple display pipeline. Plane, crtc and encoder are collapsed into one entity. Cc: jsa...@ti.com Signed-off-by: Noralf Trønnes --- [...] diff --git a/drivers/gpu/drm/drm_simple_kms_helper.c b

Re: [PATCH] fbtft: limit transfer length by spi device limit

2016-05-29 Thread Noralf Trønnes
s code of mine looks worse each time I'm confronted with it.) You have even taken care of the special txbuflen == -1 value I see, so I guess this is as good as it gets without any major refactoring, so: Acked-by: Noralf Trønnes <nor...@tronnes.org> And there's no point in doing any refactoring si

Re: [PATCH] fbtft: limit transfer length by spi device limit

2016-05-29 Thread Noralf Trønnes
I'm confronted with it.) You have even taken care of the special txbuflen == -1 value I see, so I guess this is as good as it gets without any major refactoring, so: Acked-by: Noralf Trønnes And there's no point in doing any refactoring since I'm working on a DRM successor for fbtft. I have

Re: [PATCH v4 3/3] drm: Add helper for simple display pipeline

2016-05-29 Thread Noralf Trønnes
Den 12.05.2016 20:25, skrev Noralf Trønnes: Provides helper functions for drivers that have a simple display pipeline. Plane, crtc and encoder are collapsed into one entity. Cc: jsa...@ti.com Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- [...] diff --git a/drivers/g

Re: [PATCH v4 3/3] drm: Add helper for simple display pipeline

2016-05-29 Thread Noralf Trønnes
Den 12.05.2016 20:25, skrev Noralf Trønnes: Provides helper functions for drivers that have a simple display pipeline. Plane, crtc and encoder are collapsed into one entity. Cc: jsa...@ti.com Signed-off-by: Noralf Trønnes --- [...] diff --git a/drivers/gpu/drm/drm_simple_kms_helper.c b

Re: [PATCH v4 3/3] drm: Add helper for simple display pipeline

2016-05-17 Thread Noralf Trønnes
Den 17.05.2016 14:12, skrev Ville Syrjälä: On Tue, May 17, 2016 at 02:00:45PM +0200, Noralf Trønnes wrote: Den 17.05.2016 09:59, skrev Daniel Vetter: On Tue, May 17, 2016 at 10:46:51AM +0300, Ville Syrjälä wrote: On Tue, May 17, 2016 at 09:05:01AM +0200, Daniel Vetter wrote: On Thu, May 12

Re: [PATCH v4 3/3] drm: Add helper for simple display pipeline

2016-05-17 Thread Noralf Trønnes
Den 17.05.2016 14:12, skrev Ville Syrjälä: On Tue, May 17, 2016 at 02:00:45PM +0200, Noralf Trønnes wrote: Den 17.05.2016 09:59, skrev Daniel Vetter: On Tue, May 17, 2016 at 10:46:51AM +0300, Ville Syrjälä wrote: On Tue, May 17, 2016 at 09:05:01AM +0200, Daniel Vetter wrote: On Thu, May 12

Re: [PATCH v4 3/3] drm: Add helper for simple display pipeline

2016-05-17 Thread Noralf Trønnes
Den 17.05.2016 09:59, skrev Daniel Vetter: On Tue, May 17, 2016 at 10:46:51AM +0300, Ville Syrjälä wrote: On Tue, May 17, 2016 at 09:05:01AM +0200, Daniel Vetter wrote: On Thu, May 12, 2016 at 09:36:14PM +0300, Ville Syrjälä wrote: On Thu, May 12, 2016 at 08:25:23PM +0200, Noralf Trønnes

Re: [PATCH v4 3/3] drm: Add helper for simple display pipeline

2016-05-17 Thread Noralf Trønnes
Den 17.05.2016 09:59, skrev Daniel Vetter: On Tue, May 17, 2016 at 10:46:51AM +0300, Ville Syrjälä wrote: On Tue, May 17, 2016 at 09:05:01AM +0200, Daniel Vetter wrote: On Thu, May 12, 2016 at 09:36:14PM +0300, Ville Syrjälä wrote: On Thu, May 12, 2016 at 08:25:23PM +0200, Noralf Trønnes

[PATCH v4 3/3] drm: Add helper for simple display pipeline

2016-05-12 Thread Noralf Trønnes
Provides helper functions for drivers that have a simple display pipeline. Plane, crtc and encoder are collapsed into one entity. Cc: jsa...@ti.com Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- Changes since v3: - (struct drm_simple_display_pipe *)->funcs should be const Chan

[PATCH v4 3/3] drm: Add helper for simple display pipeline

2016-05-12 Thread Noralf Trønnes
Provides helper functions for drivers that have a simple display pipeline. Plane, crtc and encoder are collapsed into one entity. Cc: jsa...@ti.com Signed-off-by: Noralf Trønnes --- Changes since v3: - (struct drm_simple_display_pipe *)->funcs should be const Changes since v2: - Drop Kcon

[PATCH v4 2/3] drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs()

2016-05-12 Thread Noralf Trønnes
Add drm_fb_cma_create_with_funcs() for drivers that need to set the dirty() callback. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Acked-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- Changes since v3: - funcs argument should be const Changes since v1: -

[PATCH v4 2/3] drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs()

2016-05-12 Thread Noralf Trønnes
Add drm_fb_cma_create_with_funcs() for drivers that need to set the dirty() callback. Signed-off-by: Noralf Trønnes Acked-by: Laurent Pinchart --- Changes since v3: - funcs argument should be const Changes since v1: - Expand docs drivers/gpu/drm/drm_fb_cma_helper.c | 31

[PATCH v4 0/3] drm: Add various helpers for simple drivers

2016-05-12 Thread Noralf Trønnes
ror code", "This hook is optional." - Add checks to drm_simple_kms_plane_atomic_check() Noralf Trønnes (3): drm/fb-cma-helper: Use const for drm_framebuffer_funcs argument drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs() drm: Add helper for simple display p

[PATCH v4 0/3] drm: Add various helpers for simple drivers

2016-05-12 Thread Noralf Trønnes
ror code", "This hook is optional." - Add checks to drm_simple_kms_plane_atomic_check() Noralf Trønnes (3): drm/fb-cma-helper: Use const for drm_framebuffer_funcs argument drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs() drm: Add helper for simple display p

[PATCH v4 1/3] drm/fb-cma-helper: Use const for drm_framebuffer_funcs argument

2016-05-12 Thread Noralf Trønnes
drm_framebuffer_init() uses const for the drm_framebuffer_funcs argument so use that on drm_fb_cma_alloc() and drm_fbdev_cma_create_with_funcs() as well. Cc: laurent.pinch...@ideasonboard.com Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/drm_fb_cma_helper

[PATCH v4 1/3] drm/fb-cma-helper: Use const for drm_framebuffer_funcs argument

2016-05-12 Thread Noralf Trønnes
drm_framebuffer_init() uses const for the drm_framebuffer_funcs argument so use that on drm_fb_cma_alloc() and drm_fbdev_cma_create_with_funcs() as well. Cc: laurent.pinch...@ideasonboard.com Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_cma_helper.c | 4 ++-- include/drm

Re: [PATCH v3 1/2] drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs()

2016-05-12 Thread Noralf Trønnes
Den 12.05.2016 15:47, skrev Laurent Pinchart: Hi Noralf, Thank you for the patch. On Thursday 12 May 2016 14:53:25 Noralf Trønnes wrote: Add drm_fb_cma_create_with_funcs() for drivers that need to set the dirty() callback. Cc: laurent.pinch...@ideasonboard.com Signed-off-by: Noralf Trønnes

Re: [PATCH v3 1/2] drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs()

2016-05-12 Thread Noralf Trønnes
Den 12.05.2016 15:47, skrev Laurent Pinchart: Hi Noralf, Thank you for the patch. On Thursday 12 May 2016 14:53:25 Noralf Trønnes wrote: Add drm_fb_cma_create_with_funcs() for drivers that need to set the dirty() callback. Cc: laurent.pinch...@ideasonboard.com Signed-off-by: Noralf Trønnes

[PATCH v3 2/2] drm: Add helper for simple display pipeline

2016-05-12 Thread Noralf Trønnes
Provides helper functions for drivers that have a simple display pipeline. Plane, crtc and encoder are collapsed into one entity. Cc: jsa...@ti.com Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- Changes since v2: - Drop Kconfig knob DRM_KMS_HELPER - Expand documentation Changes si

[PATCH v3 0/2] drm: Add various helpers for simple drivers

2016-05-12 Thread Noralf Trønnes
and add to gpu.tmpl - Fix docs: @funcs is optional, "negative error code", "This hook is optional." - Add checks to drm_simple_kms_plane_atomic_check() Noralf Trønnes (2): drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs() drm: Add helper for sim

[PATCH v3 2/2] drm: Add helper for simple display pipeline

2016-05-12 Thread Noralf Trønnes
Provides helper functions for drivers that have a simple display pipeline. Plane, crtc and encoder are collapsed into one entity. Cc: jsa...@ti.com Signed-off-by: Noralf Trønnes --- Changes since v2: - Drop Kconfig knob DRM_KMS_HELPER - Expand documentation Changes since v1: - Add DOC header

[PATCH v3 0/2] drm: Add various helpers for simple drivers

2016-05-12 Thread Noralf Trønnes
and add to gpu.tmpl - Fix docs: @funcs is optional, "negative error code", "This hook is optional." - Add checks to drm_simple_kms_plane_atomic_check() Noralf Trønnes (2): drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs() drm: Add helper for sim

[PATCH v3 1/2] drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs()

2016-05-12 Thread Noralf Trønnes
Add drm_fb_cma_create_with_funcs() for drivers that need to set the dirty() callback. Cc: laurent.pinch...@ideasonboard.com Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- Changes since v1: - Expand docs drivers/gpu/drm/drm_fb_cma_helper.c | 31 +-- i

[PATCH v3 1/2] drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs()

2016-05-12 Thread Noralf Trønnes
Add drm_fb_cma_create_with_funcs() for drivers that need to set the dirty() callback. Cc: laurent.pinch...@ideasonboard.com Signed-off-by: Noralf Trønnes --- Changes since v1: - Expand docs drivers/gpu/drm/drm_fb_cma_helper.c | 31 +-- include/drm

Re: [PATCH v2 6/6] drm: Add helper for simple display pipeline

2016-05-12 Thread Noralf Trønnes
Den 12.05.2016 10:11, skrev Daniel Vetter: On Wed, May 11, 2016 at 07:09:10PM +0200, Daniel Vetter wrote: On Wed, May 11, 2016 at 06:09:22PM +0200, Noralf Trønnes wrote: +/** + * drm_simple_display_pipe_init - Initialize a simple display pipeline + * @dev: DRM device + * @pipe: simple display

Re: [PATCH v2 6/6] drm: Add helper for simple display pipeline

2016-05-12 Thread Noralf Trønnes
Den 12.05.2016 10:11, skrev Daniel Vetter: On Wed, May 11, 2016 at 07:09:10PM +0200, Daniel Vetter wrote: On Wed, May 11, 2016 at 06:09:22PM +0200, Noralf Trønnes wrote: +/** + * drm_simple_display_pipe_init - Initialize a simple display pipeline + * @dev: DRM device + * @pipe: simple display

Re: [PATCH v2 6/6] drm: Add helper for simple display pipeline

2016-05-11 Thread Noralf Trønnes
Den 11.05.2016 21:10, skrev Paul Bolle: On wo, 2016-05-11 at 19:09 +0200, Daniel Vetter wrote: On Wed, May 11, 2016 at 06:09:22PM +0200, Noralf Trønnes wrote: --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig +config DRM_SIMPLE_KMS_HELPER + tristate + depends on DRM

Re: [PATCH v2 6/6] drm: Add helper for simple display pipeline

2016-05-11 Thread Noralf Trønnes
Den 11.05.2016 21:10, skrev Paul Bolle: On wo, 2016-05-11 at 19:09 +0200, Daniel Vetter wrote: On Wed, May 11, 2016 at 06:09:22PM +0200, Noralf Trønnes wrote: --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig +config DRM_SIMPLE_KMS_HELPER + tristate + depends on DRM

Re: [PATCH v2 6/6] drm: Add helper for simple display pipeline

2016-05-11 Thread Noralf Trønnes
Den 11.05.2016 19:09, skrev Daniel Vetter: On Wed, May 11, 2016 at 06:09:22PM +0200, Noralf Trønnes wrote: Provides helper functions for drivers that have a simple display pipeline. Plane, crtc and encoder are collapsed into one entity. Signed-off-by: Noralf Trønnes <nor...@tronnes.org>

Re: [PATCH v2 6/6] drm: Add helper for simple display pipeline

2016-05-11 Thread Noralf Trønnes
Den 11.05.2016 19:09, skrev Daniel Vetter: On Wed, May 11, 2016 at 06:09:22PM +0200, Noralf Trønnes wrote: Provides helper functions for drivers that have a simple display pipeline. Plane, crtc and encoder are collapsed into one entity. Signed-off-by: Noralf Trønnes Looks really nice, just

[PATCH v2 0/6] drm: Add various helpers for simple drivers

2016-05-11 Thread Noralf Trønnes
ocs: @funcs is optional, "negative error code", "This hook is optional." - Add checks to drm_simple_kms_plane_atomic_check() Noralf Trønnes (6): drm/fb-helper: Remove mention of CONFIG_FB_DEFERRED_IO in docs drm/fb-cma-helper: Hook up to DocBook and fix some docs drm/fb-c

[PATCH v2 0/6] drm: Add various helpers for simple drivers

2016-05-11 Thread Noralf Trønnes
ocs: @funcs is optional, "negative error code", "This hook is optional." - Add checks to drm_simple_kms_plane_atomic_check() Noralf Trønnes (6): drm/fb-helper: Remove mention of CONFIG_FB_DEFERRED_IO in docs drm/fb-cma-helper: Hook up to DocBook and fix some docs drm/fb-c

[PATCH v2 3/6] drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs()

2016-05-11 Thread Noralf Trønnes
Add drm_fb_cma_create_with_funcs() for drivers that need to set the dirty() callback. Cc: laurent.pinch...@ideasonboard.com Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- Changes since v1: - Expand docs drivers/gpu/drm/drm_fb_cma_helper.c | 31 +-- i

[PATCH v2 3/6] drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs()

2016-05-11 Thread Noralf Trønnes
Add drm_fb_cma_create_with_funcs() for drivers that need to set the dirty() callback. Cc: laurent.pinch...@ideasonboard.com Signed-off-by: Noralf Trønnes --- Changes since v1: - Expand docs drivers/gpu/drm/drm_fb_cma_helper.c | 31 +-- include/drm

[PATCH v2 2/6] drm/fb-cma-helper: Hook up to DocBook and fix some docs

2016-05-11 Thread Noralf Trønnes
Hook up fb_cma_helper to DocBook. Remove mention of CONFIG_FB_DEFERRED_IO in the docs, which was forgotten in the latest version of the deferred_io patch. Use & when referencing drm_mode_config_funcs in docs. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- Documentation/DocBoo

[PATCH v2 1/6] drm/fb-helper: Remove mention of CONFIG_FB_DEFERRED_IO in docs

2016-05-11 Thread Noralf Trønnes
This was forgotten to fixup in the latest version of the deferred_io patch which made FB_DEFERRED_IO mandatory. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/drm_fb_helper.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drive

[PATCH v2 1/6] drm/fb-helper: Remove mention of CONFIG_FB_DEFERRED_IO in docs

2016-05-11 Thread Noralf Trønnes
This was forgotten to fixup in the latest version of the deferred_io patch which made FB_DEFERRED_IO mandatory. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c

[PATCH v2 2/6] drm/fb-cma-helper: Hook up to DocBook and fix some docs

2016-05-11 Thread Noralf Trønnes
Hook up fb_cma_helper to DocBook. Remove mention of CONFIG_FB_DEFERRED_IO in the docs, which was forgotten in the latest version of the deferred_io patch. Use & when referencing drm_mode_config_funcs in docs. Signed-off-by: Noralf Trønnes --- Documentation/DocBook/gpu.tmpl

[PATCH v2 5/6] drm/atomic: Add drm_atomic_helper_best_encoder()

2016-05-11 Thread Noralf Trønnes
Add (struct drm_connector_helper_funcs *)->best_encoder callback helper for connectors that support exactly 1 encoder, statically determined at driver init time. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/drm_atomic_helper.c | 17 + in

[PATCH v2 5/6] drm/atomic: Add drm_atomic_helper_best_encoder()

2016-05-11 Thread Noralf Trønnes
Add (struct drm_connector_helper_funcs *)->best_encoder callback helper for connectors that support exactly 1 encoder, statically determined at driver init time. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_atomic_helper.c | 17 + include/drm/drm_atomic_helpe

[PATCH v2 6/6] drm: Add helper for simple display pipeline

2016-05-11 Thread Noralf Trønnes
Provides helper functions for drivers that have a simple display pipeline. Plane, crtc and encoder are collapsed into one entity. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- Changes since v1: - Add DOC header and add to gpu.tmpl - Fix docs: @funcs is optional, "negative

[PATCH v2 6/6] drm: Add helper for simple display pipeline

2016-05-11 Thread Noralf Trønnes
Provides helper functions for drivers that have a simple display pipeline. Plane, crtc and encoder are collapsed into one entity. Signed-off-by: Noralf Trønnes --- Changes since v1: - Add DOC header and add to gpu.tmpl - Fix docs: @funcs is optional, "negative error code",

[PATCH v2 4/6] drm/atomic: Don't skip drm_bridge_*() calls if !drm_encoder_helper_funcs

2016-05-11 Thread Noralf Trønnes
Don't skip drm_bridge_*() calls if encoder->helper_private is NULL. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/drm_atomic_helper.c | 39 - 1 file changed, 17 insertions(+), 22 deletions(-) diff --git a/driver

[PATCH v2 4/6] drm/atomic: Don't skip drm_bridge_*() calls if !drm_encoder_helper_funcs

2016-05-11 Thread Noralf Trønnes
Don't skip drm_bridge_*() calls if encoder->helper_private is NULL. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_atomic_helper.c | 39 - 1 file changed, 17 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/driv

Re: [PATCH 2/4] drm: Make drm_encoder_helper_funcs optional

2016-05-09 Thread Noralf Trønnes
Den 05.05.2016 18:23, skrev Daniel Vetter: On Thu, May 05, 2016 at 03:24:32PM +0200, Noralf Trønnes wrote: Make drm_encoder_helper_funcs and it's functions optional to avoid having dummy functions. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Please also update the ker

Re: [PATCH 2/4] drm: Make drm_encoder_helper_funcs optional

2016-05-09 Thread Noralf Trønnes
Den 05.05.2016 18:23, skrev Daniel Vetter: On Thu, May 05, 2016 at 03:24:32PM +0200, Noralf Trønnes wrote: Make drm_encoder_helper_funcs and it's functions optional to avoid having dummy functions. Signed-off-by: Noralf Trønnes Please also update the kerneldoc and mention

Re: [PATCH 3/4] drm: Add helper for simple display pipeline

2016-05-09 Thread Noralf Trønnes
Den 09.05.2016 16:46, skrev Daniel Vetter: On Thu, May 05, 2016 at 03:24:33PM +0200, Noralf Trønnes wrote: Provides helper functions for drivers that have a simple display pipeline. Plane, crtc and encoder are collapsed into one entity. Signed-off-by: Noralf Trønnes <nor...@tronnes.

Re: [PATCH 3/4] drm: Add helper for simple display pipeline

2016-05-09 Thread Noralf Trønnes
Den 09.05.2016 16:46, skrev Daniel Vetter: On Thu, May 05, 2016 at 03:24:33PM +0200, Noralf Trønnes wrote: Provides helper functions for drivers that have a simple display pipeline. Plane, crtc and encoder are collapsed into one entity. Signed-off-by: Noralf Trønnes +static int

Re: [PATCH 4/4] drm/panel: Add helper for simple panel connector

2016-05-07 Thread Noralf Trønnes
Den 07.05.2016 11:59, skrev Daniel Vetter: On Fri, May 6, 2016 at 9:45 PM, Noralf Trønnes <nor...@tronnes.org> wrote: In the discussion following the "no more fbdev drivers" call, someone pointed me to drm_panel. It had function hooks that I needed, so I buil

Re: [PATCH 4/4] drm/panel: Add helper for simple panel connector

2016-05-07 Thread Noralf Trønnes
Den 07.05.2016 11:59, skrev Daniel Vetter: On Fri, May 6, 2016 at 9:45 PM, Noralf Trønnes wrote: In the discussion following the "no more fbdev drivers" call, someone pointed me to drm_panel. It had function hooks that I needed, so I built tinydrm around it. If this is misusing

Re: [PATCH 4/4] drm/panel: Add helper for simple panel connector

2016-05-06 Thread Noralf Trønnes
Den 06.05.2016 16:43, skrev Thierry Reding: On Fri, May 06, 2016 at 04:34:08PM +0200, Noralf Trønnes wrote: Den 06.05.2016 16:15, skrev Thierry Reding: On Fri, May 06, 2016 at 04:08:16PM +0200, Daniel Vetter wrote: On Fri, May 06, 2016 at 04:03:47PM +0200, Thierry Reding wrote: On Thu, May

Re: [PATCH 4/4] drm/panel: Add helper for simple panel connector

2016-05-06 Thread Noralf Trønnes
Den 06.05.2016 16:43, skrev Thierry Reding: On Fri, May 06, 2016 at 04:34:08PM +0200, Noralf Trønnes wrote: Den 06.05.2016 16:15, skrev Thierry Reding: On Fri, May 06, 2016 at 04:08:16PM +0200, Daniel Vetter wrote: On Fri, May 06, 2016 at 04:03:47PM +0200, Thierry Reding wrote: On Thu, May

Re: [PATCH 4/4] drm/panel: Add helper for simple panel connector

2016-05-06 Thread Noralf Trønnes
Den 06.05.2016 16:15, skrev Thierry Reding: On Fri, May 06, 2016 at 04:08:16PM +0200, Daniel Vetter wrote: On Fri, May 06, 2016 at 04:03:47PM +0200, Thierry Reding wrote: On Thu, May 05, 2016 at 03:24:34PM +0200, Noralf Trønnes wrote: Add function to create a simple connector for a panel

Re: [PATCH 4/4] drm/panel: Add helper for simple panel connector

2016-05-06 Thread Noralf Trønnes
Den 06.05.2016 16:15, skrev Thierry Reding: On Fri, May 06, 2016 at 04:08:16PM +0200, Daniel Vetter wrote: On Fri, May 06, 2016 at 04:03:47PM +0200, Thierry Reding wrote: On Thu, May 05, 2016 at 03:24:34PM +0200, Noralf Trønnes wrote: Add function to create a simple connector for a panel

Re: [PATCH 4/4] drm/panel: Add helper for simple panel connector

2016-05-06 Thread Noralf Trønnes
Den 05.05.2016 19:03, skrev Daniel Vetter: On Thu, May 05, 2016 at 03:24:34PM +0200, Noralf Trønnes wrote: Add function to create a simple connector for a panel. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Like in the previous patch please also add a new section for the panel h

Re: [PATCH 4/4] drm/panel: Add helper for simple panel connector

2016-05-06 Thread Noralf Trønnes
Den 05.05.2016 19:03, skrev Daniel Vetter: On Thu, May 05, 2016 at 03:24:34PM +0200, Noralf Trønnes wrote: Add function to create a simple connector for a panel. Signed-off-by: Noralf Trønnes Like in the previous patch please also add a new section for the panel helpers to gpu.tmpl. I don't

Re: [PATCH 1/4] drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs()

2016-05-06 Thread Noralf Trønnes
Den 05.05.2016 18:27, skrev Daniel Vetter: On Thu, May 05, 2016 at 03:24:31PM +0200, Noralf Trønnes wrote: Add drm_fb_cma_create_with_funcs() for drivers that need to set the dirty() callback. Cc: laurent.pinch...@ideasonboard.com Signed-off-by: Noralf Trønnes <nor...@tronnes.

Re: [PATCH 1/4] drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs()

2016-05-06 Thread Noralf Trønnes
Den 05.05.2016 18:27, skrev Daniel Vetter: On Thu, May 05, 2016 at 03:24:31PM +0200, Noralf Trønnes wrote: Add drm_fb_cma_create_with_funcs() for drivers that need to set the dirty() callback. Cc: laurent.pinch...@ideasonboard.com Signed-off-by: Noralf Trønnes --- drivers/gpu/drm

[PATCH 4/4] drm/panel: Add helper for simple panel connector

2016-05-05 Thread Noralf Trønnes
Add function to create a simple connector for a panel. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/drm_panel_helper.c | 117 + drivers/gpu/drm/panel/Kconfig | 7 +++ inclu

[PATCH 4/4] drm/panel: Add helper for simple panel connector

2016-05-05 Thread Noralf Trønnes
Add function to create a simple connector for a panel. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/drm_panel_helper.c | 117 + drivers/gpu/drm/panel/Kconfig | 7 +++ include/drm/drm_panel_helper.h

[PATCH 2/4] drm: Make drm_encoder_helper_funcs optional

2016-05-05 Thread Noralf Trønnes
Make drm_encoder_helper_funcs and it's functions optional to avoid having dummy functions. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/drm_atomic_helper.c | 11 -- drivers/gpu/drm/drm_crtc_helper.c | 41 + 2 files c

[PATCH 1/4] drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs()

2016-05-05 Thread Noralf Trønnes
Add drm_fb_cma_create_with_funcs() for drivers that need to set the dirty() callback. Cc: laurent.pinch...@ideasonboard.com Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/drm_fb_cma_helper.c | 29 +++-- include/drm/drm_fb_cma_helper.h

[PATCH 2/4] drm: Make drm_encoder_helper_funcs optional

2016-05-05 Thread Noralf Trønnes
Make drm_encoder_helper_funcs and it's functions optional to avoid having dummy functions. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_atomic_helper.c | 11 -- drivers/gpu/drm/drm_crtc_helper.c | 41 + 2 files changed, 42 insertions(+), 10

[PATCH 1/4] drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs()

2016-05-05 Thread Noralf Trønnes
Add drm_fb_cma_create_with_funcs() for drivers that need to set the dirty() callback. Cc: laurent.pinch...@ideasonboard.com Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_cma_helper.c | 29 +++-- include/drm/drm_fb_cma_helper.h | 3 +++ 2 files changed, 26

[PATCH 0/4] drm: Add various helpers for simple drivers

2016-05-05 Thread Noralf Trønnes
. - drm_panel_connector_create() Create a simple connector for a panel. Noralf Trønnes (4): drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs() drm: Make drm_encoder_helper_funcs optional drm: Add helper for simple display pipeline drm/panel: Add helper for simple panel connector

[PATCH 0/4] drm: Add various helpers for simple drivers

2016-05-05 Thread Noralf Trønnes
. - drm_panel_connector_create() Create a simple connector for a panel. Noralf Trønnes (4): drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs() drm: Make drm_encoder_helper_funcs optional drm: Add helper for simple display pipeline drm/panel: Add helper for simple panel connector

[PATCH 3/4] drm: Add helper for simple display pipeline

2016-05-05 Thread Noralf Trønnes
Provides helper functions for drivers that have a simple display pipeline. Plane, crtc and encoder are collapsed into one entity. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- drivers/gpu/drm/Kconfig | 7 ++ drivers/gpu/drm/Makefile| 1 + drive

[PATCH 3/4] drm: Add helper for simple display pipeline

2016-05-05 Thread Noralf Trønnes
Provides helper functions for drivers that have a simple display pipeline. Plane, crtc and encoder are collapsed into one entity. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/Kconfig | 7 ++ drivers/gpu/drm/Makefile| 1 + drivers/gpu/drm

Re: [PATCH v4 3/7] drm/fb-helper: Add fb_deferred_io support

2016-04-29 Thread Noralf Trønnes
Den 29.04.2016 14:50, skrev Tomi Valkeinen: Hi, On 28/04/16 18:18, Noralf Trønnes wrote: This adds deferred io support to drm_fb_helper. The fbdev framebuffer changes are flushed using the callback (struct drm_framebuffer *)->funcs->dirty() by a dedicated worker ensuring that it alway

Re: [PATCH v4 3/7] drm/fb-helper: Add fb_deferred_io support

2016-04-29 Thread Noralf Trønnes
Den 29.04.2016 14:50, skrev Tomi Valkeinen: Hi, On 28/04/16 18:18, Noralf Trønnes wrote: This adds deferred io support to drm_fb_helper. The fbdev framebuffer changes are flushed using the callback (struct drm_framebuffer *)->funcs->dirty() by a dedicated worker ensuring that it alway

[PATCH v4 0/7] drm: Add fbdev deferred io support to helpers

2016-04-28 Thread Noralf Trønnes
ic context (spin_lock_irqsave) - Export fb_deferred_io_mmap() - Add some more documentation - Add qxl and udl patches Noralf Trønnes (7): drm/udl: Change drm_fb_helper_sys_*() calls to sys_*() drm/qxl: Change drm_fb_helper_sys_*() calls to sys_*() drm/fb-helper: Add fb_deferred_io support fbdev

[PATCH v4 3/7] drm/fb-helper: Add fb_deferred_io support

2016-04-28 Thread Noralf Trønnes
This adds deferred io support to drm_fb_helper. The fbdev framebuffer changes are flushed using the callback (struct drm_framebuffer *)->funcs->dirty() by a dedicated worker ensuring that it always runs in process context. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Reviewe

[PATCH v4 4/7] fbdev: fb_defio: Export fb_deferred_io_mmap

2016-04-28 Thread Noralf Trønnes
t to nocache for instance, so I think the safest bet is to do this in the driver and not in the fbdev core. And we can't call fb_pgprotect() from fb_deferred_io_mmap() either because we don't have access to the file pointer that powerpc needs. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> ---

[PATCH v4 0/7] drm: Add fbdev deferred io support to helpers

2016-04-28 Thread Noralf Trønnes
ic context (spin_lock_irqsave) - Export fb_deferred_io_mmap() - Add some more documentation - Add qxl and udl patches Noralf Trønnes (7): drm/udl: Change drm_fb_helper_sys_*() calls to sys_*() drm/qxl: Change drm_fb_helper_sys_*() calls to sys_*() drm/fb-helper: Add fb_deferred_io support fbdev

[PATCH v4 3/7] drm/fb-helper: Add fb_deferred_io support

2016-04-28 Thread Noralf Trønnes
This adds deferred io support to drm_fb_helper. The fbdev framebuffer changes are flushed using the callback (struct drm_framebuffer *)->funcs->dirty() by a dedicated worker ensuring that it always runs in process context. Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter --- C

[PATCH v4 4/7] fbdev: fb_defio: Export fb_deferred_io_mmap

2016-04-28 Thread Noralf Trønnes
t to nocache for instance, so I think the safest bet is to do this in the driver and not in the fbdev core. And we can't call fb_pgprotect() from fb_deferred_io_mmap() either because we don't have access to the file pointer that powerpc needs. Signed-off-by: Noralf Trønnes --- Changes since v1: - E

[PATCH v4 1/7] drm/udl: Change drm_fb_helper_sys_*() calls to sys_*()

2016-04-28 Thread Noralf Trønnes
rectly. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch> --- drivers/gpu/drm/udl/udl_fb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/udl/udl_fb.c b/drivers/gpu/drm/udl/udl_fb.c inde

[PATCH v4 5/7] drm/fb-cma-helper: Add fb_deferred_io support

2016-04-28 Thread Noralf Trønnes
e hook to set a driver provided (struct drm_framebuffer_funcs *)->dirty() function. Cc: laurent.pinch...@ideasonboard.com Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- Changes since v2: - FB_DEFERRED_IO is now always selected by DRM_KMS_FB_HELPER, ifdef removed

[PATCH v4 7/7] drm/udl: Use drm_fb_helper deferred_io support

2016-04-28 Thread Noralf Trønnes
Use the fbdev deferred io support in drm_fb_helper. The (struct fb_ops *)->fb_{fillrect,copyarea,imageblit} functions will now schedule a worker instead of being flushed directly like it was previously (recorded when in atomic). This patch has only been compile tested. Signed-off-by: Nor

[PATCH v4 1/7] drm/udl: Change drm_fb_helper_sys_*() calls to sys_*()

2016-04-28 Thread Noralf Trønnes
rectly. Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter --- drivers/gpu/drm/udl/udl_fb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/udl/udl_fb.c b/drivers/gpu/drm/udl/udl_fb.c index fd1eb9d..a52de2f 100644 --- a/drivers/gpu/drm/udl/udl_fb.c

[PATCH v4 5/7] drm/fb-cma-helper: Add fb_deferred_io support

2016-04-28 Thread Noralf Trønnes
e hook to set a driver provided (struct drm_framebuffer_funcs *)->dirty() function. Cc: laurent.pinch...@ideasonboard.com Signed-off-by: Noralf Trønnes --- Changes since v2: - FB_DEFERRED_IO is now always selected by DRM_KMS_FB_HELPER, ifdef removed drivers/gpu/drm/drm_fb_cma_helpe

[PATCH v4 7/7] drm/udl: Use drm_fb_helper deferred_io support

2016-04-28 Thread Noralf Trønnes
Use the fbdev deferred io support in drm_fb_helper. The (struct fb_ops *)->fb_{fillrect,copyarea,imageblit} functions will now schedule a worker instead of being flushed directly like it was previously (recorded when in atomic). This patch has only been compile tested. Signed-off-by: Nor

[PATCH v4 2/7] drm/qxl: Change drm_fb_helper_sys_*() calls to sys_*()

2016-04-28 Thread Noralf Trønnes
rectly. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch> --- drivers/gpu/drm/qxl/qxl_fb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_fb.c b/drivers/gpu/drm/qxl/qxl_fb.c inde

[PATCH v4 2/7] drm/qxl: Change drm_fb_helper_sys_*() calls to sys_*()

2016-04-28 Thread Noralf Trønnes
rectly. Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter --- drivers/gpu/drm/qxl/qxl_fb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_fb.c b/drivers/gpu/drm/qxl/qxl_fb.c index bb7ce07..3f7c543 100644 --- a/drivers/gpu/drm/qxl/qxl_fb.c

[PATCH v4 6/7] drm/qxl: Use drm_fb_helper deferred_io support

2016-04-28 Thread Noralf Trønnes
Use the fbdev deferred io support in drm_fb_helper which mirrors the one qxl has had. This patch has only been compile tested. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch> --- Changes since v2: - The drm_clip_rect_{width/heigh

[PATCH v4 6/7] drm/qxl: Use drm_fb_helper deferred_io support

2016-04-28 Thread Noralf Trønnes
Use the fbdev deferred io support in drm_fb_helper which mirrors the one qxl has had. This patch has only been compile tested. Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter --- Changes since v2: - The drm_clip_rect_{width/height} functions are dropped, so open code it Changes since

Re: [PATCH v3 0/7] drm: Add fbdev deferred io support to helpers

2016-04-27 Thread Noralf Trønnes
Den 27.04.2016 21:24, skrev Daniel Vetter: On Wed, Apr 27, 2016 at 08:16:29PM +0200, Noralf Trønnes wrote: This patchset adds fbdev deferred io support to drm_fb_helper and drm_fb_cma_helper. It channels fbdev mmap and fb_{write,fillrect,copyarea,imageblit} damage through the (struct

Re: [PATCH v3 0/7] drm: Add fbdev deferred io support to helpers

2016-04-27 Thread Noralf Trønnes
Den 27.04.2016 21:24, skrev Daniel Vetter: On Wed, Apr 27, 2016 at 08:16:29PM +0200, Noralf Trønnes wrote: This patchset adds fbdev deferred io support to drm_fb_helper and drm_fb_cma_helper. It channels fbdev mmap and fb_{write,fillrect,copyarea,imageblit} damage through the (struct

Re: [PATCH v3 3/7] drm/fb-helper: Add fb_deferred_io support

2016-04-27 Thread Noralf Trønnes
Den 27.04.2016 21:20, skrev Daniel Vetter: On Wed, Apr 27, 2016 at 08:16:32PM +0200, Noralf Trønnes wrote: This adds deferred io support to drm_fb_helper. The fbdev framebuffer changes are flushed using the callback (struct drm_framebuffer *)->funcs->dirty() by a dedicated worker en

Re: [PATCH v3 3/7] drm/fb-helper: Add fb_deferred_io support

2016-04-27 Thread Noralf Trønnes
Den 27.04.2016 21:20, skrev Daniel Vetter: On Wed, Apr 27, 2016 at 08:16:32PM +0200, Noralf Trønnes wrote: This adds deferred io support to drm_fb_helper. The fbdev framebuffer changes are flushed using the callback (struct drm_framebuffer *)->funcs->dirty() by a dedicated worker en

[PATCH v3 0/7] drm: Add fbdev deferred io support to helpers

2016-04-27 Thread Noralf Trønnes
ip_rect functions in drm_rect.{h,c} - Take into account that (struct fb_ops *)->fb_{write,...}() can be called from atomic context (spin_lock_irqsave) - Export fb_deferred_io_mmap() - Add some more documentation - Add qxl and udl patches Noralf Trønnes (7): drm/udl: Change drm_fb_helper_sys_*() cal

[PATCH v3 6/7] drm/qxl: Use drm_fb_helper deferred_io support

2016-04-27 Thread Noralf Trønnes
Use the fbdev deferred io support in drm_fb_helper which mirrors the one qxl has had. This patch has only been compile tested. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- Changes since v2: - The drm_clip_rect_{width/height} functions are dropped, so open code it Changes si

[PATCH v3 0/7] drm: Add fbdev deferred io support to helpers

2016-04-27 Thread Noralf Trønnes
ip_rect functions in drm_rect.{h,c} - Take into account that (struct fb_ops *)->fb_{write,...}() can be called from atomic context (spin_lock_irqsave) - Export fb_deferred_io_mmap() - Add some more documentation - Add qxl and udl patches Noralf Trønnes (7): drm/udl: Change drm_fb_helper_sys_*() cal

[PATCH v3 6/7] drm/qxl: Use drm_fb_helper deferred_io support

2016-04-27 Thread Noralf Trønnes
Use the fbdev deferred io support in drm_fb_helper which mirrors the one qxl has had. This patch has only been compile tested. Signed-off-by: Noralf Trønnes --- Changes since v2: - The drm_clip_rect_{width/height} functions are dropped, so open code it Changes since v1: - Add FIXME about

<    1   2   3   4   5   6   7   8   9   >