Re: randconfig build error with next-20141121, in drivers/gpu/drm/amd/amdkfd/kfd_doorbell.c

2014-11-21 Thread Oded Gabbay
On 11/21/2014 07:04 PM, Jim Davis wrote: > Building with the attached random configuration file, > > drivers/gpu/drm/amd/amdkfd/kfd_doorbell.c: In function ‘kfd_doorbell_init’: > drivers/gpu/drm/amd/amdkfd/kfd_doorbell.c:97:2: error: implicit > declaration of function ‘ioremap’ >

[PATCH] amdkfd: explicitely include io.h in kfd_doorbell.c

2014-11-21 Thread Oded Gabbay
This patch fixes a compilation error when using certain configuration by including the file io.h in kfd_doorbell.c Signed-off-by: Oded Gabbay --- drivers/gpu/drm/amd/amdkfd/kfd_doorbell.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_doorbell.c b/drivers

[PATCH] amdkfd: Remove DRM_AMDGPU dependency from Kconfig

2014-11-21 Thread Oded Gabbay
Signed-off-by: Oded Gabbay --- drivers/gpu/drm/amd/amdkfd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig b/drivers/gpu/drm/amd/amdkfd/Kconfig index e13c67c..8dfac37 100644 --- a/drivers/gpu/drm/amd/amdkfd/Kconfig +++ b/drivers/gpu

[PATCH resend] amdkfd: Remove DRM_AMDGPU dependency from Kconfig

2014-11-21 Thread Oded Gabbay
This patch removes the dependency of amdkfd upon DRM_AMDGPU symbol in amdkfd's Kconfig file. This is done because amdgpu driver is not yet upstreamed and therefore, DRM_AMDGPU symbol is not present in any Kconfig file. Reviewed-by: Alex Deucher Signed-off-by: Oded Gabbay --- drivers/gpu/drm

[PULL] amdkfd-next-3.19

2014-11-21 Thread Oded Gabbay
(2014-11-21 22:55:31 +0200) Alexey Skidanov (1): amdkfd: Instead of using get function, use container_of Jay Cornwall (1): amdkfd: Fix memory leak on process deregistration Oded Gabbay (10): amdkfd: Fix sparse warnings

Re: [PATCH 1/2] mm: export find_extend_vma and handle_mm_fault for driver use

2014-10-29 Thread Oded Gabbay
Hi Joerg and Jesse, I tested our amdkfd driver with your patches applied (kernel 3.17.1). I run OpenCL tests, Aparapi/Sumatra (Java) and OpenMP All tests passed and I didn't see any kernel error messages. So: Tested-by: Oded Gabbay Oded On 10/27/2014 05:35 PM, Jesse Barnes wrote: Thanks

Re: [PATCH 0/2] Change order of linkage in kernel makefiles for amdkfd

2015-01-08 Thread Oded Gabbay
, 2014 at 10:34:32AM +0100, Christian König wrote: Am 29.12.2014 um 09:16 schrieb Laurent Pinchart: Hi Oded, On Sunday 28 December 2014 13:36:50 Oded Gabbay wrote: On 12/26/2014 11:19 AM, Laurent Pinchart wrote: On Thursday 25 December 2014 14:20:59 Thierry Reding wrote: On Mon, Dec 22, 2014

[PULL resend] amdkfd-v6

2014-11-18 Thread Oded Gabbay
ger module amdkfd: Add process queue manager module amdkfd: Add device queue manager module Evgeny Pinchuk (2): amdkfd: Add topology module to amdkfd amdkfd: Implement the Get Clock Counters IOCTL Oded Gabbay (12): drm/radeon: reduce number of free VMIDs and pipes in KV

Re: [LKP] [drm/radeon] BUG: unable to handle kernel paging request at 03200000

2014-12-18 Thread Oded Gabbay
On 12/18/2014 10:17 AM, Huang Ying wrote: FYI, we noticed the below changes on commit e28740ece34d314002b1ddfa14e8fb7c7b909489 ("drm/radeon: Add radeon <--> amdkfd interface") +--+++ | |

Re: [LKP] [drm/radeon] BUG: unable to handle kernel paging request at 03200000

2014-12-18 Thread Oded Gabbay
On 12/18/2014 10:26 AM, Huang Ying wrote: On Thu, 2014-12-18 at 10:20 +0200, Oded Gabbay wrote: On 12/18/2014 10:17 AM, Huang Ying wrote: FYI, we noticed the below changes on commit e28740ece34d314002b1ddfa14e8fb7c7b909489 ("drm/radeon: Add radeon <--> amdkfd

Re: [LKP] [drm/radeon] BUG: unable to handle kernel paging request at 03200000

2014-12-18 Thread Oded Gabbay
On 12/18/2014 10:26 AM, Huang Ying wrote: On Thu, 2014-12-18 at 10:20 +0200, Oded Gabbay wrote: On 12/18/2014 10:17 AM, Huang Ying wrote: FYI, we noticed the below changes on commit e28740ece34d314002b1ddfa14e8fb7c7b909489 ("drm/radeon: Add radeon <--> amdkfd

Re: [LKP] [drm/radeon] BUG: unable to handle kernel paging request at 03200000

2014-12-18 Thread Oded Gabbay
On 12/18/2014 01:42 PM, Oded Gabbay wrote: On 12/18/2014 10:26 AM, Huang Ying wrote: On Thu, 2014-12-18 at 10:20 +0200, Oded Gabbay wrote: On 12/18/2014 10:17 AM, Huang Ying wrote: FYI, we noticed the below changes on commit e28740ece34d314002b1ddfa14e8fb7c7b909489 ("drm/radeon

[PATCH] iommu/amd: Track when amd_iommu_v2 init is complete

2014-12-20 Thread Oded Gabbay
of amd_iommu_v2 exported functions _before_ amd_iommu_v2 is loaded, than that function will fail, and as a result, the calling module may fail as well. Note that when the two modules are compiled as modules, this situation can't occur as the kernel enforces the order of loading. Signed-off-by: Oded Gabbay

Re: [PATCH] iommu/amd: Track when amd_iommu_v2 init is complete

2014-12-20 Thread Oded Gabbay
On 12/20/2014 10:12 PM, Oded Gabbay wrote: > This patch adds a new exported function to amd_iommu_v2, which returns 1 if > the > amd_iommu_v2 initialization function has completed, and 0 otherwise. > > This is necessary for the case when amd_iommu_v2 is compiled inside the

[PATCH 3/3] amdkfd: Use workqueue for GPU init

2014-12-20 Thread Oded Gabbay
been loaded. Then, it will call the relevant amdkfd function. The workqueue is defined per kfd_dev structure (per GPU). Signed-off-by: Oded Gabbay --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 72 +++-- drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 2 + 2 files changed

[PATCH 0/3] Use workqueue for device init in amdkfd

2014-12-20 Thread Oded Gabbay
successfully. Other methods for detection were checked, e.g. module_is_live() and MODULE_SOFTDEP(), but they were proved not to work when all modules are compiled in the kernel image (which is the problematic scenario to begin with). Oded Oded Gabbay (3): amdkfd: Don't clear *kfd2kgd

[PATCH 2/3] amdkfd: Track when amdkfd init is complete

2014-12-20 Thread Oded Gabbay
whether amdkfd has already been initialized. Note that when the two modules are compiled as modules, this situation can't occur as the kernel enforces the order of loading. Signed-off-by: Oded Gabbay --- drivers/gpu/drm/amd/amdkfd/kfd_module.c | 9 + drivers/gpu/drm/amd/amdkfd/kfd_priv.h

[PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init

2014-12-20 Thread Oded Gabbay
. Signed-off-by: Oded Gabbay --- drivers/gpu/drm/amd/amdkfd/kfd_module.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_module.c b/drivers/gpu/drm/amd/amdkfd/kfd_module.c index 95d5af1..236562f 100644 --- a/drivers/gpu/drm/amd/amdkfd

Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init

2014-12-21 Thread Oded Gabbay
On 12/20/2014 11:25 PM, Greg KH wrote: On Sat, Dec 20, 2014 at 10:46:12PM +0200, Oded Gabbay wrote: When amdkfd and radeon are compiled inside the kernel image (not as modules), radeon will load before amdkfd and will set *kfd2kgd to its interface structure. Therefore, we must not set

Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init

2014-12-21 Thread Oded Gabbay
On 12/21/2014 01:27 PM, Christian König wrote: Am 20.12.2014 um 21:46 schrieb Oded Gabbay: When amdkfd and radeon are compiled inside the kernel image (not as modules), radeon will load before amdkfd and will set *kfd2kgd to its interface structure. Therefore, we must not set *kfd2kgd to NULL

Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init

2014-12-21 Thread Oded Gabbay
On 12/21/2014 02:19 PM, Christian König wrote: Am 21.12.2014 um 12:34 schrieb Oded Gabbay: On 12/21/2014 01:27 PM, Christian König wrote: Am 20.12.2014 um 21:46 schrieb Oded Gabbay: When amdkfd and radeon are compiled inside the kernel image (not as modules), radeon will load before

Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init

2014-12-21 Thread Oded Gabbay
On 12/21/2014 03:06 PM, Oded Gabbay wrote: On 12/21/2014 02:19 PM, Christian König wrote: Am 21.12.2014 um 12:34 schrieb Oded Gabbay: On 12/21/2014 01:27 PM, Christian König wrote: Am 20.12.2014 um 21:46 schrieb Oded Gabbay: When amdkfd and radeon are compiled inside the kernel image

Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init

2014-12-21 Thread Oded Gabbay
. Oded Christian. Am 21.12.2014 um 14:24 schrieb Oded Gabbay: On 12/21/2014 03:06 PM, Oded Gabbay wrote: On 12/21/2014 02:19 PM, Christian König wrote: Am 21.12.2014 um 12:34 schrieb Oded Gabbay: On 12/21/2014 01:27 PM, Christian König wrote: Am 20.12.2014 um 21:46 schrieb

[PATCH v4 01/23] drm/radeon: reduce number of free VMIDs and pipes in KV

2014-09-24 Thread Oded Gabbay
for static vmid allocation in radeon Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/cik.c | 48 +-- drivers/gpu/drm/radeon/cikd.h | 2 ++ 2 files changed, 26 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm

[PATCH v4 04/23] drm/radeon: adding synchronization for GRBM GFX

2014-09-24 Thread Oded Gabbay
Implementing a lock for selecting and accessing shader engines and arrays. This lock will make sure that radeon and amdkfd are not colliding when accessing shader engines and arrays with GRBM_GFX_INDEX register. Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/cik.c | 26

[PATCH v4 00/23] AMDKFD Kernel Driver

2014-09-24 Thread Oded Gabbay
/update queue IOCTLs Evgeny Pinchuk (2): amdkfd: Add topology module to amdkfd amdkfd: Implement the Get Clock Counters IOCTL Oded Gabbay (9): drm/radeon: reduce number of free VMIDs and pipes in KV drm/radeon/cik: Don't touch int of pipes 1-7 drm/radeon: Report doorbell configuration

[PATCH v4 03/23] drm/radeon: Report doorbell configuration to amdkfd

2014-09-24 Thread Oded Gabbay
radeon and amdkfd share the doorbell aperture. radeon sets it up, takes the doorbells required for its own rings and reports the setup to amdkfd. radeon reserved doorbells are at the start of the doorbell aperture. Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/radeon.h| 4

[PATCH v4 02/23] drm/radeon/cik: Don't touch int of pipes 1-7

2014-09-24 Thread Oded Gabbay
amdkfd should set interrupts for pipes 1-7. Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/cik.c | 71 +--- 1 file changed, 1 insertion(+), 70 deletions(-) diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c index 1530e37

[PATCH v4 06/23] Update MAINTAINERS and CREDITS files with amdkfd info

2014-09-24 Thread Oded Gabbay
Signed-off-by: Oded Gabbay --- CREDITS | 7 +++ MAINTAINERS | 10 ++ 2 files changed, 17 insertions(+) diff --git a/CREDITS b/CREDITS index bb62788..c56d8aa 100644 --- a/CREDITS +++ b/CREDITS @@ -1197,6 +1197,13 @@ S: R. Tocantins, 89 - Cristo Rei S: 80050-430 - Curitiba

[PATCH v4 05/23] drm/radeon: Add radeon <--> amdkfd interface

2014-09-24 Thread Oded Gabbay
linux macros Add documentation for the interface v4: Change ptr field type in kgd_mem from uint32_t* to void* to match to type that is returned by radeon_sa_bo_cpu_addr Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/Makefile | 1 + drivers/gpu/drm/radeon/cik.c| 9

[PATCH v4 11/23] amdkfd: Add binding/unbinding calls to amd_iommu driver

2014-09-24 Thread Oded Gabbay
of the patchset. Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/kfd_device.c | 86 - drivers/gpu/drm/radeon/amdkfd/kfd_priv.h| 1 + drivers/gpu/drm/radeon/amdkfd/kfd_process.c | 12 3 files changed, 98 insertions(+), 1 deletion(-) diff --git

[PATCH v4 14/23] amdkfd: Add kernel queue module

2014-09-24 Thread Oded Gabbay
functions v4: Fixed a miscalculation in kernel queue wrapping Signed-off-by: Ben Goz Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/Makefile | 3 +- .../drm/radeon/amdkfd/kfd_device_queue_manager.h | 101 +++ drivers/gpu/drm/radeon/amdkfd/kfd_kernel_queue.c | 330

[PATCH v4 08/23] amdkfd: Add amdkfd skeleton driver

2014-09-24 Thread Oded Gabbay
This patch adds the amdkfd skeleton driver. The driver does nothing except define a /dev/kfd device. It returns -ENODEV on all amdkfd IOCTLs. v3: Move bool field to the end of structure, removed the pmc ioctls and added a meaningful error message for ioctl error. Signed-off-by: Oded Gabbay

[PATCH v4 18/23] amdkfd: Add device queue manager module

2014-09-24 Thread Oded Gabbay
use the size is specified as (log2(size_dwords)-1). The previous calculation assumed the size was specified in bytes, which caused interference between EOP queues when multiple MEC pipelines were active. Signed-off-by: Ben Goz Signed-off-by: Jay Cornwall Signed-off-by: Oded Gabbay --- drivers/gpu/drm/r

[PATCH v4 15/23] amdkfd: Add module parameter of scheduling policy

2014-09-24 Thread Oded Gabbay
documentation Signed-off-by: Ben Goz Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/kfd_module.c | 12 drivers/gpu/drm/radeon/amdkfd/kfd_priv.h | 29 + 2 files changed, 41 insertions(+) diff --git a/drivers/gpu/drm/radeon/amdkfd/kfd_module.c b

[PATCH v4 17/23] amdkfd: Add process queue manager module

2014-09-24 Thread Oded Gabbay
process limitation Signed-off-by: Ben Goz Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/Makefile | 3 +- drivers/gpu/drm/radeon/amdkfd/kfd_priv.h | 17 + drivers/gpu/drm/radeon/amdkfd/kfd_process.c| 16 + .../drm/radeon/amdkfd

[PATCH v4 13/23] amdkfd: Add mqd_manager module

2014-09-24 Thread Oded Gabbay
the dispatched workload context kept consistent without any interrupts. Signed-off-by: Ben Goz Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/Makefile | 2 +- drivers/gpu/drm/radeon/amdkfd/cik_regs.h| 221 + drivers/gpu/drm/radeon/amdkfd/kfd_mqd_manager.c

[PATCH v4 16/23] amdkfd: Add packet manager module

2014-09-24 Thread Oded Gabbay
documentation Signed-off-by: Ben Goz Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/Makefile | 2 +- drivers/gpu/drm/radeon/amdkfd/kfd_packet_manager.c | 495 + drivers/gpu/drm/radeon/amdkfd/kfd_priv.h | 72 +++ 3 files changed, 568 insertions

[PATCH v4 20/23] amdkfd: Implement the create/destroy/update queue IOCTLs

2014-09-24 Thread Oded Gabbay
fixed the check of the ring size argument. Signed-off-by: Ben Goz Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/kfd_chardev.c| 191 - drivers/gpu/drm/radeon/amdkfd/kfd_priv.h | 8 + .../drm/radeon/amdkfd/kfd_process_queue_manager.c | 5

[PATCH v4 23/23] amdkfd: Implement the Get Process Aperture IOCTL

2014-09-24 Thread Oded Gabbay
From: Alexey Skidanov v3: Fixed debug messages Signed-off-by: Alexey Skidanov Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/kfd_chardev.c | 47 - drivers/gpu/drm/radeon/amdkfd/kfd_priv.h| 5 +++ 2 files changed, 51 insertions(+), 1 deletion

[PATCH v4 21/23] amdkfd: Implement the Set Memory Policy IOCTL

2014-09-24 Thread Oded Gabbay
From: Andrew Lewycky Signed-off-by: Andrew Lewycky Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/kfd_chardev.c | 51 - 1 file changed, 50 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/amdkfd/kfd_chardev.c b/drivers/gpu/drm/radeon

[PATCH v4 12/23] amdkfd: Add queue module

2014-09-24 Thread Oded Gabbay
From: Ben Goz The queue module enables allocating and initializing queues uniformly. v3: Removed typedef and redundant memset call. Broke long pr_debug print to one liners and Added documentation. Signed-off-by: Ben Goz Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/Makefile

[PATCH v4 22/23] amdkfd: Implement the Get Clock Counters IOCTL

2014-09-24 Thread Oded Gabbay
From: Evgeny Pinchuk Signed-off-by: Evgeny Pinchuk Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/kfd_chardev.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/amdkfd/kfd_chardev.c b/drivers/gpu/drm/radeon

[PATCH v4 10/23] amdkfd: Add basic modules to amdkfd

2014-09-24 Thread Oded Gabbay
to support mmap of doorbell pages from userspace Added documentation for apertures v4: Replaced RCU by SRCU for kfd_process list management Signed-off-by: Andrew Lewycky Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/Makefile | 4 +- drivers/gpu/drm/radeon/amdkfd

[PATCH v4 07/23] amdkfd: Add IOCTL set definitions of amdkfd

2014-09-24 Thread Oded Gabbay
of the amdkfd device - KFD_IOC_UPDATE_QUEUE: Updates configuration of an existing usermode queue v3: Remove pragma pack and pmc ioctls. Added parameter for doorbell offset and a comment on counters Signed-off-by: Oded Gabbay --- include/uapi/linux/kfd_ioctl.h | 123

[PATCH v4 09/23] amdkfd: Add topology module to amdkfd

2014-09-24 Thread Oded Gabbay
/ | |--- properties |--- 3/ | |--- properties Signed-off-by: Evgeny Pinchuk Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/Makefile |2 +- drivers

[PATCH v4 19/23] amdkfd: Add interrupt handling module

2014-09-24 Thread Oded Gabbay
interrupts because we have no back-pressure to the hardware. v3: Change device init Made sure spin lock is taken only if init is complete Moved bool field to the end of the structure Signed-off-by: Andrew Lewycky Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/Makefile| 3

Re: [PATCH v4 05/23] drm/radeon: Add radeon <--> amdkfd interface

2014-09-25 Thread Oded Gabbay
On 24/09/14 23:45, Oded Gabbay wrote: > This patch adds the interface between the radeon driver and the amdkfd driver. > The interface implementation is contained in radeon_kfd.c and radeon_kfd.h. > > The interface itself is represented by a pointer to struct > kfd_dev. The poi

Re: [PATCH v3 00/23] AMDKFD Kernel Driver

2014-09-26 Thread Oded Gabbay
On 05/08/14 21:35, Gabbay, Oded wrote: > > > On 05/08/14 20:11, David Herrmann wrote: >> Hi >> >> On Tue, Aug 5, 2014 at 5:30 PM, Oded Gabbay wrote: >>> Hi, >>> Here is the v3 patch set of amdkfd. >>> >>> This version contains

[PATCH] drm/amdkfd: Initialize only amdkfd's assigned pipelines

2015-04-04 Thread Oded Gabbay
because it calls BUG_ON() Signed-off-by: Oded Gabbay Cc: sta...@vger.kernel.org Tested-by: Michel Dänzer --- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b

Re: Linux XIA - merge proposal

2015-03-18 Thread Oded Gabbay
On 03/17/2015 02:25 PM, Michel Machado wrote: On 03/15/2015 05:37 AM, Greg KH wrote: On Fri, Mar 13, 2015 at 11:26:46AM -0400, Michel Machado wrote: On 03/10/2015 01:01 PM, Bjorn Helgaas wrote: From my point of view (far outside the networking world and completely incompetent to judge the

Re: [RFC][PATCH] amdkfd: Convert timestamping to use 64bit time accessors

2015-03-19 Thread Oded Gabbay
On 03/13/2015 01:24 PM, Arnd Bergmann wrote: On Thursday 12 March 2015 10:23:40 John Stultz wrote: Convert the timestamping in the amdkfd driver to use a timespec64 and 64bit time accessors. Cc: Arnd Bergmann Cc: Oded Gabbay Cc: David Airlie Cc: dri-de...@lists.freedesktop.org Signed-off

[PATCH] drm/amdkfd: destroy mqd when destroying kernel queue

2015-04-12 Thread Oded Gabbay
Cc: sta...@vger.kernel.org Signed-off-by: Oded Gabbay --- drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c b/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c index

[PATCH] radeon: Update Kaveri MEC firmware to #396

2015-03-13 Thread Oded Gabbay
This patch updates the Kaveri MEC firmware to #396 (from #391). The MEC firmware is mainly used for amdkfd - AMD's HSA Linux kernel driver. Signed-off-by: Oded Gabbay --- radeon/kaveri_mec.bin | Bin 17024 -> 17024 bytes radeon/kaveri_mec2.bin | Bin 17024 -> 17024 bytes 2 files chan

Re: Linux XIA - merge proposal

2015-03-15 Thread Oded Gabbay
On 03/15/2015 11:37 AM, Greg KH wrote: On Fri, Mar 13, 2015 at 11:26:46AM -0400, Michel Machado wrote: On 03/10/2015 01:01 PM, Bjorn Helgaas wrote: From my point of view (far outside the networking world and completely incompetent to judge the merits of XIA), this email seems like a

Re: [PATCH 0/5] AMD IOMMU Fixes for v4.2-rc4

2015-07-30 Thread Oded Gabbay
Hi Joerg, I tested your patches on Kaveri, and while they do fix the initial setup between amdkfd and IOMMU, the kernel crashes when an HSA process tries to do any simple action that involves the kernel, such as to create a compute queue. So while I suppose the above patches should be included,

Re: [PATCH] iommu/amd: Allow non-ATS devices in IOMMUv2 domains

2015-07-30 Thread Oded Gabbay
Joerg, Why amdkfd's devices are considered a non-IOMMUv2 capable devices ? After all, they contain the IOMMUv2 H/W and use it constantly for HSA. ODed On Thu, Jul 30, 2015 at 1:05 PM, Joerg Roedel wrote: > From: Joerg Roedel > > With the grouping of multi-function devices a non-ATS > capable

Re: [PATCH] iommu/amd: Allow non-ATS devices in IOMMUv2 domains

2015-07-30 Thread Oded Gabbay
s.qdep; > iommu = amd_iommu_rlookup_table[dev_data->devid]; > -- > 1.9.1 > This series, with the additional patch is: Tested-by: "Oded Gabbay " -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 0/5] AMD IOMMU Fixes for v4.2-rc4

2015-07-30 Thread Oded Gabbay
+-- > 3 files changed, 45 insertions(+), 80 deletions(-) > > -- > 1.9.1 > > ___ > iommu mailing list > io...@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/iommu This series, with the additional patch, is: Tested-by: &q

Re: [RFC][PATCH 1/1] drm/amdkfd: Remove redundant pdd validation

2015-07-09 Thread Oded Gabbay
On Mon, Jun 29, 2015 at 7:33 AM, Maninder Singh wrote: > > pdd is already dereferenced before this check. > So it is redundtant to validate pdd here. > > Signed-off-by: Maninder Singh > --- > drivers/gpu/drm/amd/amdkfd/kfd_process.c |3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >

Re: [PATCH v2] drm/amdkfd: validate pdd where it acquired first

2015-07-09 Thread Oded Gabbay
On Thu, Jul 9, 2015 at 12:11 PM, Maninder Singh wrote: > Currently pdd is validate after dereferencing it, which is > not correct, Thus validate pdd before its first use. > > Signed-off-by: Maninder Singh > --- > v1: remove validation of pdd after its usage > v2: do validation at first place

Re: linux-next: build failure after merge of the drm tree

2015-05-20 Thread Oded Gabbay
On Wed, May 20, 2015 at 8:31 AM, Stephen Rothwell wrote: > Hi Dave, > > On Wed, 20 May 2015 15:25:38 +1000 Stephen Rothwell > wrote: >> >> On Wed, 20 May 2015 05:41:46 +0100 (IST) Dave Airlie >> wrote: >> > >> > > After merging the drm tree, today's linux-next build (powerpc >> > >

Re: [PATCH 03/12] drm/amdkfd: Use DECLARE_BITMAP

2015-05-20 Thread Oded Gabbay
On Wed, May 20, 2015 at 4:37 AM, Joe Perches wrote: > Use the generic mechanism to declare a bitmap instead of unsigned long. > > It seems that "struct kfd_process.allocated_queue_bitmap" is unused. > Maybe it could be deleted instead. > > Signed-off-by: Joe Perches > --- >

[PATCH] iommu/amd: Fix bug in put_pasid_state_wait

2015-04-16 Thread Oded Gabbay
_event. Signed-off-by: Oded Gabbay Cc: sta...@vger.kernel.org --- drivers/iommu/amd_iommu_v2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/amd_iommu_v2.c b/drivers/iommu/amd_iommu_v2.c index 6d5a5c4..173e70d 100644 --- a/drivers/iommu/amd_iommu_v2.c +++ b/drivers/iommu/amd_io

Re: [git pull] IOMMU Updates for Linux v4.1

2015-04-20 Thread Oded Gabbay
Hi Joerg, I sent to you (cc iommu mailing list) an important fix on Apr-16 for a bug in amd_iommu_v2.c (from kernel 4.0). See: http://lists.linuxfoundation.org/pipermail/iommu/2015-April/012757.html Could you please add that to the pull request ? Its creating problems when running HSA

Re: [PATCH] drm/amdkfd: avoid CONFIG_ prefix for non-Kconfig symbols

2015-06-06 Thread Oded Gabbay
On Fri, Jun 5, 2015 at 11:27 AM, Valentin Rothberg wrote: > The CONFIG_ prefix is reserved for Kconfig options in Make and CPP > syntax. Various static analysis tools rely on this naming convention > and check if CONFIG_ prefixed symbols are defined Kconfig. Hence add > yet another prefix AMD_

[PATCH] drm/amdkfd: Don't report local memory size

2015-05-16 Thread Oded Gabbay
cal memory for HSA, we need this patch. Cc: sta...@vger.kernel.org Reviewed-by: Alex Deucher Signed-off-by: Oded Gabbay --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/

Re: [PATCH 3/9] amdkfd: use instead of

2015-08-30 Thread Oded Gabbay
On Fri, Aug 28, 2015 at 10:27 AM, Christoph Hellwig wrote: > > The latter is a default version of and not for driver use. > > Signed-off-by: Christoph Hellwig > --- > drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +- > drivers/gpu/drm/amd/amdkfd/kfd_flat_memory.c | 2 +- > 2 files changed,

Re: [PATCH 3/6] HMM: introduce heterogeneous memory management v2.

2015-01-12 Thread Oded Gabbay
On 01/12/2015 05:46 PM, Jerome Glisse wrote: > On Sun, Jan 11, 2015 at 03:24:42PM +0200, Oded Gabbay wrote: >> >> >> On 01/06/2015 12:44 AM, j.gli...@gmail.com wrote: >>> From: Jérôme Glisse >>> >>> This patch only introduce core HMM functions fo

[BUG] 3.19-rc1 net: less interrupt masking in NAPI

2015-01-10 Thread Oded Gabbay
Hi, Commit d75b1ade567ffab085e8adbbdacf0092d10cd09c breaks my "Qualcomm Atheros AR8161 Gigabit Ethernet (rev 10)" Ethernet controller, which is handled by the alx network driver. ogabbay@odedg-ubuntu:~$ lspci -s 01:00.0 -k 01:00.0 Ethernet controller: Qualcomm Atheros AR8161 Gigabit

Re: [BUG] 3.19-rc1 net: less interrupt masking in NAPI

2015-01-10 Thread Oded Gabbay
On 01/10/2015 10:58 PM, Eric Dumazet wrote: > On Sat, 2015-01-10 at 22:39 +0200, Oded Gabbay wrote: >> Hi, >> >> Commit d75b1ade567ffab085e8adbbdacf0092d10cd09c breaks my "Qualcomm Atheros >> AR8161 Gigabit Ethernet (rev 10)" Ethernet controller, which is

Re: [BUG] 3.19-rc1 net: less interrupt masking in NAPI

2015-01-10 Thread Oded Gabbay
On 01/10/2015 11:30 PM, Oded Gabbay wrote: > > > On 01/10/2015 10:58 PM, Eric Dumazet wrote: >> On Sat, 2015-01-10 at 22:39 +0200, Oded Gabbay wrote: >>> Hi, >>> >>> Commit d75b1ade567ffab085e8adbbdacf0092d10cd09c breaks my "Qualcomm Atheros

Re: [BUG] 3.19-rc1 net: less interrupt masking in NAPI

2015-01-10 Thread Oded Gabbay
On 01/10/2015 11:50 PM, Eric Dumazet wrote: > On Sat, 2015-01-10 at 23:30 +0200, Oded Gabbay wrote: > >> Yes, no problem. >> I will update on the result. > > Please try this more complete patch, solving the TX pressure problem as > well, and not lying about NAPI bu

Re: [BUG] 3.19-rc1 net: less interrupt masking in NAPI

2015-01-10 Thread Oded Gabbay
On 01/11/2015 12:05 AM, Oded Gabbay wrote: > > > On 01/10/2015 11:50 PM, Eric Dumazet wrote: >> On Sat, 2015-01-10 at 23:30 +0200, Oded Gabbay wrote: >> >>> Yes, no problem. >>> I will update on the result. >> >> Please try this more complet

[BUG] 3.19-rc3+ - mm: prevent endless growth of anon_vma hierarchy

2015-01-11 Thread Oded Gabbay
Hello, Today I took latest branch from Linus repo to check for amdkfd regressions due to my fixes pulled for 3.19-rc4, and I got a kernel bug (see below dmesg output). I did a bisect and the first bad commit is: 7a3ef208e662f4b63d43a23f61a64a129c525bbc is the first bad commit commit

Re: BUG in 3.19.0-rc3+

2015-01-11 Thread Oded Gabbay
push %rbp > 13: 10 48 83 adc%cl,-0x7d(%rax) > 16: e8 10 49 39 d6 callq 0xd639492b > 1b: 74 54 je 0x71 > 1d: 48 8b 7d 08 mov0x8(%rbp),%rdi > 21: 48 89 eb mov%rbp,%rbx >

Re: BUG in 3.19.0-rc3+

2015-01-11 Thread Oded Gabbay
>> 38: 66 data16 >>>> 39: 0f .byte 0xf >>>> 3a: 1f (bad) >>>> 3b: 84 00 test %al,(%rax) >>>> 3d: 00 00 add%al,(%rax) >>>> ... >&g

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2015-01-11 Thread Oded Gabbay
On 01/07/2015 12:58 AM, Rusty Russell wrote: > Kees Cook writes: >> On Sun, Jan 4, 2015 at 8:28 PM, Rusty Russell wrote: >>> Kees, as far as I can tell you need another 0-terminated vmlinux.relocs >>> section for weak symbols. These should not be relocated if already 0. >> >> A few questions:

Re: [PATCH 1/6] mmu_notifier: add event information to address invalidation v6

2015-01-11 Thread Oded Gabbay
On 01/06/2015 12:44 AM, j.gli...@gmail.com wrote: > From: Jérôme Glisse > > The event information will be useful for new user of mmu_notifier API. > The event argument differentiate between a vma disappearing, a page > being write protected or simply a page being unmaped. This allow new > user

Re: [PATCH 1/6] mmu_notifier: add event information to address invalidation v6

2015-01-11 Thread Oded Gabbay
On 01/11/2015 02:24 PM, Oded Gabbay wrote: > > > On 01/06/2015 12:44 AM, j.gli...@gmail.com wrote: >> From: Jérôme Glisse >> >> The event information will be useful for new user of mmu_notifier API. >> The event argument differentiate between a vma di

Re: [PATCH 3/6] HMM: introduce heterogeneous memory management v2.

2015-01-11 Thread Oded Gabbay
On 01/06/2015 12:44 AM, j.gli...@gmail.com wrote: > From: Jérôme Glisse > > This patch only introduce core HMM functions for registering a new mirror and > stopping a mirror as well as registering and unregistering a device. > > The lifecycle of HMM object is handled differently then one of

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

2015-01-16 Thread Oded Gabbay
On 01/16/2015 02:27 AM, Kees Cook wrote: > On Sun, Jan 4, 2015 at 8:28 PM, Rusty Russell wrote: >> Oded Gabbay writes: >>> On 12/24/2014 01:01 AM, Rusty Russell wrote: >>>> Oded Gabbay writes: >>>>> I didn't say it doesn't always work. >>&

Re: [PATCH 2/2] iommu/amd: use handle_mm_fault directly v2

2015-01-25 Thread Oded Gabbay
update the appropriate task stats after the fault has been handled, and may aid with debug in the future as well. v2: drop task accounting; GPU activity may have been submitted by a different thread than the one binding the PASID (Joerg) Tested-by: Oded Gabbay Signed-off-by: Jesse Barnes Hi

Re: [PATCH v2] iommu/amd: Use wait_event in put_pasid_state_wait

2015-02-05 Thread Oded Gabbay
that I learned about possible spurious wakeups this place needs fixing too. Replace the self-coded sleep variant with the generic wait_event() helper. Signed-off-by: Joerg Roedel Tested-by: Oded Gabbay Oded -- To unsubscribe from this list: send the line "unsubscribe linux-k

[PATCH 1/1] iommu/amd: Use delayed mmu release notifier

2014-10-17 Thread Oded Gabbay
notifiers. 4. (new code in this patch) amd_iommu_unbind_pasid() sets a delayed notifier, using the delayed mmu release notifier feature (new in 3.17), which does the actual release later, after the iteration over the list of mmu notifiers is over. Signed-off-by: Oded Gabbay --- drivers/iommu

Re: [PATCH 1/1] iommu/amd: Use delayed mmu release notifier

2014-11-07 Thread Oded Gabbay
On 11/06/2014 03:33 PM, Joerg Roedel wrote: > On Sat, Oct 18, 2014 at 12:43:27AM +0300, Oded Gabbay wrote: >> 3. Later, amdkfd's mmu notifier callback (kfd_process_notifier_release()) >> gets >>called and releases more things that are related to the process. &

[PATCH v5 00/24] AMDKFD Kernel Driver

2014-11-08 Thread Oded Gabbay
dule amdkfd: Add device queue manager module Evgeny Pinchuk (2): amdkfd: Add topology module to amdkfd amdkfd: Implement the Get Clock Counters IOCTL Oded Gabbay (12): drm/radeon: reduce number of free VMIDs and pipes in KV drm/radeon/cik: Don't touch int of pipes 1-7 drm/radeon: Re

[PATCH v5 01/24] drm/radeon: reduce number of free VMIDs and pipes in KV

2014-11-08 Thread Oded Gabbay
for static vmid allocation in radeon Reviewed-by: Alex Deucher Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/cik.c | 48 +-- drivers/gpu/drm/radeon/cikd.h | 2 ++ 2 files changed, 26 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/radeon

[PATCH v5 02/24] drm/radeon/cik: Don't touch int of pipes 1-7

2014-11-08 Thread Oded Gabbay
amdkfd should set interrupts for pipes 1-7. Reviewed-by: Alex Deucher Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/cik.c | 71 +--- 1 file changed, 1 insertion(+), 70 deletions(-) diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm

[PATCH v5 03/24] drm/radeon: Report doorbell configuration to amdkfd

2014-11-08 Thread Oded Gabbay
radeon and amdkfd share the doorbell aperture. radeon sets it up, takes the doorbells required for its own rings and reports the setup to amdkfd. radeon reserved doorbells are at the start of the doorbell aperture. Reviewed-by: Alex Deucher Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon

[PATCH v5 05/24] drm/radeon: Add radeon <--> amdkfd interface

2014-11-08 Thread Oded Gabbay
with open-source HSA runtime. Move generic kfd-->kgd interface and other generic kgd definitions to a generic header file that will be used by AMD's radeon and amdgpu drivers Signed-off-by: Oded Gabbay --- drivers/gpu/drm/amd/include/kgd_kfd_interface.h | 185 drivers/gpu/drm/radeon/Makef

[PATCH v5 04/24] drm/radeon: adding synchronization for GRBM GFX

2014-11-08 Thread Oded Gabbay
Implementing a lock for selecting and accessing shader engines and arrays. This lock will make sure that radeon and amdkfd are not colliding when accessing shader engines and arrays with GRBM_GFX_INDEX register. Reviewed-by: Alex Deucher Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon

[PATCH v5 06/24] Update MAINTAINERS and CREDITS files with amdkfd info

2014-11-08 Thread Oded Gabbay
Signed-off-by: Oded Gabbay --- CREDITS | 7 +++ MAINTAINERS | 10 ++ 2 files changed, 17 insertions(+) diff --git a/CREDITS b/CREDITS index bb62788..c56d8aa 100644 --- a/CREDITS +++ b/CREDITS @@ -1197,6 +1197,13 @@ S: R. Tocantins, 89 - Cristo Rei S: 80050-430 - Curitiba

[PATCH v5 07/24] amdkfd: Add IOCTL set definitions of amdkfd

2014-11-08 Thread Oded Gabbay
to be the same size on 32/64 bit Signed-off-by: Oded Gabbay --- include/uapi/linux/kfd_ioctl.h | 154 + 1 file changed, 154 insertions(+) create mode 100644 include/uapi/linux/kfd_ioctl.h diff --git a/include/uapi/linux/kfd_ioctl.h b/include/uapi/linux

[PATCH v5 08/24] amdkfd: Add amdkfd skeleton driver

2014-11-08 Thread Oded Gabbay
/amd and move amdkfd from drm/radeon/ to drm/amd/ Remove scheduler_class from kfd_priv.h as it was never used Add skeleton implementation of the Get Version IOCTL Signed-off-by: Oded Gabbay --- drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile | 1

[PATCH v5 09/24] amdkfd: Add topology module to amdkfd

2014-11-08 Thread Oded Gabbay
how function in kfd_topology.c This situation may occur when amdkfd is loaded and there is a GPU with a CRAT table, but that GPU isn't supported by amdkfd Signed-off-by: Evgeny Pinchuk Signed-off-by: Oded Gabbay --- drivers/gpu/drm/amd/amdkfd/Makefile |2 +- drivers/gpu/drm/amd/amd

[PATCH v5 10/24] amdkfd: Add basic modules to amdkfd

2014-11-08 Thread Oded Gabbay
structure Rename kfd_mem_obj structure's members Use delayed function for process tear-down Signed-off-by: Oded Gabbay --- drivers/gpu/drm/amd/amdkfd/Makefile | 4 +- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 31 ++- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 46 +++- drivers/gpu

[PATCH v5 12/24] amdkfd: Add queue module

2014-11-08 Thread Oded Gabbay
From: Ben Goz The queue module enables allocating and initializing queues uniformly. v3: Removed typedef and redundant memset call. Broke long pr_debug print to one liners and Added documentation. v5: Move amdkfd from drm/radeon/ to drm/amd/ Signed-off-by: Ben Goz Signed-off-by: Oded Gabbay

[PATCH v5 11/24] amdkfd: Add binding/unbinding calls to amd_iommu driver

2014-11-08 Thread Oded Gabbay
of the patchset. Signed-off-by: Oded Gabbay --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 90 +++- drivers/gpu/drm/amd/amdkfd/kfd_priv.h| 1 + drivers/gpu/drm/amd/amdkfd/kfd_process.c | 12 + 3 files changed, 102 insertions(+), 1 deletion(-) diff --git

[PATCH v5 13/24] amdkfd: Add mqd_manager module

2014-11-08 Thread Oded Gabbay
-off-by: Oded Gabbay --- drivers/gpu/drm/amd/amdkfd/Makefile | 2 +- drivers/gpu/drm/amd/amdkfd/cik_regs.h| 221 + drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager.c | 346 +++ drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager.h | 91 +++ drivers

<    10   11   12   13   14   15   16   17   >