[PATCH] lowmemorykiller: prevent multiple instances of low memory killer

2013-04-15 Thread Oskar Andero
: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Brian Swetland swetl...@google.com Reviewed-by: Radovan Lekanovic radovan.lekano...@sonymobile.com Signed-off-by: Snild Dolkow snild.dol...@sonymobile.com Signed-off-by: Oskar Andero oskar.and...@sonymobile.com --- drivers/staging/android

Re: [PATCH] lowmemorykiller: prevent multiple instances of low memory killer

2013-04-15 Thread Oskar Andero
On 16:13 Mon 15 Apr , Dan Carpenter wrote: On Mon, Apr 15, 2013 at 03:38:08PM +0200, Dolkow, Snild wrote: Where is lowmem_shrink called from? I only see shrink called from the bcache sysfs handler __bch_cache_set(). The return value isn't checked there. Up to now this function

Re: [PATCH] lowmemorykiller: prevent multiple instances of low memory killer

2013-04-16 Thread Oskar Andero
On 08:19 Tue 16 Apr , Dan Carpenter wrote: On Mon, Apr 15, 2013 at 04:11:18PM -0700, David Rientjes wrote: On Mon, 15 Apr 2013, Greg Kroah-Hartman wrote: The positive numbers are used to return information on the remaining cache size (again, see the comment I pasted above). We

Re: [PATCH 1/4] kprobes: delay blacklist symbol lookup until we actually need it

2013-04-04 Thread Oskar Andero
On 08:44 Thu 04 Apr , Masami Hiramatsu wrote: (2013/04/03 17:28), oskar.and...@sonymobile.com wrote: +/* it can take some time ( 100ms ) to initialise the + * blacklist so we delay this until we actually need it + */ +static void init_kprobe_blacklist(void) +{ + int i; +

Re: [PATCH 0/4] kprobes: split blacklist into common and arch

2013-04-04 Thread Oskar Andero
directory Oskar Andero (2): kprobes: split blacklist into common and arch kprobes: replace printk with pr_-functions Toby Collett (1): kprobes: delay blacklist symbol lookup until we actually need it arch/arc/kernel/kprobes.c | 3 + arch/arm/kernel/kprobes.c

Re: [PATCH 2/4] kprobes: split blacklist into common and arch

2013-04-04 Thread Oskar Andero
On 08:17 Thu 04 Apr , Masami Hiramatsu wrote: (2013/04/03 17:28), oskar.and...@sonymobile.com wrote: Some blackpoints are only valid for specific architectures. To let each architecture specify its own blackpoints the list has been split in two lists: common and arch. The common list is

[PATCH v2 1/4] kprobes: delay blacklist symbol lookup until we actually need it

2013-04-04 Thread Oskar Andero
-by: Radovan Lekanovic radovan.lekano...@sonymobile.com Signed-off-by: Toby Collett toby.coll...@sonymobile.com Signed-off-by: Oskar Andero oskar.and...@sonymobile.com --- kernel/kprobes.c | 98 ++-- 1 file changed, 60 insertions(+), 38 deletions

[PATCH v2 4/4] kprobes: replace printk with pr_-functions

2013-04-04 Thread Oskar Andero
Instead of using printk use pr_info/pr_err/pr_warn. This was detected by the checkpatch.pl script. Cc: Masami Hiramatsu masami.hiramatsu...@hitachi.com Cc: David S. Miller da...@davemloft.net Signed-off-by: Oskar Andero oskar.and...@sonymobile.com Acked-by: Masami Hiramatsu masami.hiramatsu

[PATCH v2 0/4] kprobes: split blacklist into common and arch

2013-04-04 Thread Oskar Andero
included linux-arch in Cc for this post. -Oskar Björn Davidsson (1): kprobes: move x86-specific blacklist symbols to arch directory Oskar Andero (2): kprobes: split blacklist into common and arch kprobes: replace printk with pr_-functions Toby Collett (1): kprobes: delay blacklist symbol

[PATCH v2 3/4] kprobes: move x86-specific blacklist symbols to arch directory

2013-04-04 Thread Oskar Andero
masami.hiramatsu...@hitachi.com Cc: David S. Miller da...@davemloft.net Cc: linux-a...@vger.kernel.org Reviewed-by: Radovan Lekanovic radovan.lekano...@sonymobile.com Signed-off-by: Björn Davidsson bjorn.davids...@sonymobile.com Signed-off-by: Oskar Andero oskar.and...@sonymobile.com --- arch/x86/kernel/kprobes

[PATCH v2 2/4] kprobes: split blacklist into common and arch

2013-04-04 Thread Oskar Andero
masami.hiramatsu...@hitachi.com Cc: David S. Miller da...@davemloft.net Cc: linux-a...@vger.kernel.org Signed-off-by: Oskar Andero oskar.and...@sonymobile.com --- arch/arc/kernel/kprobes.c | 3 ++ arch/arm/kernel/kprobes.c | 2 + arch/avr32/kernel/kprobes.c| 3 ++ arch/ia64/kernel/kprobes.c

Re: [PATCH] input: don't call input_dev_release_keys() in resume

2013-04-04 Thread Oskar Andero
...@gmail.com Reviewed-by: Radovan Lekanovic radovan.lekano...@sonymobile.com Signed-off-by: Aleksej Makarov aleksej.maka...@sonymobile.com Signed-off-by: Oskar Andero oskar.and...@sonymobile.com --- drivers/input/input.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff

Re: [PATCH] input: don't call input_dev_release_keys() in resume

2013-04-05 Thread Oskar Andero
On 18:33 Thu 04 Apr , Dmitry Torokhov wrote: Hi Oskar, On Thu, Mar 07, 2013 at 03:01:22PM +0100, oskar.and...@sonymobile.com wrote: From: Aleksej Makarov aleksej.maka...@sonymobile.com When waking up the platform by pressing a specific key, sending a release on that key makes it

Re: Re: [PATCH v2 1/4] kprobes: delay blacklist symbol lookup until we actually need it

2013-04-05 Thread Oskar Andero
Thanks for your input guys! On 04:16 Fri 05 Apr , Masami Hiramatsu wrote: (2013/04/05 9:56), Joonsoo Kim wrote: Hello, Oskar. On Thu, Apr 04, 2013 at 02:51:26PM +0200, Oskar Andero wrote: From: Toby Collett toby.coll...@sonymobile.com The symbol lookup can take a long time

[PATCH v3 4/4] kprobes: replace printk with pr_-functions

2013-04-05 Thread Oskar Andero
Instead of using printk use pr_info/pr_err/pr_warn. This was detected by the checkpatch.pl script. Cc: Masami Hiramatsu masami.hiramatsu...@hitachi.com Cc: David S. Miller da...@davemloft.net Signed-off-by: Oskar Andero oskar.and...@sonymobile.com Acked-by: Masami Hiramatsu masami.hiramatsu

[PATCH v3 0/4] kprobes: split blacklist into common and arch

2013-04-05 Thread Oskar Andero
arch_kprobes_blacksyms.* as __weak symbols. -Oskar Björn Davidsson (1): kprobes: move x86-specific blacklist symbols to arch directory Oskar Andero (2): kprobes: split blacklist into common and arch kprobes: replace printk with pr_-functions Toby Collett (1): kprobes: delay blacklist

[PATCH v3 2/4] kprobes: split blacklist into common and arch

2013-04-05 Thread Oskar Andero
masami.hiramatsu...@hitachi.com Cc: David S. Miller da...@davemloft.net Cc: linux-a...@vger.kernel.org Signed-off-by: Oskar Andero oskar.and...@sonymobile.com --- kernel/kprobes.c | 88 +--- 1 file changed, 59 insertions(+), 29 deletions(-) diff --git a/kernel

[PATCH v3 3/4] kprobes: move x86-specific blacklist symbols to arch directory

2013-04-05 Thread Oskar Andero
masami.hiramatsu...@hitachi.com Cc: David S. Miller da...@davemloft.net Cc: linux-a...@vger.kernel.org Reviewed-by: Radovan Lekanovic radovan.lekano...@sonymobile.com Signed-off-by: Björn Davidsson bjorn.davids...@sonymobile.com Signed-off-by: Oskar Andero oskar.and...@sonymobile.com Acked-by: Masami Hiramatsu

[PATCH v3 1/4] kprobes: delay blacklist symbol lookup until we actually need it

2013-04-05 Thread Oskar Andero
-by: Radovan Lekanovic radovan.lekano...@sonymobile.com Signed-off-by: Toby Collett toby.coll...@sonymobile.com Signed-off-by: Oskar Andero oskar.and...@sonymobile.com --- kernel/kprobes.c | 100 ++- 1 file changed, 62 insertions(+), 38 deletions

Re: [PATCH] scsi: fix null pointer dereference in sd_revalidate_disk

2013-04-08 Thread Oskar Andero
pointer. This patch adds a null pointer check. Reviewed-by: Radovan Lekanovic radovan.lekano...@sonymobile.com Signed-off-by: syunsuke.x.itou syunsuke.x.i...@sonymobile.com Signed-off-by: Oskar Andero oskar.and...@sonymobile.com --- drivers/scsi/sd.c |7 ++- 1 files changed, 6

Re: [PATCH] scsi: fix null pointer dereference in sd_revalidate_disk

2013-04-09 Thread Oskar Andero
Hi James, On 18:39 Mon 08 Apr , James Bottomley wrote: On Mon, 2013-04-08 at 13:42 +0200, Oskar Andero wrote: On 14:36 Thu 07 Mar , oskar.and...@sonymobile.com wrote: From: syunsuke.x.itou syunsuke.x.i...@sonymobile.com By repeatadly connecting/disconnecting a USB masstorage

Re: [PATCH] MMC: Detect execution mode errors after r/w command

2013-07-25 Thread Oskar Andero
Hi, On 14:47 Tue 09 Jul , Oskar Andero wrote: From: Lars Svensson lars1.svens...@sonymobile.com Some error bits in the status field of R1/R1b response are only set by the device in response to the command following the failing command. The status is only read and checked after a r/w

[PATCH v2] input: don't call input_dev_release_keys() in resume

2013-07-25 Thread Oskar Andero
dmitry.torok...@gmail.com Reviewed-by: Radovan Lekanovic radovan.lekano...@sonymobile.com Signed-off-by: Aleksej Makarov aleksej.maka...@sonymobile.com Signed-off-by: Oskar Andero oskar.and...@sonymobile.com --- drivers/input/input.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff

Re: [PATCH] input: don't call input_dev_release_keys() in resume

2013-07-12 Thread Oskar Andero
On 09:46 Fri 05 Jul , Oskar Andero wrote: Hi Dmitry, On 18:33 Thu 04 Apr , Dmitry Torokhov wrote: Hi Oskar, On Thu, Mar 07, 2013 at 03:01:22PM +0100, oskar.and...@sonymobile.com wrote: From: Aleksej Makarov aleksej.maka...@sonymobile.com When waking up the platform

Re: [PATCH 1/1] MMC: Detect execution mode errors after r/w command

2013-11-07 Thread Oskar Andero
Hi Ulf, On 18:50 Tue 22 Oct , Ulf Hansson wrote: And this is after the patch has been applied: KB reclen write rewritereadreread 51200 4 251 990 3280 3244 51200 8 4601545 4460 4463

Re: [PATCH v2] input: don't call input_dev_release_keys() in resume

2013-09-18 Thread Oskar Andero
Hii Dmitry, On 14:09 Thu 25 Jul , Oskar Andero wrote: From: Aleksej Makarov aleksej.maka...@sonymobile.com When waking up the platform by pressing a specific key, sending a release on that key makes it impossible to react on the event in user-space. This is fixed by moving

[PATCH v2] input: don't call input_dev_release_keys() in resume

2013-11-22 Thread Oskar Andero
dmitry.torok...@gmail.com Reviewed-by: Radovan Lekanovic radovan.lekano...@sonymobile.com Signed-off-by: Aleksej Makarov aleksej.maka...@sonymobile.com Signed-off-by: Oskar Andero oskar.and...@sonymobile.com --- drivers/input/input.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff

Re: [PATCH v2] input: don't call input_dev_release_keys() in resume

2013-12-06 Thread Oskar Andero
Hi Dmitry, On 03:14 Tue 26 Nov , Dmitry Torokhov wrote: Hi Oskar, On Fri, Nov 22, 2013 at 02:27:04PM +0100, Oskar Andero wrote: From: Aleksej Makarov aleksej.maka...@sonymobile.com When waking up the platform by pressing a specific key, sending a release on that key makes

[PATCH] iio: adc: add driver for MCP3204/08 12-bit ADC

2013-04-30 Thread Oskar Andero
This adds support for Microchip's 12 bit AD converters MCP3204 and MCP3208. These chips communicates over SPI and supports single-ended and pseudo-differential configurations. Cc: Jonathan Cameron ji...@cam.ac.uk Cc: Lars-Peter Clausen l...@metafoo.de Signed-off-by: Oskar Andero oskar.and

Re: [PATCH] iio: adc: add driver for MCP3204/08 12-bit ADC

2013-05-01 Thread Oskar Andero
Hi, On 16:07 Wed 01 May , Lars-Peter Clausen wrote: On 05/01/2013 12:21 AM, Oskar Andero wrote: This adds support for Microchip's 12 bit AD converters MCP3204 and MCP3208. These chips communicates over SPI and supports single-ended and pseudo-differential configurations. Cc

[PATCHv2] iio: adc: add driver for MCP3204/08 12-bit ADC

2013-05-02 Thread Oskar Andero
This adds support for Microchip's 12 bit AD converters MCP3204 and MCP3208. These chips communicates over SPI and supports single-ended and pseudo-differential configurations. Cc: Jonathan Cameron ji...@cam.ac.uk Cc: Lars-Peter Clausen l...@metafoo.de Signed-off-by: Oskar Andero oskar.and

[PATCHv3] iio: adc: add driver for MCP3204/08 12-bit ADC

2013-05-03 Thread Oskar Andero
This adds support for Microchip's 12 bit AD converters MCP3204 and MCP3208. These chips communicates over SPI and supports single-ended and pseudo-differential configurations. Cc: Jonathan Cameron ji...@cam.ac.uk Cc: Lars-Peter Clausen l...@metafoo.de Signed-off-by: Oskar Andero oskar.and

[PATCHv4] iio: adc: add driver for MCP3204/08 12-bit ADC

2013-05-03 Thread Oskar Andero
This adds support for Microchip's 12 bit AD converters MCP3204 and MCP3208. These chips communicates over SPI and supports single-ended and pseudo-differential configurations. Cc: Jonathan Cameron ji...@cam.ac.uk Cc: Lars-Peter Clausen l...@metafoo.de Signed-off-by: Oskar Andero oskar.and

Re: [PATCH] lowmemorykiller: prevent multiple instances of low memory killer

2013-04-23 Thread Oskar Andero
On 22:00 Tue 16 Apr , David Rientjes wrote: On Tue, 16 Apr 2013, Oskar Andero wrote: The comment in shrinker.h is misleading, not the source code. do_shrinker_shrink() will fail for anything negative and 0. The comment is correct. The only acceptable negative return is -1

Re: [RFC PATCH 0/2] return value from shrinkers

2013-05-16 Thread Oskar Andero
On 01:05 Thu 16 May , Andrew Morton wrote: On Mon, 13 May 2013 16:16:33 +0200 Oskar Andero oskar.and...@sonymobile.com wrote: In a previous discussion on lkml it was noted that the shrinkers use the magic value -1 to signal that something went wrong. This patch-set implements

Re: [RFC PATCH 0/2] return value from shrinkers

2013-05-16 Thread Oskar Andero
On 16:49 Wed 15 May , Glauber Costa wrote: On 05/15/2013 06:47 PM, Oskar Andero wrote: On 16:18 Wed 15 May , Glauber Costa wrote: On 05/15/2013 06:10 PM, Oskar Andero wrote: On 17:03 Tue 14 May , Glauber Costa wrote: On 05/13/2013 06:16 PM, Oskar Andero wrote: Hi

[PATCH] mm: vmscan: handle any negative return value from scan_objects

2013-05-16 Thread Oskar Andero
Cc: Hugh Dickins hu...@google.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Signed-off-by: Oskar Andero oskar.and...@sonymobile.com --- include/linux/shrinker.h | 7 --- mm/vmscan.c | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/include/linux

Re: [PATCH] mm: vmscan: handle any negative return value from scan_objects

2013-05-16 Thread Oskar Andero
On 13:52 Thu 16 May , Dave Chinner wrote: On Thu, May 16, 2013 at 10:42:16AM +0200, Oskar Andero wrote: The shrinkers must return -1 to indicate that it is busy. Instead, treat any negative value as busy. Why? The API defines return condition for aborting a scan and gives a specific

Re: [PATCH] mm: vmscan: handle any negative return value from scan_objects

2013-05-17 Thread Oskar Andero
On 08:33 Fri 17 May , Dave Chinner wrote: On Thu, May 16, 2013 at 02:27:52PM +0200, Oskar Andero wrote: On 13:52 Thu 16 May , Dave Chinner wrote: On Thu, May 16, 2013 at 10:42:16AM +0200, Oskar Andero wrote: The shrinkers must return -1 to indicate that it is busy. Instead, treat

[PATCH] mm: vmscan: add BUG_ON on illegal return values from scan_objects

2013-05-20 Thread Oskar Andero
Cc: Hugh Dickins hu...@google.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Signed-off-by: Oskar Andero oskar.and...@sonymobile.com --- mm/vmscan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/vmscan.c b/mm/vmscan.c index 6bac41e..fbe6742 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c

[PATCH v2] mm: vmscan: add VM_BUG_ON on illegal return values from scan_objects

2013-05-21 Thread Oskar Andero
: Hugh Dickins hu...@google.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Signed-off-by: Oskar Andero oskar.and...@sonymobile.com --- mm/vmscan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/vmscan.c b/mm/vmscan.c index 6bac41e..63fec86 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c

Re: [PATCH 1/1] MMC: Detect execution mode errors after r/w command

2013-10-22 Thread Oskar Andero
Hi Ulf, On 17:01 Wed 16 Oct , Ulf Hansson wrote: Hi Oskar / Lars, Sorry for the delayed response! On 10 October 2013 15:28, Oskar Andero oskar.and...@sonymobile.com wrote: From: Lars Svensson lars1.svens...@sonymobile.com Some error bits in the status field of R1/R1b response

[PATCH 1/1] MMC: Detect execution mode errors after r/w command

2013-10-10 Thread Oskar Andero
or the following data transfer. In some situations this causes errors passing undetected. The solution is to read the status and check for these errors after each r/w operation. Signed-off-by: Lars Svensson lars1.svens...@sonymobile.com Signed-off-by: Oskar Andero oskar.and...@sonymobile.com Cc

[RFC PATCH 2/2] Clean-up shrinker return values

2013-05-13 Thread Oskar Andero
Shrinkers return hardcoded -1 on error. Use errno.h values instead to add more meaning to the errors. Cc: Hugh Dickins hu...@google.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Signed-off-by: Oskar Andero oskar.and...@sonymobile.com --- drivers/staging/android/ashmem.c | 2

[RFC PATCH 0/2] return value from shrinkers

2013-05-13 Thread Oskar Andero
say? Is this a good idea or does it make no sense at all? Thanks! -Oskar Oskar Andero (2): mm: vmscan: let any negative return value from shrinker mean error Clean-up shrinker return values drivers/staging/android/ashmem.c | 2 +- drivers/staging/zcache/zcache-main.c | 2 +- fs/gfs2

[RFC PATCH 1/2] mm: vmscan: let any negative return value from shrinker mean error

2013-05-13 Thread Oskar Andero
...@linuxfoundation.org Signed-off-by: Oskar Andero oskar.and...@sonymobile.com --- include/linux/shrinker.h | 5 +++-- mm/vmscan.c | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h index ac6b8ee..31e9406 100644 --- a/include/linux

Re: [RFC PATCH 0/2] return value from shrinkers

2013-05-15 Thread Oskar Andero
On 17:03 Tue 14 May , Glauber Costa wrote: On 05/13/2013 06:16 PM, Oskar Andero wrote: Hi, In a previous discussion on lkml it was noted that the shrinkers use the magic value -1 to signal that something went wrong. This patch-set implements the suggestion of instead using

Re: [RFC PATCH 0/2] return value from shrinkers

2013-05-15 Thread Oskar Andero
On 16:18 Wed 15 May , Glauber Costa wrote: On 05/15/2013 06:10 PM, Oskar Andero wrote: On 17:03 Tue 14 May , Glauber Costa wrote: On 05/13/2013 06:16 PM, Oskar Andero wrote: Hi, In a previous discussion on lkml it was noted that the shrinkers use the magic value -1 to signal

Re: [PATCH] input: don't call input_dev_release_keys() in resume

2013-07-05 Thread Oskar Andero
Hi Dmitry, On 18:33 Thu 04 Apr , Dmitry Torokhov wrote: Hi Oskar, On Thu, Mar 07, 2013 at 03:01:22PM +0100, oskar.and...@sonymobile.com wrote: From: Aleksej Makarov aleksej.maka...@sonymobile.com When waking up the platform by pressing a specific key, sending a release on that key

[PATCH] MMC: Detect execution mode errors after r/w command

2013-07-09 Thread Oskar Andero
or the following data transfer. In some situations this causes errors passing undetected. The solution is to read the status and check for these errors after each r/w operation. Signed-off-by: Lars Svensson lars1.svens...@sonymobile.com Signed-off-by: Oskar Andero oskar.and...@sonymobile.com Cc

[PATCH] USB: storage: Add MicroVault Flash Drive to unusual_devs

2013-07-02 Thread Oskar Andero
From: Ren Bigcren bigcren@sonymobile.com The device report an error capacity when read_capacity_16(). Using read_capacity_10() can get the correct capacity. Signed-off-by: Ren Bigcren bigcren@sonymobile.com Cc: Matthew Dharm mdharm-...@one-eyed-alien.net Signed-off-by: Oskar Andero

[PATCH] backlight: lp855x: set zero brightness at FBBLANK

2013-07-02 Thread Oskar Andero
: Richard Purdie rpur...@rpsys.net Signed-off-by: Oskar Andero oskar.and...@sonymobile.com --- drivers/video/backlight/lp855x_bl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c index a0e1e02..c0b41f1

Re: [PATCH 1/4] kprobes: delay blacklist symbol lookup until we actually need it

2013-04-04 Thread Oskar Andero
On 08:44 Thu 04 Apr , Masami Hiramatsu wrote: > (2013/04/03 17:28), oskar.and...@sonymobile.com wrote: > > > > +/* it can take some time ( > 100ms ) to initialise the > > + * blacklist so we delay this until we actually need it > > + */ > > +static void init_kprobe_blacklist(void) > > +{ > >

Re: [PATCH 0/4] kprobes: split blacklist into common and arch

2013-04-04 Thread Oskar Andero
gt; > > -Oskar > > > > Björn Davidsson (1): > > kprobes: move x86-specific blacklist symbols to arch directory > > > > Oskar Andero (2): > > kprobes: split blacklist into common and arch > > kprobes: replace printk with pr_-functions > &

Re: [PATCH 2/4] kprobes: split blacklist into common and arch

2013-04-04 Thread Oskar Andero
On 08:17 Thu 04 Apr , Masami Hiramatsu wrote: > (2013/04/03 17:28), oskar.and...@sonymobile.com wrote: > > Some blackpoints are only valid for specific architectures. To let each > > architecture specify its own blackpoints the list has been split in two > > lists: common and arch. The common

[PATCH v2 1/4] kprobes: delay blacklist symbol lookup until we actually need it

2013-04-04 Thread Oskar Andero
From: Toby Collett The symbol lookup can take a long time and kprobes is initialised very early in boot, so delay symbol lookup until the blacklist is first used. Cc: Masami Hiramatsu Cc: David S. Miller Reviewed-by: Radovan Lekanovic Signed-off-by: Toby Collett Signed-off-by: Oskar Andero

[PATCH v2 4/4] kprobes: replace printk with pr_-functions

2013-04-04 Thread Oskar Andero
Instead of using printk use pr_info/pr_err/pr_warn. This was detected by the checkpatch.pl script. Cc: Masami Hiramatsu Cc: David S. Miller Signed-off-by: Oskar Andero Acked-by: Masami Hiramatsu --- kernel/kprobes.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions

[PATCH v2 0/4] kprobes: split blacklist into common and arch

2013-04-04 Thread Oskar Andero
included linux-arch in Cc for this post. -Oskar Björn Davidsson (1): kprobes: move x86-specific blacklist symbols to arch directory Oskar Andero (2): kprobes: split blacklist into common and arch kprobes: replace printk with pr_-functions Toby Collett (1): kprobes: delay blacklist symbol

[PATCH v2 3/4] kprobes: move x86-specific blacklist symbols to arch directory

2013-04-04 Thread Oskar Andero
-a...@vger.kernel.org Reviewed-by: Radovan Lekanovic Signed-off-by: Björn Davidsson Signed-off-by: Oskar Andero --- arch/x86/kernel/kprobes/core.c | 6 +- kernel/kprobes.c | 3 --- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86

[PATCH v2 2/4] kprobes: split blacklist into common and arch

2013-04-04 Thread Oskar Andero
. Miller Cc: linux-a...@vger.kernel.org Signed-off-by: Oskar Andero --- arch/arc/kernel/kprobes.c | 3 ++ arch/arm/kernel/kprobes.c | 2 + arch/avr32/kernel/kprobes.c| 3 ++ arch/ia64/kernel/kprobes.c | 3 ++ arch/mips/kernel/kprobes.c | 3 ++ arch/mn10300/kernel

Re: [PATCH] input: don't call input_dev_release_keys() in resume

2013-04-04 Thread Oskar Andero
ed-by: Radovan Lekanovic > Signed-off-by: Aleksej Makarov > Signed-off-by: Oskar Andero > --- > drivers/input/input.c |5 - > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/drivers/input/input.c b/drivers/input/input.c > index c044699..61ce

Re: [PATCH] input: don't call input_dev_release_keys() in resume

2013-04-05 Thread Oskar Andero
On 18:33 Thu 04 Apr , Dmitry Torokhov wrote: > Hi Oskar, > > On Thu, Mar 07, 2013 at 03:01:22PM +0100, oskar.and...@sonymobile.com wrote: > > From: Aleksej Makarov > > > > When waking up the platform by pressing a specific key, sending a > > release on that key makes it impossible to react

Re: Re: [PATCH v2 1/4] kprobes: delay blacklist symbol lookup until we actually need it

2013-04-05 Thread Oskar Andero
Thanks for your input guys! On 04:16 Fri 05 Apr , Masami Hiramatsu wrote: > (2013/04/05 9:56), Joonsoo Kim wrote: > > Hello, Oskar. > > > > On Thu, Apr 04, 2013 at 02:51:26PM +0200, Oskar Andero wrote: > >> From: Toby Collett > >> > >> Th

[PATCH v3 4/4] kprobes: replace printk with pr_-functions

2013-04-05 Thread Oskar Andero
Instead of using printk use pr_info/pr_err/pr_warn. This was detected by the checkpatch.pl script. Cc: Masami Hiramatsu Cc: David S. Miller Signed-off-by: Oskar Andero Acked-by: Masami Hiramatsu --- kernel/kprobes.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions

[PATCH v3 0/4] kprobes: split blacklist into common and arch

2013-04-05 Thread Oskar Andero
arch_kprobes_blacksyms.* as __weak symbols. -Oskar Björn Davidsson (1): kprobes: move x86-specific blacklist symbols to arch directory Oskar Andero (2): kprobes: split blacklist into common and arch kprobes: replace printk with pr_-functions Toby Collett (1): kprobes: delay blacklist

[PATCH v3 2/4] kprobes: split blacklist into common and arch

2013-04-05 Thread Oskar Andero
. Miller Cc: linux-a...@vger.kernel.org Signed-off-by: Oskar Andero --- kernel/kprobes.c | 88 +--- 1 file changed, 59 insertions(+), 29 deletions(-) diff --git a/kernel/kprobes.c b/kernel/kprobes.c index c8c2281..2458ae1 100644 --- a/kernel

[PATCH v3 3/4] kprobes: move x86-specific blacklist symbols to arch directory

2013-04-05 Thread Oskar Andero
-a...@vger.kernel.org Reviewed-by: Radovan Lekanovic Signed-off-by: Björn Davidsson Signed-off-by: Oskar Andero Acked-by: Masami Hiramatsu --- arch/x86/kernel/kprobes/core.c | 7 +++ kernel/kprobes.c | 3 --- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel

[PATCH v3 1/4] kprobes: delay blacklist symbol lookup until we actually need it

2013-04-05 Thread Oskar Andero
From: Toby Collett The symbol lookup can take a long time and kprobes is initialised very early in boot, so delay symbol lookup until the blacklist is first used. Cc: Masami Hiramatsu Cc: David S. Miller Reviewed-by: Radovan Lekanovic Signed-off-by: Toby Collett Signed-off-by: Oskar Andero

Re: [PATCH] scsi: fix null pointer dereference in sd_revalidate_disk

2013-04-08 Thread Oskar Andero
ointer. This > patch adds a null pointer check. > > Reviewed-by: Radovan Lekanovic > Signed-off-by: syunsuke.x.itou > Signed-off-by: Oskar Andero > --- > drivers/scsi/sd.c |7 ++- > 1 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/drivers

Re: [PATCH] scsi: fix null pointer dereference in sd_revalidate_disk

2013-04-09 Thread Oskar Andero
Hi James, On 18:39 Mon 08 Apr , James Bottomley wrote: > On Mon, 2013-04-08 at 13:42 +0200, Oskar Andero wrote: > > On 14:36 Thu 07 Mar , oskar.and...@sonymobile.com wrote: > > > From: "syunsuke.x.itou" > > > > > > By repeatadly co

Re: [PATCH] MMC: Detect execution mode errors after r/w command

2013-07-25 Thread Oskar Andero
Hi, On 14:47 Tue 09 Jul , Oskar Andero wrote: > From: Lars Svensson > > Some error bits in the status field of R1/R1b response are only set > by the device in response to the command following the failing > command. The status is only read and checked after a r/w comman

[PATCH v2] input: don't call input_dev_release_keys() in resume

2013-07-25 Thread Oskar Andero
Signed-off-by: Aleksej Makarov Signed-off-by: Oskar Andero --- drivers/input/input.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/input/input.c b/drivers/input/input.c index c044699..ee3ff16 100644 --- a/drivers/input/input.c +++ b/drivers/input/input.c

Re: [PATCH 1/1] MMC: Detect execution mode errors after r/w command

2013-11-07 Thread Oskar Andero
Hi Ulf, On 18:50 Tue 22 Oct , Ulf Hansson wrote: > > And this is after the patch has been applied: > > KB reclen write rewritereadreread > >51200 4 251 990 3280 3244 > >51200 8 4601545 4460 4463 > >

[PATCH v2] input: don't call input_dev_release_keys() in resume

2013-11-22 Thread Oskar Andero
Signed-off-by: Aleksej Makarov Signed-off-by: Oskar Andero --- drivers/input/input.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/input/input.c b/drivers/input/input.c index 846ccdd..511d490 100644 --- a/drivers/input/input.c +++ b/drivers/input/input.c

Re: [PATCH v2] input: don't call input_dev_release_keys() in resume

2013-12-06 Thread Oskar Andero
Hi Dmitry, On 03:14 Tue 26 Nov , Dmitry Torokhov wrote: > Hi Oskar, > > On Fri, Nov 22, 2013 at 02:27:04PM +0100, Oskar Andero wrote: > > From: Aleksej Makarov > > > > When waking up the platform by pressing a specific key, sending a > > release on that

[RFC PATCH 2/2] Clean-up shrinker return values

2013-05-13 Thread Oskar Andero
Shrinkers return hardcoded -1 on error. Use errno.h values instead to add more meaning to the errors. Cc: Hugh Dickins Cc: Greg Kroah-Hartman Signed-off-by: Oskar Andero --- drivers/staging/android/ashmem.c | 2 +- drivers/staging/zcache/zcache-main.c | 2 +- fs/gfs2/glock.c

[RFC PATCH 0/2] return value from shrinkers

2013-05-13 Thread Oskar Andero
hat do you say? Is this a good idea or does it make no sense at all? Thanks! -Oskar Oskar Andero (2): mm: vmscan: let any negative return value from shrinker mean error Clean-up shrinker return values drivers/staging/android/ashmem.c | 2 +- drivers/staging/zcache/zcache-main.c | 2 +

[RFC PATCH 1/2] mm: vmscan: let any negative return value from shrinker mean error

2013-05-13 Thread Oskar Andero
The shrinkers must return -1 to indicate that it is busy. Instead of relaying on magical numbers, let any negative value indicate error. This opens up for using the errno.h error codes in the shrinker implementations. Cc: Hugh Dickins Cc: Greg Kroah-Hartman Signed-off-by: Oskar Andero

Re: [RFC PATCH 0/2] return value from shrinkers

2013-05-15 Thread Oskar Andero
On 17:03 Tue 14 May , Glauber Costa wrote: > On 05/13/2013 06:16 PM, Oskar Andero wrote: > > Hi, > > > > In a previous discussion on lkml it was noted that the shrinkers use the > > magic value "-1" to signal that something went wrong. > > &

Re: [RFC PATCH 0/2] return value from shrinkers

2013-05-15 Thread Oskar Andero
On 16:18 Wed 15 May , Glauber Costa wrote: > On 05/15/2013 06:10 PM, Oskar Andero wrote: > > On 17:03 Tue 14 May , Glauber Costa wrote: > >> On 05/13/2013 06:16 PM, Oskar Andero wrote: > >>> Hi, > >>> > >>> In a previous

Re: [RFC PATCH 0/2] return value from shrinkers

2013-05-16 Thread Oskar Andero
On 01:05 Thu 16 May , Andrew Morton wrote: > On Mon, 13 May 2013 16:16:33 +0200 Oskar Andero > wrote: > > > In a previous discussion on lkml it was noted that the shrinkers use the > > magic value "-1" to signal that something went wrong. > > > &g

Re: [RFC PATCH 0/2] return value from shrinkers

2013-05-16 Thread Oskar Andero
On 16:49 Wed 15 May , Glauber Costa wrote: > On 05/15/2013 06:47 PM, Oskar Andero wrote: > > On 16:18 Wed 15 May , Glauber Costa wrote: > >> On 05/15/2013 06:10 PM, Oskar Andero wrote: > >>> On 17:03 Tue 14 May , Glauber Costa wrote: > >>>&g

[PATCH] mm: vmscan: handle any negative return value from scan_objects

2013-05-16 Thread Oskar Andero
The shrinkers must return -1 to indicate that it is busy. Instead, treat any negative value as busy. This fixes a potential bug if scan_objects returns a negative other than -1. Cc: Glauber Costa Cc: Dave Chinner Cc: Andrew Morton Cc: Hugh Dickins Cc: Greg Kroah-Hartman Signed-off-by: Oskar

Re: [PATCH] mm: vmscan: handle any negative return value from scan_objects

2013-05-16 Thread Oskar Andero
On 13:52 Thu 16 May , Dave Chinner wrote: > On Thu, May 16, 2013 at 10:42:16AM +0200, Oskar Andero wrote: > > The shrinkers must return -1 to indicate that it is busy. Instead, treat > > any negative value as busy. > > Why? The API defines return condition for abor

Re: [PATCH] mm: vmscan: handle any negative return value from scan_objects

2013-05-17 Thread Oskar Andero
On 08:33 Fri 17 May , Dave Chinner wrote: > On Thu, May 16, 2013 at 02:27:52PM +0200, Oskar Andero wrote: > > On 13:52 Thu 16 May , Dave Chinner wrote: > > > On Thu, May 16, 2013 at 10:42:16AM +0200, Oskar Andero wrote: > > > > The shrinkers must return

Re: [PATCH] lowmemorykiller: prevent multiple instances of low memory killer

2013-04-23 Thread Oskar Andero
On 22:00 Tue 16 Apr , David Rientjes wrote: > On Tue, 16 Apr 2013, Oskar Andero wrote: > > > > > The comment in shrinker.h is misleading, not the source code. > > > > do_shrinker_shrink() will fail for anything negative and 0. > > > > > > The c

Re: [PATCH] iio: adc: add driver for MCP3204/08 12-bit ADC

2013-05-01 Thread Oskar Andero
Hi, On 16:07 Wed 01 May , Lars-Peter Clausen wrote: > On 05/01/2013 12:21 AM, Oskar Andero wrote: > > This adds support for Microchip's 12 bit AD converters MCP3204 and > > MCP3208. These chips communicates over SPI and supports single-ended > > and pseudo-differ

[PATCHv2] iio: adc: add driver for MCP3204/08 12-bit ADC

2013-05-02 Thread Oskar Andero
This adds support for Microchip's 12 bit AD converters MCP3204 and MCP3208. These chips communicates over SPI and supports single-ended and pseudo-differential configurations. Cc: Jonathan Cameron Cc: Lars-Peter Clausen Signed-off-by: Oskar Andero --- drivers/iio/adc/Kconfig | 10

[PATCHv3] iio: adc: add driver for MCP3204/08 12-bit ADC

2013-05-03 Thread Oskar Andero
This adds support for Microchip's 12 bit AD converters MCP3204 and MCP3208. These chips communicates over SPI and supports single-ended and pseudo-differential configurations. Cc: Jonathan Cameron Cc: Lars-Peter Clausen Signed-off-by: Oskar Andero --- drivers/iio/adc/Kconfig | 10

[PATCHv4] iio: adc: add driver for MCP3204/08 12-bit ADC

2013-05-03 Thread Oskar Andero
This adds support for Microchip's 12 bit AD converters MCP3204 and MCP3208. These chips communicates over SPI and supports single-ended and pseudo-differential configurations. Cc: Jonathan Cameron Cc: Lars-Peter Clausen Signed-off-by: Oskar Andero --- drivers/iio/adc/Kconfig | 10

[PATCH] lowmemorykiller: prevent multiple instances of low memory killer

2013-04-15 Thread Oskar Andero
: Brian Swetland Reviewed-by: Radovan Lekanovic Signed-off-by: Snild Dolkow Signed-off-by: Oskar Andero --- drivers/staging/android/lowmemorykiller.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c

Re: [PATCH] lowmemorykiller: prevent multiple instances of low memory killer

2013-04-15 Thread Oskar Andero
On 16:13 Mon 15 Apr , Dan Carpenter wrote: > On Mon, Apr 15, 2013 at 03:38:08PM +0200, Dolkow, Snild wrote: > > >Where is lowmem_shrink called from? I only see shrink called from the > > >bcache sysfs handler __bch_cache_set(). The return value isn't checked > > >there. > > > > > >Up to now

Re: [PATCH] lowmemorykiller: prevent multiple instances of low memory killer

2013-04-16 Thread Oskar Andero
On 08:19 Tue 16 Apr , Dan Carpenter wrote: > On Mon, Apr 15, 2013 at 04:11:18PM -0700, David Rientjes wrote: > > On Mon, 15 Apr 2013, Greg Kroah-Hartman wrote: > > > > > > The positive numbers are used to return information on the remaining > > > > cache size (again, see the comment I pasted

[PATCH 1/1] MMC: Detect execution mode errors after r/w command

2013-10-10 Thread Oskar Andero
transfer. In some situations this causes errors passing undetected. The solution is to read the status and check for these errors after each r/w operation. Signed-off-by: Lars Svensson Signed-off-by: Oskar Andero Cc: linux-...@vger.kernel.org --- drivers/mmc/card/block.c | 105

Re: [PATCH v2] input: don't call input_dev_release_keys() in resume

2013-09-18 Thread Oskar Andero
Hii Dmitry, On 14:09 Thu 25 Jul , Oskar Andero wrote: > From: Aleksej Makarov > > When waking up the platform by pressing a specific key, sending a > release on that key makes it impossible to react on the event in > user-space. This is fixed by moving the input_rese

Re: [PATCH 1/1] MMC: Detect execution mode errors after r/w command

2013-10-22 Thread Oskar Andero
Hi Ulf, On 17:01 Wed 16 Oct , Ulf Hansson wrote: > Hi Oskar / Lars, > > Sorry for the delayed response! > > On 10 October 2013 15:28, Oskar Andero wrote: > > From: Lars Svensson > > > > Some error bits in the status field of R1/R1b response are only

[PATCH] mm: vmscan: add BUG_ON on illegal return values from scan_objects

2013-05-20 Thread Oskar Andero
Add a BUG_ON to catch any illegal value from the shrinkers. This fixes a potential bug if scan_objects returns a negative other than -1, which would lead to undefined behaviour. Cc: Glauber Costa Cc: Dave Chinner Cc: Andrew Morton Cc: Hugh Dickins Cc: Greg Kroah-Hartman Signed-off-by: Oskar

[PATCH v2] mm: vmscan: add VM_BUG_ON on illegal return values from scan_objects

2013-05-21 Thread Oskar Andero
Add a VM_BUG_ON to catch any illegal value from the shrinkers. It's a potential bug if scan_objects returns a negative other than -1 and would lead to undefined behaviour. Cc: Glauber Costa Cc: Dave Chinner Cc: Andrew Morton Cc: Hugh Dickins Cc: Greg Kroah-Hartman Signed-off-by: Oskar Andero

[PATCH] iio: adc: add driver for MCP3204/08 12-bit ADC

2013-04-30 Thread Oskar Andero
This adds support for Microchip's 12 bit AD converters MCP3204 and MCP3208. These chips communicates over SPI and supports single-ended and pseudo-differential configurations. Cc: Jonathan Cameron Cc: Lars-Peter Clausen Signed-off-by: Oskar Andero --- drivers/iio/adc/Kconfig

[PATCH] USB: storage: Add MicroVault Flash Drive to unusual_devs

2013-07-02 Thread Oskar Andero
From: Ren Bigcren The device report an error capacity when read_capacity_16(). Using read_capacity_10() can get the correct capacity. Signed-off-by: Ren Bigcren Cc: Matthew Dharm Signed-off-by: Oskar Andero --- drivers/usb/storage/unusual_devs.h | 7 +++ 1 file changed, 7 insertions

  1   2   >