[PATCH] USB: io_edgeport: remove unused variable

2012-10-30 Thread Paul Bolle
. Paul Bolle --- The stable commit 12ddc74e8e25107eda81aceb74e3311c1480b381 (USB: io_edgeport: fix port-data memory leak) left one variable unused: drivers/usb/serial/io_edgeport.c: In function 'edge_release': drivers/usb/serial/io_edgeport.c:3155:6: warning: unused variable 'i' [-Wunused

Re: NULL pointer dereference at fat_detach

2012-10-30 Thread Paul Bolle
kernel: [15141.653798] VFS: Busy inodes after unmount of sdb1. Self-destruct in 5 seconds. Have a nice day... Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: NULL pointer dereference at fat_detach

2012-10-31 Thread Paul Bolle
On Wed, 2012-10-31 at 09:49 +0900, OGAWA Hirofumi wrote: This bug is known as the inotify bug. I recall I talked about this, maybe years ago. Would that be this thread: https://lkml.org/lkml/2011/6/10/155 ? Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-kernel

[PATCH] [media] budget-av: only use t_state if initialized

2012-11-01 Thread Paul Bolle
uninitialized in this function [-Wuninitialized] Move the printk() that uses t_state.bandwith to the location where it should be initialized to fix this. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- 0) Compile tested only. 1) By the way, the first two if()-tests in tda8261_get_bandwidth

[PATCH] [media] tda18212: tda18218: use 'val' if initialized

2012-11-01 Thread Paul Bolle
the return values of tda18212_rd_reg() or tda18218_rd_reg(), as these are not interesting. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- 0) Compile tested only. drivers/media/tuners/tda18212.c | 6 +++--- drivers/media/tuners/tda18218.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions

[PATCH] xfs: silence GCC warning

2012-11-02 Thread Paul Bolle
to be no easy way to give GCC enough information to determine that. So let's silence this warning, using the pattern Ingo Molnar recently suggested. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- 0) Compile tested only. 1) I fear that the only way to give GCC the information it needs to do the flow

Re: [PATCH] xfs: silence GCC warning

2012-11-02 Thread Paul Bolle
On Fri, 2012-11-02 at 09:07 -0400, Christoph Hellwig wrote: Looks good, Dave has actually sent it a tidbit earlier as part of his series with fixes for 3.7-rc I see, thanks. Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

x86: Fast TSC calibration failed error

2012-09-24 Thread Paul Bolle
) informational level. Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] aic94xx: fix handling of default CTRL-A settings

2012-09-25 Thread Paul Bolle
-off-by: Paul Bolle pebo...@tiscali.nl --- 0) I noticed this warning while building v3.6-rc7 on current Fedora 17, using Fedora's default config. 1) Compile tested only. It might be best to run test this too, if only to test whether the non-error path is unaffected. 2) This piece of code has

[PATCH] x86, tsc: downgrade message for fast calibration failure

2012-09-26 Thread Paul Bolle
-off-by: Paul Bolle pebo...@tiscali.nl --- 0) This is a rather verbose commit explanation. For trivialities like these I try to write a very short explanation. But here the verbosity is meant to obfuscate my complete ignorance of the (calibration of the) TSC. 1) By the way, it's debatable whether

[PATCH] mm: frontswap: silence GCC warning

2012-09-27 Thread Paul Bolle
in the nothing-to-do case, GCC can figure that out. So let's do that. While we're at it, stop setting pages_to_unuse to zero in __frontswap_shrink(), as that's not needed there. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- 0) I noticed this warning while building v3.6-rc7 on current Fedora 17, using

Re: [PATCH -v2] mm: frontswap: fix a wrong if condition in frontswap_shrink

2012-09-27 Thread Paul Bolle
) try_to_unuse(type, true, pages_to_unuse); return; } Are you sure pages_to_unuse won't be zero here? I've stared quite a bit at __frontswap_unuse_pages() and it's not obvious pages_to_unuse (there also called unused) will never be zero when that function returns zero. Paul

Re: [PATCH] regmap: silence GCC warning

2012-10-03 Thread Paul Bolle
On Tue, 2012-10-02 at 20:11 -0400, valdis.kletni...@vt.edu wrote: On Mon, 01 Oct 2012 11:03:21 +0100, Mark Brown said: On Sun, Sep 30, 2012 at 12:15:55PM +0200, Paul Bolle wrote: Building regmap.o triggers this GCC warning: drivers/base/regmap/regmap.c: In function regmap_raw_read

[PATCH v3] qla2xxx: silence two GCC warnings

2012-10-05 Thread Paul Bolle
information to keep track of array bounds. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- 0) Updated for Saurav's request to use strncpy(). 1) Still only compile tested. drivers/scsi/qla2xxx/qla_def.h | 1 + drivers/scsi/qla2xxx/qla_gs.c | 8 2 files changed, 5 insertions(+), 4 deletions

Re: [PATCH] regmap: silence GCC warning

2012-10-06 Thread Paul Bolle
On Sat, 2012-10-06 at 09:53 +0100, Mark Brown wrote: On Fri, Oct 05, 2012 at 06:20:44PM -0400, valdis.kletni...@vt.edu wrote: On Wed, 03 Oct 2012 09:23:36 +0200, Paul Bolle said: That is another way to silence GCC here. That's probably a preferable approach - that way, if a bogus

[PATCH] atp: remove set_rx_mode_8012()

2012-11-03 Thread Paul Bolle
' will be used uninitialized in set_rx_mode_8012(), which is apparently inlined into set_rx_mode(). But it turns out set_rx_mode_8012() will never be called, since net_local.chip_type will always be RTL8002. So we can just remove set_rx_mode_8012() and do some related cleanups. Signed-off-by: Paul Bolle

Re: [PATCH 8/9] isdn: Remove unused variable causing a compile build warning

2012-11-03 Thread Paul Bolle
On Sat, 2012-11-03 at 23:02 +0100, Lee Jones wrote: This patch fixes: drivers/isdn/i4l/isdn_common.c: In function ‘isdn_ioctl’: drivers/isdn/i4l/isdn_common.c:1278:8: warning: unused variable ‘s’ [-Wunused-variable] Did you have CONFIG_NETDEVICES not set in this build? Paul Bolle

Re: [PATCH 8/9] isdn: Remove unused variable causing a compile build warning

2012-11-04 Thread Paul Bolle
On Sat, 2012-11-03 at 23:48 +0100, Lee Jones wrote: On Sat, 03 Nov 2012, Paul Bolle wrote: On Sat, 2012-11-03 at 23:02 +0100, Lee Jones wrote: This patch fixes: drivers/isdn/i4l/isdn_common.c: In function ‘isdn_ioctl’: drivers/isdn/i4l/isdn_common.c:1278:8: warning: unused variable ‘s

Re: [PATCH 8/9] isdn: Remove unused variable causing a compile build warning

2012-11-05 Thread Paul Bolle
depend on NETDEVICES, ISDN_I4L would too, since it depends on ISDN. In that case CONFIG_NETDEVICES would always be true when compiling isdn_common.c. That would make these guards pointless. (The dependency of ISDN_PPP on NETDEVICES would then also be pointless.) Paul Bolle -- To unsubscribe from

[PATCH] [SCSI] advansys: change buildtime warning into runtime error

2012-11-05 Thread Paul Bolle
into a runtime error, only printed for those wide boards. Perhaps that might push the people using those wide boards to convert this driver. And for all others there's now one less buildtime warning to ignore. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Compile tested only. I don't have any

[PATCH v2] regmap: silence GCC warning

2012-10-08 Thread Paul Bolle
that there is a type mismatch between 'num' in regmap_volatile_range() and 'val_count' in regmap_raw_read(). And indeed, converting 'num' to the type of 'val_count' (ie, size_t) makes this warning go away. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- drivers/base/regmap/regmap.c | 2 +- 1 file changed, 1

[PATCH] drm/nv40/pm: silence GCC warnings

2012-10-08 Thread Paul Bolle
() returns an error-code integer (ie, negative on failure, zero on success). And a trivial tweak to nv40_calc_pll() that takes this into account makes these errors go away. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- 0) I noticed these warnings while building recent releases (eg, v3.6-rc7, v3.6

Re: [PATCH] IB/lmx4: silence GCC warning

2012-10-29 Thread Paul Bolle
). Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] aic7xxx_old: silence GCC warnings

2012-10-29 Thread Paul Bolle
On Fri, 2012-09-21 at 11:28 +0200, Paul Bolle wrote: Building the aic7xxx_old driver triggers these GCC warnings: drivers/scsi/aic7xxx_old.c:7901:5: warning: case value '257' not in enumerated type 'ahc_chip' [-Wswitch] drivers/scsi/aic7xxx_old.c:7898:5: warning: case value '513

Re: [PATCH] mvsas: use correct named constants

2012-10-29 Thread Paul Bolle
On Fri, 2012-09-21 at 14:11 +0200, Paul Bolle wrote: Building the mvsas driver triggers these GCC warnings: drivers/scsi/mvsas/mv_sas.c:1156:34: warning: comparison between 'enum sas_device_type' and 'enum sas_dev_type' [-Wenum-compare] drivers/scsi/mvsas/mv_sas.c:1159:39: warning

Re: [PATCH] aic94xx: fix handling of default CTRL-A settings

2012-10-29 Thread Paul Bolle
On Tue, 2012-09-25 at 14:07 +0200, Paul Bolle wrote: Compiling aic94xx_sds.o (part of the aic94xx driver) triggers this GCC warning: drivers/scsi/aic94xx/aic94xx_sds.c: In function 'asd_read_flash': drivers/scsi/aic94xx/aic94xx_sds.c:597:21: warning: 'offs' may be used uninitialized

Re: [PATCH] aic7xxx_old: silence GCC warnings

2012-10-29 Thread Paul Bolle
finding the time to test. Thanks, Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

mfd: lpc_ich: NULL pointer dereference at (second) module removal

2012-11-09 Thread Paul Bolle
print offsets in hex and gdb in decimal? (Of course, here it's trivial to realize that 0x1d is 29.) Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

[PATCH] staging: lirc_serial: silence GCC warning

2012-10-14 Thread Paul Bolle
' parameter from bool to int. But, to be safe, we also need to make sure 'sense' will only be -1, 0, or 1. There's no need to document the new values that are now allowed for the 'sense' parameter, since they're basically useless. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- 0) This warning

[PATCH] xen/xenbus: silence GCC warning

2012-10-15 Thread Paul Bolle
-off-by: Paul Bolle pebo...@tiscali.nl --- 0) Triggered by compiling v3.7-rc1 using (basically) Fedora 17's current config. Compile tested only. 1) Obligatory reference: https://lwn.net/Articles/487493/ . drivers/xen/xenbus/xenbus_xs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

Re: ext3 issue on 3.6.1

2012-10-18 Thread Paul Bolle
trace e60232a455c8e2dd ]--- And this seems unrelated - likely an NFS problem... Let's sort this out if you still see it after ext3 issue is solved. Looks rather similar too https://lkml.org/lkml/2012/8/29/165 , doesn't it? Paul Bolle -- To unsubscribe from this list: send the line

[PATCH] staging: wlags49_h2: remove vi modelines

2012-07-13 Thread Paul Bolle
Signed-off-by: Paul Bolle pebo...@tiscali.nl --- 0) Opening drivers/staging/wlags49_h2/dhf.2 with vim triggered this warning: drivers/staging/wlags49_h2/dhf.h 226L, 8428C Error detected while processing modelines: line2: E518: Unknown option: */ Press ENTER or type command to continue 1

RE: 2976579765? Really? (was Re: Move hyperv out of the drivers/staging/ directory)

2012-07-13 Thread Paul Bolle
On Fri, 2012-07-13 at 13:21 +, KY Srinivasan wrote: Ok! I don't know how easy it is to change this. I'd say nothing could possibly break if you just changed that line to #define HV_LINUX_GUEST_ID_HI 2976579765 (Not that I, somehow, tested this.) Paul Bolle -- To unsubscribe

Re: [RFC] Simplifying kernel configuration for distro issues

2012-07-13 Thread Paul Bolle
to start these journeys. Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] gigaset: silence GCC warning for unused 'format_ie'

2012-07-15 Thread Paul Bolle
Building Gigaset's CAPI support without Gigaset's debugging enabled triggers this GCC warning: 'format_ie' defined but not used [-Wunused-function] Silence this warning by wrapping format_ie() in an #ifdef CONFIG_GIGASET_DEBUG and #endif pair. Signed-off-by: Paul Bolle pebo...@tiscali.nl

Re: [RFC] Simplifying kernel configuration for distro issues

2012-07-19 Thread Paul Bolle
On Thu, 2012-07-19 at 13:19 -0400, Josh Boyer wrote: kconfig already spits out warnings for symbols being selected that don't exist. Does it? Since when does it do that? Or do you mean select in a more general way (not just meaning Kconfig's select statement)? Paul Bolle -- To unsubscribe

Re: [RFC] Simplifying kernel configuration for distro issues

2012-07-19 Thread Paul Bolle
...] Oh, only 12 warnings in the v3.5-rc7 builds. Not that bad as my gut feeling said... Well, that's yet another issue but anyhow. That number of warnings should presumably drop to (almost) zero if those weren't warnings but errors. Has that ever been tried? Paul Bolle -- To unsubscribe from

[PATCH v2] cris: drop unused Kconfig symbols

2013-04-16 Thread Paul Bolle
Signed-off-by: Paul Bolle pebo...@tiscali.nl --- 0) The first version had the subject [PATCH 21/21] cris: drop unused Kconfig symbols. 1) This version was redone on top of v3.9-rc7. The changes since the first version are: - dropped OOM_REBOOT (I sent a separate patch for that symbol because I

Re: [PATCH 09/23] perf: make cfi unwind support based on CONFIG_LIBUNWIND

2013-04-04 Thread Paul Bolle
at for the next version. Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] Blackfin: bf537: rename CONFIG_AD7314

2013-04-04 Thread Paul Bolle
In v3.2 the Analog Devices AD7314 temperature sensor driver was removed as an IIO driver and added as a HWMON driver. But it was apparently overlooked to rename two references to CONFIG_AD7314 to CONFIG_SENSORS_AD7314. Do so now. Use the IS_ENABLED() macro, while we're at it. Signed-off-by: Paul

Re: [PATCH] Blackfin: bf537: rename CONFIG_AD7314

2013-04-04 Thread Paul Bolle
[Forwarded to a recent address of Guenter, as the ericsson address bounces.] Paul Bolle On Thu, 2013-04-04 at 12:08 +0200, Paul Bolle wrote: In v3.2 the Analog Devices AD7314 temperature sensor driver was removed as an IIO driver and added as a HWMON driver. But it was apparently overlooked

[PATCH] Blackfin: bf537: rename CONFIG_ADT75

2013-04-04 Thread Paul Bolle
at it. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- 0) Also untested. 1) See commits e96f9d89e6213c7630a3323cd0c754e7f2619564 (hwmon: (lm75) Add support for Analog Devices ADT75) and cdea0bec8d37f2943ae500512b0c178bc76de6e3 (iio: adc: remove ADT75 driver - hwmon/lm75 will take over ADT75 support

[PATCH] Blackfin: bf537: rename ad2s120x -ad2s1200

2013-04-04 Thread Paul Bolle
In v3.2 the Analog Devices ad2s1200/ad2s1205 driver was renamed from ad2s120x to ad2s1200. But it apparently forgot to rename the references to this driver in the BF537-STAMP code. Rename these now, and use the IS_ENABLED() macro, while we're at it. Signed-off-by: Paul Bolle pebo...@tiscali.nl

[PATCH] MIPS: Alchemy: Fix typo CONFIG_DEBUG_PCI

2013-04-04 Thread Paul Bolle
Also add a newline to a debugging printk that this fix enables. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- 0) Entirely untested. Adding the newline adds a checkpatch warning for over 80 characters lines. 1) Typo was added in v3.2, through commit 7517de348663b08a808aff44b5300e817157a568

Re: [PATCH] Blackfin: bf537: rename CONFIG_ADT75

2013-04-04 Thread Paul Bolle
) were obvious oversights that I could as well fix right away. Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

[PATCH v2] MIPS: Alchemy: Fix typo CONFIG_DEBUG_PCI

2013-04-04 Thread Paul Bolle
Commit 7517de348663b08a808aff44b5300e817157a568 (MIPS: Alchemy: Redo PCI as platform driver) added a reference to CONFIG_DEBUG_PCI. Change it to CONFIG_PCI_DEBUG, as that is a valid Kconfig macro. Also add a newline to a debugging printk that this fix enables. Signed-off-by: Paul Bolle pebo

[PATCH] Blackfin: bf537: use CONFIG_SND_SOC_AD193X

2013-04-05 Thread Paul Bolle
() macro. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- 0) Untested. Please note that I fail to see the point of commit 57084ede395bb3c9da7905701d34a3b7d33c9356, which was added in v3.4, even if I assume it wanted to use CONFIG_SND_SOC_AD193X. Perhaps I'm missing something obvious. Anyhow

[PATCH] omap2+: Remove useless Makefile line

2013-04-05 Thread Paul Bolle
-omap3encore.c. This line can safely be removed. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- arch/arm/mach-omap2/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile index b068b7f..3d0697c 100644 --- a/arch/arm/mach-omap2/Makefile

[PATCH] omap2+: Remove useless Makefile line

2013-04-05 Thread Paul Bolle
. This line can safely be removed. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Note that MACH_PCM049 was removed from mach-types in v3.5. arch/arm/mach-omap2/Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile index 3d0697c

[PATCH] nfc: Remove useless Makefile line

2013-04-05 Thread Paul Bolle
There's no Kconfig symbol NFC_DEBUG. Besides, there doesn't seem to be any nfc code that uses a DEBUG macro. This line can safely be removed. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Untested. drivers/nfc/Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/nfc/Makefile

Re: [PATCH] nfc: Remove useless Makefile line

2013-04-05 Thread Paul Bolle
On Fri, 2013-04-05 at 09:35 -0700, Joe Perches wrote: On Fri, 2013-04-05 at 18:31 +0200, Paul Bolle wrote: -ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG pr_debug/dev_dbg/nfc_dev_dbg logging messages depend on this. Thanks. But then a NFC_DEBUG symbol needs to be added, because now the DEBUG

Re: [PATCH] regmap: don't corrupt work buffer in _regmap_raw_write()

2013-04-08 Thread Paul Bolle
this warning. I'm a bit uncertain what the regmap_parse_*() functions are meant to do. So I'd like to first ask whether something along these lines is acceptable. Paul Bolle diff --git a/drivers/base/regmap/internal.h b/drivers/base/regmap/internal.h index 5a22bd3..35877b7 100644 --- a/drivers

[PATCH v2] doc: change example to existing Makefile fragment

2013-04-08 Thread Paul Bolle
Signed-off-by: Paul Bolle pebo...@tiscali.nl Acked-by: Rob Landley r...@landley.net --- v2: added Rob's ACK and send to Michal e.a., for the kbuild tree. Documentation/kbuild/makefiles.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/kbuild/makefiles.txt

[PATCH] powerpc: remove unused config 405EP

2013-04-08 Thread Paul Bolle
All users of Kconfig symbol 405EP were removed in release v2.6.27. Remove this symbol (and a useless select of it) too. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- 0) Tested by grepping the tree only. 1) There's also a Kconfig symbol EP405. Let's hope no one ever made a typo with either

[PATCH] locking: remove three unused Kconfig symbols

2013-04-08 Thread Paul Bolle
The Kconfig symbols ARCH_INLINE_READ_UNLOCK_IRQ, ARCH_INLINE_SPIN_UNLOCK_IRQ, and ARCH_INLINE_WRITE_UNLOCK_IRQ were added in v2.6.33, but have never actually been used. It is safe to remove these. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Untested. These three symbols were added in commit

[PATCH] ARM: imx: remove configs ARCH_MX5 and ARCH_MX51

2013-04-08 Thread Paul Bolle
The Kconfig symbols ARCH_MX5 and ARCH_MX51 are unused since v3.3. They can safely be removed. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Tested with git grep only. arch/arm/mach-imx/Kconfig | 10 -- 1 file changed, 10 deletions(-) diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm

[PATCH] ARM: EXYNOS: remove config EXYNOS_DEV_DRM

2013-04-08 Thread Paul Bolle
The only user of Kconfig symbol EXYNOS_DEV_DRM was removed in commit 0a9d5ac307aefbb2c772537d3fe7f75046d563ac (ARM: EXYNOS: removing exynos-drm device registration from non-dt platforms). It is safe to remove this symbol too. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Only git grep tested

Re: [PATCH] locking: remove three unused Kconfig symbols

2013-04-08 Thread Paul Bolle
On Mon, 2013-04-08 at 17:16 +0200, Ingo Molnar wrote: * Paul Bolle pebo...@tiscali.nl wrote: The Kconfig symbols ARCH_INLINE_READ_UNLOCK_IRQ, ARCH_INLINE_SPIN_UNLOCK_IRQ, and ARCH_INLINE_WRITE_UNLOCK_IRQ were added in v2.6.33, but have never actually been used. It is safe to remove

Re: [PATCH] locking: remove three unused Kconfig symbols

2013-04-08 Thread Paul Bolle
On Mon, 2013-04-08 at 17:30 +0200, Paul Bolle wrote: Would you have any idea why this problem wasn't noticed in 16 (!) releases? Fedora 17, which I did this patch on, has Kconfig symbolk PREEMPT not set. Is it perhaps commit to not enable that option? s/commit/common/ (and, obviously, s

[PATCH] MIPS: Kconfig: remove config MIPS_BOARDS_GEN

2013-04-08 Thread Paul Bolle
The Kconfig symbol MIPS_BOARDS_GEN is unused since v2.6.27. It should now be removed. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Untested, unsurprisingly. arch/mips/Kconfig | 5 - 1 file changed, 5 deletions(-) diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig index 51244bf..7b38bf8

[PATCH] MIPS: Kconfig: remove config MIPS_DISABLE_OBSOLETE_IDE

2013-04-08 Thread Paul Bolle
The Kconfig symbol MIPS_DISABLE_OBSOLETE_IDE was added in v2.6.10. It has never been used. Let's remove it. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Tested with git grep (on current and historic trees). arch/mips/Kconfig | 3 --- arch/mips/alchemy/Kconfig | 3 --- 2 files

[PATCH] powerpc: remove config MPC10X_OPENPIC

2013-04-08 Thread Paul Bolle
The last users of Kconfig symbol MPC10X_OPENPIC were removed in v2.6.27. Its Kconfig entry can be removed now. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Untested. arch/powerpc/platforms/embedded6xx/Kconfig | 5 - 1 file changed, 5 deletions(-) diff --git a/arch/powerpc/platforms

[PATCH] [media] soc-camera: remove config MX3_VIDEO

2013-04-08 Thread Paul Bolle
The last user of Kconfig symbol MX3_VIDEO was removed in v3.2. Its Kconfig entry can be removed now. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Tested with git grep. drivers/media/platform/soc_camera/Kconfig | 4 1 file changed, 4 deletions(-) diff --git a/drivers/media/platform

[PATCH] arch/ia64/xen: remove config NO_IDLE_HZ

2013-04-08 Thread Paul Bolle
The Kconfig symbol NO_IDLE_HZ, and its last users, were removed in v2.6.27. It popped up again, for some reason, in the Kconfig file for Xen on ia64 in v2.6.28. Remove it from that file now. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- arch/ia64/xen/Kconfig | 5 - 1 file changed, 5

[PATCH v2] [media] soc-camera: remove two unused configs

2013-04-09 Thread Paul Bolle
The last users of Kconfig symbols MX3_VIDEO and VIDEO_MX2_HOSTSUPPORT were removed in v3.2. Their Kconfig entries can be removed now. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- v1 was called [...] remove config MX3_VIDEO. But it turned out that v3.2, through commit 389d12cc7f (ARM: mxc

[PATCH] x86: fixmap: remove FIX_CYCLONE_TIMER

2013-04-11 Thread Paul Bolle
The last users of FIX_CYCLONE_TIMER were removed in v2.6.18. We can remove this unneeded constant. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- See commit 61743fe445213b87fb55a389c8d073785323ca3e ([...] Time: i386 Conversion - part 4: Remove Old timer_opts Code). arch/x86/include/asm

[PATCH] [media] gspca: remove obsolete Kconfig macros

2013-03-28 Thread Paul Bolle
The et61x251 driver was removed in v3.5. Remove the last references to its Kconfig macro now. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Untested, as usual. drivers/media/usb/gspca/etoms.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/usb/gspca/etoms.c b/drivers/media

[PATCH] ARM: remove last use of CONFIG_CPU_ARM710

2013-03-28 Thread Paul Bolle
Support for ARM710 CPUs was removed in v3.5. Now remove the last code depending on its Kconfig macro. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Untested. Note that cpu_arm7_data_abort was also removed. arch/arm/include/asm/glue-df.h | 8 1 file changed, 8 deletions(-) diff

[PATCH] cirrus: cs89x0: remove two obsolete Kconfig macros

2013-03-29 Thread Paul Bolle
that macro and the code depending on it. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Compile tested only, for 32 bit x86. (Which was slightly more work than I expected, since Fedora - which I happen to run - has ISA disabled as of Fedora 17. And I use their configuration as base for my local

[PATCH] ARM: davinci: remove test for undefined Kconfig macro

2013-03-29 Thread Paul Bolle
for debugging. We can remove two lines of unneeded code. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- 0) Untested. 1) See commit 477099f189101a6675d93782164446015a3633bd (ARM: davinci: implement DEBUG_LL port choice) for the introduction of this code. arch/arm/mach-davinci/include/mach/debug

[PATCH] ASoC: Ux500: remove test for undefined Kconfig macro

2013-03-29 Thread Paul Bolle
A test for CONFIG_SND_SOC_UX500_AB5500 was added in v3.5. But there never was a corresponding Kconfig symbol so this test has always evaluated to true. And since AB5500 support was removed in v3.5 it appears safe to remove this test and a few lines of code. Signed-off-by: Paul Bolle pebo

Re: [PATCH] ARM: davinci: remove test for undefined Kconfig macro

2013-03-29 Thread Paul Bolle
[Dropped Kevin Hilman, because Kevin's address bounces.] On Fri, 2013-03-29 at 12:47 +0100, Paul Bolle wrote: The DaVinci debugging macro contains a check for CONFIG_DEBUG_DAVINCI_DA8XX_UART0. But there's corresponding Kconfig [...] there's no corresponding

[PATCH] ARM: Fix typo CONFIG_LPAE twice

2013-03-29 Thread Paul Bolle
Signed-off-by: Paul Bolle pebo...@tiscali.nl --- 0) Untested. 1) This typo was first introduced in v3.4: commit e5ab85800820edd907d3f43f285e1232f84d5a41 (ARM: 7382/1: mm: truncate memory banks to fit in 4GB space for classic MMU). The second instance was added in v3.9-rc2: commit

[PATCH] [TRIVIAL] Remove obsolete, iSeries specific, Makefile lines

2013-03-29 Thread Paul Bolle
Signed-off-by: Paul Bolle pebo...@tiscali.nl --- 0) Entirely untested. 1) See commit 3d066d77cf464ea1e47808f95243301fd2175a7f (powerpc: remove CONFIG_PPC_ISERIES from the architecture Kconfig files) and commit ba7a4822b48fbc7afd6b567c18e316a03f46684d (powerpc: Remove some of the legacy iSeries

[PATCH] ARM: Fix typo CONFIG_SAMSUNG_DEV_RTC

2013-03-29 Thread Paul Bolle
CONFIG_S3C_DEV_RTC here. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- 0) Untested. 1) Introduced in commit commit b2994d318dc78c9a4a43605629f00217335ada28 (ARM: S3C2443/S3C2416: add s3c_rtc_setname and rename rtc devices), which shipped in v3.4. Should this go to stable too (after testing

[PATCH] [TRIVIAL] Fix comment typo CONFIG_CPUIDLE

2013-03-29 Thread Paul Bolle
Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Untested. I'm far from sure what the comment tries to say, even after applying this patch. At least it now uses an actual Kconfig macro! But perhaps just dropping the CONFIG_ prefix makes more sense. arch/arm/mach-omap2/pm44xx.c | 4 ++-- 1 file

[PATCH] powerpc: Fix typo CONFIG_ICSWX_PID

2013-03-29 Thread Paul Bolle
Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Untested. As this typo was introduced in v3.3, with commit 9d670280908013004f173b2b86414d9b6918511b (powerpc: Split ICSWX ACOP and PID processing), which actually added PPC_ICSWX_PID, this surely needs testing. arch/powerpc/mm/icswx.c | 2 +- 1

[PATCH] ARM: msm: rename two Kconfig macros

2013-03-29 Thread Paul Bolle
, rename the two existing references to CONFIG_MSM_DEBUG_UART1 and CONFIG_MSM_DEBUG_UART3. Do so now. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- 0) Untested. 1) Would there actually be a readable way to write this commit explanation? This explanation even confuses me! I guess it's just

[PATCH] ARM: S3C64XX: remove obsolete Makefile line

2013-03-29 Thread Paul Bolle
-s3c64xx/dev-spi.c was already removed. So we can remove this line. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Untested. arch/arm/mach-s3c64xx/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-s3c64xx/Makefile b/arch/arm/mach-s3c64xx/Makefile index f9ce1dc..31d0c91

[PATCH] [RESEND] arch: remove CONFIG_GENERIC_FIND_NEXT_BIT again

2013-03-30 Thread Paul Bolle
CONFIG_GENERIC_FIND_NEXT_BIT was removed in v3.0, but reappeared in two architectures. Remove it again. Signed-off-by: Paul Bolle pebo...@tiscali.nl Acked-by: Jonas Bonn jo...@southpole.se --- 0) Richard asked (off list) to resend. There appear to be problems locating the patch in the archives

[PATCH] ARM: S5P64X0: Fix typo CONFIG_S5P64X0_SETUP_SDHCI

2013-03-30 Thread Paul Bolle
Commit ebc433c2890f8ecad2da39fe2dbf2b6e7b309afa (ARM: S5P64X0: Add HSMMC setup for host Controller) added the Kconfig symbol S5P64X0_SETUP_SDHCI_GPIO. By accident it also used a macro CONFIG_S5P64X0_SETUP_SDHCI. Fix that typo. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Untested. Since

[PATCH 0/8] do not export kernel integer types to userspace

2013-04-01 Thread Paul Bolle
This short series was triggered by a compile error I ran into when trying to build the lguest tool (see PATCH 1/8). After fixing that error I decided to attempt to solve all related problems. Paul Bolle (8): virtio_net: do not export u16 to userspace headers_check: add check for kernel

[PATCH 1/8] virtio_net: do not export u16 to userspace

2013-04-01 Thread Paul Bolle
Building the lguest (userspace) tool fails with this error: In file included from lguest.c:46:0: /usr/include/linux/virtio_net.h:188:2: error: unknown type name ‘u16’ make: *** [lguest] Error 1 virtio_net.h exports u16 to userspace. Use __u16 instead of u16. Signed-off-by: Paul Bolle

[PATCH 2/8] headers_check: add check for kernel integer types

2013-04-01 Thread Paul Bolle
The u8, u16, u32, and u64, and the s8, s16, s32, and s64 types shouldn't be exported to userspace. Add a simple check for these. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- scripts/headers_check.pl | 10 ++ 1 file changed, 10 insertions(+) diff --git a/scripts/headers_check.pl b

[PATCH 3/8] virtio: do not export u16 and u64 to userspace

2013-04-01 Thread Paul Bolle
virtio_balloon.h exports u16 and u64 to userspace. Use __u16 and __u64 instead. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- 0) Tested with a kernel build. 1) Both types are used in this header for quite some time now. So is my patch flawed or doesn't userspace actually use virtio_balloon.h

[PATCH 4/8] headers_check: check kernel types inside #define

2013-04-01 Thread Paul Bolle
here are just complicated enough to catch all current uses of kernel integer types inside preprocessor #defines. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- scripts/headers_check.pl | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/scripts/headers_check.pl b

[PATCH 5/8] btrfs: do not export u64 to userspace

2013-04-01 Thread Paul Bolle
btrfs.h exports u64 to userspace. Use __u64 instead. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Tested with a kernel build. I'm not familiar with userspace code using btrfs.h. include/uapi/linux/btrfs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux

[PATCH 6/8] nfsd4: do not export u64 to userspace

2013-04-01 Thread Paul Bolle
nfs4.h exports u64 to userspace. Use __u64 instead. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- 0) Tested with a kernel build. 1) I'm guessing userspace doesn't actually use NFS4_MAX_UINT64. include/uapi/linux/nfs4.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 7/8] virtio_console: do not export u32 to userspace

2013-04-01 Thread Paul Bolle
virtio_console.h exports u32 to userspace. Use __u32 instead. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- 0) Tested with a kernel build. 1) Again. I'm guessing userspace doesn't use VIRTIO_CONSOLE_BAD_ID. include/uapi/linux/virtio_console.h | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 8/8] cris: do not export u8 and friends to userspace

2013-04-01 Thread Paul Bolle
sv_addr_ag.h exports u8 and friends to userspace. Use __u8 and friends instead. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Untested. arch/cris/include/uapi/arch-v10/arch/sv_addr_ag.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/arch/cris

Re: [PATCH] [TRIVIAL] Remove obsolete, iSeries specific, Makefile lines

2013-04-01 Thread Paul Bolle
. Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 01/23] perf: initial infrasructure for kconfig

2013-04-02 Thread Paul Bolle
file changed, 5 insertions(+) create mode 100644 tools/perf/Pconfig All current Kconfig files can be found with git ls-files *Kconfig*. This file won't. Why does it need to be named differently? Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH 10/23] perf: make demangle support based on CONFIG_DEMANGLE

2013-04-02 Thread Paul Bolle
+ ... that already seems to be enforced here. config LIBPERL bool Enable support for perl scripting engine Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 09/23] perf: make cfi unwind support based on CONFIG_LIBUNWIND

2013-04-02 Thread Paul Bolle
+ Doesn't this clash with the same Kconfig symbol in arch/x86/Kconfig? +config HAVE_CFI_UNWIND_SUPPORT +bool + config NEWT bool Enable newt-based TUI Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 20/23] perf: consolidate CONFIG_LIBELF checks in Makefile

2013-04-02 Thread Paul Bolle
here for dependencies that are already enforced by the kconfig tools. Why is this needed? Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] Introduce Intel RAPL cooling device driver

2013-04-03 Thread Paul Bolle
Power Limit provides mechanisms to enforce + and monitor per domain power consumption limits of supported Intel CPUs. + endif # X86_PLATFORM_DEVICES Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

[PATCH] mtd: remove ixp2000 driver

2013-03-13 Thread Paul Bolle
Support for the IXP2000 platform got removed in commit c65f2abf54a6d07260f1fa64773154e1d7047961 (ARM: remove ixp23xx and ixp2000 platforms). That commit removed the ARCH_IXP2000 Kconfig symbol. This removes the last driver depending on that symbol. Signed-off-by: Paul Bolle pebo...@tiscali.nl

[PATCH] PM: devfreq: fix typo CPU_EXYNOS4.12 twice

2013-03-13 Thread Paul Bolle
clear that this should have been dependencies on SOC_EXYNOS4212 and SOC_EXYNOS4412. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- drivers/devfreq/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig index 0f079be..0ec6572

Re: [PATCH] PM: devfreq: fix typo CPU_EXYNOS4.12 twice

2013-03-13 Thread Paul Bolle
On Wed, 2013-03-13 at 22:10 +0100, Paul Bolle wrote: Dependencies on CPU_EXYNOS4212 and CPU_EXYNOS4412 for the ARM Exynos4210/4212/4412 Memory Bus DEVFREQ Driver were added in commit 7b4050381127ae11fcfc74a106d715a5fbbf888a (PM/Devfreq: Add Exynos4-bus device DVFS driver for Exynos4210/4212

Re: [PATCH] mtd: remove ixp2000 driver

2013-03-13 Thread Paul Bolle
On Wed, 2013-03-13 at 21:36 +0100, Paul Bolle wrote: Support for the IXP2000 platform got removed in commit c65f2abf54a6d07260f1fa64773154e1d7047961 (ARM: remove ixp23xx and ixp2000 platforms). That commit removed the ARCH_IXP2000 Kconfig symbol. This removes the last driver depending

  1   2   3   4   5   6   7   8   9   10   >