[PATCH] misc: Remove max8997-muic.o Makefile line again

2013-03-15 Thread Paul Bolle
Commit 20259849bb1ac1ffb0156eb359810e8b99cb644d ("VMCI: Some header and config files.") readded this Makefile line. Remove it again. Signed-off-by: Paul Bolle --- Bravely untested. drivers/misc/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/misc/Makefile b/dr

[PATCH] [TRIVIAL] Fix comment typo "CONFIG_IIO_RING_BUFFER"

2013-03-15 Thread Paul Bolle
Signed-off-by: Paul Bolle --- Entirely untested. include/linux/iio/gyro/itg3200.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/iio/gyro/itg3200.h b/include/linux/iio/gyro/itg3200.h index c53f169..2a82085 100644 --- a/include/linux/iio/gyro/itg3200.h +++ b

[PATCH] arc: remove #ifdef-ed out include of dead header

2013-03-15 Thread Paul Bolle
There's no (Kconfig) macro CONFIG_BLOCK_DEV_RAM. (CONFIG_BLK_DEV_RAM does exist though.) But linux/blk.h got killed in 2005 anyway (in a patch titled "kill blk.h"), so these three lines can be removed. Signed-off-by: Paul Bolle --- Untested (no relevant hardware or compiler)

[PATCH] [TRIVIAL] Fix comment typo "CONFIG_MISALIGN_ACCESS"

2013-03-15 Thread Paul Bolle
Signed-off-by: Paul Bolle --- Entirely untested. arch/arc/kernel/disasm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arc/kernel/disasm.c b/arch/arc/kernel/disasm.c index 2f39028..d14764a 100644 --- a/arch/arc/kernel/disasm.c +++ b/arch/arc/kernel/disasm.c @@ -535,4

[PATCH] firewire: Remove two unneeded checks for macros

2013-03-16 Thread Paul Bolle
The old IEEE 1394 driver stack was removed in v2.6.37. That made the checks for two Kconfig (module) macros unneeded, since they will now always evaluate to true. Remove these two checks. Signed-off-by: Paul Bolle --- Perhaps these alias can be dropped entirely. Bat that's not my call. dr

Re: RAMster selects HAVE_ALIGNED_STRUCT_PAGE on 64 bit systems when it should not

2013-03-16 Thread Paul Bolle
sequences about this, but I guess this > should be reviewed and fixed, probably by just removing the underscore from > 64_BIT in drivers/staging/zcache/Kconfig. It's an obvious typo. See the patch I sent last week: https://lkml.org/lkml/2013/3/9/106 . I have not yet received any fee

[PATCH] checkpatch: stop checking for CONFIG_EXPERIMENTAL

2013-03-16 Thread Paul Bolle
invalid Kconfig symbols and macros again. Signed-off-by: Paul Bolle --- 0) Checkpatch tested! 1) A lot of defconfigs still have CONFIG_EXPERIMENTAL in them. How should that be cleaned up? scripts/checkpatch.pl | 13 - 1 file changed, 13 deletions(-) diff --git a/scripts/checkpat

[PATCH v2] qla2xxx: silence two GCC warnings

2012-10-02 Thread Paul Bolle
on to keep track of array bounds. Signed-off-by: Paul Bolle --- 0) Rolf suggested to not use magic constants, to make sure things keep working when these strings change in the future. A trivial solution is to use preprocessor macros. I needed to add one for the manufacturer string. 1) Still only co

Re: [PATCH] regmap: silence GCC warning

2012-10-03 Thread Paul Bolle
On Tue, 2012-10-02 at 20:11 -0400, valdis.kletni...@vt.edu wrote: > On Mon, 01 Oct 2012 11:03:21 +0100, Mark Brown said: > > On Sun, Sep 30, 2012 at 12:15:55PM +0200, Paul Bolle wrote: > > > Building regmap.o triggers this GCC warning: > > > drivers/base/r

[PATCH v3] qla2xxx: silence two GCC warnings

2012-10-05 Thread Paul Bolle
nough information to keep track of array bounds. Signed-off-by: Paul Bolle --- 0) Updated for Saurav's request to use strncpy(). 1) Still only compile tested. drivers/scsi/qla2xxx/qla_def.h | 1 + drivers/scsi/qla2xxx/qla_gs.c | 8 2 files changed, 5 insertions(+), 4 deletions(-) di

[PATCH] [media] budget-av: only use t_state if initialized

2012-11-01 Thread Paul Bolle
uninitialized in this function [-Wuninitialized] Move the printk() that uses t_state.bandwith to the location where it should be initialized to fix this. Signed-off-by: Paul Bolle --- 0) Compile tested only. 1) By the way, the first two if()-tests in tda8261_get_bandwidth() should be superfluous

[PATCH] [media] tda18212: tda18218: use 'val' if initialized

2012-11-01 Thread Paul Bolle
alized_var() stopgap measure. Also stop printing the return values of tda18212_rd_reg() or tda18218_rd_reg(), as these are not interesting. Signed-off-by: Paul Bolle --- 0) Compile tested only. drivers/media/tuners/tda18212.c | 6 +++--- drivers/media/tuners/tda18218.c | 6 +++--- 2 files change

[PATCH] xfs: silence GCC warning

2012-11-02 Thread Paul Bolle
ed, but there appears to be no easy way to give GCC enough information to determine that. So let's silence this warning, using the pattern Ingo Molnar recently suggested. Signed-off-by: Paul Bolle --- 0) Compile tested only. 1) I fear that the only way to give GCC the information it needs to d

Re: [PATCH] xfs: silence GCC warning

2012-11-02 Thread Paul Bolle
On Fri, 2012-11-02 at 09:07 -0400, Christoph Hellwig wrote: > Looks good, Dave has actually sent it a tidbit earlier as part > of his series with fixes for 3.7-rc I see, thanks. Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

[PATCH] atp: remove set_rx_mode_8012()

2012-11-03 Thread Paul Bolle
7; will be used uninitialized in set_rx_mode_8012(), which is apparently inlined into set_rx_mode(). But it turns out set_rx_mode_8012() will never be called, since net_local.chip_type will always be RTL8002. So we can just remove set_rx_mode_8012() and do some related cleanups. Signed-off-by:

Re: [PATCH 8/9] isdn: Remove unused variable causing a compile build warning

2012-11-03 Thread Paul Bolle
On Sat, 2012-11-03 at 23:02 +0100, Lee Jones wrote: > This patch fixes: > drivers/isdn/i4l/isdn_common.c: In function ‘isdn_ioctl’: > drivers/isdn/i4l/isdn_common.c:1278:8: warning: unused variable ‘s’ > [-Wunused-variable] Did you have CONFIG_NETDEVICES not set in this build?

Re: [PATCH 8/9] isdn: Remove unused variable causing a compile build warning

2012-11-04 Thread Paul Bolle
On Sat, 2012-11-03 at 23:48 +0100, Lee Jones wrote: > On Sat, 03 Nov 2012, Paul Bolle wrote: > > On Sat, 2012-11-03 at 23:02 +0100, Lee Jones wrote: > > > This patch fixes: > > > drivers/isdn/i4l/isdn_common.c: In function ‘isdn_ioctl’: > > > drivers/isdn/i4l/i

Re: [PATCH 8/9] isdn: Remove unused variable causing a compile build warning

2012-11-05 Thread Paul Bolle
dn_common.c? If ISDN would depend on NETDEVICES, ISDN_I4L would too, since it depends on ISDN. In that case CONFIG_NETDEVICES would always be true when compiling isdn_common.c. That would make these guards pointless. (The dependency of ISDN_PPP on NETDEVICES would then also be pointless.) Paul Bol

[PATCH] [SCSI] advansys: change buildtime warning into runtime error

2012-11-05 Thread Paul Bolle
work. So let's change the buildtime warning into a runtime error, only printed for those wide boards. Perhaps that might push the people using those wide boards to convert this driver. And for all others there's now one less buildtime warning to ignore. Signed-off-by: Paul Bolle --- Compil

[PATCH] aic7xxx_old: silence GCC warnings

2012-09-21 Thread Paul Bolle
warnings by adopting the idiom used elsewhere in this driver. Since AHC_EISA and AHC_VL are only ever set for AHC_AIC7770 this fix should not lead to any functional change. Signed-off-by: Paul Bolle --- 0) I noticed these warnings while building v3.6-rc6 on current Fedora 17, using Fedora's

[PATCH] ipw2x00: silence GCC warning for unused variable 'dev'

2012-09-21 Thread Paul Bolle
away. Fix it by substituting ieee->dev for (its equivalent) dev. Signed-off-by: Paul Bolle --- 0) I noticed this warning while building v3.6-rc6 on current Fedora 17, using Fedora's default config. 1) Compile tested only (by just compiling libipw_wx.o). drivers/net/wireless/ipw2x00/lib

[PATCH] mISDN: suppress compiler warning

2012-09-21 Thread Paul Bolle
irq() will always return 0. Suppress this warning in the way a few other drivers do that too. Signed-off-by: Paul Bolle --- 0) I noticed this warning while building v3.6-rc6 on current Fedora 17, using Fedora's default config. 1) Compile tested only. drivers/isdn/hardware/mISDN/hfcpci.c |

[PATCH] rtc: m41t80: remove disabled alarm functionality

2012-09-21 Thread Paul Bolle
d [-Wunused-function] Remove these functions (and the commented out references to them) to silence these warnings. Anyone wanting to fix the alarm irq functionality can easily find the removed code in the git log of this file or through some web searches. Signed-off-by: Paul Bolle --- 0) I no

[PATCH] mvsas: use correct named constants

2012-09-21 Thread Paul Bolle
as_device_type' and 'enum sas_dev_type' [-Wenum-compare] Silence these warnings by using the named constants from enum sas_device_type with the same value as the currently used named constants. Signed-off-by: Paul Bolle --- 0) I noticed these warnings while building v3.6-rc6 on current

x86: "Fast TSC calibration failed" error

2012-09-24 Thread Paul Bolle
to submit the trivial patch to downgrade it to (say) informational level. Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] aic94xx: fix handling of default CTRL-A settings

2012-09-25 Thread Paul Bolle
all (and all other unneeded code) after creating that section. Signed-off-by: Paul Bolle --- 0) I noticed this warning while building v3.6-rc7 on current Fedora 17, using Fedora's default config. 1) Compile tested only. It might be best to run test this too, if only to test whether the non

[PATCH] x86, tsc: downgrade message for fast calibration failure

2012-09-26 Thread Paul Bolle
Signed-off-by: Paul Bolle --- 0) This is a rather verbose commit explanation. For trivialities like these I try to write a very short explanation. But here the verbosity is meant to obfuscate my complete ignorance of the (calibration of the) TSC. 1) By the way, it's debatable whether th

Re: [PATCH] IB/lmx4: silence GCC warning

2012-10-29 Thread Paul Bolle
r example, mlx4_ib_post_send() in > the same file (qp.c). Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] aic7xxx_old: silence GCC warnings

2012-10-29 Thread Paul Bolle
On Fri, 2012-09-21 at 11:28 +0200, Paul Bolle wrote: > Building the aic7xxx_old driver triggers these GCC warnings: > drivers/scsi/aic7xxx_old.c:7901:5: warning: case value '257' not in > enumerated type 'ahc_chip' [-Wswitch] > drivers/scsi/aic7xxx_old.c:

Re: [PATCH] mvsas: use correct named constants

2012-10-29 Thread Paul Bolle
On Fri, 2012-09-21 at 14:11 +0200, Paul Bolle wrote: > Building the mvsas driver triggers these GCC warnings: > drivers/scsi/mvsas/mv_sas.c:1156:34: warning: comparison between 'enum > sas_device_type' and 'enum sas_dev_type' [-Wenum-compare] > drivers/scsi

Re: [PATCH] aic94xx: fix handling of default CTRL-A settings

2012-10-29 Thread Paul Bolle
On Tue, 2012-09-25 at 14:07 +0200, Paul Bolle wrote: > Compiling aic94xx_sds.o (part of the aic94xx driver) triggers this GCC > warning: > drivers/scsi/aic94xx/aic94xx_sds.c: In function 'asd_read_flash': > drivers/scsi/aic94xx/aic94xx_sds.c:597:21: warni

Re: [PATCH] aic7xxx_old: silence GCC warnings

2012-10-29 Thread Paul Bolle
> maintainerless, so it will depend on someone finding the time to test. Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] USB: io_edgeport: remove unused variable

2012-10-30 Thread Paul Bolle
ch to remove this variable. Paul Bolle --- The stable commit 12ddc74e8e25107eda81aceb74e3311c1480b381 ("USB: io_edgeport: fix port-data memory leak") left one variable unused: drivers/usb/serial/io_edgeport.c: In function 'edge_release': drivers/usb/serial/io_edgeport.

Re: NULL pointer dereference at fat_detach

2012-10-30 Thread Paul Bolle
e 8:17 is not mounted) Oct 17 11:52:36 x61 kernel: [15141.653798] VFS: Busy inodes after unmount of sdb1. Self-destruct in 5 seconds. Have a nice day... Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vge

Re: NULL pointer dereference at fat_detach

2012-10-31 Thread Paul Bolle
On Wed, 2012-10-31 at 09:49 +0900, OGAWA Hirofumi wrote: > This bug is known as the inotify bug. I recall I talked about this, > maybe years ago. Would that be this thread: https://lkml.org/lkml/2011/6/10/155 ? Paul Bolle -- To unsubscribe from this list: send the line "unsubs

Re: [Xen-devel] [PATCH] xen: remove unused Kconfig parameter

2013-07-08 Thread Paul Bolle
ed, because grub2's check for it is actually superfluous. Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 2/2] PCI,pciehp: avoid add a device already exist during pciehp_resume

2013-07-09 Thread Paul Bolle
mfortable message like > > pciehp :00:1c.1:pcie04: Device :03:00.0 already exists at > :03:00, cannot hot-add > pciehp :00:1c.1:pcie04: Cannot add device at :03:00 > > This problem was reported by Paul Bolle > The discussion link: http://com

Re: [Xen-devel] [PATCH] xen: remove unused Kconfig parameter

2013-07-11 Thread Paul Bolle
s both evaluate to true or both evaluate to false. One of these two commands can safely be dropped. Another consequence is that dropping XEN_PRIVILEGED_GUEST doesn't break this configuration script. It will still behave as it does now. (Whether that script should grep for Kconfig macros in the

Re: [PATCH 2/2] PCI,pciehp: avoid add a device already exist during pciehp_resume

2013-07-11 Thread Paul Bolle
ht? Yes. I actually wouldn't even know how to remove it. I only discovered my wireless card was in a pcie slot because of the error messages at resume (which started a few releases ago, I think v3.7). Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kerne

Re: [PATCH -v2 0/3] Use PCIe DSN to improve pciehp_resume

2013-07-11 Thread Paul Bolle
|3 ++ > 4 files changed, 83 insertions(+), 3 deletions(-) Series applies cleanly to v3.10 (but there was a small problem with 3/3, which I'll mention in a reply to that patch). Compiles without warning. Those two errors on every resume are now gone! Thanks. Paul Bolle

Re: [PATCH -v2 1/3] PCI: introduce PCIe Device Serial Number Capability support

2013-07-11 Thread Paul Bolle
list_head msi_list; > struct kset *msi_kset; > #endif > + u64 sn; /* device serieal number, 0 if not support */ Typo: serieal > struct pci_vpd *vpd; > #ifdef CONFIG_PCI_ATS > union { [...] Paul Bolle -- To unsubscribe from this lis

Re: [PATCH -v2 2/3] PCI,pciehp: avoid add a device already exist before suspend during resume

2013-07-11 Thread Paul Bolle
ause the device add action will fail. Also print some uncomfortable > messages like this: > pciehp :00:1c.1:pcie04: Device :03:00.0 already exists at > :03:00, cannot hot-add > pciehp :00:1c.1:pcie04: Cannot add device at :03:00 > > Signed-off-by: Yi

Re: [PATCH -v2 3/3] PCI,pciehp: use PCIe DSN to identify device change during suspend

2013-07-11 Thread Paul Bolle
pciehp_disable_slot(slot); > It was surprisingly hard to see why the patch wouldn't apply to v3.10. It turns out the very last line of context is a line consisting of just a single tab. And in v3.10 it is an empty line. Is that lone tab perhaps an editing mistake on your

Re: [Xen-devel] [PATCH] xen: remove unused Kconfig parameter

2013-07-11 Thread Paul Bolle
On Thu, 2013-07-11 at 10:57 -0700, H. Peter Anvin wrote: > On 07/11/2013 03:08 AM, Paul Bolle wrote: > > But the Kconfig entry for XEN_PRIVILEGED_GUEST reads: > > # Dummy symbol since people have come to rely on the PRIVILEGED_GUEST > > # name in tools. > >

Re: [PATCH] cpufreq: Fix cpufreq regression after suspend/resume

2013-07-13 Thread Paul Bolle
to some other governor and then back to ondemand. Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH -v2 0/3] Use PCIe DSN to improve pciehp_resume

2013-07-13 Thread Paul Bolle
Yijing, On Fri, 2013-07-12 at 09:52 +0800, Yijing Wang wrote: > Do you wireless card support Device Serial Number ? > You can confirm it by lspci -vvv. Yes, it does: lspci -vvv -s 03:00 | grep Serial Capabilities: [140 v1] Device Serial Number [...] Paul Bolle -- To unsub

Re: [PATCH 1/8] cpufreq: Revert commit a66b2e to fix cpufreq regression during suspend/resume

2013-07-13 Thread Paul Bolle
ert only the remaining ones). > > > > Cc: sta...@vger.kernel.org > > Signed-off-by: Srivatsa S. Bhat > > --- > > > > drivers/cpufreq/cpufreq.c |4 +++- > > drivers/cpufreq/cpufreq_stats.c | 6 ++ > > 2 files changed, 5 insertions(+),

Re: [PATCH] cpufreq: Fix cpufreq regression after suspend/resume

2013-07-13 Thread Paul Bolle
On Sat, 2013-07-13 at 12:16 +0200, Paul Bolle wrote: > I suspect that the stuck frequency is a regression introduced in v3.10.0. The culprit apparently is commit a66b2e503f ("cpufreq: Preserve sysfs files across suspend/resume"). Srivatsa submitted a patch to revert that comm

[PATCH] staging/lustre/libcfs: fix typo "default false"

2013-07-13 Thread Paul Bolle
Commit 4b5b4c7222 ("staging/lustre/libcfs: restore LINVRNT") added "default false" to this Kconfig file. It was obviously meant to use "default n" here. Signed-off-by: Paul Bolle --- 0) Tested lightly, with "make menuconfig" only. 1) No-one noticed becau

[PATCH v2] staging/lustre/libcfs: staging/lustre/libcfs: drop bogus Kconfig default

2013-07-13 Thread Paul Bolle
Commit 4b5b4c7222 ("staging/lustre/libcfs: restore LINVRNT") added "default false" to this Kconfig file. It was obviously meant to use "default n" here. But we might as well drop this line, as a Kconfig bool defaults to 'n' anyway. Signed-off-by: Paul Bolle

Re: [PATCH v2] staging/lustre/libcfs: staging/lustre/libcfs: drop bogus Kconfig default

2013-07-13 Thread Paul Bolle
Greg, I'm afraid I botched the Subject line. Please remove one instance of "staging/lustre/libcfs:" from the summary. Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org Mor

[PATCH v3] staging/lustre/libcfs: drop bogus Kconfig default

2013-07-13 Thread Paul Bolle
Commit 4b5b4c7222 ("staging/lustre/libcfs: restore LINVRNT") added "default false" to this Kconfig file. It was obviously meant to use "default n" here. But we might as well drop this line, as a Kconfig bool defaults to 'n' anyway. Signed-off-by: Paul Bolle

[PATCH] ARM: multiplatform: remove reference to ARCH_MULTI_V4

2013-07-13 Thread Paul Bolle
The Kconfig symbol ARCH_MULTI_V4 was removed in commit 24e860fbfd ("ARM: multiplatform: always pick one CPU type"). Remove the last reference to it too. Signed-off-by: Paul Bolle --- 0) Untested. 1) Commit 24e860fbfd is silent on the reason to drop ARCH_MULTI_V4. And the ARM sect

Re: scsi: delete decade+ obsolete aic7xxx_old driver

2013-09-17 Thread Paul Bolle
build[2]. And now that driver is disabled in all kernels that Fedora currently ships. I'm not familiar with any complaints about this decision. Paul Bolle [1] https://lists.fedoraproject.org/pipermail/kernel/2013-February/004102.html [2] http://pkgs.fedor

[PATCH v2] mei: me: downgrade two errors to debug level

2013-09-19 Thread Paul Bolle
The mei_me driver prints "suspend" at error level at each suspend. It also prints "stop" at error level at driver unload. Downgrade these uninteresting messages to debug level. Signed-off-by: Paul Bolle --- 0) v1 was called "mei: me: downgrade "suspend&quo

Re: [PATCH] scsi: fix the build warning

2013-09-20 Thread Paul Bolle
On Thu, 2013-08-22 at 23:49 +0900, Akinobu Mita wrote: > 2013/8/22 James Bottomley : > > On Thu, 2013-08-22 at 21:42 +0900, Akinobu Mita wrote: > >> Unfortunately, this warning isn't fixed in linux-next, either. > >> Paul Bolle also sent a patch that fixes the s

Re: [PATCH] scsi: fix the build warning

2013-09-20 Thread Paul Bolle
On Fri, 2013-09-20 at 23:32 +0900, Akinobu Mita wrote: > Yesterday, I sent a patch set which includes two fixes for this issue. > I wish this to be merged and I'll do my best. I hadn't yet stumbled onto these patches. Thanks! Paul Bolle -- To unsubscribe from this lis

Re: [PATCH] mei: me: downgrade "suspend" message to debug level

2013-09-12 Thread Paul Bolle
On Thu, 2013-09-12 at 21:17 +0200, Paul Bolle wrote: > The mei_me driver prints "suspend" at error level at each suspend. > Downgrade that uninteresting message to debug level. > > Signed-off-by: Paul Bolle > --- > Lightly tested (on top of v3.10.10, actually). Should

[PATCH] mei: me: downgrade "suspend" message to debug level

2013-09-12 Thread Paul Bolle
The mei_me driver prints "suspend" at error level at each suspend. Downgrade that uninteresting message to debug level. Signed-off-by: Paul Bolle --- Lightly tested (on top of v3.10.10, actually). Should apply cleanly to v3.11 or current master. Perhaps a better fix is to remove th

Re: [PATCH] x86, tsc: downgrade fast calibration failure message

2013-09-03 Thread Paul Bolle
On Tue, 2013-09-03 at 10:09 -0400, Jerome Oufella wrote: > As pointed out by Paul Bolle in https://lkml.org/lkml/2012/9/24/221, the > fast TSC calibration method may fail on some machines and result in an > error level message that does not reflect the severity of the case. > >

Re: [PATCH v2] mei: me: downgrade two errors to debug level

2013-09-26 Thread Paul Bolle
On Thu, 2013-09-26 at 11:56 +0300, Tomas Winkler wrote: > On Thu, Sep 19, 2013 at 1:17 PM, Paul Bolle wrote: > > The mei_me driver prints "suspend" at error level at each suspend. It > > also prints "stop" at error level at driver unload. Downgrade these > &

Re: [PATCH] regmap: silence GCC warning

2012-10-06 Thread Paul Bolle
On Sat, 2012-10-06 at 09:53 +0100, Mark Brown wrote: > On Fri, Oct 05, 2012 at 06:20:44PM -0400, valdis.kletni...@vt.edu wrote: > > On Wed, 03 Oct 2012 09:23:36 +0200, Paul Bolle said: > > > That is another way to silence GCC here. > > > That's probably a pref

[PATCH v2] regmap: silence GCC warning

2012-10-08 Thread Paul Bolle
type mismatch between 'num' in regmap_volatile_range() and 'val_count' in regmap_raw_read(). And indeed, converting 'num' to the type of 'val_count' (ie, size_t) makes this warning go away. Signed-off-by: Paul Bolle --- drivers/base/regmap/regmap.c | 2 +- 1

[PATCH] drm/nv40/pm: silence GCC warnings

2012-10-08 Thread Paul Bolle
e detailed information a little earlier. See, get_pll_limits() returns an error-code integer (ie, negative on failure, zero on success). And a trivial tweak to nv40_calc_pll() that takes this into account makes these errors go away. Signed-off-by: Paul Bolle --- 0) I noticed these warnings while

Re: ext3 issue on 3.6.1

2012-10-18 Thread Paul Bolle
race e60232a455c8e2dd ]--- > And this seems unrelated - likely an NFS problem... Let's sort this out > if you still see it after ext3 issue is solved. Looks rather similar too https://lkml.org/lkml/2012/8/29/165 , doesn't it? Paul Bolle -- To unsubscribe from this list: send the

mfd: lpc_ich: NULL pointer dereference at (second) module removal

2012-11-09 Thread Paul Bolle
+33>:je 0xa8 0x00a3 <+35>:cmp%rdx,%rax 0x00a6 <+38>:jbe0xab [...] (gdb) printf "0x%0x\n", (size_t) &((struct mfd_cell *)0)->usage_count 0x10 3) So to me it looks like "cell" is NULL here, and we oop

Re: [PATCH] [RFC] drm/radeon: return 0 on successful gpu reset

2012-12-18 Thread Paul Bolle
On Tue, 2012-12-18 at 10:22 -0500, Alex Deucher wrote: > On Tue, Dec 18, 2012 at 5:36 AM, Christian König > wrote: > > On 17.12.2012 22:31, Paul Bolle wrote: > >> 1) Sent as an RFC because I do not understand why this laptop (almost > >> always) prints the "cr

Re: [PATCH] [RFC] drm/radeon: return 0 on successful gpu reset

2012-12-21 Thread Paul Bolle
On Thu, 2012-12-20 at 13:37 -0500, Alex Deucher wrote: > On Tue, Dec 18, 2012 at 12:28 PM, Paul Bolle wrote: > > On Tue, 2012-12-18 at 10:22 -0500, Alex Deucher wrote: > >> On Tue, Dec 18, 2012 at 5:36 AM, Christian König > >> wrote: > >> > You should d

Re: mfd: lpc_ich: NULL pointer dereference at (second) module removal

2012-11-19 Thread Paul Bolle
e (second or later) removal of lpc_ich. So this patch seems to do the trick. 1) Could you please send this patch to stable too (when it finally hits mainline, that is)? A quick glance suggests it can be backported to as far v3.0 (but I only tested v3.6.y, see above). Thanks, Paul Bolle -- To un

[PATCH] mfd: lpc_ich: one uninitialized cell is no error

2012-11-19 Thread Paul Bolle
ating the failure to add a single cell as an error. Those messages can be printed at notice level. And then only warn if no cells were added. Signed-off-by: Paul Bolle --- 0) This patch was written on top of v3.7-rc4 and tested on v3.6.7. 1) Please note that this patch prints a warning when no MFD

[PATCH] radeon: add AGPMode 1 quirk for RV250

2012-11-19 Thread Paul Bolle
The Intel 82855PM host bridge / Mobility FireGL 9000 RV250 combination in an (outdated) ThinkPad T41 needs AGPMode 1 for suspend/resume (under KMS, that is). So add a quirk for it. (Change R250 to RV250 in comment for preceding quirk too.) Signed-off-by: Paul Bolle --- 0) Last tested on v3.6.7

Re: [PATCH V6 2/3] efi: Pass boot services variable info to runtime code

2013-04-22 Thread Paul Bolle
e_size = store_size; > + efidata->remaining_size = remaining_size; > + efidata->max_var_size = var_size; > + > + if (data) > + data->next = (unsigned long)efidata; > + else > + params->hdr.setup_data = (unsigned long)efidata; &g

Re: [PATCH] drm/omap: change "!CONFIG_FB_OMAP2" to "!FB_OMAP2"

2013-06-13 Thread Paul Bolle
On Wed, 2013-03-13 at 20:48 +0100, Paul Bolle wrote: > Signed-off-by: Paul Bolle > --- > Untested. Perhaps the first test that people with access to the relevant > hardware might do, is to test _before applying this patch_ with FB_OMAP2 > set. Perhaps this negative dependency isn&

Re: PPC440GX (taishan config) compilation errors

2013-06-15 Thread Paul Bolle
{standard input}:82: Error: Unrecognized opcode: `mfdcrx' > make[1]: *** [arch/powerpc/boot/treeboot-currituck.o] Error 1 > make: *** [uImage] Error 2 > > Question: > > a. why is the "mkdir -p arch/powerpc/boot/" repeated so many times? > b. what is the cause o

[PATCH] rbd: silence GCC warnings

2013-06-17 Thread Paul Bolle
quot;type" is "OBJ_REQUEST_BIO". Add harmless initializations to NULL to help GCC. Signed-off-by: Paul Bolle --- 0) Compile tested only. 1) These warnings were introduced in v3.10-rc1, apparently through commit f1a4739f33 ("rbd: support page array image requests"). 2)

[PATCH] rbd: remove RBD_DEBUG

2013-06-17 Thread Paul Bolle
The RBD_DEBUG macro is always defined, so it serves no purpose. Removing it has the benefit that readers of the code won't be tricked into thinking that rbd_assert() will compile away because they didn't define RBD_DEBUG themselves. Signed-off-by: Paul Bolle --- Compile tested only.

[PATCH] ioatdma: silence GCC warnings

2013-06-17 Thread Paul Bolle
bounds [-Warray-bounds] These warnings are caused by pq16_set_src(). It uses "int idx" as an index to an eight element array. Changing "idx" to unsigned int silences these warnings. Apparently GCC can then determine that "idx" will never be negative. Signed-off-by: Pau

[PATCH] drm/tegra: Include linux/types.h

2013-06-17 Thread Paul Bolle
"make headers_check" complains about include/uapi/drm/tegra_drm.h: [...]/usr/include/drm/tegra_drm.h:21: found __[us]{8,16,32,64} type without #include So let's include linux/types.h in this header. Signed-off-by: Paul Bolle --- Tested only with "make headers_chec

Re: [PATCH] drm/tegra: Include linux/types.h

2013-06-17 Thread Paul Bolle
On Mon, 2013-06-17 at 22:33 +0200, Thierry Reding wrote: > That has already been fixed in linux-next. This header was added in v3.10-rc1. The fix in linux-next will ship in v3.11. Isn't that fix appropriate for (one of) the upcoming v3.10 release candidate(s)? Thanks, Paul Boll

[PATCH] x86: Remove check for CONFIG_X86_MCE_P4THERMAL

2013-05-29 Thread Paul Bolle
The Kconfig symbol X86_MCE_P4THERMAL was removed in v2.6.32. Remove a useless check for its macro, as it will now always evaluate to false. Signed-off-by: Paul Bolle --- Entirely untested. arch/x86/kernel/apic/apic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86

[PATCH] ASoC: OMAP: Remove obsolete Makefile line

2013-05-30 Thread Paul Bolle
Support for omap2evm was removed in v3.0. But only one of its two lines in this Makefile was removed. Remove the second line too. Signed-off-by: Paul Bolle --- Eyeball tested only. sound/soc/omap/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/omap/Makefile b/sound/soc

[PATCH] MIPS: DEC: remove unbuildable promcon.c

2013-05-30 Thread Paul Bolle
promcon.o is built if CONFIG_PROM_CONSOLE is set. But there's no Kconfig symbol PROM_CONSOLE, so promcon.c is unbuildable. Remove it. Signed-off-by: Paul Bolle --- 0) Untested. 1) There used to be a Kconfig symbol PROM_CONSOLE. But it was SPARC specific and it was removed in v2.6.32, see c

[PATCH] MIPS: MSP71xx: Remove gpio drivers

2013-05-30 Thread Paul Bolle
ion"). So these drivers were never buildable. Perhaps no-one noticed because there are no in tree users of msp71xx_init_gpio() and msp71xx_init_gpio_extended(). Anyhow, these drivers can safely be removed. Signed-off-by: Paul Bolle --- Entirely untested. arch/mips/include/asm/mach-pmcs-

[PATCH] ARM: OMAP2+: Remove obsolete Makefile line

2013-05-30 Thread Paul Bolle
The OMAP runtime PM implementation was removed in v3.0. But one Makefile line, which was used to tweak CFLAGS, was overlooked. Remove it too. Signed-off-by: Paul Bolle --- Untested. This cleans up after commit 638080c37a ("OMAP2+ / PM: move runtime PM implementation to use device power do

Re: [PATCH] fs/cepth compile error

2013-06-10 Thread Paul Bolle
ctl.o from the Makefile to fix. $ git cat-file blob v3.9.2:fs/ceph/ioctl.c | wc -l 285 $ git cat-file blob v3.9.5:fs/ceph/ioctl.c | wc -l 285 Didn't you just, somehow, delete fs/ceph/ioctl.c locally? Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-ke

[PATCH] tile: remove two outdated Kconfig entries

2013-03-21 Thread Paul Bolle
Tile support got added in v2.6.36. Its main Kconfig file was added with two outdated Kconfig entries. DEFAULT_MIGRATION_COST is unused since v2.6.23, and SEMAPHORE_SLEEPERS is unused since v2.6.26. Remove these outdated entries now. Signed-off-by: Paul Bolle --- Untested. arch/tile/Kconfig | 9

[PATCH] video: nuc900fb: remove "config FB_NUC900_DEBUG"

2013-03-21 Thread Paul Bolle
When the NUC900 LCD Controller Driver got added (in v3.4) a Kconfig entry for FB_NUC900_DEBUG got added too. It has never been used. It appears that its users were dropped during review. Anyhow, this entry can be removed. Signed-off-by: Paul Bolle --- Untested. drivers/video/Kconfig | 7

Re: [PATCH] video: nuc900fb: remove "config FB_NUC900_DEBUG"

2013-03-21 Thread Paul Bolle
On Thu, 2013-03-21 at 21:20 +0100, Paul Bolle wrote: > When the NUC900 LCD Controller Driver got added (in v3.4) a Kconfig > entry for FB_NUC900_DEBUG got added too. It has never been used. It > appears that its users were dropped during review. Anyhow, this entry > can be removed. >

[PATCH] Blackfin: remove "config IP_CHECKSUM_L1"

2013-03-21 Thread Paul Bolle
The only user of Kconfig symbol IP_CHECKSUM_L1 got removed in v2.6.33, with commit ddf9ddacef0989fdeb22e182212a232488f0f3ad ("Blackfin: convert to generic checksum code"). We can remove the Kconfig entry for this unused symbol now. Signed-off-by: Paul Bolle --- Untested. arch/blackf

[PATCH] ARM: OMAP1: remove "config MACH_OMAP_HTCWIZARD"

2013-03-21 Thread Paul Bolle
The Kconfig symbol MACH_OMAP_HTCWIZARD got added in v2.6.30. It has never been used. Its entry can safely be removed. Signed-off-by: Paul Bolle --- Untested. arch/arm/mach-omap1/Kconfig | 6 -- 1 file changed, 6 deletions(-) diff --git a/arch/arm/mach-omap1/Kconfig b/arch/arm/mach-omap1

[PATCH] appletalk: remove "config IPDDP_DECAP"

2013-03-21 Thread Paul Bolle
The Kconfig symbol IPDDP_DECAP got added in v2.1.75. It has never been used. Its entry can safely be removed. Signed-off-by: Paul Bolle --- 0) No, v2.1.75 is not a typo. 1) A follow up patch might involve some corrections to the IPDDP and IPDDP_ENCAP entries and to Documentation/networking

[PATCH] cpuimx27 and mbimx27: prepend CONFIG_ to Kconfig macro

2013-03-21 Thread Paul Bolle
Commit 2d66c7803595da0d4bcd949825d598575f5de9e6 ("cpuimx27 and mbimx27: allow fine control of UART4 and SDHC2 usage") added the Kconfig symbol MACH_EUKREA_CPUIMX27_USEUART4. But it forgot to prepend CONFIG_ to the use of its macro. Add that prefix now. Signed-off-by: Paul Bolle --

[PATCH] arch: remove KCORE_ELF again

2013-03-21 Thread Paul Bolle
The Kconfig symbol KCORE_ELF was removed in v2.6.0, but reappeared in two architectures. It is useless. Remove it again. Signed-off-by: Paul Bolle --- 0) Untested. 1) Sent as one patch. Feel free to tell me to split it up in two patches. arch/tile/Kconfig | 5 - arch/xtensa/Kconfig

Re: [PATCH] arch: remove KCORE_ELF again

2013-03-22 Thread Paul Bolle
On Fri, 2013-03-22 at 15:44 -0400, Chris Metcalf wrote: > I took the tile part of this patch into the tile tree. Thanks! Should I (try to) remember to send future patches for tile, if any, separately? Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel

[PATCH] CRIS: remove "config OOM_REBOOT"

2013-03-22 Thread Paul Bolle
The Kconfig symbol OOM_REBOOT got added in v2.6.25. It has never been used. Its entry can safely be removed. Signed-off-by: Paul Bolle --- Untested. arch/cris/Kconfig | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/cris/Kconfig b/arch/cris/Kconfig index b02ca1b..64c590f 100644 --- a

[PATCH] um: remove "config STDIO_CONSOLE"

2013-03-23 Thread Paul Bolle
The only user of Kconfig symbol STDIO_CONSOLE was removed in v2.5.65. Its entry can safely be removed. Signed-off-by: Paul Bolle --- 0) Untested. 1) A short history of STDIO_CONSOLE and CONFIG_STDIO_CONSOLE CONFIG_STDIO_CONSOLE was added in v2.4.9 (August 2001). It wrapped a call of

Re: [PATCH 21/21] cris: drop unused Kconfig symbols

2013-03-23 Thread Paul Bolle
fig symbols unused in mainline? (Note that there's a second order effect to this patch: ETRAX_ETHERNET_IFACE0, and ETRAX_ETHERNET_IFACE1, and ETRAX_SERIAL_PORT4 could also be dropped. I'm happy to submit a patch with those included too.) Paul Bolle -- To unsubscribe from this list: send

[PATCH] staging: lirc: remove dead code

2013-03-25 Thread Paul Bolle
lirc uses the CONFIG_SA1100_BITSY Kconfig macro. But its Kconfig symbol was removed in v2.4.13. So we can remove a few lines of dead code. Signed-off-by: Paul Bolle --- Untested, but of rather low risk. Note that support for the machine_is_bitsy() macro was already removed in v2.4.10. drivers

[PATCH] [TRIVIAL] irq: versatile: rename Kconfig macro in printk

2013-03-25 Thread Paul Bolle
Commit 2389d5014342e9535aad212d0c68d439aaf534ba ("ARM: plat-versatile: move FPGA irq driver to drivers/irqchip") changed Kconfig symbol PLAT_VERSATILE_FPGA_IRQ_NR to VERSATILE_FPGA_IRQ_NR. It forgot to change one reference to the related macro in a printk. Signed-off-by: Paul Bolle --

Re: [PATCH] staging: lirc: remove dead code

2013-03-25 Thread Paul Bolle
On Mon, 2013-03-25 at 13:40 +0400, Denis Kirjanov wrote: > Just found that the exactly the same patch has been posted a while ago: > http://driverdev.linuxdriverproject.org/pipermail/devel/2012-November/033623.html Thanks for that. Is that previous patch queued somewhere? Paul Bolle

<    1   2   3   4   5   6   7   8   9   10   >