.
This patch removes init_alloc_cpu_cpu() from cpu hotplug notifier. But
call it for each possible CPUs not only online CPUs at initialization time.
Looks good to me!
Reviewed-by: Pekka Enberg [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
Hi Christoph,
On 10/9/07, Christoph Lameter [EMAIL PROTECTED] wrote:
Could you check if a per cpu structure has already been allocated and then
simply skip the call to init? Otherwise we end up with lots of per cpu
structures for cpus that will never show up.
Does it matter? How?
-
To
Hi Christoph,
On 10/9/07, Christoph Lameter [EMAIL PROTECTED] wrote:
Our system come by default with the possibility of 1k cpus. However, a
small system may only have 8 cpus.
Maybe I am reading the code wrong, but I don't why that matters as
it's all statically allocated anyway (the per-cpu
Hi Lars,
On 7/22/07, Lars Ellenberg [EMAIL PROTECTED] wrote:
there is just one logical piece, the drbd module...
it is all in its own subdirectory.
it does not really touch anything else.
I don't think it is feasible to split it further.
I don't know your code at all but the diffstat suggests
Hi Sam,
On 7/22/07, Sam Ravnborg [EMAIL PROTECTED] wrote:
So essentially smaller pieces that can be revied but when ready for inclusion
it should go in as _one_ commit to avoid breaking bisect.
Or alternatively, put all Kconfig and Makefile changes in the last patch.
-
To unsubscribe from
On 7/22/07, Akinobu Mita [EMAIL PROTECTED] wrote:
This patch fixes memory leak in error path.
In reality, we don't need to call cpuup_canceled(cpu) for now.
But upcoming cpu hotplug error handling change needs this.
This and the previous patch look good to me.
Acked-by: Pekka Enberg [EMAIL
On 7/26/07, Peter Zijlstra [EMAIL PROTECTED] wrote:
--- linux-2.6.orig/mm/slub.c
+++ linux-2.6/mm/slub.c
@@ -1656,6 +1656,7 @@ static void __always_inline slab_free(st
unsigned long flags;
local_irq_save(flags);
+ debug_check_no_locks_freed(object, s-size);
Although it
Hi Mathieu,
On 8/22/07, Mathieu Desnoyers [EMAIL PROTECTED] wrote:
Cons:
- Does not help code readability, i.e.:
if (have_arch_cmpxchg())
preempt_disable();
else
local_irq_save(flags);
Heh, that's an understatement, as now slub is starting to look a bit
like slab... ;-)
Hi Thomas,
On 8/15/07, Thomas Renninger [EMAIL PROTECTED] wrote:
+int pnp_port_alloc (struct pnp_resource_table *res)
+{
+ int ret = 0, i;
+ if (res-allocated_ports == 0) {
+ res-port_resource = kmalloc(sizeof(struct resource)
+
On 8/18/07, Christoph Lameter [EMAIL PROTECTED] wrote:
That was merged over my objections. IMHO ksize(NULL) should fail since we
are determining the size of an unallocated object.
Agreed, especially as we have real zero-sized objects returned from
kmalloc() et al now.
-
To unsubscribe from this
On 8/18/07, Thomas Gleixner [EMAIL PROTECTED] wrote:
If yes, who invented this 1980s reminiscence, where you got valid
pointers for malloc(0) ?
Well, kmalloc(0) has always been legal and traditionally returned a
pointer to a smallest non-zero sized object. We did try to make
kmalloc(0) illegal
Hi Peter,
On Mon, 2007-08-20 at 12:12 +0300, Pekka J Enberg wrote:
Any reason why the callers that are actually interested in this don't do
page-reserve on their own?
On 8/20/07, Peter Zijlstra [EMAIL PROTECTED] wrote:
because new_slab() destroys the content?
Right. So maybe we could move
Hi Hugh,
On 10/12/07, Hugh Dickins [EMAIL PROTECTED] wrote:
But I keep suspecting that the answer might be the patch below (which
rather follows what drivers/block/rd.c is doing). I'm especially
worried that, rather than just AOP_WRITEPAGE_ACTIVATE being returned
to userspace, bad enough in
Hi,
On 10/12/07, Tetsuo Handa [EMAIL PROTECTED] wrote:
I saw /proc/meminfo and it seems to me that slab is leaking memory.
But /usr/bin/slabtop claims /proc/slabinfo is missing.
Do you have CONFIG_SLUB enabled? Try looking into /sys/slab/.
Pekka
-
To
Hi,
On 10/12/07, Tetsuo Handa [EMAIL PROTECTED] wrote:
I saw /proc/meminfo and it seems to me that slab is leaking memory.
But /usr/bin/slabtop claims /proc/slabinfo is missing.
At some point in time, I wrote:
Do you have CONFIG_SLUB enabled? Try looking into /sys/slab/.
On 10/13/07,
Hi Hugh,
On Sat, 13 Oct 2007, Pekka Enberg wrote:
Doesn't msync(2) get to it via mm/page-writeback.c:write_cache_pages()
without unionfs even?
On 10/14/07, Hugh Dickins [EMAIL PROTECTED] wrote:
I believe not. Please do double-check my assertions, I've always found
the _writepages paths
Hi,
On 10/15/07, Erez Zadok [EMAIL PROTECTED] wrote:
Pekka, with a small change to your patch (to handle time-based cache
coherency), your patch worked well and passed all my tests. Thanks.
So now I wonder if we still need the patch to prevent AOP_WRITEPAGE_ACTIVATE
from being returned to
On 4/26/07, Nigel Cunningham [EMAIL PROTECTED] wrote:
3) Someone else steps up to the plate and tries to merge Suspend2 one
bit at a time.
So which bits do we want to merge? For example, Suspend2
kernel/power/ui.c, kernel/power/compression.c, and
kernel/power/encryption.c seem pointless now
Hi Nigel,
On 4/26/07, Nigel Cunningham [EMAIL PROTECTED] wrote:
* Doing things in the right order? (Prepare the image, then do the
atomic copy, then save).
As I am a total newbie to the power management code, I am unable to
spot the conceptual difference in uswsusp suspend.c:suspend_system()
On 4/25/07, Pavel Machek [EMAIL PROTECTED] wrote:
Please stop using FUD.
Graphical progress it's not in the kernel, even with suspend2.
It was ascii-art, but still 'graphical', last time I checked.
Suspend2 talks to an userspace client via netlink. While I find the
name of the message
On 4/26/2007, Rafael J. Wysocki [EMAIL PROTECTED] wrote:
In principle, we could add suspend2 as an alternative (in analogy with the I/O
schedulers, for example), but I think for this purpose it should be reviewed
properly.
Yeah, this makes sense.
On 4/26/2007, Rafael J. Wysocki [EMAIL
On 4/27/07, Pavel Machek [EMAIL PROTECTED] wrote:
Now, it would be _very_ nice to be able to snapshot system and
continue running, but I just don't see how to do it without extensive
filesystem support.
So what kind of support do we need from the filesystem?
On 4/26/07, Linus Torvalds [EMAIL PROTECTED] wrote:
In fact, I personally feel that I shouldn't even have merged
userspace-swsusp, but if Andrew thinks it needs to be merged, my personal
feelings simply don't matter that much. I have to trust people. But yes,
as far as *I* am personally
Hi Oliver,
Am Freitag, 27. April 2007 12:12 schrieb Pekka J Enberg:
The problem with writing in the kernel is obvious: we need to add new code
to the kernel for compression, encryption, and userspace interaction
(graphical progress bar) that are important for user experience.
On 4/27/07,
Hi,
On Apr 6, 2005 3:15 PM, Paulo Marques [EMAIL PROTECTED] wrote:
However calloc is the standard C interface for doing this, so it makes
some sense to use it here as well... :(
I initally submitted kcalloc() with just one parameter but Arjan
wanted it to be similar to standard calloc() so we
On Fri, 2005-02-04 at 11:20 -0600, Olof Johansson wrote:
* cpu-has-feature(cpu-feature-foo) v cpu-has-feature(foo): I picked the
latter for readability.
* Renaming CPU_FTR_x - CPU_x makes it less obvious that
it's actually a cpu feature it's describing (i.e. CPU_ALTIVEC vs
CPU_FTR_ALTIVEC).
On Tue, 1 Feb 2005 03:28:31 +, [EMAIL PROTECTED]
[EMAIL PROTECTED] wrote:
diff -buprN -X dontdiff
vanilla-2.6.11-rc2-bk9/arch/um/os-Linux/drivers/tuntap_user.c
linux-2.6.11-rc2-bk9/arch/um/os-Linux/drivers/tuntap_user.c
--- vanilla-2.6.11-rc2-bk9/arch/um/os-Linux/drivers/tuntap_user.c
On Mon, 31 Jan 2005 09:03:44 -0800, Matt Mackall [EMAIL PROTECTED] wrote:
It's a nice self-contained unit test. It's here because I ran into a
strange regparm-related bug when developing the code in userspace and
I wanted to be sure that it was easy to diagnose in the field if a
similar bug
Hi Tom,
On Wed, 9 Feb 2005 20:49:36 -0600, Tom Zanussi [EMAIL PROTECTED] wrote:
+static inline struct page **alloc_page_array(int size, int *page_count)
+{
+ int n_pages;
+ struct page **page_array;
+
+ size = PAGE_ALIGN(size);
+ n_pages = size PAGE_SHIFT;
+
+
On Wed, 9 Feb 2005 20:49:36 -0600, Tom Zanussi [EMAIL PROTECTED] wrote:
+static int relayfs_create_entry(const char *name, struct dentry *parent,
+ int mode, struct rchan *chan,
+ struct dentry **dentry)
+{
+ struct qstr qname;
On Thu, 10 Feb 2005 17:18:10 +0100, Stelian Pop [EMAIL PROTECTED] wrote:
+static int sony_acpi_write_brt(struct file *file, const char __user *buffer,
unsigned long count, void *data)
+{
+ struct sony_snc *snc = (struct sony_snc *) data;
The casts for void pointer conversiosn are
On Fri, 11 Feb 2005 12:36:37 +0100, Stelian Pop [EMAIL PROTECTED] wrote:
+static int __init sony_acpi_add(struct acpi_device *device)
+{
+ acpi_status status = AE_OK;
+ struct sony_snc *snc = NULL;
+ int result;
+
+ snc = kmalloc(sizeof(struct sony_snc), GFP_KERNEL);
Phillip,
Jörn Engel wrote:
Your definition of _unnecessary_ casts may differ from mine.
Basically, every cast is unnecessary, except for maybe one or two - if
that many.
On 4/20/05, Phillip Lougher [EMAIL PROTECTED] wrote:
Well we agree to differ then. In my experience casts are
On 7/4/05, Miklos Szeredi [EMAIL PROTECTED] wrote:
Here are some numbers on the size these filesystems as in current -mm
('wc fs/${fs}/* include/linux/${fs}*')
Sloccount [1] gives more meaningful numbers than wc:
('sloccount fs/${fs}/* include/linux/${fs}*')
nfs: 21,046
9p:3,856
coda:
Hi Jesper,
On 7/4/05, Jesper Juhl [EMAIL PROTECTED] wrote:
static int
ibm_hdaps_open(struct inode *inode, struct file *filp)
{
printk(%s() start\n, __func__);
if (!atomic_dec_and_test(ibm_hdaps_available)) {
printk(%s() busy\n, __func__);
On 7/5/05, Nigel Cunningham [EMAIL PROTECTED] wrote:
Would people like me to post the patches to LKML, or are you happy to
download from suspend2.net for yourselves?
Please post it so we can be sure that we're reviewing the same version.
Pekka
-
To unsubscribe from
On 7/6/05, Nigel Cunningham [EMAIL PROTECTED] wrote:
diff -ruNp
520-version-specific-x86_64.patch-old/include/asm-x86_64/suspend2.h
520-version-specific-x86_64.patch-new/include/asm-x86_64/suspend2.h
--- 520-version-specific-x86_64.patch-old/include/asm-x86_64/suspend2.h
1970-01-01
On 7/6/05, Nigel Cunningham [EMAIL PROTECTED] wrote:
diff -ruNp 620-userui-header.patch-old/kernel/power/suspend2_core/ui.c
620-userui-header.patch-new/kernel/power/suspend2_core/ui.c
--- 620-userui-header.patch-old/kernel/power/suspend2_core/ui.c 1970-01-01
10:00:00.0 +1000
Is a
On 7/6/05, Nigel Cunningham [EMAIL PROTECTED] wrote:
diff -ruNp 623-generic-block-io.patch-old/kernel/power/suspend_block_io.c
623-generic-block-io.patch-new/kernel/power/suspend_block_io.c
--- 623-generic-block-io.patch-old/kernel/power/suspend_block_io.c
1970-01-01 10:00:00.0
On 7/6/05, Nigel Cunningham [EMAIL PROTECTED] wrote:
diff -ruNp 300-reboot-handler-hook.patch-old/kernel/sys.c
300-reboot-handler-hook.patch-new/kernel/sys.c
--- 300-reboot-handler-hook.patch-old/kernel/sys.c 2005-06-20
11:47:32.0 +1000
+++
Hi Nigel,
On 7/6/05, Nigel Cunningham [EMAIL PROTECTED] wrote:
As requested, here are the patches that form Suspend2, for review.
I've tried to split it up into byte size chunks, but please don't expect
that these will be patches that can mutate swsusp into Suspend2. That
would roughly
On 7/6/05, Nigel Cunningham [EMAIL PROTECTED] wrote:
diff -ruNp 622-swapwriter.patch-old/kernel/power/suspend_swap.c
622-swapwriter.patch-new/kernel/power/suspend_swap.c
--- 622-swapwriter.patch-old/kernel/power/suspend_swap.c1970-01-01
10:00:00.0 +1000
+++
On 7/6/05, Nigel Cunningham [EMAIL PROTECTED] wrote:
diff -ruNp 618-core.patch-old/kernel/power/suspend2_core/suspend.c
618-core.patch-new/kernel/power/suspend2_core/suspend.c
--- 618-core.patch-old/kernel/power/suspend2_core/suspend.c 1970-01-01
+#define SNPRINTF(a...) len +=
On 7/6/05, Nigel Cunningham [EMAIL PROTECTED] wrote:
diff -ruNp
301-proc-acpi-sleep-activate-hook.patch-old/drivers/acpi/sleep/proc.c
301-proc-acpi-sleep-activate-hook.patch-new/drivers/acpi/sleep/proc.c
--- 301-proc-acpi-sleep-activate-hook.patch-old/drivers/acpi/sleep/proc.c
On 7/6/05, Nigel Cunningham [EMAIL PROTECTED] wrote:
diff -ruNp 625-crypto-api-work.patch-old/crypto/lzf.c
625-crypto-api-work.patch-new/crypto/lzf.c
--- 625-crypto-api-work.patch-old/crypto/lzf.c 1970-01-01 10:00:00.0
+1000
+++ 625-crypto-api-work.patch-new/crypto/lzf.c
On 7/6/05, Nigel Cunningham [EMAIL PROTECTED] wrote:
diff -ruNp 611-io.patch-old/kernel/power/suspend2_core/io.c
611-io.patch-new/kernel/power/suspend2_core/io.c
--- 611-io.patch-old/kernel/power/suspend2_core/io.c1970-01-01
10:00:00.0 +1000
+++
On 7/6/05, Nigel Cunningham [EMAIL PROTECTED] wrote:
diff -ruNp 610-encryption.patch-old/kernel/power/suspend2_core/encryption.c
610-encryption.patch-new/kernel/power/suspend2_core/encryption.c
--- 610-encryption.patch-old/kernel/power/suspend2_core/encryption.c
1970-01-01
On 7/6/05, Nigel Cunningham [EMAIL PROTECTED] wrote:
diff -ruNp 604-utility-header.patch-old/kernel/power/suspend2_core/utility.c
604-utility-header.patch-new/kernel/power/suspend2_core/utility.c
--- 604-utility-header.patch-old/kernel/power/suspend2_core/utility.c
1970-01-01
On 7/6/05, Nigel Cunningham [EMAIL PROTECTED] wrote:
diff -ruNp
603-suspend2_common-headers.patch-old/kernel/power/suspend2_core/suspend2_common.h
603-suspend2_common-headers.patch-new/kernel/power/suspend2_core/suspend2_common.h
---
On 7/6/05, Nigel Cunningham [EMAIL PROTECTED] wrote:
diff -ruNp 614-plugins.patch-old/kernel/power/suspend2_core/plugins.c
614-plugins.patch-new/kernel/power/suspend2_core/plugins.c
--- 614-plugins.patch-old/kernel/power/suspend2_core/plugins.c 1970-01-01
10:00:00.0 +1000
+++
Jens Axboe wrote:
ATA7 defines a park maneuvre, I don't know how well supported it is
yet though. You can test with this little app, if it says 'head
parked' it works. If not, it has just idled the drive.
On 7/7/05, Lenz Grimmer [EMAIL PROTECTED] wrote:
Great! Thanks for digging this up -
Hi Nigel,
diff -ruNp 623-generic-block-io.patch-old/kernel/power/suspend_block_io.c
623-generic-block-io.patch-new/kernel/power/suspend_block_io.c
--- 623-generic-block-io.patch-old/kernel/power/suspend_block_io.c
1970-01-01 10:00:00.0 +1000
+++
On 7/7/05, Martin Knoblauch [EMAIL PROTECTED] wrote:
Interesting. Same Notebook, same drive. The program say not parked
:-( This is on FC2 with a pretty much vanilla 2.6.9 kernel.
[EMAIL PROTECTED] tmp]# uname -a
Linux l15833 2.6.9-noagp #1 Wed May 4 16:09:14 CEST 2005 i686 i686 i386
On 7/8/05, Guillermo López Alejos [EMAIL PROTECTED] wrote:
Hi,
As I anounced a couple of weeks ago, I'm studying how to build a new
filesystem. I have taken a look at the ramfs and also read some
documentation about.
Now I'm writing my own dummyfs (based on ramfs) to know how this
works,
On 7/8/05, Ram [EMAIL PROTECTED] wrote:
This patch adds the shared/private/slave support for VFS trees.
Inlining the patches to email would be greatly appreciated. Here are
some comments.
+int
+_do_make_mounted(struct nameidata *nd, struct vfsmount **mnt)
Use two underscores to follow naming
On Fri, 2005-07-08 at 15:34 +0200, Roman Zippel wrote:
Are the advantages big enough to actively discourage defines? It's nice
that you do reviews, but please leave some room for personal preferences.
If the code is correct and perfectly readable, it doesn't matter whether
to use defines or
Hi,
On Fri, 2005-07-08 at 21:11 +0200, Roman Zippel wrote:
So it basically comes down to personal preference, if the original uses
defines and it works fine, I don't really see a good enough reason to
change it to enums, so please leave the decision to author.
(And I don't see a good enough
Hi Roman,
At some point in time, I wrote:
Roman, it is not as if I get to decide for the patch submitters. I
comment on any issues _I_ have with the patch and the authors fix
whatever they want (or what the maintainers ask for).
On Fri, 2005-07-08 at 21:59 +0200, Roman Zippel wrote:
The
Some of my usual coding style comments...
On Fri, 11 Mar 2005 11:21:32 -0800, Andrew Morton [EMAIL PROTECTED] wrote:
diff -puN /dev/null drivers/net/chelsio/osdep.h
--- /dev/null 2003-09-15 06:40:47.0 -0700
+++ 25-akpm/drivers/net/chelsio/osdep.h 2005-03-11 11:13:06.0
Hi,
Few more coding style comments.
On Fri, 11 Mar 2005 11:21:32 -0800, Andrew Morton [EMAIL PROTECTED] wrote:
diff -puN /dev/null drivers/net/chelsio/cxgb2.c
--- /dev/null 2003-09-15 06:40:47.0 -0700
+++ 25-akpm/drivers/net/chelsio/cxgb2.c 2005-03-11 11:13:06.0
-0800
Hi Benjamin,
On Tue, 2005-03-08 at 22:29 +0100, Kronos wrote:
kfree(NULL) is fine, no need to check for null pointer.
On Wed, 09 Mar 2005 09:46:20 +1100, Benjamin Herrenschmidt
[EMAIL PROTECTED] wrote:
Hehe, yes, but I don't like it :)
Please consider doing that anyway as there are ongoing
Hi Benjamin,
Few coding style nitpicks follow.
On Tue, 08 Mar 2005 18:11:59 +1100, Benjamin Herrenschmidt
[EMAIL PROTECTED] wrote:
Index: linux-work/include/linux/pci.h
===
--- linux-work.orig/include/linux/pci.h 2005-01-24
Hi,
On Fri, 25 Mar 2005 17:29:56 -0500 (EST), linux-os
[EMAIL PROTECTED] wrote:
Isn't it expensive of CPU time to call kfree() even though the
pointer may have already been freed? I suggest that the check
for a NULL before the call is much less expensive than calling
kfree() and doing the
Hi,
This patch removes one redundant variable from mm/thrash.c and
moves the declaration of one variable closer to the block where
it is actually used.
Signed-off-by: Pekka Enberg [EMAIL PROTECTED]
---
thrash.c |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
Index: kernel
Hi,
Here's a version that applies with -p1. Quilt did some silly things to
the previous one...
This patch removes one redundant variable from mm/thrash.c and moves
declaration of one variable closer to the block where it is actually used.
Signed-off-by: Pekka Enberg [EMAIL PROTECTED
On Fri, 25 Mar 2005 17:34:29 -0500 (EST), linux-os
[EMAIL PROTECTED] wrote:
You really should reconsider this activity. It is quite counter-productive.
No it's not. NULL is checked twice without Jesper's cleanups. If
kfree() calls are really that performance sensitive, just make it
inline and
On Sun, 27 Mar 2005 12:40:26 -0500, Dave Jones [EMAIL PROTECTED] wrote:
Am I the only person who is completely fascinated by the
effort being spent here micro-optimising something thats
almost never in a path that needs optimising ?
I'd be amazed if any of this masturbation showed the tiniest
This patch removes macro obfuscation from fs/isofs/rock.c and cleans it up
a bit to make it more readable and maintainable. There are no functional
changes, only cleanups. I have only tested this lightly but it passes
mount and read on small Rock Ridge enabled ISO image.
Signed-off-by: Pekka
This patch indents the file fs/isofs/rock.c.
Signed-off-by: Pekka Enberg [EMAIL PROTECTED]
---
rock.c | 647 +++--
1 files changed, 356 insertions(+), 291 deletions(-)
Index: 2.6/fs/isofs/rock.c
This patch inlines the CONTINUE_DECLS macro in fs/isofs/rock.c.
Signed-off-by: Pekka Enberg [EMAIL PROTECTED]
---
rock.c | 13 ++---
1 files changed, 6 insertions(+), 7 deletions(-)
Index: 2.6/fs/isofs/rock.c
===
--- 2.6
This patch converts the CHECK_SP macro to a proper function in
fs/isofs/rock.c.
Signed-off-by: Pekka Enberg [EMAIL PROTECTED]
---
rock.c | 25 +
1 files changed, 13 insertions(+), 12 deletions(-)
Index: 2.6/fs/isofs/rock.c
This patch extracts ZISOFS entry parsing to a separate function.
Signed-off-by: Pekka Enberg [EMAIL PROTECTED]
---
rock.c | 77 +
1 files changed, 35 insertions(+), 42 deletions(-)
Index: 2.6/fs/isofs/rock.c
This patch removes some redundant variables from fs/isofs/rock.c.
Signed-off-by: Pekka Enberg [EMAIL PROTECTED]
---
rock.c | 41 +
1 files changed, 13 insertions(+), 28 deletions(-)
Index: 2.6/fs/isofs/rock.c
This patch removes redundant kfree() NULL checks from fs/isofs/rock.c.
Signed-off-by: Pekka Enberg [EMAIL PROTECTED]
---
rock.c | 36
1 files changed, 12 insertions(+), 24 deletions(-)
Index: 2.6/fs/isofs/rock.c
This patch converts the SETUP_ROCK_RIDGE macro to a proper function in
fs/isofs/rock.c.
Signed-off-by: Pekka Enberg [EMAIL PROTECTED]
---
rock.c | 34 +++---
1 files changed, 19 insertions(+), 15 deletions(-)
Index: 2.6/fs/isofs/rock.c
This patch inlines the MAYBE_CONTINUE macro in fs/isofs/rock.c.
Signed-off-by: Pekka Enberg [EMAIL PROTECTED]
---
rock.c | 121 -
1 files changed, 90 insertions(+), 31 deletions(-)
Index: 2.6/fs/isofs/rock.c
This patch inlines the CHECK_CE macro in fs/isofs/rock.c.
Signed-off-by: Pekka Enberg [EMAIL PROTECTED]
---
rock.c | 23 +++
1 files changed, 15 insertions(+), 8 deletions(-)
Index: 2.6/fs/isofs/rock.c
On Mon, 28 Mar 2005 21:52:57 -0500, Lee Revell [EMAIL PROTECTED] wrote:
I see kfree used in several hot paths. Check out
this /proc/latency_trace excerpt:
Yes, but is the pointer being free'd NULL most of the time? The
optimization does not help if you are releasing actual memory.
On Mon, 21 Feb 2005 02:43:44 +, Baruch Even [EMAIL PROTECTED] wrote:
One thing I've seen once that might be worth adding is the ability to
mark generations and then ask what allocations exist from generation x?.
In less general terms, I would like to see which module made the
allocation so
Hi,
On Tue, 1 Feb 2005 03:28:21 +, [EMAIL PROTECTED]
[EMAIL PROTECTED] wrote:
This patch creates the kstrdup library function so that it doesn't have to be
reimplemented (or even EXPORT'ed) by every user that needs it.
Signed-off-by: Paulo Marques [EMAIL PROTECTED]
diff -buprN -X
At some point in time, I wrote:
kstrdup() is a special-case _memory allocator_ (not so much a string
operation) so I think it should go into mm/slab.c where we currently
have kcalloc().
On Tue, 01 Feb 2005 17:00:17 +, Paulo Marques [EMAIL PROTECTED] wrote:
I was following Rusty
Hi,
On Fri, 4 Feb 2005 01:22:54 -0600, Olof Johansson [EMAIL PROTECTED] wrote:
+#define CPU_HAS_FEATURE(x) (cur_cpu_spec-cpu_features CPU_FTR_##x)
+
Please drop the CPU_FTR_##x macro magic as it makes grepping more
complicated. If the enum names are too long, just do s/CPU_FTR_/CPU_/g
or
Check return value for copy_to_user() and copy_from_user().
Signed-off-by: Pekka Enberg [EMAIL PROTECTED]
---
cifssmb.c | 37 ++---
file.c|6 +-
2 files changed, 27 insertions(+), 16 deletions(-)
Index: linux/fs/cifs/cifssmb.c
This patch removes commented out code.
Signed-off-by: Pekka Enberg [EMAIL PROTECTED]
---
asn1.c| 122 --
cifsencrypt.c |5 --
cifsfs.c | 25 ---
cifssmb.c | 48 +-
connect.c | 25
Remove spurious void pointer casts.
Signed-off-by: Pekka Enberg [EMAIL PROTECTED]
---
cifsfs.c|9 -
dir.c |6 ++
file.c | 32 +---
misc.c | 17 -
readdir.c |6 +++---
transport.c |5 ++---
6 files
Convert #defines to proper enums and remove duplicate symbols.
Signed-off-by: Pekka Enberg [EMAIL PROTECTED]
---
asn1.c| 72 +++--
cifspdu.h | 798 --
2 files changed, 464 insertions(+), 406 deletions(-)
Index: 2.6/fs/cifs/asn1
This patch converts cifs code to use msleep() and ssleep() instead of
schedule_timeout().
Signed-off-by: Pekka Enberg [EMAIL PROTECTED]
---
cifsfs.c |9 -
connect.c | 25 +
2 files changed, 13 insertions(+), 21 deletions(-)
Index: 2.6/fs/cifs/cifsfs.c
This patch converts deep if statement nesting to use gotos in few places.
Signed-off-by: Pekka Enberg [EMAIL PROTECTED]
---
cifsfs.c | 51 +++
connect.c | 44
2 files changed, 51 insertions(+), 44
On Thu, 20 Jan 2005 01:23:48 -0500, Karim Yaghmour [EMAIL PROTECTED] wrote:
+config RELAYFS_FS
+ tristate Relayfs file system support
+ ---help---
+ Relayfs is a high-speed data relay filesystem designed to provide
+ an efficient mechanism for tools and facilities to relay
On Sat, Jul 14, 2012 at 12:18 PM, David Rientjes rient...@google.com wrote:
On Fri, 13 Jul 2012, Shuah Khan wrote:
diff --git a/mm/slab_common.c b/mm/slab_common.c
index 12637ce..aa3ca5b 100644
--- a/mm/slab_common.c
+++ b/mm/slab_common.c
@@ -98,7 +98,9 @@ struct kmem_cache
On Sat, Jul 14, 2012 at 1:37 PM, Borislav Petkov b...@alien8.de wrote:
On Fri, Jul 13, 2012 at 11:41:21PM +0200, richard -rw- weinberger wrote:
On Fri, Jul 13, 2012 at 10:54 PM, Myklebust, Trond
trond.mykleb...@netapp.com wrote:
We could at least make selection of a minimal set of drivers for
Introduce two new helper functions, addr_to_pmd_pfn() and
addr_to_pud_pfn(), to simplify init_memory_mapping() code flow.
Cc: Tejun Heo t...@kernel.org
Cc: Yinghai Lu ying...@kernel.org
Signed-off-by: Pekka Enberg penb...@kernel.org
---
arch/x86/mm/init.c | 38
As a cleanup, move initial addr assignment to the for-loop construct
in free_init_pages().
Cc: Tejun Heo t...@kernel.org
Cc: Yinghai Lu ying...@kernel.org
Signed-off-by: Pekka Enberg penb...@kernel.org
---
arch/x86/mm/init.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff
the CR4 register.
Cc: Tejun Heo t...@kernel.org
Cc: Yinghai Lu ying...@kernel.org
Signed-off-by: Pekka Enberg penb...@kernel.org
---
arch/x86/include/asm/page_types.h |2 ++
arch/x86/kernel/setup.c |2 ++
arch/x86/mm/init.c| 23 +--
3 files
On Sat, Jul 14, 2012 at 11:43 PM, Joe Perches j...@perches.com wrote:
On Sat, 2012-07-14 at 13:36 -0700, Yinghai Lu wrote:
On Sat, Jul 14, 2012 at 6:41 AM, Pekka Enberg penb...@kernel.org wrote:
As a cleanup, move initial addr assignment to the for-loop construct
in free_init_pages
On Sun, Jul 15, 2012 at 1:14 PM, Borislav Petkov b...@amd64.org wrote:
On Sat, Jul 14, 2012 at 03:12:05PM +0300, Pekka Enberg wrote:
We have make kvmconfig in the KVM tool tree that pretty much does
that automatically. There's nothing tools/kvm specific about it so I
guess you could merge
On Sat, Jul 14, 2012 at 6:41 AM, Pekka Enberg penb...@kernel.org wrote:
Move PSE and PGE bit twiddling from init_memory_mapping() to a new
setup_paging() function to simplify the former function. The
init_memory_mapping() function is called later in the boot process by
gart_iommu_init
As a cleanup, separate the #ifdef'd code in a new helper function and move
initial addr assignment to the for-loop construct.
Cc: Joe Perches j...@perches.com
Cc: Tejun Heo t...@kernel.org
Cc: Yinghai Lu ying...@kernel.org
Signed-off-by: Pekka Enberg penb...@kernel.org
---
arch/x86/mm/init.c
the CR4 register.
Cc: Joe Perches j...@perches.com
Cc: Tejun Heo t...@kernel.org
Cc: Yinghai Lu ying...@kernel.org
Signed-off-by: Pekka Enberg penb...@kernel.org
---
arch/x86/include/asm/page_types.h |2 ++
arch/x86/kernel/setup.c |2 ++
arch/x86/mm/init.c| 23
On Tue, Jul 17, 2012 at 12:33 PM, Matt Evans m...@ozlabs.org wrote:
Just had a look, all good. Thanks for tidying some old FIXMEs, especially
the page/segment DT props encoding grot -- and the designated inits in the
cpuinfo struct, whew, I heard the scream on IRC. Sorry. ;-)
Acked-by: Matt
201 - 300 of 1778 matches
Mail list logo
