Re: [PATCH] fix crash when using XFS on loopback

On Thu, Jan 9, 2014 at 2:19 AM, Andrew Morton a...@linux-foundation.org wrote: cache-misses are reduced by this patchset, roughly 5%. And elapsed times are also improved by 3.1% to baseline. ah, OK, thanks, useful. A few instructions added to page_mapping() won't have effects like that!

Re: [RFC][PATCH 0/7] re-shrink 'struct page' when SLUB is on.

On 12/17/2013 02:45 AM, Dave Hansen wrote: I'll do some testing and see if I can coax out any delta from the optimization myself. Christoph went to a lot of trouble to put this together, so I assumed that he had a really good reason, although the changelogs don't really mention any. IIRC it's

Re: [PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

On 12/18/2013 03:16 PM, Vladimir Davydov wrote: Signed-off-by: Vladimir Davydov vdavy...@parallels.com Cc: Michal Hocko mho...@suse.cz Cc: Johannes Weiner han...@cmpxchg.org Cc: Glauber Costa glom...@gmail.com Cc: Christoph Lameter c...@linux.com Cc: Pekka Enberg penb...@kernel.org Cc: Andrew

Re: Warning at mm/slub.c

On 01/24/2014 04:21 PM, Peter Zijlstra wrote: Dave Hansen already send a fix for that: lkml.kernel.org/r/52d5746f.2040...@intel.com Pekka, any chance to get that merged? Sorry for the delay - I'm way behind my inbox. It's applied now, thanks! Pekka -- To unsubscribe

Re: [PATCH] perf tools: Fix JIT profiling on heap

On 01/16/2014 03:49 AM, Namhyung Kim wrote: Gaurav reported that perf cannot profile JIT program if it executes the code on heap. This was because current map__new() only handle JIT on anon mappings - extends it to handle no_dso (heap, stack) case too. This patch assumes JIT profiling only

Re: [PATCH] slub: Fix calculation of cpu slabs

On Sat, Oct 5, 2013 at 10:48 AM, Wanpeng Li liw...@linux.vnet.ibm.com wrote: On Tue, Sep 10, 2013 at 11:43:37AM +0800, Li Zefan wrote: /sys/kernel/slab/:t-048 # cat cpu_slabs 231 N0=16 N1=215 /sys/kernel/slab/:t-048 # cat slabs 145 N0=36 N1=109 See, the number of slabs is smaller

Re: [PATCH] mm/slub: fix accumulate per cpu partial cache objects

On Sat, Dec 28, 2013 at 3:50 AM, Li Zefan lize...@huawei.com wrote: On 2013/12/27 17:46, Wanpeng Li wrote: SLUB per cpu partial cache is a list of slab caches to accelerate objects allocation. However, current codes just accumulate the objects number of the first slab cache of per cpu partial

Re: [PATCH] mm/slub: fix accumulate per cpu partial cache objects

On 12/30/2013 03:08 AM, Wanpeng Li wrote: Zefan's patch is good enough, mine doesn't need any more. OK, thanks guys! Pekka -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] Revert slub: do not put a slab to cpu partial list when cpu_partial is 0

On Thu, Aug 8, 2013 at 4:19 PM, Steven Rostedt rost...@goodmis.org wrote: This reverts commit 318df36e57c0ca9f2146660d41ff28e8650af423 [snip] Signed-off-by: Steven Rostedt rost...@goodmis.org Acked-by: Pekka Enberg penb...@kernel.org Linus, can you pick this up or do you want a pull request

Re: [PATCH] kvm tools: Fix build of guest init with biarch powerpc compilers

On Wed, Aug 7, 2013 at 11:46 AM, Michael Ellerman mich...@ellerman.id.au wrote: On powerpc we build kvmtool as a 64bit binary. We do that by setting -m64 in our CFLAGS. For most things we just call $(CC) and it passes that info onto the linker. However there is one place where we explicitly

Re: [PATCH] slab: Fix off by one in object max number tests.

On Tue, May 6, 2014 at 6:32 AM, Linus Torvalds torva...@linux-foundation.org wrote: On Mon, May 5, 2014 at 8:25 PM, David Miller da...@davemloft.net wrote: Sam Ravnborg s...@ravnborg.org wrote: There is a related patch in this area which I think is not yet applied. See:

[PROBLEM] perf report --gtk doesn't work

Hello, I'm seeing the following with v3.15-rc2: $ ~/bin/perf report --gtk GTK browser requested but could not find libperf-gtk.so The library file is in $HOME/lib64 and perf attempts to look it up. However, printing out dlerror() output shows the following: [penberg@localhost hornet]$

Re: [PATCH 4/4] kmemcheck: Switch to using kernel disassembler

. Signed-off-by: Sasha Levin sasha.le...@oracle.com Vegard probably should take a closer look at this but: Acked-by: Pekka Enberg penb...@kernel.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: oops in slab/leaks_show

On 03/11/2014 10:30 AM, Joonsoo Kim wrote: -8- From ff6fe77fb764ca5bf8705bf53d07d38e4111e84c Mon Sep 17 00:00:00 2001 From: Joonsoo Kim iamjoonsoo@lge.com Date: Tue, 11 Mar 2014 14:14:25 +0900 Subject: [PATCH] slab: remove kernel_map_pages() optimization in slab

[GIT PULL] SLAB changes for v3.15-rc1

Hi Linus, Please pull the latest SLAB tree from: git://git.kernel.org/pub/scm/linux/kernel/git/penberg/linux.git slab/next The biggest change is byte-sized freelist indices which reduces slab freelist memory usage: https://lkml.org/lkml/2013/12/2/64 Pekka

Re: [Devel] [PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

On 12/19/2013 11:26 AM, Vasily Averin wrote: On 12/19/2013 12:39 PM, Vladimir Davydov wrote: On 12/19/2013 12:17 PM, Vasily Averin wrote: On 12/18/2013 05:16 PM, Vladimir Davydov wrote: --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -176,8 +176,9 @@ kmem_cache_create_memcg(struct mem_cgroup

Re: [PATCH v3 5/5] slab: make more slab management structure off the slab

On Fri, Dec 13, 2013 at 9:03 AM, Joonsoo Kim iamjoonsoo@lge.com wrote: Hello, Pekka. Below is updated patch for 5/5 in this series. Now I get acks from Christoph to all patches in this series. So, could you merge this patchset? :) If you want to resend wholeset with proper ack, I will do

Re: Memory allocator semantics

Hi Paul, On 01/02/2014 10:33 PM, Paul E. McKenney wrote: From what I can see, the Linux-kernel's SLAB, SLOB, and SLUB memory allocators would deal with the following sort of race: A. CPU 0: r1 = kmalloc(...); ACCESS_ONCE(gp) = r1; CPU 1: r2 = ACCESS_ONCE(gp); if (r2) kfree(r2);

Re: [PATCH v2] slab: Fix nodeid bounds check for non-contiguous node IDs

void *cache_alloc_node(struct kmem_cache *cachep, gfp_t flags, void *obj; int x; - VM_BUG_ON(nodeid num_online_nodes()); + VM_BUG_ON(nodeid 0 || nodeid = MAX_NUMNODES); n = get_node(cachep, nodeid); BUG_ON(!n); Reviewed-by: Pekka Enberg penb

Re: [PATCH 1/7] slub: Remove __slab_alloc code duplication

On Wed, Dec 10, 2014 at 6:30 PM, Christoph Lameter c...@linux.com wrote: Somehow the two branches in __slab_alloc do the same. Unify them. Signed-off-by: Christoph Lameter c...@linux.com Reviewed-by: Pekka Enberg penb...@kernel.org -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 2/7] slub: Use page-mapping to store address of page frame like done in SLAB

of invocations of page_address(). Those are mostly only used for debugging though so this should have no performance benefit. Signed-off-by: Christoph Lameter c...@linux.com Reviewed-by: Pekka Enberg penb...@kernel.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH 3/7] slub: Do not use c-page on free

On Wed, Dec 10, 2014 at 6:30 PM, Christoph Lameter c...@linux.com wrote: Avoid using the page struct address on free by just doing an address comparison. That is easily doable now that the page address is available in the page struct and we already have the page struct address of the object to

Re: [PATCH 4/7] slub: Avoid using the page struct address in allocation fastpath

On Wed, Dec 10, 2014 at 6:30 PM, Christoph Lameter c...@linux.com wrote: We can use virt_to_page there and only invoke the costly function if actually a node is specified and we have to check the NUMA locality. Increases the cost of allocating on a specific NUMA node but then that was never

Re: [PATCH 5/7] slub: Use end_token instead of NULL to terminate freelists

-by: Pekka Enberg penb...@kernel.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 6/7] slub: Drop -page field from kmem_cache_cpu

the condition that the current cpu has no percpu slab attached to it. Signed-off-by: Christoph Lameter c...@linux.com Reviewed-by: Pekka Enberg penb...@kernel.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 3/7] slub: Do not use c-page on free

-by: Pekka Enberg penb...@kernel.org - Pekka -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 1/5] LLVMLinux: Correct size_index table before replacing the bootstrap kmem_cache_node.

On 2/3/15 3:37 PM, Daniel Sanders wrote: This patch moves the initialization of the size_index table slightly earlier so that the first few kmem_cache_node's can be safely allocated when KMALLOC_MIN_SIZE is large. The patch looks OK to me but how is this related to LLVM? - Pekka -- To

Re: [PATCH 1/5] LLVMLinux: Correct size_index table before replacing the bootstrap kmem_cache_node.

On Wed, Feb 4, 2015 at 10:38 PM, Daniel Sanders daniel.sand...@imgtec.com wrote: I don't believe the bug to be LLVM specific but GCC doesn't normally encounter the problem. I haven't been able to identify exactly what GCC is doing better (probably inlining) but it seems that GCC is managing

Re: [PATCH v3 1/5] slab: Correct size_index table before replacing the bootstrap kmem_cache_node.

...@imgtec.com Cc: Christoph Lameter c...@linux.com Cc: Pekka Enberg penb...@kernel.org Cc: David Rientjes rient...@google.com Cc: Joonsoo Kim iamjoonsoo@lge.com Cc: Andrew Morton a...@linux-foundation.org Cc: linux...@kvack.org Cc: linux-kernel@vger.kernel.org Acked-by: Pekka Enberg penb...@kernel.org

Re: [PATCH -mm v2 1/3] slub: never fail to shrink cache

Lameter c...@linux.com Acked-by: Pekka Enberg penb...@kernel.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH v6 2/4] perf tools: add Java demangling support

Hi Stephane, On Tue, Mar 31, 2015 at 1:19 AM, Stephane Eranian eran...@google.com wrote: +#define BASE_ENT(c, n) [c-'A']=n +static const char *base_types['Z'-'A' + 1]={ + BASE_ENT('B', byte ), + BASE_ENT('C', char ), + BASE_ENT('D', double ), + BASE_ENT('F', float ),

Re: stand-alone kvmtool

On 2/26/15 1:02 PM, Alex Bennée wrote: If you can have it all it would be nice to preserve buildability all through your history for bisecting (and the moon on a stick please ;-) Is the dependency on the kernel sources something that has been stable over the projects history or something that's

Re: stand-alone kvmtool

Hi, On 2/18/15 5:50 PM, Will Deacon wrote: Thanks for doing this. Since it looks unlikely that kvmtool will ever be merged back into the kernel tree, it makes sense to cut the dependency in my opinion. I am certainly OK with a standalone repository which preserves the history. Will, would

Re: [PATCHSET 0/6] perf kmem: Implement page allocation analysis (v7)

, it does slab allocation analysis for backward compatibility. Nice addition! Acked-by: Pekka Enberg penb...@kernel.org for the whole series. - Pekka -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 0/13] Parallel struct page initialisation v4

the machine appears to work as normal. Boot times were measured from the time shutdown was called until ssh was available again. In the 64G case, the boot time savings are negligible. On the 1TB machine, the savings were 16 seconds. FWIW, Acked-by: Pekka Enberg penb...@kernel.org for the whole series

Re: [PATCH v2] perf kmem: Show warning when trying to run stat without record

below to inform user: # perf kmem stat --page --caller Not found page events. Have you run 'perf kmem record --page' before? Acked-by: Pekka Enberg penb...@kernel.org Signed-off-by: Namhyung Kim namhy...@kernel.org Thanks, applied. I just found the messages a bit odd souding, perhaps

[PATCH 06/14] drm: Use kvfree() in drm_free_large()

Use kvfree() instead of open-coding it. Cc: David Airlie airl...@linux.ie Signed-off-by: Pekka Enberg penb...@kernel.org --- include/drm/drm_mem_util.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/include/drm/drm_mem_util.h b/include/drm/drm_mem_util.h index 19a2404

[PATCH 12/14] dm: Use kvfree() in dm_kvfree()

Use kvfree() instead of open-coding it. Cc: Alasdair Kergon a...@redhat.com Cc: Mike Snitzer snit...@redhat.com Signed-off-by: Pekka Enberg penb...@kernel.org --- drivers/md/dm-stats.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/md/dm-stats.c b/drivers/md/dm

[PATCH 03/14] cxgb3: Use kvfree() in cxgb_free_mem()

Use kvfree() instead of open-coding it. Cc: Santosh Raspatur sant...@chelsio.com Signed-off-by: Pekka Enberg penb...@kernel.org --- drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb3

[PATCH 09/14] IB/ehca: Use kvfree() in ipz_queue_{cd}tor()

Use kvfree() instead of open-coding it. Cc: Hoang-Nam Nguyen hngu...@de.ibm.com Cc: Christoph Raisch rai...@de.ibm.com Signed-off-by: Pekka Enberg penb...@kernel.org --- drivers/infiniband/hw/ehca/ipz_pt_fn.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers

[PATCH 08/14] drivers/input/evdev.c: Use kvfree() in evdev_release()

Use kvfree() instead of open-coding it. Cc: Dmitry Torokhov dmitry.torok...@gmail.com Signed-off-by: Pekka Enberg penb...@kernel.org --- drivers/input/evdev.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c index a18f41b

[PATCH 01/14] ipc/util.c: Use kvfree() in ipc_rcu_free()

Use kvfree() instead of open-coding it. Signed-off-by: Pekka Enberg penb...@kernel.org --- ipc/util.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/ipc/util.c b/ipc/util.c index ff3323e..537a41c 100644 --- a/ipc/util.c +++ b/ipc/util.c @@ -467,10 +467,7 @@ void

[PATCH 02/14] kernel/relay.c: Use kvfree() in relay_free_page_array()

Use kvfree() instead of open-coding it. Signed-off-by: Pekka Enberg penb...@kernel.org --- kernel/relay.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/kernel/relay.c b/kernel/relay.c index e9dbaeb..0b4570c 100644 --- a/kernel/relay.c +++ b/kernel/relay.c @@ -81,10

[PATCH 05/14] ceph: Use kvfree() in ceph_put_page_vector()

Use kvfree instead of open-coding it. Cc: Yan, Zheng z...@redhat.com Cc: Sage Weil s...@redhat.com Signed-off-by: Pekka Enberg penb...@kernel.org --- net/ceph/pagevec.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/net/ceph/pagevec.c b/net/ceph/pagevec.c index 096d914

[PATCH 11/14] libcxgbi: Use kvfree() in cxgbi_free_big_mem()

Use kvfree() instead of open-coding it. Cc: James E.J. Bottomley jbottom...@odin.com Signed-off-by: Pekka Enberg penb...@kernel.org --- drivers/scsi/cxgbi/libcxgbi.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/scsi/cxgbi/libcxgbi.h b/drivers/scsi/cxgbi

[PATCH 13/14] bcache: Use kvfree() in various places

Use kvfree() instead of open-coding it. Cc: Kent Overstreet k...@daterainc.com Signed-off-by: Pekka Enberg penb...@kernel.org --- drivers/md/bcache/super.c | 10 ++ drivers/md/bcache/util.h | 10 ++ 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/md

[PATCH 14/14] NTFS: Use kvfree() in ntfs_free()

Use kvfree() instead of open-coding it. Cc: Anton Altaparmakov an...@tuxera.com Signed-off-by: Pekka Enberg penb...@kernel.org --- fs/ntfs/malloc.h | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/ntfs/malloc.h b/fs/ntfs/malloc.h index a44b14c..ab172e5 100644 --- a/fs

[PATCH 07/14] drm/nouveau/gem: Use kvfree() in u_free()

Use kvfree() instead of open-coding it. Cc: David Airlie airl...@linux.ie Signed-off-by: Pekka Enberg penb...@kernel.org --- drivers/gpu/drm/nouveau/nouveau_gem.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c b/drivers/gpu/drm

[PATCH 04/14] cxgb4: Use kvfree() in t4_free_mem()

Use kvfree() instead of open-coding it. Cc: Hariprasad S haripra...@chelsio.com Signed-off-by: Pekka Enberg penb...@kernel.org --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4

[PATCH 10/14] target: Use kvfree() in session alloc and free

Use kvfree() instead of open-coding it. Cc: Nicholas A. Bellinger n...@linux-iscsi.org Signed-off-by: Pekka Enberg penb...@kernel.org --- drivers/target/target_core_transport.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/target/target_core_transport.c

Re: [PATCH] mm: slab: convert slab_is_available to boolean

On 9/15/15 8:50 PM, Denis Kirjanov wrote: A good one candidate to return a boolean result Signed-off-by: Denis Kirjanov <k...@linux-powerpc.org> Reviewed-by: Pekka Enberg <penb...@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH, REGRESSION v3] mm: make apply_to_page_range more robust

On 01/22/2016 01:12 AM, David Rientjes wrote: NACK to your patch as it is just covering up buggy code silently. The problem needs to be addressed in change_memory_common() to return if there is no size to change (numpages == 0). It's a two line fix to that function. So add a WARN_ON there

Re: [PATCH 3/4] zswap: Zero-filled pages handling

overhead caused due to zero-filled page check is very minimal >> when compared to the time saved by avoiding compression and allocation in >> case of zero-filled pages. The load time of a zero-filled page is reduced >> by 80% when compared to baseline. On Wed, Aug 17, 2016 at 3:25

Re: [PATCH 3/4] zswap: Zero-filled pages handling

On Wed, Aug 17, 2016 at 1:18 PM, Srividya Desireddy wrote: > This patch adds a check in zswap_frontswap_store() to identify zero-filled > page before compression of the page. If the page is a zero-filled page, set > zswap_entry.zeroflag and skip the compression of the

Re: [PATCH 0/4] zswap: Optimize compressed pool memory utilization

On Wed, Aug 17, 2016 at 1:03 PM, Srividya Desireddy wrote: > This series of patches optimize the memory utilized by zswap for storing > the swapped out pages. > > Zswap is a cache which compresses the pages that are being swapped out > and stores them into a dynamically

Re: [PATCH] mm, slab: reschedule cache_reap() on the same CPU

t;workqueue: schedule WORK_CPU_UNBOUND work on wq_unbound_cpumask CPUs") CC: <sta...@vger.kernel.org> Cc: Joonsoo Kim <iamjoonsoo@lge.com> Cc: David Rientjes <rient...@google.com> Cc: Pekka Enberg <penb...@kernel.org> Cc: Christoph Lameter <c...@linux.com> Cc:

Re: [PATCH] remove redundant NULL pointer checks prior to calling kfree() in fs/nfsd/

On Fri, 25 Mar 2005 17:34:29 -0500 (EST), linux-os <[EMAIL PROTECTED]> wrote: > You really should reconsider this activity. It is quite counter-productive. No it's not. NULL is checked twice without Jesper's cleanups. If kfree() calls are really that performance sensitive, just make it inline and

Re: [PATCH] no need to check for NULL before calling kfree() -fs/ext2/

On Sun, 27 Mar 2005 12:40:26 -0500, Dave Jones <[EMAIL PROTECTED]> wrote: > Am I the only person who is completely fascinated by the > effort being spent here micro-optimising something thats > almost never in a path that needs optimising ? > I'd be amazed if any of this masturbation showed the

[PATCH 0/9] isofs: unobfuscate rock.c

This patch removes macro obfuscation from fs/isofs/rock.c and cleans it up a bit to make it more readable and maintainable. There are no functional changes, only cleanups. I have only tested this lightly but it passes mount and read on small Rock Ridge enabled ISO image. Signed-off-by: Pekka

[PATCH 1/9] isofs: indent rock.c

This patch indents the file fs/isofs/rock.c. Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]> --- rock.c | 647 +++-- 1 files changed, 356 insertions(+), 291 deletions(-) Index: 2.6/fs/isofs/

[PATCH 2/9] isofs: inline macros in rock.c

This patch inlines the CONTINUE_DECLS macro in fs/isofs/rock.c. Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]> --- rock.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) Index: 2.6/fs/isofs/

[PATCH 6/9] isofs: convert macro to function in rock.c

This patch converts the CHECK_SP macro to a proper function in fs/isofs/rock.c. Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]> --- rock.c | 25 + 1 files changed, 13 insertions(+), 12 deletions(-) Index: 2.6/fs/isofs/

[PATCH 7/9] isofs: extract zisofs parsing to function

This patch extracts ZISOFS entry parsing to a separate function. Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]> --- rock.c | 77 + 1 files changed, 35 insertions(+), 42 deletions(-) Index: 2.6/fs/isofs/

[PATCH 9/9] isofs: clean up rock.c

This patch removes some redundant variables from fs/isofs/rock.c. Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]> --- rock.c | 41 + 1 files changed, 13 insertions(+), 28 deletions(-) Index: 2.6/fs/isofs/

[PATCH 8/9] isofs: remove redundant kfree checks from rock

This patch removes redundant kfree() NULL checks from fs/isofs/rock.c. Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]> --- rock.c | 36 1 files changed, 12 insertions(+), 24 deletions(-) Index: 2.6/fs/isofs/

[PATCH 5/9] isofs: convert macro to function in rock.c

This patch converts the SETUP_ROCK_RIDGE macro to a proper function in fs/isofs/rock.c. Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]> --- rock.c | 34 +++--- 1 files changed, 19 insertions(+), 15 deletions(-) Index: 2.6/fs/isofs/

[PATCH 4/9] isofs: inline macros in rock.c

This patch inlines the MAYBE_CONTINUE macro in fs/isofs/rock.c. Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]> --- rock.c | 121 - 1 files changed, 90 insertions(+), 31 deletions(-) Index: 2.6/fs/isofs/

[PATCH 3/9] isofs: inline macros in rock.c

This patch inlines the CHECK_CE macro in fs/isofs/rock.c. Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]> --- rock.c | 23 +++ 1 files changed, 15 insertions(+), 8 deletions(-) Index: 2.6/fs/isofs/

Re: [PATCH] no need to check for NULL before calling kfree() -fs/ext2/

On Mon, 28 Mar 2005 21:52:57 -0500, Lee Revell <[EMAIL PROTECTED]> wrote: > I see kfree used in several hot paths. Check out > this /proc/latency_trace excerpt: Yes, but is the pointer being free'd NULL most of the time? The optimization does not help if you are releasing actual memory.

Re: RFC: turn kmalloc+memset(,0,) into kcalloc

Hi, On Apr 6, 2005 3:15 PM, Paulo Marques <[EMAIL PROTECTED]> wrote: > However "calloc" is the standard C interface for doing this, so it makes > some sense to use it here as well... :( I initally submitted kcalloc() with just one parameter but Arjan wanted it to be similar to standard calloc()

Re: [PATCH 2.6] 4/7 replace uml_strdup by kstrdup

On Tue, 1 Feb 2005 03:28:31 +, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > diff -buprN -X dontdiff > vanilla-2.6.11-rc2-bk9/arch/um/os-Linux/drivers/tuntap_user.c > linux-2.6.11-rc2-bk9/arch/um/os-Linux/drivers/tuntap_user.c > ---

Re: [PATCH 9/8] lib/sort: turn off self-test

On Mon, 31 Jan 2005 09:03:44 -0800, Matt Mackall <[EMAIL PROTECTED]> wrote: > It's a nice self-contained unit test. It's here because I ran into a > strange regparm-related bug when developing the code in userspace and > I wanted to be sure that it was easy to diagnose in the field if a > similar

Re: [PATCH] relayfs redux, part 4

Hi Tom, On Wed, 9 Feb 2005 20:49:36 -0600, Tom Zanussi <[EMAIL PROTECTED]> wrote: > +static inline struct page **alloc_page_array(int size, int *page_count) > +{ > + int n_pages; > + struct page **page_array; > + > + size = PAGE_ALIGN(size); > + n_pages = size >>

Re: [PATCH] relayfs redux, part 4

On Wed, 9 Feb 2005 20:49:36 -0600, Tom Zanussi <[EMAIL PROTECTED]> wrote: > +static int relayfs_create_entry(const char *name, struct dentry *parent, > + int mode, struct rchan *chan, > + struct dentry **dentry) > +{ > + struct qstr

Re: [PATCH, new ACPI driver] new sony_acpi driver

On Thu, 10 Feb 2005 17:18:10 +0100, Stelian Pop <[EMAIL PROTECTED]> wrote: > +static int sony_acpi_write_brt(struct file *file, const char __user *buffer, > unsigned long count, void *data) > +{ > + struct sony_snc *snc = (struct sony_snc *) data; The casts for void pointer conversiosn are

Re: [PATCH, new ACPI driver] new sony_acpi driver

On Fri, 11 Feb 2005 12:36:37 +0100, Stelian Pop <[EMAIL PROTECTED]> wrote: > +static int __init sony_acpi_add(struct acpi_device *device) > +{ > + acpi_status status = AE_OK; > + struct sony_snc *snc = NULL; > + int result; > + > + snc = kmalloc(sizeof(struct sony_snc),

Re: [PATCH] /proc/kmalloc

On Mon, 21 Feb 2005 02:43:44 +, Baruch Even <[EMAIL PROTECTED]> wrote: > One thing I've seen once that might be worth adding is the ability to > mark generations and then ask "what allocations exist from generation x?". In less general terms, I would like to see which module made the

Re: [PATCH] remove some usesless casts

Phillip, Jörn Engel wrote: > > Your definition of _unnecessary_ casts may differ from mine. > > Basically, every cast is unnecessary, except for maybe one or two - if > > that many. On 4/20/05, Phillip Lougher <[EMAIL PROTECTED]> wrote: > Well we agree to differ then. In my experience casts are

Re: FUSE merging?

On 7/4/05, Miklos Szeredi <[EMAIL PROTECTED]> wrote: > Here are some numbers on the size these filesystems as in current -mm > ('wc fs/${fs}/* include/linux/${fs}*') Sloccount [1] gives more meaningful numbers than wc: ('sloccount fs/${fs}/* include/linux/${fs}*') nfs: 21,046 9p:3,856

Re: IBM HDAPS things are looking up (was: Re: [Hdaps-devel] Re: [ltp] IBM HDAPS Someone interested? (Accelerometer))

Hi Jesper, On 7/4/05, Jesper Juhl <[EMAIL PROTECTED]> wrote: > static int > ibm_hdaps_open(struct inode *inode, struct file *filp) > { > printk("%s() start\n", __func__); > if (!atomic_dec_and_test(_hdaps_available)) { > printk("%s() busy\n", __func__); >

Re: Submission of Suspend2 for inclusion in mainline

On 7/5/05, Nigel Cunningham <[EMAIL PROTECTED]> wrote: > Would people like me to post the patches to LKML, or are you happy to > download from suspend2.net for yourselves? Please post it so we can be sure that we're reviewing the same version. Pekka - To unsubscribe

Re: [PATCH] [19/48] Suspend2 2.1.9.8 for 2.6.12: 510-version-specific-mac.patch

On 7/6/05, Nigel Cunningham <[EMAIL PROTECTED]> wrote: > diff -ruNp > 520-version-specific-x86_64.patch-old/include/asm-x86_64/suspend2.h > 520-version-specific-x86_64.patch-new/include/asm-x86_64/suspend2.h > --- 520-version-specific-x86_64.patch-old/include/asm-x86_64/suspend2.h > 1970-01-01

Re: [PATCH] [43/48] Suspend2 2.1.9.8 for 2.6.12: 619-userspace-nofreeze.patch

On 7/6/05, Nigel Cunningham <[EMAIL PROTECTED]> wrote: > diff -ruNp 620-userui-header.patch-old/kernel/power/suspend2_core/ui.c > 620-userui-header.patch-new/kernel/power/suspend2_core/ui.c > --- 620-userui-header.patch-old/kernel/power/suspend2_core/ui.c 1970-01-01 > 10:00:00.0 +1000

Re: [PATCH] [46/48] Suspend2 2.1.9.8 for 2.6.12: 622-swapwriter.patch

On 7/6/05, Nigel Cunningham <[EMAIL PROTECTED]> wrote: > diff -ruNp 623-generic-block-io.patch-old/kernel/power/suspend_block_io.c > 623-generic-block-io.patch-new/kernel/power/suspend_block_io.c > --- 623-generic-block-io.patch-old/kernel/power/suspend_block_io.c > 1970-01-01

Re: [PATCH] [1/48] Suspend2 2.1.9.8 for 2.6.12: submit_intro

On 7/6/05, Nigel Cunningham <[EMAIL PROTECTED]> wrote: > diff -ruNp 300-reboot-handler-hook.patch-old/kernel/sys.c > 300-reboot-handler-hook.patch-new/kernel/sys.c > --- 300-reboot-handler-hook.patch-old/kernel/sys.c 2005-06-20 > 11:47:32.0 +1000 > +++

Re: [0/48] Suspend2 2.1.9.8 for 2.6.12

Hi Nigel, On 7/6/05, Nigel Cunningham <[EMAIL PROTECTED]> wrote: > As requested, here are the patches that form Suspend2, for review. > > I've tried to split it up into byte size chunks, but please don't expect > that these will be patches that can mutate swsusp into Suspend2. That > would

Re: [PATCH] [45/48] Suspend2 2.1.9.8 for 2.6.12: 621-swsusp-tidy.patch

On 7/6/05, Nigel Cunningham <[EMAIL PROTECTED]> wrote: > diff -ruNp 622-swapwriter.patch-old/kernel/power/suspend_swap.c > 622-swapwriter.patch-new/kernel/power/suspend_swap.c > --- 622-swapwriter.patch-old/kernel/power/suspend_swap.c1970-01-01 > 10:00:00.0 +1000 > +++

Re: [PATCH] [41/48] Suspend2 2.1.9.8 for 2.6.12: 617-proc.patch

On 7/6/05, Nigel Cunningham <[EMAIL PROTECTED]> wrote: > diff -ruNp 618-core.patch-old/kernel/power/suspend2_core/suspend.c > 618-core.patch-new/kernel/power/suspend2_core/suspend.c > --- 618-core.patch-old/kernel/power/suspend2_core/suspend.c 1970-01-01 > +#define SNPRINTF(a...) len

Re: [PATCH] [2/48] Suspend2 2.1.9.8 for 2.6.12: 300-reboot-handler-hook.patch

On 7/6/05, Nigel Cunningham <[EMAIL PROTECTED]> wrote: > diff -ruNp > 301-proc-acpi-sleep-activate-hook.patch-old/drivers/acpi/sleep/proc.c > 301-proc-acpi-sleep-activate-hook.patch-new/drivers/acpi/sleep/proc.c > --- 301-proc-acpi-sleep-activate-hook.patch-old/drivers/acpi/sleep/proc.c >

Re: [PATCH] [48/48] Suspend2 2.1.9.8 for 2.6.12: 624-filewriter.patch

On 7/6/05, Nigel Cunningham <[EMAIL PROTECTED]> wrote: > diff -ruNp 625-crypto-api-work.patch-old/crypto/lzf.c > 625-crypto-api-work.patch-new/crypto/lzf.c > --- 625-crypto-api-work.patch-old/crypto/lzf.c 1970-01-01 10:00:00.0 > +1000 > +++ 625-crypto-api-work.patch-new/crypto/lzf.c

Re: [PATCH] [34/48] Suspend2 2.1.9.8 for 2.6.12: 610-extent.patch

On 7/6/05, Nigel Cunningham <[EMAIL PROTECTED]> wrote: > diff -ruNp 611-io.patch-old/kernel/power/suspend2_core/io.c > 611-io.patch-new/kernel/power/suspend2_core/io.c > --- 611-io.patch-old/kernel/power/suspend2_core/io.c1970-01-01 > 10:00:00.0 +1000 > +++

Re: [PATCH] [32/48] Suspend2 2.1.9.8 for 2.6.12: 609-driver-model.patch

On 7/6/05, Nigel Cunningham <[EMAIL PROTECTED]> wrote: > diff -ruNp 610-encryption.patch-old/kernel/power/suspend2_core/encryption.c > 610-encryption.patch-new/kernel/power/suspend2_core/encryption.c > --- 610-encryption.patch-old/kernel/power/suspend2_core/encryption.c > 1970-01-01

Re: [PATCH] [26/48] Suspend2 2.1.9.8 for 2.6.12: 603-suspend2_common-headers.patch

On 7/6/05, Nigel Cunningham <[EMAIL PROTECTED]> wrote: > diff -ruNp 604-utility-header.patch-old/kernel/power/suspend2_core/utility.c > 604-utility-header.patch-new/kernel/power/suspend2_core/utility.c > --- 604-utility-header.patch-old/kernel/power/suspend2_core/utility.c > 1970-01-01

Re: [PATCH] [25/48] Suspend2 2.1.9.8 for 2.6.12: 602-smp.patch

On 7/6/05, Nigel Cunningham <[EMAIL PROTECTED]> wrote: > diff -ruNp > 603-suspend2_common-headers.patch-old/kernel/power/suspend2_core/suspend2_common.h > > 603-suspend2_common-headers.patch-new/kernel/power/suspend2_core/suspend2_common.h > --- >

Re: [PATCH] [37/48] Suspend2 2.1.9.8 for 2.6.12: 613-pageflags.patch

On 7/6/05, Nigel Cunningham <[EMAIL PROTECTED]> wrote: > diff -ruNp 614-plugins.patch-old/kernel/power/suspend2_core/plugins.c > 614-plugins.patch-new/kernel/power/suspend2_core/plugins.c > --- 614-plugins.patch-old/kernel/power/suspend2_core/plugins.c 1970-01-01 > 10:00:00.0 +1000 >

Re: Head parking (was: IBM HDAPS things are looking up)

Jens Axboe wrote: > > ATA7 defines a park maneuvre, I don't know how well supported it is > > yet though. You can test with this little app, if it says 'head > > parked' it works. If not, it has just idled the drive. On 7/7/05, Lenz Grimmer <[EMAIL PROTECTED]> wrote: > Great! Thanks for digging

Re: [PATCH] [46/48] Suspend2 2.1.9.8 for 2.6.12: 622-swapwriter.patch

Hi Nigel, > diff -ruNp 623-generic-block-io.patch-old/kernel/power/suspend_block_io.c > 623-generic-block-io.patch-new/kernel/power/suspend_block_io.c > --- 623-generic-block-io.patch-old/kernel/power/suspend_block_io.c > 1970-01-01 10:00:00.0 +1000 > +++

Re: Head parking (was: IBM HDAPS things are looking up)

On 7/7/05, Martin Knoblauch <[EMAIL PROTECTED]> wrote: > Interesting. Same Notebook, same drive. The program say "not parked" > :-( This is on FC2 with a pretty much vanilla 2.6.9 kernel. > > [EMAIL PROTECTED] tmp]# uname -a > Linux l15833 2.6.9-noagp #1 Wed May 4 16:09:14 CEST 2005 i686 i686

Re: Developing a filesystem

On 7/8/05, Guillermo López Alejos <[EMAIL PROTECTED]> wrote: > Hi, > > As I anounced a couple of weeks ago, I'm studying how to build a new > filesystem. I have taken a look at the ramfs and also read some > documentation about. > > Now I'm writing my own dummyfs (based on ramfs) to know how

Re: [RFC PATCH 1/8] share/private/slave a subtree

On 7/8/05, Ram <[EMAIL PROTECTED]> wrote: > This patch adds the shared/private/slave support for VFS trees. Inlining the patches to email would be greatly appreciated. Here are some comments. > +int > +_do_make_mounted(struct nameidata *nd, struct vfsmount **mnt) Use two underscores to follow

<    4   5   6   7   8   9   10   11   12   13   >