e and be
reasonably smart about it:
- focus on GPL first, ignoring BSD/MIT for now
- only take out unambiguous boilerplate that is matched exactly
- and only take it out if there a proper and corresponding
license identifier already there, or add one otherwise
[0] https://github.com/nexB/scancode-
good to have SPDX identifiers in all files to make it easier to
>> > audit the kernel tree for correct licenses. This patch adds these
>> > identifiers to all files in drivers/usb/ based on a script and data from
>> > Thomas Gleixner, Philippe Ombredanne, and Kate Stew
ODULE_LICENSE: the MODULE_LICENSE should be
aligned to match the licensing
I'll run a scancode-toolkit scan on the tip of Linus' tree and create
a CSV from that to surface these oddities.
Unless you prefer me to use another tree like on the USB side for a start.
--
Cordially
Philippe Ombredanne, the wild licenses tamer
icense is "GPL 2.0
only": here the MODULE_LICENSE would need to be fixed to "GPL v2"
- or MODULE_LICENSE is "GPL v2" and the top level license is "GPL 2.0
or later": here the MODULE_LICENSE would need to be fixed to "GPL"
These will need to be fix
Martin Kepplinger <mart...@posteo.de>
>
> Patch applied. Thanks.
Herbert,
You may have missed the thread on the similar "samples" patch [1]
before applying this as-is?
[1] https://lkml.org/lkml/2017/11/14/135
--
Cordially
Philippe Ombredanne
vention at the same time?
eg:
> + // SPDX-License-Identifier: GPL-2.0
> /*
> * Copyright (C) Maxime Coquelin 2015
> + * Copyright (C) STMicroelectronics SA 2017
> * Author: Maxime Coquelin <mcoquelin.st...@gmail.com>
> - * License terms: GNU General Public License (GPL), version 2
--
Cordially
Philippe Ombredanne
ted on the comment style and unless the code demands /**/
comments as in a few .h also used in assembly, the style to use should
be a top level line this way:
> +// SPDX-License-Identifier: GPL-2.0
You can check the rationale in recent threads on this very topic.
Thomas (tglx) also wrote the doc on this.
--
Cordially
Philippe Ombredanne
d me much more compact and has the same effect. IMHO this
especially makes sense for new code as we are still cleaning the rest
of the kernel, so this would avoid extra work to clean this up later.
--
Cordially
Philippe Ombredanne
t you can now rightfully remove this line
IMHO as the "SPDX-License-Identifier: GPL-2.0" already covers it now
e.g:
> - * License terms: GNU General Public License (GPL), version 2
--
Cordially
Philippe Ombredanne
his instead?
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Copyright (C) 2017 Arasan Chip Systems Inc.
>> + *
>> + * Author: Atul Garg <ag...@arasan.com>
>> + */
Shorter and cleaner!
In any case you likely do not want a trailing comma after Arasan Chip
Systems Inc.
--
Cordially
Philippe Ombredanne
y <oleksan...@mellanox.com>
>> + *
>> + * Released under the GPLv2 only.
>> + * SPDX-License-Identifier: GPL-2.0
>> + */
I think the SPDX id should be on the first line as requested by Linus
and documented by Thomas (tglx) and Greg (greg-kh). And it should use
// c
lines by only two lines :) it'[s neat right?
And this would also help as we have tagged already ~15K files, so it
would help to use this for new files so the amount of cleanup work
still left does not increase. Thank you for your kind consideration!
--
Cordially
Philippe Ombredanne
e sense to use the new SPDX ids here? e.g.
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (c) 2011-2016, The Linux Foundation
This neat and cleaner, is it?
See tglx doc posted as patches and Linus comments for a rationale on
the comment styles.
--
Cordially
Philippe Ombredanne
On Mon, Nov 27, 2017 at 9:02 AM, Martin Kepplinger <mart...@posteo.de> wrote:
> This adds an SPDX license identifier to this driver I wrote some time back.
>
> Signed-off-by: Martin Kepplinger <mart...@posteo.de>
Reviewed-by: Philippe Ombredanne <pombreda...@nexb.c
is not a mistake and is what Linus wants
there. See the threads on this topic.
> @@ -0,0 +1,857 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2017 Linaro Ltd.
> + */
Isn't this shorter and better? :P
BTW, if you need help to fix this on the rest of Linaro contributed
c
ersion 2 or later at the following locations:
>> + *
>> + * http://www.opensource.org/licenses/gpl-license.html
>> + * http://www.gnu.org/copyleft/gpl.html
>> + */
Exactly!
And while you are it , you could replace the boilerplate license text
with the SPDX id.
--
Cordially
Philippe Ombredanne
d/or
> + * modify it under the terms of version 2 of the GNU General Public
> + * License as published by the Free Software Foundation.
> + */
I think an SPDX id would be better here e.g. just this may be?
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (c) 2017 Facebook
It should be on the first line as requested by Linus and documented by
Thomas (tglx) and Greg (greg-kh). And it should use // comments.
See threads on these topics.
--
Cordially
Philippe Ombredanne
ilbox.c
> @@ -0,0 +1,633 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
FYI, the style Linus wants us to use is this for .c:, as a top line:
// SPDX-License-Identifier: GPL-2.0
See the threads for details on this.
--
Cordially
Philippe Ombredanne
e GNU General Public License along
> with
> - * this program. If not, see <http://www.gnu.org/licenses/>.
> + * Copyright (C) STMicroelectronics 2017
> + * Author: Gabriel Fernandez <gabriel.fernan...@st.com> for
> STMicroelectronics.
> */
>
> #include
Awesome! Don't you like it when you remove this type of things?
FWIW,
Reviewed-by: Philippe Ombredanne <pombreda...@nexb.com>
--
Cordially
Philippe Ombredanne
a bonus ;)
> +// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
> +// Copyright (c) 2015-17 Intel Corporation.
Neater and simpler, is it not? In any case the SPDX line should go at the top.
See Linus and tglx doc posts for comment and doc styles for this.
NB: some includes used in assembly sometimes require to use /**/
comments instead.
--
Cordially
Philippe Ombredanne
ation
Neater and simpler?
See Linus posts on the topic of comment styles too BTW
--
Cordially
Philippe Ombredanne
Benjamin:
On Thu, Nov 30, 2017 at 2:05 PM, Benjamin Gaignard
<benjamin.gaign...@linaro.org> wrote:
> 2017-11-30 13:56 GMT+01:00 Philippe Ombredanne <pombreda...@nexb.com>:
>> On Thu, Nov 30, 2017 at 1:47 PM, Benjamin Gaignard
>> <benjamin.gaign...@linaro.org> wrot
On Thu, Nov 30, 2017 at 2:36 PM, Patrick Brünn <p.bru...@beckhoff.com> wrote:
>>From: Philippe Ombredanne [mailto:pombreda...@nexb.com]
>>Sent: Donnerstag, 30. November 2017 09:18
>>>
>>>> +/*
>>>> + * Copyright (C) 2004-2011
On Thu, Nov 30, 2017 at 1:47 PM, Benjamin Gaignard
<benjamin.gaign...@linaro.org> wrote:
> 2017-11-30 12:28 GMT+01:00 Philippe Ombredanne <pombreda...@nexb.com>:
>> On Thu, Nov 30, 2017 at 9:41 AM, Benjamin Gaignard
>> <benjamin.gaign...@linaro.org> wrote:
>> + * This file is subject to the terms and conditions of the GNU General
>> Public
>> + * License. See the file "COPYING" in the main directory of this archive
>> + * for more details.
>> + *
>> + * Copyright (C) 2017 Cavium, Inc.
>> + */
Since you nicely included an SPDX id, you would not need the
boilerplate anymore. e.g. these can go alright?
>> + * This file is subject to the terms and conditions of the GNU General
>> Public
>> + * License. See the file "COPYING" in the main directory of this archive
>> + * for more details.
--
Cordially
Philippe Ombredanne
Neil,
On Fri, Dec 1, 2017 at 10:19 AM, Neil Armstrong <narmstr...@baylibre.com> wrote:
> Hi Philippe,
>
> On 01/12/2017 10:02, Philippe Ombredanne wrote:
>> On Fri, Dec 1, 2017 at 9:54 AM, Neil Armstrong <narmstr...@baylibre.com>
>> wrote:
>>> On 30/1
.0
> + // Copyright (c) 2017 Spreadtrum Communications Inc.
or at least this with the id on the first and the // comment style
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2017 Spreadtrum Communications Inc.
> + *
> + */
--
Cordially
Philippe Ombredanne
as a bonus, this device tree addition of yours minus this
boilerplate could save a few real trees if someone ever prints --god
forbid-- this file, so you would be making a good thing for the
planet! And consider too the energy savings from not having these
extra bytes transferred million of times and not retrieved from disks
spindles.
[1] https://marc.info/?l=linux-kernel=151051532322831=2
[2] https://lwn.net/SubscriberLink/739183/262749cbe307ddc7/
--
Cordially
Philippe Ombredanne
bre.com>
>>> + *
>>> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>>> + */
Should this be instead on the first line with a // comment style if
possible, right?
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
Thomas has sent a first doc patch [1] set and is working on an updated
version. Jonathan also wrote a nice background article on the topic
at LWN [2].
Linus explained why he wants the // comment style and a first line
location on the list too.
[1] https://marc.info/?l=linux-kernel=151051532322831=2
[2] https://lwn.net/SubscriberLink/739183/262749cbe307ddc7/
--
Cordially
Philippe Ombredanne
On Fri, Dec 1, 2017 at 6:35 AM, Bjorn Andersson
<bjorn.anders...@linaro.org> wrote:
> On Thu 30 Nov 00:18 PST 2017, Philippe Ombredanne wrote:
>
>> Bjorn,
>>
>> On Thu, Nov 30, 2017 at 2:16 AM, Bjorn Andersson
>> <bjorn.anders...@linaro.org> wrote
r (at your option) any later version.
> + */
Would you mind using the new SPDX tags here. See Thomas patches [1]. Thanks!
[1] https://lkml.org/lkml/2017/12/4/934
--
Cordially
Philippe Ombredanne
David, Greg,
On Fri, Dec 1, 2017 at 6:42 PM, David Daney <dda...@caviumnetworks.com> wrote:
> On 11/30/2017 11:53 PM, Philippe Ombredanne wrote:
[...]
>>>> --- /dev/null
>>>> +++ b/arch/mips/cavium-octeon/resource-mgr.c
>>>> @@ -0,0 +1,371
David,
On Fri, Dec 1, 2017 at 9:01 PM, David Daney <dda...@caviumnetworks.com> wrote:
> On 12/01/2017 11:49 AM, Philippe Ombredanne wrote:
>>
>> David, Greg,
>>
>> On Fri, Dec 1, 2017 at 6:42 PM, David Daney <dda...@caviumnetworks.com>
>> wrote:
>&g
+ * GNU General Public License for more details.
> + */
Do you mind using the new SPDX ids instead of this long legalese?
You can check the doc patches from Thomas for details [1]
[1] https://lkml.org/lkml/2017/12/4/934
--
Cordially
Philippe Ombredanne
gt;
>>> Cc: Sylwester Nawrocki <snawro...@kernel.org>
>>> Cc: Sakari Ailus <sakari.ai...@iki.fi>
>>> Cc: Philippe Ombredanne <pombreda...@nexb.com>
>>> ---
>>> Changes from v9:
>>> - Use SPDX License ID (Philippe)
For the use of SPDX tags, thanks!
Acked-by: Philippe Ombredanne <pombreda...@nexb.com>
e doc patches from Thomas for details [1]
[1] https://lkml.org/lkml/2017/12/4/934
--
Cordially
Philippe Ombredanne
*/
>
> #ifndef __SPI_S3C64XX_H
> --
> 2.15.1
>
You still need to put this line at the very top of the file, first
line. That's the convention for the SPDX tags as documented by Thomas
Gleixner.
> + * SPDX-License-Identifier: GPL-2.0
--
Cordially
Philippe Ombredanne
Dhaval,
On Wed, Dec 13, 2017 at 10:52 AM, Dhaval Shah
<dhaval.s...@softnautics.com> wrote:
> HI
>
> Thanks a lot for the review.
>
>> From: Philippe Ombredanne <pombreda...@nexb.com>
>> Sent: Wednesday, December 13, 2
new way as documented in
Thomas [1] patches and already adopted by other Intel contributors.
Thank you for your kind consideration!
[1] https://lkml.org/lkml/2017/12/4/934
CC: Vinod Koul <vinod.k...@intel.com>
CC: Jessica Marz <jessica.m...@intel.com>
--
Cordially
Philippe Ombredanne
, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>> + * OTHER DEALINGS IN THE SOFTWARE.
>> + */
>
> Patch looks good.
>
> Just a comment: people have been starting to use SPDX license identifiers.
>
> This would really make all this huge license text much shorter :-)
Oh yes, please! Every time there are more than three lines of legalese
in a kernel source code file, a kitten dies somewhere. That's sad. We
all love kitten, right? See also Thomas doc patches for details [1]
though he forgot to mention this cat fact.
[1] https://lkml.org/lkml/2017/12/4/934
--
Cordially
Philippe Ombredanne
by the Free Software Foundation.
> + */
Would you mind using the new SPDX tags here. See Thomas patches [1]
> +MODULE_LICENSE("GPL");
Also please make sure your module license (here GPL 2.0 or later per
module.h) matches your top level license tag correctly (here GPL 2.0
only)?
[1] https://lkml.org/lkml/2017/12/4/934
--
Cordially
Philippe Ombredanne
he Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + */
Please consider using the new SPDX tags per Thomas doc patches [1]
Thanks!
[1] https://lkml.org/lkml/2017/12/4/934
--
Cordially
Philippe Ombredanne, your friendly kernel licensing scruffy
CLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> + *
> + * Authors:
> + *
> + * Jarkko Sakkinen <jarkko.sakki...@linux.intel.com>
> + * Suresh Siddha <suresh.b.sid...@intel.com>
or can use mailbox
> to interact with the PF driver.
>
> Signed-off-by: Salil Mehta <salil.me...@huawei.com>
> Signed-off-by: lipeng <lipeng...@huawei.com>
> ---
> Patch V3: Addressed SPDX change requested by Philippe Ombredanne
> Link: https://lkml.org/lkml/2017/12/8/87
bute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
You may want to use the new SPDX ids as documented in Thomas doc
patches instead of the loner legalese?
--
Cordially
Philippe Ombredanne
his patchset with V2 or we
> will update in the next patchset once this patch merge?
That's not for me to decide, I am just a lowly licensing elf helper scruffy!
PS: you might want to avoid sending HTML email on lkml, FWIW.
--
Cordially
Philippe Ombredanne
lp Greg and
Thomas with kernel license scans). Net effect is that on a laptop on 8
threads it takes ~20 minutes to scan a whole kernel using this
diff-based approach and obtain a fairly accurate license detection.
--
Cordially
Philippe Ombredanne
are over 80+ licenses in the kernel and
there is (or rather was before starting adding SPDX tags) 1000+
different license notices and over 700+ variations of "this file in
under the GPL"... This starts to diminish a bit with the addition of
SPDX tags and eventually most or all boilerplate could be removed over
time with reviews and discussions, IMHO for the better: I will then be
able to trash my tool and use a good ole grep instead ;)
--
Cordially
Philippe Ombredanne
jtag_unregister;
> - jtag_alloc;
> - jtag_free;
>
> Platform driver on registration with jtag-core creates the next
> entry in dev folder:
> /dev/jtagX
>
> Signed-off-by: Oleksandr Shamray <oleksan...@mellanox.com>
> Signed-off-by: Jiri Pirko <j...@mellanox.com>
<a...@arndb.de>
> ---
> v13->v14
> Comments pointed by Philippe Ombredanne <pombreda...@nexb.com>
> - Change style of head block comment from /**/ to //
>
> v12->v13
> Comments pointed by Philippe Ombredanne <pombreda...@nexb.com>
> - Change
by the copyright
> owners, or by LF legal counseling. So, I prefer to not pick those myself,
> except from people I trust.
Exactly, and this why --after the first batch that Greg pushed and
Linus pulled and that had been carefully reviewed--, I am trying to
gently nit the submitters of new patches, one at a time to use the new
SPDX tags. Eventually if I can find the time, I could also submit some
bigger patches to add SPDX tags to a bunch of files at once but that
would have to be organized in small batches by copyright holder and
these would be only RFCs until reviewed by and agreed to by the actual
copyright holders.
--
Cordially
Philippe Ombredanne
kernel@vger.kernel.org (open list)
> Cc: Fabio Estevam <fabio.este...@nxp.com>
> Cc: Juergen Borleis <j...@pengutronix.de>
> Cc: Noel Vellemans <noel.vellem...@visionbms.com>
> Cc: Shawn Guo <shawn...@kernel.org>
> Cc: Sascha Hauer <ker...@pengutronix
he Free Software Foundation; either version
> + * 2 of the License, or (at your option) any later version.
> + */
Would you mind using the new SPDX tags documented in Thomas patch set
[1] rather than this legalese?
Thank you!
[1] https://lkml.org/lkml/2017/12/4/934
--
Cordially
Philippe Ombredanne
e terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + */
Would you mind using the new SPDX tags documented in Thomas patch set
[1] rather than this fine but longer legalese? Thank you!
[1] https://lkml.org/lkml/2017/12/4/934
--
Cordially
Philippe Ombredanne
t; + * GNU General Public License for more details.
>> + */
Could you consider using the new SPDX tags documented in Thomas patch set
[1] rather than this fine but longer legalese?
Thank you!
[1] https://lkml.org/lkml/2017/12/4/934
--
Cordially
Philippe Ombredanne
t; + * eXtensible Bitmaps provide an unlimited-size sparse bitmap facility.
> + * All bits are initially zero.
> + */
Would you mind using the new SPDX tags documented in Thomas patch set
[1] rather than this fine but longer legalese?
And if you could spread the word to others in your team this
Alexandre, Linux
On Fri, Dec 15, 2017 at 12:53 AM, Linus Walleij
<linus.wall...@linaro.org> wrote:
> On Wed, Dec 13, 2017 at 10:23 AM, Philippe Ombredanne
> <pombreda...@nexb.com> wrote:
>> On Wed, Dec 13, 2017 at 9:15 AM, Linus Walleij <linus.wall...@linaro.org>
&
note, you want to make sure that such as patch set
is not merged by mistake until you have collected an explicit review
or ack from all the copyright holders involved.
May be calling it an "RFC" could be best until you have these acks?
--
Cordially
Philippe Ombredanne
derivative of the PF driver. Just like PF driver, this driver is also PCI
> Express based.
>
> Change Log Summary:
> Patch V4: Addressed SPDX related comment by Philippe Ombredanne
> Patch V3: Addressed SPDX change requested by Philippe Ombredanne
Thank you.
For the u
nse for more details.
> + */
Have you considered using the new SPDX tags instead of this fine but
long legalese? And if other Chromium contributors could follow suit
and you could spread the word that would be even better!
See Thomas doc patches [1] for details.
Thanks!
[1] https://lkml.org/lkml/2017/12/4/934
--
Cordially
Philippe Ombredanne
ou use the new SPDX tags instead of this fine and long boilerplate? See
Thomas doc for details [1]
[1] https://lkml.org/lkml/2017/12/4/934
Thanks!
PS: if you could spread the word out in your team too, this would be
much welcomed!
--
Cordially
Philippe Ombredanne
mments made on the list by Linus.
If you could spread the word out in your team too, this would be much welcomed!
Thanks!
[1] https://lkml.org/lkml/2017/12/4/934
--
Cordially
Philippe Ombredanne
samsung.com>
>*/
>
> or
>
> 2. with a little interpretation
>
> /*
>* SPDX-License-Identifier: GPL-2.0
>*
>* Copyright (C) 2009 Samsung Electronics Ltd.
>* Jaswinder Singh <jassi.b...@samsung.com>
>*/
>
> (I opted for the one with the least number of changes)
You should go strictly by Thomas' doc. This is one area where
consistency is the thing that brings benefits. Interpretation is not
needed.
So please, consider going with 1.
--
Cordially
Philippe Ombredanne
mode 100644 drivers/soundwire/slave.c
> create mode 100644 include/linux/soundwire/sdw.h
> create mode 100644 include/linux/soundwire/sdw_intel.h
> create mode 100644 include/linux/soundwire/sdw_registers.h
> create mode 100644 include/linux/soundwire/sdw_type.h
>
> --
> 2.7.4
>
Thanks!
For the whole patch set my reviewed-by stands for the usage of SPDX
license tags.
(I am not qualified to review the rest ;) )
--
Cordially
Philippe Ombredanne
option) any later version.
> + */
Could you use the new SPDX tags instead of this fine and long
boilerplate? See Thomas doc for details [1]
[1] https://lkml.org/lkml/2017/12/4/934
Thanks!
--
Cordially
Philippe Ombredanne
,10 +1,8 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +
> /*
> * Copyright (C) 2009 Samsung Electronics Ltd.
> * Jaswinder Singh <jassi.b...@samsung.com>
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under
g a
"suggestion", but that's your call to consider it this way.
--
Cordially
Philippe Ombredanne
You should have received a copy of the GNU General Public License
> + * along with this program; if not, see <http://www.gnu.org/licenses/>.
> + */
Would you mind using the new SPDX tags documented in Thomas patch set
[1] rather than this fine but longer legalese?
Thank you!
[1] https://lkml.org/lkml/2017/12/4/934
--
Cordially
Philippe Ombredanne
[2] https://blogs.s-osg.org/linux-kernel-license-practices-revisited-spdx/
--
Cordially
Philippe Ombredanne
.. and use SPDX tags for the top level notice of course!
Thank you!
[1] https://lkml.org/lkml/2017/12/4/934
CC: Aleksey Makarov <aleksey.maka...@cavium.com>
--
Cordially
Philippe Ombredanne
On Sun, Dec 17, 2017 at 7:46 PM, Maciej S. Szmigiero
<m...@maciej.szmigiero.name> wrote:
> This series adds support for analog part of Medion 95700 in the cxusb
> driver.
> Changes from v3:
> Add SPDX tag to a newly added "cxusb-analog.c" file.
Thank you.
--
Cordially
Philippe Ombredanne
firm this is the correct way.
>
> With this fixed you can add:
>
> Reviewed-by: Fabio Estevam <fabio.este...@nxp.com>
--
Cordially
Philippe Ombredanne
On Fri, Nov 17, 2017 at 9:57 AM, Greg Kroah-Hartman
<gre...@linuxfoundation.org> wrote:
> On Fri, Nov 17, 2017 at 08:37:28AM +0100, Philippe Ombredanne wrote:
>> Or fix the non-standard redefinition of the MODULE_LICENSE macro as
>> DRIVER_LICENSE as in [2] and found else
c language of your notices in the
scancode-toolkit!
FWIW for this 6 patch series:
Reviewed-by: Philippe Ombredanne <pombreda...@nexb.com>
CC: Thomas Gleixner <t...@linutronix.de>
CC: Greg Kroah-Hartman <gre...@linuxfoundation.org>
--
Cordially
Philippe Ombredanne
gt;
> ---
For this V4 and all the V2 11 patch series, after using a fine comb
Reviewed-by: Philippe Ombredanne <pombreda...@nexb.com>
--
Cordially
Philippe Ombredanne
er <mart...@posteo.de>
FWIW, looking all good to me!
Reviewed-by: Philippe Ombredanne <pombreda...@nexb.com>
--
Cordially
Philippe Ombredanne
On Fri, Nov 17, 2017 at 4:01 PM, Mauro Carvalho Chehab
<mche...@s-opensource.com> wrote:
> Em Fri, 17 Nov 2017 12:54:15 +0100
> Philippe Ombredanne <pombreda...@nexb.com> escreveu:
>
>> On Fri, Nov 17, 2017 at 11:21 AM, Mauro Carvalho Chehab
>> <mche...@s-open
<airl...@linux.ie>
> Reported-by: Philippe Ombredanne <pombreda...@nexb.com>
> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombreda...@nexb.com>
--
Cordially
Philippe Ombredanne
om>
> Cc: Arvind Yadav <arvind.yadav...@gmail.com>
> Reported-by: Philippe Ombredanne <pombreda...@nexb.com>
> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombreda...@nexb.com>
--
Cordially
Philippe Ombredanne
the source
> code license to work properly, as there is no need to unwind the
> unneeded dereference, especially when it is defined just a few lines
> above from where it is used.
>
> Cc: Wim Van Sebroeck <w...@iguana.be>
> Cc: Guenter Roeck <li...@roeck-us.net&
s4all.nl>
>> Cc: Mauro Carvalho Chehab <mche...@kernel.org>
>> Cc: Johan Hovold <jo...@kernel.org>
>> Cc: Davidlohr Bueso <d...@stgolabs.net>
>> Cc: Sakari Ailus <sakari.ai...@linux.intel.com>
>> Reported-by: Philippe Ombredanne <pombreda...@
the source
> code license to work properly, as there is no need to unwind the
> unneeded dereference.
>
> Cc: "David S. Miller" <da...@davemloft.net>
> Cc: Andreas Kemnade <andr...@kemnade.info>
> Cc: Johan Hovold <jo...@kernel.org>
> Reported-by: Phi
r Bueso <d...@stgolabs.net>
> Cc: Sakari Ailus <sakari.ai...@linux.intel.com>
> Reported-by: Philippe Ombredanne <pombreda...@nexb.com>
> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombreda...@nexb.com>
--
Cordially
Philippe Ombredanne
On Fri, Nov 17, 2017 at 6:01 PM, Mauro Carvalho Chehab
<mche...@s-opensource.com> wrote:
> Em Fri, 17 Nov 2017 16:01:41 +0100
> Philippe Ombredanne <pombreda...@nexb.com> escreveu:
>
>> On Fri, Nov 17, 2017 at 3:58 PM, Mauro Carvalho Chehab
>> <mche...@s-openso
third-party module:
MODULE_LICENSE("\x47\x50\x4c\x20\x76\x32");
... which was most likely from a GPL-shy closet Free software
advocate: this is "GPL v2" in ASCII.
--
Cordially
Philippe Ombredanne
On Sat, Nov 18, 2017 at 1:49 PM, Greg Kroah-Hartman
<gre...@linuxfoundation.org> wrote:
> On Sat, Nov 18, 2017 at 01:39:03PM +0100, Philippe Ombredanne wrote:
>> On Sat, Nov 18, 2017 at 11:27 AM, Greg Kroah-Hartman
>> <gre...@linuxfoundation.org> wrote:
>> &
.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/alpha/kernel/srm_env.c?h=v4.14#n13
[3]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/module.h?h=v4.14#n174
[4]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/gma500/psb_drv.h?h=v4.14#n39
--
Cordially
Philippe Ombredanne
B/scancode-toolkit/blob/833-espedexify/src/scancode/plugin_espedexify.py
--
Cordially
Philippe Ombredanne
his
initial pull [3]
To get a lot of details you can check all the recent SPDX-related posts too [4]
[1] https://marc.info/?l=linux-kernel=151051532322831=2
[2] https://marc.info/?l=linux-kernel=151068111802610=2
[3] https://marc.info/?l=linux-kernel=150963579219623=2
[4] https://marc.info/?l=linux-kernel=2=1=spdx=b
--
Cordially
Philippe Ombredanne
20050507090312/http://www.fsf.org/licensing/licenses/gpl.html
[5]
http://web.archive.org/web/20031202220858/http://www.fsf.org/copyleft/gpl.html
[6]
http://web.archive.org/web/19980119061851/http://www.fsf.org/copyleft/gpl.html
[7] https://en.wikipedia.org/wiki/IBM_Selectric_typewriter
--
Cordially
Philippe Ombredanne
On Tue, Nov 21, 2017 at 2:57 PM, Philippe Ombredanne
<pombreda...@nexb.com> wrote:
> Alan, Linus,
>
> On Mon, Nov 20, 2017 at 4:31 PM, Alan Cox <gno...@lxorguk.ukuu.org.uk> wrote:
>> On Sat, 18 Nov 2017 11:14:00 -0800
>> Linus Torvalds <torva...@linux-f
Allen Hubbe <allen.hu...@emc.com>
> Cc: Gary R Hook <gary.h...@amd.com>
> Cc: Serge Semin <fancer.lan...@gmail.com>
> Reported-by: Philippe Ombredanne <pombreda...@nexb.com>
> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombreda...@nexb.com>
--
Cordially
Philippe Ombredanne
uot;Martin K. Petersen" <martin.peter...@oracle.com>
> Cc: Varun Prakash <va...@chelsio.com>
> Reported-by: Philippe Ombredanne <pombreda...@nexb.com>
> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombreda...@nexb.com>
--
Cordially
Philippe Ombredanne
tifier is a legally binding shorthand, which can be used
>> > instead of the full boiler plate text.
>> >
>> > This work is based on a script and data from Thomas Gleixner, Philippe
>> > Ombredanne, and Kate Stewart.
>> >
>> > Cc: Thomas Gleixner &
On Sun, Nov 5, 2017 at 2:51 PM, Greg Kroah-Hartman
<gre...@linuxfoundation.org> wrote:
> On Sun, Nov 05, 2017 at 01:53:54PM +0100, Philippe Ombredanne wrote:
>> On Sat, Nov 4, 2017 at 11:40 AM, Greg Kroah-Hartman
>> <gre...@linuxfoundation.org> wrote:
>> > On F
mples
that adopted SPDX license ids to simplify and clarify licensing
documentation.
[1] https://github.com/nexB/scancode-toolkit
[2]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/w1/slaves/w1_therm.c?h=v4.14-rc8#n8
--
Cordially
Philippe Ombredanne
it message as well for the why driver
> in drivers/misc.
Thank you for the SPDX comments updates.
Acked-by: Philippe Ombredanne <pombreda...@nexb.com>
--
Cordially
Philippe Ombredanne
ier: GPL-2.0+
// Copyright (C) 2017 Facebook
// Author: Roman Gushchin <g...@fb.com>
Don't you love it with less boilerplate and a better code/comments ratio?
BTW the comment style may surprise you here: this is a suggestion, but
not just. Check the posts from Linus on this topic and Thomas's doc
patches for the rationale.
Thank you for your kind consideration!
--
Cordially
Philippe Ombredanne
David,
On Fri, Dec 8, 2017 at 1:09 AM, David Daney <david.da...@cavium.com> wrote:
[]
> Changes in v5:
[]
> o Removed redundant licensing text boilerplate.
Thank you very much!
Acked-by: Philippe Ombredanne <pombreda...@nexb.com>
--
Cordially
Philippe Ombredanne, the licensing scruffy
Sricharan,
On Fri, Dec 8, 2017 at 12:00 PM, Sricharan R <sricha...@codeaurora.org> wrote:
> Hi Philippe,
>
>
> On 12/8/2017 3:53 PM, Philippe Ombredanne wrote:
>> Sricharan, Stephen,
>>
>> On Fri, Dec 8, 2017 at 10:29 AM, Sricharan R <sricha...@codeaurora
1 - 100 of 583 matches
Mail list logo
