[PATCH] Staging:Comedi:comedi_compat32.c: Lindent changes

Recommended indentation by Lindent on file comedi_compat32.c Signed-off-by: Pratik Jain <pratik.jain0...@gmail.com> --- drivers/staging/comedi/comedi_compat32.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/comedi/comedi_compat32.c b/d

[PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

Fixed coding style issue. Signed-off-by: Pratik Jain <pratik.jain0...@gmail.com> --- drivers/staging/comedi/drivers/ni_atmio.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c

[PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

Fixed coding style issue. Signed-off-by: Pratik Jain <pratik.jain0...@gmail.com> --- drivers/staging/comedi/drivers/ni_atmio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c

Re: [PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

Resending the email because it was sent only to Greg. Context: In my previous patch, I had removed an extra newline at the end of the code. My Reply: It was unintentional, but does it violate any coding or other standard?

Re: [PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

Yes that can be done. But isn't 80 column limit more of a historical convention? On Fri, Mar 16, 2018 at 10:17:28AM +, Ian Abbott wrote: > On 15/03/2018 18:59, Pratik Jain wrote: > > Fixed coding style issue. > > > > Signed-off-by: Pratik Jain <p

[PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

Fixed coding style issue. Signed-off-by: Pratik Jain <pratik.jain0...@gmail.com> --- drivers/staging/comedi/drivers/ni_atmio.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c

Re: [PATCH] Staging: xgifb: XGI_main_26.c: Fixed over 80 column characters

Thanks for the advice. I will work on it.

Re: [PATCH] Staging: xgifb: XGI_main_26.c: Fixed multi-line dereference warning

IGNORE THIS THREAD

[PATCH] Staging: xgifb: XGI_main_26.c: Fixed over 80 column characters

Fixed coding style issues detected by checkpatch.pl Signed-off-by: Pratik Jain <pratik.jain0...@gmail.com> --- drivers/staging/xgifb/XGI_main_26.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/s

[PATCH] Staging: xgifb: XGI_main_26.c: Fixed multi-line dereference warning

Fixed coding style issues detected by checkpatch.pl Signed-off-by: Pratik Jain <pratik.jain0...@gmail.com> --- drivers/staging/xgifb/XGI_main_26.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/s

[PATCH] Staging: xgifb: XGI_main_26.c: Refactored the function

Refactored the function `XGIfb_search_refresh_rate` by removing a level of `if...else` block nesting. Removed unnecessary parantheses. Signed-off-by: Pratik Jain <pratik.jain0...@gmail.com> --- drivers/staging/xgifb/XGI_main_26.c | 63 +++-- 1 file chang

Re: [PATCH] Staging: xgifb: XGI_main_26.c: Refactored the function

You got a valid point about `++i` and `i++`. But I still feel that it is less complicated than previous one. I am explicitly saying(in first loop) that we are skipping some values to get to a specific index. Apart from that, we can avoid unncessary wrapping and indentation. Logic becomes much more

[PATCH] Staging: xgifb: XGI_main_26.c: Refactored the function

Refactored the function `XGIfb_search_refresh_rate` by removing a level of `if...else` block nesting. Removed unnecessary parantheses. Signed-off-by: Pratik Jain <pratik.jain0...@gmail.com> --- drivers/staging/xgifb/XGI_main_26.c | 61 +++-- 1 file chang

[PATCH] Staging: xgifb: XGI_main_26.c: Refactored the function

Refactored the function `XGIfb_search_refresh_rate` by removing a level of `if...else` block nesting. Removed unnecessary parantheses. Signed-off-by: Pratik Jain <pratik.jain0...@gmail.com> --- drivers/staging/xgifb/XGI_main_26.c | 59 +++-- 1 file chang

[PATCH] Staging: xgifb: XGI_main_26.c: Refactored the function

Refactored the function `XGIfb_search_refresh_rate` by removing a level of `if...else` block nesting. Removed unnecessary parantheses. Signed-off-by: Pratik Jain <pratik.jain0...@gmail.com> --- drivers/staging/xgifb/XGI_main_26.c | 63 +++-- 1 file chang

[PATCH] Staging: xgifb: XGI_main_26.c: Refactored the function

Refactored the function `XGIfb_search_refresh_rate` by removing a level of `if...else` block nesting. Removed unnecessary parantheses. Removed potential bug of array underflow. Signed-off-by: Pratik Jain <pratik.jain0...@gmail.com> --- drivers/staging/xgifb/XGI_main_26.

[PATCH] Staging: xgifb: XGI_main_26.c: Refactored the function

Refactored the function `XGIfb_search_refresh_rate` by removing a level of `if...else` block nesting. Removed unnecessary parantheses. Signed-off-by: Pratik Jain --- drivers/staging/xgifb/XGI_main_26.c | 63 +++-- 1 file changed, 33 insertions(+), 30 deletions

[PATCH] Staging: xgifb: XGI_main_26.c: Refactored the function

Refactored the function `XGIfb_search_refresh_rate` by removing a level of `if...else` block nesting. Removed unnecessary parantheses. Signed-off-by: Pratik Jain --- drivers/staging/xgifb/XGI_main_26.c | 63 +++-- 1 file changed, 33 insertions(+), 30 deletions

Re: [PATCH] Staging: xgifb: XGI_main_26.c: Refactored the function

You got a valid point about `++i` and `i++`. But I still feel that it is less complicated than previous one. I am explicitly saying(in first loop) that we are skipping some values to get to a specific index. Apart from that, we can avoid unncessary wrapping and indentation. Logic becomes much more

[PATCH] Staging: xgifb: XGI_main_26.c: Refactored the function

Refactored the function `XGIfb_search_refresh_rate` by removing a level of `if...else` block nesting. Removed unnecessary parantheses. Signed-off-by: Pratik Jain --- drivers/staging/xgifb/XGI_main_26.c | 61 +++-- 1 file changed, 32 insertions(+), 29 deletions

[PATCH] Staging: xgifb: XGI_main_26.c: Refactored the function

Refactored the function `XGIfb_search_refresh_rate` by removing a level of `if...else` block nesting. Removed unnecessary parantheses. Signed-off-by: Pratik Jain --- drivers/staging/xgifb/XGI_main_26.c | 59 +++-- 1 file changed, 30 insertions(+), 29 deletions

[PATCH] Staging: xgifb: XGI_main_26.c: Refactored the function

Refactored the function `XGIfb_search_refresh_rate` by removing a level of `if...else` block nesting. Removed unnecessary parantheses. Removed potential bug of array underflow. Signed-off-by: Pratik Jain --- drivers/staging/xgifb/XGI_main_26.c | 59 +++-- 1 file

[PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

Fixed coding style issue. Signed-off-by: Pratik Jain --- drivers/staging/comedi/drivers/ni_atmio.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c index b9e9ab548c4b..e82fbe987dd8

[PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

Fixed coding style issue. Signed-off-by: Pratik Jain --- drivers/staging/comedi/drivers/ni_atmio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c index b9e9ab548c4b..4e27a2959b64

Re: [PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

Resending the email because it was sent only to Greg. Context: In my previous patch, I had removed an extra newline at the end of the code. My Reply: It was unintentional, but does it violate any coding or other standard?

Re: [PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

Yes that can be done. But isn't 80 column limit more of a historical convention? On Fri, Mar 16, 2018 at 10:17:28AM +, Ian Abbott wrote: > On 15/03/2018 18:59, Pratik Jain wrote: > > Fixed coding style issue. > > > > Signed-off-by: Pratik Jain > > --- > >

[PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

Fixed coding style issue. Signed-off-by: Pratik Jain --- drivers/staging/comedi/drivers/ni_atmio.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c index b9e9ab548c4b..2b7bfe0dd7f3

[PATCH] Staging:Comedi:comedi_compat32.c: Lindent changes

Recommended indentation by Lindent on file comedi_compat32.c Signed-off-by: Pratik Jain --- drivers/staging/comedi/comedi_compat32.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/comedi/comedi_compat32.c b/drivers/staging/comedi

[PATCH] Staging: xgifb: XGI_main_26.c: Fixed multi-line dereference warning

Fixed coding style issues detected by checkpatch.pl Signed-off-by: Pratik Jain --- drivers/staging/xgifb/XGI_main_26.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c index

[PATCH] Staging: xgifb: XGI_main_26.c: Fixed over 80 column characters

Fixed coding style issues detected by checkpatch.pl Signed-off-by: Pratik Jain --- drivers/staging/xgifb/XGI_main_26.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c index

Re: [PATCH] Staging: xgifb: XGI_main_26.c: Fixed multi-line dereference warning

IGNORE THIS THREAD

Re: [PATCH] Staging: xgifb: XGI_main_26.c: Fixed over 80 column characters

Thanks for the advice. I will work on it.