[PATCH v5 0/2] ubi: add possibility to skip CRC check for static UBI volumes

2018-07-02 Thread Quentin Schulz
chard, Quentin Schulz (2): ubi: provide a way to skip CRC checks ubi: expose the volume CRC check skip flag drivers/mtd/ubi/cdev.c | 11 +++ drivers/mtd/ubi/kapi.c | 2 +- drivers/mtd/ubi/ubi-media.h | 6 ++ drivers/mtd/ubi/ubi.h | 4 drivers/mtd/ubi/vmt.c

[PATCH v5 2/2] ubi: expose the volume CRC check skip flag

2018-07-02 Thread Quentin Schulz
-by: Boris Brezillon Signed-off-by: Quentin Schulz Reviewed-by: Boris Brezillon --- drivers/mtd/ubi/cdev.c | 11 +++ drivers/mtd/ubi/vmt.c | 3 +++ include/uapi/mtd/ubi-user.h | 18 -- 3 files changed, 30 insertions(+), 2 deletions(-) diff --git a/drive

[PATCH v2 0/2] add possibility to skip CRC check for static UBI volumes

2018-06-27 Thread Quentin Schulz
at the block granularity instead of verifying the whole volume. Skipping this test drastically improves the boot-time. Patches for mtd-utils will be available as well. Thanks, Quentin v2: - use volume flags instead of arguments on the kernel command line as suggested by Richard, Quentin

[PATCH v2 1/2] ubi: provide a way to skip CRC checks

2018-06-27 Thread Quentin Schulz
at the block granularity instead of verifying the whole volume. Skipping this test drastically improves the boot-time. Suggested-by: Boris Brezillon Signed-off-by: Quentin Schulz --- drivers/mtd/ubi/kapi.c | 2 +- drivers/mtd/ubi/ubi-media.h | 6 ++ drivers/mtd/ubi/ubi.h | 4

[PATCH v2 2/2] ubi: expose the volume CRC check skip flag

2018-06-27 Thread Quentin Schulz
e UBI volume for which we are trying to skip the CRC check is static. Suggested-by: Boris Brezillon Signed-off-by: Quentin Schulz --- drivers/mtd/ubi/cdev.c | 4 drivers/mtd/ubi/vmt.c | 3 +++ include/uapi/mtd/ubi-user.h | 16 ++-- 3 files changed, 21 insertions(

[PATCH v3 0/2] ubi: add possibility to skip CRC check for static UBI volumes

2018-06-28 Thread Quentin Schulz
suggested by Richard, Quentin Schulz (2): ubi: provide a way to skip CRC checks ubi: expose the volume CRC check skip flag drivers/mtd/ubi/cdev.c | 4 drivers/mtd/ubi/kapi.c | 2 +- drivers/mtd/ubi/ubi-media.h | 6 ++ drivers/mtd/ubi/ubi.h | 4 drivers/mtd/ubi/vmt.c

[PATCH v3 2/2] ubi: expose the volume CRC check skip flag

2018-06-28 Thread Quentin Schulz
e UBI volume for which we are trying to skip the CRC check is static. Suggested-by: Boris Brezillon Signed-off-by: Quentin Schulz Reviewed-by: Boris Brezillon --- drivers/mtd/ubi/cdev.c | 4 drivers/mtd/ubi/vmt.c | 3 +++ include/uapi/mtd/ubi-user.h | 16 ++-- 3

[PATCH v3 1/2] ubi: provide a way to skip CRC checks

2018-06-28 Thread Quentin Schulz
at the block granularity instead of verifying the whole volume. Skipping this test drastically improves the boot-time. Suggested-by: Boris Brezillon Signed-off-by: Quentin Schulz Reviewed-by: Boris Brezillon --- drivers/mtd/ubi/kapi.c | 2 +- drivers/mtd/ubi/ubi-media.h | 6

Re: [GIT PULL firmware] microchip: add firmware for VSC8574 and VSC8584 Ethernet PHYs

2018-12-14 Thread Quentin Schulz
Hi Josh, On Fri, Dec 14, 2018 at 07:57:37AM -0500, Josh Boyer wrote: > On Thu, Dec 6, 2018 at 5:34 AM Quentin Schulz > wrote: > > > > Hi all, > > > > Both VSC8574 and VSC8584 Ethernet PHYs require a firmware patch to be > > applied before making use of them

Re: [PATCH v6 8/8] mfd: axp20x: Add supported cells for AXP803

2018-12-10 Thread Quentin Schulz
Hi Lee, On Mon, Dec 10, 2018 at 06:27:18AM +, Lee Jones wrote: > On Sat, 08 Dec 2018, Quentin Schulz wrote: > > > Hi Lee, > > > > On Fri, Dec 07, 2018 at 07:22:37PM +, Lee Jones wrote: > > > On Fri, 07 Dec 2018, Vasily Khoruzhick wrote: > > >

Re: [PATCH] phy: ocelot-serdes: fix out-of-bounds read

2018-10-08 Thread Quentin Schulz
Hi Gustavo, On Mon, Oct 08, 2018 at 08:06:49PM +0200, Gustavo A. R. Silva wrote: > Currently, there is an out-of-bounds read on array ctrl->phys, > once variable i reaches the maximum array size of SERDES_MAX > in the for loop. > > Fix this by changing the condition in the for loop from > i <= SE

Re: [PATCH 1/2] dt-bindings: phy: Update SERDES_MAX to be SERDES_MAX + 1

2018-10-09 Thread Quentin Schulz
ecause the size of > array ctrl->phys is SERDES_MAX. > > Partially fix this by updating SERDES_MAX to be SERDES6G_MAX + 1. > > Notice that this is the first part of the solution to > the out-of-bounds bug mentioned above. Although this > change is not dependent on any

Re: [PATCH 2/2] phy: ocelot-serdes: fix out-of-bounds read

2018-10-09 Thread Quentin Schulz
for loop from > i <= SERDES_MAX to i < SERDES_MAX. > Reviewed-by: Quentin Schulz Thanks, Quentin signature.asc Description: PGP signature

Re: [PATCH 0/2] phy: ocelot-serdes: fix out-of-bounds bug

2018-10-09 Thread Quentin Schulz
size of SERDES_MAX > in the for loop. > > Quentin Schulz pointed out that SERDES_MAX is a valid value to > index ctrl->phys. So, I updated SERDES_MAX to be SERDES6G_MAX + 1 > in include/dt-bindings/phy/phy-ocelot-serdes.h. > > Then I changed the condition in the for loop f

Re: [PATCH 2/2] mmc: Add mmc_force_detect_change_begin / _end functions

2018-10-09 Thread Quentin Schulz
Hi Frieder, On Mon, Oct 08, 2018 at 11:53:21AM +0200, Frieder Schrempf wrote: > Hi, > > On 27.09.2018 10:14, Maxime Ripard wrote: > > On Wed, Sep 26, 2018 at 10:19:22PM +0200, Hans de Goede wrote: > > > On 26-09-18 16:44, Frieder Schrempf wrote: > > > > Hi, > > > > > > > > On Fri, Feb 09, 2018 a

Re: [PATCH net-next 2/2] net: phy: mscc: fix memory leak in vsc8574_config_pre_init

2018-10-09 Thread Quentin Schulz
Hi Gustavo, On Tue, Oct 09, 2018 at 09:39:53PM +0200, Gustavo A. R. Silva wrote: > In case memory resources for *fw* were successfully allocated, > release them before return. > > Addresses-Coverity-ID: 1473968 ("Resource leak") > Fixes: 00d70d8e0e78 ("net: phy: mscc: add support for VSC8574 PHY"

Re: [PATCH net-next 1/2] net: phy: mscc: fix signedness bug in vsc85xx_downshift_get

2018-10-09 Thread Quentin Schulz
select/restore_page > functions") Reviewed-by: Quentin Schulz Thanks! Quentin signature.asc Description: PGP signature

Re: [PATCH net-next v2 2/2] net: phy: mscc: fix memory leak in vsc8574_config_pre_init

2018-10-10 Thread Quentin Schulz
c: add support for VSC8574 PHY") Reviewed-by: Quentin Schulz Thanks! Quentin signature.asc Description: PGP signature

Re: [PATCH v5 04/11] dt-bindings: iio: adc: add AXP803 ADC bindings

2018-10-29 Thread Quentin Schulz
Hi Jonathan, On Sun, Oct 28, 2018 at 03:40:11PM +, Jonathan Cameron wrote: > On Wed, 24 Oct 2018 08:56:33 -0500 > Rob Herring wrote: > > > On Tue, 23 Oct 2018 21:53:23 +0300, Oskari Lemmela wrote: > > > The AXP803 ADC is compatible with AXP813 ADC, but add > > > specific compatible for it. >

Re: [PATCH v3 2/7] ARM: dts: axp81x: add AC power supply subnode

2018-10-12 Thread Quentin Schulz
Hi Oskari, On Mon, Oct 08, 2018 at 09:19:03PM +0300, Oskari Lemmela wrote: > Add AC power supply subnode for AXP81X PMIC. > Reviewed-by: Quentin Schulz Thanks, Quentin signature.asc Description: PGP signature

Re: [PATCH v3 1/7] dt-bindings: power: supply: axp20x: add AXP813 AC power DT binding

2018-10-12 Thread Quentin Schulz
Hi Oskari, On Mon, Oct 08, 2018 at 09:19:02PM +0300, Oskari Lemmela wrote: > The AXP803/AXP813 AC power supply can limit input current and voltage. > Reviewed-by: Quentin Schulz Thanks, Quentin signature.asc Description: PGP signature

Re: [PATCH v3 3/7] arm64: dts: allwinner: axp803: add AC and battery power supplies

2018-10-12 Thread Quentin Schulz
Hi Oskari, On Mon, Oct 08, 2018 at 09:19:04PM +0300, Oskari Lemmela wrote: > AXP803 is compatible with AXP813. Add DT nodes ADC, GPIO, > AC and battery power supplies. > Reviewed-by: Quentin Schulz Thanks, Quentin signature.asc Description: PGP signature

Re: [PATCH v3 4/7] arm64: dts: allwinner: a64: sopine: enable power supplies

2018-10-12 Thread Quentin Schulz
Hi Oskari, On Mon, Oct 08, 2018 at 09:19:05PM +0300, Oskari Lemmela wrote: > Sopine baseboard have ACIN and battery connectors. > Reviewed-by: Quentin Schulz Thanks, Quentin signature.asc Description: PGP signature

Re: [PATCH v3 6/7] mfd: axp20x: Add AC power supply cell for AXP813

2018-10-12 Thread Quentin Schulz
Hi Oskari, On Mon, Oct 08, 2018 at 09:19:07PM +0300, Oskari Lemmela wrote: > As axp20x-ac-power-supply now supports AXP813, add a cell for it. > Reviewed-by: Quentin Schulz Thanks, Quentin signature.asc Description: PGP signature

Re: [PATCH 4/4] power: supply: add AXP803/AXP813 AC and battery power supply support

2018-10-05 Thread Quentin Schulz
Hi Oskari, On Thu, Oct 04, 2018 at 10:34:10PM +0300, Oskari Lemmela wrote: > AXP803 PMIC is register compatible with AXP813. > > Added support for AXP803/AXP813 AC power supply. > AXP8x3 is capable to limit input current and minimum input voltage. > Both of these register values are writeable. >

Re: [PATCH v2 0/6] AXP8x3 AC and battery power supply support

2018-10-08 Thread Quentin Schulz
Hi Oskari, On Sun, Oct 07, 2018 at 12:18:30AM +0300, Oskari Lemmela wrote: > AXP813 AC power supply support with input current and > voltage limiting support. > > AXP803 AC and battery power supply support. > Great to see a new developer taking interest in those PMICs :) I received the v2 patc

Re: [PATCH v2 2/6] ARM: dts: axp81x: add AC power supply subnode

2018-10-08 Thread Quentin Schulz
Hi Oskari, On Sun, Oct 07, 2018 at 12:18:32AM +0300, Oskari Lemmela wrote: > Add AC power supply subnode for AXP81X PMIC. > > Signed-off-by: Oskari Lemmela > --- > arch/arm/boot/dts/axp81x.dtsi | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/axp81x.dtsi b/arch/a

Re: [PATCH v2 3/6] arm64: dts: allwinner: axp803: add AC and battery power supplies

2018-10-08 Thread Quentin Schulz
Hi Oskari, On Sun, Oct 07, 2018 at 12:18:33AM +0300, Oskari Lemmela wrote: > AXP803 is compatible with AXP813. Add DT nodes ADC, GPIO, > AC and battery power supplies. > > Signed-off-by: Oskari Lemmela > --- > arch/arm64/boot/dts/allwinner/axp803.dtsi | 31 +++ > 1 file chan

Re: [PATCH v2 5/6] mfd: axp20x: add support AXP803 AC and battery power supplies

2018-10-08 Thread Quentin Schulz
Hi Oskari, On Sun, Oct 07, 2018 at 12:18:35AM +0300, Oskari Lemmela wrote: > AXP803 is compatible with AXP813. > Adding needed cells for AC and battery power supplies. > > AXP813 AC power supply cell added. > > Signed-off-by: Oskari Lemmela > --- > drivers/mfd/axp20x.c | 22 +

Re: [PATCH v2 6/6] power: supply: add AC power supply driver for AXP813

2018-10-08 Thread Quentin Schulz
power_supply_property psp, > + const union power_supply_propval *val) > +{ Argh, missed this one in the first version. Since you're introducing it with the AXP813 and it isn't used with the AXP20X, I'd name it axp813_ac_power_set_property. I'll let Maxime or Chen-Yu confirm though. With the modification in the header from the previous patch in this patch, Reviewed-by: Quentin Schulz Thanks! Quentin signature.asc Description: PGP signature

[PATCH net-next v3 3/6] net: phy: mscc: Add EEE init sequence

2018-10-08 Thread Quentin Schulz
EEE in order to improve performance. Reviewed-by: Florian Fainelli Signed-off-by: Raju Lakkaraju Signed-off-by: Quentin Schulz --- drivers/net/phy/mscc.c | 65 ++ 1 file changed, 65 insertions(+) diff --git a/drivers/net/phy/mscc.c b/drivers/net/phy

[PATCH net-next v3 2/6] net: phy: mscc: add ethtool statistics counters

2018-10-08 Thread Quentin Schulz
iewed-by: Andrew Lunn Signed-off-by: Raju Lakkaraju Signed-off-by: Quentin Schulz --- drivers/net/phy/mscc.c | 119 + 1 file changed, 119 insertions(+) diff --git a/drivers/net/phy/mscc.c b/drivers/net/phy/mscc.c index 52198be46c68..47fbab489287 100644

Re: [PATCH v6 4/6] power: supply: core: Add some helpers to use the battery OCV capacity table

2018-11-01 Thread Quentin Schulz
Hi Baolin, On Thu, Nov 01, 2018 at 03:22:18PM +0800, Baolin Wang wrote: > Hi Quentin, > > On 29 October 2018 at 22:48, Quentin Schulz > wrote: [...] > > > >> + return len; > >> + } else if (len > POWER_SUPPLY_OCV_TEMP_MAX) { > >

[PATCH v5 5/6] power: supply: axp20x_battery: add support for AXP813

2018-02-28 Thread Quentin Schulz
the PMIC is valid. Signed-off-by: Quentin Schulz Reviewed-by: Chen-Yu Tsai --- drivers/power/supply/axp20x_battery.c | 42 - 1 file changed, 42 insertions(+) diff --git a/drivers/power/supply/axp20x_battery.c b/drivers/power/supply/axp20x_battery.c index 04a0d91

[PATCH v5 2/6] mfd: axp20x: probe axp20x_adc driver for AXP813

2018-02-28 Thread Quentin Schulz
This makes the axp20x_adc driver probe with platform device id "axp813-adc". Signed-off-by: Quentin Schulz Acked-for-MFD-by: Lee Jones Acked-by: Chen-Yu Tsai --- drivers/mfd/axp20x.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/axp20x.c b/d

[PATCH v5 4/6] dt-bindings: power: supply: axp20x: add AXP813 battery DT binding

2018-02-28 Thread Quentin Schulz
The AXP813 can have a battery as power supply, so let's add it to the list of compatibles. Signed-off-by: Quentin Schulz Reviewed-by: Rob Herring Acked-by: Chen-Yu Tsai --- Documentation/devicetree/bindings/power/supply/axp20x_battery.txt | 8 +++ 1 file changed, 4 insertions(

[PATCH v5 6/6] mfd: axp20x: add battery power supply cell for AXP813

2018-02-28 Thread Quentin Schulz
As axp20x-battery-power-supply now supports AXP813, add a cell for it. Signed-off-by: Quentin Schulz Acked-for-MFD-by: Lee Jones Reviewed-by: Chen-Yu Tsai --- drivers/mfd/axp20x.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c index e5516aa

[PATCH v5 0/6] add support for AXP813 ADC and battery power supply

2018-02-28 Thread Quentin Schulz
data structure instead of ID for variant specific code in battery driver, - add DT binding for ADC driver, - make mfd probe the ADC driver via DT as well so that its IIO channels can be consumed by other drivers via DT mapping, Thanks, Quentin Quentin Schulz (6): mfd: axp20x: make AXP20

[PATCH v5 1/6] mfd: axp20x: make AXP209/22x cells probe their ADC via DT

2018-02-28 Thread Quentin Schulz
This makes AXP209 and AXP22x ADCs probe first via DT and then by fallback via platform. Signed-off-by: Quentin Schulz Acked-for-MFD-by: Lee Jones Acked-by: Chen-Yu Tsai --- drivers/mfd/axp20x.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/axp20x.c b

[PATCH v5 3/6] power: supply: axp20x_battery: use data struct for variant specific code

2018-02-28 Thread Quentin Schulz
use it. Signed-off-by: Quentin Schulz Reviewed-by: Chen-Yu Tsai --- drivers/power/supply/axp20x_battery.c | 100 +-- 1 file changed, 66 insertions(+), 34 deletions(-) diff --git a/drivers/power/supply/axp20x_battery.c b/drivers/power/supply/axp20x_battery.c index 7

[PATCH 2/3] ARM: dts: sun8i: a711: set regulator for each cluster of CPUs

2018-02-28 Thread Quentin Schulz
The Allwinner A83T is a SoC with two clusters of 4 A7 which have a different clock and regulator. Set the CPU regulator. Signed-off-by: Quentin Schulz --- arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs

[PATCH 1/3] ARM: dts: sun8i: a83t: add cpu0 and cpu100 labels

2018-02-28 Thread Quentin Schulz
The Allwinner A83T is a SoC with two clusters of 4 A7, each cluster having its own regulator and clock. The regulators are board-specific, thus we need labels for cpu0 and cpu100 so that we can use references to these nodes from the board header file. Signed-off-by: Quentin Schulz --- arch/arm

[PATCH 0/3] add CPUs OPPs to sun8i a83t

2018-02-28 Thread Quentin Schulz
shuts down). It seems[1] impossible to reach those frequencies with none or passive cooling, so better leave them out by default. It's still possible to add those OPPs on a per-board basis though. [1] http://linux-sunxi.org/User:Tkaiser#First_steps_with_Banana_Pi_M3 Thanks, Quentin Quentin

[PATCH 3/3] ARM: dts: sun8i: a83t: add stable OPP tables and CPUfreq

2018-02-28 Thread Quentin Schulz
on a per-board basis though. Signed-off-by: Quentin Schulz --- arch/arm/boot/dts/sun8i-a83t.dtsi | 118 +++- 1 file changed, 118 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi index 016d22f..05d5dd7 100644 --- a/arc

[PATCH net-next v3 04/11] net: mscc: ocelot: move the HSIO header to include/soc

2018-09-14 Thread Quentin Schulz
Since HSIO address space can be used by different drivers (PLL, SerDes muxing, temperature sensor), let's move it somewhere it can be included by all drivers. Acked-by: Alexandre Belloni Signed-off-by: Quentin Schulz --- drivers/net/ethernet/mscc/ocelot.h | 1 +- drivers/net/eth

[PATCH net-next 5/5] net: phy: mscc: remove unneeded temporary variable

2018-09-14 Thread Quentin Schulz
Here, the rc variable is either used only for the condition right after the assignment or right before being used as the return value of the function it's being used in. So let's remove this unneeded temporary variable whenever possible. Signed-off-by: Quentin Schulz --- drivers/net/

[PATCH net-next 4/5] net: phy: mscc: shorten `x != 0` condition to `x`

2018-09-14 Thread Quentin Schulz
`if (x != 0)` is basically a more verbose version of `if (x)` so let's use the latter so it's consistent throughout the whole driver. Signed-off-by: Quentin Schulz --- drivers/net/phy/mscc.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) di

Re: [PATCH net-next v2 1/7] net: phy: mscc: factorize code for LEDs mode

2018-09-04 Thread Quentin Schulz
Hi David, On Tue, Sep 04, 2018 at 10:48:27AM -0700, David Miller wrote: > From: Quentin Schulz > Date: Mon, 3 Sep 2018 10:48:47 +0200 > > > LEDs modes are set the same way, except they are offset by 4 times the > > index of the LED. > > > > Let's factori

Re: [PATCH 5/7] MIPS: mscc: ocelot: add GPIO4 pinmuxing DT node

2018-10-01 Thread Quentin Schulz
Hi Andrew, On Fri, Sep 14, 2018 at 07:02:21PM +0200, Andrew Lunn wrote: > On Fri, Sep 14, 2018 at 06:26:38PM +0200, Quentin Schulz wrote: > > Hi Alexandre, > > > > On Fri, Sep 14, 2018 at 04:54:46PM +0200, Alexandre Belloni wrote: > > > Hi, > > > >

Re: [PATCH net-next 2/7] net: phy: mscc: add support for VSC8584 PHY

2018-10-01 Thread Quentin Schulz
Hi Andrew, On Fri, Sep 14, 2018 at 07:27:54PM +0200, Andrew Lunn wrote: > > > struct vsc8531_private { > > int rate_magic; > > u16 supp_led_modes; > > @@ -181,6 +354,7 @@ struct vsc8531_private { > > struct vsc85xx_hw_stat *hw_stats; > > u64 *stats; > > int nstats; > > + bo

[PATCH v2 00/11] mscc: ocelot: add support for SerDes muxing configuration

2018-09-03 Thread Quentin Schulz
driver, - use a dev_dbg for the deferring of the probe in the SerDes driver, - use constants in the Device Tree to select the SerDes macro in use with a port, - adapt the SerDes driver to use those constants, - add a header file in include/dt-bindings for the constants, - fix space/tab i

[PATCH net-next v2 05/11] net: mscc: ocelot: simplify register access for PLL5 configuration

2018-09-03 Thread Quentin Schulz
ff-by: Quentin Schulz --- drivers/net/ethernet/mscc/ocelot.h | 73 drivers/net/ethernet/mscc/ocelot_regs.c | 92 +++-- include/soc/mscc/ocelot_hsio.h | 74 3 files changed, 83 insertions(+), 156 deletions(-) diff --git a/driver

[PATCH v2 10/11] phy: add driver for Microsemi Ocelot SerDes muxing

2018-09-03 Thread Quentin Schulz
The Microsemi Ocelot can mux SerDes lanes (aka macros) to different switch ports or even make it act as a PCIe interface. This adds support for the muxing of the SerDes. Signed-off-by: Quentin Schulz --- drivers/phy/Kconfig | 1 + drivers/phy/Makefile | 1

Re: [PATCH 2/2] ubi: introduce ubi.nocheck parameter to skip CRC check when attaching ubi vol

2018-06-11 Thread Quentin Schulz
Hi Richard, On Fri, Apr 20, 2018 at 11:37:07AM +0200, Richard Weinberger wrote: > Quentin, > > Am Freitag, 20. April 2018, 10:52:41 CEST schrieb Quentin Schulz: > > There's already ECC on NAND pages so there may be no need for one to > > check the CRC of a UBI volume.

Re: [PATCH 2/2] ubi: introduce ubi.nocheck parameter to skip CRC check when attaching ubi vol

2018-04-23 Thread Quentin Schulz
Hi Boris, On Fri, Apr 20, 2018 at 07:19:24PM +0200, Boris Brezillon wrote: > On Fri, 20 Apr 2018 10:52:41 +0200 > Quentin Schulz wrote: > > > There's already ECC on NAND pages so there may be no need for one to > > check the CRC of a UBI volume. > > That&#x

[PATCH 1/2] ubi: move constants for ubi vol parsing from kernel param to ubi.h

2018-04-20 Thread Quentin Schulz
onstants to ubi.h so that they can be used to parse other parameters impacting UBI volumes. Signed-off-by: Quentin Schulz --- drivers/mtd/ubi/block.c | 33 + drivers/mtd/ubi/ubi.h | 15 +++ 2 files changed, 24 insertions(+), 24 deletions(-) diff --g

[PATCH 2/2] ubi: introduce ubi.nocheck parameter to skip CRC check when attaching ubi vol

2018-04-20 Thread Quentin Schulz
. I gained 3.2s on boot time of a SPEAr600-based board for a ~20MB UBI volume used as rootfs. Signed-off-by: Quentin Schulz --- drivers/mtd/ubi/kapi.c | 70 +++- drivers/mtd/ubi/ubi.h | 6 - drivers/mtd/ubi/vtbl.c | 24 ++- 3 files c

Re: [PATCH 2/2] ubi: introduce ubi.nocheck parameter to skip CRC check when attaching ubi vol

2018-04-20 Thread Quentin Schulz
Hi Richard, On Fri, Apr 20, 2018 at 11:37:07AM +0200, Richard Weinberger wrote: > Quentin, > > Am Freitag, 20. April 2018, 10:52:41 CEST schrieb Quentin Schulz: > > There's already ECC on NAND pages so there may be no need for one to > > check the CRC of a UBI volume.

[PATCH 0/2] add support for AXP209 GPIOs functions

2016-11-23 Thread Quentin Schulz
/AXP209_Datasheet_v1.0en.pdf Quentin Schulz (2): gpio: axp209: use correct register for GPIO input status gpio: axp209: add pinctrl support .../devicetree/bindings/gpio/gpio-axp209.txt | 28 +- drivers/gpio/gpio-axp209.c | 557 ++--- 2 files changed

[PATCH 1/2] gpio: axp209: use correct register for GPIO input status

2016-11-23 Thread Quentin Schulz
The GPIO input status was read from control register (AXP20X_GPIO[210]_CTRL) instead of status register (AXP20X_GPIO20_SS). Signed-off-by: Quentin Schulz --- drivers/gpio/gpio-axp209.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpio/gpio-axp209.c b

[PATCH 2/2] gpio: axp209: add pinctrl support

2016-11-23 Thread Quentin Schulz
. [1] see registers 90H, 92H and 93H at http://dl.linux-sunxi.org/AXP/AXP209_Datasheet_v1.0en.pdf Signed-off-by: Quentin Schulz --- .../devicetree/bindings/gpio/gpio-axp209.txt | 28 +- drivers/gpio/gpio-axp209.c | 551 ++--- 2 files changed, 503

[PATCH RESEND 2/2] gpio: axp209: add pinctrl support

2016-11-23 Thread Quentin Schulz
. [1] see registers 90H, 92H and 93H at http://dl.linux-sunxi.org/AXP/AXP209_Datasheet_v1.0en.pdf Signed-off-by: Quentin Schulz --- .../devicetree/bindings/gpio/gpio-axp209.txt | 28 +- drivers/gpio/gpio-axp209.c | 551 ++--- 2 files changed, 503

[PATCH RESEND 1/2] gpio: axp209: use correct register for GPIO input status

2016-11-23 Thread Quentin Schulz
The GPIO input status was read from control register (AXP20X_GPIO[210]_CTRL) instead of status register (AXP20X_GPIO20_SS). Signed-off-by: Quentin Schulz --- drivers/gpio/gpio-axp209.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpio/gpio-axp209.c b

[PATCH RESEND 0/2] add support for AXP209 GPIOs functions

2016-11-23 Thread Quentin Schulz
/AXP209_Datasheet_v1.0en.pdf Quentin Schulz (2): gpio: axp209: use correct register for GPIO input status gpio: axp209: add pinctrl support .../devicetree/bindings/gpio/gpio-axp209.txt | 28 +- drivers/gpio/gpio-axp209.c | 557 ++--- 2 files changed

Re: [PATCH 05/22] ARM: dtsi: axp209: add AXP209 ADC subnode

2017-01-05 Thread Quentin Schulz
On 05/01/2017 06:51, Chen-Yu Tsai wrote: > On Tue, Jan 3, 2017 at 12:37 AM, Quentin Schulz > wrote: >> X-Powers AXP209 PMIC has multiple ADCs, each one exposing data from the >> different power supplies connected to the PMIC. >> >> This adds the ADC subnode for AX

Re: [PATCH 15/22] mfd: axp20x: add CHRG_CTRL1 to writeable regs for AXP20X/AXP22X

2017-01-05 Thread Quentin Schulz
On 05/01/2017 07:10, Chen-Yu Tsai wrote: > On Tue, Jan 3, 2017 at 12:37 AM, Quentin Schulz > wrote: >> The CHR_CTRL1 register is made of 7 read-write bits with one being used >> to set the target voltage for battery charging. > > The description is incorrect. >

Re: [PATCH 03/22] iio: adc: add support for X-Powers AXP20X and AXP22X PMICs ADCs

2017-01-05 Thread Quentin Schulz
Hi Chen-Yu, On 05/01/2017 06:42, Chen-Yu Tsai wrote: > On Tue, Jan 3, 2017 at 12:37 AM, Quentin Schulz > wrote: [...] >> + >> +#define AXP20X_ADC_RATE_MASK (3 << 6) >> +#define AXP20X_ADC_RATE_25HZ (0 <<

Re: [PATCH 03/22] iio: adc: add support for X-Powers AXP20X and AXP22X PMICs ADCs

2017-01-05 Thread Quentin Schulz
On 05/01/2017 09:27, Chen-Yu Tsai wrote: > On Thu, Jan 5, 2017 at 4:06 PM, Quentin Schulz > wrote: >> Hi Chen-Yu, >> >> On 05/01/2017 06:42, Chen-Yu Tsai wrote: >>> On Tue, Jan 3, 2017 at 12:37 AM, Quentin Schulz >>> wrote: >> [...] >>>&g

Re: [PATCH 17/22] power: supply: add battery driver for AXP20X and AXP22X PMICs

2017-01-06 Thread Quentin Schulz
Hi, On 06/01/2017 04:39, Chen-Yu Tsai wrote: > Hi, > > On Tue, Jan 3, 2017 at 12:37 AM, Quentin Schulz > wrote: [...] >> + case POWER_SUPPLY_PROP_CURRENT_MAX: >> + ret = regmap_read(axp20x_batt->regmap, AXP20X_CHRG_CTRL1, >&g

Re: [PATCH v9 3/3] iio: adc: add support for Allwinner SoCs ADC

2017-01-14 Thread Quentin Schulz
Hi Jonathan, On 08/01/2017 12:17, Jonathan Cameron wrote: > On 30/12/16 14:40, Jonathan Cameron wrote: >> On 13/12/16 14:33, Quentin Schulz wrote: >>> The Allwinner SoCs all have an ADC that can also act as a touchscreen >>> controller and a thermal sensor. This patch a

Re: [PATCH v2 16/25] dt-bindings: power: supply: add AXP20X/AXP22X battery DT binding

2017-01-31 Thread Quentin Schulz
Hi, On 29/01/2017 17:47, Sebastian Reichel wrote: > Hi, > > On Fri, Jan 27, 2017 at 09:54:49AM +0100, Quentin Schulz wrote: >> - added x-powers,constant-charge-current property to set the >> maximal default constant current charge of the battery, > > Since th

Re: [PATCH 08/22] power: supply: add AC power supply driver for AXP20X and AXP22X PMICs

2017-01-26 Thread Quentin Schulz
Hi Sebastian, On 17/01/2017 04:00, Sebastian Reichel wrote: > Hi Quentin, > > The driver looks mostly fine. I do have a two comments, though. > > On Mon, Jan 02, 2017 at 05:37:08PM +0100, Quentin Schulz wrote: >> [...] >> >> +static int axp20x_ac_power_p

Re: [PATCH 08/22] power: supply: add AC power supply driver for AXP20X and AXP22X PMICs

2017-01-08 Thread Quentin Schulz
Hi Jonathan, On 07/01/2017 20:31, Jonathan Cameron wrote: > On 02/01/17 11:37, Quentin Schulz wrote: [...] >> +/* >> + * IIO framework gives mV but Power Supply framework gives µV. >> + */ > single line comment syntax throughout or we

Re: [PATCH 14/22] dt-bindings: power: supply: add AXP20X/AXP22X battery DT binding

2017-01-08 Thread Quentin Schulz
Hi Jonathan, On 07/01/2017 20:33, Jonathan Cameron wrote: > On 04/01/17 08:21, Rob Herring wrote: >> On Mon, Jan 02, 2017 at 05:37:14PM +0100, Quentin Schulz wrote: >>> The X-Powers AXP20X and AXP22X PMICs can have a battery as power supply. >>> >>> This pat

[PATCH v2 17/25] mfd: axp20x: add CHRG_CTRL1/2/3 to writeable regs for AXP20X/AXP22X

2017-01-27 Thread Quentin Schulz
registers to the list of writeable registers for AXP20X and AXP22X PMICs. Signed-off-by: Quentin Schulz Acked-for-MFD-by: Lee Jones --- v2: - added AXP20X_CHRG_CTRL2 and AXP20X_CHRG_CTRL3 to the writeable registers table, - removed added reg range for ADC data in volatile regs range, drivers/mfd

[PATCH v2 02/25] mfd: axp20x: correct name of temperature data ADC registers

2017-01-27 Thread Quentin Schulz
The registers 0x56 and 0x57 of AXP22X PMIC store the value of the internal temperature of the PMIC. This patch modifies the name of these registers from AXP22X_PMIC_ADC_H/L to AXP22X_PMIC_TEMP_H/L so their purpose is clearer. Signed-off-by: Quentin Schulz --- added in v2 drivers/mfd/axp20x.c

[PATCH v2 14/25] ARM: dts: sun8i: sina33: enable ACIN power supply subnode

2017-01-27 Thread Quentin Schulz
The Sinlinx SinA33 has an AXP223 PMIC and an ACIN connector, thus, we enable the ACIN power supply in its Device Tree. Signed-off-by: Quentin Schulz --- arch/arm/boot/dts/sun8i-a33-sinlinx-sina33.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-a33-sinlinx

[PATCH v2 07/25] ARM: dtsi: axp22x: add AXP22X ADC subnode

2017-01-27 Thread Quentin Schulz
X-Powers AXP22X PMIC has multiple ADCs, each one exposing data from the different power supplies connected to the PMIC. This adds the ADC subnode for AXP22X PMIC. Signed-off-by: Quentin Schulz --- v2: - removed #io-channels property (the IIO channels mapping is done by using iio_map

[PATCH v2 06/25] ARM: dtsi: axp209: add AXP209 ADC subnode

2017-01-27 Thread Quentin Schulz
X-Powers AXP209 PMIC has multiple ADCs, each one exposing data from the different power supplies connected to the PMIC. This adds the ADC subnode for AXP20X PMIC. Signed-off-by: Quentin Schulz --- v2: - removed #io-channels property (the IIO channels mapping is done by using iio_map

[PATCH v2 13/25] ARM: dtsi: axp22x: add AC power supply subnode

2017-01-27 Thread Quentin Schulz
The X-Powers AXP22X PMIC exposes the status of AC power supply. This adds the AC power supply subnode for the AXP22X PMIC. Signed-off-by: Quentin Schulz --- v2: - changed DT node name from ac_power_supply to ac-power-supply, - removed io-channels and io-channel-names from DT (the IIO mapping

[PATCH v2 08/25] dt-bindings: power: supply: add AXP20X/AXP22X AC power supply

2017-01-27 Thread Quentin Schulz
The X-Powers AXP20X and AXP22X PMICs have an AC entry to supply power to the board. They have a few registers dedicated to the status of the AC power supply. This adds the DT binding documentation for the AC power supply for AXP20X and AXP22X PMICs. Signed-off-by: Quentin Schulz --- v2

[PATCH v2 11/25] mfd: axp20x: add AC power supply cells for AXP22X PMICs

2017-01-27 Thread Quentin Schulz
The X-Powers AXP20X and AXP22X PMICs expose the status of AC power supply. This adds the AC power supply driver to the MFD cells of the AXP22X PMICs. Signed-off-by: Quentin Schulz Acked-for-MFD-by: Lee Jones --- drivers/mfd/axp20x.c | 10 ++ 1 file changed, 10 insertions(+) diff

[PATCH v2 12/25] ARM: dtsi: axp209: add AC power supply subnode

2017-01-27 Thread Quentin Schulz
The X-Powers AXP20X PMIC exposes the status of AC power supply, the current current and voltage supplied to the board by the AC power supply. This adds the AC power supply subnode for AXP20X PMIC. Signed-off-by: Quentin Schulz --- v2: - changed DT node name from ac_power_supply to ac-power

[PATCH v2 05/25] mfd: axp20x: add ADC cells for AXP20X and AXP22X PMICs

2017-01-27 Thread Quentin Schulz
This adds the AXP20X/AXP22x ADCs driver to the mfd cells of the AXP209, AXP221 and AXP223 MFD. Signed-off-by: Quentin Schulz Acked-for-MFD-by: Lee Jones Acked-by: Chen-Yu Tsai --- drivers/mfd/axp20x.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/mfd/axp20x.c b/drivers

[PATCH v2 09/25] iio: adc: axp20x_adc: map acin_i and acin_v

2017-01-27 Thread Quentin Schulz
This maps the IIO channels acin_i and acin_v (respectively exposing the current current and voltage measures of the AC power supply) to the AC power supply driver. Only the AXP20X PMICs have these ADC channels and thus they are only mapped for this version of the PMIC. Signed-off-by: Quentin

[PATCH v2 10/25] power: supply: add AC power supply driver for AXP20X and AXP22X PMICs

2017-01-27 Thread Quentin Schulz
: Quentin Schulz Acked-by: Jonathan Cameron --- v2: - replaced µ character by a common u for micro units to make checkpatch happy, - use of structure for specific data instead of an ID and if condiftions, - use dev_get_regmap instead of manually looking for it in the parent drvdata, drivers

[PATCH v2 01/25] dt-bindings: iio: adc: add AXP20X/AXP22X ADC DT binding

2017-01-27 Thread Quentin Schulz
AXP22X PMICs ADCs. Signed-off-by: Quentin Schulz Acked-by: Rob Herring Acked-by: Chen-Yu Tsai Acked-by: Maxime Ripard --- v2: - removing io-channels from required properties, - update AXP ADC DT node name from axp209_adc to simply adc, .../devicetree/bindings/iio/adc/axp20x_adc.txt | 22

[PATCH v2 00/25] add support for AXP20X and AXP22X power supply drivers

2017-01-27 Thread Quentin Schulz
. voltage and current of the battery have the same index in different IIO types), - Added structures for specific data instead of matching on IDs, - Switched from DT IIO channels mapping to iio_map structures IIO channels mapping, Quentin Quentin Schulz (25): dt-bindings: iio: adc: add AXP

[PATCH v2 03/25] power: supply: axp20x_usb_power: use IIO channels when available

2017-01-27 Thread Quentin Schulz
compiled, this driver will fall back on previous behaviour which is direct register readings. Signed-off-by: Quentin Schulz --- added in v2 drivers/power/supply/axp20x_usb_power.c | 70 +++-- 1 file changed, 66 insertions(+), 4 deletions(-) diff --git a/drivers/power

[PATCH v2 04/25] iio: adc: add support for X-Powers AXP20X and AXP22X PMICs ADCs

2017-01-27 Thread Quentin Schulz
c @@ -0,0 +1,572 @@ +/* ADC driver for AXP20X and AXP22X PMICs + * + * Copyright (c) 2016 Free Electrons NextThing Co. + * Quentin Schulz + * + * This program is free software; you can redistribute it and/or modify it under + * the terms of the GNU General Public License version 2 as publish

[PATCH v2 16/25] dt-bindings: power: supply: add AXP20X/AXP22X battery DT binding

2017-01-27 Thread Quentin Schulz
capacity (in percentage), voltage max and min limits, current voltage and battery capacity (in Ah). Signed-off-by: Quentin Schulz --- v2: - changed DT node name from ac_power_supply to ac-power-supply, - removed io-channels and io-channel-names from DT (the IIO mapping is done in the IIO ADC

[PATCH v2 21/25] mfd: axp20x: add MFD cells for AXP20X and AXP22X battery driver

2017-01-27 Thread Quentin Schulz
The X-Powers AXP20X and AXP22X PMICs can have a battery as power supply. This patch adds the AXP20X/AXP22X battery driver to the MFD cells of the AXP209, AXP221 and AXP223 MFD. Signed-off-by: Quentin Schulz Acked-for-MFD-by: Lee Jones --- drivers/mfd/axp20x.c | 9 + 1 file changed, 9

[PATCH v2 23/25] ARM: dtsi: axp22x: add battery power supply subnode

2017-01-27 Thread Quentin Schulz
subnode for AXP22X PMIC. Signed-off-by: Quentin Schulz --- v2: - changed DT node name from battery_power_supply to battery-power-supply, - removed io-channels and io-channel-names from DT (the IIO mapping is done in the IIO ADC driver now), arch/arm/boot/dts/axp22x.dtsi | 5 + 1 file

[PATCH v2 19/25] iio: adc: axp20x_adc: map battery IIO channels

2017-01-27 Thread Quentin Schulz
This maps the IIO channels batt_v, batt_chrg_i and batt_dischrg_i (respectively exposing the current charging and discharging currents and current voltage measures of the battery power supply) to the battery power supply driver. Signed-off-by: Quentin Schulz --- added in v2 drivers/iio/adc

[PATCH v2 25/25] ARM: sun5i: chip: enable battery power supply subnode

2017-01-27 Thread Quentin Schulz
The NextThing Co. CHIP has an AXP209 PMIC with battery connector. This enables the battery power supply subnode. Signed-off-by: Quentin Schulz --- arch/arm/boot/dts/sun5i-r8-chip.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/sun5i-r8-chip.dts b/arch/arm/boot

[PATCH v2 18/25] mfd: axp20x: add V_OFF to writeable regs for AXP20X and AXP22X

2017-01-27 Thread Quentin Schulz
The V_OFF register has its first 3 read-write bits for the minimal voltage (Voff) of the battery before the system is automatically shut down due to the power being too low. This adds V_OFF register to the writeable registers of AXP20X and AXP22X PMICs. Signed-off-by: Quentin Schulz Acked-for

[PATCH v2 22/25] ARM: dtsi: axp209: add battery power supply subnode

2017-01-27 Thread Quentin Schulz
supply subnode for AXP20X PMIC. Signed-off-by: Quentin Schulz --- v2: - changed DT node name from battery_power_supply to battery-power-supply, - removed io-channels and io-channel-names from DT (the IIO mapping is done in the IIO ADC driver now), arch/arm/boot/dts/axp209.dtsi | 5 + 1

[PATCH v2 24/25] ARM: dts: sun8i: sina33: enable battery power supply subnode

2017-01-27 Thread Quentin Schulz
The Sinlinx SinA33 has an AXP223 PMIC and a battery connector, thus, we enable the battery power supply subnode in its Device Tree. Signed-off-by: Quentin Schulz --- arch/arm/boot/dts/sun8i-a33-sinlinx-sina33.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/sun8i

[PATCH v2 15/25] ARM: sun5i: chip: enable ACIN power supply subnode

2017-01-27 Thread Quentin Schulz
The NextThing Co. CHIP has an AXP209 PMIC and can be power-supplied by ACIN via the CHG-IN pin. This enables the ACIN power supply subnode in the DT. Signed-off-by: Quentin Schulz --- arch/arm/boot/dts/sun5i-r8-chip.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts

[PATCH v2 20/25] power: supply: add battery driver for AXP20X and AXP22X PMICs

2017-01-27 Thread Quentin Schulz
max and min limits, current voltage and battery capacity (in Ah). This battery driver uses the AXP20X/AXP22X ADC driver as PMIC data provider. Signed-off-by: Quentin Schulz --- v2: - changed BIT(x) to 1 << x when describing bits purpose for which 2 << x or 3 << x exists

<    1   2   3   4   5   6   7   >