ch
* bool bPacketToSelf -> to_self
* bool bPacketBeacon -> is_beacon
* bool bToSelf -> (removed because it isn't used)
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/rtl8723bs/hal/odm.h | 16 +--
drivers/staging/rtl8723
ch
* bool bPacketToSelf -> to_self
* bool bPacketBeacon -> is_beacon
* bool bToSelf -> (removed because it isn't used)
Signed-off-by: Quytelda Kahja
---
drivers/staging/rtl8723bs/hal/odm.h | 16 +--
drivers/staging/rtl8723bs/hal/odm_CfoTracking.c | 4 +-
Factor out code from rtl8723bs_recv_tasklet() into helper methods
to unindent lines over 80 characters.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 95 +++---
1 file changed, 69 insertions(+), 26 deletions(-)
Replace the comparison of 'precvbuf' to 'NULL' with '!precvbuf'.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
b/d
Replace the comparison of 'precvbuf' to 'NULL' with '!precvbuf'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
b/drivers/staging/rtl8723bs/hal
Factor out code from rtl8723bs_recv_tasklet() into helper methods
to unindent lines over 80 characters.
Signed-off-by: Quytelda Kahja
---
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 95 +++---
1 file changed, 69 insertions(+), 26 deletions(-)
diff --git a/drivers
Wrap the function parameters for rtl8723bs_c2h_packet_handler() so
the function signature doesn't exceed 80 characters.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
Wrap the function parameters for rtl8723bs_c2h_packet_handler() so
the function signature doesn't exceed 80 characters.
Signed-off-by: Quytelda Kahja
---
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging
Fix lines over the 80 character limit in update_recvframe_attrib().
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 30 +++---
1 file changed, 22 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl
Fix lines over the 80 character limit in update_recvframe_attrib().
Signed-off-by: Quytelda Kahja
---
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 30 +++---
1 file changed, 22 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
b
Condense multiple blank lines to one, and remove blank lines before
braces.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
b/d
Condense multiple blank lines to one, and remove blank lines before
braces.
Signed-off-by: Quytelda Kahja
---
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
b/drivers/staging/rtl8723bs/hal
Realign the function parameters and comment blocks to match the kernel
coding style.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/
Realign the function parameters and comment blocks to match the kernel
coding style.
Signed-off-by: Quytelda Kahja
---
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
b
The modified file includes 'linux/ieee80211.h', but redefines many
constants that already exist in the header. This will create a conflict
if the values are ever changed in the kernel.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/rtl8723bs/include/ieee80211.
The modified file includes 'linux/ieee80211.h', but redefines many
constants that already exist in the header. This will create a conflict
if the values are ever changed in the kernel.
Signed-off-by: Quytelda Kahja
---
drivers/staging/rtl8723bs/include/ieee80211.h | 12
1 file
the duplicate #defines from
drivers/staging/rtl8723bs/include/ieee80211.h. It looks like there's
also some #defines there that shadow enum members in
'linux/ieee80211.h', but I will address that in separate patch(es)
when I have a chance.
Thank you,
Quytelda Kahja
On Sun, Mar 25, 2018 at 7:05 AM
the duplicate #defines from
drivers/staging/rtl8723bs/include/ieee80211.h. It looks like there's
also some #defines there that shadow enum members in
'linux/ieee80211.h', but I will address that in separate patch(es)
when I have a chance.
Thank you,
Quytelda Kahja
On Sun, Mar 25, 2018 at 7:05 AM
maintainer desires,
they can always squash them together or ask me to resubmit as one
patch.
On 3/24/18, Larry Finger <larry.fin...@lwfinger.net> wrote:
> On 03/23/2018 11:10 PM, Quytelda Kahja wrote:
>> It is neater and more consistent with the rest of the document to use the
&
maintainer desires,
they can always squash them together or ask me to resubmit as one
patch.
On 3/24/18, Larry Finger wrote:
> On 03/23/2018 11:10 PM, Quytelda Kahja wrote:
>> It is neater and more consistent with the rest of the document to use the
>> BIT() macro from '
Fix two spelling mistakes in comments.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.h | 2 +-
drivers/staging/ks7010/ks_wlan.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h
b/d
The "_t" suffix is not needed for structure names in this driver,
and is a reflection of an older typedef system that is no longer
in place. Remove the "_t" suffix from every structure defined in this
driver.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
-
Fix two spelling mistakes in comments.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 2 +-
drivers/staging/ks7010/ks_wlan.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h
b/drivers/staging/ks7010/ks_hostif.h
The "_t" suffix is not needed for structure names in this driver,
and is a reflection of an older typedef system that is no longer
in place. Remove the "_t" suffix from every structure defined in this
driver.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010
It is neater and more consistent with the rest of the document to use the
BIT() macro from 'linux/bitops.h' to define the
IEEE80211_SPCT_MSR_RPRT_MODE_* bitmasks.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
include/linux/ieee80211.h | 6 +++---
1 file changed, 3 insertions
It is neater and more consistent with the rest of the document to use the
BIT() macro from 'linux/bitops.h' to define the
IEEE80211_SPCT_MSR_RPRT_MODE_* bitmasks.
Signed-off-by: Quytelda Kahja
---
include/linux/ieee80211.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
It is neater and more consistent with the rest of the document to use the
BIT() macro from 'linux/bitops.h' to define the WLAN_ERP_* bitmasks.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
include/linux/ieee80211.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
It is neater and more consistent with the rest of the document to use the
BIT() macro from 'linux/bitops.h' to define the WLAN_ERP_* bitmasks.
Signed-off-by: Quytelda Kahja
---
include/linux/ieee80211.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux
; replace these values with plain integers.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
include/linux/ieee80211.h | 56 +++
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h
; replace these values with plain integers.
Signed-off-by: Quytelda Kahja
---
include/linux/ieee80211.h | 56 +++
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h
index ee6657a0ed69
There are several instances where comments are spaced so far to the
right they cause the line to go over the 80 character limit. Move
these comments to above the statements they describe instead.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.
There are several instances where comments are spaced so far to the
right they cause the line to go over the 80 character limit. Move
these comments to above the statements they describe instead.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 19 ---
1
The AUTH_TYPE_OPEN_SYSTEM and AUTH_TYPE_SHARED_KEY #define lines
are duplicated in ks_hostif.h. Replace them both with one set of
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.h | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff
Instead of using memcmp() to directly compare BSSIDs, use
ether_addr_equal() from 'linux/etherdevice.h'.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/
The AUTH_TYPE_OPEN_SYSTEM and AUTH_TYPE_SHARED_KEY #define lines
are duplicated in ks_hostif.h. Replace them both with one set of
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging
Instead of using memcmp() to directly compare BSSIDs, use
ether_addr_equal() from 'linux/etherdevice.h'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers
There is no reason for comment describing the BSSID check for loop
to be spaced so far to the right. Move it above the for loop.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
There is no reason for comment describing the BSSID check for loop
to be spaced so far to the right. Move it above the for loop.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010
of the request
initialization code in ks_hostif.c to be factored out into the
'init_request' function.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 53 +++--
drivers/staging/ks7010/ks_hostif.
of the request
initialization code in ks_hostif.c to be factored out into the
'init_request' function.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 53 +++--
drivers/staging/ks7010/ks_hostif.h | 54 --
2
The handling of hostif_infrastructure_set_request_t and
hostif_infrastructure_set2_request_t is identical, with the exception
of the event type value. Merge the two structs so they can be handled
by a single function ('hostif_infrastructure_set_request').
Signed-off-by: Quytelda Kahja <qu
The handling of hostif_infrastructure_set_request_t and
hostif_infrastructure_set2_request_t is identical, with the exception
of the event type value. Merge the two structs so they can be handled
by a single function ('hostif_infrastructure_set_request').
Signed-off-by: Quytelda Kahja
Some of the code for reading IEs is replicated multiple times in the
switch statement for get_ap_information(). Factor that code out into
read_ie().
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 31 +++
1 file c
Some of the code for reading IEs is replicated multiple times in the
switch statement for get_ap_information(). Factor that code out into
read_ie().
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 31 +++
1 file changed, 15 insertions(+), 16
Braces aren't required for a single line if statement.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
The code to initialize various different types of request structs
is repeated multiple times. Factor this code out into a macro
called INIT_REQUEST.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 55 +++---
Braces aren't required for a single line if statement.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index 00b97e8e9b4f
The code to initialize various different types of request structs
is repeated multiple times. Factor this code out into a macro
called INIT_REQUEST.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 55 +++---
1 file changed, 16 insertions
Remove unnecessary parentheses highlighted by checkpatch.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_ho
Some of the code for reading IEs is replicated multiple times in the
switch statement for get_ap_information(). Factor that code out into
read_ie().
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 48 +-
Remove unnecessary parentheses highlighted by checkpatch.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index 948d45280d18
Some of the code for reading IEs is replicated multiple times in the
switch statement for get_ap_information(). Factor that code out into
read_ie().
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 48 +-
1 file changed, 22 insertions
Some cases in the switch statement in get_ap_information() are indented
as much as five levels, which makes the code difficult to read because
of all the wrapping. Factor them out into helper methods.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_ho
There is no reason for comment describing the BSSID check for loop
to be spaced so far to the right. Move it above the for loop.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
Some cases in the switch statement in get_ap_information() are indented
as much as five levels, which makes the code difficult to read because
of all the wrapping. Factor them out into helper methods.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 46
There is no reason for comment describing the BSSID check for loop
to be spaced so far to the right. Move it above the for loop.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010
The code to initialize various different types of request structs
is repeated multiple times. Factor this code out into a macro
called INIT_REQUEST.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 55 +++---
The code to initialize various different types of request structs
is repeated multiple times. Factor this code out into a macro
called INIT_REQUEST.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 55 +++---
1 file changed, 16 insertions
There is no reason for comment describing the BSSID check for loop
to be spaced so far to the right. Move it above the for loop.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
Remove unnecessary parentheses highlighted by checkpatch.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_ho
Some cases in the switch statement in get_ap_information() are indented
as much as five levels, which makes the code difficult to read because
of all the wrapping. Factor them out into helper methods.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_ho
There is no reason for comment describing the BSSID check for loop
to be spaced so far to the right. Move it above the for loop.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010
Remove unnecessary parentheses highlighted by checkpatch.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index 948d45280d18
Some cases in the switch statement in get_ap_information() are indented
as much as five levels, which makes the code difficult to read because
of all the wrapping. Factor them out into helper methods.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 46
Braces aren't required for a single line if statement.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
Braces aren't required for a single line if statement.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index 00b97e8e9b4f
Some of the code for reading IEs is replicated multiple times in the
switch statement for get_ap_information(). Factor that code out into
read_ie().
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 48 +-
Some of the code for reading IEs is replicated multiple times in the
switch statement for get_ap_information(). Factor that code out into
read_ie().
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 48 +-
1 file changed, 22 insertions
There is no need for the calls to BUG_ON() in this driver, which are
used to check if mbo or mbo->context are NULL; mbo is never NULL, and
if mbo->context is NULL it would have already been dereferenced and
oopsed before reaching the BUG_ON().
Signed-off-by: Quytelda Kahja <quyte...@ta
There is no need for the calls to BUG_ON() in this driver, which are
used to check if mbo or mbo->context are NULL; mbo is never NULL, and
if mbo->context is NULL it would have already been dereferenced and
oopsed before reaching the BUG_ON().
Signed-off-by: Quytelda Kahja
---
drivers/s
Replace literal bytestring with CIPHER_ID_WPA_WEP40 constant.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_ho
Replace literal bytestring with CIPHER_ID_WPA_WEP40 constant.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index 7935ba56bb1d
Indent the parameters for a function call that extends past 80 characters.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/most/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
Indent the parameters for a function call that extends past 80 characters.
Signed-off-by: Quytelda Kahja
---
drivers/staging/most/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
index 67e2d7f29967
ugh, so I assumed
there wasn't really much recovery to be made from that problem. If
you feel this doesn't improve the behavior of the driver, just drop
the patch.
Thank you,
Quytelda Kahja
On Thu, Mar 1, 2018 at 8:21 AM, Greg KH <gre...@linuxfoundation.org> wrote:
> On Fri, Feb 23, 2018 a
ugh, so I assumed
there wasn't really much recovery to be made from that problem. If
you feel this doesn't improve the behavior of the driver, just drop
the patch.
Thank you,
Quytelda Kahja
On Thu, Mar 1, 2018 at 8:21 AM, Greg KH wrote:
> On Fri, Feb 23, 2018 at 11:58:33PM -0800, Quytelda Kahja
Use a blank line after components_show() function declaration.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/most/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
index 0ab2de5ecf18..67e2d7
Use a blank line after components_show() function declaration.
Signed-off-by: Quytelda Kahja
---
drivers/staging/most/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
index 0ab2de5ecf18..67e2d7f29967 100644
--- a/drivers
Indent the parameters for a function call that extends past 80 characters.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/most/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
Indent the parameters for a function call that extends past 80 characters.
Signed-off-by: Quytelda Kahja
---
drivers/staging/most/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
index 67e2d7f29967
Use a blank line after components_show() function declaration.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/most/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
index 0ab2de5ecf18..67e2d7
Use a blank line after components_show() function declaration.
Signed-off-by: Quytelda Kahja
---
drivers/staging/most/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
index 0ab2de5ecf18..67e2d7f29967 100644
--- a/drivers
my imperative attempts. However, I will word my change
logs in the imperative as best I can in the future.
Thank you,
Quytelda Kahja
On Thu, Mar 1, 2018 at 12:54 PM, Tobin C. Harding <m...@tobin.cc> wrote:
> On Thu, Mar 01, 2018 at 02:15:00PM +0300, Dan Carpenter wrote:
>> On Th
my imperative attempts. However, I will word my change
logs in the imperative as best I can in the future.
Thank you,
Quytelda Kahja
On Thu, Mar 1, 2018 at 12:54 PM, Tobin C. Harding wrote:
> On Thu, Mar 01, 2018 at 02:15:00PM +0300, Dan Carpenter wrote:
>> On Thu, Mar 01, 2018 at 0
The code that generates a WLAN capability mask is repeated in five
functions. This change refactors that code into a new function, which is
called now in each of those functions.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.
-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 2 +-
drivers/staging/ks7010/ks_hostif.h | 6 --
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index f425975fbcbc..7935ba
This driver defined constants BSS_CAP_* to represent WLAN capability
codes; however, these constants are already defined in the header
'linux/ieee80211.h' as WLAN_CAPABILITY_*. This change removes the locally
defined constants and substitutes the kernel's constants.
Signed-off-by: Quytelda Kahja
The code that generates a WLAN capability mask is repeated in five
functions. This change refactors that code into a new function, which is
called now in each of those functions.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 88 ++
1
-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 2 +-
drivers/staging/ks7010/ks_hostif.h | 6 --
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index f425975fbcbc..7935ba56bb1d 100644
--- a/drivers
This driver defined constants BSS_CAP_* to represent WLAN capability
codes; however, these constants are already defined in the header
'linux/ieee80211.h' as WLAN_CAPABILITY_*. This change removes the locally
defined constants and substitutes the kernel's constants.
Signed-off-by: Quytelda Kahja
The case statement in get_ap_information() should not use literal integers
to parse information element IDs when these values are provided by name
in 'enum ieee80211_eid' in the header 'linux/ieee80211.h'.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/
The case statement in get_ap_information() should not use literal integers
to parse information element IDs when these values are provided by name
in 'enum ieee80211_eid' in the header 'linux/ieee80211.h'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 31
SSID_MAX_SIZE is a constant defined locally in ks_hostif.h, but it should
be replaced with IEEE80211_MAX_SSID_LEN from the kernel's 802.11 header,
of which it is just a copy.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/ks7010/ks_hostif.c | 4 ++--
drivers/s
SSID_MAX_SIZE is a constant defined locally in ks_hostif.h, but it should
be replaced with IEEE80211_MAX_SSID_LEN from the kernel's 802.11 header,
of which it is just a copy.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 4 ++--
drivers/staging/ks7010/ks_hostif.h | 3
ed in the future since we run
modern machines that aren't limited to 80 character terminals anymore,
so this warning may soon be irrelevant anyway.
Thank you,
Quytelda Kahja
On Mon, Feb 26, 2018 at 5:51 AM, Hans Verkuil <hverk...@xs4all.nl> wrote:
> On 02/20/2018 07:53 AM, Quytelda
ed in the future since we run
modern machines that aren't limited to 80 character terminals anymore,
so this warning may soon be irrelevant anyway.
Thank you,
Quytelda Kahja
On Mon, Feb 26, 2018 at 5:51 AM, Hans Verkuil wrote:
> On 02/20/2018 07:53 AM, Quytelda Kahja wrote:
>> Fix a cod
The function pointer 'complete' in 'struct mbo' should use an identifier
for its argument.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/most/core.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/core.h b/drivers/stagin
Replace calls to BUG_ON() used to check for NULL pointers with WARN_ONCE()
followed by a return.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/most/core.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/most/co
Makes two very minor changes indicated by checkpatch:
1) Add a newline after components_show() definition.
2) Fix a line over the 80 character limit.
Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
drivers/staging/most/core.c | 5 -
1 file changed, 4 insertions(+), 1 de
Makes two very minor changes indicated by checkpatch:
1) Add a newline after components_show() definition.
2) Fix a line over the 80 character limit.
Signed-off-by: Quytelda Kahja
---
drivers/staging/most/core.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers
401 - 500 of 566 matches
Mail list logo
