-off-by: Ramkumar Ramachandra artag...@gmail.com
---
tools/perf/builtin-stat.c | 26 --
1 file changed, 12 insertions(+), 14 deletions(-)
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 8b0e1c9..0bd98fa 100644
--- a/tools/perf/builtin-stat.c
+++ b
Jiri Olsa wrote:
###
# 1 task will execute (on 1 nodes, 4 CPUs):
# -1x 1MB global shared mem operations
# -1x 0MB process shared mem operations
# -1x 0MB thread local mem operations
###
...
'-1x' does not seem right/intentional for default
While adding usage information, 44d742e (perf list: Add usage,
2013-10-30) broke
$ perf list --raw-dump
Fix this by making raw-dump a subcommand.
Cc: David Ahern dsah...@gmail.com
Cc: Jiri Olsa jo...@redhat.com
Cc: Arnaldo Carvalho de Melo a...@redhat.com
Signed-off-by: Ramkumar Ramachandra
Jiri Olsa wrote:
but looks like the usage is for bash completion only, so we probably
need only the first example functionality above.
If this is the case I think it should not be an option but another
command like 'raw-dump'.
I decided that there's no point making it an option, so I've sent
Jiri Olsa wrote:
you need to update perf-completion.sh now
also please add it to perf list man page as well
I updated perf-completion.sh, although I didn't mention it in the
commit message. I'll add it to the perf-list man page and send out
another version.
Ram
--
To unsubscribe from this
a...@redhat.com
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
tools/perf/Documentation/perf-list.txt | 3 +++
tools/perf/builtin-list.c | 2 +-
tools/perf/perf-completion.sh | 2 +-
3 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/tools/perf/Documentation
simple_strtoul() is marked for obsoletion; use the newer and more
pleasant kstrtoul() in its place.
Cc: Alexey Dobriyan adobri...@gmail.com
Cc: Haavard Skinnemoen hskinnem...@gmail.com
Cc: Hans-Christian Egtvedt egtv...@samfundet.no
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
arch
Just ran a few of them. Unsure about [4/4] because of aabccae6 and
a58130d.
Thanks.
Ramkumar Ramachandra (4):
selftests: add .gitignore for vm
selftests: fix clean target in kcmp Makefile
selftests: add .gitignore for kcmp
selftests: get {cpu,memory}-hotplug tests to run
tools/testing
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
tools/testing/selftests/kcmp/.gitignore | 2 ++
1 file changed, 2 insertions(+)
create mode 100644 tools/testing/selftests/kcmp/.gitignore
diff --git a/tools/testing/selftests/kcmp/.gitignore
b/tools/testing/selftests/kcmp/.gitignore
the executable bit fixing this.
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
tools/testing/selftests/cpu-hotplug/on-off-test.sh| 0
tools/testing/selftests/memory-hotplug/on-off-test.sh | 0
2 files changed, 0 insertions(+), 0 deletions(-)
mode change 100644 = 100755 tools
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
tools/testing/selftests/vm/.gitignore | 4
1 file changed, 4 insertions(+)
create mode 100644 tools/testing/selftests/vm/.gitignore
diff --git a/tools/testing/selftests/vm/.gitignore
b/tools/testing/selftests/vm/.gitignore
new
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
tools/testing/selftests/kcmp/Makefile | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/testing/selftests/kcmp/Makefile
b/tools/testing/selftests/kcmp/Makefile
index 56eb552..d7d6bbe 100644
--- a/tools/testing
Arnaldo Carvalho de Melo wrote:
> Em Thu, Oct 08, 2015 at 10:59:50AM +0530, Sriram Raghunathan escreveu:
>> Minor change, adding --list-opts to usage string. So that it is
>> visible to the user on running perf --help. or just perf
>> from command line.
>
>
> Ramkumar, Yunlong, are you ok with
Jan Kara wrote:
> Hum, I have somewhat hard time to understand what do you mean by
> 'magically optimized syscalls'. What should happen in VFS to speedup your
> load?
In retrospect, I think this is a terrible hack to begin with. Tuning
the filesystem specifically for git repositories is
H. Peter Anvin wrote:
> UML, lguest and Xen were done before the x86 architecture supported
> hardware virtualization.
[...]
> but on KVM-enabled hardware KVM seems
> like the better option (and is indeed what libguestfs uses.)
While we're still on the topic, I'd like a few clarifications. From
[Dropping git people from the CC, as this is not relevant to git anymore]
Okay, let me attempt to understand this.
Jan Kara wrote:
> On Fri 05-04-13 17:12:29, Al Viro wrote:
>> On Fri, Apr 05, 2013 at 05:55:34PM +0200, Jan Kara wrote:
>>
>> > What your question reminds me is an idea of recursive
Alexey Shmalko wrote:
> It would be great to participate in the next year GSoC contributing to
> the Linux kernel. For this reason, I have to find a mentor. If someone
> pushes me in the right direction, I'll be happy.
Start sending patches. There's plenty of low-hanging fruit: just look
around
Signed-off-by: Ramkumar Ramachandra
---
We discussed this pretty extensively on LLVMDev, but I'm still not
sure that I haven't missed something.
arch/x86/include/asm/bitops.h | 16
arch/x86/include/asm/percpu.h | 2 +-
2 files changed, 9 insertions(+), 9 deletions(-)
diff
Linus Torvalds wrote:
>> btrl $1, 0
>> btr $1, 0
>> btsl $1, 0
>> bts $1, 0
>
> What the heck is that supposed to show?
I was trying to show a reduced case where gas doesn't complain, but
llvm-mc does. Try compiling this with llvm-mc, and you'll get:
.text
btrl
Linus Torvalds wrote:
> Ok. So your commit message and explanation was pure and utter tripe,
> and the real reason you want this is that llvm-mc is broken.
>
> Please fix llvm-mc instead, ok? If the intent of llvm is to be
> compatible with the gnu compiler tools, then it should do that. Plus
>
Ping?
Does this patch look okay?
Thanks.
On Fri, Jul 5, 2013 at 4:15 AM, Ramkumar Ramachandra wrote:
> arch/um/defconfig only lists one default configuration, and that applies
> only to the i386 architecture. Replace it with two files:
>
> i386_defconfig and x86_64_defconfig
&
Ping?
Does this series look alright?
On Thu, Jul 4, 2013 at 6:11 PM, Ramkumar Ramachandra wrote:
> Hi,
>
> So I just started using perf, and noticed the accompanying completion
> script. Having dabbled with git.git's completion script a bit, I
> thought I should contribute wha
Rob Landley wrote:
> (Balsa is such an incompetent email client I wrote a python script to do
> this via raw smtp, and I'm always convinced it's going to screw up the send.
> But I think I've got it debugged now...)
Use the tried-and-tested git-send-email.perl, perhaps?
--
To unsubscribe from
Hi,
So, I was trying to boot User-Mode Linux with a modern rootfs with
systemd on it, and found that it wouldn't present me a prompt. I dug
further, and found out that getty is not able to open /dev/tty1; I
then tried the console-getty.service (which uses /dev/console), and it
worked. The
Richard Weinberger wrote:
> UML does not have CONFIG_VT.
Not sure what this means.
> But recent systemd versions can deal with that.
Nope, running systemd HEAD. I only recently figured out how to detect
that um Linux is running [1].
[1]: https://github.com/systemd/systemd/commit/7080ea16
--
Richard Weinberger wrote:
> UML does not have virtual consoles.
Then why do I see this on my UML box?
# ls /dev/tty* | wc -l
113
Why is it creating unusable devices? Is drivers/tty.c responsible for
this? What is it exactly?
> I'm not running HEAD, but opensuse 12.3 (with systemd) works on
Avoid creating lots of bogus devices nodes like /dev/tty* (since
User-Mode Linux does not have virtual consoles.
Cc: Richard Weinberger
Cc: Jeff Dike
Signed-off-by: Ramkumar Ramachandra
---
Applies on top of the patch I posted earlier.
arch/um/configs/i386_defconfig | 3 +--
arch/um
Richard Weinberger wrote:
> If you don't want devtmpfs, just disable it in your config.
I don't understand: is this not a good default? Why is creating bogus
devices, confusing systemd, and making um Linux hard to boot
desirable?
--
To unsubscribe from this list: send the line "unsubscribe
Richard Weinberger wrote:
> Why does this confuse systemd? systemd has also a dependency on devtmpfs.
See getty@.service, which is a dependency of getty.target:
# On systems without virtual consoles, don't start any getty. (Note
# that serial gettys are covered by serial-getty@.service, not
Ramkumar Ramachandra wrote:
> No, systemd does not have a hard dependency on devtmpfs.
Wait, let me double-check that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vg
Arnaldo Carvalho de Melo wrote:
> Huh? Why would this be more "modern", if both are equivalent, I think
> applying the same rules as we have for C code applies here.
It's the prevalent style in git.git, and I figured that it was picked
up from linux.git but didn't check. Drop this part
Ramkumar Ramachandra wrote:
> Ramkumar Ramachandra wrote:
>> No, systemd does not have a hard dependency on devtmpfs.
>
> Wait, let me double-check that.
Sorry about the stupidity; devtmpfs is very much a hard dependency. I
just realized that CONFIG_VT is on, and can't be turne
Richard Weinberger wrote:
> BTW: I'll not apply any patch to the kernel if the issue can easily
> fixed in user space, that's the major reason for my NAK.
I was just asking for good defaults; I want um Linux to work
out-of-the-box. There's really no point in creating bogus devices in
/dev, and
Al Viro wrote:
> As for the devices, they are *not* bogus. RTFM, already.
> Documentation/virtual/uml/UserModeLinux-HOWTO.txt, if you can't be bothered
> to say git grep UML Documentation/ and find where it on your own. The
> relevant section is called "Setting up serial lines and consoles".
>
Richard Weinberger wrote:
> http://user-mode-linux.sourceforge.net/downloads.html
I found a uml_utilities_20070815.tar.bz2. 2007, seriously? Is there
no interest in maintaining it?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Rob Landley wrote:
> Is this script of yours any use for patches that aren't, and never were, in
> git? (Given that it's not in the kernel tree, I'm guessing "no".)
It's part of git.git. And yes, it works with plain mbox files
(especially those generated by `git format-patch`).
--
To unsubscribe
Sarah Sharp wrote:
> I do smile often in email. :) And be sad. :( And be apologetic. :-/
> Smug. ^~^ Angry. >:[ Sarcastic. ;) Trolling/crazy. 8) D'oh. (>.<)
> Worried. (>_>); Disappointed. (-_-) Kitty! =^_^= Meow!
>
> Be creative. There are ways of expressing emotion without cussing.
Sarah Sharp wrote:
> https://picasaweb.google.com/116960357493251979546/Trolls#5901298464591248626
> https://picasaweb.google.com/116960357493251979546/Trolls#5901288095984358098
>
> On my blog, here's some choice comments, mostly asking me to quit kernel
> development, along with more than a few
Arnaldo Carvalho de Melo wrote:
> Can you check how is this in the current perf/core branch so that we can
> move forward while I process some other patches?
This series (except this part) was merged into perf/completion of
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux 3 weeks ago,
so
Rusty Russell wrote:
> Ramkumar Ramachandra writes:
>> asm and volatile are provided for backward compatibility; use the ansi
>> versions __asm__ and __volatile__.
>
> Really? I don't see that in the gcc documentation. In fact, I didn't
> know __volatile__ at all:
T
Jiri Olsa wrote:
> On Thu, Nov 21, 2013 at 08:03:47PM +0530, Ramkumar Ramachandra wrote:
>> In
>>
>> $ perf diff -c ratio
>>
>> color the Ratio column using percent_color_snprintf().
>
> why is there 'INCOMPLETE' in the subject?
As explained in the segm
Jiri Olsa wrote:
> this patch changes the diff output for 'perf diff'
>
> file '1' - old perf
> file '2' - your change
>
> I expected only the difference would be only color
> not numbers.
Oh, sorry; I forgot about the threshold completely. I'll submit
another iteration with a fresh [4/4] once
Cc: Arnaldo Carvalho de Melo
Signed-off-by: Ramkumar Ramachandra
---
tools/perf/builtin-diff.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
index 3b67ea2..79e0448 100644
--- a/tools/perf/builtin-diff.c
+++ b/tools/perf/builtin
].
Thanks.
Ramkumar Ramachandra (5):
perf diff: don't compute Delta if he->dummy
perf diff: color the Delta column
perf diff: generalize hpp__color_delta for -c
perf diff: color the Ratio column
perf diff: color the Weighted Diff column
tools/perf/builtin-diff.c |
Generalize the function so that we can accommodate all three comparison
methods: delta, ratio, and wdiff.
Cc: Jiri Olsa
Cc: Namhyung Kim
Cc: Arnaldo Carvalho de Melo
Signed-off-by: Ramkumar Ramachandra
---
tools/perf/builtin-diff.c | 47 +--
1 file
Color the numbers in the Delta column either green or red depending on
whether the number is positive or negative.
Cc: Jiri Olsa
Cc: Namhyung Kim
Cc: Arnaldo Carvalho de Melo
Signed-off-by: Ramkumar Ramachandra
---
tools/perf/builtin-diff.c | 37 -
1 file
In
$ perf diff -c ratio
color the Ratio column using percent_color_snprintf().
Cc: Jiri Olsa
Cc: Namhyung Kim
Cc: Arnaldo Carvalho de Melo
Signed-off-by: Ramkumar Ramachandra
---
tools/perf/builtin-diff.c | 20
1 file changed, 20 insertions(+)
diff --git a/tools
In
$ perf diff -c wdiff:M,N
color the numbers in the Weighted Diff column either green or red,
depending on whether the number is positive or negative.
Cc: Jiri Olsa
Cc: Namhyung Kim
Cc: Arnaldo Carvalho de Melo
Signed-off-by: Ramkumar Ramachandra
---
tools/perf/builtin-diff.c | 22
Jiri Olsa wrote:
>> The incomplete bit is marked using a TODO; removing two trailing '%'
>> symbols doesn't seem to work. Can someone please tell me how to fix
>> this problem?
>
> aah here it is..
I fixed it and sent another iteration.
--
To unsubscribe from this list: send the line
Jiri Olsa wrote:
> I think it'd be better to have just one switch for
> comparison_method and do all the processing within
Okay, will fix in the next iteration.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More
Jiri Olsa wrote:
>> if (!pair)
>> goto dummy_print;
>> if (pair->diff.computed)
>> - percent = pair->diff.period_ratio_delta;
>> + switch (comparison_method) {
>> + case COMPUTE_DELTA:
>> + delta =
Jiri Olsa wrote:
>> diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
>> index 79e0448..84d5f2d 100644
>> --- a/tools/perf/builtin-diff.c
>> +++ b/tools/perf/builtin-diff.c
>> @@ -769,6 +769,33 @@ static int hpp__entry_baseline(struct hist_entry *he,
>> char *buf, size_t size)
>>
Jiri Olsa wrote:
>> diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
>> index 3b67ea2..79e0448 100644
>> --- a/tools/perf/builtin-diff.c
>> +++ b/tools/perf/builtin-diff.c
>> @@ -792,6 +792,9 @@ hpp__entry_pair(struct hist_entry *he, struct hist_entry
>> *pair,
>>
>>
Ramkumar Ramachandra wrote:
> Jiri Olsa wrote:
>>> if (!pair)
>>> goto dummy_print;
>>> if (pair->diff.computed)
>>> - percent = pair->diff.period_ratio_delta;
>>> + switch (com
Generalize the function so that we can accommodate all three comparison
methods: delta, ratio, and wdiff.
Cc: Jiri Olsa
Cc: Namhyung Kim
Cc: Arnaldo Carvalho de Melo
Signed-off-by: Ramkumar Ramachandra
---
tools/perf/builtin-diff.c | 39 ++-
1 file changed
In
$ perf diff -c wdiff:M,N
color the numbers in the Weighted Diff column either green or red,
depending on whether the number is positive or negative.
Cc: Jiri Olsa
Cc: Namhyung Kim
Cc: Arnaldo Carvalho de Melo
Signed-off-by: Ramkumar Ramachandra
---
tools/perf/builtin-diff.c | 22
Color the numbers in the Delta column either green or red depending on
whether the number is positive or negative.
Cc: Jiri Olsa
Cc: Namhyung Kim
Cc: Arnaldo Carvalho de Melo
Signed-off-by: Ramkumar Ramachandra
---
tools/perf/builtin-diff.c | 37 -
1 file
In
$ perf diff -c ratio
color the Ratio column using percent_color_snprintf().
Cc: Jiri Olsa
Cc: Namhyung Kim
Cc: Arnaldo Carvalho de Melo
Signed-off-by: Ramkumar Ramachandra
---
tools/perf/builtin-diff.c | 20
1 file changed, 20 insertions(+)
diff --git a/tools
Hi,
This iteration fixes several small problems in the previous iteration
pointed out by Jiri Olsa. Most significantly, the first patch has been
dropped, and there's just one switch-case statement for the entire
logic.
Thanks.
Ramkumar Ramachandra (4):
perf diff: color the Delta column
perf
Jiri Olsa wrote:
> these colors are not consistent with colors in baseline,
> moreover all negative values are shown as red
>
> - please check get_percent_color function (used for baseline),
> it checks the percentage against following values:
>
> #define MIN_GREEN 0.5
> #define
Jiri Olsa wrote:
> This patch basicaly factor the code you added in previous one.
>
> Could we use the function below from the beggining?
Yeah, I suppose I could squash this into [2/4].
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Color the numbers in the Delta column using percent_color_snprintf().
Generalize the function so that we can accommodate all three comparison
methods in the future: delta, ratio, and wdiff.
Cc: Jiri Olsa
Cc: Arnaldo Carvalho de Melo
Signed-off-by: Ramkumar Ramachandra
---
tools/perf/builtin
In
$ perf diff -c wdiff:M,N
color the numbers in the Weighted Diff column either green or red,
depending on whether the number is positive or negative.
Cc: Jiri Olsa
Cc: Arnaldo Carvalho de Melo
Signed-off-by: Ramkumar Ramachandra
---
tools/perf/builtin-diff.c | 22
Olsa.
Cc: Jiri Olsa
Cc: Arnaldo Carvalho de Melo
Ramkumar Ramachandra (3):
perf diff: color the Delta column
perf diff: color the Ratio column
perf diff: color the Weighted Diff column
tools/perf/builtin-diff.c | 91 ++-
1 file changed, 90
In
$ perf diff -c ratio
color the Ratio column using percent_color_snprintf().
Cc: Jiri Olsa
Cc: Arnaldo Carvalho de Melo
Signed-off-by: Ramkumar Ramachandra
---
tools/perf/builtin-diff.c | 20
1 file changed, 20 insertions(+)
diff --git a/tools/perf/builtin-diff.c b
As spotted by scripts/checkincludes.pl.
Cc: Russell King
Signed-off-by: Ramkumar Ramachandra
---
arch/arm/kvm/handle_exit.c| 2 --
arch/arm/mach-lpc32xx/phy3250.c | 1 -
arch/arm/mach-omap1/board-voiceblue.c | 1 -
arch/arm/mach-sa1100/hackkit.c| 1 -
arch/arm/mach
Cc: Gleb Natapov
Cc: Paolo Bonzini
Signed-off-by: Ramkumar Ramachandra
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 3438384..1dd73f7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4835,7 +4835,7 @@ KERNEL VIRTUAL MACHINE
The document hasn't been updated since cf3e3d3 (KVM: Document KVM
specific review items, 2010-06-24); kvm does not have a separate
repository anymore.
Cc: Avi Kivity
Cc: Gleb Natapov
Cc: Paolo Bonzini
Signed-off-by: Ramkumar Ramachandra
---
Documentation/virtual/kvm/review-checklist.txt | 2
Cc: Gleb Natapov
Cc: Paolo Bonzini
Signed-off-by: Ramkumar Ramachandra
---
Documentation/virtual/kvm/00-INDEX | 24
1 file changed, 24 insertions(+)
create mode 100644 Documentation/virtual/kvm/00-INDEX
diff --git a/Documentation/virtual/kvm/00-INDEX
b/Documentation
Hi,
I was going through the kvm documentation when I noticed the following
minor nits.
Thanks.
Ramkumar Ramachandra (3):
MAINTAINERS: fix broken link to www.linux-kvm.org
Documentation/kvm: patches should be against linux.git
Documentation/kvm: add a 00-INDEX file
Documentation/virtual
Cc: Gleb Natapov
Cc: Paolo Bonzini
Cc: KVM List
Signed-off-by: Ramkumar Ramachandra
---
This is a replacement for [PATCH 2/3] Documentation/kvm: patches
should be against linux.git
Thanks to Paolo for pointing to the right tree.
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff
] to [3/5] factors things out and prepares the stage for [4/5],
which is the focus of the series. [5/5] is just a pure rename.
Thanks.
Ramkumar Ramachandra (5):
perf completion: introduce a layer of indirection
perf completion: factor out compgen stuff
perf completion: factor out call
override'able __perfcomp_colon function;
we will override it when introducing zsh support.
Cc: Arnaldo Carvalho de Melo
Cc: Ingo Molnar
Signed-off-by: Ramkumar Ramachandra
---
tools/perf/bash_completion | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/tools/perf
compgen is a bash-builtin; factor out the invocations into a separate
function to give us a chance to override it with a zsh equivalent in
future patches.
Cc: Arnaldo Carvalho de Melo
Cc: Ingo Molnar
Signed-off-by: Ramkumar Ramachandra
---
tools/perf/bash_completion | 15 ++-
1
Define the variables cur, words, cword, and prev outside the main
completion function so that we have a chance to override it when we
introduce zsh support.
Cc: Arnaldo Carvalho de Melo
Cc: Ingo Molnar
Signed-off-by: Ramkumar Ramachandra
---
tools/perf/bash_completion | 17
__perfcomp(), __perfcomp_colon(), and _perf() have to be
overridden. Inspired by the way the git.git completion system is
structured.
Cc: Namhyung Kim
Cc: Frederic Weisbecker
Cc: Arnaldo Carvalho de Melo
Cc: Ingo Molnar
Signed-off-by: Ramkumar Ramachandra
---
tools/perf/bash_completion | 63
Cc: Arnaldo Carvalho de Melo
Cc: Ingo Molnar
Signed-off-by: Ramkumar Ramachandra
---
tools/perf/{bash_completion => perf-completion.sh} | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename tools/perf/{bash_completion => perf-completion.sh} (100%)
diff --git a/tool
Arnaldo Carvalho de Melo wrote:
> static inline percent_color_snprintf(...)
> {
> return value_color_snprintf(...);
> }
The issue with this suggestion is that the prototype of
percent_color_snprintf() is:
int percent_color_snprintf(char *bf, size_t size, const char *fmt, ...)
So, I
Arnaldo Carvalho de Melo wrote:
>> The issue with this suggestion is that the prototype of
>> percent_color_snprintf() is:
>>
>> int percent_color_snprintf(char *bf, size_t size, const char *fmt, ...)
>>
>> So, I can only pass value_color_snprintf() a va_list, making its prototype:
>>
>> int
(PARSE_OPT_KEEP_UNKNOWN) so that we have a chance to handle it
later. The trade-off that this patch makes is that
$ perf list --foo
will not error out like it used to.
Fixes: 44d742e01e6d (perf list: Add usage)
Cc: David Ahern
Cc: Ingo Molnar
Cc: Arnaldo Carvalho de Melo
Signed-off-by: Ramkumar Ramachandra
Currently, there is no way to enumerate the subcommands under 'perf
kvm', so hardcode them.
Signed-off-by: Ramkumar Ramachandra
---
tools/perf/perf-completion.sh | 4
1 file changed, 4 insertions(+)
diff --git a/tools/perf/perf-completion.sh b/tools/perf/perf-completion.sh
index 4949488
Hi,
These are based on tip/master.
Thanks.
Ramkumar Ramachandra (2):
perf completion: complete 'perf kvm'
perf tools: ignore files generated by 'perf kvm'
tools/perf/.gitignore | 2 ++
tools/perf/perf-completion.sh | 4
2 files changed, 6 insertions(+)
--
1.8.5.rc0.5
Signed-off-by: Ramkumar Ramachandra
---
tools/perf/.gitignore | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/perf/.gitignore b/tools/perf/.gitignore
index 782d86e..28264a9 100644
--- a/tools/perf/.gitignore
+++ b/tools/perf/.gitignore
@@ -13,6 +13,8 @@ perf*.html
common-cmds.h
st: Fix raw-dump arg
Ramkumar reported that perf list --raw-dump was broken by 44d742e.
Fix by making raw-dump a proper argument.
Signed-off-by: David Ahern
Cc: Ingo Molnar
Cc: Arnaldo Carvalho de Melo
Cc: Ramkumar Ramachandra
Signed-off-by: Ramkumar Ramachandra
---
tools/perf/builtin
Signed-off-by: Ramkumar Ramachandra
---
Include .kvm[.old], .host[.old] files, as suggested by Arnaldo.
tools/perf/.gitignore | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tools/perf/.gitignore b/tools/perf/.gitignore
index 782d86e..9fea0d9 100644
--- a/tools/perf/.gitignore
+++ b
David Ahern wrote:
> I don't like the command list being embedded in the completion script. It
> will get outdated quickly.
I could introduce a
$ perf kvm --list-cmds
but that would mean a
printf("record report stat ..")
in builtin-kvm.c, because the commands aren't in any sort of array.
Introduce
$ perf kvm --list-cmds
to dump a raw list of commands for use by the completion script. While
at it, refactor kvm_usage so that there's only one copy of the command
listing.
Cc: David Ahern
Cc: Arnaldo Carvalho de Melo
Signed-off-by: Ramkumar Ramachandra
---
David Ahern wrote
Jan Kara wrote:
> Initially, you will have to flip the flag on every directory in the
> subtree. But the flag is persistently stored on disk so you have to do it
> once when the directory is created and then each time you notice the
> directory has changed and the flag has been cleared.
How is
-by: Ramkumar Ramachandra
---
drivers/gpu/drm/i915/intel_lvds.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_lvds.c
b/drivers/gpu/drm/i915/intel_lvds.c
index 6c09617..8275551 100644
--- a/drivers/gpu/drm/i915/intel_lvds.c
+++ b/drivers/gpu/drm
Cc: Andreas Heider
Cc: Seth Forshee
Original-patch-by: Andreas Heider
Signed-off-by: Ramkumar Ramachandra
---
drivers/gpu/drm/i915/i915_dma.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
index
If the LVDS panel wasn't connected at boot then we won't have an EDID
for it. To fix this, call intel_lvds_get_edid() from the vga_switcheroo
reprobe callback.
Cc: Andreas Heider
Cc: Seth Forshee
Original-patch-by: Seth Forshee
Signed-off-by: Ramkumar Ramachandra
---
drivers/gpu/drm/i915
This code will be reused to support hybrid graphics on some Apple
machines that can't get a mode for the LVDS panel at boot, so move it
into a new function named intel_lvds_get_edid().
Cc: Andreas Heider
Cc: Seth Forshee
Original-patch-by: Seth Forshee
Signed-off-by: Ramkumar Ramachandra
switcheroo-reprobe to call get-edid. I think it's a step
in the right direction, although I think more stuff is required to fix
the issue.
Disclaimer: The series might be utter rubbish, because this is my
first attempt at any driver code.
Thanks.
Cc: Andreas Heider
Cc: Seth Forshee
Ramkumar
Ramkumar Ramachandra wrote:
> My system freezes if I remove modules like usbhci, ahci, ehci_hcd.
Correction: my input devices (keyboard, trackpad) depend on usbhci,
ehci_hcd, while libata and my hard disk drivers depend on ahci;
there's no way I can do without them. I'm trying to get
Hi Chris,
Chris Wilson wrote:
>> diff --git a/drivers/gpu/drm/i915/i915_dma.c
>> b/drivers/gpu/drm/i915/i915_dma.c
>> index 5c64842..336a835b 100644
>> --- a/drivers/gpu/drm/i915/i915_dma.c
>> +++ b/drivers/gpu/drm/i915/i915_dma.c
>> @@ -1265,6 +1265,12 @@ static void
Chris Wilson wrote:
> On Tue, Jan 07, 2014 at 03:28:43PM +0530, Ramkumar Ramachandra wrote:
>> If the LVDS panel wasn't connected at boot then we won't have an EDID
>> for it. To fix this, call intel_lvds_get_edid() from the vga_switcheroo
>> reprobe callback.
>
> I wo
Chris Wilson wrote:
> Rather than special casing lvds (especially when there are other panel
> connectors that can also be muxed), extend the connector interface to
> support a reprobe and walk over all connectors associated with i915
> after a switcheroo event.
Okay, so I can see the following
Seth Forshee wrote:
> 1. On many Macbook models the firmware isn't putting LVDS information
> in opregion. Reading the EDID during device initialization also
> fails since the DDC is muxed to the DGPU, so i915 concludes there's
> no LVDS and doesn't register an LVDS connector at all.
Cc: Andreas Heider
Cc: Seth Forshee
Original-patch-by: Andreas Heider
Signed-off-by: Ramkumar Ramachandra
---
drivers/gpu/drm/i915/i915_dma.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
index
Hi Chris et al,
I got this far with creating a generic interface for various
get_edid() functions, but I'm stuck now. Where do I get the specific
i2c_adapter from?
I hope the series is okay otherwise.
Thanks.
Ramkumar Ramachandra (4):
drm/i915: add support for vga_switcheroo reprobe
drm
301 - 400 of 703 matches
Mail list logo
