[uPATCH] Nulling mmap_cache iff needed (2.4.0)

2001-01-10 Thread Rasmus Andersen
Hi. The following (trivial) patch against 2.4.0 (but should apply cleanly against 241p1) makes do_munmap only null our precious cache if the pointer contained therein is invalidated by the unmapping. I doubt it will make any measurable difference but it seems straightforward enough to be done

Re: 2.4.0-ac6: drivers/net/rcpci45.c typo

2001-01-11 Thread Rasmus Andersen
On Thu, Jan 11, 2001 at 01:59:31PM +0200, Hans Grobler wrote: Yes we know about this one. This is a bug that was killed, and then came back to life. We're still trying to figure out how... :) I feel that I must step up and claim responsibility here: The patch is mine and I apparently messed

Re: 2.4.0-ac6: drivers/net/rcpci45.c typo

2001-01-11 Thread Rasmus Andersen
On Thu, Jan 11, 2001 at 01:06:32PM +0100, Rasmus Andersen wrote: On Thu, Jan 11, 2001 at 01:59:31PM +0200, Hans Grobler wrote: Yes we know about this one. This is a bug that was killed, and then came back to life. We're still trying to figure out how... :) I feel that I must step up

[PATCH] limit mmap_cache nulling (2.2.19-7)

2001-01-14 Thread Rasmus Andersen
Hi. The following patch against 2.2.19-7 adds checks in do_munmap and merge_segments to limit the nulling of mmap_cache to the cases where the cached vma is in the affected area. Comments? --- linux-2.2.19-7/mm/mmap.c~ Sun Jan 14 13:43:50 2001 +++ linux-2.2.19-7/mm/mmap.cSun Jan 14

[PATCH] make drivers/scsi/a3000.c check request_irq (240p3)

2001-01-14 Thread Rasmus Andersen
Hi. (I cannot seem to find a maintainer for this code.) The following patch makes drivers/scsi/a3000.c check the return from request_irq. Applies cleanly against 2.4.0 and ac9. Comments? --- linux-ac9/drivers/scsi/a3000.c.org Sun Jan 14 13:47:32 2001 +++ linux-ac9/drivers/scsi/a3000.c

[PATCH] make drivers/scsi/atari_scsi.c check request_irq (240p3)

2001-01-14 Thread Rasmus Andersen
Hi. The following patch makes drivers/scsi/atari_scsi.c check request_irq's return code. It applies cleanly against 240p3 and ac9. Comments? --- linux-ac9/drivers/scsi/atari_scsi.c~Tue Nov 28 02:57:34 2000 +++ linux-ac9/drivers/scsi/atari_scsi.c Sun Jan 14 19:28:00 2001 @@ -690,19

Re: [PATCH] make drivers/scsi/atari_scsi.c check request_irq (240p3)

2001-01-14 Thread Rasmus Andersen
Hi again and sorry for the noise. Hans Grobler kindly pointed me towards scsi_unregister which I heppily had ignored. The following patch includes this function in the exit paths. Otherwise it is identical to the earlier one. --- linux-ac9/drivers/scsi/atari_scsi.c.org Sun Jan 14 19:41:56

Re: [PATCH] make drivers/scsi/a3000.c check request_irq (240p3)

2001-01-14 Thread Rasmus Andersen
On Sun, Jan 14, 2001 at 07:49:35PM +0100, Rasmus Andersen wrote: Comments? Well, Hans Grobler had some. the patch below tries to accommodate them by adding scsi_unregister() and wd33c93_release() to the earlier patch. Sorry for the multiple mailings. (Any other) comments? :) --- linux-ac9

Re: [PATCH] make drivers/scsi/atari_scsi.c check request_irq (240p3)

2001-01-14 Thread Rasmus Andersen
On Sun, Jan 14, 2001 at 04:29:11PM -0500, Jeff Garzik wrote: request_irq returns zero on success, not on failure. Further, you need to return the request_irq error value back to the caller, if possible. chokeblush My, that was embarassing. I'll change this as soon as I trust myself with a

Re: [PATCH] make drivers/scsi/atari_scsi.c check request_irq (240p3)

2001-01-16 Thread Rasmus Andersen
Hi again. The following patch should correct the request_irq mistake. (The zero return on failure seems to be required by scsi/scsi.c and is what everybody else does.) Other comments? :) --- linux-ac9/drivers/scsi/atari_scsi.c.org Sun Jan 14 19:41:56 2001 +++

[PATCH] make drivers/scsi/blz1230.c check request_irq return (240p3)

2001-01-17 Thread Rasmus Andersen
Hi. The following patch makes drivers/scsi/blz1230.c check request_irq's return code. It applies cleanly against 240p3 and ac9. It also swaps two lines in an existing error path (esp_deallocate/ scsi_unregister) since this seems wrong. Comments? --- linux-ac9/drivers/scsi/blz1230.c.org

[PATCH] make drivers/scsi/dec_esp.c check request_irq return code (240p3)

2001-01-17 Thread Rasmus Andersen
Hi. (I have not been able to find a maintainer for this code.) This patch makes drivers/scsi/dec_esp.c check the return code of request_irq. It applies cleanly against 240p3 and ac9. In the search_tc_slot loop I made it continue the search on failure for one slot. Would this be correct?

[PATCH] make drivers/scsi/mvme147.c care about (some) return codes (240p3)

2001-01-17 Thread Rasmus Andersen
Hi. (I have not been able to find a maintainer for this code.) The following patch makes drivers/scsi/mvme147.c check the return code from request_irq and scsi_register. It applies cleanly against 240p3 and ac9. Please comment. --- linux/drivers/scsi/mvme147.cTue Nov 28 02:57:34

[PATCH] make drivers/scsi/sgiwd93.c check some more return codes (240p3)

2001-01-17 Thread Rasmus Andersen
Hi. The following patch makes drivers/scsi/sgiwd93.c check the return code from request_irq and get_free_pages. It also removes a line already done a bit higher up (the dma_cache_wback_inv one). Please comment. --- linux-ac9/drivers/scsi/sgiwd93.c.orgSun Jan 14 21:33:29 2001 +++

[rasmus@jaquet.dk: [PATCH] make drivers/scsi/sun3x_esp.c check request_irq's return value (240p3)]

2001-01-17 Thread Rasmus Andersen
(Ooops. Forgot to cc linux-kernel.) - Forwarded message from Rasmus Andersen [EMAIL PROTECTED] - Hi. The following patch makes drivers/scsi/sun3x_esp.c check the return value of request_irq. Comments? --- linux-ac9/drivers/scsi/sun3x_esp.c~ Thu Jan 4 22:00:55 2001 +++ linux-ac9

[PATCH] drivers/scsi/53c7xx.c error handling and cleanup (241p9)

2001-01-22 Thread Rasmus Andersen
Hi. (I hope I haven't missed any relevant lists :) ) The following patch makes drivers/scsi/53c7xx.c check the return code of request_region and release the irq properly in the error path. It applies cleanly against ac10 and 241p9. Comments? --- linux-ac10-clean/drivers/scsi/53c7xx.c

[PATCH] general cleanup of drivers/scsi/NCR53c406a.c (241p9)

2001-01-22 Thread Rasmus Andersen
Hi. (I hope you are the NCR53c406a maintainer. If not, I apologize for the inconvenience and hope you can redirect me.) The following patch makes drivers/scsi/NCR53c406a.c use the return code of request_region instead of check_region and makes it release the proper resources in its error paths.

[PATCH] drivers/scsi/aha1740.c: check request_region return code (241p9)

2001-01-22 Thread Rasmus Andersen
Hi. (I have not been able to determine a probable maintainer for this code.) The following patch makes drivers/scsi/aha1740.c use the return code of request_region instead of check_region. The change necessitated some changes to the folllowing error paths so I changed those to be forwards

[PATCH] drivers/scsi/3w-xxxx.c check_region - request_region (241p9)

2001-01-22 Thread Rasmus Andersen
(Sorry, forgot lk.) Hi. The following patch makes drivers/scsi/3w-.c use the return code from request_region instead of check_region. It applies cleanly against ac10 and 241p9. Comments? --- linux-ac10-clean/drivers/scsi/3w-.c Thu Nov 9 02:09:50 2000 +++

[PATCH] make drivers/scsi/fastlane.c check return code of request_irq (241p9)

2001-01-22 Thread Rasmus Andersen
Hi. (I have not been able to find a maintainer for this code.) The following patch makes drivers/scsi/fastlane.c check the return code of request_irq and converts (some) error paths to use forward gotos. It applies cleanly against ac10 and 241p9. Comments? ---

Re: 2.4.0-ac10 compile errors

2001-01-23 Thread Rasmus Andersen
On Tue, Jan 23, 2001 at 11:19:38PM +1100, Keith Owens wrote: On Tue, 23 Jan 2001 12:16:11 +, Anders Karlsson [EMAIL PROTECTED] wrote: Even if it is a pristine kernel tree? What function does the 'make mrproper' fill on an unused kernel tree? Depends on how you removed the old tree.

Re: [PATCH] make drivers/scsi/fastlane.c check return code of request_irq (241p9)

2001-01-23 Thread Rasmus Andersen
On Tue, Jan 23, 2001 at 12:37:18AM +0100, Rasmus Andersen wrote: Hi. This is an updated patch since I messed the one from yesterday up. The comments still apply, though. Apologies for the extra mails. --- linux-ac10-clean/drivers/scsi/fastlane.cMon Oct 16 21:51:16 2000 +++ linux-ac10

[PATCH] drives/scsi/tmscsim.c: check_region - request_region (241p9)

2001-01-23 Thread Rasmus Andersen
(Forgot to cc lk. If anyone have comments please cc [EMAIL PROTECTED] Thanks.) - Forwarded message from Rasmus Andersen [EMAIL PROTECTED] - Hi. The following patch makes drives/scsi/tmscsim.c use request_region instead of check_region+request_region. It applies cleanly against ac10

[PATCH] drivers/scsi/u14-35f.c: check_region - request_region (241p9)

2001-01-23 Thread Rasmus Andersen
(Too fast again and forgot to cc the lists. If anyone replies to this mail, please cc [EMAIL PROTECTED] Thanks.) - Forwarded message from Rasmus Andersen [EMAIL PROTECTED] - Hi. The following patch makes drivers/scsi/u14-35f.c drop check_region in favour of checking the return code

[PATCH] drivers/scsi/wd7000.c: check_region - request_region (241p9)

2001-01-23 Thread Rasmus Andersen
Hi. The following patch makes drivers/scsi/wd7000.c use request_region instead of check_region+request_region. It also drops a panic() and changes error paths to be forward gotos (in part necessary by the request_region change). It applies cleanly against ac10 and 241p9. Comments? ---

[PATCH] drivers/scsi/aic7xxx.c: check_region - request_region (241p9)

2001-01-22 Thread Rasmus Andersen
Hi. The following patch makes drivers/scsi/aic7xxx.c use the return code of request_region instead of check_region. Since this touched a lot of error paths I converted them to forward gotos while I was there anyway. It applies cleanly against ac10 and 241p9. Comments? ---

[PATCH] drivers/scsi/cpqfcTSinit.c cleanup (241p9)

2001-01-22 Thread Rasmus Andersen
Hi. The following patch makes drivers/scsi/cpqfcTSinit.c check the return code of ioremap, makes it use the return code of request_region instead of check_region and converts the touched code to use forward gotos on error paths. It applies cleanly against ac10 and 241p9. Comments? ---

[PATCH] drivers/scsi/g_NCR5380.c: check_*_region - request_*_region (241p9)

2001-01-22 Thread Rasmus Andersen
Hi. (I have not been able to find a maintainer for this code.) The following patch makes drivers/scsi/g_NCR5380.c check the return code of request_region instead of using check_region. Ditto for request_mem_region. It applies cleanly against ac10 and 241p9. Comments? ---

[PATCH] make drivers/scsi/hosts.c check kmalloc return codes (241p9)

2001-01-22 Thread Rasmus Andersen
Hi. The following patch makes drivers/scsi/hosts.c check kmalloc's return code, drops some gratitious zero initializations and makes it a little less panicky. It applies cleanly against ac10 and 241p9. Please comment. --- linux-ac10-clean/drivers/scsi/hosts.c Mon Oct 30 23:44:29 2000

[PATCH] drivers/scsi/inia100.c cleanup (241p9)

2001-01-22 Thread Rasmus Andersen
Hi. The following patch makes drivers/scsi/inia100.c refrain from calling panic(), makes it check the return code of request_region and makes it release a lot of resources on error. It applies cleanly against ac10 and 241p9. Comments? --- linux-ac10-clean/drivers/scsi/inia100.c Sun Nov

[PATCH] make drivers/scsi/megaraid.c check ioremaps return code (241p9)

2001-01-22 Thread Rasmus Andersen
Hi. The following patch makes drivers/scsi/megaraid.c check the return code of ioremap and converts the affected code paths to forward gotos error handling. It applies cleanly against ac10 and with a little fuzz against 241p9. Please comment. --- linux-ac10-clean/drivers/scsi/megaraid.c

Re: [PATCH] make drivers/scsi/megaraid.c check ioremaps return code (241p9)

2001-01-23 Thread Rasmus Andersen
On Tue, Jan 23, 2001 at 12:45:20AM +0100, Rasmus Andersen wrote: (This is another updated patch with the comments from the earlier mail still valid.) --- linux-ac10-clean/drivers/scsi/megaraid.cSat Jan 20 15:17:13 2001 +++ linux-ac10/drivers/scsi/megaraid.c Tue Jan 23 23:06:14 2001

Re: [PATCH] drivers/scsi/g_NCR5380.c: check_*_region - request_*_region (241p9)

2001-01-23 Thread Rasmus Andersen
On Tue, Jan 23, 2001 at 12:40:26AM +0100, Rasmus Andersen wrote: (This is another updated patch with the comments from the earlier mail still valid.) --- linux-ac10-clean/drivers/scsi/g_NCR5380.c Sat Jan 20 15:17:13 2001 +++ linux-ac10/drivers/scsi/g_NCR5380.c Tue Jan 23 21:05:44 2001

Re: [PATCH] drivers/scsi/inia100.c cleanup (241p9)

2001-01-23 Thread Rasmus Andersen
On Tue, Jan 23, 2001 at 12:42:42AM +0100, Rasmus Andersen wrote: (This is another updated patch with the comments from my earlier mail still valid.) --- linux-ac10-clean/drivers/scsi/inia100.c Sun Nov 12 04:01:11 2000 +++ linux-ac10/drivers/scsi/inia100.c Tue Jan 23 21:23:47 2001

[PATCH] drivers/scsi/ips.c check_region - request_region (241p9)

2001-01-23 Thread Rasmus Andersen
Hi. The following patch makes drivers/scsi/ips.c use the return code of request_region instead of calling check_region. It also moves some resource freeing to ips_free since that made my error path cleaner. It applies cleanly against ac10 and 241p9. Please comment. ---

[PATCH] drivers/scsi/qla1280.c check_region - request-region (241p9)

2001-01-23 Thread Rasmus Andersen
Hi. The following patch makes drivers/scsi/qla1280.c use the return code of request_region instead of a call to check_region. It applies cleanly against ac10 and 241p9. Comments? --- linux-ac10-clean/drivers/scsi/qla1280.c Wed Dec 6 21:06:18 2000 +++ linux-ac10/drivers/scsi/qla1280.c

Re: [PATCH] drivers/scsi/53c7xx.c error handling and cleanup (241p9)

2001-01-23 Thread Rasmus Andersen
On Tue, Jan 23, 2001 at 12:27:36AM +0100, Rasmus Andersen wrote: Hi again. I completely messed up a large part of the patches posted yesterday due to lack of sleep and being clinically braindead (the compile test was run in the wrong tree...). So I'll be posting some new patches that actually

[PATCH] drivers/scsi/qlogicfas.c: check_region - request_region + cleanup (241p9)

2001-01-23 Thread Rasmus Andersen
Hi. (I have not been able to find a probable maintainer for this code.) The follow patch makes drivers/scsi/qlogicfas.c use the return code from request_region instead of a call to check_region. It also adds a missing free_irq on an error path and makes us check the return from scsi_register.

[PATCH] make drivers/scsi/qlogicfc.c check_region - request_region + cleanup (241p9)

2001-01-23 Thread Rasmus Andersen
Hi. (I am guessing you as the maintainer of this code. If you are not, I apologize for your inconvenience.) The following patch makes drivers/scsi/qlogicfc.c check the return code of scsi_register, adds a missing pci64_free_consistent on an error path and makes it use request_region

[PATCH] drivers/scsi/qlogicisp.c: return code from scsi_register (241p9)

2001-01-23 Thread Rasmus Andersen
Hi. The following patch adds a check for scsi_register's return code to drivers/scsi/qlogicisp.c. It applies cleanly against ac10 and 241p9. Comments? --- linux-ac10-clean/drivers/scsi/qlogicisp.c Sat Jan 20 15:17:13 2001 +++ linux-ac10/drivers/scsi/qlogicisp.c Sat Jan 20 23:05:47 2001 @@

Re: [PATCH] general cleanup of drivers/scsi/NCR53c406a.c (241p9)

2001-01-23 Thread Rasmus Andersen
On Tue, Jan 23, 2001 at 12:29:54AM +0100, Rasmus Andersen wrote: (This is another updated patch with the comments from the earlier mail still valid.) --- linux-ac10-clean/drivers/scsi/NCR53c406a.c Mon Sep 18 22:36:24 2000 +++ linux-ac10/drivers/scsi/NCR53c406a.cTue Jan 23 21:09:09

[PATCH] eliminate #ifdef in parport_pc.c by adding empty entry in pci.h (241p10)

2001-01-25 Thread Rasmus Andersen
Hi. The following two patches removes an #ifdef CONFIG_PCI in drivers/parport/parport_pc.c by adding a nop definition of pci_match_device to include/linux/pci.h. It incidentially also removes a compiler warning when CONFIG_PCI is not set. Applies against ac11 and 241p10 (the latter with a bit

[uPATCH][Probably fucked up] arch/i386/kernel/io_apic.c: missing extern? (241p10)

2001-01-26 Thread Rasmus Andersen
Hi. In arch/i386/kernel we declare nr_ioapics in both io_apic.c and mpparse.c. I guess that one of them should be an 'extern' declaration? In the patch below I have guessed that it is io_apic.c that is missing it since (AFAICS) never assign to nr_ioapic in this file. But I am in way over my

Re: [uPATCH][Probably fucked up] arch/i386/kernel/io_apic.c: missing extern? (241p10)

2001-01-26 Thread Rasmus Andersen
On Fri, Jan 26, 2001 at 10:13:35PM +0100, Rasmus Andersen wrote: Hi. [...] But I am in way over my head here so please be gentle when you point out my mistake. Already someone did :) I was too sloppy in checking my facts; it is only -ac11 that has the 'int nr_ioapics;' in mpparse.c

[PATCH] make drivers/scsi/sym53c8xx.c check request_region's return code (241p9)]

2001-01-25 Thread Rasmus Andersen
Hi. I apparently forgot to cc the lists on this one. Replies should be cc'ed to [EMAIL PROTECTED] also. Thanks. - Forwarded message from Rasmus Andersen [EMAIL PROTECTED] - Date: Tue, 23 Jan 2001 23:37:14 +0100 From: Rasmus Andersen [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject

Re: [ANNOUNCE] Kernel Janitor's TODO list

2001-01-29 Thread Rasmus Andersen
On Mon, Jan 29, 2001 at 02:51:18PM -0600, Timur Tabi wrote: ** Reply to message from [EMAIL PROTECTED] on Mon, 29 Jan 2001 20:44:55 + (GMT) make pdfdocs [ttabi@one DocBook]$ make pdfdocs Makefile:140: /Rules.make: No such file or directory You have to be in the top level

[PATCH] guard mm-rss with page_table_lock (241p11)

2001-01-29 Thread Rasmus Andersen
Hi. This patch tries to fix the potential rss accounting race where we fiddle with mm-rss without holding the page_table_lock. In addition to the places this patch touches there are some places in fs/ where mm-rss is touched. But I am not sure of the finer points of this code, so perhaps

Re: [PATCH] guard mm-rss with page_table_lock (241p11)

2001-01-29 Thread Rasmus Andersen
On Mon, Jan 29, 2001 at 07:30:01PM -0200, Rik van Riel wrote: On Mon, 29 Jan 2001, Rasmus Andersen wrote: Please comment. Or else I will continue to sumbit it :) The following will hang the kernel on SMP, since you're already holding the spinlock here. Try compiling with CONFIG_SMP

[PATCH] drivers/scsi/BusLogic.c: No resource probing before pci_enable_device (241p11)

2001-01-29 Thread Rasmus Andersen
Hi. The following patch makes drivers/scsi/BusLogic.c wait with probing pdev-irq and pdev-resource[] until we call pci_enable_device. This is recommended due to hot-plug considerations (according to Jeff Garzik). It applies against ac12 and 241p11. Comments? ---

[PATCH] drivers/scsi/dmx3191d.c: small cleanup patch (241p11)

2001-01-29 Thread Rasmus Andersen
(Forgot l-k. Please cc [EMAIL PROTECTED] on replies to this mail.) - Forwarded message from Rasmus Andersen [EMAIL PROTECTED] - Hi. The following patch makes drivers/scsi/dmx3191d.c call pci_enable_device before probing resources and replaces a check_region+request_region

[PATCH] make sym53c8xx.c and ncr53c8xx.c call pci_enable_device (241p11)

2001-01-29 Thread Rasmus Andersen
Hi. The following patch makes drivers/scsi/sym53c8xx.c and (by way of sym53c8xx_comm.h::sym53c8xx__detect) ncr53c8xx.c do a pci_enable_device after finding a device. It applies against ac12 and 241p11. Comments? --- linux-ac11-clean/drivers/scsi/sym53c8xx.c Mon Jan 1 19:23:21 2001 +++

[uPATCH] make drivers/scsi/eata.c call pci_enable_device before rs. probing (241p11)

2001-01-29 Thread Rasmus Andersen
Hi. The following patch makes drivers/scsi/eata.c wait with probing pci resources until we have called pci_enable_device. This is recommended due to hot-plug considerations (according to Jeff Garzik). It applies against ac12 and 241p11. Comments? --- linux-ac12-clean/drivers/scsi/eata.c

[PATCH] make drivers/scsi/seagate.c use ioremap instead of isa_{read,write} (241p11)

2001-01-29 Thread Rasmus Andersen
Hi. (I have not been able to find a probable current maintainer for this code.) The following patch makes drivers/scsi/seagate.c use ioremap instead of isa_{read, write}. It applies against ac12 and 241p11. Please comment, esp. on the size of the remappings. ---

Re: [PATCH] guard mm-rss with page_table_lock (241p11)

2001-01-30 Thread Rasmus Andersen
On Tue, Jan 30, 2001 at 08:18:56AM +, David Howells wrote: ... + spin_lock(mm-page_table_lock); mm-rss++; + spin_unlock(mm-page_table_lock); ... Would it not be better to use some sort of atomic add/subtract/clear operation rather than a spinlock? (Which would also give

Re: [NEW SCSI DRIVER] for 53c700 chip and NCR_D700 card against 2.4.4

2001-05-14 Thread Rasmus Andersen
Disclaimer: I know nothing of this device/hw, the scsi protocol or anything remotely applicable the functioning of this driver. The stuff below is just nit-picking and PITA-ing :) Pro-active kernel janitoring, if you like. On Sat, May 12, 2001 at 11:43:04AM -0500, James Bottomley wrote: [...]

[PATCH] make drivers/block/ps2esdi.c compile (2.4.4)

2001-05-20 Thread Rasmus Andersen
Hi. The following trivial patch against 2.4.4(-ac11) makes ps2esdi compile. --- linux-244-ac10-clean/drivers/block/ps2esdi.cSat May 19 21:06:29 2001 +++ linux-244-ac10/drivers/block/ps2esdi.c Sun May 20 14:47:04 2001 @@ -953,10 +953,10 @@ break; }

Re: [PATCH] drivers/net/others

2001-05-24 Thread Rasmus Andersen
On Thu, May 24, 2001 at 09:00:20AM -0700, Jonathan Lundell wrote: [...] Fine. But: At 3:02 AM +0200 2001-05-24, Andrzej Krzysztofowicz wrote: -printk(version); +#ifdef MODULE +printk(s, version); printed_version = 1; +#endif /* MODULE */ ...is playing it just a little

[PATCH] __init - __initdata for drivers/ide/feature.c (244-ac16)

2001-05-25 Thread Rasmus Andersen
Hi. The following patch changes an __init to an __initdata. Applies against 2.4.4-ac16. --- linux-244-ac16-clean/arch/ppc/kernel/feature.c Sat May 19 21:06:18 2001+++ linux-244-ac16/arch/ppc/kernel/feature.cMon May 21 00:04:35 2001 @@ -267,7 +267,7 @@ static struct board_features_t

[PATCH] check kmalloc return in ide-cd.c (244-ac16)

2001-05-25 Thread Rasmus Andersen
Hi. This patch adds a check for the return value from kmalloc in ide_cdrom_open. Applies against ac16. --- linux-244-ac16-clean/drivers/ide/ide-cd.c Fri May 25 21:11:08 2001 +++ linux-244-ac16/drivers/ide/ide-cd.c Fri May 25 21:30:20 2001 @@ -2869,12 +2869,12 @@ int ide_cdrom_open (struct

[PATCH] kmalloc checks for drivers/ide/ide-probe.c (244ac16)

2001-05-25 Thread Rasmus Andersen
Hi. The following patch adds a number of checks for kmalloc returns to drivers/ide/ide-probe.c. It applies against ac16. One comment: This patch adds 'drive-present = 0' to the code path for the EXABYTE case. I could not discern if this was a shortcoming of the original code or not. Please

[PATCH] __idetape_kmalloc_stage return code check in ide-tape.c (244-ac16)

2001-05-25 Thread Rasmus Andersen
Hi. This trivial patch adds a kmalloc check to ide-tape.c:: idetape_onstream_read_back_buffer as per the Stanford team's report way back. It applies against 244ac16. Reading the code I was not sure if it was OK to just return or more should be done. Please sanity check this. ---

Re: [PATCH] kmalloc checks for drivers/ide/ide-probe.c (244ac16)

2001-05-25 Thread Rasmus Andersen
On Fri, May 25, 2001 at 01:47:52PM -0700, Andre Hedrick wrote: Not valid because the jump to that part of the code is protected. If a polling response for a valid status and no timeout, is detected then it attempts to the command for real only after success or a test. Otherwise it would

[PATCH] Add missing spin_unlock_irq to ide.c (244ac16)

2001-05-25 Thread Rasmus Andersen
(I forgot to cc l-k on this one when it went to andre.) Hi. This patch adds a spin_unlock_irqsave to ide_spin_wait_hwgroup as reported by the Stanford team way back. It applies against 244ac16. --- linux-244-ac16-clean/drivers/ide/ide.c Fri May 25 21:11:08 2001 +++

[PATCH] __init - __initdata in drivers/video/matrox/matroxfb_base.c (244ac16)

2001-05-25 Thread Rasmus Andersen
Hi. The following patch changes an __init to __initdata. Applies against 2.4.4-ac11. --- linux-244-ac11-clean/drivers/video/matrox/matroxfb_base.c Sat May 19 20:58:43 2001 +++ linux-244-ac11/drivers/video/matrox/matroxfb_base.c Sun May 20 23:55:24 2001 @@ -2483,7 +2483,7 @@ return

Re: [PATCH] Add missing spin_unlock_irq to ide.c (244ac16)

2001-05-25 Thread Rasmus Andersen
On Fri, May 25, 2001 at 11:11:23PM +0200, Jens Axboe wrote: [...] This isn't right. Granted the locking isn't straight forward here, but take a look at ide_write_setting - ide_spin_wait_hwgroup and the latters return value. Yes, Andre set me straight here. My apologies for being lazy and

[PATCH] comx-hw-mixcom.c interrupt flag cleanup (244-ac18)

2001-05-26 Thread Rasmus Andersen
(Forgot l-k when sending this off to [EMAIL PROTECTED] :/) Hi. The following patch tries to eliminate the interrupt flag bugs identified by the stanford team a while back in drivers/net/wan/ comx-hw-mixcom.c. It moves request_region and request_irq outside the cli()/restore_flags() pair as they

[PATCH] fix for buggy variable reuse in riotable.c (244ac18)

2001-05-27 Thread Rasmus Andersen
Forgot l-k when sending this off... - Forwarded message from Rasmus Andersen [EMAIL PROTECTED] - Hi. The following patch fixes a buggy variable reuse i drivers/char/ rio/riotable.c (244-ac18) as reported by the stanford team way back. --- linux-244-ac18-clean/drivers/char/rio

[PATCH] missing rio_spin_unlock_irqrestore in rioroute.c (244ac18)

2001-05-27 Thread Rasmus Andersen
sigh Forgot l-k when sending this off.. - Forwarded message from Rasmus Andersen [EMAIL PROTECTED] - Hi. The following patch fixes a missing rio_spin_unlock_irqrestore in drivers/char/rio/rioroute.c as per the stanford team's report a way back. It applies against 244ac18. --- linux

[PATCH] Add missing restore_flags to sm_wss.c (244-ac18)

2001-05-27 Thread Rasmus Andersen
Hi. The following patch adds a missing restore_flags as per the stanford team's report way back. Applies against 244ac18. --- linux-244-ac18-clean/drivers/net/hamradio/soundmodem/sm_wss.c Wed Jul 19 01:55:19 2000 +++ linux-244-ac18/drivers/net/hamradio/soundmodem/sm_wss.c Sun May 27

[PATCH] fix interrupt flag bugs in irport.c (2.4.4-ac18)

2001-05-26 Thread Rasmus Andersen
Hi. The following patch tries to correct the interrupt bugs found by the stanford team a long time ago in drivers/net/irda/irport.c. Applies against 2.4.4-ac18. --- linux-244-ac18-clean/drivers/net/irda/irport.c Sat May 19 20:59:17 2001 +++ linux-244-ac18/drivers/net/irda/irport.cSat

[PATCH] remove unnecessary zero initializations from aironet4500_proc.c (245ac1)

2001-05-28 Thread Rasmus Andersen
(Forgot l-k again... :) - Forwarded message from Rasmus Andersen [EMAIL PROTECTED] - Hi. The following patch removes two superfluous initializations from aironet4500_proc.c, making the .o ~12K smaller in size. It applies against 245ac1 and was discovered by Adam Ritcher some time ago

[PATCH] make kmalloc error return unconditional in hysdn_net.c (245ac1)

2001-05-28 Thread Rasmus Andersen
Hi. The patch below fixes what I believe is a bug in hysdn_net.c. I cannot see how we can proceed under _any_ circumstances after the kmalloc fails. Applies against 245ac1. --- linux-245-ac1-clean/drivers/isdn/hysdn/hysdn_net.c Sun May 27 22:15:22 2001 +++

[PATCH] add restore_flags to error path in irttp.c (245ac1)

2001-05-27 Thread Rasmus Andersen
Hi. The following patch makes irttp_read_proc restore_flags() in error cases too. Applies against 245ac1. --- linux-245-ac1-clean/net/irda/irttp.cSun May 27 22:15:34 2001 +++ linux-245-ac1/net/irda/irttp.c Sun May 27 22:37:59 2001 @@ -1598,7 +1598,7 @@ self = (struct

[PATCH] Fix interrupt flag bug(s) in irtty.c (244-ac18)

2001-05-27 Thread Rasmus Andersen
Hi. The following patch fixes an interrupt flag bug in irtty.c as per the stanford team's report way back. Applies against 224-ac18. --- linux-244-ac18-clean/drivers/net/irda/irtty.c Sat May 19 20:59:17 2001 +++ linux-244-ac18/drivers/net/irda/irtty.c Sun May 27 21:56:14 2001 @@

[patchlet] Minor compile warnings from net/appletalk/aarp.c (240t8p1)

2000-08-31 Thread Rasmus Andersen
Hi. When I compile net/appletalk/aarp.c without procfs support I get the following warning: net/appletalk/aarp.c:1089: warning: `aarp_get_info' defined but not used The following patch fixes this: --- linux-240test7-pre2-clean/net/appletalk/aarp.c Mon Jul 31 21:05:04 2000 +++

[patchlet] Compile warning in drivers/media/video/bttv-cards.c (240t8p1)

2000-08-31 Thread Rasmus Andersen
Hi. When I compile drivers/media/video/bttv-cards.c I get the following warnings: bttv-cards.c:781: warning: `init_tea5757' defined but not used Since the call to init_tea5757() is languishing inside an #if 0 construct the following patch does the same to the function declarations. Please

[patch] Returning value from void function (kernel/signal.c) (240t8p1)

2000-08-31 Thread Rasmus Andersen
Hi. I guess the threads stuff introduced this minor compile warning: signal.c: In function `handle_stop_signal': signal.c:367: warning: `return' with a value, in function returning void The following small patch fixes this: --- linux-240test8-pre1/kernel/signal.c Tue Aug 29 22:20:51 2000 +++

[patchlet] current-state=XX - __set_task_state in mm/highmem.c

2000-08-31 Thread Rasmus Andersen
Hi. In mm/highmem.c:map_new_virtual (in a 2.4.0-t8p1 kernel) we set current's state directly. I believe that using __set_task_state is nicer. The following patch acts out this belief :) Please comment. --- linux-240test8-pre1/mm/highmem.cThu Aug 24 09:43:36 2000 +++ linux/mm/highmem.c Thu

[patch] Updated affs to use new mark_buffers_dirty interface

2000-09-04 Thread Rasmus Andersen
Hi. (I hope you are the code maintainer for affs. Your name is in the affs files.) I have changed the interface to mark_buffer_dirty (as per Tigran Aivazian's suggestion). This impacts affs as per the following patch. diff -u --recursive -X misc/dontdiff linux-240test8-pre2/fs/affs/amigaffs.c

[patch] Updated bfs to use new mark_buffers_dirty interface

2000-09-04 Thread Rasmus Andersen
Hi. I have changed the interface to mark_buffer_dirty (as per your suggestion to Arnaldo Carvalho de Melo). This impacts bfs as per the following patch. diff -u --recursive -X misc/dontdiff linux-240test8-pre2/fs/bfs/dir.c linux/fs/bfs/dir.c --- linux-240test8-pre2/fs/bfs/dir.cThu Aug 24

[patch] Updated hpfs to use new mark_buffers_dirty interface

2000-09-04 Thread Rasmus Andersen
Hi. I have changed the interface to mark_buffer_dirty (as per Tigran Aivazian's suggestion). This impacts hpfs as per the following patch. diff -u --recursive -X misc/dontdiff linux-240test8-pre2/fs/hpfs/anode.c linux/fs/hpfs/anode.c --- linux-240test8-pre2/fs/hpfs/anode.c Tue Oct 19 22:52:52

[patch] All the fs patches resulting from updating mark_buffer_dirty

2000-09-04 Thread Rasmus Andersen
Hi. I have changed the interface to mark_buffer_dirty (as per Tigran Aivazian's suggestion). This impacts a lot of places in the kernel (trivially), noticeably the file systems. The URL below points a big patch for all these changes. (I have been advised against the fine granularity of the

Oops with 2.4.0-t8p6

2000-09-07 Thread Rasmus Andersen
Hi. I have just gotten hold of an old machine previously running Win98. When I tried to install RH 6.2 on it I got an oops during boot from the floppy. I replaced the kernel on the floppy with a 2.4.0-test8-pre6 kernel and got an oops again right after the line 'POSIX conformance testing by

Oops on boot with both 2.2.17 and 2.4.0t8p6

2000-09-08 Thread Rasmus Andersen
Hi. I just got hold of an old machine (P75, 32MB RAM). On trying to install RH 6.2 on it, I got an oops after loading the kernel from the boot floppy. I then tried to boot a 2.4.0-test8-pre6 (made with make bzdisk), but got an oops. The same with 2.2.17. Any help would be appreciated. Oops

Re: Oops on boot with both 2.2.17 and 2.4.0t8p6

2000-09-09 Thread Rasmus Andersen
On 0, Keith Owens [EMAIL PROTECTED] wrote: On Fri, 8 Sep 2000 14:48:51 +0200, Rasmus Andersen [EMAIL PROTECTED] wrote: I just got hold of an old machine (P75, 32MB RAM). On trying to install RH 6.2 on it, I got an oops after loading the kernel from the boot floppy. I then tried to boot

Re: Oops on boot with both 2.2.17 and 2.4.0t8p6

2000-09-10 Thread Rasmus Andersen
Hi. Interesting turn in my efforts to make linux boot on my newly acquired old computer: Mike Galbraith offered me IKD for 2.4.0t8, which I accepted and tried (I said yes to all the IKD config options). This made 2.4.0t8 boot and get as far as complaining about bad root fs (which is correct for

[patchlet] minor mm/slab.c cleanup (2.4.0-t8)

2000-09-10 Thread Rasmus Andersen
Hi. This is against 2.4.0-test8. It removes an unnecessary check (done earlier) for a slab destructor (unless I am missing some black magic) and substitutes __set_current_state for current-state=XXX. --- linux-240test8-clean/mm/slab.c Thu Aug 24 09:43:36 2000 +++ linux/mm/slab.c Sun

Re: Oops on boot with both 2.2.17 and 2.4.0t8p6

2000-09-11 Thread Rasmus Andersen
On Mon, Sep 11, 2000 at 12:40:25AM +0200, Mike Galbraith wrote: On Sun, 10 Sep 2000, Rasmus Andersen wrote: [...] So adding IKD to 2.4.0t8 made the initial oops go away/be hidden. The odd colours/chars are the print EIP feature in action. You should almost never say yes to all config

[patchlet] Minor cleanup in mm/swapfile.c (2.4.0t8)

2000-09-13 Thread Rasmus Andersen
Hi. This patch does minor and strightforward cleanup in mm/swapfile.c. --- linux-240test8-clean/mm/swapfile.c Thu Aug 10 16:29:54 2000 +++ linux/mm/swapfile.c Wed Sep 13 20:40:15 2000 @@ -101,7 +101,7 @@ while (1) { p = swap_info[type]; - if ((p-flags

Re: [patchlet] Minor cleanup in mm/swapfile.c (2.4.0t8)

2000-09-13 Thread Rasmus Andersen
On Wed, Sep 13, 2000 at 08:52:54PM +0200, Rasmus Andersen wrote: Hi. This patch does minor and strightforward cleanup in mm/swapfile.c. I have been corrected on this and retract it. Sorry to bother you all. -- Regards, Rasmus([EMAIL PROTECTED]) I am two fools, I know, for loving

Re: Oops on boot with both 2.2.17 and 2.4.0t8p6

2000-09-18 Thread Rasmus Andersen
On Sun, Sep 17, 2000 at 10:53:55PM -0300, Marcelo Tosatti wrote: AFAIK most distros use CONFIG_PCI_GOANY, which causes the kernel to try to detect the PCI devices directly, and in case this fails, it tries to detect via BIOS. I thought so too from reading the help regarding this option, but

Re: [patchlet] Update help for COMX

2000-09-18 Thread Rasmus Andersen
On Mon, Sep 18, 2000 at 08:47:55PM +0100, Alan Cox wrote: The drivers/net/wan/comx.c #errors if it is compiled in a kernel without procfs support. The following patch updates the documentation to state this. I have cc'ed the maintainer so he can comment. It does really need procfs, but

[PATCH] PCI detection in 2.2.x and 2.4.0

2000-09-30 Thread Rasmus Andersen
Hi. I recently had a problem with linux 2.2.x and 2.4.0 oopsing early in the boot process on a old pentium I had gotten hold of. printk investigation showed the problem to be in the PCI detection code, specifically the part where linux tries to go through the BIOS to get the PCI settings.

[PATCH] fs/Makefile error in test9pre8 (dquot.o left behind)

2000-10-02 Thread Rasmus Andersen
Hi. When I compile a test9pre8 kernel with quota support I get a lot of link errors regarding quota stuff. The patch below fixes this by correcting what seems to be a mailer/mime error: --- linux-240test9-pre8-clean/fs/Makefile Mon Oct 2 21:07:54 2000 +++ linux/fs/Makefile Mon Oct 2

Re: 2.4.0-test9 i810_rng compilation failure

2000-10-03 Thread Rasmus Andersen
On Tue, Oct 03, 2000 at 08:20:12PM +, Graham Murray wrote: i810_rng.c does not compile when not a module. It fails at line 384, which looks as though it should only be included when being built as a module. This patch fixes this. Could the maintainer comment? Is there a better way to do

ixj.c compile error in kernel 240-test9

2000-10-03 Thread Rasmus Andersen
Hi. When I compile drivers/telephony/ixj.c from the 2.4.0-test9 kernel I get the following: make[3]: Entering directory `/home/rasmus/kernel/linux/drivers/telephony' gcc -D__KERNEL__ -I/home/rasmus/kernel/linux/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -pipe -march=i686

[PATCH] PCI detection in 2.2.x and 2.4.0

2000-10-06 Thread Rasmus Andersen
Hi. (This mail is a repeat from an earlier l-k mail.) I recently had a problem with linux 2.2.x and 2.4.0 oopsing early in the boot process on a old pentium I had gotten hold of. printk investigation showed the problem to be in the PCI detection code, specifically the part where linux tries to

Re: [PATCH] PCI detection in 2.2.x and 2.4.0

2000-10-06 Thread Rasmus Andersen
Some years ago, the PCI routines have really used this strategy (and the obsolete help text reflects this situation), but unfortunately, there exist machines where the direct access detection gives bogus results, so it's much better to ask the BIOS first. Also, it's conceptually cleaner to

[PATCH] Removing __initfunc from drivers/video/sun3fb.c (240-test9)

2000-10-06 Thread Rasmus Andersen
Hi. (I hope that you are the current maintainer for the Sun3 framebuffer. If not, please redirect me if you are able to.) It is my understanding that __initfunc is deprecate in 2.4.0. So this patch exchanges __initfunc with __init. --- linux-240-test9-clean/drivers/video/sun3fb.cMon

[PATCH] x86 PCI detection and documentation

2000-10-20 Thread Rasmus Andersen
(This is a repost of a mail I made just before vger went offline. My apoligies to Linus and Martin Mares for mailing this twice to them, but any comments should be received by all.) Hi. (This has mostly been discussed in an earlier thread. This is a follow-up with some extra added.) There

  1   2   3   4   >