Re: [PATCH v3 4/4] x86, mpx: extend siginfo structure to include bound violation information

2014-01-25 Thread Ren Qiaowei
On 01/26/2014 12:22 PM, David Rientjes wrote: On Sun, 26 Jan 2014, Qiaowei Ren wrote: This patch adds new fields about bound violation into siginfo structure. si_lower and si_upper are respectively lower bound and upper bound when bound violation is caused. These fields will be set in #BR

Re: [PATCH v3 1/4] x86, mpx: add documentation on Intel MPX

2014-01-25 Thread Ren Qiaowei
On 01/26/2014 11:06 AM, Randy Dunlap wrote: On 01/26/2014 01:08 AM, Qiaowei Ren wrote: This patch adds the Documentation/x86/intel_mpx.txt file with some information about Intel MPX. Signed-off-by: Qiaowei Ren --- Documentation/x86/intel_mpx.txt | 226

Re: [PATCH v3 1/4] x86, mpx: add documentation on Intel MPX

2014-01-25 Thread Ren Qiaowei
On 01/26/2014 11:06 AM, Randy Dunlap wrote: On 01/26/2014 01:08 AM, Qiaowei Ren wrote: This patch adds the Documentation/x86/intel_mpx.txt file with some information about Intel MPX. Signed-off-by: Qiaowei Ren qiaowei@intel.com --- Documentation/x86/intel_mpx.txt | 226

Re: [PATCH v3 4/4] x86, mpx: extend siginfo structure to include bound violation information

2014-01-25 Thread Ren Qiaowei
exception handler by decoding the user instruction and constructing the faulting pointer. A userspace application can get violation address, lower bound and upper bound for bound violation from this new siginfo structure. Signed-off-by: Qiaowei Ren qiaowei@intel.com Same 32-bit warnings I

Re: [PATCH v2 0/4] Intel MPX support

2014-01-22 Thread Ren Qiaowei
On 01/22/2014 08:30 PM, Ingo Molnar wrote: * Ren, Qiaowei wrote: -Original Message- From: Ingo Molnar [mailto:mingo.kernel@gmail.com] On Behalf Of Ingo Molnar Sent: Wednesday, January 22, 2014 7:53 PM To: Ren, Qiaowei Cc: H. Peter Anvin; Thomas Gleixner; Ingo Molnar; x

RE: [PATCH v2 0/4] Intel MPX support

2014-01-22 Thread Ren, Qiaowei
> -Original Message- > From: Ingo Molnar [mailto:mingo.kernel@gmail.com] On Behalf Of Ingo > Molnar > Sent: Wednesday, January 22, 2014 7:53 PM > To: Ren, Qiaowei > Cc: H. Peter Anvin; Thomas Gleixner; Ingo Molnar; x...@kernel.org; > linux-kernel@vger.kerne

RE: [PATCH v2 0/4] Intel MPX support

2014-01-22 Thread Ren, Qiaowei
> -Original Message- > From: David Rientjes [mailto:rient...@google.com] > Sent: Wednesday, January 22, 2014 4:01 PM > To: Ren, Qiaowei > Cc: H. Peter Anvin; Thomas Gleixner; Ingo Molnar; x...@kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2 0

RE: [PATCH v2 0/4] Intel MPX support

2014-01-22 Thread Ren, Qiaowei
-Original Message- From: David Rientjes [mailto:rient...@google.com] Sent: Wednesday, January 22, 2014 4:01 PM To: Ren, Qiaowei Cc: H. Peter Anvin; Thomas Gleixner; Ingo Molnar; x...@kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/4] Intel MPX support On Wed, 22

RE: [PATCH v2 0/4] Intel MPX support

2014-01-22 Thread Ren, Qiaowei
-Original Message- From: Ingo Molnar [mailto:mingo.kernel@gmail.com] On Behalf Of Ingo Molnar Sent: Wednesday, January 22, 2014 7:53 PM To: Ren, Qiaowei Cc: H. Peter Anvin; Thomas Gleixner; Ingo Molnar; x...@kernel.org; linux-kernel@vger.kernel.org; Peter Zijlstra Subject: Re

Re: [PATCH v2 0/4] Intel MPX support

2014-01-22 Thread Ren Qiaowei
On 01/22/2014 08:30 PM, Ingo Molnar wrote: * Ren, Qiaowei qiaowei@intel.com wrote: -Original Message- From: Ingo Molnar [mailto:mingo.kernel@gmail.com] On Behalf Of Ingo Molnar Sent: Wednesday, January 22, 2014 7:53 PM To: Ren, Qiaowei Cc: H. Peter Anvin; Thomas Gleixner

RE: [PATCH 2/5] x86, mpx: hook #BR exception handler to allocate bound tables

2014-01-19 Thread Ren, Qiaowei
> -Original Message- > From: Steven Rostedt [mailto:rost...@goodmis.org] > Sent: Saturday, January 18, 2014 1:15 AM > To: H. Peter Anvin > Cc: Borislav Petkov; Ren, Qiaowei; Thomas Gleixner; Ingo Molnar; > x...@kernel.org; linux-kernel@vger.kernel.org > Subject: Re:

RE: [PATCH 2/5] x86, mpx: hook #BR exception handler to allocate bound tables

2014-01-19 Thread Ren, Qiaowei
-Original Message- From: Steven Rostedt [mailto:rost...@goodmis.org] Sent: Saturday, January 18, 2014 1:15 AM To: H. Peter Anvin Cc: Borislav Petkov; Ren, Qiaowei; Thomas Gleixner; Ingo Molnar; x...@kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] x86, mpx: hook #BR

RE: [PATCH 5/5] x86, mpx: extend siginfo structure to include bound violation information

2014-01-17 Thread Ren, Qiaowei
> -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Monday, January 13, 2014 6:43 PM > To: Ren, Qiaowei > Cc: H. Peter Anvin; Thomas Gleixner; Ingo Molnar; x...@kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH 5/5] x86, mpx: ext

RE: [PATCH 2/5] x86, mpx: hook #BR exception handler to allocate bound tables

2014-01-17 Thread Ren, Qiaowei
> -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Monday, January 13, 2014 6:38 PM > To: Ren, Qiaowei > Cc: H. Peter Anvin; Thomas Gleixner; Ingo Molnar; x...@kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH 2/5] x86, mp

RE: [PATCH 2/5] x86, mpx: hook #BR exception handler to allocate bound tables

2014-01-17 Thread Ren, Qiaowei
-Original Message- From: Borislav Petkov [mailto:b...@alien8.de] Sent: Monday, January 13, 2014 6:38 PM To: Ren, Qiaowei Cc: H. Peter Anvin; Thomas Gleixner; Ingo Molnar; x...@kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] x86, mpx: hook #BR exception handler

RE: [PATCH 5/5] x86, mpx: extend siginfo structure to include bound violation information

2014-01-17 Thread Ren, Qiaowei
-Original Message- From: Borislav Petkov [mailto:b...@alien8.de] Sent: Monday, January 13, 2014 6:43 PM To: Ren, Qiaowei Cc: H. Peter Anvin; Thomas Gleixner; Ingo Molnar; x...@kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] x86, mpx: extend siginfo structure

[PATCH 1/1] x86: remove extra space in structure for consistency

2014-01-15 Thread Ren Qiaowei
Remove extra space before x86_max_cores member in struct cpuinfo_x86 for consistency. Signed-off-by: Ren Qiaowei --- arch/x86/include/asm/processor.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h index

[PATCH 1/1] x86: remove extra space in structure for consistency

2014-01-15 Thread Ren Qiaowei
Remove extra space before x86_max_cores member in struct cpuinfo_x86 for consistency. Signed-off-by: Ren Qiaowei qiaowei@intel.com --- arch/x86/include/asm/processor.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm

Re: [PATCH 5/5] x86, mpx: extend siginfo structure to include bound violation information

2014-01-13 Thread Ren Qiaowei
On 01/13/2014 11:09 AM, Ren Qiaowei wrote: On 01/13/2014 01:03 AM, Borislav Petkov wrote: On Sun, Jan 12, 2014 at 08:49:21AM -0800, H. Peter Anvin wrote: I saw a previous version of the code that did that, and it really didn't work out well -- it ended up being more complex and slower. I

Re: [PATCH 5/5] x86, mpx: extend siginfo structure to include bound violation information

2014-01-13 Thread Ren Qiaowei
On 01/13/2014 11:09 AM, Ren Qiaowei wrote: On 01/13/2014 01:03 AM, Borislav Petkov wrote: On Sun, Jan 12, 2014 at 08:49:21AM -0800, H. Peter Anvin wrote: I saw a previous version of the code that did that, and it really didn't work out well -- it ended up being more complex and slower. I

Re: [PATCH 2/5] x86, mpx: hook #BR exception handler to allocate bound tables

2014-01-12 Thread Ren Qiaowei
On 01/12/2014 05:20 PM, Borislav Petkov wrote: On Sun, Jan 12, 2014 at 05:20:00PM +0800, Qiaowei Ren wrote: +static bool allocate_bt(unsigned long bd_entry) +{ + unsigned long bt_size = 1UL << (MPX_L2_BITS+MPX_L2_SHIFT); + unsigned long bt_addr, old_val; + + bt_addr =

Re: [PATCH 5/5] x86, mpx: extend siginfo structure to include bound violation information

2014-01-12 Thread Ren Qiaowei
On 01/13/2014 01:03 AM, Borislav Petkov wrote: On Sun, Jan 12, 2014 at 08:49:21AM -0800, H. Peter Anvin wrote: I saw a previous version of the code that did that, and it really didn't work out well -- it ended up being more complex and slower. I suspected as much. But, we still probably

Re: [PATCH 5/5] x86, mpx: extend siginfo structure to include bound violation information

2014-01-12 Thread Ren Qiaowei
On 01/13/2014 01:03 AM, Borislav Petkov wrote: On Sun, Jan 12, 2014 at 08:49:21AM -0800, H. Peter Anvin wrote: I saw a previous version of the code that did that, and it really didn't work out well -- it ended up being more complex and slower. I suspected as much. But, we still probably

Re: [PATCH 2/5] x86, mpx: hook #BR exception handler to allocate bound tables

2014-01-12 Thread Ren Qiaowei
On 01/12/2014 05:20 PM, Borislav Petkov wrote: On Sun, Jan 12, 2014 at 05:20:00PM +0800, Qiaowei Ren wrote: +static bool allocate_bt(unsigned long bd_entry) +{ + unsigned long bt_size = 1UL (MPX_L2_BITS+MPX_L2_SHIFT); + unsigned long bt_addr, old_val; + + bt_addr =

RE: [PATCH 1/2] x86: add user_atomic_cmpxchg_inatomic at uaccess.h

2013-12-16 Thread Ren, Qiaowei
Qiaowei Ren wrote: > This patch adds user_atomic_cmpxchg_inatomic() to use CMPXCHG instruction > against a user space address. > > This generalizes the already existing futex_atomic_cmpxchg_inatomic() so it > can be used in other contexts. This will be used in the upcoming support for > Intel

RE: [PATCH 1/2] x86: add user_atomic_cmpxchg_inatomic at uaccess.h

2013-12-16 Thread Ren, Qiaowei
Qiaowei Ren wrote: This patch adds user_atomic_cmpxchg_inatomic() to use CMPXCHG instruction against a user space address. This generalizes the already existing futex_atomic_cmpxchg_inatomic() so it can be used in other contexts. This will be used in the upcoming support for Intel MPX

RE: [Qemu-devel] [PATCH v2 3/3] X86, mpx: Intel MPX xstate feature definition

2013-12-06 Thread Ren, Qiaowei
> -Original Message- > From: H. Peter Anvin [mailto:h...@zytor.com] > Sent: Saturday, December 07, 2013 9:07 AM > To: Ren, Qiaowei; Liu, Jinsong; Paolo Bonzini > Cc: k...@vger.kernel.org; x...@kernel.org; Xudong Hao; > qemu-de...@nongnu.org; linux-kernel@vger.kerne

RE: [Qemu-devel] [PATCH v2 3/3] X86, mpx: Intel MPX xstate feature definition

2013-12-06 Thread Ren, Qiaowei
> -Original Message- > From: Liu, Jinsong > Sent: Saturday, December 07, 2013 6:13 AM > To: H. Peter Anvin; Paolo Bonzini; Ren, Qiaowei > Cc: k...@vger.kernel.org; x...@kernel.org; Xudong Hao; > qemu-de...@nongnu.org; linux-kernel@vger.kernel.org; Ingo Molnar; Thomas &g

RE: [PATCH 1/3] x86, mpx: add documentation on Intel MPX

2013-12-06 Thread Ren, Qiaowei
> -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Saturday, December 07, 2013 12:06 AM > To: Ren, Qiaowei > Cc: Paolo Bonzini; H. Peter Anvin; Ingo Molnar; Thomas Gleixner; > x...@kernel.org; linux-kernel@vger.kernel.org; qemu-de.

RE: [PATCH 3/3] X86, mpx: Intel MPX xstate feature definition

2013-12-06 Thread Ren, Qiaowei
> -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Friday, December 06, 2013 9:47 PM > To: Ren, Qiaowei > Cc: Paolo Bonzini; H. Peter Anvin; Ingo Molnar; Thomas Gleixner; > x...@kernel.org; linux-kernel@vger.kernel.org; qemu-de.

RE: [PATCH 1/3] x86, mpx: add documentation on Intel MPX

2013-12-06 Thread Ren, Qiaowei
> -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Friday, December 06, 2013 9:27 PM > To: Ren, Qiaowei > Cc: Paolo Bonzini; H. Peter Anvin; Ingo Molnar; Thomas Gleixner; > x...@kernel.org; linux-kernel@vger.kernel.org; qemu-de.

RE: [PATCH 1/3] x86, mpx: add documentation on Intel MPX

2013-12-06 Thread Ren, Qiaowei
-Original Message- From: Borislav Petkov [mailto:b...@alien8.de] Sent: Friday, December 06, 2013 9:27 PM To: Ren, Qiaowei Cc: Paolo Bonzini; H. Peter Anvin; Ingo Molnar; Thomas Gleixner; x...@kernel.org; linux-kernel@vger.kernel.org; qemu-de...@nongnu.org; k...@vger.kernel.org

RE: [PATCH 3/3] X86, mpx: Intel MPX xstate feature definition

2013-12-06 Thread Ren, Qiaowei
-Original Message- From: Borislav Petkov [mailto:b...@alien8.de] Sent: Friday, December 06, 2013 9:47 PM To: Ren, Qiaowei Cc: Paolo Bonzini; H. Peter Anvin; Ingo Molnar; Thomas Gleixner; x...@kernel.org; linux-kernel@vger.kernel.org; qemu-de...@nongnu.org; k...@vger.kernel.org

RE: [PATCH 1/3] x86, mpx: add documentation on Intel MPX

2013-12-06 Thread Ren, Qiaowei
-Original Message- From: Borislav Petkov [mailto:b...@alien8.de] Sent: Saturday, December 07, 2013 12:06 AM To: Ren, Qiaowei Cc: Paolo Bonzini; H. Peter Anvin; Ingo Molnar; Thomas Gleixner; x...@kernel.org; linux-kernel@vger.kernel.org; qemu-de...@nongnu.org; k...@vger.kernel.org

RE: [Qemu-devel] [PATCH v2 3/3] X86, mpx: Intel MPX xstate feature definition

2013-12-06 Thread Ren, Qiaowei
-Original Message- From: Liu, Jinsong Sent: Saturday, December 07, 2013 6:13 AM To: H. Peter Anvin; Paolo Bonzini; Ren, Qiaowei Cc: k...@vger.kernel.org; x...@kernel.org; Xudong Hao; qemu-de...@nongnu.org; linux-kernel@vger.kernel.org; Ingo Molnar; Thomas Gleixner Subject: RE

RE: [Qemu-devel] [PATCH v2 3/3] X86, mpx: Intel MPX xstate feature definition

2013-12-06 Thread Ren, Qiaowei
-Original Message- From: H. Peter Anvin [mailto:h...@zytor.com] Sent: Saturday, December 07, 2013 9:07 AM To: Ren, Qiaowei; Liu, Jinsong; Paolo Bonzini Cc: k...@vger.kernel.org; x...@kernel.org; Xudong Hao; qemu-de...@nongnu.org; linux-kernel@vger.kernel.org; Ingo Molnar; Thomas

RE: [PATCH] x86, tboot: iomem fixes

2013-07-20 Thread Ren, Qiaowei
On 2013-07-20, Ingo Molnar wrote: > > * Qiaowei Ren wrote: > >> +#define SINIT_MLE_DATA_VTD_DMAR_OFF 140 > >> /* get addr of DMAR table */ + dmar_tbl_off = readl(heap_ptr + >> SINIT_MLE_DATA_VTD_DMAR_OFF); dmar_tbl = (struct acpi_table_header >> *)(heap_ptr + >> -

RE: [PATCH] x86, tboot: iomem fixes

2013-07-20 Thread Ren, Qiaowei
On 2013-07-20, Ingo Molnar wrote: * Qiaowei Ren qiaowei@intel.com wrote: +#define SINIT_MLE_DATA_VTD_DMAR_OFF 140 /* get addr of DMAR table */ + dmar_tbl_off = readl(heap_ptr + SINIT_MLE_DATA_VTD_DMAR_OFF); dmar_tbl = (struct acpi_table_header *)(heap_ptr

RE: [PATCH v3] x86, tboot: iomem fixes

2013-07-18 Thread Ren, Qiaowei
On 2013-07-18, Ingo Molnar wrote: > > * Qiaowei Ren wrote: > >> Current code doesn't use specific interface to access I/O space. >> So some potential bugs can be caused. We can fix this by using >> specific API. > > This is still very vague. > >> >> Signed-off-by: Qiaowei Ren >> --- >>

RE: [PATCH v3] x86, tboot: iomem fixes

2013-07-18 Thread Ren, Qiaowei
On 2013-07-18, Ingo Molnar wrote: * Qiaowei Ren qiaowei@intel.com wrote: Current code doesn't use specific interface to access I/O space. So some potential bugs can be caused. We can fix this by using specific API. This is still very vague. Signed-off-by: Qiaowei Ren qiaowei

Re: [PATCH] x86, tboot: provide debugfs interfaces to access TXT log

2013-06-23 Thread Ren Qiaowei
On 06/23/2013 04:36 PM, Joe Perches wrote: On Sun, 2013-06-23 at 15:54 +0800, Qiaowei Ren wrote: These logs come from tboot (Trusted Boot, an open source, pre-kernel/VMM module that uses Intel TXT to perform a measured and verified launch of an OS kernel/VMM.). [] diff --git

Re: [PATCH] x86, tboot: provide debugfs interfaces to access TXT log

2013-06-23 Thread Ren Qiaowei
On 06/23/2013 04:36 PM, Joe Perches wrote: On Sun, 2013-06-23 at 15:54 +0800, Qiaowei Ren wrote: These logs come from tboot (Trusted Boot, an open source, pre-kernel/VMM module that uses Intel TXT to perform a measured and verified launch of an OS kernel/VMM.). [] diff --git

RE: [PATCH v2 2/3] driver: provide sysfs interfaces to access TXT config space

2013-05-17 Thread Ren, Qiaowei
On 2013-05-17, Pavel Machek wrote: > On Tue 2013-05-14 01:24:43, Qiaowei Ren wrote: >> +What: /sys/devices/platform/intel_txt/config/STS_raw +Date: >> May 2013 >> +KernelVersion: 3.9 +Contact: "Qiaowei Ren" >> +Description:TXT.STS is the general status

RE: [PATCH v2 2/3] driver: provide sysfs interfaces to access TXT config space

2013-05-17 Thread Ren, Qiaowei
On 2013-05-17, Pavel Machek wrote: On Tue 2013-05-14 01:24:43, Qiaowei Ren wrote: +What: /sys/devices/platform/intel_txt/config/STS_raw +Date: May 2013 +KernelVersion: 3.9 +Contact: Qiaowei Ren qiaowei@intel.com +Description:TXT.STS is the general

RE: [PATCH] x86: add a new SMP bring up way for tboot case

2013-05-15 Thread Ren, Qiaowei
On 2013-05-14, H. Peter Anvin wrote: > On 05/14/2013 02:21 PM, Qiaowei Ren wrote: >> tboot provides a better AP wakeup mechanism based on cpu MWAIT >> feature for OS/VMM. With this mechanism, system will boot faster and >> will NOT require VT to be enabled. But it requires that OS/VMM must >> have

RE: [PATCH] x86: add a new SMP bring up way for tboot case

2013-05-15 Thread Ren, Qiaowei
On 2013-05-14, H. Peter Anvin wrote: On 05/14/2013 02:21 PM, Qiaowei Ren wrote: tboot provides a better AP wakeup mechanism based on cpu MWAIT feature for OS/VMM. With this mechanism, system will boot faster and will NOT require VT to be enabled. But it requires that OS/VMM must have support

RE: [PATCH] x86: add a new SMP bring up way for tboot case

2013-05-14 Thread Ren, Qiaowei
On 2013-05-14, Borislav Petkov wrote: > On Wed, May 15, 2013 at 05:21:25AM +0800, Qiaowei Ren wrote: > > diff --git a/arch/x86/kernel/tboot.c b/arch/x86/kernel/tboot.c index > > f84fe00..0ec1947 100644 > > --- a/arch/x86/kernel/tboot.c > > +++ b/arch/x86/kernel/tboot.c > > @@ -101,6 +101,8 @@ void

RE: [PATCH] x86: add a new SMP bring up way for tboot case

2013-05-14 Thread Ren, Qiaowei
On 2013-05-14, Borislav Petkov wrote: On Wed, May 15, 2013 at 05:21:25AM +0800, Qiaowei Ren wrote: diff --git a/arch/x86/kernel/tboot.c b/arch/x86/kernel/tboot.c index f84fe00..0ec1947 100644 --- a/arch/x86/kernel/tboot.c +++ b/arch/x86/kernel/tboot.c @@ -101,6 +101,8 @@ void __init

RE: [PATCH v2 1/3] driver: add TXT driver in kernel

2013-05-13 Thread Ren, Qiaowei
On 2013-05-14, Matthew Garrett wrote: > On Tue, 2013-05-14 at 01:24 +0800, Qiaowei Ren wrote: > > static int __init txt_sysfs_init(void) > > +{ > > + if (!tboot_enabled()) > > + return -ENODEV; > > If there's a CPU flag that indicates tboot support, you should add a modalias > for >

RE: [PATCH v2 2/3] driver: provide sysfs interfaces to access TXT config space

2013-05-13 Thread Ren, Qiaowei
On 2013-05-14, Matthew Garrett wrote: > On Tue, 2013-05-14 at 01:24 +0800, Qiaowei Ren wrote: > > These interfaces are located > > in /sys/devices/platform/intel_txt/config, > > and including totally 37 files, providing access to Intel TXT > > configuration registers. > > Do you have any example

RE: [PATCH v2 2/3] driver: provide sysfs interfaces to access TXT config space

2013-05-13 Thread Ren, Qiaowei
On 2013-05-14, Matthew Garrett wrote: On Tue, 2013-05-14 at 01:24 +0800, Qiaowei Ren wrote: These interfaces are located in /sys/devices/platform/intel_txt/config, and including totally 37 files, providing access to Intel TXT configuration registers. Do you have any example userspace

RE: [PATCH v2 1/3] driver: add TXT driver in kernel

2013-05-13 Thread Ren, Qiaowei
On 2013-05-14, Matthew Garrett wrote: On Tue, 2013-05-14 at 01:24 +0800, Qiaowei Ren wrote: static int __init txt_sysfs_init(void) +{ + if (!tboot_enabled()) + return -ENODEV; If there's a CPU flag that indicates tboot support, you should add a modalias for it in order

RE: [PATCH 4/4] driver: provide sysfs interfaces to access SMX parameter

2013-05-10 Thread Ren, Qiaowei
On 2013-05-10, Matthew Garrett wrote: > On Fri, 2013-05-10 at 07:05 +0000, Ren, Qiaowei wrote: >> On 2013-05-08, Matthew Garrett wrote: >>> On Tue, 2013-05-07 at 22:55 +0800, Qiaowei Ren wrote: >>> >>>> +What: /sys/devices/platform/inte

RE: [PATCH 4/4] driver: provide sysfs interfaces to access SMX parameter

2013-05-10 Thread Ren, Qiaowei
On 2013-05-08, Matthew Garrett wrote: > On Tue, 2013-05-07 at 22:55 +0800, Qiaowei Ren wrote: > > > +What: /sys/devices/platform/intel_txt/parameter/acm_max_size > > +Date: May 2013 > > +KernelVersion: 3.9 > > +Contact: "Qiaowei Ren" > > +Description: The

RE: [PATCH 4/4] driver: provide sysfs interfaces to access SMX parameter

2013-05-10 Thread Ren, Qiaowei
On 2013-05-08, Matthew Garrett wrote: On Tue, 2013-05-07 at 22:55 +0800, Qiaowei Ren wrote: +What: /sys/devices/platform/intel_txt/parameter/acm_max_size +Date: May 2013 +KernelVersion: 3.9 +Contact: Qiaowei Ren qiaowei@intel.com +Description

RE: [PATCH 4/4] driver: provide sysfs interfaces to access SMX parameter

2013-05-10 Thread Ren, Qiaowei
On 2013-05-10, Matthew Garrett wrote: On Fri, 2013-05-10 at 07:05 +, Ren, Qiaowei wrote: On 2013-05-08, Matthew Garrett wrote: On Tue, 2013-05-07 at 22:55 +0800, Qiaowei Ren wrote: +What: /sys/devices/platform/intel_txt/parameter/acm_max_size +Date: May 2013

RE: [PATCH 1/4] driver: add TXT driver in kernel

2013-05-09 Thread Ren, Qiaowei
On 2013-05-08, Matthew Garrett wrote: > On Tue, 2013-05-07 at 22:55 +0800, Qiaowei Ren wrote: > > > + * This module is expected to be a better tool to access below > > + resources > > Expected to be or is? :) "is" :) > > + * Data is currently found below > > You're adding it to ABI, so it

RE: [PATCH 0/4] Intel TXT driver

2013-05-09 Thread Ren, Qiaowei
On 2013-05-09, Matthew Garrett wrote: > On Thu, 2013-05-09 at 08:19 +0000, Ren, Qiaowei wrote: > > On 2013-05-08, Matthew Garrett wrote: > > > On Tue, 2013-05-07 at 22:55 +0800, Qiaowei Ren wrote: > > >> This module is expected to be a better tool to access below r

RE: [PATCH 3/4] driver: provide sysfs interfaces to access TXT log

2013-05-09 Thread Ren, Qiaowei
On 2013-05-09, Matthew Garrett wrote: > On Thu, 2013-05-09 at 08:05 +0000, Ren, Qiaowei wrote: > > On 2013-05-08, Matthew Garrett wrote: > > > How different are these logs to the TPM measurements exported via > > > securityfs? > > > > These logs come from t

RE: [PATCH 0/4] Intel TXT driver

2013-05-09 Thread Ren, Qiaowei
On 2013-05-08, Matthew Garrett wrote: > On Tue, 2013-05-07 at 22:55 +0800, Qiaowei Ren wrote: >> This module is expected to be a better tool to access below resources >> - TXT config space >> - Tboot log mem >> - SMX parameter > > What's SMX? Safer Mode Extensions (SMX) provide a

RE: [PATCH 3/4] driver: provide sysfs interfaces to access TXT log

2013-05-09 Thread Ren, Qiaowei
On 2013-05-08, Matthew Garrett wrote: > On Tue, 2013-05-07 at 22:55 +0800, Qiaowei Ren wrote: > >> +What: /sys/devices/platform/intel_txt/log/log_header >> +Date: May 2013 >> +KernelVersion: 3.9 > > How different are these logs to the TPM measurements exported

RE: [PATCH 3/4] driver: provide sysfs interfaces to access TXT log

2013-05-09 Thread Ren, Qiaowei
. +What: /sys/devices/platform/intel_txt/log/block_index +Date: May 2013 +KernelVersion: 3.9 +Contact:Qiaowei Ren qiaowei@intel.com +Description:The block_index property allows you to set the block +index for output. So I write

RE: [PATCH 0/4] Intel TXT driver

2013-05-09 Thread Ren, Qiaowei
On 2013-05-08, Matthew Garrett wrote: On Tue, 2013-05-07 at 22:55 +0800, Qiaowei Ren wrote: This module is expected to be a better tool to access below resources - TXT config space - Tboot log mem - SMX parameter What's SMX? Safer Mode Extensions (SMX) provide a programming

RE: [PATCH 3/4] driver: provide sysfs interfaces to access TXT log

2013-05-09 Thread Ren, Qiaowei
On 2013-05-09, Matthew Garrett wrote: On Thu, 2013-05-09 at 08:05 +, Ren, Qiaowei wrote: On 2013-05-08, Matthew Garrett wrote: How different are these logs to the TPM measurements exported via securityfs? These logs come from tboot (Trusted Boot, an open source, pre-kernel/VMM

RE: [PATCH 0/4] Intel TXT driver

2013-05-09 Thread Ren, Qiaowei
On 2013-05-09, Matthew Garrett wrote: On Thu, 2013-05-09 at 08:19 +, Ren, Qiaowei wrote: On 2013-05-08, Matthew Garrett wrote: On Tue, 2013-05-07 at 22:55 +0800, Qiaowei Ren wrote: This module is expected to be a better tool to access below resources - TXT config space

RE: [PATCH 1/4] driver: add TXT driver in kernel

2013-05-09 Thread Ren, Qiaowei
On 2013-05-08, Matthew Garrett wrote: On Tue, 2013-05-07 at 22:55 +0800, Qiaowei Ren wrote: + * This module is expected to be a better tool to access below + resources Expected to be or is? :) is :) + * Data is currently found below You're adding it to ABI, so it shouldn't just be

RE: [PATCH v2] x86: add a new SMP bring up way for tboot case

2013-04-11 Thread Ren, Qiaowei
> -Original Message- > From: H. Peter Anvin [mailto:h...@zytor.com] > Sent: Wednesday, March 20, 2013 11:02 AM > To: Ren, Qiaowei > Cc: Thomas Gleixner; Ingo Molnar; x...@kernel.org; Maliszewski, Richard L; > linux-kernel@vger.kernel.org; tboot-de...@lists.sourceforge.ne

RE: [PATCH v2] x86: add a new SMP bring up way for tboot case

2013-04-11 Thread Ren, Qiaowei
-Original Message- From: H. Peter Anvin [mailto:h...@zytor.com] Sent: Wednesday, March 20, 2013 11:02 AM To: Ren, Qiaowei Cc: Thomas Gleixner; Ingo Molnar; x...@kernel.org; Maliszewski, Richard L; linux-kernel@vger.kernel.org; tboot-de...@lists.sourceforge.net; Xiaoyan Zhang; Wei

RE: [PATCH v2] x86: add a new SMP bring up way for tboot case

2013-03-19 Thread Ren, Qiaowei
Any comments on this patch? Thanks, Qiaowei -Original Message- From: Ren, Qiaowei Sent: Thursday, October 11, 2012 6:11 PM To: Thomas Gleixner; Ingo Molnar; H. Peter Anvin; x...@kernel.org Cc: Maliszewski, Richard L; linux-kernel@vger.kernel.org; tboot-de...@lists.sourceforge.net; Ren

RE: [PATCH v2] x86: add a new SMP bring up way for tboot case

2013-03-19 Thread Ren, Qiaowei
Any comments on this patch? Thanks, Qiaowei -Original Message- From: Ren, Qiaowei Sent: Thursday, October 11, 2012 6:11 PM To: Thomas Gleixner; Ingo Molnar; H. Peter Anvin; x...@kernel.org Cc: Maliszewski, Richard L; linux-kernel@vger.kernel.org; tboot-de...@lists.sourceforge.net; Ren

RE: [PATCH 1/1] proc: add /proc/pid/shmaps

2012-08-08 Thread Ren, Qiaowei
analyzing 'maps' file? -Original Message- From: David Rientjes [mailto:rient...@google.com] Sent: Thursday, August 09, 2012 5:10 AM To: Ren, Qiaowei Cc: Andrew Morton; Al Viro; Oleg Nesterov; Cyrill Gorcunov; Vasiliy Kulikov; Hugh Dickins; Naoya Horiguchi; Konstantin Khlebnikov; linux-kernel

RE: [PATCH 1/1] proc: add /proc/pid/shmaps

2012-08-08 Thread Ren, Qiaowei
analyzing 'maps' file? -Original Message- From: David Rientjes [mailto:rient...@google.com] Sent: Thursday, August 09, 2012 5:10 AM To: Ren, Qiaowei Cc: Andrew Morton; Al Viro; Oleg Nesterov; Cyrill Gorcunov; Vasiliy Kulikov; Hugh Dickins; Naoya Horiguchi; Konstantin Khlebnikov; linux-kernel

<    1   2