Robert Baldyga (3):
USB: gadget: s3c-hsotg: fix protocol stall handling
USB: gadget: s3c-hsotg: fix dedicated fifos handling
USB: gadget: s3c-hsotg: fix clear feature ENDPOINT_HALT
drivers/usb/gadget/Kconfig |2 +-
drivers/usb/gadget/s3c-hsotg.c | 81
be used on almost all Samsung
platforms.
Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
This patch adds two fixes:
- Property halted of s3c_hsotg_ep structure is actually changed when halt is
set/cleared.
- All requests for endpoint are completed when it was halted, and the halt was
cleared by CLEAR_FEATURE, but not when new state is same as previous.
Signed-off-by: Robert
and of DAINT and
DAINTMSK, because we should handle masked interrupts only.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/s3c-hsotg.c | 48
1 file changed, 34 insertions
.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/s3c-hsotg.c |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
index dd5524c
of it. It also moves disabling voltage regulators out
of the atomic context, because handling regulators (which are usually
i2c devices) might require sleeping.
Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p
this interrupt is occurred.
Signed-off-by: Chanho Park chanho61.p...@samsung.com
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/s3c-hsotg.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/gadget/s3c
-bandwidtch
endpoints).
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
Hello,
This is update for my patch. From last version I have fixed typos
pointed out by Felipe Balbi.
On 10/01/2013 03:56 PM, Felipe Balbi wrote: Hi,
On Fri, Sep 27, 2013 at 12:31:09PM +0200, Robert Baldyga wrote
SUPER-SPEED
BULK 8, 16, 32, 64 512 1024
INTERRUPT1..64 1..1024 1..1024
ISOCHRONOUS 1..1023 1..1024 1..1024
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
Hello,
This is fourth version of my patch. From last version I have removed
On 10/01/2013 04:45 PM, Felipe Balbi wrote:
Hello,
Hi,
On Tue, Sep 24, 2013 at 11:47:16AM +0200, Robert Baldyga wrote:
Hello,
This is update for my proposal for isochronous transfers support in s3c-hsotg
driver. I've fixed issuses pointed by Bartlomiej Zolnierkiewicz. For more
information
Hello,
On 10/02/2013 05:48 PM, Alan Stern wrote:
On Wed, 2 Oct 2013, Robert Baldyga wrote:
This patch fix validation of maxpacket value given in endpoint descriptor.
Add check of maxpacket for bulk endpoints. If maxpacket is not set in
descriptor, it's set to maximum value for given type
. Now only masked ep interrupts are handled.
- Fix halt property updating.
- Fix endpoint halt clearing, when it is not currently halted.
Best regards
Robert Baldyga
Samsung RD Institute Poland
Changelog:
v2:
- splitted patches to get one fix in each patch, as Felipe Balbi suggested
- fixed typos
.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/s3c-hsotg.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
index dd5524c
All requests for endpoint are completed when it was halted and the halt was
cleared by CLEAR_FEATURE, but not when new state is same as previous.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/s3c-hsotg.c | 10
Property halted of s3c_hsotg_ep structure is actually initialised when ep
enabled, and changed when halt is set/cleared.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/s3c-hsotg.c |3 +++
1 file changed, 3
In s3c_hsotg_write_fifo function PTxFEmp/NPTxFEmp interrupts are enabled
only in shared-fifo mode. In dedicated-fifo mode they should not be used
(when enabled then cause interrupt storm).
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
When s3c_hsotg_trytx is called for ep without enqueued request, interrupts
for this ep are disabled, to prevent interrupt flooding. Interrupts are
enabled when new request for this ep is starting.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p
In OEPInt/IEPInt interrupts handling added bitwise and of DAINT and
DAINTMSK, because we should handle masked interrupts only.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/s3c-hsotg.c |8 ++--
1 file
has no requests enqueued.
- Fixed DAINT register usage. Now only masked ep interrupts are handled.
- Fix halt property updating.
- Fix endpoint halt clearing, when it is not currently halted.
- Fix interrupt configuration in dedicated fifo mode.
Best regards
Robert Baldyga
Samsung RD Institute Poland
.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/s3c-hsotg.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
index dd5524c
In OEPInt/IEPInt interrupts handling added bitwise and of DAINT and
DAINTMSK, because we should handle masked interrupts only.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/s3c-hsotg.c |8 ++--
1 file
Property halted of s3c_hsotg_ep structure is actually initialised when ep
enabled, and changed when halt is set/cleared.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/s3c-hsotg.c |3 +++
1 file changed, 3
All requests for endpoint are completed when it was halted and the halt was
cleared by CLEAR_FEATURE, but not when new state is same as previous.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/s3c-hsotg.c | 10
In dedicated-fifo mode TxFIFOEmpty interrupt should be asserted when TxFIFO
for this endpoint is completly empty, so NPTxFEmpLvl and PTxFEmpLvl bits are
set in GAHBCFG register.
In DIEPMSK register INTknTXFEmpMsk is set, becouse it's needed to indicate
FIFO Empty state.
Signed-off-by: Robert
When s3c_hsotg_trytx is called for ep without enqueued request, interrupts
for this ep are disabled, to prevent interrupt flooding. Interrupts are
enabled when new request for this ep is starting.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p
In s3c_hsotg_write_fifo function PTxFEmp/NPTxFEmp interrupts are enabled
only in shared-fifo mode. In dedicated-fifo mode they should not be used
(when enabled then cause interrupt storm).
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
This patch removes unused label.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/s3c-hsotg.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
This patch set maximum possible maxpacket value for each speed. Previous
values didn't allow to use maxpacket sizes greater than 64 in full speed
and 512 in high speed, although hardware is able to handle up to 1023 in fs
and 1024 in hs.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Signed
will
be back enabled, sending new data will be impossible.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/s3c-hsotg.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb
Hello,
This patches contains fixes for s3c-hsotg driver. They fix maxpacket sizes set
in s3c_hsotg_irq_enumdone() function, and adds flushing TX FIFO when killing all
requests in dedicated-fifo mode. More info in commit messages.
Best regards
Robert Baldyga
Samsung RD Institute Poland
Robert
Hi,
On 03/13/2014 03:03 AM, Chanwoo Choi wrote:
Hi Robert,
On 03/12/2014 10:37 PM, Robert Baldyga wrote:
This patch modifies mfd driver to use regmap for handling interrupts.
It allows to simplify irq handling process. This modifications needed
to make small changes in function drivers
This patch changes naming convention of MUIC interrupts form CamelCase
to upper case. It makes names more readable and consistent with another
interrupt names in max8997 driver.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
drivers/extcon/extcon-max8997.c | 32
This patch modifies max8997 driver and each associated function driver,
to use regmap instead of operating directly on i2c bus. It will allow to
simplify IRQ handling using regmap-irq.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
, their i2c
clients, regmaps and irqs are not registered.
Best regards
Robert Baldyga
Samsung RD Institute Poland
Changelog:
v3:
- fix error handling
- fix deinitializations order
- move muic irq enum values renaming to separate patch
v2: https://lkml.org/lkml/2014/3/12/237
- rebase patches on Lee
This patch moves code creating new i2c clients and regmaps to function
drivers which use them. It allows to avoid creating this instances when
individual function drivers are not enabled.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
drivers/extcon/extcon-max8997.c | 131
This patch modifies mfd driver to use regmap for handling interrupts.
It allows to simplify irq handling process. This modifications needed
to make small changes in function drivers, which use interrupts.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
drivers/extcon/extcon-max8997.c
Hi,
On 03/13/2014 11:25 AM, Chanwoo Choi wrote:
Hi Robert,
On 03/13/2014 06:38 PM, Robert Baldyga wrote:
Hi,
This patchset modifies max8997 driver and associated function drivers to use
register maps instead of operating directly on i2c bus. This change allowed
to simplify irq handling
On 03/13/2014 11:45 AM, Chanwoo Choi wrote:
Hi Robert,
On 03/13/2014 06:38 PM, Robert Baldyga wrote:
This patch modifies mfd driver to use regmap for handling interrupts.
It allows to simplify irq handling process. This modifications needed
to make small changes in function drivers, which
This patch adds device tree node for IRQ used by max8997.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
arch/arm/boot/dts/exynos4210-trats.dts | 13 +
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4210-trats.dts
b/arch/arm/boot/dts/exynos4210
useless it doesn't
make me unhappy :)
Best regards
Robert Baldyga
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
This patch modifies max8997 driver and each associated function driver,
to use regmap instead of operating directly on i2c bus. It will allow to
simplify IRQ handling using regmap-irq.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
drivers/extcon/extcon-max8997.c | 17
This patch modifies max8997 driver and each associated function driver,
to use regmap instead of operating directly on i2c bus. It will allow to
simplify IRQ handling using regmap-irq.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
Changelog:
v2:
- check devm_regmap_init_i2c() return
Hi,
On 03/05/2014 07:54 PM, Dmitry Torokhov wrote:
Hi Robert,
On Wed, Mar 05, 2014 at 03:58:17PM +0100, Robert Baldyga wrote:
-int max8997_write_reg(struct i2c_client *i2c, u8 reg, u8 value)
+int max8997_write_reg(struct regmap *map, u8 reg, u8 value)
Why don't you make read/write reg
missed to remove reference to unused variable. I will fix it.
Thanks!
Robert Baldyga
Samsung RD Institute Poland
On 03/05/2014 11:58 PM, Robert Baldyga wrote:
This patch modifies max8997 driver and each associated function driver,
to use regmap instead of operating directly on i2c bus
This patch modifies max8997 driver and each associated function driver,
to use regmap instead of operating directly on i2c bus. It will allow to
simplify IRQ handling using regmap-irq.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
Changelog:
v3:
- remove unused variables
- use regmap_
On 03/06/2014 05:29 PM, Dmitry Torokhov wrote:
On Thu, Mar 06, 2014 at 07:42:30AM +0100, Robert Baldyga wrote:
Hi,
On 03/05/2014 07:54 PM, Dmitry Torokhov wrote:
Hi Robert,
On Wed, Mar 05, 2014 at 03:58:17PM +0100, Robert Baldyga wrote:
-int max8997_write_reg(struct i2c_client *i2c, u8
This patch adds missing spin_unlock and mutex_unlock calls in
error handling code.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
drivers/usb/gadget/f_fs.c |8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/f_fs.c b/drivers/usb/gadget
, their i2c
clients, regmaps and irqs are not registered.
Best regards
Robert Baldyga
Samsung RD Institute Poland
Robert Baldyga (3):
mfd: max8997: use regmap to access registers
mfd: max8997: handle IRQs using regmap
mfd: max8997: move regmap handling to function drivers
drivers/extcon/extcon
This patch modifies max8997 driver and each associated function driver,
to use regmap instead of operating directly on i2c bus. It will allow to
simplify IRQ handling using regmap-irq.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
drivers/extcon/extcon-max8997.c | 31
This patch moves code creating new i2c clients and regmaps to function
drivers which uses them. It allow to avoid creating this instances when
intividual function drivers are not enabled.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
drivers/extcon/extcon-max8997.c | 118
This patch modifies mfd driver to use regmap for handling interrupts.
It allows to simplify irq handling process. This modifications needed
to make small changes in function drivers, which use interrupts.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
drivers/extcon/extcon-max8997.c
On 03/11/2014 03:32 PM, Krzysztof Kozlowski wrote:
On Tue, 2014-03-11 at 14:58 +0100, Robert Baldyga wrote:
This patch modifies max8997 driver and each associated function
driver, to use regmap instead of operating directly on i2c bus. It
will allow to simplify IRQ handling using regmap-irq
, their i2c
clients, regmaps and irqs are not registered.
Best regards
Robert Baldyga
Samsung RD Institute Poland
Changelog:
v2:
- rebase patches on Lee Jones' MFD tree
- add missing selects in Kconfig
- add missing deinitializations
- add interrupt disabling when suspend
- few minor changes and typo
This patch moves code creating new i2c clients and regmaps to function
drivers which use them. It allows to avoid creating this instances when
individual function drivers are not enabled.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Conflicts:
drivers/mfd/max8997.c
---
drivers
This patch modifies max8997 driver and each associated function driver,
to use regmap instead of operating directly on i2c bus. It will allow to
simplify IRQ handling using regmap-irq.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
drivers/extcon/extcon-max8997.c | 31
This patch modifies mfd driver to use regmap for handling interrupts.
It allows to simplify irq handling process. This modifications needed
to make small changes in function drivers, which use interrupts.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
drivers/extcon/extcon-max8997.c
USB
transaction.
In s3c_hsotg_ep_enable() function added s3c_hsotg_set_ep_maxpacket() call
instead of setting ep.maxpacket value directly.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/s3c-hsotg.c | 11
.
- Add Odd/Even microframe toggle to allow data transfering in each microframe
in s3c_hsotg_epint() function.
- Fix s3c_hsotg_ep_enable() function by supporting isochronous endpoint type.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
: gadget: s3c-hsotg: add isochronous
transfers
support.
Best regards
Robert Baldyga
Samsung RD Institute Poland
drivers/usb/gadget/s3c-hsotg.c | 34 --
1 file changed, 28 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb
Hello,
On 10/10/2013 06:04 PM, Felipe Balbi wrote:
Hi,
On Wed, Oct 09, 2013 at 08:41:57AM +0200, Robert Baldyga wrote:
@@ -2616,14 +2630,19 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep,
s3c_hsotg_set_ep_maxpacket(hsotg, hs_ep-index, mps);
/* default, set to non-periodic
s3c_hsotg_ep_enable() function by supporting isochronous endpoint type.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/s3c-hsotg.c | 74 +++-
1 file changed, 57 insertions(+), 17
specific endpoint descriptor fields handling.
- Add high-speed high-bandwidth trensfers support by correct Multi Count
handling and Odd/Even frame toggle for interval=1.
- Improve endpoint interrupt handling by ignoring unneded interrupts for
isochronous endpoints.
Best regards
Robert Baldyga
check
causing the limitation concerns only non-periodic endpoints.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/s3c-hsotg.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
I have found one small bug
-off-by: Robert Baldyga r.bald...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Changelog:
v2:
- moved bugfix affecting to the other features to separated patch
- changed conditions order in request length checking in s3c_hsotg_start_req
function, as Bartlomiej
This patch add missing error check in ffs_func_bind() function, after
ffs_do_descs() funcion call for hs descriptors. Without this check it's
possible that the module will try dereference incorrect pointer.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
drivers/usb/gadget/f_fs.c |3
This patch fixes validation of maxpacket value given in endpoint descriptor.
Added check of maxpacket for bulk endpoints.
Correct maxpacket value is:
FULL-SPEED HIGH-SPEED
BULK 64 512
INTERRUPT64 1024
ISOCHRONOUS 10231024
Signed-off-by: Robert
-bandwidtch
endpoints).
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
drivers/usb/gadget/s3c-hsotg.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
index 8a9e2c6..0d1dcbd 100644
--- a/drivers/usb/gadget
for high speed descriptors. Without this check
it's possible that the module will try to dereference incorrect pointer.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Changelog:
v2:
- fix typos
- expand patch desctiprion
v1: https://lkml.org/lkml/2013/9/27/128
---
drivers/usb/gadget/f_fs.c
endpoints.
Correct maxpacket value is:
FULL-SPEED HIGH-SPEED SUPER-SPEED
BULK 64 512 1024
INTERRUPT64 10241024
ISOCHRONOUS 102310241024
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Changelog:
v2:
- arrange code
SUPER-SPEED
BULK 8, 16, 32, 64 512 1024
INTERRUPT1..64 1..1024 1..1024
ISOCHRONOUS 1..1023 1..1024 1..1024
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
Hello,
This is third version of my patch. Form last version I have fixed
This patch modifies mfd driver to use regmap for handling interrupts.
It allows to simplify irq handling process. This modifications needed
to make small changes in function drivers, which use interrupts.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Reviewed-by: Krzysztof Kozlowski
spinlock recursion.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
drivers/usb/gadget/composite.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
index d41103e..77cae4b 100644
--- a/drivers/usb/gadget
This field allows to mark ep as claimed in more clear way. Claiming
endpoint by setting driver_data to non-null value is leaky solution
and makes code unreadable.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
drivers/usb/gadget/epautoconf.c | 11 ++-
include/linux/usb/gadget.h
callback function.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
fs/aio.c | 77 ++
1 file changed, 47 insertions(+), 30 deletions(-)
diff --git a/fs/aio.c b/fs/aio.c
index 062a5f6..ea275fa 100644
--- a/fs/aio.c
+++ b/fs/aio.c
function call, so spinlock
recursion will not occur in case of aio_complete() call. After cancel function
call spinlock is locked back.
There is also __must_hold() macro added for kiocb_cancel() function, to allow
sparse spin lock checking.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
This patch modifies mfd driver to use regmap for handling interrupts.
It allows to simplify irq handling process. This modifications needed
to make small changes in function drivers, which use interrupts.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
drivers/mfd/Kconfig
This patch modifies mfd driver to use regmap for handling interrupts.
It allows to simplify irq handling process. This modifications needed
to make small changes in function drivers, which use interrupts.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Reviewed-by: Krzysztof Kozlowski
This patch adds IRQ line specification for the MAX8997 chip and necessary
pinctrl group to configure pull-up and driver strength of the pin.
It's needed for proper handling of IRQs coming from MAX8997 multifunction
device (IRQs are used by PMIC, MUIC and RTC).
Signed-off-by: Robert Baldyga r.bald
On 04/24/2014 09:52 PM, Greg KH wrote:
On Mon, Apr 14, 2014 at 01:46:11PM +0200, Robert Baldyga wrote:
This patchset adds many improvements to extcon class driver and extcon
provider drivers. It changes extcon API to faster and safer by replaceing
function taking extcon and cable names
This patch modifies mfd driver to use regmap for handling interrupts.
It allows to simplify irq handling process. This modifications needed
to make small changes in function drivers, which use interrupts.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Reviewed-by: Krzysztof Kozlowski
This patch modifies mfd driver to use regmap for handling interrupts.
It allows to simplify irq handling process. This modifications needed
to make small changes in function drivers, which use interrupts.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Reviewed-by: Krzysztof Kozlowski
This patch changes naming convention of MUIC interrupts form CamelCase
to upper case. It makes names more readable and consistent with another
interrupt names in max8997 driver.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
This patch modifies max8997 driver and each associated function driver,
to use regmap instead of operating directly on i2c bus. It will allow to
simplify IRQ handling using regmap-irq.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
, their i2c
clients, regmaps and irqs are not registered.
Best regards
Robert Baldyga
Samsung RD Institute Poland
Changelog:
v4:
- remove patch moving regmap handling to function drivers
v3: https://lkml.org/lkml/2014/3/13/101
- fix error handling
- fix deinitializations order
- move muic irq enum
This patchset modifies max77693 driver and associated function drivers
to improve regmap support. It removes unnecessary wrapper functions,
which make code more clean, and modifies IRQ handling to use regmap irq.
Best regards
Robert Baldyga
Samsung RD Institute Poland
Robert Baldyga (2):
mfd
This patch modifies mfd driver to use regmap for handling interrupts.
It allows to simplify irq handling process. This modifications needed
to make small changes in function drivers, which use interrupts.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
drivers/extcon/extcon-max77693.c
This patch removes wrapper functions used to access regmap, and
make driver using regmap_*() functions instead.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
drivers/extcon/extcon-max77693.c | 30 +--
drivers/mfd/max77693-irq.c | 31
This patch removes wrapper functions used to access regmap, and
make driver using regmap_*() functions instead.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
drivers/extcon/extcon-max77693.c | 32 ++---
drivers/mfd/max77693-irq.c | 50
This patchset modifies max77693 driver and associated function drivers
to improve regmap support. It removes unnecessary wrapper functions,
which make code more clean, and modifies IRQ handling to use regmap irq.
Best regards
Robert Baldyga
Samsung RD Institute Poland
Changelog:
v2:
- change
This patch modifies mfd driver to use regmap for handling interrupts.
It allows to simplify irq handling process. This modifications needed
to make small changes in function drivers, which use interrupts.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
drivers/extcon/extcon-max77693.c
This patchset modifies max77693 driver and associated function drivers
to improve regmap support. It removes unnecessary wrapper functions,
which make code more clean, and modifies IRQ handling to use regmap irq.
Best regards
Robert Baldyga
Samsung RD Institute Poland
Changelog:
v3:
- fix some
This patch modifies mfd driver to use regmap for handling interrupts.
It allows to simplify irq handling process. This modifications needed
to make small changes in function drivers, which use interrupts.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Reviewed-by: Krzysztof Kozlowski
This patch removes wrapper functions used to access regmap, and
make driver using regmap_*() functions instead.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Acked-by: Lee Jones lee.jo...@linaro.org
[For extcon part]
Acked
On 04/22/2014 09:51 PM, Mark Brown wrote:
On Mon, Apr 14, 2014 at 01:46:12PM +0200, Robert Baldyga wrote:
That's quite some CC list you've got there, and the mail seems a bit
corrupted too (it confused my MUA).
This patch adds extcon devicetree bindings. Documentation describes
On 04/19/2014 12:52 PM, Aaro Koskinen wrote:
Hi,
On Mon, Apr 14, 2014 at 01:46:16PM +0200, Robert Baldyga wrote:
dev_info(pdev-dev,
- OMAP USB OTG controller rev %d.%d (%s, id=%d, vbus=%d)\n,
- (rev 4) 0xf, rev 0xf, config-extcon, otg_dev-id
On 04/22/2014 05:03 PM, Aaro Koskinen wrote:
Hi,
On Tue, Apr 22, 2014 at 08:21:35AM +0200, Robert Baldyga wrote:
On 04/19/2014 12:52 PM, Aaro Koskinen wrote:
On Mon, Apr 14, 2014 at 01:46:16PM +0200, Robert Baldyga wrote:
dev_info(pdev-dev,
- OMAP USB OTG controller rev %d.%d
This patch adds extcon devicetree bindings. Documentation describes in general
client and provider bindings, and contains detailed desctiprion of bindings
for each extcon provider.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
.../devicetree/bindings/extcon/extcon-adc-jack.txt | 60
This patch changes charger-manager bindings to be compatible with
new extcon bindings.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
.../bindings/power_supply/charger-manager.txt | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/Documentation
be found in commit messages and Documentation.
Best regards
Robert Baldyga
Samsung RD Institute Poland
Robert Baldyga (13):
Documentation: add extcon devicetree bindings
Documentation: update charger-manager devicetree bindings
extcon: extcon-class: remove extcon_set_cable_state() function
This patch removes two functions, extcon_find_cable_index() and
extcon_get_edev_by_phandle(). They are not longer needed, since
extcon client API has changed to be oriented on extcon_cable instead
of extcon_dev.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
drivers/extcon/extcon
1 - 100 of 1893 matches
Mail list logo
