Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-14 Thread Rodolfo Giometti
On Tue, Mar 13, 2007 at 06:48:17PM -0400, Lennart Sorensen wrote: I have tried out 3.0.0-rc2 which seems to work pretty well so far (when Thanks. I just posted to the linux kernel ML the last release 3.0.0. Maybe you can do a git pull and try it out. :) combined with the patches to the jsm

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-14 Thread Rodolfo Giometti
On Wed, Mar 14, 2007 at 09:19:34AM -0400, Lennart Sorensen wrote: I will grab the last couple of commits and try although they didn't sound like they really make much difference. Some fixes up... see the git log for further info. I couldn't find any way to do that with setserial (at least

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-14 Thread Rodolfo Giometti
On Wed, Mar 14, 2007 at 10:12:53AM -0400, Lennart Sorensen wrote: I looked at those, and they didn't sound important. I will grab it anyhow just for completeness. Ok! Thanks. Well I think I may just write a small tool to do the ioctl to enable it so I don't need the full setserial around.

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-14 Thread Rodolfo Giometti
On Wed, Mar 14, 2007 at 10:42:51AM -0400, Lennart Sorensen wrote: Now you said to check the return value of time_pps_readlink. Well it I refere to readlink(), not to time_pps_readlink(). I'm sorry for mistake. If the call was to readlink directly it needs to be done, while your

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-14 Thread Rodolfo Giometti
On Wed, Mar 14, 2007 at 11:37:05AM -0400, Lennart Sorensen wrote: Well here is my current version of the refclock_nmea.c.patch for LinuxPPS. It now uses /dev/gps# for the nmea messages and /dev/pps# for the PPS device (which in my case is of course the same device). I am running some more

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-15 Thread Rodolfo Giometti
On Wed, Mar 14, 2007 at 04:57:32PM -0400, Lennart Sorensen wrote: Well it does work for our GPS receiver at least. Of course I have to change the baud rate in the driver since our unit doens't use the NNEA standard 4800. And the configure script for ntp doesn't recognize the v2 PPSAPI, so

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-15 Thread Rodolfo Giometti
On Thu, Mar 15, 2007 at 11:18:55AM -0400, Lennart Sorensen wrote: How come none of the .patch files in http://ftp.enneenne.com/pub/misc/linuxpps/refclocks/nmea/ can be accessed? Does your web server not like serving up .patch files? Sorry. I set wrong file permissions. :) Try now. Ciao,

[PATCH] pxafb: Add option to enable/disable the cursor

2007-02-13 Thread Rodolfo Giometti
Add cursor enable/disable, very useful if you wish a full screen boot logo. Cursor can be disabled from kernel command line: video=pxafb:nocursor or from sysfs interface: echo 1 /sys/module/pxafb/parameters/nocursor Signed-off-by: Rodolfo Giometti [EMAIL PROTECTED

Re: [PATCH] pxafb: Add option to enable/disable the cursor

2007-02-13 Thread Rodolfo Giometti
On Tue, Feb 13, 2007 at 05:48:29PM +, Russell King wrote: Maybe this should be a generic option? Or maybe issue ESC [ 25 l to disable the cursor if you're wanting to turn it off from userspace. This is useful if you have a full screen boot logo. How I can issue ESC [ 25 l at boot time?

Re: [PATCH] pxafb: Add option to enable/disable the cursor

2007-02-15 Thread Rodolfo Giometti
On Tue, Feb 13, 2007 at 06:22:01PM +, James Simmons wrote: The reason you have a cursor is because you are using the framebuffer console. Do you need fbcon ? Yes. During the system update process on in the production stage a console is very useful. Ciao, Rodolfo -- GNU/Linux

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-02-16 Thread Rodolfo Giometti
On Fri, Feb 16, 2007 at 07:12:08PM +, Russell King wrote: Yuck. Please. No. Doing it this way means you have to modify every single serial driver out there which is a mamouth task. uart_handle_dcd_change(up-port, status UART_MSR_DCD); Did you not look to

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-02-16 Thread Rodolfo Giometti
On Fri, Feb 16, 2007 at 08:56:18PM +0100, Jan Dittmer wrote: Drop the linux prefix. It's in the linux kernel after all. Ok. +PROCFS support +-- New features shouldn't introduce new /proc stuff. It's a must? I can leave procfs for backward compatibility with old utilities?

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-02-16 Thread Rodolfo Giometti
On Fri, Feb 16, 2007 at 08:51:35PM +, Russell King wrote: You can't because it doesn't go through the interfaces you're hooking into. Existing interfaces are changed to point at the UARTs using setserial, which does its work via an ioctl. I see. Not specifically only userland - if it

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-21 Thread Rodolfo Giometti
On Wed, Mar 21, 2007 at 09:05:34AM +0100, Jon K Hellan wrote: Have you received any comments on this from the NTP community? From Ulrich Windl? Not yet... that's why I reposted my patch. Thanks, Rodolfo -- GNU/Linux Solutions e-mail:[EMAIL PROTECTED] Linux Device

Re: [LinuxPPS] [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-21 Thread Rodolfo Giometti
On Wed, Mar 21, 2007 at 10:55:58AM -0600, Reg Clemens wrote: Just one point with your patch. A couple of years ago there was a long discussion on the Linux Kernel mailing list as to how USER codes were not supposed to use KERNEL include files. Now I still see __KERNEL__ all over the

[PATCH 1/1] MTD: support for auto locking flash on power up

2007-03-22 Thread Rodolfo Giometti
Auto unlock sectors on resume for auto locking flash on power up. Signed-off-by: Rodolfo Giometti [EMAIL PROTECTED] diff --git a/drivers/mtd/chips/cfi_cmdset_0001.c b/drivers/mtd/chips/cfi_cmdset_0001.c index f69184a..8a4395e 100644 --- a/drivers/mtd/chips/cfi_cmdset_0001.c +++ b/drivers/mtd

Backlight support for pxafb

2007-02-20 Thread Rodolfo Giometti
Hello, I noticed that backlight support for this device is provided by the pxafb_backlight_power() function which allows to turn on and off the backlight. On the other hand I notice also the backlight driver support which allows several configurations on a specific backlight. It could be

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-02-21 Thread Rodolfo Giometti
On Mon, Feb 19, 2007 at 06:56:20PM -0800, H. Peter Anvin wrote: It's not a precondition for a file descriptor, either. There are plenty of ioctl-only device drivers in existence. Furthermore, a file descriptor doesn't imply a device entry. Consider pipe(2), for example. As far as the

[PATCH 1/1] PXAFB: Support for backlight control

2007-02-21 Thread Rodolfo Giometti
Backlight control support for the PXA fram buffer. Signed-off-by: Rodolfo Giometti [EMAIL PROTECTED] --- Each platform should define the backlight properties in its own setup file in linux/arch/arm/mach-pxa/ as follow: static int pxafb_bl_get_brightness(struct backlight_device *bl_dev

Advice on backlight support

2007-02-21 Thread Rodolfo Giometti
Hello, I'd like to add backlight support for input devices since my custom board has a backlighted mini keyboard. It could be acceptable to move the code from drivers/video/backlight/ to drivers/backlight/ renaming the Backlight LCD name into Backlight and adding two new entries LCD and, maybe,

Re: [PATCH 1/1] PXAFB: Support for backlight control

2007-02-21 Thread Rodolfo Giometti
On Wed, Feb 21, 2007 at 06:00:37PM +0200, Paul Sokolovsky wrote: On the other hand, there's already drivers/video/backlight/backlight.c which provides generic BL support, implemented using notifier callback for FB core. Moreover, there's My patch _uses_ that support. corgi_bl.c driver

Re: [PATCH 1/1] PXAFB: Support for backlight control

2007-02-22 Thread Rodolfo Giometti
On Thu, Feb 22, 2007 at 12:59:06AM +, Richard Purdie wrote: Reading through the patch its: 1) Not against any mainline kernel 2) Not against a recent kernel I'm sorry, but the patch applay against the latest kernel. Please, try it. There were a number of backlight class changes just

Re: [PATCH 1/1] PXAFB: Support for backlight control

2007-02-22 Thread Rodolfo Giometti
On Wed, Feb 21, 2007 at 06:26:08PM +0200, Paul Sokolovsky wrote: k Why? It's the same, except that it already exists, generic one (not limited to pxafb), and requires 1 function (too bad that C doesn't support lambda's): Ah, ok. I sent a bit of criticism for that too ;-). YMMV, but kernel

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-02-22 Thread Rodolfo Giometti
On Wed, Feb 21, 2007 at 08:14:14AM -0800, H. Peter Anvin wrote: If you have a kernel driver at all, then it makes perfect sense. If you don't have a kernel driver at all, then it's irrelevant to the linux-kernel discussion. ??? So you are told me that if my PPS source is connected with a

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-02-22 Thread Rodolfo Giometti
On Thu, Feb 22, 2007 at 12:51:48AM +0100, Roman Zippel wrote: Hi, On Wednesday 21 February 2007 13:04, Rodolfo Giometti wrote: RFC simply doesn't consider the fact that you can have a PPS source __without__ a filedes connected with, and a single filedes is considered __always__

Re: [PATCH 1/1] PXAFB: Support for backlight control

2007-02-22 Thread Rodolfo Giometti
On Thu, Feb 22, 2007 at 09:27:09AM +, Richard Purdie wrote: Yes, my point is that you shouldn't need to touch pxafb if you use the backlight class. I know pxafb has backlight hooks but they are probably going to get removed at some point as they should no longer be needed. I see. What

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-02-22 Thread Rodolfo Giometti
On Wed, Feb 21, 2007 at 10:16:45AM +, Pavel Machek wrote: Hi! @@ -0,0 +1,206 @@ + + PPS - Pulse Per Second + -- + +(C) Copyright 2007 Rodolfo Giometti [EMAIL PROTECTED] If you add copyright, add license, too. Ok

Re: [PATCH 1/1] PXAFB: Support for backlight control

2007-02-22 Thread Rodolfo Giometti
On Thu, Feb 22, 2007 at 12:33:35PM +0200, Paul Sokolovsky wrote: We in handhelds.org codebase have attached patch* to make corgi_bl more suitable for general use. This patch was submitted to Richard (so, more votes needed ;-) ). Otherwise, snippet I pasted is from real machine

[PATCH] INPUT/keyboard: PXA27x keyboard support

2007-03-02 Thread Rodolfo Giometti
= { .platform_data = wwpc1100_kbd, }, }; static struct platform_device *platform_devices[] __initdata = { wwpc1100_audio_device, wwpc1100_keyboard, wwpc1100_lcd_bl_device, wwpc1100_keyb_bl_device, }; Signed-off-by: Rodolfo Giometti [EMAIL PROTECTED] ---diff --git

heartbeat for leds on i2c bus

2007-12-03 Thread Rodolfo Giometti
Hello, on my custom board I have some leds mapped on a dedicated chip connected via i2c bus. If I try to use the heartbeat trigger I hang the system... I suppose it is due the fact the led_set_brightness() function is called inside a kernel timer. How I can solve this problem? I thought to

Re: [PATCH] LinuxPPS - PPS support for Linux

2007-10-25 Thread Rodolfo Giometti
On Tue, Oct 23, 2007 at 02:08:19PM -0700, Roland Dreier wrote: +void pps_unregister_source(int source) ... + wait_event(pps-usage_queue, atomic_read(pps-usage) == 0); + + pps_sysfs_remove_source_entry(pps); + pps_unregister_cdev(pps); + kfree(pps); This reference

[PATCH] PCMCIA: prevent auto insert during resume.

2007-10-26 Thread Rodolfo Giometti
If a socket has been ejected before sleeping, at resume time it shouldn't be awaked. Signed-off-by: Rodolfo Giometti [EMAIL PROTECTED] --- drivers/pcmcia/cs.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/pcmcia/cs.c b/drivers/pcmcia/cs.c index 729e37d

Re: [PATCH] PCMCIA: prevent auto insert during resume.

2007-10-26 Thread Rodolfo Giometti
On Fri, Oct 26, 2007 at 04:11:41PM +0100, Russell King wrote: On Fri, Oct 26, 2007 at 12:51:25PM +0200, Rodolfo Giometti wrote: If a socket has been ejected before sleeping, at resume time it shouldn't be awaked. Conversely, if a card has been inserted into an empty slot prior to resuming

Re: [PATCH] PCMCIA: prevent auto insert during resume.

2007-10-26 Thread Rodolfo Giometti
On Fri, Oct 26, 2007 at 05:02:06PM +0100, Russell King wrote: Not on a battery powered device with a graphical interface. This can be done by a button, menu or other graphical object. :) On battery powered device I should prevent power lost, so if I power down a device I'd like it should

Re: [PATCH] PCMCIA: prevent auto insert during resume.

2007-10-26 Thread Rodolfo Giometti
On Fri, Oct 26, 2007 at 05:36:51PM +0100, Russell King wrote: On Fri, Oct 26, 2007 at 06:27:06PM +0200, Rodolfo Giometti wrote: On Fri, Oct 26, 2007 at 05:02:06PM +0100, Russell King wrote: When you bring the battery device out of resume, and you've inserted a card, you want

Re: [PATCH] PCMCIA: prevent auto insert during resume.

2007-10-26 Thread Rodolfo Giometti
On Fri, Oct 26, 2007 at 06:00:31PM +0100, Russell King wrote: Also if you didn't eject the socket, at resume the device will be powered up again, my patch just prevents that a pre-powered off device to be turned on at resume time. However you should consider that some

Re: [PATCH] PCMCIA: prevent auto insert during resume.

2007-10-26 Thread Rodolfo Giometti
On Fri, Oct 26, 2007 at 07:37:40PM +0100, Russell King wrote: On Fri, Oct 26, 2007 at 07:18:57PM +0200, Rodolfo Giometti wrote: On Fri, Oct 26, 2007 at 06:00:31PM +0100, Russell King wrote: Or that - probably a sysfs attribute on the pcmcia socket would be better. Ok, but how can I

[RFC] LinuxPPS (pre)patch

2007-10-19 Thread Rodolfo Giometti
Hello, here my last patch of LinuxPPS. Main differences from old versions is that now (finally) each PPS source is a dedicated char device! This thanks to an agreement with NTP people who suggested to me how to interpret RFC 2783 in such a way even a dedicated char device is now RFC complain.

Re: Oops: [RFC] LinuxPPS (pre)patch

2007-10-22 Thread Rodolfo Giometti
On Sat, Oct 20, 2007 at 09:06:41PM -0700, Greg KH wrote: Please use a 'struct class' instead of a 'struct class_device'. We have Ok, fixed. I'll repost my patch ASAP. Ciao, Rodolfo -- GNU/Linux Solutions e-mail:[EMAIL PROTECTED] Linux Device Driver

Re: [PATCH] LinuxPPS - PPS support for Linux

2007-10-23 Thread Rodolfo Giometti
On Tue, Oct 23, 2007 at 04:17:50PM -0400, Dave Jones wrote: On Tue, Oct 23, 2007 at 08:04:18PM +0200, Rodolfo Giometti wrote: Hi Rodolfo, Hi! :) here my last patch for PPS support. Please, let me know if I have something to do for kernel inclusion. Thanks for trying to get

Re: [PATCH] LinuxPPS - PPS support for Linux

2007-10-24 Thread Rodolfo Giometti
On Tue, Oct 23, 2007 at 02:08:19PM -0700, Roland Dreier wrote: A few comments: + dev_err(port-dev, PPS support disabled due port \%s\ is + in polling mode\n, I think because instead of due is closer to standard English. Fixed. +

PCMCIA insert on resume

2007-10-24 Thread Rodolfo Giometti
Hello, I don't understand why, on resume, the function socket_resume() (in drivers/pcmcia/cs.c) do: if (!(skt-state SOCKET_PRESENT)) { skt-state = ~SOCKET_SUSPEND; return socket_insert(skt); } This cause a powered off socket before suspend to be

Re: [PATCH 1/8] LinuxPPS core support.

2008-02-11 Thread Rodolfo Giometti
On Mon, Feb 11, 2008 at 07:25:42AM -0800, Greg KH wrote: On Mon, Feb 11, 2008 at 10:53:46AM +0100, Rodolfo Giometti wrote: On Fri, Feb 08, 2008 at 10:45:31PM -0800, Greg KH wrote: As you are adding sysfs files, please also describe them in Documentation/ABI/ in this same series

Re: [PATCH 1/8] LinuxPPS core support.

2008-02-11 Thread Rodolfo Giometti
On Mon, Feb 11, 2008 at 07:31:53PM +0100, Rodolfo Giometti wrote: Do you think is better create these files anyway and in case report a NULL string? Is that ok? /* * Attribute functions */ static ssize_t pps_show_assert(struct device *dev, struct

Re: [PATCH 1/8] LinuxPPS core support.

2008-02-11 Thread Rodolfo Giometti
On Fri, Feb 08, 2008 at 10:45:31PM -0800, Greg KH wrote: As you are adding sysfs files, please also describe them in Documentation/ABI/ in this same series of patches. Ok. I'm going to add them under testing. Why not use a default attribute group? That way the files are created before

[RFC] driving a LCD panel via I2C

2007-09-24 Thread Rodolfo Giometti
Hello, I have an LCD panel on a custom PXA27x based board and it must be turned on/off by some special commands via a GPIO throught a I2C chip. I'd like some suggestion about I can easily manage this situation. Maybe can I add a special I2C function to get i2c_client pointer and then using it

Re: [Linux-fbdev-devel] [RFC] driving a LCD panel via I2C

2007-09-26 Thread Rodolfo Giometti
On Mon, Sep 24, 2007 at 12:34:08PM +0200, Haavard Skinnemoen wrote: I have a similar panel in the sense that it needs a bunch of SPI commands to get started. I implemented a LCD driver (drivers/video/backlight) for it so that it is automatically turned on/off at bootup/shutdown, and can be

USB host controller OXU210HP

2007-10-03 Thread Rodolfo Giometti
Hello, someone is working on this device? http://www.oxsemi.com/products/usb/OXU210HP.html Thanks in advance, Rodolfo -- GNU/Linux Solutions e-mail:[EMAIL PROTECTED] Linux Device Driver [EMAIL PROTECTED] Embedded Systems

PXA27x UDC driver GIT repository

2007-07-21 Thread Rodolfo Giometti
Hello, as promised I just published my version of the driver for PXA27x USB device controller. You can find all references om my wiki at: http://wiki.enneenne.com/index.php/PXA27x_UDC I reworked the driver according to latest suggestions from you. It's far from perfection but it's still

Re: [linux-usb-devel] PXA27x UDC driver GIT repository

2007-07-22 Thread Rodolfo Giometti
On Sat, Jul 21, 2007 at 02:47:22PM -0700, David Brownell wrote: On Saturday 21 July 2007, Rodolfo Giometti wrote: I reworked the driver according to latest suggestions from you. ... except for the most important one, which is to remove the requirement to change every part of the gadget

Re: [PATCH] LinuxPPS - definitive version

2007-07-23 Thread Rodolfo Giometti
On Mon, Jul 23, 2007 at 02:35:16PM +0100, David Woodhouse wrote: s/Documentaion/Documentation/ in the last line of Documentation/pps/pps.txt Fixed. Please feed it to scripts/checkpatch.pl -- you can ignore all the warnings about lines greater than 80 characters, and the complete crap about

Re: [PATCH] LinuxPPS - definitive version

2007-07-24 Thread Rodolfo Giometti
On Tue, Jul 24, 2007 at 02:49:02PM +0100, David Woodhouse wrote: Also 's/unknow /unknown /' (2 instances) ?? I didn't find them: $ grep 'unknow ' Documentation/pps/pps.txt Am I right in thinking that the only place it matters is within pps_event()? In that case, at the very least you

Re: [PATCH] LinuxPPS - definitive version

2007-07-24 Thread Rodolfo Giometti
On Tue, Jul 24, 2007 at 02:49:02PM +0100, David Woodhouse wrote: I think you still haven't quite got the 32-bit vs. 64-bit compatibility right. Remember that on i386, the alignment of a uint64_t is only 4 bytes, while on most other architectures it's 8 bytes. On i386, there will be no

Re: [PATCH] LinuxPPS - definitive version

2007-07-24 Thread Rodolfo Giometti
On Tue, Jul 24, 2007 at 03:45:19PM +0100, David Woodhouse wrote: On Tue, 2007-07-24 at 16:31 +0200, Rodolfo Giometti wrote: drivers/built-in.o: In function `sys_time_pps_fetch': (.text+0x5f05e): undefined reference to `__udivdi3' Hm, not sure. Maybe put it back to uint32_t and then add

Re: LinuxPPS spinlocks

2007-07-27 Thread Rodolfo Giometti
On Fri, Jul 27, 2007 at 01:40:14PM -0600, Chris Friesen wrote: My point is that the lock should be used to protect specific data. Thus, it would be more correct to say, spinlock foo is taken because pps_register_source() accesses variable bar. That way, if someone else wants to access bar,

Re: LinuxPPS spinlocks

2007-07-27 Thread Rodolfo Giometti
On Fri, Jul 27, 2007 at 01:08:58PM -0600, Chris Friesen wrote: Rodolfo Giometti wrote: The pps_event() is now protected by a spinlock against pps_register_source() and pps_unregister_source()... Locks protect data, not code. It may make more sense to identify the specific data being

[RFC] Dynamic boot logo

2007-08-06 Thread Rodolfo Giometti
Hello, I'd like to have some suggestions from you about how I can implement the dynamic boot logo feature in Linux reading the logo image from the flash memory. In my custom board, using u-boot I read a compressed BMP from the flash memory and then I use it to display the logo, so users just

Re: LinuxPPS spinlocks

2007-07-29 Thread Rodolfo Giometti
On Sat, Jul 28, 2007 at 02:17:24AM +0530, Satyam Sharma wrote: I only glanced through the code, so could be wrong, but I noticed that the only global / shared data you have in there is a global pps_source array of pps_s structs. That's accessed / modified from the various syscalls introduced

Re: LinuxPPS spinlocks

2007-07-29 Thread Rodolfo Giometti
On Sat, Jul 28, 2007 at 05:11:17AM +0530, Satyam Sharma wrote: Take the race between the time_pps_setparams() syscall and a concurrent pps_event() from an interrupt for instance. From sys_time_pps_setparams, the parameters for an existing source are not modified / set atomically, which means

Re: LinuxPPS spinlocks

2007-07-29 Thread Rodolfo Giometti
On Sat, Jul 28, 2007 at 05:11:17AM +0530, Satyam Sharma wrote: Ok, I've looked through (most of) the RFC and code now, and am only commenting on a design-level for now. Anyway, I didn't like the way you've significantly drifted from the RFC in several ways: Please, read documentation file

Re: LinuxPPS spinlocks

2007-07-29 Thread Rodolfo Giometti
On Sat, Jul 28, 2007 at 05:11:17AM +0530, Satyam Sharma wrote: Take the race between the time_pps_setparams() syscall and a concurrent pps_event() from an interrupt for instance. From sys_time_pps_setparams, the parameters for an existing source are not modified / set atomically, which means

Re: LinuxPPS spinlocks

2007-07-30 Thread Rodolfo Giometti
On Mon, Jul 30, 2007 at 09:49:20AM +0530, Satyam Sharma wrote: Hmm? I still don't see why you can't introduce spin_lock_irqsave/restore() in pps_event() around the access to pps_source. In pps_event() is not useful using spin_lock_irqsave/restore() since the only difference between

Re: LinuxPPS spinlocks

2007-07-30 Thread Rodolfo Giometti
On Mon, Jul 30, 2007 at 10:33:35AM +0530, Satyam Sharma wrote: Fair enough, but I think the code could become a trifle simpler/easier after the conversion, so probably greater chances of getting merged :-) I see. I'll start thinging about it. But that's alright -- see, as I said, you're

Re: LinuxPPS spinlocks

2007-07-30 Thread Rodolfo Giometti
On Mon, Jul 30, 2007 at 10:39:38AM +0530, Satyam Sharma wrote: Nopes, this isn't quite correct/safe. I suggest you should read: http://www.kernel.org/pub/linux/kernel/people/rusty/kernel-locking/ I read it but still I don't see why my solution isn't correct/safe. :) Can you please propose

Re: LinuxPPS spinlocks

2007-07-30 Thread Rodolfo Giometti
On Mon, Jul 30, 2007 at 02:37:26PM +0530, Satyam Sharma wrote: On Mon, 30 Jul 2007, Rodolfo Giometti wrote: In pps_event() is not useful using spin_lock_irqsave/restore() since the only difference between spin_lock_irqsave() and spin_lock() is that the former will turn off interrupts

Re: LinuxPPS spinlocks

2007-07-31 Thread Rodolfo Giometti
On Tue, Jul 31, 2007 at 03:31:22AM +0530, Satyam Sharma wrote: Hi Rodolfo, Hi :) Yup, this would avoid races, but then we will lose events. Why is that acceptable, when better alternative (above) exists? Because is better lossign events then recording them delayed. In the past we (LinuxPPS

Re: LinuxPPS spinlocks

2007-07-31 Thread Rodolfo Giometti
On Wed, Aug 01, 2007 at 12:19:48AM +0530, Satyam Sharma wrote: That's just absolute bullshit. ... I'm sorry to say this, Rodolfo, but _all_ your arguments above are *totally* nonsensical and factually incorrect -- and I have had enough of trying to talk sense to you, it's been ~15 mails in

Re: [LinuxPPS] [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-04-26 Thread Rodolfo Giometti
On Wed, Mar 21, 2007 at 04:35:22PM -0600, Reg Clemens wrote: On Wed, Mar 21, 2007 at 10:55:58AM -0600, Reg Clemens wrote: Just one point with your patch. A couple of years ago there was a long discussion on the Linux Kernel mailing list as to how USER codes were not supposed

Re: [PATCH v2 0/9] 3.8-rc regression with pps-ldisc due to 70ece7a731

2013-02-13 Thread Rodolfo Giometti
On Wed, Feb 13, 2013 at 08:45:47AM -0800, Greg KH wrote: I can take these through my tty tree, but it would be very good if I actually had the ack from the PPS maintainer... Rodolfo, any objection for me taking these? No. It's ok for me. If you wish you can add my «Acked-by» sign. Ciao,

Advice on APM-EMU reunion

2007-01-29 Thread Rodolfo Giometti
Hello, some months ago I sent to the MIPS and ARM mail lists a patch to unify the several APM emulation codes adding a new dedicated directory so it can be used to put there the per board specific code avoiding code duplications (see files ./arch/arm/kernel/apm.c, ./arch/mips/kernel/apm.c and

[PATCH] TSL2550 support (I2C device driver)

2007-01-29 Thread Rodolfo Giometti
sensor + * + * Copyright (C) 2007 Rodolfo Giometti [EMAIL PROTECTED] + * Copyright (C) 2007 Eurotech S.p.A. [EMAIL PROTECTED] + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software

Re: Advice on APM-EMU reunion

2007-01-29 Thread Rodolfo Giometti
On Mon, Jan 29, 2007 at 11:53:46PM +, Richard Purdie wrote: I'm not sure this is a good idea. As you're creating a new interface, why not create something new/improved without the problems that confining yourself to APM emulation brings? Because several applications (and expecially in

Re: [PATCH] TSL2550 support (I2C device driver)

2007-01-30 Thread Rodolfo Giometti
On Mon, Jan 29, 2007 at 06:39:50PM -0800, Andrew Morton wrote: +/* Insmod parameters */ +I2C_CLIENT_INSMOD_1(tsl2550); + +static int operating_mode = 0; The `= 0' is unneeded and undesirable. Fixed. ... +static int tsl2550_get_adc_value(struct i2c_client *client, int channel)

[PATCH 001/001] I2C: TSL2550 support

2007-01-30 Thread Rodolfo Giometti
From: Rodolfo Giometti [EMAIL PROTECTED] Patch to add support for Taos TSL2550 ambient light sensors. Signed-off-by: Rodolfo Giometti [EMAIL PROTECTED] --- diff --git a/drivers/i2c/chips/Kconfig b/drivers/i2c/chips/Kconfig index 87ee3ce..18e60ec 100644 --- a/drivers/i2c/chips/Kconfig +++ b

Advice on battery support [was: Advice on APM-EMU reunion]

2007-02-01 Thread Rodolfo Giometti
On Tue, Jan 30, 2007 at 10:00:55AM +0900, Paul Mundt wrote: However, it has since been reposted: http://article.gmane.org/gmane.linux.kernel/485833 http://article.gmane.org/gmane.linux.kernel/485834 http://article.gmane.org/gmane.linux.kernel/485835

[PATCH 4/8] PPS: documentation programs and examples.

2008-02-08 Thread Rodolfo Giometti
Here some utilities and examples about the PPS API and the LinuxPPS support. * ppsctl.c implements an useful testing program, while * ppsfind tries to help the user into finding a specific PPS source by using its name or path. Signed-off-by: Rodolfo Giometti [EMAIL PROTECTED

[PATCH 8/8] PPS: parallel port clients support.

2008-02-08 Thread Rodolfo Giometti
Adds support for the PPS sources connected with the interrupt pin of a parallel port. Signed-off-by: Rodolfo Giometti [EMAIL PROTECTED] --- drivers/char/lp.c | 61 +++ drivers/pps/clients/Kconfig | 10 +++ include/linux/parport.h

[PATCH 7/8] PPS: example program to enable PPS support on serial ports.

2008-02-08 Thread Rodolfo Giometti
Signed-off-by: Rodolfo Giometti [EMAIL PROTECTED] --- Documentation/pps/Makefile |2 +- Documentation/pps/ppsctl.c | 62 2 files changed, 63 insertions(+), 1 deletions(-) create mode 100644 Documentation/pps/ppsctl.c diff --git a/Documentation

LinuxPPS patch

2008-01-27 Thread Rodolfo Giometti
Hello, here my patch for PPS support against kernel 2.6.24: http://ftp.enneenne.com/pub/misc/linuxpps/patches/ntp-pps-2.6.24.diff The code has been tested by some guys intered in PPS stuff and it seems ok. :) Please report your suggestions in order to get kernel inclusion. Thanks in

Re: LinuxPPS patch

2008-01-28 Thread Rodolfo Giometti
On Mon, Jan 28, 2008 at 08:43:08AM -0500, Lennart Sorensen wrote: I would test it except I am still on 2.6.18 and probably will be for quite a while. I am still using an older patch of yours which works great for now, although I know the interface has a changed a bit since. Yes, you are

[PATCH] PPS: userland header file for PPS API.

2008-02-18 Thread Rodolfo Giometti
This patch adds into the PPS's documentation directory a possible implementation of the PPS API (RFC 2783) by using the LinuxPPS's char devices. This file is not just an example but it can be used into real systems. :) Signed-off-by: Rodolfo Giometti [EMAIL PROTECTED] --- Documentation/pps

[PATCH] PPS: documentation programs and examples.

2008-02-18 Thread Rodolfo Giometti
Here some utilities and examples about the PPS API and the LinuxPPS support. * ppstest.c implements an useful testing program, while * ppsfind tries to help the user into finding a specific PPS source by using its name or path. Signed-off-by: Rodolfo Giometti [EMAIL PROTECTED

[PATCH] PPS: serial clients support.

2008-02-18 Thread Rodolfo Giometti
Adds support for the PPS sources connected with the CD (Carrier Detect) pin of a serial port. Signed-off-by: Rodolfo Giometti [EMAIL PROTECTED] --- drivers/pps/clients/Kconfig | 10 ++ drivers/serial/8250.c|2 + drivers/serial/serial_core.c | 71

[PATCH] PPS: example program to enable PPS support on serial ports.

2008-02-18 Thread Rodolfo Giometti
Signed-off-by: Rodolfo Giometti [EMAIL PROTECTED] --- Documentation/pps/Makefile |2 +- Documentation/pps/ppsctl.c | 62 2 files changed, 63 insertions(+), 1 deletions(-) create mode 100644 Documentation/pps/ppsctl.c diff --git a/Documentation

[PATCH] PPS: parallel port clients support.

2008-02-18 Thread Rodolfo Giometti
Adds support for the PPS sources connected with the interrupt pin of a parallel port. Signed-off-by: Rodolfo Giometti [EMAIL PROTECTED] --- drivers/char/lp.c | 61 +++ drivers/pps/clients/Kconfig | 10 +++ include/linux/parport.h

[PATCH] PPS: LinuxPPS clients support.

2008-02-18 Thread Rodolfo Giometti
be useful to test system integrity on real systems. Signed-off-by: Rodolfo Giometti [EMAIL PROTECTED] --- drivers/pps/Kconfig |2 + drivers/pps/Makefile |1 + drivers/pps/clients/Kconfig | 18 +++ drivers/pps/clients/Makefile |9 +++ drivers/pps/clients/ktimer.c

[PATCH] LinuxPPS core support.

2008-02-18 Thread Rodolfo Giometti
is implemented by this patch. It provides a set of chars devices, one per PPS source, which can be used to get the time signal. The RFC's functions can be implemented by accessing to these char devices. Signed-off-by: Rodolfo Giometti [EMAIL PROTECTED] --- Documentation/ABI/testing/sysfs-pps | 73

LinuxPPS (RESUBMIT): the PPS Linux implementation.

2008-02-18 Thread Rodolfo Giometti
This patch set adds the PPS support into Linux. PPS means pulse per second and its API is specified by RFC 2783 (Pulse-Per-Second API for UNIX-like Operating Systems, Version 1.0). The code has been tested with the NTPD program (http://www.eecis.udel.edu/~mills/ntp/html/index.html) and several

[PATCH] PPS: documentation programs and examples.

2008-02-22 Thread Rodolfo Giometti
Here some utilities and examples about the PPS API and the LinuxPPS support. * ppstest.c implements an useful testing program, while * ppsfind tries to help the user into finding a specific PPS source by using its name or path. Signed-off-by: Rodolfo Giometti [EMAIL PROTECTED

LinuxPPS (RESUBMIT): the PPS Linux implementation.

2008-02-22 Thread Rodolfo Giometti
This patch set adds the PPS support into Linux. PPS means pulse per second and its API is specified by RFC 2783 (Pulse-Per-Second API for UNIX-like Operating Systems, Version 1.0). The code has been tested with the NTPD program (http://www.eecis.udel.edu/~mills/ntp/html/index.html) and several

[PATCH] PPS: serial clients support.

2008-02-22 Thread Rodolfo Giometti
Adds support for the PPS sources connected with the CD (Carrier Detect) pin of a serial port. Signed-off-by: Rodolfo Giometti [EMAIL PROTECTED] --- drivers/pps/clients/Kconfig | 10 ++ drivers/serial/8250.c|2 + drivers/serial/serial_core.c | 71

[PATCH] PPS: example program to enable PPS support on serial ports.

2008-02-22 Thread Rodolfo Giometti
Signed-off-by: Rodolfo Giometti [EMAIL PROTECTED] --- Documentation/pps/Makefile |2 +- Documentation/pps/ppsctl.c | 62 2 files changed, 63 insertions(+), 1 deletions(-) create mode 100644 Documentation/pps/ppsctl.c diff --git a/Documentation

[PATCH] LinuxPPS core support.

2008-02-22 Thread Rodolfo Giometti
is implemented by this patch. It provides a set of chars devices, one per PPS source, which can be used to get the time signal. The RFC's functions can be implemented by accessing to these char devices. Signed-off-by: Rodolfo Giometti [EMAIL PROTECTED] --- Documentation/ABI/testing/sysfs-pps | 73

[PATCH] PPS: LinuxPPS clients support.

2008-02-22 Thread Rodolfo Giometti
be useful to test system integrity on real systems. Signed-off-by: Rodolfo Giometti [EMAIL PROTECTED] --- drivers/pps/Kconfig |2 + drivers/pps/Makefile |1 + drivers/pps/clients/Kconfig | 18 +++ drivers/pps/clients/Makefile |9 +++ drivers/pps/clients/ktimer.c

[PATCH] PPS: userland header file for PPS API.

2008-02-22 Thread Rodolfo Giometti
This patch adds into the PPS's documentation directory a possible implementation of the PPS API (RFC 2783) by using the LinuxPPS's char devices. This file is not just an example but it can be used into real systems. :) Signed-off-by: Rodolfo Giometti [EMAIL PROTECTED] --- Documentation/pps

[PATCH] PPS: parallel port clients support.

2008-02-22 Thread Rodolfo Giometti
Adds support for the PPS sources connected with the interrupt pin of a parallel port. Signed-off-by: Rodolfo Giometti [EMAIL PROTECTED] --- drivers/char/lp.c | 61 +++ drivers/pps/clients/Kconfig | 10 +++ include/linux/parport.h

[PATCH] ARM: Convert to use shared Device Drivers menu

2007-02-02 Thread Rodolfo Giometti
ARM: Convert to use shared Device Drivers menu. Signed-off-by: Rodolfo Giometti [EMAIL PROTECTED] diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 6783c2e..a2ca665 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -885,84 +885,7 @@ endmenu source net/Kconfig -menu Device Drivers

[PATCH 1/1] APM-EMULATION: apm_get_power_status() should be NULL on init [was: Advice on battery support]

2007-02-02 Thread Rodolfo Giometti
APM-EMULATION: apm_get_power_status() should be NULL on init. Signed-off-by: Rodolfo Giometti [EMAIL PROTECTED] --- If the function apm_get_info() do like this: static int apm_get_info(char *buf, char **start, off_t fpos, int length) { struct apm_power_info info

Re: [PATCH] PCMCIA: prevent auto insert during resume.

2007-11-01 Thread Rodolfo Giometti
On Mon, Oct 29, 2007 at 07:24:15PM +, Pavel Machek wrote: On Fri 2007-10-26 19:18:57, Rodolfo Giometti wrote: On Fri, Oct 26, 2007 at 06:00:31PM +0100, Russell King wrote: Also if you didn't eject the socket, at resume the device will be powered up again, my patch just

Re: [PATCH] PCMCIA: prevent auto insert during resume.

2007-11-06 Thread Rodolfo Giometti
On Thu, Nov 01, 2007 at 06:37:41PM +, Russell King wrote: On Thu, Nov 01, 2007 at 03:53:59PM +0100, Rodolfo Giometti wrote: On Mon, Oct 29, 2007 at 07:24:15PM +, Pavel Machek wrote: On Fri 2007-10-26 19:18:57, Rodolfo Giometti wrote: On Fri, Oct 26, 2007 at 06:00:31PM +0100

  1   2   3   4   5   >