Re: [PATCH] Start to genericize kconfig for use by other projects.

2007-07-12 Thread Roman Zippel
Hi, On Wed, 11 Jul 2007, Rob Landley wrote: Replace name Linux Kernel in menuconfig with a macro (defaulting to Linux Kernel if not -Ddefined by the makefile), and remove a few unnecessary occurrences of kernel in pop-up text. Could you drop the PROJECT_NAME changes for now? The rest looks

Re: [PATCH] Start to genericize kconfig for use by other projects.

2007-07-12 Thread Roman Zippel
Hi, On Thu, 12 Jul 2007, I wrote: On Wed, 11 Jul 2007, Rob Landley wrote: Replace name Linux Kernel in menuconfig with a macro (defaulting to Linux Kernel if not -Ddefined by the makefile), and remove a few unnecessary occurrences of kernel in pop-up text. Could you drop the

Re: x86 status was Re: -mm merge plans for 2.6.23

2007-07-12 Thread Roman Zippel
Hi, On Wed, 11 Jul 2007, Linus Torvalds wrote: Sure, bugs happen, but code that everybody runs the same generally doesn't break. So a CPU scheduler doesn't worry me all that much. CPU schedulers are easy. A little more advance warning wouldn't have hurt though. The new scheduler does

Re: [PATCH] LinuxPPS (with new syscalls API) - new version

2007-07-11 Thread Roman Zippel
Hi, On Wed, 11 Jul 2007, Lennart Sorensen wrote: > On Wed, Jul 11, 2007 at 03:18:46AM +0200, Roman Zippel wrote: > > This is really not an API that needs to deal with such large time range. > > No one will want to use PPS API to keep accurate time past 2030? Why > not? Or s

Re: [PATCH] LinuxPPS (with new syscalls API) - new version

2007-07-11 Thread Roman Zippel
Hi, On Wed, 11 Jul 2007, Lennart Sorensen wrote: On Wed, Jul 11, 2007 at 03:18:46AM +0200, Roman Zippel wrote: This is really not an API that needs to deal with such large time range. No one will want to use PPS API to keep accurate time past 2030? Why not? Or should we be forced

Re: [PATCH] LinuxPPS (with new syscalls API) - new version

2007-07-10 Thread Roman Zippel
Hi, On Tuesday 10 July 2007, Lennart Sorensen wrote: > On Sun, Jul 01, 2007 at 09:24:41PM +0200, Rodolfo Giometti wrote: > > struct pps_timedata_s { > >__32 sec; > >__32 nsec; > > } > > > > Ok? I think 32 bits are enought for keeping seconds... :) > > You want to

Re: [PATCH] LinuxPPS (with new syscalls API) - new version

2007-07-10 Thread Roman Zippel
Hi, On Tuesday 10 July 2007, Lennart Sorensen wrote: On Sun, Jul 01, 2007 at 09:24:41PM +0200, Rodolfo Giometti wrote: struct pps_timedata_s { __32 sec; __32 nsec; } Ok? I think 32 bits are enought for keeping seconds... :) You want to purposely define an API

Re: [PATCH] NTP: remove clock_was_set() call to prevent deadlock

2007-07-04 Thread Roman Zippel
Hi, On Tuesday 03 July 2007, Thomas Gleixner wrote: > The clock_was_set() call in seconds_overflow() which happens only when > leap seconds are inserted / deleted is wrong in two aspects: > > 1. it results in a call to on_each_cpu() with interrupts disabled > 2. it is potential deadlock source

Re: [PATCH] NTP: remove clock_was_set() call to prevent deadlock

2007-07-04 Thread Roman Zippel
Hi, On Tuesday 03 July 2007, Thomas Gleixner wrote: The clock_was_set() call in seconds_overflow() which happens only when leap seconds are inserted / deleted is wrong in two aspects: 1. it results in a call to on_each_cpu() with interrupts disabled 2. it is potential deadlock source vs.

Re: 2.6.22-rc6-mm1

2007-06-30 Thread Roman Zippel
Hi, On Sat, 30 Jun 2007, Andrew Morton wrote: > > > I continue to believe that kbuild's lets-trash-your-symlink behaviour is > > > obnoxious, but I was unable to persuade anyone else of this. > > > > I thought we fixed that long time ago?!?! > > Nope, a simple `make oldconfig' breaks the

Re: 2.6.22-rc6-mm1

2007-06-30 Thread Roman Zippel
Hi, On Fri, 29 Jun 2007, Andrew Morton wrote: > > Reset generates values only if Kconfig and .config agree. > > unclear. Could you please explain further what this change does? Normally generated values (Kconfig entries without a prompt) are cleared as they are regenerated anyway and so they

Re: 2.6.22-rc6-mm1

2007-06-30 Thread Roman Zippel
Hi, On Fri, 29 Jun 2007, Andrew Morton wrote: Reset generates values only if Kconfig and .config agree. unclear. Could you please explain further what this change does? Normally generated values (Kconfig entries without a prompt) are cleared as they are regenerated anyway and so they

Re: 2.6.22-rc6-mm1

2007-06-30 Thread Roman Zippel
Hi, On Sat, 30 Jun 2007, Andrew Morton wrote: I continue to believe that kbuild's lets-trash-your-symlink behaviour is obnoxious, but I was unable to persuade anyone else of this. I thought we fixed that long time ago?!?! Nope, a simple `make oldconfig' breaks the symlink.

Re: 2.6.22-rc6-mm1

2007-06-29 Thread Roman Zippel
fig before > running oldconfig saved a large number of config items from getting lost. This patch should help for this, so that this isn't done when Kconfig or .config has been changed and they are not in sync. bye, Roman Reset generates values only if Kconfig and .config agree. Signed-off

Re: 2.6.22-rc6-mm1

2007-06-29 Thread Roman Zippel
a large number of config items from getting lost. This patch should help for this, so that this isn't done when Kconfig or .config has been changed and they are not in sync. bye, Roman Reset generates values only if Kconfig and .config agree. Signed-off-by: Roman Zippel [EMAIL PROTECTED

Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_IOMEM

2007-06-28 Thread Roman Zippel
Hi, On Fri, 29 Jun 2007, Alan Cox wrote: > > > check_signature is relevant for anything with MMIO space (for example you > > > can legitimately want to check_signature a MAC68K Nubus ROM). > > > > A generic check_signature() is a little difficult if we have separate io > > functions for every

Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_IOMEM

2007-06-28 Thread Roman Zippel
Hi, On Thu, 28 Jun 2007, Alan Cox wrote: > > check_signature() needs readb() but with some setups (s390, m68k > > allmodconfig) > > there is no implementation of readb. This causes build errors with > > -Werror-implicit-function-declaration. > > This completely bogus. readb() should be

Re: [PATCH] cross-architecture ELF clean up

2007-06-28 Thread Roman Zippel
Hi, On Thu, 28 Jun 2007, Jeremy Fitzhardinge wrote: > Roman Zippel wrote: > > This could be avoided by reordering things within elf.h, but is it really > > necessary since there is no user of this right now? > > > > Well, yes, I don't have much need to include EL

Re: [PATCH] cross-architecture ELF clean up

2007-06-28 Thread Roman Zippel
Hi, On Thu, 28 Jun 2007, Jeremy Fitzhardinge wrote: Roman Zippel wrote: This could be avoided by reordering things within elf.h, but is it really necessary since there is no user of this right now? Well, yes, I don't have much need to include ELF headers in asm now, but I still

Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_IOMEM

2007-06-28 Thread Roman Zippel
Hi, On Thu, 28 Jun 2007, Alan Cox wrote: check_signature() needs readb() but with some setups (s390, m68k allmodconfig) there is no implementation of readb. This causes build errors with -Werror-implicit-function-declaration. This completely bogus. readb() should be present on M68K,

Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_IOMEM

2007-06-28 Thread Roman Zippel
Hi, On Fri, 29 Jun 2007, Alan Cox wrote: check_signature is relevant for anything with MMIO space (for example you can legitimately want to check_signature a MAC68K Nubus ROM). A generic check_signature() is a little difficult if we have separate io functions for every bus. Does

Re: [PATCH] cross-architecture ELF clean up

2007-06-27 Thread Roman Zippel
Hi, On Tue, 26 Jun 2007, Jeremy Fitzhardinge wrote: > > We have the __ASSEMBLY__ define for this, so just for asm code we don't need > > a separate header. > > > > Hm. The number of __ASSEMBLY__s end up being pretty large, and it just seemed > cleaner to put them in separate headers. This

Re: [PATCH] cross-architecture ELF clean up

2007-06-27 Thread Roman Zippel
Hi, On Tue, 26 Jun 2007, Jeremy Fitzhardinge wrote: We have the __ASSEMBLY__ define for this, so just for asm code we don't need a separate header. Hm. The number of __ASSEMBLY__s end up being pretty large, and it just seemed cleaner to put them in separate headers. This could be

Re: [patch, v2.6.22-rc6] sys_time() speedup

2007-06-26 Thread Roman Zippel
Hi, On Tue, 26 Jun 2007, Ingo Molnar wrote: Another BTW before someone takes this seriously: > ( whether there is any correlation between a decade long fundamental > suckage and stagnation of the Linux time and NTP subsystem and Roman's > decade long negative feedback presence in that area

Re: [patch, v2.6.22-rc6] sys_time() speedup

2007-06-26 Thread Roman Zippel
Hi, On Tue, 26 Jun 2007, Ingo Molnar wrote: > if you are curious why Roman's reaction to this patch was so negative: Instead of answering all the open questions, pretty much the second thing you do is to discredit me personally. :-( BTW there is a difference between critical and negative...

Re: [patch, v2.6.22-rc6] sys_time() speedup

2007-06-26 Thread Roman Zippel
Hi, On Tue, 26 Jun 2007, Ingo Molnar wrote: if you are curious why Roman's reaction to this patch was so negative: Instead of answering all the open questions, pretty much the second thing you do is to discredit me personally. :-( BTW there is a difference between critical and negative...

Re: [patch, v2.6.22-rc6] sys_time() speedup

2007-06-26 Thread Roman Zippel
Hi, On Tue, 26 Jun 2007, Ingo Molnar wrote: Another BTW before someone takes this seriously: ( whether there is any correlation between a decade long fundamental suckage and stagnation of the Linux time and NTP subsystem and Roman's decade long negative feedback presence in that area of

Re: [patch, v2.6.22-rc6] sys_time() speedup

2007-06-25 Thread Roman Zippel
Hi, On Tue, 26 Jun 2007, Jesper Juhl wrote: > Even if it is not faster, what would make it slower? Have you spotted > something I have not? There are other ways to read the clock and would require similiar synchronization hooks. Some archs can implement sys_time() in userspace, so there this

Re: [patch, v2.6.22-rc6] sys_time() speedup

2007-06-25 Thread Roman Zippel
Hi, On Mon, 25 Jun 2007, Jesper Juhl wrote: > > On Monday 25 June 2007, Ingo Molnar wrote: > > > > > the patch improves the sysbench OLTP macrobenchmark significantly: > > > > Has that any real practical relevance? > > > It seems to me that Ingo's patch offers slightly improved performance >

Re: [patch, v2.6.22-rc6] sys_time() speedup

2007-06-25 Thread Roman Zippel
Hi, On Monday 25 June 2007, Ingo Molnar wrote: > the patch improves the sysbench OLTP macrobenchmark significantly: Has that any real practical relevance? > @@ -373,6 +376,20 @@ void do_gettimeofday (struct timeval *tv > > tv->tv_sec = sec; > tv->tv_usec = usec; > + > + /* > +

Re: [PATCH] cross-architecture ELF clean up

2007-06-25 Thread Roman Zippel
Hi, On Wed, 20 Jun 2007, Jeremy Fitzhardinge wrote: > linux/elf-const.h - ELF constants, includable by asm code BTW who's the maniac who tries to use this in asm code? Many of these constants are pretty useless without the corresponding structure definitions. bye, Roman - To

Re: [PATCH] cross-architecture ELF clean up

2007-06-25 Thread Roman Zippel
Hi, On Mon, 25 Jun 2007, Clemens Koller wrote: > > glibc provides its own version, so it doesn't has to be exported at all. > > AFAIK the glibc folks want to rely more on the linux kernel headers > in the future and not provide more or less redundant headers anymore... In this case it's more

Re: [PATCH] cross-architecture ELF clean up

2007-06-25 Thread Roman Zippel
Hi, On Mon, 25 Jun 2007, David Woodhouse wrote: > On Wed, 2007-06-20 at 16:08 -0700, Jeremy Fitzhardinge wrote: > > This patch cleans up the ELF headers and their users. It does several > > related things: > > Looks good. We can get away with exporting a lot less of this to > userspace too,

Re: [PATCH] cross-architecture ELF clean up

2007-06-25 Thread Roman Zippel
Hi, On Wed, 20 Jun 2007, Jeremy Fitzhardinge wrote: > This patch cleans up the ELF headers and their users. It does several > related things: > > 1. split linux/elf.h into pieces > > This splits linux/elf.h into several pieces: > linux/elf.h - still the common elf header, >

Re: [patch 2/2] HFS+: Add custom dentry hash and comparison operations

2007-06-25 Thread Roman Zippel
-by: Duane Griffin <[EMAIL PROTECTED]> Signed-off-by: Roman Zippel <[EMAIL PROTECTED]> --- fs/hfsplus/btree.c |4 + fs/hfsplus/dir.c|2 fs/hfsplus/hfsplus_fs.h |4 + fs/hfsplus/inode.c |5 + fs/hfsplus/super.c |1

Re: [patch 1/2] HFS+: Refactor ASCII to unicode conversion routine for later reuse

2007-06-25 Thread Roman Zippel
ary memory allocation compared to using the string conversion routine directly in the new functions. Signed-off-by: Duane Griffin <[EMAIL PROTECTED]> Signed-off-by: Roman Zippel <[EMAIL PROTECTED]> --- fs/hfsplus/unicode.c | 105 +-- 1 f

Re: [patch 1/2] HFS+: Refactor ASCII to unicode conversion routine for later reuse

2007-06-25 Thread Roman Zippel
compared to using the string conversion routine directly in the new functions. Signed-off-by: Duane Griffin [EMAIL PROTECTED] Signed-off-by: Roman Zippel [EMAIL PROTECTED] --- fs/hfsplus/unicode.c | 105 +-- 1 file changed, 60 insertions(+), 45 deletions

Re: [patch 2/2] HFS+: Add custom dentry hash and comparison operations

2007-06-25 Thread Roman Zippel
PROTECTED] Signed-off-by: Roman Zippel [EMAIL PROTECTED] --- fs/hfsplus/btree.c |4 + fs/hfsplus/dir.c|2 fs/hfsplus/hfsplus_fs.h |4 + fs/hfsplus/inode.c |5 + fs/hfsplus/super.c |1 fs/hfsplus/unicode.c| 123

Re: [PATCH] cross-architecture ELF clean up

2007-06-25 Thread Roman Zippel
Hi, On Wed, 20 Jun 2007, Jeremy Fitzhardinge wrote: This patch cleans up the ELF headers and their users. It does several related things: 1. split linux/elf.h into pieces This splits linux/elf.h into several pieces: linux/elf.h - still the common elf header,

Re: [PATCH] cross-architecture ELF clean up

2007-06-25 Thread Roman Zippel
Hi, On Mon, 25 Jun 2007, David Woodhouse wrote: On Wed, 2007-06-20 at 16:08 -0700, Jeremy Fitzhardinge wrote: This patch cleans up the ELF headers and their users. It does several related things: Looks good. We can get away with exporting a lot less of this to userspace too, can't we?

Re: [PATCH] cross-architecture ELF clean up

2007-06-25 Thread Roman Zippel
Hi, On Mon, 25 Jun 2007, Clemens Koller wrote: glibc provides its own version, so it doesn't has to be exported at all. AFAIK the glibc folks want to rely more on the linux kernel headers in the future and not provide more or less redundant headers anymore... In this case it's more an ABI

Re: [PATCH] cross-architecture ELF clean up

2007-06-25 Thread Roman Zippel
Hi, On Wed, 20 Jun 2007, Jeremy Fitzhardinge wrote: linux/elf-const.h - ELF constants, includable by asm code BTW who's the maniac who tries to use this in asm code? Many of these constants are pretty useless without the corresponding structure definitions. bye, Roman - To

Re: [patch, v2.6.22-rc6] sys_time() speedup

2007-06-25 Thread Roman Zippel
Hi, On Monday 25 June 2007, Ingo Molnar wrote: the patch improves the sysbench OLTP macrobenchmark significantly: Has that any real practical relevance? @@ -373,6 +376,20 @@ void do_gettimeofday (struct timeval *tv tv-tv_sec = sec; tv-tv_usec = usec; + + /* + *

Re: [patch, v2.6.22-rc6] sys_time() speedup

2007-06-25 Thread Roman Zippel
Hi, On Mon, 25 Jun 2007, Jesper Juhl wrote: On Monday 25 June 2007, Ingo Molnar wrote: the patch improves the sysbench OLTP macrobenchmark significantly: Has that any real practical relevance? It seems to me that Ingo's patch offers slightly improved performance for any program

Re: [patch, v2.6.22-rc6] sys_time() speedup

2007-06-25 Thread Roman Zippel
Hi, On Tue, 26 Jun 2007, Jesper Juhl wrote: Even if it is not faster, what would make it slower? Have you spotted something I have not? There are other ways to read the clock and would require similiar synchronization hooks. Some archs can implement sys_time() in userspace, so there this

Re: Kconfig troubles when using menuconfig - Was: [patch]Re: [linux-usb-devel] linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301_core.c

2007-06-24 Thread Roman Zippel
Hi, On Sat, 23 Jun 2007, Jan Engelhardt wrote: > Would it make sense to define a new entity called "configmenu" (or something > else) that is equivalent to menuconfig with the following changes? > > * it creates a CM_ variable instead of a CONFIG_ one > * the CM_ symbols are not available to

Re: [PATCH] HFSPlus: simplify inode mode settting logic

2007-06-24 Thread Roman Zippel
Hi, On Sat, 23 Jun 2007, Wyatt Banks wrote: > Besides this redundancy, mode is the BSD file type and mode > bits (see Apple TechNote 1150 for details) and is never 0. This is wrong, there is an extra note: "If the S_IFMT field (upper 4 bits) of the fileMode field is zero, then Mac OS X

Re: [PATCH] HFSPlus: simplify inode mode settting logic

2007-06-24 Thread Roman Zippel
Hi, On Sat, 23 Jun 2007, Wyatt Banks wrote: Besides this redundancy, mode is the BSD file type and mode bits (see Apple TechNote 1150 for details) and is never 0. This is wrong, there is an extra note: If the S_IFMT field (upper 4 bits) of the fileMode field is zero, then Mac OS X assumes

Re: Kconfig troubles when using menuconfig - Was: [patch]Re: [linux-usb-devel] linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301_core.c

2007-06-24 Thread Roman Zippel
Hi, On Sat, 23 Jun 2007, Jan Engelhardt wrote: Would it make sense to define a new entity called configmenu (or something else) that is equivalent to menuconfig with the following changes? * it creates a CM_ variable instead of a CONFIG_ one * the CM_ symbols are not available to

Re: Kconfig troubles when using menuconfig - Was: [patch]Re: [linux-usb-devel] linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301_core.c

2007-06-22 Thread Roman Zippel
Hi, On Sat, 23 Jun 2007, Satyam Sharma wrote: > But why? Let it do just one thing, and do it well. Is their > any requirement anywhere that requires us to give a dual > meaning to these menuconfig objects -- i.e. to also control > the inclusion / exclusion of code from the kernel as well as >

Re: Kconfig troubles when using menuconfig - Was: [patch]Re: [linux-usb-devel] linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301_core.c

2007-06-22 Thread Roman Zippel
Hi, On Sat, 23 Jun 2007, Satyam Sharma wrote: > Yup, so how / why am I wrong? I was making the point that a > "menuconfig" does not have code associated with it. Which is wrong, it's not and will not be limited to this. bye, Roman - To unsubscribe from this list: send the line "unsubscribe

Re: Kconfig troubles when using menuconfig - Was: [patch]Re: [linux-usb-devel] linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301_core.c

2007-06-22 Thread Roman Zippel
Hi, On Sat, 23 Jun 2007, Satyam Sharma wrote: > 1. Kconfig symbols will always have code associated with them. > That's the entire purpose of Kconfig, is it not? A possible counter example: CONFIG_SCSI. (RAID_ATTRS is currently a little misplaced). It's optional for any config symbol to have

Re: Kconfig troubles when using menuconfig - Was: [patch]Re: [linux-usb-devel] linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301_core.c

2007-06-22 Thread Roman Zippel
Hi, On Sat, 23 Jun 2007, Satyam Sharma wrote: > > menuconfig is really a type of config symbol, rather than a type of menu. > > Well, I'd have to disagree here. A config symbol has code associated > with it (at least _all_ config symbols in the kernel originally did, till > when these

Re: Kconfig troubles when using menuconfig - Was: [patch]Re: [linux-usb-devel] linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301_core.c

2007-06-22 Thread Roman Zippel
Hi, On Sat, 23 Jun 2007, Satyam Sharma wrote: > given "menuconfig FOO depends on BAR", then all the "config BAZ"s > inside this menuconfig also automatically "depend on" BAR too. > This is simpler in the long run because it requires least amount > (actually none) of redundant typing I don't

Re: Kconfig troubles when using menuconfig - Was: [patch]Re: [linux-usb-devel] linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301_core.c

2007-06-22 Thread Roman Zippel
Hi, On Fri, 22 Jun 2007, Jan Engelhardt wrote: > V4L_USB_DRIVERS=y turns USB into =y? That can't be. It should give the "this > depends on another symbol [USB] that is modular". That's not how it works, the enclosed symbols depend now on V4L_USB_DRIVERS, which is a boolean and it can only have

Re: Kconfig troubles when using menuconfig - Was: [patch]Re: [linux-usb-devel] linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301_core.c

2007-06-22 Thread Roman Zippel
But if only want to enable a video driver, I likely don't want a radio driver... bye, Roman Reset generates values only if Kconfig and .config agree. Signed-off-by: Roman Zippel <[EMAIL PROTECTED]> --- scripts/kconfig/confdata.c | 37 ++--- 1 file

Re: Kconfig troubles when using menuconfig - Was: [patch]Re: [linux-usb-devel] linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301_core.c

2007-06-22 Thread Roman Zippel
Hi, On Fri, 22 Jun 2007, Mauro Carvalho Chehab wrote: > Hi Roman, > > Several instabilities on Kconfig started to happen after replacing > Kconfig menus to use menuconfig, as this one, reported by Oliver: > > Em Qui, 2007-06-21 às 13:50 +0200, Oliver Neukum escreveu: > > Am Donnerstag, 21.

Re: Kconfig troubles when using menuconfig - Was: [patch]Re: [linux-usb-devel] linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301_core.c

2007-06-22 Thread Roman Zippel
Hi, On Fri, 22 Jun 2007, Mauro Carvalho Chehab wrote: Hi Roman, Several instabilities on Kconfig started to happen after replacing Kconfig menus to use menuconfig, as this one, reported by Oliver: Em Qui, 2007-06-21 às 13:50 +0200, Oliver Neukum escreveu: Am Donnerstag, 21. Juni 2007

Re: Kconfig troubles when using menuconfig - Was: [patch]Re: [linux-usb-devel] linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301_core.c

2007-06-22 Thread Roman Zippel
Hi, On Fri, 22 Jun 2007, Jan Engelhardt wrote: V4L_USB_DRIVERS=y turns USB into =y? That can't be. It should give the this depends on another symbol [USB] that is modular. That's not how it works, the enclosed symbols depend now on V4L_USB_DRIVERS, which is a boolean and it can only have two

Re: Kconfig troubles when using menuconfig - Was: [patch]Re: [linux-usb-devel] linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301_core.c

2007-06-22 Thread Roman Zippel
likely don't want a radio driver... bye, Roman Reset generates values only if Kconfig and .config agree. Signed-off-by: Roman Zippel [EMAIL PROTECTED] --- scripts/kconfig/confdata.c | 37 ++--- 1 file changed, 26 insertions(+), 11 deletions(-) Index: linux-2.6

Re: Kconfig troubles when using menuconfig - Was: [patch]Re: [linux-usb-devel] linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301_core.c

2007-06-22 Thread Roman Zippel
Hi, On Sat, 23 Jun 2007, Satyam Sharma wrote: given menuconfig FOO depends on BAR, then all the config BAZs inside this menuconfig also automatically depend on BAR too. This is simpler in the long run because it requires least amount (actually none) of redundant typing I don't like this, as

Re: Kconfig troubles when using menuconfig - Was: [patch]Re: [linux-usb-devel] linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301_core.c

2007-06-22 Thread Roman Zippel
Hi, On Sat, 23 Jun 2007, Satyam Sharma wrote: menuconfig is really a type of config symbol, rather than a type of menu. Well, I'd have to disagree here. A config symbol has code associated with it (at least _all_ config symbols in the kernel originally did, till when these menuconfig

Re: Kconfig troubles when using menuconfig - Was: [patch]Re: [linux-usb-devel] linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301_core.c

2007-06-22 Thread Roman Zippel
Hi, On Sat, 23 Jun 2007, Satyam Sharma wrote: 1. Kconfig symbols will always have code associated with them. That's the entire purpose of Kconfig, is it not? A possible counter example: CONFIG_SCSI. (RAID_ATTRS is currently a little misplaced). It's optional for any config symbol to have any

Re: Kconfig troubles when using menuconfig - Was: [patch]Re: [linux-usb-devel] linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301_core.c

2007-06-22 Thread Roman Zippel
Hi, On Sat, 23 Jun 2007, Satyam Sharma wrote: Yup, so how / why am I wrong? I was making the point that a menuconfig does not have code associated with it. Which is wrong, it's not and will not be limited to this. bye, Roman - To unsubscribe from this list: send the line unsubscribe

Re: Kconfig troubles when using menuconfig - Was: [patch]Re: [linux-usb-devel] linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301_core.c

2007-06-22 Thread Roman Zippel
Hi, On Sat, 23 Jun 2007, Satyam Sharma wrote: But why? Let it do just one thing, and do it well. Is their any requirement anywhere that requires us to give a dual meaning to these menuconfig objects -- i.e. to also control the inclusion / exclusion of code from the kernel as well as also

Re: [PATCH for 2.6.22] [5/10] x86_64: Quieten Atari keyboard warnings in Kconfig

2007-06-20 Thread Roman Zippel
ig. Um, I thought it had been fixed already. (I'm a little busy with other things at the moment.) > Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> Acked-by: Roman Zippel <[EMAIL PROTECTED]> bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel&q

Re: [PATCH for 2.6.22] [5/10] x86_64: Quieten Atari keyboard warnings in Kconfig

2007-06-20 Thread Roman Zippel
already. (I'm a little busy with other things at the moment.) Signed-off-by: Andi Kleen [EMAIL PROTECTED] Acked-by: Roman Zippel [EMAIL PROTECTED] bye, Roman - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: kconfig - scan all Kconfig files

2007-05-22 Thread Roman Zippel
Hi, On Mon, 21 May 2007, Sam Ravnborg wrote: > > A simple example would be > > help texts, right now they are per symbol, but they should really be per > > menu, so archs can provide different help texts for something. > > This one turned out easy. > I assume what you had in mind was

Re: [RFC][PATCH] do_div_signed()

2007-05-22 Thread Roman Zippel
casts, so gcc can do better register allocation and generate better code. bye, Roman Signed-off-by: Roman Zippel <[EMAIL PROTECTED]> --- include/asm-generic/div64.h | 14 ++ include/asm-i386/div64.h| 20 include/linux/calc64.h | 28 ++

Re: [RFC][PATCH] do_div_signed()

2007-05-22 Thread Roman Zippel
allocation and generate better code. bye, Roman Signed-off-by: Roman Zippel [EMAIL PROTECTED] --- include/asm-generic/div64.h | 14 ++ include/asm-i386/div64.h| 20 include/linux/calc64.h | 28 kernel/time.c

Re: kconfig - scan all Kconfig files

2007-05-22 Thread Roman Zippel
Hi, On Mon, 21 May 2007, Sam Ravnborg wrote: A simple example would be help texts, right now they are per symbol, but they should really be per menu, so archs can provide different help texts for something. This one turned out easy. I assume what you had in mind was something like

Re: 2.6.22-rc2 built on ppc (2)

2007-05-21 Thread Roman Zippel
Hi, On Mon, 21 May 2007, Thomas Gleixner wrote: > diff --git a/kernel/time/ntp.c b/kernel/time/ntp.c > index cb25649..bb1bf86 100644 > --- a/kernel/time/ntp.c > +++ b/kernel/time/ntp.c > @@ -304,10 +304,12 @@ int do_adjtimex(struct timex *txc) > temp64 = time_offset <<

Re: 2.6.22-rc2 built on ppc (2)

2007-05-21 Thread Roman Zippel
Hi, On Mon, 21 May 2007, Thomas Gleixner wrote: diff --git a/kernel/time/ntp.c b/kernel/time/ntp.c index cb25649..bb1bf86 100644 --- a/kernel/time/ntp.c +++ b/kernel/time/ntp.c @@ -304,10 +304,12 @@ int do_adjtimex(struct timex *txc) temp64 = time_offset (SHIFT_NSEC

Re: 2.6.22-rc2 built on ppc (2)

2007-05-20 Thread Roman Zippel
Hi, On Sun, 20 May 2007, Andrew Morton wrote: > On Sun, 20 May 2007 13:08:15 +0200 Elimar Riesebieter <[EMAIL PROTECTED]> > wrote: > > > FYI, building 2.6.22-rc2 with > > gcc (GCC) 4.1.3 20070514 (prerelease) (Debian 4.1.2-7) > > on my powerbook (PPC) gives: > > > > ... > > kernel/time/ntp.c:

Re: kconfig - scan all Kconfig files

2007-05-20 Thread Roman Zippel
Hi, On Sun, 20 May 2007, Sam Ravnborg wrote: > I did a quick hack so kconfig could scan all Kconfig files > in the kernel tree. > By scanning all Kconfig files we gain the following: > > -> kconfig can report when a depends on refer to an undefined symbol > -> kconfig can report when a select

Re: RFC: kconfig select warnings bogus?

2007-05-20 Thread Roman Zippel
Hi, On Sat, 19 May 2007, Sam Ravnborg wrote: > We see a lot of these lately: > GEN /home/bor/build/linux-2.6.22/Makefile > scripts/kconfig/conf -s arch/i386/Kconfig > drivers/macintosh/Kconfig:116:warning: 'select' used by config symbol > 'PMAC_APM_EMU' refers to undefined symbol

Re: RFC: kconfig select warnings bogus?

2007-05-20 Thread Roman Zippel
Hi, On Sat, 19 May 2007, Sam Ravnborg wrote: We see a lot of these lately: GEN /home/bor/build/linux-2.6.22/Makefile scripts/kconfig/conf -s arch/i386/Kconfig drivers/macintosh/Kconfig:116:warning: 'select' used by config symbol 'PMAC_APM_EMU' refers to undefined symbol

Re: kconfig - scan all Kconfig files

2007-05-20 Thread Roman Zippel
Hi, On Sun, 20 May 2007, Sam Ravnborg wrote: I did a quick hack so kconfig could scan all Kconfig files in the kernel tree. By scanning all Kconfig files we gain the following: - kconfig can report when a depends on refer to an undefined symbol - kconfig can report when a select refer to

Re: 2.6.22-rc2 built on ppc (2)

2007-05-20 Thread Roman Zippel
Hi, On Sun, 20 May 2007, Andrew Morton wrote: On Sun, 20 May 2007 13:08:15 +0200 Elimar Riesebieter [EMAIL PROTECTED] wrote: FYI, building 2.6.22-rc2 with gcc (GCC) 4.1.3 20070514 (prerelease) (Debian 4.1.2-7) on my powerbook (PPC) gives: ... kernel/time/ntp.c: In function

Re: [RFC] select and dependencies in Kconfig

2007-05-17 Thread Roman Zippel
Hi, On Wed, 16 May 2007, Al Viro wrote: > On Tue, May 15, 2007 at 08:36:20PM +0100, Al Viro wrote: > > > > stuff that does select USB should depend on USB_ARCH_HAS_HCD, or we'll > > end up with unbuildable configs. > > BTW, this kind of situation happens often enough, so how about doing > the

Re: [RFC] select and dependencies in Kconfig

2007-05-17 Thread Roman Zippel
Hi, On Wed, 16 May 2007, Al Viro wrote: On Tue, May 15, 2007 at 08:36:20PM +0100, Al Viro wrote: stuff that does select USB should depend on USB_ARCH_HAS_HCD, or we'll end up with unbuildable configs. BTW, this kind of situation happens often enough, so how about doing the following:

Re: kconfig: error out if recursive dependencies are found

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Sam Ravnborg wrote: > We need to point out _one_ of the faulty spots only. The problem is you print only a random spot (which may not even be right one) of one of the involved symbols. We could actually print out the whole faulty chain, but it would require a few

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Jeff Garzik wrote: > Tough, the kernel community has voted against you. > > It makes far more sense to include a driver during kernel configuration, and > have that driver pull in its libraries via 'select'. The lame alternative > requires developers to know which

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Krzysztof Halasa wrote: > Roman Zippel <[EMAIL PROTECTED]> writes: > > > HDLC doesn't really look like simple library code, what's up with all the > > HDLC_* options? > > Sub-modules. So it's not simple library code, or is it? > A

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Jeff Garzik wrote: > > select seriously screws with the dependencies, it's especially problematic > > if the selected symbol has other dependencies as HDLC in this case, it makes > > it only more complicated to get the dependencies correct again. > > Please use it only if

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Krzysztof Halasa wrote: > Actually I can't see any bad idea here. > The original dependency was certainly, uhm, not the best one. select seriously screws with the dependencies, it's especially problematic if the selected symbol has other dependencies as HDLC in this

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Krzysztof Halasa wrote: > Roman Zippel <[EMAIL PROTECTED]> writes: > > > What's the advantage? The HDLC option is directly before this? > > You don't have to know it's required, you can just select a driver > for your hardware,

Re: [PATCH 1/3] WAN Kconfig: change depends on HDLC to select

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Krzysztof Halasa wrote: Roman Zippel [EMAIL PROTECTED] writes: HDLC doesn't really look like simple library code, what's up with all the HDLC_* options? Sub-modules. So it's not simple library code, or is it? Anyway, what does the patch screw exactly

Re: [PATCH 1/3] WAN Kconfig: change depends on HDLC to select

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Jeff Garzik wrote: Tough, the kernel community has voted against you. It makes far more sense to include a driver during kernel configuration, and have that driver pull in its libraries via 'select'. The lame alternative requires developers to know which libraries

Re: kconfig: error out if recursive dependencies are found

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Sam Ravnborg wrote: We need to point out _one_ of the faulty spots only. The problem is you print only a random spot (which may not even be right one) of one of the involved symbols. We could actually print out the whole faulty chain, but it would require a few

Re: [PATCH 1/3] WAN Kconfig: change depends on HDLC to select

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Krzysztof Halasa wrote: Roman Zippel [EMAIL PROTECTED] writes: What's the advantage? The HDLC option is directly before this? You don't have to know it's required, you can just select a driver for your hardware, without enabling HDLC first. Is this a real

Re: [PATCH 1/3] WAN Kconfig: change depends on HDLC to select

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Krzysztof Halasa wrote: Actually I can't see any bad idea here. The original dependency was certainly, uhm, not the best one. select seriously screws with the dependencies, it's especially problematic if the selected symbol has other dependencies as HDLC in this case,

Re: [PATCH 1/3] WAN Kconfig: change depends on HDLC to select

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Jeff Garzik wrote: select seriously screws with the dependencies, it's especially problematic if the selected symbol has other dependencies as HDLC in this case, it makes it only more complicated to get the dependencies correct again. Please use it only if it

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-06 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Krzysztof Halasa wrote: > Allow enabling WAN drivers without selecting generic HDLC first, > HDLC will be selected automatically. > > Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> > > diff --git a/drivers/net/wan/Kconfig b/drivers/net/wan/Kconfig > index

Re: kconfig: error out if recursive dependencies are found

2007-05-06 Thread Roman Zippel
Hi, On Sun, 6 May 2007, Sam Ravnborg wrote: > if (sym->flags & SYMBOL_CHECK) { > - printf("Warning! Found recursive dependency: %s", sym->name); > + fprintf(stderr, "%s:%d:error: found recursive dependency: %s", > + sym->prop->file->name,

Re: [PATCH] m68k: needs

2007-05-06 Thread Roman Zippel
Hi, On Sun, 6 May 2007, Geert Uytterhoeven wrote: > The recent cleanup uncovered that include/asm-m68k/scatterlist.h > needs to include > > Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> > --- > include/asm-m68k/scatterlist.h |2 ++ > 1 file changed, 2 insertions(+) > > ---

Re: [PATCH] m68k: asm/scatterlist.h needs asm/types.h

2007-05-06 Thread Roman Zippel
Hi, On Sun, 6 May 2007, Geert Uytterhoeven wrote: The recent linux/pci.h cleanup uncovered that include/asm-m68k/scatterlist.h needs to include asm/types.h Signed-off-by: Geert Uytterhoeven [EMAIL PROTECTED] --- include/asm-m68k/scatterlist.h |2 ++ 1 file changed, 2 insertions(+)

Re: kconfig: error out if recursive dependencies are found

2007-05-06 Thread Roman Zippel
Hi, On Sun, 6 May 2007, Sam Ravnborg wrote: if (sym-flags SYMBOL_CHECK) { - printf(Warning! Found recursive dependency: %s, sym-name); + fprintf(stderr, %s:%d:error: found recursive dependency: %s, + sym-prop-file-name, sym-prop-lineno,

Re: [PATCH 1/3] WAN Kconfig: change depends on HDLC to select

2007-05-06 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Krzysztof Halasa wrote: Allow enabling WAN drivers without selecting generic HDLC first, HDLC will be selected automatically. Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED] diff --git a/drivers/net/wan/Kconfig b/drivers/net/wan/Kconfig index 8897f53..3a2fe82

Re: [v4l-dvb-maintainer] [PATCH 35/36] Use menuconfig objects II - DVB

2007-05-03 Thread Roman Zippel
Hi, On Thu, 3 May 2007, Sam Ravnborg wrote: > Please include Roman Zippel when you propose kconfig changes. Thanks, the lkml volume lately forces me to skip a lot, so it's quite possible I miss something. :) > > xconfig has the menu tree display in the left panel, where on

<    1   2   3   4   5   6   7   8   9   10   >