Re: [PULL REQ] IXP4xx changes for Linux 3.7

2012-10-29 Thread Ryan Mallon
On 18/10/12 09:01, Krzysztof Halasa wrote: Hi, snip Unfortunately, as I already explained to you in https://lkml.org/lkml/2012/9/29/37, my resources for IXP4xx are very limited (and this isn't a paid job) and I'm in no way able to do what you require. This, coupled with my inability to

Re: BUG_ON/panic proliferation.

2012-09-27 Thread Ryan Mallon
of the pty drivers fails. Instead return an error and fail the module load. Signed-off-by: Ryan Mallon rmal...@gmail.com diff --git a/drivers/tty/pty.c b/drivers/tty/pty.c index 5505ffc..69af453 100644 --- a/drivers/tty/pty.c +++ b/drivers/tty/pty.c @@ -382,20 +382,21 @@ static const struct

Re: [PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization

2012-10-07 Thread Ryan Mallon
On 08/10/12 08:39, Joe Perches wrote: On Sun, 2012-10-07 at 20:56 +0200, Julia Lawall wrote: Some people thought that it would be nice to have the macros rather than the inlined field initializations, especially since there is no flag for write. A separate question is whether an array of one

Re: [PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization

2012-10-07 Thread Ryan Mallon
On 08/10/12 03:44, Julia Lawall wrote: On Sun, 7 Oct 2012, walter harms wrote: Am 07.10.2012 17:38, schrieb Julia Lawall: From: Julia Lawall julia.law...@lip6.fr Introduce use of I2c_MSG_READ/WRITE/OP, for readability. In the second i2c_msg structure, a length expressed as an explicit

Re: [PATCH 3/13] drivers/media/tuners/qt1010.c: use macros for i2c_msg initialization

2012-10-07 Thread Ryan Mallon
On 08/10/12 02:38, Julia Lawall wrote: From: Julia Lawall julia.law...@lip6.fr Introduce use of I2c_MSG_READ/WRITE/OP, for readability. A length expressed as an explicit constant is also re-expressed as the size of the buffer, when this is possible. A simplified version of the semantic

Re: [PATCH 5/13] drivers/media/tuners: use macros for i2c_msg initialization

2012-10-07 Thread Ryan Mallon
On 08/10/12 02:38, Julia Lawall wrote: From: Julia Lawall julia.law...@lip6.fr Introduce use of I2c_MSG_READ/WRITE/OP, for readability. A length expressed as an explicit constant is also re-expressed as the size of the buffer, when this is possible. A simplified version of the semantic

Re: [PATCH 12/13] drivers/media/tuners/max2165.c: use macros for i2c_msg initialization

2012-10-07 Thread Ryan Mallon
On 08/10/12 02:38, Julia Lawall wrote: From: Julia Lawall julia.law...@lip6.fr Introduce use of I2c_MSG_READ/WRITE/OP, for readability. A length expressed as an explicit constant is also re-expressed as the size of the buffer, when this is possible. The second case is simplified to use

Re: [PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization

2012-10-07 Thread Ryan Mallon
On 08/10/12 12:56, Mauro Carvalho Chehab wrote: Em Sun, 07 Oct 2012 14:51:58 -0700 Joe Perches j...@perches.com escreveu: On Sun, 2012-10-07 at 23:43 +0200, Julia Lawall wrote: On Sun, 7 Oct 2012, Joe Perches wrote: Are READ and WRITE the action names? They are really the important

Re: [PATCH 3/13] drivers/media/tuners/qt1010.c: use macros for i2c_msg initialization

2012-10-07 Thread Ryan Mallon
On 08/10/12 16:05, Julia Lawall wrote: On Mon, 8 Oct 2012, Ryan Mallon wrote: On 08/10/12 02:38, Julia Lawall wrote: From: Julia Lawall julia.law...@lip6.fr Introduce use of I2c_MSG_READ/WRITE/OP, for readability. A length expressed as an explicit constant is also re-expressed

Re: [PATCH] Staging: Android: logger: module_exit implementation

2012-11-04 Thread Ryan Mallon
On 02/11/12 17:15, Luca Clementi wrote: Created the module_exit for the android logger so that it can be loaded and unloaded as a module. Fixed module_init and some other minor issues. Signed-off-by: Luca Clementi luca.cleme...@gmail.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org

Re: [PATCH] Staging: Android: logger: module_exit implementationg

2012-11-04 Thread Ryan Mallon
On 04/11/12 04:45, Luca Clementi wrote: On Fri, Nov 2, 2012 at 11:29 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Thu, Nov 01, 2012 at 11:15:52PM -0700, Luca Clementi wrote: snip + vfree(current_log-buffer); + kfree(current_log-misc.name); +

Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

2012-11-07 Thread Ryan Mallon
On 06/11/12 08:40, Tabi Timur-B04825 wrote: On Mon, Nov 5, 2012 at 2:40 PM, Grant Likely grant.lik...@secretlab.ca wrote: Jane is building custom BeagleBone expansion boards called 'capes'. She can boot the system with a stock BeagleBoard device tree, but additional data is needed before a

Re: [PATCH 04/11] ARM: set arch_gettimeoffset directly

2012-11-08 Thread Ryan Mallon
-Christophe Plagniol-Villard plagn...@jcrosoft.com Cc: Hartley Sweeten hswee...@visionengravers.com Cc: Ryan Mallon rmal...@gmail.com Cc: Ben Dooks ben-li...@fluff.org Cc: Kukjin Kim kgene@samsung.com Signed-off-by: Stephen Warren swar...@nvidia.com --- arch/arm/include/asm/mach/time.h |3

Re: [RFC PATCH] gpiolib: Refactor gpio_export

2012-10-19 Thread Ryan Mallon
On 19/10/12 21:07, Linus Walleij wrote: On Wed, Oct 17, 2012 at 1:41 AM, Ryan Mallon rmal...@gmail.com wrote: The gpio_export function uses nested if statements and the status variable to handle the failure cases. This makes the function logic difficult to follow. Refactor the code to abort

[PATCH v2] gpiolib: Refactor gpio_export

2012-10-21 Thread Ryan Mallon
and number of split lines and makes the code easier to read. Signed-off-by: Ryan Mallon --- Changes since v1: - Return immediately if no unwinding needed - Added pr_debug to immediate returns - Changed unavailable (!requested || exported) to -EPERM diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio

Re: [PATCH v2] gpiolib: Refactor gpio_export

2012-10-22 Thread Ryan Mallon
On 23/10/12 09:13, Linus Walleij wrote: On Mon, Oct 22, 2012 at 2:39 AM, Ryan Mallon rmal...@gmail.com wrote: The gpio_export function uses nested if statements and the status variable to handle the failure cases. This makes the function logic difficult to follow. Refactor the code to abort

Re: [PATCH v2] Remove uninitialized_var()

2012-10-28 Thread Ryan Mallon
On 28/10/12 21:20, Ingo Molnar wrote: * Andrew Morton a...@linux-foundation.org wrote: On Sat, 27 Oct 2012 15:12:03 +0200 Ingo Molnar mi...@kernel.org wrote: There's 3 types of conversions done: uninitialized_var(x)= x = 0 /* for scalar types */ uninitialized_var(x)

Re: [PATCH 04/11] ARM: set arch_gettimeoffset directly

2012-11-09 Thread Ryan Mallon
On 10/11/12 08:07, Stephen Warren wrote: On 11/08/2012 04:06 PM, Ryan Mallon wrote: On 09/11/12 08:01, Stephen Warren wrote: remove ARM's struct sys_timer .offset function pointer, and instead directly set the arch_gettimeoffset function pointer when the timer driver is initialized

Re: [PATCH] vmxnet3: convert BUG_ON(true) into a simple BUG()

2012-11-11 Thread Ryan Mallon
On 09/11/12 07:23, Sasha Levin wrote: Signed-off-by: Sasha Levin sasha.le...@oracle.com --- drivers/net/vmxnet3/vmxnet3_drv.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index

Re: [PATCH] LDT - Linux Driver Template

2012-11-13 Thread Ryan Mallon
On 14/11/12 05:46, Constantine Shulyupin wrote: From: Constantine Shulyupin co...@makelinux.com LDT is useful for Linux driver development beginners, hackers and as starting point for a new drivers. The driver uses following Linux facilities: module, platform driver, file operations

Re: [PATCH RFC 1/6 v3] gpio: Add a block GPIO API to gpiolib

2012-10-14 Thread Ryan Mallon
On 13/10/12 06:11, Roland Stigge wrote: The recurring task of providing simultaneous access to GPIO lines (especially for bit banging protocols) needs an appropriate API. This patch adds a kernel internal Block GPIO API that enables simultaneous access to several GPIOs. This is done by

Re: [PATCH RFC 2/6 v3] gpio: Add sysfs support to block GPIO API

2012-10-14 Thread Ryan Mallon
On 13/10/12 06:11, Roland Stigge wrote: This patch adds sysfs support to the block GPIO API. Signed-off-by: Roland Stigge sti...@antcom.de Hi Roland, Some comments below, ~Ryan --- Documentation/ABI/testing/sysfs-gpio |6 drivers/gpio/gpiolib.c | 226

Re: [PATCH RFC 1/6 v3] gpio: Add a block GPIO API to gpiolib

2012-10-15 Thread Ryan Mallon
On 16/10/12 04:20, Roland Stigge wrote: Hi Ryan, thank you for your feedback, I will include it, except for some points noted below: + gbc-mask |= BIT(bit); + + /* collect gpios that are specified together, represented by +* neighboring bits +

Re: [PATCH RFC 01/11 v4] gpio: Add a block GPIO API to gpiolib

2012-10-15 Thread Ryan Mallon
On 16/10/12 10:31, Roland Stigge wrote: The recurring task of providing simultaneous access to GPIO lines (especially for bit banging protocols) needs an appropriate API. This patch adds a kernel internal Block GPIO API that enables simultaneous access to several GPIOs. This is done by

Re: [PATCH V2 RESEND] gpio: samsung: use pr_* instead of printk

2012-10-16 Thread Ryan Mallon
On 16/10/12 19:25, Jingoo Han wrote: This patch uses pr_* instead of printk. Also, gpio_dbg is replaced with pr_debug. Signed-off-by: Ryan Mallon rmal...@gmail.com If I recall correctly, I only offered review comments on this patch, I wasn't directly involved in writing

[RFC PATCH] gpiolib: Refactor gpio_export

2012-10-16 Thread Ryan Mallon
and number of split lines and makes the code easier to read. Signed-off-by: Ryan Mallon --- diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 5d6c71e..a142246 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -702,68 +702,74 @@ int gpio_export(unsigned gpio, bool

[GIT PULL] ep93xx-devel for 3.6

2012-07-17 Thread Ryan Mallon
Hi Arnd, Olof, The following changes since commit f8f5701bdaf9134b1f90e5044a82c66324d2073f: Linux 3.5-rc1 (2012-06-02 18:29:26 -0700) are available in the git repository at: git://github.com/RyanMallon/linux-ep93xx.git tags/ep93xx-devel-for-3.6 for you to fetch changes up to

Re: [PATCH] video: ep93xx_fb: include linux/io.h for devm_ioremap()

2013-03-15 Thread Ryan Mallon
Cc: Ryan Mallon rmal...@gmail.com Cc: Damien Cassou damien.cas...@lifl.fr Acked-by: Ryan Mallon rmal...@gmail.com --- drivers/video/ep93xx-fb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/ep93xx-fb.c b/drivers/video/ep93xx-fb.c index 3f2519d..e06cd5d 100644

Re: [PATCH 1/3] backlight: ep93xx_bl: fix section mismatch

2013-03-15 Thread Ryan Mallon
On 16/03/13 12:03, H Hartley Sweeten wrote: Remove the __init tag from ep93xxbl_probe() to fix the section mismatch warning. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ryan Mallon rmal...@gmail.com Cc: Richard Purdie rpur...@rpsys.net Cc: Florian Tobias Schandinat

Re: [PATCH 3/3] misc: ep93xx_pwm.c: fix section mismatch and use module_platform_driver

2013-03-16 Thread Ryan Mallon
-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ryan Mallon rmal...@gmail.com Cc: Arnd Bergmann a...@arndb.de Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Acked-by: Arnd Bergmann a...@arndb.de For the whole series: Acked-by: Ryan Mallon rmal...@gmail.com Not sure if I should

Re: [PATCH v3 3/3] backlight: as3711: add OF support

2013-03-25 Thread Ryan Mallon
On 26/03/13 09:40, Andrew Morton wrote: On Fri, 22 Mar 2013 17:15:49 +0100 Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Add support for configuring AS3711 backlight driver from DT. Signed-off-by: Guennadi Liakhovetski g.liakhovetski+rene...@gmail.com Reviwed-by: Mark Brown

Re: [PATCH v2 05/11] staging: refactoring request/free voice channels

2013-03-02 Thread Ryan Mallon
On 01/03/13 21:57, Michail Kurachkin wrote: From: Michail Kurochkin michail.kurach...@promwad.com Signed-off-by: Michail Kurochkin michail.kurach...@promwad.com --- drivers/staging/tdm/kirkwood_tdm.c | 162 +--- drivers/staging/tdm/kirkwood_tdm.h | 10

Re: [PATCH v2 16/31] workqueue: introduce workqueue_attrs

2013-03-05 Thread Ryan Mallon
On 05/03/13 05:37, Tejun Heo wrote: Introduce struct workqueue_attrs which carries worker attributes - currently the nice level and allowed cpumask along with helper routines alloc_workqueue_attrs() and free_workqueue_attrs(). Each worker_pool now carries -attrs describing the attributes of

Re: [PATCH v2 16/31] workqueue: introduce workqueue_attrs

2013-03-05 Thread Ryan Mallon
On 06/03/13 09:34, Tejun Heo wrote: On Tue, Mar 05, 2013 at 02:33:27PM -0800, Tejun Heo wrote: Hello, Ryan. On Wed, Mar 06, 2013 at 09:29:35AM +1100, Ryan Mallon wrote: @@ -148,6 +148,8 @@ struct worker_pool { struct mutexassoc_mutex;/* protect POOL_DISASSOCIATED

Re: [PATCH V2] backlight: ep93xx_bl: remove incorrect __init annotation

2013-03-05 Thread Ryan Mallon
On 04/03/13 20:02, Jingoo Han wrote: When platform_driver_probe() is not used, bind/unbind via sysfs is enabled. Thus, __init/__exit annotations should be removed from probe()/remove(). Signed-off-by: Jingoo Han jg1@samsung.com Acked-by: Ryan Mallon rmal...@gmail.com --- Changes

Re: [PATCH v2 16/31] workqueue: introduce workqueue_attrs

2013-03-05 Thread Ryan Mallon
On 06/03/13 09:44, Tejun Heo wrote: Hello, On Wed, Mar 06, 2013 at 09:40:48AM +1100, Ryan Mallon wrote: Ooh, right, and that cpumask_t is going away and you can't statically allocate cpumask_var_t, so it needs an allocation and error check from it anyway. Not sure I follow. I mean drop

Re: [PATCH v2 01/11] staging: Initial commit of TDM core

2013-03-01 Thread Ryan Mallon
On 01/03/13 21:50, Michail Kurachkin wrote: From: Michail Kurochkin michail.kurach...@promwad.com Signed-off-by: Michail Kurochkin michail.kurach...@promwad.com Hi Michail, Quick review below. I'll try to find some time to look through the other patches later. ~Ryan ---

Re: [PATCH v2 02/11] staging: Initial commit of Kirkwood TDM driver

2013-03-01 Thread Ryan Mallon
On 01/03/13 21:52, Michail Kurachkin wrote: From: Michail Kurochkin michail.kurach...@promwad.com Signed-off-by: Michail Kurochkin michail.kurach...@promwad.com --- drivers/staging/tdm/kirkwood_tdm.c | 932 drivers/staging/tdm/kirkwood_tdm.h | 110

Re: [PATCH 1/4] gpiolib: check descriptors validity before use

2013-02-13 Thread Ryan Mallon
On 13/02/13 18:02, Alexandre Courbot wrote: From: Alexandre Courbot acour...@nvidia.com Some functions dereferenced their GPIO descriptor argument without checking its validity first, potentially leading to an oops when given an invalid argument. This patch also makes gpio_get_value()

Re: [PATCH 4/4] gpiolib: rename local offset variables to hwgpio

2013-02-13 Thread Ryan Mallon
On 13/02/13 18:03, Alexandre Courbot wrote: From: Alexandre Courbot acour...@nvidia.com Their value being obtained by gpio_chip_hwgpio(), this better reflects their use. Signed-off-by: Alexandre Courbot acour...@nvidia.com --- drivers/gpio/gpiolib.c | 70

Re: [PATCH] ARM: ep93xx: Fix build error due to 'SZ_32M' undeclared

2012-09-06 Thread Ryan Mallon
Lin axel@gmail.com Signed-off-by: Ryan Mallon rmal...@gmail.com diff --git a/arch/arm/mach-ep93xx/adssphere.c b/arch/arm/mach-ep93xx/adssphere.c index a472777..41383bf 100644 --- a/arch/arm/mach-ep93xx/adssphere.c +++ b/arch/arm/mach-ep93xx/adssphere.c @@ -13,6 +13,7 @@ #include linux

[PATCH] ep93xx: Fix type error warnings in ts72xx build

2012-09-06 Thread Ryan Mallon
Add IOMEM defines for the TS72xx VIRT_BASE defines to fix type conversion warnings. Signed-off-by: Ryan Mallon rmal...@gmail.com --- diff --git a/arch/arm/mach-ep93xx/include/mach/ts72xx.h b/arch/arm/mach-ep93xx/include/mach/ts72xx.h index f1397a1..b30deb6 100644 --- a/arch/arm/mach-ep93xx

Re: [PATCH] ARM: ep93xx: Fix build error due to 'SZ_32M' undeclared

2012-09-07 Thread Ryan Mallon
On 07/09/12 15:48, Axel Lin wrote: Hi Axel, The patch looks fine. I notice that the other ep93xx boards are also using the SZ_ defines, but are indirectly including linux/sizes.h via asm/memory.h, which in turn is indirectly included via asm/io.h. That Seems this is also true for other

Re: [PATCH] gpio: samsung: use pr_* instead of printk

2012-09-11 Thread Ryan Mallon
On 10/09/12 21:59, Jingoo Han wrote: This patch uses pr_* instead of printk. Signed-off-by: Jingoo Han jg1@samsung.com --- drivers/gpio/gpio-samsung.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-samsung.c

Re: [PATCH] allow gpiolib to be a module

2012-09-11 Thread Ryan Mallon
On 10/09/12 22:16, Jan Beulich wrote: Without ARCH_REQUIRE_GPIOLIB there's no reason to force this code, when enabled, to always be built into the kernel, which requires only minor Makefile and source code adjustments. Signed-off-by: Jan Beulich jbeul...@suse.com --- snip +#ifdef

Re: [PATCH] gpio: samsung: use pr_* instead of printk

2012-09-11 Thread Ryan Mallon
On 11/09/12 16:39, Jingoo Han wrote: On Tuesday, September 11, 2012 3:31 PM Felipe Balbi wrote Hi, On Mon, Sep 10, 2012 at 08:59:11PM +0900, Jingoo Han wrote: This patch uses pr_* instead of printk. Signed-off-by: Jingoo Han jg1@samsung.com --- drivers/gpio/gpio-samsung.c |6

Re: [PATCH 1/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Ryan Mallon
On 17/09/12 23:58, Shubhrajyoti D wrote: Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com ---

Re: [PATCH 3/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Ryan Mallon
On 17/09/12 23:58, Shubhrajyoti D wrote: Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com ---

Re: [PATCH 3/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Ryan Mallon
On 17/09/12 23:58, Shubhrajyoti D wrote: Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com ---

Re: [PATCH 3/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Ryan Mallon
On 18/09/12 15:40, Shubhrajyoti wrote: On Tuesday 18 September 2012 07:21 AM, Ryan Mallon wrote: Actually, I wonder if it is useful to have something like:. Read and write differ only in the flag also it will be a deviation from what $SUBJECT would warrant. So could be a separate patch

Re: [PATCH 1/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-18 Thread Ryan Mallon
On 18/09/12 16:05, Shubhrajyoti wrote: On Tuesday 18 September 2012 07:14 AM, Ryan Mallon wrote: On 17/09/12 23:58, Shubhrajyoti D wrote: Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like

Re: [PATCH 03/16] ARM: ep93xx: move platform_data definitions

2012-09-11 Thread Ryan Mallon
Acked-by: Ryan Mallon rmal...@gmail.com Cc: Grant Likely grant.lik...@secretlab.ca Cc: Hartley Sweeten hswee...@visionengravers.com Cc: Ryan Mallon rmal...@gmail.com Cc: Jeff Garzik jgar...@pobox.com (supporter:SERIAL ATA Cc: Vinod Koul vinod.k...@intel.com Cc: Dan Williams d...@fb.com Cc

Re: [PATCH 04/24] ARM: ep93xx: use __iomem pointers for MMIO

2012-09-14 Thread Ryan Mallon
On 15/09/12 07:34, Arnd Bergmann wrote: ARM is moving to stricter checks on readl/write functions, so we need to use the correct types everywhere. Cc: Hartley Sweeten hswee...@visionengravers.com Cc: Ryan Mallon rmal...@gmail.com Signed-off-by: Arnd Bergmann a...@arndb.de Hi Arnd, Do

Re: [PATCH 1/3] proc: return -ENOMEM when inode allocation failed

2012-09-03 Thread Ryan Mallon
On 04/09/12 00:14, yan wrote: Signed-off-by: yan clouds@gmail.com --- fs/proc/generic.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/proc/generic.c b/fs/proc/generic.c index b3647fe..9e8f631 100644 --- a/fs/proc/generic.c +++ b/fs/proc/generic.c @@

Re: [PATCH 3/3] proc: use kzalloc instead of kmalloc and memset

2012-09-03 Thread Ryan Mallon
On 04/09/12 00:14, yan wrote: Signed-off-by: yan clouds@gmail.com --- fs/proc/generic.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/proc/generic.c b/fs/proc/generic.c index 9e8f631..38de015 100644 --- a/fs/proc/generic.c +++ b/fs/proc/generic.c @@

Re: Two question about kernel global function declaration and directory layout

2012-09-03 Thread Ryan Mallon
On 04/09/12 01:32, daley wrote: hi, everyone, I'm a big fan of the kernel, I was always being attracted by its clean and intelligent design. I'm new to the mailing list and this is my first post. I want to ask two basic question about kernel which bother me a lot, I've googled a lot but nobody

Re: [PATCH 05/11] fblog: register one fblog object per framebuffer

2012-08-14 Thread Ryan Mallon
On 14/08/12 21:01, David Herrmann wrote: Hi Ryan On Mon, Aug 13, 2012 at 1:54 AM, Ryan Mallon rmal...@gmail.com wrote: On 13/08/12 00:53, David Herrmann wrote: drivers/video/console/fblog.c | 195 ++ 1 file changed, 195 insertions(+) diff --git

Re: [PATCH] SubmittingPatches: clarify SOB tag usage when evolving submissions

2012-08-09 Thread Ryan Mallon
On 10/08/12 06:51, Luis R. Rodriguez wrote: From: Luis R. Rodriguez mcg...@do-not-panic.com Initial large code submissions typically are not accepted on their first patch submission. The developers are typically given feedback and at times some developers may even submit changes to the

Re: [PATCH 03/11] fblog: new framebuffer kernel log dummy driver

2012-08-12 Thread Ryan Mallon
On 13/08/12 00:53, David Herrmann wrote: Fblog displays all kernel log messages on all connected framebuffers. It replaces fbcon when CONFIG_VT=n is selected. Its main purpose is to debug boot problems by displaying the whole boot log on the screen. This patch provides the first dummy

Re: [PATCH 05/11] fblog: register one fblog object per framebuffer

2012-08-12 Thread Ryan Mallon
On 13/08/12 00:53, David Herrmann wrote: One fblog object is associated to each registered framebuffer. This way, we can draw the console to each framebuffer. When a framebuffer driver unregisters a framebuffer, we also unregister our fblog object. That is, our lifetime is coupled to the

Re: [PATCH 06/11] fblog: open fb on registration

2012-08-12 Thread Ryan Mallon
On 13/08/12 00:53, David Herrmann wrote: This opens the framebuffer upon registration so we can use it for drawing-operations. On unregistration we close it again. While opening/closing or accessing the fb in any other way, we must hold the fb-mutex. However, since the notifiers are often

Re: [PATCH 07/11] fblog: allow selecting fbs via sysfs and module-parameters

2012-08-12 Thread Ryan Mallon
On 13/08/12 00:53, David Herrmann wrote: fblog is mainly useful during boot, reboot, panics and maintenance. In all cases you often want to control which monitors are used for console output. Moreover, in multi-seat environments it is desireable to reduce system-overhead by not drawing the

Re: [PATCH v3 01/17] hashtable: introduce a small and naive hashtable

2012-08-22 Thread Ryan Mallon
On 23/08/12 04:01, Tejun Heo wrote: Hello, Sasha. On Wed, Aug 22, 2012 at 04:26:56AM +0200, Sasha Levin wrote: +#define DEFINE_HASHTABLE(name, bits) \ +struct hlist_head name[HASH_SIZE(bits)]; Shouldn't this be something like the following?

Re: [PATCH 5/5] Fixes a potential bug in android/logger.c

2012-08-01 Thread Ryan Mallon
On 01/08/12 14:54, Cruz Julian Bishop wrote: Previously, when calling is_between(a, b, c), the calculation was wrong. It counted C as between A and B if C was equal to B, but not A. Example of this are: is_between(1, 10, 10) = 1 (Expected: 0) is_between(1, 10, 1) = 0 (Expected: 0)

Re: /sys and access(2): Correctly implemented?

2012-07-08 Thread Ryan Mallon
On 06/07/12 16:27, Ulrich Windl wrote: Hi! Recently I found a problem with the command (kernel 3.0.34-0.7-default from SLES 11 SP2, run as root): test -r $file cat $file emitting Permission denied Investigating, I found that test actually uses access() to check for permissions.

Re: Antw: Re: /sys and access(2): Correctly implemented?

2012-07-09 Thread Ryan Mallon
On 09/07/12 16:23, Ulrich Windl wrote: Ryan Mallon rmal...@gmail.com schrieb am 09.07.2012 um 01:24 in Nachricht 4ffa16b6.9050...@gmail.com: On 06/07/12 16:27, Ulrich Windl wrote: Hi! Recently I found a problem with the command (kernel 3.0.34-0.7-default from SLES 11 SP2, run as root

Re: [PATCH v3] panel: Use pr_err(...) rather than printk(KERN_ERR ...)

2012-07-11 Thread Ryan Mallon
On 12/07/12 12:35, Toshiaki Yamane wrote: This change is inspired by checkpatch. Your changelog needs to describe all of the changes you are making. The subject line only describes one. This patch is doing the following: - Converting printk(KERN_ERR to pr_err - Adding __func__ prefixes to

Re: [PATCH 3/7] staging: rts_pstor: reuse kbasename()

2012-10-02 Thread Ryan Mallon
On 03/10/12 01:00, Andy Shevchenko wrote: The custom filename function mostly repeats the kernel's kbasename. This patch simplifies it. The updated filename() will not check for the '\' in the filenames. It seems redundant in Linux. Signed-off-by: Andy Shevchenko

Re: [PATCH 3/7] staging: rts_pstor: reuse kbasename()

2012-10-02 Thread Ryan Mallon
On 03/10/12 10:30, Ryan Mallon wrote: On 03/10/12 01:00, Andy Shevchenko wrote: The custom filename function mostly repeats the kernel's kbasename. This patch simplifies it. The updated filename() will not check for the '\' in the filenames. It seems redundant in Linux. Signed-off-by: Andy

Re: [PATCH] Change request_irq() to use struct net_device *dev-name

2013-07-24 Thread Ryan Mallon
On 24/07/13 16:09, Prashant Shah wrote: Signed-off-by: Prashant Shah pshah.mum...@gmail.com --- drivers/net/ethernet/8390/wd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/8390/wd.c b/drivers/net/ethernet/8390/wd.c index 03eb3ee..b43a63f

[PATCH 2/2] uinput: Use input_inject_event in uinput_inject_event

2013-09-10 Thread Ryan Mallon
Call input_inject_event rather than input_event in uinput_inject_event. This mirrors the behaviour of evdev_write. input_inject_event will ignore the injected event if the uinput input device has been grabbed for exclusive access by a handler other than uinput. Signed-off-by: Ryan Mallon rmal

[PATCH 1/2] uinput: Support injecting multiple events in one write() call

2013-09-10 Thread Ryan Mallon
Rework the code in uinput_inject_event so that it matches the code in evdev_write and allows injecting more than one event, or zero events. Signed-off-by: Ryan Mallon rmal...@gmail.com --- drivers/input/misc/uinput.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff

Re: [PATCH 2/2] uinput: Use input_inject_event in uinput_inject_event

2013-09-10 Thread Ryan Mallon
On 11/09/13 10:12, Dmitry Torokhov wrote: Hi Ryan, On Wed, Sep 11, 2013 at 09:32:53AM +1000, Ryan Mallon wrote: Call input_inject_event rather than input_event in uinput_inject_event. This mirrors the behaviour of evdev_write. input_inject_event will ignore the injected event if the uinput

Re: [PATCH 1/2] uinput: Support injecting multiple events in one write() call

2013-09-10 Thread Ryan Mallon
On 11/09/13 10:14, Dmitry Torokhov wrote: Hi Ryan, On Wed, Sep 11, 2013 at 09:32:52AM +1000, Ryan Mallon wrote: Rework the code in uinput_inject_event so that it matches the code in evdev_write and allows injecting more than one event, or zero events. Signed-off-by: Ryan Mallon rmal

Re: [PATCH 2/9] GenWQE: Remove option to select name

2013-11-04 Thread Ryan Mallon
On 05/11/13 04:08, Frank Haverkamp wrote: Selecting interface names via configuration option is obsolete. Don't do this. You are adding completely new code, so there is no reason to post a patch full of code that is known to be incorrect, followed by a set of patches fixing things. Just post the

Re: [PATCH 5/6] GenWQE Sysfs interfaces

2013-11-05 Thread Ryan Mallon
On 05/11/13 19:44, Frank Haverkamp wrote: Sysfs interfaces for the GenWQE card. There are attributes to query the version of the bitstream as well as some for the driver. For debugging, please also see the debugfs interfaces of this driver. Signed-off-by: Frank Haverkamp

Re: [PATCH 4/6] GenWQE Debugfs interfaces

2013-11-05 Thread Ryan Mallon
On 05/11/13 19:44, Frank Haverkamp wrote: Debugfs interfaces for the GenWQE card. Help to debug potential problems. Dump internal chip state for debugging and failure determination. Signed-off-by: Frank Haverkamp ha...@linux.vnet.ibm.com Co-authors: Joerg-Stephan Vogt jsv...@de.ibm.com,

Re: [PATCH] Staging : android: binder.c: Prefer seq_puts to seq_printf

2013-10-01 Thread Ryan Mallon
On 02/10/13 11:57, Mathieu Rhéaume wrote: This patch changes seq_printf for seq_puts in binder.c. It fixes the warnings emitted by checkpatch.pl. Signed-off-by: Mathieu Rhéaume math...@codingrhemes.com --- drivers/staging/android/binder.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [PATCH 1/2] procfs: restore 0400 permissions on /proc/*/{syscall,stack,personality}

2013-10-03 Thread Ryan Mallon
On 04/10/13 10:41, Kees Cook wrote: On Wed, Aug 28, 2013 at 1:49 PM, Kees Cook keesc...@chromium.org wrote: snip BTW, this just came to my attention: http://marc.info/?l=linux-kernelm=138049414321387w=2 Same problem, just for /proc/kallsyms. This would benefit from the open vs read cred

[PATCH 1/2] input: Return the number of bytes written so far on evdev write failure

2013-09-17 Thread Ryan Mallon
If input_event_from_user() fails in evdev write() and at least one event has been written successfully then return the number of bytes written. If no events have been written, then the EFAULT error is returned. Signed-off-by: Ryan Mallon rmal...@gmail.com --- drivers/input/evdev.c |3 ++- 1

[PATCH 2/2] uinput: Support injecting multiple events in one write() call

2013-09-17 Thread Ryan Mallon
Rework the code in uinput_inject_event so that it matches the code in evdev_write and allows injecting more than one event, or zero events. Signed-off-by: Ryan Mallon rmal...@gmail.com --- drivers/input/misc/uinput.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions

Re: [PATCH 2/2] uinput: Support injecting multiple events in one write() call

2013-09-18 Thread Ryan Mallon
On 19/09/13 05:48, Dmitry Torokhov wrote: Hi Ryan, On Wed, Sep 18, 2013 at 08:55:44AM +1000, Ryan Mallon wrote: Rework the code in uinput_inject_event so that it matches the code in evdev_write and allows injecting more than one event, or zero events. After some thinking I went back

Re: [RFC PATCH] fpga: Introduce new fpga subsystem

2013-09-18 Thread Ryan Mallon
On 19/09/13 01:56, Michal Simek wrote: This new subsystem should unify all fpga drivers which do the same things. Load configuration data to fpga or another programmable logic through common interface. It doesn't matter if it is MMIO device, gpio bitbanging, etc. connection. The point is to

[RFC PATCH] video: Use fb_sys_write rather than open-coding in drivers

2013-09-20 Thread Ryan Mallon
Several video drivers open code the fb_write write function with code which is very similar to fb_sys_write. Replace the open code versions with calls to fb_sys_write. An fb_sync callback is added to each of the drivers. Signed-off-by: Ryan Mallon rmal...@gmail.com --- diff --git a/drivers

Re: [PATCH 1/2 v3] ARM: ep93xx_defconfig: cleanup ep93xx_defconfig

2013-10-17 Thread Ryan Mallon
. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Acked-by: Ryan Mallon rmal...@gmail.com Cc: Ryan Mallon rmal...@gmail.com Cc: Alan Stern st...@rowland.harvard.edu Cc: Lennert Buytenhek ker...@wantstofly.org Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Olof Johansson

Re: [patch 7/9] mm: thrash detection-based file cache sizing

2013-11-25 Thread Ryan Mallon
On 25/11/13 10:38, Johannes Weiner wrote: The VM maintains cached filesystem pages on two types of lists. One list holds the pages recently faulted into the cache, the other list holds pages that have been referenced repeatedly on that first list. The idea is to prefer reclaiming young pages

Re: [PATCH v3a] vsprintf: Check real user/group id for %pK

2013-10-11 Thread Ryan Mallon
On 11/10/13 15:42, George Spelvin wrote: ebied...@xmission.com (Eric W. Biederman) wrote: Sigh. This is all wrong. The only correct thing to test is file-f_cred. Aka the capabilities of the program that opened the file. Which means that the interface to %pK in the case of kptr_restrict

Re: [PATCH v3a] vsprintf: Check real user/group id for %pK

2013-10-14 Thread Ryan Mallon
On 12/10/13 09:37, Eric W. Biederman wrote: Ryan Mallon rmal...@gmail.com writes: The only remaining problem is kernel/module.c:module_sect_show() which is used to write the sysfs files in /sys/module/modname/sections/. Those files are actually are really good target for leaking %pK values

Re: [PATCH v3a] vsprintf: Check real user/group id for %pK

2013-10-14 Thread Ryan Mallon
On 14/10/13 21:17, Djalal Harouni wrote: On Fri, Oct 11, 2013 at 02:19:14PM +1100, Ryan Mallon wrote: On 11/10/13 13:20, Eric W. Biederman wrote: Joe Perches j...@perches.com writes: Some setuid binaries will allow reading of files which have read permission by the real user id

Re: [PATCH] usb: ohci: remove ep93xx bus glue platform driver

2013-10-14 Thread Ryan Mallon
: Ryan Mallon rmal...@gmail.com --- diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index b3f20d7..2c8f2db 100644 --- a/drivers/usb/host/Kconfig +++ b/drivers/usb/host/Kconfig @@ -472,7 +472,7 @@ config USB_CNS3XXX_OHCI config USB_OHCI_HCD_PLATFORM tristate

[PATCH v4] vsprintf: Check real user/group id for %pK

2013-10-14 Thread Ryan Mallon
dmesg_restrict. Signed-off-by: Ryan Mallon rmal...@gmail.com Cc: sta...@vger.kernel.org --- This is a temporary solution only, but fixes a minor security hole when kptr_restrict=1. I am working to fix this properly, but there is still some discussion around how to achieve this, see here: https

Re: [PATCH] ARM: ep93xx: remove deprecated IRQF_DISABLED

2013-10-14 Thread Ryan Mallon
On 15/10/13 02:47, Hartley Sweeten wrote: On Friday, October 11, 2013 8:11 PM, Michael Opdenacker wrote: This patch proposes to remove the use of the IRQF_DISABLED flag It's a NOOP since 2.6.35 and it will be removed one day. Signed-off-by: Michael Opdenacker

Re: [PATCH] usb: ohci: remove ep93xx bus glue platform driver

2013-10-14 Thread Ryan Mallon
: Ryan Mallon rmal...@gmail.com Cc'ed Olof, who wanted to see what the patches looked like. I think the overall code reduction is probably worth the small increase in arch/arm code size. ~Ryan --- arch/arm/mach-ep93xx/clock.c | 2 +- arch/arm/mach-ep93xx/core.c| 45

Re: [RFC PATCH] video: Use fb_sys_write rather than open-coding in drivers

2014-02-11 Thread Ryan Mallon
On 12/02/14 03:06, Tomi Valkeinen wrote: On 20/09/13 10:06, Ryan Mallon wrote: Several video drivers open code the fb_write write function with code which is very similar to fb_sys_write. Replace the open code versions with calls to fb_sys_write. An fb_sync callback is added to each

Re: [RFC PATCH] video: Use fb_sys_write rather than open-coding in drivers

2014-02-11 Thread Ryan Mallon
On 12/02/14 19:54, Tomi Valkeinen wrote: On 11/02/14 21:07, Ryan Mallon wrote: On 12/02/14 03:06, Tomi Valkeinen wrote: On 20/09/13 10:06, Ryan Mallon wrote: Several video drivers open code the fb_write write function with code which is very similar to fb_sys_write. Replace the open code

Re: [PATCH v4] pwm: add sysfs interface

2013-06-11 Thread Ryan Mallon
On 11/06/13 20:14, Thierry Reding wrote: On Mon, Jun 10, 2013 at 04:12:07PM -0700, H Hartley Sweeten wrote: [...] +What: /sys/class/pwm/pwmchipN/pwmX/duty +Date: May 2013 +KernelVersion: 3.11 +Contact:H Hartley Sweeten hswee...@visionengravers.com

Re: [PATCH] pwm: add sysfs interface

2013-05-29 Thread Ryan Mallon
On 30/05/13 07:08, H Hartley Sweeten wrote: Add a simple sysfs interface to the PWM framework. /sys/class/pwm/ `-- pwmchipN/ for each PWM chip |-- export (w/o) ask the kernel to export a PWM to userspace |-- npwm (r/o) number of PWM in pwmchipN

Re: [PATCH v1.1] gpiolib: append SFI helpers for GPIO API

2013-06-02 Thread Ryan Mallon
On 31/05/13 19:27, Andy Shevchenko wrote: To support some (legacy) firmwares and platforms let's make life easier for their customers. This patch extracts SFI GPIO API from arch/x86/platform/mrst/mrst.c. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked-by: Len Brown

Re: Is spin_is_locked() safe to use with BUG_ON()/WARN_ON()?

2013-05-23 Thread Ryan Mallon
On 24/05/13 01:12, David Howells wrote: Linus Torvalds torva...@linux-foundation.org wrote: We do *not* want to add some crazy spin_is_nt_locked. We just want to get rid of these idiotic debug tests. Generally, I think you are right, though there are also some checks in deallocation

Re: [PATCH 00/14] misc/ep93xx_pwm: cleanup driver for conversion to PWM framework

2013-05-26 Thread Ryan Mallon
(-) Series looks fine to me. Reviewed-by: Ryan Mallon rmal...@gmail.com ~Ryan -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

  1   2   3   >