[PATCH 3/9] regulator: da9063: Add missing of_node_put

2014-02-17 Thread Sachin Kamat
Add of_node_put to decrement the ref count. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/da9063-regulator.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c index bfd7f2f795a6

[PATCH 2/9] regulator: as3722: Add missing of_node_put

2014-02-17 Thread Sachin Kamat
Add of_node_put to decrement the ref count. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/as3722-regulator.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/as3722-regulator.c b/drivers/regulator/as3722-regulator.c index 8b17d786cb71

[PATCH 1/1] tty: tty_ldisc.h: Remove duplicate include

2014-02-17 Thread Sachin Kamat
linux/wait.h was included twice. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- include/linux/tty_ldisc.h |1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/tty_ldisc.h b/include/linux/tty_ldisc.h index b8347c207cb8..add26da2faeb 100644 --- a/include/linux/tty_ldisc.h

[PATCH 02/15] regulator: ti-abb: Do not hardcode return value

2014-02-18 Thread Sachin Kamat
Propagate the error value returned by the function instead. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/ti-abb-regulator.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/ti-abb-regulator.c b/drivers/regulator/ti-abb

[PATCH 04/15] regulator: max8973: Remove redundant error message

2014-02-18 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/max8973-regulator.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/regulator/max8973-regulator.c b/drivers/regulator/max8973-regulator.c

[PATCH 01/15] regulator: wm8350: Do not hardcode return value

2014-02-18 Thread Sachin Kamat
Propagate the error value returned by the function instead. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/wm8350-regulator.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/wm8350-regulator.c b/drivers/regulator/wm8350

[PATCH 07/15] regulator: lp3971: Do not hardcode return value

2014-02-18 Thread Sachin Kamat
Propagate the error value returned by the function instead. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/lp3971.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/lp3971.c b/drivers/regulator/lp3971.c index 3b1102b75071

[PATCH 12/15] regulator: act8865: Remove redundant error message

2014-02-18 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/act8865-regulator.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/regulator/act8865-regulator.c b/drivers/regulator/act8865-regulator.c

[PATCH 11/15] regulator: 88pm800: Remove redundant error message

2014-02-18 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/88pm800.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/regulator/88pm800.c b/drivers/regulator/88pm800.c index d333f7eac106

[PATCH 13/15] regulator: arizona-ldo1: Remove redundant error message

2014-02-18 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/arizona-ldo1.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/regulator/arizona-ldo1.c b/drivers/regulator/arizona-ldo1.c index

[PATCH 15/15] regulator: as3711: Remove redundant error message

2014-02-18 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/as3711-regulator.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/regulator/as3711-regulator.c b/drivers/regulator/as3711-regulator.c

[PATCH 10/15] regulator: da9055: Do not hardcode return value

2014-02-18 Thread Sachin Kamat
Propagate the error value returned by the function instead. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/da9055-regulator.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/da9055-regulator.c b/drivers/regulator/da9055

[PATCH 09/15] regulator: da9063: Do not hardcode return values

2014-02-18 Thread Sachin Kamat
Propagate the error values returned by the function instead. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/da9063-regulator.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063

[PATCH 14/15] regulator: arizona-micsupp: Remove redundant error message

2014-02-18 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/arizona-micsupp.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/regulator/arizona-micsupp.c b/drivers/regulator/arizona-micsupp.c index

[PATCH 08/15] regulator: fan53555: Do not hardcode return values

2014-02-18 Thread Sachin Kamat
Propagate the error values returned by the function instead. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/fan53555.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/fan53555.c b/drivers/regulator/fan53555.c index

[PATCH 06/15] regulator: lp872x: Do not hardcode return values

2014-02-18 Thread Sachin Kamat
Propagate the error values returned by the function instead. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/lp872x.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/lp872x.c b/drivers/regulator/lp872x.c index 2e4734ff79fc

[PATCH 05/15] regulator: max8925: Do not hardcode return value

2014-02-18 Thread Sachin Kamat
Propagate the error value returned by the function instead. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/max8925-regulator.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/max8925-regulator.c b/drivers/regulator/max8925

[PATCH 03/15] regulator: ti-abb: Remove redundant error message

2014-02-18 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/ti-abb-regulator.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/regulator/ti-abb-regulator.c b/drivers/regulator/ti-abb

Re: [PATCH] pfuze100-regulator: Revert regulator: pfuze100: Use of_get_child_by_name

2014-02-18 Thread Sachin Kamat
On 18 February 2014 21:20, Fabio Estevam fabio.este...@freescale.com wrote: Since commit d7857c42 (regulator: pfuze100: Use of_get_child_by_name) we get the following probe failure: pfuze100-regulator 1-0008: Full layer: 1, Metal layer: 0 pfuze100-regulator 1-0008: FAB: 0, FIN: 0

Re: [PATCH 1/2] staging: android: binder: remove unnecessary comment

2014-02-18 Thread Sachin Kamat
On 19 February 2014 05:58, SeongJae Park sj38.p...@gmail.com wrote: On Wed, Feb 19, 2014 at 2:07 AM, Greg KH gre...@linuxfoundation.org wrote: On Tue, Feb 18, 2014 at 08:23:25PM +0900, SeongJae Park wrote: Signed-off-by: SeongJae Park sj38.p...@gmail.com --- drivers/staging/android/binder.c

Re: [PATCH] pfuze100-regulator: Revert regulator: pfuze100: Use of_get_child_by_name

2014-02-18 Thread Sachin Kamat
On 19 February 2014 07:42, Shawn Guo shawn@linaro.org wrote: On Tue, Feb 18, 2014 at 09:58:52PM +0530, Sachin Kamat wrote: On 18 February 2014 21:20, Fabio Estevam fabio.este...@freescale.com wrote: Since commit d7857c42 (regulator: pfuze100: Use of_get_child_by_name) we get

Re: [PATCH] pfuze100-regulator: Fix of_node_get() parameter

2014-02-18 Thread Sachin Kamat
@linaro.org Signed-off-by: Fabio Estevam fabio.este...@freescale.com Thanks for the fix Fabio. Acked-by: Sachin Kamat sachin.ka...@linaro.org Mark, There are a few more instances that should be fixed like this one. How would you prefer to handle them - Resend the complete patch or send just

Re: [PATCH v4 0/4] Bugfix for of_match_node ordering

2014-02-20 Thread Sachin Kamat
Hi Grant, I observe the following boot failure with today's (next-20140220) linux-next tree on Exynos based boards with the default exynos_defconfig. Uncompressing Linux... done, booting the kernel. [0.00] Booting Linux on physical CPU 0x900 [0.00] Linux version

[PATCH 02/23] regulator: da9210: Remove redundant error message

2014-02-20 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: S Twiss stwiss.opensou...@diasemi.com --- drivers/regulator/da9210-regulator.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/regulator/da9210-regulator.c

[PATCH 01/23] regulator: da9063: Remove redundant error message

2014-02-20 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Krystian Garbaciak krystian.garbac...@diasemi.com --- drivers/regulator/da9063-regulator.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/regulator/da9063

[PATCH 05/23] regulator: fixed: Remove redundant error message

2014-02-20 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/fixed.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c index 3c307d62fd31..c61f7e97e4f8

[PATCH 13/23] regulator: tps62360: Remove redundant error message

2014-02-20 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Laxman Dewangan ldewan...@nvidia.com --- drivers/regulator/tps62360-regulator.c |9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/regulator/tps62360

[PATCH 22/23] regulator: wm831x-ldo: Remove redundant error message

2014-02-20 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/wm831x-ldo.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/regulator/wm831x-ldo.c b/drivers/regulator/wm831x-ldo.c index

[PATCH 20/23] regulator: wm831x-dcdc: Remove redundant error message

2014-02-20 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/wm831x-dcdc.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/regulator/wm831x-dcdc.c b/drivers/regulator/wm831x-dcdc.c index

[PATCH 23/23] regulator: wm8994: Remove redundant error message

2014-02-20 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/wm8994-regulator.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/regulator/wm8994-regulator.c b/drivers/regulator/wm8994-regulator.c

[PATCH 21/23] regulator: wm831x-isink: Remove redundant error message

2014-02-20 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/wm831x-isink.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/regulator/wm831x-isink.c b/drivers/regulator/wm831x-isink.c index

[PATCH 18/23] regulator: tps65910: Remove redundant error message

2014-02-20 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Graeme Gregory g...@slimlogic.co.uk --- drivers/regulator/tps65910-regulator.c | 21 + 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/drivers/regulator

[PATCH 19/23] regulator: tps80031: Remove redundant error message

2014-02-20 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Laxman Dewangan ldewan...@nvidia.com --- drivers/regulator/tps80031-regulator.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/regulator/tps80031

[PATCH 16/23] regulator: tps6524x: Remove redundant error message

2014-02-20 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/tps6524x-regulator.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/tps6524x-regulator.c b/drivers/regulator/tps6524x

[PATCH 15/23] regulator: tps65090: Remove redundant error message

2014-02-20 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Venu Byravarasu vbyravar...@nvidia.com --- drivers/regulator/tps65090-regulator.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/regulator/tps65090

[PATCH 17/23] regulator: tps6586x: Remove redundant error message

2014-02-20 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Mike Rapoport m...@compulab.co.il --- drivers/regulator/tps6586x-regulator.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/regulator/tps6586x

[PATCH 14/23] regulator: tps6507x: Remove redundant error message

2014-02-20 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/tps6507x-regulator.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/regulator/tps6507x-regulator.c b/drivers/regulator/tps6507x

[PATCH 12/23] regulator: tps51632: Remove redundant error message

2014-02-20 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Laxman Dewangan ldewan...@nvidia.com --- drivers/regulator/tps51632-regulator.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/regulator/tps51632

[PATCH 11/23] regulator: s5m8767: Remove redundant error message

2014-02-20 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Sangbeom Kim sbki...@samsung.com --- drivers/regulator/s5m8767.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/regulator/s5m8767.c b/drivers

[PATCH 09/23] regulator: max8997: Remove redundant error message

2014-02-20 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/max8997.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/regulator/max8997.c b/drivers/regulator/max8997.c index 10108f2941e3..f657d8db9c0c 100644

[PATCH 10/23] regulator: rc5t583: Remove redundant error message

2014-02-20 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Laxman Dewangan ldewan...@nvidia.com --- drivers/regulator/rc5t583-regulator.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/regulator/rc5t583-regulator.c

[PATCH 08/23] regulator: max8952: Remove redundant error message

2014-02-20 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/max8952.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/regulator/max8952.c b/drivers/regulator/max8952.c index 788e5ae2af1b

[PATCH 07/23] regulator: max8907: Remove redundant error message

2014-02-20 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/max8907-regulator.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/max8907-regulator.c b/drivers/regulator/max8907

[PATCH 06/23] regulator: max77686: Remove redundant error message

2014-02-20 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/max77686.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/regulator/max77686.c b/drivers/regulator/max77686.c index b411af00065d..de020adf0568 100644

[PATCH 03/23] regulator: dbx500: Remove redundant error message

2014-02-20 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Sundar Iyer sundar.i...@stericsson.com --- drivers/regulator/dbx500-prcmu.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/regulator/dbx500-prcmu.c b

[PATCH 04/23] regulator: fan53555: Remove redundant error message

2014-02-20 Thread Sachin Kamat
kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Yunfan Zhang yfzh...@marvell.com --- drivers/regulator/fan53555.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/fan53555.c b/drivers/regulator

Re: [PATCH v4 0/4] Bugfix for of_match_node ordering

2014-02-20 Thread Sachin Kamat
Hi Kevin, On 20 February 2014 15:42, Kevin Hao haoke...@gmail.com wrote: On Thu, Feb 20, 2014 at 02:09:08PM +0530, Sachin Kamat wrote: Hi Grant, I observe the following boot failure with today's (next-20140220) linux-next tree on Exynos based boards with the default exynos_defconfig. Does

Re: [PATCH v4 0/4] Bugfix for of_match_node ordering

2014-02-20 Thread Sachin Kamat
On 20 February 2014 16:25, Kevin Hao haoke...@gmail.com wrote: On Thu, Feb 20, 2014 at 03:57:07PM +0530, Sachin Kamat wrote: Hi Kevin, On 20 February 2014 15:42, Kevin Hao haoke...@gmail.com wrote: On Thu, Feb 20, 2014 at 02:09:08PM +0530, Sachin Kamat wrote: Hi Grant, I observe

Re: [PATCH] regulator: max14577: Fix invalid return value on DT parse success

2014-02-21 Thread Sachin Kamat
Hi Krzysztof, On 20 February 2014 20:49, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: This fixes bug introduced in 667a6b7a (regulator: max14577: Add missing of_node_put). The DTS parsing function returned number of matched regulators as success status which then was compared against 0

Re: [PATCH] regulator: max14577: Fix invalid return value on DT parse success

2014-02-21 Thread Sachin Kamat
On 21 February 2014 16:12, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: On Fri, 2014-02-21 at 15:54 +0530, Sachin Kamat wrote: Hi Krzysztof, On 20 February 2014 20:49, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: This fixes bug introduced in 667a6b7a (regulator: max14577: Add

Re: [PATCH v3 3/3] Documentation: mfd: Add binding document for S2MPA01

2014-02-21 Thread Sachin Kamat
On 13 February 2014 12:07, Sachin Kamat sachin.ka...@linaro.org wrote: Added initial binding documentation for S2MPA01 MFD. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- Changes since v2: * Re-worded as suggested by Mark Rutland --- Documentation/devicetree/bindings/mfd/s2mpa01

Re: [PATCH v2] regulator: max14577: Fix invalid return value on DT parse success

2014-02-21 Thread Sachin Kamat
. Result was a probe fail after successful parsing the DTS: max14577-regulator: probe of max14577-regulator failed with error 2 Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Sachin Kamat sachin.ka...@linaro.org Looks good. Reviewed-by: Sachin Kamat sachin.ka...@linaro.org

Re: [PATCH v6 1/3] ARM: EXYNOS: Add support for EXYNOS5410 SoC

2014-02-10 Thread Sachin Kamat
Hi Tarek, Nothing in specific about the patch, but to just make you aware that some clean up patches haves been proposed which might cause conflicts with this patch. Please see inline for details. On 10 February 2014 15:38, Tarek Dakhran t.dakh...@samsung.com wrote: EXYNOS5410 is SoC in

Re: [PATCH v2] mfd: MAX6650/6651 support

2014-02-10 Thread Sachin Kamat
Hi Laszlo, If you are considering re-spinning this patch based on Lee's comments, please also consider my comments inline. On 8 February 2014 17:03, Laszlo Papp lp...@kde.org wrote: MAX6650/MAX6651 chip is a multi-function device with I2C busses. The chip includes fan-speed regulators and

Re: [PATCH v2] mfd: MAX6650/6651 support

2014-02-10 Thread Sachin Kamat
On 10 February 2014 17:51, Lee Jones lee.jo...@linaro.org wrote: +#include linux/device.h +#include linux/mfd/core.h +#include linux/module.h +#include linux/i2c.h Please arrange these alphabetically. Why? 1. It makes it easier to avoid adding duplicate includes. 2. Code looks more

Re: [PATCH v2] mfd: MAX6650/6651 support

2014-02-10 Thread Sachin Kamat
On 10 February 2014 18:48, Laszlo Papp lp...@kde.org wrote: On Mon, Feb 10, 2014 at 12:02 PM, Sachin Kamat sachin.ka...@linaro.org wrote: Hi Laszlo, If you are considering re-spinning this patch based on Lee's comments, please also consider my comments inline. Hi, sure, thanks. On 8

Re: [PATCH v1 0/1] Boot all secondary cores on Exynos SoC's

2014-02-10 Thread Sachin Kamat
Hi Tarek, On 11 February 2014 07:45, Tarek Dakhran t.dakh...@samsung.com wrote: Due to implementation of exynos_boot_secondary function only one secondary core boots on Exynos SoC's. Even without this patch I could boot the secondary CPUs on Exynos4210, 4412 and 5250 based boards with the

Re: [PATCH v1 0/1] Boot all secondary cores on Exynos SoC's

2014-02-11 Thread Sachin Kamat
] Brought up 4 CPUs [4.255000] SMP: Total of 4 processors activated. Regards, Sachin On Tue, Feb 11, 2014 at 3:17 PM, Sachin Kamat sachin.ka...@linaro.org wrote: Hi Tarek, On 11 February 2014 07:45, Tarek Dakhran t.dakh...@samsung.com wrote: Due to implementation of exynos_boot_secondary

Re: [PATCH v2] mfd: MAX6650/6651 support

2014-02-11 Thread Sachin Kamat
On 11 February 2014 15:40, Laszlo Papp lp...@kde.org wrote: [snip] + +struct max665x_dev { + struct device *dev; + struct mutex iolock; + + struct i2c_client *i2c; + struct regmap *map; + + int type; Unnecessary extra lines above could be removed. I

Re: [PATCH v2] mfd: MAX6650/6651 support

2014-02-11 Thread Sachin Kamat
On 11 February 2014 17:09, Laszlo Papp lp...@kde.org wrote: On Tue, Feb 11, 2014 at 11:14 AM, Sachin Kamat sachin.ka...@linaro.org wrote: On 11 February 2014 15:40, Laszlo Papp lp...@kde.org wrote: [snip] + +struct max665x_dev { + struct device *dev; + struct mutex iolock

Re: [PATCH v6] mfd: MAX6650/6651 support

2014-02-11 Thread Sachin Kamat
Hi Laszlo, Sorry for missing out on a couple of points during my earlier review. Please see inline. On 12 February 2014 09:32, Laszlo Papp lp...@kde.org wrote: MAX6650/MAX6651 chip is a multi-function device with I2C busses. The chip includes fan-speed regulators and monitors, GPIO, and alarm.

[PATCH 3/4] mfd: stw481x: Staticize stw481x_regmap_config

2014-02-12 Thread Sachin Kamat
stw481x_regmap_config is local to this file. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Linus Walleij linus.wall...@linaro.org --- drivers/mfd/stw481x.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/stw481x.c b/drivers/mfd/stw481x.c index

[PATCH 1/4] mfd: wm8400-core: Remove unnecessary goto

2014-02-12 Thread Sachin Kamat
Return directly to avoid redundant lines of code. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/mfd/wm8400-core.c | 22 +- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/drivers/mfd/wm8400-core.c b/drivers/mfd/wm8400-core.c index

[PATCH 4/4] mfd: stw481x: Check the return value of devm_regmap_init_i2c

2014-02-12 Thread Sachin Kamat
devm_regmap_init_i2c can fail. Check for it. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Linus Walleij linus.wall...@linaro.org --- drivers/mfd/stw481x.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/mfd/stw481x.c b/drivers/mfd/stw481x.c index cc42f88586f6

[PATCH 2/4] mfd: max14577: Include missing err.h

2014-02-12 Thread Sachin Kamat
Add this header explicitly for IS_ERR and friends. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/mfd/max14577.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c index 2ac2f2d7cea6..88cf5811ce3b 100644 --- a/drivers/mfd

Re: [PATCH v2 3/3] Documentation: mfd: Add binding document for S2MPA01

2014-02-12 Thread Sachin Kamat
On 9 January 2014 16:52, Sachin Kamat sachin.ka...@linaro.org wrote: Added initial binding documentation for S2MPA01 MFD. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- * Re-organised as suggested by Mark Rutland. --- Documentation/devicetree/bindings/mfd/s2mpa01.txt | 86

Re: [PATCH] ARM: S3C24XX: Fix typo CONFIG_CPUS_3C2443

2014-02-12 Thread Sachin Kamat
= { }; #endif -#if defined(CONFIG_CPUS_3C2443) || defined(CONFIG_CPU_S3C2416) +#if defined(CONFIG_CPU_S3C2443) || defined(CONFIG_CPU_S3C2416) This is definitely a typo and the current fix looks good. Reviewed-by: Sachin Kamat sachin.ka...@linaro.org -- With warm regards, Sachin

Re: [PATCH v2 2/3] regulator: Add support for S2MPA01 regulator

2014-02-12 Thread Sachin Kamat
On 12 February 2014 23:32, Mark Rutland mark.rutl...@arm.com wrote: On Thu, Jan 09, 2014 at 11:22:33AM +, Sachin Kamat wrote: Add support for S2MPA01 voltage and current regulator. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- * Addressed comments from Mark Brown - Used

Re: [PATCH v2 3/3] Documentation: mfd: Add binding document for S2MPA01

2014-02-12 Thread Sachin Kamat
Hi Mark, On 12 February 2014 23:40, Mark Rutland mark.rutl...@arm.com wrote: Hi Sachin, Apologies for the delay on this. No problem :). Thank you for your review. Please see my comments inline. On Thu, Jan 09, 2014 at 11:22:34AM +, Sachin Kamat wrote: Added initial binding

[PATCH v3 3/3] Documentation: mfd: Add binding document for S2MPA01

2014-02-12 Thread Sachin Kamat
Added initial binding documentation for S2MPA01 MFD. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- Changes since v2: * Re-worded as suggested by Mark Rutland --- Documentation/devicetree/bindings/mfd/s2mpa01.txt | 90 + 1 file changed, 90 insertions(+) create

[PATCH v3 2/3] regulator: Add support for S2MPA01 regulator

2014-02-12 Thread Sachin Kamat
Add support for S2MPA01 voltage and current regulator. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Acked-by: Mark Brown broo...@linaro.org --- Changes since v2: * Added missing of_node_put * Used of_get_child_by_name --- drivers/regulator/Kconfig |7 + drivers/regulator/Makefile

[PATCH v3 1/3] mfd: Add support for S2MPA01 device

2014-02-12 Thread Sachin Kamat
Add the necessary entries required for S2MPA01 multi-function device. While at it also convert whitespaces to tabs in core.h. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Acked-by: Lee Jones lee.jo...@linaro.org --- No change in v3 since v2. --- drivers/mfd/sec-core.c | 45

Re: [PATCH] mfd: sec-core: Fix I2C dummy device resource leak on probe failure

2014-03-18 Thread Sachin Kamat
-by: Sachin Kamat sachin.ka...@linaro.org -- With warm regards, Sachin -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH 2/4] regulator: max8660: Silence checkpatch warnings

2014-03-19 Thread Sachin Kamat
On 18 March 2014 18:09, Mark Brown broo...@kernel.org wrote: On Tue, Mar 18, 2014 at 03:53:02PM +0530, Sachin Kamat wrote: Silences the following type of error/warnings: ERROR: that open brace { should be on the previous line WARNING: Missing a blank line after declarations Applied

Re: [PATCH] mfd: sec-core: Fix uninitialized 'regmap_rtc' on S2MPA01

2014-03-19 Thread Sachin Kamat
/mfd/sec-core.c:342:45: warning: 'regmap_rtc' may be used uninitialized in this function [-Wuninitialized] Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com From the point of suppressing this warning and considering how it is done for S2MPS11, Acked-by: Sachin Kamat sachin.ka

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-19 Thread Sachin Kamat
On 19 March 2014 14:29, Cho KyongHo pullip@samsung.com wrote: On Tue, 18 Mar 2014 16:14:53 +0100, Tomasz Figa wrote: On 18.03.2014 12:09, Cho KyongHo wrote: On Fri, 14 Mar 2014 20:52:43 +0530, Sachin Kamat wrote: Hi KyongHo, On 14 March 2014 10:35, Cho KyongHo pullip@samsung.com

[PATCH 1/1] regulator: max8660: Fix brace alignment

2014-03-19 Thread Sachin Kamat
Move the }; to next line as is the general coding practice. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/regulator/max8660.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/max8660.c b/drivers/regulator/max8660.c index aabfb3b2407c

Re: [PATCH] drm/exynos: fix error return code in exynos_drm_ipp_set_property()

2013-05-07 Thread Sachin Kamat
Hi Wei Yongjun, On 7 May 2013 18:54, Wei Yongjun weiyj...@gmail.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. ipp_create_cmd_work() return ERR_PTR() on error and

[PATCH 1/2] regulator: isl6271a: Use NULL instead of 0

2013-05-08 Thread Sachin Kamat
init_data is a pointer. Use NULL instead of 0. Silences the following sparse warning: drivers/regulator/isl6271a-regulator.c:133:44: warning: Using plain integer as NULL pointer Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Marek Vasut marek.va...@gmail.com --- drivers/regulator

[PATCH 2/2] regulator: palmas: Fix incorrect condition

2013-05-08 Thread Sachin Kamat
Since 'id' cannot take two values at the same time, the condition should probably be an OR (||) instead of AND (). Introduced by commit 28d1e8cd67 (regulator: palma: add ramp delay support through regulator constraints). Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Laxman Dewangan

[PATCH 1/1] regulator: dbx500: Make local symbol static

2013-05-08 Thread Sachin Kamat
power_state_active_get is used only in this file. Make it static. While at it also move this function definition inside the CONFIG_REGULATOR_DEBUG macro as it is called only from within it. This also avoids further build warning related to unused definition. Signed-off-by: Sachin Kamat sachin.ka

Re: [PATCH 11/15] regulator: ti-abb: Convert to use devm_ioremap_resource

2013-06-10 Thread Sachin Kamat
On 10 June 2013 17:05, Tushar Behera tushar.beh...@linaro.org wrote: Commit 75096579c3ac (lib: devres: Introduce devm_ioremap_resource()) introduced devm_ioremap_resource() and deprecated the use of devm_request_and_ioremap(). Signed-off-by: Tushar Behera tushar.beh...@linaro.org CC: Mark

Re: [PATCH 01/15] sparc,leon: Convert to use devm_ioremap_resource

2013-06-10 Thread Sachin Kamat
On 10 June 2013 17:04, Tushar Behera tushar.beh...@linaro.org wrote: Commit 75096579c3ac (lib: devres: Introduce devm_ioremap_resource()) introduced devm_ioremap_resource() and deprecated the use of devm_request_and_ioremap(). Signed-off-by: Tushar Behera tushar.beh...@linaro.org CC:

Re: [PATCH 12/15] ASoC: spear: Convert to use devm_ioremap_resource

2013-06-10 Thread Sachin Kamat
On 10 June 2013 17:05, Tushar Behera tushar.beh...@linaro.org wrote: Commit 75096579c3ac (lib: devres: Introduce devm_ioremap_resource()) introduced devm_ioremap_resource() and deprecated the use of devm_request_and_ioremap(). This patch does a little more than just conversion. May that change

Re: [PATCH 13/15] pci: mvebu: Convert to use devm_ioremap_resource

2013-06-10 Thread Sachin Kamat
On 10 June 2013 17:05, Tushar Behera tushar.beh...@linaro.org wrote: Commit 75096579c3ac (lib: devres: Introduce devm_ioremap_resource()) introduced devm_ioremap_resource() and deprecated the use of devm_request_and_ioremap(). Signed-off-by: Tushar Behera tushar.beh...@linaro.org CC:

[PATCH 1/1] mfd: davinci_voicecodec: Convert to use devm_* APIs

2013-06-12 Thread Sachin Kamat
devm_* APIs are device managed and make code simpler. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Miguel Aguilar miguel.agui...@ridgerun.com --- Patch is based on mfd-next tree and compile tested. This driver gives following compilation error (not introduced by this patch): drivers

[PATCH Resend 1/1] mfd: davinci_voicecodec: Convert to use devm_* APIs

2013-06-12 Thread Sachin Kamat
devm_* APIs are device managed and make code simpler. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Miguel Aguilar miguel.agui...@ridgerun.com --- CC'd Lee Jones Patch is based on mfd-next tree and compile tested. This driver gives following compilation error (not introduced

[PATCH 1/1] mfd: 88pm860x: Use devm_regmap_init_i2c()

2013-06-12 Thread Sachin Kamat
devm_regmap_init_i2c() is device managed and makes cleanup simpler. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/mfd/88pm860x-core.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mfd/88pm860x-core.c b/drivers/mfd/88pm860x-core.c index ef6d82c

Re: [PATCH] pwm: Fill in missing .owner fields

2013-06-12 Thread Sachin Kamat
Hi Thierry, On 12 June 2013 16:59, Thierry Reding thierry.red...@gmail.com wrote: Some drivers don't set the .owner fields of the struct device_driver or struct pwm_ops, which causes the module usage count to become wrong. Recently a patch [1] was added to solve this issue of missing .owner

Re: [RFC: PATCH] err.h: silence warning when using IS_ERR on void __iomem *

2013-06-12 Thread Sachin Kamat
On 13 June 2013 03:01, Marc Kleine-Budde m...@pengutronix.de wrote: Commit 75096579c3ac (lib: devres: Introduce devm_ioremap_resource()) introduced devm_ioremap_resource() and encourage to check its return value with IS_ERR(). This however leads to the following sparse warnings, as

Re: [PATCH 09/15] net: can: Convert to use devm_ioremap_resource

2013-06-12 Thread Sachin Kamat
On 13 June 2013 11:00, Tushar Behera tushar.beh...@linaro.org wrote: On 06/10/2013 05:05 PM, Tushar Behera wrote: Commit 75096579c3ac (lib: devres: Introduce devm_ioremap_resource()) introduced devm_ioremap_resource() and deprecated the use of devm_request_and_ioremap(). Signed-off-by:

Re: [PATCH Resend 1/1] mfd: davinci_voicecodec: Convert to use devm_* APIs

2013-06-13 Thread Sachin Kamat
Hi Lee, On 13 June 2013 16:19, Lee Jones lee.jo...@linaro.org wrote: On Wed, 12 Jun 2013, Sachin Kamat wrote: devm_* APIs are device managed and make code simpler. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Miguel Aguilar miguel.agui...@ridgerun.com --- CC'd Lee Jones Can

Re: [PATCH Resend 1/1] mfd: davinci_voicecodec: Convert to use devm_* APIs

2013-06-14 Thread Sachin Kamat
On 14 June 2013 12:36, Lee Jones lee.jo...@linaro.org wrote: On Fri, 14 Jun 2013, Sachin Kamat wrote: Hi Lee, On 13 June 2013 16:19, Lee Jones lee.jo...@linaro.org wrote: On Wed, 12 Jun 2013, Sachin Kamat wrote: devm_* APIs are device managed and make code simpler. Signed-off

[PATCH Resend] mfd: davinci_voicecodec: Convert to use devm_* APIs

2013-06-14 Thread Sachin Kamat
devm_* APIs are device managed and make code simpler. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Miguel Aguilar miguel.agui...@ridgerun.com --- Patch is based on mfd-next tree and compile tested. This driver gives following compilation error (not introduced by this patch): drivers

[PATCH 1/1] pinctrl: exynos: Fix build breakage

2013-06-17 Thread Sachin Kamat
] exynos_wkup_irq_ack(irqd); Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Doug Anderson diand...@chromium.org --- drivers/pinctrl/pinctrl-exynos.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/pinctrl/pinctrl-exynos.c b/drivers

[PATCH Resend] pinctrl: exynos: Fix build breakage

2013-06-17 Thread Sachin Kamat
] exynos_wkup_irq_ack(irqd); Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Doug Anderson diand...@chromium.org --- Fixed the commit message. --- drivers/pinctrl/pinctrl-exynos.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/pinctrl

Re: [PATCH Resend] pinctrl: exynos: Fix build breakage

2013-06-17 Thread Sachin Kamat
On 17 June 2013 16:55, Linus Walleij linus.wall...@linaro.org wrote: On Mon, Jun 17, 2013 at 11:38 AM, Sachin Kamat sachin.ka...@linaro.org wrote: 'exynos_wkup_irq_ack' should be defined ahead of its call. Fixes the following error: drivers/pinctrl/pinctrl-exynos.c: In function

Re: [PATCH] Allow binding drivers/uio/uio_pdrv_genirq.c to devices using command line option

2013-06-17 Thread Sachin Kamat
Hi Greg, On 17 June 2013 23:07, Greg KH gre...@linuxfoundation.org wrote: On Mon, Jun 17, 2013 at 03:47:41PM +0200, Pavel Machek wrote: Hi! This adds ability to bind uio driver to given open firmware device using command line option. Thus, userspace driver can be developed and used

Re: [PATCH Resend 1/1] mfd: davinci_voicecodec: Convert to use devm_* APIs

2013-06-18 Thread Sachin Kamat
Hi Samuel, On 18 June 2013 14:10, Samuel Ortiz sa...@linux.intel.com wrote: Hi Sachin, On Wed, Jun 12, 2013 at 01:49:42PM +0530, Sachin Kamat wrote: devm_* APIs are device managed and make code simpler. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Miguel Aguilar miguel.agui

[PATCH 3/4] pinctrl: spear/plgpio: Staticize spear310_o2p

2013-06-18 Thread Sachin Kamat
'spear310_o2p' is referenced only in this file. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Viresh Kumar viresh.ku...@linaro.org --- drivers/pinctrl/spear/pinctrl-plgpio.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/spear/pinctrl-plgpio.c b

<    1   2   3   4   5   6   7   8   9   10   >