[PATCHv2 1/2] firmware: add request_firmware_nowait_nowarn function

2018-07-04 Thread Sebastian Reichel
firmware). This is based on previous work from Rafał Miłecki . Signed-off-by: Sebastian Reichel --- drivers/base/firmware_loader/main.c | 40 - include/linux/firmware.h| 12 + 2 files changed, 45 insertions(+), 7 deletions(-) diff --git a/drivers/base

[PATCHv2 2/2] dmaengine: imx-sdma: request firmware with FW_OPT_NO_WARN

2018-07-04 Thread Sebastian Reichel
Request firmware with FW_OPT_NO_WARN. The driver works without the firmware by using the one supplied in ROM. There is already an info message, that informs about this. Signed-off-by: Sebastian Reichel --- drivers/dma/imx-sdma.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions

[PATCHv2 0/2] Avoid firmware warning in imx-sdma

2018-07-04 Thread Sebastian Reichel
/20180628031332.ge21...@wotan.suse.de/ -- Sebastian Sebastian Reichel (2): firmware: add request_firmware_nowait_nowarn function dmaengine: imx-sdma: request firmware with FW_OPT_NO_WARN drivers/base/firmware_loader/main.c | 40 - drivers/dma/imx-sdma.c

Re: [GIT PULL] Immutable branch between MFD and Power? due for the v4.19 merge window

2018-07-05 Thread Sebastian Reichel
Hi, On Wed, Jul 04, 2018 at 07:12:46AM +0100, Lee Jones wrote: > Apologies for the delay -- these two patches dropped from my radar. Thanks, merged. -- Sebastian > > Enjoy! > > The following changes since commit ce397d215ccd07b8ae3f71db689aedb85d56ab40: > > Linux 4.18-rc1 (2018-06-17 08:04

Re: [PATCH v4 2/3] power: supply: add cros-ec USBPD charger driver.

2018-07-05 Thread Sebastian Reichel
Hi, On Wed, May 02, 2018 at 05:44:17PM +0200, Enric Balletbo i Serra wrote: > From: Sameer Nanda > > This driver gets various bits of information about what is connected to > USB PD ports from the EC and converts that into power_supply properties. > > Signed-off-by: Sameer Nanda > Signed-off-b

Re: droid 4: connection refused from voltage_now

2018-07-06 Thread Sebastian Reichel
Hi, On Wed, Jul 04, 2018 at 09:52:38PM +0200, Pavel Machek wrote: > On Wed 2018-07-04 21:45:56, Ladislav Michl wrote: > > On Wed, Jul 04, 2018 at 07:11:56PM +0200, Pavel Machek wrote: > > > Hi! > > > > > > I started to use droid 4 as my primary phone... so I have battery > > > monitor running for

Re: [PATCH 1/2] power: supply: sbs-battery: don't assume MANUFACTURER_DATA formats

2018-07-06 Thread Sebastian Reichel
Hi, On Tue, Jun 12, 2018 at 01:20:41PM -0700, Brian Norris wrote: > This driver was originally submitted for the TI BQ20Z75 battery IC > (commit a7640bfa10c5 ("power_supply: Add driver for TI BQ20Z75 gas gauge > IC")) and later renamed to express generic SBS support. While it's > mostly true that

Re: [PATCH 2/2] dt-bindings: power: sbs-battery: re-document "ti,bq20z75"

2018-07-06 Thread Sebastian Reichel
Hi, On Tue, Jun 12, 2018 at 01:20:42PM -0700, Brian Norris wrote: > This compatible property was documented before the driver was renamed to > "SBS" (see commit e57f1b68c406 ("devicetree-bindings: Propagate > bq20z75->sbs rename to dt bindings")). The driver has continued to > support this propert

Re: [PATCH] power: supply: tps65217: Switch to SPDX identifier.

2018-07-06 Thread Sebastian Reichel
Hi, On Tue, Jun 05, 2018 at 12:00:21PM +0200, Enric Balletbo i Serra wrote: > Adopt the SPDX license identifier headers to ease license compliance > management. > > Signed-off-by: Enric Balletbo i Serra > --- Thanks, queued to power-supply-next. -- Sebastian signature.asc Description: PGP si

Re: [PATCH] power: reset: zx-reboot: put device node in zx_reboot_probe()

2018-07-06 Thread Sebastian Reichel
Hi, On Sun, Jun 03, 2018 at 01:22:05AM +0300, Alexey Khoroshilov wrote: > zx_reboot_probe() increments refcnt of zx296702-pcu device node by > of_find_compatible_node() and leaves it undecremented on both > successful and error paths. > > Found by Linux Driver Verification project (linuxtesting.o

Re: [PATCH] power: supply: max1721x: fix spelling mistake "RSenese" -> "RSense"

2018-07-06 Thread Sebastian Reichel
Hi, On Sat, May 26, 2018 at 02:56:06PM +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in dev_warn message text > > Signed-off-by: Colin Ian King > --- Thanks, queued to power-supply-next. -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v4 4/5] power: supply: ds2760_battery: merge ds2760 supply driver with its w1 slave companion

2018-07-06 Thread Sebastian Reichel
back. > > Signed-off-by: Daniel Mack > --- Acked-for-power-supply: Sebastian Reichel -- Sebastian > drivers/power/supply/Kconfig | 2 +- > drivers/power/supply/ds2760_battery.c | 321 ++ > drivers/w1/slaves/Kconfig | 12 - > drivers/

Re: [PATCH v4 5/5] power: supply: ds2760_battery: add devicetree probing

2018-07-06 Thread Sebastian Reichel
Hi, On Fri, Jul 06, 2018 at 07:35:52AM +0200, Daniel Mack wrote: > Add a matching table for devicetree probing, and optionally set the module > parameter variables from DT properties. > > Signed-off-by: Daniel Mack > --- Acked-for-power-supply: Sebastian Reichel -- Sebast

Re: [PATCH v4 3/5] w1: core: match sub-nodes of bus masters in devicetree

2018-07-06 Thread Sebastian Reichel
Hi Greg & Evgeniy, I suggest, that I take this patch and the DT bindings together with the power-supply changes, once the bindings have been reviewed by Rob (Herring). I will prepare an immutable branch, that can be pulled into w1 as needed. Are you fine with this? -- Sebastian On Fri, Jul 06, 2

Re: [PATCH] power: remove possible deadlock when unregistering power_supply

2018-07-06 Thread Sebastian Reichel
Hi, On Mon, Jun 25, 2018 at 09:51:48AM +0200, Benjamin Tissoires wrote: > If a device gets removed right after having registered a power_supply node, > we might enter in a deadlock between the remove call (that has a lock on > the parent device) and the deferred register work. > > Allow the defer

Re: [PATCH] power: supply: ab8500: stop using getnstimeofday64()

2018-07-06 Thread Sebastian Reichel
Hi, On Mon, Jun 18, 2018 at 04:23:29PM +0200, Arnd Bergmann wrote: > getnstimeofday64() is deprecated in favor of the ktime_get() family. > > The direct replacement would be ktime_get_real_ts64(), but we only need > the seconds value, and it seems better to use boottime than real time > to avoid

Re: [PATCH 0/2] power: generic-adc-battery: fix out of bounds write

2018-07-06 Thread Sebastian Reichel
Hi, On Tue, Jun 26, 2018 at 03:28:28PM +0200, H. Nikolaus Schaller wrote: > This patch set addresses two bugs in the gab_probe() function which are > there since the first commit in 3.7-rc1: > > 1. there is an out of bounds write access by a miscalculated destination >address for the memcpy()

Re: [PATCH] power: supply: ltc2941-battery-gauge: Release device_node in ltc294x_i2c_probe()

2018-07-06 Thread Sebastian Reichel
Hi, On Tue, May 08, 2018 at 10:16:31PM +0300, Alexey Khoroshilov wrote: > On 01.05.2018 15:39, Sebastian Reichel wrote: > > On Sun, Apr 29, 2018 at 01:35:55AM +0300, Alexey Khoroshilov wrote: > >> There is of_node_get(client->dev.of_node) in ltc294x_i2c_probe(), > >&g

Re: [PATCH v4 2/2] dt-bindings: power: sbs-battery: re-document "ti,bq20z75"

2018-06-12 Thread Sebastian Reichel
Hi, On Fri, Jun 08, 2018 at 03:36:55PM -0700, Brian Norris wrote: > This compatible property was documented before the driver was renamed to > "SBS" (see commit e57f1b68c406 ("devicetree-bindings: Propagate > bq20z75->sbs rename to dt bindings")). The driver has continued to > support this propert

Re: [PATCH 1/2] power: supply: sbs-battery: don't assume MANUFACTURER_DATA formats

2018-06-13 Thread Sebastian Reichel
Hi Brian, On Tue, Jun 12, 2018 at 01:23:25PM -0700, Brian Norris wrote: > Eek, sorry this series should have subjects "[PATCH v5 X/2] ...". I > can resend if really needed, but hopefully by now this is ready to > go... No need to resend. Patches look fine to me, but we are currently in the merge

[PATCH] power: supply: isp1704: switch to gpiod API

2018-12-12 Thread Sebastian Reichel
described here: Documentation/driver-api/gpio/board.rst Signed-off-by: Sebastian Reichel --- Patch has been tested on Nokia N900. --- drivers/power/supply/isp1704_charger.c | 60 ++ include/linux/power/isp1704_charger.h | 30 - 2 files changed, 12 insertions

Re: [PATCH 2/7] drm: omapdrm: Cleanup drm_display_mode print str

2018-12-19 Thread Sebastian Reichel
-- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/omap_connector.c | 9 ++--- > drivers/gpu/drm/omapdrm/omap_crtc.c | 8 ++-- > 2 files changed, 4 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/omap_connector.

Re: [PATCH v3] MAINTAINERS: add maintainers for ChromeOS EC sub-drivers

2018-12-14 Thread Sebastian Reichel
d-off-by: Enric Balletbo i Serra > Signed-off-by: Benson Leung > Acked-by: Wolfram Sang > Acked-by: Chanwoo Choi > Acked-by: Jonathan Cameron for iio parts. > Acked-by: Alexandre Belloni > Acked-by: Lee Jones > --- Acked-by: Sebastian Reichel -- Sebastian > > Cha

Re: [PATCH v5 3/3] Input: atmel_mxt_ts: Document optional voltage regulators

2018-12-16 Thread Sebastian Reichel
Hi, On Fri, Dec 14, 2018 at 04:12:14PM +0100, Paweł Chmiel wrote: > Document new optional voltage regulators, which can be used > to power down/up touchscreen. > > Signed-off-by: Paweł Chmiel > Reviewed-by: Rob Herring Reviewed-by: Sebastian Reichel -- Sebastian > ---

Re: Droid 4: poweroff does not work? calls

2018-12-10 Thread Sebastian Reichel
Hi, On Sun, Dec 09, 2018 at 01:13:18PM +0100, Pavel Machek wrote: > Poweroff does not seem to work on Motorola droid 4 -- it reboots. It > seems to be problem "forever", 4.18 and 4.20-rc5 seem to be > affected. It is bad, because when your battery is low, you get into > reboot loop and discharge i

Re: [PATCH v2] MAINTAINERS: add maintainers for ChromeOS EC sub-drivers

2018-12-11 Thread Sebastian Reichel
Hi, On Tue, Dec 11, 2018 at 08:09:52PM +0100, Enric Balletbo i Serra wrote: > There are multiple ChromeOS EC sub-drivers spread in different > subsystems, as all of them are related to the Chrome stuff add > Benson and myself as a maintainers for all these sub-drivers. > > Signed-off-by: Enric Ba

[PATCH 06/14] media: wl128x-radio: remove global radio_dev

2018-12-20 Thread Sebastian Reichel
From: Sebastian Reichel Move global radio_dev into device structure to prepare converting this driver into a normal platform device driver supporting multiple instances. Signed-off-by: Sebastian Reichel --- drivers/media/radio/wl128x/fmdrv.h| 2 +- drivers/media/radio/wl128x

[PATCH 01/14] ARM: dts: LogicPD Torpedo: Add WiLink UART node

2018-12-20 Thread Sebastian Reichel
From: Sebastian Reichel Add a node for the UART part of WiLink chip. Cc: Adam Ford Signed-off-by: Sebastian Reichel --- This is compile tested only! --- arch/arm/boot/dts/logicpd-torpedo-37xx-devkit.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/logicpd

[PATCH 09/14] media: wl128x-radio: load firmware from ti-connectivity/

2018-12-20 Thread Sebastian Reichel
From: Sebastian Reichel All TI WiLink firmware files are loaded from the ti-connectivity subdirectory, so let's also move the FM firmware. Signed-off-by: Sebastian Reichel --- drivers/media/radio/wl128x/fmdrv_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

[PATCH 13/14] Bluetooth: btwilink: drop superseded driver

2018-12-20 Thread Sebastian Reichel
From: Sebastian Reichel All users of this driver have been converted to the serdev based hci_ll driver. The unused driver can be safely dropped now. Signed-off-by: Sebastian Reichel --- drivers/bluetooth/Kconfig| 11 -- drivers/bluetooth/Makefile | 1 - drivers/bluetooth/btwilink.c

[PATCH 08/14] media: wl128x-radio: use device managed memory allocation

2018-12-20 Thread Sebastian Reichel
From: Sebastian Reichel This simplifies memory allocation and removes a few useless errors in case of -ENOMEM errors. Signed-off-by: Sebastian Reichel --- drivers/media/radio/wl128x/fmdrv_common.c | 41 +++ 1 file changed, 13 insertions(+), 28 deletions(-) diff --git a

[PATCH 14/14] misc: ti-st: Drop superseded driver

2018-12-20 Thread Sebastian Reichel
From: Sebastian Reichel This driver has been superseded by the serdev based Bluetooth hci_ll driver, which is initialized from DT. All mainline users have been converted and this driver can be safely dropped. Signed-off-by: Sebastian Reichel --- drivers/misc/Kconfig | 1 - drivers

[PATCH 12/14] media: wl128x-radio: move from TI_ST to hci_ll driver

2018-12-20 Thread Sebastian Reichel
From: Sebastian Reichel This updates the wl128x-radio driver to be used with hci_ll instead of the deprecated TI_ST driver. Signed-off-by: Sebastian Reichel --- drivers/bluetooth/hci_ll.c| 115 -- drivers/media/radio/wl128x/Kconfig| 2 +- drivers

[PATCH 00/14] Add support for FM radio in hcill and kill TI_ST

2018-12-20 Thread Sebastian Reichel
ce initial get_frequency returns an error: $ radio -f 100.0 Merry Christmas! -- Sebastian Sebastian Reichel (14): ARM: dts: LogicPD Torpedo: Add WiLink UART node ARM: dts: IGEP: Add WiLink UART node ARM: OMAP2+: pdata-quirks: drop TI_ST/KIM support media: wl128x-radio: remove module versi

[PATCH 05/14] media: wl128x-radio: remove global radio_disconnected

2018-12-20 Thread Sebastian Reichel
From: Sebastian Reichel Move global radio_disconnected into device structure to prepare converting this driver into a normal platform device driver supporting multiple instances. Signed-off-by: Sebastian Reichel --- drivers/media/radio/wl128x/fmdrv.h | 1 + drivers/media/radio/wl128x

[PATCH 11/14] media: wl128x-radio: fix skb debug printing

2018-12-20 Thread Sebastian Reichel
From: Sebastian Reichel This fixes incorrect code in the TX/RX skb debug print function and add stubs in receive/transmit packet path. Signed-off-by: Sebastian Reichel --- drivers/media/radio/wl128x/fmdrv_common.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git

[PATCH 10/14] media: wl128x-radio: simplify fmc_prepare/fmc_release

2018-12-20 Thread Sebastian Reichel
From: Sebastian Reichel Remove unused return code from fmc_prepare() and fmc_release() to simplify the code a bit. Signed-off-by: Sebastian Reichel --- drivers/media/radio/wl128x/fmdrv_common.c | 26 +-- drivers/media/radio/wl128x/fmdrv_common.h | 4 ++-- drivers/media

[PATCH 04/14] media: wl128x-radio: remove module version

2018-12-20 Thread Sebastian Reichel
From: Sebastian Reichel Drop module version. We already have the kernel's version and this module is mainline. Signed-off-by: Sebastian Reichel --- drivers/media/radio/wl128x/fmdrv.h| 1 - drivers/media/radio/wl128x/fmdrv_common.c | 5 ++--- 2 files changed, 2 insertions(

[PATCH 07/14] media: wl128x-radio: convert to platform device

2018-12-20 Thread Sebastian Reichel
From: Sebastian Reichel This converts the wl128x FM radio module into a platform device. It's a preparation for using it from hci_ll Bluetooth driver instead of TI_ST. Signed-off-by: Sebastian Reichel --- drivers/media/radio/wl128x/fmdrv_common.c | 30 --- 1 file ch

[PATCH 03/14] ARM: OMAP2+: pdata-quirks: drop TI_ST/KIM support

2018-12-20 Thread Sebastian Reichel
From: Sebastian Reichel All TI_ST users have been migrated to the new serdev based HCILL bluetooth driver. That driver is initialized from DT and does not need any platform quirks. Signed-off-by: Sebastian Reichel --- arch/arm/mach-omap2/pdata-quirks.c | 52 -- 1

[PATCH 02/14] ARM: dts: IGEP: Add WiLink UART node

2018-12-20 Thread Sebastian Reichel
From: Sebastian Reichel Add a node for the UART part of WiLink chip. Cc: Enric Balletbo i Serra Signed-off-by: Sebastian Reichel --- This is compile tested only! --- arch/arm/boot/dts/omap3-igep0020-rev-f.dts | 8 arch/arm/boot/dts/omap3-igep0030-rev-g.dts | 8 2 files

Re: [PATCH 00/14] Add support for FM radio in hcill and kill TI_ST

2018-12-21 Thread Sebastian Reichel
Hi, On Fri, Dec 21, 2018 at 10:02:05AM -0800, Tony Lindgren wrote: > * Sebastian Reichel [181221 01:18]: > > The new code has been tested on the Motorola Droid 4. For testing the audio > > should be configured to route Ext to Speaker or Headphone. Then you need to > > plug

Re: [PATCH 14/14] misc: ti-st: Drop superseded driver

2018-12-21 Thread Sebastian Reichel
Hi, On Fri, Dec 21, 2018 at 03:10:52PM -0600, Adam Ford wrote: > On Fri, Dec 21, 2018 at 2:13 AM Sebastian Reichel wrote: > > > > From: Sebastian Reichel > > > > This driver has been superseded by the serdev based Bluetooth > > hci_ll driver, which is initia

[GIT PULL] power-supply changes for 4.21

2018-12-28 Thread Sebastian Reichel
ap (1): power/supply: fix sc27xx_fuel_gauge build errors Sebastian Reichel (16): Merge tag 'psy-mfd-axp813-immutable-for-v4.21-signed' into psy-next power: supply: core: add support for custom sysfs attributes power: supply: bq2415x: fix race-condition in sys

[GIT PULL] hsi changes for hsi-4.21

2018-12-28 Thread Sebastian Reichel
Hi Linus, Not much to say about this. The patch has been in linux-next for 3 or 4 weeks. -- Sebastian The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a: Linux 4.20-rc1 (2018-11-04 15:37:52 -0800) are available in the Git repository at: ssh://g...@gitolite.kernel.

Re: [PATCH 5/9] w1: use octal numbers instead of macros for file mode

2018-10-29 Thread Sebastian Reichel
Hi, On Sun, Oct 28, 2018 at 11:09:24PM +0100, Steffen Vogel wrote: > This satifies a warning raised by the checkpatch tool. > > Signed-off-by: Steffen Vogel > --- > drivers/w1/w1.c | 24 > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/w1/w1

[GIT PULL] power-supply changes for 4.20

2018-10-24 Thread Sebastian Reichel
convert to SPDX identifiers Liu Xiang (1): power: supply: bq27xxx: Add support for BQ27411 Sebastian Reichel (2): Merge tag 'psy-at91-poweroff-immutable-for-v4.20-signed' into psy-next Merge tag 'psy-mfd-cros-immutable-for-v4.20-signed' into psy-next Tomasz Fi

Re: [PATCH v5 00/11] AXP8x3 AC and battery power supply support

2018-10-25 Thread Sebastian Reichel
Hi, Patches 1, 2 & 9 look good to me and do not seem to have any dependencies. I plan to merge them after the merge window for 4.20 closes. -- Sebastian On Tue, Oct 23, 2018 at 09:53:19PM +0300, Oskari Lemmela wrote: > AXP813 AC power supply support with input current and > voltage limiting supp

Re: [PATCH v6 1/6] dt-bindings: power: Introduce one property to present the battery internal resistance

2018-10-25 Thread Sebastian Reichel
Hi Baolin, On Thu, Oct 25, 2018 at 10:01:55AM +0800, Baolin Wang wrote: > Hi Sebastian, > > On 22 October 2018 at 15:43, Baolin Wang wrote: > > The internal resistance of a battery is not a constant in its life cycle, > > this varies over the age of the battery or temperature and so on. But we >

Re: [PATCH v5 4/6] power: supply: core: Add some helpers to use the battery OCV capacity table

2018-10-21 Thread Sebastian Reichel
Hi, On Fri, Oct 19, 2018 at 06:53:13PM +0800, Baolin Wang wrote: > We have introduced some battery properties to present the OCV table > temperatures and OCV capacity table values. Thus this patch add OCV > temperature and OCV table for battery information, as well as providing > some helper funct

Re: [PATCH v5 3/6] dt-bindings: power: Introduce properties to present the battery OCV capacity table

2018-10-21 Thread Sebastian Reichel
OCV table > temperatures and OCV capacity table values. > > Suggested-by: Sebastian Reichel > Signed-off-by: Baolin Wang > Reviewed-by: Linus Walleij > --- Looks good to me. -- Sebastian > Changes from v4: > - Improve the description of ocv-capacity-table-n to make the

Re: [PATCH v5 5/6] dt-bindings: power: Add Spreadtrum SC27XX fuel gauge unit documentation

2018-10-21 Thread Sebastian Reichel
Hi, On Fri, Oct 19, 2018 at 06:53:14PM +0800, Baolin Wang wrote: > This patch adds the binding documentation for Spreadtrum SC27XX series PMICs > fuel gauge unit device, which is used to calculate the battery capacity. > > Signed-off-by: Baolin Wang > Reviewed-by: Linus Walleij > Reviewed-by: R

Re: [PATCH v5 2/6] power: supply: core: Add one field to present the battery internal resistance

2018-10-21 Thread Sebastian Reichel
Hi, On Fri, Oct 19, 2018 at 06:53:11PM +0800, Baolin Wang wrote: > Add one field for 'struct power_supply_battery_info' to present the battery > factory internal resistance. > > Signed-off-by: Baolin Wang > Reviewed-by: Linus Walleij > --- Looks good to me. -- Sebastian > Changes from v4: >

Re: [PATCH v5 6/6] power: supply: Add Spreadtrum SC27XX fuel gauge unit driver

2018-10-21 Thread Sebastian Reichel
Hi, On Fri, Oct 19, 2018 at 06:53:15PM +0800, Baolin Wang wrote: > This patch adds the Spreadtrum SC27XX serial PMICs fuel gauge support, > which is used to calculate the battery capacity. > > Original-by: Yuanjiang Yu > Signed-off-by: Baolin Wang > Acked-by: Linus Walleij > --- Looks mostly

Re: [PATCH v5 1/6] dt-bindings: power: Introduce one property to present the battery internal resistance

2018-10-21 Thread Sebastian Reichel
Hi, On Fri, Oct 19, 2018 at 06:53:10PM +0800, Baolin Wang wrote: > The internal resistance of a battery is not a constant in its life cycle, > this varies over the age of the battery or temperature and so on. But we > just want use one constant battery internal resistance to estimate the > battery

Re: [PATCH] power: supply: fix spelling mistake "Gauage" -> "Guage"

2018-10-21 Thread Sebastian Reichel
Hi, On Sat, Oct 13, 2018 at 04:27:27PM +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in MODULE_DESCRIPTION text > > Signed-off-by: Colin Ian King > --- Thanks, queued with typo in subject fixed. -- Sebastian > drivers/power/supply/ds2780_battery.c | 2

Re: [PATCH] power: max8925: mark expected switch fall-through

2018-10-21 Thread Sebastian Reichel
Hi, On Thu, Oct 04, 2018 at 03:56:36PM +0200, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 201510 ("Missing break in switch") > Signed-off-by: Gustavo A. R. Silva > --- Than

Re: [PATCH v5 6/6] power: supply: Add Spreadtrum SC27XX fuel gauge unit driver

2018-10-22 Thread Sebastian Reichel
Hi, On Mon, Oct 22, 2018 at 01:54:50PM +0800, Baolin Wang wrote: > Hi Sebastian, > > On 22 October 2018 at 00:52, Sebastian Reichel wrote: > > Hi, > > > > On Fri, Oct 19, 2018 at 06:53:15PM +0800, Baolin Wang wrote: > >> This patch adds the Spreadtrum SC

Re: [PATCH RFC 2/5] power: supply: bq24190_charger: add support for bq24192 variant

2018-10-22 Thread Sebastian Reichel
Hi, On Mon, Oct 01, 2018 at 01:30:02AM -0400, Brian Masney wrote: > From: Jonathan Marek > > This patch adds support for the bq24192 variant to bq24190_charger. > > Signed-off-by: Jonathan Marek > Signed-off-by: Brian Masney > --- > drivers/power/supply/bq24190_charger.c | 5 - > 1 file

Re: [PATCH v4 1/7] dt-bindings: power: supply: axp20x: add AXP813 AC power DT binding

2018-10-22 Thread Sebastian Reichel
Hi, On Sat, Oct 13, 2018 at 11:08:42AM +0300, Oskari Lemmela wrote: > The AXP803/AXP813 AC power supply can limit input current and voltage. > > Signed-off-by: Oskari Lemmela > Reviewed-by: Rob Herring > Reviewed-by: Quentin Schulz > --- Reviewed-by: Sebastian Reic

Re: [PATCH 01/15] power: supply: olpc_battery: correct the temperature units

2018-10-22 Thread Sebastian Reichel
Hi, On Fri, Oct 19, 2018 at 04:00:32PM +0300, Andy Shevchenko wrote: > On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel wrote: > > > > According to [1] and [2], the temperature values are in tenths of degree > > Celsius. Exposing the Celsius value makes the battery appear on fire: > > > > $ upowe

Re: [PATCH 0/15] Add support for OLPC XO 1.75 Embedded Controller

2018-10-22 Thread Sebastian Reichel
Hi, On Wed, Oct 10, 2018 at 07:22:45PM +0200, Lubomir Rintel wrote: > Hi. > > This patchset adds support for the Embedded Controller on an OLPC XO > 1.75 machine. OLPC XO 1.75 is a MMP2 based ARM laptop. It plugs into > the existing OLPC platform infrastructure, currently used by the x86 > based

Re: [PATCH v4 5/7] power: supply: add AC power supply driver for AXP813

2018-10-22 Thread Sebastian Reichel
Hi, On Sat, Oct 13, 2018 at 11:08:46AM +0300, Oskari Lemmela wrote: > AXP813 and AXP803 PMICs can control input current and > minimum voltage. > > Both of these values are configurable. > > Signed-off-by: Oskari Lemmela > Reviewed-by: Quentin Schulz > --- Looks good to me apart from Chen-Yu T

Re: [PATCH] power_supply: sysfs: ratelimit property read error message

2018-09-16 Thread Sebastian Reichel
Hi, On Wed, Sep 12, 2018 at 07:48:30PM -0500, David Lechner wrote: > This adds ratelimiting to the message that is printed when reading a > power supply property via sysfs returns an error. This will prevent > userspace applications from unintentionally dDOSing the system by > continuosuly reading

Re: [PATCH v2 0/3] power: supply: cros: add support for dedicated port and expose connected ports

2018-09-16 Thread Sebastian Reichel
Hi, On Fri, Aug 10, 2018 at 03:13:46PM +0200, Fabien Parent wrote: > Dear all, > > This patch series adds support for an optional dedicated port > to the ChromeOS power supply driver and adds a new property that expose > when a power supply is connected. The series was tested on ChromeOS "Fizz" >

Re: [PATCH 0/6] shutdown procedure verification for SAMA5D2

2018-09-16 Thread Sebastian Reichel
Hi, On Thu, Aug 30, 2018 at 02:50:05PM +0300, Claudiu Beznea wrote: > Hi, > > Patch 1 from this series implement a fix for shutdown procedure > for SAMA5D2. > > The rest of the patch are improvements as follows: > patch 2 - use only one function for poweroff > patches 3-6 - cosmetic improvements

Re: [PATCH 1/2] dt-bindings: power: Add Spreadtrum SC27XX fuel gauge unit documentation

2018-09-16 Thread Sebastian Reichel
Hi, On Wed, Sep 12, 2018 at 03:29:38PM +0800, Baolin Wang wrote: > This patch adds the binding documentation for Spreadtrum SC27XX series PMICs > fuel gauge unit device, which is used to calculate the battery capacity. > > Signed-off-by: Baolin Wang > --- > .../devicetree/bindings/power/supply/

Re: [PATCH v3 1/3] power: supply: max8998-charger: Fix platform data retrieval

2018-09-16 Thread Sebastian Reichel
Hi, On Tue, Jul 17, 2018 at 06:05:07PM +0200, Paweł Chmiel wrote: > From: Tomasz Figa > > Since the max8998 MFD driver supports instantiation by DT, platform data > retrieval is handled in MFD probe and cell drivers should get use > the pdata field of max8998_dev struct to obtain them. > > Fixe

Re: [PATCH v7 2/4] power: supply: Add support for the Qualcomm Battery Monitoring System

2018-09-16 Thread Sebastian Reichel
Hi, First of all thanks for the patch and big sorry for the long delay in reviewing this. I did not find enough time to do it properly until now :( On Thu, Jun 14, 2018 at 04:14:15PM +0100, Craig Tatlor wrote: > This patch adds a driver for the BMS (Battery Monitoring System) > block of the PM894

Re: [PATCH v2 3/3] power: supply: cros: add property to detect connected ports

2018-09-16 Thread Sebastian Reichel
Hi, On Fri, Aug 10, 2018 at 03:13:49PM +0200, Fabien Parent wrote: > When a port is connected but acting as a source, its 'online' and > 'status' properties are identical to a port that is not connected. This > makes it tedious for userspace to know for sure whether a port is > connected or not. >

Re: [PATCH] power: supply: bq27xxx: Add support for BQ27411

2018-09-16 Thread Sebastian Reichel
Hi, On Sun, Jul 22, 2018 at 09:33:56PM +0800, Liu Xiang wrote: > According to the datasheet, bq27411 is similar to bq27421. > > Signed-off-by: Liu Xiang > --- Looks good to me. Do you plan to test/review this Andrew, or should I proceed with merging this patch? -- Sebastian > Documentation/d

Re: [PATCH] power: reset: msm: Add support for download-mode control

2018-09-16 Thread Sebastian Reichel
Hi, What's the status of this patch? It looks good to me, should it be merged, did I miss a newer version? -- Sebastian On Fri, Jul 20, 2018 at 10:44:53AM -0700, Stephen Boyd wrote: > Quoting Rajendra Nayak (2018-07-18 23:59:20) > > > > > > On 7/19/2018 11:12 AM, Bjorn Andersson wrote: > > > O

Re: [PATCH 2/2] power: supply: Add Spreadtrum SC27XX fuel gauge unit driver

2018-09-16 Thread Sebastian Reichel
Hi, Looks mostly good. I have a couple of comments in addition to the ones from the binding about using battery_info for the OCV -> capacity mapping. On Wed, Sep 12, 2018 at 03:29:39PM +0800, Baolin Wang wrote: > This patch adds the Spreadtrum SC27XX serial PMICs fuel gauge support, > which is us

Re: [PATCH v2 2/2] power: supply: Add Spreadtrum SC2731 charger support

2018-09-16 Thread Sebastian Reichel
Hi Baolin, On Mon, Sep 03, 2018 at 04:55:46PM +0800, Baolin Wang wrote: > This patch adds the SC2731 PMIC switch charger support. > > Signed-off-by: Baolin Wang > --- The power-supply sysfs files uses uA instead of mA, otherwise the driver and the binding looks fine to me. -- Sebastian > Chan

Re: Cont: power_supply: Introduce power supply charging driver

2018-09-16 Thread Sebastian Reichel
Hi Andy, On Sun, Jul 29, 2018 at 06:30:03PM +0300, Andy Shevchenko wrote: > It has been a while. I didn't get from archives what happened to the > patch series [1]? Is it still actual to apply? > > [1]: https://lwn.net/Articles/608527/ Sorry for my late reply. The discussion died off at some poi

Re: [PATCH 0/4] power: supply: MAX17040: Add IRQ for low level and alert SOC changes

2018-09-16 Thread Sebastian Reichel
Hi Matheus, Did I miss a v2 of this patchset, that solves the issues found by Krzysztof? -- Sebastian On Mon, Jul 23, 2018 at 12:08:12AM -0400, Matheus Castello wrote: > This series add IRQ handler for low level SOC alert, define a devicetree > binding attribute to configure the alert level thr

Re: [PATCH v7 3/4] dt-bindings: power: supply: qcom_bms: Add bindings

2018-09-16 Thread Sebastian Reichel
Hi, Sorry for my long delay in reviewing this. I like the binding, but the "qcom," specific properties should become common properties in Documentation/devicetree/bindings/power/supply/battery.txt and referenced via monitored-battery. -- Sebastian On Thu, Jun 14, 2018 at 04:14:16PM +0100, Crai

Re: [PATCH v2 0/3] power: supply: cros: add support for dedicated port and expose connected ports

2018-09-16 Thread Sebastian Reichel
Hi Lee, On Sun, Sep 16, 2018 at 01:12:54PM +0200, Sebastian Reichel wrote: > Hi, > > On Fri, Aug 10, 2018 at 03:13:46PM +0200, Fabien Parent wrote: > > Dear all, > > > > This patch series adds support for an optional dedicated port > > to the ChromeOS power supp

Re: [PATCH 0/6] shutdown procedure verification for SAMA5D2

2018-09-16 Thread Sebastian Reichel
Hi Nicolas, On Sun, Sep 16, 2018 at 12:43:01PM +0200, Sebastian Reichel wrote: > Hi, > > On Thu, Aug 30, 2018 at 02:50:05PM +0300, Claudiu Beznea wrote: > > Hi, > > > > Patch 1 from this series implement a fix for shutdown procedure > > for SAMA5D2. &

Re: [PATCH] dts/droid4: fix dts w.r.t. pwm

2018-07-16 Thread Sebastian Reichel
Hi, On Mon, Jul 16, 2018 at 09:10:48AM +0200, Pavel Machek wrote: > pwm node should not be under gpio6 node in the device tree. > > This fixes detection of the pwm on Droid 4. > > Signed-off-by: Pavel Machek Reviewed-by: Sebastian Reichel -- Sebastian > diff --g

[DISCUSSION] spi multi chipselect support

2018-07-18 Thread Sebastian Reichel
Hi Mark, Some SPI slave devices have more than one chip select [0]. Rob suggested to use the following DT notation for this [1]: spi-controller { slave@0 { reg = <0>, <1>; }; }; I think this makes sense from a DT point of view, but this needs quite some changes in the SPI core. I

Re: [PATCH] openrisc: Use do_kernel_power_off()

2024-04-14 Thread Sebastian Reichel
use do_kernel_power_off() instead of the > legacy pm_power_off(). > > Fixes: 14c5678720bd ("power: reset: syscon-poweroff: Use > devm_register_sys_off_handler(POWER_OFF)") > Signed-off-by: Stafford Horne > --- Reviewed-by: Sebastian Reichel -- Sebastian > arch

Re: [PATCH] power: supply: cpcap-battery: fix invalid usage of list cursor

2021-04-20 Thread Sebastian Reichel
[+Cc Tony] Hi, On Wed, Apr 14, 2021 at 02:47:24PM +0800, zhuguangqin...@gmail.com wrote: > From: Guangqing Zhu > > Fix invalid usage of a list_for_each_entry in cpcap_battery_irq_thread(). > When list is empty or if the list is completely traversed (without breaking > from the loop on one of the

Re: [PATCH v2 12/19] dt-bindings: power: supply: da9150: update da9150-charger.txt reference

2021-04-07 Thread Sebastian Reichel
ocumentation/devicetree/bindings/power/supply/da9150-charger.txt > - da9150-fg: See Documentation/devicetree/bindings/power/da9150-fg.txt This got "renamed" again in -next. Also I do not see the point to update the next line in its own patch. git show --stat 59604ba75633 commit 596

Re: [PATCH v2 0/2] power: supply: Add battery and AC drivers for Surface devices

2021-04-08 Thread Sebastian Reichel
Hi, On Tue, Apr 06, 2021 at 01:41:24AM +0200, Maximilian Luz wrote: > This series provides battery and AC drivers for Microsoft Surface > devices, where this information is provided via an embedded controller > (the Surface System Aggregator Module, SSAM) instead of the usual ACPI > interface. >

Re: [PATCH -next] power: supply: generic-adc-battery: fix possible use-after-free in gab_remove()

2021-04-08 Thread Sebastian Reichel
Hi, On Wed, Apr 07, 2021 at 05:17:06PM +0800, Yang Yingliang wrote: > This driver's remove path calls cancel_delayed_work(). However, that > function does not wait until the work function finishes. This means > that the callback function may still be running after the driver's > remove function ha

Re: [PATCH -next] power: supply: s3c_adc_battery: fix possible use-after-free in s3c_adc_bat_remove()

2021-04-08 Thread Sebastian Reichel
Hi, On Wed, Apr 07, 2021 at 01:15:11PM +0200, Krzysztof Kozlowski wrote: > On 07/04/2021 11:19, Yang Yingliang wrote: > > This driver's remove path calls cancel_delayed_work(). However, that > > function does not wait until the work function finishes. This means > > that the callback function may

Re: [PATCH] power: supply: Fix missing IRQF_ONESHOT as only threaded handler

2021-04-08 Thread Sebastian Reichel
Hi, On Tue, Apr 06, 2021 at 01:28:29PM +0800, zhuguangqin...@gmail.com wrote: > From: Guangqing Zhu > > Coccinelle noticed: > 1. drivers/power/supply/pm2301_charger.c:1089:7-27: ERROR: Threaded IRQ > with no primary handler requested without IRQF_ONESHOT > 2. drivers/power/supply/tps65090-

Re: [PATCH V2 3/4] dt-bindings: power: reset: qcom-pon: Convert qcom PON binding to yaml

2021-04-08 Thread Sebastian Reichel
Hi, On Thu, Apr 08, 2021 at 05:01:08PM +0530, satya priya wrote: > Convert qcom PON binding from .txt to .yaml format. > > Signed-off-by: satya priya > --- Thanks for doing this. > Changes in V2: > - As per Rob's comments, converted the main PON binding and added in V2. > > .../devicetree/b

Re: [PATCH V3] ARM: dts: am57xx-beagle-x15: Add GPIO controlled fan node

2015-01-03 Thread Sebastian Reichel
Hi Nishanth, On Sat, Jan 03, 2015 at 12:30:26PM -0600, Nishanth Menon wrote: > [...] > + gpio-fan,speed-map = <00 > + 13000 1>; > [...] iirc DT maintainers prefer this format: gpio-fan,speed-map = <0 0>, <13000 1>; This

Re: [PATCH] hsi: nokia-modem: fix uninitialized device pointer

2015-01-04 Thread Sebastian Reichel
Hi Aaro, On Sun, Jan 04, 2015 at 07:34:13PM +0200, Aaro Koskinen wrote: > modem->device was never initialized. This resulted in logs such as: > [ 241.386322] (NULL device *): CMT rst line change detected Thanks, applied to for-next: https://git.kernel.org/cgit/linux/kernel/git/sre/linux-hsi.git

[PATCH 0/3] OMAP3 temperature sensor

2014-12-26 Thread Sebastian Reichel
So far the patchset is _compile-tested only_. I will test it on my N900 in the next days. -- Sebastian Sebastian Reichel (3): DT Binding for omap3 temperature sensor hwmon: Driver for OMAP3 temperature sensor ARM: dts: OMAP34xx/36xx: Add temperature sensor .../bindings/hwmon/omap3-tempe

[PATCH 1/3] DT Binding for omap3 temperature sensor

2014-12-26 Thread Sebastian Reichel
OMAP34xx and OMAP36xx processors contain a register in the syscon area, which can be used to determine the SoCs temperature. This provides a DT binding specification for the temperature monitor. Signed-off-by: Sebastian Reichel --- .../bindings/hwmon/omap3-temperature.txt | 25

[PATCH 2/3] hwmon: Driver for OMAP3 temperature sensor

2014-12-26 Thread Sebastian Reichel
f8591.o diff --git a/drivers/hwmon/omap3-temp.c b/drivers/hwmon/omap3-temp.c new file mode 100644 index 000..5c331c5 --- /dev/null +++ b/drivers/hwmon/omap3-temp.c @@ -0,0 +1,307 @@ +/* + * omap3-temp.c - driver for OMAP34xx and OMAP36xx temperature sensor + * + * Copyright (c) 2014 Sebastian Rei

[PATCH 3/3] ARM: dts: OMAP34xx/36xx: Add temperature sensor

2014-12-26 Thread Sebastian Reichel
OMAP34xx and OMAP36xx processors contain a register in the syscon area, which can be used to determine the SoCs temperature. Signed-off-by: Sebastian Reichel --- arch/arm/boot/dts/omap34xx.dtsi | 7 +++ arch/arm/boot/dts/omap36xx.dtsi | 7 +++ 2 files changed, 14 insertions(+) diff

Re: [PATCH 1/3] DT Binding for omap3 temperature sensor

2014-12-26 Thread Sebastian Reichel
Hi Pavel, On Fri, Dec 26, 2014 at 06:19:44PM +0100, Pavel Machek wrote: > On Fri 2014-12-26 13:34:52, Sebastian Reichel wrote: > > OMAP34xx and OMAP36xx processors contain a register in the syscon area, > > which can be used to determine the SoCs temperature. This provides a

Re: [PATCH 2/3] hwmon: Driver for OMAP3 temperature sensor

2014-12-28 Thread Sebastian Reichel
On Sun, Dec 28, 2014 at 12:24:47AM -0800, Guenter Roeck wrote: > On Sat, Dec 27, 2014 at 11:35:16PM +0100, Pavel Machek wrote: > > On Sat 2014-12-27 20:58:25, Pavel Machek wrote: > > > On Fri 2014-12-26 13:34:53, Sebastian Reichel wrote: > > > > OMAP34xx and OMAP36xx

Re: [PATCH v4 2/2] Documentation: Add documentation for rt5033 multifunction device

2015-01-22 Thread Sebastian Reichel
on for rt5033 multifunction > > >> device. > > >> > > >> Cc: Sebastian Reichel > > >> Cc: Lee Jones > > >> Cc: Mark Brown > > >> Cc: Rob Herring > > >> Cc: Pawel Moll > > >> Cc: Mark Rutland &

Re: [PATCH v2 3/3] X-Power AXP288 PMIC Fuel Gauge Driver

2015-01-25 Thread Sebastian Reichel
Hi, On Thu, Jan 22, 2015 at 12:52:07PM -0800, Todd Brandt wrote: > New power_supply driver at driver/power which interfaces with the > axp20x mfd driver as a cell. Provides battery info, monitors for > changes, and generates alerts on temperature and capacity issues Apart from two issues the driv

Re: [PATCH v2 1/3] mfd/axp20x: change battery cell name to fuel gauge

2015-01-25 Thread Sebastian Reichel
ces), > - .resources = axp288_battery_resources, > + .name = "axp288_fuel_gauge", > + .num_resources = ARRAY_SIZE(axp288_fuel_gauge_resources), > + .resources = axp288_fuel_gauge_resources, > }, > { > .name = "axp288_pmic_acpi", Acked-By: Sebastian Reichel -- Sebastian signature.asc Description: Digital signature

<    1   2   3   4   5   6   7   8   9   10   >