Re: [PATCH v6 28/41] ARM: davinci: remove CONFIG_DAVINCI_RESET_CLOCKS

: David Lechner <da...@lechnology.com> Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [PATCH v6 29/41] ARM: davinci_all_defconfig: remove CONFIG_DAVINCI_RESET_CLOCKS

On Saturday 20 January 2018 10:44 PM, David Lechner wrote: > This removes CONFIG_DAVINCI_RESET_CLOCKS. The option has been removed from > the kernel. > > Signed-off-by: David Lechner <da...@lechnology.com> Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [PATCH v6 25/41] ARM: dm646x: add new clock init using common clock framework

On Saturday 20 January 2018 10:44 PM, David Lechner wrote: > void __init dm646x_init_time(unsigned long ref_clk_rate, >unsigned long aux_clkin_rate) > { > +#ifdef CONFIG_COMMON_CLK > + void __iomem *pll1, *pll2, *psc; > + struct clk *clk; > + > + pll1 =

Re: [PATCH v6 18/41] clk: davinci: New driver for TI DA8XX CFGCHIP clocks

On Saturday 20 January 2018 10:43 PM, David Lechner wrote: > +static const struct clk_ops da8xx_cfgchip_div4p5_clk_ops = { > + .enable = da8xx_cfgchip_gate_clk_enable, > + .disable= da8xx_cfgchip_gate_clk_disable, > + .is_enabled = da8xx_cfgchip_gate_clk_is_enabled,

Re: [PATCH v6 23/41] ARM: dm365: add new clock init using common clock framework

; > Also clean up the #includes since we are adding some here. > > Signed-off-by: David Lechner <da...@lechnology.com> Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [PATCH v6 14/41] clk: davinci: Add platform information for TI DM365 PSC

On Saturday 20 January 2018 10:43 PM, David Lechner wrote: > This adds platform-specific declarations for the PSC clocks on TI > DM365 based systems. > > Signed-off-by: David Lechner <da...@lechnology.com> Apart from comment given on 13/41 that applies here: Reviewed-by:

Re: [PATCH v6 16/41] clk: davinci: Add platform information for TI DM646x PSC

On Saturday 20 January 2018 10:43 PM, David Lechner wrote: > This adds platform-specific declarations for the PSC clocks on TI > DM646x based systems. > > Signed-off-by: David Lechner <da...@lechnology.com> Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [PATCH v6 12/41] clk: davinci: Add platform information for TI DA850 PSC

On Saturday 20 January 2018 10:43 PM, David Lechner wrote: > This adds platform-specific declarations for the PSC clocks on TI DA850/ > OMAP-L138/AM18XX SoCs. > > Signed-off-by: David Lechner <da...@lechnology.com> Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [PATCH v6 02/41] clk: davinci: New driver for davinci PLL clocks

On Thursday 01 February 2018 01:31 PM, Sekhar Nori wrote: > One thing missing is DIV4.5 clock. It will be nice to add that too, > mostly just because it will make the binding complete. Ah, ignore this comment please. I noticed that its part of cfgchip clocks (which makes sense). Thanks, Sekhar

Re: [PATCH v6 11/41] clk: davinci: Add platform information for TI DA830 PSC

On Saturday 20 January 2018 10:43 PM, David Lechner wrote: > This adds platform-specific declarations for the PSC clocks on TI DA830/ > OMAP-L137/AM17XX SoCs. > > Signed-off-by: David Lechner <da...@lechnology.com> Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [PATCH v6 13/41] clk: davinci: Add platform information for TI DM355 PSC

On Saturday 20 January 2018 10:43 PM, David Lechner wrote: > + LPSC(26, 0, gpio,pll1_sysclk2, gpio_clkdev,0), > + LPSC(27, 0, timer0, pll1_auxclk, timer0_clkdev, 0), > + LPSC(28, 0, timer1, pll1_auxclk, NULL, 0), > + /* REVISIT: why

Re: [PATCH v6 15/41] clk: davinci: Add platform information for TI DM644x PSC

On Saturday 20 January 2018 10:43 PM, David Lechner wrote: > This adds platform-specific declarations for the PSC clocks on TI > DM644x based systems. > > Signed-off-by: David Lechner <da...@lechnology.com> Apart from a comment given on similar file: Reviewed-by: Sekhar No

Re: [PATCH v6 17/41] dt-bindings: clock: Add bindings for DA8XX CFGCHIP clocks

On Saturday 20 January 2018 10:43 PM, David Lechner wrote: > +EMIFA clock source (ASYNC1) > +--- > +Required properties: > +- compatible: shall be "ti,da850-async1-clksrc". > +- #clock-cells: from common clock binding; shall be set to 0. > +- clocks: phandles to the parent

Re: [PATCH v6 04/41] clk: davinci: Add platform information for TI DA850 PLL

On Friday 02 February 2018 12:34 AM, David Lechner wrote: > On 02/01/2018 02:58 AM, Sekhar Nori wrote: >> On Saturday 20 January 2018 10:43 PM, David Lechner wrote: >>> This adds platform-specific declarations for the PLL clocks on TI DA850/ >>> OMAP-L138/AM18XX SoCs. &

Re: [PATCH v6 04/41] clk: davinci: Add platform information for TI DA850 PLL

On Friday 02 February 2018 12:52 AM, David Lechner wrote: >> +static const char * const da850_pll1_obsclk_parent_names[] >> __initconst = { >> +    "oscin", > > Re: the issue of "ref_clk" vs. "oscin"... > > This is one of the places where having the otherwise unnecessary "oscin" > clock >

Re: [PATCH v6 02/41] clk: davinci: New driver for davinci PLL clocks

On Friday 02 February 2018 12:27 AM, David Lechner wrote: > On 02/01/2018 02:01 AM, Sekhar Nori wrote: >> On Saturday 20 January 2018 10:43 PM, David Lechner wrote: >>> This adds a new driver for mach-davinci PLL clocks. This is porting the >>> code from arch/arm/mach-da

Re: [PATCH v6 17/41] dt-bindings: clock: Add bindings for DA8XX CFGCHIP clocks

On Friday 02 February 2018 11:20 PM, David Lechner wrote: > On 02/02/2018 12:20 AM, Sekhar Nori wrote: >> On Saturday 20 January 2018 10:43 PM, David Lechner wrote: >>> +EMIFA clock source (ASYNC1) >>> +--- >>> +Required properties: &

Re: [PATCH v6 20/41] ARM: da830: add new clock init using common clock framework

On Friday 02 February 2018 11:33 PM, David Lechner wrote: > On 02/02/2018 08:12 AM, Sekhar Nori wrote: >> On Saturday 20 January 2018 10:43 PM, David Lechner wrote: >>>   void __init da830_init_time(void) >>>   { >>> +#ifdef CONFIG_COMMON_CLK >&

Re: [PATCH v6 04/41] clk: davinci: Add platform information for TI DA850 PLL

On Saturday 20 January 2018 10:43 PM, David Lechner wrote: > This adds platform-specific declarations for the PLL clocks on TI DA850/ > OMAP-L138/AM18XX SoCs. > > Signed-off-by: David Lechner > +static const struct davinci_pll_clk_info da850_pll1_info __initconst = { > +

Re: [PATCH v6 05/41] clk: davinci: Add platform information for TI DM355 PLL

On Saturday 20 January 2018 10:43 PM, David Lechner wrote: > +void __init dm355_pll_clk_init(void __iomem *pll1, void __iomem *pll2) > +{ > + const struct davinci_pll_sysclk_info *info; > + > + davinci_pll_clk_register(_pll1_info, "ref_clk", pll1); > + > + for (info =

Re: [PATCH v6 06/41] clk: davinci: Add platform information for TI DM365 PLL

On Saturday 20 January 2018 10:43 PM, David Lechner wrote: > + > +void __init dm365_pll_clk_init(void __iomem *pll1, void __iomem *pll2) > +{ > + const struct davinci_pll_sysclk_info *info; > + > + davinci_pll_clk_register(_pll1_info, "ref_clk", pll1); > + > +

Re: [PATCH v6 03/41] clk: davinci: Add platform information for TI DA830 PLL

On Saturday 20 January 2018 10:43 PM, David Lechner wrote: > This adds platform-specific declarations for the PLL clocks on TI DA830/ > OMAP-L137/AM17XX SoCs. > > Signed-off-by: David Lechner <da...@lechnology.com> Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [PATCH v6 02/41] clk: davinci: New driver for davinci PLL clocks

On Saturday 20 January 2018 10:43 PM, David Lechner wrote: > This adds a new driver for mach-davinci PLL clocks. This is porting the > code from arch/arm/mach-davinci/clock.c to the common clock framework. > Additionally, it adds device tree support for these clocks. > > The ifeq

Re: [PATCH v6 10/41] clk: davinci: New driver for davinci PSC clocks

tion that there is only one PSC per SoC and uses > global variables, but here we have two controllers per SoC. > > Signed-off-by: David Lechner <da...@lechnology.com> Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [PATCH v6 24/41] ARM: dm644x: add new clock init using common clock framework

On Friday 02 February 2018 11:36 PM, David Lechner wrote: > On 02/02/2018 08:39 AM, Sekhar Nori wrote: >> On Saturday 20 January 2018 10:44 PM, David Lechner wrote: >>> This adds the new board-specific clock init in mach-davinci/dm644x.c >>> using the new com

Re: [PATCH 2/7] soc: davinci: new genpd driver

On Wednesday 07 February 2018 07:15 PM, Bartosz Golaszewski wrote: > + /* > + * DaVinci always uses a single clock for power-management. We assume > + * it's the first one in the clocks property. > + */ > + clk = of_clk_get(dev->of_node, 0); > + if (IS_ERR(clk)) > +

Re: [PATCH] ARM: dts: da850-evm: add clock properties to the nand node

On Monday 05 February 2018 09:22 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Make nand work with the common clock framework by specifying which > clock should be used and what name to look up. > > Signed-off-by: Bartosz Golaszewski

Re: [PATCH] ARM: da8xx: use platform data for CFGCHIP syscon regmap

On Thursday 25 January 2018 08:57 PM, Sekhar Nori wrote: > + Arnd, Kishon and Lee for their information. > > On Wednesday 24 January 2018 05:06 AM, David Lechner wrote: >> This converts from using a platform device for the CFGCHIP syscon >> regmap to using platform da

Re: [PATCH v2 15/15] ARM: dts: dra7: Add high speed modes capability to MMC1/MMC2 dt node

On Wednesday 07 February 2018 02:51 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Wednesday 07 February 2018 02:41 PM, Sekhar Nori wrote: >> Kishon, >> >> On Tuesday 06 February 2018 06:28 PM, Kishon Vijay Abraham I wrote: >>> Add UHS/HS200/DDR speed mode

Re: [PATCH v2] reset: add support for non-DT systems

[FOO_RESET] = { .dev = "foo", .id = "foo_id" }, > [BAR_RESET] = { .dev = "bar", .id = NULL }, > { } > }; > > where FOO_RESET and BAR_RESET will correspond with the id parameters > of reset callbacks. > > Cc: Sekhar Nori <nsek...@

Re: [PATCH 0/7] ARM: davinci: add genpd support

Hi David, On Thursday 08 February 2018 04:13 AM, David Lechner wrote: > On 02/07/2018 07:45 AM, Bartosz Golaszewski wrote: >> From: Bartosz Golaszewski >> >> Hi Sekhar et al, >> >> please take a look at the following patches. They add a simple genpd >> driver and use

Re: [PATCH v6 41/41] ARM: dts: da850: Add clocks

On Saturday 20 January 2018 10:44 PM, David Lechner wrote: > diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi > index c66cf78..7f4acd7 100644 > --- a/arch/arm/boot/dts/da850.dtsi > +++ b/arch/arm/boot/dts/da850.dtsi > @@ -21,6 +21,36 @@ >

Re: [PATCH 2/7] soc: davinci: new genpd driver

On Thursday 08 February 2018 03:24 PM, Bartosz Golaszewski wrote: > 2018-02-08 10:30 GMT+01:00 Sekhar Nori <nsek...@ti.com>: >> On Wednesday 07 February 2018 07:15 PM, Bartosz Golaszewski wrote: >>> + /* >>> + * DaVinci always uses a single cloc

Re: [PATCH v2 15/15] ARM: dts: dra7: Add high speed modes capability to MMC1/MMC2 dt node

Kishon, On Tuesday 06 February 2018 06:28 PM, Kishon Vijay Abraham I wrote: > Add UHS/HS200/DDR speed mode capability to MMC1 and MMC2 dt nodes. > > Signed-off-by: Kishon Vijay Abraham I Along with this, dont we need to have /delete-property/ mmc-hs200-1_8v; for eMMC

Re: [PATCH v2 15/15] ARM: dts: dra7: Add high speed modes capability to MMC1/MMC2 dt node

On Wednesday 07 February 2018 02:51 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Wednesday 07 February 2018 02:41 PM, Sekhar Nori wrote: >> Kishon, >> >> On Tuesday 06 February 2018 06:28 PM, Kishon Vijay Abraham I wrote: >>> Add UHS/HS200/DDR speed mode

Re: [PATCH 2/7] soc: davinci: new genpd driver

On Thursday 08 February 2018 06:57 PM, Bartosz Golaszewski wrote: > 2018-02-08 13:56 GMT+01:00 Sekhar Nori <nsek...@ti.com>: >> On Thursday 08 February 2018 03:24 PM, Bartosz Golaszewski wrote: >>> 2018-02-08 10:30 GMT+01:00 Sekhar Nori <nsek...@ti.com>: >>>&

Re: [PATCH] ARM: dts: da850-evm: add clock properties to the nand node

On Tuesday 06 February 2018 06:38 PM, Bartosz Golaszewski wrote: > 2018-02-06 12:07 GMT+01:00 Sekhar Nori <nsek...@ti.com>: >> On Monday 05 February 2018 09:22 PM, Bartosz Golaszewski wrote: >>> From: Bartosz Golaszewski <bgolaszew...@baylibre.com> >>> &

Re: [PATCH v6 33/41] ARM: dm355: Remove legacy clock init

On Saturday 20 January 2018 10:44 PM, David Lechner wrote: > This removes the unused legacy clock init code from > arch/arm/mach-davinci/dm355.c. > > Signed-off-by: David Lechner <da...@lechnology.com> Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [PATCH v6 34/41] ARM: dm365: Remove legacy clock init

On Saturday 20 January 2018 10:44 PM, David Lechner wrote: > This removes the unused legacy clock init code from > arch/arm/mach-davinci/dm365.c. > > Signed-off-by: David Lechner <da...@lechnology.com> Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [PATCH v6 35/41] ARM: dm644x: Remove legacy clock init

On Saturday 20 January 2018 10:44 PM, David Lechner wrote: > This removes the unused legacy clock init code from > arch/arm/mach-davinci/dm644x.c. > > Signed-off-by: David Lechner <da...@lechnology.com> Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [PATCH v6 36/41] ARM: dm646x: Remove legacy clock init

On Saturday 20 January 2018 10:44 PM, David Lechner wrote: > This removes the unused legacy clock init code from > arch/arm/mach-davinci/dm646x.c. > > Signed-off-by: David Lechner <da...@lechnology.com> Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [PATCH v6 37/41] ARM: da8xx: Remove legacy clock init

patch description? Apart from that: Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [PATCH v6 38/41] ARM: davinci: remove legacy clocks

On Saturday 20 January 2018 10:44 PM, David Lechner wrote: > This removes the unused legacy clock code from arch/arm/mach-davinci/. > > Signed-off-by: David Lechner <da...@lechnology.com> Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [PATCH v6 30/41] ARM: davinci: switch to common clock framework

0x01c40800 > +#define DAVINCI_PLL2_BASE0x01c40c00 > +#define DAVINCI_PWR_SLEEP_CNTRL_BASE0x01c41000 Please drop the tab after #define With that. Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [PATCH v6 31/41] ARM: da830: Remove legacy clock init

On Saturday 20 January 2018 10:44 PM, David Lechner wrote: > This removes the unused legacy clock init code from > arch/arm/mach-davinci/da830.c. > > Signed-off-by: David Lechner <da...@lechnology.com> Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [PATCH] ARM: dts: da850-evm: add clock properties to the nand node

On Wednesday 07 February 2018 12:15 AM, Bartosz Golaszewski wrote: > 2018-02-06 19:25 GMT+01:00 David Lechner <da...@lechnology.com>: >> On 02/06/2018 12:16 PM, David Lechner wrote: >>> >>> On 02/06/2018 07:51 AM, Sekhar Nori wrote: >>>> >&

Re: [PATCH v6 32/41] ARM: da850: Remove legacy clock init

On Saturday 20 January 2018 10:44 PM, David Lechner wrote: > This removes the unused legacy clock init code from > arch/arm/mach-davinci/da850.c. > > Signed-off-by: David Lechner <da...@lechnology.com> Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [PATCH v2] ARM: da8xx: use platform data for CFGCHIP syscon regmap

On Sunday 18 February 2018 08:52 AM, David Lechner wrote: > This converts from using a platform device for the CFGCHIP syscon > regmap to using platform data to pass the regmap to consumers. > > A lazy getter function is used so that the regmap will only be > created if it is actually used. This

Re: [PATCH] ARM: dts: da850-lego-ev3: use a correct fallback for at24 compatible

On Monday 22 January 2018 10:20 PM, David Lechner wrote: > On 01/22/2018 06:55 AM, Bartosz Golaszewski wrote: >> From: Bartosz Golaszewski >> >> We now require all at24 users to use the "atmel," fallback in >> device tree for different manufacturers. >> >>

Re: [PATCH] ARM: davinci_all_defconfig: set CONFIG_DAVINCI_WATCHDOG=y

commit id adjusted since the said patch did not make it to v4.16 > watchdog driver, devices cannot reboot unless the watchdog driver is > loaded, so make it a compiled-in option so that we can always reboot, even > when modules are not loaded. > > Cc: Sekhar Nori <nsek...@ti.

Re: [PATCH] ARM: dts: da850: use gpio-ranges

On Thursday 22 February 2018 09:04 PM, Linus Walleij wrote: > On Mon, Feb 19, 2018 at 11:29 PM, David Lechner wrote: > >> This makes use of the gpio-ranges feature that connects GPIO >> controllers and PINMUX controllers. >> >> In da850.dtsi, pinctrl-single,gpio-range is

Re: [PATCH v2 1/2] ARM: dts: da850-lego-ev3: Add node for reboot modes

On Friday 12 January 2018 07:59 AM, David Lechner wrote: > This adds a new node for reboot modes on LEGO MINDSTORMS EV3. The EV3's > bootloader looks for a magic number in the ARM local RAM and if found, > it will boot into a special firmware update mode where the flash memory > can be written via

Re: [PATCH v2 2/2] ARM: davinci_all_defconfig: enable SYSCON_REBOOT_MODE

On Friday 12 January 2018 07:59 AM, David Lechner wrote: > This enables SYSCON_REBOOT_MODE as a module. This is used by LEGO > MINDSTORMS EV3 to reboot into a special firmware update mode. > > Signed-off-by: David Lechner Applied to v4.17/defconfig Thanks, Sekhar

Re: [PATCH 3/3] ARM: davinci: mark spi_board_info arrays as const

; Signed-off-by: Arnd Bergmann <a...@arndb.de> > > I applied this to the fixes branch now. Thanks Arnd. FWIW now: Acked-by: Sekhar Nori <nsek...@ti.com> Regards, Sekhar

Re: [PATCH V6] mmc:host:sdhci-pci:Addition of Arasan PCI Controller with integrated phy.

ff-by: Atul Garg <ag...@arasan.com> Apart from the comments given by Adrian, looks good to me. Reviewed-by: Sekhar Nori <nsek...@ti.com> Regards, Sekhar

Re: [PATCH v4 0/7] ARM: davinci: convert to common clock framework​

On Tuesday 02 January 2018 08:40 PM, Adam Ford wrote: > On Sun, Dec 31, 2017 at 5:39 PM, David Lechner wrote: >> This series converts macreqh-davinci to use the common clock framework. >> >> Basically, this series does some cleanup and rearranging to get things >> ready for

Re: [PATCH v4 5/7] clk: Introduce davinci clocks

On Wednesday 03 January 2018 03:01 AM, David Lechner wrote: > Forgot to cc linux-clk, so doing that now... > > > On 12/31/2017 05:39 PM, David Lechner wrote: >> This introduces new drivers for arch/arm/mach-davinci. The code is based >> on the clock drivers from there and adapted to use the

Re: [PATCH v4 3/7] ARM: davinci: fix duplicate clocks

On Monday 01 January 2018 05:09 AM, David Lechner wrote: > There are a number of clocks that were duplicated because they are used by > more than one device. It is no longer necessary to do this since we are > explicitly calling clk_register_clkdev() for each clock. In da830.c, some > clocks were

Re: [PATCH v4 2/7] ARM: davinci: don't use static clk_lookup

Hi David, On Monday 01 January 2018 05:09 AM, David Lechner wrote: > In preparation of moving to the common clock framework, usage of static > struct clk_lookup is removed. The common clock framework uses an opaque > struct clk, so we won't be able to use static tables as was previously > done. >

Re: [PATCH v4 6/7] ARM: davinci: convert to common clock framework

On Monday 01 January 2018 05:09 AM, David Lechner wrote: > This converts all of arch/arm/mach-davinci to the common clock framework. > The clock drivers from clock.c and psc.c have been moved to drivers/clk, > so these files are removed. > > There is one subtle change in the clock trees. AUX,

Re: [PATCH v4 5/7] clk: Introduce davinci clocks

. commit aad70de20fc69970a3080e7e8f02b54a4a3fe3e6 Author: Sekhar Nori <nsek...@ti.com> AuthorDate: Wed Jul 6 06:01:22 2011 +0000 Commit: Sekhar Nori <nsek...@ti.com> CommitDate: Fri Jul 8 11:10:09 2011 +0530 davinci: enable forced transitions on PSC Some DaVinci modules like the SATA on DA850 nee

Re: [PATCH v7 0/4] ARM: davinci: complete the conversion to using the reset framework

Hi Bartosz, On Thursday 21 June 2018 01:07 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > These are the remaining patches that still need to be merged in order > to complete the conversion of the davinci dsp driver to using the reset > framework. > > They apply on top of

Re: [PATCH v7 1/4] remoteproc/davinci: use the reset framework

instead of handcoded reset routines >>> we used so far. >>> >>> Signed-off-by: Bartosz Golaszewski >>> Reviewed-by: Sekhar Nori >>> Reviewed-by: Philipp Zabel >> >> Acked-by: Bjorn Andersson >> > > Sekhar, > > can

Re: [PATCH v3 00/13] ARM: davinci: remove duplicate aemif support

Hi David, On Monday 06 August 2018 10:05 PM, David Lechner wrote: > On 07/10/2018 05:19 AM, Sekhar Nori wrote: >> On Friday 06 July 2018 11:09 PM, David Lechner wrote: >>> On 07/04/2018 01:35 AM, Sekhar Nori wrote: >>>> Hi David, >>>> >>>>

Re: [PATCH] remoteproc/davinci: Mark error recovery as disabled

Hi Bjorn, On Tuesday 14 August 2018 12:22 AM, Bjorn Andersson wrote: > On Mon 13 Aug 08:11 PDT 2018, Suman Anna wrote: > >> Hi Bjorn, >> >> On 07/23/2018 06:27 PM, Suman Anna wrote: >>> The Davinci remoteproc driver does not support error recovery at >>> present, so mark the corresponding

Re: [PATCH] remoteproc/davinci: Use %zx for formating size_t

On Friday 17 August 2018 01:09 PM, Bartosz Golaszewski wrote: > 2018-08-17 2:49 GMT+02:00 Bjorn Andersson : >> da8xx_rproc_mem size is of type size_t, so use %zx to format the debug >> print of it to avoid a compile warning. >> >> Signed-off-by: Bjorn Andersson >> --- >>

Re: [PATCH 00/28] at24: remove at24_platform_data

Hi Bart, On Wednesday 08 August 2018 10:22 PM, Bartosz Golaszewski wrote: > 2018-08-08 18:44 GMT+02:00 Andrew Lunn : >> On Wed, Aug 08, 2018 at 06:27:25PM +0200, Bartosz Golaszewski wrote: >>> 2018-08-08 17:55 GMT+02:00 Wolfram Sang : On Wed, Aug 08, 2018 at 05:31:22PM +0200, Bartosz

Re: [PATCH 2/5] gpio: davinci: Use dev name for label and automatic base selection

On Monday 10 September 2018 12:55 PM, Linus Walleij wrote: > On Sat, Sep 8, 2018 at 9:41 PM Grygorii Strashko > wrote: >> On 09/06/2018 09:16 AM, Keerthy wrote: > >>> Okay now its numbered differently: >>> >>> cat /sys/class/gpio/gpiochip340/ngpio >>> 144 >>> >>> cat

Re: [PATCH v3 00/13] ARM: davinci: remove duplicate aemif support

Hi David, On Monday 02 July 2018 09:02 PM, David Lechner wrote: > On 07/02/2018 07:28 AM, Sekhar Nori wrote: >> Hi David, Stephen, >> >> On Thursday 28 June 2018 03:27 PM, Bartosz Golaszewski wrote: >>> From: Bartosz Golaszewski >>> >>> This s

Re: [PATCH v3 00/13] ARM: davinci: remove duplicate aemif support

On Friday 06 July 2018 11:09 PM, David Lechner wrote: > On 07/04/2018 01:35 AM, Sekhar Nori wrote: >> Hi David, >> >> On Monday 02 July 2018 09:02 PM, David Lechner wrote: >>> On 07/02/2018 07:28 AM, Sekhar Nori wrote: >>>> Hi David, Stephen, >>&g

Re: [PATCH v5 11/44] clk: davinci: Add platform information for TI DA830 PSC

On Tuesday 16 January 2018 10:46 PM, David Lechner wrote: >>> +static const struct davinci_psc_clk_info da830_psc0_info[] >>> __initconst = { >>> +    LPSC(0, 0, tpcc, pll0_sysclk2, LPSC_ALWAYS_ENABLED), >>> +    LPSC(1, 0, tptc0, pll0_sysclk2, LPSC_ALWAYS_ENABLED), >>> +    LPSC(2, 0, tptc1,

Re: [PATCH v5 10/44] clk: davinci: New driver for davinci PSC clocks

On Tuesday 16 January 2018 10:21 PM, David Lechner wrote: >>> +static struct clk *davinci_psc_clk_register(const char *name, >>> +    const char *parent_name, >>> +    struct regmap *regmap, >>> +    u32 lpsc, u32 pd, u32 flags) >>> +{

Re: [PATCH v5 12/44] clk: davinci: Add platform information for TI DA850 PSC

On Tuesday 16 January 2018 10:51 PM, David Lechner wrote: > On 01/16/2018 08:00 AM, Sekhar Nori wrote: >> On Monday 08 January 2018 07:47 AM, David Lechner wrote: >>> +void __init da850_psc_clk_init(void __iomem *psc0, void __iomem *psc1) >>> +{ >>> + 

Re: [PATCH v5 21/44] clk: davinci: New driver for TI DA8XX USB PHY clocks

On Friday 19 January 2018 12:19 AM, David Lechner wrote: >> > > or to avoid defining a new macro? > > >> regmap_write_bits(clk->regmap, CFGCHIP(2), >>   CFGCHIP2_USB1PHYCLKMUX, >>   index ? CFGCHIP2_USB1PHYCLKMUX : 0); Looks good as well! Regards, Sekhar

Re: [PATCH v5 29/44] ARM: da8xx: add new USB PHY clock init using common clock framework

On Friday 19 January 2018 12:13 AM, David Lechner wrote: > On 01/18/2018 09:14 AM, Sekhar Nori wrote: >> On Monday 08 January 2018 07:47 AM, David Lechner wrote: >>> +int __init da8xx_register_usb20_phy_clk(bool use_usb_refclkin) >>> +{ >>> +    struct

Re: [PATCH] pata_bk3710: clarify license version and use SPDX header

On Thursday 01 March 2018 04:46 PM, Bartlomiej Zolnierkiewicz wrote: > - clarify license version (it should be GPL 2.0) > - use SPDX header > > Cc: Sekhar Nori <nsek...@ti.com> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> Acked-by: Sekhar No

Re: [PATCH] ARM: davinci: DA8XX: simplify CFGCHIP regmap_config

On Thursday 15 March 2018 11:43 PM, David Lechner wrote: > Since commit 8253bb3f8255 ("regmap: potentially duplicate the name > string stored in regmap"), the name field of struct regmap_config > is copied in __regmap_init(), so we no longer need to worry about > keeping our own copy of the name.

Re: [PATCH] ARM: davinci: DA8XX: fix oops in USB PHY driver due to stack allocated platform platform_data

On Thursday 15 March 2018 11:32 PM, David Lechner wrote: > This fixes a possible kernel oops due to using stack allocated platform > data for the USB PHY driver on DA8XX devices. If the platform device > probe is deferred, then we get a corrupt pointer for the platform data. > > We now use a

Re: [PATCH v2] ARM: davinci: fix the GPIO lookup for omapl138-hawk

r for mmc pins") Signed-off-by: Bartosz Golaszewski <bgolaszew...@baylibre.com> [nsek...@ti.com: add a note on where the chip label is set] Signed-off-by: Sekhar Nori <nsek...@ti.com>

Re: [PATCH v8 25/42] ARM: davinci: dm644x: add new clock init using common clock framework

On Friday 16 March 2018 08:22 AM, David Lechner wrote: > +static struct resource dm644x_pll1_resources[] = { > + { > + .start = DAVINCI_PLL1_BASE, > + .end= DAVINCI_PLL1_BASE + SZ_4K - 1, The .end should be DAVINCI_PLL1_BASE + SZ_1K - 1, otherwise it prevents PLL2

Re: [PATCH v8 40/42] ARM: davinci: add device tree support to timer

On Friday 16 March 2018 08:22 AM, David Lechner wrote: > +static int __init of_davinci_timer_init(struct device_node *np) > +{ > + struct clk *clk; > + > + clk = of_clk_get(np, 0); > + if (IS_ERR(clk)) { > + struct of_phandle_args clkspec; > + > + /* > +

Re: [PATCH v8 20/42] ARM: davinci: pass clock as parameter to davinci_timer_init()

On Friday 16 March 2018 08:22 AM, David Lechner wrote: > This changes davinci_timer_init() so that we pass the clock as a > parameter instead of using clk_get(). This is done in preparation > for converting to the common clock framework. > > It removes the requirement that we have to have a clock

Re: [PATCH v8 25/42] ARM: davinci: dm644x: add new clock init using common clock framework

On Wednesday 04 April 2018 12:17 PM, Sekhar Nori wrote: > On Tuesday 03 April 2018 10:00 PM, David Lechner wrote: >> On 04/03/2018 05:26 AM, Sekhar Nori wrote: >>> On Friday 16 March 2018 08:22 AM, David Lechner wrote: >>>> +static struct

Re: [PATCH v5 12/44] clk: davinci: Add platform information for TI DA850 PSC

On Thursday 05 April 2018 07:14 PM, Bartosz Golaszewski wrote: > 2018-04-05 15:09 GMT+02:00 Sekhar Nori <nsek...@ti.com>: >> Hi Bartosz, >> >> On Friday 09 February 2018 10:18 PM, Michael Turquette wrote: >>> On Fri, Feb 9, 2018 at 8:22 AM, Bartosz Golaszewski

Re: [PATCH v5 12/44] clk: davinci: Add platform information for TI DA850 PSC

Hi Bartosz, On Friday 09 February 2018 10:18 PM, Michael Turquette wrote: > On Fri, Feb 9, 2018 at 8:22 AM, Bartosz Golaszewski wrote: >> 2018-01-08 3:17 GMT+01:00 David Lechner : >> Hi David, >> >> I've been working on moving the genpd code from its own

Re: [PATCH v5 12/44] clk: davinci: Add platform information for TI DA850 PSC

Hi Bart, On Thursday 05 April 2018 09:21 PM, Bartosz Golaszewski wrote: > 2018-04-05 16:36 GMT+02:00 Sekhar Nori <nsek...@ti.com>: >> On Thursday 05 April 2018 07:14 PM, Bartosz Golaszewski wrote: >>> 2018-04-05 15:09 GMT+02:00 Sekhar Nori <nsek...@ti.com>: >>&

Re: [RESEND PATCH v2 0/4] ARM: davinci: remove the mach-specific aemif driver - part 1

Hi Bartosz, On Tuesday 17 April 2018 03:59 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > This is the first part of changes required to remove duplicate aemif > support from mach-davinci. > > I actually noticed that one of my previous changes from

Re: [RESEND PATCH v2 4/4] ARM: davinci: use aemif platform driver in legacy mode for da850-evm

On Tuesday 17 April 2018 03:59 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > We now support board files in aemif. Use the platform driver instead > of the handcrafted API in da850-evm. > > Note: the id of davinci_nand is changed to 0 in order to make

Re: [RESEND PATCH v2 2/4] memory: aemif: add support for board files

On Tuesday 17 April 2018 03:59 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Currently aemif is supported in two places separately. By the platform > driver in drivers/memory and by a hand crafted driver in mach-davinci. > > We want to drop the latter

Re: [PATCH v6 6/7] remoteproc/davinci: use the reset framework

.@baylibre.com> Looks good! Reviewed-by: Sekhar Nori <nsek...@ti.com> This depends on DaVinci gaining common clock / reset framework support though. I am guessing remoteproc maintainers will have to be reminded when its safe to apply. Thanks, Sekhar

Re: [PATCH v6 3/7] remoteproc/davinci: add the missing retval check for clk_enable()

-by: Bartosz Golaszewski <bgolaszew...@baylibre.com> > Acked-by: Suman Anna <s-a...@ti.com> > Reviewed-by: David Lechner <da...@lechnology.com> Reviewed-by: Sekhar Nori <nsek...@ti.com> This should be safe to apply to v4.17-rc1 and should be queued by Ohad / Bjorn. Thanks, Sekhar

Re: [PATCH v6 5/7] remoteproc/davinci: use octal permissions for module_param()

On Tuesday 17 April 2018 11:00 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszew...@baylibre.com> > > Checkpatch recommends to use octal perms instead of S_IRUGO. > > Signed-off-by: Bartosz Golaszewski <bgolaszew...@baylibre.com> Reviewed-by:

Re: [RESEND PATCH v2 0/4] ARM: davinci: remove the mach-specific aemif driver - part 1

On Tuesday 17 April 2018 10:59 PM, Santosh Shilimkar wrote: > On 4/17/2018 5:36 AM, Bartosz Golaszewski wrote: >> 2018-04-17 12:53 GMT+02:00 Sekhar Nori <nsek...@ti.com>: >>> Hi Bartosz, > > [...] > >>>> This series applies on top of v8 of Davi

Re: [PATCH v6 4/7] remoteproc/davinci: prepare and unprepare the clock where needed

> Signed-off-by: Bartosz Golaszewski <bgolaszew...@baylibre.com> > Acked-by: Suman Anna <s-a...@ti.com> > Reviewed-by: David Lechner <da...@lechnology.com> Reviewed-by: Sekhar Nori <nsek...@ti.com> This should be safe to apply to v4.17-rc1 as well (for inclus

Re: [PATCH] ARM: dts: da850: use gpio-ranges

On Monday 16 April 2018 12:27 AM, David Lechner wrote: > On 02/23/2018 05:44 AM, Sekhar Nori wrote: >> On Thursday 22 February 2018 09:04 PM, Linus Walleij wrote: >>> On Mon, Feb 19, 2018 at 11:29 PM, David Lechner >>> <da...@lechnology.com> wrote: >>&

Re: [PATCH 2/2] memory: aemif: add support for board files

On Wednesday 18 April 2018 09:05 PM, Bartosz Golaszewski wrote: > @@ -373,15 +372,23 @@ static int aemif_probe(struct platform_device *pdev) > goto error; > } > > - /* > - * For every controller device node, there is a cs device node that > - * describe the bus

Re: [PATCH v5 12/44] clk: davinci: Add platform information for TI DA850 PSC

On Tuesday 24 April 2018 09:41 PM, David Lechner wrote: > On 04/24/2018 03:28 AM, Sekhar Nori wrote: >> On Monday 23 April 2018 08:29 PM, David Lechner wrote: >>> On 04/06/2018 11:46 AM, Stephen Boyd wrote: >>>> Quoting Sekhar Nori (2018-04-06 02:37:03) &g

Re: [RESEND PATCH v2 3/4] ARM: davinci: add aemif & nand support to da850-lcdk in legacy mode

On Wednesday 25 April 2018 02:44 PM, Bartosz Golaszewski wrote: > 2018-04-17 16:09 GMT+02:00 Sekhar Nori <nsek...@ti.com>: >> On Tuesday 17 April 2018 03:59 PM, Bartosz Golaszewski wrote: >>> From: Bartosz Golaszewski <bgolaszew...@baylibre.com> >>> >&g

Re: [RFC work-in-progress 5/7] !WIP ARM: davinci: convert da850 to using the davinci clocksource driver

On Tuesday 24 April 2018 12:08 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Signed-off-by: Bartosz Golaszewski > --- > arch/arm/mach-davinci/da850.c | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git

Re: [PATCH v5 12/44] clk: davinci: Add platform information for TI DA850 PSC

On Monday 23 April 2018 08:29 PM, David Lechner wrote: > On 04/06/2018 11:46 AM, Stephen Boyd wrote: >> Quoting Sekhar Nori (2018-04-06 02:37:03) >>> >>> Can you please check that and confirm there is no issue with genpd and >>> using CLK_OF_DECLARE() to i

<    6   7   8   9   10   11   12   13   14   15   >