Re: [PATCH v2 07/12] NTB: Introduce functions to calculate multi-port resource index

2019-03-12 Thread Serge Semin
On Wed, Mar 06, 2019 at 04:22:33PM -0700, Logan Gunthorpe wrote: > > On 2019-03-06 3:45 p.m., Serge Semin wrote: > [Snip] > > Pretty sure everything above is just agreement... > > > So your current approach is inbound MW-centralized, while mine is developed > > a

Re: [PATCH] spi: dw: Avoid stack content exposure

2021-02-11 Thread Serge Semin
/spi-dw-bt1.c: In function 'dw_spi_bt1_dirmap_copy_from_map': > drivers/spi/spi-dw-bt1.c:77:6: note: 'data' declared here >77 | u32 data; > | ^~~~ Can't believe I missed that. Thanks! Acked-by: Serge Semin > > Addresses-Coverity: CID 149777

Re: [PATCH] mtd: physmap: physmap-bt1-rom: Fix unintentional stack access

2021-02-12 Thread Serge Semin
e of code > is actually intended to be a byte offset. Thanks, one more time.) Acked-by: Serge Semin > > Fixes: b3e79e7682e0 ("mtd: physmap: Add Baikal-T1 physically mapped ROM > support") > Addresses-Coverity-ID: 1497765 ("Out-of-bounds access") > Cc

Re: [PATCH v6 09/10] usb: dwc3: qcom: Detect DWC3 DT-nodes with "usb"-prefixed names

2021-02-12 Thread Serge Semin
On Wed, Feb 10, 2021 at 10:33:26PM +0300, Serge Semin wrote: > On Wed, Feb 10, 2021 at 12:56:59PM -0600, Bjorn Andersson wrote: > > On Wed 10 Feb 12:40 CST 2021, Serge Semin wrote: > > > > > On Wed, Feb 10, 2021 at 12:17:27PM -0600, Rob Herring wrote: > > > &

Re: [PATCH v6 09/10] usb: dwc3: qcom: Detect DWC3 DT-nodes with "usb"-prefixed names

2021-02-12 Thread Serge Semin
On Fri, Feb 12, 2021 at 11:49:15AM -0600, Bjorn Andersson wrote: > On Wed 10 Feb 13:33 CST 2021, Serge Semin wrote: > > > On Wed, Feb 10, 2021 at 12:56:59PM -0600, Bjorn Andersson wrote: > > > On Wed 10 Feb 12:40 CST 2021, Serge Semin wrote: > > > > > > >

[PATCH v7 2/3] usb: dwc3: qcom: Detect DWC3 DT-nodes using compatible string

2021-02-12 Thread Serge Semin
mpatible string to match the "snps,dwc3". The semantic of the code won't change seeing all the DWC USB3 nodes are supposed to have the compatible property with any of those strings set. Signed-off-by: Serge Semin --- Changelog v7: - Replace "of_get_child_by_name(np, "

[PATCH v7 3/3] arm64: dts: qcom: Harmonize DWC USB3 DT nodes name

2021-02-12 Thread Serge Semin
In accordance with the DWC USB3 bindings the corresponding node name is suppose to comply with the Generic USB HCD DT schema, which requires the USB nodes to have the name acceptable by the regexp: "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly named.

[PATCH v7 1/3] usb: dwc3: qcom: Add missing DWC3 OF node refcount decrement

2021-02-12 Thread Serge Semin
there. Fixes: a4333c3a6ba9 ("usb: dwc3: Add Qualcomm DWC3 glue driver") Signed-off-by: Serge Semin --- Note the patch will get cleanly applied on the commit 2bc02355f8ba ("usb: dwc3: qcom: Add support for booting with ACPI"), while the bug has been there since the Qualcomm

Re: [PATCH v3 09/10] usb: dwc3: qcom: Detect DWC3 DT-nodes with "usb"-prefixed names

2021-02-10 Thread Serge Semin
On Wed, Feb 03, 2021 at 10:06:46AM +0100, Greg Kroah-Hartman wrote: > On Tue, Feb 02, 2021 at 05:02:08PM -0600, Bjorn Andersson wrote: > > On Sat 05 Dec 09:56 CST 2020, Serge Semin wrote: > > > > > In accordance with the USB HCD/DRD schema all the USB controllers are &

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-10 Thread Serge Semin
On Tue, Feb 09, 2021 at 10:56:46AM +, Russell King - ARM Linux admin wrote: > On Tue, Feb 09, 2021 at 11:37:29AM +0100, Heiner Kallweit wrote: > > Right, adding something like a genphy_{read,write}_mmd() doesn't make > > too much sense for now. What I meant is just exporting mmd_phy_indirect().

[PATCH v6 04/10] arm: dts: lpc18xx: Harmonize EHCI/OHCI DT nodes name

2021-02-10 Thread Serge Semin
hci"-compatible nodes are correctly named. Signed-off-by: Serge Semin Acked-by: Vladimir Zapolskiy Acked-by: Krzysztof Kozlowski --- arch/arm/boot/dts/lpc18xx.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/lpc18xx.dtsi b/arch/arm/boot/dts/l

[PATCH v6 03/10] arc: dts: Harmonize EHCI/OHCI DT nodes name

2021-02-10 Thread Serge Semin
hci"-compatible nodes are correctly named. Signed-off-by: Serge Semin Acked-by: Alexey Brodkin Acked-by: Krzysztof Kozlowski --- arch/arc/boot/dts/axc003.dtsi| 4 ++-- arch/arc/boot/dts/axc003_idu.dtsi| 4 ++-- arch/arc/boot/dts/axs10x_mb.dtsi | 4 ++-- arch/arc/boot/dts/hsdk.dt

[PATCH v6 02/10] arm: dts: keystone: Correct DWC USB3 compatible string

2021-02-10 Thread Serge Semin
Syonpsys IP cores are supposed to be defined with "snps" vendor-prefix. Use it instead of the deprecated "synopsys" one. Signed-off-by: Serge Semin Reviewed-by: Krzysztof Kozlowski --- arch/arm/boot/dts/keystone-k2e.dtsi | 2 +- arch/arm/boot/dts/keystone.dtsi | 2 +-

[PATCH RESEND v6 00/10] dt-bindings: usb: Harmonize xHCI/EHCI/OHCI/DWC3 nodes name

2021-02-10 Thread Serge Semin
org Cc: linux-arm-...@vger.kernel.org Cc: devicet...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Serge Semin (10): arm: dts: ls1021a: Harmonize DWC USB3 DT nodes name arm: dts: keystone: Correct DWC USB3 compatible string arc: dts: Harmonize EHCI/OHCI DT nodes name arm: dts: lpc18xx: Harmoni

[PATCH v6 01/10] arm: dts: ls1021a: Harmonize DWC USB3 DT nodes name

2021-02-10 Thread Serge Semin
In accordance with the DWC USB3 bindings the corresponding node name is suppose to comply with the Generic USB HCD DT schema, which requires the USB nodes to have the name acceptable by the regexp: "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly named.

[PATCH v6 06/10] arm: dts: keystone: Harmonize DWC USB3 DT nodes name

2021-02-10 Thread Serge Semin
In accordance with the DWC USB3 bindings the corresponding node name is suppose to comply with the Generic USB HCD DT schema, which requires the USB nodes to have the name acceptable by the regexp: "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly named.

[PATCH v6 07/10] arm: dts: stih407-family: Harmonize DWC USB3 DT nodes name

2021-02-10 Thread Serge Semin
In accordance with the DWC USB3 bindings the corresponding node name is suppose to comply with the Generic USB HCD DT schema, which requires the USB nodes to have the name acceptable by the regexp: "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly named.

[PATCH v6 09/10] usb: dwc3: qcom: Detect DWC3 DT-nodes with "usb"-prefixed names

2021-02-10 Thread Serge Semin
the deprecated naming so not to fail on the legacy DTS-files passed to the newer kernels. Signed-off-by: Serge Semin Reviewed-by: Bjorn Andersson --- drivers/usb/dwc3/dwc3-qcom.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/d

[PATCH v6 08/10] arm64: dts: apm: Harmonize DWC USB3 DT nodes name

2021-02-10 Thread Serge Semin
spite of the warning comment about possible backward compatibility issues. Signed-off-by: Serge Semin Acked-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 4 ++-- arch/arm64/boot/dts/apm/apm-storm.dtsi | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-

[PATCH v6 05/10] powerpc: dts: akebono: Harmonize EHCI/OHCI DT nodes name

2021-02-10 Thread Serge Semin
hci"-compatible nodes are correctly named. Signed-off-by: Serge Semin Acked-by: Krzysztof Kozlowski --- arch/powerpc/boot/dts/akebono.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/boot/dts/akebono.dts b/arch/powerpc/boot/dts/akebono.dts index df18f8dc4

[PATCH v6 10/10] arm64: dts: qcom: Harmonize DWC USB3 DT nodes name

2021-02-10 Thread Serge Semin
In accordance with the DWC USB3 bindings the corresponding node name is suppose to comply with the Generic USB HCD DT schema, which requires the USB nodes to have the name acceptable by the regexp: "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly named.

Re: [PATCH 00/16] net: stmmac: Add DW MAC GPIOs and Baikal-T1 GMAC support

2021-02-10 Thread Serge Semin
On Tue, Feb 09, 2021 at 03:11:41PM +0100, Andrew Lunn wrote: > > Regarding splitting the series up. I don't see a problem in just > > sending the cover-letter patch and actual GPIO-related patches to > > the GPIO-maintainers with no need to have them added to Cc in the rest > > of the series. > >

Re: [PATCH v6 09/10] usb: dwc3: qcom: Detect DWC3 DT-nodes with "usb"-prefixed names

2021-02-10 Thread Serge Semin
On Wed, Feb 10, 2021 at 12:17:27PM -0600, Rob Herring wrote: > On Wed, Feb 10, 2021 at 11:29 AM Serge Semin > wrote: > > > > In accordance with the USB HCD/DRD schema all the USB controllers are > > supposed to have DT-nodes named with prefix "^usb(@.*)?". Since

Re: [PATCH RESEND v6 00/10] dt-bindings: usb: Harmonize xHCI/EHCI/OHCI/DWC3 nodes name

2021-02-10 Thread Serge Semin
On Wed, Feb 10, 2021 at 10:21:47AM -0800, Florian Fainelli wrote: > On 2/10/21 9:28 AM, Serge Semin wrote: > > As the subject states this series is an attempt to harmonize the xHCI, > > EHCI, OHCI and DWC USB3 DT nodes with the DT schema introduced in the > > framewo

Re: [PATCH v6 09/10] usb: dwc3: qcom: Detect DWC3 DT-nodes with "usb"-prefixed names

2021-02-10 Thread Serge Semin
On Wed, Feb 10, 2021 at 12:56:59PM -0600, Bjorn Andersson wrote: > On Wed 10 Feb 12:40 CST 2021, Serge Semin wrote: > > > On Wed, Feb 10, 2021 at 12:17:27PM -0600, Rob Herring wrote: > > > On Wed, Feb 10, 2021 at 11:29 AM Serge Semin > > > wrote: > > > &

Re: [PATCH v2 04/24] dt-bindings: net: dwmac: Refactor snps,*-config properties

2021-02-10 Thread Serge Semin
On Tue, Feb 09, 2021 at 04:26:08PM -0600, Rob Herring wrote: > On Mon, Feb 08, 2021 at 04:55:48PM +0300, Serge Semin wrote: > > Currently the "snps,axi-config", "snps,mtl-rx-config" and > > "snps,mtl-tx-config" properties are declared as a single phand

Re: [PATCH v2 07/24] dt-bindings: net: dwmac: Detach Generic DW MAC bindings

2021-02-10 Thread Serge Semin
On Tue, Feb 09, 2021 at 04:32:58PM -0600, Rob Herring wrote: > On Mon, Feb 08, 2021 at 04:55:51PM +0300, Serge Semin wrote: > > Currently the snps,dwmac.yaml DT bindings file is used for both DT nodes > > describing generic DW MAC devices and as DT schema with common properties >

Re: [PATCH v2 16/24] net: stmmac: Use optional reset control API to work with stmmaceth

2021-02-10 Thread Serge Semin
On Wed, Feb 10, 2021 at 02:49:24PM +0800, Jisheng Zhang wrote: > Hi, > > On Mon, 8 Feb 2021 16:56:00 +0300 Serge Semin wrote: > > > > > > Since commit bb3222f71b57 ("net: stmmac: platform: use optional clk/reset > > get APIs") a manual implemen

Re: [PATCH 01/16] dt-bindings: net: dwmac: Add DW GMAC GPIOs properties

2021-02-10 Thread Serge Semin
On Tue, Feb 09, 2021 at 05:13:52PM -0600, Rob Herring wrote: > On Mon, Feb 08, 2021 at 05:08:05PM +0300, Serge Semin wrote: > > Synopsys DesignWare Ethernet controllers can be synthesized with > > General-Purpose IOs support. GPIOs can work either as inputs or as outputs > &g

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-11 Thread Serge Semin
On Thu, Feb 11, 2021 at 10:39:41AM +, Russell King - ARM Linux admin wrote: > On Wed, Feb 10, 2021 at 07:47:20PM +0300, Serge Semin wrote: > > On Tue, Feb 09, 2021 at 10:56:46AM +, Russell King - ARM Linux admin > > wrote: > > > On Tue, Feb 09, 2021 at 11:37:29A

Re: [PATCH v7 1/3] usb: dwc3: qcom: Add missing DWC3 OF node refcount decrement

2021-02-18 Thread Serge Semin
eb 12, 2021 at 11:55:19PM +0300, Serge Semin wrote: > of_get_child_by_name() increments the reference counter of the OF node it > managed to find. So after the code is done using the device node, the > refcount must be decremented. Add missing of_node_put() invocation then > to the dwc3_qcom

Re: [PATCH v7 1/3] usb: dwc3: qcom: Add missing DWC3 OF node refcount decrement

2021-02-18 Thread Serge Semin
On Thu, Feb 18, 2021 at 04:32:29PM +0100, Greg Kroah-Hartman wrote: > On Thu, Feb 18, 2021 at 06:29:04PM +0300, Serge Semin wrote: > > Bjorn, Greg, Felippe, Andy, > > Any comments on this series? Bjorn, Greg you asked me to resend the > > patches related with the DW USB3 node

Re: [PATCH 01/16] dt-bindings: net: dwmac: Add DW GMAC GPIOs properties

2021-02-18 Thread Serge Semin
On Thu, Feb 11, 2021 at 01:28:06AM +0300, Serge Semin wrote: > On Tue, Feb 09, 2021 at 05:13:52PM -0600, Rob Herring wrote: > > On Mon, Feb 08, 2021 at 05:08:05PM +0300, Serge Semin wrote: > > > Synopsys DesignWare Ethernet controllers can be synthesized with > > >

Re: [PATCH v2 04/24] dt-bindings: net: dwmac: Refactor snps,*-config properties

2021-02-18 Thread Serge Semin
On Thu, Feb 11, 2021 at 12:58:00AM +0300, Serge Semin wrote: > On Tue, Feb 09, 2021 at 04:26:08PM -0600, Rob Herring wrote: > > On Mon, Feb 08, 2021 at 04:55:48PM +0300, Serge Semin wrote: > > > Currently the "snps,axi-config", "snps,mtl-rx-config" and >

Re: [PATCH v3 09/10] usb: dwc3: qcom: Detect DWC3 DT-nodes with "usb"-prefixed names

2021-02-03 Thread Serge Semin
On Wed, Feb 03, 2021 at 10:06:46AM +0100, Greg Kroah-Hartman wrote: > On Tue, Feb 02, 2021 at 05:02:08PM -0600, Bjorn Andersson wrote: > > On Sat 05 Dec 09:56 CST 2020, Serge Semin wrote: > > > > > In accordance with the USB HCD/DRD schema all the USB controllers are &

[PATCH 06/16] net: stmmac: Extend DMA IRQs enable/disable interface

2021-02-08 Thread Serge Semin
le the DMA IRQs anymore. Such modification won't break the DMA-related code because the default macro has both Tx and Rx DMA IRQs flags set anyway. So in order to make things working as usual we just need to call the stmmac_enable_dma_irq() method aside with the generic IRQs activating function.

[PATCH 10/16] net: stmmac: Convert STMMAC_DOWN flag to STMMAC_UP

2021-02-08 Thread Serge Semin
onous flag switching together with the IRQs unmasking and masking. Luckily the IRQs are normally enabled/disable in the late/early network initialization stages respectively. Signed-off-by: Serge Semin --- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 +- drivers/net/ethernet/stmi

[PATCH 12/16] net: stmmac: Introduce NIC software reset function

2021-02-08 Thread Serge Semin
uired for some early versions of DW GMAC (in our case it's DW GMAC v3.73a). Signed-off-by: Serge Semin --- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 32 +-- 1 file changed, 30 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

[PATCH 08/16] net: stmmac: Introduce Safety Feature IRQs enable/disable methods

2021-02-08 Thread Serge Semin
them have been enabled by default. Signed-off-by: Serge Semin --- Folks, the zero initialization of the DW xGMAC XGMAC_MTL_ECC_CONTROL register looks suspicious. Are you sure it is supposed to be cleared out in order to enable the safety IRQs? --- .../net/ethernet/stmicro/stmmac/dwmac4_core.c

[PATCH 16/16] net: stmmac: Add DW MAC IPs of 3.72a/3.73a/3.74a versions

2021-02-08 Thread Serge Semin
if there were no more specific glue-driver for them. Signed-off-by: Serge Semin --- drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c

[PATCH 15/16] net: stmmac: Add DW GMAC GPIOs support

2021-02-08 Thread Serge Semin
. Signed-off-by: Serge Semin --- Folks, I don't know whether the same GPIO CSR layout is defined for some other DW MAC IP-core. So for now the accessors have been created for GMACs only. But if you are sure the callbacks can be used for some other IP, I can move them to dwmac_lib.c. Though in

[PATCH 14/16] net: stmmac: Add Generic DW MAC GPIO port driver

2021-02-08 Thread Serge Semin
to the initial state too. Instead we suggest to at least restore the DMA/MAC registers to the initial state, when the software reset were supposed to happen. Signed-off-by: Serge Semin --- .../ethernet/stmicro/stmmac.rst | 4 + drivers/net/ethernet/stmicro/stmmac/Kconfig |

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-08 Thread Serge Semin
On Mon, Feb 08, 2021 at 04:27:36PM +0100, Andrew Lunn wrote: > On Mon, Feb 08, 2021 at 05:03:22PM +0300, Serge Semin wrote: > > It has been noticed that RTL8211E PHY stops detecting and reporting events > > when EEE is successfully advertised and RXC stopping in LPI is enabled.

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-09 Thread Serge Semin
On Mon, Feb 08, 2021 at 09:14:02PM +0100, Heiner Kallweit wrote: > On 08.02.2021 15:03, Serge Semin wrote: > > It has been noticed that RTL8211E PHY stops detecting and reporting events > > when EEE is successfully advertised and RXC stopping in LPI is enabled. > > The freez

Re: [PATCH v2 00/24] net: stmmac: Fix clocks/reset-related procedures

2021-02-09 Thread Serge Semin
On Mon, Feb 08, 2021 at 11:05:21AM -0800, Jakub Kicinski wrote: > On Mon, 8 Feb 2021 16:55:44 +0300 Serge Semin wrote: > > Baikal-T1 SoC is equipped with two Synopsys DesignWare GMAC v3.73a-based > > ethernet interfaces with no internal Ethernet PHY attached. The IP-cores > &

Re: [PATCH 00/16] net: stmmac: Add DW MAC GPIOs and Baikal-T1 GMAC support

2021-02-09 Thread Serge Semin
On Mon, Feb 08, 2021 at 08:36:33PM +0100, Andrew Lunn wrote: > On Mon, Feb 08, 2021 at 05:08:04PM +0300, Serge Semin wrote: > > Hi Serge > > I suggest you split this patchset up. This uses the generic GPIO > framework, which is great. But that also means you should be Cc: th

[PATCH v4 5/7] watchdog: dw_wdt: Support devices with asynch clocks

2020-05-30 Thread Serge Semin
ynchronous configuration. Signed-off-by: Serge Semin Reviewed-by: Guenter Roeck Cc: Alexey Malahov Cc: Thomas Bogendoerfer Cc: Arnd Bergmann Cc: Rob Herring Cc: linux-m...@vger.kernel.org Cc: devicet...@vger.kernel.org --- Changelog v2: - Rearrange SoBs. --- drivers/watchdog/dw_

[PATCH v4 2/7] dt-bindings: watchdog: dw-wdt: Support devices with asynch clocks

2020-05-30 Thread Serge Semin
pport the optional APB3 bus clock specified along with the mandatory watchdog timer reference clock. Signed-off-by: Serge Semin Reviewed-by: Rob Herring Reviewed-by: Guenter Roeck Cc: Alexey Malahov Cc: Thomas Bogendoerfer Cc: Arnd Bergmann Cc: linux-m...@vger.kernel.org --- Changelog v2: - I

[PATCH v4 4/7] watchdog: dw_wdt: Support devices with non-fixed TOP values

2020-05-30 Thread Serge Semin
support the new timeouts data structure. Signed-off-by: Serge Semin Reviewed-by: Guenter Roeck Cc: Alexey Malahov Cc: Thomas Bogendoerfer Cc: Arnd Bergmann Cc: Rob Herring Cc: linux-m...@vger.kernel.org Cc: devicet...@vger.kernel.org --- Changelog v2: - Rearrange SoBs. - Add "ms" suffix

[PATCH v4 6/7] watchdog: dw_wdt: Add pre-timeouts support

2020-05-30 Thread Serge Semin
happens, the IRQ lane will be left pending until it's cleared by the timer restart. Signed-off-by: Serge Semin Reviewed-by: Guenter Roeck Cc: Alexey Malahov Cc: Thomas Bogendoerfer Cc: Arnd Bergmann Cc: Rob Herring Cc: linux-m...@vger.kernel.org Cc: devicet...@vger.kernel.org --- Changel

[PATCH v4 1/7] dt-bindings: watchdog: Convert DW WDT binding to DT schema

2020-05-30 Thread Serge Semin
references clock source, optional reset line and pre-timeout interrupt. Signed-off-by: Serge Semin Reviewed-by: Rob Herring Reviewed-by: Guenter Roeck Cc: Alexey Malahov Cc: Thomas Bogendoerfer Cc: Arnd Bergmann Cc: linux-m...@vger.kernel.org --- Changelog v2: - Rearrange SoBs. - Discard BE

[PATCH v4 0/7] watchdog: dw_wdt: Take Baikal-T1 DW WDT peculiarities into account

2020-05-30 Thread Serge Semin
dog/20200526154123.24402-1-sergey.se...@baikalelectronics.ru Changelog v4: - Add Guenter's Reviewed-by tags. - IRQ > 0 is only valid in Linux so make sure we request IRQ only if valid number is returned from platform_get_irq_optional(). Signed-off-by: Serge Semin Cc: Alexey Malahov Cc: Ma

[PATCH v4 3/7] dt-bindings: watchdog: dw-wdt: Add watchdog TOPs array property

2020-05-30 Thread Serge Semin
In case if DW Watchdog IP core is built with WDT_USE_FIX_TOP == false, a custom timeout periods are used to preset the timer counter. In this case that periods should be specified in a new "snps,watchdog-tops" property of the DW watchdog dts node. Signed-off-by: Serge Semin Review

[PATCH v4 7/7] watchdog: dw_wdt: Add DebugFS files

2020-05-30 Thread Serge Semin
For the sake of the easier device-driver debug procedure, we added a DebugFS file with the controller registers state. It's available only if kernel is configured with DebugFS support. Signed-off-by: Serge Semin Reviewed-by: Guenter Roeck Cc: Alexey Malahov Cc: Thomas Bogendoerfer Cc:

Re: [PATCH v6 01/11] dt-bindings: i2c: Convert DW I2C binding to DT schema

2020-05-30 Thread Serge Semin
Hello Wolfram On Sat, May 30, 2020 at 11:39:42AM +0200, Wolfram Sang wrote: > > Just double checking: > > > Signed-off-by: Serge Semin > > Reviewed-by: Rob Herring > > Rob, what about this checkpatch warning? > > WARNING: DT binding documents should be l

Re: [PATCH v6 08/11] i2c: designware: Convert driver to using regmap API

2020-05-31 Thread Serge Semin
On Sat, May 30, 2020 at 11:05:54PM +0200, Wolfram Sang wrote: > On Sat, May 30, 2020 at 01:09:30PM +0200, Wolfram Sang wrote: > > On Thu, May 28, 2020 at 12:33:18PM +0300, Serge Semin wrote: > > > Seeing the DW I2C driver is using flags-based accessors with two > > > c

Re: [PATCH v2] check: Add 10bit/slave i2c reg flags support

2020-05-31 Thread Serge Semin
On Sat, May 30, 2020 at 11:31:52AM +0200, Wolfram Sang wrote: > > > + addr = reg & 0x3FFFU; > > + snprintf(unit_addr, sizeof(unit_addr), "%x", addr); > > Hmm, this hardcoded value will not work if we ever need to add another > bit. I hope this will never happen, though. > > > +

[PATCH v2 1/6] dt-bindings: power: Convert mti,mips-cpc to DT schema

2020-06-01 Thread Serge Semin
It's a Cluster Power Controller embedded into the MIPS IP cores. Currently the corresponding dts node is supposed to have compatible and reg properties. Signed-off-by: Serge Semin Reviewed-by: Rob Herring --- Changelog prev: - Reword the changelog summary - use shorter version. - Lowe

[PATCH v2 4/6] mips: cdmm: Add mti,mips-cdmm dtb node support

2020-06-01 Thread Serge Semin
platforms by default. Signed-off-by: Serge Semin --- Changelog prev: - Use alphabetical order for the include pre-processor operator. --- drivers/bus/mips_cdmm.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/bus/mips_cdmm.c b/drivers/bus/mips_cdmm.c index

[PATCH v2 6/6] MAINTAINERS: Add maintainers for MIPS core drivers

2020-06-01 Thread Serge Semin
Add myself as a maintainer of MIPS CPU and GIC IRQchip, MIPS GIC timer and MIPS CPS CPUidle drivers. Signed-off-by: Serge Semin --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2926327e4976..f21e51c4a0d5 100644 --- a/MAINTAINERS

[PATCH v2 2/6] dt-bindings: interrupt-controller: Convert mti,gic to DT schema

2020-06-01 Thread Serge Semin
. MIPS GIC also includes a free-running global timer, per-CPU count/compare timers, and a watchdog. Since currently the GIC Timer is only supported the DT schema expects an IRQ and clock-phandler charged timer sub-node with "mti,mips-gic-timer" compatible string. Signed-off-by: Serge Sem

[PATCH RESEND v2 0/6] mips: Add DT bindings for MIPS CDMM and MIPS GIC

2020-06-01 Thread Serge Semin
s file for MIPS CDMM dt-node. - Convert mti,mips-cpc to DT schema. - Use a shorter summary describing the bindings modification patches. - Rearrange the SoBs with adding Alexey' co-development tag. - Lowercase the hex numbers in the dt-bindings. Changelog v2: - Resend. Signed-off-by: Serge

[PATCH v2 3/6] dt-bindings: bus: Add MIPS CDMM controller

2020-06-01 Thread Serge Semin
It's a Common Device Memory Map controller embedded into the MIPS IP cores, which dts node is supposed to have compatible and reg properties. Signed-off-by: Serge Semin Reviewed-by: Rob Herring --- Changelog prev: - Lowercase the example hex'es. --- .../bindings/bus/mti,mips

[PATCH v2 5/6] bus: cdmm: Add MIPS R5 arch support

2020-06-01 Thread Serge Semin
CDMM may be available not only on MIPS R2 architectures, but also on newer MIPS R5 chips. For instance our P5600 chip has one. Let's mark the CDMM bus being supported for that MIPS arch too. Signed-off-by: Serge Semin Reviewed-by: Thomas Bogendoerfer --- drivers/bus/Kconfig | 2 +- 1

Re: [PATCH v2 6/6] MAINTAINERS: Add maintainers for MIPS core drivers

2020-06-01 Thread Serge Semin
On Mon, Jun 01, 2020 at 04:56:21PM +0300, Andy Shevchenko wrote: > On Mon, Jun 1, 2020 at 3:26 PM Serge Semin > wrote: > > > > Add myself as a maintainer of MIPS CPU and GIC IRQchip, MIPS GIC timer > > and MIPS CPS CPUidle drivers. > ... > > +MIPS CORE DRIVER

Re: [PATCH RESEND v2 0/6] mips: Add DT bindings for MIPS CDMM and MIPS GIC

2020-06-01 Thread Serge Semin
Hello Marc, On Mon, Jun 01, 2020 at 01:31:27PM +0100, Marc Zyngier wrote: > On 2020-06-01 13:21, Serge Semin wrote: > > [...] > > > Since Paul isn't looking after the MIPS arch code anymore, Ralf hasn't > > been seen maintaining MIPS for a long time, Thomas is

Re: [PATCH v2 6/6] MAINTAINERS: Add maintainers for MIPS core drivers

2020-06-01 Thread Serge Semin
On Mon, Jun 01, 2020 at 06:30:22PM +0300, Andy Shevchenko wrote: > On Mon, Jun 1, 2020 at 6:19 PM Serge Semin > wrote: > > On Mon, Jun 01, 2020 at 04:56:21PM +0300, Andy Shevchenko wrote: > > > On Mon, Jun 1, 2020 at 3:26 PM Serge Semin > > > wrote: > > >

Re: [PATCH RESEND v2 0/6] mips: Add DT bindings for MIPS CDMM and MIPS GIC

2020-06-01 Thread Serge Semin
On Mon, Jun 01, 2020 at 06:56:46PM +0200, Thomas Bogendoerfer wrote: > On Mon, Jun 01, 2020 at 06:24:49PM +0300, Serge Semin wrote: > > Hello Marc, > > > > On Mon, Jun 01, 2020 at 01:31:27PM +0100, Marc Zyngier wrote: > > > On 2020-

Re: [PATCH v2 2/6] dt-bindings: dma: dw: Add max burst transaction length property

2020-05-18 Thread Serge Semin
On Mon, May 18, 2020 at 11:30:03AM -0600, Rob Herring wrote: > On Sun, May 17, 2020 at 08:47:39PM +0300, Serge Semin wrote: > > On Fri, May 15, 2020 at 02:11:13PM +0300, Serge Semin wrote: > > > On Fri, May 15, 2020 at 04:26:58PM +0530, Vinod Koul wrote: > > > > On 15

Re: [PATCH v2 18/20] mips: csrc-r4k: Decrease r4k-clocksource rating if CPU_FREQ enabled

2020-05-18 Thread Serge Semin
On Mon, May 18, 2020 at 06:32:06PM +0200, Thomas Bogendoerfer wrote: > On Mon, May 18, 2020 at 04:48:20PM +0300, Serge Semin wrote: > > On Fri, May 15, 2020 at 11:06:47PM +0200, Thomas Bogendoerfer wrote: > > > On Fri, May 15, 2020 at 10:48:27AM +0300, Serge Semin wro

Re: [PATCH 2/2] spi: Add Baikal-T1 System Boot SPI Controller driver

2020-05-18 Thread Serge Semin
On Mon, May 18, 2020 at 04:19:47PM +0100, Mark Brown wrote: > On Mon, May 18, 2020 at 03:05:42AM +0300, Serge Semin wrote: > > On Mon, May 11, 2020 at 10:25:06PM +0100, Mark Brown wrote: > > > > Yes, some flags should work here - the issue was that at least some > &g

Re: [PATCH 1/2] dt-bindings: spi: Add Baikal-T1 System Boot SPI Controller binding

2020-05-18 Thread Serge Semin
On Mon, May 18, 2020 at 09:26:59AM -0600, Rob Herring wrote: > On Fri, May 08, 2020 at 12:36:20PM +0300, Serge Semin wrote: > > Baikal-T1 Boot SPI is a part of the SoC System Controller and is > > responsible for the system bootup from an external SPI flash. It's a DW &

Re: [PATCH v2 03/12] dt-bindings: i2c: dw: Add Baikal-T1 SoC I2C controller

2020-05-18 Thread Serge Semin
On Mon, May 18, 2020 at 02:33:19PM -0600, Rob Herring wrote: > On Sun, May 10, 2020 at 12:50:09PM +0300, Serge Semin wrote: > > Add the "baikal,bt1-sys-i2c" compatible string to the DW I2C binding and > > make sure the reg property isn't required in this case because

Re: [PATCH v2 3/7] dt-bindings: watchdog: dw-wdt: Add watchdog TOPs array property

2020-05-18 Thread Serge Semin
On Mon, May 18, 2020 at 02:40:37PM -0600, Rob Herring wrote: > On Sun, May 10, 2020 at 01:58:03PM +0300, Serge Semin wrote: > > In case if DW Watchdog IP core is built with WDT_USE_FIX_TOP == false, > > a custom timeout periods are used to preset the timer counter. In > > t

Re: [PATCH 1/2] dt-bindings: spi: Add Baikal-T1 System Boot SPI Controller binding

2020-05-18 Thread Serge Semin
On Mon, May 18, 2020 at 09:26:59AM -0600, Rob Herring wrote: > On Fri, May 08, 2020 at 12:36:20PM +0300, Serge Semin wrote: > > Baikal-T1 Boot SPI is a part of the SoC System Controller and is > > responsible for the system bootup from an external SPI flash. It's a DW &

Re: [PATCH v2 1/2] dt-bindings: memory: Add Baikal-T1 L2-cache Control Block binding

2020-05-19 Thread Serge Semin
03AM +0300, Serge Semin wrote: > There is a single register provided by the SoC system controller, > which can be used to tune the L2-cache RAM up. It only provides a way > to change the L2-RAM access latencies. So aside from "be,bt1-l2-ctl" > compatible string the device node

Re: [PATCH v2 1/4] dt-bindings: clk: Add Baikal-T1 CCU PLLs binding

2020-05-19 Thread Serge Semin
On Thu, May 14, 2020 at 02:13:18PM -0500, Rob Herring wrote: > On Thu, May 07, 2020 at 01:22:57AM +0300, Serge Semin wrote: > > Baikal-T1 Clocks Control Unit is responsible for transformation of a > > signal coming from an external oscillator into clocks of various > > fre

Re: [PATCH 4/7] gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip

2020-07-29 Thread Serge Semin
On Mon, Jul 27, 2020 at 12:22:28AM +0200, Linus Walleij wrote: > On Sat, Jul 25, 2020 at 1:03 AM Serge Semin > wrote: > > > According to the DW APB GPIO databook it can be configured to provide > > either a > > combined IRQ line or multiple interrupt signals for ea

Re: [PATCH 4/7] gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip

2020-07-29 Thread Serge Semin
On Wed, Jul 29, 2020 at 06:10:24PM +0300, Andy Shevchenko wrote: > On Wed, Jul 29, 2020 at 3:58 PM Serge Semin > wrote: > > On Mon, Jul 27, 2020 at 12:22:28AM +0200, Linus Walleij wrote: > > ... > > > Sorry for a delay with a response to this issue. I had to g

[PATCH v2 00/10] gpio: dwapb: Refactor GPIO resources initialization

2020-07-30 Thread Serge Semin
macro. - Introduce dwapb_convert_irqs() method to convert the sparse parental IRQs array into an array of linearly distributed IRQs correctly perceived by GPIO-lib. Signed-off-by: Serge Semin Cc: Andy Shevchenko Cc: Andy Shevchenko Cc: Alexey Malahov Cc: Pavel Parkhomenko Cc: Rob Herring Cc:

[PATCH v2 02/10] gpio: dwapb: Add ngpios DT-property support

2020-07-30 Thread Serge Semin
rors log above shall motivate the platform developer to convert the DW APB GPIO DT-nodes to using the standard number of GPIOs property. Signed-off-by: Serge Semin Reviewed-by: Andy Shevchenko --- drivers/gpio/gpio-dwapb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH v2 05/10] gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip

2020-07-30 Thread Serge Semin
4) nor 5) shall cause a regression of commit 6a2f4b7dadd5 ("gpio: dwapb: use a second irq chip"), since the later isn't properly used here anyway. Signed-off-by: Serge Semin --- Note in this patch we omit the next GPIO-lib IRQ-chip settings initialization: gc->irq.map gc->ir

[PATCH v2 08/10] gpio: dwapb: Get reset control by means of resource managed interface

2020-07-30 Thread Serge Semin
be purely managed by the device resources interface. Signed-off-by: Serge Semin Reviewed-by: Andy Shevchenko --- drivers/gpio/gpio-dwapb.c | 35 +-- 1 file changed, 29 insertions(+), 6 deletions(-) diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio

[PATCH v2 10/10] gpio: dwapb: Use resource managed GPIO-chip add data method

2020-07-30 Thread Serge Semin
done for it. All the cleanups are now performed by means of the device managed framework. Signed-off-by: Serge Semin Reviewed-by: Andy Shevchenko --- drivers/gpio/gpio-dwapb.c | 37 ++--- 1 file changed, 2 insertions(+), 35 deletions(-) diff --git a/drivers/gpio

[PATCH v2 09/10] gpio: dwapb: Get clocks by means of resource managed interface

2020-07-30 Thread Serge Semin
clocks acquisition and release will be purely managed by the device resources interface. Signed-off-by: Serge Semin Reviewed-by: Andy Shevchenko --- drivers/gpio/gpio-dwapb.c | 48 ++- 1 file changed, 32 insertions(+), 16 deletions(-) diff --git a/drivers/gpio

[PATCH v2 04/10] gpio: dwapb: Add max GPIOs macro

2020-07-30 Thread Serge Semin
Add a new macro DWAPB_MAX_GPIOS which defines the maximum possible number of GPIO lines corresponding to the maximum DW APB GPIO controller port width. Use the new macro instead of number literal 32 where it's applicable. Signed-off-by: Serge Semin --- drivers/gpio/gpio-dw

[PATCH v2 01/10] dt-bindings: gpio: dwapb: Add ngpios property support

2020-07-30 Thread Serge Semin
It's redundant to have a vendor-specific property describing a number of GPIOS while there is a generic one. Let's mark the former one as deprecated and define the "ngpios" property supported with constraints of being within [1; 32] range. Signed-off-by: Serge Semin Revi

[PATCH v2 06/10] gpio: dwapb: Discard GPIO-to-IRQ mapping function

2020-07-30 Thread Serge Semin
: Serge Semin --- Changelog v2: - This is a new patch detached from commit "gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip". --- drivers/gpio/gpio-dwapb.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwa

[PATCH v2 07/10] gpio: dwapb: Discard ACPI GPIO-chip IRQs request

2020-07-30 Thread Serge Semin
Since GPIOlib-based IRQ-chip interface is now utilized there is no need in calling the methods acpi_gpiochip_{request,free}_interrupts() here. They will be called from gpiochip_add_irqchip()/gpiochip_irqchip_remove() anyway. Signed-off-by: Serge Semin --- Changelog v2: - This is a new patch

[PATCH v2 03/10] gpio: dwapb: Move MFD-specific IRQ handler

2020-07-30 Thread Serge Semin
For better readability let's group all the IRQ handlers in a single place of the driver instead of having them scatter around all over the file. Signed-off-by: Serge Semin Reviewed-by: Andy Shevchenko --- drivers/gpio/gpio-dwapb.c | 10 +- 1 file changed, 5 insertions(+), 5 dele

Re: [PATCH v2 04/10] gpio: dwapb: Add max GPIOs macro

2020-07-30 Thread Serge Semin
On Thu, Jul 30, 2020 at 05:05:26PM +0300, Andy Shevchenko wrote: > On Thu, Jul 30, 2020 at 04:55:30PM +0300, Serge Semin wrote: > > Add a new macro DWAPB_MAX_GPIOS which defines the maximum possible number > > of GPIO lines corresponding to the maximum DW APB GPIO controller port

Re: [PATCH v2 00/10] gpio: dwapb: Refactor GPIO resources initialization

2020-07-30 Thread Serge Semin
Wou, I've confused my SOB tag here. Linus, if no additional patchset revision is required, could you please replace it with: Signed-off-by: Serge Semin ? Alternatively I could resend the series with correct version of the tag. -Sergey On Thu, Jul 30, 2020 at 04:55:26PM +0300, Serge

Re: [PATCH v2 04/10] gpio: dwapb: Add max GPIOs macro

2020-07-30 Thread Serge Semin
On Thu, Jul 30, 2020 at 05:05:26PM +0300, Andy Shevchenko wrote: > On Thu, Jul 30, 2020 at 04:55:30PM +0300, Serge Semin wrote: > > Add a new macro DWAPB_MAX_GPIOS which defines the maximum possible number > > of GPIO lines corresponding to the maximum DW APB GPIO controller port

Re: [PATCH v2 05/10] gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip

2020-07-30 Thread Serge Semin
On Thu, Jul 30, 2020 at 05:26:18PM +0300, Andy Shevchenko wrote: > On Thu, Jul 30, 2020 at 04:55:31PM +0300, Serge Semin wrote: > > GPIO-lib provides a ready-to-use interface to initialize an IRQ-chip on > > top of a GPIO chip. It's better from maintainability and readability

[PATCH v3 05/10] gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip

2020-07-30 Thread Serge Semin
ote neither 4) nor 5) shall cause a regression of commit 6a2f4b7dadd5 ("gpio: dwapb: use a second irq chip"), since the later isn't properly used here anyway. Signed-off-by: Serge Semin --- Note in this patch we omit the next GPIO-lib IRQ-chip settings initialization: gc->irq.map

[PATCH v3 03/10] gpio: dwapb: Move MFD-specific IRQ handler

2020-07-30 Thread Serge Semin
For better readability let's group all the IRQ handlers in a single place of the driver instead of having them scatter around all over the file. Signed-off-by: Serge Semin Reviewed-by: Andy Shevchenko --- drivers/gpio/gpio-dwapb.c | 10 +- 1 file changed, 5 insertions(+), 5 dele

[PATCH v3 09/10] gpio: dwapb: Get clocks by means of resource managed interface

2020-07-30 Thread Serge Semin
clocks acquisition and release will be purely managed by the device resources interface. Signed-off-by: Serge Semin Reviewed-by: Andy Shevchenko --- drivers/gpio/gpio-dwapb.c | 48 ++- 1 file changed, 32 insertions(+), 16 deletions(-) diff --git a/drivers/gpio

[PATCH v3 07/10] gpio: dwapb: Discard ACPI GPIO-chip IRQs request

2020-07-30 Thread Serge Semin
Since GPIOlib-based IRQ-chip interface is now utilized there is no need in calling the methods acpi_gpiochip_{request,free}_interrupts() here. They will be called from gpiochip_add_irqchip()/gpiochip_irqchip_remove() anyway. Signed-off-by: Serge Semin Reviewed-by: Andy Shevchenko

[PATCH v3 02/10] gpio: dwapb: Add ngpios DT-property support

2020-07-30 Thread Serge Semin
rors log above shall motivate the platform developer to convert the DW APB GPIO DT-nodes to using the standard number of GPIOs property. Signed-off-by: Serge Semin Reviewed-by: Andy Shevchenko --- drivers/gpio/gpio-dwapb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH v3 10/10] gpio: dwapb: Use resource managed GPIO-chip add data method

2020-07-30 Thread Serge Semin
done for it. All the cleanups are now performed by means of the device managed framework. Signed-off-by: Serge Semin Reviewed-by: Andy Shevchenko --- drivers/gpio/gpio-dwapb.c | 37 ++--- 1 file changed, 2 insertions(+), 35 deletions(-) diff --git a/drivers/gpio

<    1   2   3   4   5   6   7   8   9   10   >