Re: [PATCH] input: Export matrix_keypad_parse_of_params()

2013-04-17 Thread Simon Glass
] undefined! Reported-by: Randy Dunlap rdun...@infradead.org Acked-by: Dmitry Torokhov dmitry.torok...@gmail.com Signed-off-by: Michal Marek mma...@suse.cz Acked-by: Simon Glass s...@chromium.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH v6 0/6] Add ChromeOS Embedded Controller support

2013-03-18 Thread Simon Glass
Hi Samuel, On Wed, Feb 27, 2013 at 12:40 AM, Samuel Ortiz sa...@linux.intel.com wrote: Hi Simon, On Tue, Feb 26, 2013 at 09:13:06PM -0800, Simon Glass wrote: Hi Samuel, On Mon, Feb 25, 2013 at 2:08 PM, Simon Glass s...@chromium.org wrote: The ChromeOS Embedded Controller (EC) is an Open

Re: [PATCH v6 0/6] Add ChromeOS Embedded Controller support

2013-03-19 Thread Simon Glass
Hi Samuel, On Tue, Mar 19, 2013 at 6:12 PM, Samuel Ortiz sa...@linux.intel.com wrote: On Wed, Mar 20, 2013 at 01:56:52AM +0100, Samuel Ortiz wrote: Hi Simon, On Mon, Feb 25, 2013 at 02:08:35PM -0800, Simon Glass wrote: The ChromeOS Embedded Controller (EC) is an Open Source EC

Re: [PATCH v6 0/6] Add ChromeOS Embedded Controller support

2013-03-20 Thread Simon Glass
Hi Samuel, On Wed, Mar 20, 2013 at 1:52 AM, Samuel Ortiz sa...@linux.intel.com wrote: Hi Simon, On Wed, Mar 20, 2013 at 09:14:56AM +0100, Samuel Ortiz wrote: On Tue, Mar 19, 2013 at 07:01:42PM -0700, Simon Glass wrote: Hi Samuel, On Tue, Mar 19, 2013 at 6:12 PM, Samuel Ortiz sa

Re: [patch] drivers, mfd: fix link error

2013-03-21 Thread Simon Glass
/mfd/cros_ec.ko] undefined! Fix it by selecting CONFIG_MFD_CORE anytime CONFIG_MFD_CROS_EC is enabled. Signed-off-by: David Rientjes rient...@google.com Take 2 Acked-by: Simon Glass s...@chromium.org --- drivers/mfd/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd

Re: [PATCH] i2c: exynos5: add High Speed I2C controller driver

2013-03-12 Thread Simon Glass
[please excuse my mailer html confusion] Hi Naveen, On Mon, Mar 11, 2013 at 9:32 PM, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: Adds support for High Speed I2C driver found in Exynos5 and later SoCs from Samsung. This driver currently supports Auto mode. Driver only supports

Re: [PATCH 1/2] Boottime: A tool for automatic measurement of kernel/bootloader boot time

2012-11-29 Thread Simon Glass
Hi, On Tue, Nov 20, 2012 at 8:16 AM, Lee Jones lee.jo...@linaro.org wrote: +/* for automatic boot timing testcases */ +#define ATAG_BOOTTIME 0x41000403 Where can I refer this ATAG usage? can you point out the reference URL or patches? I assumed this would be in Mainline u-boot, but

Re: [PATCH 2/2] i2c-s3c2410: Add bus arbitration implementation

2012-11-29 Thread Simon Glass
+Olof On Thu, Nov 29, 2012 at 8:34 AM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Thu, Nov 29, 2012 at 10:35:35AM +0530, Naveen Krishna Chatradhi wrote: The arbitrator is a general purpose function which uses two GPIOs to communicate with another device to claim/release a bus.

Re: [PATCH 0/5] Add ChromeOS Embedded Controller support

2013-02-12 Thread Simon Glass
Hi Samuel, On Wed, Dec 12, 2012 at 1:33 PM, Simon Glass s...@chromium.org wrote: (get_maintainer.pl has produced an enormous list - I hope you are all interested.) The ChromeOS Embedded Controller (EC) is an Open Source EC implementation used on ARM and Intel Chromebooks. Current

Re: [PATCH 0/5] Add ChromeOS Embedded Controller support

2013-02-12 Thread Simon Glass
Hi Samuel, On Tue, Feb 12, 2013 at 4:37 PM, Simon Glass s...@chromium.org wrote: Hi Samuel, On Wed, Dec 12, 2012 at 1:33 PM, Simon Glass s...@chromium.org wrote: (get_maintainer.pl has produced an enormous list - I hope you are all interested.) The ChromeOS Embedded Controller (EC

[PATCH v2 2/6] mfd: Add ChromeOS EC implementation

2013-02-12 Thread Simon Glass
resume notification also, in case drivers wish to perform some action there. A simple message structure is used to pass messages to the protocol driver. Signed-off-by: Simon Glass s...@chromium.org Signed-off-by: Che-Liang Chiou clch...@chromium.org Signed-off-by: Jonathan Kliegman kli

[PATCH v2 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-12 Thread Simon Glass
information. Signed-off-by: Simon Glass s...@chromium.org Signed-off-by: Luigi Semenzato semenz...@chromium.org Signed-off-by: Vincent Palatin vpala...@chromium.org --- Changes in v2: - Remove use of __devinit/__devexit - Use function to read matrix-keypad parameters from DT - Remove key autorepeat

[PATCH v2 4/6] mfd: Add ChromeOS EC SPI driver

2013-02-12 Thread Simon Glass
This uses a SPI bus to talk to the ChromeOS EC. The protocol is defined by the EC and is fairly simple, with a length byte, checksum, command byte and version byte (to permit easy creation of new commands). Signed-off-by: Simon Glass s...@chromium.org --- Changes in v2: - Remove use of __devinit

[PATCH v2 0/6] Add ChromeOS Embedded Controller support

2013-02-12 Thread Simon Glass
/__devexit - Use function to read matrix-keypad parameters from DT - Remove key autorepeat parameters from DT binding and driver - Use unsigned int for rows/cols Simon Glass (6): mfd: Add ChromeOS EC messages header mfd: Add ChromeOS EC implementation mfd: Add ChromeOS EC I2C driver mfd

[PATCH v2 5/6] Input: matrix-keymap: Add function to read the new DT binding

2013-02-12 Thread Simon Glass
-GPIO drivers to use to decode the binding. Note: We could in fact create an entirely separate structure to hold these two fields, but it does not seem worth it, yet. If we have more parameters then we can add this, and then refactor each driver to hold such a structure. Signed-off-by: Simon Glass

[PATCH v2 1/6] mfd: Add ChromeOS EC messages header

2013-02-12 Thread Simon Glass
This file is included verbatim from the ChromeOS EC respository. Ideally we would prefer to avoid changing it, to make it easier to track this rapidly-changing file. Signed-off-by: Simon Glass s...@chromium.org Signed-off-by: Che-Liang Chiou clch...@chromium.org Signed-off-by: Vincent Palatin

[PATCH v2 3/6] mfd: Add ChromeOS EC I2C driver

2013-02-12 Thread Simon Glass
This uses an I2C bus to talk to the ChromeOS EC. The protocol is defined by the EC and is fairly simple, with a length byte, checksum, command byte and version byte (to permit easy creation of new commands). Signed-off-by: Simon Glass s...@chromium.org Signed-off-by: Che-Liang Chiou clch

Re: [PATCH v6 0/6] Add ChromeOS Embedded Controller support

2013-02-26 Thread Simon Glass
Hi Samuel, On Mon, Feb 25, 2013 at 2:08 PM, Simon Glass s...@chromium.org wrote: The ChromeOS Embedded Controller (EC) is an Open Source EC implementation used on ARM and Intel Chromebooks. Current implementations use a Cortex-M3 connected on a bus (such as I2C, SPI, LPC) to the AP. A separate

Re: [PATCH v6 0/6] Add ChromeOS Embedded Controller support

2013-02-27 Thread Simon Glass
Hi Samuel, On Wed, Feb 27, 2013 at 12:40 AM, Samuel Ortiz sa...@linux.intel.com wrote: Hi Simon, On Tue, Feb 26, 2013 at 09:13:06PM -0800, Simon Glass wrote: Hi Samuel, On Mon, Feb 25, 2013 at 2:08 PM, Simon Glass s...@chromium.org wrote: The ChromeOS Embedded Controller (EC) is an Open

Re: [PATCH v2 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-13 Thread Simon Glass
Hi Dmitry, On Wed, Feb 13, 2013 at 12:02 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi SImon, On Tue, Feb 12, 2013 at 06:42:26PM -0800, Simon Glass wrote: Use the key-matrix layer to interpret key scan information from the EC and inject input based on the FDT-supplied key map

[PATCH v3 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-13 Thread Simon Glass
-off-by: Simon Glass s...@chromium.org Signed-off-by: Luigi Semenzato semenz...@chromium.org Signed-off-by: Vincent Palatin vpala...@chromium.org --- Changes in v3: - Remove 'select MFD_CROS_EC' from Kconfig as it isn't necessary - Remove old_state by using input layer's idev-key - Move inner loop

[PATCH v3 5/6] Input: matrix-keymap: Add function to read the new DT binding

2013-02-13 Thread Simon Glass
-GPIO drivers to use to decode the binding. Note: We could in fact create an entirely separate structure to hold these two fields, but it does not seem worth it, yet. If we have more parameters then we can add this, and then refactor each driver to hold such a structure. Signed-off-by: Simon Glass

Re: [PATCH v2 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-15 Thread Simon Glass
Hi Dmitry, On Thu, Feb 14, 2013 at 9:31 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Wed, Feb 13, 2013 at 10:45:07PM -0800, Simon Glass wrote: +config KEYBOARD_CROS_EC + tristate ChromeOS EC keyboard + select INPUT_MATRIXKMAP + select MFD_CROS_EC

Re: [PATCH v2 2/6] mfd: Add ChromeOS EC implementation

2013-02-15 Thread Simon Glass
Hi Joe, On Tue, Feb 12, 2013 at 7:35 PM, Joe Perches j...@perches.com wrote: On Tue, 2013-02-12 at 18:42 -0800, Simon Glass wrote: This is the base EC implementation, which provides a high level interface to the EC for use by the rest of the kernel. The actual communcations is dealt

[PATCH v4 0/6] Add ChromeOS Embedded Controller support

2013-02-15 Thread Simon Glass
-keypad DT binding - Remove use of __devinit/__devexit - Use function to read matrix-keypad parameters from DT - Remove key autorepeat parameters from DT binding and driver - Use unsigned int for rows/cols Simon Glass (6): mfd: Add ChromeOS EC messages header mfd: Add ChromeOS EC implementation

[PATCH v4 4/6] mfd: Add ChromeOS EC SPI driver

2013-02-15 Thread Simon Glass
This uses a SPI bus to talk to the ChromeOS EC. The protocol is defined by the EC and is fairly simple, with a length byte, checksum, command byte and version byte (to permit easy creation of new commands). Signed-off-by: Simon Glass s...@chromium.org --- Changes in v4: None Changes in v3: None

[PATCH v4 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-15 Thread Simon Glass
-off-by: Simon Glass s...@chromium.org Signed-off-by: Luigi Semenzato semenz...@chromium.org Signed-off-by: Vincent Palatin vpala...@chromium.org --- Changes in v4: - Add 'depends on MFD_CROS_EC' to Kconfig - Remove use of wake_notifier - Remove manual code to locate device tree node - Add resume

[PATCH v4 2/6] mfd: Add ChromeOS EC implementation

2013-02-15 Thread Simon Glass
structure is used to pass messages to the protocol driver. Signed-off-by: Simon Glass s...@chromium.org Signed-off-by: Che-Liang Chiou clch...@chromium.org Signed-off-by: Jonathan Kliegman kli...@chromium.org Signed-off-by: Luigi Semenzato semenz...@chromium.org Signed-off-by: Olof Johansson ol

[PATCH v4 3/6] mfd: Add ChromeOS EC I2C driver

2013-02-15 Thread Simon Glass
This uses an I2C bus to talk to the ChromeOS EC. The protocol is defined by the EC and is fairly simple, with a length byte, checksum, command byte and version byte (to permit easy creation of new commands). Signed-off-by: Simon Glass s...@chromium.org Signed-off-by: Che-Liang Chiou clch

[PATCH v4 5/6] Input: matrix-keymap: Add function to read the new DT binding

2013-02-15 Thread Simon Glass
-GPIO drivers to use to decode the binding. Note: We could in fact create an entirely separate structure to hold these two fields, but it does not seem worth it, yet. If we have more parameters then we can add this, and then refactor each driver to hold such a structure. Signed-off-by: Simon Glass

[PATCH v4 1/6] mfd: Add ChromeOS EC messages header

2013-02-15 Thread Simon Glass
This file is included verbatim from the ChromeOS EC respository. Ideally we would prefer to avoid changing it, to make it easier to track this rapidly-changing file. Signed-off-by: Simon Glass s...@chromium.org Signed-off-by: Che-Liang Chiou clch...@chromium.org Signed-off-by: Vincent Palatin

Re: [PATCH v4 3/6] mfd: Add ChromeOS EC I2C driver

2013-02-16 Thread Simon Glass
Hi, On Sat, Feb 16, 2013 at 1:06 AM, Felipe Balbi ba...@ti.com wrote: On Fri, Feb 15, 2013 at 08:16:09PM -0800, Simon Glass wrote: This uses an I2C bus to talk to the ChromeOS EC. The protocol is defined by the EC and is fairly simple, with a length byte, checksum, command byte and version

Re: [v3 0/6] ARM: tegra: convert device tree files to use CLK defines

2013-02-17 Thread Simon Glass
Hi Hiroshi, On Fri, Feb 15, 2013 at 12:43 AM, Hiroshi Doyu hd...@nvidia.com wrote: Hi, With new dtc+cpp feature, we could get rid of magic numbers in dts* files. This patch replaces CLK IDs. We also plan to share those DT header files with kernel source later[1]. This series depends on:

Re: [PATCH v4 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-18 Thread Simon Glass
Hi Dmitry, On Sat, Feb 16, 2013 at 12:49 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Simon, On Fri, Feb 15, 2013 at 08:16:12PM -0800, Simon Glass wrote: + for (row = 0; row ckdev-rows; row++) { + if (cros_ec_keyb_row_has_ghosting(ckdev, buf, row

Re: [PATCH v4 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-19 Thread Simon Glass
Hi, On Tue, Feb 19, 2013 at 12:36 AM, li guang lig.f...@cn.fujitsu.com wrote: 在 2013-02-15五的 20:16 -0800,Simon Glass写道: Use the key-matrix layer to interpret key scan information from the EC and inject input based on the FDT-supplied key map. This driver registers itself with the ChromeOS EC

[PATCH v5 2/6] mfd: Add ChromeOS EC implementation

2013-02-20 Thread Simon Glass
structure is used to pass messages to the protocol driver. Signed-off-by: Simon Glass s...@chromium.org Signed-off-by: Che-Liang Chiou clch...@chromium.org Signed-off-by: Jonathan Kliegman kli...@chromium.org Signed-off-by: Luigi Semenzato semenz...@chromium.org Signed-off-by: Olof Johansson ol

[PATCH v5 4/6] mfd: Add ChromeOS EC SPI driver

2013-02-20 Thread Simon Glass
This uses a SPI bus to talk to the ChromeOS EC. The protocol is defined by the EC and is fairly simple, with a length byte, checksum, command byte and version byte (to permit easy creation of new commands). Signed-off-by: Simon Glass s...@chromium.org --- Changes in v5: - Switch cros_ec_spi

[PATCH v5 3/6] mfd: Add ChromeOS EC I2C driver

2013-02-20 Thread Simon Glass
This uses an I2C bus to talk to the ChromeOS EC. The protocol is defined by the EC and is fairly simple, with a length byte, checksum, command byte and version byte (to permit easy creation of new commands). Signed-off-by: Simon Glass s...@chromium.org Signed-off-by: Che-Liang Chiou clch

[PATCH v5 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-20 Thread Simon Glass
-off-by: Simon Glass s...@chromium.org Signed-off-by: Luigi Semenzato semenz...@chromium.org Signed-off-by: Vincent Palatin vpala...@chromium.org --- Changes in v5: - Fix {} style nit in cros_ec_keyb_has_ghosting - Correct key lookup logic which was broken in previous version - Switch cros_ec_keyb

[PATCH v5 5/6] Input: matrix-keymap: Add function to read the new DT binding

2013-02-20 Thread Simon Glass
-GPIO drivers to use to decode the binding. Note: We could in fact create an entirely separate structure to hold these two fields, but it does not seem worth it, yet. If we have more parameters then we can add this, and then refactor each driver to hold such a structure. Signed-off-by: Simon Glass

[PATCH v5 1/6] mfd: Add ChromeOS EC messages header

2013-02-20 Thread Simon Glass
This file is included verbatim from the ChromeOS EC respository. Ideally we would prefer to avoid changing it, to make it easier to track this rapidly-changing file. Signed-off-by: Simon Glass s...@chromium.org Signed-off-by: Che-Liang Chiou clch...@chromium.org Signed-off-by: Vincent Palatin

[PATCH v5 0/6] Add ChromeOS Embedded Controller support

2013-02-20 Thread Simon Glass
function to read matrix-keypad parameters from DT - Remove key autorepeat parameters from DT binding and driver - Use unsigned int for rows/cols Simon Glass (6): mfd: Add ChromeOS EC messages header mfd: Add ChromeOS EC implementation mfd: Add ChromeOS EC I2C driver mfd: Add ChromeOS EC SPI

Re: [PATCH v5 5/6] Input: matrix-keymap: Add function to read the new DT binding

2013-02-25 Thread Simon Glass
Hi Dmitry, On Wed, Feb 20, 2013 at 10:18 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Wed, Feb 20, 2013 at 09:24:38AM -0800, Simon Glass wrote: We now have a binding which adds two parameters to the matrix keypad DT node. This is separate from the GPIO-driven matrix keypad binding

[PATCH v6 0/6] Add ChromeOS Embedded Controller support

2013-02-25 Thread Simon Glass
- Remove key autorepeat parameters from DT binding and driver - Use unsigned int for rows/cols Simon Glass (6): mfd: Add ChromeOS EC messages header mfd: Add ChromeOS EC implementation mfd: Add ChromeOS EC I2C driver mfd: Add ChromeOS EC SPI driver Input: matrix-keymap: Add function to read

[PATCH v6 1/6] mfd: Add ChromeOS EC messages header

2013-02-25 Thread Simon Glass
This file is included verbatim from the ChromeOS EC respository. Ideally we would prefer to avoid changing it, to make it easier to track this rapidly-changing file. Signed-off-by: Simon Glass s...@chromium.org Signed-off-by: Che-Liang Chiou clch...@chromium.org Signed-off-by: Vincent Palatin

[PATCH v6 3/6] mfd: Add ChromeOS EC I2C driver

2013-02-25 Thread Simon Glass
This uses an I2C bus to talk to the ChromeOS EC. The protocol is defined by the EC and is fairly simple, with a length byte, checksum, command byte and version byte (to permit easy creation of new commands). Signed-off-by: Simon Glass s...@chromium.org Signed-off-by: Che-Liang Chiou clch

[PATCH v6 2/6] mfd: Add ChromeOS EC implementation

2013-02-25 Thread Simon Glass
structure is used to pass messages to the protocol driver. Signed-off-by: Simon Glass s...@chromium.org Signed-off-by: Che-Liang Chiou clch...@chromium.org Signed-off-by: Jonathan Kliegman kli...@chromium.org Signed-off-by: Luigi Semenzato semenz...@chromium.org Signed-off-by: Olof Johansson ol

[PATCH v6 4/6] mfd: Add ChromeOS EC SPI driver

2013-02-25 Thread Simon Glass
This uses a SPI bus to talk to the ChromeOS EC. The protocol is defined by the EC and is fairly simple, with a length byte, checksum, command byte and version byte (to permit easy creation of new commands). Signed-off-by: Simon Glass s...@chromium.org --- Changes in v6: None Changes in v5

[PATCH v6 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-25 Thread Simon Glass
-off-by: Simon Glass s...@chromium.org Signed-off-by: Luigi Semenzato semenz...@chromium.org Signed-off-by: Vincent Palatin vpala...@chromium.org --- Changes in v6: - Fix incorrect indentation in cros_ec_keyb_process() - Remove unnecessary assignment to NULL in probe function Changes in v5: - Fix

[PATCH v6 5/6] Input: matrix-keymap: Add function to read the new DT binding

2013-02-25 Thread Simon Glass
-GPIO drivers to use to decode the binding. Note: We could in fact create an entirely separate structure to hold these two fields, but it does not seem worth it, yet. If we have more parameters then we can add this, and then refactor each driver to hold such a structure. Signed-off-by: Simon Glass

[PATCH 0/7] Add support for Exynos5 ISP SPI ports

2012-09-18 Thread Simon Glass
work, but I think it is worth sending out as is. Prathyush K (1): PM / Domains: add generic function 'pm_genpd_of_add_device_by_name' Simon Glass (6): spi: s3c64xx: Fix enum dma_data_direction warning spi: s3c64xx: Add support for ISP SPI ports spi: s3c64xx: Use jiffies instead of loops

[PATCH 2/7] spi: s3c64xx: Fix enum dma_data_direction warning

2012-09-18 Thread Simon Glass
' and 'enum dma_transfer_direction' [-Wenum-compare] Signed-off-by: Simon Glass s...@chromium.org --- drivers/spi/spi-s3c64xx.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 646a765..3152659 100644 --- a/drivers/spi

[PATCH 7/7] spi: s3c64xx: Write to PACKET_CNT after reset

2012-09-18 Thread Simon Glass
that SPI operation with ChromeOS EC is reliable now. Signed-off-by: Simon Glass s...@chromium.org --- drivers/spi/spi-s3c64xx.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index c34ef8f..3716825 100644

[PATCH 3/7] spi: s3c64xx: Add support for ISP SPI ports

2012-09-18 Thread Simon Glass
The ISP has two SPI ports which can be used for general SPI activities. Add support for these for: - clocks and clock gating - SPI FIFO size for these ports - support for 'samsung,pd' node in SPI so we can mark these ports as dependent on the ISP power domain Signed-off-by: Simon Glass s

[PATCH 5/7] spi: s3c64xx: Allow use with SPI ports without dma

2012-09-18 Thread Simon Glass
The ISP SPI ports appear not to support dma. Allow these to work to some extent. The current driver will not permit transfers larger than the FIFO size, which is 256 bytes in the case of the ISP SPI ports, unless dma is enabled. Signed-off-by: Simon Glass s...@chromium.org --- drivers/spi/spi

[PATCH 6/7] spi: s3c64xx: Tidy up SPI chip select handling

2012-09-18 Thread Simon Glass
in one place (enable/disable_cs()) instead of using the macro separately in a different place. Also we need to make sure that the FIFOs are cleared even in the event of an empty transaction or error. (This adds a proposed new fdt binding for Samsung SPI) Signed-off-by: Simon Glass s...@chromium.org

[PATCH 1/7] PM / Domains: add generic function 'pm_genpd_of_add_device_by_name'

2012-09-18 Thread Simon Glass
K prathyus...@samsung.com Signed-off-by: Simon Glass s...@chromium.org Tested-by: Prathyush Kalashwaram prathy...@chromium.org --- include/linux/pm_domain.h | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/include/linux/pm_domain.h b/include/linux

[PATCH 4/7] spi: s3c64xx: Use jiffies instead of loops for timeout

2012-09-18 Thread Simon Glass
The current timeout uses loops, but does not actually use an empty loop. In fact it checks SPI registers which are pretty slow to read. As a result the timeout ends up being several seconds most of the time. Change this to use jiffies instead. Signed-off-by: Simon Glass s...@chromium.org

Re: [RFC][PATCH v3 1/3] runtime interpreted power sequences

2012-07-30 Thread Simon Glass
Hi, On Fri, Jul 27, 2012 at 1:05 PM, Alexandre Courbot acour...@nvidia.com wrote: Some device drivers (panel backlights especially) need to follow precise sequences for powering on and off, involving gpios, regulators, PWMs with a precise powering order and delays to respect between each

Re: [RFC][PATCH V2 3/3] tegra: add pwm backlight device tree nodes

2012-07-12 Thread Simon Glass
Hi Alex, On Mon, Jul 9, 2012 at 8:08 AM, Alexandre Courbot acour...@nvidia.com wrote: Signed-off-by: Alexandre Courbot acour...@nvidia.com --- arch/arm/boot/dts/tegra20-ventana.dts | 31 +++ arch/arm/boot/dts/tegra20.dtsi| 2 +- 2 files changed, 32

Re: [RFC][PATCH V2 3/3] tegra: add pwm backlight device tree nodes

2012-07-12 Thread Simon Glass
Hi Alex, On Thu, Jul 12, 2012 at 12:11 PM, Alex Courbot acour...@nvidia.com wrote: Hi Simon, On Thu 12 Jul 2012 06:37:33 PM JST, Simon Glass wrote: I would like to do something similar in U-Boot for Tegra, although perhaps not right away. For now I will go with something considerably

Device tree node to major/minor?

2012-11-20 Thread Simon Glass
Hi, I hope this is a stupid question with an easy answer, but I cannot find it. I have a device tree node for an mmc block device and I want to use that block device from another driver. I have a phandle which lets me get the node of the mmc device, but I am not sure how to convert that into a

Re: Device tree node to major/minor?

2012-11-20 Thread Simon Glass
Hi Grant, On Tue, Nov 20, 2012 at 2:32 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Tue, Nov 20, 2012 at 10:23 PM, Simon Glass s...@chromium.org wrote: Hi, I hope this is a stupid question with an easy answer, but I cannot find it. I have a device tree node for an mmc block device

Re: Device tree node to major/minor?

2012-11-21 Thread Simon Glass
Hi Grant, On Wed, Nov 21, 2012 at 7:47 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Tue, 20 Nov 2012 15:48:24 -0800, Simon Glass s...@chromium.org wrote: Hi Grant, On Tue, Nov 20, 2012 at 2:32 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Tue, Nov 20, 2012 at 10:23 PM

Re: [PATCH 5/5] Input: Add ChromeOS EC keyboard driver

2012-12-19 Thread Simon Glass
: On Wed, 12 Dec 2012 13:33:48 -0800, Simon Glass s...@chromium.org wrote: Use the key-matrix layer to interpret key scan information from the EC and inject input based on the FDT-supplied key map. This driver registers itself with the ChromeOS EC driver to perform

Re: [PATCH 1/2] i2c-core: Add gpio based bus arbitration implementation

2012-12-19 Thread Simon Glass
On Wed, Dec 19, 2012 at 9:14 AM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Dec 19, 2012 at 12:32:01PM +, Grant Likely wrote: I'm not convinced on the design of this protocol. It won't scale beyond 2 bus masters and it seems very specific to the design of a specific

[PATCH] RFC: input: Extend matrix-keypad device tree binding

2012-12-20 Thread Simon Glass
-off-by: Simon Glass s...@chromium.org --- .../devicetree/bindings/input/matrix-keymap.txt| 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/Documentation/devicetree/bindings/input/matrix-keymap.txt b/Documentation/devicetree/bindings/input/matrix-keymap.txt

Re: [PATCH] RFC: input: Extend matrix-keypad device tree binding

2012-12-20 Thread Simon Glass
Hi Dmitry, On Thu, Dec 20, 2012 at 1:13 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Simon, On Thu, Dec 20, 2012 at 12:23:58PM -0800, Simon Glass wrote: For the key repeat feature, we need to set this after the input device is registered. So we would need to add

[PATCH 0/5] Add ChromeOS Embedded Controller support

2012-12-12 Thread Simon Glass
-snow is provided at this stage, since we must wait for the above-mentioned patches to land to avoid errors from dtc. This can be added with a follow-on patch when that work is complete. Simon Glass (5): mfd: Add ChromeOS EC messages header mfd: Add ChromeOS EC implementation mfd: Add ChromeOS

[PATCH 1/5] mfd: Add ChromeOS EC messages header

2012-12-12 Thread Simon Glass
This file is included verbatim from the ChromeOS EC respository. Ideally we would prefer to avoid changing it, to make it easier to track this rapidly-changing file. Signed-off-by: Simon Glass s...@chromium.org Signed-off-by: Che-Liang Chiou clch...@chromium.org Signed-off-by: Vincent Palatin

[PATCH 2/5] mfd: Add ChromeOS EC implementation

2012-12-12 Thread Simon Glass
resume notification also, in case drivers wish to perform some action there. A simple message structure is used to pass messages to the protocol driver. Signed-off-by: Simon Glass s...@chromium.org Signed-off-by: Che-Liang Chiou clch...@chromium.org Signed-off-by: Jonathan Kliegman kli

[PATCH 5/5] Input: Add ChromeOS EC keyboard driver

2012-12-12 Thread Simon Glass
information. Signed-off-by: Simon Glass s...@chromium.org Signed-off-by: Luigi Semenzato semenz...@chromium.org Signed-off-by: Vincent Palatin vpala...@chromium.org --- .../devicetree/bindings/input/cros-ec-keyb.txt | 77 drivers/input/keyboard/Kconfig | 10 + drivers/input

[PATCH 4/5] mfd: Add ChromeOS EC SPI driver

2012-12-12 Thread Simon Glass
This uses a SPI bus to talk to the ChromeOS EC. The protocol is defined by the EC and is fairly simple, with a length byte, checksum, command byte and version byte (to permit easy creation of new commands). Signed-off-by: Simon Glass s...@chromium.org --- drivers/mfd/Kconfig | 10

[PATCH 3/5] mfd: Add ChromeOS EC I2C driver

2012-12-12 Thread Simon Glass
This uses an I2C bus to talk to the ChromeOS EC. The protocol is defined by the EC and is fairly simple, with a length byte, checksum, command byte and version byte (to permit easy creation of new commands). Signed-off-by: Simon Glass s...@chromium.org Signed-off-by: Che-Liang Chiou clch

Re: [PATCH 5/5] Input: Add ChromeOS EC keyboard driver

2013-01-10 Thread Simon Glass
Hi Grant, On Wed, Dec 19, 2012 at 12:42 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Wed, Dec 19, 2012 at 8:20 PM, Simon Glass s...@chromium.org wrote: On Wed, Dec 19, 2012 at 10:16 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Wed, Dec 19, 2012 at 12:57:22PM +, Grant

[PATCH v2] input: Extend matrix-keypad device tree binding

2013-01-10 Thread Simon Glass
be done by passing 0 for these parameters? Many of the parameters can already be set to NULL. Ick. Signed-off-by: Simon Glass s...@chromium.org --- Changes in v2: - Remove repeat rate parameters - Update TI OMAP, tca8418 and lpc32xx bindings to use this one .../devicetree/bindings/input/lpc32xx

Re: [PATCH V7] kbuild: create a rule to run the pre-processor on *.dts files

2013-01-12 Thread Simon Glass
. Signed-off-by: Stephen Warren swar...@nvidia.com Acked-by: Simon Glass s...@chromium.org --- Grant, back in mid-November, you said you'd make a decision on this in the next couple of days, but I think this got overlooked. v7: Build *.dtb from *.dts not src/*.dts. v6: No change. v5

Re: [PATCH] input: cros_ec_keyb_clear_keyboard() depends on CONFIG_PM_SLEEP

2013-05-08 Thread Simon Glass
protected by #ifdef CONFIG_PM_SLEEP to fix this. Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org Acked-by: Simon Glass s...@chromium.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] mfd: ChromeOS EC - Spelling s/ned/need/

2013-05-06 Thread Simon Glass
On Mon, May 6, 2013 at 1:46 AM, Geert Uytterhoeven ge...@linux-m68k.org wrote: Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org Acked-by: Simon Glass s...@chromium.org --- drivers/mfd/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list

Re: [PATCH v8 0/3] Runtime Interpreted Power Sequences

2013-04-26 Thread Simon Glass
Hi, On Thu, Nov 15, 2012 at 10:38 PM, Alexandre Courbot acour...@nvidia.com wrote: Hopefully the final series before the feature gets merged. Anton Vorontsov kindly accepted to take it into his tree, so this series is mostly a call for acks, tests and reviews notices before the merge window

Re: [RESEND] spi/tegra114: Correct support for cs_change

2013-09-23 Thread Simon Glass
[trying again] Hi, On Mon, Sep 23, 2013 at 3:14 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 09/23/2013 03:01 PM, Rhyland Klein wrote: On 9/23/2013 3:58 PM, Stephen Warren wrote: On 09/23/2013 01:48 PM, Rhyland Klein wrote: On 9/23/2013 2:51 PM, Stephen Warren wrote: On 09/18/2013

Re: [PATCH 02/10] mfd: cros_ec: IRQs for cros_ec should be optional

2014-06-17 Thread Simon Glass
...@chromium.org Reviewed-by: Simon Glass s...@chromium.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 03/10] mfd: cros_ec: Allow static din/dout buffers with cros_ec_register()

2014-06-17 Thread Simon Glass
devm allocation), but it's good to document it. [dianders: Resolved conflicts; documented that no code changes needed on mainline] Signed-off-by: Bill Richardson wfric...@chromium.org Signed-off-by: Doug Anderson diand...@chromium.org Reviewed-by: Simon Glass s...@chromium.org

Re: [PATCH 04/10] mfd: cros_ec: Tweak struct cros_ec_device for clarity

2014-06-17 Thread Simon Glass
Hi Doug, On 16 June 2014 14:39, Doug Anderson diand...@chromium.org wrote: From: Bill Richardson wfric...@chromium.org The members of struct cros_ec_device were improperly commented, and intermixed the private and public sections. This is just cleanup to make it more obvious what goes with

Re: [PATCH 07/10] mfd: cros_ec: cleanup: remove unused fields from struct cros_ec_device

2014-06-17 Thread Simon Glass
field. Except that it no longer prints I2C/SPI - i.e. the transport that is used. Is that not considered important? Anyway: Reviewed-by: Simon Glass s...@chromium.org Regards, Simon -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 08/10] mfd: cros_ec: cleanup: Remove EC wrapper functions

2014-06-17 Thread Simon Glass
Hi Doug, On 16 June 2014 14:39, Doug Anderson diand...@chromium.org wrote: From: Bill Richardson wfric...@chromium.org Remove the three wrapper functions that talk to the EC without passing all the desired arguments and just use the underlying communication function that passes everything in

Re: [PATCH 09/10] mfd: cros_ec: Check result code from EC messages

2014-06-17 Thread Simon Glass
Hi Doug, On 16 June 2014 14:39, Doug Anderson diand...@chromium.org wrote: From: Bill Richardson wfric...@chromium.org Just because the host was able to talk to the EC doesn't mean that the EC was happy with what it was told. Errors in communincation are not the same as error messages from

Re: [PATCH 10/10] mfd: cros_ec: ec_dev-cmd_xfer() returns number of bytes received from EC

2014-06-17 Thread Simon Glass
Hi, On 16 June 2014 14:40, Doug Anderson diand...@chromium.org wrote: From: Bill Richardson wfric...@chromium.org When communicating with the EC, the cmd_xfer() function should return the number of bytes it received from the EC, or negative on error. This is just for the I2C tunnel feature,

Re: [PATCH 07/10] mfd: cros_ec: cleanup: remove unused fields from struct cros_ec_device

2014-06-17 Thread Simon Glass
Hi Doug, On 17 June 2014 21:22, Doug Anderson diand...@chromium.org wrote: Simon, On Tue, Jun 17, 2014 at 8:39 PM, Simon Glass s...@chromium.org wrote: Hi Doug, On 16 June 2014 14:39, Doug Anderson diand...@chromium.org wrote: From: Bill Richardson wfric...@chromium.org struct

Re: [PATCH 08/10] mfd: cros_ec: cleanup: Remove EC wrapper functions

2014-06-17 Thread Simon Glass
Hi Doug, On 17 June 2014 21:27, Doug Anderson diand...@chromium.org wrote: Simon, On Tue, Jun 17, 2014 at 8:42 PM, Simon Glass s...@chromium.org wrote: diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c index 4083796..dc37b6b 100644 --- a/drivers

Re: [PATCH 10/10] mfd: cros_ec: ec_dev-cmd_xfer() returns number of bytes received from EC

2014-06-17 Thread Simon Glass
Hi Doug, On 17 June 2014 21:54, Doug Anderson diand...@chromium.org wrote: Simon, On Tue, Jun 17, 2014 at 8:46 PM, Simon Glass s...@chromium.org wrote: Hi, On 16 June 2014 14:40, Doug Anderson diand...@chromium.org wrote: From: Bill Richardson wfric...@chromium.org When communicating

Re: [PATCH 3/7] mfd: cros_ec: spi: Make the cros_ec_spi timeout more reliable

2014-04-18 Thread Simon Glass
a timeout after a single loop. Let's be paranoid and make sure we do one last transfer after the timeout expires. Signed-off-by: Doug Anderson diand...@chromium.org Reviewed-by: Simon Glass s...@chromium.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH 2/7] mfd: cros_ec: spi: Add mutex to cros_ec_spi

2014-04-18 Thread Simon Glass
Hi Doug, On 17 April 2014 11:59, Doug Anderson diand...@chromium.org wrote: The main transfer function for cros_ec_spi can be called by more than one client at a time. Make sure that those clients don't stomp on each other by locking the bus for the duration of the transfer function. Is

Re: [PATCH 5/7] mfd: cros_ec: Sync to the latest cros_ec_commands.h from EC sources

2014-04-18 Thread Simon Glass
/chromiumos/platform/ec [dianders: took today's ToT version from the Chromium OS EC; deleted references to cros_ec_dev and cros_ec_lpc since those aren't upstream yet] Signed-off-by: Bill Richardson wfric...@chromium.org Signed-off-by: Doug Anderson diand...@chromium.org Reviewed-by: Simon Glass s

Re: [PATCH 1/7] mfd: cros_ec: spi: calculate delay between transfers correctly

2014-04-18 Thread Simon Glass
miscalculation causes the delay period to be far too short. Most noticably this impacts commands with a long turnaround time such as EC firmware reads and writes. Signed-off-by: David Hendricks dhend...@chromium.org Signed-off-by: Doug Anderson diand...@chromium.org Reviewed-by: Simon Glass s

Re: [PATCH 4/7] mfd: cros_ec: spi: Increase cros_ec_spi deadline from 5ms to 100ms

2014-04-18 Thread Simon Glass
believe the EC protocol should be changed on future platforms to poll for completion of I2C, but in the meantime this patch prevents failure. Reviewed-by: Simon Glass s...@chromium.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 2/7] mfd: cros_ec: spi: Add mutex to cros_ec_spi

2014-04-18 Thread Simon Glass
Hi Doug, On 18 April 2014 15:15, Doug Anderson diand...@chromium.org wrote: Simon, On Fri, Apr 18, 2014 at 10:28 AM, Simon Glass s...@chromium.org wrote: Hi Doug, On 17 April 2014 11:59, Doug Anderson diand...@chromium.org wrote: The main transfer function for cros_ec_spi can

Re: [PATCH v2 5/5] regulator: tps65090: Make FETs more reliable by adding retries

2014-04-16 Thread Simon Glass
Anderson diand...@chromium.org Signed-off-by: Simon Glass s...@chromium.org Signed-off-by: Michael Spang sp...@chromium.org Signed-off-by: Sean Paul seanp...@chromium.org --- Changes in v2: - Separated the overcurrent and retries changes into two patches. - No longer open code fet_is_enabled

Re: [PATCH v2 5/5] regulator: tps65090: Make FETs more reliable by adding retries

2014-04-16 Thread Simon Glass
Hi Doug, On 16 April 2014 15:25, Doug Anderson diand...@chromium.org wrote: Simon, On Wed, Apr 16, 2014 at 1:50 PM, Simon Glass s...@chromium.org wrote: +#define MAX_CTRL_READ_TRIES5 +#define MAX_FET_ENABLE_TRIES 1000 Gosh that is a lot of tries - should we maybe give up sooner

Re: [PATCH] i2c: cros_ec: Remove EC_I2C_FLAG_10BIT

2014-06-24 Thread Simon Glass
...@chromium.org Funny. We certainly don't use it. Reviewed-by: Simon Glass s...@chromium.org Regards, Simon -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

  1   2   3   >