[PATCH v1 5/6] eeprom: qfprom: Add Qualcomm QFPROM support.

2015-03-05 Thread Srinivas Kandagatla
the driver. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- drivers/eeprom/Kconfig | 7 + drivers/eeprom/Makefile | 1 + drivers/eeprom/qfprom.c | 74 + 3 files changed, 82 insertions(+) create mode 100644 drivers

[PATCH v1 6/6] eeprom: Add to MAINTAINERS for eeprom framework

2015-03-05 Thread Srinivas Kandagatla
This patch adds MAINTAINERS to eeprom framework. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index d66a97d..ee7ba92 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3657,6

Re: [PATCH v1 5/6] eeprom: qfprom: Add Qualcomm QFPROM support.

2015-03-05 Thread Srinivas Kandagatla
Thankyou for the comments, On 05/03/15 10:02, Paul Bolle wrote: On Thu, 2015-03-05 at 09:46 +, Srinivas Kandagatla wrote: diff --git a/drivers/eeprom/Kconfig b/drivers/eeprom/Kconfig index bff8ecb..65325c7 100644 --- a/drivers/eeprom/Kconfig +++ b/drivers/eeprom/Kconfig @@ -28,4 +28,11

Re: [PATCH 06/12] ARM: DT: apq8064: add pci support in CM QS600

2015-02-23 Thread Srinivas Kandagatla
Hi Kumar, Sorry, I should have dropped this patch.. PCIE is still not in the mainline.. :-) Will fix it in next version. --srini On 23/02/15 11:31, Igor Grinberg wrote: Hi Srini, On 02/23/15 09:55, Srinivas Kandagatla wrote: From: Nicolas Dechesne nicolas.deche...@linaro.org This patch

Re: [RFC PATCH 1/3] eeprom: Add a simple EEPROM framework

2015-02-23 Thread Srinivas Kandagatla
Thankyou for the comments. On 23/02/15 15:04, Mark Brown wrote: On Thu, Feb 19, 2015 at 05:08:28PM +, Srinivas Kandagatla wrote: .../devicetree/bindings/eeprom/eeprom.txt | 48 drivers/Kconfig| 2 + drivers/Makefile

[PATCH 01/12] ARM: dts: apq8064: add RPM regulators support

2015-02-22 Thread Srinivas Kandagatla
This patch adds rpm node to apq8064 dt as rpm would be used by other devices for regulator support. Also adds all the regulators in the rpm. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- arch/arm/boot/dts/qcom-apq8064.dtsi | 241 1

[PATCH 02/12] ARM: dts: apq8064: Add usb host support.

2015-02-22 Thread Srinivas Kandagatla
This patch adds device tree nodes to support two usb hosts on APQ8064 SOC. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 40 + arch/arm/boot/dts/qcom-apq8064.dtsi| 47

[PATCH 03/12] ARM: dts: apq8064: Add USB OTG support

2015-02-22 Thread Srinivas Kandagatla
This patch adds USB OTG support on USB1 of APQ8064 SOC. Tested on IFC6410 with ethernet gadget. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 22 arch/arm/boot/dts/qcom-apq8064.dtsi| 32

[PATCH 00/12] ARM: dts: apq8064 dt patches.

2015-02-22 Thread Srinivas Kandagatla
-600 Pramod Gurav (1): ARM: qcom: Add DT alias for serial port Rob Clark (1): ARM: dts: APQ8064: Add MDP support Srinivas Kandagatla (7): ARM: dts: apq8064: add RPM regulators support ARM: dts: apq8064: Add usb host support. ARM: dts: apq8064: Add USB OTG support ARM: dts: apq8064: Add

[PATCH 05/12] ARM: dts: APQ8064: Add MDP support

2015-02-22 Thread Srinivas Kandagatla
From: Rob Clark robdcl...@gmail.com This patch adds MDP node to APQ8064 dt. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- arch/arm/boot/dts/qcom-apq8064.dtsi | 112 1 file changed, 112 insertions(+) diff --git a/arch/arm/boot/dts

[PATCH 10/12] ARM: dts: apq8064: Remove incorrect gsbi2 node.

2015-02-22 Thread Srinivas Kandagatla
according to 3.4 kernel sources. Removing this node as this node would never get tested. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- arch/arm/boot/dts/qcom-apq8064.dtsi | 20 1 file changed, 20 deletions(-) diff --git a/arch/arm/boot/dts/qcom

[PATCH 11/12] ARM: dts: Move i2c1 pinctrl to apq8064.dtsi

2015-02-22 Thread Srinivas Kandagatla
I2C1 pinctrl is not really specific to a board, moving to SOC dtsi would avoid redefining this in every board. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 7 --- arch/arm/boot/dts/qcom-apq8064.dtsi| 7 +++ 2

[PATCH 12/12] ARM: dts: apq8064 add i2c3 node for panel.

2015-02-22 Thread Srinivas Kandagatla
This patch adds i2c3 node which is used for panel control on IFC6410. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 10 ++ arch/arm/boot/dts/qcom-apq8064.dtsi| 25 + 2 files changed, 35

[PATCH 04/12] ARM: dts: apq8064: Add SATA controller support.

2015-02-22 Thread Srinivas Kandagatla
This patch adds AHCI based SATA controller support to APQ8064. Tested on IFC6410 board. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 15 + arch/arm/boot/dts/qcom-apq8064.dtsi| 35

[PATCH 07/12] ARM: DT: apq8064: Add usb host support to CM QS-600

2015-02-22 Thread Srinivas Kandagatla
From: Nicolas Dechesne nicolas.deche...@linaro.org This patch adds device tree nodes to support two usb hosts on Compulab QS600 board. Signed-off-by: Nicolas Dechesne nicolas.deche...@linaro.org --- arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts | 16 1 file changed, 16

[PATCH 06/12] ARM: DT: apq8064: add pci support in CM QS600

2015-02-22 Thread Srinivas Kandagatla
From: Nicolas Dechesne nicolas.deche...@linaro.org This patch adds PCIE support to APQ8064, tested with Ethernet on Compulab QS600 board. Signed-off-by: Nicolas Dechesne nicolas.deche...@linaro.org --- arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts | 19 +++ 1 file changed, 19

[PATCH 08/12] ARM: DT: apq8064: Add USB OTG support for CM QS-600

2015-02-22 Thread Srinivas Kandagatla
From: Nicolas Dechesne nicolas.deche...@linaro.org This patch adds USB OTG support on USB1 for Compulab QS-600 Board. Signed-off-by: Nicolas Dechesne nicolas.deche...@linaro.org --- arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts | 16 +++- 1 file changed, 15 insertions(+), 1

[PATCH 09/12] ARM: qcom: Add DT alias for serial port

2015-02-22 Thread Srinivas Kandagatla
From: Pramod Gurav pramod.gu...@smartplayin.com Define an alias for serial port present on ifc6410 which is used as console. Signed-off-by: Pramod Gurav pramod.gu...@smartplayin.com --- arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 4 arch/arm/boot/dts/qcom-apq8064.dtsi| 2 +- 2

Re: [RFC PATCH 1/3] eeprom: Add a simple EEPROM framework

2015-02-23 Thread Srinivas Kandagatla
Thanks Stephen for the comments. On 23/02/15 23:11, Stephen Boyd wrote: On 02/22/15 16:57, Rob Herring wrote: On Sun, Feb 22, 2015 at 8:32 AM, Maxime Ripard maxime.rip...@free-electrons.com wrote: On Fri, Feb 20, 2015 at 04:01:55PM -0600, Rob Herring wrote: [...] += Data consumers = +

Re: [PATCH 1/2] regmap: Add range check in _regmap_raw_read()

2015-02-24 Thread Srinivas Kandagatla
On 24/02/15 08:55, Mark Brown wrote: On Thu, Feb 19, 2015 at 01:02:03PM +, Srinivas Kandagatla wrote: The culprit was in my test code, which I eventually fixed. However I would have expected regmap to do some out of bound check before it tries to access the register space. If I try

Re: [PATCH 06/12] ARM: DT: apq8064: add pci support in CM QS600

2015-02-24 Thread Srinivas Kandagatla
On 24/02/15 10:23, Stanimir Varbanov wrote: On 02/23/2015 01:43 PM, Srinivas Kandagatla wrote: Hi Kumar, Sorry, I should have dropped this patch.. PCIE is still not in the mainline.. :-) Srini, Does it possible to reuse the driver which I'm trying to upstream at [1] Yes, it should

Re: [RFC PATCH 1/3] eeprom: Add a simple EEPROM framework

2015-02-26 Thread Srinivas Kandagatla
On 26/02/15 13:21, Maxime Ripard wrote: On Thu, Feb 26, 2015 at 09:16:27AM +, Srinivas Kandagatla wrote: I think we are making simple eeprom framework too smart which will break in future. IMHO, Anything on top of eeprom interface that interprets the data should not go into the eeprom

Re: [PATCH 01/12] ARM: dts: apq8064: add RPM regulators support

2015-02-26 Thread Srinivas Kandagatla
On 26/02/15 19:31, Stephen Boyd wrote: On 02/22/15 23:54, Srinivas Kandagatla wrote: + pm8921_s5: pm8921-s5 { + compatible = qcom,rpm-pm8921-ftsmps; + reg = QCOM_RPM_PM8921_SMPS5

Re: [PATCH 01/12] ARM: dts: apq8064: add RPM regulators support

2015-02-26 Thread Srinivas Kandagatla
On 26/02/15 19:00, Bjorn Andersson wrote: On Sun, Feb 22, 2015 at 11:54 PM, Srinivas Kandagatla srinivas.kandaga...@linaro.org wrote: This patch adds rpm node to apq8064 dt as rpm would be used by other devices for regulator support. Also adds all the regulators in the rpm. This looks good

Re: [PATCH 01/12] ARM: dts: apq8064: add RPM regulators support

2015-02-26 Thread Srinivas Kandagatla
On 26/02/15 18:25, Kumar Gala wrote: On Feb 23, 2015, at 1:54 AM, Srinivas Kandagatla srinivas.kandaga...@linaro.org wrote: This patch adds rpm node to apq8064 dt as rpm would be used by other devices for regulator support. Also adds all the regulators in the rpm. Signed-off-by: Srinivas

Re: [PATCH 00/12] ARM: dts: apq8064 dt patches.

2015-02-26 Thread Srinivas Kandagatla
On 26/02/15 18:29, Kumar Gala wrote: On Feb 23, 2015, at 1:53 AM, Srinivas Kandagatla srinivas.kandaga...@linaro.org wrote: Hi Kumar, Now that the rpm header file dependency is resolved, Could you queue these dt patches for rc2. Thanks, srini Nicolas Dechesne (3): ARM: DT: apq8064

Re: [RFC PATCH 1/3] eeprom: Add a simple EEPROM framework

2015-02-21 Thread Srinivas Kandagatla
On 20/02/15 22:01, Rob Herring wrote: On Fri, Feb 20, 2015 at 1:25 PM, Srinivas Kandagatla srinivas.kandaga...@linaro.org wrote: On 20/02/15 17:21, Rob Herring wrote: On Thu, Feb 19, 2015 at 11:08 AM, Srinivas Kandagatla srinivas.kandaga...@linaro.org wrote: From: Maxime Ripard

Re: [RFC PATCH 1/3] eeprom: Add a simple EEPROM framework

2015-02-20 Thread Srinivas Kandagatla
On 20/02/15 17:46, Russell King - ARM Linux wrote: On Thu, Feb 19, 2015 at 05:08:28PM +, Srinivas Kandagatla wrote: +static struct class eeprom_class = { + .name = eeprom, + .dev_groups = eeprom_dev_groups, +}; + +int eeprom_register(struct eeprom_device *eeprom

Re: [RFC PATCH 1/3] eeprom: Add a simple EEPROM framework

2015-02-20 Thread Srinivas Kandagatla
On 20/02/15 17:21, Rob Herring wrote: On Thu, Feb 19, 2015 at 11:08 AM, Srinivas Kandagatla srinivas.kandaga...@linaro.org wrote: From: Maxime Ripard maxime.rip...@free-electrons.com Up until now, EEPROM drivers were stored in drivers/misc, where they all had to duplicate pretty much

Re: [RFC PATCH 1/3] eeprom: Add a simple EEPROM framework

2015-02-26 Thread Srinivas Kandagatla
On 25/02/15 01:30, Stephen Boyd wrote: On 02/24, Maxime Ripard wrote: On Mon, Feb 23, 2015 at 03:11:40PM -0800, Stephen Boyd wrote: I would do something more simple that is just a list of keys and their location like this: device-serial-number = start size; key1 = start size; key2 = start

Re: [Patch V6 08/10] ASoC: qcom: Add ability to build QCOM drivers

2015-02-25 Thread Srinivas Kandagatla
On 25/02/15 06:39, Kenneth Westfield wrote: From: Kenneth Westfield kwest...@codeaurora.org Define the LPASS platform driver, the LPASS CPU DAI driver and the Storm machine driver configurations, and how to build them. Signed-off-by: Kenneth Westfield kwest...@codeaurora.org Acked-by:

Re: [PATCH v2 1/7] eeprom: Add a simple EEPROM framework for eeprom providers

2015-03-24 Thread Srinivas Kandagatla
On 24/03/15 19:02, Mark Brown wrote: On Tue, Mar 24, 2015 at 06:34:32PM +, Srinivas Kandagatla wrote: On 24/03/15 17:23, Mark Brown wrote: regmap_get_size(regmap) This is already there. Sorry, I can't see any such api atleast in v4.0-rc5 and linux-next? Are you referring to another

[PATCH 0/2] clk: qcom: gcc: Add support to child devices.

2015-01-30 Thread Srinivas Kandagatla
This patchset adds support to child devices whose memory registers fall insider gcc memory map. For example on APQ8064 whose thermal sensor registers are inside gcc memory range. Thanks, srini Srinivas Kandagatla (2): clk: qcom: gcc-msm8960: add child devices support. clk: qcom: gcc

[PATCH v2 2/2] clk: qcom: gcc bindings: Update to add child node support.

2015-01-30 Thread Srinivas Kandagatla
This patch adds note in the bindings about the optional child nodes which are currently possible with SOCs like MSM8960, APQ8064. These child device nodes are typically for drivers like thermal sensor which fall under the memory-map of gcc. Signed-off-by: Srinivas Kandagatla srinivas.kandaga

[PATCH 2/2] clk: qcom: gcc bindings: Update to add child node support.

2015-01-30 Thread Srinivas Kandagatla
This patch adds note in the bindings about the optional child nodes which are currently possible with SOCs like MSM8960, APQ8064. These child device nodes are typically for drivers like thermal sensor which fall under the memory-map of gcc. Signed-off-by: Srinivas Kandagatla srinivas.kandaga

[PATCH 1/2] clk: qcom: gcc-msm8960: add child devices support.

2015-01-30 Thread Srinivas Kandagatla
This patch adds support to add child devices to gcc as some of the registers mapped by gcc are used by drivers like thermal sensors. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- drivers/clk/qcom/gcc-msm8960.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion

[PATCH v2 1/2] clk: qcom: gcc-msm8960: add child devices support.

2015-01-30 Thread Srinivas Kandagatla
This patch adds support to add child devices to gcc as some of the registers mapped by gcc are used by drivers like thermal sensors. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- drivers/clk/qcom/gcc-msm8960.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion

[PATCH v2 0/2] clk: qcom: gcc: Add support to child devices.

2015-01-30 Thread Srinivas Kandagatla
This patchset adds support to child devices whose memory registers fall insider gcc memory map. For example on APQ8064 whose thermal sensor registers are inside gcc memory range. Changes since v1: - Check return value of qcom_cc_probe spotted by Pramod. Thanks, srini Srinivas

Re: [PATCH] regulator: qcom-rpm: Make it possible to specify supply

2015-01-30 Thread Srinivas Kandagatla
Hi Bjorn, Thanks for sending this patch.. I almost forgot about this. Shouldn’t we update the DT Bindings with this info? Other than that: Acked-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --srini On 30/01/15 00:22, Bjorn Andersson wrote: Make it possible to specify the supply

Re: [PATCH v2 1/7] eeprom: Add a simple EEPROM framework for eeprom providers

2015-03-23 Thread Srinivas Kandagatla
On 23/03/15 21:09, Mark Brown wrote: On Fri, Mar 13, 2015 at 09:50:14AM +, Srinivas Kandagatla wrote: A couple of *very* minor points below, otherwise this looks OK to me. Thankyou for the review. +struct eeprom_device *eeprom_register(struct eeprom_config *config) +{ + struct

[RFC PATCH 03/14] ASoC: qcom: move ipq806x specific bits out of lpass driver.

2015-04-30 Thread Srinivas Kandagatla
. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound/soc/qcom/Kconfig | 9 +- sound/soc/qcom/Makefile | 2 + sound/soc/qcom/lpass-cpu.c | 157 sound/soc/qcom/lpass-ipq806x.c | 82

[RFC PATCH 04/14] ASoC: qcom: remove hardcoded i2s port number

2015-04-30 Thread Srinivas Kandagatla
This patch attempts to remove the hardcoded i2s port number in lpass driver. Now the the port number comes from the dai id field. This will allow other SOCs to use different port numbers on the lpass driver. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound/soc/qcom

[RFC PATCH 02/14] ASoC: qcom: remove unnecessary header files

2015-04-30 Thread Srinivas Kandagatla
This patch removes unnecessary header files in lpass cpu and platform code. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound/soc/qcom/lpass-cpu.c | 6 +- sound/soc/qcom/lpass-platform.c | 6 -- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git

[RFC PATCH 10/14] ASoC: qcom: add bit map to track static dma channel allocations

2015-04-30 Thread Srinivas Kandagatla
This patch adds dma channel bit mask to lpass data to keep track of dma channel allocations. This flag would be used in apq8016 lpass driver. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound/soc/qcom/lpass.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound

[RFC PATCH 07/14] ASoC: qcom: add no osr clk flag to lpass variant

2015-04-30 Thread Srinivas Kandagatla
Some LPASS integrations like on APQ8016 do not have OSR clk, so adding no osr clk bit would allow such integrations to use lpass driver. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound/soc/qcom/lpass-cpu.c | 49 +- sound/soc

[RFC PATCH 12/14] ASoC: qcom: add apq8016 sound card support

2015-04-30 Thread Srinivas Kandagatla
This patch adds apq8016 machine driver support. This patch was tested on two apq8016-sbc and msm8916-mtp board for both hdmi and analog audio features. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound/soc/qcom/Kconfig | 9 ++ sound/soc/qcom/Makefile | 1 + sound

[RFC PATCH 11/14] ASoC: qcom: Add apq8016 lpass driver support

2015-04-30 Thread Srinivas Kandagatla
This patch adds apq8016 lpass driver support. APQ8016 has 4 MI2S which can be routed to one internal codec and 2 external codec interfaces. Primary, Secondary, Quaternary I2S can do Rx(playback) and Tertiary and Quaternary can do Tx(capture). Signed-off-by: Srinivas Kandagatla srinivas.kandaga

[RFC PATCH 13/14] ASoC: qcom: Document apq8016 bindings.

2015-04-30 Thread Srinivas Kandagatla
This patch updates lpass bindings with apq8016 specific bindings. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/Documentation

[RFC PATCH 14/14] ASoC: qcom: document apq8016 machine driver bindings

2015-04-30 Thread Srinivas Kandagatla
This patch adds bindings for apq8016 machine driver. On APQ8016 4 MI2S can be configured to different sinks like internal codec/external codec, this connection is controlled via 2 iomux registers. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- .../bindings/sound/qcom

[RFC PATCH 08/14] ASoC: qcom: add dma channel control offset to variant data

2015-04-30 Thread Srinivas Kandagatla
This patch adds ability to pass dma channel control bits start offset, which differ in differnet qcom SOCs. On apq8016 dma channel control bits start after an offset of 1. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound/soc/qcom/lpass-platform.c | 2 +- sound/soc/qcom

[RFC PATCH 00/14] ASoC: qcom: add support to apq8016 audio

2015-04-30 Thread Srinivas Kandagatla
documentation. I would like to get your opinon on the over all approch. Kenneth/Patrick, Could you please try these patches on storm board? Thanks, srini Srinivas Kandagatla (14): ASoC: qcom: Remove redundant error check. ASoC: qcom: remove unnecessary header files ASoC: qcom: move

[RFC PATCH 01/14] ASoC: qcom: Remove redundant error check.

2015-04-30 Thread Srinivas Kandagatla
This patch remove redundant check after request_resource as ioremap would do the check anyway. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound/soc/qcom/lpass-cpu.c | 4 1 file changed, 4 deletions(-) diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass

[RFC PATCH 05/14] ASoC: qcom: remove hardcoded dma channel

2015-04-30 Thread Srinivas Kandagatla
This patch removes hardcoded dma channel value in lpass driver, Now the dma channel allocation happens in the SOC specific layer. This will allow different LPASS integrations to use the lpass driver in more generic way. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound

[RFC PATCH 09/14] ASoC: qcom: Add ability to handle interrupts per dma channel

2015-04-30 Thread Srinivas Kandagatla
This patch adds ablity to lpass driver to handle interrupt per dma channel. Without this patch its not possible to use multipl ports on the lpass. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound/soc/qcom/lpass-platform.c | 89

[RFC PATCH 06/14] ASoC: qcom: support bitclk and osrclk per i2s port

2015-04-30 Thread Srinivas Kandagatla
This patch adds support to allow bitclk and osrclk per i2s dai port. on APQ8016 there are 4 i2s ports each one has its own bit clks. Without this patch its not possible to support multiple i2s ports in the lpass driver. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound

Re: [PATCH v4 04/10] eeprom: Add a simple EEPROM framework for eeprom consumers

2015-05-05 Thread Srinivas Kandagatla
Hi Stephen, Sorry I took so long to reply. On 09/04/15 15:45, Stephen Boyd wrote: On 04/07, Srinivas Kandagatla wrote: On 07/04/15 19:45, Stephen Boyd wrote: On 03/30, Srinivas Kandagatla wrote: Do you have an overview of how to use these APIs? Maybe some Documentation/ is in order? I'm

Re: [RFC PATCH 00/14] ASoC: qcom: add support to apq8016 audio

2015-05-06 Thread Srinivas Kandagatla
Hi Kenneth, On 06/05/15 06:47, Kenneth Westfield wrote: I will test the patches and let you know by Wednesday. Also, I posted some comments, but Patrick should be posting his comments separately later next week. Srinivas, After applying the patches, audio playback is no longer functional on

Re: [RFC PATCH 03/14] ASoC: qcom: move ipq806x specific bits out of lpass driver.

2015-05-05 Thread Srinivas Kandagatla
On 03/05/15 00:57, Kenneth Westfield wrote: On Thu, Apr 30, 2015 at 06:16:53PM +0100, Srinivas Kandagatla wrote: This patch tries to make the lpass driver more generic by moving the ipq806x specific bits out of the cpu and platform driver, also allows the SOC specific drivers to add

Re: [RFC PATCH 08/14] ASoC: qcom: add dma channel control offset to variant data

2015-05-05 Thread Srinivas Kandagatla
On 03/05/15 00:59, Kenneth Westfield wrote: On Thu, Apr 30, 2015 at 06:17:32PM +0100, Srinivas Kandagatla wrote: This patch adds ability to pass dma channel control bits start offset, which differ in differnet qcom SOCs. On apq8016 dma channel control bits start after an offset of 1. Alot

Re: [RFC PATCH 07/14] ASoC: qcom: add no osr clk flag to lpass variant

2015-05-05 Thread Srinivas Kandagatla
On 04/05/15 13:26, Mark Brown wrote: On Thu, Apr 30, 2015 at 06:17:24PM +0100, Srinivas Kandagatla wrote: + if (!drvdata-variant-no_osr_clk) { + ret = clk_prepare_enable(drvdata-mi2s_osr_clk[dai-id]); Can we do this by checking to see if the clock is set to IS_ERR

Re: [RFC PATCH 14/14] ASoC: qcom: document apq8016 machine driver bindings

2015-05-05 Thread Srinivas Kandagatla
On 03/05/15 01:03, Kenneth Westfield wrote: On Thu, Apr 30, 2015 at 06:18:26PM +0100, Srinivas Kandagatla wrote: This patch adds bindings for apq8016 machine driver. On APQ8016 4 MI2S can be configured to different sinks like internal codec/external codec, this connection is controlled via 2

Re: [RFC PATCH 03/14] ASoC: qcom: move ipq806x specific bits out of lpass driver.

2015-05-05 Thread Srinivas Kandagatla
On 05/05/15 06:19, Kenneth Westfield wrote: +enum lpaif_i2s_ports { + LPAIF_I2S_PORT_MIN = 0, + + LPAIF_I2S_PORT_CODEC_SPK= 0, + LPAIF_I2S_PORT_CODEC_MIC= 1, + LPAIF_I2S_PORT_SEC_SPK = 2, + LPAIF_I2S_PORT_SEC_MIC =

Re: [RFC PATCH 07/14] ASoC: qcom: add no osr clk flag to lpass variant

2015-05-05 Thread Srinivas Kandagatla
On 03/05/15 00:58, Kenneth Westfield wrote: On Thu, Apr 30, 2015 at 06:17:24PM +0100, Srinivas Kandagatla wrote: Some LPASS integrations like on APQ8016 do not have OSR clk, so adding no osr clk bit would allow such integrations to use lpass driver. Going forward, as the code is generalized

Re: [RFC PATCH 12/14] ASoC: qcom: add apq8016 sound card support

2015-05-05 Thread Srinivas Kandagatla
On 03/05/15 01:01, Kenneth Westfield wrote: On Thu, Apr 30, 2015 at 06:18:07PM +0100, Srinivas Kandagatla wrote: This patch adds apq8016 machine driver support. This patch was tested on two apq8016-sbc and msm8916-mtp board for both hdmi and analog audio features. apq8016 refers to the SOC

Re: [RFC PATCH 09/14] ASoC: qcom: Add ability to handle interrupts per dma channel

2015-05-05 Thread Srinivas Kandagatla
On 03/05/15 01:00, Kenneth Westfield wrote: On Thu, Apr 30, 2015 at 06:17:42PM +0100, Srinivas Kandagatla wrote: This patch adds ablity to lpass driver to handle interrupt per dma channel. Without this patch its not possible to use multipl ports on the lpass. diff --git a/sound/soc/qcom

[PATCH v1 09/13] ASoC: qcom: add bit map to track static dma channel allocations

2015-05-13 Thread Srinivas Kandagatla
This patch adds dma channel bit mask to lpass data to keep track of dma channel allocations. This flag would be used in apq8016 lpass driver. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound/soc/qcom/lpass.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound

[PATCH v1 10/13] ASoC: qcom: Add apq8016 lpass driver support

2015-05-13 Thread Srinivas Kandagatla
This patch adds apq8016 lpass driver support. APQ8016 has 4 MI2S which can be routed to one internal codec and 2 external codec interfaces. Primary, Secondary, Quaternary I2S can do Rx(playback) and Tertiary and Quaternary can do Tx(capture). Signed-off-by: Srinivas Kandagatla srinivas.kandaga

[PATCH v1 11/13] ASoC: qcom: add apq8016 sound card support

2015-05-13 Thread Srinivas Kandagatla
This patch adds apq8016 machine driver support. This patch was tested on two apq8016-sbc and msm8916-mtp board for both hdmi and analog audio features. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound/soc/qcom/Kconfig | 9 ++ sound/soc/qcom/Makefile | 2

[PATCH v1 13/13] ASoC: qcom: document apq8016 sbc machine driver bindings

2015-05-13 Thread Srinivas Kandagatla
This patch adds bindings for apq8016 sbc machine driver. On APQ8016 4 MI2S can be configured to different sinks like internal codec/external codec, this connection is controlled via 2 iomux registers. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- .../devicetree/bindings

[PATCH v1 12/13] ASoC: qcom: Document apq8016 bindings.

2015-05-13 Thread Srinivas Kandagatla
This patch updates lpass bindings with apq8016 specific bindings. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/Documentation

[PATCH v1 08/13] ASoC: qcom: Add ability to handle interrupts per dma channel

2015-05-13 Thread Srinivas Kandagatla
This patch adds ablity to lpass driver to handle interrupt per dma channel. Without this patch its not possible to use multipl ports on the lpass. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound/soc/qcom/lpass-platform.c | 94

[PATCH v1 06/13] ASoC: qcom: make osr clock optional

2015-05-13 Thread Srinivas Kandagatla
Some LPASS integrations like on APQ8016 do not have OSR clk, so making osr clk optional would allow such integrations to use lpass driver. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound/soc/qcom/lpass-cpu.c | 33 ++--- 1 file changed, 22

[PATCH v1 07/13] ASoC: qcom: add dma channel control offset to variant data

2015-05-13 Thread Srinivas Kandagatla
This patch adds ability to pass dma channel control bits start offset, which differ in differnet qcom SOCs. On apq8016 dma channel control bits start after an offset of 1. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound/soc/qcom/lpass-platform.c | 2 +- sound/soc/qcom

[PATCH v1 05/13] ASoC: qcom: support bitclk and osrclk per i2s port

2015-05-13 Thread Srinivas Kandagatla
This patch adds support to allow bitclk and osrclk per i2s dai port. on APQ8016 there are 4 i2s ports each one has its own bit clks. Without this patch its not possible to support multiple i2s ports in the lpass driver. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound

[PATCH v1 04/13] ASoC: qcom: remove hardcoded dma channel

2015-05-13 Thread Srinivas Kandagatla
This patch removes hardcoded dma channel value in lpass driver, Now the dma channel allocation happens in the SOC specific layer. This will allow different LPASS integrations to use the lpass driver in more generic way. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound

[PATCH v1 03/13] ASoC: qcom: remove hardcoded i2s port number

2015-05-13 Thread Srinivas Kandagatla
This patch attempts to remove the hardcoded i2s port number in lpass driver. Now the the port number comes from the dai id field. This will allow other SOCs to use different port numbers on the lpass driver. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound/soc/qcom

[PATCH v1 01/13] ASoC: qcom: make lpass driver depend on OF

2015-05-13 Thread Srinivas Kandagatla
lpass driver only support DT so make this explicit in the kconfig. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound/soc/qcom/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig index 5f58e4f

[PATCH v1 02/13] ASoC: qcom: move ipq806x specific bits out of lpass driver.

2015-05-13 Thread Srinivas Kandagatla
. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound/soc/qcom/Kconfig | 9 +- sound/soc/qcom/Makefile | 2 + sound/soc/qcom/lpass-cpu.c | 157 sound/soc/qcom/lpass-ipq806x.c | 96

[PATCH v1 00/13] ASoC: qcom: add support to apq8016 audio

2015-05-13 Thread Srinivas Kandagatla
return values spotted by Kenneth - renamed the machine file to apq8016-sbc.c as suggested by Kenneth. - use dai-driver-id instead of dai-id as it breaks on Storm board. Srinivas Kandagatla (13): ASoC: qcom: make lpass driver depend on OF ASoC: qcom: move ipq806x specific bits out of lpass driver

Re: [PATCH v1 05/13] ASoC: qcom: support bitclk and osrclk per i2s port

2015-05-15 Thread Srinivas Kandagatla
On 15/05/15 06:23, Kenneth Westfield wrote: On Wed, May 13, 2015 at 05:00:52AM -0700, Srinivas Kandagatla wrote: This patch adds support to allow bitclk and osrclk per i2s dai port. on APQ8016 there are 4 i2s ports each one has its own bit clks. Without this patch its not possible to support

Re: [PATCH v1 10/13] ASoC: qcom: Add apq8016 lpass driver support

2015-05-15 Thread Srinivas Kandagatla
Thanks for review, On 15/05/15 06:23, Kenneth Westfield wrote: On Wed, May 13, 2015 at 05:03:06AM -0700, Srinivas Kandagatla wrote: This patch adds apq8016 lpass driver support. APQ8016 has 4 MI2S which can be routed to one internal codec and 2 external codec interfaces. Primary, Secondary

Re: [PATCH v1 11/13] ASoC: qcom: add apq8016 sound card support

2015-05-15 Thread Srinivas Kandagatla
On 15/05/15 06:23, Kenneth Westfield wrote: On Wed, May 13, 2015 at 05:03:14AM -0700, Srinivas Kandagatla wrote: This patch adds apq8016 machine driver support. This patch was tested on two apq8016-sbc and msm8916-mtp board for both hdmi and analog audio features. diff --git a/sound/soc

Re: [PATCH v1 02/13] ASoC: qcom: move ipq806x specific bits out of lpass driver.

2015-05-15 Thread Srinivas Kandagatla
On 15/05/15 06:23, Kenneth Westfield wrote: On Wed, May 13, 2015 at 05:00:26AM -0700, Srinivas Kandagatla wrote: This patch tries to make the lpass driver more generic by moving the ipq806x specific bits out of the cpu and platform driver, also allows the SOC specific drivers to add

[PATCH] ASoC: skip legacy dai naming if dai driver has all the information

2015-05-15 Thread Srinivas Kandagatla
...@metafoo.de Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound/soc/soc-core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 2373252..7d028e8 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c

[PATCH v2 01/13] ASoC: qcom: make lpass driver depend on OF

2015-05-16 Thread Srinivas Kandagatla
lpass driver only support DT so make this explicit in the kconfig. Tested-by: Kenneth Westfield kwest...@codeaurora.org Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound/soc/qcom/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc

[PATCH v2 02/13] ASoC: qcom: move ipq806x specific bits out of lpass driver.

2015-05-16 Thread Srinivas Kandagatla
. Tested-by: Kenneth Westfield kwest...@codeaurora.org Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound/soc/qcom/Kconfig | 9 +- sound/soc/qcom/Makefile | 2 + sound/soc/qcom/lpass-cpu.c | 157 sound/soc

[PATCH v2 00/13] ASoC: qcom: add support to apq8016 audio

2015-05-16 Thread Srinivas Kandagatla
as it breaks on Storm board. Srinivas Kandagatla (13): ASoC: qcom: make lpass driver depend on OF ASoC: qcom: move ipq806x specific bits out of lpass driver. ASoC: qcom: remove hardcoded i2s port number ASoC: qcom: remove hardcoded dma channel ASoC: qcom: support bitclk and osrclk per i2s port

[PATCH v2 03/13] ASoC: qcom: remove hardcoded i2s port number

2015-05-16 Thread Srinivas Kandagatla
This patch attempts to remove the hardcoded i2s port number in lpass driver. Now the the port number comes from the dai id field. This will allow other SOCs to use different port numbers on the lpass driver. Tested-by: Kenneth Westfield kwest...@codeaurora.org Signed-off-by: Srinivas Kandagatla

[PATCH v2 09/13] ASoC: qcom: add bit map to track static dma channel allocations

2015-05-16 Thread Srinivas Kandagatla
This patch adds dma channel bit mask to lpass data to keep track of dma channel allocations. This flag would be used in apq8016 lpass driver. Tested-by: Kenneth Westfield kwest...@codeaurora.org Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound/soc/qcom/lpass.h | 3

[PATCH v2 10/13] ASoC: qcom: Add apq8016 lpass driver support

2015-05-16 Thread Srinivas Kandagatla
Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- include/dt-bindings/sound/apq8016-lpass.h | 9 ++ sound/soc/qcom/Kconfig| 6 + sound/soc/qcom/Makefile | 2 + sound/soc/qcom/lpass-apq8016.c| 242

[PATCH v2 11/13] ASoC: qcom: add apq8016 sound card support

2015-05-16 Thread Srinivas Kandagatla
This patch adds apq8016 machine driver support. This patch was tested on two apq8016-sbc and msm8916-mtp board for both hdmi and analog audio features. Tested-by: Kenneth Westfield kwest...@codeaurora.org Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound/soc/qcom

[PATCH v2 12/13] ASoC: qcom: Document apq8016 bindings.

2015-05-16 Thread Srinivas Kandagatla
This patch updates lpass bindings with apq8016 specific bindings. Tested-by: Kenneth Westfield kwest...@codeaurora.org Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt | 13 - 1 file changed, 12

[PATCH v2 05/13] ASoC: qcom: support bitclk and osrclk per i2s port

2015-05-16 Thread Srinivas Kandagatla
This patch adds support to allow bitclk and osrclk per i2s dai port. on APQ8016 there are 4 i2s ports each one has its own bit clks. Without this patch its not possible to support multiple i2s ports in the lpass driver. Tested-by: Kenneth Westfield kwest...@codeaurora.org Signed-off-by: Srinivas

[PATCH v2 06/13] ASoC: qcom: make osr clock optional

2015-05-16 Thread Srinivas Kandagatla
Some LPASS integrations like on APQ8016 do not have OSR clk, so making osr clk optional would allow such integrations to use lpass driver. Tested-by: Kenneth Westfield kwest...@codeaurora.org Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound/soc/qcom/lpass-cpu.c | 25

[PATCH v2 08/13] ASoC: qcom: Add ability to handle interrupts per dma channel

2015-05-16 Thread Srinivas Kandagatla
This patch adds ablity to lpass driver to handle interrupt per dma channel. Without this patch its not possible to use multipl ports on the lpass. Tested-by: Kenneth Westfield kwest...@codeaurora.org Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound/soc/qcom/lpass

[PATCH v2 07/13] ASoC: qcom: add dma channel control offset to variant data

2015-05-16 Thread Srinivas Kandagatla
This patch adds ability to pass dma channel control bits start offset, which differ in differnet qcom SOCs. On apq8016 dma channel control bits start after an offset of 1. Tested-by: Kenneth Westfield kwest...@codeaurora.org Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org

[PATCH v2 04/13] ASoC: qcom: remove hardcoded dma channel

2015-05-16 Thread Srinivas Kandagatla
This patch removes hardcoded dma channel value in lpass driver, Now the dma channel allocation happens in the SOC specific layer. This will allow different LPASS integrations to use the lpass driver in more generic way. Tested-by: Kenneth Westfield kwest...@codeaurora.org Signed-off-by: Srinivas

[PATCH v2 13/13] ASoC: qcom: document apq8016 sbc machine driver bindings

2015-05-16 Thread Srinivas Kandagatla
This patch adds bindings for apq8016 sbc machine driver. On APQ8016 4 MI2S can be configured to different sinks like internal codec/external codec, this connection is controlled via 2 iomux registers. Tested-by: Kenneth Westfield kwest...@codeaurora.org Signed-off-by: Srinivas Kandagatla

Re: [alsa-devel] [RFC PATCH 00/14] ASoC: qcom: add support to apq8016 audio

2015-05-14 Thread Srinivas Kandagatla
On 12/05/15 18:04, Lars-Peter Clausen wrote: Its not clear from code, why should we enter to legacy naming if the dais count == 1 even-though the dai_drv has has valid name and id information. Mark/Lars, I can workaround this by using dai-driver-id in the driver, But do you think that dai

Re: [alsa-devel] [RFC PATCH 00/14] ASoC: qcom: add support to apq8016 audio

2015-05-12 Thread Srinivas Kandagatla
+ adding Lars On 12/05/15 05:06, Kenneth Westfield wrote: Srinivas, I was able to get audio working on the Storm board. There were several issues. First, the I2S control port was saved in the DAI driver id field (which was 4), but the DAI id field was used by the macro (which was 0). The

<    2   3   4   5   6   7   8   9   10   11   >